summary refs log tree commit diff
path: root/synapse/handlers (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'release-v1.13.0' into developBrendan Abolivier2020-05-071-1/+3
|\
| * Add a configuration setting for the dummy event threshold (#7422)Brendan Abolivier2020-05-071-1/+3
| | | | | | Add dummy_events_threshold which allows configuring the number of forward extremities a room needs for Synapse to send forward extremities in it.
* | Add more type hints to SAML handler. (#7445)Patrick Cloke2020-05-071-12/+16
| |
* | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-061-4/+8
|\|
| * Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-059-281/+250
| |\
| * | Speed up fetching device lists changes in sync.Erik Johnston2020-05-051-4/+8
| | | | | | | | | | | | | | | Currently we copy `users_who_share_room` needlessly about three times, which is expensive when the set is large (which it can easily be).
* | | Convert the room handler to async/await. (#7396)Patrick Cloke2020-05-041-24/+18
| |/ |/|
* | async/await is_server_admin (#7363)Andrew Morgan2020-05-019-281/+250
|/
* Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-303-116/+63
| | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
* Apply federation check for /publicRooms with filter list (#7367)Andrew Morgan2020-04-301-1/+5
|
* Convert some of the federation handler methods to async/await. (#7338)Patrick Cloke2020-04-241-25/+24
|
* Stop the master relaying USER_SYNC for other workers (#7318)Richard van der Hoff2020-04-223-105/+135
| | | | | | | Long story short: if we're handling presence on the current worker, we shouldn't be sending USER_SYNC commands over replication. In an attempt to figure out what is going on here, I ended up refactoring some bits of the presencehandler code, so the first 4 commits here are non-functional refactors to move this code slightly closer to sanity. (There's still plenty to do here :/). Suggest reviewing individual commits. Fixes (I hope) #7257.
* Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-221-9/+139
|\
| * Query missing cross-signing keys on local sig upload (#7289)Andrew Morgan2020-04-221-9/+139
| |
* | import urllib.parse when using urllib.parse.quote (#7319)Andrew Morgan2020-04-221-1/+1
| |
* | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-201-129/+9
|\|
| * Revert "Query missing cross-signing keys on local sig upload"Richard van der Hoff2020-04-201-129/+9
| | | | | | | | | | | | This was incorrectly merged to the release branch before it was ready. This reverts commit 72fe2affb6ac86d433b80b6452da57052365aa26.
* | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-201-9/+129
|\|
| * Always send the user updates to their own device list (#7160)David Baker2020-04-202-3/+18
| |
| * Query missing cross-signing keys on local sig uploadAndrew Morgan2020-04-171-9/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add changelog Save retrieved keys to the db lint Fix and de-brittle remote result dict processing Use query_user_devices instead, assume only master, self_signing key types Make changelog more useful Remove very specific exception handling Wrap get_verify_key_from_cross_signing_key in a try/except Note that _get_e2e_cross_signing_verify_key can raise a SynapseError lint Add comment explaining why this is useful Only fetch master and self_signing key types Fix log statements, docstrings Remove extraneous items from remote query try/except lint Factor key retrieval out into a separate function Send device updates, modeled after SigningKeyEduUpdater._handle_signing_key_updates Update method docstring
| * Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-141-7/+11
| |
* | Reject unknown UI auth sessions (instead of silently generating a new one) ↵Patrick Cloke2020-04-201-65/+94
| | | | | | | | (#7268)
* | Use a template for the SSO success page to allow for customization. (#7279)Patrick Cloke2020-04-171-32/+12
| |
* | Convert auth handler to async/await (#7261)Patrick Cloke2020-04-154-111/+115
| |
* | Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-141-7/+11
| |
* | Check on room creation if the user is allowed to publish the room to the ↵PeerD2020-04-131-0/+7
| | | | | | | | room directory. (#7260)
* | typosMatthew Hodgson2020-04-111-1/+1
| |
* | Default PL100 to enable encryption in a room (#7230)Andrew Morgan2020-04-091-0/+1
| |
* | Do not allow a deactivated user to login via SSO. (#7240)Patrick Cloke2020-04-093-6/+32
| |
* | Improve error responses when a remote server doesn't allow you to access its ↵Andrew Morgan2020-04-061-11/+12
| | | | | | | | public rooms list (#6899)
* | Support CAS in UI Auth flows. (#7186)Patrick Cloke2020-04-032-74/+91
| |
* | Support SAML in the user interactive authentication workflow. (#7102)Patrick Cloke2020-04-012-14/+153
| |
* | Allow admins to create aliases when they are not in the room (#7191)Patrick Cloke2020-04-011-1/+5
| |
* | Rewrite prune_old_outbound_device_pokes for efficiency (#7159)Richard van der Hoff2020-03-301-23/+2
| | | | | | | | make sure we clear out all but one update for the user
* | Transfer alias mappings when joining an upgraded room (#6946)Andrew Morgan2020-03-301-0/+3
| |
* | Merge pull request #7160 from ↵David Baker2020-03-302-3/+18
|\ \ | | | | | | | | | | | | matrix-org/dbkr/always_send_own_device_list_updates Always send the user updates to their own device list
| * | Add explanatory commentAndrew Morgan2020-03-302-1/+4
| | |
| * | blackDavid Baker2020-03-301-1/+3
| | |
| * | Just add own user ID to the list we track device changes forDavid Baker2020-03-302-7/+11
| | |
| * | Fix undefined variable & remove debug loggingDavid Baker2020-03-271-10/+2
| | |
| * | blackDavid Baker2020-03-271-4/+4
| | |
| * | Always send the user updates to their own device listDavid Baker2020-03-272-6/+20
| | | | | | | | | | | | | | | This will allow clients to notify users about new devices even if the user isn't in any rooms (yet).
* | | Add options to prevent users from changing their profile. (#7096)Dirk Klimpel2020-03-271-0/+16
|/ /
* | Merge pull request #7151 from matrix-org/jaywink/saml-redirect-fixJason Robinson2020-03-261-0/+4
|\ \ | | | | | | Allow RedirectResponse in SAML response handler
| * | Allow RedirectResponse in SAML response handlerJason Robinson2020-03-261-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | Allow custom SAML handlers to redirect after processing an auth response. Fixes #7149 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | | Refactor the CAS code (move the logic out of the REST layer to a handler) ↵Patrick Cloke2020-03-261-0/+204
| | | | | | | | | | | | (#7136)
* | | Allow server admins to define and enforce a password policy (MSC2000). (#7118)Dirk Klimpel2020-03-262-0/+95
|/ /
* | Validate that the session is not modified during UI-Auth (#7068)Patrick Cloke2020-03-261-4/+33
| |
* | Clean up some LoggingContext stuff (#7120)Richard van der Hoff2020-03-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.
* | Use the proper error code when a canonical alias that does not exist is ↵Patrick Cloke2020-03-231-19/+38
| | | | | | | | used. (#7109)
* | Remove concept of a non-limited stream. (#7011)Erik Johnston2020-03-202-4/+11
|/
* Add an option to the set password API to choose whether to logout other ↵Patrick Cloke2020-03-181-16/+25
| | | | devices. (#7085)
* Remove special casing of `m.room.aliases` events (#7034)Patrick Cloke2020-03-171-15/+1
|
* Revert "Add options to disable setting profile info for prevent changes. ↵Richard van der Hoff2020-03-171-16/+0
| | | | | | | (#7053)" This reverts commit 54dd28621b070ca67de9f773fe9a89e1f4dc19da, reversing changes made to 6640460d054e8f4444046a34bdf638921b31c01e.
* Fix buggy condition in account validity handler (#7074)Brendan Abolivier2020-03-161-1/+5
|
* Add type annotations and comments to auth handler (#7063)Patrick Cloke2020-03-121-89/+104
|
* Don't filter out dummy events when we're checking the visibility of stateBrendan Abolivier2020-03-111-1/+1
|
* Add options to disable setting profile info for prevent changes. (#7053)Brendan Abolivier2020-03-101-0/+16
|\
| * lint, fix testsdklimpel2020-03-091-1/+3
| |
| * updates after reviewdklimpel2020-03-091-4/+4
| |
| * lintdklimpel2020-03-081-4/+2
| |
| * changelogdklimpel2020-03-081-2/+8
| |
| * Add options to disable setting profile info for prevent changes.dklimpel2020-03-081-0/+10
| |
* | SAML2: render a comprehensible error page if something goes wrongBrendan Abolivier2020-03-101-1/+19
| | | | | | | | | | | | If an error happened while processing a SAML AuthN response, or a client ends up doing a `GET` request to `/authn_response`, then render a customisable error page rather than a confusing error.
* | LintBrendan Abolivier2020-03-061-2/+1
| |
* | Mention the session ID in the error messageBrendan Abolivier2020-03-061-2/+3
| |
* | LintBrendan Abolivier2020-03-061-1/+2
| |
* | Make sure that is_verified is a boolean when processing room keysBrendan Abolivier2020-03-061-0/+6
| |
* | Allow deleting an alias if the user has sufficient power level (#6986)Patrick Cloke2020-03-041-33/+74
| |
* | Merge branch 'master' into developBrendan Abolivier2020-03-032-3/+76
|\ \
| * | Fix wrong handler being used in SAML handlerBrendan Abolivier2020-03-031-3/+2
| | |
| * | Factor out complete_sso_login and expose it to the Module APIBrendan Abolivier2020-03-031-0/+74
| | |
* | | Validate the alt_aliases property of canonical alias events (#6971)Patrick Cloke2020-03-032-10/+51
| |/ |/|
* | Store room version on invite (#6983)Richard van der Hoff2020-02-261-0/+12
| | | | | | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...
* | Port PresenceHandler to async/await (#6991)Erik Johnston2020-02-262-108/+89
| |
* | Remove redundant store_room call (#6979)Richard van der Hoff2020-02-241-23/+0
| | | | | | | | | | `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant.
* | Upsert room version when we join over federation (#6968)Richard van der Hoff2020-02-241-10/+12
| | | | | | | | | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns.
* | Change displayname of user as admin in rooms (#6876)Dirk Klimpel2020-02-211-1/+11
| |
* | Stop returning aliases as part of the room list. (#6970)Patrick Cloke2020-02-211-9/+0
| |
* | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Patrick Cloke2020-02-219-35/+33
| | | | | | | | Ensure good comprehension hygiene using flake8-comprehensions.
* | Merge branch 'master' into developRichard van der Hoff2020-02-211-5/+5
|\|
| * Small grammar fixes to the ACME v1 deprecation notice (#6944)Andrew Morgan2020-02-211-5/+5
| | | | | | Some small fixes to the copy in #6907.
* | Do not send alias events when creating / upgrading a room (#6941)Patrick Cloke2020-02-202-40/+15
|/ | | Stop emitting room alias update events during room creation/upgrade.
* Merge pull request #6949 from matrix-org/rav/list_room_aliases_peekableRichard van der Hoff2020-02-195-33/+22
|\ | | | | Make room alias lists peekable
| * Make room alias lists peekableRichard van der Hoff2020-02-191-1/+3
| | | | | | | | | | | | As per https://github.com/matrix-org/matrix-doc/pull/2432#pullrequestreview-360566830, make room alias lists accessible to users outside world_readable rooms.
| * Add `allow_departed_users` param to `check_in_room_or_world_readable`Richard van der Hoff2020-02-193-6/+14
| | | | | | | | | | | | | | ... and set it everywhere it's called. while we're here, rename it for consistency with `check_user_in_room` (and to help check that I haven't missed any instances)
| * Refactor the membership check methods in AuthRichard van der Hoff2020-02-182-28/+7
| | | | | | | | | | these were getting a bit unwieldy, so let's combine `check_joined_room` and `check_user_was_in_room` into a single `check_user_in_room`.
* | Merge pull request #6945 from matrix-org/babolivier/fix-retention-debug-logBrendan Abolivier2020-02-191-1/+1
|\ \ | |/ |/| Fix log in message retention purge jobs
| * Fix log in message retention purge jobsBrendan Abolivier2020-02-181-1/+1
| |
* | Implement GET /_matrix/client/r0/rooms/{roomId}/aliases (#6939)Richard van der Hoff2020-02-181-1/+16
| | | | | | | | | | per matrix-org/matrix-doc#2432
* | Merge pull request #6907 from matrix-org/babolivier/acme-configBrendan Abolivier2020-02-181-1/+15
|\ \ | |/ |/| Add mention and warning about ACME v1 deprecation to the TLS config
| * Make the log more noticeableBrendan Abolivier2020-02-181-1/+2
| |
| * Print the error as an error log and raise the same exception we gotBrendan Abolivier2020-02-181-9/+10
| |
| * LintBrendan Abolivier2020-02-131-6/+7
| |
| * LintBrendan Abolivier2020-02-131-7/+6
| |
| * Add a comprehensive error when failing to register for an ACME accountBrendan Abolivier2020-02-131-1/+13
| |
* | Stop sending events when creating or deleting aliases (#6904)Patrick Cloke2020-02-182-40/+41
| | | | | | Stop sending events when creating or deleting associations (room aliases). Send an updated canonical alias event if one of the alt_aliases is deleted.
* | Raise the default power levels for invites, tombstones and server acls (#6834)Andrew Morgan2020-02-171-1/+9
| |
* | Filter the results of user directory searching via the spam checker (#6888)Patrick Cloke2020-02-141-2/+12
|/ | | Add a method to the spam checker to filter the user directory results.
* Merge branch 'release-v1.10.0' into developRichard van der Hoff2020-02-111-0/+1
|\
| * filter out m.room.aliases from /sync state blocks (#6884)Matthew Hodgson2020-02-101-0/+1
| | | | | | We forgot to filter out aliases from /sync state blocks as well as the timeline.
* | Reject device display names that are too long (#6882)Patrick Cloke2020-02-101-1/+13
| | | | | | | | | | | | | | | | * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name.
* | Add support for putting fed user query API on workers (#6873)Erik Johnston2020-02-071-19/+16
| |
* | Allow moving group read APIs to workers (#6866)Erik Johnston2020-02-071-131/+139
| |
* | Admin api to add an email address (#6789)Dirk Klimpel2020-02-072-0/+10
| |
* | Limit the number of events that can be requested when backfilling events (#6864)Patrick Cloke2020-02-061-0/+4
| | | | | | Limit the maximum number of events requested when backfilling events.
* | pass room version into FederationClient.send_join (#6854)Richard van der Hoff2020-02-061-2/+1
| | | | | | | | ... which allows us to sanity-check the create event.
* | Third party event rules Update (#6781)PeerD2020-02-061-1/+5
| |
* | Reduce amount of logging at INFO level. (#6862)Erik Johnston2020-02-064-11/+11
| | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* | Merge pull request #6823 from matrix-org/rav/redact_changes/5Richard van der Hoff2020-02-061-6/+2
|\ \ | | | | | | pass room versions around
| * | Pass room version object into `FederationClient.get_pdu`Richard van der Hoff2020-02-051-6/+2
| | |
* | | Merge tag 'v1.10.0rc2' into developErik Johnston2020-02-064-17/+69
|\ \ \ | |/ / |/| / | |/ | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850))
| * Check sender_key matches on inbound encrypted events. (#6850)Erik Johnston2020-02-052-14/+66
| | | | | | If they don't then the device lists are probably out of sync.
| * Fix detecting unknown devices from remote encrypted events. (#6848)Erik Johnston2020-02-043-3/+3
| | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.
* | Merge pull request #6837 from matrix-org/rav/federation_asyncRichard van der Hoff2020-02-043-235/+211
|\ \ | | | | | | Port much of `synapse.handlers.federation` to async/await.
| * | make FederationHandler.send_invite asyncRichard van der Hoff2020-02-032-6/+4
| | |
| * | make FederationHandler.on_get_missing_events asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.user_joined_room asyncRichard van der Hoff2020-02-031-3/+3
| | |
| * | make FederationHandler._clean_room_for_join asyncRichard van der Hoff2020-02-031-4/+4
| | |
| * | make FederationHandler._notify_persisted_event asyncRichard van der Hoff2020-02-031-4/+6
| | |
| * | make FederationHandler.persist_events_and_notify asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._make_and_verify_event asyncRichard van der Hoff2020-02-031-5/+10
| | |
| * | make FederationHandler.do_remotely_reject_invite asyncRichard van der Hoff2020-02-032-8/+11
| | |
| * | make FederationHandler._check_for_soft_fail asyncRichard van der Hoff2020-02-031-13/+9
| | |
| * | make FederationHandler._persist_auth_tree asyncRichard van der Hoff2020-02-031-11/+7
| | |
| * | make FederationHandler.do_invite_join asyncRichard van der Hoff2020-02-032-18/+18
| | |
| * | make FederationHandler.on_event_auth asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_exchange_third_party_invite_request asyncRichard van der Hoff2020-02-031-14/+12
| | |
| * | make FederationHandler.construct_auth_difference asyncRichard van der Hoff2020-02-031-3/+4
| | |
| * | make FederationHandler._update_context_for_auth_events asyncRichard van der Hoff2020-02-031-10/+10
| | |
| * | make FederationHandler._update_auth_events_and_context_for_auth asyncRichard van der Hoff2020-02-031-20/+21
| | |
| * | make FederationHandler.do_auth asyncRichard van der Hoff2020-02-031-10/+14
| | |
| * | make FederationHandler._prep_event asyncRichard van der Hoff2020-02-031-23/+10
| | |
| * | make FederationHandler._handle_new_event asyncRichard van der Hoff2020-02-031-6/+7
| | |
| * | make FederationHandler._handle_new_events asyncRichard van der Hoff2020-02-031-8/+6
| | |
| * | make FederationHandler.on_make_leave_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_send_leave_request asyncRichard van der Hoff2020-02-031-5/+3
| | |
| * | make FederationHandler.on_make_join_request asyncRichard van der Hoff2020-02-031-13/+10
| | |
| * | make FederationHandler.on_invite_request asyncRichard van der Hoff2020-02-031-5/+4
| | |
| * | make FederationHandler.on_send_join_request asyncRichard van der Hoff2020-02-031-9/+7
| | |
| * | make FederationHandler.on_query_auth asyncRichard van der Hoff2020-02-031-7/+6
| |/
* / Add typing to SyncHandler (#6821)Erik Johnston2020-02-031-341/+364
|/ | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* pass room_version into compute_event_signature (#6807)Richard van der Hoff2020-01-311-1/+4
|
* Merge pull request #6820 from matrix-org/rav/get_room_version_idRichard van der Hoff2020-01-314-14/+16
|\ | | | | Make `get_room_version` return a RoomVersion object
| * s/get_room_version/get_room_version_id/Richard van der Hoff2020-01-314-14/+16
| | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object.
* | Fix bug with getting missing auth event during join 500'ed (#6810)Erik Johnston2020-01-311-1/+5
|/
* pass room version into FederationHandler.on_invite_request (#6805)Richard van der Hoff2020-01-301-3/+3
|
* Resync remote device list when detected as stale. (#6786)Erik Johnston2020-01-302-4/+24
|
* Make /directory/room/<alias> handle restrictive power levelsRichard van der Hoff2020-01-291-1/+6
| | | | | Fixes a bug where the alias would be added, but `PUT /directory/room/<alias>` would return a 403.
* Set the PL for aliases events to 0.Richard van der Hoff2020-01-291-2/+15
|
* Factor out a `copy_power_levels_contents` methodRichard van der Hoff2020-01-291-12/+11
| | | | I'm going to need another copy (hah!) of this.
* Fix bug when querying remote user keys that require a resync. (#6796)Erik Johnston2020-01-291-1/+2
| | | | We ended up only returning a single device, rather than all of them.
* Detect unknown remote devices and mark cache as stale (#6776)Erik Johnston2020-01-282-2/+75
| | | | We just mark the fact that the cache may be stale in the database for now.
* Pass room version object into event_auth.check and check_redaction (#6788)Richard van der Hoff2020-01-282-9/+17
| | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.
* Add `rooms.room_version` column (#6729)Erik Johnston2020-01-272-35/+82
| | | This is so that we don't have to rely on pulling it out from `current_state_events` table.
* Validate client_secret parameter (#6767)Andrew Morgan2020-01-241-1/+3
|
* Remove unnecessary abstractions in admin handler (#6751)Andrew Morgan2020-01-221-62/+0
|
* Add more logging around message retention policies support (#6717)Brendan Abolivier2020-01-171-0/+13
| | | So we can debug issues like #6683 more easily
* Merge pull request #6714 from matrix-org/babolivier/retention_select_eventBrendan Abolivier2020-01-171-1/+1
|\ | | | | Fix instantiation of message retention purge jobs
| * Fix instantiation of message retention purge jobsBrendan Abolivier2020-01-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When figuring out which topological token to start a purge job at, we need to do the following: 1. Figure out a timestamp before which events will be purged 2. Select the first stream ordering after that timestamp 3. Select info about the first event after that stream ordering 4. Build a topological token from that info In some situations (e.g. quiet rooms with a short max_lifetime), there might not be an event after the stream ordering at step 3, therefore we abort the purge with the error `No event found`. To mitigate that, this patch fetches the first event _before_ the stream ordering, instead of after.
* | Merge pull request #6724 from matrix-org/rav/log_saml_attributesRichard van der Hoff2020-01-171-1/+12
|\ \ | | | | | | Log saml assertions rather than the whole response
| * | Log saml assertions rather than the whole responseRichard van der Hoff2020-01-161-1/+12
| | | | | | | | | | | | | | | | | | ... since the whole response is huge. We even need to break up the assertions, since kibana otherwise truncates them.
* | | Delegate remote_user_id mapping to the saml mapping provider (#6723)Richard van der Hoff2020-01-171-6/+21
|/ / | | | | Turns out that figuring out a remote user id for the SAML user isn't quite as obvious as it seems. Factor it out to the SamlMappingProvider so that it's easy to control.
* | Add StateMap type alias (#6715)Erik Johnston2020-01-163-28/+31
| |
* | Port synapse.replication.tcp to async/await (#6666)Erik Johnston2020-01-161-1/+1
| | | | | | | | | | | | | | | | | | | | * Port synapse.replication.tcp to async/await * Newsfile * Correctly document type of on_<FOO> functions as async * Don't be overenthusiastic with the asyncing....
* | Add `local_current_membership` table (#6655)Erik Johnston2020-01-156-6/+6
|/ | | | | | | Currently we rely on `current_state_events` to figure out what rooms a user was in and their last membership event in there. However, if the server leaves the room then the table may be cleaned up and that information is lost. So lets add a table that separately holds that information.
* Kill off RegistrationError (#6691)Richard van der Hoff2020-01-131-9/+3
| | | This is pretty pointless. Let's just use SynapseError.
* Don't assign numeric IDs for empty usernames (#6690)Richard van der Hoff2020-01-131-1/+1
| | | | Fix a bug where we would assign a numeric userid if somebody tried registering with an empty username
* Pass client redirect URL into SAML mapping providersRichard van der Hoff2020-01-121-4/+11
|
* Pass the module_api into the SamlMappingProviderRichard van der Hoff2020-01-121-2/+5
| | | | | ... for consistency with other modules, and because we'll need it sooner or later and it will be a pain to introduce later.
* Allow admin users to create or modify users without a shared secret (#6495)Manuel Stahl2020-01-091-0/+9
| | | Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Correctly proxy remote group HTTP errors. (#6654)Erik Johnston2020-01-071-0/+16
| | | | | e.g. if remote returns a 404 then that shouldn't be treated as an error but should be proxied through.
* Merge pull request #6652 from matrix-org/babolivier/depth_missing_eventsBrendan Abolivier2020-01-071-2/+2
|\ | | | | Fix conditions failing if min_depth = 0
| * Fix conditions failing if min_depth = 0Brendan Abolivier2020-01-071-2/+2
| | | | | | | | This could result in Synapse not fetching prev_events for new events in the room if it has missed some events.
* | Merge pull request #6629 from matrix-org/rav/kill_event_reference_hashesRichard van der Hoff2020-01-062-34/+20
|\ \ | | | | | | Remove a bunch of unused code from event creation
| * | Remove unused hashes and depths from _update_membership paramsRichard van der Hoff2020-01-061-13/+4
| | |
| * | Remove unused hashes and depths from create_event paramsRichard van der Hoff2020-01-062-17/+12
| | |
| * | Remove unused hashes and depths from create_new_client_event paramsRichard van der Hoff2020-01-061-12/+14
| | |
| * | replace get_prev_events_and_hashes_for_room with get_prev_events_for_room in ↵Richard van der Hoff2020-01-061-9/+3
| | | | | | | | | | | | create_new_client_event
| * | rename get_prev_events_for_room to get_prev_events_and_hashes_for_roomRichard van der Hoff2020-01-062-3/+7
| | | | | | | | | | | | ... to make way for a new method which just returns the event ids
* | | Fix some test failures when frozen_dicts are enabled (#6642)Richard van der Hoff2020-01-062-6/+11
| | | | | | | | | | | | Fixes #4026
* | | Fix an error which was thrown by the PresenceHandler _on_shutdown handler. ↵Richard van der Hoff2020-01-061-7/+2
|/ / | | | | | | (#6640)
* / Fix power levels being incorrectly set in old and new rooms after a room ↵Andrew Morgan2020-01-061-7/+10
|/ | | | | | upgrade (#6633) Modify a copy of an upgraded room's PL before sending to the new room
* Merge branch 'master' into developRichard van der Hoff2019-12-201-1/+4
|\
| * Fix exceptions when attempting to backfill (#6576)Richard van der Hoff2019-12-201-1/+4
| | | | | | Fixes #6575
* | Change EventContext to use the Storage class (#6564)Erik Johnston2019-12-205-16/+16
| |
* | Port some admin handlers to async/await (#6559)Erik Johnston2019-12-192-54/+41
| |
* | Add database config class (#6513)Erik Johnston2019-12-181-1/+1
| | | | | | | | | | This encapsulates config for a given database and is the way to get new connections.
* | Merge release-v1.7.1 into developRichard van der Hoff2019-12-182-2/+6
|\|
| * Merge pull request #6553 from matrix-org/babolivier/fix-context-filterBrendan Abolivier2019-12-161-2/+5
| |\ | | | | | | Use the filtered version of an event when responding to /context requests for that event
| | * Incorporate reviewBrendan Abolivier2019-12-161-1/+1
| | |
| | * Use the filtered version of an event when responding to /context requests ↵Brendan Abolivier2019-12-161-1/+4
| | | | | | | | | | | | | | | | | | for that event Sometimes the filtering function can return a pruned version of an event (on top of either the event itself or an empty list), if it thinks the user should be able to see that there's an event there but not the content of that event. Therefore, the previous logic of 'if filtered is empty then we can use the event we retrieved from the database' is flawed, and we should use the event returned by the filtering function.
| * | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
| * | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-161-163/+80
| | | | | | | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
| * | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-161-0/+1
| | | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
| * | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-161-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
| * | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-161-18/+21
| | | | | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
| * | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-161-6/+95
| |/ | | | | | | | | This is a non-functional refactor as a precursor to some other work.
* | Remove unused `get_pagination_rows` methods. (#6557)Erik Johnston2019-12-173-18/+0
| | | | | | Remove unused get_pagination_rows methods
* | Add option to allow profile queries without sharing a room (#6523)Will Hunt2019-12-161-1/+5
| |
* | Exclude rejected state events when calculating state at backwards extrems ↵Richard van der Hoff2019-12-161-1/+1
| | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404.
* | Persist auth/state events at backwards extremities when we fetch them (#6526)Richard van der Hoff2019-12-161-167/+80
| | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room.
* | sanity-checking for events used in state res (#6531)Richard van der Hoff2019-12-131-0/+1
| | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room.
* | Merge pull request #6496 from matrix-org/erikj/initial_sync_asnycErik Johnston2019-12-131-52/+44
|\ \ | | | | | | Port synapse.handlers.initial_sync to async/await
| * \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2019-12-118-236/+452
| |\ \ | | | | | | | | | | | | erikj/initial_sync_asnyc
| * | | Port synapse.handlers.initial_sync to async/awaitErik Johnston2019-12-091-52/+44
| | | |
* | | | look up cross-signing keys from the DB in bulk (#6486)Hubert Chathi2019-12-121-8/+27
| | | |
* | | | Check the room_id of events when fetching room state/auth (#6524)Richard van der Hoff2019-12-121-23/+51
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there.
* | | Add `include_event_in_state` to _get_state_for_room (#6521)Richard van der Hoff2019-12-111-22/+28
| | | | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest.
* | | Merge pull request #6517 from matrix-org/rav/event_auth/13Richard van der Hoff2019-12-112-98/+88
|\ \ \ | | | | | | | | Port some of FederationHandler to async/await
| * | | convert to async: FederationHandler._process_received_pduRichard van der Hoff2019-12-111-11/+10
| | | | | | | | | | | | | | | | also fix user_joined_room to consistently return deferreds
| * | | convert to async: FederationHandler._get_state_for_roomRichard van der Hoff2019-12-111-21/+21
| | | | | | | | | | | | | | | | ... and _get_events_from_store_or_dest
| * | | convert to async: FederationHandler.on_receive_pduRichard van der Hoff2019-12-111-27/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu
| * | | Convert federation backfill to asyncRichard van der Hoff2019-12-112-39/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill
* | | | Merge pull request #6504 from matrix-org/erikj/account_validity_async_awaitErik Johnston2019-12-112-55/+45
|\ \ \ \ | |/ / / |/| | | Port handlers.account_validity to async/await.
| * | | Port handlers.account_validity to async/await.Erik Johnston2019-12-102-47/+41
| | | |
| * | | Port handlers.account_data to async/await.Erik Johnston2019-12-101-9/+5
| | |/ | |/|
* | | Clean up some logging (#6515)Richard van der Hoff2019-12-111-18/+19
| | | | | | | | | | | | This just makes some of the logging easier to follow when things start going wrong.
* | | Prevent redacted events from appearing in message search (#6377)Andrew Morgan2019-12-112-4/+8
| | |
* | | Prevent message search in upgraded rooms we're not in (#6385)Andrew Morgan2019-12-112-11/+27
| | |
* | | Move get_state methods into FederationHandler (#6503)Richard van der Hoff2019-12-101-6/+95
| | | | | | | | | | | | | | | This is a non-functional refactor as a precursor to some other work.
* | | Allow SAML username provider plugins (#6411)Andrew Morgan2019-12-101-28/+170
| | |
* | | Merge pull request #6506 from matrix-org/erikj/remove_snapshot_cacheErik Johnston2019-12-101-11/+8
|\ \ \ | |/ / |/| / | |/ Remove SnapshotCache in favour of ResponseCache
| * Remove SnapshotCache in favour of ResponseCacheErik Johnston2019-12-091-11/+8
| |
* | Back out perf regression from get_cross_signing_keys_from_cache. (#6494)Neil Johnson2019-12-091-30/+8
|/ | | Back out cross-signing code added in Synapse 1.5.0, which caused a performance regression.
* Merge pull request #6493 from matrix-org/erikj/invite_state_configErik Johnston2019-12-091-1/+3
|\ | | | | Pull out room_invite_state_types config option once.
| * Pull out room_invite_state_types config option once.Erik Johnston2019-12-091-1/+3
| | | | | | | | Pulling things out of config is currently surprisingly expensive.
* | Merge pull request #6484 from matrix-org/erikj/port_sync_handlerErik Johnston2019-12-093-152/+131
|\ \ | |/ |/| Port SyncHandler to async/await
| * Fixup functions to consistently return deferredsErik Johnston2019-12-062-4/+4
| |
| * Port SyncHandler to async/awaitErik Johnston2019-12-052-151/+130
| |
* | Replace /admin/v1/users_paginate endpoint with /admin/v2/users (#5925)Manuel Stahl2019-12-051-9/+12
|/
* Stronger typing in the federation handler (#6480)Richard van der Hoff2019-12-051-24/+57
| | | | | replace the event_info dict with an attrs thing
* Sanity-check the rooms of auth events before pulling them in. (#6472)Richard van der Hoff2019-12-051-9/+25
|
* get rid of (most of) have_events from ↵Richard van der Hoff2019-12-041-38/+24
| | | | | | | | | | | | | _update_auth_events_and_context_for_auth (#6468) have_events was a map from event_id to rejection reason (or None) for events which are in our local database. It was used as filter on the list of event_ids being passed into get_events_as_list. However, since get_events_as_list will ignore any event_ids that are unknown or rejected, we can equivalently just leave it to get_events_as_list to do the filtering. That means that we don't have to keep `have_events` up-to-date, and can use `have_seen_events` instead of `get_seen_events_with_rejection` in the one place we do need it.
* Merge pull request #6441 from syamgk/fix-parameter-mismatchErik Johnston2019-12-041-1/+1
|\ | | | | Fix issue #6406 parameter mismatch
| * Issue #6406 Fix parameter mismatchSyam G Krishnan2019-12-041-1/+1
| | | | | | | | Signed-off-by: Syam G Krishnan <syamgk01@gmail.com>
* | Merge pull request #6329 from matrix-org/babolivier/context_filtersBrendan Abolivier2019-12-041-2/+12
|\ \ | | | | | | Filter state, events_before and events_after in /context requests
| * \ Merge branch 'develop' into babolivier/context_filtersBrendan Abolivier2019-12-0414-192/+395
| |\ \
| * | | Incorporate reviewBrendan Abolivier2019-12-041-2/+1
| | | |
| * | | Also filter state eventsBrendan Abolivier2019-11-061-1/+7
| | | |
| * | | Only filter if a filter was providedBrendan Abolivier2019-11-051-4/+6
| | | |
| * | | Update copyrightBrendan Abolivier2019-11-051-1/+2
| | | |
| * | | Filter events_before and events_after in /context requestsBrendan Abolivier2019-11-051-2/+4
| | | | | | | | | | | | | | | | While the current version of the spec doesn't say much about how this endpoint uses filters (see https://github.com/matrix-org/matrix-doc/issues/2338), the current implementation is that some fields of an EventFilter apply (the ones that are used when running the SQL query) and others don't (the ones that are used by the filter itself) because we don't call event_filter.filter(...). This seems counter-intuitive and probably not what we want so this commit fixes it.
* | | | Add ephemeral messages support (MSC2228) (#6409)Brendan Abolivier2019-12-032-1/+130
| |/ / |/| | | | | | | | | | | | | | | | | | | | Implement part [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). The parts that differ are: * the feature is hidden behind a configuration flag (`enable_ephemeral_messages`) * self-destruction doesn't happen for state events * only implement support for the `m.self_destruct_after` field (not the `m.self_destruct` one) * doesn't send synthetic redactions to clients because for this specific case we consider the clients to be able to destroy an event themselves, instead we just censor it (by pruning its JSON) in the database
* | | Transfer power level state events on room upgrade (#6237)Andrew Morgan2019-12-021-5/+31
| |/ |/|
* | Merge pull request #6434 from matrix-org/erikj/msc2367_membership_reasonsErik Johnston2019-11-293-7/+15
|\ \ | | | | | | Implement MSC 2367 - Membership Reasons
| * | Propagate reason in remotely rejected invitesErik Johnston2019-11-283-7/+15
| | |
* | | Discard retention policies when retrieving stateBrendan Abolivier2019-11-281-1/+1
|/ / | | | | | | | | | | | | | | Purge jobs don't delete the latest event in a room in order to keep the forward extremity and not break the room. On the other hand, get_state_events, when given an at_token argument calls filter_events_for_client to know if the user can see the event that matches that (sync) token. That function uses the retention policies of the events it's given to filter out those that are too old from a client's view. Some clients, such as Riot, when loading a room, request the list of members for the latest sync token it knows about, and get confused to the point of refusing to send any message if the server tells it that it can't get that information. This can happen very easily with the message retention feature turned on and a room with low activity so that the last event sent becomes too old according to the room's retention policy. An easy and clean fix for that issue is to discard the room's retention policies when retrieving state.
* | Remove local threepids on account deactivation (#6426)Andrew Morgan2019-11-281-0/+3
| |
* | add etag and count to key backup endpoints (#5858)Hubert Chathi2019-11-271-50/+80
| |
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-30 06:41:08 +0000