Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Fix exception reporting due to HTTP request errors. (#7556) | Erik Johnston | 2020-05-22 | 1 | -0/+7 |
| | | | | These are business as usual errors, rather than stuff we want to log at error. | ||||
* | Convert federation handler to async/await. (#7459) | Patrick Cloke | 2020-05-11 | 1 | -18/+14 |
| | |||||
* | async/await is_server_admin (#7363) | Andrew Morgan | 2020-05-01 | 1 | -11/+10 |
| | |||||
* | Convert some of the federation handler methods to async/await. (#7338) | Patrick Cloke | 2020-04-24 | 1 | -25/+24 |
| | |||||
* | Rewrite prune_old_outbound_device_pokes for efficiency (#7159) | Richard van der Hoff | 2020-03-30 | 1 | -23/+2 |
| | | | | make sure we clear out all but one update for the user | ||||
* | Store room version on invite (#6983) | Richard van der Hoff | 2020-02-26 | 1 | -0/+12 |
| | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere... | ||||
* | Remove redundant store_room call (#6979) | Richard van der Hoff | 2020-02-24 | 1 | -23/+0 |
| | | | | | `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant. | ||||
* | Upsert room version when we join over federation (#6968) | Richard van der Hoff | 2020-02-24 | 1 | -10/+12 |
| | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns. | ||||
* | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957) | Patrick Cloke | 2020-02-21 | 1 | -9/+9 |
| | | | | Ensure good comprehension hygiene using flake8-comprehensions. | ||||
* | Limit the number of events that can be requested when backfilling events (#6864) | Patrick Cloke | 2020-02-06 | 1 | -0/+4 |
| | | | Limit the maximum number of events requested when backfilling events. | ||||
* | pass room version into FederationClient.send_join (#6854) | Richard van der Hoff | 2020-02-06 | 1 | -2/+1 |
| | | | | ... which allows us to sanity-check the create event. | ||||
* | Merge pull request #6823 from matrix-org/rav/redact_changes/5 | Richard van der Hoff | 2020-02-06 | 1 | -6/+2 |
|\ | | | | | pass room versions around | ||||
| * | Pass room version object into `FederationClient.get_pdu` | Richard van der Hoff | 2020-02-05 | 1 | -6/+2 |
| | | |||||
* | | Merge tag 'v1.10.0rc2' into develop | Erik Johnston | 2020-02-06 | 1 | -14/+60 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc2 (2020-02-06) ============================== Bugfixes -------- - Fix an issue with cross-signing where device signatures were not sent to remote servers. ([\#6844](https://github.com/matrix-org/synapse/issues/6844)) - Fix to the unknown remote device detection which was introduced in 1.10.rc1. ([\#6848](https://github.com/matrix-org/synapse/issues/6848)) Internal Changes ---------------- - Detect unexpected sender keys on remote encrypted events and resync device lists. ([\#6850](https://github.com/matrix-org/synapse/issues/6850)) | ||||
| * | Check sender_key matches on inbound encrypted events. (#6850) | Erik Johnston | 2020-02-05 | 1 | -13/+59 |
| | | | | | | If they don't then the device lists are probably out of sync. | ||||
| * | Fix detecting unknown devices from remote encrypted events. (#6848) | Erik Johnston | 2020-02-04 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776. | ||||
* | | make FederationHandler.send_invite async | Richard van der Hoff | 2020-02-03 | 1 | -3/+2 |
| | | |||||
* | | make FederationHandler.on_get_missing_events async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | |||||
* | | make FederationHandler.user_joined_room async | Richard van der Hoff | 2020-02-03 | 1 | -3/+3 |
| | | |||||
* | | make FederationHandler._clean_room_for_join async | Richard van der Hoff | 2020-02-03 | 1 | -4/+4 |
| | | |||||
* | | make FederationHandler._notify_persisted_event async | Richard van der Hoff | 2020-02-03 | 1 | -4/+6 |
| | | |||||
* | | make FederationHandler.persist_events_and_notify async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | |||||
* | | make FederationHandler._make_and_verify_event async | Richard van der Hoff | 2020-02-03 | 1 | -5/+10 |
| | | |||||
* | | make FederationHandler.do_remotely_reject_invite async | Richard van der Hoff | 2020-02-03 | 1 | -6/+7 |
| | | |||||
* | | make FederationHandler._check_for_soft_fail async | Richard van der Hoff | 2020-02-03 | 1 | -13/+9 |
| | | |||||
* | | make FederationHandler._persist_auth_tree async | Richard van der Hoff | 2020-02-03 | 1 | -11/+7 |
| | | |||||
* | | make FederationHandler.do_invite_join async | Richard van der Hoff | 2020-02-03 | 1 | -16/+14 |
| | | |||||
* | | make FederationHandler.on_event_auth async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | |||||
* | | make FederationHandler.on_exchange_third_party_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -14/+12 |
| | | |||||
* | | make FederationHandler.construct_auth_difference async | Richard van der Hoff | 2020-02-03 | 1 | -3/+4 |
| | | |||||
* | | make FederationHandler._update_context_for_auth_events async | Richard van der Hoff | 2020-02-03 | 1 | -10/+10 |
| | | |||||
* | | make FederationHandler._update_auth_events_and_context_for_auth async | Richard van der Hoff | 2020-02-03 | 1 | -20/+21 |
| | | |||||
* | | make FederationHandler.do_auth async | Richard van der Hoff | 2020-02-03 | 1 | -10/+14 |
| | | |||||
* | | make FederationHandler._prep_event async | Richard van der Hoff | 2020-02-03 | 1 | -23/+10 |
| | | |||||
* | | make FederationHandler._handle_new_event async | Richard van der Hoff | 2020-02-03 | 1 | -6/+7 |
| | | |||||
* | | make FederationHandler._handle_new_events async | Richard van der Hoff | 2020-02-03 | 1 | -8/+6 |
| | | |||||
* | | make FederationHandler.on_make_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | |||||
* | | make FederationHandler.on_send_leave_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+3 |
| | | |||||
* | | make FederationHandler.on_make_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -13/+10 |
| | | |||||
* | | make FederationHandler.on_invite_request async | Richard van der Hoff | 2020-02-03 | 1 | -5/+4 |
| | | |||||
* | | make FederationHandler.on_send_join_request async | Richard van der Hoff | 2020-02-03 | 1 | -9/+7 |
| | | |||||
* | | make FederationHandler.on_query_auth async | Richard van der Hoff | 2020-02-03 | 1 | -7/+6 |
|/ | |||||
* | pass room_version into compute_event_signature (#6807) | Richard van der Hoff | 2020-01-31 | 1 | -1/+4 |
| | |||||
* | Merge pull request #6820 from matrix-org/rav/get_room_version_id | Richard van der Hoff | 2020-01-31 | 1 | -9/+9 |
|\ | | | | | Make `get_room_version` return a RoomVersion object | ||||
| * | s/get_room_version/get_room_version_id/ | Richard van der Hoff | 2020-01-31 | 1 | -9/+9 |
| | | | | | | | | | | ... to make way for a forthcoming get_room_version which returns a RoomVersion object. | ||||
* | | Fix bug with getting missing auth event during join 500'ed (#6810) | Erik Johnston | 2020-01-31 | 1 | -1/+5 |
|/ | |||||
* | pass room version into FederationHandler.on_invite_request (#6805) | Richard van der Hoff | 2020-01-30 | 1 | -3/+3 |
| | |||||
* | Resync remote device list when detected as stale. (#6786) | Erik Johnston | 2020-01-30 | 1 | -2/+16 |
| | |||||
* | Detect unknown remote devices and mark cache as stale (#6776) | Erik Johnston | 2020-01-28 | 1 | -0/+20 |
| | | | | We just mark the fact that the cache may be stale in the database for now. | ||||
* | Pass room version object into event_auth.check and check_redaction (#6788) | Richard van der Hoff | 2020-01-28 | 1 | -7/+11 |
| | | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string. | ||||
* | Add `rooms.room_version` column (#6729) | Erik Johnston | 2020-01-27 | 1 | -15/+50 |
| | | | This is so that we don't have to rely on pulling it out from `current_state_events` table. | ||||
* | Add StateMap type alias (#6715) | Erik Johnston | 2020-01-16 | 1 | -6/+4 |
| | |||||
* | Fix conditions failing if min_depth = 0 | Brendan Abolivier | 2020-01-07 | 1 | -2/+2 |
| | | | | This could result in Synapse not fetching prev_events for new events in the room if it has missed some events. | ||||
* | Merge branch 'master' into develop | Richard van der Hoff | 2019-12-20 | 1 | -1/+4 |
|\ | |||||
| * | Fix exceptions when attempting to backfill (#6576) | Richard van der Hoff | 2019-12-20 | 1 | -1/+4 |
| | | | | | | Fixes #6575 | ||||
* | | Change EventContext to use the Storage class (#6564) | Erik Johnston | 2019-12-20 | 1 | -7/+7 |
| | | |||||
* | | Merge release-v1.7.1 into develop | Richard van der Hoff | 2019-12-18 | 1 | -0/+1 |
|\| | |||||
| * | Exclude rejected state events when calculating state at backwards extrems ↵ | Richard van der Hoff | 2019-12-16 | 1 | -1/+1 |
| | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404. | ||||
| * | Persist auth/state events at backwards extremities when we fetch them (#6526) | Richard van der Hoff | 2019-12-16 | 1 | -163/+80 |
| | | | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room. | ||||
| * | sanity-checking for events used in state res (#6531) | Richard van der Hoff | 2019-12-16 | 1 | -0/+1 |
| | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room. | ||||
| * | Check the room_id of events when fetching room state/auth (#6524) | Richard van der Hoff | 2019-12-16 | 1 | -24/+54 |
| | | | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there. | ||||
| * | Add `include_event_in_state` to _get_state_for_room (#6521) | Richard van der Hoff | 2019-12-16 | 1 | -18/+21 |
| | | | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest. | ||||
| * | Move get_state methods into FederationHandler (#6503) | Richard van der Hoff | 2019-12-16 | 1 | -6/+95 |
| | | | | | | | | | | This is a non-functional refactor as a precursor to some other work. | ||||
* | | Exclude rejected state events when calculating state at backwards extrems ↵ | Richard van der Hoff | 2019-12-16 | 1 | -1/+1 |
| | | | | | | | | | | (#6527) This fixes a weird bug where, if you were determined enough, you could end up with a rejected event forming part of the state at a backwards-extremity. Authing that backwards extrem would then lead to us trying to pull the rejected event from the db (with allow_rejected=False), which would fail with a 404. | ||||
* | | Persist auth/state events at backwards extremities when we fetch them (#6526) | Richard van der Hoff | 2019-12-16 | 1 | -167/+80 |
| | | | | | | The main point here is to make sure that the state returned by _get_state_in_room has been authed before we try to use it as state in the room. | ||||
* | | sanity-checking for events used in state res (#6531) | Richard van der Hoff | 2019-12-13 | 1 | -0/+1 |
| | | | | | | | | | | | | | | When we perform state resolution, check that all of the events involved are in the right room. | ||||
* | | Check the room_id of events when fetching room state/auth (#6524) | Richard van der Hoff | 2019-12-12 | 1 | -23/+51 |
| | | | | | | | | | | | | | | | | | | | | When we request the state/auth_events to populate a backwards extremity (on backfill or in the case of missing events in a transaction push), we should check that the returned events are in the right room rather than blindly using them in the room state or auth chain. Given that _get_events_from_store_or_dest takes a room_id, it seems clear that it should be sanity-checking the room_id of the requested events, so let's do it there. | ||||
* | | Add `include_event_in_state` to _get_state_for_room (#6521) | Richard van der Hoff | 2019-12-11 | 1 | -22/+28 |
| | | | | | | | | | | Make it return the state *after* the requested event, rather than the one before it. This is a bit easier and requires fewer calls to get_events_from_store_or_dest. | ||||
* | | convert to async: FederationHandler._process_received_pdu | Richard van der Hoff | 2019-12-11 | 1 | -11/+10 |
| | | | | | | | | also fix user_joined_room to consistently return deferreds | ||||
* | | convert to async: FederationHandler._get_state_for_room | Richard van der Hoff | 2019-12-11 | 1 | -21/+21 |
| | | | | | | | | ... and _get_events_from_store_or_dest | ||||
* | | convert to async: FederationHandler.on_receive_pdu | Richard van der Hoff | 2019-12-11 | 1 | -27/+22 |
| | | | | | | | | | | | | | | and associated functions: * on_receive_pdu * handle_queued_pdus * get_missing_events_for_pdu | ||||
* | | Convert federation backfill to async | Richard van der Hoff | 2019-12-11 | 1 | -25/+22 |
| | | | | | | | | | | | | | | | | | | PaginationHandler.get_messages is only called by RoomMessageListRestServlet, which is async. Chase the code path down from there: - FederationHandler.maybe_backfill (and nested try_backfill) - FederationHandler.backfill | ||||
* | | Clean up some logging (#6515) | Richard van der Hoff | 2019-12-11 | 1 | -18/+19 |
| | | | | | | | | This just makes some of the logging easier to follow when things start going wrong. | ||||
* | | Prevent redacted events from appearing in message search (#6377) | Andrew Morgan | 2019-12-11 | 1 | -2/+5 |
| | | |||||
* | | Prevent message search in upgraded rooms we're not in (#6385) | Andrew Morgan | 2019-12-11 | 1 | -2/+2 |
| | | |||||
* | | Move get_state methods into FederationHandler (#6503) | Richard van der Hoff | 2019-12-10 | 1 | -6/+95 |
|/ | | | | | This is a non-functional refactor as a precursor to some other work. | ||||
* | Stronger typing in the federation handler (#6480) | Richard van der Hoff | 2019-12-05 | 1 | -24/+57 |
| | | | | | replace the event_info dict with an attrs thing | ||||
* | Sanity-check the rooms of auth events before pulling them in. (#6472) | Richard van der Hoff | 2019-12-05 | 1 | -9/+25 |
| | |||||
* | get rid of (most of) have_events from ↵ | Richard van der Hoff | 2019-12-04 | 1 | -38/+24 |
| | | | | | | | | | | | | | _update_auth_events_and_context_for_auth (#6468) have_events was a map from event_id to rejection reason (or None) for events which are in our local database. It was used as filter on the list of event_ids being passed into get_events_as_list. However, since get_events_as_list will ignore any event_ids that are unknown or rejected, we can equivalently just leave it to get_events_as_list to do the filtering. That means that we don't have to keep `have_events` up-to-date, and can use `have_seen_events` instead of `get_seen_events_with_rejection` in the one place we do need it. | ||||
* | Add ephemeral messages support (MSC2228) (#6409) | Brendan Abolivier | 2019-12-03 | 1 | -0/+8 |
| | | | | | | | | Implement part [MSC2228](https://github.com/matrix-org/matrix-doc/pull/2228). The parts that differ are: * the feature is hidden behind a configuration flag (`enable_ephemeral_messages`) * self-destruction doesn't happen for state events * only implement support for the `m.self_destruct_after` field (not the `m.self_destruct` one) * doesn't send synthetic redactions to clients because for this specific case we consider the clients to be able to destroy an event themselves, instead we just censor it (by pruning its JSON) in the database | ||||
* | Propagate reason in remotely rejected invites | Erik Johnston | 2019-11-28 | 1 | -2/+2 |
| | |||||
* | Merge pull request #6358 from matrix-org/babolivier/message_retention | Brendan Abolivier | 2019-11-27 | 1 | -2/+2 |
|\ | | | | | Implement message retention policies (MSC1763) | ||||
| * | Merge branch 'develop' into babolivier/message_retention | Brendan Abolivier | 2019-11-26 | 1 | -3/+8 |
| |\ | |||||
| * | | Fix 3PID invite exchange | Brendan Abolivier | 2019-11-19 | 1 | -1/+1 |
| | | | |||||
| * | | Implement per-room message retention policies | Brendan Abolivier | 2019-11-04 | 1 | -1/+1 |
| | | | |||||
* | | | remove confusing fixme | Richard van der Hoff | 2019-11-26 | 1 | -6/+0 |
| | | | |||||
* | | | Merge remote-tracking branch 'origin/develop' into rav/event_auth/4 | Richard van der Hoff | 2019-11-18 | 1 | -2/+2 |
|\ \ \ | | |/ | |/| | |||||
| * | | Replace instance variations of homeserver with correct case/spacing | Andrew Morgan | 2019-11-12 | 1 | -2/+2 |
| | | | |||||
* | | | Use get_events_as_list rather than lots of calls to get_event | Richard van der Hoff | 2019-11-08 | 1 | -16/+8 |
| | | | | | | | | | | | | It's more efficient and clearer. | ||||
* | | | Update some docstrings and comments | Richard van der Hoff | 2019-11-08 | 1 | -8/+31 |
| | | | |||||
* | | | Simplify _update_auth_events_and_context_for_auth | Richard van der Hoff | 2019-11-08 | 1 | -11/+9 |
|/ / | | | | | | | | | move event_key calculation into _update_context_for_auth_events, since it's only used there. | ||||
* | | Fix bug which caused rejected events to be stored with the wrong room state ↵ | Richard van der Hoff | 2019-11-06 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | (#6320) Fixes a bug where rejected events were persisted with the wrong state group. Also fixes an occasional internal-server-error when receiving events over federation which are rejected and (possibly because they are backwards-extremities) have no prev_group. Fixes #6289. | ||||
* | | Add some checks that we aren't using state from rejected events (#6330) | Richard van der Hoff | 2019-11-05 | 1 | -1/+5 |
|/ | | | | | | | | | | | | | * Raise an exception if accessing state for rejected events Add some sanity checks on accessing state_group etc for rejected events. * Skip calculating push actions for rejected events It didn't actually cause any bugs, because rejected events get filtered out at various later points, but there's not point in trying to calculate the push actions for a rejected event. | ||||
* | Factor out an _AsyncEventContextImpl (#6298) | Richard van der Hoff | 2019-11-01 | 1 | -19/+19 |
| | | | | | | The intention here is to make it clearer which fields we can expect to be populated when: notably, that the _event_type etc aren't used for the synchronous impl of EventContext. | ||||
* | Depublish a room from the public rooms list when it is upgraded (#6232) | Andrew Morgan | 2019-11-01 | 1 | -1/+29 |
| | |||||
* | Update black to 19.10b0 (#6304) | Amber Brown | 2019-11-01 | 1 | -4/+5 |
| | | | * update version of black and also fix the mypy config being overridden | ||||
* | Merge pull request #6294 from matrix-org/erikj/add_state_storage | Erik Johnston | 2019-10-31 | 1 | -9/+10 |
|\ | | | | | Add StateGroupStorage interface | ||||
| * | Port to use state storage | Erik Johnston | 2019-10-30 | 1 | -9/+10 |
| | | |||||
* | | Remove usage of deprecated logger.warn method from codebase (#6271) | Andrew Morgan | 2019-10-31 | 1 | -16/+20 |
|/ | | | Replace every instance of `logger.warn` with `logger.warning` as the former is deprecated. | ||||
* | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2019-10-30 | 1 | -3/+19 |
|\ | | | | | | | erikj/split_out_persistence_store | ||||
| * | Fix log line that was printing undefined value (#6278) | Andrew Morgan | 2019-10-30 | 1 | -1/+1 |
| | | |||||
| * | Improve signature checking on some federation APIs (#6262) | Richard van der Hoff | 2019-10-28 | 1 | -2/+18 |
| | | | | | | | | | | Make sure that we check that events sent over /send_join, /send_leave, and /invite, are correctly signed and come from the expected servers. | ||||
* | | Use new EventPersistenceStore | Erik Johnston | 2019-10-23 | 1 | -1/+2 |
|/ | |||||
* | Remove Auth.check method (#6217) | Richard van der Hoff | 2019-10-18 | 1 | -3/+4 |
| | | | This method was somewhat redundant, and confusing. | ||||
* | rip out some unreachable code | Richard van der Hoff | 2019-10-17 | 1 | -102/+0 |
| | | | | The only possible rejection reason is AUTH_ERROR, so all of this is unreachable. | ||||
* | Typo | Brendan Abolivier | 2019-10-04 | 1 | -1/+1 |
| | |||||
* | Lint | Brendan Abolivier | 2019-10-04 | 1 | -3/+1 |
| | |||||
* | Incorporate review | Brendan Abolivier | 2019-10-04 | 1 | -14/+8 |
| | |||||
* | Add test case | Brendan Abolivier | 2019-10-03 | 1 | -1/+1 |
| | |||||
* | Lint | Brendan Abolivier | 2019-10-02 | 1 | -1/+3 |
| | |||||
* | Don't 500 code when trying to exchange a revoked 3PID invite | Brendan Abolivier | 2019-10-02 | 1 | -2/+13 |
| | | | | | | | | While this is not documented in the spec (but should be), Riot (and other clients) revoke 3PID invites by sending a m.room.third_party_invite event with an empty ({}) content to the room's state. When the invited 3PID gets associated with a MXID, the identity server (which doesn't know about revocations) sends down to the MXID's homeserver all of the undelivered invites it has for this 3PID. The homeserver then tries to talk to the inviting homeserver in order to exchange these invite for m.room.member events. When one of the invite is revoked, the inviting homeserver responds with a 500 error because it tries to extract a 'display_name' property from the content, which is empty. This might cause the invited server to consider that the server is down and not try to exchange other, valid invites (or at least delay it). This fix handles the case of revoked invites by avoiding trying to fetch a 'display_name' from the original invite's content, and letting the m.room.member event fail the auth rules (because, since the original invite's content is empty, it doesn't have public keys), which results in sending a 403 with the correct error message to the invited server. | ||||
* | Remove origin parameter from add_display_name_to_third_party_invite and add ↵ | Andrew Morgan | 2019-09-11 | 1 | -1/+6 |
| | | | | | | | params to docstring (#6010) Another small fixup noticed during work on a larger PR. The `origin` field of `add_display_name_to_third_party_invite` is not used and likely was just carried over from the `on_PUT` method of `FederationThirdPartyInviteExchangeServlet` which, like all other servlets, provides an `origin` argument. Since it's not used anywhere in the handler function though, we should remove it from the function arguments. | ||||
* | Remove unnecessary parentheses around return statements (#5931) | Andrew Morgan | 2019-08-30 | 1 | -1/+1 |
| | | | | | Python will return a tuple whether there are parentheses around the returned values or not. I'm just sick of my editor complaining about this all over the place :) | ||||
* | Implement a structured logging output system. (#5680) | Amber Brown | 2019-08-28 | 1 | -2/+3 |
| | |||||
* | Merge pull request #5790 from matrix-org/erikj/groups_request_errors | Erik Johnston | 2019-08-01 | 1 | -0/+3 |
|\ | | | | | Handle RequestSendFailed exception correctly in more places. | ||||
| * | Don't log as exception when failing durig backfill | Erik Johnston | 2019-07-30 | 1 | -0/+3 |
| | | |||||
* | | Room Complexity Client Implementation (#5783) | Amber Brown | 2019-07-30 | 1 | -0/+25 |
|/ | |||||
* | Merge pull request #5744 from matrix-org/erikj/log_leave_origin_mismatch | Richard van der Hoff | 2019-07-26 | 1 | -2/+35 |
|\ | | | | | Log when we receive a /make_* request from a different origin | ||||
| * | Log when we receive a /make_* request from a different origin | Richard van der Hoff | 2019-07-26 | 1 | -2/+35 |
| | | |||||
* | | Replace returnValue with return (#5736) | Amber Brown | 2019-07-23 | 1 | -42/+40 |
|/ | |||||
* | Move logging utilities out of the side drawer of util/ and into logging/ (#5606) | Amber Brown | 2019-07-04 | 1 | -21/+22 |
| | |||||
* | Run Black. (#5482) | Amber Brown | 2019-06-20 | 1 | -521/+363 |
| | |||||
* | Merge pull request #5042 from matrix-org/erikj/fix_get_missing_events_error | Erik Johnston | 2019-06-19 | 1 | -9/+19 |
|\ | | | | | Handle the case of `get_missing_events` failing | ||||
| * | Fix logline | Erik Johnston | 2019-06-18 | 1 | -1/+1 |
| | | |||||
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2019-06-18 | 1 | -132/+289 |
| |\ | | | | | | | | | | erikj/fix_get_missing_events_error | ||||
| * | | Handle the case of `get_missing_events` failing | Erik Johnston | 2019-04-10 | 1 | -9/+20 |
| | | | | | | | | | | | | | | | | | | | | | Currently if a call to `/get_missing_events` fails we log an exception and stop processing the top level event we received over federation. Instead let's try and handle it sensibly given it is a somewhat expected failure mode. | ||||
* | | | Add some logging to 3pid invite sig verification (#5015) | David Baker | 2019-06-18 | 1 | -8/+38 |
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | I had to add quite a lot of logging to diagnose a problem with 3pid invites - we only logged the one failure which isn't all that informative. NB. I'm not convinced the logic of this loop is right: I think it should just accept a single valid signature from a trusted source rather than fail if *any* signature is invalid. Also it should probably not skip the rest of middle loop if a check fails? However, I'm deliberately not changing the logic here. | ||||
* | | Merge pull request #5464 from matrix-org/erikj/3pid_remote_invite_state | Erik Johnston | 2019-06-17 | 1 | -6/+0 |
|\ \ | | | | | | | Fix 3PID invite room state over federation. | ||||
| * | | Fix 3PID invite room state over federation. | Erik Johnston | 2019-06-14 | 1 | -6/+0 |
| | | | | | | | | | | | | | | | | | | | | | Fixes that when a user exchanges a 3PID invite for a proper invite over federation it does not include the `invite_room_state` key. This was due to synapse incorrectly sending out two invite requests. | ||||
* | | | Add plugin APIs for implementations of custom event rules. | Brendan Abolivier | 2019-06-14 | 1 | -2/+66 |
|/ / | |||||
* | | Add logging when request fails and clarify we ignore errors. | Erik Johnston | 2019-06-05 | 1 | -4/+12 |
| | | |||||
* | | Fix handling of failures when calling /event_auth. | Erik Johnston | 2019-06-03 | 1 | -12/+38 |
| | | | | | | | | | | | | | | | | | | | | When processing an incoming event over federation, we may try and resolve any unexpected differences in auth events. This is a non-essential process and so should not stop the processing of the event if it fails (e.g. due to the remote disappearing or not implementing the necessary endpoints). Fixes #3330 | ||||
* | | Simplifications and comments in do_auth (#5227) | Richard van der Hoff | 2019-05-23 | 1 | -120/+181 |
| | | | | | | | | | | I was staring at this function trying to figure out wtf it was actually doing. This is (hopefully) a non-functional refactor which makes it a bit clearer. | ||||
* | | Exclude soft-failed events from fwd-extremity candidates. (#5146) | Richard van der Hoff | 2019-05-21 | 1 | -1/+6 |
|/ | | | | | | | | When considering the candidates to be forward-extremities, we must exclude soft failures. Hopefully fixes #5090. | ||||
* | Collect room-version variations into one place (#4969) | Richard van der Hoff | 2019-04-01 | 1 | -8/+5 |
| | | | | Collect all the things that make room-versions different to one another into one place, so that it's easier to define new room versions. | ||||
* | Factor out soft fail checks | Erik Johnston | 2019-03-08 | 1 | -5/+22 |
| | |||||
* | Implement soft fail | Erik Johnston | 2019-03-06 | 1 | -1/+76 |
| | |||||
* | clarify comments | Erik Johnston | 2019-03-05 | 1 | -8/+11 |
| | |||||
* | Only check history visibility when filtering | Erik Johnston | 2019-03-04 | 1 | -1/+3 |
| | | | | | | When filtering events to send to server we check more than just history visibility. However when deciding whether to backfill or not we only care about the history visibility. | ||||
* | s/get_forward_events/get_successor_events/ | Erik Johnston | 2019-03-04 | 1 | -1/+1 |
| | |||||
* | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2019-03-04 | 1 | -3/+31 |
|\ | | | | | | | erikj/stop_fed_not_in_room | ||||
| * | Fix typo | Erik Johnston | 2019-02-25 | 1 | -1/+1 |
| | | |||||
| * | More comments | Erik Johnston | 2019-02-25 | 1 | -0/+4 |
| | | |||||
| * | Assert rather than clobber the values | Erik Johnston | 2019-02-25 | 1 | -2/+2 |
| | | |||||
| * | Add comments and paranoia | Erik Johnston | 2019-02-25 | 1 | -2/+23 |
| | | |||||
| * | Fix backfill storing incorrect state for events | Erik Johnston | 2019-02-22 | 1 | -1/+4 |
| | | |||||
* | | Update comments | Erik Johnston | 2019-02-27 | 1 | -3/+13 |
| | | |||||
* | | Stop backpaginating when events not visible | Erik Johnston | 2019-02-20 | 1 | -0/+31 |
|/ | |||||
* | Fix flake8 (#4519) | Amber Brown | 2019-01-30 | 1 | -1/+1 |
| | |||||
* | Use snder and not event ID domain to check if ours | Erik Johnston | 2019-01-29 | 1 | -0/+8 |
| | | | | | | The transaction queue only sends out events that we generate. This was done by checking domain of event ID, but that can no longer be used. Instead, we may as well use the sender field. | ||||
* | Fixup calls to `comput_event_signature` | Erik Johnston | 2019-01-29 | 1 | -1/+1 |
| | | | | | | | | We currently pass FrozenEvent instead of `dict` to `compute_event_signature`, which works by accident due to `dict(event)` producing the correct result. This fixes PR #4493 commit 855a151 | ||||
* | Merge pull request #4494 from matrix-org/erikj/fixup_event_validator | Erik Johnston | 2019-01-29 | 1 | -2/+5 |
|\ | | | | | Split up event validation between event and builder | ||||
| * | Split up event validation between event and builder | Erik Johnston | 2019-01-28 | 1 | -2/+5 |
| | | | | | | | | | | | | | | | | | | The validator was being run on the EventBuilder objects, and so the validator only checked a subset of fields. With the upcoming EventBuilder refactor even fewer fields will be there to validate. To get around this we split the validation into those that can be run against an EventBuilder and those run against a fully fledged event. | ||||
* | | Pass through room version to event auth | Erik Johnston | 2019-01-25 | 1 | -8/+12 |
|/ | |||||
* | Require event format version to parse or create events | Erik Johnston | 2019-01-25 | 1 | -28/+44 |
| | |||||
* | Merge branch 'develop' of github.com:matrix-org/synapse into erikj/msc_1813 | Erik Johnston | 2019-01-25 | 1 | -31/+18 |
|\ | |||||
| * | Merge pull request #4448 from matrix-org/erikj/get_pdu_versions | Erik Johnston | 2019-01-24 | 1 | -2/+15 |
| |\ | | | | | | | Add room_version param to get_pdu | ||||
| | * | Review comments | Erik Johnston | 2019-01-24 | 1 | -0/+5 |
| | | | |||||
| | * | Add room_version param to get_pdu | Erik Johnston | 2019-01-23 | 1 | -2/+10 |
| | | | | | | | | | | | | | | | When we add new event format we'll need to know the event format or room version when parsing events. | ||||
| * | | Remove unecessary setting of outlier bit | Erik Johnston | 2019-01-24 | 1 | -2/+0 |
| | | | |||||
| * | | Use term 'out of band membership' instead | Erik Johnston | 2019-01-24 | 1 | -2/+2 |
| | | | |||||
| * | | Clarify the invite flows | Erik Johnston | 2019-01-23 | 1 | -1/+11 |
| | | | |||||
| * | | Remove unnecessary '_sign_event' | Erik Johnston | 2019-01-23 | 1 | -14/+0 |
| | | | |||||
| * | | Store rejected remote invite events as outliers | Erik Johnston | 2019-01-23 | 1 | -32/+12 |
| |/ | | | | | | | | | | | | | | | | | | | | | Currently they're stored as non-outliers even though the server isn't in the room, which can be problematic in places where the code assumes it has the state for all non outlier events. In particular, there is an edge case where persisting the leave event triggers a state resolution, which requires looking up the room version from state. Since the server doesn't have the state, this causes an exception to be thrown. | ||||
* / | Implement MSC 1813 - Add room version to make APIs | Erik Johnston | 2019-01-23 | 1 | -1/+1 |
|/ | | | | | We also implement `make_membership_event` converting the returned room version to an event format version. | ||||
* | Remove hack to support rejoining rooms | Erik Johnston | 2018-11-09 | 1 | -74/+42 |
| | |||||
* | Simplify to always drop events if server isn't in the room | Erik Johnston | 2018-11-09 | 1 | -14/+9 |
| | |||||
* | Add helpers for getting prev and auth events (#4139) | Erik Johnston | 2018-11-06 | 1 | -24/+24 |
| | | | | | | | * Add helpers for getting prev and auth events This is in preparation for allowing the event format to change between room versions. | ||||
* | Merge pull request #4040 from matrix-org/erikj/states_res_v2_rebase | Erik Johnston | 2018-10-24 | 1 | -15/+15 |
|\ | | | | | Add v2 state resolution algorithm | ||||
| * | Comment | Erik Johnston | 2018-10-24 | 1 | -2/+5 |
| | | |||||
| * | Rename resolve_events_with_factory | Erik Johnston | 2018-10-24 | 1 | -2/+2 |
| | | |||||
| * | Fix up use of resolve_events_with_factory | Erik Johnston | 2018-10-16 | 1 | -13/+10 |
| | | |||||
* | | Remove redundant run_as_background_process() from pusherpool | Richard van der Hoff | 2018-10-22 | 1 | -2/+2 |
| | | | | | | | | | | | | | | `on_new_notifications` and `on_new_receipts` in `HttpPusher` and `EmailPusher` now always return synchronously, so we can remove the `defer.gatherResults` on their results, and the `run_as_background_process` wrappers can be removed too because the PusherPool methods will now complete quickly enough. | ||||
* | | Fix incorrect truncation in get_missing_events | Richard van der Hoff | 2018-10-16 | 1 | -7/+5 |
|/ | | | | | | | | | It's quite important that get_missing_events returns the *latest* events in the room; however we were pulling event ids out of the database until we got *at least* 10, and then taking the *earliest* of the results. We also shouldn't really be relying on depth, and should be checking the room_id. | ||||
* | Avoid reraise, to improve stacktraces | Richard van der Hoff | 2018-10-01 | 1 | -10/+10 |
| | |||||
* | Include event when resolving state for missing prevs | Richard van der Hoff | 2018-09-27 | 1 | -2/+16 |
| | | | | | | | | | | | If we have a forward extremity for a room as `E`, and you receive `A`, `B`, s.t. `A -> B -> E`, and `B` also points to an unknown event `X`, then we need to do state res between `X` and `E`. When that happens, we need to make sure we include `X` in the state that goes into the state res alg. Fixes #3934. | ||||
* | Include state from remote servers in pdu handling | Richard van der Hoff | 2018-09-27 | 1 | -4/+19 |
| | | | | | | | | If we've fetched state events from remote servers in order to resolve the state for a new event, we need to actually pass those events into resolve_events_with_factory (so that it can do the state res) and then persist the ones we need - otherwise other bits of the codebase get confused about why we have state groups pointing to non-existent events. | ||||
* | Fix "unhashable type: 'list'" exception in federation handling | Richard van der Hoff | 2018-09-27 | 1 | -7/+12 |
| | | | | | | | | | | | | | get_state_groups returns a map from state_group_id to a list of FrozenEvents, so was very much the wrong thing to be putting as one of the entries in the list passed to resolve_events_with_factory (which expects maps from (event_type, state_key) to event id). We actually want get_state_groups_ids().values() rather than get_state_groups(). This fixes the main problem in #3923, but there are other problems with this bit of code which get discovered once you do so. | ||||
* | more comments | Richard van der Hoff | 2018-09-27 | 1 | -4/+3 |
| | |||||
* | Clarifications in FederationHandler | Richard van der Hoff | 2018-09-27 | 1 | -2/+11 |
| | | | | | | | * add some comments on things that look a bit bogus * rename this `state` variable to avoid confusion with the `state` used elsewhere in this function. (There was no actual conflict, but it was a confusing bit of spaghetti.) | ||||
* | Merge pull request #3966 from matrix-org/rav/rx_txn_logging_2 | Richard van der Hoff | 2018-09-27 | 1 | -0/+4 |
|\ | | | | | Logging improvements | ||||
| * | Logging improvements | Richard van der Hoff | 2018-09-26 | 1 | -0/+4 |
| | | | | | | | | Some logging tweaks to help with debugging incoming federation transactions | ||||
* | | Include eventid in log lines when processing incoming federation ↵ | Richard van der Hoff | 2018-09-27 | 1 | -26/+39 |
|/ | | | | | | | | | | | transactions (#3959) when processing incoming transactions, it can be hard to see what's going on, because we process a bunch of stuff in parallel, and because we may end up recursively working our way through a chain of three or four events. This commit creates a way to use logcontexts to add the relevant event ids to the log lines. | ||||
* | Comments and interface cleanup for on_receive_pdu | Richard van der Hoff | 2018-09-20 | 1 | -23/+46 |
| | | | | | | | | Add some informative comments about what's going on here. Also, `sent_to_us_directly` and `get_missing` were doing the same thing (apart from in `_handle_queued_pdus`, which looks like a bug), so let's get rid of `get_missing` and use `sent_to_us_directly` consistently. | ||||
* | Improve the logging when handling a federation transaction (#3904) | Richard van der Hoff | 2018-09-19 | 1 | -55/+109 |
| | | | | | | | | | | Let's try to rationalise the logging that happens when we are processing an incoming transaction, to make it easier to figure out what is going wrong when they take ages. In particular: - make everything start with a [room_id event_id] prefix - make sure we log a warning when catching exceptions rather than just turning them into other, more cryptic, exceptions. | ||||
* | Bump timeout on get_missing_events request | Richard van der Hoff | 2018-09-18 | 1 | -1/+30 |
| | |||||
* | Port handlers/ to Python 3 (#3803) | Amber Brown | 2018-09-07 | 1 | -3/+3 |
| | |||||
* | Remove unnecessary resolve_events_with_state_map | Erik Johnston | 2018-08-22 | 1 | -1/+1 |
| | | | | | We only ever used the synchronous resolve_events_with_state_map in one place, which is trivial to replace with the async version. | ||||
* | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2018-08-20 | 1 | -20/+59 |
|\ | | | | | | | erikj/refactor_state_handler | ||||
| * | Fix logcontexts for running pushers | Richard van der Hoff | 2018-08-17 | 1 | -2/+1 |
| | | | | | | | | | | | | | | First of all, avoid resetting the logcontext before running the pushers, to fix the "Starting db txn 'get_all_updated_receipts' from sentinel context" warning. Instead, give them their own "background process" logcontexts. | ||||
| * | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2018-08-15 | 1 | -1/+1 |
| |\ | | | | | | | | | | erikj/split_federation | ||||
| | * | Rename async to async_helpers because `async` is a keyword on Python 3.7 (#3678) | Amber Brown | 2018-08-10 | 1 | -1/+1 |
| | | | |||||
| * | | Use federation handler function rather than duplicate | Erik Johnston | 2018-08-15 | 1 | -7/+7 |
| | | | | | | | | | | | | This involves renaming _persist_events to be a public function. | ||||
| * | | Move clean_room_for_join to master | Erik Johnston | 2018-08-09 | 1 | -2/+14 |
| | | | |||||
| * | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2018-08-09 | 1 | -2/+11 |
| |\| | | | | | | | | | | erikj/split_federation | ||||
| * | | Add EDU/query handling over replication | Erik Johnston | 2018-08-06 | 1 | -11/+13 |
| | | | |||||
| * | | Add replication APIs for persisting federation events | Erik Johnston | 2018-08-06 | 1 | -9/+35 |
| | | | |||||
* | | | Remove redundant room_version checks | Erik Johnston | 2018-08-20 | 1 | -1/+1 |
| | | | |||||
* | | | Choose state algorithm based on room version | Erik Johnston | 2018-08-09 | 1 | -2/+6 |
| |/ |/| | |||||
* | | include known room versions in outgoing make_joins | Richard van der Hoff | 2018-08-06 | 1 | -2/+11 |
|/ | |||||
* | Merge branch 'master' into develop | Richard van der Hoff | 2018-08-02 | 1 | -6/+23 |
|\ | |||||
| * | Avoid extra db lookups | Richard van der Hoff | 2018-08-02 | 1 | -27/+11 |
| | | | | | | | | | | Since we're about to look up the events themselves anyway, we can skip the extra db queries here. | ||||
| * | Validation for events/rooms in fed requests | Richard van der Hoff | 2018-08-02 | 1 | -1/+34 |
| | | | | | | | | | | | | | | When we get a federation request which refers to an event id, make sure that said event is in the room the caller claims it is in. (patch supplied by @turt2live) | ||||
* | | Merge pull request #3621 from matrix-org/erikj/split_fed_store | Erik Johnston | 2018-08-02 | 1 | -87/+88 |
|\ \ | | | | | | | Split out DB writes in federation handler | ||||
| * | | update docs | Erik Johnston | 2018-08-01 | 1 | -3/+5 |
| | | | |||||
| * | | _persist_auth_tree no longer returns anything | Erik Johnston | 2018-08-01 | 1 | -1/+1 |
| | | | |||||
| * | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2018-07-30 | 1 | -1/+1 |
| |\ \ | | | | | | | | | | | | | erikj/split_fed_store | ||||
| * | | | Split out DB writes in federation handler | Erik Johnston | 2018-07-25 | 1 | -83/+82 |
| | | | | | | | | | | | | | | | | | | | | | | | | This will allow us to easily add an internal replication API to proxy these reqeusts to master, so that we can move federation APIs to workers. | ||||
* | | | | rename replication_layer to federation_client | Richard van der Hoff | 2018-07-31 | 1 | -14/+14 |
| |/ / |/| | | | | | | | | | | | I have HAD ENOUGH of trying to remember wtf a replication layer is in terms of classes. | ||||
* | | | Fix a minor documentation typo in on_make_leave | Travis Ralston | 2018-07-25 | 1 | -1/+1 |
|/ / | |||||
* | | Handle delta_ids being None in _update_context_for_auth_events | Richard van der Hoff | 2018-07-23 | 1 | -7/+6 |
| | | | | | | | | | | | | | | it's easier to create the new state group as a delta from the existing one. (There's an outside chance this will help with https://github.com/matrix-org/synapse/issues/3364) | ||||
* | | Add support for updating state | Erik Johnston | 2018-07-23 | 1 | -9/+23 |
| | | |||||
* | | Use new getters | Erik Johnston | 2018-07-23 | 1 | -7/+16 |
| | | |||||
* | | Make the rest of the .iterwhatever go away (#3562) | Amber Brown | 2018-07-21 | 1 | -9/+9 |
| | | |||||
* | | Merge pull request #3367 from matrix-org/rav/drop_re_signing_hacks | Richard van der Hoff | 2018-07-18 | 1 | -43/+0 |
|\ \ | |/ |/| | Remove event re-signing hacks | ||||
| * | Merge branch 'develop' into rav/drop_re_signing_hacks | Richard van der Hoff | 2018-07-04 | 1 | -51/+153 |
| |\ | |||||
| * | | Remove event re-signing hacks | Richard van der Hoff | 2018-06-07 | 1 | -43/+0 |
| | | | | | | | | | | | | | | | | | | These "temporary fixes" have been here three and a half years, and I can't find any events in the matrix.org database where the calculated signature differs from what's in the db. It's time for them to go away. | ||||
* | | | Move filter_events_for_server out of FederationHandler | Richard van der Hoff | 2018-07-16 | 1 | -138/+6 |
| | | | | | | | | | | | | for easier unit testing. | ||||
* | | | run isort | Amber Brown | 2018-07-09 | 1 | -18/+22 |
| |/ |/| | |||||
* | | try and clean up | Amber Brown | 2018-06-27 | 1 | -3/+6 |
| | | |||||
* | | pep8 | Amber Brown | 2018-06-27 | 1 | -6/+4 |
| | | |||||
* | | cleanups | Amber Brown | 2018-06-27 | 1 | -13/+15 |
| | | |||||
* | | handle federation not telling us about prev_events | Amber Brown | 2018-06-27 | 1 | -25/+62 |
| | | |||||
* | | Actually fix it | Erik Johnston | 2018-06-25 | 1 | -3/+3 |
| | | |||||
* | | Comment | Erik Johnston | 2018-06-25 | 1 | -0/+8 |
| | | |||||
* | | Fix bug with assuming wrong type | Erik Johnston | 2018-06-25 | 1 | -2/+2 |
| | | |||||
* | | Add fast path to _filter_events_for_server | Erik Johnston | 2018-06-25 | 1 | -1/+34 |
| | | | | | | | | | | | | Most rooms have a trivial history visibility like "shared" or "world_readable", especially large rooms, so lets not bother getting the full membership of those rooms in that case. | ||||
* | | Revert "Revert "Merge pull request #3431 from ↵ | Erik Johnston | 2018-06-25 | 1 | -0/+13 |
| | | | | | | | | | | | | matrix-org/rav/erasure_visibility"" This reverts commit 1d009013b3c3e814177afc59f066e02a202b21cd. | ||||
* | | Revert "Merge pull request #3431 from matrix-org/rav/erasure_visibility" | Richard van der Hoff | 2018-06-22 | 1 | -13/+0 |
| | | | | | | | | | | This reverts commit ce0d911156b355c5bf452120bfb08653dad96497, reversing changes made to b4a5d767a94f1680d07edfd583aae54ce422573e. | ||||
* | | Merge pull request #3431 from matrix-org/rav/erasure_visibility | Erik Johnston | 2018-06-22 | 1 | -0/+13 |
|\ \ | | | | | | | Support hiding events from deleted users | ||||
| * | | Filter out erased messages | Richard van der Hoff | 2018-06-12 | 1 | -0/+13 |
| | | | | | | | | | | | | Redact any messges sent by erased users. | ||||
* | | | Merge pull request #3428 from matrix-org/erikj/persisted_pdu | Erik Johnston | 2018-06-22 | 1 | -18/+26 |
|\| | | | | | | | | Simplify get_persisted_pdu | ||||
| * | | simplify get_persisted_pdu | Richard van der Hoff | 2018-06-12 | 1 | -18/+26 |
| | | | | | | | | | | | | | | | it doesn't make much sense to use get_persisted_pdu on the receive path: just get the event straight from the store. | ||||
* | | | Remove run_on_reactor (#3395) | Amber Brown | 2018-06-14 | 1 | -5/+1 |
|/ / | |||||
* / | Fix event filtering in get_missing_events handler | Richard van der Hoff | 2018-06-08 | 1 | -0/+4 |
|/ | |||||
* | Consistently use six's iteritems and wrap lazy keys/values in list() if ↵ | Amber Brown | 2018-05-31 | 1 | -9/+8 |
| | | | | they're not meant to be lazy (#3307) | ||||
* | Misc. py3 fixes | Adrian Tschira | 2018-05-24 | 1 | -4/+5 |
| | | | | Signed-off-by: Adrian Tschira <nota@notafile.com> | ||||
* | Merge pull request #3261 from matrix-org/erikj/pagination_fixes | Erik Johnston | 2018-05-24 | 1 | -9/+22 |
|\ | | | | | Fix federation backfill bugs | ||||
| * | Use iter* methods | Erik Johnston | 2018-05-22 | 1 | -7/+7 |
| | | |||||
| * | Fix that states is a dict of dicts | Erik Johnston | 2018-05-22 | 1 | -1/+4 |
| | | |||||
| * | get_domains_from_state returns list of tuples | Erik Johnston | 2018-05-22 | 1 | -2/+12 |
| | | |||||
* | | s/values/itervalues/ | Erik Johnston | 2018-05-23 | 1 | -1/+1 |
| | | |||||
* | | Use iter* methods for _filter_events_for_server | Erik Johnston | 2018-05-23 | 1 | -4/+4 |
|/ | |||||
* | Make sure we reject attempts to invite the notices user | Richard van der Hoff | 2018-05-18 | 1 | -0/+8 |
| | |||||
* | Merge pull request #3153 from NotAFile/py3-httplib | Richard van der Hoff | 2018-04-30 | 1 | -3/+3 |
|\ | | | | | move httplib import to six | ||||
| * | move httplib import to six | Adrian Tschira | 2018-04-28 | 1 | -3/+3 |
| | | |||||
* | | Merge remote-tracking branch 'origin/develop' into rav/use_run_in_background | Richard van der Hoff | 2018-04-27 | 1 | -6/+10 |
|\| | |||||
| * | reraise exceptions more carefully | Richard van der Hoff | 2018-04-27 | 1 | -6/+10 |
| | | | | | | | | | | | | | | We need to be careful (under python 2, at least) that when we reraise an exception after doing some error handling, we actually reraise the original exception rather than anything that might have been raised (and handled) during the error handling. | ||||
* | | Use run_in_background in preference to preserve_fn | Richard van der Hoff | 2018-04-27 | 1 | -6/+10 |
|/ | | | | | | While I was going through uses of preserve_fn for other PRs, I converted places which only use the wrapped function once to use run_in_background, to avoid creating the function object. | ||||
* | Merge pull request #3118 from matrix-org/rav/reject_prev_events | Richard van der Hoff | 2018-04-23 | 1 | -7/+71 |
|\ | | | | | Reject events which have lots of prev_events |