summary refs log tree commit diff
path: root/stubs (unfollow)
Commit message (Collapse)AuthorFilesLines
2021-09-08Add a script to update the debian changelog for non-Debian systems (#10778)Brendan Abolivier2-0/+65
When releasing 1.42.0 with @Azrenbeth and talking with @clokep yesterday I realised doing the dch incantations related to releasing Synapse wasn't trivial on eg a macOS system, so this is a script to run in a Debian container to make things a bit easier.
2021-09-08Document that /spaces & /hierarchy can be routed to workers. (#10648)Patrick Cloke4-25/+33
Also refactors some of the registration of endpoints on workers.
2021-09-08Skip handling of push actions for outlier events (#10780)Erik Johnston3-4/+19
Outlier events don't ever have push actions associated with them, so we can skip some expensive queries during event persistence.
2021-09-08Add a constant for m.federate. (#10775)Patrick Cloke8-10/+28
2021-09-08Change logging of puppeted requests to better differentiate users (#10779)Erik Johnston2-1/+2
This used to be a comma and got accidentally changed to a period in #9654, but a pipe character is more easier to parse visually.
2021-09-08Request JSON for oEmbed requests (and ignore XML only providers). (#10759)Patrick Cloke4-8/+98
This adds the format to the request arguments / URL to ensure that JSON data is returned (which is all that Synapse supports). This also adds additional error checking / filtering to the configuration file to ignore XML-only providers.
2021-09-08Add some assertions about outliers (#10773)Richard van der Hoff2-71/+78
I think I have finally teased apart the codepaths which handle outliers, and those that handle non-outliers. Let's add some assertions to demonstrate my newfound knowledge.
2021-09-08Persist auth events before the events that rely on them (#10771)Richard van der Hoff2-36/+66
If we're persisting an event E which has auth_events A1, A2, then we ought to make sure that we correctly auth and persist A1 and A2, before we blindly accept E. This PR does part of that - it persists the auth events first - but it does not fully solve the problem, because we still don't check that the auth events weren't rejected.
2021-09-07Add "No significant changes" to changelog v1.42.0Azrenbeth1-0/+2
2021-09-07Move upgrade notice up in changelogAzrenbeth1-6/+1
2021-09-071.42.0Azrenbeth3-1/+13
2021-09-07Use attrs internally for the URL preview code & add documentation. (#10753)Patrick Cloke5-119/+132
2021-09-07Return stripped m.space.child events via the space summary. (#10760)Patrick Cloke2-14/+13
The full event content cannot be trusted from this API (as no auth chain, etc.) is processed over federation. Returning the full event content was a bug as MSC2946 specifies that only the stripped state should be returned. This also avoids calculating aggregations / annotations which go unused.
2021-09-07Underscore-prefix private fields in `FederationEventHandler` (#10746)Richard van der Hoff2-71/+74
2021-09-06Add logging to help debug #9424 (#10704)Azrenbeth2-13/+55
2021-09-06Add config option to use non-default manhole password and keys (#10643)Azrenbeth9-17/+161
2021-09-06Improve changelog wording v1.42.0rc2Brendan Abolivier1-1/+1
2021-09-06Expand on why users should read upgrade notesBrendan Abolivier1-1/+4
2021-09-06Move the upgrade notes reminder up to rc2Brendan Abolivier1-3/+2
2021-09-06 1.42.0rc2Brendan Abolivier5-3/+22
2021-09-06Add a warning when using deprecated template_dir settings (#10768)Brendan Abolivier4-0/+42
The deprecation itself happened in #10596 which shipped with Synapse v1.41.0. However, it doesn't seem fair to suddenly drop support for these settings in ~4-6w without being more vocal about said deprecation.
2021-09-06Stop using BaseHandler in `FederationEventHandler` (#10745)Richard van der Hoff3-10/+12
It's now only used in a couple of places, so we can drop it altogether.
2021-09-06Allow `room_alias_name` parameter to be handled by /createRoom calls on ↵Andrew Morgan2-2/+3
workers (#10757)
2021-09-06Ease searching for M_TOO_LARGE-related error codes (#10750)Andrew Morgan2-9/+7
2021-09-06Doc: Clarifying undoing room shutdowns (#10480)David Teller2-15/+28
2021-09-06Move `maybe_kick_guest_users` out of `BaseHandler` (#10744)Richard van der Hoff9-85/+125
This is part of my ongoing war against BaseHandler. I've moved kick_guest_users into RoomMemberHandler (since it calls out to that handler anyway), and split maybe_kick_guest_users into the two places it is called.
2021-09-06Pull out encrypted_by_default tests from user_directory tests (#10752)David Robertson4-95/+111
2021-09-06Speed up persisting redacted events (#10756)Erik Johnston2-11/+12
2021-09-04Allow room creator to send MSC2716 related events in existing room versions ↵Eric Eastwood4-10/+61
(#10566) * Allow room creator to send MSC2716 related events in existing room versions Discussed at https://github.com/matrix-org/matrix-doc/pull/2716/#discussion_r682474869 Restoring `get_create_event_for_room_txn` from, https://github.com/matrix-org/synapse/pull/10245/commits/44bb3f0cf5cb365ef9281554daceeecfb17cc94d * Add changelog * Stop people from trying to redact MSC2716 events in unsupported room versions * Populate rooms.creator column for easy lookup > From some [out of band discussion](https://matrix.to/#/!UytJQHLQYfvYWsGrGY:jki.re/$p2fKESoFst038x6pOOmsY0C49S2gLKMr0jhNMz_JJz0?via=jki.re&via=matrix.org), my plan is to use `rooms.creator`. But currently, we don't fill in `creator` for remote rooms when a user is invited to a room for example. So we need to add some code to fill in `creator` wherever we add to the `rooms` table. And also add a background update to fill in the rows missing `creator` (we can use the same logic that `get_create_event_for_room_txn` is doing by looking in the state events to get the `creator`). > > https://github.com/matrix-org/synapse/pull/10566#issuecomment-901616642 * Remove and switch away from get_create_event_for_room_txn * Fix no create event being found because no state events persisted yet * Fix and add tests for rooms creator bg update * Populate rooms.creator field for easy lookup Part of https://github.com/matrix-org/synapse/pull/10566 - Fill in creator whenever we insert into the rooms table - Add background update to backfill any missing creator values * Add changelog * Fix usage * Remove extra delta already included in #10697 * Don't worry about setting creator for invite * Only iterate over rows missing the creator See https://github.com/matrix-org/synapse/pull/10697#discussion_r695940898 * Use constant to fetch room creator field See https://github.com/matrix-org/synapse/pull/10697#discussion_r696803029 * More protection from other random types See https://github.com/matrix-org/synapse/pull/10697#discussion_r696806853 * Move new background update to end of list See https://github.com/matrix-org/synapse/pull/10697#discussion_r696814181 * Fix query casing * Fix ambiguity iterating over cursor instead of list Fix `psycopg2.ProgrammingError: no results to fetch` error when tests run with Postgres. ``` SYNAPSE_POSTGRES=1 SYNAPSE_TEST_LOG_LEVEL=INFO python -m twisted.trial tests.storage.databases.main.test_room ``` --- We use `txn.fetchall` because it will return the results as a list or an empty list when there are no results. Docs: > `cursor` objects are iterable, so, instead of calling explicitly fetchone() in a loop, the object itself can be used: > > https://www.psycopg.org/docs/cursor.html#cursor-iterable And I'm guessing iterating over a raw cursor does something weird when there are no results. --- Test CI failure: https://github.com/matrix-org/synapse/pull/10697/checks?check_run_id=3468916530 ``` tests.test_visibility.FilterEventsForServerTestCase.test_large_room =============================================================================== [FAIL] Traceback (most recent call last): File "/home/runner/work/synapse/synapse/tests/storage/databases/main/test_room.py", line 85, in test_background_populate_rooms_creator_column self.get_success( File "/home/runner/work/synapse/synapse/tests/unittest.py", line 500, in get_success return self.successResultOf(d) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/trial/_synctest.py", line 700, in successResultOf self.fail( twisted.trial.unittest.FailTest: Success result expected on <Deferred at 0x7f4022f3eb50 current result: None>, found failure result instead: Traceback (most recent call last): File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 701, in errback self._startRunCallbacks(fail) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 764, in _startRunCallbacks self._runCallbacks() File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 858, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 1751, in gotResult current_context.run(_inlineCallbacks, r, gen, status) --- <exception caught here> --- File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 1657, in _inlineCallbacks result = current_context.run( File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/failure.py", line 500, in throwExceptionIntoGenerator return g.throw(self.type, self.value, self.tb) File "/home/runner/work/synapse/synapse/synapse/storage/background_updates.py", line 224, in do_next_background_update await self._do_background_update(desired_duration_ms) File "/home/runner/work/synapse/synapse/synapse/storage/background_updates.py", line 261, in _do_background_update items_updated = await update_handler(progress, batch_size) File "/home/runner/work/synapse/synapse/synapse/storage/databases/main/room.py", line 1399, in _background_populate_rooms_creator_column end = await self.db_pool.runInteraction( File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 686, in runInteraction result = await self.runWithConnection( File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 791, in runWithConnection return await make_deferred_yieldable( File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/internet/defer.py", line 858, in _runCallbacks current.result = callback( # type: ignore[misc] File "/home/runner/work/synapse/synapse/tests/server.py", line 425, in <lambda> d.addCallback(lambda x: function(*args, **kwargs)) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/enterprise/adbapi.py", line 293, in _runWithConnection compat.reraise(excValue, excTraceback) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/deprecate.py", line 298, in deprecatedFunction return function(*args, **kwargs) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/python/compat.py", line 404, in reraise raise exception.with_traceback(traceback) File "/home/runner/work/synapse/synapse/.tox/py/lib/python3.9/site-packages/twisted/enterprise/adbapi.py", line 284, in _runWithConnection result = func(conn, *args, **kw) File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 786, in inner_func return func(db_conn, *args, **kwargs) File "/home/runner/work/synapse/synapse/synapse/storage/database.py", line 554, in new_transaction r = func(cursor, *args, **kwargs) File "/home/runner/work/synapse/synapse/synapse/storage/databases/main/room.py", line 1375, in _background_populate_rooms_creator_column_txn for room_id, event_json in txn: psycopg2.ProgrammingError: no results to fetch ``` * Move code not under the MSC2716 room version underneath an experimental config option See https://github.com/matrix-org/synapse/pull/10566#issuecomment-906437909 * Add ordering to rooms creator background update See https://github.com/matrix-org/synapse/pull/10697#discussion_r696815277 * Add comment to better document constant See https://github.com/matrix-org/synapse/pull/10697#discussion_r699674458 * Use constant field
2021-09-03Speed up MultiWriterIdGenerator when lots of IDs are in flight. (#10755)Erik Johnston4-2/+124
2021-09-03Support MSC3375: room version 9. (#10747)Patrick Cloke4-1/+79
2021-09-03Add a partial index to `presence_stream` to speed up startups (#10748)Sean4-1/+43
Signed-off-by: Sean Quah <seanq@element.io>
2021-09-03Use `execute_values` more in PostgreSQL (#10754)Erik Johnston2-19/+43
`execute_values` is a faster version of `execute_batch`.
2021-09-03Raise an error if an unknown preset is used to create a room. (#10738)Patrick Cloke2-1/+7
Raises a 400 error instead of a 500 if an unknown preset is passed from a client to create a room.
2021-09-03Additional type hints for client REST servlets (part 5) (#10736)Patrick Cloke8-68/+146
Additionally this enforce type hints on all function signatures inside of the synapse.rest.client package.
2021-09-03Fix bug with reusing 'txn' when persisting event. (#10743)Erik Johnston2-1/+8
This will only happen when a server has multiple out of band membership events in a single room.
2021-09-02Fix documentation of directory name for remote thumbnails (#10556)cuttingedge11092-1/+2
2021-09-01Ignore rooms with unknown room versions in the spaces summary. (#10727)Patrick Cloke3-2/+40
This avoids breaking the entire endpoint if a room with an unsupported room version is encountered.
2021-09-01Consider the `origin_server_ts` of the `m.space.child` event when ordering ↵Patrick Cloke3-12/+22
rooms. (#10730) This updates the ordering of the returned events from the spaces summary API to that defined in MSC2946 (which updates MSC1772). Previously a step was skipped causing ordering to be inconsistent with clients.
2021-09-01Additional type hints for client REST servlets (part 4) (#10728)Patrick Cloke9-100/+145
2021-09-01Populate `rooms.creator` field for easy lookup (#10697)Eric Eastwood6-4/+213
Part of https://github.com/matrix-org/synapse/pull/10566 - Fill in creator whenever we insert into the rooms table - Add background update to backfill any missing creator values
2021-09-01Make minor changes to changelog v1.42.0rc1Olivier Wilkinson (reivilibre)1-2/+2
2021-09-01Correctly include room avatars in email notifications (#10658)David Robertson3-6/+71
Judging by the template, this was intended ages ago, but we never actually passed an avatar URL to the template. So let's provide one. Closes #1546. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2021-09-01Improve changelogOlivier Wilkinson (reivilibre)1-3/+3
Expand OIDC to OpenID Connect.
2021-09-01Improve changelogOlivier Wilkinson (reivilibre)1-7/+6
2021-09-01Skip the final GC on shutdown to improve restart times (#10712)Sean2-0/+8
Use `gc.freeze()` on exit to exclude all existing objects from the final GC. In testing, this sped up shutdown by up to a few seconds. `gc.freeze()` runs in constant time, so there is little chance of performance regression. Signed-off-by: Sean Quah <seanq@element.io>
2021-09-011.42.0rc1Olivier Wilkinson (reivilibre)51-52/+78
2021-09-01Fix iteration in _remove_deleted_email_pushers background job. (#10734)Andrew Morgan3-1/+47
2021-08-31Allow configuration of the oEmbed URLs. (#10714)Patrick Cloke8-252/+463
This adds configuration options (under an `oembed` section) to configure which URLs are matched to use oEmbed for URL previews.
2021-08-31Additional type hints for the client REST servlets (part 3). (#10707)Patrick Cloke7-150/+306
2021-08-31Move the sessions delta to the latest schema version. (#10725)Patrick Cloke2-0/+1
This was erroneously put under schema version 62 instead of 63.
2021-08-31 1.41.1 v1.41.1Richard van der Hoff3-1/+39
2021-08-31Fix up unit tests (#10723)Richard van der Hoff2-2/+16
These were broken in an incorrect merge of GHSA-jj53-8fmw-f2w2 (cb35df9)
2021-08-31Advertise matrix-org.github.io/synapse docs (#10595)David Robertson4-432/+459
Point to the book where possible, and use hyperlinks to github to refer to files not included in the book. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2021-08-31Merge pull request from GHSA-jj53-8fmw-f2w2reivilibre2-2/+59
2021-08-31Merge pull request from GHSA-3x4c-pq33-4w3qreivilibre2-4/+103
* Add some tests to characterise the problem Some failing. Current states: RoomsMemberListTestCase test_get_member_list ... [OK] test_get_member_list_mixed_memberships ... [OK] test_get_member_list_no_permission ... [OK] test_get_member_list_no_permission_former_member ... [OK] test_get_member_list_no_permission_former_member_with_at_token ... [FAIL] test_get_member_list_no_room ... [OK] test_get_member_list_no_permission_with_at_token ... [FAIL] * Correct the tests * Check user is/was member before divulging room membership * Pull out only the 1 membership event we want. * Update tests/rest/client/v1/test_rooms.py Co-authored-by: Erik Johnston <erik@matrix.org> * Fixup tests (following apply review suggestion) Co-authored-by: Erik Johnston <erik@matrix.org>
2021-08-27Fix incompatibility with Twisted < 21. (#10713)Richard van der Hoff5-21/+173
Turns out that the functionality added in #10546 to skip TLS was incompatible with older Twisted versions, so we need to be a bit more inventive. Also, add a test to (hopefully) not break this in future. Sadly, testing TLS is really hard.
2021-08-27 Removed page summaries from the top of installation and contributing doc ↵Azrenbeth4-75/+21
pages (#10711) - Removed page summaries from CONTRIBUTING and installation pages as this information was already in the table of contents on the right hand side - Fixed some broken links in CONTRIBUTING - Added margin-right tag for when table of contents is being shown (otherwise the text in the page sometimes overlaps with it)
2021-08-27Clarifications to reverse_proxy.md (#10708)Richard van der Hoff2-5/+6
* Update reverse_proxy.md * Create 10708.doc
2021-08-27Remove unused `compare_digest` function. (#10706)Patrick Cloke2-13/+1
2021-08-27Improve ServerNoticeServlet to avoid duplicate requests (#10679)Dirk Klimpel5-17/+475
Fixes: #9544
2021-08-27Fix perf of fetching the same events many times. (#10703)Erik Johnston2-6/+24
The code to deduplicate repeated fetches of the same set of events was N^2 (over the number of events requested), which could lead to a process being completely wedged. The main fix is to deduplicate the returned deferreds so we only await on a deferred once rather than many times. Seperately, when handling the returned events from the defrered we only add the events we care about to the event map to be returned (so that we don't pay the price of inserting extraneous events into the dict).
2021-08-26Split `FederationHandler` in half (#10692)Richard van der Hoff11-1780/+1883
The idea here is to take anything to do with incoming events and move it out to a separate handler, as a way of making FederationHandler smaller.
2021-08-26Make `backfill` and `get_missing_events` use the same codepath (#10645)Richard van der Hoff3-233/+42
Given that backfill and get_missing_events are basically the same thing, it's somewhat crazy that we have entirely separate code paths for them. This makes backfill use the existing get_missing_events code, and then clears up all the unused code.
2021-08-26Validate new m.room.power_levels events (#10232)Aaron Raimist5-4/+160
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-08-26Remove pushers when deleting 3pid from account (#10581)Azrenbeth7-1/+143
When a user deletes an email from their account it will now also remove all pushers for that email and that user (even if these pushers were created by a different client)
2021-08-26Additional type hints for REST servlets (part 2). (#10674)Patrick Cloke17-138/+216
Applies the changes from #10665 to additional modules.
2021-08-26Cache the result of fetching the room hierarchy over federation. (#10647)Patrick Cloke2-40/+67
2021-08-25Make a note to leave a summary when one is bumping the schema version (#10621)Andrew Morgan2-0/+3
I found this easy to miss (and evidently, it looks like it was missed for schema version 62).
2021-08-25Ensure the base Docker image is rebuilt when running complement with ↵Patrick Cloke2-7/+8
workers. (#10686) We now always rebuild the matrixdotorg/synapse image, then build the matrixdotorg/synapse-workers image on top of it.
2021-08-25Fix error when selecting between thumbnails with the same quality (#10684)Sean3-10/+56
Fixes #10318
2021-08-24Update changelog v1.41.0Erik Johnston1-4/+9
2021-08-24 1.41.0Erik Johnston4-2/+16
2021-08-24Persist room hierarchy pagination sessions to the database. (#10613)Patrick Cloke7-38/+212
2021-08-24Correctly initialise the `synapse_user_logins` metric. (#10677)Richard van der Hoff4-6/+44
Fix a bug where the prometheus metrics for SSO logins wouldn't be initialised until the first user logged in with a given auth provider.
2021-08-23doc: add django-oauth-toolkit to oidc doc (#10192)Hugo DELVAL2-0/+49
Signed-off-by: Hugo Delval <hugo.delval@gmail.com>
2021-08-23Enforce the max length for per-room display names / avatar URLs. (#10654)Azrenbeth2-1/+17
To match the maximum lengths allowed for profile data.
2021-08-23Fix the titles in the OIDC documentation (#10639)Andrew Morgan2-6/+11
* Fix the titles in the OIDC documentation Having them as links broke the table-of-contents rendering in mdbook. Plus there's no reason for only some of the provider titles to be links. * Changelog * Add link to google idp docs
2021-08-23Avoid duplicate issues from Twisted trunk failures (#10672)Dan Callahan2-1/+3
Setting `update_existing: true` in the `create-an-issue` GitHub Action will avoid opening duplicate issues if an open issue already exists with an identical title. If no open issues match the title, then a new issue will be created. This helps avoid spamming our issue tracker should there be a failure when testing against Twisted's trunk. This PR also pins the SHA of the `create-an-issue` action to mitigate the risk of a malicious actor gaining access to JasonEtco's account. See GitHub's page on security hardening third party actions for more: https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#using-third-party-actions Signed-off-by: Dan Callahan <danc@element.io>
2021-08-23Additional type hints for the sync REST servlet. (#10666)Patrick Cloke3-61/+93
2021-08-23Addtional type hints for the REST servlets. (#10665)Patrick Cloke14-107/+204
2021-08-23Do not include stack traces for known exceptions when trying multiple ↵Patrick Cloke2-1/+7
federation destinations. (#10662)
2021-08-23Run a nightly CI build against Twisted trunk. (#10651)Richard van der Hoff4-0/+102
This creates a GHA workflow which runs at 8am every day, and runs mypy, trial and sytest against Twisted's current trunk. If any of the jobs fail, it opens an issue.
2021-08-21Implement MSC3231: Token authenticated registration (#10142)Callum Brown21-1/+2389
Signed-off-by: Callum Brown <callum@calcuode.com> This is part of my GSoC project implementing [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231).
2021-08-20Flatten tests/rest/client/{v1,v2_alpha} too (#10667)David Robertson27-18/+6
2021-08-20Simplify tests for the device admin rest API. (#10664)Dirk Klimpel2-81/+19
By replacing duplicated code with parameterized tests and avoiding unnecessary dumping of JSON data.
2021-08-20Follow-up: format changelog, add licence (#10593)David Robertson2-1/+15
Merged before approval; these comments from @clokep on that PR.
2021-08-20Validate device_keys for C-S /keys/query requests (#10593)David Robertson4-1/+101
* Validate device_keys for C-S /keys/query requests Closes #10354 A small, not particularly critical fix. I'm interested in seeing if we can find a more systematic approach though. #8445 is the place for any discussion.
2021-08-20Set room version 8 as preferred for restricted rooms. (#10571)Patrick Cloke4-4/+5
2021-08-19Split `on_receive_pdu` in half (#10640)Richard van der Hoff4-109/+142
Here we split on_receive_pdu into two functions (on_receive_pdu and process_pulled_event), rather than having both cases in the same method. There's a tiny bit of overlap, but not that much.
2021-08-19Extract `_resolve_state_at_missing_prevs` (#10624)Richard van der Hoff2-105/+125
This is a follow-up to #10615: it takes the code that constructs the state at a backwards extremity, and extracts it to a separate method.
2021-08-19Do not include rooms with an unknown room version in a sync response. (#10644)Patrick Cloke7-11/+145
A user will still see this room if it is in a local cache, but it will not reappear if clearing the cache and reloading.
2021-08-19Fix typo in release notes (#10646)John-Scott Atlakson1-1/+1
Ubuntu 20.10 was not an LTS release Signed-off-by: John-Scott Atlakson 24574+jsma@users.noreply.github.com
2021-08-19Support MSC3283: Expose `enable_set_displayname` in capabilities (#10452)Dirk Klimpel4-23/+101
2021-08-19Remove not needed database updates in modify user admin API (#10627)Dirk Klimpel5-33/+118
2021-08-18Additional type hints for the proxy agent and SRV resolver modules. (#10608)Dirk Klimpel5-25/+41
2021-08-18Update docs/upgrade.md with new versionErik Johnston1-1/+1
2021-08-18Fix weakref_slot parameter for room member storage attrs. (#10642)Patrick Cloke2-4/+5
Follow-up to #10629 which set it to true, not false.
2021-08-18Update changelog v1.41.0rc1Erik Johnston1-4/+4
2021-08-18 1.41.0rc1Erik Johnston63-61/+86
2021-08-18Convert room member storage tuples to attrs. (#10629)Patrick Cloke7-29/+54
Instead of using namedtuples. This helps with asserting type hints and code completion.
2021-08-18Mount /_synapse/admin/v1/users/{userId}/media admin API on media workers ↵Andrew Morgan6-165/+173
only (#10628) Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2021-08-18Display an error page during failure of fallback UIA. (#10561)Callum Brown8-28/+65
2021-08-18fix broken link to upgrade notes (#10631)Richard van der Hoff2-1/+2
2021-08-18Refactor `on_receive_pdu` code (#10615)Richard van der Hoff2-134/+138
* drop room pdu linearizer sooner No point holding onto it while we recheck the db * move out `missing_prevs` calculation we're going to need `missing_prevs` whatever we do, so we may as well calculate it eagerly and just update it if it gets outdated. * Add another `if missing_prevs` condition this should be a no-op, since all the code inside the block already checks `if missing_prevs` * reorder if conditions This shouldn't change the logic at all. * Push down `min_depth` read No point reading it from the database unless we're going to use it. * Collect the sent_to_us_directly code together Move the remaining `sent_to_us_directly` code inside the `if sent_to_us_directly` block. * Properly separate the `not sent_to_us_directly` branch Since the only way this second block is now reachable is if we *didn't* go into the `sent_to_us_directly` branch, we can replace it with a simple `else`. * changelog
2021-08-18Use auto-attribs for attrs classes for sync. (#10630)Patrick Cloke2-78/+79
2021-08-18Allow modules to run looping call on all instances (#10638)Erik Johnston2-1/+9
By default the calls only ran on the worker configured to run background tasks.
2021-08-17Remove deprecated Shutdown Room and Purge Room Admin API (#8830)Dirk Klimpel9-384/+14
2021-08-17Allow /createRoom to be run on workers (#10564)Andrew Morgan4-35/+37
Fixes https://github.com/matrix-org/synapse/issues/7867
2021-08-17Port the PresenceRouter module interface to the new generic interface (#10524)Azrenbeth9-69/+326
Port the PresenceRouter module interface to the new generic interface introduced in v1.37.0
2021-08-17Remove the unused public_room_list_stream (#10565)Andrew Morgan9-250/+48
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2021-08-17Build debs for bookworm (#10612)Richard van der Hoff2-1/+3
2021-08-17Centralise the custom template directory (#10596)Brendan Abolivier12-418/+342
Several configuration sections are using separate settings for custom template directories, which can be confusing. This PR adds a new top-level configuration for a custom template directory which is then used for every module. The only exception is the consent templates, since the consent template directory require a specific hierarchy, so it's probably better that it stays separate from everything else.
2021-08-17Attempt to pull from the legacy spaces summary API over federation. (#10583)Patrick Cloke2-9/+56
If the new /hierarchy API does not exist on all destinations, fallback to querying the /spaces API and translating the results. This is a backwards compatibility hack since not all of the federated homeservers will update at the same time.
2021-08-17Stop setting the outlier flag for things that aren't (#10614)Richard van der Hoff2-7/+3
Marking things as outliers to inhibit pushes is a sledgehammer to crack a nut. Move the test further down the stack so that we just inhibit the thing we want.
2021-08-17Make `PeriodicallyFlushingMemoryHandler` the default logging handler. (#10518)reivilibre4-21/+61
2021-08-17Flatten the synapse.rest.client package (#10600)reivilibre123-188/+137
2021-08-17Always list fallback key types in /sync (#10623)Andrew Morgan2-4/+6
2021-08-17Allow to edit `external_ids` by Edit User admin API (#10598)Dirk Klimpel5-89/+340
Signed-off-by: Dirk Klimpel dirk@klimpel.org
2021-08-17update links to schema doc (#10620)Richard van der Hoff3-3/+4
2021-08-17Allow using several custom template directories (#10587)Brendan Abolivier7-27/+98
Allow using several directories in read_templates.
2021-08-17Add an admin API to check if a username is available (#10578)Will Hunt5-0/+136
This adds a new API GET /_synapse/admin/v1/username_available?username=foo to check if a username is available. It is the counterpart to https://matrix.org/docs/spec/client_server/r0.6.0#get-matrix-client-r0-register-available, except that it works even if registration is disabled.
2021-08-16Manhole: wrap coroutines in `defer.ensureDeferred` automatically (#10602)reivilibre3-1/+16
2021-08-16Update CONTRIBUTING.md to fix index links and SyTest instructions (#10599)reivilibre2-3/+5
Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>
2021-08-16Validate the max_rooms_per_space parameter to ensure it is non-negative. ↵Patrick Cloke3-9/+39
(#10611)
2021-08-16Experimental support for MSC3266 Room Summary API. (#10394)Michael Telatynski10-115/+289
2021-08-16Split `synapse.federation.transport.server` into multiple files. (#10590)Patrick Cloke7-2158/+2219
2021-08-16Clean up some logging in the federation event handler (#10591)Richard van der Hoff4-29/+28
* Include outlier status in `str(event)` In places where we log event objects, knowing whether or not you're dealing with an outlier is super useful. * Remove duplicated logging in get_missing_events When we process events received from get_missing_events, we log them twice (once in `_get_missing_events_for_pdu`, and once in `on_receive_pdu`). Reduce the duplication by removing the logging in `on_receive_pdu`, and ensuring the call sites do sensible logging. * log in `on_receive_pdu` when we already have the event * Log which prev_events we are missing * changelog
2021-08-16Support federation in the new spaces summary API (MSC2946). (#10569)Patrick Cloke6-165/+518
2021-08-16Handle string read receipt data (#10606)Šimon Brandner3-1/+32
* Handle string read receipt data Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Test that we handle string read receipt data Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Add changelog for #10606 Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Add docs Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Ignore malformed RRs Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Only surround hidden = ... Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Remove unnecessary argument Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> * Update changelog.d/10606.bugfix Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2021-08-16Update the Synapse Grafana dashboard (#10570)Brendan Abolivier2-66/+485
2021-08-13Move /batch_send to /v2_alpha directory (MSC2716) (#10576)Eric Eastwood4-409/+445
* Move /batch_send to /v2_alpha directory As pointed out by @erikjohnston, https://github.com/matrix-org/synapse/pull/10552#discussion_r685836624
2021-08-13Fix a harmless exception when the staged events queue is empty. (#10592)Patrick Cloke2-5/+11
2021-08-12Stop building a debian package for Groovy Gorilla (#10588)David Robertson2-1/+1
2021-08-12Remove buildkite-era commentDavid Robertson1-3/+0
2021-08-12portdb also uses coverage, so provide $TOP thereDavid Robertson1-0/+2
2021-08-12Also rename in lint.shDavid Robertson1-1/+1
2021-08-11Update the pagination parameter name based on MSC2946 review. (#10579)Patrick Cloke3-10/+11
2021-08-11Admin API to delete media for a specific user (#10558)Dirk Klimpel7-128/+347
2021-08-11Missed another ci->.ciDavid Robertson1-9/+9
Should have been more systematic with my grepping.
2021-08-11set TOP in sytest containersDavid Robertson2-2/+3
2021-08-11Teach MANIFEST and tox about ci->.ciDavid Robertson2-2/+2
2021-08-11Allow requesting the summary of a space which is joinable. (#10580)Patrick Cloke3-15/+45
As opposed to only allowing the summary of spaces which the user is already in or has world-readable visibility. This makes the logic consistent with whether a space/room is returned as part of a space and whether a space summary can start at a space.
2021-08-11Rename ci to .ciDavid Robertson8-6/+6
2021-08-11