summary refs log tree commit diff
path: root/jenkins.sh (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-08-31Tweak changelog formatting v1.66.0Sean Quah1-6/+4
2022-08-31Move notice from 1.66.0rc1 to 1.66.0 section in changelogSean Quah1-6/+6
2022-08-31Tweak changelog wordingSean Quah1-4/+5
2022-08-31Improve clarity on deprecation of TCP replicationSean Quah2-2/+10
Borrows some text from https://github.com/matrix-org/synapse/pull/13647 for the changelog.
2022-08-31Fix dead link in 1.18.0 upgrade notesSean Quah1-1/+1
2022-08-31Update changelog to link to the Synapse docs instead of markdownSean Quah1-1/+1
2022-08-311.66.0Sean Quah3-3/+12
2022-08-31Update changelog for v1.62.0Sean Quah1-0/+14
2022-08-31Remind people that direct TCP replication is disabled. (#13674)Patrick Cloke1-0/+8
2022-08-30Update changes v1.66.0rc2David Robertson1-1/+1
2022-08-301.66.0rc2David Robertson4-2/+16
2022-08-30Fix rate limit metrics registering twice and misreporting (#13649)Eric Eastwood3-32/+128
* Fix rate limit metrics registering twice and misreporting Fix https://github.com/matrix-org/synapse/issues/13641 * Fix lints * Add changelog * Document `metrics_name=None`.
2022-08-23Remove manually-added changelog v1.66.0rc1David Robertson1-1/+0
2022-08-23Drop support for delegating email validation, round 2 (#13596)David Robertson13-245/+108
2022-08-23Update changelogDavid Robertson1-5/+5
2022-08-23Adjust changelogDavid Robertson1-18/+26
2022-08-23Describe changes to admin API in 1.66David Robertson1-0/+2
Cross-ref #13525
2022-08-231.66.0rc1David Robertson47-46/+68
2022-08-23Fix that sending server notices fail if avatar is `None` (#13566)Dirk Klimpel4-4/+64
Indroduced in #11846.
2022-08-23Fix Prometheus metrics being negative (mixed up start/end) (#13584)Eric Eastwood4-2/+22
Fix: - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244
2022-08-22`synapse.api.auth.Auth` cleanup: make permission-related methods use ↵Quentin Gliech26-208/+203
`Requester` instead of the `UserID` (#13024) Part of #13019 This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it. It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.
2022-08-22Remove redundant opentracing spans for `/sendToDevice` and `/keys/upload` ↵Andrew Morgan3-4/+3
(#13574)
2022-08-19MSC2716v4 room version - remove namespace from MSC2716 event content fields ↵Eric Eastwood5-24/+25
(#13551) Complement PR: https://github.com/matrix-org/complement/pull/450 As suggested in https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r941444525
2022-08-19Implement MSC3852: Expose `last_seen_user_agent` to users for their own ↵Andrew Morgan8-2/+153
devices; also expose to Admin API (#13549)
2022-08-19Register homeserver modules when creating test homeserver (#13558)Andrew Morgan5-22/+15
2022-08-19Reduce the number of tests using TCP replication. (#13543)Patrick Cloke6-77/+36
Uses Redis replication in additional test cases (instead of TCP replication). A small step towards dropping TCP replication.
2022-08-19Fix validation problem that occurs when a user tries to deactivate their ↵reivilibre3-3/+19
account or change their password. (#13563)
2022-08-18Add metrics to track `/messages` response time by room size (#13545)Eric Eastwood2-2/+54
Follow-up to https://github.com/matrix-org/synapse/pull/13533 Part of https://github.com/matrix-org/synapse/issues/13356
2022-08-18Fix incorrect juggling of logging contexts in `_PerHostRatelimiter` (#13554)Sean Quah2-10/+8
Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-08-18Track number of hosts affected by the rate limiter (#13541)Eric Eastwood2-4/+40
Track number of hosts affected by the rate limiter so we can differentiate one really noisy homeserver from a general ratelimit tuning problem across the federation. Follow-up to https://github.com/matrix-org/synapse/pull/13534 Part of https://github.com/matrix-org/synapse/issues/13356
2022-08-18Add support for compression to federation responses (#13537)Ayush Anand3-2/+6
Closes #13415. Signed-off-by: Ayush Anand <iamayushanand@gmail.com>
2022-08-18Avoid blocking lazy-loading `/sync`s during partial joins (#13477)Sean Quah3-34/+244
Use a state filter or accept partial state in a few places where we request state, to avoid blocking. To make lazy-loading `/sync`s work, we need to provide the memberships of event senders, which are not guaranteed to be in the room state. Instead we dig through auth events for memberships to present to clients. The auth events of an event are guaranteed to contain a passable membership event, otherwise the event would have been rejected. Note that this only covers the common code paths encountered during testing. There has been no exhaustive checking of all sync code paths. Fixes #13146. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-08-17Add metrics to track how the rate limiter is affecting requests ↵Eric Eastwood2-8/+30
(sleep/reject) (#13534) Related to https://github.com/matrix-org/synapse/pull/13499 Part of https://github.com/matrix-org/synapse/issues/13356
2022-08-17Fix a bug in the `/event_reports` Admin API which meant that the total count ↵reivilibre3-0/+34
could be larger than the number of results you can actually query for. (#13525) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-08-17A first pass at pruning the Synapse README (#13491)David Robertson3-347/+194
2022-08-17Fix breaking event sending due to bad push rule (#13547)Erik Johnston2-1/+13
Broke by #13522 It looks like we have some rules in the DB with a priority class less than 0 that don't override the base rules. Before these were just dropped, but #13522 made that a hard error.
2022-08-17Reject non-strict types in Pydantic models (#13502)David Robertson4-1/+440
2022-08-17Fix a typo in docs and in some warnings (#13538)Antonin Loubiere5-4/+5
2022-08-17Add forgotten status to Room Details API (#13503)Dirk Klimpel6-1/+101
2022-08-17Add metrics to track rate limiter queue timing (#13544)Eric Eastwood2-0/+31
2022-08-17Time how long it takes us to do backfill processing (#13535)Eric Eastwood3-16/+90
2022-08-17Add specific metric to time long-running `/messages` requests (#13533)Eric Eastwood2-0/+33
2022-08-16Instrument the federation/backfill part of `/messages` (#13489)Eric Eastwood11-33/+220
Instrument the federation/backfill part of `/messages` so it's easier to follow what's going on in Jaeger when viewing a trace. Split out from https://github.com/matrix-org/synapse/pull/13440 Follow-up from https://github.com/matrix-org/synapse/pull/13368 Part of https://github.com/matrix-org/synapse/issues/13356
2022-08-16Note explicitly that #11365 was reverted in the 1.65 CHANGELOGAndrew Morgan1-1/+1
2022-08-161.65.0 v1.65.0Andrew Morgan3-1/+13
2022-08-16Refuse to start when `faster_joins` is enabled on a worker deployment (#13531)Sean Quah2-0/+8
Synapse does not currently support faster room joins on deployments with workers. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-08-16Add missing links in `user_consent` section of configuration manual (#13536)Dirk Klimpel2-2/+3
Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-08-16Faster room joins: make `/joined_members` block whilst the room is partial ↵reivilibre4-1/+22
stated. (#13514)
2022-08-16Make push rules use proper structures. (#13522)Erik Johnston8-333/+494
This improves load times for push rules: | Version | Time per user | Time for 1k users | | -------------------- | ------------- | ----------------- | | Before | 138 µs | 138ms | | Now (with custom) | 2.11 µs | 2.11ms | | Now (without custom) | 49.7 ns | 0.05 ms | This therefore has a large impact on send times for rooms with large numbers of local users in the room.
2022-08-15Use Pydantic to systematically validate a first batch of endpoints in ↵David Robertson10-92/+296
`synapse.rest.client.account`. (#13188)
2022-08-15Add a warning to retention documentation regarding the possibility of ↵Shay3-2/+9
database corruption (#13497)
2022-08-15Instrument `FederationStateIdsServlet` - `/state_ids` (#13499)Eric Eastwood5-2/+21
Instrument FederationStateIdsServlet - `/state_ids` so it's easier to follow what's going on in Jaeger when viewing a trace.
2022-08-15Revert "Update locked versions of mypy and mypy-zope (#13521)"David Robertson7-60/+73
This reverts commit f383b9b3eceaa082d5ae690550fe41460b711779. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.
2022-08-15Clarifications for event push action processing. (#13485)Patrick Cloke3-21/+35
* Clarifies comments. * Fixes an erroneous comment (about return type) added in #13455 (ec24813220f9d54108924dc04aecd24555277b99). * Clarifies the name of a variable. * Simplifies logic of pulling out the latest join for the requesting user.
2022-08-15Update locked versions of mypy and mypy-zope (#13521)David Robertson7-73/+60
2022-08-13Update grafana dashboardRichard van der Hoff1-1805/+2695
2022-08-12Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker ↵reivilibre2-1/+2
image. (#13515)
2022-08-11Add `openssl` example for registration HMAC (#13472)James Barton2-2/+20
Signed-off-by: James Barton <james@neodon.com>
2022-08-11Add note to `redaction_retention_period` documentation mentioning that event ↵Andrew Morgan2-0/+5
purging runs at most every 5m (#13492)
2022-08-11Add viewport directive to HTML templates to optimise for mobile (#13493)Germain31-47/+140
2022-08-11Update the rejected state of events during resync (#13459)Richard van der Hoff4-9/+66
Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.
2022-08-111.65.0rc2 v1.65.0rc2Olivier Wilkinson (reivilibre)4-2/+16
2022-08-11Revert 'Remove the unspecced field in the response. (#13365)' to give more ↵reivilibre2-0/+2
time for clients to update. (#13501)
2022-08-10Use literals in place of `HTTPStatus` constants in tests (#13488)Dirk Klimpel12-447/+177
* Use literals in place of `HTTPStatus` constants in tests * newsfile * code style * code style
2022-08-10Add some miscellaneous comments around sync (#13474)Sean Quah3-40/+81
Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-08-09Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)Eric Eastwood3-56/+186
```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```
2022-08-09Use literals in place of `HTTPStatus` constants in tests (#13479)Dirk Klimpel12-141/+141
Replace - `HTTPStatus.NOT_FOUND` - `HTTPStatus.FORBIDDEN` - `HTTPStatus.UNAUTHORIZED` - `HTTPStatus.CONFLICT` - `HTTPStatus.CREATED` Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-08-09Fix changelog mistakeOlivier Wilkinson (reivilibre)1-2/+1
2022-08-09Strengthen tests about deleted old push actions. (#13471)Patrick Cloke2-0/+16
2022-08-09Tweak the changelog v1.65.0rc1Olivier Wilkinson (reivilibre)1-6/+6
2022-08-091.65.0rc1Olivier Wilkinson (reivilibre)52-51/+82
2022-08-09Make the configuration for the cache clearer (#13481)Dirk Klimpel2-4/+6
2022-08-08Update matrix-synapse-ldap3 version in lockfile to v0.2.2. (#13470)Shay2-12/+14
2022-08-08Use literals in place of `HTTPStatus` constants in tests (#13469)Dirk Klimpel13-331/+329
2022-08-08Correct a misnamed argument in state res v2 (#13467)David Robertson2-6/+7
In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.
2022-08-05Support stable identifiers for MSC2285: private read receipts. (#13273)Šimon Brandner14-94/+246
This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.
2022-08-05Use literals in place of `HTTPStatus` constants in tests (#13463)Dirk Klimpel18-191/+172
2022-08-05Mark token-authenticaticated-registration API as not-experimental (#11897)Julian-Samuel Gebühr2-3/+4
2022-08-05Update module API "update room membership" method to allow for remote joins ↵Matt C3-4/+34
(#13441) Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-08-04Add comments about how event push actions are stored. (#13445)Erik Johnston2-0/+62
2022-08-04Fix `@tag_args` being off-by-one (ahead) (#13452)Eric Eastwood2-2/+14
Fix @tag_args being off-by-one (ahead) Example: ``` argspec.args=[ 'self', 'room_id' ] args=( <synapse.storage.databases.main.DataStore object at 0x10d0b8d00>, '!HBehERstyQBxyJDLfR:my.synapse.server' ) ``` --- The previous logic was also flawed and we can end up in a situation like this: ``` argspec.args=['self', 'dest', 'room_id', 'limit', 'extremities'] args=(<synapse.federation.federation_client.FederationClient object at 0x7f1651c18160>, 'hs1', '!jAEHKIubyIfuLOdfpY:hs1') ``` From this source: ```py async def backfill( self, dest: str, room_id: str, limit: int, extremities: Collection[str] ) -> Optional[List[EventBase]]: ``` And this usage: ```py events = await self._federation_client.backfill( dest, room_id, limit=limit, extremities=extremities ) ``` which would previously cause this error: ``` synapse_main | 2022-08-04 06:13:12,051 - synapse.handlers.federation - 424 - ERROR - GET-5 - Failed to backfill from hs1 because tuple index out of range synapse_main | Traceback (most recent call last): synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation.py", line 392, in try_backfill synapse_main | await self._federation_event_handler.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation_event.py", line 593, in backfill synapse_main | events = await self._federation_client.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 827, in _wrapper synapse_main | with wrapping_logic(func, *args, **kwargs): synapse_main | File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__ synapse_main | return next(self.gen) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 922, in _wrapping_logic synapse_main | set_attribute("ARG_" + arg, str(args[i + 1])) # type: ignore[index] synapse_main | IndexError: tuple index out of range ```
2022-08-04Improve comments (& avoid a duplicate query) in push actions processing. ↵Patrick Cloke2-124/+159
(#13455) * Adds docstrings and inline comments. * Formats SQL queries using triple quoted strings. * Minor formatting changes. * Avoid fetching `event_push_summary_stream_ordering` multiple times in the same transactions.
2022-08-04Update type of `EventContext.rejected` (#13460)Richard van der Hoff3-5/+5
2022-08-04Faster Room Joins: prevent Synapse from answering federated join requests ↵reivilibre3-0/+35
for a room which it has not fully joined yet. (#13416)
2022-08-04Optimise async get event lookups (#13435)Nick Mills-Barrett4-8/+87
Still maintains local in memory lookup optimisation, but does any external lookup as part of the deferred that prevents duplicate lookups for the same event at once. This makes the assumption that fetching from an external cache is a non-zero load operation.
2022-08-04Update some outdated information on `sso_mapping_providers.md` (#13449)Dirk Klimpel2-6/+9
2022-08-04Fix return value in example on `password_auth_provider_callbacks.md` (#13450)Dirk Klimpel2-2/+3
Fixes: #12534 Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
2022-08-04synapse-workers docker: copy nginx and redis in from base images (#13447)Richard van der Hoff3-36/+60
Part of my continuing quest to make the docker images build quicker: copy nginx and redis in from base docker images, rather than apt installing each time.
2022-08-04Add module API method to create a room (#13429)Matt C3-0/+103
Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-08-04Fix rooms not being properly excluded from incremental sync (#13408)Brendan Abolivier3-10/+37
2022-08-03Add some tracing spans to give insight into local joins (#13439)Shay3-33/+40
2022-08-03Instrument `/messages` for understandable traces in Jaeger (#13368)Eric Eastwood11-1/+32
In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work
2022-08-03Return 404 or member list when getting joined_members after leaving (#13374)andrew do3-2/+20
Signed-off-by: Andrew Doh <andrewddo@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <andrewm@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-08-03Install cryptography build dependencies in requirements image. (#13372)Jasper Spaans2-1/+3
2022-08-03Improve documentation on becoming server admin (#13230)jejo862-1/+3
* Improved section regarding server admin Added steps describing how to elevate an existing user to administrator by manipulating a `postgres` database. Signed-off-by: jejo86 28619134+jejo86@users.noreply.github.com * Improved section regarding server admin * Reference database settings Add instructions to check database settings to find out the database name, instead of listing all available PostgreSQL databases. * Add suggestions from PR conversation Replace config filename `homeserver.yaml`. with "config file". Remove instructions to switch to `postgres` user. Add instructions how to connect to SQLite database. * Update changelog.d/13230.doc Co-authored-by: reivilibre <olivier@librepush.net>
2022-08-03Update doc for setting `macaroon_secret_key` (#13443)Dirk Klimpel2-3/+8
* Update doc for setting `macaroon_secret_key` * newsfile
2022-08-03Rename `RateLimitConfig` to `RatelimitSettings` (#13442)Dirk Klimpel5-29/+30
2022-08-03Add module API method to resolve a room alias to a room ID (#13428)Matt C3-0/+44
Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-08-03Remove 'Contents' section from the Configuration Manual (#13438)Dirk Klimpel2-43/+1
Fixes: #13053
2022-08-03Fix wrong headline for `url_preview_accept_language` in docs (#13437)Dirk Klimpel2-1/+2
Fixes: #13433
2022-08-02Add a `merge-back` command to the release script, which automates merging ↵reivilibre2-0/+77
the correct branches after a release. (#13393)
2022-08-02Fix error when out of servers to sync partial state with (#13432)Sean Quah2-2/+4
so that we raise the intended error instead. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-08-02Mention specific version in rc2 notes v1.64.0Olivier Wilkinson (reivilibre)1-1/+1
2022-08-02Add upgrade notesOlivier Wilkinson (reivilibre)1-0/+10
2022-08-021.64.0Olivier Wilkinson (reivilibre)3-1/+22
2022-08-01Faster Room Joins: don't leave a stuck room partial state flag if the join ↵reivilibre3-15/+140
fails. (#13403)
2022-08-01Fix missing import in `federation_event` handler. (#13431)Patrick Cloke2-0/+2
#13404 removed an import of `Optional` which was still needed due to #13413 added more usages.
2022-08-01Refactor `_resolve_state_at_missing_prevs` to return an `EventContext` (#13404)Sean Quah5-86/+68
Previously, `_resolve_state_at_missing_prevs` returned the resolved state before an event and a partial state flag. These were unwieldy to carry around would only ever be used to build an event context. Build the event context directly instead. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-08-01Enable Complement CI tests in the 'latest deps' test run. (#13213)reivilibre4-5/+58
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
2022-08-01Re-enable running Complement tests against Synapse with workers. (#13420)reivilibre2-24/+4
2022-08-01Faster joins: fix rejected events becoming un-rejected during resync (#13413)Richard van der Hoff3-6/+32
Make sure that we re-check the auth rules during state resync, otherwise rejected events get un-rejected.
2022-07-29update changelog v1.64.0rc2Richard van der Hoff1-5/+2
2022-07-291.64.0rc2Richard van der Hoff4-2/+16
2022-07-29Revert "Drop support for delegating email validation (#13192)" (#13406)3nprob12-266/+425
Reverts commit fa71bb18b527d1a3e2629b48640ea67fff2f8c59, and tweaks documentation. Signed-off-by: 3nprob <git@3n.anonaddy.com>
2022-07-29Explicitly mention which resources support compression in the config guide ↵Brendan Abolivier2-1/+3
(#13221)
2022-07-27Use stable prefixes for MSC3827: filtering of `/publicRooms` by room type ↵Šimon Brandner7-11/+8
(#13370) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-07-27Add missing type hints for tests.unittest. (#13397)Patrick Cloke6-52/+66
2022-07-27Implement MSC3848: Introduce errcodes for specific event sending failures ↵Will Hunt11-36/+144
(#13343) Implements MSC3848
2022-07-27Make minor clarifications to the error messages given when we fail to join a ↵reivilibre4-3/+17
room via any server. (#13160)
2022-07-27Fix `get_pdu` asking every remote destination even after it finds an event ↵Eric Eastwood2-3/+4
(#13346)
2022-07-26Copy room serials before handling in `get_new_events_as` (#13392)Nick Mills-Barrett2-3/+11
2022-07-26Extend the release script to automatically push a new SyTest branch, rather ↵reivilibre2-32/+55
than having that be a manual process. (#12978) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2022-07-26Remove the unspecced `room_id` field in the `/hierarchy` response. (#13365)Patrick Cloke2-1/+1
The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
2022-07-26Explain less-known term 'Implicit TLS' v1.64.0rc1Olivier Wilkinson (reivilibre)1-1/+1
2022-07-26Fix infinite loop in partial-state resync (#13353)Richard van der Hoff3-8/+27
Make sure that we only pull out events from the db once they have no prev-events with partial state.
2022-07-26Tweak changelog in response to reviewOlivier Wilkinson (reivilibre)1-9/+7
2022-07-26Faster room joins: avoid blocking when pulling events with missing prevs ↵Sean Quah8-33/+124
(#13355) Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-07-26Tweak changelogOlivier Wilkinson (reivilibre)1-9/+11
2022-07-26Remove unused argument for get_relations_for_event. (#13383)Patrick Cloke3-9/+1
2022-07-261.64.0rc1Olivier Wilkinson (reivilibre)73-73/+95
2022-07-26Disable autocorrect and autocaptialisation when entering username for SSO ↵Doug2-1/+2
registration. (#13350) When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).
2022-07-25Update Caddy reverse proxy documentation (#13344)Matt Holt2-42/+12
Improve/simplify Caddy examples. Remove Caddy v1 (has long been EOL'ed) Signed-off-by: Matthew Holt <mholt@users.noreply.github.com>
2022-07-25Support Implicit TLS for sending emails (#13317)Jan Schär5-13/+99
Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>
2022-07-25Additional fixes for opentracing type hints. (#13362)Patrick Cloke2-2/+3
2022-07-25Refactor presence so we can prune user in room caches (#13313)Erik Johnston4-91/+109
See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.
2022-07-22Backfill remote event fetched by MSC3030 so we can paginate from it later ↵Eric Eastwood3-15/+94
(#13205) Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848
2022-07-22Update config_documentation.md (#13364)Richard van der Hoff1-2/+2
"changed in" goes before the example
2022-07-22Update locked frozendict version to 2.3.3 (#13352)Sean Quah3-18/+28
frozendict 2.3.3 includes fixes for memory leaks that get triggered during `/sync`.
2022-07-22Skip soft fail checks for rooms with partial state (#13354)Sean Quah2-0/+11
When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-07-21Remove old empty/redundant slaved stores. (#13349)Nick Mills-Barrett12-238/+63
2022-07-21Make DictionaryCache have better expiry properties (#13292)Erik Johnston7-43/+358
2022-07-21Don't hold onto full state in state cache (#13324)Erik Johnston2-15/+54
2022-07-21Call out buildkit is required when building test docker images (#13338)Brendan Abolivier4-0/+7
Co-authored-by: David Robertson <davidr@element.io>
2022-07-21Track DB txn times w/ two counters, not histogram (#13342)David Robertson2-3/+6
2022-07-21Add missing types to opentracing. (#13345)Patrick Cloke14-45/+83
After this change `synapse.logging` is fully typed.
2022-07-21Use cache store remove base slaved (#13329)Nick Mills-Barrett16-114/+39
This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
2022-07-21Document `rc_invites.per_issuer`, added in v1.63.David Teller2-0/+9
Resolves #13330. Missed in #13125. Signed-off-by: David Teller <davidt@element.io>
2022-07-20Update `get_pdu` to return the original, pristine `EventBase` (#13320)Eric Eastwood5-61/+233
Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
2022-07-20Validate federation destinations and log an error if server name is invalid. ↵Shay3-2/+12
(#13318)
2022-07-201.63.1 v1.63.1Erik Johnston4-2/+16
2022-07-20Don't include appservice users when calculating push rules (#13332)Erik Johnston3-0/+93
This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
2022-07-19Fix spurious warning when fetching state after a missing prev event (#13258)Sean Quah2-0/+4
2022-07-19Add type annotations to `trace` decorator. (#13328)Patrick Cloke12-55/+102
Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
2022-07-19Reduce memory usage of state group cache (#13323)Erik Johnston2-1/+3
2022-07-19Stop building Ubuntu 21.10 (Impish Indri) which is end of life. (#13326)Patrick Cloke2-1/+1
2022-07-19Improve precision on validation improvements v1.63.0Brendan Abolivier1-1/+1
2022-07-191.63.0Brendan Abolivier4-4/+13
2022-07-19Remove 'anonymised' from the phone home stats documentation (#13321)Andrew Morgan11-30/+44
2022-07-19Bash script for creating multiple stream writers (#13271)villepeh3-1/+147
Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.
2022-07-19Add notes when config options were changed to config documentation (#13314)Jörg Behrmann2-0/+6
Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
2022-07-19Rate limit joins per-room (#13276)David Robertson18-15/+498
2022-07-19Safe async event cache (#13308)Nick Mills-Barrett8-21/+102
Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
2022-07-18Increase batch size of `bulk_get_push_rules` and ↵Shay3-1/+3
`_get_joined_profiles_from_event_ids`. (#13300)
2022-07-18Improve performance of query ` _get_subset_users_in_room_with_profiles` (#13299)Shay2-1/+2
2022-07-18Fix overcounting of pushers when they are replaced (#13296)Sean Quah2-11/+17
Signed-off-by: Sean Quah <seanq@matrix.org>
2022-07-18Up the dependency on canonicaljson to ^1.5.0 (#13172)Brendan Abolivier3-2/+5
Co-authored-by: David Robertson <davidr@element.io>
2022-07-18Prevent #3679 from appearing in blame results (#13311)Andrew Morgan2-0/+14
2022-07-18Revert "Make all `process_replication_rows` methods async (#13304)" (#13312)Erik Johnston14-40/+25
This reverts commit 5d4028f217f178fcd384d5bfddd92225b4e78c51.
2022-07-18Don't pull out full state when sending dummy events (#13310)Erik Johnston2-7/+2
2022-07-18Use READ COMMITTED isolation level when purging rooms (#12942)Nick Mills-Barrett2-2/+32
To close: #10294. Signed off by Nick @ Beeper.
2022-07-18Update expected DB query count when creating a room (#13307)Andrew Morgan2-2/+3
2022-07-18Don't pull out the full state when creating an event (#13281)Erik Johnston3-2/+10
2022-07-17Remove unnecessary `json.dumps` from tests (#13303)Dirk Klimpel13-200/+143
2022-07-17Make all `process_replication_rows` methods async (#13304)Nick Mills-Barrett14-25/+40
More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
2022-07-15Use HTTPStatus constants in place of literals in tests. (#13297)Dirk Klimpel9-238/+308
2022-07-15Provide more info why we don't have any thumbnails to serve (#13038)Eric Eastwood4-17/+129
Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
2022-07-15Use and recommend poetry 1.1.14, up from 1.1.12 (#13285)David Robertson5-4/+30
2022-07-15Don't pull out the full state when storing state (#13274)Erik Johnston6-71/+132
2022-07-15Use a real room in the notification rotation tests. (#13260)Patrick Cloke2-116/+80
Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
2022-07-15Use state before join to determine if we `_should_perform_remote_join` (#13270)David Robertson4-24/+35
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-07-15Update locked frozendict version to 2.3.2 (#13284)Sean Quah2-18/+19
`frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-07-15Bg update to populate new `events` table columns (#13215)Richard van der Hoff3-0/+135
These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
2022-07-15Fix a bug which could lead to incorrect state (#13278)Erik Johnston4-7/+58
There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
2022-07-15Docker: copy postgres from base image (#13279)Richard van der Hoff3-34/+51
When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.
2022-07-15Async get event cache prep (#13242)Nick Mills-Barrett11-26/+86
Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
2022-07-15Federation Sender & Appservice Pusher Stream Optimisations (#13251)Nick Mills-Barrett7-87/+60
* Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
2022-07-14Rip out auth-event reconciliation code (#12943)Richard van der Hoff6-375/+88
There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
2022-07-14CHANGES.md: fix link to upgrade notesRichard van der Hoff1-1/+1
2022-07-14Don't pull out state in `compute_event_context` for unconflicted state (#13267)Erik Johnston7-136/+95
2022-07-13Allow rate limiters to passively record actions they cannot limit (#13253)David Robertson3-12/+157
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-07-13Notifier: accept callbacks to fire on room joins (#13254)David Robertson2-0/+19
2022-07-13Call the v2 identity service `/3pid/unbind` endpoint, rather than v1. (#13240)Jacek Kuśnierz2-2/+3
* Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
2022-07-13Add support for room version 10 (#13220)Shay4-1/+100
2022-07-13Document advising against publicly exposing the Admin API and provide a ↵jejo862-0/+18
usage example (#13231) * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
2022-07-13Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett4-19/+78
2022-07-13Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke3-44/+33
2022-07-13Add prometheus counters for content types other than events (#13175)Brad Murray2-0/+15
2022-07-13Drop unused tables from groups/communities. (#12967)Patrick Cloke4-19/+36
These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
2022-07-13Do not fail build if complement with workers fails. (#13266)Patrick Cloke2-3/+25
2022-07-13Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston3-0/+37
(#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
2022-07-12Inline URL preview documentation. (#13261)Patrick Cloke7-74/+62
Inline URL preview documentation near the implementation.
2022-07-12Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2-0/+18
This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
2022-07-12Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz3-26/+11
`id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
2022-07-12Rename test case method to `add_hashes_and_signatures_from_other_server` ↵David Robertson7-18/+14
(#13255)
2022-07-12Drop support for delegating email validation (#13192)Richard van der Hoff13-253/+110
* Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
2022-07-12Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2-0/+2
The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
2022-07-12Add info about configuration in the url preview docs (#13233)Shay2-0/+3
Cross-link doc pages for easier navigation.
2022-07-12Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2-2/+9
token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
2022-07-12expose whether a room is a space in the Admin API (#13208)andrew do4-13/+36
2022-07-12Update changelog once more v1.63.0rc1Sean Quah1-2/+2
2022-07-12Reorder and tidy up changelogSean Quah1-29/+25
2022-07-121.63.0rc1Sean Quah54-54/+87
2022-07-11Don't pull out the full state when calculating push actions (#13078)Erik Johnston7-344/+164
2022-07-11Add a sample bash script to docs for creating multiple worker files (#13032)villepeh2-0/+32
Signed-off-by: Ville Petteri Huh.
2022-07-11Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett3-2/+32
Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
2022-07-11Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller12-60/+426
return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-07-11Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2-2/+4
The field name was simply incorrect, leading to errors.
2022-07-11Remove delay when rotating event push actions (#13211)Erik Johnston2-3/+2
We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
2022-07-11Document the 'databases' homeserver config option (#13212)Andrew Morgan2-0/+93
2022-07-11Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston3-138/+400
2022-07-11Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2-1/+4
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
2022-07-11Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2-1/+5
2022-07-08editorconfig: add max_line_length for Python files (#13228)Sumner Evans2-0/+2
See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>
2022-07-08Fix notification count after a highlighted message (#13223)Erik Johnston3-3/+16
Fixes #13196 Broke by #13005
2022-07-07Fix exception when using MSC3030 to look for remote federated events before ↵Eric Eastwood2-1/+6
room creation (#13197) Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
2022-07-07Add --build-only option to complement.sh to prevent actually running ↵reivilibre2-3/+19
Complement. (#13158)
2022-07-07Remove obsolete RoomEventsStoreTestCase (#13200)Petr Vaněk2-69/+1
All tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b3c508 - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
2022-07-07Faster room joins: fix race in recalculation of current room state (#13151)Sean Quah8-55/+214
Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-07-07Use a single query in `ProfileHandler.get_profile` (#13209)Nick Mills-Barrett2-12/+8
2022-07-07Bump lxml from 4.8.0 to 4.9.1 (#13207)dependabot[bot]2-62/+72
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
2022-07-07Check that `auto_vacuum` is disabled when porting a SQLite database to ↵reivilibre3-0/+43
Postgres, as `VACUUM`s must not be performed between runs of the script. (#13195)
2022-07-07Make `_get_state_map_for_room` not break when room state events don't ↵David Teller2-8/+2
contain an event id. (#13174) Method `_get_state_map_for_room` seems to break in presence of some ill-formed events in the database. Reimplementing this method to use `get_current_state`, which is more robust to such events.
2022-07-06Add information on how the Synapse team does reviews. (#13132)Patrick Cloke4-1/+47
2022-07-06Fix bug where we failed to delete old push actions (#13194)Erik Johnston2-2/+5
This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.
2022-07-05Handle race between persisting an event and un-partial stating a room (#13100)Sean Quah10-74/+234
Whenever we want to persist an event, we first compute an event context, which includes the state at the event and a flag indicating whether the state is partial. After a lot of processing, we finally try to store the event in the database, which can fail for partial state events when the containing room has been un-partial stated in the meantime. We detect the race as a foreign key constraint failure in the data store layer and turn it into a special `PartialStateConflictError` exception, which makes its way up to the method in which we computed the event context. To make things difficult, the exception needs to cross a replication request: `/fed_send_events` for events coming over federation and `/send_event` for events from clients. We transport the `PartialStateConflictError` as a `409 Conflict` over replication and turn `409`s back into `PartialStateConflictError`s on the worker making the request. All client events go through `EventCreationHandler.handle_new_client_event`, which is called in *a lot* of places. Instead of trying to update all the code which creates client events, we turn the `PartialStateConflictError` into a `429 Too Many Requests` in `EventCreationHandler.handle_new_client_event` and hope that clients take it as a hint to retry their request. On the federation event side, there are 7 places which compute event contexts. 4 of them use outlier event contexts: `FederationEventHandler._auth_and_persist_outliers_inner`, `FederationHandler.do_knock`, `FederationHandler.on_invite_request` and `FederationHandler.do_remotely_reject_invite`. These events won't have the partial state flag, so we do not need to do anything for then. The remaining 3 paths which create events are `FederationEventHandler.process_remote_join`, `FederationEventHandler.on_send_membership_event` and `FederationEventHandler._process_received_pdu`. We can't experience the race in `process_remote_join`, unless we're handling an additional join into a partial state room, which currently blocks, so we make no attempt to handle it correctly. `on_send_membership_event` is only called by `FederationServer._on_send_membership_event`, so we catch the `PartialStateConflictError` there and retry just once. `_process_received_pdu` is called by `on_receive_pdu` for incoming events and `_process_pulled_event` for backfill. The latter should never try to persist partial state events, so we ignore it. We catch the `PartialStateConflictError` in `on_receive_pdu` and retry just once. Refering to the graph of code paths in https://github.com/matrix-org/synapse/issues/12988#issuecomment-1156857648 may make the above make more sense. Signed-off-by: Sean Quah <seanq@matrix.org>
2022-07-05Type `tests.utils` (#13028)David Robertson5-46/+102
* Cast to postgres types when handling postgres db * Remove unused method * Easy annotations * Annotate create_room * Use `ParamSpec` to annotate looping_call * Annotate `default_config` * Track `now` as a float `time_ms` returns an int like the proper Synapse `Clock` * Introduce a `Timer` dataclass * Introduce a Looper type * Suppress checking of a mock * tests.utils is typed * Changelog * Whoops, import ParamSpec from typing_extensions * ditch the psycopg2 casts
2022-07-05Factor out some common Complement CI setup commands to a script. (#13157)reivilibre4-47/+42
2022-07-05Use upserts for updating `event_push_summary` (#13153)Erik Johnston2-40/+8
2022-07-05Fix application service not being able to join remote federated room without ↵Eric Eastwood2-9/+24
a profile set (#13131) Fix https://github.com/matrix-org/synapse/issues/4778 Complement tests: https://github.com/matrix-org/complement/pull/399
2022-07-05Mention the spamchecker plugins v1.62.0David Robertson1-0/+2
2022-07-051.62.0David Robertson3-1/+13
2022-07-05Add the ability to set the log level using the `SYNAPSE_TEST_LOG_LEVEL` ↵reivilibre6-6/+44
environment when using `complement.sh`. (#13152)
2022-07-05Add missing links to config options (#13166)Dirk Klimpel2-3/+4
2022-07-04annotate tests.server.FakeChannel (#13136)David Robertson7-26/+36
2022-07-04Revert "Up the dependency on canonicaljson to ^1.5.0"Brendan Abolivier1-3/+1
This reverts commit dcc4e0621cc101271efc573600bd7591a12cea7c.
2022-07-04Up the dependency on canonicaljson to ^1.5.0Brendan Abolivier1-1/+3
2022-07-04Update changelog for v1.62.0rc2 v1.62.0rc3Andrew Morgan1-2/+2
2022-07-041.62.0rc3Andrew Morgan5-3/+17
2022-07-04Fix stuck notification counts on small servers (#13168)Erik Johnston3-7/+13
2022-07-04Remove tests/utils.py from mypy's exclude list (#13159)Andrew Morgan4-4/+3