summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Add some cross references to worker documentation (#13974)Dirk Klimpel2022-09-301-0/+1
| | | | Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* Fix performance regression in `get_users_in_room` (#13972)Erik Johnston2022-09-301-0/+1
| | | | | Fixes #13942. Introduced in #13575. Basically, let's only get the ordered set of hosts out of the DB if we need an ordered set of hosts. Since we split the function up the caching won't be as good, but I think it will still be fine as e.g. multiple backfill requests for the same room will hit the cache.
* Fix overflows in /messages backfill calculation (#13936)David Robertson2022-09-301-0/+1
| | | | | | | | * Reproduce bug * Compute `least_function` first * Substitute `least_function` with an f-string * Bugfix: avoid overflow Co-authored-by: Eric Eastwood <erice@element.io>
* Add missing version information in the ModuleApi (#13947)Brendan Abolivier2022-09-301-0/+1
|
* Don't require `setuptools_rust` at runtime (#13952)David Robertson2022-09-291-0/+1
|
* Update UPSERT comment now that native upserts are the default (#13924)David Robertson2022-09-291-0/+1
|
* Implement push rule evaluation in Rust. (#13838)Erik Johnston2022-09-291-0/+1
|
* Optimise get_rooms_for_user (drop with_stream_ordering) (#13787)Nick Mills-Barrett2022-09-291-0/+1
|
* Allow admins to require a manual approval process before new accounts can be ↵Brendan Abolivier2022-09-291-0/+1
| | | | used (using MSC3866) (#13556)
* Explicit cast to enforce type hints. (#13939)Patrick Cloke2022-09-291-0/+1
|
* Expose MSC3882 only be under an unstable endpoint. (#13868)Hugh Nimmo-Smith2022-09-291-0/+1
|
* Clarify that a method returns only unthreaded receipts. (#13937)Patrick Cloke2022-09-291-0/+1
| | | | | By renaming it and updating the docstring. Additionally, refactors a method which is used only by tests.
* Always send default and rule_id to clients (#13904)Nicolas Werner2022-09-291-0/+1
|
* Improve backfill robustness by trying more servers. (#13890)reivilibre2022-09-291-0/+1
| | | Co-authored-by: Eric Eastwood <erice@element.io>
* Handle local device list updates during partial join (#13934)Erik Johnston2022-09-281-0/+1
|
* Limit and filter the number of backfill points to get from the database (#13879)Eric Eastwood2022-09-281-0/+1
| | | | | | | | | There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history. Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time 🤷. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place. Part of https://github.com/matrix-org/synapse/issues/13356
* Add upgrade notes for changes to receipts replication. (#13932)Patrick Cloke2022-09-281-0/+1
|
* Revert "Stop returning an unused column when handling new receipts. ↵Patrick Cloke2022-09-281-1/+0
| | | | | | | (#13933)" (#13935) This reverts commit 7766bd5b354cd4ea1a33351ba320e54a14d3aeac (#13933). The unused column is actually used, but much further down in the function.
* Stop returning an unused column when handling new receipts. (#13933)Patrick Cloke2022-09-281-0/+1
|
* Document that the 'auto_join_rooms' option works with Spaces (#13931)Andrew Morgan2022-09-281-0/+1
|
* Correct default number of bcrypt hash rounds in .1 man page (#13930)Andrew Morgan2022-09-281-0/+1
|
* Handle remote device list updates during partial join (#13913)Erik Johnston2022-09-281-0/+1
| | | | | | | c.f. #12993 (comment), point 3 This stores all device list updates that we receive while partial joins are ongoing, and processes them once we have the full state. Note: We don't actually process the device lists in the same ways as if we weren't partially joined. Instead of updating the device list remote cache, we simply notify local users that a change in the remote user's devices has happened. I think this is safe as if the local user requests the keys for the remote user and we don't have them we'll simply fetch them as normal.
* fix: Push notifications for invite over federation (#13719)Kateřina Churanová2022-09-281-0/+1
|
* Add instruction for running unit tests in parallel (#13928)Ashish Kumar2022-09-281-0/+1
|
* Persist CreateRoom events to DB in a batch (#13800)Shay2022-09-281-0/+1
|
* Prepatory work for batching events to send (#13487)Shay2022-09-281-0/+1
| | | This PR begins work on batching up events during the creation of a room. The PR splits out the creation and sending/persisting of the events. The first three events in the creation of the room-creating the room, joining the creator to the room, and the power levels event are sent sequentially, while the subsequent events are created and collected to be sent at the end of the function. This is currently done by appending them to a list and then iterating over the list to send, the next step (after this PR) would be to send and persist the collected events as a batch.
* Fix `have_seen_event` cache not being invalidated (#13863)Eric Eastwood2022-09-271-0/+1
| | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/13856 Fix https://github.com/matrix-org/synapse/issues/13865 > Discovered while trying to make Synapse fast enough for [this MSC2716 test for importing many batches](https://github.com/matrix-org/complement/pull/214#discussion_r741678240). As an example, disabling the `have_seen_event` cache saves 10 seconds for each `/messages` request in that MSC2716 Complement test because we're not making as many federation requests for `/state` (speeding up `have_seen_event` itself is related to https://github.com/matrix-org/synapse/issues/13625) > > But this will also make `/messages` faster in general so we can include it in the [faster `/messages` milestone](https://github.com/matrix-org/synapse/milestone/11). > > *-- https://github.com/matrix-org/synapse/issues/13856* ### The problem `_invalidate_caches_for_event` doesn't run in monolith mode which means we never even tried to clear the `have_seen_event` and other caches. And even in worker mode, it only runs on the workers, not the master (AFAICT). Additionally there was bug with the key being wrong so `_invalidate_caches_for_event` never invalidates the `have_seen_event` cache even when it does run. Because we were using the `@cachedList` wrong, it was putting items in the cache under keys like `((room_id, event_id),)` with a `set` in a `set` (ex. `(('!TnCIJPKzdQdUlIyXdQ:test', '$Iu0eqEBN7qcyF1S9B3oNB3I91v2o5YOgRNPwi_78s-k'),)`) and we we're trying to invalidate with just `(room_id, event_id)` which did nothing.
* Emphasize the right reasons to use `(room_id, event_id)` in a schema (#13915)Eric Eastwood2022-09-271-0/+1
| | | | | | | * Emphasize the right reasons to use (room_id, event_id) Follow-up to: - https://github.com/matrix-org/synapse/pull/13701 - https://github.com/matrix-org/synapse/pull/13771
* Add new columns tracking when we partial-joined (#13892)David Robertson2022-09-271-0/+1
|
* Support the stable dir parameter for /relations. (#13920)Patrick Cloke2022-09-271-0/+1
| | | | | | | Since MSC3715 has passed FCP, the stable parameter can be used. This currently falls back to the unstable parameter if the stable parameter is not provided (and MSC3715 support is enabled in the configuration).
* Prioritize outbound to-device over device list updates (#13922)Erik Johnston2022-09-271-0/+1
| | | Otherwise device list changes for large accounts can temporarily delay to-device messages.
* Dockerfile for tests: align comments with current behavior (#13867)Mathieu Velten2022-09-271-0/+1
| | | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Carry IdP Session IDs through user-mapping sessions. (#13839)Quentin Gliech2022-09-271-0/+1
| | | Since #11482, we're saving sessions IDs from upstream IdPs, but we've been losing them when the user goes through a user mapping session on account registration.
* Handle the case of remote users leaving a partial join room for device lists ↵Erik Johnston2022-09-271-0/+1
| | | | (#13885)
* Faster room joins: Fix spurious error when joining a room (#13872)Sean Quah2022-09-271-0/+1
| | | | | | | | | | | | | | | | During a `lazy_load_members` `/sync`, we look through auth events in rooms with partial state to find prior membership events. When such a membership is not found, an error is logged. Since the first join event for a user never has a prior membership event to cite, the error would always be logged when one appeared in the room timeline. Avoid logging errors for such events. Introduced in #13477. Signed-off-by: Sean Quah <seanq@matrix.org>
* Complement image: propagate SIGTERM to all workers (#13914)Richard van der Hoff2022-09-261-0/+1
| | | | | | | | | | This should mean that logs from worker processes are flushed before shutdown. When a test completes, Complement stops the docker container, which means that synapse will receive a SIGTERM. Currently, the `complement_fork_starter` exits immediately (without notifying the worker processes), which means that the workers never get a chance to flush their logs before the whole container is vaped. We can fix this by propagating the SIGTERM to the children.
* Improve tests for get_unread_push_actions_for_user_in_range_*. (#13893)Patrick Cloke2022-09-261-0/+1
| | | | | * Adds a docstring. * Reduces a small amount of duplicated code. * Improves tests.
* Update the manpage documentation for the hash_password script (#13911)Andrew Morgan2022-09-261-0/+1
|
* Snapshot schema 72 (#13873)David Robertson2022-09-261-0/+1
| | | Including another batch of fixes to the schema dump script
* typing: check origin server of typing event against room's servers (#13830)Mathieu Velten2022-09-261-0/+1
| | | | | | | This is also using the partial state approximation if needed so we do not block here during a fast join. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Simplify cache invalidation after event persist txn (#13796)Nick Mills-Barrett2022-09-261-0/+1
| | | | | This moves all the invalidations into a single place and de-duplicates the code involved in invalidating caches for a given event by using the base class method.
* Update NixOS module URL (#13818)enterprisey2022-09-261-0/+1
| | | | | * Update NixOS module URL * Create 13818.doc
* Correctly add Cargo.lock to sdsit (#13909)Erik Johnston2022-09-261-0/+1
|
* Fix mypy errors with latest canonicaljson (#13905)David Robertson2022-09-261-0/+1
| | | | | | | | | | | | | | | | * Lockfile: update canonicaljson 1.6.0 -> 1.6.3 * Fix mypy errors with latest canonicaljson The change to `_encode_json_bytes` definition wasn't sufficient: ``` synapse/http/server.py:751: error: Incompatible types in assignment (expression has type "Callable[[Arg(object, 'json_object')], bytes]", variable has type "Callable[[Arg(object, 'data')], bytes]") [assignment] ``` Which I think is mypy warning us that the two functions accept different sets of kwargs. Fair enough! * Changelog
* Only try to backfill event if we haven't tried before recently (#13635)Eric Eastwood2022-09-231-0/+1
| | | | | | | | | | Only try to backfill event if we haven't tried before recently (exponential backoff). No need to keep trying the same backfill point that fails over and over. Fix https://github.com/matrix-org/synapse/issues/13622 Fix https://github.com/matrix-org/synapse/issues/8451 Follow-up to https://github.com/matrix-org/synapse/pull/13589 Part of https://github.com/matrix-org/synapse/issues/13356
* Faster room joins: Avoid blocking `/keys/changes` (#13888)Sean Quah2022-09-231-0/+1
| | | | | | | | | Part of the work for #12993. Once #12993 is fully resolved, we expect `/keys/changes` to behave sensibly when joined to a room with partial state. Signed-off-by: Sean Quah <seanq@matrix.org>
* Fix access token leak to logs from proxyagent (#13855)Eric Eastwood2022-09-231-0/+1
| | | | | | | | | | | | | | | This can happen specifically with an application service `/transactions/10722?access_token=leaked` request Fix https://github.com/matrix-org/synapse/issues/13010 --- Saw an example leak in https://github.com/matrix-org/synapse/issues/13423#issuecomment-1205348482 ``` 2022-08-04 14:47:57,925 - synapse.http.client - 401 - DEBUG - as-sender-signal-1 - Sending request PUT http://localhost:29328/transactions/10722?access_token=<redacted> 2022-08-04 14:47:57,926 - synapse.http.proxyagent - 223 - DEBUG - as-sender-signal-1 - Requesting b'http://localhost:29328/transactions/10722?access_token=leaked' via <HostnameEndpoint localhost:29328> ```
* Update Cargo.lock file. (#13889)Patrick Cloke2022-09-231-0/+1
|
* Accept & store thread IDs for receipts (implement MSC3771). (#13782)Patrick Cloke2022-09-231-0/+1
| | | | Updates the `/receipts` endpoint and receipt EDU handler to parse a `thread_id` from the body and insert it in the database.
* Send device list updates out to servers in partially joined rooms (#13874)Sean Quah2022-09-231-0/+1
| | | | | | | | | | | Use the provided list of servers in the room from the `/send_join` response, since we will not know which users are in the room. This isn't sufficient to ensure that all remote servers receive the right device list updates, since the `/send_join` response may be inaccurate or we may calculate the membership state of new users in the room incorrectly. Signed-off-by: Sean Quah <seanq@matrix.org>
* Faster Remote Room Joins: tell remote homeservers that we are unable to ↵reivilibre2022-09-231-0/+1
| | | | authorise them if they query a room which has partial state on our server. (#13823)
* Add comments to the Prometheus recording rules to make it clear which set of ↵reivilibre2022-09-231-0/+1
| | | | rules you need for Grafana or Prometheus Console. (#13876)
* Raise issue if complement fails with latest deps (#13859)David Robertson2022-09-221-0/+1
|
* Fix the cross-link from register admin API to config docs. (#13870)Patrick Cloke2022-09-221-0/+1
|
* Properly paginate forward in the /relations API. (#13840)Patrick Cloke2022-09-221-0/+1
| | | | | This fixes a bug where the `/relations` API with `dir=f` would skip the first item of each page (except the first page), causing incomplete data to be returned to the client.
* Last batch of Pydantic for synapse/rest/client/account.py (#13832)David Robertson2022-09-211-0/+1
| | | | | | | * Validation for `/add_threepid/msisdn/submit_token` * Don't validate deprecated endpoint * Changelog
* Add version flag for MSC3881 (#13860)Brendan Abolivier2022-09-211-0/+1
|
* Track device IDs for pushers (#13831)Brendan Abolivier2022-09-211-0/+1
| | | Second half of the MSC3881 implementation
* Implementation of MSC3882 login token request (#13722)Hugh Nimmo-Smith2022-09-211-0/+1
|
* Add `worker_main_http_uri` to the contrib bash script (#13772)villepeh2022-09-211-0/+1
| | | | | | * Add worker_main_http_uri, replace >> with > Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
* Support enabling/disabling pushers (from MSC3881) (#13799)Brendan Abolivier2022-09-211-0/+1
| | | Partial implementation of MSC3881
* Add cache invalidation across workers to module API (#13667)Mathieu Velten2022-09-211-0/+1
| | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* Correct documentation for map_user_attributes of OpenID Mapping Providers ↵Peter Scheu2022-09-211-0/+1
| | | | | (#13836) Co-authored-by: David Robertson <davidr@element.io>
* Improve the `synapse.api.auth.Auth` mock used in unit tests. (#13809)Quentin Gliech2022-09-211-0/+1
| | | To return the proper type (`Requester`) instead of a `dict`.
* Fix the release script not publishing binary wheels. (#13850)reivilibre2022-09-211-0/+1
|
* Merge branch 'release-v1.68' into developOlivier Wilkinson (reivilibre)2022-09-2066-66/+0
|\
| * 1.68.0rc1Olivier Wilkinson (reivilibre)2022-09-2066-66/+0
| |
* | Remove the `complete_sso_login` method from the Module API which was ↵Quentin Gliech2022-09-201-0/+1
| | | | | | | | | | deprecated in Synapse 1.13.0. (#13843) Signed-off-by: Quentin Gliech <quenting@element.io>
* | Generate separate snapshots for logical databases (#13792)David Robertson2022-09-201-0/+1
| | | | | | | | | | | | | | * Generate separate snapshots for sqlite, postgres and common * Cleanup postgres dbs in the TRAP * Say which logical DB we're applying updates to * Run background updates on the state DB * Add new option for accepting a SCHEMA_NUMBER
* | Port the push rule classes to Rust. (#13768)Erik Johnston2022-09-201-0/+1
|/
* Don't include redundant prev_state in new events (#13791)Denis2022-09-201-0/+1
|
* Add support to purge rows from MSC2716 and other tables when purging a room ↵Eric Eastwood2022-09-161-0/+1
| | | | | | | | | | | (#13825) `event_failed_pull_attempts` added in https://github.com/matrix-org/synapse/pull/13589 MSC2716 related tables added in: - https://github.com/matrix-org/synapse/pull/10245/files#diff-3d42dfb44d02f7de3aada105e0bdc1cc9dd7f953cbf0f36c5d0f50827bf0320aR1 - Renamed in https://github.com/matrix-org/synapse/pull/10838/files#diff-2730bfbe9e688b55e46f9371aefe67dac2bd2b2b7d9d6b92774eea1fcfae156dR1 - https://github.com/matrix-org/synapse/pull/10498/files#diff-c52bbfbb5921a3f6f023b24343668479d966fac164f13b7c39d2197ce3afa7a5R1
* Fix Docker build when Rust .so has been build locally first (#13811)Mathieu Velten2022-09-161-0/+1
| | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* Compare ported to unported PG schemas in portdb test job (#13808)David Robertson2022-09-161-0/+1
|
* Minor speedups to CI linting (#13827)David Robertson2022-09-161-0/+1
|
* Remove error spam when users query the keys of departed remote users (#13826)Sean Quah2022-09-161-0/+1
| | | | The error message introduced in #13749 has turned out to be very spammy. Remove it for now.
* complement: init postgres DB directly inside the target image (#13819)Mathieu Velten2022-09-161-0/+1
| | | | | | | Doing so in the base postgres image doesn't work with buildah because changes in a declared VOLUME in the Dockerfile is supposed to be discarded, cf https://docs.docker.com/engine/reference/builder/#volume Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* Add an admin API endpoint to find a user based on its external ID in an auth ↵Quentin Gliech2022-09-161-0/+1
| | | | provider. (#13810)
* Update request log format documentation to mention the format used when the ↵reivilibre2022-09-161-0/+1
| | | | authenticated user is controlling another user. (#13794)
* Avoid putting rejected events in room state (#13723)Sean Quah2022-09-161-0/+1
| | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Document common fix of Poetry problems by removing egg-info (#13785)Eric Eastwood2022-09-151-0/+1
| | | | | `matrix_synapse.egg-info/` Mentioned at https://matrix.to/#/!vcyiEtMVHIhWXcJAfl:sw1v.org/$aKy_IjrKwb70aTVZWeW_6zt0k7OIZ1YkyZpkP9uiRaM?via=matrix.org&via=element.io&via=beeper.com and many other places.
* Be able to correlate timeouts in reverse-proxy layer in front of Synapse ↵Eric Eastwood2022-09-151-0/+1
| | | | | | | | | | | | | | | | | | (pull request ID from header) (#13801) Fix https://github.com/matrix-org/synapse/issues/13685 New config: ```diff listeners: - port: 8008 tls: false type: http x_forwarded: true + request_id_header: "cf-ray" bind_addresses: ['::1', '127.0.0.1', '0.0.0.0'] ```
* Record any exception when processing a pulled event (#13814)Eric Eastwood2022-09-152-1/+2
| | | | | Part of https://github.com/matrix-org/synapse/issues/13700 and https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13589
* Support providing an index predicate for upserts. (#13822)Patrick Cloke2022-09-151-0/+1
| | | | This is useful to upsert against a table which has a unique partial index while avoiding conflicts.
* A third batch of Pydantic validation for rest/client/account.py (#13736)David Robertson2022-09-151-0/+1
|
* Add a `MXCUri` class to make working with mxc uri's easier. (#13162)Andrew Morgan2022-09-151-0/+1
|
* Keep track when we try and fail to process a pulled event (#13589)Eric Eastwood2022-09-141-0/+1
| | | | | | | | | | | | | | We can follow-up this PR with: 1. Only try to backfill from an event if we haven't tried recently -> https://github.com/matrix-org/synapse/issues/13622 1. When we decide to backfill that event again, process it in the background so it doesn't block and make `/messages` slow when we know it will probably fail again -> https://github.com/matrix-org/synapse/issues/13623 1. Generally track failures everywhere we try and fail to pull an event over federation -> https://github.com/matrix-org/synapse/issues/13700 Fix https://github.com/matrix-org/synapse/issues/13621 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.qv7cj51sv9i5)
* Update event push action and receipt tables to support threads. (#13753)Patrick Cloke2022-09-141-0/+1
| | | | | | | | | | | | | | | Adds a `thread_id` column to the `event_push_actions`, `event_push_actions_staging`, and `event_push_summary` tables. This will notifications to be segmented by the thread in a future pull request. The `thread_id` column stores the root event ID or the special value `"main"`. The `thread_id` column for `event_push_actions` and `event_push_summary` is backfilled with `"main"` for all existing rows. New entries into `event_push_actions` and `event_push_actions_staging` will get the proper thread ID. `receipts_linearized` and `receipts_graph` also gain a `thread_id` column, which is similar, except `NULL` is a special value meaning the receipt is "unthreaded". See MSC3771 and MSC3773 for where this data will be useful.
* Use partial indices on SQLIte. (#13802)Patrick Cloke2022-09-141-0/+1
| | | | | | | Partial indices have been supported since SQLite 3.8, but Synapse now requires >= 3.27, so we can enable support for them. This requires rebuilding previous indices which were partial on PostgreSQL, but not on SQLite.
* Deduplicate `is_server_notices_room`. (#13780)reivilibre2022-09-141-0/+1
|
* Fix a memory leak when running the unit tests. (#13798)reivilibre2022-09-141-0/+1
|
* Remove unused method in `synapse.api.auth.Auth`. (#13795)Quentin Gliech2022-09-141-0/+1
| | | | | Clean-up from b19060a29b4f73897847db2aba5d03ec819086e0 (#13094) and 73af10f419346a5f2d70131ac1ed8e69942edca0 (#13093) which removed all callers.
* Remove incorrect migration file from `state` logical DB (#13788)David Robertson2022-09-141-0/+1
| | | | | | | | | | | | | * Remove incorrect migration file from `state` logical DB The table `ex_outlier_stream` is part of the `main` logical DB; it should not have been created in the `state` logical DB. We remove this migration now as a tidy-up. Note: we cannot `DROP TABLE IF EXISTS ex_outlier_stream` in a new migration, because some (most) instances of Synapse host both of these logical DBs on the same DB cluster. * Changelog
* Fix bug in device list caching when remote users leave rooms (#13749)Sean Quah2022-09-141-0/+1
| | | | | | | | | | | | When a remote user leaves the last room shared with the homeserver, we have to mark their device list as unsubscribed, otherwise we would hold on to a stale device list in our cache. Crucially, the device list would remain cached even after the remote user rejoined the room, which could lead to E2EE failures until the next change to the remote user's device list. Fixes #13651. Signed-off-by: Sean Quah <seanq@matrix.org>
* Fix a long-standing spec compliance bug where Synapse would accept a ↵reivilibre2022-09-141-0/+1
| | | | | | | | | | | trailing slash on the end of `/get_missing_events` federation requests. (#13789) * Don't accept a trailing slash on the end of /get_missing_events * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Make sequence `cache_invalidation_stream_seq` begin at `2` (#13766)Mathieu Velten2022-09-131-0/+1
| | | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Merge branch 'master' into developErik Johnston2022-09-1353-53/+0
|\
| * 1.67.0rc1Erik Johnston2022-09-0653-53/+0
| |
* | Updates to the schema dump script (#13770)David Robertson2022-09-131-0/+1
| |
* | Simplify CI tests DAG (#13784)David Robertson2022-09-131-0/+1
| | | | | | | | | | * Simplify CI tests DAG * Changelog
* | installation.md: require libpq on M1 macs (#13480)Richard van der Hoff2022-09-131-0/+1
| |
* | Add receipts event stream ordering (#13703)Nick Mills-Barrett2022-09-131-0/+1
| |
* | Fix GHA skippable syntax (#13778)Mathieu Velten2022-09-121-0/+1
| | | | | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* | Fix typo in ratelimiting documentation (#13727)Brendan Abolivier2022-09-121-0/+1
| |
* | Fix CI on non-PR builds (#13769)Erik Johnston2022-09-121-0/+1
| | | | | | Mark cargo-test as skippable since it only runs on Rust code change.
* | Remove check current state membership up to date (#13745)Nick Mills-Barrett2022-09-121-0/+1
| | | | | | | | | | | | | | * Remove checks for membership column in current_state_events * Add schema script to force through the `current_state_events_membership` background job Contributed by Nick @ Beeper (@fizzadar).
* | Check if Rust lib needs rebuilding. (#13759)Erik Johnston2022-09-121-0/+1
| | | | | | This protects against the common mistake of failing to remember to rebuild Rust code after making changes.
* | Concurrently collect room unread counts for push badges (#13765)Nick Mills-Barrett2022-09-091-0/+1
| | | | | | | | | | | | | | Most of the time this function is heavily cached, but when that isn't the case fetching the counts room by room slows down push delivery on users with many (thousands) of rooms. Signed off by Nick @ Beeper.
* | Tag trace with instance name (#13761)Eric Eastwood2022-09-091-0/+1
| | | | | | | | | | | | | | | | We tag the Synapse instance name so that it's an easy jumping off point into the logs. Can also be used to filter for an instance that is under load. As suggested by @clokep and @reivilibre in, - https://github.com/matrix-org/synapse/pull/13729#discussion_r964719258 - https://github.com/matrix-org/synapse/pull/13729#discussion_r964733578
* | Strip number suffix from instance name to consolidate services that traces ↵Eric Eastwood2022-09-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | are spread over (#13729) The problem with many services is that it makes it hard to find which service has the trace you want, see https://github.com/jaegertracing/jaeger-ui/issues/985 Previously, we split traces out into services based on their instance name like `matrix.org client_reader-1`, etc but there are many worker instances of the same `client_reader` so there is a lot to click through. With this PR, all of the traces are just collected under the worker type like `client_reader`, `event_persister` 😇 Note: A Synapse worker instance name is an opaque string with the number convention only being our own thing for the `matrix.org` deployment. But seems pretty sensible to group things this way.
* | Use an upsert for `receipts_graph`. (#13752)Patrick Cloke2022-09-091-0/+1
| | | | | | | | | | | | Instead of a delete, then insert. This was previously done for `receipts_linearized` in 2dc430d36ef793b38d6d79ec8db4ea60588df2ee (#7607).
* | Add rust to CI (#13763)Erik Johnston2022-09-091-0/+1
| |
* | Require SQLite >= 3.27.0 (#13760)David Robertson2022-09-091-0/+1
| |
* | Re-type hint some collections in `/sync` code as read-only (#13754)Sean Quah2022-09-081-0/+1
| | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | Remove unused Prometheus recording rules from `synapse-v2.rules` and add ↵reivilibre2022-09-081-0/+1
| | | | | | | | comments describing where the rest are used. (#13756)
* | Add timestamp to user's consent (#13741)Dirk Klimpel2022-09-081-0/+1
| | | | | | Co-authored-by: reivilibre <olivier@librepush.net>
* | Update docstrings to explain the impact of partial state (#13750)Sean Quah2022-09-081-0/+1
| | | | | | | | | | | | | | Update the docstrings for `get_users_in_room` and `get_current_hosts_in_room` to explain the impact of partial state. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Avoid raising errors due to malformed IDs in `get_current_hosts_in_room` ↵Sean Quah2022-09-081-0/+1
| | | | | | | | | | | | | | | | | | | | (#13748) Handle malformed user IDs with no colons in `get_current_hosts_in_room`. It's not currently possible for a malformed user ID to join a room, so this error would never be hit. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Fix error in `is_mine_id` when encountering a malformed ID (#13746)Sean Quah2022-09-081-0/+1
| | | | | | | | | | | | | | | | | | Previously, `is_mine_id` would raise an exception when passed an ID with no colons. Return `False` instead. Fixes #13040. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Fix cache metrics not being updated when not using the legacy exposition ↵reivilibre2022-09-081-0/+1
| | | | | | | | module. (#13717)
* | Fix Prometheus recording rules to not use legacy metric names. (#13718)reivilibre2022-09-081-0/+1
| |
* | Fix latest deps (#13743)Erik Johnston2022-09-081-0/+1
| |
* | Fix a bug where Synapse fails to start if a signing key file contains an ↵reivilibre2022-09-081-0/+1
| | | | | | | | empty line. (#13738)
* | Instrument `get_metadata_for_events` for tracing (#13730)Eric Eastwood2022-09-071-0/+1
| | | | | | | | When backfilling, `_get_state_ids_after_missing_prev_event` calls [`get_metadata_for_events`](https://github.com/matrix-org/synapse/blob/26bc26586b4b95d63ce7e453e9312469843f796e/synapse/handlers/federation_event.py#L1133). For `#matrix:matrix.org`, it's called with 77k `state_events` which means 77 calls to the database and takes 28 seconds.
* | Fix latest deps CI (#13734)Erik Johnston2022-09-071-0/+1
| |
* | Add some rust caching to CI (#13735)Erik Johnston2022-09-071-0/+1
| |
* | Correct out-of-date doc for `event_cache_size` (#13726)David Robertson2022-09-071-0/+1
| |
* | Define SQLite compat policy (#13728)David Robertson2022-09-071-0/+1
| |
* | A second batch of Pydantic models for rest/client/account.py (#13687)David Robertson2022-09-071-0/+1
| |
* | Cancel the processing of key query requests when they time out. (#13680)reivilibre2022-09-071-0/+1
| |
* | Rename the `EventFormatVersions` enum values so that they line up with room ↵reivilibre2022-09-071-0/+1
| | | | | | | | version numbers. (#13706)
* | Add Admin API to Fetch Messages Within a Particular Window (#13672)Connor Davis2022-09-071-0/+1
| | | | | | This adds two new admin APIs that allow us to fetch messages from a room within a particular time.
* | Remove the unspecced room_id field in the /hierarchy response. (#13506)reivilibre2022-09-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | This is a re-do of 57d334a13d983406ea452dfa203bbe4837509c4e (#13365), which was backed out in 12abd724974a2311d5311272d26d2f8aa11734a9 (#13501). The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
* | Add a stub Rust crate (#12595)Erik Johnston2022-09-061-0/+1
| |
* | Fix trial-olddeps (#13725)Erik Johnston2022-09-061-0/+1
| |
* | Actually fix typechecking with latest types-jsonschema (#13724)David Robertson2022-09-061-0/+1
| |
* | Update trial old deps CI to use poetry 1.2.0 (#13707)Erik Johnston2022-09-061-0/+1
| |
* | Update Grafana dashboard to not use legacy metric names. (#13714)reivilibre2022-09-061-0/+1
|/
* Remove configuration options for direct TCP replication. (#13647)Patrick Cloke2022-09-061-0/+1
| | | Removes the ability to configure legacy direct TCP replication. Workers now require Redis to run.
* Reduce number of CI jobs run on PRs (#13713)Erik Johnston2022-09-051-0/+1
| | | | | | | | | | | | | * Reduce number of CI jobs run on PRs * Newsfile * Also limit sytest jobs * Fix typo * Fix up * Fixup
* Extend the release script to wait for GitHub Actions to finish and to be ↵reivilibre2022-09-051-0/+1
| | | | usable as a guide for the whole process. (#13483)
* Fix typechecking with latest `types-jsonschema` (#13712)David Robertson2022-09-051-0/+1
|
* Share some metrics between the Prometheus exporter and the phone home stats ↵Brendan Abolivier2022-09-051-0/+1
| | | | (#13671)
* Clarify `(room_id, event_id)` global uniqueness (#13701)Eric Eastwood2022-09-021-0/+1
| | | Summarized from @richvdh's reply at https://github.com/matrix-org/synapse/pull/13589#discussion_r961116999
* Update docs to make enabling metrics more clear (#13678)Eric Eastwood2022-09-021-0/+1
| | | It was really easy to miss the `enable_metrics: True` step with the previous language.
* Update lock file for Poetry v1.2.0 (#13689)Erik Johnston2022-09-021-0/+1
|
* Only run trial CI on all python versions on non-PRs (#13698)Erik Johnston2022-09-021-0/+1
|
* Fix two typos with colon in headlines (#13665)Dirk Klimpel2022-09-011-0/+1
|
* Add a schema delta to drop unstable private read receipts. (#13692)Patrick Cloke2022-09-011-0/+1
| | | | Otherwise they'll be leaked due to the filtering code only respecting the stable identifiers for private read receipts.
* Disable calculating unread counts unless the config flag is enabled. (#13694)Patrick Cloke2022-09-011-0/+1
| | | | | | | | This avoids doing work that will never be used (since the resulting unread counts will never be sent in a /sync response). The negative of doing this is that unread counts will be incorrect when the feature is initially enabled.
* Update the Grafana dashboard that is included with Synapse in the `contrib` ↵reivilibre2022-09-011-0/+1
| | | | | | | | | | | | | directory. (#13697) * Add missing graph to contrib * Update with minor but plausible changes, including positioning changes * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Cache `is_partial_state_room` (#13693)Erik Johnston2022-09-011-0/+1
| | | Fixes #13613.
* Add monthly active users documentation (#13617)Will Hunt2022-09-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add monthly active users documentation * changelog * Tidy up notes * more tidyup * Rewrite #1 * link back to mau docs * fix links * s/appservice|AS/application service * further review * a newline * Remove bit about shadow banned users. I think talking about them is confusing, and the current text doesn't imply they get any special treatment. * Update docs/usage/administration/monthly_active_users.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update docs/usage/administration/monthly_active_users.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add some logging to help track down #13444 (#13679)Erik Johnston2022-09-011-0/+1
|
* Return keys for unwhitelisted servers from `/_matrix/key/v2/query` (#13683)Richard van der Hoff2022-09-011-0/+1
|
* Bump docker image to use stable poetry version (#13688)Erik Johnston2022-09-011-0/+1
|
* Remove support for unstable private read receipts (#13653)Šimon Brandner2022-09-011-0/+1
| | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Drop support for calling `/_matrix/client/v3/rooms/{roomId}/invite` without ↵Jacek Kuśnierz2022-08-311-0/+1
| | | | | | | an `id_access_token` (#13241) Fixes #13206 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* Remove cached wrap on `_get_joined_users_from_context` method (#13569)Nick Mills-Barrett2022-08-311-0/+1
| | | | | | | The method doesn't actually do any data fetching and the method that does, `_get_joined_profile_from_event_id`, has its own cache. Signed off by Nick @ Beeper (@Fizzadar).
* Generalise the `@cancellable` annotation so it can be used on functions ↵reivilibre2022-08-311-0/+1
| | | | other than just servlet methods. (#13662)
* Fix admin List Room API return type on sqlite (#13509)David Robertson2022-08-311-0/+1
|
* Give the correct next event when the message timestamps are the same - ↵Eric Eastwood2022-08-301-0/+1
| | | | | | | | | MSC3030 (#13658) Discovered while working on https://github.com/matrix-org/synapse/pull/13589 and I had all the messages at the same timestamp in the tests. Part of https://github.com/matrix-org/matrix-spec-proposals/pull/3030 Complement tests: https://github.com/matrix-org/complement/pull/457
* Drop unused column `application_services_state.last_txn` (#13627)Shay2022-08-301-0/+1
|
* Remove documentation of legacy `frontend_proxy` worker app (#13645)Richard van der Hoff2022-08-301-0/+1
| | | | | This has been the same as a generic_worker since #6964, so let's get rid of it. Fixes #3717
* Clarify documentation about replication traffic. (#13656)Patrick Cloke2022-08-301-0/+1
| | | | It can be authenticated with the worker_replication_secret setting, but is always unencrypted.
* Fix bug where we wedge media plugins if clients disconnect early (#13660)Erik Johnston2022-08-301-0/+1
| | | | | | | | We incorrectly didn't use the returned `Responder` if the client had disconnected, which meant that the resource used by the Responder wasn't correctly released. In particular, this exhausted the thread pools so that *all* requests timed out.
* Do not wait for background updates to complete do expire URL cache. (#13657)Patrick Cloke2022-08-301-0/+1
| | | | | | | | | | | | | | Media downloaded as part of a URL preview is normally deleted after two days. However, while a background database migration is running, the process is stopped. A long-running database migration can therefore cause the media store to fill up with old preview files. This logic was added in #2697 to make sure that we didn't try to run the expiry without an index on `local_media_repository.created_ts`; the original logic that needs that index was added in #2478 (in `get_url_cache_media_before`, as amended by 93247a424a5068b088567fa98b6990e47608b7cb), and is still present. Given that the background update was added before Synapse v1.0.0, just drop this check and assume the index exists.
* Speed up inserting `event_push_actions_staging`. (#13634)Patrick Cloke2022-08-301-0/+1
| | | By using `execute_values` instead of `execute_batch`.
* Fix that user cannot `/forget` rooms after the last member has left (#13546)Dirk Klimpel2022-08-301-0/+1
|
* Optimize how we calculate `likely_domains` during backfill (#13575)Eric Eastwood2022-08-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimize how we calculate `likely_domains` during backfill because I've seen this take 17s in production just to `get_current_state` which is used to `get_domains_from_state` (see case [*2. Loading tons of events* in the `/messages` investigation issue](https://github.com/matrix-org/synapse/issues/13356)). There are 3 ways we currently calculate hosts that are in the room: 1. `get_current_state` -> `get_domains_from_state` - Used in `backfill` to calculate `likely_domains` and `/timestamp_to_event` because it was cargo-culted from `backfill` - This one is being eliminated in favor of `get_current_hosts_in_room` in this PR 🕳 1. `get_current_hosts_in_room` - Used for other federation things like sending read receipts and typing indicators 1. `get_hosts_in_room_at_events` - Used when pushing out events over federation to other servers in the `_process_event_queue_loop` Fix https://github.com/matrix-org/synapse/issues/13626 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh) ### Query performance #### Before The query from `get_current_state` sucks just because we have to get all 80k events. And we see almost the exact same performance locally trying to get all of these events (16s vs 17s): ``` synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 16035.612 ms (00:16.036) synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 4243.237 ms (00:04.243) ``` But what about `get_current_hosts_in_room`: When there is 8M rows in the `current_state_events` table, the previous query in `get_current_hosts_in_room` took 13s from complete freshness (when the events were first added). But takes 930ms after a Postgres restart or 390ms if running back to back to back. ```sh $ psql synapse synapse=# \timing on synapse=# SELECT COUNT(DISTINCT substring(state_key FROM '@[^:]*:(.*)$')) FROM current_state_events WHERE type = 'm.room.member' AND membership = 'join' AND room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 4130 (1 row) Time: 13181.598 ms (00:13.182) synapse=# SELECT COUNT(*) from current_state_events where room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 80814 synapse=# SELECT COUNT(*) from current_state_events; count --------- 8162847 synapse=# SELECT pg_size_pretty( pg_total_relation_size('current_state_events') ); pg_size_pretty ---------------- 4702 MB ``` #### After I'm not sure how long it takes from complete freshness as I only really get that opportunity once (maybe restarting computer but that's cumbersome) and it's not really relevant to normal operating times. Maybe you get closer to the fresh times the more access variability there is so that Postgres caches aren't as exact. Update: The longest I've seen this run for is 6.4s and 4.5s after a computer restart. After a Postgres restart, it takes 330ms and running back to back takes 260ms. ```sh $ psql synapse synapse=# \timing on Timing is on. synapse=# SELECT substring(c.state_key FROM '@[^:]*:(.*)$') as host FROM current_state_events c /* Get the depth of the event from the events table */ INNER JOIN events AS e USING (event_id) WHERE c.type = 'm.room.member' AND c.membership = 'join' AND c.room_id = '!OGEhHVWSdvArJzumhm:matrix.org' GROUP BY host ORDER BY min(e.depth) ASC; Time: 333.800 ms ``` #### Going further To improve things further we could add a `limit` parameter to `get_current_hosts_in_room`. Realistically, we don't need 4k domains to choose from because there is no way we're going to query that many before we a) probably get an answer or b) we give up. Another thing we can do is optimize the query to use a index skip scan: - https://wiki.postgresql.org/wiki/Loose_indexscan - Index Skip Scan, https://commitfest.postgresql.org/37/1741/ - https://www.timescale.com/blog/how-we-made-distinct-queries-up-to-8000x-faster-on-postgresql/
* Print complement failure results last (#13639)Richard van der Hoff2022-08-281-0/+1
| | | | | Since github always scrolls to the bottom of any test output, let's put the failed tests last and hide any successful packages.
* Improve documentation around user registration (#13640)Richard van der Hoff2022-08-261-0/+1
| | | | | Update a bunch of the documentation for user registration, add some cross links, etc.
* Generate missing configuration files at startup (#13615)Richard van der Hoff2022-08-261-0/+1
| | | | | | | | If things like the signing key file are missing, let's just try to generate them on startup. Again, this is useful for k8s-like deployments where we just want to generate keys on the first run.
* Move the execution of the retention purge_jobs to the main worker (#13632)Brad Murray2022-08-261-0/+1
| | | | | Fixes #9927 Signed-off-by: Brad Murray brad@beeper.com
* Support `registration_shared_secret` in a file (#13614)Richard van der Hoff2022-08-251-0/+1
| | | | A new `registration_shared_secret_path` option. This is kinda handy for k8s deployments and things.
* register_new_matrix_user: read server url from config (#13616)Richard van der Hoff2022-08-251-0/+1
| | | | Fixes https://github.com/matrix-org/synapse/issues/3672: `https://localhost:8448` is virtually never right.
* Comment about a better future where we can get the state diff between two ↵Eric Eastwood2022-08-241-0/+1
| | | | | | | | | | events (#13586) Split off from https://github.com/matrix-org/synapse/pull/13561 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh)
* Rename `event_map` to `unpersisted_events` (#13603)David Robertson2022-08-241-0/+1
|
* Update `get_users_in_room` mis-use to get hosts with dedicated ↵Eric Eastwood2022-08-241-0/+1
| | | | | `get_current_hosts_in_room` (#13605) See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
* Directly lookup local membership instead of getting all members in a room ↵Eric Eastwood2022-08-241-0/+1
| | | | | first (`get_users_in_room` mis-use) (#13608) See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
* When loading current ids, sort by `stream_id` to avoid incorrect overwrite ↵Eric Eastwood2022-08-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and avoid errors caused by sorting alphabetical instance name which can be `null` (#13585) When loading current ids, sort by stream ID so that we don't want to overwrite the `current_position` of an instance to a lower stream ID than we're actually at ([discussion](https://github.com/matrix-org/synapse/pull/13585#discussion_r951795379)). Previously, it sorted alphabetically by instance name which can be `null` and throw errors but more importantly, accomplishes nothing. Fixes the following startup error which is why I started looking into this area: ``` $ poetry run synapse_homeserver --config-path homeserver.yaml **************************************************************** Error during initialisation: '<' not supported between instances of 'NoneType' and 'str' There may be more information in the logs. **************************************************************** ``` Somehow my database ended up looking like the following, notice the `instance_name` is `null` in the db, and we can't sort `NoneType` things. Another question is why do we see the `instance_name` as `null` sometimes instead of `master` in monolith mode? ``` $ psql synapse synapse=# SELECT * FROM stream_positions; stream_name | instance_name | stream_id -----------------+---------------+----------- account_data | master | 1242 events | master | 1787 to_device | master | 58 presence_stream | master | 485638 receipts | master | 341 backfill | master | -139106 (6 rows) synapse=# SELECT instance_name, stream_id FROM receipts_linearized; instance_name | stream_id ---------------+----------- | 211 | 3 | 4 | 212 | 213 | 224 | 228 | 164 | 313 | 253 | 38 | 321 | 324 | 189 | 192 | 193 | 194 | 195 | 197 | 198 | 275 | 79 | 339 | 340 | 82 | 341 | 84 | 85 | 91 | 119 ```
* Use dedicated `get_local_users_in_room` to find local users when calculating ↵Eric Eastwood2022-08-241-0/+1
| | | | | | | `join_authorised_via_users_server` of a `/make_join` request (#13606) Use dedicated `get_local_users_in_room` to find local users when calculating `join_authorised_via_users_server` ("the authorising user for joining a restricted room") of a `/make_join` request. Found while working on https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 but it's not related.
* Add experimental configuration option to allow disabling legacy Prometheus ↵reivilibre2022-08-241-0/+1
| | | | | metric names. (#13540) Co-authored-by: David Robertson <davidr@element.io>
* Rewrite get push actions queries (#13597)Nick Mills-Barrett2022-08-241-0/+1
|
* Faster Room Joins: fix `/make_knock` blocking indefinitely when the room in ↵reivilibre2022-08-241-0/+1
| | | | | question is a partial-stated room. (#13583) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child ↵Eric Eastwood2022-08-231-0/+1
| | | | | | | | | concurrent calls (#13588) Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child concurrent calls because I've see `_check_sigs_and_hash_and_fetch` take [10.41s to process 100 events](https://github.com/matrix-org/synapse/issues/13587) Fix https://github.com/matrix-org/synapse/issues/13587 Part of https://github.com/matrix-org/synapse/issues/13356
* Write about the chain cover a little. (#13602)David Robertson2022-08-231-0/+1
| | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Speed up `@cachedList` (#13591)Erik Johnston2022-08-231-0/+1
| | | | | | | | | This speeds things up by ~2x. The vast majority of the time is now spent in `LruCache` moving things around the linked lists. We do this via two things: 1. Don't create a deferred per-key during bulk set operations in `DeferredCache`. Instead, only create them if a subsequent caller asks for the key. 2. Add a bulk lookup API to `DeferredCache` rather than use a loop.
* Fix regression caused by #13573 (#13600)Erik Johnston2022-08-231-0/+1
| | | Broke in #13573.
* Merge tag 'v1.66.0rc1' into developDavid Robertson2022-08-2344-45/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.66.0rc1 (2022-08-23) ============================== This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\#13188](https://github.com/matrix-org/synapse/issues/13188), [\#13563](https://github.com/matrix-org/synapse/issues/13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\#13503](https://github.com/matrix-org/synapse/issues/13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](https://github.com/matrix-org/matrix-spec-proposals/pull/3852). ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](https://github.com/matrix-org/matrix-spec-proposals/pull/2716). ([\#13551](https://github.com/matrix-org/synapse/issues/13551)) - Add support for compression to federation responses. ([\#13537](https://github.com/matrix-org/synapse/issues/13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\#13522](https://github.com/matrix-org/synapse/issues/13522), [\#13547](https://github.com/matrix-org/synapse/issues/13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\#13514](https://github.com/matrix-org/synapse/issues/13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\#13525](https://github.com/matrix-org/synapse/issues/13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\#13566](https://github.com/matrix-org/synapse/issues/13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\#13574](https://github.com/matrix-org/synapse/issues/13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\#13472](https://github.com/matrix-org/synapse/issues/13472)) - Tidy up Synapse's README. ([\#13491](https://github.com/matrix-org/synapse/issues/13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\#13492](https://github.com/matrix-org/synapse/issues/13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\#13497](https://github.com/matrix-org/synapse/issues/13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\#13515](https://github.com/matrix-org/synapse/issues/13515)) - Add missing links in `user_consent` section of configuration manual. ([\#13536](https://github.com/matrix-org/synapse/issues/13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\#13538](https://github.com/matrix-org/synapse/issues/13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\#13459](https://github.com/matrix-org/synapse/issues/13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\#13477](https://github.com/matrix-org/synapse/issues/13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\#13531](https://github.com/matrix-org/synapse/issues/13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\#13453](https://github.com/matrix-org/synapse/issues/13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\#13489](https://github.com/matrix-org/synapse/issues/13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\#13499](https://github.com/matrix-org/synapse/issues/13499), [\#13554](https://github.com/matrix-org/synapse/issues/13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\#13533](https://github.com/matrix-org/synapse/issues/13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\#13534](https://github.com/matrix-org/synapse/issues/13534), [\#13541](https://github.com/matrix-org/synapse/issues/13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\#13535](https://github.com/matrix-org/synapse/issues/13535), [\#13584](https://github.com/matrix-org/synapse/issues/13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\#13544](https://github.com/matrix-org/synapse/issues/13544)) - Update metrics to track `/messages` response time by room size. ([\#13545](https://github.com/matrix-org/synapse/issues/13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\#13024](https://github.com/matrix-org/synapse/issues/13024)) - Clean-up tests for notifications. ([\#13471](https://github.com/matrix-org/synapse/issues/13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\#13474](https://github.com/matrix-org/synapse/issues/13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\#13479](https://github.com/matrix-org/synapse/issues/13479), [\#13488](https://github.com/matrix-org/synapse/issues/13488)) - Add comments about how event push actions are rotated. ([\#13485](https://github.com/matrix-org/synapse/issues/13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\#13493](https://github.com/matrix-org/synapse/issues/13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\#13502](https://github.com/matrix-org/synapse/issues/13502)) - Reduce the number of tests using legacy TCP replication. ([\#13543](https://github.com/matrix-org/synapse/issues/13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\#13558](https://github.com/matrix-org/synapse/issues/13558))
| * Remove manually-added changelog v1.66.0rc1David Robertson2022-08-231-1/+0
| |
| * Drop support for delegating email validation, round 2 (#13596)David Robertson2022-08-231-0/+1
| |
| * 1.66.0rc1David Robertson2022-08-2344-45/+0
| |
* | Speed up fetching large numbers of push rules (#13592)Erik Johnston2022-08-231-0/+1
| |
* | Cache user IDs instead of profile objects (#13573)Nick Mills-Barrett2022-08-231-0/+1
|/ | | The profile objects are never used and increase cache size significantly.
* Fix that sending server notices fail if avatar is `None` (#13566)Dirk Klimpel2022-08-231-0/+1
| | | Indroduced in #11846.
* Fix Prometheus metrics being negative (mixed up start/end) (#13584)Eric Eastwood2022-08-231-0/+1
| | | | | | | Fix: - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244
* `synapse.api.auth.Auth` cleanup: make permission-related methods use ↵Quentin Gliech2022-08-221-0/+1
| | | | | | | | | `Requester` instead of the `UserID` (#13024) Part of #13019 This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it. It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.
* Remove redundant opentracing spans for `/sendToDevice` and `/keys/upload` ↵Andrew Morgan2022-08-221-0/+1
| | | | (#13574)
* MSC2716v4 room version - remove namespace from MSC2716 event content fields ↵Eric Eastwood2022-08-191-0/+1
| | | | | | | | (#13551) Complement PR: https://github.com/matrix-org/complement/pull/450 As suggested in https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r941444525
* Implement MSC3852: Expose `last_seen_user_agent` to users for their own ↵Andrew Morgan2022-08-192-0/+2
| | | | devices; also expose to Admin API (#13549)
* Register homeserver modules when creating test homeserver (#13558)Andrew Morgan2022-08-191-0/+1
|
* Reduce the number of tests using TCP replication. (#13543)Patrick Cloke2022-08-191-0/+1
| | | | Uses Redis replication in additional test cases (instead of TCP replication). A small step towards dropping TCP replication.
* Fix validation problem that occurs when a user tries to deactivate their ↵reivilibre2022-08-191-0/+1
| | | | account or change their password. (#13563)
* Add metrics to track `/messages` response time by room size (#13545)Eric Eastwood2022-08-181-0/+1
| | | | | Follow-up to https://github.com/matrix-org/synapse/pull/13533 Part of https://github.com/matrix-org/synapse/issues/13356
* Fix incorrect juggling of logging contexts in `_PerHostRatelimiter` (#13554)Sean Quah2022-08-181-0/+1
| | | | | | Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Track number of hosts affected by the rate limiter (#13541)Eric Eastwood2022-08-181-0/+1
| | | | | | | Track number of hosts affected by the rate limiter so we can differentiate one really noisy homeserver from a general ratelimit tuning problem across the federation. Follow-up to https://github.com/matrix-org/synapse/pull/13534 Part of https://github.com/matrix-org/synapse/issues/13356
* Add support for compression to federation responses (#13537)Ayush Anand2022-08-181-0/+1
| | | | | | Closes #13415. Signed-off-by: Ayush Anand <iamayushanand@gmail.com>
* Avoid blocking lazy-loading `/sync`s during partial joins (#13477)Sean Quah2022-08-181-0/+1
| | | | | | | | | | | | | | | | | Use a state filter or accept partial state in a few places where we request state, to avoid blocking. To make lazy-loading `/sync`s work, we need to provide the memberships of event senders, which are not guaranteed to be in the room state. Instead we dig through auth events for memberships to present to clients. The auth events of an event are guaranteed to contain a passable membership event, otherwise the event would have been rejected. Note that this only covers the common code paths encountered during testing. There has been no exhaustive checking of all sync code paths. Fixes #13146. Signed-off-by: Sean Quah <seanq@matrix.org>
* Add metrics to track how the rate limiter is affecting requests ↵Eric Eastwood2022-08-171-0/+1
| | | | | | | (sleep/reject) (#13534) Related to https://github.com/matrix-org/synapse/pull/13499 Part of https://github.com/matrix-org/synapse/issues/13356
* Fix a bug in the `/event_reports` Admin API which meant that the total count ↵reivilibre2022-08-171-0/+1
| | | | | could be larger than the number of results you can actually query for. (#13525) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* A first pass at pruning the Synapse README (#13491)David Robertson2022-08-171-0/+1
|
* Fix breaking event sending due to bad push rule (#13547)Erik Johnston2022-08-171-0/+1
| | | | | | | Broke by #13522 It looks like we have some rules in the DB with a priority class less than 0 that don't override the base rules. Before these were just dropped, but #13522 made that a hard error.
* Reject non-strict types in Pydantic models (#13502)David Robertson2022-08-171-0/+1
|
* Fix a typo in docs and in some warnings (#13538)Antonin Loubiere2022-08-171-0/+1
|
* Add forgotten status to Room Details API (#13503)Dirk Klimpel2022-08-171-0/+1
|
* Add metrics to track rate limiter queue timing (#13544)Eric Eastwood2022-08-171-0/+1
|
* Time how long it takes us to do backfill processing (#13535)Eric Eastwood2022-08-171-0/+1
|
* Add specific metric to time long-running `/messages` requests (#13533)Eric Eastwood2022-08-171-0/+1
|
* Instrument the federation/backfill part of `/messages` (#13489)Eric Eastwood2022-08-161-0/+1
| | | | | | | | | Instrument the federation/backfill part of `/messages` so it's easier to follow what's going on in Jaeger when viewing a trace. Split out from https://github.com/matrix-org/synapse/pull/13440 Follow-up from https://github.com/matrix-org/synapse/pull/13368 Part of https://github.com/matrix-org/synapse/issues/13356
* Refuse to start when `faster_joins` is enabled on a worker deployment (#13531)Sean Quah2022-08-161-0/+1
| | | | | | Synapse does not currently support faster room joins on deployments with workers. Signed-off-by: Sean Quah <seanq@matrix.org>
* Add missing links in `user_consent` section of configuration manual (#13536)Dirk Klimpel2022-08-161-0/+1
| | | Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* Faster room joins: make `/joined_members` block whilst the room is partial ↵reivilibre2022-08-161-0/+1
| | | | stated. (#13514)
* Make push rules use proper structures. (#13522)Erik Johnston2022-08-161-0/+1
| | | | | | | | | | | | This improves load times for push rules: | Version | Time per user | Time for 1k users | | -------------------- | ------------- | ----------------- | | Before | 138 µs | 138ms | | Now (with custom) | 2.11 µs | 2.11ms | | Now (without custom) | 49.7 ns | 0.05 ms | This therefore has a large impact on send times for rooms with large numbers of local users in the room.
* Use Pydantic to systematically validate a first batch of endpoints in ↵David Robertson2022-08-151-0/+1
| | | | `synapse.rest.client.account`. (#13188)
* Add a warning to retention documentation regarding the possibility of ↵Shay2022-08-151-0/+2
| | | | database corruption (#13497)
* Instrument `FederationStateIdsServlet` - `/state_ids` (#13499)Eric Eastwood2022-08-151-0/+1
| | | Instrument FederationStateIdsServlet - `/state_ids` so it's easier to follow what's going on in Jaeger when viewing a trace.
* Revert "Update locked versions of mypy and mypy-zope (#13521)"David Robertson2022-08-151-1/+0
| | | | | | | | This reverts commit f383b9b3eceaa082d5ae690550fe41460b711779. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.
* Clarifications for event push action processing. (#13485)Patrick Cloke2022-08-151-0/+1
| | | | | | | | * Clarifies comments. * Fixes an erroneous comment (about return type) added in #13455 (ec24813220f9d54108924dc04aecd24555277b99). * Clarifies the name of a variable. * Simplifies logic of pulling out the latest join for the requesting user.
* Update locked versions of mypy and mypy-zope (#13521)David Robertson2022-08-151-0/+1
|
* Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker ↵reivilibre2022-08-121-0/+1
| | | | image. (#13515)
* Add `openssl` example for registration HMAC (#13472)James Barton2022-08-111-0/+1
| | | Signed-off-by: James Barton <james@neodon.com>
* Add note to `redaction_retention_period` documentation mentioning that event ↵Andrew Morgan2022-08-111-0/+1
| | | | purging runs at most every 5m (#13492)
* Add viewport directive to HTML templates to optimise for mobile (#13493)Germain2022-08-111-0/+1
|
* Update the rejected state of events during resync (#13459)Richard van der Hoff2022-08-111-0/+1
| | | | | Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.
* Use literals in place of `HTTPStatus` constants in tests (#13488)Dirk Klimpel2022-08-101-0/+1
| | | | | | | | | * Use literals in place of `HTTPStatus` constants in tests * newsfile * code style * code style
* Add some miscellaneous comments around sync (#13474)Sean Quah2022-08-101-0/+1
| | | | | | | | Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)Eric Eastwood2022-08-091-0/+1
| | | | | | | | | | | | | ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```
* Use literals in place of `HTTPStatus` constants in tests (#13479)Dirk Klimpel2022-08-091-0/+1
| | | | | | | | | | Replace - `HTTPStatus.NOT_FOUND` - `HTTPStatus.FORBIDDEN` - `HTTPStatus.UNAUTHORIZED` - `HTTPStatus.CONFLICT` - `HTTPStatus.CREATED` Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* Merge branch 'release-v1.65' into developOlivier Wilkinson (reivilibre)2022-08-0949-50/+0
|\
| * 1.65.0rc1Olivier Wilkinson (reivilibre)2022-08-0949-50/+0
| |
* | Strengthen tests about deleted old push actions. (#13471)Patrick Cloke2022-08-091-0/+1
|/
* Make the configuration for the cache clearer (#13481)Dirk Klimpel2022-08-091-0/+1
|
* Update matrix-synapse-ldap3 version in lockfile to v0.2.2. (#13470)Shay2022-08-081-0/+2
|
* Use literals in place of `HTTPStatus` constants in tests (#13469)Dirk Klimpel2022-08-081-0/+1
|
* Correct a misnamed argument in state res v2 (#13467)David Robertson2022-08-081-0/+1
| | | | | | | | | | | In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.
* Support stable identifiers for MSC2285: private read receipts. (#13273)Šimon Brandner2022-08-051-0/+1
| | | | | This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.
* Use literals in place of `HTTPStatus` constants in tests (#13463)Dirk Klimpel2022-08-051-0/+1
|
* Mark token-authenticaticated-registration API as not-experimental (#11897)Julian-Samuel Gebühr2022-08-051-0/+1
|
* Update module API "update room membership" method to allow for remote joins ↵Matt C2022-08-051-0/+1
| | | | | | (#13441) Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-14 17:42:54 +0000