summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* 1.29.0rc1Erik Johnston2021-03-0440-40/+0
|
* Fix additional type hints from Twisted upgrade. (#9518)Patrick Cloke2021-03-031-0/+1
|
* Set X-Forwarded-Proto header when frontend-proxy proxies a request (#9539)Richard van der Hoff2021-03-031-0/+1
| | | Should fix some remaining warnings
* Fix 'rejected_events_metadata' background update (#9537)Erik Johnston2021-03-031-0/+1
| | | | Turns out matrix.org has an event that has duplicate auth events (which really isn't supposed to happen, but here we are). This caused the background update to fail due to `UniqueViolation`.
* Purge chain cover tables when purging events. (#9498)Patrick Cloke2021-03-031-0/+1
|
* Add type hints to user admin API. (#9521)Dirk Klimpel2021-03-031-0/+1
|
* Bump the mypy and mypy-zope versions. (#9529)Patrick Cloke2021-03-031-0/+1
|
* Make deleting stale pushers a background update (#9536)Erik Johnston2021-03-031-0/+1
|
* Update nginx reverse-proxy docs (#9512)Richard van der Hoff2021-03-031-0/+1
| | | Turns out nginx overwrites the Host header by default.
* Prevent presence background jobs from running when presence is disabled (#9530)Aaron Raimist2021-03-031-0/+1
| | | | | Prevent presence background jobs from running when presence is disabled Signed-off-by: Aaron Raimist <aaron@raim.ist>
* Revert "Fix #8518 (sync requests being cached wrongly on timeout) (#9358)"Patrick Cloke2021-03-021-1/+0
| | | | | | | This reverts commit f5c93fc9931e4029bbd8000f398b6f39d67a8c46. This is being backed out due to a regression (#9507) and additional review feedback being provided.
* Re-run rejected metadata background update. (#9503)Erik Johnston2021-03-021-0/+1
| | | | | | | It landed in schema version 58 after 59 had been created, causing some servers to not run it. The main effect of was that not all rooms had their chain cover calculated correctly. After the BG updates complete the chain covers will get fixed when a new state event in the affected rooms is received.
* Fix SQL delta file taking a long time to run (#9516)Erik Johnston2021-03-021-0/+1
| | | | Fixes #9504
* Add type hints to device and event report admin API (#9519)Dirk Klimpel2021-03-021-0/+1
|
* Fix a bug when a room alias is given to the admin join endpoint (#9506)Patrick Cloke2021-03-011-0/+1
|
* (Hopefully) stop leaking file descriptors in media repo. (#9497)Patrick Cloke2021-03-011-0/+1
| | | | By consuming the response if the headers imply that the content is too large.
* Use the proper Request in type hints. (#9515)Patrick Cloke2021-03-011-0/+1
| | | | This also pins the Twisted version in the mypy job for CI until proper type hints are fixed throughout Synapse.
* Allow bytecode again (#9502)Jonathan de Jong2021-02-261-0/+1
| | | | | | | In #75, bytecode was disabled (from a bit of FUD back in `python<2.4` days, according to dev chat), I think it's safe enough to enable it again. Added in `__pycache__/` and `.pyc`/`.pyd` to `.gitignore`, to extra-insure compiled files don't get committed. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`
* Add support for no_proxy and case insensitive env variables (#9372)Tim Leung2021-02-261-0/+1
| | | | | | | | | | | | | | | ### Changes proposed in this PR - Add support for the `no_proxy` and `NO_PROXY` environment variables - Internally rely on urllib's [`proxy_bypass_environment`](https://github.com/python/cpython/blob/bdb941be423bde8b02a5695ccf51c303d6204bed/Lib/urllib/request.py#L2519) - Extract env variables using urllib's `getproxies`/[`getproxies_environment`](https://github.com/python/cpython/blob/bdb941be423bde8b02a5695ccf51c303d6204bed/Lib/urllib/request.py#L2488) which supports lowercase + uppercase, preferring lowercase, except for `HTTP_PROXY` in a CGI environment This does contain behaviour changes for consumers so making sure these are called out: - `no_proxy`/`NO_PROXY` is now respected - lowercase `https_proxy` is now allowed and taken over `HTTPS_PROXY` Related to #9306 which also uses `ProxyAgent` Signed-off-by: Timothy Leung tim95@hotmail.co.uk
* SSO: redirect to public URL before setting cookies (#9436)Richard van der Hoff2021-02-261-0/+1
| | | ... otherwise, we don't get the cookie back.
* Call out the need for an X-Forwarded-Proto in the upgrade notes (#9501)Richard van der Hoff2021-02-262-1/+2
|
* Test that we require validated email for email pushers (#9496)Erik Johnston2021-02-251-0/+1
|
* Ensure pushers are deleted for deactivated accounts (#9285)Erik Johnston2021-02-251-0/+1
|
* Add support for X-Forwarded-Proto (#9472)Richard van der Hoff2021-02-241-0/+1
| | | | | rewrite XForwardedForRequest to set `isSecure()` based on `X-Forwarded-Proto`. Also implement `getClientAddress()` while we're here.
* Add SQL delta for deleting stale pushers (#9479)Erik Johnston2021-02-241-0/+1
|
* Fix #8518 (sync requests being cached wrongly on timeout) (#9358)Jonathan de Jong2021-02-241-0/+1
| | | | | | | This fixes #8518 by adding a conditional check on `SyncResult` in a function when `prev_stream_token == current_stream_token`, as a sanity check. In `CachedResponse.set.<remove>()`, the result is immediately popped from the cache if the conditional function returns "false". This prevents the caching of a timed-out `SyncResult` (that has `next_key` as the stream key that produced that `SyncResult`). The cache is prevented from returning a `SyncResult` that makes the client request the same stream key over and over again, effectively making it stuck in a loop of requesting and getting a response immediately for as long as the cache keeps those values. Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* Clean up `ShardedWorkerHandlingConfig` (#9466)Erik Johnston2021-02-241-0/+1
| | | | | | | | | | | | | | | | | * Split ShardedWorkerHandlingConfig This is so that we have a type level understanding of when it is safe to call `get_instance(..)` (as opposed to `should_handle(..)`). * Remove special cases in ShardedWorkerHandlingConfig. `ShardedWorkerHandlingConfig` tried to handle the various different ways it was possible to configure federation senders and pushers. This led to special cases that weren't hit during testing. To fix this the handling of the different cases is moved from there and `generic_worker` into the worker config class. This allows us to have the logic in one place and allows the rest of the code to ignore the different cases.
* Refactor to ensure we call check_consistency (#9470)Erik Johnston2021-02-241-0/+1
| | | The idea here is to stop people forgetting to call `check_consistency`. Folks can still just pass in `None` to the new args in `build_sequence_generator`, but hopefully they won't.
* Add a comment about systemd-python. (#9464)Richard van der Hoff2021-02-231-0/+1
| | | | This confused me for a while.
* Include newly added sequences in the port DB script. (#9449)Patrick Cloke2021-02-231-0/+1
| | | And ensure the consistency of `event_auth_chain_id`.
* Fix deleting pushers when using sharded pushers. (#9465)Erik Johnston2021-02-221-0/+1
|
* Remove vestiges of uploads_path config (#9462)Richard van der Hoff2021-02-221-0/+1
| | | | `uploads_path` was a thing that was never used; most of it was removed in #6628 but a few vestiges remained.
* Add an `order_by` field to list users' media admin API. (#8978)Dirk Klimpel2021-02-221-0/+1
|
* example systemd config: propagate reloads to units (#9463)Richard van der Hoff2021-02-221-0/+1
| | | | | It should be possible to reload `synapse.target` to have the reload propagate to all the synapse units.
* Remove cache for get_shared_rooms_for_users (#9416)Andrew Morgan2021-02-221-0/+1
| | | | | | | This PR remove the cache for the `get_shared_rooms_for_users` storage method (the db method driving the experimental "what rooms do I share with this user?" feature: [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)). Currently subsequent requests to the endpoint will return the same result, even if your shared rooms with that user have changed. The cache was added in https://github.com/matrix-org/synapse/pull/7785, but we forgot to ensure it was invalidated appropriately. Upon attempting to invalidate it, I found that the cache had to be entirely invalidated whenever a user (remote or local) joined or left a room. This didn't make for a very useful cache, especially for a function that may or may not be called very often. Thus, I've opted to remove it instead of invalidating it.
* Clean up the user directory sample config section (#9385)Andrew Morgan2021-02-221-0/+1
| | | | | The user directory sample config section was a little messy, and didn't adhere to our [recommended config format guidelines](https://github.com/matrix-org/synapse/blob/develop/docs/code_style.md#configuration-file-format). This PR cleans that up a bit.
* Ratelimit cross-user key sharing requests. (#8957)Patrick Cloke2021-02-191-0/+1
|
* Regenerate exact thumbnails if missing (#9438)Erik Johnston2021-02-191-0/+1
|\
| * NewsfileErik Johnston2021-02-181-0/+1
| |
* | Add documentation and type hints to parse_duration. (#9432)Patrick Cloke2021-02-191-0/+1
| |
* | Merge tag 'v1.28.0rc1' into developPatrick Cloke2021-02-1943-43/+0
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.28.0rc1 (2021-02-19) ============================== Note that this release drops support for ARMv7 in the official Docker images, due to repeated problems building for ARMv7 (and the associated maintenance burden this entails). This release also fixes the documentation included in v1.27.0 around the callback URI for SAML2 identity providers. If your server is configured to use single sign-on via a SAML2 IdP, you may need to make configuration changes. Please review [UPGRADE.rst](UPGRADE.rst) for more details on these changes. Removal warning --------------- The v1 list accounts API is deprecated and will be removed in a future release. This API was undocumented and misleading. It can be replaced by the [v2 list accounts API](https://github.com/matrix-org/synapse/blob/release-v1.28.0/docs/admin_api/user_admin_api.rst#list-accounts), which has been available since Synapse 1.7.0 (2019-12-13). Please check if you're using any scripts which use the admin API and replace `GET /_synapse/admin/v1/users/<user_id>` with `GET /_synapse/admin/v2/users`. Features -------- - New admin API to get the context of an event: `/_synapse/admin/rooms/{roomId}/context/{eventId}`. ([\#9150](https://github.com/matrix-org/synapse/issues/9150)) - Further improvements to the user experience of registration via single sign-on. ([\#9300](https://github.com/matrix-org/synapse/issues/9300), [\#9301](https://github.com/matrix-org/synapse/issues/9301)) - Add hook to spam checker modules that allow checking file uploads and remote downloads. ([\#9311](https://github.com/matrix-org/synapse/issues/9311)) - Add support for receiving OpenID Connect authentication responses via form `POST`s rather than `GET`s. ([\#9376](https://github.com/matrix-org/synapse/issues/9376)) - Add the shadow-banning status to the admin API for user info. ([\#9400](https://github.com/matrix-org/synapse/issues/9400)) Bugfixes -------- - Fix long-standing bug where sending email notifications would fail for rooms that the server had since left. ([\#9257](https://github.com/matrix-org/synapse/issues/9257)) - Fix bug in Synapse 1.27.0rc1 which meant the "session expired" error page during SSO registration was badly formatted. ([\#9296](https://github.com/matrix-org/synapse/issues/9296)) - Assert a maximum length for some parameters for spec compliance. ([\#9321](https://github.com/matrix-org/synapse/issues/9321), [\#9393](https://github.com/matrix-org/synapse/issues/9393)) - Fix additional errors when previewing URLs: "AttributeError 'NoneType' object has no attribute 'xpath'" and "ValueError: Unicode strings with encoding declaration are not supported. Please use bytes input or XML fragments without declaration.". ([\#9333](https://github.com/matrix-org/synapse/issues/9333)) - Fix a bug causing Synapse to impose the wrong type constraints on fields when processing responses from appservices to `/_matrix/app/v1/thirdparty/user/{protocol}`. ([\#9361](https://github.com/matrix-org/synapse/issues/9361)) - Fix bug where Synapse would occasionally stop reconnecting to Redis after the connection was lost. ([\#9391](https://github.com/matrix-org/synapse/issues/9391)) - Fix a long-standing bug when upgrading a room: "TypeError: '>' not supported between instances of 'NoneType' and 'int'". ([\#9395](https://github.com/matrix-org/synapse/issues/9395)) - Reduce the amount of memory used when generating the URL preview of a file that is larger than the `max_spider_size`. ([\#9421](https://github.com/matrix-org/synapse/issues/9421)) - Fix a long-standing bug in the deduplication of old presence, resulting in no deduplication. ([\#9425](https://github.com/matrix-org/synapse/issues/9425)) - The `ui_auth.session_timeout` config option can now be specified in terms of number of seconds/minutes/etc/. Contributed by Rishabh Arya. ([\#9426](https://github.com/matrix-org/synapse/issues/9426)) - Fix a bug introduced in v1.27.0: "TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType." related to the user directory. ([\#9428](https://github.com/matrix-org/synapse/issues/9428)) Updates to the Docker image --------------------------- - Drop support for ARMv7 in Docker images. ([\#9433](https://github.com/matrix-org/synapse/issues/9433)) Improved Documentation ---------------------- - Reorganize CHANGELOG.md. ([\#9281](https://github.com/matrix-org/synapse/issues/9281)) - Add note to `auto_join_rooms` config option explaining existing rooms must be publicly joinable. ([\#9291](https://github.com/matrix-org/synapse/issues/9291)) - Correct name of Synapse's service file in TURN howto. ([\#9308](https://github.com/matrix-org/synapse/issues/9308)) - Fix the braces in the `oidc_providers` section of the sample config. ([\#9317](https://github.com/matrix-org/synapse/issues/9317)) - Update installation instructions on Fedora. ([\#9322](https://github.com/matrix-org/synapse/issues/9322)) - Add HTTP/2 support to the nginx example configuration. Contributed by David Vo. ([\#9390](https://github.com/matrix-org/synapse/issues/9390)) - Update docs for using Gitea as OpenID provider. ([\#9404](https://github.com/matrix-org/synapse/issues/9404)) - Document that pusher instances are shardable. ([\#9407](https://github.com/matrix-org/synapse/issues/9407)) - Fix erroneous documentation from v1.27.0 about updating the SAML2 callback URL. ([\#9434](https://github.com/matrix-org/synapse/issues/9434)) Deprecations and Removals ------------------------- - Deprecate old admin API `GET /_synapse/admin/v1/users/<user_id>`. ([\#9429](https://github.com/matrix-org/synapse/issues/9429)) Internal Changes ---------------- - Fix 'object name reserved for internal use' errors with recent versions of SQLite. ([\#9003](https://github.com/matrix-org/synapse/issues/9003)) - Add experimental support for running Synapse with PyPy. ([\#9123](https://github.com/matrix-org/synapse/issues/9123)) - Deny access to additional IP addresses by default. ([\#9240](https://github.com/matrix-org/synapse/issues/9240)) - Update the `Cursor` type hints to better match PEP 249. ([\#9299](https://github.com/matrix-org/synapse/issues/9299)) - Add debug logging for SRV lookups. Contributed by @Bubu. ([\#9305](https://github.com/matrix-org/synapse/issues/9305)) - Improve logging for OIDC login flow. ([\#9307](https://github.com/matrix-org/synapse/issues/9307)) - Share the code for handling required attributes between the CAS and SAML handlers. ([\#9326](https://github.com/matrix-org/synapse/issues/9326)) - Clean up the code to load the metadata for OpenID Connect identity providers. ([\#9362](https://github.com/matrix-org/synapse/issues/9362)) - Convert tests to use `HomeserverTestCase`. ([\#9377](https://github.com/matrix-org/synapse/issues/9377), [\#9396](https://github.com/matrix-org/synapse/issues/9396)) - Update the version of black used to 20.8b1. ([\#9381](https://github.com/matrix-org/synapse/issues/9381)) - Allow OIDC config to override discovered values. ([\#9384](https://github.com/matrix-org/synapse/issues/9384)) - Remove some dead code from the acceptance of room invites path. ([\#9394](https://github.com/matrix-org/synapse/issues/9394)) - Clean up an unused method in the presence handler code. ([\#9408](https://github.com/matrix-org/synapse/issues/9408))
| * | 1.28.0rc1Patrick Cloke2021-02-1843-43/+0
| | |
* | | Support not providing an IdP icon when choosing a username. (#9440)Patrick Cloke2021-02-191-0/+1
| | |
* | | Be smarter about which hosts to send presence to when processing room joins ↵Andrew Morgan2021-02-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#9402) This PR attempts to eliminate unnecessary presence sending work when your local server joins a room, or when a remote server joins a room your server is participating in by processing state deltas in chunks rather than individually. --- When your server joins a room for the first time, it requests the historical state as well. This chunk of new state is passed to the presence handler which, after filtering that state down to only membership joins, will send presence updates to homeservers for each join processed. It turns out that we were being a bit naive and processing each event individually, and sending out presence updates for every one of those joins. Even if many different joins were users on the same server (hello IRC bridges), we'd send presence to that same homeserver for every remote user join we saw. This PR attempts to deduplicate all of that by processing the entire batch of state deltas at once, instead of only doing each join individually. We process the joins and note down which servers need which presence: * If it was a local user join, send that user's latest presence to all servers in the room * If it was a remote user join, send the presence for all local users in the room to that homeserver We deduplicate by inserting all of those pending updates into a dictionary of the form: ``` { server_name1: {presence_update1, ...}, server_name2: {presence_update1, presence_update2, ...} } ``` Only after building this dict do we then start sending out presence updates.
* | | Add a config option to prioritise local users in user directory search ↵Andrew Morgan2021-02-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | results (#9383) This PR adds a homeserver config option, `user_directory.prefer_local_users`, that when enabled will show local users higher in user directory search results than remote users. This option is off by default. Note that turning this on doesn't necessarily mean that remote users will always be put below local users, but they should be assuming all other ranking factors (search query match, profile information present etc) are identical. This is useful for, say, University networks that are openly federating, but want to prioritise local students and staff in the user directory over other random users.
* | | Add configs to make profile data more private (#9203)AndrewFerr2021-02-191-0/+1
|/ / | | | | | | | | | | | | Add off-by-default configuration settings to: - disable putting an invitee's profile info in invite events - disable profile lookup via federation Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>
* / Remove deprecated SAML2 callback URL since it does not work. (#9434)Patrick Cloke2021-02-181-0/+1
|/ | | | Updates documentation from #9289 and removes a deprecated endpoint which didn't work as expected.
* Revert "Newsfragment", which was meant to be part of #9434.Patrick Cloke2021-02-181-1/+0
| | | | This reverts commit 8ad4676f35ec065853a5eb335b5566fdcf320460.
* NewsfragmentPatrick Cloke2021-02-181-0/+1
|
* Drop ARMv7 from docker (#9433)Erik Johnston2021-02-181-0/+1
| | | It's proving incredibly hard to build in CircleCI infra.
* Parse ui_auth.session_timeout as a duration (instead of treating it as ms) ↵Rishabh Arya2021-02-181-0/+1
| | | | (#9426)
* Deprecate old admin API `GET /_synapse/admin/v1/users/<user_id>` (#9429)Dirk Klimpel2021-02-181-0/+1
| | | This API was undocumented and nonsensical.
* Reduce the memory usage of previewing media files. (#9421)Patrick Cloke2021-02-181-0/+1
| | | | | | | | This reduces the memory usage of previewing media files which end up larger than the `max_spider_size` by avoiding buffering content internally in treq. It also checks the `Content-Length` header in additional places instead of streaming the content to check the body length.
* Add http2 to the nginx example config (#9390)David Vo2021-02-181-0/+1
|
* Add back the guard against the user directory stream position not existing. ↵Patrick Cloke2021-02-181-0/+1
| | | | | | (#9428) As the comment says, this guard was there for when the initial user directory update has yet to happen.
* Add the shadow-banning status to the display user admin API. (#9400)Dirk Klimpel2021-02-171-0/+1
|
* Remove dead notify_for_states presence method (#9408)Andrew Morgan2021-02-171-0/+1
|
* Fix only handling the last presence state for each user (#9425)Andrew Morgan2021-02-171-0/+1
| | | | | | | | | | | | | | This is a small bug that I noticed while working on #8956. We have a for-loop which attempts to strip all presence changes for each user except for the final one, as we don't really care about older presence: https://github.com/matrix-org/synapse/blob/9e19c6aab4b5a99039f2ddc7d3120dd3b26c274b/synapse/handlers/presence.py#L368-L371 `new_states_dict` stores this stripped copy of latest presence state for each user, before it is... put into a new variable `new_state`, which is just overridden by the subsequent for loop. I believe this was instead meant to override `new_states`. Without doing so, it effectively meant: 1. The for loop had no effect. 2. We were still processing old presence state for users.
* Reorganize CONTRIBUTING.md documentation. (#9281)David Teller2021-02-171-0/+1
|
* Add type hints to groups code. (#9393)Patrick Cloke2021-02-172-1/+2
|
* Support for form_post in OIDC responses (#9376)Richard van der Hoff2021-02-171-0/+1
| | | Apple want to POST the OIDC auth response back to us rather than using query-params; add the necessary support to make that work.
* Allow OIDC config to override discovered values (#9384)Richard van der Hoff2021-02-161-0/+1
| | | Fixes #9347
* Update black, and run auto formatting over the codebase (#9381)Eric Eastwood2021-02-161-0/+1
| | | | | | | - Update black version to the latest - Run black auto formatting over the codebase - Run autoformatting according to [`docs/code_style.md `](https://github.com/matrix-org/synapse/blob/80d6dc9783aa80886a133756028984dbf8920168/docs/code_style.md) - Update `code_style.md` docs around installing black to use the correct version
* Fix OIDC gitiea redirect URL. (#9404)Marcus2021-02-161-0/+1
| | | | Fixes a "conflict" from 846b9d3df033be1043710e49e89bcba68722071e and d1f13c7485768b45bfc1a2a674830c681c52e2a1.
* Clean up caching/locking of OIDC metadata load (#9362)Richard van der Hoff2021-02-161-0/+1
| | | | Ensure that we lock correctly to prevent multiple concurrent metadata load requests, and generally clean up the way we construct the metadata cache.
* Handle missing data in power levels events during room upgrade. (#9395)Patrick Cloke2021-02-161-0/+1
|
* Document that pusher instances are shardable (#9407)Erik Johnston2021-02-161-0/+1
|
* Convert additional test-cases to homeserver test case. (#9396)Patrick Cloke2021-02-161-0/+1
| | | And convert some inlineDeferreds to async-friendly functions.
* Remove dead handled_events set in invite_join (#9394)Andrew Morgan2021-02-121-0/+1
| | | | | This PR removes a set that was created and [initially used](https://github.com/matrix-org/synapse/commit/1d2a0040cff8d04cdc7d7d09d8f04a5d628fa9dd#diff-0bc92da3d703202f5b9be2d3f845e375f5b1a6bc6ba61705a8af9be1121f5e42R435-R436), but is no longer today. May help cut down a bit on the time it takes to accept invites.
* Merge tag 'v1.27.0rc2' into developPatrick Cloke2021-02-113-3/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.27.0rc2 (2021-02-11) ============================== Features -------- - Further improvements to the user experience of registration via single sign-on. ([\#9297](https://github.com/matrix-org/synapse/issues/9297)) Bugfixes -------- - Fix ratelimiting introduced in v1.27.0rc1 for invites to respect the `ratelimit` flag on application services. ([\#9302](https://github.com/matrix-org/synapse/issues/9302)) - Do not automatically calculate `public_baseurl` since it can be wrong in some situations. Reverts behaviour introduced in v1.26.0. ([\#9313](https://github.com/matrix-org/synapse/issues/9313)) Improved Documentation ---------------------- - Clarify the sample configuration for changes made to the template loading code. ([\#9310](https://github.com/matrix-org/synapse/issues/9310))
| * 1.27.0rc2Patrick Cloke2021-02-114-4/+0
| |
| * Backout changes for automatically calculating the public baseurl. (#9313)Patrick Cloke2021-02-111-0/+1
| | | | | | | | This breaks some people's configurations (if their Client-Server API is not accessed via port 443).
* | Ensure that we never stop reconnecting to redis (#9391)Erik Johnston2021-02-111-0/+1
| |
* | Convert some test cases to use HomeserverTestCase. (#9377)Patrick Cloke2021-02-111-0/+1
| | | | | | | | This has the side-effect of being able to remove use of `inlineCallbacks` in the test-cases for cleaner tracebacks.
* | Combine the CAS & SAML implementations for required attributes. (#9326)Patrick Cloke2021-02-111-0/+1
| |
* | Remove conflicting sqlite tables that are "reserved" (shadow fts4 tables) ↵Eric Eastwood2021-02-101-0/+1
| | | | | | | | | | | | | | (#9003) Remove conflicting sqlite tables that throw sqlite3.OperationalError: object name reserved for internal use: event_search_content when running the twisted unit tests. Fix #8996
* | Remove unneeded type constraints on 3rd party protocol lookup responsesBrendan Abolivier2021-02-091-0/+1
| |
* | Type hints and validation improvements. (#9321)Patrick Cloke2021-02-081-0/+1
| | | | | | | | | | * Adds type hints to the groups servlet and stringutils code. * Assert the maximum length of some input values for spec compliance.
* | Handle additional errors when previewing URLs. (#9333)Patrick Cloke2021-02-081-0/+1
| | | | | | | | * Handle the case of lxml not finding a document tree. * Parse the document encoding from the XML tag.
* | Merge pull request #9150 from Yoric/develop-contextDavid Teller2021-02-081-0/+1
|\ \ | | | | | | New API /_synapse/admin/rooms/{roomId}/context/{eventId}
| * | FIXUP: Now testing that the user is admin!David Teller2021-01-281-4/+1
| | |
| * | New API /_synapse/admin/rooms/{roomId}/context/{eventId}David Teller2021-01-281-0/+4
| | | | | | | | | | | | Signed-off-by: David Teller <davidt@element.io>
* | | Update type hints for Cursor to match PEP 249. (#9299)Jonathan de Jong2021-02-051-0/+1
| | |
* | | Update installation instructions on Fedora (#9322)Dan Callahan2021-02-051-0/+1
| | | | | | | | | | | | | | | | | | | | | Signed-off-by: Joseph Arnault <computerdude90042@outlook.com> Signed-off-by: Dan Callahan <danc@element.io> Co-authored-by: compu42 <56663749+compu42@users.noreply.github.com>
* | | Merge branch 'erikj/media_spam_checker' into developErik Johnston2021-02-041-0/+1
|\ \ \
| * | | Add check_media_file_for_spam spam checker hookErik Johnston2021-02-041-0/+1
| | |/ | |/|
* | | Correct `matrix-synapse.service` reference in TURN howto docs. (#9308)dykstranet2021-02-041-0/+1
| | |
* | | Handle empty rooms when generating email notifications. (#9257)Patrick Cloke2021-02-041-0/+1
| | | | | | | | | | | | | | | | | | Fixes some exceptions if the room state isn't quite as expected. If the expected state events aren't found, try to find them in the historical room state. If they still aren't found, fallback to a reasonable, although ugly, value.
* | | Fix escaping of braces in OIDC sample config. (#9317)Patrick Cloke2021-02-041-0/+1
| | | | | | | | | This fixes the Jinja2 templates for the mapping provider.
* | | Add experimental support for PyPy. (#9123)Jonathan de Jong2021-02-041-0/+1
| | | | | | | | | | | | * Adds proper dependencies. * Minor fixes in database layer.
* | | Add debug logging to DNS SRV requests. (#9305)Marcus2021-02-031-0/+1
| | |
* | | Merge branch 'social_login_hotfixes' into developRichard van der Hoff2021-02-036-0/+6
|\ \ \
| * | | Merge remote-tracking branch 'origin/release-v1.27.0' into social_login_hotfixesRichard van der Hoff2021-02-033-0/+3
| |\| |
| | * | Clarify documentation about escaping URLs in templates. (#9310)Patrick Cloke2021-02-031-0/+1
| | | |
| | * | social login Fix username validation javascript (#9297)Richard van der Hoff2021-02-031-0/+1
| | | | | | | | | | | | | | | | | | | | * fix validation and don't use built-in validation UI Co-authored-by: Bruno Windels <brunow@element.io>
| * | | Social login UI polish (#9301)Richard van der Hoff2021-02-031-0/+1
| | | |
| * | | Add debug for OIDC flow (#9307)Richard van der Hoff2021-02-031-0/+1
| | | |
| * | | Fix formatting for "bad session" error during sso registration flow (#9296)Richard van der Hoff2021-02-031-0/+1
| | | |
| * | | social login: add noopener to terms link (#9300)Richard van der Hoff2021-02-021-0/+1
| | | |
* | | | config: Add detail to auto_join_rooms comment (#9291)dykstranet2021-02-031-0/+1
| | | | | | | | | | | | | | | | | | | | config: Add detail to auto_join_rooms comment Signed-off-by: Gary Dykstra <gary@dykstranet.com>
* | | | Convert blacklisted IPv4 addresses to compatible IPv6 addresses. (#9240)Patrick Cloke2021-02-031-0/+1
| |/ / |/| | | | | Also add a few more IP ranges to the default blacklist.
* | | Honour ratelimit flag for application services for invite ratelimiting (#9302)Erik Johnston2021-02-031-0/+1
|/ /
* | 1.27.0rc1Erik Johnston2021-02-0251-51/+0
| |
* | Add an admin API to get the current room state (#9168)Travis Ralston2021-02-021-0/+1
| | | | | | | | | | This could arguably replace the existing admin API for `/members`, however that is out of scope of this change. This sort of endpoint is ideal for moderation use cases as well as other applications, such as needing to retrieve various bits of information about a room to perform a task (like syncing power levels between two places). This endpoint exposes nothing more than an admin would be able to access with a `select *` query on their database.
* | Put SAML callback URI under /_synapse/client. (#9289)Richard van der Hoff2021-02-021-0/+1
| |
* | Put OIDC callback URI under /_synapse/client. (#9288)Richard van der Hoff2021-02-011-0/+1
| |
* | Add an OpenID example config for Gitea. (#9134)Oliver Hanikel2021-02-011-0/+1
| |
* | Merge branch 'social_login' into developRichard van der Hoff2021-02-014-0/+4
|\ \
| * | Collect terms consent from the user during SSO registration (#9276)Richard van der Hoff2021-02-011-0/+1
| | |
| * | Improve styling and wording of SSO UIA templates (#9286)Richard van der Hoff2021-02-011-0/+1
| | | | | | | | | fixes #9171
| * | Improve styling and wording of SSO error templates (#9287)Richard van der Hoff2021-02-011-0/+1
| | |
| * | Make importing display name and email optional (#9277)Richard van der Hoff2021-02-011-0/+1
| | |
* | | Refactor email summary generation. (#9260)Patrick Cloke2021-02-011-0/+1
| | | | | | | | | | | | | | | | | | * Fixes a case where no summary text was returned. * The use of messages_from_person vs. messages_from_person_and_others was tweaked to depend on whether there was 1 sender or multiple senders, not based on if there was 1 room or multiple rooms.
* | | Merge branch 'social_login' into developRichard van der Hoff2021-02-014-0/+4
|\| |
| * | Replace username picker with a template (#9275)Richard van der Hoff2021-02-011-0/+1
| | | | | | | | | | | | | | | There's some prelimiary work here to pull out the construction of a jinja environment to a separate function. I wanted to load the template at display time rather than load time, so that it's easy to update on the fly. Honestly, I think we should do this with all our templates: the risk of ending up with malformed templates is far outweighed by the improved turnaround time for an admin trying to update them.
| * | Improve styling and wording of SSO redirect confirm template (#9272)Richard van der Hoff2021-02-011-0/+1
| | |
| * | Fix SSO on workers (#9271)Richard van der Hoff2021-02-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #8966. * Factor out build_synapse_client_resource_tree Start a function which will mount resources common to all workers. * Move sso init into build_synapse_client_resource_tree ... so that we don't have to do it for each worker * Fix SSO-login-via-a-worker Expose the SSO login endpoints on workers, like the documentation says. * Update workers config for new endpoints Add documentation for endpoints recently added (#8942, #9017, #9262) * remove submit_token from workers endpoints list this *doesn't* work on workers (yet). * changelog * Add a comment about the odd path for SAML2Resource
| * | Split out a separate endpoint to complete SSO registration (#9262)Richard van der Hoff2021-02-011-0/+1
| | | | | | | | | There are going to be a couple of paths to get to the final step of SSO reg, and I want the URL in the browser to consistent. So, let's move the final step onto a separate path, which we redirect to.
* | | Add phone home stats for encrypted messages. (#9283)Jan Christian Grünhage2021-02-011-0/+1
| | | | | | | | | Signed-off-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz>
* | | Prevent email UIA failures from raising a LoginError (#9265)Andrew Morgan2021-02-011-0/+1
| | | | | | | | | | | | | | | | | | | | | Context, Fixes: https://github.com/matrix-org/synapse/issues/9263 In the past to fix an issue with old Riots re-requesting threepid validation tokens, we raised a `LoginError` during UIA instead of `InteractiveAuthIncompleteError`. This is now breaking the way Tchap logs in - which isn't standard, but also isn't disallowed by the spec. An easy fix is just to remove the 4 year old workaround.
* | | Fixes for PyPy compatibility (#9270)Ivan Shapovalov2021-01-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * synapse.app.base: only call gc.freeze() on CPython gc.freeze() is an implementation detail of CPython garbage collector, and notably does not exist on PyPy. Rather than playing whack-a-mole and skipping the call when under PyPy, simply restrict it to CPython because the whole gc module is implementation-defined. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
* | | Ratelimit invites by room and target user (#9258)Erik Johnston2021-01-291-0/+1
| | |
* | | Fix Debian builds on Xenial (#9254)Dan Callahan2021-01-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Adds note about updating dh-virtualenv once we drop support for Xenial. We can't update now, because it needs debhelper 12, while Xenial only backports 10. Signed-off-by: Dan Callahan <danc@element.io>
* | | Merge branch 'social_login' into developRichard van der Hoff2021-01-283-1/+3
|\| |
| * | Add 'brand' field to MSC2858 response (#9242)Richard van der Hoff2021-01-272-1/+2
| | | | | | | | | | | | | | | | | | We've decided to add a 'brand' field to help clients decide how to style the buttons. Also, fix up the allowed characters for idp_id, while I'm in the area.
| * | Support for scraping email addresses from OIDC providers (#9245)Richard van der Hoff2021-01-271-0/+1
| | |
* | | Ratelimit 3PID /requestToken API (#9238)Erik Johnston2021-01-281-0/+1
| | |
* | | Cache config options in SSL verification (#9255)Erik Johnston2021-01-281-0/+1
| | | | | | | | | Reading from the config object is *slow*.
* | | Add type hints to E2E handler. (#9232)Patrick Cloke2021-01-281-0/+1
| |/ |/| | | This finishes adding type hints to the `synapse.handlers` module.
* | Add notes on integrating with Facebook for SSO login. (#9244)Richard van der Hoff2021-01-271-0/+1
| |
* | Check if a user is in the room before sending a PowerLevel event on their ↵Pankaj Yadav2021-01-271-0/+1
| | | | | | | | behalf (#9235)
* | Merge branch 'social_login' into developRichard van der Hoff2021-01-271-0/+1
|\|
| * Implement MSC2858 support (#9183)Richard van der Hoff2021-01-271-0/+1
| | | | | | Fixes #8928.
| * Fix Python 3.5 old deps build by using a compatible pip version. (#9217)Patrick Cloke2021-01-251-0/+1
| | | | | | | | | | Co-authored-by: Dan Callahan <danc@element.io> pip 21.0 stopped supporting Python 3.5.
| * Merge tag 'v1.26.0rc2' into social_loginRichard van der Hoff2021-01-251-1/+0
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204))
* | | Clean-up the template loading code. (#9200)Patrick Cloke2021-01-271-0/+1
| | | | | | | | | | | | | | | * Enables autoescape by default for HTML files. * Adds a new read_template method for reading a single template. * Some logic clean-up.
* | | Add a note to changelog about redis usage (#9227)Erik Johnston2021-01-271-0/+1
| | |
* | | Pass a dict, instead of None, to modules if a None config is specified in ↵Andrew Morgan2021-01-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | the homeserver config (#9229) If a Synapse module's config block were empty in YAML, thus being translated to a `Nonetype` in Python, then some modules could fail as that None ends up getting passed to their `parse_config` method. Modules are expected to accept a `dict` instead. This PR ensures that if the user does end up specifying an empty config block (such as what [the default oidc config in the sample config](https://github.com/matrix-org/synapse/blob/5310808d3bebd17275355ecd474bc013e8c7462d/docs/sample_config.yaml#L1816-L1845) states) then `None` is not passed to the module. An empty dict is passed instead. This code assumes that no existing modules are relying on receiving a `None` config block, but I'd really hope that they aren't.
* | | Add type hints to various handlers. (#9223)Patrick Cloke2021-01-261-0/+1
| | | | | | | | | | | | With this change all handlers except the e2e_* ones have type hints enabled.
* | | Do not require the CAS service URL setting (use public_baseurl instead). (#9199)Patrick Cloke2021-01-261-0/+1
| | | | | | | | | | | | The current configuration is handled for backwards compatibility, but is considered deprecated.
* | | Precompute joined hosts and store in Redis (#9198)Erik Johnston2021-01-261-0/+1
| | |
* | | Try to recover from unknown encodings when previewing media. (#9164)Patrick Cloke2021-01-261-0/+1
| | | | | | | | | | | | | | | | | | Treat unknown encodings (according to lxml) as UTF-8 when generating a preview for HTML documents. This isn't fully accurate, but will hopefully give a reasonable title and summary.
* | | Update isort to v5.7.0 (#9222)Andrew Morgan2021-01-261-0/+1
| | | | | | | | | | | | | | | This new version no longer has the problem of adding/removing a blank line in `.pyi` files, which black disagrees with. This would cause `isort` to slightly modify `.pyi` files, before `black` would subsequently modify back directly afterwards. Relevant `isort` issue: https://github.com/pycqa/isort/issues/1284
* | | Merge pull request #9062 from matrix-org/jaywink/admin-forward-extremitiesJason Robinson2021-01-261-0/+1
|\ \ \ | | | | | | | | Add forward extremities endpoint to rooms admin API
| * \ \ Merge branch 'develop' into jaywink/admin-forward-extremitiesJason Robinson2021-01-262-0/+2
| |\ \ \ | | | | | | | | | | | | | | | | | | | | # Conflicts: # synapse/rest/admin/__init__.py
| * \ \ \ Merge remote-tracking branch 'origin/develop' into ↵Patrick Cloke2021-01-251-0/+1
| |\ \ \ \ | | | | | | | | | | | | | | | | | | jaywink/admin-forward-extremities
| * \ \ \ \ Merge remote-tracking branch 'origin/develop' into ↵Jason Robinson2021-01-254-3/+1
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | jaywink/admin-forward-extremities
| * \ \ \ \ \ Merge branch 'develop' into jaywink/admin-forward-extremitiesJason Robinson2021-01-2337-23/+14
| |\ \ \ \ \ \
| * | | | | | | Add changelog and admin API docsJason Robinson2021-01-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | | | | | | | Periodically send pings to detect dead Redis connections (#9218)Erik Johnston2021-01-261-0/+1
| |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is done by creating a custom `RedisFactory` subclass that periodically pings all connections in its pool. We also ensure that the `replyTimeout` param is non-null, so that we timeout waiting for the reply to those pings (and thus triggering a reconnect).
* | | | | | | Don't error if deleting a non-existent pusher. (#9121)Patrick Cloke2021-01-251-0/+1
| | | | | | |
* | | | | | | Add an admin API for shadow-banning users. (#9209)Patrick Cloke2021-01-251-0/+1
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This expands the current shadow-banning feature to be usable via the admin API and adds documentation for it. A shadow-banned users receives successful responses to their client-server API requests, but the events are not propagated into rooms. Shadow-banning a user should be used as a tool of last resort and may lead to confusing or broken behaviour for the client.
* | | | | | Fix Python 3.5 old deps build by using a compatible pip version. (#9217)Patrick Cloke2021-01-251-0/+1
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | Co-authored-by: Dan Callahan <danc@element.io> pip 21.0 stopped supporting Python 3.5.
* | | | | Merge tag 'v1.26.0rc2' into developPatrick Cloke2021-01-253-3/+0
|\ \ \ \ \ | | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.26.0rc2 (2021-01-25) ============================== Bugfixes -------- - Fix receipts and account data not being sent down sync. Introduced in v1.26.0rc1. ([\#9193](https://github.com/matrix-org/synapse/issues/9193), [\#9195](https://github.com/matrix-org/synapse/issues/9195)) - Fix chain cover update to handle events with duplicate auth events. Introduced in v1.26.0rc1. ([\#9210](https://github.com/matrix-org/synapse/issues/9210)) Internal Changes ---------------- - Add an `oidc-` prefix to any `idp_id`s which are given in the `oidc_providers` configuration. ([\#9189](https://github.com/matrix-org/synapse/issues/9189)) - Bump minimum `psycopg2` version to v2.8. ([\#9204](https://github.com/matrix-org/synapse/issues/9204))
| * | | | 1.26.0rc2Patrick Cloke2021-01-255-5/+0
| | | | |
| * | | | Fix chain cover update to handle events with duplicate auth events (#9210)Erik Johnston2021-01-221-0/+1
| | | | |
| * | | | Bump psycopg2 version (#9204)Erik Johnston2021-01-221-0/+1
| | | | | | | | | | | | | | | As we use `execute_values` with the `fetch` parameter.
* | | | | Handle missing content keys when calculating presentable names. (#9165)Patrick Cloke2021-01-251-0/+1
| |_|/ / |/| | | | | | | | | | | Treat the content as untrusted and do not assume it is of the proper form.
* | | | Return a 404 if no valid thumbnail is found. (#9163)Patrick Cloke2021-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | If no thumbnail of the requested type exists, return a 404 instead of erroring. This doesn't quite match the spec (which does not define what happens if no thumbnail can be found), but is consistent with what Synapse already does.
* | | | Align the directories linted in CI with the defaults in scripts-dev/lint.sh ↵Andrew Morgan2021-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | (#9191) The lists of source directories to lint between `tox.ini` and `lint.sh` became out of sync. This PR tightens them up and adds some comments reminding any future readers to keep the list in sync.
* | | | Speed up chain cover calculation (#9176)Erik Johnston2021-01-211-0/+1
| | | |
* | | | Increase perf of handling concurrent use of StreamIDGenerators. (#9190)Erik Johnston2021-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | We have seen a failure mode here where if there are many in flight unfinished IDs then marking an ID as finished takes a lot of CPU (as calling deque.remove iterates over the list)
* | | | Merge remote-tracking branch 'origin/release-v1.26.0' into developErik Johnston2021-01-211-0/+1
|\| | |
| * | | Add schema update to fix existing DBs affected by #9193 (#9195)Erik Johnston2021-01-211-0/+1
| | | |
* | | | Merge remote-tracking branch 'origin/release-v1.26.0' into developErik Johnston2021-01-211-0/+1
|\| | |
| * | | Fix receipts or account data not being sent down sync (#9193)Erik Johnston2021-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | Introduced in #9104 This wasn't picked up by the tests as this is all fine the first time you run Synapse (after upgrading), but then when you restart the wrong value is pulled from `stream_positions`.
* | | | Use execute_batch in more places (#9188)Erik Johnston2021-01-211-0/+1
| | | | | | | | | | | | | | | | | | | | * Use execute_batch in more places * Newsfile
* | | | Add tests for List Users Admin API (#9045)Dirk Klimpel2021-01-211-0/+1
| |_|/ |/| |
* | | Add a check for duplicate IdP ids (#9184)Richard van der Hoff2021-01-211-0/+1
| | |
* | | Merge remote-tracking branch 'origin/release-v1.26.0' into developRichard van der Hoff2021-01-211-0/+1
|\| |
| * | Prefix idp_id with "oidc-" (#9189)Richard van der Hoff2021-01-211-0/+1
| | | | | | | | | ... to avoid clashes with other SSO mechanisms
* | | Use execute_batch instead of executemany in places (#9181)Erik Johnston2021-01-211-0/+1
| | | | | | | | | `execute_batch` does fewer round trips in postgres than `executemany`, but does not give a correct `txn.rowcount` result after.
* | | Specify that the long description is rST in the package metadata. (#9180)Patrick Cloke2021-01-201-0/+1
| | | | | | | | | This avoids a warning when uploading packages to PyPI via twine.
* | | Merge tag 'v1.26.0rc1' into developPatrick Cloke2021-01-201-1/+0
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.26.0rc1 (2021-01-20) ============================== This release brings a new schema version for Synapse and rolling back to a previous verious is not trivial. Please review [UPGRADE.rst](UPGRADE.rst) for more details on these changes and for general upgrade guidance. Features -------- - Add support for multiple SSO Identity Providers. ([\#9015](https://github.com/matrix-org/synapse/issues/9015), [\#9017](https://github.com/matrix-org/synapse/issues/9017), [\#9036](https://github.com/matrix-org/synapse/issues/9036), [\#9067](https://github.com/matrix-org/synapse/issues/9067), [\#9081](https://github.com/matrix-org/synapse/issues/9081), [\#9082](https://github.com/matrix-org/synapse/issues/9082), [\#9105](https://github.com/matrix-org/synapse/issues/9105), [\#9107](https://github.com/matrix-org/synapse/issues/9107), [\#9109](https://github.com/matrix-org/synapse/issues/9109), [\#9110](https://github.com/matrix-org/synapse/issues/9110), [\#9127](https://github.com/matrix-org/synapse/issues/9127), [\#9153](https://github.com/matrix-org/synapse/issues/9153), [\#9154](https://github.com/matrix-org/synapse/issues/9154), [\#9177](https://github.com/matrix-org/synapse/issues/9177)) - During user-interactive authentication via single-sign-on, give a better error if the user uses the wrong account on the SSO IdP. ([\#9091](https://github.com/matrix-org/synapse/issues/9091)) - Give the `public_baseurl` a default value, if it is not explicitly set in the configuration file. ([\#9159](https://github.com/matrix-org/synapse/issues/9159)) - Improve performance when calculating ignored users in large rooms. ([\#9024](https://github.com/matrix-org/synapse/issues/9024)) - Implement [MSC2176](https://github.com/matrix-org/matrix-doc/pull/2176) in an experimental room version. ([\#8984](https://github.com/matrix-org/synapse/issues/8984)) - Add an admin API for protecting local media from quarantine. ([\#9086](https://github.com/matrix-org/synapse/issues/9086)) - Remove a user's avatar URL and display name when deactivated with the Admin API. ([\#8932](https://github.com/matrix-org/synapse/issues/8932)) - Update `/_synapse/admin/v1/users/<user_id>/joined_rooms` to work for both local and remote users. ([\#8948](https://github.com/matrix-org/synapse/issues/8948)) - Add experimental support for handling to-device messages on worker processes. ([\#9042](https://github.com/matrix-org/synapse/issues/9042), [\#9043](https://github.com/matrix-org/synapse/issues/9043), [\#9044](https://github.com/matrix-org/synapse/issues/9044), [\#9130](https://github.com/matrix-org/synapse/issues/9130)) - Add experimental support for handling `/keys/claim` and `/room_keys` APIs on worker processes. ([\#9068](https://github.com/matrix-org/synapse/issues/9068)) - Add experimental support for handling `/devices` API on worker processes. ([\#9092](https://github.com/matrix-org/synapse/issues/9092)) - Add experimental support for moving off receipts and account data persistence off master. ([\#9104](https://github.com/matrix-org/synapse/issues/9104), [\#9166](https://github.com/matrix-org/synapse/issues/9166)) Bugfixes -------- - Fix a long-standing issue where an internal server error would occur when requesting a profile over federation that did not include a display name / avatar URL. ([\#9023](https://github.com/matrix-org/synapse/issues/9023)) - Fix a long-standing bug where some caches could grow larger than configured. ([\#9028](https://github.com/matrix-org/synapse/issues/9028)) - Fix error handling during insertion of client IPs into the database. ([\#9051](https://github.com/matrix-org/synapse/issues/9051)) - Fix bug where we didn't correctly record CPU time spent in `on_new_event` block. ([\#9053](https://github.com/matrix-org/synapse/issues/9053)) - Fix a minor bug which could cause confusing error messages from invalid configurations. ([\#9054](https://github.com/matrix-org/synapse/issues/9054)) - Fix incorrect exit code when there is an error at startup. ([\#9059](https://github.com/matrix-org/synapse/issues/9059)) - Fix `JSONDecodeError` spamming the logs when sending transactions to remote servers. ([\#9070](https://github.com/matrix-org/synapse/issues/9070)) - Fix "Failed to send request" errors when a client provides an invalid room alias. ([\#9071](https://github.com/matrix-org/synapse/issues/9071)) - Fix bugs in federation catchup logic that caused outbound federation to be delayed for large servers after start up. Introduced in v1.8.0 and v1.21.0. ([\#9114](https://github.com/matrix-org/synapse/issues/9114), [\#9116](https://github.com/matrix-org/synapse/issues/9116)) - Fix corruption of `pushers` data when a postgres bouncer is used. ([\#9117](https://github.com/matrix-org/synapse/issues/9117)) - Fix minor bugs in handling the `clientRedirectUrl` parameter for SSO login. ([\#9128](https://github.com/matrix-org/synapse/issues/9128)) - Fix "Unhandled error in Deferred: BodyExceededMaxSize" errors when .well-known files that are too large. ([\#9108](https://github.com/matrix-org/synapse/issues/9108)) - Fix "UnboundLocalError: local variable 'length' referenced before assignment" errors when the response body exceeds the expected size. This bug was introduced in v1.25.0. ([\#9145](https://github.com/matrix-org/synapse/issues/9145)) - Fix a long-standing bug "ValueError: invalid literal for int() with base 10" when `/publicRooms` is requested with an invalid `server` parameter. ([\#9161](https://github.com/matrix-org/synapse/issues/9161)) Improved Documentation ---------------------- - Add some extra docs for getting Synapse running on macOS. ([\#8997](https://github.com/matrix-org/synapse/issues/8997)) - Correct a typo in the `systemd-with-workers` documentation. ([\#9035](https://github.com/matrix-org/synapse/issues/9035)) - Correct a typo in `INSTALL.md`. ([\#9040](https://github.com/matrix-org/synapse/issues/9040)) - Add missing `user_mapping_provider` configuration to the Keycloak OIDC example. Contributed by @chris-ruecker. ([\#9057](https://github.com/matrix-org/synapse/issues/9057)) - Quote `pip install` packages when extras are used to avoid shells interpreting bracket characters. ([\#9151](https://github.com/matrix-org/synapse/issues/9151)) Deprecations and Removals ------------------------- - Remove broken and unmaintained `demo/webserver.py` script. ([\#9039](https://github.com/matrix-org/synapse/issues/9039)) Internal Changes ---------------- - Improve efficiency of large state resolutions. ([\#8868](https://github.com/matrix-org/synapse/issues/8868), [\#9029](https://github.com/matrix-org/synapse/issues/9029), [\#9115](https://github.com/matrix-org/synapse/issues/9115), [\#9118](https://github.com/matrix-org/synapse/issues/9118), [\#9124](https://github.com/matrix-org/synapse/issues/9124)) - Various clean-ups to the structured logging and logging context code. ([\#8939](https://github.com/matrix-org/synapse/issues/8939)) - Ensure rejected events get added to some metadata tables. ([\#9016](https://github.com/matrix-org/synapse/issues/9016)) - Ignore date-rotated homeserver logs saved to disk. ([\#9018](https://github.com/matrix-org/synapse/issues/9018)) - Remove an unused column from `access_tokens` table. ([\#9025](https://github.com/matrix-org/synapse/issues/9025)) - Add a `-noextras` factor to `tox.ini`, to support running the tests with no optional dependencies. ([\#9030](https://github.com/matrix-org/synapse/issues/9030)) - Fix running unit tests when optional dependencies are not installed. ([\#9031](https://github.com/matrix-org/synapse/issues/9031)) - Allow bumping schema version when using split out state database. ([\#9033](https://github.com/matrix-org/synapse/issues/9033)) - Configure the linters to run on a consistent set of files. ([\#9038](https://github.com/matrix-org/synapse/issues/9038)) - Various cleanups to device inbox store. ([\#9041](https://github.com/matrix-org/synapse/issues/9041)) - Drop unused database tables. ([\#9055](https://github.com/matrix-org/synapse/issues/9055)) - Remove unused `SynapseService` class. ([\#9058](https://github.com/matrix-org/synapse/issues/9058)) - Remove unnecessary declarations in the tests for the admin API. ([\#9063](https://github.com/matrix-org/synapse/issues/9063)) - Remove `SynapseRequest.get_user_agent`. ([\#9069](https://github.com/matrix-org/synapse/issues/9069)) - Remove redundant `Homeserver.get_ip_from_request` method. ([\#9080](https://github.com/matrix-org/synapse/issues/9080)) - Add type hints to media repository. ([\#9093](https://github.com/matrix-org/synapse/issues/9093)) - Fix the wrong arguments being passed to `BlacklistingAgentWrapper` from `MatrixFederationAgent`. Contributed by Timothy Leung. ([\#9098](https://github.com/matrix-org/synapse/issues/9098)) - Reduce the scope of caught exceptions in `BlacklistingAgentWrapper`. ([\#9106](https://github.com/matrix-org/synapse/issues/9106)) - Improve `UsernamePickerTestCase`. ([\#9112](https://github.com/matrix-org/synapse/issues/9112)) - Remove dependency on `distutils`. ([\#9125](https://github.com/matrix-org/synapse/issues/9125)) - Enforce that replication HTTP clients are called with keyword arguments only. ([\#9144](https://github.com/matrix-org/synapse/issues/9144)) - Fix the Python 3.5 / old dependencies build in CI. ([\#9146](https://github.com/matrix-org/synapse/issues/9146)) - Replace the old `perspectives` option in the Synapse docker config file template with `trusted_key_servers`. ([\#9157](https://github.com/matrix-org/synapse/issues/9157))
| * | Re-run towncrier.Patrick Cloke2021-01-203-3/+0
| | |
| * | Tighten the restrictions on `idp_id` (#9177)Richard van der Hoff2021-01-201-0/+1
| | |
| * | Support icons for Identity Providers (#9154)Richard van der Hoff2021-01-201-0/+1
| | |
* | | Various improvements to the federation client. (#9129)Patrick Cloke2021-01-201-0/+1
| | | | | | | | | | | | * Type hints for `FederationClient`. * Using `async` functions instead of returning `Awaitable` instances.
* | | docs: Add link to Matrix VoIP tester for turn-howto (#9135)rht2021-01-201-0/+1
|/ / | | | | Signed-off-by: rht <rhtbot@protonmail.com>
* | Merge remote-tracking branch 'origin/develop' into release-v1.26.0Richard van der Hoff2021-01-201-0/+1
|\ \
| * | Give `public_baseurl` a default value (#9159)Richard van der Hoff2021-01-201-0/+1
| | |
* | | 1.26.0rc1Patrick Cloke2021-01-2074-74/+0
|/ /
* | Use the account handler in additional places. (#9166)Patrick Cloke2021-01-201-0/+1
| |
* | Validate the server name for the /publicRooms endpoint. (#9161)Patrick Cloke2021-01-191-0/+1
| | | | | | | | If a remote server name is provided, ensure it is something reasonable before making remote connections to it.
* | Replace 'perspectives' config block with 'trusted_key_servers' in docker ↵Andrew Morgan2021-01-191-0/+1
| | | | | | | | homeserver.yaml template (#9157)
* | Fix error messages from OIDC config parsing (#9153)Richard van der Hoff2021-01-191-0/+1
| | | | | | | | Make sure we report the correct config path for errors in the OIDC configs.
* | Quote pip install with brackets to avoid shell interpretation. (#9151)Patrick Cloke2021-01-181-0/+1
| |
* | Allow moving account data and receipts streams off master (#9104)Erik Johnston2021-01-181-0/+1
| |
* | Enforce all replication HTTP clients calls use kwargs (#9144)Erik Johnston2021-01-181-0/+1
| |
* | Properly raise an exception when the body exceeds the max size. (#9145)Patrick Cloke2021-01-181-0/+1
| | | | | | ...instead of just creating the exception object and doing nothing with it.
* | Fix bugs in handling clientRedirectUrl, and improve OIDC tests (#9127, #9128)Richard van der Hoff2021-01-182-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Factor out a common TestHtmlParser Looks like I'm doing this in a few different places. * Improve OIDC login test Complete the OIDC login flow, rather than giving up halfway through. * Ensure that OIDC login works with multiple OIDC providers * Fix bugs in handling clientRedirectUrl - don't drop duplicate query-params, or params with no value - allow utf-8 in query-params
* | Fix the Python 3.5 old-deps build. (#9146)Patrick Cloke2021-01-181-0/+1
| | | | | | setuptools 51.0.0 dropped support for Python 3.5.
* | Ensure the user ID is serialized in the payload instead of used as an ↵Patrick Cloke2021-01-181-0/+1
| | | | | | | | instance name. (#9130)
* | Make chain cover index bg update go faster (#9124)Erik Johnston2021-01-151-0/+1
| | | | | | | | | | | | We do this by allowing a single iteration to process multiple rooms at a time, as there are often a lot of really tiny rooms, which can massively slow things down.
* | Ensure we store pusher data as text (#9117)Richard van der Hoff2021-01-151-0/+1
| | | | | | | | | | I don't think there's any need to use canonicaljson here. Fixes: #4475.
* | Land support for multiple OIDC providers (#9110)Richard van der Hoff2021-01-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the final step for supporting multiple OIDC providers concurrently. First of all, we reorganise the config so that you can specify a list of OIDC providers, instead of a single one. Before: oidc_config: enabled: true issuer: "https://oidc_provider" # etc After: oidc_providers: - idp_id: prov1 issuer: "https://oidc_provider" - idp_id: prov2 issuer: "https://another_oidc_provider" The old format is still grandfathered in. With that done, it's then simply a matter of having OidcHandler instantiate a new OidcProvider for each configured provider.
* | Add an admin API endpoint to protect media. (#9086)Patrick Cloke2021-01-151-0/+1
| | | | | | | | | | | | Protecting media stops it from being quarantined when e.g. all media in a room is quarantined. This is useful for sticker packs and other media that is uploaded by server administrators, but used by many people.
* | Avoid raising the body exceeded error multiple times. (#9108)Patrick Cloke2021-01-151-0/+1
| | | | | | | | | | Previously this code generated unreferenced `Deferred` instances which caused "Unhandled Deferreds" errors to appear in error situations.
* | Remote dependency on distutils (#9125)Richard van der Hoff2021-01-151-0/+1
| | | | | | | | | | | | | | | | | | `distutils` is pretty much deprecated these days, and replaced with `setuptools`. It's also annoying because it's you can't `pip install` it, and it's hard to figure out which debian package we should depend on to make sure it's there. Since we only use it for a tiny function anyway, let's just vendor said function into our codebase.
* | Add type hints to media rest resources. (#9093)Patrick Cloke2021-01-151-0/+1
| |
* | Improve UsernamePickerTestCase (#9112)Richard van der Hoff2021-01-151-0/+1
| | | | | | | | | | * make the OIDC bits of the test work at a higher level - via the REST api instead of poking the OIDCHandler directly. * Move it to test_login.py, where I think it fits better.
* | Store an IdP ID in the OIDC session (#9109)Richard van der Hoff2021-01-151-0/+1
| | | | | | | | | | Again in preparation for handling more than one OIDC provider, add a new caveat to the macaroon used as an OIDC session cookie, which remembers which OIDC provider we are talking to. In future, when we get a callback, we'll need it to make sure we talk to the right IdP. As part of this, I'm adding an idp_id and idp_name field to the OIDC configuration object. They aren't yet documented, and we'll just use the old values by default.
* | Add some extra notes for getting Synapse running on macOS. (#8997)Eric Eastwood2021-01-151-0/+1
| |
* | Merge pull request #9091 from matrix-org/rav/error_on_bad_ssoRichard van der Hoff2021-01-151-0/+1
|\ \ | | | | | | Give the user a better error when they present bad SSO creds
| * | Give the user a better error when they present bad SSO credsRichard van der Hoff2021-01-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO IdP, try to give them a better error. Previously, the UIA would claim to be successful, but then the operation in question would simply fail with "auth fail". Instead, serve up an error page which explains the failure.
* | | Fix event chain bg update. (#9118)Erik Johnston2021-01-141-0/+1
| | | | | | | | | | | | We passed in a graph to `sorted_topologically` which didn't have an entry for each node (as we dropped nodes with no edges).
* | | Fix perf of get_cross_signing_keys (#9116)Erik Johnston2021-01-142-1/+2
| | |
* | | Fix chain cover background update to work with split out event persisters ↵Erik Johnston2021-01-141-0/+1
| | | | | | | | | | | | (#9115)
* | | Fix get destinations to catch up query. (#9114)Erik Johnston2021-01-141-0/+1
| | | | | | | | | | | | t was doing a sequential scan on `destination_rooms`, which took minutes.
* | | Add background update for add chain cover index (#9029)Erik Johnston2021-01-142-1/+2
| | |
* | | Split OidcProvider out of OidcHandler (#9107)Richard van der Hoff2021-01-141-0/+1
| | | | | | | | | | | | | | | | | | | | | The idea here is that we will have an instance of OidcProvider for each configured IdP, with OidcHandler just doing the marshalling of them. For now it's still hardcoded with a single provider.
* | | Fix wrong arguments being passed to BlacklistingAgentWrapper (#9098)Tim Leung2021-01-141-0/+1
|/ / | | | | | | | | | | A reactor was being passed instead of a whitelist for the BlacklistingAgentWrapper used by the WellyKnownResolver. This coulld cause exceptions when attempting to connect to IP addresses that are blacklisted, but in reality this did not have any observable affect since this code is not used for IP literals.
* | Add a test for UI-Auth-via-SSO (#9082)Richard van der Hoff2021-01-131-0/+1
| | | | | | | | | | * Add complete test for UI-Auth-via-SSO. * review comments
* | Merge pull request #9105 from matrix-org/rav/multi_idp/oidc_provider_configRichard van der Hoff2021-01-131-0/+1
|\ \ | | | | | | Enhancements to OIDC configuration handling
| * | changelogRichard van der Hoff2021-01-131-0/+1
| | |
* | | Reduce scope of exception handler. (#9106)Patrick Cloke2021-01-131-0/+1
| | | | | | | | | | | | Removes a bare `except Exception` clause and replaces it with catching a specific exception around the portion that might throw.
* | | Register the /devices endpoint on workers. (#9092)Patrick Cloke2021-01-131-0/+1
|/ /
* | Add basic domain validation for `DomainSpecificString.is_valid`. (#9071)Patrick Cloke2021-01-131-0/+1
| | | | | | | | | | This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.
* | Preparatory refactors of OidcHandler (#9067)Richard van der Hoff2021-01-131-0/+1
| | | | | | | | | | | | | | | | Some light refactoring of OidcHandler, in preparation for bigger things: * remove inheritance from deprecated BaseHandler * add an object to hold the things that go into a session cookie * factor out a separate class for manipulating said cookies
* | Remove user's avatar URL and displayname when deactivated. (#8932)Dirk Klimpel2021-01-121-0/+1
| | | | | | This only applies if the user's data is to be erased.
* | UI Auth via SSO: redirect the user to an appropriate SSO. (#9081)Richard van der Hoff2021-01-121-0/+1
| | | | | | | | | | | | | | If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one. There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated. Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.
* | Handle bad JSON data being returned from the federation API. (#9070)Patrick Cloke2021-01-121-0/+1
| |
* | Kill off `HomeServer.get_ip_from_request()` (#9080)Richard van der Hoff2021-01-121-0/+1
| | | | | | Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
* | Remove SynapseRequest.get_user_agent (#9069)Richard van der Hoff2021-01-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.
* | Also support remote users on the joined_rooms admin API. (#8948)David Teller2021-01-111-0/+1
| | | | | | | | For remote users, only the rooms which the server knows about are returned. Local users have all of their joined rooms returned.
* | Move more encryption endpoints off master (#9068)Erik Johnston2021-01-111-0/+1
| |
* | Removes unnecessary declarations in the tests for the admin API. (#9063)Dirk Klimpel2021-01-111-0/+1
| |
* | Use a chain cover index to efficiently calculate auth chain difference (#8868)Erik Johnston2021-01-111-0/+1
| |
* | Clean up exception handling in the startup code (#9059)Richard van der Hoff2021-01-111-0/+1
| | | | | | | | Factor out the exception handling in the startup code to a utility function, and fix the some logging and exit code stuff.
* | Remove old tables after schema version bump (#9055)Erik Johnston2021-01-111-0/+1
| | | | | | | | | | These tables are unused, and can be dropped now the schema version has been bumped.
* | Ensure rejected events get added to some metadata tables (#9016)Erik Johnston2021-01-111-0/+1
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix a typo in the install docs. (#9040)0xflotus2021-01-111-0/+1
| |
* | Remove unused SynapseService (#9058)Richard van der Hoff2021-01-111-0/+1
| |
* | Drop last_used column from access_tokens (#9025)Jerin J Titus2021-01-111-0/+1
|/ | | | | * Dropped last_used column from access_tokens Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* Keycloak mapping_provider example (#9037) (#9057)Christopher Rücker2021-01-081-0/+1
| | | | | This PR adds the missing user_mapping_provider section in oidc.md Signed-off-by: Christopher Rücker chris-ruecker@protonmail.com
* Fix "Starting metrics collection from sentinel context" errors (#9053)Erik Johnston2021-01-081-0/+1
|
* Merge pull request #9036 from matrix-org/rav/multi_idp/testsRichard van der Hoff2021-01-081-0/+1
|\ | | | | Add tests for the IdP picker
| * changelogRichard van der Hoff2021-01-071-0/+1
| |
* | Fix validate_config on nested objects (#9054)Richard van der Hoff2021-01-081-0/+1
| |
* | Fix error handling during insertion of client IPs (#9051)Erik Johnston2021-01-081-0/+1
| | | | | | | | | | You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.
* | Remove broken and unmaintained 'webserver.py' script (#9039)Richard van der Hoff2021-01-081-0/+1
| | | | | | | | | | | | I'm not even sure what this was supposed to do, but the fact it has python2isms and nobody has noticed suggests it's not terribly important. It doesn't seem to have been used since ff23e5ba3764506c99d9c1c640e202fe262b65ce.
* | Run the linters on a consistent list of files (#9038)Richard van der Hoff2021-01-081-0/+1
| | | | | | | | | | We were running some linters on some files and some on others. Extract a common setting and use it everywhere.
* | Allow running sendToDevice on workers (#9044)Erik Johnston2021-01-071-0/+1
| |
* | Support routing edu's to multiple instances (#9042)Erik Johnston2021-01-071-0/+1
| | | | | | This is in preparation for moving `SendToDeviceServlet` off master
* | Ensure that remote users' device list resyncing always happens on master (#9043)Erik Johnston2021-01-071-0/+1
| | | | | | Currently `DeviceMessageHandler` only ever exists on master, but that is about to change.
* | Some cleanups to device inbox store. (#9041)Erik Johnston2021-01-071-0/+1
| |
* | Fix typo in docs/systemd-with-workers/README.md (#9035)Emelie2021-01-071-0/+1
| | | | | | Signed-off-by: Emelie em@nao.sh
* | Improve the performance of calculating ignored users in large rooms (#9024)Patrick Cloke2021-01-071-0/+1
|/ | | | | | This allows for efficiently finding which users ignore a particular user. Co-authored-by: Erik Johnston <erik@matrix.org>
* tox: Add a -noextras factor (#9030)Richard van der Hoff2021-01-071-0/+1
| | | ... for running the tests with no optional deps.
* Skip unit tests which require optional dependencies (#9031)Richard van der Hoff2021-01-071-0/+1
| | | If we are lacking an optional dependency, skip the tests that rely on it.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-24 07:15:27 +0000