summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Convert streams to async. (#8014)Patrick Cloke2020-08-041-0/+1
|
* re-implement daemonize (#8011)Richard van der Hoff2020-08-041-0/+1
| | | | | | | | | | | | | This has long been something I've wanted to do. Basically the `Daemonize` code is both too flexible and not flexible enough, in that it offers a bunch of features that we don't use (changing UID, closing FDs in the child, logging to syslog) and doesn't offer a bunch that we could do with (redirecting stdout/err to a file instead of /dev/null; having the parent not exit until the child is running). As a first step, I've lifted the Daemonize code and removed the bits we don't use. This should be a non-functional change. Fixing everything else will come later.
* Remove signature check on v1 identity server lookups (#8001)Andrew Morgan2020-08-031-0/+1
| | | | | | | We've [decided](https://github.com/matrix-org/synapse/issues/5253#issuecomment-665976308) to remove the signature check for v1 lookups. The signature check has been removed in v2 lookups. v1 lookups are currently deprecated. As mentioned in the above linked issue, this verification was causing deployments for the vector.im and matrix.org IS deployments, and this change is the simplest solution, without being unjustified. Implementations are encouraged to use the v2 lookup API as it has [increased privacy benefits](https://github.com/matrix-org/matrix-doc/pull/2134).
* Prevent join->join membership transitions changing member count (#7977)Andrew Morgan2020-08-031-0/+1
| | | | | | | | | | | `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.
* Implement handling of HTTP HEAD requests. (#7999)Patrick Cloke2020-08-031-0/+1
|
* Convert the crypto module to async/await. (#8003)Patrick Cloke2020-08-031-0/+1
|
* Allow guests to operate in encrypted rooms (#7314)Michael Albert2020-08-031-0/+1
| | | Signed-off-by: Michael Albert <michael.albert@awesome-technologies.de>
* Convert replication code to async/await. (#7987)Patrick Cloke2020-08-031-0/+1
|
* Convert ACME code to async/await. (#7989)Patrick Cloke2020-08-031-0/+1
|
* Fix some comments and types in service notices (#7996)Patrick Cloke2020-07-311-0/+1
|
* Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2020-07-3124-0/+24
|\ | | | | | | erikj/add_rate_limiting_to_joins
| * Add docs for undoing room shutdowns (#7998)Travis Ralston2020-07-311-0/+1
| | | | | | These docs were tested successfully in production by a customer, so it's probably fine.
| * Update workers docs (#7990)Stuart Mumford2020-07-301-0/+1
| |
| * Fix invite rejection when we have no forward-extremeties (#7980)Richard van der Hoff2020-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | Thanks to some slightly overzealous cleanup in the `delete_old_current_state_events`, it's possible to end up with no `event_forward_extremities` in a room where we have outstanding local invites. The user would then get a "no create event in auth events" when trying to reject the invite. We can hack around it by using the dangling invite as the prev event.
| * Fix typo in docs/workers.md (#7992)Erik Johnston2020-07-301-0/+1
| |
| * Convert federation client to async/await. (#7975)Patrick Cloke2020-07-301-0/+1
| |
| * Convert appservice to async. (#7973)Patrick Cloke2020-07-301-0/+1
| |
| * Convert some of the data store to async. (#7976)Patrick Cloke2020-07-301-0/+1
| |
| * Ensure that remove_pusher is always async (#7981)Patrick Cloke2020-07-301-0/+1
| |
| * Ensure the msg property of HttpResponseException is a string. (#7979)Patrick Cloke2020-07-291-0/+1
| |
| * Remove from the event_relations table when purging historical events. (#7978)Patrick Cloke2020-07-291-0/+1
| |
| * Add additional logging for SAML sessions. (#7971)Patrick Cloke2020-07-291-0/+1
| |
| * Add MSC reference to changelog for #7736Brendan Abolivier2020-07-291-1/+1
| |
| * Re-implement unread counts (#7736)Brendan Abolivier2020-07-291-0/+1
| |
| * Various improvements to the docs (#7899)Aaron Raimist2020-07-291-0/+1
| |
| * Convert storage layer to async/await. (#7963)Patrick Cloke2020-07-281-0/+1
| |
| * Add an option to disable purge in delete room admin API (#7964)Dirk Klimpel2020-07-281-0/+1
| | | | | | | | | | | | Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete``` Fixes: #3761 Signed-off-by: Dirk Klimpel dirk@klimpel.org
| * Move some log lines from default logger to sql/transaction loggers (#7952)Andrew Morgan2020-07-281-0/+1
| | | | | | Idea from matrix-org/synapse-dinsic#49
| * Use the JSON module from the std library instead of simplejson. (#7936)Patrick Cloke2020-07-281-0/+1
| |
| * Fix exit code for `check_line_terminators.sh` (#7970)Richard van der Hoff2020-07-281-0/+1
| | | | | | | | | | | | | | | | | | If there are *no* files with CRLF line endings, then the xargs exits with a non-zero exit code (as expected), but then, since that is the last thing to happen in the script, the script as a whole exits non-zero, making the whole thing fail. using `if/then/fi` instead of `&& (...)` means that the script exits with a zero exit code.
| * Option to allow server admins to join complex rooms (#7902)lugino-emeritus2020-07-281-0/+1
| | | | | | | | | | Fixes #7901. Signed-off-by: Niklas Tittjung <nik_t.01@web.de>
| * Add script for finding files with unix line terminators (#7965)Andrew Morgan2020-07-281-0/+1
| | | | | | | | | | This PRs adds a script to check for unix-line terminators in the repo. It will be used to address https://github.com/matrix-org/synapse/issues/7943 by adding the check to CI. I've changed the original script slightly as proposed in https://github.com/matrix-org/pipelines/pull/81#discussion_r460580664
| * Convert the remaining media repo code to async / await. (#7947)Patrick Cloke2020-07-271-0/+1
| |
| * Convert a synapse.events to async/await. (#7949)Patrick Cloke2020-07-273-2/+3
| |
| * Convert groups and visibility code to async / await. (#7951)Patrick Cloke2020-07-271-0/+1
| |
| * Convert push to async/await. (#7948)Patrick Cloke2020-07-271-0/+1
| |
* | NewsfileErik Johnston2020-07-311-0/+1
| |
* | 1.18.0Olivier Wilkinson (reivilibre)2020-07-301-1/+0
| |
* | Update worker docs with recent enhancements (#7969)Erik Johnston2020-07-291-0/+1
| |
* | 1.18.0rc2 v1.18.0rc2Richard van der Hoff2020-07-283-3/+0
| |
* | Typing worker needs to handle stream update requests (#7967)Erik Johnston2020-07-281-0/+1
| | | | | | | | | | IIRC this doesn't break tests because its only hit on reconnection, or something. Basically, when a process needs to fetch missing updates for the `typing` stream it needs to query the writer instance via HTTP (as we don't write typing notifications to the DB), the problem was that the endpoint (`streams`) was only registered on master and specifically not on the typing writer worker.
* | Handle replication commands synchronously where possible (#7876)Richard van der Hoff2020-07-272-0/+2
|/ | | Most of the stuff we do for replication commands can be done synchronously. There's no point spinning up background processes if we're not going to need them.
* 1.18.0rc1Richard van der Hoff2020-07-2774-75/+0
|
* Fix error reporting when using `opentracing.trace` (#7961)Erik Johnston2020-07-271-0/+1
|
* Fix typing replication not being handled on master (#7959)Erik Johnston2020-07-271-0/+1
| | | | | | | | | | | | | | | | Handling of incoming typing stream updates from replication was not hooked up on master, effecting set ups where typing was handled on a different worker. This is really only a problem if the master process is also handling sync requests, which is unlikely for those that are at the stage of moving typing off. The other observable effect is that if a worker restarts or a replication connect drops then the typing worker will issue a `POSITION typing`, triggering master process to try and stream *all* typing updates from position 0. Fixes #7907
* Remove hacky error handling for inlineDeferreds. (#7950)Patrick Cloke2020-07-271-0/+1
|
* Convert tests/rest/admin/test_room.py to unix file endings (#7953)Andrew Morgan2020-07-271-0/+1
| | | | | Converts tests/rest/admin/test_room.py to have unix file endings after they were accidentally changed in #7613. Keeping the same changelog as #7613 as it hasn't gone out in a release yet.
* Support oEmbed for media previews. (#7920)Patrick Cloke2020-07-271-0/+1
| | | Fixes previews of Twitter URLs by using their oEmbed endpoint to grab content.
* Convert state resolution to async/await (#7942)Patrick Cloke2020-07-241-0/+1
|
* Fix up types and comments that refer to Deferreds. (#7945)Patrick Cloke2020-07-241-0/+1
|
* Do not convert async functions to Deferreds in the interactive_auth_handler ↵Patrick Cloke2020-07-241-0/+1
| | | | (#7944)
* Convert more of the media code to async/await (#7873)Patrick Cloke2020-07-241-0/+1
|
* Return an empty body for OPTIONS requests. (#7886)Patrick Cloke2020-07-241-0/+1
|
* Downgrade warning on client disconnect to INFO (#7928)Richard van der Hoff2020-07-241-0/+1
| | | | Clients disconnecting before we finish processing the request happens from time to time. We don't need to yell about it
* Convert presence handler helpers to async/await. (#7939)Patrick Cloke2020-07-231-0/+1
|
* Update the auth providers to be async. (#7935)Patrick Cloke2020-07-231-0/+1
|
* Put a cache on `/state_ids` (#7931)Richard van der Hoff2020-07-231-0/+1
| | | | | | | | | | | | | | | | | | If we send out an event which refers to `prev_events` which other servers in the federation are missing, then (after a round or two of backfill attempts), they will end up asking us for `/state_ids` at a particular point in the DAG. As per https://github.com/matrix-org/synapse/issues/7893, this is quite expensive, and we tend to see lots of very similar requests around the same time. We can therefore handle this much more efficiently by using a cache, which (a) ensures that if we see the same request from multiple servers (or even the same server, multiple times), then they share the result, and (b) any other servers that miss the initial excitement can also benefit from the work. [It's interesting to note that `/state` has a cache for exactly this reason. `/state` is now essentially unused and replaced with `/state_ids`, but evidently when we replaced it we forgot to add a cache to the new endpoint.]
* Abort federation requests if the client disconnects early (#7930)Richard van der Hoff2020-07-231-0/+1
| | | | | | | | | | | | | | | | | | | | | For inbound federation requests, if a given remote server makes too many requests at once, we start stacking them up rather than processing them immediatedly. However, that means that there is a fair chance that the requesting server will disconnect before we start processing the request. In that case, if it was a read-only request (ie, a GET request), there is absolutely no point in building a response (and some requests are quite expensive to handle). Even in the case of a POST request, one of two things will happen: * Most likely, the requesting server will retry the request and we'll get the information anyway. * Even if it doesn't, the requesting server has to assume that we didn't get the memo, and act accordingly. In short, we're better off aborting the request at this point rather than ploughing on with what might be a quite expensive request.
* Reorder database docs to promote postgresql. (#7933)Michael Kaye2020-07-231-0/+1
|
* Convert the federation agent and related code to async/await. (#7874)Patrick Cloke2020-07-231-0/+1
|
* Follow-up to admin API to re-activate accounts (#7908)Patrick Cloke2020-07-221-0/+1
|
* Convert the message handler to async/await. (#7884)Patrick Cloke2020-07-221-0/+1
|
* Update the dates for ACME v1 EOLBrendan Abolivier2020-07-221-0/+1
| | | | As per https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430
* Skip serializing /sync response if client has disconnected (#7927)Richard van der Hoff2020-07-221-0/+1
| | | ... it's a load of work which may be entirely redundant.
* Add debugging to sync response generation (#7929)Richard van der Hoff2020-07-221-0/+1
|
* Remove an unused prometheus metric (#7878)Richard van der Hoff2020-07-221-0/+1
|
* Track command processing as a background process (#7879)Richard van der Hoff2020-07-221-0/+1
| | | | I'm going to be doing more stuff synchronously, and I don't want to lose the CPU metrics down the sofa.
* Clean up PreserveLoggingContext (#7877)Richard van der Hoff2020-07-221-0/+1
| | | This had some dead code and some just plain wrong docstrings.
* Convert room list handler to async/await. (#7912)Patrick Cloke2020-07-211-0/+1
|
* Element CSS and logo in email templates (#7919)Jason Robinson2020-07-211-0/+1
| | | | | Use Element CSS and logo in notification emails when app name is Element. Signed-off-by: Jason Robinson <jasonr@matrix.org>
* Lint the contrib/ directory in CI and linting scripts, add synctl to linting ↵Andrew Morgan2020-07-201-0/+1
| | | | | | | script (#7914) Run `isort`, `flake8` and `black` over the `contrib/` directory and `synctl` script. The latter was already being done in CI, but now the linting script does it too. Fixes https://github.com/matrix-org/synapse/issues/7910
* Remove unused code from synapse.logging.utils. (#7897)Karthikeyan Singaravelan2020-07-201-0/+2
|
* Fix a typo in the sample config. (#7890)Adrian2020-07-201-0/+1
|
* Fix deprecation warning: import ABC from collections.abc (#7892)Karthikeyan Singaravelan2020-07-201-0/+1
|
* Change sample config's postgres user to synapse_user (#7889)Andrew Morgan2020-07-201-0/+1
| | | | | | | The [postgres setup docs](https://github.com/matrix-org/synapse/blob/develop/docs/postgres.md#set-up-database) recommend setting up your database with user `synapse_user`. However, uncommenting the postgres defaults in the sample config leave you with user `synapse`. This PR switches the sample config to recommend `synapse_user`. Took a me a second to figure this out, so assume this will beneficial to others.
* Fix deprecation warning due to invalid escape sequences (#7895)Karthikeyan Singaravelan2020-07-201-0/+1
| | | | | | | * Fix deprecation warnings due to invalid escape sequences. * Add changelog Signed-off-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
* Remove Ubuntu Eoan that is now EOL (#7888)Gary Kim2020-07-171-0/+1
|
* Fix the trace function for async functions. (#7872)Patrick Cloke2020-07-171-0/+1
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Add help for creating a user via docker (#7885)Michael Kaye2020-07-171-0/+1
|
* Switch to Debian:Slim from Alpine for the docker image (#7839)Christopher May-Townsend2020-07-171-0/+1
| | | As mentioned in #7397, switching to a debian base should help with multi-arch work to save time on compiling. This is unashamedly based on #6373, but without the extra functionality. Switch python version back to generic 3.7 to always pull the latest. Essentially, keeping this as small as possible. The image is bigger though unfortunately.
* Stop using 'device_max_stream_id' (#7882)Erik Johnston2020-07-171-0/+1
| | | | | It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.
* Fix TypeError in synapse.notifier (#7880)Erik Johnston2020-07-171-0/+1
| | | Fixes #7774
* Add a default limit (of 100) to get/sync operations. (#7858)Patrick Cloke2020-07-171-0/+1
|
* Change "unknown room ver" logging to warning. (#7881)Erik Johnston2020-07-171-0/+1
| | | | It's somewhat expected for us to have unknown room versions in the database due to room version experiments.
* Convert device handler to async/await (#7871)Patrick Cloke2020-07-171-0/+1
|
* Convert synapse.app to async/await. (#7868)Patrick Cloke2020-07-171-0/+1
|
* Convert _base, profile, and _receipts handlers to async/await (#7860)Patrick Cloke2020-07-171-0/+1
|
* Add admin endpoint to get members in a room. (#7842)Michael Albert2020-07-161-0/+1
|
* Consistently use `db_to_json` to convert from database values to JSON ↵Patrick Cloke2020-07-161-0/+1
| | | | objects. (#7849)
* Optimise queueing of inbound replication commands (#7861)Richard van der Hoff2020-07-161-0/+1
| | | | | | | | | | | When we get behind on replication, we tend to stack up background processes behind a linearizer. Bg processes are heavy (particularly with respect to prometheus metrics) and linearizers aren't terribly efficient once the queue gets long either. A better approach is to maintain a queue of requests to be processed, and nominate a single process to work its way through the queue. Fixes: #7444
* Reject attempts to join empty rooms over federation (#7859)Richard van der Hoff2020-07-161-0/+1
| | | | | | We shouldn't allow others to make_join through us if we've left the room; reject such attempts with a 404. Fixes #7835. Fixes #6958.
* Allow moving typing off master (#7869)Erik Johnston2020-07-161-0/+1
|
* Add ability to run multiple pusher instances (#7855)Erik Johnston2020-07-161-0/+1
| | | This reuses the same scheme as federation sender sharding
* Merge pull request #7866 from matrix-org/rav/fix_guest_user_idRichard van der Hoff2020-07-161-0/+1
|\ | | | | Fix guest user registration with lots of client readers
| * changelogRichard van der Hoff2020-07-161-0/+1
| |
* | Add some tiny type annotations (#7870)Richard van der Hoff2020-07-161-0/+1
| | | | | | I found these made pycharm have more of a clue as to what was going on in other places.
* | Ensure that calls to `json.dumps` are compatible with the standard library ↵Patrick Cloke2020-07-151-0/+1
| | | | | | | | json. (#7836)
* | Avoid brand new rooms in `delete_old_current_state_events` (#7854)Richard van der Hoff2020-07-151-0/+1
| | | | | | | | | | | | | | | | When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.
* | Merge branch 'erikj/faster_typing' of github.com:matrix-org/synapse into developErik Johnston2020-07-151-0/+1
|\ \ | |/ |/|
| * NewsfileErik Johnston2020-07-151-0/+1
| |
* | Allow accounts to be re-activated from the admin APIs. (#7847)Patrick Cloke2020-07-151-0/+1
| |
* | Fix client reader sharding tests (#7853)Erik Johnston2020-07-151-0/+1
|/ | | | | | | | | | | | | | | * Fix client reader sharding tests * Newsfile * Fix typing * Update changelog.d/7853.misc Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Move mocking of http_client to tests Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Convert E2E key and room key handlers to async/await. (#7851)Patrick Cloke2020-07-151-0/+1
|
* Return the proper 403 Forbidden error during errors with JWT logins. (#7844)Patrick Cloke2020-07-151-0/+1
|
* remove `retry_on_integrity_error` wrapper for persist_events (#7848)Richard van der Hoff2020-07-151-0/+1
| | | | | | | | | As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.
* Fix bug in per-room message retention policies. (#7850)Patrick Cloke2020-07-141-0/+1
|
* Allow email subjects to be customised through Synapse's configuration (#7846)Brendan Abolivier2020-07-141-0/+1
|
* Add delete room admin endpoint (#7613)Dirk Klimpel2020-07-141-0/+1
| | | | | | | | | | | | | | | | | | The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. https://github.com/matrix-org/synapse/blob/901b1fa561e3cc661d78aa96d59802cf2078cb0d/synapse/storage/data_stores/main/room.py#L99-L105 Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827)Patrick Cloke2020-07-141-0/+1
|
* Improve the type hints of synapse.api.errors. (#7820)Patrick Cloke2020-07-141-0/+1
|
* Correctly pass app_name to all email templates. (#7829)Erik Johnston2020-07-141-0/+1
| | | We didn't do this for e.g. registration emails.
* Support handling registration requests across multiple client readers. (#7830)Patrick Cloke2020-07-131-0/+1
|
* Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822)Brendan Abolivier2020-07-131-0/+1
| | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7821, introduced in https://github.com/matrix-org/synapse/pull/7639 Turns out PyYAML translates `off` into a `False` boolean if it's unquoted (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values), which seems to be a liberal interpretation of this bit of the YAML spec: https://yaml.org/spec/1.1/current.html#id864510 An alternative fix would be to implement the solution mentioned in the SO post linked above, but I'm aware it might break existing setups (which might use these values in the configuration file) so it's probably better just to add an extra check for this one. We should be aware that this is a thing for the next times we do that though. I didn't find any other occurrence of this bug elsewhere in the codebase.
* Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802)Patrick Cloke2020-07-101-0/+1
|
* Add types to the server code and remove unused parameter (#7813)Patrick Cloke2020-07-101-0/+1
|
* Include room states on invite events sent to ASes (#6455)Sorunome2020-07-101-0/+1
|
* Add ability to shard the federation sender (#7798)Erik Johnston2020-07-101-0/+1
|
* Fix resync remote devices on receive PDU in worker mode. (#7815)Erik Johnston2020-07-101-0/+1
| | | | | | The replication client requires that arguments are given as keyword arguments, which was not done in this case. We also pull out the logic so that we can catch and handle any exceptions raised, rather than leaving them unhandled.
* Fix recursion error when fetching auth chain over federation (#7817)Erik Johnston2020-07-101-0/+1
| | | | | | | | | | | | | | | When fetching the state of a room over federation we receive the event IDs of the state and auth chain. We then fetch those events that we don't already have. However, we used a function that recursively fetched any missing auth events for the fetched events, which can lead to a lot of recursion if the server is missing most of the auth chain. This work is entirely pointless because would have queued up the missing events in the auth chain to be fetched already. Let's just diable the recursion, since it only gets called from one place anyway.
* 1.17.0rc1 v1.17.0rc1Richard van der Hoff2020-07-0926-26/+0
|
* Fix some spelling mistakes / typos. (#7811)Patrick Cloke2020-07-091-0/+1
|
* `update_membership` declaration: now always returns an event id. (#7809)Richard van der Hoff2020-07-091-0/+1
|
* Improve stacktraces from exceptions in background processes (#7808)Richard van der Hoff2020-07-091-0/+1
| | | use `Failure()` to fish out the real exception.
* Fix `can only concatenate list (not "tuple") to list` exception (#7810)Richard van der Hoff2020-07-091-0/+1
| | | It seems auth_events can be either a list or a tuple, depending on Things.
* Pass original request headers from workers to the main process. (#7797)Patrick Cloke2020-07-091-0/+1
|
* Generate real events when we reject invites (#7804)Richard van der Hoff2020-07-091-0/+1
| | | | | | | | Fixes #2181. The basic premise is that, when we fail to reject an invite via the remote server, we can generate our own out-of-band leave event and persist it as an outlier, so that we have something to send to the client.
* Add `HomeServer.signing_key` property (#7805)Richard van der Hoff2020-07-081-0/+1
| | | ... instead of duplicating `config.signing_key[0]` everywhere
* Revert "Update the installation docs on apt-transport-https (#7801)"Richard van der Hoff2020-07-081-1/+0
| | | | | | | | This reverts commit e0c01296936a178d83556fc4f00f69e429fa7ba5. As discussed at https://github.com/matrix-org/synapse/pull/7801#pullrequestreview-444652786, I don't think this is an improvement.
* Do not use simplejson in Synapse. (#7800)Patrick Cloke2020-07-081-0/+1
|
* Stop passing bytes when dumping JSON (#7799)Patrick Cloke2020-07-081-0/+1
|
* Update the installation docs on apt-transport-https (#7801)Dirk Heinrichs2020-07-081-0/+1
| | | | | * Starting with apt 1.6, https support has moved into the main package and apt-transport-https has become a transitional dummy package. Signed-off-by: Dirk Heinrichs <dirk.heinrichs@altum.de>
* Change Caddy links (old is deprecated) (#7789)Nicolai Søborg2020-07-081-0/+1
| | | | | | | * Change Caddy links Current links points to Caddy v1 which is deprecated. Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>
* Stop populating unused table `local_invites`. (#7793)Richard van der Hoff2020-07-071-0/+1
| | | | | This table is no longer used, so we may as well stop populating it. Removing it would prevent people rolling back to older releases of Synapse, so that can happen in a future release.
* Refactor getting replication updates from database v2. (#7740)Erik Johnston2020-07-071-0/+1
|
* Add libwebp dependency to Dockerfile (#7791)Juho Vanhanen2020-07-061-0/+1
| | | | | * Add libwebp dependency to Dockerfile Signed-off-by: Juho Vanhanen <juho@vanhanen.io>
* Add documentation for JWT login type and improve sample config. (#7776)Patrick Cloke2020-07-061-0/+1
|
* Convert the appservice handler to async/await. (#7775)Patrick Cloke2020-07-061-0/+1
|
* Don't ignore `set_tweak` actions with no explicit `value`. (#7766)reivilibre2020-07-061-0/+1
| | | | | | | | | | | | | | * Fix spec compliance; tweaks without values are valid (default to True, which is only concretely specified for `highlight`, but it seems only reasonable to generalise) * Changelog for 7766. * Add documentation to `tweaks_for_actions` May as well tidy up when I'm here. * Add a test for `tweaks_for_actions`
* Allow to use higher versions of prometheus_client (#7780)Oliver Kurz2020-07-061-0/+1
| | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7641 The package was pinned to <0.8.0 without an obvious reasoning with 7ad1d7635 in https://github.com/matrix-org/synapse/pull/5636 while the version selection looks to just try to exclude an arbitrary next minor version number that might introduce API breaking changes. Selecting the next minor number might be a good conservative selection. Downstream distributions already reported success patching out the version requirements. This also fixes the integration of upgraded packages into openSUSE packages, e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 . Signed-off-by: Oliver Kurz <okurz@suse.de> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* isort 5 compatibility (#7786)Will Hunt2020-07-051-0/+1
| | | The CI appears to use the latest version of isort, which is a problem when isort gets a major version bump. Rather than try to pin the version, I've done the necessary to make isort5 happy with synapse.
* Merge different Resource implementation classes (#7732)Erik Johnston2020-07-031-0/+1
|
* Fix inconsistent handling of upper and lower cases of email addresses. (#7021)Dirk Klimpel2020-07-031-0/+1
| | | fixes #7016
* Allow YAML config file to contain None (#7779)Alex Kotov2020-07-031-0/+1
| | | | | Useful when config file is fully commented Signed-off-by: Alex Kotov <kotovalexarian@gmail.com>
* Merge tag 'v1.16.0rc2' into developPatrick Cloke2020-07-021-1/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.16.0rc2 (2020-07-02) ============================== Synapse 1.16.0rc2 includes the security fixes released with Synapse 1.15.2. Please see [below](https://github.com/matrix-org/synapse/blob/master/CHANGES.md#synapse-1152-2020-07-02) for more details. Improved Documentation ---------------------- - Update postgres image in example `docker-compose.yaml` to tag `12-alpine`. ([\#7696](https://github.com/matrix-org/synapse/issues/7696)) Internal Changes ---------------- - Add some metrics for inbound and outbound federation latencies: `synapse_federation_server_pdu_process_time` and `synapse_event_processing_lag_by_event`. ([\#7771](https://github.com/matrix-org/synapse/issues/7771))
| * 1.16.0rc2Patrick Cloke2020-07-022-2/+0
| |
| * Merge branch 'master' into release-v1.16.0Patrick Cloke2020-07-021-0/+1
| |\
| * | Fix new metric where we used ms instead of seconds (#7771)Erik Johnston2020-07-011-0/+1
| | | | | | | | | | | | Introduced in #7755, not yet released.
* | | Merge branch 'master' into developPatrick Cloke2020-07-021-0/+1
|\ \ \ | | |/ | |/|
| * | Update postgres in the Docker compose example to 12-alpine. (#7696)lub2020-06-171-0/+1
| | |
| * | 1.15.1Brendan Abolivier2020-06-162-2/+0
| | |
| * | Wrap register_device coroutine in an ensureDeferred (#7684)Andrew Morgan2020-06-161-0/+1
| | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/7683 Broke in: #7649 We had a `yield` acting on a coroutine. To be fair this one is a bit difficult to notice as there's a function in the middle that just passes the coroutine along.
| * | Enable 3PID add/bind/unbind endpoints on r0 routesBrendan Abolivier2020-06-151-0/+1
| | |
* | | Hack to add push priority to push notifications (#7765)reivilibre2020-07-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove obsolete comment about ancient temporary code Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Implement hack to set push priority based on whether the tweaks indicate the event might cause effects. * Changelog for 7765 Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Antilint * Add tests for push priority Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Update synapse/push/httppusher.py Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Antilint * Remove needless invites from tests. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | | Add early returns to `_check_for_soft_fail` (#7769)Richard van der Hoff2020-07-011-0/+1
| | | | | | | | | | | | my editor was complaining about unset variables, so let's add some early returns to fix that and reduce indentation/cognitive load.
* | | Use symbolic names for replication stream names (#7768)Richard van der Hoff2020-07-011-0/+1
| | | | | | | | | This makes it much easier to find where streams are referenced.
* | | Type checking for `FederationHandler` (#7770)Richard van der Hoff2020-07-011-0/+1
| | | | | | | | | fix a few things to make this pass mypy.
* | | Fix incorrect error message when database CTYPE was set incorrectly. (#7760)Richard van der Hoff2020-07-011-0/+1
| |/ |/|
* | 1.16.0rc1Andrew Morgan2020-07-0143-43/+0
| |
* | Back out MSC2625 implementation (#7761)Brendan Abolivier2020-07-013-2/+1
| |
* | Additional configuration options for auto-join rooms (#7763)Patrick Cloke2020-06-301-0/+1
| |
* | Add some metrics for inbound and outbound federation processing times (#7755)Erik Johnston2020-06-301-0/+1
| |
* | Explain the purpose of the "tests" conditional dependency requirement (#7751)Andrew Morgan2020-06-301-0/+1
| |
* | Add another yield point to state res v2 (#7746)Erik Johnston2020-06-261-0/+1
| |
* | Move flake8 to end. Don't exit script on failure (#7738)Andrew Morgan2020-06-251-0/+1
| |
* | Make tox actions work on Debian 10 (#7703)Dagfinn Ilmari Mannsåker2020-06-251-0/+1
| | | | | | | | | | | | - Remove the requirement for a specific version of Python - Move dep comment to a separate line, Tox 3.7.0 like trailing ones Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Yield during large v2 state res. (#7735)Erik Johnston2020-06-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | State res v2 across large data sets can be very CPU intensive, and if all the relevant events are in the cache the algorithm will run from start to finish within a single reactor tick. This can result in blocking the reactor tick for several seconds, which can have major repercussions on other requests. To fix this we simply add the occaisonal `sleep(0)` during iterations to yield execution until the next reactor tick. The aim is to only do this for large data sets so that we don't impact otherwise quick resolutions.=
* | add org.matrix.login.jwt so that m.login.jwt can be deprecated (#7675)Sorunome2020-06-241-0/+1
| |
* | Set Content-Length for Metrics requests (#7730)Christian Svensson2020-06-231-0/+1
| | | | | | | | | | | | HTTP requires the response to contain a Content-Length header unless chunked encoding is being used. Prometheus metrics endpoint did not set this, causing software such as prometheus-proxy to not be able to scrape synapse for metrics. Signed-off-by: Christian Svensson <blue@cmd.nu>
* | Sync ignored table names in synapse_port_db to current database schema (#7717)Patrick Cloke2020-06-231-0/+1
| |
* | Allow local media to be marked as safe from being quarantined. (#7718)Patrick Cloke2020-06-221-0/+1
| |
* | Convert directory handler to async/await (#7727)Patrick Cloke2020-06-221-0/+1
| |
* | Speed up state res v2 across large state differences. (#7725)Erik Johnston2020-06-191-0/+1
| |
* | Fixed typo by adding a 'g' to PostgreSQL (#7724)Jesse Riddle2020-06-191-0/+1
| |
* | Merge pull request #7716 from matrix-org/babolivier/unread_fixBrendan Abolivier2020-06-171-0/+1
|\ \ | | | | | | Fix unread counts in sync
| * | Fix unread counts in syncBrendan Abolivier2020-06-171-0/+1
| | | | | | | | | | | | | | | * Always return an unread_count in get_unread_event_push_actions_by_room_for_user * Don't always expect unread_count to be there so we don't take out sync entirely if something goes wrong
* | | Convert the typing handler to async/await. (#7679)Patrick Cloke2020-06-171-0/+1
| | |
* | | Require parameterized package version to be at least 0.7.0. (#7680)Oleg Girko2020-06-171-0/+1
|/ / | | | | | | | | Older versions of `parameterized` package have no `parameterized_class` decorator. This decorator is used in tests. Signed-off-by: Oleg Girko <ol@infoserver.lv>
* | Ignore the UI Auth sessions when porting from sqlite to postgresql (#7711)Patrick Cloke2020-06-171-0/+1
| |
* | Add support for using rust-python-jaeger-reporter (#7697)Erik Johnston2020-06-171-0/+1
| |
* | Support running multiple media repos. (#7706)Erik Johnston2020-06-171-0/+1
| | | | | | | | | | This requires a new config option to specify which media repo should be responsible for running background jobs to e.g. clear out expired URL preview caches.
* | Fetch from the r0 media path instead of the unspecced v1. (#7714)Patrick Cloke2020-06-171-0/+1
| |
* | Implement unread counter (MSC2625) (#7673)Brendan Abolivier2020-06-171-0/+1
|\ \ | | | | | | Implementation of https://github.com/matrix-org/matrix-doc/pull/2625
| * \ Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-154-0/+4
| |\ \
| * \ \ Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-156-0/+6
| |\ \ \
| * | | | Incorporate review bitsBrendan Abolivier2020-06-121-1/+1
| | | | |
| * | | | ChangelogBrendan Abolivier2020-06-102-1/+1
| | | | |
| * | | | Merge branch 'develop' into babolivier/mark_unreadBrendan Abolivier2020-06-1094-94/+0
| |\ \ \ \ | | | |_|/ | | |/| |
| * | | | changelogMatthew Hodgson2019-09-191-0/+1
| | | | |
* | | | | fix broken link in sample config (#7712)Richard van der Hoff2020-06-161-0/+1
| | | | |
* | | | | Refactor getting replication updates from database. (#7636)Erik Johnston2020-06-161-0/+1
| | | | | | | | | | | | | | | The aim here is to make it easier to reason about when streams are limited and when they're not, by moving the logic into the database functions themselves. This should mean we can kill of `db_query_to_update_function` function.
* | | | | Fix "argument of type 'ObservableDeferred' is not iterable" error (#7708)Patrick Cloke2020-06-161-0/+1
| | | | |
* | | | | Add instructions for authing with Keycloak via OpenID (#7659)hungrymonkey2020-06-161-0/+1
| | | | |
* | | | | Include a user agent in federation requests. (#7677)Patrick Cloke2020-06-161-0/+1
| | | | |
* | | | | Replace all remaining six usage with native Python 3 equivalents (#7704)Dagfinn Ilmari Mannsåker2020-06-161-0/+1
| | | | |
* | | | | Convert the device message and pagination handlers to async/await. (#7678)Patrick Cloke2020-06-161-0/+1
| | | | |
* | | | | Create a ListenerConfig object (#7681)Richard van der Hoff2020-06-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ended up being a bit more invasive than I'd hoped for (not helped by generic_worker duplicating some of the code from homeserver), but hopefully it's an improvement. The idea is that, rather than storing unstructured `dict`s in the config for the listener configurations, we instead parse it into a structured `ListenerConfig` object.
* | | | | Ensure the body is a string before comparing push rules. (#7701)Patrick Cloke2020-06-151-0/+1
| | | | |
* | | | | Ensure etag is a string for GET room_keys/version response (#7691)Hubert Chathi2020-06-151-0/+1
| | | | |
* | | | | Update m.id.phone to use 'phone' instead of 'number' (#7687)Andrew Morgan2020-06-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The spec [states](https://matrix.org/docs/spec/client_server/r0.6.1#phone-number) that `m.id.phone` requires the field `country` and `phone`. In Synapse, we've been enforcing `country` and `number`. I am not currently sure whether this affects any client implementations. This issue was introduced in #1994.
* | | | | Fix "There was no active span when trying to log." error (#7698)Erik Johnston2020-06-151-0/+1
| |_|_|/ |/| | |
* | | | Discard RDATA from already seen positions. (#7648)Patrick Cloke2020-06-151-0/+1
| | | |
* | | | Replace iteritems/itervalues/iterkeys with native versions. (#7692)Patrick Cloke2020-06-151-0/+1
| | | |
* | | | Fix warnings about losing log context during UI auth. (#7688)Patrick Cloke2020-06-121-0/+1
| | | |
* | | | Fix a typo when comparing the URI & method during UI Auth. (#7689)Patrick Cloke2020-06-121-0/+1
| |_|/ |/| |
* | | Remove "user_id" from GET /presence. (#7606)Will Hunt2020-06-111-0/+1
| | |
* | | Increase the default SAML session expirary time to 15 minutes. (#7664)Patrick Cloke2020-06-111-0/+1
| | |
* | | fix typo in sample_config.yaml (#7652)wondratsch2020-06-111-0/+1
| | | | | | | | | | | | | | | Just a simple typo fix. Signed-off-by: wondratsch 28294257+wondratsch@users.noreply.github.com
* | | Take out a lock before modifying _CACHES (#7663)Richard van der Hoff2020-06-101-0/+1
| | | | | | | | | | | | This should fix #7610.
* | | Add option to enable encryption by default for new rooms (#7639)Andrew Morgan2020-06-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/2431 Adds config option `encryption_enabled_by_default_for_room_type`, which determines whether encryption should be enabled with the default encryption algorithm in private or public rooms upon creation. Whether the room is private or public is decided based upon the room creation preset that is used. Part of this PR is also pulling out all of the individual instances of `m.megolm.v1.aes-sha2` into a constant variable to eliminate typos ala https://github.com/matrix-org/synapse/pull/7637 Based on #7637
* | | Clean-up the fallback login code. (#7657)Patrick Cloke2020-06-101-0/+1
| |/ |/|
* | 1.15.0rc1 v1.15.0rc1Brendan Abolivier2020-06-0943-43/+0
| |
* | Revert "1.15.0rc1"Brendan Abolivier2020-06-0943-0/+43
| | | | | | | | This reverts commit 8587b0426fa4e65992aaa47158e991fa1797d3fb.
* | 1.15.0rc1Brendan Abolivier2020-06-0943-43/+0
| |
* | Fix bug in account data replication stream. (#7656)Erik Johnston2020-06-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ensure account data stream IDs are unique. The account data stream is shared between three tables, and the maximum allocated ID was tracked in a dedicated table. Updating the max ID happened outside the transaction that allocated the ID, leading to a race where if the server was restarted then the same ID could be allocated but the max ID failed to be updated, leading it to be reused. The ID generators have support for tracking across multiple tables, so we may as well use that instead of a dedicated table. * Fix bug in account data replication stream. If the same stream ID was used in both global and room account data then the getting updates for the replication stream would fail due to `heapq.merge(..)` trying to compare a `str` with a `None`. (This is because you'd have two rows like `(534, '!room')` and `(534, None)` from the room and global account data tables). Fix is just to order by stream ID, since we don't rely on the ordering beyond that. The bug where stream IDs can be reused should be fixed now, so this case shouldn't happen going forward. Fixes #7617
* | Convert the registration handler to async/await. (#7649)Patrick Cloke2020-06-081-0/+1
| |
* | Accept device information at the login fallback endpoint. (#7629)Patrick Cloke2020-06-081-0/+1
| |
* | Convert user directory handler and related classes to async/await. (#7640)Patrick Cloke2020-06-051-0/+1
| |
* | Add an option to disable autojoin for guest accounts (#6637)Travis Ralston2020-06-051-0/+1
| | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/3177
* | Clarifications to the admin api documentation (#7647)Richard van der Hoff2020-06-051-0/+1
| | | | | | | | | | | | * Clarify how to authenticate * path params are not the same thing as query params * Fix documentation for `/_synapse/admin/v2/users/<user_id>`
* | Update to the stable SSO prefix for UI Auth. (#7630)Patrick Cloke2020-06-051-0/+1
| |
* | Fix type information on `assert_*_is_admin` methods (#7645)Richard van der Hoff2020-06-051-0/+1
| | | | | | These things don't return Deferreds.
* | Remove some unused constants. (#7644)Richard van der Hoff2020-06-051-0/+1
| |
* | Allow new users to be registered via the admin API even if the monthly ↵Dirk Klimpel2020-06-051-0/+1
| | | | | | | | active user limit has been reached (#7263)
* | Add device management to admin API (#7481)Dirk Klimpel2020-06-051-0/+1
| | | | | | | | | | | | | | | | | | | | - Admin is able to - change displaynames - delete devices - list devices - get device informations Fixes #7330
* | Attempt to fix PhoneHomeStatsTestCase.test_performance_100 being flaky. (#7634)Patrick Cloke2020-06-051-0/+1
| |
* | Support CS API v0.6.0 (#6585)Andrew Morgan2020-06-051-0/+1
| |
* | Add support for webp thumbnailing (#7586)WGH2020-06-051-0/+1
| | | | | | | | | | Closes #4382 Signed-off-by: Maxim Plotnikov <wgh@torlan.ru>
* | Performance improvements and refactor of Ratelimiter (#7595)Andrew Morgan2020-06-051-0/+1
| | | | | | | | | | | | | | | | | | | | While working on https://github.com/matrix-org/synapse/issues/5665 I found myself digging into the `Ratelimiter` class and seeing that it was both: * Rather undocumented, and * causing a *lot* of config checks This PR attempts to refactor and comment the `Ratelimiter` class, as well as encourage config file accesses to only be done at instantiation. Best to be reviewed commit-by-commit.
* | Fix encryption algorithm typos in tests/comments (#7637)Andrew Morgan2020-06-041-0/+1
| | | | | | | | | | | | | | | | @uhoreg has confirmed these were both typos. They are only in comments and tests though, rather than anything critical. Introduced in: * https://github.com/matrix-org/synapse/pull/7157 * https://github.com/matrix-org/synapse/pull/5726
* | Advertise the token login type when OpenID Connect is enabled. (#7631)Patrick Cloke2020-06-041-0/+1
| |
* | Cleanups to the OpenID Connect integration (#7628)Richard van der Hoff2020-06-031-0/+1
| | | | | | | | docs, default configs, comments. Nothing very significant.
* | async/await get_user_id_by_threepid (#7620)Andrew Morgan2020-06-031-0/+1
| | | | | | | | | | Based on #7619 async's `get_user_id_by_threepid` and its call stack.
* | Check the changelog number in check-newsfragment (#7623)Richard van der Hoff2020-06-031-0/+1
| |
* | Replace instances of reactor pumping with get_success. (#7619)Andrew Morgan2020-06-031-0/+1
| | | | | | | | | | Calls `self.get_success` on all deferred methods instead of abusing `self.pump()`. This has the benefit of working with coroutines, as well as checking that method execution completed successfully. There are also a few small cleanups that I made in the process.
* | Check if the localpart is reserved for guests earlier in the registration ↵Brendan Abolivier2020-06-031-0/+1
| | | | | | | | | | flow (#7625) This is so the user is warned about the username not being valid as soon as possible, rather than only once they've finished UIA.
* | Fix exceptions when fetching events from a down host. (#7622)Erik Johnston2020-06-031-0/+1
| | | | | | We already caught some exceptions, but not all.
* | `synctl restart` should start synapse if it wasn't running (#7624)Richard van der Hoff2020-06-031-0/+1
| |
* | Switch back to upstream dh-virtualenv (#7621)Richard van der Hoff2020-06-031-0/+1
| | | | | | | | | | | | Upstream have merged our changes (https://github.com/spotify/dh-virtualenv/pull/300), so let's switch back to it instead of using our fork.
* | Clean up exception handling in SAML2ResponseResource (#7614)Richard van der Hoff2020-06-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | * Expose `return_html_error`, and allow it to take a Jinja2 template instead of a raw string * Clean up exception handling in SAML2ResponseResource * use the existing code in `return_html_error` instead of re-implementing it (giving it a jinja2 template rather than inventing a new form of template) * do the exception-catching in the REST layer rather than in the handler layer, to make sure we catch all exceptions.
* | Mention #synapse:matrix.org in README troubleshooting (#7603)Andrew Morgan2020-06-011-0/+1
| | | | | | Just in case people head straight to the troubleshooting section and find themselves at a dead end.
* | Advertise Python 3.8 support in setup.py (#7602)Andrew Morgan2020-06-011-0/+1
| | | | | | Synapse supports Python 3.8. We've been using it in CI for a while now.
* | Fix a bug in automatic user creation with m.login.jwt. (#7585)Olof Johansson2020-06-011-0/+1
| |
* | Process cross-signing keys when resyncing device lists (#7594)Brendan Abolivier2020-06-011-0/+1
| | | | | | It looks like `user_device_resync` was ignoring cross-signing keys from the results received from the remote server. This patch fixes this, by processing these keys using the same process `_handle_signing_key_updates` does (and effectively factor that part out of that function).
* | Email notifications for new users when creating via the Admin API. (#7267)Dirk Klimpel2020-06-011-0/+1
| |
* | Improve performance of _get_state_groups_from_groups_txn (#7567)Dagfinn Ilmari Mannsåker2020-06-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The query keeps showing up in my slow query log. This changes the plan under the top-level Sort node from ``` WindowAgg (cost=280335.88..292963.15 rows=561212 width=80) (actual time=138.651..160.562 rows=27112 loops=1) -> Sort (cost=280335.88..281738.91 rows=561212 width=84) (actual time=138.597..140.622 rows=27112 loops=1) Sort Key: state_groups_state.type, state_groups_state.state_key, state_groups_state.state_group Sort Method: quicksort Memory: 4581kB -> Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=21.548..47.657 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=21.526..21.535 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=21.280..21.493 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.005..0.991 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` to ``` Nested Loop (cost=2.83..226745.22 rows=561212 width=84) (actual time=24.194..52.834 rows=27112 loops=1) -> HashAggregate (cost=2.27..3.28 rows=101 width=8) (actual time=24.130..24.138 rows=20 loops=1) Group Key: state.state_group -> CTE Scan on state (cost=0.00..2.02 rows=101 width=8) (actual time=23.887..24.113 rows=20 loops=1) -> Index Scan using state_groups_state_type_idx on state_groups_state (cost=0.56..2189.40 rows=5557 width=84) (actual time=0.016..1.159 rows=1356 loops=20) Index Cond: (state_group = state.state_group) ``` This cuts the execution time from ~190ms to ~130ms, i.e. a reduction of ~30%. The full plans are visualised at https://explain.depesz.com/s/WpbT and https://explain.depesz.com/s/KlEk Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Convert groups local and server to async/await. (#7600)Patrick Cloke2020-06-011-0/+1
| |
* | Don't fail all of an iteration of the device list retry loop on error (#7609)Brendan Abolivier2020-06-011-0/+1
| | | | | | Without this patch, if an error happens which isn't caught by `user_device_resync`, then `_maybe_retry_device_resync` would fail, without retrying the next users in the iteration. This patch fixes this so that it now only logs an error in this case.
* | Use upsert when inserting read receipts (#7607)Dagfinn Ilmari Mannsåker2020-06-011-0/+1
| | | | | | | | | | Fixes #7469 Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* | Update OpenBSD installation instructions (#7587)hashashini2020-05-301-0/+1
| | | | | | | | Synapse was added to the ports tree in Nov, 2019 by Renaud Allard (https://marc.info/?l=openbsd-ports&m=157417848805329). With the release of OpenBSD 6.7 on May 22, 2020 a pre-compiled binary is available as well.
* | Fix 'FederationGroupsRoomsServlet' API when group has room server is not in. ↵Erik Johnston2020-05-291-0/+1
| | | | | | | | (#7599)