summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Fix device list update stream ids going backward (#7158)Richard van der Hoff2020-04-031-0/+1
| | | | | | | | | | | | | | | | Occasionally we could get a federation device list update transaction which looked like: ``` [ {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}} ] ``` Having `stream_ids` which are lower than `prev_ids` looks odd. It might work (I'm not actually sure), but in any case it doesn't seem like a reasonable thing to expect other implementations to support.
* Support SAML in the user interactive authentication workflow. (#7102)Patrick Cloke2020-04-011-0/+1
|
* Allow admins to create aliases when they are not in the room (#7191)Patrick Cloke2020-04-011-0/+1
|
* Update postgres.md (#7119)siroccal2020-04-011-0/+1
|
* Remove connections per replication stream metric. (#7195)Erik Johnston2020-04-011-0/+1
| | | | | This broke in a recent PR (#7024) and is no longer useful due to all replication clients implicitly subscribing to all streams, so let's just remove it.
* Improve TURN documentation. (#7167)Jostein Kjønigsen2020-03-311-0/+1
|
* Fix "'NoneType' has no attribute start|stop" logcontext errors (#7181)Richard van der Hoff2020-03-311-0/+1
| | | | Fixes #7179.
* Fill in the 'default' field for user-defined push rules (#6639)Karlinde2020-03-311-0/+1
| | | Signed-off-by: Karl Linderhed <git@karlinde.se>
* Only setdefault for signatures if device has key_json (#7177)Andrew Morgan2020-03-311-0/+1
|
* Fix use of async/await in media code (#7184)Patrick Cloke2020-03-311-0/+1
|
* Fix a bug which could cause incorrect 'cyclic dependency' error. (#7178)Richard van der Hoff2020-03-311-0/+1
| | | | | | | | If there was an exception setting up one of the attributes of the Homeserver god object, then future attempts to fetch that attribute would raise a confusing "Cyclic dependency" error. Let's make sure that we clear the `building` flag so that we just get the original exception. Ref: #7169
* Rewrite prune_old_outbound_device_pokes for efficiency (#7159)Richard van der Hoff2020-03-301-0/+1
| | | | make sure we clear out all but one update for the user
* Transfer alias mappings when joining an upgraded room (#6946)Andrew Morgan2020-03-301-0/+1
|
* Fix a small typo in the `metrics_flags` config option. (#7171)Andrew Morgan2020-03-301-0/+1
|
* Remove usage of "conn_id" for presence. (#7128)Erik Johnston2020-03-301-0/+1
| | | | | | | | | | | | | | | | * Remove `conn_id` usage for UserSyncCommand. Each tcp replication connection is assigned a "conn_id", which is used to give an ID to a remotely connected worker. In a redis world, there will no longer be a one to one mapping between connection and instance, so instead we need to replace such usages with an ID generated by the remote instances and included in the replicaiton commands. This really only effects UserSyncCommand. * Add CLEAR_USER_SYNCS command that is sent on shutdown. This should help with the case where a synchrotron gets restarted gracefully, rather than rely on 5 minute timeout.
* Merge pull request #7160 from ↵David Baker2020-03-301-0/+1
|\ | | | | | | | | matrix-org/dbkr/always_send_own_device_list_updates Always send the user updates to their own device list
| * changelogDavid Baker2020-03-271-0/+1
| |
* | Merge pull request #7157 from matrix-org/rev.outbound_device_pokes_testsRichard van der Hoff2020-03-301-0/+1
|\ \ | | | | | | Add tests for outbound device pokes
| * | Add tests for outbound device pokesRichard van der Hoff2020-03-271-0/+1
| | |
* | | Add developer documentation for running a local CAS server (#7147)Patrick Cloke2020-03-301-0/+1
| | |
* | | Always whitelist the login fallback for SSO (#7153)Richard van der Hoff2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | That fallback sets the redirect URL to itself (so it can process the login token then return gracefully to the client). This would make it pointless to ask the user for confirmation, since the URL the confirmation page would be showing wouldn't be the client's.
* | | Improve the UX of the login fallback when using SSO (#7152)Brendan Abolivier2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.
* | | Admin API to join users to a room. (#7051)Dirk Klimpel2020-03-271-0/+1
| | |
* | | Add options to prevent users from changing their profile. (#7096)Dirk Klimpel2020-03-271-0/+1
| | |
* | | update debian installation instructions to recommend installing `virtualenv` ↵txt-file2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of `python3-virtualenv` (#6892) * change debian package from python3-virtualenv to virtualenv The virtualenv package is needed for the virtualenv command. The virtualenv package depends on python3-virtualenv (at least since debian jessie) so there is no need to specify python3-virtualenv additionally. Signed-off-by: Vieno Hakkerinen <vieno@hakkerinen.eu> * Add changelog Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
* | | Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean (#7150)Andrew Morgan2020-03-271-0/+1
| | |
* | | Only import sqlite3 when type checking (#7155)David Vo2020-03-271-0/+1
| |/ |/| | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
* | Merge pull request #7151 from matrix-org/jaywink/saml-redirect-fixJason Robinson2020-03-261-0/+1
|\ \ | | | | | | Allow RedirectResponse in SAML response handler
| * | Update changelog.d/7151.bugfixJason Robinson2020-03-261-1/+1
| | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | Allow RedirectResponse in SAML response handlerJason Robinson2020-03-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Allow custom SAML handlers to redirect after processing an auth response. Fixes #7149 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | | Refactor the CAS code (move the logic out of the REST layer to a handler) ↵Patrick Cloke2020-03-261-0/+1
| | | | | | | | | | | | (#7136)
* | | Don't default to an invalid sqlite config if no database configuration is ↵Nektarios Katakis2020-03-261-0/+1
| | | | | | | | | | | | provided (#6573)
* | | Allow server admins to define and enforce a password policy (MSC2000). (#7118)Dirk Klimpel2020-03-261-0/+1
|/ /
* | Validate that the session is not modified during UI-Auth (#7068)Patrick Cloke2020-03-261-0/+1
| |
* | Remove unused captcha_bypass_secret option (#7137)Aaron Raimist2020-03-251-0/+1
| | | | | | Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Move catchup of replication streams to worker. (#7024)Erik Johnston2020-03-251-0/+1
| | | | | | This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
* | Various cleanups to INSTALL.md (#7141)Andrew Morgan2020-03-251-0/+1
| |
* | Merge pull request #7133 from matrix-org/erikj/fix_worker_startupErik Johnston2020-03-251-0/+1
|\ \ | | | | | | Fix starting workers when federation sending not split out.
| * | NewsfileErik Johnston2020-03-241-0/+1
| | |
* | | Clean up some LoggingContext stuff (#7120)Richard van der Hoff2020-03-241-0/+1
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.
* | Fix CAS redirect url (#6634)Naugrimm2020-03-241-0/+1
| | | | | | Build the same service URL when requesting the CAS ticket and when calling the proxyValidate URL.
* | Use the proper error code when a canonical alias that does not exist is ↵Patrick Cloke2020-03-231-0/+1
| | | | | | | | used. (#7109)
* | Update pre-built package name for FreeBSD (#7107). (#7107)Kartikaya Gupta (kats)2020-03-231-0/+1
| | | | | | Signed-off-by: Kartikaya Gupta <kats@trevize.staktrace.com>
* | Convert `*StreamRow` classes to inner classes (#7116)Richard van der Hoff2020-03-231-0/+1
| | | | | | | | | | This just helps keep the rows closer to their streams, so that it's easier to see what the format of each stream is.
* | Fix processing of `groups` stream, and use symbolic names for streams (#7117)Richard van der Hoff2020-03-231-0/+1
| | | | | | | | | | | | `groups` != `receipts` Introduced in #6964
* | Set Referrer-Policy to no-referrer for media (#7009)Dionysis Grigoropoulos2020-03-231-0/+1
| |
* | Clean-up some auth/login REST code (#7115)Patrick Cloke2020-03-201-0/+1
| |
* | Improve database configuration docs (#6988)Richard van der Hoff2020-03-201-0/+1
| | | | | | | | | | Attempts to clarify the sample config for databases, and add some stuff about tcp keepalives to `postgres.md`.
* | Remove concept of a non-limited stream. (#7011)Erik Johnston2020-03-201-0/+1
| |
* | Convert some of the media REST code to async/await (#7110)Patrick Cloke2020-03-201-0/+1
| |
* | Fix a bug in the federation API which could cause occasional "Failed to get ↵Patrick Cloke2020-03-191-0/+1
| | | | | | | | PDU" errors (#7089).
* | Change device list streams to have one row per ID (#7010)Erik Johnston2020-03-191-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add 'device_lists_outbound_pokes' as extra table. This makes sure we check all the relevant tables to get the current max stream ID. Currently not doing so isn't problematic as the max stream ID in `device_lists_outbound_pokes` is the same as in `device_lists_stream`, however that will change. * Change device lists stream to have one row per id. This will make it possible to process the streams more incrementally, avoiding having to process large chunks at once. * Change device list replication to match new semantics. Instead of sending down batches of user ID/host tuples, send down a row per entity (user ID or host). * Newsfile * Remove handling of multiple rows per ID * Fix worker handling * Comments from review
| * \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2020-03-025-1/+4
| |\ \ | | | | | | | | | | | | erikj/fixup_devices_stream
| * | | NewsfileErik Johnston2020-02-281-0/+1
| | | |
* | | | 1.12.0rc1Richard van der Hoff2020-03-1958-58/+0
| | | |
* | | | Fix concurrent modification errors in pusher metrics (#7106)Richard van der Hoff2020-03-191-0/+1
| | | | | | | | | | | | add a lock to try to make this metric actually work
* | | | Add prometheus metrics for the number of active pushers (#7103)Richard van der Hoff2020-03-191-0/+1
| | | |
* | | | Move pusherpool startup into _base.setup (#7104)Richard van der Hoff2020-03-191-0/+1
| | | | | | | | | | | | | | | | | | | | This should be safe to do on all workers/masters because it is guarded by a config option which will ensure it is only actually done on the worker assigned as a pusher.
* | | | Improve get auth chain difference algorithm. (#7095)Erik Johnston2020-03-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was originally implemented by pulling the full auth chain of all state sets out of the database and doing set comparison. However, that can take a lot work if the state and auth chains are large. Instead, lets try and fetch the auth chains at the same time and calculate the difference on the fly, allowing us to bail early if all the auth chains converge. Assuming that the auth chains do converge more often than not, this should improve performance. Hopefully.
* | | | Add an option to the set password API to choose whether to logout other ↵Patrick Cloke2020-03-181-0/+1
| | | | | | | | | | | | | | | | devices. (#7085)
* | | | Update INSTALL.md updated CentOS8 install instructions (#6925)Richard von Kellner2020-03-171-0/+1
| | | |
* | | | Share SSL contexts for non-federation requests (#7094)Richard van der Hoff2020-03-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Extends #5794 etc to the SimpleHttpClient so that it also applies to non-federation requests. Fixes #7092.
* | | | Set charset to utf-8 when adding headers for certain text content types (#7044)The Stranjer2020-03-171-0/+1
| | | | | | | | | | | | | | | | Fixes #7043
* | | | Remove unused federation endpoint (`query_auth`) (#7026)Patrick Cloke2020-03-171-0/+1
| | | |
* | | | Remove special casing of `m.room.aliases` events (#7034)Patrick Cloke2020-03-171-0/+1
| | | |
* | | | Revert "Add options to disable setting profile info for prevent changes. ↵Richard van der Hoff2020-03-171-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7053)" This reverts commit 54dd28621b070ca67de9f773fe9a89e1f4dc19da, reversing changes made to 6640460d054e8f4444046a34bdf638921b31c01e.
* | | | Populate the room version from state events (#7070)Brendan Abolivier2020-03-161-0/+1
| | | | | | | | | | | | | | | | | | | | Fixes #7065 This is basically the same as https://github.com/matrix-org/synapse/pull/6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.
* | | | Fix buggy condition in account validity handler (#7074)Brendan Abolivier2020-03-161-0/+1
| | | |
* | | | Merge pull request #7067 from matrix-org/babolivier/saml_error_moarBrendan Abolivier2020-03-131-0/+1
|\ \ \ \ | | | | | | | | | | Move the default SAML2 error HTML to a dedicated file
| * | | | ChangelogBrendan Abolivier2020-03-111-0/+1
| | | | |
* | | | | Add type annotations and comments to auth handler (#7063)Patrick Cloke2020-03-121-0/+1
| | | | |
* | | | | ChangelogBrendan Abolivier2020-03-111-0/+1
|/ / / /
* | | | Add options to disable setting profile info for prevent changes. (#7053)Brendan Abolivier2020-03-101-0/+1
|\ \ \ \
| * | | | updates after reviewdklimpel2020-03-091-1/+1
| | | | |
| * | | | changelogdklimpel2020-03-081-0/+1
| | |/ / | |/| |
* | | | ChangelogBrendan Abolivier2020-03-101-0/+1
| | | |
* | | | Merge pull request #7055 from ↵Brendan Abolivier2020-03-091-0/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | matrix-org/babolivier/get_time_of_last_push_action_before Move get_time_of_last_push_action_before to the EventPushActionsWorkerStore
| * | | | ChangelogBrendan Abolivier2020-03-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | It's the same as in #6964 since it's the most likely cause of the bug and that change hasn't been released yet.
* | | | | Remove special auth and redaction rules for aliases events in experimental ↵Patrick Cloke2020-03-091-0/+1
| | | | | | | | | | | | | | | | | | | | room ver. (#7037)
* | | | | Update routing of fallback auth in the worker docs. (#7048)Patrick Cloke2020-03-091-0/+1
| | | | |
* | | | | Merge pull request #7045 from matrix-org/babolivier/room_keys_checkBrendan Abolivier2020-03-091-0/+1
|\ \ \ \ \ | | | | | | | | | | | | Make sure that is_verified is a boolean when processing room keys
| * | | | | ChangelogBrendan Abolivier2020-03-061-0/+1
| |/ / / /
* | | | | Add type hints to logging/context.py (#6309)Neil Pilgrim2020-03-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add type hints to logging/context.py Signed-off-by: neiljp (Neil Pilgrim) <github@kepier.clara.net>
* | | | | Break down monthly active users by appservice_id (#7030)Neil Johnson2020-03-061-0/+1
|/ / / / | | | | | | | | | | | | | | | | * Break down monthly active users by appservice_id and emit via prometheus. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | | | Convert remote key resource REST layer to async/await. (#7020)Patrick Cloke2020-03-051-0/+1
| | | |
* | | | Store room_versions in EventBase objects (#6875)Richard van der Hoff2020-03-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a bit fiddly because it all has to be done on one fell swoop: * Wherever we create a new event, pass in the room version (and check it matches the format version) * When we prune an event, use the room version of the unpruned event to create the pruned version. * When we pass an event over the replication protocol, pass the room version over alongside it, and use it when deserialising the event again.
* | | | ChangelogBrendan Abolivier2020-03-041-0/+1
| | | |
* | | | Allow deleting an alias if the user has sufficient power level (#6986)Patrick Cloke2020-03-041-0/+1
| | | |
* | | | Read the room version from database when fetching events (#6874)Richard van der Hoff2020-03-041-0/+1
| | | | | | | | | | | | | | | | | | | | This is a precursor to giving EventBase objects the knowledge of which room version they belong to.
* | | | Merge branch 'master' into developBrendan Abolivier2020-03-031-1/+0
|\ \ \ \ | | |_|/ | |/| |
| * | | v1.11.1Brendan Abolivier2020-03-032-2/+0
| | | |
| * | | Fixed set a user as an admin with the new API (#6928)Dirk Klimpel2020-03-021-0/+1
| | | | | | | | | | | | | | | | Fix #6910
* | | | Validate the alt_aliases property of canonical alias events (#6971)Patrick Cloke2020-03-031-0/+1
| |/ / |/| |
* | | Always return a deferred from `get_current_state_deltas`. (#7019)Erik Johnston2020-03-021-0/+1
| | | | | | | | | | | | | | | This currently causes presence notify code to log exceptions when there is no state changes to process. This doesn't actually cause any problems as we'd simply do nothing anyway.
* | | Fix py35-old CI by using native tox. (#7018)Erik Johnston2020-03-021-0/+1
| | | | | | | | | | | | | | | I'm not really sure how this was going wrong, but this seems like the right approach anyway.
* | | remove spurious changelogRichard van der Hoff2020-03-021-1/+0
| | |
* | | Fix last date for ACMEv1 install (#7015)Uday Bansal2020-02-291-0/+1
| | | | | | | | | | | | | | | | | | Support for getting TLS certificates through ACMEv1 ended on November 2019. Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>
* | | Add some type annotations to the federation base & client classes (#6995)Patrick Cloke2020-02-281-0/+1
| |/ |/|
* | Fixed set a user as an admin with the new API (#6928)Dirk Klimpel2020-02-281-0/+1
| | | | | | Fix #6910
* | Merge remote-tracking branch 'origin/release-v1.11.1' into developPatrick Cloke2020-02-271-0/+1
|\|
| * Cast a coroutine into a Deferred in the federation base (#6996)Patrick Cloke2020-02-261-0/+1
| | | | | | | | Properly convert a coroutine into a Deferred in federation_base to fix an error when joining a room.
| * 1.11.0 v1.11.0 github/release-v1.11.0 release-v1.11.0Richard van der Hoff2020-02-211-1/+0
| |
| * Small grammar fixes to the ACME v1 deprecation notice (#6944)Andrew Morgan2020-02-211-0/+1
| | | | | | Some small fixes to the copy in #6907.
* | Don't refuse to start worker if media listener configured. (#7002)Erik Johnston2020-02-271-0/+1
| | | | | | | | | | | | | | | | Instead lets just warn if the worker has a media listener configured but has the media repository disabled. Previously non media repository workers would just ignore the media listener.
* | set worker_app for frontend proxy test (#7003)Richard van der Hoff2020-02-271-0/+1
| | | | | | to stop the federationhandler trying to do master stuff
* | Expose common commands via snap run interface to allow easier invocation (#6315)James2020-02-271-0/+1
| | | | | | | | | | Signed-off-by: James Hebden <james@ec0.io>
* | Add some type annotations in `synapse.storage` (#6987)Richard van der Hoff2020-02-271-0/+1
| | | | | | | | | | I cracked, and added some type definitions in synapse.storage.
* | Store room version on invite (#6983)Richard van der Hoff2020-02-261-0/+1
| | | | | | | | | | When we get an invite over federation, store the room version in the rooms table. The general idea here is that, when we pull the invite out again, we'll want to know what room_version it belongs to (so that we can later redact it if need be). So we need to store it somewhere...
* | Port PresenceHandler to async/await (#6991)Erik Johnston2020-02-261-0/+1
| |
* | Updated warning for incorrect database collation/ctype (#6985)Uday Bansal2020-02-261-0/+1
| | | | | | Signed-off-by: Uday Bansal <43824981+udaybansal19@users.noreply.github.com>
* | Ensure 'deactivated' parameter is a boolean on user admin API, Fix error ↵Andrew Morgan2020-02-261-0/+1
| | | | | | | | handling of call to deactivate user (#6990)
* | Sanity-check database before running upgrades (#6982)Richard van der Hoff2020-02-251-0/+1
| | | | | | | | | | | | Some of the database deltas rely on `config.server_name` being set correctly, so we should check that it is before running the deltas. Fixes #6870.
* | Merge worker apps into one. (#6964)Erik Johnston2020-02-251-0/+1
| |
* | contrib/docker: remove quotes for POSTGRES_INITDB_ARGS (#6984)Fridtjof Mund2020-02-251-0/+1
| | | | | | | | | | I made a mistake in https://github.com/matrix-org/synapse/pull/6921 - the quotes break the postgres container's startup script (or docker-compose), which makes initdb fail: https://github.com/matrix-org/synapse/pull/6921#issuecomment-590657154 Signed-off-by: Fridtjof Mund <fridtjof@das-labor.org>
* | Remove redundant store_room call (#6979)Richard van der Hoff2020-02-241-0/+1
| | | | | | | | | | `_process_received_pdu` is only called by `on_receive_pdu`, which ignores any events for unknown rooms, so this is redundant.
* | Upsert room version when we join over federation (#6968)Richard van der Hoff2020-02-241-0/+1
| | | | | | | | | | | | | | | | This is intended as a precursor to storing room versions when we receive an invite over federation, but has the happy side-effect of fixing #3374 at last. In short: change the store_room with try/except to a proper upsert which updates the right columns.
* | Fix minor issues with email config (#6962)Richard van der Hoff2020-02-241-0/+1
| | | | | | | | | | | | * Give `notif_template_html`, `notif_template_text` default values (fixes #6960) * Don't complain if `smtp_host` and `smtp_port` are unset, since they have sensible defaults (fixes #6961) * Set the example for `enable_notifs` to `True`, for consistency and because it's more useful * Raise errors as ConfigError rather than RuntimeError for nicer formatting
* | No longer use room alias events to calculate room names for push ↵Patrick Cloke2020-02-211-0/+1
| | | | | | | | notifications. (#6966)
* | Change displayname of user as admin in rooms (#6876)Dirk Klimpel2020-02-211-0/+1
| |
* | Stop returning aliases as part of the room list. (#6970)Patrick Cloke2020-02-211-0/+1
| |
* | Publishing/removing from the directory requires a power level greater than ↵Patrick Cloke2020-02-211-0/+1
| | | | | | | | canonical aliases.
* | Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)Patrick Cloke2020-02-211-0/+1
| | | | | | | | Ensure good comprehension hygiene using flake8-comprehensions.
* | changelogRichard van der Hoff2020-02-211-0/+1
| |
* | Do not send alias events when creating / upgrading a room (#6941)Patrick Cloke2020-02-201-0/+1
| | | | | | Stop emitting room alias update events during room creation/upgrade.
* | don't insert into the device table for remote cross-signing keys (#6956)Hubert Chathi2020-02-201-0/+1
| |
* | Add some clarifications to README.md in the database schema directory. (#6615)Ruben Barkow-Kuder2020-02-201-0/+1
| | | | | | Signed-off-by: Ruben Barkow-Kuder <github@r.z11.de>
* | Minor perf fixes to `get_auth_chain_ids`.Erik Johnston2020-02-191-0/+1
| |
* | Freeze allocated objects on startup. (#6953)Erik Johnston2020-02-191-0/+1
| | | | | | | | | | This may make gc go a bit faster as the gc will know things like caches/data stores etc. are frozen without having to check.
* | Reduce auth chains fetched during v2 state res. (#6952)Erik Johnston2020-02-191-0/+1
|/ | | | | | The state res v2 algorithm only cares about the difference between auth chains, so we can pass in the known common state to the `get_auth_chain` storage function so that it can ignore those events.
* 1.11.0rc1Richard van der Hoff2020-02-1955-55/+0
|
* Revert `get_auth_chain_ids` changes (#6951)Erik Johnston2020-02-191-0/+1
|
* Merge pull request #6949 from matrix-org/rav/list_room_aliases_peekableRichard van der Hoff2020-02-191-0/+1
|\ | | | | Make room alias lists peekable
| * changelogRichard van der Hoff2020-02-191-0/+1
| |
* | Merge pull request #6940 from matrix-org/babolivier/federate.mdBrendan Abolivier2020-02-191-0/+1
|\ \ | | | | | | Clean up and update federation docs
| * | ChangelogBrendan Abolivier2020-02-181-0/+1
| | |
* | | Move MSC2432 stuff onto unstable prefix (#6948)Richard van der Hoff2020-02-191-0/+1
| | | | | | | | | it's not in the spec yet, so needs to be unstable. Also add a feature flag for it. Also add a test for admin users.
* | | Tiny optimisation for _get_handler_for_request (#6950)Richard van der Hoff2020-02-191-0/+1
| | | | | | | | | | | | we have hundreds of path_regexes (see #5118), so let's not convert the same bytes to str for each of them.
* | | Increase DB/CPU perf of `_is_server_still_joined` check. (#6936)Erik Johnston2020-02-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Increase DB/CPU perf of `_is_server_still_joined` check. For rooms with large amount of state a single user leaving could cause us to go and load a lot of membership events and then pull out membership state in a large number of batches. * Newsfile * Update synapse/storage/persist_events.py Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Fix adding if too soon * Update docstring * Review comments * Woops typo Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Merge pull request #6945 from matrix-org/babolivier/fix-retention-debug-logBrendan Abolivier2020-02-191-0/+1
|\ \ \ | | | | | | | | Fix log in message retention purge jobs
| * | | Update changelog.d/6945.bugfixBrendan Abolivier2020-02-191-1/+1
| | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | ChangelogBrendan Abolivier2020-02-181-0/+1
| | | |
* | | | Limit size of get_auth_chain_ids query (#6947)Erik Johnston2020-02-191-0/+1
| |_|/ |/| |
* | | Implement GET /_matrix/client/r0/rooms/{roomId}/aliases (#6939)Richard van der Hoff2020-02-181-0/+1
| | | | | | | | | | | | | | | per matrix-org/matrix-doc#2432
* | | Merge pull request #6872 from matrix-org/rav/dictpropertyRichard van der Hoff2020-02-181-0/+1
|\ \ \ | | | | | | | | Rewrite _EventInternalMetadata to back it with a dict
| * | | changelogRichard van der Hoff2020-02-141-0/+1
| | | |
* | | | Merge pull request #6907 from matrix-org/babolivier/acme-configBrendan Abolivier2020-02-181-0/+1
|\ \ \ \ | |_|/ / |/| | | Add mention and warning about ACME v1 deprecation to the TLS config
| * | | ChangelogBrendan Abolivier2020-02-131-0/+1
| | | |
* | | | Increase perf of `get_auth_chain_ids` used in state res v2. (#6937)Erik Johnston2020-02-181-0/+1
| | | | | | | | | | | | We do this by moving the recursive query to be fully in the DB.
* | | | Fix worker docs to point `/publicised_groups` API correctly. (#6938)Erik Johnston2020-02-181-0/+1
| | | |
* | | | Merge pull request #6909 from matrix-org/babolivier/acme-installBrendan Abolivier2020-02-181-0/+1
|\ \ \ \ | | | | | | | | | | Update INSTALL.md to recommend reverse proxying and warn about ACMEv1 deprecation
| * | | | ChangelogBrendan Abolivier2020-02-131-0/+1
| | |_|/ | |/| |
* | | | Stop sending events when creating or deleting aliases (#6904)Patrick Cloke2020-02-181-0/+1
| | | | | | | | | | | | Stop sending events when creating or deleting associations (room aliases). Send an updated canonical alias event if one of the alt_aliases is deleted.
* | | | Kill off deprecated "config-on-the-fly" docker mode (#6918)Richard van der Hoff2020-02-181-0/+1
| | | | | | | | | | | | | | | | | | | | Lots of people seem to get confused by this mode, and it's been deprecated since Synapse 1.1.0. It's time for it to go.
* | | | #6924 has been released in 1.10.1Richard van der Hoff2020-02-171-1/+0
| | | |
* | | | Raise the default power levels for invites, tombstones and server acls (#6834)Andrew Morgan2020-02-171-0/+1
| | | |
* | | | wait for current_state_events_membership before ↵Richard van der Hoff2020-02-171-0/+1
| | | | | | | | | | | | | | | | delete_old_current_state_events (#6924)
* | | | Add type hints to the spam check module (#6915)Patrick Cloke2020-02-141-0/+1
| | | | | | | | | | | | | | | | Add typing information to the spam checker modules.
* | | | contrib/docker: Ensure correct encoding and locale settings on DB creation ↵Fridtjof Mund2020-02-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | (#6921) Signed-off-by: Fridtjof Mund <fridtjof@das-labor.org>
* | | | Add a warning about indentation to generated config (#6920)Richard van der Hoff2020-02-141-0/+1
| | | | | | | | | | | | Fixes #6916.
* | | | Convert the directory handler tests to use HomeserverTestCase (#6919)Patrick Cloke2020-02-141-0/+1
| |_|/ |/| | | | | Convert directory handler tests to use HomeserverTestCase.
* | | Filter the results of user directory searching via the spam checker (#6888)Patrick Cloke2020-02-141-0/+1
|/ / | | | | Add a method to the spam checker to filter the user directory results.
* | Update changelog for #6905 to group it with upcoming PRsBrendan Abolivier2020-02-131-1/+1
| |
* | Add documentation for the spam checker module (#6906)Patrick Cloke2020-02-131-0/+1
| | | | | | Add documentation for the spam checker.
* | Merge pull request #6905 from matrix-org/babolivier/acme.mdBrendan Abolivier2020-02-131-0/+1
|\ \ | | | | | | Update ACME.md to mention ACME v1 deprecation
| * | ChangelogBrendan Abolivier2020-02-121-0/+1
| |/
* / Remove m.lazy_load_members from unstable features since it is in CS r0.5.0 ↵Aaron Raimist2020-02-131-0/+1
|/ | | | | | | (#6877) Fixes #5528
* Merge pull request #6891 from matrix-org/babolivier/retention-doc-amendBrendan Abolivier2020-02-121-0/+1
|\ | | | | Spell out that the last event sent to a room won't be deleted by a purge
| * Update the changelog fileBrendan Abolivier2020-02-111-1/+1
| |
| * ChangelogBrendan Abolivier2020-02-111-0/+1
| |
* | Return a 404 for admin api user lookup if user not found (#6901)Andrew Morgan2020-02-121-0/+1
| |
* | Use BSD-compatible in-place editing for sed. (#6887)Patrick Cloke2020-02-121-0/+1
|/
* Reject device display names that are too long (#6882)Patrick Cloke2020-02-101-0/+1
| | | | | | | | * Reject device display names that are too long. Too long is currently defined as 100 characters in length. * Add a regression test for rejecting a too long device display name.
* Add an additional test to the SyTest blacklist for worker mode. (#6883)Patrick Cloke2020-02-101-0/+1
|
* Merge tag 'v1.10.0rc3' into developRichard van der Hoff2020-02-101-1/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.10.0rc3 (2020-02-10) ============================== Features -------- - Filter out m.room.aliases from the CS API to mitigate abuse while a better solution is specced. ([\#6878](https://github.com/matrix-org/synapse/issues/6878)) Internal Changes ---------------- - Fix continuous integration failures with old versions of `pip`, which were introduced by a release of the `zipp` library. ([\#6880](https://github.com/matrix-org/synapse/issues/6880))
| * 1.10.0rc3 v1.10.0rc3Richard van der Hoff2020-02-102-2/+0
| |
| * filter out m.room.aliases from the CS API until a better solution is specced ↵Matthew Hodgson2020-02-101-0/+1
| | | | | | | | | | (#6878) We're in the middle of properly mitigating spam caused by malicious aliases being added to a room. However, until this work fully lands, we temporarily filter out all m.room.aliases events from /sync and /messages on the CS API, to remove abusive aliases. This is considered acceptable as m.room.aliases events were never a reliable record of the given alias->id mapping and were purely informational, and in their current state do more harm than good.
* | Merge remote-tracking branch 'origin/release-v1.10.0' into developRichard van der Hoff2020-02-101-0/+1
|\|
| * Update setuptools for python 3.5 tests (#6880)Richard van der Hoff2020-02-101-0/+1
| | | | | | Workaround for jaraco/zipp#40
| * 1.10.0rc2Erik Johnston2020-02-063-3/+0
| |
| * Check sender_key matches on inbound encrypted events. (#6850)Erik Johnston2020-02-051-0/+1
| | | | | | If they don't then the device lists are probably out of sync.
| * Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-051-0/+1
| | | | | | add device signatures to device key query results
| * Fix detecting unknown devices from remote encrypted events. (#6848)Erik Johnston2020-02-041-0/+1
| | | | | | | | | | | | | | | | We were looking at the wrong event type (`m.room.encryption` vs `m.room.encrypted`). Also fixup the duplicate `EvenTypes` entries. Introduced in #6776.
* | Add support for putting fed user query API on workers (#6873)Erik Johnston2020-02-071-0/+1
| |
* | Remove unused `get_room_stats_state` method. (#6869)Richard van der Hoff2020-02-071-0/+1
| |
* | Add a `make_event_from_dict` method (#6858)Richard van der Hoff2020-02-071-0/+1
| | | | | | | | | | | | | | ... and use it in places where it's trivial to do so. This will make it easier to pass room versions into the FrozenEvent constructors.
* | Add typing to synapse.federation.sender (#6871)Erik Johnston2020-02-071-0/+1
| |
* | Allow moving group read APIs to workers (#6866)Erik Johnston2020-02-071-0/+1
| |
* | Admin api to add an email address (#6789)Dirk Klimpel2020-02-071-0/+1
| |
* | remove unused room_version_to_event_format (#6857)Richard van der Hoff2020-02-071-0/+1
| |
* | Merge pull request #6856 from matrix-org/rav/redact_changes/6Richard van der Hoff2020-02-071-0/+1
|\ \ | | | | | | Pass room_version into `event_from_pdu_json`
| * | Pass room_version into `event_from_pdu_json`Richard van der Hoff2020-02-061-0/+1
| | | | | | | | | | | | It's called from all over the shop, so this one's a bit messy.
* | | Limit the number of events that can be requested when backfilling events (#6864)Patrick Cloke2020-02-061-0/+1
|/ / | | | | Limit the maximum number of events requested when backfilling events.
* | pass room version into FederationClient.send_join (#6854)Richard van der Hoff2020-02-061-0/+1
| | | | | | | | ... which allows us to sanity-check the create event.
* | Allow empty federation_certificate_verification_whitelist (#6849)timfi2020-02-061-0/+1
| |
* | Third party event rules Update (#6781)PeerD2020-02-061-0/+1
| |
* | Reduce amount of logging at INFO level. (#6862)Erik Johnston2020-02-061-0/+1
| | | | | | | | | | | | | | | | A lot of the things we log at INFO are now a bit superfluous, so lets make them DEBUG logs to reduce the amount we log by default. Co-Authored-By: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* | Merge pull request #6823 from matrix-org/rav/redact_changes/5Richard van der Hoff2020-02-061-0/+1
|\ \ | | | | | | pass room versions around
| * | NewsfileRichard van der Hoff2020-02-051-0/+1
| | |
* | | Merge pull request #6855 from matrix-org/clokep/readme-pip-installPatrick Cloke2020-02-051-0/+1
|\ \ \ | |/ / |/| | Add quotes around the pip install target to avoid my shell complaining
| * | Add quotes around pip install target (my shell complained without them).Patrick Cloke2020-02-051-0/+1
| | |
* | | Merge pull request #6840 from matrix-org/rav/federation_client_asyncRichard van der Hoff2020-02-051-0/+1
|\ \ \ | |/ / |/| | Port much of `synapse.federation.federation_client` to async/await
| * | Merge remote-tracking branch 'origin/develop' into rav/federation_client_asyncRichard van der Hoff2020-02-042-0/+2
| |\ \
| * | | newsfileRichard van der Hoff2020-02-031-0/+1
| | | |
* | | | Reduce performance logging to DEBUG (#6833)Michael Kaye2020-02-051-0/+1
| | | | | | | | | | | | | | | | | | | | * Reduce tnx performance logging to DEBUG * Changelog.d
* | | | Database updates to populate rooms.room_version (#6847)Richard van der Hoff2020-02-041-0/+1
| | | | | | | | | | | | We're going to need this so that we can figure out how to handle redactions when fetching events from the database.
* | | | Merge pull request #6844 from matrix-org/uhoreg/cross_signing_fix_device_fedHubert Chathi2020-02-041-0/+1
|\ \ \ \ | | | | | | | | | | add device signatures to device key query results
| * | | | add changelogHubert Chathi2020-02-041-0/+1
| | | | |
* | | | | Update CONTRIBUTING.md about merging PRs. (#6846)Michael Kaye2020-02-041-0/+1
| |_|/ / |/| | |
* | | | Merge pull request #6837 from matrix-org/rav/federation_asyncRichard van der Hoff2020-02-041-0/+1
|\ \ \ \ | |/ / / |/| / / | |/ / Port much of `synapse.handlers.federation` to async/await.
| * | changelogRichard van der Hoff2020-02-031-0/+1
| | |
* | | Add typing to SyncHandler (#6821)Erik Johnston2020-02-031-0/+1
| | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Fix stacktraces when using ObservableDeferred and async/await (#6836)Erik Johnston2020-02-031-0/+1
|/ /
* | Allow URL-encoded user IDs on user admin api paths (#6825)Andrew Morgan2020-02-031-0/+1
| |
* | Fix `room_version` in `on_invite_request` flow (#6827)Richard van der Hoff2020-02-031-0/+1
|/ | | | I messed this up a bit in #6805, but fortunately we weren't actually doing anything with the room_version so it didn't matter that it was a str not a RoomVersion.
* 1.10.0rc1Erik Johnston2020-01-3132-32/+0
|
* Fix deleting of stale marker for device lists (#6819)Erik Johnston2020-01-311-0/+1
| | | | We were in fact only deleting stale marker when we got an incremental update, rather than when we did a full resync.
* pass room_version into compute_event_signature (#6807)Richard van der Hoff2020-01-311-0/+1
|
* Merge pull request #6806 from matrix-org/rav/redact_changes/3Richard van der Hoff2020-01-311-0/+1
|\ | | | | Pass room_version into add_hashes_and_signatures
| * changelogRichard van der Hoff2020-01-301-0/+1
| |
* | Merge pull request #6820 from matrix-org/rav/get_room_version_idRichard van der Hoff2020-01-311-0/+1
|\ \ | | | | | | Make `get_room_version` return a RoomVersion object
| * | newsfileRichard van der Hoff2020-01-311-0/+1
| | |
* | | Fix bug with getting missing auth event during join 500'ed (#6810)Erik Johnston2020-01-311-0/+1
|/ /
* | pass room version into FederationHandler.on_invite_request (#6805)Richard van der Hoff2020-01-301-0/+1
| |
* | Log when we delete room in bg update (#6816)Erik Johnston2020-01-301-0/+1
|/
* MSC2260: Block direct sends of m.room.aliases events (#6794)Richard van der Hoff2020-01-301-0/+1
| | | | | as per MSC2260
* Backgroud update to clean out rooms from current state (#6802)Erik Johnston2020-01-301-0/+1
|
* Resync remote device list when detected as stale. (#6786)Erik Johnston2020-01-301-0/+1
|
* Fix sending server up commands from workers (#6811)Erik Johnston2020-01-301-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* When server leaves room check for stale device lists. (#6801)Erik Johnston2020-01-301-0/+1
| | | | | | | | | When a server leaves a room it may stop sharing a room with remote users, and thus not get any updates to their device lists. So we need to check for this case and delete those device lists from the cache. We don't need to do this if we stop sharing a room because the remote user leaves the room, because we track that case via looking at membership changes.
* When a client asks for remote keys check if should resync. (#6797)Erik Johnston2020-01-301-0/+1
| | | | | | If we detect that the remote users' keys may have changed then we should attempt to resync against the remote server rather than using the (potentially) stale local cache.
* Type defintions for use in refactoring for redaction changes (#6803)Richard van der Hoff2020-01-301-0/+1
| | | | | | | | | | * Bump signedjson to 1.1 ... so that we can use the type definitions * Fix breakage caused by upgrade to signedjson 1.1 Thanks, @illicitonion...
* Remove unused DeviceRow class (#6800)Erik Johnston2020-01-291-0/+1
|
* changelogRichard van der Hoff2020-01-291-0/+1
|
* Fix race in federation sender that delayed device updates. (#6799)Erik Johnston2020-01-291-0/+1
| | | | | | | | | | | | We were sending device updates down both the federation stream and device streams. This mean there was a race if the federation sender worker processed the federation stream first, as when the sender checked if there were new device updates the slaved ID generator hadn't been updated with the new stream IDs and so returned nothing. This situation is correctly handled by events/receipts/etc by not sending updates down the federation stream and instead having the federation sender worker listen on the other streams and poke the transaction queues as appropriate.
* Delete current state when server leaves a room (#6792)Erik Johnston2020-01-291-0/+1
| | | | | | Otherwise its just stale data, which may get deleted later anyway so can't be relied on. It's also a bit of a shotgun if we're trying to get the current state of a room we're not in.
* Fix bug when querying remote user keys that require a resync. (#6796)Erik Johnston2020-01-291-0/+1
| | | | We ended up only returning a single device, rather than all of them.
* Fix outbound federation request metrics (#6795)Erik Johnston2020-01-281-0/+1
|
* Merge pull request #6787 from matrix-org/rav/msc2260Richard van der Hoff2020-01-281-0/+1
|\ | | | | Implement updated auth rules from MSC2260
| * update changelogRichard van der Hoff2020-01-282-1/+1
| |
| * changelogRichard van der Hoff2020-01-281-0/+1
| |
* | Detect unknown remote devices and mark cache as stale (#6776)Erik Johnston2020-01-281-0/+1
|/ | | | We just mark the fact that the cache may be stale in the database for now.
* Pass room version object into event_auth.check and check_redaction (#6788)Richard van der Hoff2020-01-281-0/+1
| | | | | | | These are easier to work with than the strings and we normally have one around. This fixes `FederationHander._persist_auth_tree` which was passing a RoomVersion object into event_auth.check instead of a string.
* Warn if postgres database has non-C locale. (#6734)Erik Johnston2020-01-281-0/+1
| | | As using non-C locale can cause issues on upgrading OS.
* Add `rooms.room_version` column (#6729)Erik Johnston2020-01-271-0/+1
| | | This is so that we don't have to rely on pulling it out from `current_state_events` table.
* Propagate cache invalidates from workers to other workers. (#6748)Erik Johnston2020-01-271-0/+1
| | | Currently if a worker invalidates a cache it will be streamed to master, which then didn't forward those to other workers.
* Merge pull request #6775 from matrix-org/jaywink/worker-docs-tweaksBrendan Abolivier2020-01-271-0/+1
|\ | | | | Clarifications to the workers documentation
| * Formatting of changelogJason Robinson2020-01-271-1/+1
| | | | | | Co-Authored-By: Brendan Abolivier <babolivier@matrix.org>
| * Clarifications to the workers documentationJason Robinson2020-01-241-0/+1
| | | | | | | | | | | | | | | | | | * Add note that user_dir requires disabling user dir updates from the main synapse process. * Add note that federation_reader should have the federation listener resource. Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | Validate client_secret parameter (#6767)Andrew Morgan2020-01-241-0/+1
|/
* Make 'event.redacts' never raise. (#6771)Erik Johnston2020-01-231-0/+1
| | | | | | There are quite a few places that we assume that a redaction event has a corresponding `redacts` key, which is not always the case. So lets cheekily make it so that event.redacts just returns None instead.