summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Add an OSX prompt to manually configure icu4c. (#17069)Neil Johnson2024-04-191-0/+1
| | | Documentation fix.
* Clarify what part of message retention is still experimental (#17099)devonh2024-04-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [X] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [X] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))
* Parse json validation (#16923)Gordan Trevis2024-04-181-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Helpers to transform Twisted requests to Rust http Requests/Responses (#17081)Quentin Gliech2024-04-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds functions to transform a Twisted request to the `http::Request`, and then to send back an `http::Response` through it. It also imports the SynapseError exception so that we can throw that from Rust code directly Example usage of this would be: ```rust use crate::http::{http_request_from_twisted, http_response_to_twisted, HeaderMapPyExt}; fn handler(twisted_request: &PyAny) -> PyResult<()> { let request = http_request_from_twisted(twisted_request)?; let ua: headers::UserAgent = request.headers().typed_get_required()?; if whatever { return Err((crate::errors::SynapseError::new( StatusCode::UNAUTHORIZED, "Whatever".to_owned "M_UNAUTHORIZED", None, None, ))); } let response = Response::new("hello".as_bytes()); http_response_to_twisted(twisted_request, response)?; Ok(()) } ```
* Fix remote receipts for events we don't have (#17096)Erik Johnston2024-04-171-0/+1
| | | Introduced in #17032
* Support for MSC4108 via delegation (#17086)Quentin Gliech2024-04-171-0/+1
| | | | | | | This adds support for MSC4108 via delegation, similar to what has been done for MSC3886 --------- Co-authored-by: Hugh Nimmo-Smith <hughns@element.io>
* Bump minimum required Rust version to 1.66.0 (#17079)Quentin Gliech2024-04-171-0/+1
|
* Parse Integer negative value validation (#16920)Gordan Trevis2024-04-161-0/+1
|
* bugfix: make msc3967 idempotent (#16943)Kegan Dougal2024-04-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MSC3967 was updated recently to make it more robust to network failures: > there is an existing cross-signing master key and it exactly matches the cross-signing master key provided in the request body. If there are any additional keys provided in the request (self signing key, user signing key) they MUST also match the existing keys stored on the server. In other words, the request contains no new keys. If there are new keys, UIA MUST be performed. https://github.com/matrix-org/matrix-spec-proposals/blob/hughns/device-signing-upload-uia/proposals/3967-device-signing-upload-uia.md#proposal This covers the case where the 200 OK is lost in transit so the client retries the upload, only to then get UIA'd. Complement tests: https://github.com/matrix-org/complement/pull/713 - passing example https://github.com/element-hq/synapse/actions/runs/7976948122/job/21778795094?pr=16943#step:7:8820 ### Pull Request Checklist <!-- Please read https://element-hq.github.io/synapse/latest/development/contributing_guide.html before submitting your pull request --> * [x] Pull request is based on the develop branch * [x] Pull request includes a [changelog file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog). The entry should: - Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from `EventStore` to `EventWorkerStore`.". - Use markdown where necessary, mostly for `code blocks`. - End with either a period (.) or an exclamation mark (!). - Start with a capital letter. - Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry. * [x] [Code style](https://element-hq.github.io/synapse/latest/code_style.html) is correct (run the [linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters)) --------- Co-authored-by: reivilibre <oliverw@matrix.org>
* Use receipts `event_stream_ordering` instead of joins (#17032)Nick Mills-Barrett2024-04-121-0/+1
| | | | | | | | | | | | | | | | | | | | Resurrecting https://github.com/matrix-org/synapse/pull/13918. This should reduce IOPs incurred by joining to the events table to lookup stream ordering, which happens in many receipt handling code paths. Like the previous PR I believe sufficient time has passed between the original migration in DB schema 72 and now to merge this as-is. It's highly unlikely that both the migration is still ongoing AND (active) users still have any receipts prior to that date. In the unlikely event there is a receipt without a populated `event_stream_ordering` synapse will behave just as it does now when receipts exist for events that don't (yet): for push action calculation the receipts are just ignored. I've removed the validation on event IDs as this is already covered here: https://github.com/element-hq/synapse/blob/59ceabcb9798793cd4312fdbcced4e612aeda84d/synapse/handlers/receipts.py#L189-L192
* Fix mypy on latest Twisted release (#17036)Erik Johnston2024-04-111-0/+1
| | | | | | `ITransport.abortConnection` isn't a thing, but `HTTPChannel.forceAbortClient` calls it, so lets just use that Fixes https://github.com/element-hq/synapse/issues/16728
* 1.105.0rc1 v1.105.0rc1Andrew Morgan2024-04-1116-16/+0
|
* Stabilize support for MSC4010: push rules & account data. (#17022)Patrick Cloke2024-04-091-0/+1
| | | | | | | See [MSC4010](https://github.com/matrix-org/matrix-spec-proposals/pull/4010), but this is pretty much just removing an experimental flag. Part of #17021
* Stabliize support for MSC3981: recurse /relations (#17023)Patrick Cloke2024-04-091-0/+1
| | | | | | | See [MSC3981](https://github.com/matrix-org/matrix-spec-proposals/pull/3981), this pretty much just removes flags though. Part of #17021
* Also check if first event matches the last in prev batch (#17066)Erik Johnston2024-04-091-0/+1
| | | | | Refinement of #17064 cc @richvdh
* #17039 Issue: Update base_rules.rs (#17043)Sumiran Pokharel2024-04-091-0/+1
| | | | Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Fix PR #16677, a parameter was missing in a function call (#17033)Mathieu Velten2024-04-091-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Add forgotten schema delta (#17054)Erik Johnston2024-04-091-0/+1
| | | This should have been in #17045. Whoops.
* Fixups to #17064 (#17065)Erik Johnston2024-04-081-0/+1
| | | | | Forget a line, and an empty batch is trivially linear. c.f. #17064
* Add back fast path for non-gappy syncs (#17064)Erik Johnston2024-04-081-0/+1
| | | | | | | | | | | PR #16942 removed an invalid optimisation that avoided pulling out state for non-gappy syncs. This causes a large increase in DB usage. c.f. #16941 for why that optimisation was wrong. However, we can still optimise in the simple case where the events in the timeline are a linear chain without any branching/merging of the DAG. cc. @richvdh
* Pull out fewer receipts from DB when doing push (#17049)Erik Johnston2024-04-051-0/+1
| | | | | | | Before we were pulling out *all* read receipts for a user for every event we pushed. Instead let's only pull out the relevant receipts. This also pulled out the event rows for each receipt, causing load on the events table.
* Fix bug in calculating state for non-gappy syncs (#16942)Richard van der Hoff2024-04-043-2/+3
| | | | | | | | | Unfortunately, the optimisation we applied here for non-gappy syncs is not actually valid. Fixes https://github.com/element-hq/synapse/issues/16941. ~~Based on https://github.com/element-hq/synapse/pull/16930.~~ Requires https://github.com/matrix-org/sytest/pull/1374.
* `/sync`: fix bug in calculating `state` response (#16930)Richard van der Hoff2024-04-041-0/+1
| | | | | | | Fix a long-standing issue which could cause state to be omitted from the sync response if the last event was filtered out. Fixes: https://github.com/element-hq/synapse/issues/16928
* Fix bug in `/sync` response for archived rooms (#16932)Richard van der Hoff2024-04-041-0/+1
| | | | | | | | | | | | This PR fixes a very, very niche edge-case, but I've got some more work coming which will otherwise make the problem worse. The bug happens when the syncing user leaves a room, and has a sync filter which includes "left" rooms, but sets the timeline limit to 0. In that case, the state returned in the `state` section is calculated incorrectly. The fix is to pass a token corresponding to the point that the user leaves the room through to `compute_state_delta`.
* Add missing index to `access_tokens` table (#17045)Erik Johnston2024-04-041-0/+1
| | | This was causing sequential scans when using refresh tokens.
* Merge branch 'master' into developErik Johnston2024-04-021-1/+0
|\
| * 1.104.0 v1.104.0 github/release-v1.104 release-v1.104Erik Johnston2024-04-021-1/+0
| |
* | Refactor chain fetching (#17044)Erik Johnston2024-04-021-0/+1
| | | | | | Since these queries are duplicated in two places.
* | Fixups to new push stream (#17038)Erik Johnston2024-03-282-1/+2
| | | | | | Follow on from #17037
* | Add support for moving `/push_rules` off of main process (#17037)Erik Johnston2024-03-281-0/+1
|/
* Merge remote-tracking branch 'origin/develop' into release-v1.104Erik Johnston2024-03-261-0/+1
|\
| * Fix OIDC login regression (#17031)Erik Johnston2024-03-261-0/+1
| | | | | | | | | | Requests may require a User-Agent header, and the change in #16972 accidentally removed it, resulting in requests getting rejected causing login to fail.
* | 1.104.0rc1Erik Johnston2024-03-2622-23/+0
|/
* Ensure that pending to-device events are sent over federation at startup ↵Richard van der Hoff2024-03-221-0/+1
| | | | | | | | | | | | | | (#16925) Fixes https://github.com/element-hq/synapse/issues/16680, as well as a related bug, where servers which we had *never* successfully sent an event to would not be retried. In order to fix the case of pending to-device messages, we hook into the existing `wake_destinations_needing_catchup` process, by extending it to look for destinations that have pending to-device messages. The federation transmission loop then attempts to send the pending to-device messages as normal.
* Add OIDC config to add extra parameters to the authorize URL (#16971)Mathieu Velten2024-03-221-0/+1
|
* Do not refuse to set read_marker if previous event_id is in wrong room (#16990)SpiritCroc2024-03-211-0/+1
|
* Fix reject knocks on deactivating account (#17010)Hanadi2024-03-211-0/+1
|
* generate configuration with correct user in start.py for docker (#16978)Sam Wedgwood2024-03-211-0/+1
|
* OIDC: try to JWT decode userinfo response if JSON parsing failed (#16972)Mathieu Velten2024-03-211-0/+1
|
* Patch the db conn pool sooner in tests (#17017)Richard van der Hoff2024-03-211-0/+1
| | | | | | | | | When running unit tests, we patch the database connection pool so that it runs queries "synchronously". This is ok, except that if any queries are launched before we do the patching, those queries get left in limbo and never complete. To fix this, let's change the way we do the switcheroo, by patching out the method which creates the connection pool in the first place.
* Remove the hardcoded poetry version from contributing guide (#17002)Tadeusz Sośnierz2024-03-211-0/+1
|
* Prevent `start_for_complement.sh` from setting `START_POSTGRES` to `false` ↵Andrew Morgan2024-03-211-0/+1
| | | | | | | | | | when it's already set (#16985) I have a use case where I'd like the Synapse image to start up a postgres instance that I can use, but don't want to force Synapse to use postgres as well. This commit prevents postgres from being started when it has already been explicitly enabled elsewhere.
* Update power level default for public rooms (#16907)Shay2024-03-191-0/+1
|
* Improve event validation (#16908)Shay2024-03-191-0/+1
| | | As the title states.
* Pass module API to OIDC mapping provider (#16974)Mathieu Velten2024-03-191-0/+1
| | | | As done for SAML mapping provider, let's pass the module API to the OIDC one so the mapper can do more logic in its code.
* Specify IP subnet literals in canonical form (#16953)V024602024-03-191-0/+1
| | | | | This is needed, because the netaddr package removed support for the implicit prefix form in version 1.0.0: https://github.com/netaddr/netaddr/pull/360
* Clarify docs for some room state functions (#16950)Richard van der Hoff2024-03-191-0/+1
| | | | State *before* an event is different to state *after* that event, and people tend to assume the wrong one.
* `/sync`: Fix edge-case in calculating the "device_lists" response (#16949)Richard van der Hoff2024-03-141-0/+1
| | | | | Fixes https://github.com/element-hq/synapse/issues/16948. If the `join` and the `leave` are in the same sync response, we need to count them as a "left" user.
* Split up `SyncHandler.compute_state_delta` (#16929)Richard van der Hoff2024-03-141-0/+2
| | | | | | This is a huge method, which melts my brain. This is a non-functional change which lays some groundwork for future work in this area.
* Sort versions in the documentation version picker appropriately. (#16966)Will Hunt2024-03-141-0/+1
| | | | | | Fixes #16964 This adds a proper sorter for versions which takes into account semantic versions, rather than just relying on localeCompare.
* upgrade.md: fix grammatical errors (#16965)Richard van der Hoff2024-03-141-0/+1
| | | | comma splice "rollback" is a noun
* Add query to update local cache of a remote user's device list to docs (#16892)Andrew Morgan2024-03-141-0/+1
|
* Improve lock performance when a lot of locks are waiting (#16840)Mathieu Velten2024-03-141-0/+1
| | | | | | | | | | | | When a lot of locks are waiting for a single lock, notifying all locks independently with `call_later` on each release is really costly and incurs some kind of async contention, where the CPU is spinning a lot for not much. The included test is taking around 30s before the change, and 0.5s after. It was found following failing tests with https://github.com/element-hq/synapse/pull/16827.
* Multi-worker-docker-container: disable log buffering (#16919)Richard van der Hoff2024-03-131-0/+1
| | | | | | | | | | | Background: we have a `matrixdotorg/synapse-workers` docker image, which is intended for running multiple workers within the same container. That image includes a `prefix-log` script which, for each line printed to stdout or stderr by one of the processes, prepends the name of the process. This commit disables buffering in that script, so that lines are logged quickly after they are printed. This makes it much easier to understand the output, since they then come out in a natural order.
* Raise poetry-core version cap to 1.9.0 (#16986)V024602024-03-131-0/+1
| | | | A new poetry-core version was released. See if CI is happy. Required for the latest Fedora Synapse package.
* Update changelog v1.103.0rc1Erik Johnston2024-03-121-1/+0
|
* Merge remote-tracking branch 'origin/develop' into release-v1.103Erik Johnston2024-03-121-0/+1
|\
| * Prevent locking up while processing batched_auth_events (#16968)Gerrit Gogel2024-03-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR aims to fix #16895, caused by a regression in #7 and not fixed by #16903. The PR #16903 only fixes a starvation issue, where the CPU isn't released. There is a second issue, where the execution is blocked. This theory is supported by the flame graphs provided in #16895 and the fact that I see the CPU usage reducing and far below the limit. Since the changes in #7, the method `check_state_independent_auth_rules` is called with the additional parameter `batched_auth_events`: https://github.com/element-hq/synapse/blob/6fa13b4f927c10b5f4e9495be746ec28849f5cb6/synapse/handlers/federation_event.py#L1741-L1743 It makes the execution enter this if clause, introduced with #15195 https://github.com/element-hq/synapse/blob/6fa13b4f927c10b5f4e9495be746ec28849f5cb6/synapse/event_auth.py#L178-L189 There are two issues in the above code snippet. First, there is the blocking issue. I'm not entirely sure if this is a deadlock, starvation, or something different. In the beginning, I thought the copy operation was responsible. It wasn't. Then I investigated the nested `store.get_events` inside the function `update`. This was also not causing the blocking issue. Only when I replaced the set difference operation (`-` ) with a list comprehension, the blocking was resolved. Creating and comparing sets with a very large amount of events seems to be problematic. This is how the flamegraph looks now while persisting outliers. As you can see, the execution no longer locks up in the above function. ![output_2024-02-28_13-59-40](https://github.com/element-hq/synapse/assets/13143850/6db9c9ac-484f-47d0-bdde-70abfbd773ec) Second, the copying here doesn't serve any purpose, because only a shallow copy is created. This means the same objects from the original dict are referenced. This fails the intention of protecting these objects from mutation. The review of the original PR https://github.com/matrix-org/synapse/pull/15195 had an extensive discussion about this matter. Various approaches to copying the auth_events were attempted: 1) Implementing a deepcopy caused issues due to builtins.EventInternalMetadata not being pickleable. 2) Creating a dict with new objects akin to a deepcopy. 3) Creating a dict with new objects containing only necessary attributes. Concluding, there is no easy way to create an actual copy of the objects. Opting for a deepcopy can significantly strain memory and CPU resources, making it an inefficient choice. I don't see why the copy is necessary in the first place. Therefore I'm proposing to remove it altogether. After these changes, I was able to successfully join these rooms, without the main worker locking up: - #synapse:matrix.org - #element-android:matrix.org - #element-web:matrix.org - #ecips:matrix.org - #ipfs-chatter:ipfs.io - #python:matrix.org - #matrix:matrix.org
* | 1.103.0rc1Erik Johnston2024-03-126-6/+0
|/
* deactivated flag refactored to filter deactivated users. (#16874)Alexander Fechler2024-03-111-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Stabilize support for Retry-After header (MSC4014) (#16947)Patrick Cloke2024-03-081-0/+1
|
* Fix joining remote rooms when a `on_new_event` callback is registered (#16973)Quentin Gliech2024-03-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Synapse 1.76.0, any module which registers a `on_new_event` callback would brick the ability to join remote rooms. This is because this callback tried to get the full state of the room, which would end up in a deadlock. Related: https://github.com/matrix-org/synapse-auto-accept-invite/issues/18 The following module would brick the ability to join remote rooms: ```python from typing import Any, Dict, Literal, Union import logging from synapse.module_api import ModuleApi, EventBase logger = logging.getLogger(__name__) class MyModule: def __init__(self, config: None, api: ModuleApi): self._api = api self._config = config self._api.register_third_party_rules_callbacks( on_new_event=self.on_new_event, ) async def on_new_event(self, event: EventBase, _state_map: Any) -> None: logger.info(f"Received new event: {event}") @staticmethod def parse_config(_config: Dict[str, Any]) -> None: return None ``` This is technically a breaking change, as we are now passing partial state on the `on_new_event` callback. However, this callback was broken for federated rooms since 1.76.0, and local rooms have full state anyway, so it's unlikely that it would change anything.
* Revert "Ignore notification counts from rooms you've left" (#16981)Andrew Morgan2024-03-051-1/+0
|
* Ignore notification counts from rooms you've left (#16954)Andrew Morgan2024-02-231-0/+1
| | | | Co-authored-by: reivilibre <oliverw@matrix.org>
* Add docs on upgrading from a very old version (#16951)Twilight Sparkle2024-02-221-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Better complement docs (#16946)kegsay2024-02-201-0/+1
|
* Merge branch 'release-v1.102' into developAndrew Morgan2024-02-208-8/+0
|\
| * 1.102.0rc1 v1.102.0rc1Andrew Morgan2024-02-208-8/+0
| |
* | Add HAProxy example for single port operation (#16768)Georg2024-02-201-0/+1
|/
* Don't lock up when joining large rooms (#16903)Erik Johnston2024-02-201-0/+1
| | | | Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
* bugfix: always prefer unthreaded receipt when >1 exist (MSC4102) (#16927)kegsay2024-02-201-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Fix incorrect docker hub link in release script (#16910)Erik Johnston2024-02-201-0/+1
|
* fix typo in admin_api/rooms.md (#16857)Rainer Zufall2024-02-201-0/+1
| | | | Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
* Add metric for emails sent (#16881)Remi Rampin2024-02-141-0/+1
| | | | | This adds a counter `synapse_emails_sent_total` for emails sent. They are broken down by `type`, which are `password_reset`, `registration`, `add_threepid`, `notification` (matching the methods of `Mailer`).
* Merge branch 'master' into developErik Johnston2024-02-131-1/+0
|\
| * 1.101.0 v1.101.0 github/release-v1.101 release-v1.101Erik Johnston2024-02-131-1/+0
| |
* | Don't invalidate the entire event cache when we purge history (#16905)Erik Johnston2024-02-131-0/+1
| | | | | | | | | | We do this by adding support to the LRU cache for "extra indices" based on the cached value. This allows us to efficiently map from room ID to the cached events and only invalidate those.
* | Add a config to not send out device list updates for specific users (#16909)Erik Johnston2024-02-131-0/+1
| | | | | | | | | | | | | | | | | | List of users not to send out device list updates for when they register new devices. This is useful to handle bot accounts. This is undocumented as its mostly a hack to test on matrix.org. Note: This will still send out device list updates if the device is later updated, e.g. end to end keys are added.
* | Merge remote-tracking branch 'origin/release-v1.101' into developErik Johnston2024-02-091-0/+1
|\|
| * Increase batching when fetching auth chains (#16893)Erik Johnston2024-02-091-0/+1
| | | | | | | | | | | | | | | | This basically reverts a change that was in https://github.com/element-hq/synapse/pull/16833, where we reduced the batching. The smaller batching can cause performance issues on busy servers and databases.
* | Only do one concurrent fetch per server in keyring (#16894)Erik Johnston2024-02-091-0/+1
|/ | | | | Otherwise if we've stacked a bunch of requests for the keys of a server, we'll end up sending lots of concurrent requests for its keys, needlessly.
* 1.101.0rc1 v1.101.0rc1Erik Johnston2024-02-064-4/+0
|
* Accept unprefixed form of MSC3981 recurse parameter (#16842)David Baker2024-02-061-0/+1
| | | Now that the MSC3981 has passed FCP
* Update docs for MacOS installs (#16854)kegsay2024-02-061-0/+1
| | | | ICU is an optional dependency and also a pain to install. Mention that you can just not install it and still get a working installation.
* Fix broken links on docs (#16853)kegsay2024-02-061-0/+1
| | | | Some links seemed to be incorrect (vector-im/sygnal and vector-im/sytest have never been A Thing iirc) so pointed them back to matrix-org/*).
* Update version picker for element-hq (#16880)Will Hunt2024-02-011-0/+1
|
* 1.100.0rc3 v1.100.0rc3Olivier Wilkinson (reivilibre)2024-01-241-1/+0
|
* Run `ANALYZE` after fiddling with stats (#16849)Erik Johnston2024-01-241-0/+1
| | | | | Introduced in #16833 Fixes #16844
* 1.100.0rc2Olivier Wilkinson (reivilibre)2024-01-241-1/+0
|
* Downgrade the `download-artifact` and `upload-artifact` actions to v3 due to ↵reivilibre2024-01-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | breaking changes. (#16847) Partially reverts #16796 This is causing errors of the form: ``` Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` for the debs and wheels stages. There were breaking changes that weren't included in the dependabot changelog (:/): https://github.com/actions/upload-artifact#breaking-changes <!-- Fixes: # <!-- --> <!-- Supersedes: # <!-- --> <!-- Follows: # <!-- --> <!-- Part of: # <!-- --> Base: `release-v1.100` <!-- git-stack-base-branch:release-v1.100 --> <!-- This pull request is commit-by-commit review friendly. <!-- --> <!-- This pull request is intended for commit-by-commit review. <!-- --> Original commit schedule, with full messages: <ol> <li> Downgrade the `upload-artifact` and `download-artifact` actions to v3 </li> </ol> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* 1.100.0rc1Olivier Wilkinson (reivilibre)2024-01-2321-22/+0
|
* Speed up e2e device keys queries for bot accounts (#16841)Erik Johnston2024-01-231-0/+1
| | | | | | This helps with bot accounts with lots of non-e2e devices. The change is basically to change the order of the join for the case of using `INNER JOIN`
* Correctly mention previous copyright (#16820)Erik Johnston2024-01-231-0/+1
| | | | | During the migration the automated script to update the copyright headers accidentally got rid of some of the existing copyright lines. Reinstate them.
* Preparatory work for tweaking performance of auth chain lookups (#16833)Erik Johnston2024-01-231-0/+1
|
* Add a `--generate-only` option to the Complement launcher. (#16828)reivilibre2024-01-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulled out of #16803 since the drive-by cleanup was maybe not as drive-by as I had hoped. <!-- Fixes: # <!-- --> <!-- Supersedes: # <!-- --> <!-- Follows: # <!-- --> <!-- Part of: # <!-- --> Base: `develop` <!-- git-stack-base-branch:develop --> <!-- This pull request is commit-by-commit review friendly. <!-- --> <!-- This pull request is intended for commit-by-commit review. <!-- --> Original commit schedule, with full messages: <ol> <li> Add a --generate-only option </li> </ol> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* listen http2 deprecated nginx (updating documentation) (#16831)Arnold2024-01-221-0/+1
| | | | | More info [here](https://www.nginx.com/blog/nginx-plus-r30-released/). Nginx threw error's at me when I used all the options of the doc
* Allow room creation but not publishing to continue if room publication rules ↵Shay2024-01-221-0/+2
| | | | | | | | | | | | | are violated when creating a new room. (#16811) Prior to this PR, if a request to create a public (public as in published to the rooms directory) room violated the room list publication rules set in the [config](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#room_list_publication_rules), the request to create the room was denied and the room was not created. This PR changes the behavior such that when a request to create a room published to the directory violates room list publication rules, the room is still created but the room is not published to the directory.
* Bump minimum Rust version to 1.65.0 (#16818)Erik Johnston2024-01-221-0/+1
| | | | | The ecosystem e.g. regex crate, have bumped up their MSRV to 1.65.0, which was released Nov 2022. In line with our policy, let's bump to match.
* Handle wildcard type filters properly (#14984)Mo Balaa2024-01-221-0/+1
|
* Fix broken links in issue template (#16810)Erik Johnston2024-01-171-0/+1
| | | This happened during the migration
* feat: add msc4028 to versions api (#16787)Hanadi2024-01-161-0/+1
| | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Optimize query for fetching to-device messages in `/sync` (#16805)Erik Johnston2024-01-111-0/+1
| | | | | | | | The current query supports passing in a list of users, which generates a query using `user_id = ANY(..)`. This is generates a less efficient query plan that is notably slower than a simple `user_id = ?` condition. Note: The new function is mostly a copy and paste and then a simplification of the existing function.
* Improve DB performance of calculating badge counts for push. (#16756)Erik Johnston2024-01-111-0/+1
| | | | | | | | | | | | | | | | The crux of the change is to try and make the queries simpler and pull out fewer rows. Before, there were quite a few joins against subqueries, which caused postgres to pull out more rows than necessary. Instead, let's simplify the query and do some of the filtering out in Python instead, letting Postgres do better optimizations now that it doesn't have to deal with joins against subqueries. Review note: this is a complete rewrite of the function, so not sure how useful the diff is. --------- Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Correctly handle OIDC config with no `client_secret` set (#16806)Erik Johnston2024-01-101-0/+1
| | | | | | | | | | | In previous versions of authlib using `client_secret_basic` without a `client_secret` would result in an invalid auth header. Since authlib 1.3 it throws an exception. The configuration may be accepted in by very lax servers, so we don't want to deny it outright. Instead, let's default the `client_auth_method` to `none`, which does the right thing. If the config specifies `client_auth_method` and no `client_secret` then that is going to be bogus and we should reject it
* Faster load recents for sync (#16783)Erik Johnston2024-01-101-0/+1
| | | This hopefully reduces the amount of state we need to keep in memory
* Pull less state out if we fail to backfill (#16788)Erik Johnston2024-01-101-0/+1
| | | | | | | | | | | Sometimes we fail to fetch events during backfill due to missing state, and we often end up querying the same bad events periodically (as people backpaginate). In such cases its likely we will continue to fail to get the state, and therefore we should try *before* loading the state that we have from the DB (as otherwise it's wasted DB and memory). --------- Co-authored-by: reivilibre <oliverw@matrix.org>
* Reduce amount of state pulled out when querying federation hierachy (#16785)Erik Johnston2024-01-101-0/+1
| | | | | | | | | | | There are two changes here: 1. Only pull out the required state when handling the request. 2. Change the get filtered state return type to check that we're only querying state that was requested --------- Co-authored-by: reivilibre <oliverw@matrix.org>
* Split up deleting devices into batches (#16766)Erik Johnston2024-01-101-0/+1
| | | | Otherwise for users with large numbers of devices this can cause a lot of woe.
* Fix auto-merge CI to correctly wait for linting. (#16781)Erik Johnston2024-01-101-0/+1
| | | | Otherwise if you hit the `Enable auto-merge` button and the linting fails the PR is still aut-merged.
* Remove CI check for sign off (#16776)Erik Johnston2024-01-101-0/+1
| | | Since we don't require one anymore.
* Add a link to the Request log format page from Logging Sample Config (#16778)Andrew Morgan2024-01-101-0/+1
|
* Faster partial join to room with complex auth graph (#7)Erik Johnston2024-01-101-0/+1
| | | | | | | | Instead of persisting outliers in a bunch of batches, let's just do them all at once. This is fine because all `_auth_and_persist_outliers_inner` is doing is checking the auth rules for each event, which requires the events to be topologically sorted by the auth graph.
* 1.99.0rc1Erik Johnston2024-01-0921-22/+0
|
* Filter out rooms from the room directory being served to other homeservers ↵reivilibre2024-01-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when those rooms block that homeserver by their Access Control Lists. (#16759) The idea here being that the directory server shouldn't advertise rooms to a requesting server is the requesting server would not be allowed to join or participate in the room. <!-- Fixes: # <!-- --> <!-- Supersedes: # <!-- --> <!-- Follows: # <!-- --> <!-- Part of: # <!-- --> Base: `develop` <!-- git-stack-base-branch:develop --> <!-- This pull request is commit-by-commit review friendly. <!-- --> <!-- This pull request is intended for commit-by-commit review. <!-- --> Original commit schedule, with full messages: <ol> <li> Pass `from_federation_origin` down into room list retrieval code </li> <li> Don't cache /publicRooms response for inbound federated requests </li> <li> fixup! Don't cache /publicRooms response for inbound federated requests </li> <li> Cap the number of /publicRooms entries to 100 </li> <li> Simplify code now that you can't request unlimited rooms </li> <li> Filter out rooms from federated requests that don't have the correct ACL </li> <li> Request a handful more when filtering ACLs so that we can try to avoid shortchanging the requester </li> </ol> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Port `EventInternalMetadata` class to Rust (#16782)Erik Johnston2024-01-081-0/+1
| | | | | | | | | | | | | There are a couple of things we need to be careful of here: 1. The current python code does no validation when loading from the DB, so we need to be careful to ignore such errors (at least on jki.re there are some old events with internal metadata fields of the wrong type). 2. We want to be memory efficient, as we often have many hundreds of thousands of events in the cache at a time. --------- Co-authored-by: Quentin Gliech <quenting@element.io>
* Fix linting (#16780)Erik Johnston2024-01-051-0/+1
| | | Introduced in #16762
* Simplify internal metadata class. (#16762)Erik Johnston2024-01-051-0/+1
| | | | | | | | | We remove these fields as they're just duplicating data the event already stores, and (for reasons :shushing_face:) I'd like to simplify the class to only store simple types. I'm not entirely convinced that we shouldn't instead add helper methods to the event class to generate stream tokens, but I don't really think that's where they belong either
* Implement cosign on docker image (#16774)Gaël Goinvic2024-01-041-0/+1
| | | Signed-off-by: Gaël Goinvic <gaelg@element.io>
* Add recursion_depth to /relations if recursing (#16775)David Baker2024-01-041-0/+1
| | | | | This is an extra response parameter just added to MSC3981. In the current impl, the recursion depth is always 3, so this just returns a static 3 if the recurse parameter is supplied.
* Search non ASCII display names using Admin API (#16767)Adam Jędrzejewski2024-01-041-0/+2
| | | | | Closes #16370 Signed-off-by: Adam Jedrzejewski <adamjedrzejewski@icloud.com>
* Fix email verification redirection (#16761)FadhlanR2024-01-021-0/+1
| | | | | | Previously, the response status of `HTMLResource` was hardcoded as `200`. However, for proper redirection after the user verifies their email, we require the status to be `302`. This PR addresses that issue by using `code` as response status.
* Delete the add version picker GHA workflow (#9453)Andrew Morgan2024-01-021-0/+1
| | | | | | | | | | | | | | | | | | | | Added in https://github.com/matrix-org/synapse/pull/16533, this workflow was intended to be run once to add the version picker to all historical versions of the https://matrix-org.github.io/synapse documentation website. Note that the latest version of the docs built from this repo now exist at https://element-hq.github.io/synapse/. The workflow has been run successfully and the version picker was added to the documentation. Thus we can now delete this workflow. --- Note: Do not confuse this PR with https://github.com/matrix-org/synapse/issues/9453. This PR was made while we were populating this repo with "Dummy issues" after the changeover from matrix-org/synapse to element-hq/synapse - therefore referencing this PR may cause some confusion.
* Add another custom statistics collection server (#16769)Christian Lölkes2024-01-021-0/+1
| | | Signed-off-by: Christian Lölkes <christian.loelkes@gmail.com>
* Enable user without password (#16770)Dirk Klimpel2024-01-021-0/+1
| | | | | | | | | | | Closes: - https://github.com/matrix-org/synapse/issues/10397 - #10397 An administrator should know whether he wants to set a password or not. There are many uses cases where a blank password is required. - Use of only some users with SSO. - Use of bots with password, users with SSO
* Remove config value from header (#16763)Fredrik Lanker2024-01-021-0/+1
| | | Signed-off-by: Fredrik Lanker <fredrik@lanker.se>
* Move the rust stubs inline for better IDE integration (#16757)Erik Johnston2023-12-211-0/+1
| | | | At least for vscode this allows click through / type checking / syntax highlighting.
* Fix sample config doc CI (#16758)Erik Johnston2023-12-211-0/+1
| | | I accidentally broke it during the move by removing a trailing new line.
* Sentry Alert configuration based on production and development environment ↵Zeeshan Rafiq2023-12-121-0/+1
| | | | (#16738)
* Add avatar and topic settings for server notice room (#16679)Mathieu Velten2023-12-121-0/+1
|
* Add config to change the delay before sending a notification email (#16696)Mathieu Velten2023-12-121-0/+1
|
* Adding a version picker for Synapse docs (#16533)Dmytro Kagirov2023-12-111-0/+1
|
* Write signing keys with file mode 0640 (#16740)elara-leitstellentechnik2023-12-081-0/+1
| | | | Co-authored-by: Fabian Klemp <fabian.klemp@frequentis.com>
* Clarify documentation for `only_for_reauth` (#16737)Dirk Klimpel2023-12-071-0/+1
|
* Expose OIDC discovery information under the CSAPI (#16726)David Robertson2023-12-061-0/+1
| | | | Co-authored-by: Quentin Gliech <quenting@element.io>
* 1.98.0rc1David Robertson2023-12-0527-27/+0
|
* Fix upgrading a room without `events` field in power levels (#16725)David Robertson2023-12-051-0/+1
|
* Add how to validate configuration file with synapse.config script (#16714)Amanda H. L. de Andrade Katz2023-12-051-0/+1
|
* Set response values to zero if None for ↵Will Hunt2023-12-051-0/+1
| | | | | | /_synapse/admin/v1/federation/destinations (#16729)
* Fix postgres schema after dropping old tables (#16730)David Robertson2023-12-051-0/+1
|
* Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit ↵reivilibre2023-12-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | one. This should allow use of Postgres logical replication. (take 2, now with no added deadlocks!) (#16658) * Add `ALTER TABLE ... REPLICA IDENTITY ...` for individual tables We can't combine them into one file as it makes it likely to hit a deadlock if Synapse is running, as it only takes one other transaction to access two tables in a different order to the schema delta. * Add notes * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Re-introduce REPLICA IDENTITY test --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Switch UNIX socket paths to /run, and add a UNIX socket example for HAProxy ↵villepeh2023-12-041-0/+1
| | | | (#16700)
* Server notices: add an autojoin setting for the notices room (#16699)Mathieu Velten2023-12-041-0/+1
| | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Implement MSC4069: Inhibit profile propagation (#16636)Travis Ralston2023-12-041-0/+1
| | | MSC: https://github.com/matrix-org/matrix-spec-proposals/pull/4069
* ModuleAPI SSO auth callbacks (#15207)Andrew Yasinishyn2023-12-011-0/+1
| | | Signed-off-by: Andrii Yasynyshyn yasinishyn.a.n@gmail.com
* Drop unused tables & unneeded access token ID for events. (#16522)Patrick Cloke2023-12-011-0/+1
|
* Upgrade poetry-core range to fix issue with .so file (#16702)Mo Balaa2023-11-291-0/+1
| | | | | | | | poetry-core 1.8.x includes a fix which properly moves the generate synapse_rust.abi3.so file to the synapse directory when using an editable install. Without this change developers are left with a confusing experience of the synapse.synapse_rust module not being found after installation.
* Declare support for Matrix v1.7, v1.8, and v1.9. (#16707)Patrick Cloke2023-11-291-0/+1
|
* Request & follow redirects for /media/v3/download (#16701)Patrick Cloke2023-11-291-0/+1
| | | | | | Implement MSC3860 to follow redirects for federated media downloads. Note that the Client-Server API doesn't support this (yet) since the media repository in Synapse doesn't have a way of supporting redirects.
* Reduce DB load when forget on leave setting is disabled (#16668)Erik Johnston2023-11-291-0/+1
| | | | | * Reduce DB load when forget on leave setting is disabled * Newsfile
* Add a workflow to try and automatically fixup a PR (#16704)Erik Johnston2023-11-291-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Speed up pruning of `user_ips` table (#16667)Erik Johnston2023-11-291-0/+1
| | | Silly query planner
* Document which versions of Synapse have compatible schema versions. (#16661)Patrick Cloke2023-11-281-0/+1
|
* Ignore `encryption_enabled_by_default_for_room_type` for notices room (#16677)Mathieu Velten2023-11-281-0/+1
|
* Remove old full schema dumps. (#16697)Patrick Cloke2023-11-281-0/+1
| | | | These are not useful and make it difficult to search for table definitions, etc.
* Fix poetry version typo in contributors' guide (#16695)David Robertson2023-11-271-0/+1
|
* Move media retention tests out of rest tests (#16684)David Robertson2023-11-271-0/+1
| | | | | | | | * Move media retention tests out of rest tests AFAICS this doesn't make any HTTP requests and so it ought not to belong in `tests.rest`. * Changelog
* Correctly read to-device stream pos on SQLite (#16682)David Robertson2023-11-241-0/+1
|
* Keep track of `user_ips` and `monthly_active_users` when delegating auth ↵David Robertson2023-11-231-0/+1
| | | | | | | | | | | | | (#16672) * Describe `insert_client_ip` * Pull out client_ips and MAU tracking to BaseAuth * Define HAS_AUTHLIB once in tests sick of copypasting * Track ips and token usage when delegating auth * Test that we track MAU and user_ips * Don't track `__oidc_admin`
* Enable refreshable tokens on the admin registration endpoint (#16642)Charles Wright2023-11-221-0/+1
| | | Signed-off-by: Charles Wright <cvwright@futo.org>
* Bump pyo3 (0.20), pythonize (0.20), pyo3-log (0.9) (#16673)V024602023-11-221-0/+1
| | | Signed-off-by: Kai A. Hiller <V02460@gmail.com>
* Admin API for server notice: consistently bypass rate limits (#16670)Mathieu Velten2023-11-221-0/+1
| | | | | | | * Admin API for server notice: disable rate limit for all calls * Add changelog * Update changelog.d/16670.bugfix
* Filter out auth chain queries that don't exist (#16552)Jason Little2023-11-221-0/+1
|
* 1.97.0rc1David Robertson2023-11-2136-36/+0
|
* Speed up how quickly we launch new tasks (#16660)Erik Johnston2023-11-171-0/+1
| | | Now that we're reducing concurrency (#16656), this is more important.
* Bump requests-toolbelt from 0.10.1 to 1.0.0. (#16659)Patrick Cloke2023-11-171-0/+1
|
* Speed up purge room by adding index (#16657)Erik Johnston2023-11-171-0/+1
| | | What it says on the tin
* Also discard 'caches' and 'backfill' stream POSITIONS (#16655)Erik Johnston2023-11-171-0/+1
| | | Follow on from #16640
* Update admin user API return types in docs. (#16654)Michael Weimann2023-11-171-0/+1
|
* Reduce task concurrency (#16656)Erik Johnston2023-11-171-0/+1
|
* Revert "Fix test not detecting tables with missing primary keys and missing ↵Erik Johnston2023-11-161-1/+0
| | | | | replica identities, then add more replica identities. (#16647)" (#16652) This reverts commit 830988ae72d63bbb67d2020a3f221664f3f456ee.
* Revert "Add a Postgres `REPLICA IDENTITY` to tables that do not have an ↵Erik Johnston2023-11-161-1/+0
| | | | | implicit one. This should allow use of Postgres logical replication. (#16456)" (#16651) This reverts commit 69afe3f7a0d89f3422ddbd3aa16bc9bbc01056eb.
* Speed up deleting device messages (#16643)Erik Johnston2023-11-161-0/+1
| | | Keeping track of a lower bound of stream ID where we've deleted everything below makes the queries much faster. Otherwise, every time we scan for rows to delete we'd re-scan across all the rows that have previously deleted (until the next table VACUUM).
* Speed up persisting large number of outliers (#16649)Erik Johnston2023-11-161-0/+1
| | | Recalculating the roots tuple every iteration could be very expensive, so instead let's do a topological sort.
* Fix sending out of order `POSITION` over replication (#16639)Erik Johnston2023-11-161-0/+1
| | | | | If a worker reconnects to Redis we send out the current positions of all our streams. However, if we're also trying to send out a backlog of RDATA at the same time then we can end up sending a `POSITION` with the current token *before* we've sent all the RDATA before the current token. This doesn't cause actual bugs as the receiving servers see the POSITION, fetch the relevant rows from the DB, and then ignore the old RDATA as they come in. However, this is inefficient so it'd be better if we didn't send out-of-order positions
* More efficiently handle no-op POSITION (#16640)Erik Johnston2023-11-161-0/+1
| | | | We may receive `POSITION` commands where we already know that worker has advanced past that position, so there is no point in handling it.
* Fix test not detecting tables with missing primary keys and missing replica ↵reivilibre2023-11-161-0/+1
| | | | | | | | | | | | | | | identities, then add more replica identities. (#16647) * Fix the CI query that did not detect all cases of missing primary keys * Add more missing REPLICA IDENTITY entries * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Add an Admin API to temporarily grant the ability to update an existing ↵David Robertson2023-11-151-0/+1
| | | | cross-signing key without UIA (#16634)
* Asynchronous Uploads (#15503)Sumner Evans2023-11-151-0/+1
| | | Support asynchronous uploads as defined in MSC2246.
* Add links to pre-1.0 changelog issue/PR references. (#16638)Patrick Cloke2023-11-151-0/+1
|
* Use full GitHub links instead of bare issue numbers. (#16637)Patrick Cloke2023-11-151-0/+1
|
* Improve documentation for ↵Will Hunt2023-11-141-0/+1
| | | | `/_synapse/admin/v1/rooms/<room_id>/timestamp_to_event` (#16631)
* Remove whole table locks on push rule add/delete (#16051)Nick Mills-Barrett2023-11-131-0/+1
| | | | The statements are already executed within a transaction thus a table level lock is unnecessary.
* Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit ↵reivilibre2023-11-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | one. This should allow use of Postgres logical replication. (#16456) * Add Postgres replica identities to tables that don't have an implicit one Fixes #16224 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Move the delta to version 83 as we missed the boat for 82 * Add a test that all tables have a REPLICA IDENTITY * Extend the test to include when indices are deleted * isort * black * Fully qualify `oid` as it is a 'hidden attribute' in Postgres 11 * Update tests/storage/test_database.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Add missed tables --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Fix outbound_federation_restricted_to docs & note when added (#16628)David Robertson2023-11-131-0/+1
|
* Use attempt_to_set_autocommit everywhere. (#16615)Patrick Cloke2023-11-091-0/+1
| | | To avoid asserting the type of the database connection.
* Fix a long-standing bug where Synapse would not unbind third-party ↵reivilibre2023-11-091-0/+1
| | | | | | | | | | | | | | | identifiers for Application Service users when deactivated and would not emit a compliant response. (#16617) * Don't skip unbinding 3PIDs and returning success status when deactivating AS user Fixes #16608 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Use dbname instead of database for Postgres config. (#16618)Patrick Cloke2023-11-091-0/+1
|
* Use _invalidate_cache_and_stream_bulk in more places. (#16616)Patrick Cloke2023-11-092-1/+2
| | | | | This takes advantage of the new bulk method in more places to invalidate caches for many keys at once (and then to stream that over replication).
* Convert simple_select_one_txn and simple_select_one to return tuples. (#16612)Patrick Cloke2023-11-091-0/+1
|
* Return attrs for more media repo APIs. (#16611)Patrick Cloke2023-11-091-0/+1
|
* Bulk-invalidate e2e cached queries after claiming keys (#16613)David Robertson2023-11-091-0/+1
| | | | Co-authored-by: Patrick Cloke <patrickc@matrix.org>
* Avoid updating the same rows multiple times with simple_update_many_txn. ↵Patrick Cloke2023-11-071-0/+1
| | | | | | (#16609) simple_update_many_txn had a bug in it which would cause each update to be applied twice.
* Avoid executing no-op queries. (#16583)Patrick Cloke2023-11-071-0/+1
| | | | | | If simple_{insert,upsert,update}_many_txn is called without any data to modify then return instead of executing the query. This matches the behavior of simple_{select,delete}_many_txn.
* More tests for the simple_* methods. (#16596)Patrick Cloke2023-11-071-0/+1
| | | | Expand tests for the simple_* database methods, additionally test against both PostgreSQL and SQLite variants.
* Collect information for PushRuleEvaluator in parallel. (#16590)Patrick Cloke2023-11-061-0/+1
| | | | | | | | Fetch information needed for push rule evaluation in parallel. Ideally this would use query pipelining, but this is not available in psycopg2. Due to the database thread pool this may result in little to no parallelization.
* Bump setuptools_rust to match pinned version. (#16605)Patrick Cloke2023-11-061-0/+1
|
* Support reactor timing metric on more reactors. (#16532)Patrick Cloke2023-11-061-0/+1
| | | | | | | | | | Previously only Twisted's EPollReactor was compatible with the reactor timing metric, notably not working when asyncio was used. After this change, the following configurations support the reactor timing metric: * poll, epoll, or select reactors * asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.
* Simplify event persistence code (#16584)Patrick Cloke2023-11-032-0/+2
| | | | | | | | | | | The event persistence code used to handle multiple rooms at a time, but was simplified to only ever be called with a single room at a time (different rooms are now handled in parallel). The code is still generic to multiple rooms causing a lot of work that is unnecessary (e.g. unnecessary loops, and partitioning data by room). This strips out the ability to handle multiple rooms at once, greatly simplifying the code.
* Use simple_select_many_txn in event persistance code. (#16585)Patrick Cloke2023-11-021-0/+1
| | | | | Just to standardize on the normal helpers, it might also have a slight perf improvement on PostgreSQL which will now use `ANY (?)` instead of `IN (?, ?, ...)`.
* Bump twisted from 23.8.0 to 23.10.0 (#16588)dependabot[bot]2023-11-011-0/+1
|
* Do not call getfullargspec on every call. (#16589)Patrick Cloke2023-10-311-0/+1
| | | | | getfullargspec is relatively expensive and the results will not change between calls, so precalculate it outside the wrapper.
* Remove remaining usage of cursor_to_dict. (#16564)Patrick Cloke2023-10-311-0/+1
|
* 1.96.0rc1Erik Johnston2023-10-3138-38/+0
|
* Revert "1.96.0rc1"Erik Johnston2023-10-3138-0/+38
| | | | This reverts commit 4724a6ded136c727bcff5082b94c2b3d6355e908.
* 1.96.0rc1Erik Johnston2023-10-3138-38/+0
|
* Claim local one-time-keys in bulk (#16565)David Robertson2023-10-301-0/+1
| | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Clients link fixed in README (#16569)Niranjan Kurhade2023-10-301-0/+1
|
* Add fast path for replication events stream fetch (#16580)Erik Johnston2023-10-301-0/+1
| | | | We can bail early if the from token is greater than or equal to the current token.
* Claim fallback keys in bulk (#16570)David Robertson2023-10-301-0/+1
|
* Bump setuptools-rust from 1.7.0 to 1.8.0 (#16574)dependabot[bot]2023-10-301-0/+1
| | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Run actions/setup-go after checking out complement (#16567)David Robertson2023-10-301-0/+1
|
* Fix HTTP repl response to use minimum token (#16578)Erik Johnston2023-10-301-0/+1
|
* Portdb: don't copy a table that gets rebuilt (#16563)David Robertson2023-10-271-0/+1
|
* complement: enable dirty runs (#16520)kegsay2023-10-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * complement: enable dirty runs * Add changelog * Set a low connpool limit when running in Complement Dirty runs can cause many containers to be running concurrently, which seems to easily exhaust resources on the host. The increased speedup from dirty runs also seems to use more db connections on workers, which are misconfigured currently to have `SUM(workers * cp_max) > max_connections`, causing ``` FATAL: sorry, too many clients already ``` which results in tests failing. * Try p=2 concurrency to restrict slowness of servers which causes partial state join tests to flake * Debug logging * Only run flakey tests * Only adjust connection pool limits in worker mode * Move cp vars to somewhere where they get executed in CI * Move cp values back to where they actually work * Debug logging * Try p=1 to see if this makes worker mode happier * Remove debug logging
* Ensure local invited & knocking users leave before purge. (#16559)Patrick Cloke2023-10-271-0/+1
| | | | | This is mostly useful for federated rooms where some users would get stuck in the invite or knock state when the room was purged from their homeserver.
* Reduce amount of caches POSITIONS we send (#16561)Erik Johnston2023-10-271-0/+1
| | | Follow on from / actually correctly does #16557
* Reduce spurious replication catchup (#16555)Erik Johnston2023-10-271-0/+1
|
* Fix cross-worker ratelimiting (#16558)Erik Johnston2023-10-271-0/+1
| | | c.f. #16481
* Reduce replication traffic due to reflected cache stream POSITION (#16557)Erik Johnston2023-10-271-0/+1
|
* Add new module API for adding custom fields to events `unsigned` section ↵Erik Johnston2023-10-271-0/+1
| | | | (#16549)
* Remove more usages of cursor_to_dict. (#16551)Patrick Cloke2023-10-261-0/+1
| | | Mostly to improve type safety.
* Add a new module API to update user presence state. (#16544)Patrick Cloke2023-10-261-0/+1
| | | | | | | | | | This adds a module API which allows a module to update a user's presence state/status message. This is useful for controlling presence from an external system. To fully control presence from the module the presence.enabled config parameter gains a new state of "untracked" which disables internal tracking of presence changes via user actions, etc. Only updates from the module will be persisted and sent down sync properly).
* Convert simple_select_list and simple_select_list_txn to return lists of ↵Patrick Cloke2023-10-261-0/+1
| | | | | tuples (#16505) This should use fewer allocations and improves type hints.
* Pin the recommended poetry version in contributors' guide (#16550)David Robertson2023-10-251-0/+1
|
* Allow multiple workers to write to receipts stream. (#16432)Erik Johnston2023-10-251-0/+1
| | | Fixes #16417
* Fix tests on Twisted trunk. (#16528)Patrick Cloke2023-10-251-0/+1
| | | | | | | | | | | | | Twisted trunk makes a change to the `TLSMemoryBIOFactory` where the underlying protocol is changed from `TLSMemoryBIOProtocol` to `BufferingTLSTransport` to improve performance of TLS code (see https://github.com/twisted/twisted/issues/11989). In order to properly hook this code up in tests we need to pass the test reactor's clock into `TLSMemoryBIOFactory` to avoid the global (trial) reactor being used by default. Twisted does something similar internally for tests: https://github.com/twisted/twisted/blob/157cd8e659705940e895d321339d467e76ae9d0a/src/twisted/web/test/test_agent.py#L871-L874
* Fix http/s proxy authentication with long username/passwords (#16504)Richard Brežák2023-10-241-0/+1
|
* Rework alias and public room list rules docs (#16541)David Robertson2023-10-241-0/+1
|
* Remove duplicate call to wake a remote destination when using federation ↵Jason Little2023-10-241-0/+1
| | | | sending worker (#16515)
* Replace all Prometheus datasource UIDs of the Grafana Dashboard with the ↵Michael Sasser2023-10-231-0/+1
| | | | variable `${DS_PROMETHEUS}` and remove `__inputs` (#16471)
* Fix type hint errors from Twisted trunk (#16526)Patrick Cloke2023-10-231-0/+1
|
* Fix bug where a new writer advances their token too quickly (#16473)Erik Johnston2023-10-231-0/+1
| | | | | | | | | | | | | | | | | | | * Fix bug where a new writer advances their token too quickly When starting a new writer (for e.g. persisting events), the `MultiWriterIdGenerator` doesn't have a minimum token for it as there are no rows matching that new writer in the DB. This results in the the first stream ID it acquired being announced as persisted *before* it actually finishes persisting, if another writer gets and persists a subsequent stream ID. This is due to the logic of setting the minimum persisted position to the minimum known position of across all writers, and the new writer starts off not being considered. * Fix sending out POSITIONs when our token advances without update Broke in #14820 * For replication HTTP requests, only wait for minimal position
* Fix bug that could cause a `/sync` to tightloop with sqlite after restart ↵Erik Johnston2023-10-231-0/+1
| | | | | (#16540) This could happen if the last rows in the account data stream were inserted into `account_data`. After a restart the max account ID would be calculated without looking at the `account_data` table, and so have an old ID.
* Mention how to redirect the Jaeger traces to a specific Jaeger instance (#16531)Marcel2023-10-231-0/+1
|
* Force TLS certificate verification in registration script. (#16530)Denis Kasak2023-10-231-0/+1
| | | | | | | | | | If using the script remotely, there's no particularly convincing reason to disable certificate verification, as this makes the connection interceptible. If on the other hand, the script is used locally (the most common use case), you can simply target the HTTP listener and avoid TLS altogether. This is what the script already attempts to do if passed a homeserver configuration YAML file.
* Remove the last reference to event_txn_id. (#16521)Patrick Cloke2023-10-231-0/+1
| | | | This table was no longer used, except for a background process which purged old entries in it.
* Bump matrix-synapse-ldap3 from 0.2.2 to 0.3.0 (#16539)David Robertson2023-10-231-0/+1
|
* Clarify presence router docs. (#16529)Patrick Cloke2023-10-201-0/+1
|
* Mark sync as limited if there is a gap in the timeline (#16485)Erik Johnston2023-10-191-0/+1
| | | | | | | | This splits thinsg into two queries, but most of the time we won't have new event backwards extremities so this shouldn't actually add an extra RTT for the majority of cases. Note this removes the check for events with no prev events, but that was part of MSC2716 work that has since been removed.
* Avoid sending massive replication updates when purging a room. (#16510)Patrick Cloke2023-10-181-0/+1
|
* Improve performance of delete device messages query (#16492)Mathieu Velten2023-10-181-0/+1
|
* Run trial/integration tests if .ci is modified. (#16512)Patrick Cloke2023-10-181-0/+1
|
* Test against Python 3.12 release (#16511)Patrick Cloke2023-10-171-0/+1
|
* 1.95.0rc1Patrick Cloke2023-10-1730-30/+0
|
* Convert DeviceLastConnectionInfo to attrs. (#16507)Patrick Cloke2023-10-171-0/+1
| | | To improve type safety & memory usage.
* Fix a bug where servers could be marked as up when they were failing (#16506)Patrick Cloke2023-10-171-0/+1
| | | | After this change a server will only be reported as back online if they were previously having requests fail.
* Update the release script to remind releaser to check for special release ↵reivilibre2023-10-161-0/+1
| | | | | | | | | | | | | | | | | notes. (#16461) * Add reminder to check special release notes board in release script * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Update release.py * Bah, black --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Convert state delta processing from a dict to attrs. (#16469)Patrick Cloke2023-10-161-0/+1
| | | For improved type checking & memory usage.
* Remove useless async job to delete device messages on sync (#16491)Mathieu Velten2023-10-161-0/+1
|
* Clean up logging on event persister endpoints (#16488)Richard van der Hoff2023-10-141-0/+1
|