summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Add support for room version 10 (#13220)Shay2022-07-131-0/+1
|
* Document advising against publicly exposing the Admin API and provide a ↵jejo862022-07-131-0/+1
| | | | | | | | | | | | | | | | usage example (#13231) * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett2022-07-131-0/+1
|
* Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke2022-07-131-0/+1
|
* Add prometheus counters for content types other than events (#13175)Brad Murray2022-07-131-0/+1
|
* Drop unused tables from groups/communities. (#12967)Patrick Cloke2022-07-131-0/+1
| | | | These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
* Do not fail build if complement with workers fails. (#13266)Patrick Cloke2022-07-131-0/+1
|
* Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston2022-07-131-0/+1
| | | | | | (#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Inline URL preview documentation. (#13261)Patrick Cloke2022-07-122-2/+2
| | | Inline URL preview documentation near the implementation.
* Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2022-07-121-0/+1
| | | This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
* Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz2022-07-121-0/+1
| | | | | | | `id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* Rename test case method to `add_hashes_and_signatures_from_other_server` ↵David Robertson2022-07-121-0/+1
| | | | (#13255)
* Drop support for delegating email validation (#13192)Richard van der Hoff2022-07-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
* Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2022-07-121-0/+1
| | | | The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
* Add info about configuration in the url preview docs (#13233)Shay2022-07-121-0/+2
| | | Cross-link doc pages for easier navigation.
* Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2022-07-121-0/+1
| | | | | | | | token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
* expose whether a room is a space in the Admin API (#13208)andrew do2022-07-121-0/+1
|
* 1.63.0rc1Sean Quah2022-07-1251-53/+0
|
* Don't pull out the full state when calculating push actions (#13078)Erik Johnston2022-07-112-1/+2
|
* Add a sample bash script to docs for creating multiple worker files (#13032)villepeh2022-07-111-0/+1
| | | Signed-off-by: Ville Petteri Huh.
* Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett2022-07-111-0/+1
| | | | | | | | Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
* Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller2022-07-111-0/+1
| | | | | | return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2022-07-111-0/+1
| | | | The field name was simply incorrect, leading to errors.
* Remove delay when rotating event push actions (#13211)Erik Johnston2022-07-111-0/+1
| | | | We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
* Document the 'databases' homeserver config option (#13212)Andrew Morgan2022-07-111-0/+1
|
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-111-0/+1
|
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2022-07-111-0/+1
| | | | | | | | | | | * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
* Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2022-07-111-0/+1
|
* editorconfig: add max_line_length for Python files (#13228)Sumner Evans2022-07-081-0/+1
| | | | | | See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>
* Fix notification count after a highlighted message (#13223)Erik Johnston2022-07-081-0/+1
| | | | | Fixes #13196 Broke by #13005
* Fix exception when using MSC3030 to look for remote federated events before ↵Eric Eastwood2022-07-071-0/+1
| | | | | | | | | | | | | | | | room creation (#13197) Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
* Add --build-only option to complement.sh to prevent actually running ↵reivilibre2022-07-071-0/+1
| | | | Complement. (#13158)
* Remove obsolete RoomEventsStoreTestCase (#13200)Petr Vaněk2022-07-071-0/+1
| | | | | | | | | | All tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b3c508 - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
* Faster room joins: fix race in recalculation of current room state (#13151)Sean Quah2022-07-071-0/+1
| | | | | | | | | | | Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>
* Use a single query in `ProfileHandler.get_profile` (#13209)Nick Mills-Barrett2022-07-071-0/+1
|
* Bump lxml from 4.8.0 to 4.9.1 (#13207)dependabot[bot]2022-07-071-0/+1
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Check that `auto_vacuum` is disabled when porting a SQLite database to ↵reivilibre2022-07-071-0/+1
| | | | Postgres, as `VACUUM`s must not be performed between runs of the script. (#13195)
* Make `_get_state_map_for_room` not break when room state events don't ↵David Teller2022-07-071-0/+1
| | | | | contain an event id. (#13174) Method `_get_state_map_for_room` seems to break in presence of some ill-formed events in the database. Reimplementing this method to use `get_current_state`, which is more robust to such events.
* Add information on how the Synapse team does reviews. (#13132)Patrick Cloke2022-07-061-0/+1
|
* Fix bug where we failed to delete old push actions (#13194)Erik Johnston2022-07-061-0/+1
| | | This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.
* Handle race between persisting an event and un-partial stating a room (#13100)Sean Quah2022-07-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever we want to persist an event, we first compute an event context, which includes the state at the event and a flag indicating whether the state is partial. After a lot of processing, we finally try to store the event in the database, which can fail for partial state events when the containing room has been un-partial stated in the meantime. We detect the race as a foreign key constraint failure in the data store layer and turn it into a special `PartialStateConflictError` exception, which makes its way up to the method in which we computed the event context. To make things difficult, the exception needs to cross a replication request: `/fed_send_events` for events coming over federation and `/send_event` for events from clients. We transport the `PartialStateConflictError` as a `409 Conflict` over replication and turn `409`s back into `PartialStateConflictError`s on the worker making the request. All client events go through `EventCreationHandler.handle_new_client_event`, which is called in *a lot* of places. Instead of trying to update all the code which creates client events, we turn the `PartialStateConflictError` into a `429 Too Many Requests` in `EventCreationHandler.handle_new_client_event` and hope that clients take it as a hint to retry their request. On the federation event side, there are 7 places which compute event contexts. 4 of them use outlier event contexts: `FederationEventHandler._auth_and_persist_outliers_inner`, `FederationHandler.do_knock`, `FederationHandler.on_invite_request` and `FederationHandler.do_remotely_reject_invite`. These events won't have the partial state flag, so we do not need to do anything for then. The remaining 3 paths which create events are `FederationEventHandler.process_remote_join`, `FederationEventHandler.on_send_membership_event` and `FederationEventHandler._process_received_pdu`. We can't experience the race in `process_remote_join`, unless we're handling an additional join into a partial state room, which currently blocks, so we make no attempt to handle it correctly. `on_send_membership_event` is only called by `FederationServer._on_send_membership_event`, so we catch the `PartialStateConflictError` there and retry just once. `_process_received_pdu` is called by `on_receive_pdu` for incoming events and `_process_pulled_event` for backfill. The latter should never try to persist partial state events, so we ignore it. We catch the `PartialStateConflictError` in `on_receive_pdu` and retry just once. Refering to the graph of code paths in https://github.com/matrix-org/synapse/issues/12988#issuecomment-1156857648 may make the above make more sense. Signed-off-by: Sean Quah <seanq@matrix.org>
* Type `tests.utils` (#13028)David Robertson2022-07-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cast to postgres types when handling postgres db * Remove unused method * Easy annotations * Annotate create_room * Use `ParamSpec` to annotate looping_call * Annotate `default_config` * Track `now` as a float `time_ms` returns an int like the proper Synapse `Clock` * Introduce a `Timer` dataclass * Introduce a Looper type * Suppress checking of a mock * tests.utils is typed * Changelog * Whoops, import ParamSpec from typing_extensions * ditch the psycopg2 casts
* Factor out some common Complement CI setup commands to a script. (#13157)reivilibre2022-07-051-0/+1
|
* Use upserts for updating `event_push_summary` (#13153)Erik Johnston2022-07-051-0/+1
|
* Fix application service not being able to join remote federated room without ↵Eric Eastwood2022-07-051-0/+1
| | | | | | | a profile set (#13131) Fix https://github.com/matrix-org/synapse/issues/4778 Complement tests: https://github.com/matrix-org/complement/pull/399
* Add the ability to set the log level using the `SYNAPSE_TEST_LOG_LEVEL` ↵reivilibre2022-07-051-0/+1
| | | | environment when using `complement.sh`. (#13152)
* Add missing links to config options (#13166)Dirk Klimpel2022-07-051-0/+1
|
* annotate tests.server.FakeChannel (#13136)David Robertson2022-07-041-0/+1
|
* Remove tests/utils.py from mypy's exclude list (#13159)Andrew Morgan2022-07-041-0/+1
|
* [Complement] Allow device_name lookup over federation (#13167)Till2022-07-041-0/+1
|
* Enable Complement testing in the 'Twisted Trunk' CI runs. (#13079)reivilibre2022-07-011-0/+1
|
* complement.sh: Permit skipping docker build (#13143)Richard van der Hoff2022-07-011-0/+1
| | | Add a `-f` argument to `complement.sh` to skip the docker build
* Merge tag 'v1.62.0rc2' into developAndrew Morgan2022-07-012-2/+0
|\ | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc2 (2022-07-01) ============================== Bugfixes -------- - Fix unread counts for users on large servers. Introduced in v1.62.0rc1. ([\#13140](https://github.com/matrix-org/synapse/issues/13140)) - Fix DB performance when deleting old push notifications. Introduced in v1.62.0rc1. ([\#13141](https://github.com/matrix-org/synapse/issues/13141))
| * 1.62.0rc2 v1.62.0rc2Andrew Morgan2022-07-012-2/+0
| |
* | Extra validation for rest/client/account_data (#13148)David Robertson2022-07-011-0/+1
| | | | | | | | | | | | | | * Extra validation for rest/client/account_data This is a fairly simple endpoint and we did pretty well here. * Changelog
* | `_process_received_pdu`: Improve exception handling (#13145)Richard van der Hoff2022-07-011-0/+1
| | | | | | | | `_check_event_auth` is expected to raise `AuthError`s, so no need to log it again.
* | Skip waiting for full state for incoming events (#13144)Richard van der Hoff2022-07-011-0/+1
| | | | | | | | | | When we receive an event over federation during a faster join, there is no need to wait for full state, since we have a whole reconciliation process designed to take the partial state into account.
* | Add documentation for phone home stats (#13086)Andrew Morgan2022-06-301-0/+1
| |
* | Allow dependency errors to pass through (#13113)Jacek Kuśnierz2022-06-301-0/+1
| | | | | | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge remote-tracking branch 'origin/release-v1.62' into developPatrick Cloke2022-06-302-0/+2
|\|
| * Fix unread counts on large servers (#13140)Erik Johnston2022-06-301-0/+1
| |
| * Add index to help delete old push actions (#13141)Erik Johnston2022-06-301-0/+1
| |
* | Don't process /send requests for users who have hit their ratelimit (#13134)Shay2022-06-301-0/+1
| |
* | Cleanup references to sample config in the docs and redirect users to ↵Shay2022-06-301-0/+3
| | | | | | | | configuration manual (#13077)
* | Add a link to the configuration manual from the homeserver sample config ↵Andrew Morgan2022-06-301-0/+1
| | | | | | | | documentation page (#13139)
* | More type hints for `synapse.logging` (#13103)Patrick Cloke2022-06-301-0/+1
| | | | | | | | Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.
* | Improve startup times in Complement test runs against workers, particularly ↵reivilibre2022-06-301-0/+1
| | | | | | | | | | in CPU-constrained environments. (#13127) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Actually typecheck `tests.test_server` (#13135)David Robertson2022-06-301-0/+1
| |
* | Rate limiting invites per issuer (#13125)David Teller2022-06-301-0/+1
| | | | | | Co-authored-by: reivilibre <oliverw@matrix.org>
* | Don't actually one-line the SQL statements we send to the DB (#13129)Brendan Abolivier2022-06-301-0/+1
| |
* | Implement MSC3827: Filtering of `/publicRooms` by room type (#13031)Šimon Brandner2022-06-291-0/+1
| | | | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Fix documentation header for `allow_public_rooms_over_federation` (#13116)Moritz Stückler2022-06-291-0/+1
| | | | | | | | Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Improve performance of getting unread counts in rooms (#13119)Erik Johnston2022-06-291-0/+1
| |
* | Document the `--report-stats` argument (#13029)jejo862022-06-291-0/+1
|/ | | Signed-off-by: jejo86 <28619134+jejo86@users.noreply.github.com>
* 1.62.0rc1Andrew Morgan2022-06-2877-79/+0
|
* Fix serialization errors when rotating notifications (#13118)Erik Johnston2022-06-281-0/+1
|
* Extra type annotations in `test_server` (#13124)David Robertson2022-06-281-0/+1
|
* Remove unspecced DELETE endpoint that modifies room visibility (#13123)santhoshivan232022-06-281-0/+1
|
* Update MSC3786 implementation: Check the `state_key` (#12939)Šimon Brandner2022-06-271-0/+1
| | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add Cross-Origin-Resource-Policy header to thumbnail and download media ↵Robert Long2022-06-271-0/+1
| | | | endpoints (#12944)
* Refactor the Dockerfile-workers configuration script to use Jinja2 templates ↵reivilibre2022-06-271-0/+1
| | | | | in Synapse workers' Supervisord blocks. (#13054) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Remove docs for Delete Group Admin API (#13112)Aaron Raimist2022-06-271-0/+1
| | | | | | This API no longer exists. Signed-off-by: Aaron Raimist <aaron@raim.ist>
* validate room alias before interacting with the room directory (#13106)santhoshivan232022-06-221-0/+1
|
* Use caret (semver bounds) for matrix.org packages (#13082)David Robertson2022-06-171-0/+1
|
* Update opentracing docs to reference the configuration manual rather than ↵Shay2022-06-171-0/+1
| | | | the configuation file. (#13076)
* Fix inconsistencies in event validation (#13088)Richard van der Hoff2022-06-171-0/+1
|
* Fix inconsistencies in event validation for `m.room.create` events (#13087)Richard van der Hoff2022-06-171-0/+1
| | | | | | | | | | * Extend the auth rule checks for `m.room.create` events ... and move them up to the top of the function. Since the no auth_events are allowed for m.room.create events, we may as well get the m.room.create event checks out of the way first. * Add a test for create events with prev_events
* Add type hints to event push actions tests. (#13099)Patrick Cloke2022-06-172-1/+2
|
* Fix type error that made its way onto develop (#13098)reivilibre2022-06-171-0/+1
| | | | | | | * Fix type error introduced accidentally by #13045 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Update info on downstream debs (#13095)Richard van der Hoff2022-06-171-0/+1
|
* Simplify the alias deletion logic as an application service. (#13093)Quentin Gliech2022-06-171-0/+1
|
* Rotate notifications more frequently (#13096)Erik Johnston2022-06-171-0/+1
|
* Use new `device_list_changes_in_room` table when getting device list changes ↵Erik Johnston2022-06-171-0/+1
| | | | (#13045)
* Allow MSC3030 'timestamp_to_event' calls from anyone on world-readable ↵Quentin Gliech2022-06-171-0/+1
| | | | | rooms. (#13062) Signed-off-by: Quentin Gliech <quenting@element.io>
* Fix logging context misuse when we fail to persist a federation event (#13089)Sean Quah2022-06-171-0/+1
| | | | | | | | | When we fail to persist a federation event, we kick off a task to remove its push actions in the background, using the current logging context. Since we don't `await` that task, we may finish our logging context before the task finishes. There's no reason to not `await` the task, so let's do that. Signed-off-by: Sean Quah <seanq@matrix.org>
* Add desc to `get_earliest_token_for_stats` (#13085)Erik Johnston2022-06-161-0/+1
|
* Add a Subject Alternative Name to the certificate generated for Complement ↵reivilibre2022-06-161-0/+1
| | | | tests. (#13071)
* Improve URL previews for sites with only Twitter card information. (#13056)Patrick Cloke2022-06-161-0/+1
| | | | | | Pull out `twitter:` meta tags when generating a preview and use it to augment any `og:` meta tags. Prefers Open Graph information over Twitter card information.
* Reduce the duplication of code that invokes the rate limiter. (#13070)reivilibre2022-06-161-0/+1
|
* Complement: use SQLite by default (#13075)Richard van der Hoff2022-06-161-0/+1
| | | | | If no database is configured explicitly, use sqlite. This means that you don't have to pass any variables into the image.
* Add custom well-known (#13035)Jacek Kuśnierz2022-06-161-0/+1
| | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Add instructions for running Complement with `gotestfmt`-formatted output ↵reivilibre2022-06-161-0/+1
| | | | locally. (#13073)
* Move some event auth checks out to a different method (#13065)Richard van der Hoff2022-06-151-0/+1
| | | | | | | | | | | | | | * Add auth events to events used in tests * Move some event auth checks out to a different method Some of the event auth checks apply to an event's auth_events, rather than the state at the event - which means they can play no part in state resolution. Move them out to a separate method. * Rename check_auth_rules_for_event Now it only checks the state-dependent auth rules, it needs a better name.
* Add headers to individual options in config documentation to allow for ↵Shay2022-06-151-0/+1
| | | | linking. (#13055)
* Add more tests for room upgrades (#13074)Sean Quah2022-06-151-0/+1
| | | | Signed-off-by: Sean Quah <seanq@element.io>
* Change default `sync_response_cache_duration` (#13042)Erik Johnston2022-06-151-0/+1
|
* Replace pyjwt with authlib in `org.matrix.login.jwt` (#13011)Hannes Lerchl2022-06-151-0/+1
|
* Sort failing jobs in Complement CI to the top of the logs to make them ↵reivilibre2022-06-151-0/+1
| | | | easier to read. (#13057)
* Add a CI job to check that schema deltas are in the correct folder. (#13063)Erik Johnston2022-06-151-0/+1
|
* Type annotations in `synapse.databases.main.devices` (#13025)David Robertson2022-06-151-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Speed up `get_unread_event_push_actions_by_room` (#13005)Erik Johnston2022-06-151-0/+1
| | | | | | | | | | | Fixes #11887 hopefully. The core change here is that `event_push_summary` now holds a summary of counts up until a much more recent point, meaning that the range of rows we need to count in `event_push_actions` is much smaller. This needs two major changes: 1. When we get a receipt we need to recalculate `event_push_summary` rather than just delete it 2. The logic for deleting `event_push_actions` is now divorced from calculating `event_push_summary`. In future it would be good to calculate `event_push_summary` while we persist a new event (it should just be a case of adding one to the relevant rows in `event_push_summary`), as that will further simplify the get counts logic and remove the need for us to periodically update `event_push_summary` in a background job.
* Rename complement-developonly (#13046)Erik Johnston2022-06-151-0/+1
|
* Use updated `update_user_directory_from_worker` options in Complement tests. ↵reivilibre2022-06-151-0/+1
| | | | (#13069)
* Collapse Docker build commands in Complement CI runs to make the logs easier ↵reivilibre2022-06-151-0/+1
| | | | to read. (#13058)
* Track a histogram of state res durations (#13036)David Robertson2022-06-151-0/+1
|
* Fix a long-standing bug which meant that rate limiting was not restrictive ↵reivilibre2022-06-151-0/+1
| | | | enough in some cases. (#13018)
* Don't use keyword arguments when initialising modules (#13060)Brendan Abolivier2022-06-151-0/+1
|
* Clean up schema for `event_edges` (#12893)Richard van der Hoff2022-06-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant references to `event_edges.room_id` We don't need to care about the room_id here, because we are already checking the event id. * Clean up the event_edges table We make a number of changes to `event_edges`: * We give the `room_id` and `is_state` columns defaults (null and false respectively) so that we can stop populating them. * We drop any rows that have `is_state` set true - they should no longer exist. * We drop any rows that do not exist in `events` - these should not exist either. * We drop the old unique constraint on all the colums, which wasn't much use. * We create a new unique index on `(event_id, prev_event_id)`. * We add a foreign key constraint to `events`. These happen rather differently depending on whether we are on Postgres or SQLite. For SQLite, we just rebuild the whole table, copying only the rows we want to keep. For Postgres, we try to do things in the background as much as possible. * Stop populating `event_edges.room_id` and `is_state` We can just rely on the defaults.
* Fix typechecks against twisted trunk (#13061)David Robertson2022-06-151-0/+1
|
* Refactor entry points so that they all have a `main` function. (#13052)reivilibre2022-06-141-0/+1
|
* Fix `destination_is` errors seen in sentry. (#13041)David Robertson2022-06-141-0/+2
| | | | | | * Rename test_fedclient to match its source file * Require at least one destination to be truthy * Explicitly validate user ID in profile endpoint GETs Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Up complement time outs (#13048)Erik Johnston2022-06-141-0/+1
|
* Fix version number in spam checker callbacks doc (#13047)Brendan Abolivier2022-06-141-0/+1
|
* Remove code generating comments in configuration file (#12941)Shay2022-06-141-0/+1
|
* Rename delta to apply in the proper schema version. (#13050)Patrick Cloke2022-06-141-0/+1
|
* Move the "email unsubscribe" resource, refactor the macaroon generator & ↵Quentin Gliech2022-06-141-0/+1
| | | | | | | | | | | | | | | | | | | | | simplify the access token verification logic. (#12986) This simplifies the access token verification logic by removing the `rights` parameter which was only ever used for the unsubscribe link in email notifications. The latter has been moved under the `/_synapse` namespace, since it is not a standard API. This also makes the email verification link more secure, by embedding the app_id and pushkey in the macaroon and verifying it. This prevents the user from tampering the query parameters of that unsubscribe link. Macaroon generation is refactored: - Centralised all macaroon generation and verification logic to the `MacaroonGenerator` - Moved to `synapse.utils` - Changed the constructor to require only a `Clock`, hostname, and a secret key (instead of a full `Homeserver`). - Added tests for all methods.
* Fix Complement runs always being Postgres (#13034)reivilibre2022-06-141-0/+1
| | | | | | | * Fix Complement runs always being Postgres * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Mention removed community/group worker endpoints in upgrade.md (#13023)Sami Olmari2022-06-141-0/+1
|
* Decouple `synapse.api.auth_blocking.AuthBlocking` from ↵Quentin Gliech2022-06-141-0/+1
| | | | `synapse.api.auth.Auth`. (#13021)
* Uniformize spam-checker API, part 4: port other spam-checker callbacks to ↵David Teller2022-06-131-0/+1
| | | | | return `Union[Allow, Codes]`. (#12857) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Replace noop background updates with DELETE. (#12954)Patrick Cloke2022-06-131-0/+1
| | | | Removes the `register_noop_background_update` and deletes the background updates directly in a delta file.
* Merge branch 'rav/simplify_event_auth_interface' into developRichard van der Hoff2022-06-131-0/+1
|\
| * changelogRichard van der Hoff2022-06-121-0/+1
| |
* | Revert "Changelog"David Robertson2022-06-101-1/+0
| | | | | | | | | | | | This reverts commit ae09cc2ee45715f3e5c14a5549b3d142a026406f. This commit was intended for a different branch.
* | ChangelogDavid Robertson2022-06-101-0/+1
| |
* | Add missing TOC link to poetry cheat sheet (#13022)David Robertson2022-06-101-0/+1
| | | | | | Missed by #12475.
* | Fix-up the contrib/graph scripts. (#13013)Patrick Cloke2022-06-101-0/+1
| | | | | | | | | | | | * Clarifies comments and documentation. * Adds type-hints. * Fixes Python 3 compatibility (and runs pyupgrade). * Updates for changes in Synapse internals.
* | Stop depending on `room_id` to be returned for children state in the ↵Patrick Cloke2022-06-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | hierarchy response. (#12991) The `room_id` field was removed from MSC2946 before it was accepted. It was initially kept for backwards compatibility and should be removed now that the stable form of the API is used. This change only stops Synapse from validating that it is returned, a future PR will remove returning it as part of the response.
* | Enable testing against PostgreSQL databases in Complement CI. (#12965)reivilibre2022-06-091-0/+1
| |
* | Fix example of running complement.sh. (#12990)Patrick Cloke2022-06-091-0/+1
| |
* | Faster joins: add issue links to the TODOs (#13004)Richard van der Hoff2022-06-091-0/+1
| | | | | | | | ... to help us keep track of these things
* | Type annotations for `test_v2` (#12985)David Robertson2022-06-091-0/+1
| |
* | Use READ COMMITTED isolation level when inserting read receipts (#12957)Nick Mills-Barrett2022-06-091-0/+1
| |
* | Move the (unstable) `dir` parameter for /relations behind an experimental ↵Patrick Cloke2022-06-081-0/+1
| | | | | | | | | | | | flag. (#12984) MSC3715 defines this parameter, but the unstable version of it should be behind an experimental flag.
* | Use a GitHub form for issues rather than a hard-to-read, easy-to-ignore ↵reivilibre2022-06-081-0/+1
| | | | | | | | | | template. (#12982) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge the Complement testing Docker images into a single, multi-purpose ↵reivilibre2022-06-081-0/+1
| | | | | | | | | | image. (#12881) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Docker Compose Worker Documentation and Examples (#12737)James2022-06-081-0/+1
| |
* | Clean up the test code for client disconnections (#12929)Sean Quah2022-06-071-0/+1
| | | | | | | | | | | | | | * Reword failure message about `await_result=False` * Use `reactor.advance()` instead of `reactor.pump()` * Raise `AssertionError`s ourselves * Un-instance method `_test_disconnect` * Replace `ThreadedMemoryReactorClock` with `MemoryReactorClock`
* | Use dummy fallback engines if imports fail (#12979)David Robertson2022-06-071-0/+1
| |
* | Test cancellation at every `await` during request handling (#12674)Sean Quah2022-06-071-0/+1
| | | | | | | | | | | | * Add tests for `/rooms/<room_id>/members` cancellation. * Add tests for `/rooms/<room_id>/state` cancellation. Signed-off-by: Sean Quah <seanq@element.io>
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-06-0774-74/+0
|\|
| * 1.61.0rc1Olivier Wilkinson (reivilibre)2022-06-0774-74/+0
| |
* | Return the same error message from `/login` when password is incorrect and ↵Daniel Aloni2022-06-071-0/+1
| | | | | | | | when account doesn't exist. (#12738)
* | Fix Synapse git info missing in version strings (#12973)David Robertson2022-06-071-0/+1
| |
* | Reduce amount of state we pull out when attempting to send catchup PDUs. ↵Erik Johnston2022-06-071-0/+1
| | | | | | | | | | | | | | | | | | (#12963) * Don't pull out state for catchup * Newsfile * Merge newsfile
* | Fix a stale comment in get_room_version_id_txn. (#12969)Patrick Cloke2022-06-071-0/+1
| |
* | Consolidate the logic of delete_device/delete_devices. (#12970)Patrick Cloke2022-06-071-0/+1
|/ | | | | | | | By always using delete_devices and sometimes passing a list with a single device ID. Previously these methods had gotten out of sync with each other and it seems there's little benefit to the single-device variant.
* Prevent breaking old sqlite's when media retention is enabled (#12977)Andrew Morgan2022-06-071-0/+1
|
* Prevent local quarantined media from being claimed by media retention (#12972)Andrew Morgan2022-06-071-0/+1
|
* Remove remaining pieces of groups code. (#12966)Patrick Cloke2022-06-061-0/+1
| | | | | * Remove an unused stream ID generator. * Remove the now unused remote profile cache.
* Reduce state pulled from DB due to sending typing and receipts over ↵Erik Johnston2022-06-061-0/+1
| | | | | federation (#12964) Reducing the amount of state we pull from the DB is useful as fetching state is expensive in terms of DB, CPU and memory.
* Do not break URL previews if an image is unreachable. (#12950)Patrick Cloke2022-06-061-0/+1
| | | | Avoid breaking a URL preview completely if the chosen image 404s or is unreachable for some other reason (e.g. DNS).
* Implement MSC3816, consider the root event for thread participation. (#12766)Patrick Cloke2022-06-061-0/+1
| | | | As opposed to only considering a user to have "participated" if they replied to the thread.
* Allow updating passwords using the admin api without logging out devices ↵Jan Christian Grünhage2022-06-061-0/+1
| | | | (#12952)
* Reduce the amount of state we pull from the DB (#12811)Erik Johnston2022-06-061-0/+1
|
* Remove groups code from synapse_port_db. (#12899)Patrick Cloke2022-06-031-0/+1
|
* Improve URL previews for some pages (#12951)Patrick Cloke2022-06-031-0/+1
| | | | | * Skip `og` and `meta` tags where the value is empty. * Fallback to the favicon if there are no other images. * Ignore tags meant for navigation.
* Wait for lazy join to complete when getting current state (#12872)Erik Johnston2022-06-011-0/+1
|
* Fix complement tests using the wrong path (#12933)Michael Telatynski2022-06-011-0/+1
|
* Remove remaining bits of groups code. (#12936)Patrick Cloke2022-06-011-0/+1
| | | | | | * Update worker docs to remove group endpoints. * Removes an unused parameter to `ApplicationService`. * Break dependency between media repo and groups. * Avoid copying `m.room.related_groups` state events during room upgrades.
* Remove direct refeferences to PyNaCl (use signedjson instead). (#12902)Jacek Kuśnierz2022-06-011-0/+1
|
* Fix 404 on `/sync` when the last event is a redaction of an unknown/purged ↵Richard van der Hoff2022-06-011-0/+1
| | | | | | | | | | | event (#12905) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.
* Fix potential thumbnail memory leaks. (#12932)Erik Johnston2022-06-011-0/+1
|
* Remove most groups datastore code. (#12895)Patrick Cloke2022-05-311-0/+1
| | | | The remaining piece is a background update that is needed for backwards compatibility.
* Improve logging when signature checks fail (#12925)Richard van der Hoff2022-05-311-0/+1
| | | | | | | | | | | | | * Raise a dedicated `InvalidEventSignatureError` from `_check_sigs_on_pdu` * Downgrade logging about redactions to DEBUG this can be very spammy during a room join, and it's not very useful. * Raise `InvalidEventSignatureError` from `_check_sigs_and_hash` ... and, more importantly, move the logging out to the callers. * changelog
* Remove groups replication code. (#12900)Patrick Cloke2022-05-311-0/+1
| | | | The replication logic for groups is no longer used, so the message passing infrastructure can be removed.
* Add config options for media retention (#12732)Andrew Morgan2022-05-311-0/+1
|
* Faster room joins: Resume state re-syncing after a Synapse restart (#12813)Sean Quah2022-05-311-0/+1
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Faster room joins: Try other destinations when resyncing the state of a ↵Sean Quah2022-05-311-0/+1
| | | | | | | partial-state room (#12812) Signed-off-by: Sean Quah <seanq@matrix.org>
* Test Synapse against Complement with workers. (#12810)reivilibre2022-05-311-0/+1
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Reduce DB load of /sync when using presence (#12885)Erik Johnston2022-05-311-0/+1
| | | While the query was fast, we were calling it *a lot*.
* Stop reading from `event_edges.room_id`. (#12914)Richard van der Hoff2022-05-311-0/+1
| | | event_edges.room_id is implied by the event id, so there is no need to join on the room id.
* Rename storage classes (#12913)Erik Johnston2022-05-311-0/+1
|
* Rework stream token to stop caring about groups. (#12897)Patrick Cloke2022-05-311-0/+1
|
* Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12923)Travis Ralston2022-05-312-1/+2
|
* Revert "Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922)"Travis Ralston2022-05-302-2/+1
| | | | This reverts commit e0fae823e9938618a260adadb82bfee6e4c2f907.
* Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922)Travis Ralston2022-05-312-1/+2
| | | `M_` is a reserved namespace.
* Don't return `end` from `/messages` if there are no more events (#12903)Jacek Kuśnierz2022-05-301-0/+1
| | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de>
* Document the Synapse version of a new module API method (#12917)Brendan Abolivier2022-05-301-0/+1
|
* Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ↵David Teller2022-05-302-0/+2
| | | | | ability to return additional fields (#12846) Signed-off-by: David Teller <davidt@element.io>
* demo: check if we are in a virtualenv before overriding PYTHONPATH (#12916)Mathieu Velten2022-05-301-0/+1
|
* Add a migration step to cleanup potential leftovers of bug 11833 (#12784)Mathieu Velten2022-05-301-0/+1
| | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Fix invite notifications for users without pushers (#12840)DeepBlueV7.X2022-05-301-0/+1
| | | | Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* Fix `get_metadata_for_events` (#12904)Richard van der Hoff2022-05-301-0/+1
| | | | This method was introduced in #12852. It is using the `state_key` column from the `events` table, which is not (yet) reliable (see #11496).
* Remove unused `contrib/experiments/cursesio.py` (#12910)David Robertson2022-05-301-0/+1
|
* Remove `contrib/experiments/test_messaging.py` (#12911)David Robertson2022-05-301-0/+1
|
* Remove contrib/jitsimeetbridge (#12909)David Robertson2022-05-301-0/+1
|
* Remove contrib/scripts/kick_users.py (#12908)David Robertson2022-05-301-0/+1
|
* Bump jsonschema stubs (#12912)David Robertson2022-05-301-0/+1
|
* Mutual rooms: Remove dependency on user directory (#12836)Jonathan de Jong2022-05-301-0/+1
|
* LockStore: fix acquiring a lock via `LockStore.try_acquire_lock` (#12832)Sumner Evans2022-05-301-0/+1
| | | Signed-off-by: Sumner Evans <sumner@beeper.com>
* Add a background job to automatically delete stale devices (#12855)Brendan Abolivier2022-05-271-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add code M_USER_ACCOUNT_SUSPENDED, as per MSC3823. (#12845)David Teller2022-05-271-0/+1
| | | | Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Clean-up some receipts code (#12888)Patrick Cloke2022-05-271-0/+1
| | | | | * Properly marks private methods as private. * Adds missing docstrings. * Rework inline methods.
* Additional constants for EDU types. (#12884)Patrick Cloke2022-05-271-0/+1
| | | Instead of hard-coding strings in many places.
* Remove federation client code for groups. (#12563)Patrick Cloke2022-05-271-0/+1
|
* Add storage and module API methods to get monthly active users and their ↵Matt C2022-05-271-0/+1
| | | | appservices (#12838)
* Easy type hints in synapse.logging.opentracing (#12894)David Robertson2022-05-271-0/+1
|
* Fix room deletion (#12889)Richard van der Hoff2022-05-271-0/+1
| | | | | | | | | * Fix room deletion ae7858f broke room deletion by attempting to delete the entry from `rooms` before the tables that reference it. * faster_joins: remove database rows on purge
* Refactor have_seen_events to reduce OOMs (#12886)Richard van der Hoff2022-05-271-0/+1
| | | | | My server is currently OOMing in the middle of have_seen_events, so let's try to fix that.
* Remove backing code for groups/communities (#12558)Patrick Cloke2022-05-261-0/+1
| | | | Including handlers, configuration code, appservice support, and the GroupID construct.
* Bump pyjwt from 2.3.0 to 2.4.0 (#12865)dependabot[bot]2022-05-261-0/+1
| | | | | | | | | | | | | | | Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](https://github.com/jpadilla/pyjwt/compare/2.3.0...2.4.0) --- updated-dependencies: - dependency-name: pyjwt dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
* Fix ambiguous column name that would prevent use of MSC2716 History Import ↵reivilibre2022-05-261-0/+1
| | | | when using Postgres as a database. (#12843)
* Remove unstable APIs for /hierarchy. (#12851)Patrick Cloke2022-05-261-0/+1
| | | | Removes the unstable endpoint as well as a duplicated field which was modified during stabilization.
* Avoid attempting to delete push actions for remote users. (#12879)Patrick Cloke2022-05-261-0/+1
| | | | Remote users will never have push actions, so we can avoid a database round-trip/transaction completely.
* Pull out less state when handling gaps mk2 (#12852)Erik Johnston2022-05-261-0/+1
|
* Allow bigger responses to `/federation/v1/state` (#12877)Richard van der Hoff2022-05-251-0/+1
| | | | | | | | | | | * Refactor HTTP response size limits Rather than passing a separate `max_response_size` down the stack, make it an attribute of the `parser`. * Allow bigger responses on `federation/v1/state` `/state` can return huge responses, so we need to handle that.
* Fix up `state_store` naming (#12871)Erik Johnston2022-05-251-0/+1
|
* Remove user-visible groups/communities code (#12553)Patrick Cloke2022-05-251-0/+1
| | | | | | | | | Makes it so that groups/communities no longer exist from a user-POV. E.g. we remove: * All API endpoints (including Client-Server, Server-Server, and admin). * Documented configuration options (and the experimental flag, which is now unused). * Special handling during room upgrades. * The `groups` section of the `/sync` response.
* Fix caching behavior for relations push rules. (#12859)Patrick Cloke2022-05-251-0/+1
| | | | | By always returning all requested values from the function wrapped by cachedList. Otherwise implicit None values get added into the cache, which are unexpected.
* Misc clean-up of push rules datastore (#12856)Patrick Cloke2022-05-251-0/+1
|
* Correct typo in changelog for #12858.David Robertson2022-05-251-1/+1
|
* Add the `batch_send` endpoint to generic workers (#12868)Nick Mills-Barrett2022-05-251-0/+1
|
* Don't create empty AS txns when the AS is down (#12869)Nick Mills-Barrett2022-05-251-0/+1
|
* Add the `/account/whoami` endpoint to generic workers (#12866)Nick Mills-Barrett2022-05-251-0/+1
|
* Fix incorrect worker-allowed path in documentation (#12867)Nick Mills-Barrett2022-05-251-0/+1
|
* Make sure `prev_ids` defaults to empty list (#12829)Carl Bordum Hansen2022-05-251-0/+1
| | | Signed-off-by: Carl Bordum Hansen <carl@bordum.dk>
* Fix typos in documentation (#12863)Dirk Klimpel2022-05-251-0/+1
|
* Correct annotation of `_iterate_over_text` (#12860)David Robertson2022-05-241-0/+1
|
* Fixes to MSC3787 implementation (#12858)David Robertson2022-05-241-0/+1
|
* Remove `dont_notify` from the `.m.rule.room.server_acl` rule (#12849)Šimon Brandner2022-05-241-0/+1
| | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* Add authentication to thirdparty bridge APIs (#12746)Will Hunt2022-05-241-0/+1
| | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Merge tag 'v1.60.0rc1' into developSean Quah2022-05-2484-86/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.60.0rc1 (2022-05-24) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Measure the time taken in spam-checking callbacks and expose those measurements as metrics. ([\#12513](https://github.com/matrix-org/synapse/issues/12513)) - Add a `default_power_level_content_override` config option to set default room power levels per room preset. ([\#12618](https://github.com/matrix-org/synapse/issues/12618)) - Add support for [MSC3787: Allowing knocks to restricted rooms](https://github.com/matrix-org/matrix-spec-proposals/pull/3787). ([\#12623](https://github.com/matrix-org/synapse/issues/12623)) - Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. ([\#12672](https://github.com/matrix-org/synapse/issues/12672), [\#12809](https://github.com/matrix-org/synapse/issues/12809)) - Synapse will now reload [cache config](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#caching) when it receives a [SIGHUP](https://en.wikipedia.org/wiki/SIGHUP) signal. ([\#12673](https://github.com/matrix-org/synapse/issues/12673)) - Add a config options to allow for auto-tuning of caches. ([\#12701](https://github.com/matrix-org/synapse/issues/12701)) - Update [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) implementation to process marker events from the current state to avoid markers being lost in timeline gaps for federated servers which would cause the imported history to be undiscovered. ([\#12718](https://github.com/matrix-org/synapse/issues/12718)) - Add a `drop_federated_event` callback to `SpamChecker` to disregard inbound federated events before they take up much processing power, in an emergency. ([\#12744](https://github.com/matrix-org/synapse/issues/12744)) - Implement [MSC3818: Copy room type on upgrade](https://github.com/matrix-org/matrix-spec-proposals/pull/3818). ([\#12786](https://github.com/matrix-org/synapse/issues/12786), [\#12792](https://github.com/matrix-org/synapse/issues/12792)) - Update to the `check_event_for_spam` module callback. Deprecate the current callback signature, replace it with a new signature that is both less ambiguous (replacing booleans with explicit allow/block) and more powerful (ability to return explicit error codes). ([\#12808](https://github.com/matrix-org/synapse/issues/12808)) Bugfixes -------- - Fix a bug introduced in Synapse 1.7.0 that would prevent events from being sent to clients if there's a retention policy in the room when the support for retention policies is disabled. ([\#12611](https://github.com/matrix-org/synapse/issues/12611)) - Fix a bug introduced in Synapse 1.57.0 where `/messages` would throw a 500 error when querying for a non-existent room. ([\#12683](https://github.com/matrix-org/synapse/issues/12683)) - Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. ([\#12687](https://github.com/matrix-org/synapse/issues/12687)) - Fix a long-standing bug where an empty room would be created when a user with an insufficient power level tried to upgrade a room. ([\#12696](https://github.com/matrix-org/synapse/issues/12696)) - Fix a bug introduced in Synapse 1.30.0 where empty rooms could be automatically created if a monthly active users limit is set. ([\#12713](https://github.com/matrix-org/synapse/issues/12713)) - Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper. ([\#12721](https://github.com/matrix-org/synapse/issues/12721)) - Fix poor database performance when reading the cache invalidation stream for large servers with lots of workers. ([\#12747](https://github.com/matrix-org/synapse/issues/12747)) - Delete events from the `federation_inbound_events_staging` table when a room is purged through the admin API. ([\#12770](https://github.com/matrix-org/synapse/issues/12770)) - Give a meaningful error message when a client tries to create a room with an invalid alias localpart. ([\#12779](https://github.com/matrix-org/synapse/issues/12779)) - Fix a bug introduced in 1.43.0 where a file (`providers.json`) was never closed. Contributed by @arkamar. ([\#12794](https://github.com/matrix-org/synapse/issues/12794)) - Fix a long-standing bug where finished log contexts would be re-started when failing to contact remote homeservers. ([\#12803](https://github.com/matrix-org/synapse/issues/12803)) - Fix a bug, introduced in Synapse 1.21.0, that led to media thumbnails being unusable before the index has been added in the background. ([\#12823](https://github.com/matrix-org/synapse/issues/12823)) Updates to the Docker image --------------------------- - Fix the docker file after a dependency update. ([\#12853](https://github.com/matrix-org/synapse/issues/12853)) Improved Documentation ---------------------- - Fix a typo in the Media Admin API documentation. ([\#12715](https://github.com/matrix-org/synapse/issues/12715)) - Update the OpenID Connect example for Keycloak to be compatible with newer versions of Keycloak. Contributed by @nhh. ([\#12727](https://github.com/matrix-org/synapse/issues/12727)) - Fix typo in server listener documentation. ([\#12742](https://github.com/matrix-org/synapse/issues/12742)) - Link to the configuration manual from the welcome page of the documentation. ([\#12748](https://github.com/matrix-org/synapse/issues/12748)) - Fix typo in `run_background_tasks_on` option name in configuration manual documentation. ([\#12749](https://github.com/matrix-org/synapse/issues/12749)) - Add information regarding the `rc_invites` ratelimiting option to the configuration docs. ([\#12759](https://github.com/matrix-org/synapse/issues/12759)) - Add documentation for cancellation of request processing. ([\#12761](https://github.com/matrix-org/synapse/issues/12761)) - Recommend using docker to run tests against postgres. ([\#12765](https://github.com/matrix-org/synapse/issues/12765)) - Add missing user directory endpoint from the generic worker documentation. Contributed by @olmari. ([\#12773](https://github.com/matrix-org/synapse/issues/12773)) - Add additional info to documentation of config option `cache_autotuning`. ([\#12776](https://github.com/matrix-org/synapse/issues/12776)) - Update configuration manual documentation to document size-related suffixes. ([\#12777](https://github.com/matrix-org/synapse/issues/12777)) - Fix invalid YAML syntax in the example documentation for the `url_preview_accept_language` config option. ([\#12785](https://github.com/matrix-org/synapse/issues/12785)) Deprecations and Removals ------------------------- - Require a body in POST requests to `/rooms/{roomId}/receipt/{receiptType}/{eventId}`, as required by the [Matrix specification](https://spec.matrix.org/v1.2/client-server-api/#post_matrixclientv3roomsroomidreceiptreceipttypeeventid). This breaks compatibility with Element Android 1.2.0 and earlier: users of those clients will be unable to send read receipts. ([\#12709](https://github.com/matrix-org/synapse/issues/12709)) Internal Changes ---------------- - Improve event caching mechanism to avoid having multiple copies of an event in memory at a time. ([\#10533](https://github.com/matrix-org/synapse/issues/10533)) - Preparation for faster-room-join work: return subsets of room state which we already have, immediately. ([\#12498](https://github.com/matrix-org/synapse/issues/12498)) - Add `@cancellable` decorator, for use on endpoint methods that can be cancelled when clients disconnect. ([\#12586](https://github.com/matrix-org/synapse/issues/12586), [\#12588](https://github.com/matrix-org/synapse/issues/12588), [\#12630](https://github.com/matrix-org/synapse/issues/12630), [\#12694](https://github.com/matrix-org/synapse/issues/12694), [\#12698](https://github.com/matrix-org/synapse/issues/12698), [\#12699](https://github.com/matrix-org/synapse/issues/12699), [\#12700](https://github.com/matrix-org/synapse/issues/12700), [\#12705](https://github.com/matrix-org/synapse/issues/12705)) - Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$event_type/*` requests. ([\#12708](https://github.com/matrix-org/synapse/issues/12708)) - Improve documentation of the `synapse.push` module. ([\#12676](https://github.com/matrix-org/synapse/issues/12676)) - Refactor functions to on `PushRuleEvaluatorForEvent`. ([\#12677](https://github.com/matrix-org/synapse/issues/12677)) - Preparation for database schema simplifications: stop writing to `event_reference_hashes`. ([\#12679](https://github.com/matrix-org/synapse/issues/12679)) - Remove code which updates unused database column `application_services_state.last_txn`. ([\#12680](https://github.com/matrix-org/synapse/issues/12680)) - Refactor `EventContext` class. ([\#12689](https://github.com/matrix-org/synapse/issues/12689)) - Remove an unneeded class in the push code. ([\#12691](https://github.com/matrix-org/synapse/issues/12691)) - Consolidate parsing of relation information from events. ([\#12693](https://github.com/matrix-org/synapse/issues/12693)) - Convert namespace class `Codes` into a string enum. ([\#12703](https://github.com/matrix-org/synapse/issues/12703)) - Optimize private read receipt filtering. ([\#12711](https://github.com/matrix-org/synapse/issues/12711)) - Drop the logging level of status messages for the URL preview cache expiry job from INFO to DEBUG. ([\#12720](https://github.com/matrix-org/synapse/issues/12720)) - Downgrade some OIDC errors to warnings in the logs, to reduce the noise of Sentry reports. ([\#12723](https://github.com/matrix-org/synapse/issues/12723)) - Update configs used by Complement to allow more invites/3PID validations during tests. ([\#12731](https://github.com/matrix-org/synapse/issues/12731)) - Fix a long-standing bug where the user directory background process would fail to make forward progress if a user included a null codepoint in their display name or avatar. ([\#12762](https://github.com/matrix-org/synapse/issues/12762)) - Tweak the mypy plugin so that `@cached` can accept `on_invalidate=None`. ([\#12769](https://github.com/matrix-org/synapse/issues/12769)) - Move methods that call `add_push_rule` to the `PushRuleStore` class. ([\#12772](https://github.com/matrix-org/synapse/issues/12772)) - Make handling of federation Authorization header (more) compliant with RFC7230. ([\#12774](https://github.com/matrix-org/synapse/issues/12774)) - Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. ([\#12775](https://github.com/matrix-org/synapse/issues/12775)) - Do not keep going if there are 5 back-to-back background update failures. ([\#12781](https://github.com/matrix-org/synapse/issues/12781)) - Fix federation when using the demo scripts. ([\#12783](https://github.com/matrix-org/synapse/issues/12783)) - The `hash_password` script now fails when it is called without specifying a config file. Contributed by @jae1911. ([\#12789](https://github.com/matrix-org/synapse/issues/12789)) - Improve and fix type hints. ([\#12567](https://github.com/matrix-org/synapse/issues/12567), [\#12477](https://github.com/matrix-org/synapse/issues/12477), [\#12717](https://github.com/matrix-org/synapse/issues/12717), [\#12753](https://github.com/matrix-org/synapse/issues/12753), [\#12695](https://github.com/matrix-org/synapse/issues/12695), [\#12734](https://github.com/matrix-org/synapse/issues/12734), [\#12716](https://github.com/matrix-org/synapse/issues/12716), [\#12726](https://github.com/matrix-org/synapse/issues/12726), [\#12790](https://github.com/matrix-org/synapse/issues/12790), [\#12833](https://github.com/matrix-org/synapse/issues/12833)) - Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible. ([\#12791](https://github.com/matrix-org/synapse/issues/12791)) - Remove Caddy from the Synapse workers image used in Complement. ([\#12818](https://github.com/matrix-org/synapse/issues/12818)) - Add Complement's shared registration secret to the Complement worker image. This fixes tests that depend on it. ([\#12819](https://github.com/matrix-org/synapse/issues/12819)) - Support registering Application Services when running with workers under Complement. ([\#12826](https://github.com/matrix-org/synapse/issues/12826)) - Disable 'faster room join' Complement tests when testing against Synapse with workers. ([\#12842](https://github.com/matrix-org/synapse/issues/12842))
| * 1.60.0rc1Sean Quah2022-05-2484-86/+0
| |
* | Experimental support for MSC3772 (#12740)Patrick Cloke2022-05-241-0/+1
|/ | | | | | | | | | Implements the following behind an experimental configuration flag: * A new push rule kind for mutually related events. * A new default push rule (`.m.rule.thread_reply`) under an unstable prefix. This is missing part of MSC3772: * The `.m.rule.thread_reply_to_me` push rule, this depends on MSC3664 / #11804.
* Pin poetry.core in Docker images (#12853)Erik Johnston2022-05-241-0/+1
|
* Marker events as state - MSC2716 (#12718)Eric Eastwood2022-05-231-0/+1
| | | | | | | | | | | | | | | | Sending marker events as state now so they are always able to be seen by homeservers (not lost in some timeline gap). Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) Complement tests: https://github.com/matrix-org/complement/pull/371 As initially discussed at https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r782629097 and https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r876684431 When someone joins a room, process all of the marker events we see in the current state. Marker events should be sent with a unique `state_key` so that they can all resolve in the current state to easily be discovered. Marker events as state - If we re-use the same `state_key` (like `""`), then we would have to fetch previous snapshots of state up through time to find all of the marker events. This way we can avoid all of that. This PR was originally doing this but then thought of the smarter way to tackle in an [out of band discussion with @erikjohnston](https://docs.google.com/document/d/1JJDuPfcPNX75fprdTWlxlaKjWOdbdJylbpZ03hzo638/edit#bookmark=id.sm92fqyq7vpp). - Also avoids state resolution conflicts where only one of the marker events win As a homeserver, when we see new marker state, we know there is new history imported somewhere back in time and should process it to fetch the insertion event where the historical messages are and set it as an insertion extremity. This way we know where to backfill more messages when someone asks for scrollback.
* Uniformize spam-checker API, part 2: check_event_for_spam (#12808)David Teller2022-05-231-0/+1
| | | Signed-off-by: David Teller <davidt@element.io>
* Prevent expired events from being filtered out when retention is disabled ↵Brendan Abolivier2022-05-231-0/+1
| | | | | | (#12611) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* add SpamChecker callback for silently dropping inbound federated events (#12744)Jess Porter2022-05-231-0/+1
| | | Signed-off-by: jesopo <github@lolnerd.net>
* Disable 'faster room join' Complement tests when testing against Synapse ↵reivilibre2022-05-231-0/+1
| | | | with workers. (#12842)
* Support registering Application Services when running with workers under ↵reivilibre2022-05-231-0/+1
| | | | | Complement. (#12826) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add some type hints to tests files (#12833)Dirk Klimpel2022-05-231-0/+1
| | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Fix Complement `TestCanRegisterAdmin` with workers, by adding Complement's ↵reivilibre2022-05-231-0/+1
| | | | shared registration secret. (#12819)
* Remove Caddy from the Synapse workers image used in Complement. (#12818)reivilibre2022-05-231-0/+1
|
* Fix media thumbnails being unusable before the index had been added in the ↵reivilibre2022-05-231-0/+1
| | | | background. (#12823)
* Send `USER_IP` commands on a different Redis channel, in order to reduce ↵reivilibre2022-05-203-1/+2
| | | | traffic to workers that do not process these commands. (#12809)
* Uniformize spam-checker API, part 1: the `Code` enum. (#12703)David Teller2022-05-201-0/+1
|
* Update EventContext `get_current_event_ids` and `get_prev_event_ids` to ↵Shay2022-05-201-0/+1
| | | | accept state filters and update calls where possible (#12791)
* Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803)Sean Quah2022-05-191-0/+1
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-18 04:32:18 +0000