summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Give the user a better error when they present bad SSO credsRichard van der Hoff2021-01-131-0/+1
| | | | | | | | | If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO IdP, try to give them a better error. Previously, the UIA would claim to be successful, but then the operation in question would simply fail with "auth fail". Instead, serve up an error page which explains the failure.
* Add a test for UI-Auth-via-SSO (#9082)Richard van der Hoff2021-01-131-0/+1
| | | | | * Add complete test for UI-Auth-via-SSO. * review comments
* Merge pull request #9105 from matrix-org/rav/multi_idp/oidc_provider_configRichard van der Hoff2021-01-131-0/+1
|\ | | | | Enhancements to OIDC configuration handling
| * changelogRichard van der Hoff2021-01-131-0/+1
| |
* | Reduce scope of exception handler. (#9106)Patrick Cloke2021-01-131-0/+1
| | | | | | | | Removes a bare `except Exception` clause and replaces it with catching a specific exception around the portion that might throw.
* | Register the /devices endpoint on workers. (#9092)Patrick Cloke2021-01-131-0/+1
|/
* Add basic domain validation for `DomainSpecificString.is_valid`. (#9071)Patrick Cloke2021-01-131-0/+1
| | | | | This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.
* Preparatory refactors of OidcHandler (#9067)Richard van der Hoff2021-01-131-0/+1
| | | | | | | | Some light refactoring of OidcHandler, in preparation for bigger things: * remove inheritance from deprecated BaseHandler * add an object to hold the things that go into a session cookie * factor out a separate class for manipulating said cookies
* Remove user's avatar URL and displayname when deactivated. (#8932)Dirk Klimpel2021-01-121-0/+1
| | | This only applies if the user's data is to be erased.
* UI Auth via SSO: redirect the user to an appropriate SSO. (#9081)Richard van der Hoff2021-01-121-0/+1
| | | | | | | If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one. There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated. Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.
* Handle bad JSON data being returned from the federation API. (#9070)Patrick Cloke2021-01-121-0/+1
|
* Kill off `HomeServer.get_ip_from_request()` (#9080)Richard van der Hoff2021-01-121-0/+1
| | | Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
* Remove SynapseRequest.get_user_agent (#9069)Richard van der Hoff2021-01-121-0/+1
| | | | | | | | | | | SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.
* Also support remote users on the joined_rooms admin API. (#8948)David Teller2021-01-111-0/+1
| | | | For remote users, only the rooms which the server knows about are returned. Local users have all of their joined rooms returned.
* Move more encryption endpoints off master (#9068)Erik Johnston2021-01-111-0/+1
|
* Removes unnecessary declarations in the tests for the admin API. (#9063)Dirk Klimpel2021-01-111-0/+1
|
* Use a chain cover index to efficiently calculate auth chain difference (#8868)Erik Johnston2021-01-111-0/+1
|
* Clean up exception handling in the startup code (#9059)Richard van der Hoff2021-01-111-0/+1
| | | | Factor out the exception handling in the startup code to a utility function, and fix the some logging and exit code stuff.
* Remove old tables after schema version bump (#9055)Erik Johnston2021-01-111-0/+1
| | | | | These tables are unused, and can be dropped now the schema version has been bumped.
* Ensure rejected events get added to some metadata tables (#9016)Erik Johnston2021-01-111-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Fix a typo in the install docs. (#9040)0xflotus2021-01-111-0/+1
|
* Remove unused SynapseService (#9058)Richard van der Hoff2021-01-111-0/+1
|
* Drop last_used column from access_tokens (#9025)Jerin J Titus2021-01-111-0/+1
| | | | | * Dropped last_used column from access_tokens Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* Keycloak mapping_provider example (#9037) (#9057)Christopher Rücker2021-01-081-0/+1
| | | | | This PR adds the missing user_mapping_provider section in oidc.md Signed-off-by: Christopher Rücker chris-ruecker@protonmail.com
* Fix "Starting metrics collection from sentinel context" errors (#9053)Erik Johnston2021-01-081-0/+1
|
* Merge pull request #9036 from matrix-org/rav/multi_idp/testsRichard van der Hoff2021-01-081-0/+1
|\ | | | | Add tests for the IdP picker
| * changelogRichard van der Hoff2021-01-071-0/+1
| |
* | Fix validate_config on nested objects (#9054)Richard van der Hoff2021-01-081-0/+1
| |
* | Fix error handling during insertion of client IPs (#9051)Erik Johnston2021-01-081-0/+1
| | | | | | | | | | You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.
* | Remove broken and unmaintained 'webserver.py' script (#9039)Richard van der Hoff2021-01-081-0/+1
| | | | | | | | | | | | I'm not even sure what this was supposed to do, but the fact it has python2isms and nobody has noticed suggests it's not terribly important. It doesn't seem to have been used since ff23e5ba3764506c99d9c1c640e202fe262b65ce.
* | Run the linters on a consistent list of files (#9038)Richard van der Hoff2021-01-081-0/+1
| | | | | | | | | | We were running some linters on some files and some on others. Extract a common setting and use it everywhere.
* | Allow running sendToDevice on workers (#9044)Erik Johnston2021-01-071-0/+1
| |
* | Support routing edu's to multiple instances (#9042)Erik Johnston2021-01-071-0/+1
| | | | | | This is in preparation for moving `SendToDeviceServlet` off master
* | Ensure that remote users' device list resyncing always happens on master (#9043)Erik Johnston2021-01-071-0/+1
| | | | | | Currently `DeviceMessageHandler` only ever exists on master, but that is about to change.
* | Some cleanups to device inbox store. (#9041)Erik Johnston2021-01-071-0/+1
| |
* | Fix typo in docs/systemd-with-workers/README.md (#9035)Emelie2021-01-071-0/+1
| | | | | | Signed-off-by: Emelie em@nao.sh
* | Improve the performance of calculating ignored users in large rooms (#9024)Patrick Cloke2021-01-071-0/+1
|/ | | | | | This allows for efficiently finding which users ignore a particular user. Co-authored-by: Erik Johnston <erik@matrix.org>
* tox: Add a -noextras factor (#9030)Richard van der Hoff2021-01-071-0/+1
| | | ... for running the tests with no optional deps.
* Skip unit tests which require optional dependencies (#9031)Richard van der Hoff2021-01-071-0/+1
| | | If we are lacking an optional dependency, skip the tests that rely on it.
* Handle updating schema version without any deltas. (#9033)Erik Johnston2021-01-071-0/+1
| | | | This can happen when using a split out state database and we've upgraded the schema version without there being any changes in the state schema.
* Empty iterables should count towards cache usage. (#9028)Patrick Cloke2021-01-061-0/+1
|
* Merge tag 'v1.25.0rc1' into developPatrick Cloke2021-01-0677-77/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.25.0rc1 (2021-01-06) ============================== Removal warning --------------- The old [Purge Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/purge_room.md) and [Shutdown Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/shutdown_room.md) are deprecated and will be removed in a future release. They will be replaced by the [Delete Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/rooms.md#delete-room-api). `POST /_synapse/admin/v1/rooms/<room_id>/delete` replaces `POST /_synapse/admin/v1/purge_room` and `POST /_synapse/admin/v1/shutdown_room/<room_id>`. Features -------- - Add an admin API that lets server admins get power in rooms in which local users have power. ([\#8756](https://github.com/matrix-org/synapse/issues/8756)) - Add optional HTTP authentication to replication endpoints. ([\#8853](https://github.com/matrix-org/synapse/issues/8853)) - Improve the error messages printed as a result of configuration problems for extension modules. ([\#8874](https://github.com/matrix-org/synapse/issues/8874)) - Add the number of local devices to Room Details Admin API. Contributed by @dklimpel. ([\#8886](https://github.com/matrix-org/synapse/issues/8886)) - Add `X-Robots-Tag` header to stop web crawlers from indexing media. Contributed by Aaron Raimist. ([\#8887](https://github.com/matrix-org/synapse/issues/8887)) - Spam-checkers may now define their methods as `async`. ([\#8890](https://github.com/matrix-org/synapse/issues/8890)) - Add support for allowing users to pick their own user ID during a single-sign-on login. ([\#8897](https://github.com/matrix-org/synapse/issues/8897), [\#8900](https://github.com/matrix-org/synapse/issues/8900), [\#8911](https://github.com/matrix-org/synapse/issues/8911), [\#8938](https://github.com/matrix-org/synapse/issues/8938), [\#8941](https://github.com/matrix-org/synapse/issues/8941), [\#8942](https://github.com/matrix-org/synapse/issues/8942), [\#8951](https://github.com/matrix-org/synapse/issues/8951)) - Add an `email.invite_client_location` configuration option to send a web client location to the invite endpoint on the identity server which allows customisation of the email template. ([\#8930](https://github.com/matrix-org/synapse/issues/8930)) - The search term in the list room and list user Admin APIs is now treated as case-insensitive. ([\#8931](https://github.com/matrix-org/synapse/issues/8931)) - Apply an IP range blacklist to push and key revocation requests. ([\#8821](https://github.com/matrix-org/synapse/issues/8821), [\#8870](https://github.com/matrix-org/synapse/issues/8870), [\#8954](https://github.com/matrix-org/synapse/issues/8954)) - Add an option to allow re-use of user-interactive authentication sessions for a period of time. ([\#8970](https://github.com/matrix-org/synapse/issues/8970)) - Allow running the redact endpoint on workers. ([\#8994](https://github.com/matrix-org/synapse/issues/8994)) Bugfixes -------- - Fix bug where we might not correctly calculate the current state for rooms with multiple extremities. ([\#8827](https://github.com/matrix-org/synapse/issues/8827)) - Fix a long-standing bug in the register admin endpoint (`/_synapse/admin/v1/register`) when the `mac` field was not provided. The endpoint now properly returns a 400 error. Contributed by @edwargix. ([\#8837](https://github.com/matrix-org/synapse/issues/8837)) - Fix a long-standing bug on Synapse instances supporting Single-Sign-On, where users would be prompted to enter their password to confirm certain actions, even though they have not set a password. ([\#8858](https://github.com/matrix-org/synapse/issues/8858)) - Fix a longstanding bug where a 500 error would be returned if the `Content-Length` header was not provided to the upload media resource. ([\#8862](https://github.com/matrix-org/synapse/issues/8862)) - Add additional validation to pusher URLs to be compliant with the specification. ([\#8865](https://github.com/matrix-org/synapse/issues/8865)) - Fix the error code that is returned when a user tries to register on a homeserver on which new-user registration has been disabled. ([\#8867](https://github.com/matrix-org/synapse/issues/8867)) - Fix a bug where `PUT /_synapse/admin/v2/users/<user_id>` failed to create a new user when `avatar_url` is specified. Bug introduced in Synapse v1.9.0. ([\#8872](https://github.com/matrix-org/synapse/issues/8872)) - Fix a 500 error when attempting to preview an empty HTML file. ([\#8883](https://github.com/matrix-org/synapse/issues/8883)) - Fix occasional deadlock when handling SIGHUP. ([\#8918](https://github.com/matrix-org/synapse/issues/8918)) - Fix login API to not ratelimit application services that have ratelimiting disabled. ([\#8920](https://github.com/matrix-org/synapse/issues/8920)) - Fix bug where we ratelimited auto joining of rooms on registration (using `auto_join_rooms` config). ([\#8921](https://github.com/matrix-org/synapse/issues/8921)) - Fix a bug where deactivated users appeared in the user directory when their profile information was updated. ([\#8933](https://github.com/matrix-org/synapse/issues/8933), [\#8964](https://github.com/matrix-org/synapse/issues/8964)) - Fix bug introduced in Synapse v1.24.0 which would cause an exception on startup if both `enabled` and `localdb_enabled` were set to `False` in the `password_config` setting of the configuration file. ([\#8937](https://github.com/matrix-org/synapse/issues/8937)) - Fix a bug where 500 errors would be returned if the `m.room_history_visibility` event had invalid content. ([\#8945](https://github.com/matrix-org/synapse/issues/8945)) - Fix a bug causing common English words to not be considered for a user directory search. ([\#8959](https://github.com/matrix-org/synapse/issues/8959)) - Fix bug where application services couldn't register new ghost users if the server had reached its MAU limit. ([\#8962](https://github.com/matrix-org/synapse/issues/8962)) - Fix a long-standing bug where a `m.image` event without a `url` would cause errors on push. ([\#8965](https://github.com/matrix-org/synapse/issues/8965)) - Fix a small bug in v2 state resolution algorithm, which could also cause performance issues for rooms with large numbers of power levels. ([\#8971](https://github.com/matrix-org/synapse/issues/8971)) - Add validation to the `sendToDevice` API to raise a missing parameters error instead of a 500 error. ([\#8975](https://github.com/matrix-org/synapse/issues/8975)) - Add validation of group IDs to raise a 400 error instead of a 500 eror. ([\#8977](https://github.com/matrix-org/synapse/issues/8977)) Improved Documentation ---------------------- - Fix the "Event persist rate" section of the included grafana dashboard by adding missing prometheus rules. ([\#8802](https://github.com/matrix-org/synapse/issues/8802)) - Combine related media admin API docs. ([\#8839](https://github.com/matrix-org/synapse/issues/8839)) - Fix an error in the documentation for the SAML username mapping provider. ([\#8873](https://github.com/matrix-org/synapse/issues/8873)) - Clarify comments around template directories in `sample_config.yaml`. ([\#8891](https://github.com/matrix-org/synapse/issues/8891)) - Moved instructions for database setup, adjusted heading levels and improved syntax highlighting in [INSTALL.md](../INSTALL.md). Contributed by fossterer. ([\#8987](https://github.com/matrix-org/synapse/issues/8987)) - Update the example value of `group_creation_prefix` in the sample configuration. ([\#8992](https://github.com/matrix-org/synapse/issues/8992)) - Link the Synapse developer room to the development section in the docs. ([\#9002](https://github.com/matrix-org/synapse/issues/9002)) Deprecations and Removals ------------------------- - Deprecate Shutdown Room and Purge Room Admin APIs. ([\#8829](https://github.com/matrix-org/synapse/issues/8829)) Internal Changes ---------------- - Properly store the mapping of external ID to Matrix ID for CAS users. ([\#8856](https://github.com/matrix-org/synapse/issues/8856), [\#8958](https://github.com/matrix-org/synapse/issues/8958)) - Remove some unnecessary stubbing from unit tests. ([\#8861](https://github.com/matrix-org/synapse/issues/8861)) - Remove unused `FakeResponse` class from unit tests. ([\#8864](https://github.com/matrix-org/synapse/issues/8864)) - Pass `room_id` to `get_auth_chain_difference`. ([\#8879](https://github.com/matrix-org/synapse/issues/8879)) - Add type hints to push module. ([\#8880](https://github.com/matrix-org/synapse/issues/8880), [\#8882](https://github.com/matrix-org/synapse/issues/8882), [\#8901](https://github.com/matrix-org/synapse/issues/8901), [\#8940](https://github.com/matrix-org/synapse/issues/8940), [\#8943](https://github.com/matrix-org/synapse/issues/8943), [\#9020](https://github.com/matrix-org/synapse/issues/9020)) - Simplify logic for handling user-interactive-auth via single-sign-on servers. ([\#8881](https://github.com/matrix-org/synapse/issues/8881)) - Skip the SAML tests if the requirements (`pysaml2` and `xmlsec1`) aren't available. ([\#8905](https://github.com/matrix-org/synapse/issues/8905)) - Fix multiarch docker image builds. ([\#8906](https://github.com/matrix-org/synapse/issues/8906)) - Don't publish `latest` docker image until all archs are built. ([\#8909](https://github.com/matrix-org/synapse/issues/8909)) - Various clean-ups to the structured logging and logging context code. ([\#8916](https://github.com/matrix-org/synapse/issues/8916), [\#8935](https://github.com/matrix-org/synapse/issues/8935)) - Automatically drop stale forward-extremities under some specific conditions. ([\#8929](https://github.com/matrix-org/synapse/issues/8929)) - Refactor test utilities for injecting HTTP requests. ([\#8946](https://github.com/matrix-org/synapse/issues/8946)) - Add a maximum size of 50 kilobytes to .well-known lookups. ([\#8950](https://github.com/matrix-org/synapse/issues/8950)) - Fix bug in `generate_log_config` script which made it write empty files. ([\#8952](https://github.com/matrix-org/synapse/issues/8952)) - Clean up tox.ini file; disable coverage checking for non-test runs. ([\#8963](https://github.com/matrix-org/synapse/issues/8963)) - Add type hints to the admin and room list handlers. ([\#8973](https://github.com/matrix-org/synapse/issues/8973)) - Add type hints to the receipts and user directory handlers. ([\#8976](https://github.com/matrix-org/synapse/issues/8976)) - Drop the unused `local_invites` table. ([\#8979](https://github.com/matrix-org/synapse/issues/8979)) - Add type hints to the base storage code. ([\#8980](https://github.com/matrix-org/synapse/issues/8980)) - Support using PyJWT v2.0.0 in the test suite. ([\#8986](https://github.com/matrix-org/synapse/issues/8986)) - Fix `tests.federation.transport.RoomDirectoryFederationTests` and ensure it runs in CI. ([\#8998](https://github.com/matrix-org/synapse/issues/8998)) - Add type hints to the crypto module. ([\#8999](https://github.com/matrix-org/synapse/issues/8999))
| * 1.25.0rc1Patrick Cloke2021-01-0678-78/+0
| |
| * Fix-up assertions about last stream token in push (#9020)Patrick Cloke2021-01-051-0/+1
| | | | | | The last stream token is always known and we do not need to handle none.
* | Handle a display name / avatar URL not included in a federation request. (#9023)Patrick Cloke2021-01-061-0/+1
| | | | | | | | These may be omitted if not set, but Synapse assumed they would be in the response.
* | Ignore date-rotated logs (#9018)Eric Eastwood2021-01-051-0/+1
| | | | | | | | | | | | Ex. - homeserver.log.2020-12-29 - homeserver.log.2020-12-31
* | Add type hints to the logging context code. (#8939)Patrick Cloke2021-01-051-0/+1
| |
* | Implement MSC2176: Updated redaction rules (#8984)Patrick Cloke2021-01-051-0/+1
| | | | | | | | An experimental room version ("org.matrix.msc2176") contains the new redaction rules for testing.
* | Add initial support for a "pick your IdP" page (#9017)Richard van der Hoff2021-01-051-0/+1
| | | | | | | | | | During login, if there are multiple IdPs enabled, offer the user a choice of IdPs.
* | Combine the SSO Redirect Servlets (#9015)Richard van der Hoff2021-01-041-0/+1
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | * Implement CasHandler.handle_redirect_request ... to make it match OidcHandler and SamlHandler * Clean up interface for OidcHandler.handle_redirect_request Make it accept `client_redirect_url=None`. * Clean up interface for `SamlHandler.handle_redirect_request` ... bring it into line with CAS and OIDC by making it take a Request parameter, move the magic for `client_redirect_url` for UIA into the handler, and fix the return type to be a `str` rather than a `bytes`. * Define a common protocol for SSO auth provider impls * Give SsoIdentityProvider an ID and register them * Combine the SSO Redirect servlets Now that the SsoHandler knows about the identity providers, we can combine the various *RedirectServlets into a single implementation which delegates to the right IdP. * changelog
* Add type hints to the receipts and user directory handlers. (#8976)Patrick Cloke2021-01-041-0/+1
|
* Add type hints to the crypto module. (#8999)Patrick Cloke2021-01-041-0/+1
|
* Add link to Synapse dev room to the relevant README section (#9002)Eric Eastwood2021-01-041-0/+1
|
* Use the SSO handler helpers for CAS registration/login. (#8856)Patrick Cloke2021-01-031-0/+1
|
* Fix RoomDirectoryFederationTests and make them actually run (#8998)Andrew Morgan2020-12-301-0/+1
| | | | | | | | | | The `RoomDirectoryFederationTests` tests were not being run unless explicitly called as an `__init__.py` file was not present in `tests/federation/transport/`. Thus the folder was not a python module, and `trial` did not look inside for any test cases to run. This was found while working on #6739. This PR adds a `__init__.py` and also fixes the test in a couple ways: - Switch to subclassing `unittest.FederatingHomeserverTestCase` instead, which sets up federation endpoints for us. - Supply a `federation_auth_origin` to `make_request` in order to more act like the request is coming from another server, instead of just an unauthenicated client requesting a federation endpoint. I found that the second point makes no difference to the test passing, but felt like the right thing to do if we're testing over federation.
* Check if group IDs are valid before using them. (#8977)Patrick Cloke2020-12-301-0/+1
|
* Add additional type hints to the storage module. (#8980)Patrick Cloke2020-12-301-0/+1
|
* Doc/move database setup instructions in install md (#8987)Shashank Sabniveesu2020-12-301-0/+1
|
* Add type hints to admin and room list handlers. (#8973)Patrick Cloke2020-12-291-0/+1
|
* Validate input parameters for the sendToDevice API. (#8975)Patrick Cloke2020-12-291-0/+1
| | | | This makes the "messages" key in the content required. This is currently optional in the spec, but that seems to be an error.
* Update the value of group_creation_prefix in sample config. (#8992)Jerin J Titus2020-12-291-0/+1
| | | Removes the trailing slash with causes issues with matrix.to/Element.
* Allow redacting events on workers (#8994)Patrick Cloke2020-12-291-0/+1
| | | Adds the redacts endpoint to workers that have the client listener.
* Drop the unused local_invites table. (#8979)Patrick Cloke2020-12-291-0/+1
| | | This table has been unused since Synapse v1.17.0.
* Support PyJWT v2.0.0. (#8986)Patrick Cloke2020-12-221-0/+1
| | | | Tests were broken due to an API changing. The code used in Synapse proper should be compatible with both versions already.
* Refactor the CAS handler in prep for using the abstracted SSO code. (#8958)Patrick Cloke2020-12-181-0/+1
| | | | | | This makes the CAS handler look more like the SAML/OIDC handlers: * Render errors to users instead of throwing JSON errors. * Internal reorganization.
* Send the location of the web client to the IS when inviting via 3PIDs. (#8930)Patrick Cloke2020-12-181-0/+1
| | | | Adds a new setting `email.invite_client_location` which, if defined, is passed to the identity server during invites.
* Allow server admin to get admin bit in rooms where local user is an admin ↵Erik Johnston2020-12-181-0/+1
| | | | | | | (#8756) This adds an admin API that allows a server admin to get power in a room if a local user has power in a room. Will also invite the user if they're not in the room and its a private room. Can specify another user (rather than the admin user) to be granted power. Co-authored-by: Matthew Hodgson <matthew@matrix.org>
* Fix mainline ordering in state res v2 (#8971)Erik Johnston2020-12-181-0/+1
| | | | | | This had two effects 1) it'd give the wrong answer and b) would iterate *all* power levels in the auth chain of each event. The latter of which can be *very* expensive for certain types of IRC bridge rooms that have large numbers of power level changes.
* Implement a username picker for synapse (#8942)Richard van der Hoff2020-12-181-0/+1
| | | | | | | | | | | | | | The final part (for now) of my work to implement a username picker in synapse itself. The idea is that we allow `UsernameMappingProvider`s to return `localpart=None`, in which case, rather than redirecting the browser back to the client, we redirect to a username-picker resource, which allows the user to enter a username. We *then* complete the SSO flow (including doing the client permission checks). The static resources for the username picker itself (in https://github.com/matrix-org/synapse/tree/rav/username_picker/synapse/res/username_picker) are essentially lifted wholesale from https://github.com/matrix-org/matrix-synapse-saml-mozilla/tree/master/matrix_synapse_saml_mozilla/res. As the comment says, we might want to think about making them customisable, but that can be a follow-up. Fixes #8876.
* Allow re-using a UI auth validation for a period of time (#8970)Patrick Cloke2020-12-181-0/+1
|
* Ensure that a URL exists in the content during push. (#8965)Patrick Cloke2020-12-181-0/+1
| | | | This fixes an KeyError exception, after this PR the content is just considered unknown.
* Merge remote-tracking branch 'origin/erikj/as_mau_block' into developErik Johnston2020-12-181-0/+1
|\
| * NewsfileErik Johnston2020-12-171-0/+1
| |
| * 1.24.0 v1.24.0Erik Johnston2020-12-091-1/+0
| |
| * Fix installing pysaml2 on Python 3.5. (#8898)Patrick Cloke2020-12-081-0/+1
| | | | | | This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.
| * 1.24.0rc2Patrick Cloke2020-12-042-2/+0
| |
| * Fix a regression that mapping providers should be able to redirect users. ↵Patrick Cloke2020-12-041-0/+1
| | | | | | | | | | (#8878) This was broken in #8801.
| * Remove version pin prometheus_client dependency (#8875)Jordan Bancino2020-12-041-0/+1
| | | | | | | | | | | | | | This removes the version pin of the `prometheus_client` dependency, in direct response to #8831. If merged, this will close #8831 As far as I can tell, no other changes are needed, but as I'm no synapse expert, I'm relying heavily on CI and maintainer reviews for this. My very primitive test of synapse with prometheus_client v0.9.0 on my home server didn't bring up any issues, so we'll see what happens. Signed-off-by: Jordan Bancino
* | Try and drop stale extremities. (#8929)Erik Johnston2020-12-181-0/+1
| | | | | | | | If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.
* | Clean up tox.ini (#8963)Richard van der Hoff2020-12-171-0/+1
| | | | | | ... and disable coverage tracking for mypy and friends.
* | Fix `UsersListTestCase` (#8964)Richard van der Hoff2020-12-171-0/+1
| |
* | Use the simple dictionary in full text search for the user directory (#8959)Brendan Abolivier2020-12-171-0/+1
| | | | | | | | | | * Use the simple dictionary in fts for the user directory * Clarify naming
* | Fix a bug that deactivated users appear in the directory (#8933)Dirk Klimpel2020-12-171-0/+1
| | | | | | | | | | | | | | | | | | | | Fixes a bug that deactivated users appear in the directory when their profile information was updated. To change profile information of deactivated users is neccesary for example you will remove displayname or avatar. But they should not appear in directory. They are deactivated. Co-authored-by: Erik Johnston <erikj@jki.re>
* | Make search statement in List Room and User Admin API case-insensitive (#8931)Dirk Klimpel2020-12-171-0/+1
| |
* | Add a maximum size for well-known lookups. (#8950)Patrick Cloke2020-12-161-0/+1
| |
* | Push login completion down into SsoHandler (#8941)Richard van der Hoff2020-12-161-0/+1
| | | | | | This is another part of my work towards fixing #8876. It moves some of the logic currently in the SAML and OIDC handlers - in particular the call to `AuthHandler.complete_sso_login` down into the `SsoHandler`.
* | Fix the sample config location for the ip_range_whitelist setting. (#8954)Patrick Cloke2020-12-161-0/+1
| | | | | | | | Move it from the federation section to the server section to match ip_range_blacklist.
* | Convert internal pusher dicts to attrs classes. (#8940)Patrick Cloke2020-12-161-0/+1
| | | | | | This improves type hinting and should use less memory.
* | Merge pull request #8951 from matrix-org/rav/username_picker_2Richard van der Hoff2020-12-161-0/+1
|\ \ | | | | | | More preparatory refactoring of the OidcHandler tests
| * | changelogRichard van der Hoff2020-12-151-0/+1
| | |
* | | Merge pull request #8946 from matrix-org/rav/refactor_send_requestRichard van der Hoff2020-12-161-0/+1
|\ \ \ | | | | | | | | Remove `Request` return value from `make_request`
| * | | changelogRichard van der Hoff2020-12-151-0/+1
| |/ /
* | | Fix generate_log_config script (#8952)Richard van der Hoff2020-12-161-0/+1
| | | | | | | | | It used to write an empty file if you gave it a -o arg.
* | | Do not assume that the contents dictionary includes history_visibility. (#8945)Patrick Cloke2020-12-161-0/+1
|/ /
* | Preparatory refactoring of the SamlHandlerTestCase (#8938)Richard van der Hoff2020-12-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | * move simple_async_mock to test_utils ... so that it can be re-used * Remove references to `SamlHandler._map_saml_response_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead, factor out a higher-level method which takes a SAML object, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`. * changelog
* | Fix handling of stream tokens for push. (#8943)Patrick Cloke2020-12-151-0/+1
| | | | | | | | Removes faulty assertions and fixes the logic to ensure the max stream token is always set.
* | Fix startup failure with localdb_enabled: False (#8937)Richard van der Hoff2020-12-141-0/+1
| |
* | Various clean-ups to the logging context code (#8935)Patrick Cloke2020-12-142-1/+2
| |
* | Preparatory refactoring of the OidcHandlerTestCase (#8911)Richard van der Hoff2020-12-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove references to handler._auth_handler (and replace them with hs.get_auth_handler) * Factor out a utility function for building Requests * Remove mocks of `OidcHandler._map_userinfo_to_user` This method is going away, so mocking it out is no longer a valid approach. Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or simply allow the regular implementation to proceed and update the expectations accordingly. * Remove references to `OidcHandler._map_userinfo_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead we build mock "callback" requests which we pass into `handle_oidc_callback`, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.
* | Allow spam-checker modules to be provide async methods. (#8890)David Teller2020-12-111-0/+1
| | | | | | | | Spam checker modules can now provide async methods. This is implemented in a backwards-compatible manner.
* | Add type hints to the push module. (#8901)Patrick Cloke2020-12-111-0/+1
| |
* | Honour AS ratelimit settings for /login requests (#8920)Erik Johnston2020-12-111-0/+1
| | | | | | | | Fixes #8846.
* | Improve tests for structured logging. (#8916)Patrick Cloke2020-12-111-0/+1
| |
* | Add number of local devices to Room Details Admin API (#8886)Dirk Klimpel2020-12-111-0/+1
| |
* | Don't ratelimit autojoining of rooms (#8921)Erik Johnston2020-12-111-0/+1
| | | | | | Fixes #8866
* | Don't publish `latest` docker image until all archs are built (#8909)Richard van der Hoff2020-12-101-0/+1
| |
* | Fix deadlock on SIGHUP (#8918)Erik Johnston2020-12-101-0/+1
| | | | | | Fixes #8892
* | Refactor `SsoHandler.get_mxid_from_sso` (#8900)Richard van der Hoff2020-12-101-0/+1
| | | | | | | | | | | | | | * Factor out _call_attribute_mapper and _register_mapped_user This is mostly an attempt to simplify `get_mxid_from_sso`. * Move mapping_lock down into SsoHandler.
* | Fix buglet in DirectRenderJsonResource (#8897)Richard van der Hoff2020-12-101-0/+1
| | | | | | | | this was using `canonical_json` without setting it, so when you used it as a standalone class, you would get exceptions.
* | Deprecate Shutdown Room and Purge Room Admin API (#8829)Dirk Klimpel2020-12-101-0/+1
| | | | | | | | | | Deprecate both APIs in favour of the Delete Room API. Related: #8663 and #8810
* | Default to blacklisting reserved IP ranges and add a whitelist. (#8870)Patrick Cloke2020-12-092-1/+2
| | | | | | | | This defaults `ip_range_blacklist` to reserved IP ranges and also adds an `ip_range_whitelist` setting to override it.
* | Skip the SAML tests if xmlsec1 isn't available. (#8905)Patrick Cloke2020-12-091-0/+1
| |
* | Combine related media admin API docs (#8839)Dirk Klimpel2020-12-091-0/+1
| | | | | | | | | | | | Related: #8810 Also a few small improvements. Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Merge remote-tracking branch 'origin/master' into developRichard van der Hoff2020-12-091-0/+1
|\ \
| * | Pin the docker version for multiarch buildsRichard van der Hoff2020-12-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that letting CircleCI use its default docker version (17.09.0-ce, apparently) did not interact well with multiarch builds: in particular, we saw weird effects where running an amd64 build at the same time as an arm64 build caused the arm64 builds to fail with: Error while loading /usr/sbin/dpkg-deb: No such file or directory
| * | 1.23.0Erik Johnston2020-11-181-1/+0
| | |
| * | Cap the version of prometheus_client to <v0.9.0 in the dockerfile (#8767)Andrew Morgan2020-11-171-0/+1
| | | | | | | | | Short-term fix for https://github.com/matrix-org/synapse/issues/8766.
* | | Add X-Robots-Tag header to stop crawlers from indexing media (#8887)Aaron Raimist2020-12-081-0/+1
| | | | | | | | | | | | | | | | | | | | | Fixes / related to: https://github.com/matrix-org/synapse/issues/6533 This should do essentially the same thing as a robots.txt file telling robots to not index the media repo. https://developers.google.com/search/reference/robots_meta_tag Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | | Better formatting for config errors from modules (#8874)Richard van der Hoff2020-12-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea is that the parse_config method of extension modules can raise either a ConfigError or a JsonValidationError, and it will be magically turned into a legible error message. There's a few components to it: * Separating the "path" and the "message" parts of a ConfigError, so that we can fiddle with the path bit to turn it into an absolute path. * Generally improving the way ConfigErrors get printed. * Passing in the config path to load_module so that it can wrap any exceptions that get caught appropriately.
* | | Simplify the flow for SSO UIA (#8881)Richard van der Hoff2020-12-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | * SsoHandler: remove inheritance from BaseHandler * Simplify the flow for SSO UIA We don't need to do all the magic for mapping users when we are doing UIA, so let's factor that out.
* | | Clarify config template comments (#8891)Richard van der Hoff2020-12-081-0/+1
| | |
* | | Call set_avatar_url with target_user, not user_id (#8872)Will Hunt2020-12-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Call set_avatar_url with target_user, not user_id Fixes https://github.com/matrix-org/synapse/issues/8871 * Create 8872.bugfix * Update synapse/rest/admin/users.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Testing * Update changelog.d/8872.bugfix Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | | Do not raise a 500 exception when previewing empty media. (#8883)Patrick Cloke2020-12-071-0/+1
| | |
* | | Add type hints for HTTP and email pushers. (#8880)Patrick Cloke2020-12-071-0/+1
| | |
* | | Add type hints to the push mailer module. (#8882)Patrick Cloke2020-12-071-0/+1
| | |
* | | Add authentication to replication endpoints. (#8853)Patrick Cloke2020-12-041-0/+1
| | | | | | | | | | | | Authentication is done by checking a shared secret provided in the Synapse configuration file.
* | | Pass room_id to get_auth_chain_difference (#8879)Erik Johnston2020-12-041-0/+1
| | | | | | | | | | | | | | | This is so that we can choose which algorithm to use based on the room ID.
* | | Add additional validation to pusher URLs. (#8865)Patrick Cloke2020-12-041-0/+1
| | | | | | | | | | | | Pusher URLs now must end in `/_matrix/push/v1/notify` per the specification.
* | | Do not 500 if the content-length is not provided when uploading media. (#8862)Patrick Cloke2020-12-041-0/+1
| | | | | | | | | Instead return the proper 400 error.
* | | Fix a buglet in the SAML username mapping provider doc (#8873)Richard van der Hoff2020-12-041-0/+1
| | | | | | | | | the constructor is called with a `module_api`.
* | | Fix errorcode for disabled registration (#8867)Richard van der Hoff2020-12-031-0/+1
| | | | | | | | | | | | The spec says we should return `M_FORBIDDEN` when someone tries to register and registration is disabled.
* | | Merge remote-tracking branch 'origin/develop' into rav/remove_unused_mocksRichard van der Hoff2020-12-022-0/+2
|\ \ \
| * \ \ Merge pull request #8858 from matrix-org/rav/sso_uiaRichard van der Hoff2020-12-021-0/+1
| |\ \ \ | | | | | | | | | | UIA: offer only available auth flows
| | * | | newsfileRichard van der Hoff2020-12-021-0/+1
| | | | |
| * | | | remove unused FakeResponse (#8864)Richard van der Hoff2020-12-021-0/+1
| | | | |
* | | | | changelogRichard van der Hoff2020-12-021-0/+1
|/ / / /
* | | | Apply an IP range blacklist to push and key revocation requests. (#8821)Patrick Cloke2020-12-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).
* | | | Correctly handle unpersisted events when calculating auth chain difference. ↵Erik Johnston2020-12-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8827) We do state res with unpersisted events when calculating the new current state of the room, so that should be the only thing impacted. I don't think this is tooooo big of a deal as: 1. the next time a state event happens in the room the current state should correct itself; 2. in the common case all the unpersisted events' auth events will be pulled in by other state, so will still return the correct result (or one which is sufficiently close to not affect the result); and 3. we mostly use the state at an event to do important operations, which isn't affected by this.
* | | | Add missing prometheus rules for persisted events (#8802)Johanna Dorothea Reichmann2020-12-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The official dashboard uses data from these rules, but they were never added to the synapse-v2.rules. They are mentioned in this issue: https://github.com/matrix-org/synapse/issues/7917#issuecomment-661330409, but never got added to the rules. Adding them results in all graphs in the "Event persist rate" section to function as intended. Signed-off-by: Johanna Dorothea Reichmann <transcaffeine@finallycoffee.eu>
* | | | Add additional validation for the admin register endpoint. (#8837)David Florness2020-12-021-0/+1
| |_|/ |/| | | | | Raise a proper 400 error if the `mac` field is missing.
* | | 1.24.0rc1Patrick Cloke2020-12-0253-53/+0
|/ /
* | Fix a regression when grandfathering SAML users. (#8855)Patrick Cloke2020-12-021-0/+1
| | | | | | | | | | | | This was broken in #8801 when abstracting code shared with OIDC. After this change both SAML and OIDC have a concept of grandfathering users, but with different implementations.
* | Add basic SAML tests for mapping users. (#8800)Patrick Cloke2020-12-021-0/+1
| |
* | Create a `PasswordProvider` wrapper object (#8849)Richard van der Hoff2020-12-021-0/+1
| | | | | | | | The idea here is to abstract out all the conditional code which tests which methods a given password provider has, to provide a consistent interface.
* | Allow specifying room version in 'RestHelper.create_room_as' and add typing ↵Andrew Morgan2020-12-021-0/+1
| | | | | | | | | | (#8854) This PR adds a `room_version` argument to the `RestHelper`'s `create_room_as` function for tests. I plan to use this for testing knocking, which currently uses an unstable room version.
* | Support "identifier" dicts in UIA (#8848)Richard van der Hoff2020-12-011-0/+1
| | | | | | | | | | | | | | | | | | | | The spec requires synapse to support `identifier` dicts for `m.login.password` user-interactive auth, which it did not (instead, it required an undocumented `user` parameter.) To fix this properly, we need to pull the code that interprets `identifier` into `AuthHandler.validate_login` so that it can be called from the UIA code. Fixes #5665.
* | Add missing `ordering` to background updates (#8850)Richard van der Hoff2020-12-011-0/+1
| | | | | | | | | | | | | | It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.
* | Allow Date header through CORS (#8804)Nicolas Chamo2020-12-011-0/+1
| |
* | Don't offer password login when it is disabled (#8835)Richard van der Hoff2020-12-011-0/+1
| | | | | | Fix a minor bug where we would offer "m.login.password" login if a custom auth provider supported it, even if password login was disabled.
* | Add some tests for `password_auth_providers` (#8819)Richard van der Hoff2020-12-011-0/+1
| | | | | | | | These things seemed to be completely untested, so I added a load of tests for them.
* | Fix broken testcase (#8851)Richard van der Hoff2020-12-011-0/+1
| | | | | | | | This test was broken by #8565. It doesn't need to set set `self.clock` here anyway - that is done by `setUp`.
* | Simplify appservice login code (#8847)Richard van der Hoff2020-11-301-0/+1
| | | | | | we don't need to support legacy login dictionaries here.
* | Allow per-room profile to be used for server notice user (#8799)Mathieu Velten2020-11-301-0/+1
| | | | | | | | This applies even if the feature is disabled at the server level with `allow_per_room_profiles`. The server notice not being a real user it doesn't have an user profile.
* | Drop (almost) unused index on event_json (#8845)Richard van der Hoff2020-11-301-0/+1
| |
* | Add a config option to change whether unread push notification counts are ↵Andrew Morgan2020-11-301-0/+1
| | | | | | | | | | | | | | | | per-message or per-room (#8820) This PR adds a new config option to the `push` section of the homeserver config, `group_unread_count_by_room`. By default Synapse will group push notifications by room (so if you have 1000 unread messages, if they lie in 55 rooms, you'll see an unread count on your phone of 55). However, it is also useful to be able to send out the true count of unread messages if desired. If `group_unread_count_by_room` is set to `false`, then with the above example, one would see an unread count of 1000 (email anyone?).
* | Simplify the way the `HomeServer` object caches its internal attributes. ↵Jonathan de Jong2020-11-301-0/+1
| | | | | | | | | | (#8565) Changes `@cache_in_self` to use underscore-prefixed attributes.
* | Add `force_purge` option to delete-room admin api. (#8843)Richard van der Hoff2020-11-301-0/+1
| |
* | Remove special case of pretty printing JSON responses for curl (#8833)Tulir Asokan2020-11-271-0/+1
| | | | | | | | | | * Remove special case of pretty printing JSON responses for curl Signed-off-by: Tulir Asokan <tulir@maunium.net>
* | Add typing to membership Replication class methods (#8809)Andrew Morgan2020-11-271-0/+1
| | | | | | | | | | This PR grew out of #6739, and adds typing to some method arguments You'll notice that there are a lot of `# type: ignores` in here. This is due to the base methods not matching the overloads here. This is necessary to stop mypy complaining, but a better solution is #8828.
* | Update example prometheus console (#8824)Dirk Klimpel2020-11-261-0/+1
| | | | | | | | Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Defer SIGHUP handlers to reactor. (#8817)Erik Johnston2020-11-261-0/+1
| | | | | | | | | | | | | | | | | | We can get a SIGHUP at any point, including times where we are not in a sane state. By deferring calling the handlers until the next reactor tick we ensure that we don't get unexpected conflicts, e.g. trying to flush logs from the signal handler while the code was in the process of writing a log entry. Fixes #8769.
* | Strip trailing / from server_url in register_new_matrix_user (#8823)Dmitry Borodaenko2020-11-261-0/+1
| | | | | | | | | | | | | | | | | | When server URL provided to register_new_matrix_user includes path component (e.g. "http://localhost:8008/"), the command fails with "ERROR! Received 400 Bad Request". Stripping trailing slash from the server_url command argument makes sure combined endpoint URL remains valid. Signed-off-by: Dmitry Borodaenko angdraug@debian.org
* | Improve documentation how to configure prometheus for workers (#8822)Dirk Klimpel2020-11-261-0/+1
| |
* | Remove deprecated `/_matrix/client/*/admin` endpoints (#8785)Dirk Klimpel2020-11-251-0/+1
| | | | | | These are now only available via `/_synapse/admin/v1`.
* | Fix the formatting of push config section (#8818)Andrew Morgan2020-11-251-0/+1
| | | | | | This PR updates the push config's formatting to better align with our [code style guidelines](https://github.com/matrix-org/synapse/blob/develop/docs/code_style.md#configuration-file-format).
* | Speed up remote invite rejection database call (#8815)Andrew Morgan2020-11-251-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: https://github.com/matrix-org/synapse/blob/f737368a26bb9eea401fcc3a5bdd7e0b59e91f09/synapse/handlers/room_member.py#L518-L540 It calls `get_invite_for_local_user_in_room`, which will actually query *all* rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't *joined* the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead
* | Add additional type hints to HTTP client. (#8812)Patrick Cloke2020-11-252-1/+2
| | | | | | | | This also removes some duplicated code between the simple HTTP client and matrix federation client.
* | Support trying multiple localparts for OpenID Connect. (#8801)Patrick Cloke2020-11-251-0/+1
| | | | | | | | Abstracts the SAML and OpenID Connect code which attempts to regenerate the localpart of a matrix ID if it is already in use.
* | Add type hints to matrix federation client / agent. (#8806)Patrick Cloke2020-11-251-0/+1
| |
* | Clarify documentation of the admin list media API (#8795)Dirk Klimpel2020-11-241-0/+1
| | | | | | Clarify that the list media API only shows media from unencrypted events.
* | Add a script to sign arbitrary json objects. (#8772)Richard van der Hoff2020-11-241-0/+1
| |
* | Update turn-howto (#8779)Richard van der Hoff2020-11-241-0/+1
| | | | | | Some hopefully-useful notes on setting up a turnserver.
* | Properly report user-agent/IP during registration of SSO users. (#8784)Patrick Cloke2020-11-231-0/+1
| | | | | | | | | | This also expands type-hints to the SSO and registration code. Refactors the CAS code to more closely match OIDC/SAML.
* | Fix synctl and duplicate worker spawning (#8798)Waylon Cude2020-11-231-0/+1
| | | | | | | | | | | | | | | | | | Synctl did not check if a worker thread was already running when using `synctl start` and would naively start a fresh copy. This would sometimes lead to cases where many duplicate copies of a single worker would run. This fix adds a pid check when starting worker threads and synctl will now refuse to start individual workers if they're already running.
* | Improve logging of the mapping from SSO IDs to Matrix IDs. (#8773)Andrew Morgan2020-11-231-0/+1
| |
* | INSTALL: Fix setting content-type on well-known (#8793)Daniele Sluijters2020-11-231-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using `add_header` nginx will literally add a header. If a `content-type` header is already configured (for example through a server wide default), this means we end up with 2 content-type headers, like so: ``` content-type: text/html content-type: application/json access-control-allow-origin: * ``` That doesn't make sense. Instead, we want the content type of that block to only be `application/json` which we can achieve using `default_type` instead. Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>
* | Improve error checking for OIDC/SAML mapping providers (#8774)Patrick Cloke2020-11-191-0/+1
| | | | | | | | | | | | Checks that the localpart returned by mapping providers for SAML and OIDC are valid before registering new users. Extends the OIDC tests for existing users and invalid data.
* | SAML: Allow specifying the IdP entityid to use. (#8630)Ben Banfield-Zanin2020-11-191-0/+1
| | | | | | | | If the SAML metadata includes multiple IdPs it is necessary to specify which IdP to redirect users to for authentication.
* | Consistently use room_id from federation request body (#8776)Richard van der Hoff2020-11-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | * Consistently use room_id from federation request body Some federation APIs have a redundant `room_id` path param (see https://github.com/matrix-org/matrix-doc/issues/2330). We should make sure we consistently use either the path param or the body param, and the body param is easier. * Kill off some references to "context" Once upon a time, "rooms" were known as "contexts". I think this kills of the last references to "contexts".
* | Improve appservice handler to send only the most recent read receipts when ↵Will Hunt2020-11-181-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no stream_id is stored. (#8744) * Make this line debug (it's noisy) * Don't include from_key for presence if we are at 0 * Limit read receipts for all rooms to 100 * changelog.d/8744.bugfix * Allow from_key to be None * Update 8744.bugfix * The from_key is superflous * Update comment
* | Fix tests on develop (#8777)Erik Johnston2020-11-181-0/+1
| | | | | | This was broken due to #8617 and #8761.
* | SAML: Document allowing a clock/time difference from IdP (#8731)Marcus Schopen2020-11-181-0/+1
| | | | | | | | Updates the sample configuration with the pysaml2 configuration for accepting clock skew/drift between the homeserver and IdP.
* | Merge pull request #8761 from matrix-org/rav/test_request_renderingRichard van der Hoff2020-11-171-0/+1
|\ \ | | | | | | Make `make_request` actually render the request
| * | changelogRichard van der Hoff2020-11-161-0/+1
| | |
* | | Abstract shared SSO code. (#8765)Patrick Cloke2020-11-171-0/+1
| | | | | | | | | De-duplicates code between the SAML and OIDC implementations.
* | | a comma too much (#8771)chagai952020-11-171-0/+1
| | | | | | | | | Signed-off-by: Chagai Friedlander chagai95@gmail.com
* | | Use TYPE_CHECKING instead of magic MYPY variable. (#8770)Patrick Cloke2020-11-171-0/+1
| | |
* | | Add admin API for logging in as a user (#8617)Erik Johnston2020-11-171-0/+1
|/ /
* | Merge pull request #8757 from matrix-org/rav/pass_site_to_make_requestRichard van der Hoff2020-11-161-0/+1
|\ \ | | | | | | Pass a Site into `make_request`
| * \ Merge branch 'develop' into rav/pass_site_to_make_requestRichard van der Hoff2020-11-1673-69/+4
| |\ \
| * | | changelogRichard van der Hoff2020-11-151-0/+1
| | | |
* | | | Move `wait_until_result` into `FakeChannel` (#8758)Richard van der Hoff2020-11-161-0/+1
| | | | | | | | | | | | | | | | FakeChannel has everything we need, and this more accurately models the real flow.
* | | | Generalise _locally_reject_invite (#8751)Andrew Morgan2020-11-161-0/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | `_locally_reject_invite` generates an out-of-band membership event which can be passed to clients, but not other homeservers. This is used when we fail to reject an invite over federation. If this happens, we instead just generate a leave event locally and send it down /sync, allowing clients to reject invites even if we can't reach the remote homeserver. A similar flow needs to be put in place for rescinding knocks. If we're unable to contact any remote server from the room we've tried to knock on, we'd still like to generate and store the leave event locally. Hence the need to reuse, and thus generalise, this method. Separated from #6739.
* | | Rename `create_test_json_resource` to `create_test_resource` (#8759)Richard van der Hoff2020-11-161-0/+1
| | | | | | | | | | | | | | | The root resource isn't necessarily a JsonResource, so rename this method accordingly, and update a couple of test classes to use the method rather than directly manipulating self.resource.
* | | Add a `custom_headers` param to `make_request` (#8760)Richard van der Hoff2020-11-161-0/+1
| | | | | | | | | | | | Some tests want to set some custom HTTP request headers, so provide a way to do that before calling requestReceived().
* | | Clarify the usecase for an msisdn delegate (#8734)Adrian Wannenmacher2020-11-141-0/+1
| | | | | | | | | Signed-off-by: Adrian Wannenmacher <tfld@tfld.dev>
* | | Generalise _maybe_store_room_on_invite (#8754)Andrew Morgan2020-11-131-0/+1
| |/ |/| | | | | | | | | | | | | | | There's a handy function called maybe_store_room_on_invite which allows us to create an entry in the rooms table for a room and its version for which we aren't joined to yet, but we can reference when ingesting events about. This is currently used for invites where we receive some stripped state about the room and pass it down via /sync to the client, without us being in the room yet. There is a similar requirement for knocking, where we will eventually do the same thing, and need an entry in the rooms table as well. Thus, reusing this function works, however its name needs to be generalised a bit. Separated out from #6739.
* | 1.23.0rc1Erik Johnston2020-11-1369-69/+0
|/
* Migrate documentation `docs/admin_api/event_reports` to markdown (#8742)Dirk Klimpel2020-11-131-0/+1
| | | Related to #8714. `event_reports.rst` was introduced in Synapse 1.21.0.
* SAML: add <mdui:UIInfo> element examples (#8718)Marcus Schopen2020-11-131-0/+1
| | | add some mdui:UIInfo element examples for saml2_config in homeserver.yaml
* Updating README.rst (#8746)chagai952020-11-131-0/+1
| | | Minor corrections and advice... Should help beginners.
* Add metrics for tracking 3PID /requestToken requests. (#8712)Erik Johnston2020-11-131-0/+1
| | | | | | The main use case is to see how many requests are being made, and how many are second/third/etc attempts. If there are large number of retries then that likely indicates a delivery problem.
* Fix port script so that it can be run again after failure. (#8755)Erik Johnston2020-11-131-0/+1
| | | | | | | If the script fails (or is CTRL-C'ed) between porting some of the events table and copying of the sequences then the port script will immediately die if run again due to the postgres DB having inconsistencies between sequences and tables. The fix is to move the porting of sequences to before porting the tables, so that there is never a period where the Postgres DB is inconsistent. To do that we need to change how we port the sequences so that it calculates the values from the SQLite DB rather than the Postgres DB. Fixes #8619
* Cache event ID to auth event IDs lookups (#8752)Erik Johnston2020-11-131-0/+1
| | | | | This should hopefully speed up `get_auth_chain_difference` a bit in the case of repeated state res on the same rooms. `get_auth_chain_difference` does a breadth first walk of the auth graphs by repeatedly looking up events' auth events. Different state resolutions on the same room will end up doing a lot of the same event to auth events lookups, so by caching them we should speed things up in cases of repeated state resolutions on the same room.
* Enable reconnection in DB pool (#8726)Erik Johnston2020-11-121-0/+1
| | | | | | `adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574
* Fix port script fails when DB has no backfilled events. (#8729)Erik Johnston2020-11-111-0/+1
| | | Fixes #8618
* Fix port script to handle foreign key constraints (#8730)Erik Johnston2020-11-111-0/+1
|
* Check support room has only two users before sending a notice (#8728)Will Hunt2020-11-111-0/+1
| | | | | | | | | | | * Check support room has only two users * Create 8728.bugfix * Update synapse/server_notices/server_notices_manager.py Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
* Better error message when a remote resource uses invalid Content-Type (#8719)Andrew Morgan2020-11-111-0/+1
|
* Catch exceptions in password_providers (#8636)Nicolai Søborg2020-11-111-0/+1
| | | Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>
* Notes on SSO logins and media_repository worker (#8701)Marcus Schopen2020-11-061-0/+1
| | | | | | | If SSO login is used (e.g. SAML) in a multi worker setup, it should be mentioned that currently all SAML logins must run on the same worker, see https://github.com/matrix-org/synapse/issues/7530 Also, if you are using different ports (for example 443 and 8448) in a reverse proxy for client and federation, the path `/_matrix/media` on the client and federation port must point to the listener of the `media_repository` worker, otherwise you'll get a 404 on the federation port for the path `/_matrix/media`, if a remote server is trying to get the media object on federation port, see https://github.com/matrix-org/synapse/issues/8695
* Add documentation about documentation to CONTRIBUTING.md (#8714)Andrew Morgan2020-11-061-0/+1
| | | | | | This PR adds some documentation that: * Describes who the audience for the `docs/`, `docs/dev/` and `docs/admin/` directories are, as well as Synapse's wiki page. * Stresses that we'd like all documentation to be down in markdown.
* Fix SIGHUP handler (#8697)Richard van der Hoff2020-11-061-0/+1
| | | | | | | Fixes: ``` builtins.TypeError: _reload_logging_config() takes 1 positional argument but 2 were given ```
* Add an admin API for users' media statistics (#8700)Dirk Klimpel2020-11-051-0/+1
| | | | | | | | Add `GET /_synapse/admin/v1/statistics/users/media` to get statisics about local media usage by users. Related to #6094 It is the first API for statistics. Goal is to avoid/reduce usage of sql queries like [Wiki analyzing Synapse](https://github.com/matrix-org/synapse/wiki/SQL-for-analyzing-Synapse-PostgreSQL-database-stats) Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Add `displayname` to Shared-Secret Registration for admins (#8722)Dirk Klimpel2020-11-051-0/+1
| | | Add `displayname` to Shared-Secret Registration for admins to `POST /_synapse/admin/v1/register`
* Consolidate purge table lists to prevent desyncronisation (#8713)Andrew Morgan2020-11-041-0/+1
| | | I idly noticed that these lists were out of sync with each other, causing us to miss a table in a test case (`local_invites`). Let's consolidate this list instead to prevent this from happening in the future.
* Remove the "draft" status of the Room Details Admin API (#8702)Dirk Klimpel2020-11-031-0/+1
| | | Fixes #8550
* Block clients from sending server ACLs that lock the local server out. (#8708)Erik Johnston2020-11-031-0/+1
| | | Fixes #4042
* Document how to set up multiple event persisters (#8706)Erik Johnston2020-11-031-0/+1
|
* Improve error messages of non-str displayname/avatar_url (#8705)Andrew Morgan2020-11-021-0/+1
| | | | | | | | This PR fixes two things: * Corrects the copy/paste error of telling the client their displayname is wrong when they are submitting an `avatar_url`. * Returns a `M_INVALID_PARAM` instead of `M_UNKNOWN` for non-str type parameters. Reported by @t3chguy.
* Add base pushrule to notify for jitsi conferences (#8286)David Baker2020-11-021-0/+1
| | | This could be customised to trigger a different kind of notification in the future, but for now it's a normal non-highlight one.
* Use Python 3.8 in Docker images by default (#8698)Dan Callahan2020-11-021-0/+1
| | | | | | | This bumps us closer to current Python without going all the way to 3.9. Fixes #8674 Signed-off-by: Dan Callahan <danc@element.io>
* Improve start time by adding index to e2e_cross_signing_keys (#8694)Erik Johnston2020-11-021-0/+1
| | | We do a `SELECT MAX(stream_id) FROM e2e_cross_signing_keys` on startup.
* Fix error handling around when completing an AS transaction (#8693)Brendan Abolivier2020-10-301-0/+1
|
* Merge branch 'master' into developErik Johnston2020-10-302-2/+0
|\
| * 1.22.1Erik Johnston2020-10-302-2/+0
| |
| * Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-301-0/+1
| | | | | | Fix serialisation errors when using third-party event rules.
| * Tie together matches_user_in_member_list and get_users_in_room caches (#8676)Will Hunt2020-10-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove **kwargs * Update 8676.bugfix
* | Improve the sample config for SSO (OIDC, SAML, and CAS). (#8635)Patrick Cloke2020-10-301-0/+1
| |
* | Implement and use an @lru_cache decorator (#8595)Richard van der Hoff2020-10-301-0/+1
| | | | | | We don't always need the full power of a DeferredCache.
* | Fail test cases if they fail to await all awaitables (#8690)Patrick Cloke2020-10-301-0/+1
| |
* | Fix race for concurrent downloads of remote media. (#8682)Erik Johnston2020-10-301-0/+1
| | | | | | Fixes #6755
* | Fix optional parameter in stripped state storage method (#8688)Andrew Morgan2020-10-301-0/+1
| | | | | | Missed in #8671.
* | Fix unit tests (#8689)Erik Johnston2020-10-291-0/+1
| | | | | | | | | | * Fix unit tests * Newsfile
* | Tie together matches_user_in_member_list and get_users_in_room caches (#8676)Will Hunt2020-10-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove **kwargs * Update 8676.bugfix
* | Gracefully handle a pending logging connection during shutdown. (#8685)Patrick Cloke2020-10-293-1/+2
| |
* | Add ability for access tokens to belong to one user but grant access to ↵Erik Johnston2020-10-291-0/+1
| | | | | | | | | | | | | | | | | | | | another user. (#8616) We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.
* | Fix cache call signature to accept `on_invalidate`. (#8684)Erik Johnston2020-10-291-0/+1
| | | | | | Cached functions accept an `on_invalidate` function, which we failed to add to the type signature. It's rarely used in the files that we have typed, which is why we haven't noticed it before.
* | Use `%r` rather than `%s` for stringifying events (#8679)Richard van der Hoff2020-10-291-0/+1
| | | | | | | | otherwise non-state events get written as `<FrozenEvent ... state_key='None'>` which is indistinguishable from state events with the actual state_key `None`.
* | Optimise createRoom with multiple invites (#8559)Richard van der Hoff2020-10-291-0/+1
| | | | | | | | | | By not dropping the membership lock between invites, we can stop joins from grabbing the lock when we're half-done and slowing the whole thing down.
* | Support generating structured logs in addition to standard logs. (#8607)Patrick Cloke2020-10-291-0/+1
| | | | | | | | | | | | | | This modifies the configuration of structured logging to be usable from the standard Python logging configuration. This also separates the formatting of logs from the transport allowing JSON logs to files or standard logs to sockets.
* | Don't require hiredis to run unit tests (#8680)Erik Johnston2020-10-291-0/+1
| |
* | Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-281-0/+1
|\ \ | | | | | | Fix serialisation errors when using third-party event rules.
| * | Remove frozendict_json_encoder and support frozendicts everywhereRichard van der Hoff2020-10-281-0/+1
| |/ | | | | | | | | | | Not being able to serialise `frozendicts` is fragile, and it's annoying to have to think about which serialiser you want. There's no real downside to supporting frozendicts, so let's just have one json encoder.
* | Add type hints to application services. (#8655)Patrick Cloke2020-10-281-0/+1
| |
* | Add an admin APIs to allow server admins to list users' pushers (#8610)Dirk Klimpel2020-10-281-0/+1
| | | | | | Add an admin API `GET /_synapse/admin/v1/users/<user_id>/pushers` like https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-pushers
* | Run mypy as part of the lint.sh script. (#8633)kleph2020-10-281-0/+1
| |
* | Don't pull event from DB when handling replication traffic. (#8669)Erik Johnston2020-10-281-0/+1
| | | | | | | | | | I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Tell Black to format code for Python 3.5 (#8664)Dan Callahan2020-10-271-0/+1
| | | | | | | | | | | | | | | | This allows trailing commas in multi-line arg lists. Minor, but we might as well keep our formatting current with regard to our minimum supported Python version. Signed-off-by: Dan Callahan <danc@element.io>
* | Minor updates to docs on how to run tests (#8666)Dan Callahan2020-10-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test runner isn't present in the `[all]` set of extras, so the previous instructions did not work without also installing `[test]`. Note that this does not include the `[lint]` extras, since those do not install on all supported Python versions (specifically, isort 5.x requires Python 3.6, while we still support 3.5). Instructions for that are included in our pull request template, so we should be fine there. I've also dropped the `--no-use-pep517` arg to `pip install` since it seems to have been added to address a temporary regression in pip 19.1 which was fixed in pip 19.1.1 the following month. Lastly, updated the example output of the test suite to set more realistic expectations around run time. Signed-off-by: Dan Callahan <danc@element.io>
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-27 05:13:11 +0000