summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Don't wake up destination transaction queue if they're not due for retry. ↵Erik Johnston2023-09-041-0/+1
| | | | (#16223)
* Add last_seen_ts to the admin users API (#16218)Mathieu Velten2023-09-041-0/+1
|
* Don't reset retry timers on "valid" error codes (#16221)Erik Johnston2023-09-041-0/+1
|
* Cache device resync requests over replication (#16241)David Robertson2023-09-041-0/+1
|
* Fix typo where we ended up with multiple `WorkerLocksHandler` (#16220)Erik Johnston2023-09-011-0/+1
| | | | | I don't think has caused any actual issues. Introduced in #15891
* Log the details of background update failures (#16212)David Robertson2023-09-011-0/+1
|
* Ignore redundant casts in latest deps CI job (#16213)David Robertson2023-08-301-0/+1
|
* Gracefully handle failing to thumbnail images (#16211)Erik Johnston2023-08-301-0/+1
|
* Fix rare bug that broke looping calls (#16210)Erik Johnston2023-08-301-0/+1
| | | | | | | | | | * Fix rare bug that broke looping calls We can't interact with the reactor from the main thread via looping call. Introduced in v1.90.0 / #15791. * Newsfile
* Stop writing to the event_txn_id table (#16175)Patrick Cloke2023-08-301-0/+1
|
* Describe which rate limiter was hit in logs (#16135)David Robertson2023-08-301-0/+1
|
* Track currently syncing users by device for presence (#16172)Patrick Cloke2023-08-291-0/+1
| | | | | | | Refactoring to use both the user ID & the device ID when tracking the currently syncing users in the presence handler. This is done both locally and over replication. Note that the device ID is discarded but will be used in a future change.
* Bump mypy-zope & mypy. (#16188)Patrick Cloke2023-08-291-0/+1
|
* Support IPv6-only SMTP servers (#16155)Evilham2023-08-291-0/+1
| | | | Use Twisted HostnameEndpoint to connect to SMTP servers (instead of connectTCP/connectSSL) which properly supports IPv6-only servers.
* Update black & fix the targeted Python versions. (#16187)Patrick Cloke2023-08-291-0/+1
| | | Black should target Python 3.8 to 3.11.
* Fix inaccurate error message while trying to ban or unban a user with the ↵Chen Zhang2023-08-291-0/+1
| | | | same or higher PL (#16205)
* Pass the device ID around in the presence handler (#16171)Patrick Cloke2023-08-281-0/+1
| | | | | | Refactoring to pass the device ID (in addition to the user ID) through the presence handler (specifically the `user_syncing`, `set_state`, and `bump_presence_active_time` methods and their replication versions).
* Combine logic about not overriding BUSY presence. (#16170)Patrick Cloke2023-08-281-0/+1
| | | | | | | | | | | | | Simplify some of the presence code by reducing duplicated code between worker & non-worker modes. The main change is to push some of the logic from `user_syncing` into `set_state`. This is done by passing whether the user is setting the presence via a `/sync` with a new `is_sync` flag to `set_state`. If this is `true` some additional logic is performed: * Don't override `busy` presence. * Update the `last_user_sync_ts`. * Never update the status message.
* Task scheduler: add replication notify for new task to launch ASAP (#16184)Mathieu Velten2023-08-281-0/+1
|
* Bump setuptools-rust from 1.6.0 to 1.7.0. (#16201)Patrick Cloke2023-08-281-0/+1
|
* Prepare unit tests for Python 3.12 (#16099)V024602023-08-251-0/+1
|
* service-identity, incremental, and setuptools-rust now have type hints. (#16186)Patrick Cloke2023-08-251-0/+1
|
* Validate input to POST /key/v2/query endpoint. (#16183)Patrick Cloke2023-08-251-0/+1
| | | To avoid 500 internal server errors with garbage input.
* Send proper JSON POST data to /publicRooms (#16185)Patrick Cloke2023-08-251-0/+1
| | | | The include_all_networks was previously sent in the JSON body as string "true" and "false" instead of boolean true and false.
* Replace simple_async_mock with AsyncMock (#16180)Patrick Cloke2023-08-251-0/+1
| | | | Python 3.8 has a native AsyncMock, use it instead of a custom implementation.
* Add warnings about MSC3861 on certain APIs. (#16168)Will Hunt2023-08-251-0/+1
|
* Replace make_awaitable with AsyncMock (#16179)Patrick Cloke2023-08-241-0/+1
| | | | Python 3.8 provides a native AsyncMock, we can replace the homegrown version we have.
* Document `exclude_rooms_fom_sync` configuration option (#16178)Shay2023-08-241-0/+1
|
* Add configuration setting for CAS protocol version (#15816)Aurélien Grimpard2023-08-241-0/+1
|
* Update URLs to matrix.org blog categories. (#16008)Amirreza Aflakparast2023-08-241-0/+1
|
* Fix typechecking with twisted trunk (#16121)David Robertson2023-08-241-0/+1
|
* Add `Retry-After` to M_LIMIT_EXCEEDED error responses (#16136)Will Hunt2023-08-241-0/+1
| | | Implements MSC4041 behind an experimental configuration flag.
* Merge branch 'release-v1.91' into developH. Shay2023-08-2340-40/+0
|\
| * 1.91.0rc1 v1.91.0rc1H. Shay2023-08-2340-40/+0
| |
* | Stabilize support for MSC3958 (suppress notifications from edits). (#16113)Patrick Cloke2023-08-231-0/+1
|/
* Fix rare deadlock when using read/write locks (#16169) github/release-v1.91.0 release-v1.91.0Erik Johnston2023-08-231-0/+1
|
* Switch `devenv` dependency in the nix development environment to the latest ↵Andrew Morgan2023-08-231-0/+1
| | | | release (instead of the development branch) (#16063)
* Filter out unwanted user_agents from udv. (#16124)Neil Johnson2023-08-231-0/+1
|
* Fix rare deadlock when using read/write locks (#16133)Erik Johnston2023-08-231-0/+1
|
* Reduce DB contention on worker locks (#16160)Erik Johnston2023-08-231-0/+1
|
* Always update `retry_last_ts` (#16164)Erik Johnston2023-08-231-0/+1
|
* Task scheduler: mark task as active if we are scheduling ASAP (#16165)Mathieu Velten2023-08-231-0/+1
|
* Add tests for restoring the presence state after a restart. (#16151)Patrick Cloke2023-08-232-1/+2
|
* Properly update retry_last_ts when hitting the maximum retry interval (#16156)DeepBlueV7.X2023-08-231-0/+1
| | | | | | | | | | | | | | | | | | | | | * Properly update retry_last_ts when hitting the maximum retry interval This was broken in 1.87 when the maximum retry interval got changed from almost infinite to a week (and made configurable). fixes #16101 Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> * Add changelog * Change fix + add test * Add comment --------- Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
* Only lock when we're backfilling (#16159)Erik Johnston2023-08-231-0/+1
|
* Increase perf of read/write locks (#16149)Erik Johnston2023-08-231-0/+1
| | | We do this by marking the tables as `UNLOGGED` in PostgreSQL.
* Clean-up presence tests (#16158)Patrick Cloke2023-08-221-0/+1
| | | Reduce duplicated code & remove unused variables.
* Fix perf of `wait_for_stream_positions` (#16148)Erik Johnston2023-08-221-0/+1
|
* Disable `m.3pid_changes` capability when MSC3861 is enabled. (#16134)Mathieu Velten2023-08-222-1/+2
|
* Add an admin endpoint to allow authorizing server to signal token ↵Shay2023-08-221-0/+1
| | | | revocations (#16125)
* Fix user directory test for deactivated support user. (#16157)Patrick Cloke2023-08-221-0/+1
| | | | Support users should not be added to the user directory after being deactivated.
* Raise poetry-core version cap to 1.7.0 (#16152)Theodore Ni2023-08-221-0/+1
|
* Properly call setup_background_tasks in unit tests. (#16150)Patrick Cloke2023-08-221-0/+1
| | | | | This should only be called on HomeServer objects which are configured to run background tasks, which is automatically (and properly) done via the call to setup().
* Disallow user_consent where experimental MSC3861 is enabled (#16127)Hugh Nimmo-Smith2023-08-221-0/+1
|
* Add `client_secret_path` as alternative for `client_secret` for OIDC config ↵Maximilian Bosch2023-08-211-0/+1
| | | | (#16030)
* Implements a task scheduler for resumable potentially long running tasks ↵Mathieu Velten2023-08-211-0/+1
| | | | (#15891)
* Speed up state res in rare case we don't have all events (#16116)Erik Johnston2023-08-181-0/+1
| | | | | | | If we don't have all the auth events in a room then not all state events will have a chain cover index. Even so, we can still use the chain cover index on the events that do have it, rather than bailing and using the slower functions. This situation should not arise for newly persisted rooms, as we check we have the full auth chain for each event, but can happen for existing rooms. c.f. #15245
* MSC3861: allow impersonation by an admin using a query param (#16132)Mathieu Velten2023-08-181-0/+1
|
* Allow filtering for admins in the list accounts admin API (#16114)Alexander Fechler2023-08-181-0/+1
|
* Add response time metrics for introspection requests (#16131)Erik Johnston2023-08-181-0/+1
| | | See #16119
* Add cache to `get_server_keys_json_for_remote` (#16123)Erik Johnston2023-08-181-0/+1
|
* Cache token introspection response from OIDC provider (#16117)Shay2023-08-171-0/+1
|
* Fix database performance of read/write worker locks (#16061)Erik Johnston2023-08-171-0/+1
| | | | | | | We were seeing serialization errors when taking out multiple read locks. The transactions were retried, so isn't causing any failures. Introduced in #15782.
* Override global statement timeout when creating indexes in Postgres (#16085)Shay2023-08-171-0/+1
|
* Disable caching in /sync corner case (#16080)Matthew Ma2023-08-171-0/+1
| | | Fixes #15502
* Rename pagination&purge locks and add comments explaining them (#16112)Mathieu Velten2023-08-161-0/+1
|
* Add link explaining ELK stack to structured_logging.md (#16091)axel simon2023-08-161-0/+1
|
* Attempt to fix twisted trunk (#16115)David Robertson2023-08-151-0/+1
|
* Run pyupgrade for python 3.7 & 3.8. (#16110)Patrick Cloke2023-08-151-0/+1
|
* Allow customizing IdP name and icon for SAML and CAS (#16094)Gabriel Rodríguez2023-08-111-0/+1
|
* Add linearizer on user ID to push rule PUT/DELETE requests (#16052)Nick Mills-Barrett2023-08-111-0/+1
| | | | | See: #16053 Signed off by Nick @ Beeper (@Fizzadar)
* Fix the type annotation on `run_db_interaction` in the Module API. (#16089)reivilibre2023-08-101-0/+1
| | | | | | | | | | | * Fix the method signature of `run_db_interaction` on the module API * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Clean-up presence code (#16092)Patrick Cloke2023-08-101-0/+1
| | | | | | | | Misc. clean-ups to: * Use keyword arguments. * Return early (reducing indentation) of some functions. * Removing duplicated / unused code. * Use wrap_as_background_process.
* Implements admin API to lock an user (MSC3939) (#15870)Mathieu Velten2023-08-101-0/+1
|
* Support MSC3814: Dehydrated Devices Part 2 (#16010)Shay2023-08-081-0/+1
|
* 1.90.0rc1Erik Johnston2023-08-0827-28/+0
|
* Allow modules to schedule delayed background calls. (#15993)reivilibre2023-08-081-0/+1
| | | | | | | | | | | | | | | * Add a module API function to provide `call_later` * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Add comments * Update version number --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Remove old rows from the `cache_invalidation_stream_by_instance` table ↵reivilibre2023-08-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | automatically. (This table is not used when Synapse is configured to use SQLite.) (#15868) * Add a cache invalidation clean-up task * Run the cache invalidation stream clean-up on the background worker * Tune down * call_later is in millis! * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * fixup! Add a cache invalidation clean-up task * Update synapse/storage/databases/main/cache.py Co-authored-by: Eric Eastwood <erice@element.io> * Update synapse/storage/databases/main/cache.py Co-authored-by: Eric Eastwood <erice@element.io> * MILLISEC -> MS * Expand on comment * Move and tweak comment about Postgres * Use `wrap_as_background_process` --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Co-authored-by: Eric Eastwood <erice@element.io>
* Fix endpoint improperly declaring support for MSC3814 (#16068)Shay2023-08-071-0/+1
|
* Drop backwards compat hack for event serialization (#16069)Shay2023-08-071-0/+1
|
* Add notes describing Synapse's streams (#16015)David Robertson2023-08-071-0/+1
| | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Fix deletion for Dehydrated Devices (#16046)Shay2023-08-041-0/+1
|
* Stabilize support for MSC3970: updated transaction semantics (scope to ↵Patrick Cloke2023-08-041-0/+1
| | | | | | | `device_id`) (#15629) For now this maintains compatible with old Synapses by falling back to using transaction semantics on a per-access token. A future version of Synapse will drop support for this.
* Move support for application service query parameter authorization behind a ↵Shay2023-08-031-0/+1
| | | | configuration option (#16017)
* Allow config of the backoff algorithm for the federation client. (#15754)Mathieu Velten2023-08-031-0/+1
| | | | | | | | | | | Adds three new configuration variables: * destination_min_retry_interval is identical to before (10mn). * destination_retry_multiplier is now 2 instead of 5, the maximum value will be reached slower. * destination_max_retry_interval is one day instead of (essentially) infinity. Capping this will cause destinations to continue to be retried sometimes instead of being lost forever. The previous value was 2 ^ 62 milliseconds.
* Allow modules to check whether the current worker is configured to run ↵reivilibre2023-08-031-0/+1
| | | | background tasks. (#15991)
* Add forward-compatibility for the redacts property (MSC2174). (#16013)Patrick Cloke2023-08-021-0/+1
| | | | | | | | The location of the redacts field changes in room version 11. Ensure it is copied to the *new* location for *old* room versions for forwards-compatibility with clients. Note that copying it to the *old* location for the *new* room version was previously handled.
* Update MSC3958 support to interact with intentional mentions. (#15992)Patrick Cloke2023-08-021-0/+1
| | | | | | | * Updates the rule ID. * Use `event_property_is` instead of `event_match`. This updates the implementation of MSC3958 to match the latest text from the MSC.
* Update `flake.lock` to fix running the nix developer environment on MacOS ↵Andrew Morgan2023-08-021-0/+1
| | | | (#16019)
* Update certifi to 2023.7.22 and pygments to 2.15.1. (#16044)Patrick Cloke2023-08-011-0/+1
|
* Properly setup the additional sequences in the portdb script. (#16043)Patrick Cloke2023-08-011-0/+1
| | | | | The un_partial_stated_event_stream_sequence and application_services_txn_id_seq were never properly configured in the portdb script, resulting in an error on start-up.
* Trim whitespace when setting display names (#16031)Mohit Rathee2023-08-011-0/+1
|
* Add metrics tracking for eviction to ResponseCache (#16028)Jason Little2023-08-011-0/+1
| | | | Track whether the ResponseCache is evicting due to invalidation or due to time.
* Combine duplicated code for calculating an event ID from a txn ID (#16023)Patrick Cloke2023-07-311-0/+1
| | | | Refactoring related to stabilization of MSC3970, refactor to combine code which has the same logic.
* Do not expose Admin API in caddy reverse proxy example (#16027)Nils2023-07-311-0/+1
| | | Signed-off-by: Nils ANDRÉ-CHANG <nils@nilsand.re>
* Add ability to wait for locks and add locks to purge history / room deletion ↵Erik Johnston2023-07-311-0/+1
| | | | | (#15791) c.f. #13476
* Clarify comment on key uploads over replication (#16016)Shay2023-07-271-0/+2
|
* Fix 404 on /profile when the display name is empty but not the avatar (#16012)Mathieu Velten2023-07-271-0/+1
|
* Update PyYAML to 6.0.1 (#16011)Mathieu Velten2023-07-271-0/+1
|
* Attempt to fix labelling in docker workflow (#16009)David Robertson2023-07-271-0/+1
|
* Remove support for legacy application service paths (#15964)Shay2023-07-261-0/+1
|
* Inline SQL queries using boolean parameters (#15525)Anshul Madnawat2023-07-261-0/+1
| | | | SQLite now supports TRUE and FALSE constants, simplify some queries by inlining those instead of passing them as arguments.
* Add synapse version as Docker container label (#15972)Mo Balaa2023-07-261-0/+1
| | | | Co-authored-by: Mo Balaa <balaa@fractalnetworks.co>
* Remove changelog fileMathieu Velten2023-07-261-1/+0
|
* Bump DB version to 79 since synapse v1.88 was already there (#15998)Mathieu Velten2023-07-261-0/+1
|
* 1.89.0rc1Mathieu Velten2023-07-2530-30/+0
|
* Support MSC3814: Dehydrated Devices (#15929)Shay2023-07-241-0/+1
| | | | | | Signed-off-by: Nicolas Werner <n.werner@famedly.com> Co-authored-by: Nicolas Werner <n.werner@famedly.com> Co-authored-by: Nicolas Werner <89468146+nico-famedly@users.noreply.github.com> Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
* Fix broken Arch Linux package link (#15981)SnipeX_2023-07-241-0/+1
|
* Resync stale devices in background (#15975)Erik Johnston2023-07-241-0/+1
| | | | This is so we don't block responding to federation transaction while we try and fetch the device lists.
* Properly handle redactions of creation events (#15973)Shay2023-07-231-0/+1
|
* Actually stop reading from column `user_id` of tables `profiles` (#15955)Shay2023-07-231-0/+1
|
* Build packages for Debian Trixie (#15961)Shay2023-07-231-0/+1
|
* Speed up updating state in large rooms (#15971)Erik Johnston2023-07-201-0/+1
| | | This should speed up updating state in rooms with lots of state.
* Fixed grafana deploy annotations in the dashboard config, so it shows for ↵Will Lewis2023-07-201-0/+1
| | | | | | | | | those not managing matrix.org (#15957) Removed the 'matrix.org' hardcorded instance setting Originally introduced in #15674 Co-authored-by: wrjlewis <will.lewis@askattest.com>
* Don't log exceptions for every non-200 response (#15969)Erik Johnston2023-07-201-0/+1
| | | Introduced in #15913
* Reduce the amount of state we pull out (#15968)Erik Johnston2023-07-201-0/+1
|
* Ensure a long state res does not starve CPU (#15960)Erik Johnston2023-07-191-0/+1
| | | We do this by yielding the reactor in hot loops.
* Fix bad merge of #15933 (#15958)Erik Johnston2023-07-191-0/+1
| | | This was because we reverted the bump of the schema version, so we were not applying the new deltas.
* Fix race in triggers for read/write locks. (#15933)Erik Johnston2023-07-191-0/+1
|
* Fix background schema updates failing over a large upgrade gap (#15887)Shay2023-07-181-0/+1
|
* Support room version 11 (#15912)Patrick Cloke2023-07-181-0/+1
| | | | | And fix a bug in the implementation of the updated redaction format (MSC2174) where the top-level redacts field was not properly added for backwards-compatibility.
* Add a locality to a few presence metrics (#15952)Jason Little2023-07-181-0/+1
|
* Re-introduce the outbound federation proxy (#15913)Eric Eastwood2023-07-181-0/+1
| | | | | Allow configuring the set of workers to proxy outbound federation traffic through (`outbound_federation_restricted_to`). This is useful when you have a worker setup with `federation_sender` instances responsible for sending outbound federation requests and want to make sure *all* outbound federation traffic goes through those instances. Before this change, the generic workers would still contact federation themselves for things like profile lookups, backfill, etc. This PR allows you to set more strict access controls/firewall for all workers and only allow the `federation_sender`'s to contact the outside world.
* Pin the rust version in `flake.nix`, and bump to 1.70.0 to fix installing ↵Andrew Morgan2023-07-171-0/+1
| | | | `ruff` (#15940)
* Document that you cannot login as yourself on ↵Will Hunt2023-07-141-0/+1
| | | | /_synapse/admin/v1/users/<user_id>/login (#15938)
* Stop accepting 'user' parameter for application service registration. (#15928)Patrick Cloke2023-07-131-0/+1
| | | This is unspecced, but has existed for a very long time.
* Remove unneeded __init__. (#15926)Patrick Cloke2023-07-121-0/+1
| | | | Remove an __init__ which only calls super() without changing the input arguments.
* Fix running with an empty experimental features section. (#15925)Patrick Cloke2023-07-121-0/+1
|
* Fix push for invites received over federation (#15820)Erik Johnston2023-07-121-0/+1
|
* Mark get_user_in_directory private since only used in tests (#15884)Mathieu Velten2023-07-121-0/+1
|
* Make it more obvious which Python version runs on a given Linux distribution ↵Eric Eastwood2023-07-111-0/+1
| | | | | | | (#15909) Make it more obvious which Python version runs on a given Linux distribution so when we end up dropping support for a given Python version, we can more easily find the reference to the Python version and remove any references for the distribution. We don't want to be running tests or building packages on a distribution that no longer has a supported Python version. This way, we can avoid another situation like when we dropped support for Python 3.7 but forgot to drop the Debian Buster references everywhere (https://github.com/matrix-org/synapse/pull/15893)
* Better clarify how to run a worker instance (pass both configs) (#15921)Eric Eastwood2023-07-111-0/+1
| | | | | | | | | Previously, if you just followed the instructions per the docs, you just ran into an error: ```sh $ poetry run synapse_worker --config-path homeserver_generic_worker1.yaml Missing mandatory `server_name` config option. ```
* Better warning in logs when we fail to fetch an alias (#15922)Eric Eastwood2023-07-111-0/+1
| | | | | | | | | | | | | **Before:** ``` Error retrieving alias ``` **After:** ``` Error retrieving alias #foo:bar -> 401 Unauthorized ``` *Spawning from creating the [manual testing strategy for the outbound federation proxy](https://github.com/matrix-org/synapse/pull/15773).*
* Bump Unix sockets intro version (#15924)Eric Eastwood2023-07-111-0/+1
| | | https://github.com/matrix-org/synapse/pull/15708 didn't quite make the cut for `1.88.0` this morning.
* Unix Sockets for HTTP Replication (#15708)Jason Little2023-07-111-0/+1
| | | | | | | | | Unix socket support for `federation` and `client` Listeners has existed now for a little while(since [1.81.0](https://github.com/matrix-org/synapse/pull/15353)), but there was one last hold out before it could be complete: HTTP Replication communication. This should finish it up. The Listeners would have always worked, but would have had no way to be talked to/at. --------- Co-authored-by: Eric Eastwood <madlittlemods@gmail.com> Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Co-authored-by: Eric Eastwood <erice@element.io>
* Add + as an allowed character for Matrix IDs (MSC4009) (#15911)Patrick Cloke2023-07-111-0/+1
|
* 1.88.0rc1David Robertson2023-07-1122-24/+0
|
* Add `Server` to Access-Control-Expose-Headers header (#15908)Michael Telatynski2023-07-111-0/+1
|
* Make the media `/upload` tracing less ambiguous (#15888)Eric Eastwood2023-07-101-0/+1
| | | | | | | | | | A lot of the functions have the same name in this space like `store_file`, and we also do it multiple times for different reasons (main media repo, other storage providers, thumbnails, etc) so it's good to differentiate them so your head doesn't explode. Follow-up to https://github.com/matrix-org/synapse/pull/15850 Tracing instrumentation to media `/upload` code paths to investigate https://github.com/matrix-org/synapse/issues/15841
* Drop debian buster (#15893)Shay2023-07-101-0/+1
|
* Revert "Federation outbound proxy" (#15910)Eric Eastwood2023-07-101-1/+0
| | | | | | Revert "Federation outbound proxy (#15773)" This reverts commit b07b14b494ae1dd564b4c44f844c9a9545b3d08a.
* Revert "Placeholder changelog"Eric Eastwood2023-07-101-1/+0
| | | | This reverts commit 6e731e86bfa9d92f983f7df9367e37aa80733078.
* Fix downgrading to previous version of Synapse (#15907)Erik Johnston2023-07-101-0/+1
| | | We do this by marking the constraint as deferrable.
* Fix building rust with nightly (#15906)Erik Johnston2023-07-101-0/+1
| | | Also fix up a warning.
* Placeholder changelogEric Eastwood2023-07-101-0/+1
|
* Stop running sytest on buster/python3.7 (#15892)Shay2023-07-071-0/+1
|
* Stop writing to column `user_id` of tables `profiles` and `user_filters` ↵Shay2023-07-071-0/+1
| | | | (#15787)
* Remove `worker_replication_*` settings from worker doc (#15872)Dirk Klimpel2023-07-071-0/+1
| | | Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
* Remove `worker_replication_*` deprecated settings, with helpful errors on ↵Jason Little2023-07-071-0/+1
| | | | | | startup (#15860) Co-authored-by: reivilibre <oliverw@matrix.org>
* Update link to the clients webpage, fix #15825 (#15874)sarthak shah2023-07-061-0/+1
|
* Federation outbound proxy (#15773)Eric Eastwood2023-07-051-0/+1
| | | | | | | Allow configuring the set of workers to proxy outbound federation traffic through (`outbound_federation_restricted_to`). This is useful when you have a worker setup with `federation_sender` instances responsible for sending outbound federation requests and want to make sure *all* outbound federation traffic goes through those instances. Before this change, the generic workers would still contact federation themselves for things like profile lookups, backfill, etc. This PR allows you to set more strict access controls/firewall for all workers and only allow the `federation_sender`'s to contact the outside world. The original code is from @erikjohnston's branches which I've gotten in-shape to merge.
* Remove support for Python 3.7 (#15851)Eric Eastwood2023-07-051-0/+1
| | | Fix https://github.com/matrix-org/synapse/issues/15836
* Add basic read/write lock (#15782)Erik Johnston2023-07-051-0/+1
|
* Add tracing to media `/upload` endpoint (#15850)Eric Eastwood2023-07-051-0/+1
| | | Add tracing instrumentation to media `/upload` code paths to investigate https://github.com/matrix-org/synapse/issues/15841
* docs/admin_api: fix header level on 'Users' page (#15852)Sumner Evans2023-07-051-0/+1
| | | Signed-off-by: Sumner Evans <sumner@beeper.com>
* Fix could not serialize access due to concurrent `DELETE` from ↵Jason Little2023-07-051-0/+1
| | | | | | | presence_stream (#15826) * Change update_presence to have a isolation level of READ_COMMITTED * changelog
* Add foreign key constraint to `event_forward_extremities`. (#15751)Erik Johnston2023-07-051-0/+1
|
* use Image.LANCZOS instead of Image.ANTIALIAS for thumbnail resize (#15876)an0nfunc2023-07-051-0/+1
| | | | | Image.ANTIALIAS is not defined in current pillow releases. Since ANTIALIAS was just using LANCZOS anyways, this is just a cosmetic change, but makes synapse work with most recent pillow releases. Signed-off-by: Giovanni Harting <539@idlegandalf.com>
* Add not_user_type param to the list accounts admin API (#15844)Michael Weimann2023-07-041-0/+1
| | | Signed-off-by: Michael Weimann <michaelw@element.io>
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2023-07-041-1/+0
|\
| * 1.87.0Olivier Wilkinson (reivilibre)2023-07-042-4/+0
| |
| * Pin `pydantic` to <2.0.0 (#15862)Paarth Shah2023-07-041-0/+3
| | | | | | Signed-off-by: Paarth Shah <mail@shahpaarth.com>
* | Pin `pydantic` to <2.0.0 (#15862)Paarth Shah2023-07-041-0/+3
| | | | | | Signed-off-by: Paarth Shah <mail@shahpaarth.com>
* | devices: use combined ANY clause for faster cleanup (#15861)pacien2023-07-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Old device entries for the same user were being removed in individual SQL commands, making the batch take way longer than necessary. This combines the commands into a single one with a IN/ANY clause. Example of log entry before the change, regularly observed with "log_min_duration_statement = 10000" in PostgreSQL's config: LOG: duration: 42538.282 ms statement: DELETE FROM device_lists_stream WHERE user_id = '@someone' AND device_id = 'someid1' AND stream_id < 123456789 ; DELETE FROM device_lists_stream WHERE user_id = '@someone' AND device_id = 'someid2' AND stream_id < 123456789 ; [repeated for each device ID of that user, potentially a lot...] With the patch applied on my instance for the past couple of days, I no longer notice overly long statements of that particular kind. Signed-off-by: pacien <pacien.trangirard@pacien.net>
* | Fix the `devenv up` configuration which was ignoring the config overrides. ↵reivilibre2023-07-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#15854) * Fix use of config override directory in `devenv up` `--config-directory` is for the generate config script; `-c` is for usage * Add homeserver config override directory to gitignore * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Add a timeout that aborts any Postgres statement taking more than 1 hour. ↵reivilibre2023-07-031-0/+1
|/ | | | | | | | | | | | | (#15853) * Add a timeout to Postgres statements * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Split out 2022 changes from the changelog (#15846)Eric Eastwood2023-06-281-0/+1
| | | Split out 2022 changes from the changelog so the rendered version in GitHub doesn't timeout as much.
* Prepare changelog for v1.87.0rc1Eric Eastwood2023-06-2721-21/+0
|
* Fix sqlite `user_filters` upgrade (#15817)Shay2023-06-271-0/+1
|
* Add login spam checker API (#15838)Erik Johnston2023-06-261-0/+1
|
* Fix forgotten rooms missing in initial sync (#15815)Nicolas Werner2023-06-211-0/+1
| | | | | | | | If you leave a room and forget it, then rejoin it, the room would be missing from the next initial sync. fixes #13262 Signed-off-by: Nicolas Werner <n.werner@famedly.com>
* Fix harmless exception in port DB script (#15814)Erik Johnston2023-06-211-0/+1
| | | | | | | The port DB script would try and run database background tasks, which could fail if the data they acted on was in the process of being ported. These exceptions were non fatal. Fixes #15789
* Fix typo in faster join docs (#15812)Erik Johnston2023-06-211-0/+1
| | | Fixes #15756
* Allow for the configuration of max request retries and min/max retry delays ↵Mathieu Velten2023-06-211-0/+1
| | | | in the matrix federation client (#15783)
* Fix Sytest environmental variable evaluation in CI (#15804)Shay2023-06-201-0/+1
|
* Fix admin api documentation typo (#15805)ew-at-vier2023-06-201-0/+1
| | | | | * Fix admin api documentation typo Signed-off-by: Eric Wolf <eric.wolf@vier.ai>
* Switch from `matrix://` to `matrix-federation://` scheme for internal ↵Eric Eastwood2023-06-201-0/+1
| | | | | | | Synapse routing of outbound federation traffic (#15806) `matrix://` is a registered specced scheme nowadays and doesn't make sense for our internal to Synapse use case anymore. ([discussion] (https://github.com/matrix-org/synapse/pull/15773#discussion_r1227598679))
* Remove experimental MSC2716 implementation to incrementally import history ↵Eric Eastwood2023-06-161-0/+1
| | | | | | | | | | | | into existing rooms (#15748) Context for why we're removing the implementation: - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1487441010 - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1504262734 Anyone wanting to continue MSC2716, should also address these leftover tasks: https://github.com/matrix-org/synapse/issues/10737 Closes https://github.com/matrix-org/synapse/issues/10737 in the fact that it is not longer necessary to track those things.
* Don't always lock "user_ips" table when performing non-native upsert (#15788)Andrew Morgan2023-06-161-0/+1
|
* push rules: fix internal conversion from _type to value (#15781)Mathieu Velten2023-06-161-0/+1
| | | Also fix wrong rule names for `is_user_mention` and `is_room_mention`.
* Regularly try to wake up dests instead of waiting for next PDU/EDU (#15743)Mathieu Velten2023-06-161-0/+1
|
* Fix unsafe hotserving behaviour for non-multimedia uploads. (#15680)Josh Qou2023-06-151-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix unsafe hotserving behaviour for non-multimedia uploads. * invert disposition assert * test_media_storage.py: run lint * test_base.py: /inline/attachment/s * Only return attachment for disposition type, update tests * Update synapse/media/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update changelog.d/15680.bugfix Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * add attribution * Update changelog. --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Fix joining rooms through aliases where the alias server isn't a real ↵Tulir Asokan2023-06-141-0/+1
| | | | homeserver (#15776)
* Merge branch 'release-v1.86' into developMathieu Velten2023-06-1430-30/+0
|\
| * 1.86.0rc2 v1.86.0rc2Mathieu Velten2023-06-141-1/+0
| |
| * Fix empty scope when having version mismatch between workers (#15774)Mathieu Velten2023-06-141-0/+1
| |
| * 1.86.0rc1Mathieu Velten2023-06-1330-30/+0
| |
* | Prefill events after invalidate not before when persisting events (#15758)Jason Little2023-06-141-0/+1
| | | | | | | | | | Fixes #15757
* | Document `looping_call()` functionality that will wait for the given ↵Eric Eastwood2023-06-131-0/+1
| | | | | | | | | | | | | | function to finish before scheduling another (#15772) Thanks to @erikjohnston for clarifying, https://github.com/matrix-org/synapse/pull/15743#discussion_r1226544457 We don't have to worry about calls stacking up if the given function takes longer than the scheduled time.
* | Replace `EventContext` fields `prev_group` and `delta_ids` with field ↵Shay2023-06-131-0/+1
| | | | | | | | `state_group_deltas` (#15233)
* | Fix MSC3983 support: only one OTK per device was returned through federation ↵Mathieu Velten2023-06-131-0/+1
| | | | | | | | (#15770)
* | Avoid backfill when we already have messages to return (#15737)Eric Eastwood2023-06-131-0/+1
| | | | | | | | | | We now only block the client to backfill when we see a large gap in the events (more than 2 events missing in a row according to `depth`), more than 3 single-event holes, or not enough messages to fill the response. Otherwise, we return the messages directly to the client and backfill in the background for eventual consistency sake. Fix https://github.com/matrix-org/synapse/issues/15696
* | Fix MSC3983 support: Use the unstable /keys/claim federation endpoint if ↵Patrick Cloke2023-06-131-0/+1
|/ | | | multiple keys are requested (#15755)
* Bump minimum supported Rust version (#15768)Erik Johnston2023-06-121-0/+1
| | | | Important crates such as `log` and `regex` have bumped theirs to 1.60.0 as well.
* Backfill in the background if we're doing it "just because" (#15710)Eric Eastwood2023-06-091-0/+1
| | | Fix https://github.com/matrix-org/synapse/issues/15702
* Speed up typechecking CI (#15752)Erik Johnston2023-06-091-0/+1
| | | | By restoring the rust cache before installing the project.
* Allow for the configuration of max request retries and min/max retry delays ↵Shay2023-06-091-0/+1
| | | | | | | in the matrix federation client (#12504) Co-authored-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
* Clear event caches when we purge history (#15609)Erik Johnston2023-06-081-0/+1
| | | | | | | This should help a little with #13476 --------- Co-authored-by: Patrick Cloke <patrickc@matrix.org>
* Quick & dirty metric for background update status (#15740)David Robertson2023-06-071-0/+1
| | | | | | | | | | | | | | | * Quick & dirty metric for background update status * Changelog * Remove debug Co-authored-by: Mathieu Velten <mathieuv@matrix.org> * Actually write to _aborted --------- Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
* Remove superfluous `room_memberships` join from background update (#15733)Eric Eastwood2023-06-071-0/+1
| | | Spawning from https://github.com/matrix-org/synapse/pull/15731
* Remove redundant `room_memberships` join to find participating servers in a ↵Eric Eastwood2023-06-071-0/+1
| | | | | room (#15732) Spawning from https://github.com/matrix-org/synapse/pull/15731
* Check required power levels earlier in createRoom handler. (#15695)Grant McLean2023-06-071-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Check required power levels earlier in createRoom handler. - If a server was configured to reject the creation of rooms with E2EE enabled (by specifying an unattainably high power level for "m.room.encryption" in default_power_level_content_override), the 403 error was not being triggered until after the room was created and before the "m.room.power_levels" was sent. This allowed a user to access the partially-configured room and complete the setup of E2EE and power levels manually. - This change causes the power level overrides to be checked earlier and the request to be rejected before the user gains access to the room. - A new `_validate_room_config` method is added to contain checks that should be run before a room is created. - The new test case confirms that a user request is rejected by the new validation method. Signed-off-by: Grant McLean <grant@catalyst.net.nz> * Add a changelog file. * Formatting fix for black. * Remove unneeded line from test. --------- Signed-off-by: Grant McLean <grant@catalyst.net.nz>
* No need for the extra join since `membership` is built-in to ↵Eric Eastwood2023-06-061-0/+1
| | | | | | | `current_state_events` (#15731) This helps with the upstream `is_host_joined()` and `is_host_invited()` functions. `membership` was added to `current_state_events` in https://github.com/matrix-org/synapse/pull/5706 and forced in https://github.com/matrix-org/synapse/pull/13745
* Trace functions which return `Awaitable` (#15650)Eric Eastwood2023-06-061-0/+1
|
* Update error to more plainly explain we can only authorize our own events ↵Eric Eastwood2023-06-061-0/+1
| | | | (#15725)
* Add context for when/why to use the `long_retries` option when sending ↵Eric Eastwood2023-06-061-0/+1
| | | | Federation requests (#15721)
* Improve performance of user directory search (#15729)Shay2023-06-061-0/+1
|
* Prevent "twisted trunk" and "latest deps" workflows from running on forks ↵Andrew Morgan2023-06-061-0/+1
| | | | (#15726)
* Remove some unused `server_name` fields (#15723)Sean Quah2023-06-061-0/+1
| | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Stabilize support for MSC3952: Intentional mentions. (#15520)Patrick Cloke2023-06-061-0/+1
|
* Some house keeping on `maybe_backfill()` functions (#15709)Eric Eastwood2023-06-051-0/+1
|
* `N + 3`: Read from column `full_user_id` rather than `user_id` of tables ↵Shay2023-06-021-0/+1
| | | | `profiles` and `user_filters` (#15649)
* Add a catch-all * to the supported relation types when redacting (#15705)Mathieu Velten2023-06-021-0/+1
| | | This is an update to MSC3912 implementation
* Log when events are (unexpectedly) filtered out of responses in tests (#14213)Eric Eastwood2023-06-011-0/+1
| | | | | See https://github.com/matrix-org/synapse/pull/14095#discussion_r990335492 This is useful because when see that a relevant event is an `outlier` or `soft-failed`, then that's a good unexpected indicator explaining why it's not showing up. `filter_events_for_client` is used in `/sync`, `/messages`, `/context` which are all common end-to-end assertion touch points (also notifications, relations).
* Cache requests for user's devices from federation (#15675)Erik Johnston2023-06-011-0/+1
| | | | This should mitigate the issue where lots of different servers requests the same user's devices all at once.
* Implement stable support for MSC3882 to allow an existing device/session to ↵Hugh Nimmo-Smith2023-06-011-0/+1
| | | | | | | | generate a login token for use on a new device/session (#15388) Implements stable support for MSC3882; this involves updating Synapse's support to match the MSC / the spec says. Continue to support the unstable version to allow clients to transition.
* Add Synapse version deploy annotations to Grafana dashboard (#15674)Eric Eastwood2023-05-311-0/+1
| | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/15662 This manifests as purple lines that show up on all time series panels that you can hover and see what version was deployed. Also added a new "Deployed Synapse versions over time" panel where the color block changes with each version. And mixed this color block into the "Up" time series panel. To get the Grafana dashboard JSON to copy here: use the **Share** icon at the top -> **Export** -> check the **Export for sharing externally** option -> **View JSON** or **Save to file**
* Add stubs package for lxml. (#15697)Patrick Cloke2023-05-311-0/+1
| | | | | | | The stubs have some issues so this has some generous cast and ignores in it, but it is better than not having stubs. Note that confusing that Element is a function which creates _Element instances (and similarly for Comment).
* Docker fully qualified image names (#15689)Jason Little2023-05-311-0/+1
| | | | | | | | | | | | | | | | | | | | * Fully qualified docker image names for the main Dockerfile and Complement related. * Fully qualified docker image names for Dockerfiles associated with building Debian release artifacts. This one is harder and is separate from the other commit in case it wasn't correct or was unwanted. I decided to do the expansion on the docker images in the Dockerfile itself, instead of the various source places that build which distribution that is selected, as it would have been more invasive with the scripts breaking up the string for tagging and such. This one is untested. * Changelog * Update docker/Dockerfile-workers * Update docker/complement/Dockerfile --------- Co-authored-by: reivilibre <olivier@librepush.net>
* Add get_canonical_room_alias to module API (#15450)Gabriel Féron2023-05-311-0/+1
| | | Co-authored-by: Boxdot <d@zerovolt.org>
* Add stricter mypy options (#15694)Patrick Cloke2023-05-311-0/+1
| | | | Enable warn_unused_configs, strict_concatenate, disallow_subclassing_any, and disallow_incomplete_defs.
* Merge branch 'release-v1.85' into developDavid Robertson2023-05-3050-50/+0
|\
| * 1.85.0rc1David Robertson2023-05-3050-50/+0
| |
* | Newsfile.Quentin Gliech2023-05-301-0/+1
| |
* | Remove unused `FederationServer.__str__` override (#15690)Sean Quah2023-05-301-0/+1
|/ | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Create dependabot changelogs at release time (#15481)David Robertson2023-05-301-0/+1
| | | | | | | | | * Ditch dependabot changelog workflow * Summarise dependabot commits in release script * Changelog * Update scripts-dev/release.py
* Bump types-bleach from 6.0.0.1 to 6.0.0.3 (#15686)dependabot[bot]2023-05-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-bleach from 6.0.0.1 to 6.0.0.3 Bumps [types-bleach](https://github.com/python/typeshed) from 6.0.0.1 to 6.0.0.3. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-bleach dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Bump types-requests from 2.30.0.0 to 2.31.0.0 (#15684)dependabot[bot]2023-05-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | * Bump types-requests from 2.30.0.0 to 2.31.0.0 Bumps [types-requests](https://github.com/python/typeshed) from 2.30.0.0 to 2.31.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump log from 0.4.17 to 0.4.18 (#15681)dependabot[bot]2023-05-291-0/+1
|
* Bump pydantic from 1.10.7 to 1.10.8 (#15685)dependabot[bot]2023-05-291-0/+1
|
* Bump prometheus-client from 0.16.0 to 0.17.0 (#15682)dependabot[bot]2023-05-291-0/+1
|
* Bump types-pyyaml from 6.0.12.9 to 6.0.12.10 (#15683)dependabot[bot]2023-05-291-0/+1
|
* Add Unix socket support for Redis connections (#15644)Jason Little2023-05-261-0/+1
| | | | Adds a new configuration setting to connect to Redis via a Unix socket instead of over TCP. Disabled by default.
* Add `MSC3820opt2` as a known room version (#15678)Travis Ralston2023-05-261-0/+1
|
* Documentation improvements to contributing guide (#15667) (#15668)Grant McLean2023-05-261-0/+1
| | | | | | | | | Fix #15667 - Reiterate the importance of getting Rust installed and set up before attempting to install the Python dependencies. - Mention the importance of confirming that `poetry install` completed successfully and include a typical error that the user might see if it did not. - Expand on "Now edit homeserver.yaml" to give examples of things likely to need changing and to link to the relevant sections of the Synapse server documentation.
* Set thread_id column to non-null for ↵Patrick Cloke2023-05-261-0/+1
| | | | | | | | | | | | | | | | event_push_{actions,actions_staging,summary} (#15597) Updates the database schema to require a thread_id (by adding a constraint that the column is non-null) for event_push_actions, event_push_actions_staging, and event_push_actions_summary. For PostgreSQL we add the constraint as NOT VALID, then VALIDATE the constraint a background job to avoid locking the table during an upgrade. Each table is updated as a separate schema delta to avoid deadlocks between them. For SQLite we simply rebuild the table & copy the data.
* Add MSC3820 (room version 11) option 2 unstable room version. (#15666)Travis Ralston2023-05-261-0/+1
|
* Process previously failed backfill events in the background (#15585)Eric Eastwood2023-05-241-0/+1
| | | | | | | | | Process previously failed backfill events in the background because they are bound to fail again and we don't need to waste time holding up the request for something that is bound to fail again. Fix https://github.com/matrix-org/synapse/issues/13623 Follow-up to https://github.com/matrix-org/synapse/issues/13621 and https://github.com/matrix-org/synapse/issues/13622 Part of making `/messages` faster: https://github.com/matrix-org/synapse/issues/13356
* Add requesting user id parameter to key claim methods in ↵Shay2023-05-241-0/+1
| | | | `TransportLayerClient` (#15663)
* Add type hints to test_descriptors. (#15659)Patrick Cloke2023-05-241-0/+1
| | | Require type hints in test_descriptors and add missing ones.
* Speed up user directory rebuild for users some more... (#15665)Erik Johnston2023-05-241-0/+1
|
* Improve type hints for cached decorator. (#15658)Patrick Cloke2023-05-241-0/+1
| | | | | The cached decorators always return a Deferred, which was not properly propagated. It was close enough when wrapping coroutines, but failed if a bare function was wrapped.
* Fix `@trace` not wrapping some state methods that return coroutines ↵Eric Eastwood2023-05-231-0/+1
| | | | | | | | | | | correctly (#15647) ``` 2023-05-21 09:30:09,288 - synapse.logging.opentracing - 940 - ERROR - POST-1 - @trace may not have wrapped StateStorageController.get_state_for_groups correctly! The function is not async but returned a coroutine ``` Tracing instrumentation for these functions originally introduced in https://github.com/matrix-org/synapse/pull/15610
* Consolidate logic to check for deactivated users. (#15634)Patrick Cloke2023-05-231-0/+1
| | | | | | | This moves the deactivated user check to the method which all login types call. Additionally updates the application service tests to be more realistic by removing invalid tests and fixing server names.
* Use a custom scheme & the worker name for replication requests. (#15578)Jason Little2023-05-231-0/+1
| | | | | | | | All the information needed is already in the `instance_map`, so use that instead of passing the hostname / IP & port manually for each replication request. This consolidates logic for future improvements of using e.g. UNIX sockets for workers.
* Bump requests from 2.28.2 to 2.31.0 (#15651)dependabot[bot]2023-05-231-0/+1
|
* Remove duplicate timestamp from test logs (`_trial_temp/test.log`) (#15636)Eric Eastwood2023-05-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/15618 ### Before ``` 2023-05-17 22:51:36-0500 [-] 2023-05-17 22:51:36,889 - synapse.server - 338 - INFO - sentinel - Finished setting up. ``` ### After ``` 2023-05-19 18:16:20-0500 [-] synapse.server - 338 - INFO - sentinel - Finished setting up. ``` ### Dev notes The `Twisted.Logger` controls the `2023-05-19 18:16:20-0500 [-]` prefix, see : [`twisted/twisted` -> `src/twisted/logger/_format.py#L362-L374`](https://github.com/twisted/twisted/blob/34b161e66bc7c9f9efbb95e82c770a863933e498/src/twisted/logger/_format.py#L362-L374) And we delegate our logs to the Twisted Logger for the tests which puts it in `_trial_temp/test.log`
* Remove outdated comment in log config (#15648)Andrew Morgan2023-05-221-0/+1
|
* Properly parse event_fields in filters (#15607)Patrick Cloke2023-05-221-0/+1
| | | | | | | | The event_fields property in filters should use the proper escape rules, namely backslashes can be escaped with an additional backslash. This adds tests (adapted from matrix-js-sdk) and implements the logic to properly split the event_fields strings.
* Bump pygithub from 1.58.1 to 1.58.2 (#15643)dependabot[bot]2023-05-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | * Bump pygithub from 1.58.1 to 1.58.2 Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.58.1 to 1.58.2. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/v1.58.2/doc/changes.rst) - [Commits](https://github.com/pygithub/pygithub/compare/v1.58.1...v1.58.2) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>