summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Add missing type hints to config classes. (#12402)Patrick Cloke2022-04-111-0/+1
|
* Enable certificate checking during complement tests (#12435)Richard van der Hoff2022-04-111-0/+1
|
* Do not consider events by ignored users for bundled aggregations (#12235)Patrick Cloke2022-04-113-1/+2
| | | | | | | Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / 4df10d32148ae29f792afc68ff774bcbd1915cea for corresponding changes for the `/relations` endpoint.
* Fix up healthcheck generation for workers docker image (#12405)Richard van der Hoff2022-04-111-0/+1
| | | This wasn't quite generating the right thing.
* Disallow untyped defs in synapse._scripts (#12422)David Robertson2022-04-111-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.
* Move complement setup stuff into the Synapse repo (#12404)Richard van der Hoff2022-04-111-0/+1
| | | | | | Fixes matrix-org/complement#330 (or it will, once we remove the old files). It's not quite a lift-and-shift: I've also taken the opportunity to get rid of the custom CA that we used to use to sign the TLS certs, which has been superceded by the CA exposed by Complement.
* Add Module API for reading and writing global account data. (#12391)reivilibre2022-04-111-0/+1
|
* CI: Fix the export-data job to run under poetry (#12418)David Robertson2022-04-081-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Optimise `_update_client_ips_batch_txn` to batch together database ↵reivilibre2022-04-081-0/+1
| | | | | operations. (#12252) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Make `synapse._scripts` pass typechecks (#12421)David Robertson2022-04-081-0/+1
|
* Stop maintaining a list of lint targets in `lint.sh` (#12420)David Robertson2022-04-081-0/+1
|
* Unify HTTP query parameter type hints (#12415)David Robertson2022-04-081-0/+1
| | | | | | * Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410
* Update the server notices user profile in room if changed. (#12115)Jorge Florian2022-04-081-0/+1
|
* CI: Get the portdb job to run under poetry (#12412)David Robertson2022-04-081-0/+1
|
* Add missing type definitions for scripts in docker folder (#12280)Jorge Florian2022-04-081-0/+1
| | | | Signed-off-by: Jorge Florian <jafn28@gmail.com>
* Fix rejecting invites over federation (#12409)Erik Johnston2022-04-071-0/+1
| | | | | Currently causes future incremental syncs to fail. Broke by #12191
* Fix fetching public rooms over federation (#12410)Erik Johnston2022-04-071-0/+1
| | | Broke by #12364
* Do not add groups to sync results if disabled. (#12408)Patrick Cloke2022-04-071-0/+1
|
* Add opentracing spans to calls to external cache (#12380)Erik Johnston2022-04-071-0/+1
|
* Poetry: use locked environment in Docker images (#12385)David Robertson2022-04-071-0/+1
|
* Support the v1 endpoint for `/relations`. (#12403)Patrick Cloke2022-04-071-0/+1
| | | | Now that MSC2675 has passed FCP and the implementation is compliant with the final version.
* Clarify that we mark as outliers because we don't have any state for them ↵Eric Eastwood2022-04-061-0/+1
| | | | | (#12345) As discussed at https://github.com/matrix-org/synapse/pull/12179#discussion_r837263852
* Update changelog to describe changes from #12370 relative to `develop` (#12401)Eric Eastwood2022-04-062-1/+1
|
* Remove docs for converting a legacy structured logging config. (#12392)Patrick Cloke2022-04-061-0/+1
| | | And update the upgrade notes to point at old versions of the documentation.
* Remove support for the unstable identifier from MSC3288. (#12398)Patrick Cloke2022-04-061-0/+1
|
* Narrow the `importlib_metadata` dependency (#12400)David Robertson2022-04-061-0/+1
|
* Fix `synapse_event_persisted_position` metric (#12390)Richard van der Hoff2022-04-061-0/+1
| | | | Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`
* Update type annotations for compatiblity with prometheus_client 0.14 (#12389)Richard van der Hoff2022-04-061-0/+1
| | | | | | | Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.
* Generate historic pagination token for `/messages` when no `?from` token ↵Eric Eastwood2022-04-061-0/+1
| | | | provided (#12370)
* Add missing dependency on importlib_metadata (#12384)David Robertson2022-04-051-0/+1
|
* Poetry: initial pyproject.toml and poetry.lock (#12381)David Robertson2022-04-051-0/+1
| | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Post 1.56.0 release tidy up (#12379)Sean Quah2022-04-052-1/+1
|
* Update mdbook to 0.4.17 (#12339)Andrew Morgan2022-04-051-0/+1
| | | Update mdbook (the tool used to render the documentation website) to version 0.4.17.
* Fix edge case where a `Linearizer` could get stuck (#12358)Sean Quah2022-04-051-0/+1
| | | | | | | Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
* Make `StreamToken` and `RoomStreamToken` methods propagate cancellations ↵Sean Quah2022-04-051-0/+1
| | | | | | | | | (#12366) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>
* Update docstrings for `ReadWriteLock` tests (#12354)Sean Quah2022-04-051-0/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Refactor and convert `Linearizer` to async (#12357)Sean Quah2022-04-051-0/+1
| | | | | | | | | | | Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
* Convert `Linearizer` tests from `inlineCallbacks` to async (#12353)Sean Quah2022-04-051-0/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Prefill more stream change caches. (#12372)Erik Johnston2022-04-051-0/+1
|
* Add type hints to some tests files (#12371)Dirk Klimpel2022-04-051-0/+1
|
* Fix a spec compliance issue where requests to the `/publicRooms` federation ↵reivilibre2022-04-051-0/+1
| | | | API would specify `limit` as a string. (#12364)
* Allow specifying the Postgres database's port when running unit tests with ↵reivilibre2022-04-051-0/+1
| | | | Postgres. (#12376)
* Merge tag 'v1.56.0rc1' into developRichard van der Hoff2022-04-0543-43/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314))
| * 1.56.0rc1Brendan Abolivier2022-03-2943-43/+0
| |
* | Explain how to decipher live and historic pagination tokens (#12317)Eric Eastwood2022-04-051-0/+1
| |
* | Update broken link in `workers.md` (#12369)Shay2022-04-041-0/+1
| |
* | Allow non-member state sent in room batch to resolve for historic events ↵Eric Eastwood2022-04-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | (MSC2716) (#12329) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.
* | Prefill the device_list_stream_cache (#12367)Erik Johnston2022-04-041-0/+1
| | | | | | | | | | | | | | * Prefill the device_list_stream_cache * Newsfile * Newsfile
* | Track device list updates per room. (#12321)Erik Johnston2022-04-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.
* | Remove more dead/broken dev scripts (#12355)David Robertson2022-04-031-0/+1
| |
* | Add type hints for `tests/unittest.py`. (#12347)Richard van der Hoff2022-04-011-0/+1
| | | | | | In particular, add type hints for get_success and friends, which are then helpful in a bunch of places.
* | Remove redundant `get_success` calls in test code (#12346)Richard van der Hoff2022-04-011-0/+1
| | | | | | There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.
* | Default to `private` room visibility rather than `public` when a client does ↵reivilibre2022-04-011-0/+1
| | | | | | | | not specify one, according to spec. (#12350)
* | Burn `check_signature` dev script. (#12351)David Robertson2022-04-012-1/+2
| |
* | Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209)Nick Mills-Barrett2022-04-011-0/+1
| | | | | | | | | | | | | | | | Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.
* | Remove `list_url_patterns` dev script (#12349)David Robertson2022-04-011-0/+1
| |
* | Move single-use methods out of `TestCase` (#12348)Richard van der Hoff2022-04-011-0/+1
| | | | | | | | These methods are only used by a single testcase, so they shouldn't be cluttering up the base `TestCase` class.
* | Move `update_client_ip` background job from the main process to the ↵reivilibre2022-04-011-0/+1
| | | | | | | | background worker. (#12251)
* | Raise an exception when getting state at an outlier (#12191)Richard van der Hoff2022-04-011-0/+1
| | | | | | | | | | | | It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.
* | Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040)Richard van der Hoff2022-04-011-0/+1
| | | | | | If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.
* | Add a module callback to react to account data changes (#12327)Brendan Abolivier2022-04-011-0/+1
| | | | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Add set_user_admin function to the module API (#12341)Amanda Graven2022-04-011-0/+1
| |
* | Move MSC2654 support behind an experimental configuration flag. (#12295)Patrick Cloke2022-03-311-0/+1
| | | | | | To match the current thinking on disabling experimental features by default.
* | Handle outliers in `/federation/v1/event` (#12332)Richard van der Hoff2022-03-311-0/+1
| | | | | | | | | | | | | | The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.
* | Add more type hints to the main state store. (#12267)Patrick Cloke2022-03-311-0/+1
| |
* | Add a callback to react to 3PID associations (#12302)Brendan Abolivier2022-03-311-0/+1
| |
* | Remove an unnecessary class from the relations code. (#12338)Patrick Cloke2022-03-311-0/+1
| | | | | | | | | | The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.
* | Remove `dockerfile-pgtests` (#12336)David Robertson2022-03-311-0/+1
| |
* | Ignore .envrc for direnv users (#12335)David Robertson2022-03-311-0/+1
| |
* | Nuke the tox `packaging` job (#12334)David Robertson2022-03-311-0/+1
| |
* | Ensure the type of URL attributes is always str when matching against ↵Brendan Abolivier2022-03-311-0/+1
| | | | | | | | preview blacklist (#12333)
* | Remove the unused and unstable `/aggregations` endpoint. (#12293)Patrick Cloke2022-03-301-0/+1
| | | | | | | | | | | | | | | | | | This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.
* | Send device list updates to application services (MSC3202) - part 1 (#11881)Andrew Morgan2022-03-301-0/+1
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Flesh out documentation for running SyTest against Synapse, including use of ↵reivilibre2022-03-301-0/+1
| | | | | | | | | | Postgres and worker mode. (#12271) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Update dead links in check-newsfragment.sh (#12331)David Robertson2022-03-301-0/+1
| |
* | Remove references to "msc2403" (#12165)Andrew Morgan2022-03-301-0/+1
| |
* | Start application service stream token tracking from 1 (#12193)Andrew Morgan2022-03-301-0/+1
| | | | | | Co-authored-by: Erik Johnston <erik@matrix.org>
* | Disable proactive sends for remote joins (#12330)Richard van der Hoff2022-03-301-0/+1
| | | | | | | | Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.
* | Add a configuration to exclude rooms from sync response (#12310)Brendan Abolivier2022-03-301-0/+1
| |
* | Fix typechecker problems exposed by signedjson 1.1.2 (#12326)David Robertson2022-03-291-0/+1
| |
* | Room batch: fix up handling of unknown prev_event_ids (#12316)Richard van der Hoff2022-03-291-0/+1
| |
* | Update `LoggingTransaction.call_after` and `call_on_exception` docstrings ↵Sean Quah2022-03-291-0/+1
| | | | | | | | | | | | | | | | (#12315) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>
* | Bump `black` and `click` versions (#12320)David Robertson2022-03-291-0/+1
|/
* Remove unused `auth_event_ids` argument plumbing (#12304)Eric Eastwood2022-03-291-0/+1
| | | | | | | | | | | | | | Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`
* Exclude outliers in `on_backfill_request` (#12314)Richard van der Hoff2022-03-281-0/+1
| | | | | | When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.
* Add some type hints to datastore. (#12255)Dirk Klimpel2022-03-281-0/+1
|
* Un-revert Jinja2 fix (#12313)Brendan Abolivier2022-03-281-0/+1
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Allow modules to store already existing 3PID associations (#12195)Brendan Abolivier2022-03-281-0/+1
|
* Improve type annotations for `execute_values`. (#12311)reivilibre2022-03-281-0/+1
|
* HAProxy guide update (#12279)villepeh2022-03-281-0/+1
| | | HAproxy reverse proxy guide update to stop sending IPv4-mapped address to HS.
* Add restrictions by default to open registration in Synapse (#12091)Shay2022-03-251-0/+1
|
* Add cache for `get_membership_from_event_ids` (#12272)Erik Johnston2022-03-251-0/+1
| | | | | This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>
* Enhance logging for inbound federation events (#12301)Richard van der Hoff2022-03-251-0/+1
| | | | It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.
* Refactor `create_new_client_event` to use a new parameter, ↵Eric Eastwood2022-03-251-0/+1
| | | | | | | `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)
* Always allow the empty string as an avatar_url. (#12261)David Robertson2022-03-251-0/+1
| | | | | Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Authentik OpenID minor doc update (#12275)IronTooch2022-03-251-0/+1
|
* Mention the new behaviour on unsafe database locale in the upgrade notes ↵Brendan Abolivier2022-03-251-0/+1
| | | | | (#12288) Co-authored-by: Shay <hillerys@element.io>
* Re-enable test concurrency on Complement (#12283)kegsay2022-03-241-0/+1
|
* Remove unused test code. (#12291)Patrick Cloke2022-03-241-0/+1
| | | | The `MockHttpResource` and `MockKey` objects were unused since #9396 (74af356baf79de5d719fad6c32b981eedbdd950d).
* Do not consider events by ignored users for relations (#12285)Patrick Cloke2022-03-245-2/+3
| | | | Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).
* Optionally include account validity in MSC3720 account status responses (#12266)Brendan Abolivier2022-03-241-0/+1
|
* Refuse to start if DB has an unsafe locale (#12262)Shay2022-03-231-0/+1
|
* Use psycopg2 type stubs (#12269)David Robertson2022-03-231-0/+1
|
* Remove mutual_rooms `update_user_directory` check, and add extra ↵Jonathan de Jong2022-03-231-0/+1
| | | | | documentation (#12038) Resolves #10339
* Allow registering admin users using the module API (#12250)Nicolas Werner2022-03-231-0/+1
| | | Signed-off-by: Nicolas Werner <n.werner@famedly.com>
* Rename shared_rooms to mutual_rooms (#12036)Jonathan de Jong2022-03-231-0/+1
| | | Co-authored-by: reivilibre <olivier@librepush.net>
* Merge branch 'master' into developAndrew Morgan2022-03-221-1/+0
|\
| * 1.55.0Andrew Morgan2022-03-222-2/+0
| |
| * Tweak copy for sso account details template (#12265)Michael Telatynski2022-03-221-0/+1
| | | | | | | | | | | | | | * Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
* | Add type hints to tests files. (#12256)Dirk Klimpel2022-03-211-0/+1
| |
* | Merge branch 'release-v1.55' into developDavid Robertson2022-03-211-0/+1
|\|
| * Reword 'Choose your user name' as 'Choose your account name' in the SSO ↵reivilibre2022-03-211-0/+1
| | | | | | | | | | | | | | | | | | registration template, in order to comply with SIWA guidelines. (#12260) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Make it possible to enable compression for the metrics HTTP resource (#12258)Nick Mills-Barrett2022-03-211-0/+1
| | | | | | | | | | | | | | | | | | | | * Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint
* | Return a 404 from `/state` for an outlier (#12087)Richard van der Hoff2022-03-211-0/+1
| | | | | | | | | | * Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier
* | Try to detect borked package installations. (#12244)David Robertson2022-03-181-0/+1
| | | | | | | | | | | | | | * Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Move get_bundled_aggregations to relations handler. (#12237)Patrick Cloke2022-03-181-0/+1
| | | | | | | | | | The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.
* | Only fetch thread participation for events with threads. (#12228)Patrick Cloke2022-03-181-0/+1
| | | | | | | | | | | | | | | | | | We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.
* | Sync more worker regexes in the documentation. (#12243)Patrick Cloke2022-03-181-0/+1
| |
* | Add some type hints to datastore (#12248)Dirk Klimpel2022-03-181-0/+1
| | | | | | | | | | * inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Correct `check_username_for_spam` annotations and docs (#12246)David Robertson2022-03-181-0/+1
| | | | | | | | | | | | | | * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Generate announcement links in release script (#12242)David Robertson2022-03-171-0/+1
| |
* | Add type hints to more tests files. (#12240)Dirk Klimpel2022-03-171-0/+1
| |
* | Merge branch 'release-v1.55' into developPatrick Cloke2022-03-1662-62/+0
|\|
| * Re-generate changelog. v1.55.0rc1Patrick Cloke2022-03-161-1/+0
| |
| * Fix bundling aggregations if unsigned is not a returned event field. (#12234)Patrick Cloke2022-03-161-0/+1
| | | | | | | | | | | | | | An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.
| * 1.55.0rc1David Robertson2022-03-1562-62/+0
| |
* | Handle cancellation in `DatabasePool.runInteraction()` (#12199)Sean Quah2022-03-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>
* | Add a relations handler to avoid duplication. (#12227)Patrick Cloke2022-03-161-0/+1
| | | | | | Adds a handler layer between the REST and datastore layers for relations.
* | Add some missing type hints to cache datastore. (#12216)Patrick Cloke2022-03-161-0/+1
| |
* | Fix dead link in spam checker warning (#12231)David Robertson2022-03-161-0/+1
| |
* | Refactor relations tests (#12232)Patrick Cloke2022-03-161-0/+1
| | | | | | | | | | * Moves the relation pagination tests to a separate class. * Move the assertion of the response code into the `_send_relation` helper. * Moves some helpers into the base-class.
* | Clean-up logic for rebasing URLs during URL preview. (#12219)Patrick Cloke2022-03-161-0/+1
| | | | | | | | By using urljoin from the standard library and reducing the number of places URLs are rebased.
* | Use the ignored_users table to test event visibility & sync. (#12225)Patrick Cloke2022-03-151-0/+1
| | | | | | | | | | Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.
* | Add tests for database transaction callbacks (#12198)Sean Quah2022-03-151-0/+1
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Add type hints to some tests/handlers files. (#12224)Dirk Klimpel2022-03-151-0/+1
|/
* Add cancellation support to `@cached` and `@cachedList` decorators (#12183)Sean Quah2022-03-141-0/+1
| | | | | | | | These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>
* Add cancellation support to `ReadWriteLock` (#12120)Sean Quah2022-03-141-0/+1
| | | | | | Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>
* Fix broken background updates when using sqlite with `enable_search` off ↵Sean Quah2022-03-141-0/+1
| | | | | (#12215) Signed-off-by: Sean Quah <seanq@element.io>
* Add `delay_cancellation` utility function (#12180)Sean Quah2022-03-141-0/+1
| | | | | | | | | `delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>
* Deprecate the groups/communities endpoints and add an experimental ↵Patrick Cloke2022-03-121-0/+1
| | | | configuration flag. (#12200)
* Add config settings for background update parameters (#11980)Shay2022-03-111-0/+1
|
* Implement a Jinja2 filter to extract localparts from email addresses (#12212)Brendan Abolivier2022-03-111-0/+1
|
* Improve code documentation for the typing stream over replication. (#12211)reivilibre2022-03-111-0/+1
|
* Add an additional HTTP pusher + push rule tests. (#12188)Nick Mills-Barrett2022-03-111-0/+1
| | | And rename the field used for caching from _id to _cache_key.
* Update the SSO username picker template to comply with SIWA guidelines (#12210)Brendan Abolivier2022-03-111-0/+1
| | | Fixes https://github.com/matrix-org/synapse/issues/12205
* Add type hints to `tests/rest`. (#12208)Dirk Klimpel2022-03-111-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add some type hints to the tests.handlers module. (#12207)Patrick Cloke2022-03-113-2/+3
|
* Remove unnecessary pass statements. (#12206)Patrick Cloke2022-03-111-0/+1
|
* Note that contributors can sign off privately (#12204)Andrew Morgan2022-03-111-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Retention test: avoid relying on state at purged events (#12202)Richard van der Hoff2022-03-111-0/+1
| | | | This test was relying on poking events which weren't in the database into filter_events_for_client.
* Document that most streams can only have a single writer. (#12196)~creme2022-03-101-0/+1
| | | | This includes the `typing`, `to_device`, `account_data`, `receipts`, and `presence` streams (really anything except the `events` stream).
* fix misleading comment in `check_events_for_spam` (#12203)Shay2022-03-101-0/+1
|
* Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir ↵reivilibre2022-03-101-0/+1
| | | | compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700)
* Support stable identifiers for MSC3440: Threading (#12151)Patrick Cloke2022-03-101-0/+1
| | | | The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.
* Updates to the Room DAG concepts development document (#12179)Richard van der Hoff2022-03-101-0/+1
| | | | Some stuff that came up while we were talking about #12173.
* Allow retrieving the relations of a redacted event. (#12130)Patrick Cloke2022-03-103-1/+2
| | | | | | | | | This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).
* Rename get_tcp_replication to get_replication_command_handler. (#12192)Patrick Cloke2022-03-101-0/+1
| | | | | | Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.
* Remove dead code in `tests/storage/test_database.py` (#12197)Sean Quah2022-03-091-0/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Add third_party module callbacks to check if a user can delete a room and ↵Will Hunt2022-03-091-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | deactivate a user (#12028) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Allow for ignoring some arguments when caching. (#12189)Patrick Cloke2022-03-091-0/+1
| | | | | * `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)
* Remove some unused variables/parameters. (#12187)Patrick Cloke2022-03-091-0/+1
|
* Retry some http replication failures (#12182)Nick Mills-Barrett2022-03-091-0/+1
| | | | | | | | This allows for the target process to be down for around a minute which provides time for restarts during synapse upgrades/config updates. Closes: #12178 Signed off by Nick Mills-Barrett nick@beeper.com
* Skip attempt to get state at backwards-extremities (#12173)Richard van der Hoff2022-03-091-0/+1
| | | | We don't *have* the state at a backwards-extremity, so this is never going to do anything useful.
* Clean-up demo scripts & documentation (#12143)Patrick Cloke2022-03-081-0/+1
| | | | | | | | | * Rewrites the demo documentation to be clearer, accurate, and moves it to our documentation tree. * Improvements to the demo scripts: * `clean.sh` now runs `stop.sh` first to avoid zombie processes. * Uses more modern Synapse configuration (and removes some obsolete configuration). * Consistently use the HTTP ports for server name, etc. * Remove the `demo/etc` directory and place everything into the `demo/808x` directories.
* Use `ParamSpec` in type hints for `synapse.logging.context` (#12150)Sean Quah2022-03-081-0/+1
| | | | Signed-off-by: Sean Quah <seanq@element.io>
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-03-084-4/+0
|\
| * 1.54.0Olivier Wilkinson (reivilibre)2022-03-085-5/+0
| |
| * Fix a bug introduced in 1.54.0rc1 which meant that Synapse would refuse to ↵reivilibre2022-03-081-0/+1
| | | | | | | | | | | | | | | | | | | | | | start if pre-release versions of dependencies were installed. (#12177) * Add failing test to characterise the regression #12176 * Permit pre-release versions of specified packages * Newsfile (bugfix) Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Fix CI not attaching source distributions and wheels to the GitHub releases. ↵reivilibre2022-03-081-0/+1
| | | | | | | | (#12131)
* | Add experimental environment variable to enable asyncio reactor (#12135)Erik Johnston2022-03-081-0/+1
| |
* | Do not return allowed_room_ids from /hierarchy response. (#12175)Patrick Cloke2022-03-081-0/+1
| | | | | | | | | | This field is only to be used in the Server-Server API, and not the Client-Server API, but was being leaked when a federation response was used in the /hierarchy API.
* | Fix incorrect type hints for txredis. (#12042)Patrick Cloke2022-03-081-0/+1
| | | | | | | | Some properties were marked as RedisProtocol instead of ConnectionHandler, which wraps RedisProtocol instance(s).
* | Fix a bug in background updates wherein background updates are never run ↵Shay2022-03-071-0/+1
| | | | | | | | using the default batch size (#12157)
* | Invalidate caches when an event with a relation is redacted. (#12121)Patrick Cloke2022-03-073-1/+2
| | | | | | | | | | The caches for the target of the relation must be cleared so that the bundled aggregations are re-calculated after the redaction is processed.
* | Switch the `tests-done` job to an Action (#12161)Richard van der Hoff2022-03-071-0/+1
| | | | | | | | I've factored it out for easier use in other workflows.
* | Merge remote-tracking branch 'origin/release-v1.54' into developRichard van der Hoff2022-03-044-0/+4
|\|
| * Relax version guard for packaging (#12166)David Robertson2022-03-041-0/+1
| | | | | | | | | | | | | | It’s just occurred to me that #12088 pulled in the “packaging” package (~=21.3). I pulled in the newest version I had at the time. I only use it for packaging.requirements.Requirements. Which was added in packaging 16.1: https://github.com/pypa/packaging/releases/tag/16.1 https://pkgs.org/download/python3-packaging suggests that the oldest version we care about is 17.1 in Ubuntu Bionic. So I think with this bound we're hunky dory.
| * Don't impose version checks on dev extras at runtime (#12129)David Robertson2022-03-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix incorrect argument in test case * Add copyright header * Docstring and __all__ * Exclude dev depenencies * Use changelog from #12088 * Include version in error messages This will hopefully distinguish between the version of the source code and the version of the distribution package that is installed. * Linter script is your friend
| * Correctly register deactivation and profile update module callbacks (#12141)Brendan Abolivier2022-03-031-0/+1
| |
| * Make release script write correct no-op changelog (#12127)Erik Johnston2022-03-021-0/+1
| | | | | | | | As we want to include the previous version in the "No new changes..." string.
* | Reduce to-device queries for /sync. (#12163)Erik Johnston2022-03-041-0/+1
| |
* | Add type hints for `ObservableDeferred` attributes (#12159)Sean Quah2022-03-041-0/+1
| | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Add test for `ObservableDeferred`'s cancellation behaviour (#12149)Sean Quah2022-03-041-0/+1
| | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Remove backwards compatibility with RelationPaginationToken. (#12138)Patrick Cloke2022-03-041-0/+1
| |
* | Changelog (#12153)David Robertson2022-03-041-0/+1
| |
* | Move synctl into `synapse._scripts` and expose as an entrypoint (#12140)David Robertson2022-03-041-0/+1
| |
* | Spread out sending device lists to remote hosts (#12132)Erik Johnston2022-03-041-0/+1
| |
* | Update client-visibility filtering for outlier events (#12155)Richard van der Hoff2022-03-041-0/+1
| | | | | | Avoid trying to get the state for outliers, which isn't a sensible thing to do.
* | Fix type of `events` in `StateGroupStorage` and `StateHandler` (#12156)Richard van der Hoff2022-03-041-0/+1
| | | | | | We make multiple passes over this, so a regular iterable won't do.
* | Avoid generating state groups for local out-of-band leaves (#12154)Richard van der Hoff2022-03-031-0/+1
| | | | | | | | | | | | | | | | | | If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.
* | Rename various ApplicationServices interested methods (#11915)Andrew Morgan2022-03-031-0/+1
| |
* | Detox, part 2 of N (#12152)David Robertson2022-03-031-0/+1
| | | | | | | | | | | | I've argued in #11537 that poetry and tox don't cooperate well at the moment. (See also #12119.) Therefore I'm pruning away bits of tox to make the transition to poetry easier. This change removes the commands for coverage. We don't use coverage in anger at the moment. It shouldn't be too hard to add coverage as a dev-dependency and reintroduce this if we really want it.
* | Add type hints to `tests/rest` (#12146)Dirk Klimpel2022-03-031-0/+1
| | | | | | | | | | | | | | * Add type hints to `tests/rest` * newsfile * change import from `SigningKey`
* | Use the proper serialization format when bundling aggregations. (#12090)Patrick Cloke2022-03-031-0/+1
| | | | | | | | This ensures that the `latest_event` field of the bundled aggregation for threads uses the same format as the other events in the response.
* | Enable MSC2716 Complement tests in Synapse (#12145)Eric Eastwood2022-03-031-0/+1
| | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Limit the size of the aggregation_key (#12101)Erik Johnston2022-03-031-0/+1
| | | | | | There's no reason to let people use long keys.
* | Enable MSC3030 Complement tests in Synapse (#12144)Eric Eastwood2022-03-031-0/+1
| | | | | | | | | | The Complement tests for MSC3030 are now merged, https://github.com/matrix-org/complement/pull/178 Synapse implmentation: https://github.com/matrix-org/synapse/pull/9445
* | Move the `snapcraft` configuration to `contrib`. (#12142)David Robertson2022-03-021-0/+1
| | | | | | | | | | | | | | | | | | * Move the `snapcraft` configuration to `contrib`. We're happy for people to package this as a snap image if it's useful, but we don't support or maintain it. I'd like to move the config to `contrib` to reflect this state of affairs. * Changelog
* | Add suffices to scripts in scripts-dev (#12137)David Robertson2022-03-021-0/+1
| | | | | | | | | | | | | | | | | | * Rename scripts-dev to have suffices * Update references to `scripts-dev` * Changelog * These scripts don't pass mypy
* | Remove unused mocks from `test_typing` (#12136)David Robertson2022-03-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | * Remove unused mocks from `test_typing` It's not clear what these do. `get_user_by_access_token` has the wrong signature, including the return type. Tests all pass without these. I think we should nuke them. * Changelog * Fixup imports
* | Add type hints to `tests/rest/client` (#12108)Dirk Klimpel2022-03-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add type hints to `tests/rest/client` * newsfile * fix imports * add `test_account.py` * Remove one type hint in `test_report_event.py` * change `on_create_room` to `async` * update new functions in `test_third_party_rules.py` * Add `test_filter.py` * add `test_rooms.py` * change to `assertEquals` to `assertEqual` * lint
* | Enable complexity checking in complexity checking docs example (#11998)Andrew Morgan2022-03-021-0/+1
| |
* | Merge tag 'v1.54.0rc1' into developOlivier Wilkinson (reivilibre)2022-03-0271-71/+0
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119))
| * 1.54.0rc1Olivier Wilkinson (reivilibre)2022-03-0271-71/+0
| |
* | Check if instances are lists, not sequences. (#12128)Patrick Cloke2022-03-021-0/+1
| | | | | | | | | | As a str is a sequence, the checks were not granular enough and would allow lists or strings, when only lists were valid.
* | Move scripts directory inside synapse, exposing as setuptools entry_points ↵David Robertson2022-03-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | (#12118) * Two scripts are basically entry_points already * Move and rename scripts/* to synapse/_scripts/*.py * Delete sync_room_to_group.pl * Expose entry points in setup.py * Update linter script and config * Fixup scripts & docs mentioning scripts that moved Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Improve and refactor the tests for relations. (#12113)Patrick Cloke2022-03-021-0/+1
|/ | | | | | * Modernizes code (f-strings, etc.) * Fixes incorrect comments. * Splits the test case into two. * Factors out some duplicated code.
* Remove misleading newsfile from #12126 which backs out an unreleased change.Olivier Wilkinson (reivilibre)2022-03-021-1/+0
|
* Back out in-flight state caching changes. (#12126)reivilibre2022-03-025-4/+1
|
* Make get_room_version use cached get_room_version_id. (#11808)lukasdenk2022-03-021-0/+1
|
* Detox, part 1 of N (#12119)David Robertson2022-03-011-0/+1
| | | | * Don't use `tox` for `check-sampleconfig` * Don't use `tox` for check-newsfragment
* Use importlib.metadata to read requirements (#12088)David Robertson2022-03-011-0/+1
| | | | | | | | | | | | | | | | | | * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases
* Fix rare error in `ReadWriteLock` when writers complete immediately (#12105)Sean Quah2022-03-011-0/+1
| | | | Signed-off-by: Sean Quah <seanq@element.io>
* Add module callbacks called for reacting to deactivation status change and ↵Brendan Abolivier2022-03-011-0/+1
| | | | profile update (#12062)
* Use Python 3.9 in Synapse dockerfiles by default (#12112)Andrew Morgan2022-03-011-0/+1
|
* Add `stop_cancellation` utility function (#12106)Sean Quah2022-03-011-0/+1
|
* Order in-flight state group queries in biggest-first order (#11610)reivilibre2022-03-011-0/+1
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Faster joins: persist to database (#12012)Richard van der Hoff2022-03-011-0/+1
| | | | | | | | | | | | When we get a partial_state response from send_join, store information in the database about it: * store a record about the room as a whole having partial state, and stash the list of member servers too. * flag the join event itself as having partial state * also, for any new events whose prev-events are partial-stated, note that they will *also* be partial-stated. We don't yet make any attempt to interpret this data, so API calls (and a bunch of other things) are just going to get incorrect data.
* Advertise Python 3.10 support in setup.py (#12111)Andrew Morgan2022-03-011-0/+1
|
* Fix 'Unhandled error in Deferred' (#12089)Richard van der Hoff2022-03-011-0/+1
| | | | | | | | | | | | | * Fix 'Unhandled error in Deferred' Fixes a CRITICAL "Unhandled error in Deferred" log message which happened when a function wrapped with `@cachedList` failed * Minor optimisation to cachedListDescriptor we can avoid re-using `missing`, which saves looking up entries in `deferreds_map`, and means we don't need to copy it. * Improve type annotation on CachedListDescriptor
* Improve exception handling for concurrent execution (#12109)Richard van der Hoff2022-03-011-0/+1
| | | | | | | | | | | | | | | * fix incorrect unwrapFirstError import this was being imported from the wrong place * Refactor `concurrently_execute` to use `yieldable_gather_results` * Improve exception handling in `yieldable_gather_results` Try to avoid swallowing so many stack traces. * mark unwrapFirstError deprecated * changelog
* Add type hints to `tests/rest/client` (#12094)Dirk Klimpel2022-02-281-0/+1
| | | | | | | | | * Add type hints to `tests/rest/client` * update `mypy.ini` * newsfile * add `test_register.py`
* Remove the unstable `/spaces` endpoint. (#12073)Patrick Cloke2022-02-281-0/+1
| | | | | | | | ...and various code supporting it. The /spaces endpoint was from an old version of MSC2946 and included both a Client-Server and Server-Server API. Note that the unstable /hierarchy endpoint (from the final version of MSC2946) is not yet removed.
* Move experimental support for MSC3440 to /versions. (#12099)Patrick Cloke2022-02-281-0/+1
| | | | Instead of being part of /capabilities, this matches a change to MSC3440 to properly use these endpoints.
* Add type hints to `tests/rest/client` (#12084)Dirk Klimpel2022-02-281-0/+1
|
* Fix `PushRuleEvaluator` and `Filter` to work on frozendicts (#12100)Richard van der Hoff2022-02-281-0/+1
| | | | | | | | | | * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.
* Actually fix bad debug logging rejecting device list & signing key ↵David Robertson2022-02-281-0/+1
| | | | transactions (#12098)
* Properly failover for unknown endpoints from Conduit/Dendrite. (#12077)Patrick Cloke2022-02-281-0/+1
| | | | | Before this fix, a legitimate 404 from a federation endpoint (e.g. due to an unknown room) would be treated as an unknown endpoint. This could cause unnecessary federation traffic.
* Replace assertEquals and friends with non-deprecated versions. (#12092)Patrick Cloke2022-02-281-0/+1
|
* synctl: print warning if synctl_cache_factor is set in config (#11865)lukasdenk2022-02-281-0/+1
| | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Ensure that `get_datastores().main` is typed (#12070)Sean Quah2022-02-251-0/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Minor typing fixes for `synapse/storage/persist_events.py` (#12069)Sean Quah2022-02-251-0/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Add type hints to `tests/rest/client` (#12072)Dirk Klimpel2022-02-241-0/+1
|
* Add support for MSC3202: sending one-time key counts and fallback key usage ↵reivilibre2022-02-241-0/+1
| | | | | states to Application Services. (#11617) Co-authored-by: Erik Johnston <erik@matrix.org>
* Fix non-strings in the `event_search` table (#12037)Sean Quah2022-02-241-0/+1
| | | | | | | Don't attempt to add non-string `value`s to `event_search` and add a background update to clear out bad rows from `event_search` when using sqlite. Signed-off-by: Sean Quah <seanq@element.io>
* Add documentation for missing worker types. (#11599)Patrick Cloke2022-02-231-0/+1
| | | And clean-up the endpoints which should be routed to workers.
* Add logging to `/sync` for debugging #11916 (#12068)Erik Johnston2022-02-231-0/+1
|
* Add type hints to `tests/rest/client` (#12066)Dirk Klimpel2022-02-231-0/+1
|
* Remove more references to `get_datastore` (#12067)Richard van der Hoff2022-02-231-0/+1
| | | | | These have snuck in since #12031 was started. Also a couple of other cleanups while we're in the area.
* Remove `HomeServer.get_datastore()` (#12031)Richard van der Hoff2022-02-231-0/+1
| | | | | | | The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733
* Rename default branch of complement.sh to main (#12063)Nicolas Werner2022-02-231-0/+1
| | | | | | | The complement.sh script relies on the name of the ref matching the name of the unpacked folder. The branch redirect from renaming the default branch breaks that assumption. Signed-off-by: Nicolas Werner <n.werner@famedly.com>
* Remove excess condition on `knock->leave` check (#11900)Travis Ralston2022-02-221-0/+1
|
* Better error message when failing to request from another process (#12060)Erik Johnston2022-02-221-0/+1
|
* Implement account status endpoints (MSC3720) (#12001)Brendan Abolivier2022-02-221-0/+1
| | | | | See matrix-org/matrix-doc#3720 Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Prune setup.cfg some more (#12059)David Robertson2022-02-222-1/+2
| | | | | | | | | | * Remove `trial` section from setup.cfg This was added in the initial commit from 2014. I can't see that it does anything. Maybe it's there so that you can run `trial` without any extra args, but if I do that then I just get the `--help` message. * Move flake8's config to its own file
* Cap the number of in-flight requests for state from a single group (#11608)reivilibre2022-02-221-0/+1
|
* Use room version 9 as the default room version (per MSC3589). (#12058)Patrick Cloke2022-02-221-0/+1
|
* Run `_handle_queued_pdus` as a background process (#12041)Richard van der Hoff2022-02-221-0/+1
| | | ... to ensure it gets a proper log context, mostly.
* Fix slow performance of `/logout` in some cases where refresh tokens are in ↵reivilibre2022-02-221-0/+1
| | | | use. The slowness existed since the initial implementation of refresh tokens. (#12056)
* Faster joins: Support for calling `/federation/v1/state` (#12013)Richard van der Hoff2022-02-221-0/+1
| | | | This is an endpoint that we have server-side support for, but no client-side support. It's going to be useful for resyncing partial-stated rooms, so let's introduce it.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-24 21:46:22 +0000