summary refs log tree commit diff
path: root/changelog.d (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Convert sending mail to async/await. (#7557)Erik Johnston2020-05-221-0/+1
| | | | Mainly because sometimes the email push code raises exceptions where the stack traces have gotten lost, which is hopefully fixed by this.
* Use a non-empty RelayState for user interactive auth with SAML. (#7552)Patrick Cloke2020-05-221-0/+1
|
* On upgrade room only send canonical alias once. (#7547)Erik Johnston2020-05-221-0/+1
| | | | | | | | Instead of doing a complicated dance of deleting and moving aliases one by one, which sends a canonical alias update into the old room for each one, lets do it all in one go. This also changes the function to move *all* local alias events to the new room, however that happens later on anyway.
* Fix exception reporting due to HTTP request errors. (#7556)Erik Johnston2020-05-221-0/+1
| | | | These are business as usual errors, rather than stuff we want to log at error.
* synapse.metrics: implement detailed memory usage reporting on PyPy (#7536)Ivan Shapovalov2020-05-221-0/+1
| | | | | | PyPy's gc.get_stats() returns an object containing detailed allocator statistics which could be beneficial to collect as metrics. Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
* Refresh apt cache when building dh_virtualenv docker image (#7555)Richard van der Hoff2020-05-221-0/+1
| | | | | | When we tried to build debs for 1.13.0, the build failed because docker used a base docker image which had a stale apt cache. Fixes: #7540
* Fix stacktrace mangling in `patch_inline_callbacks` (#7554)Richard van der Hoff2020-05-221-0/+1
| | | `Failure()` is more cunning than `Failure(e)`.
* mypy for synapse.http.site (#7553)Richard van der Hoff2020-05-221-0/+1
|
* Fix some DETECTED VIOLATIONS in the config file (#7550)Richard van der Hoff2020-05-221-0/+1
| | | consistency ftw
* Retry to sync out of sync device lists (#7453)Brendan Abolivier2020-05-211-0/+1
| | | | | | | | | | | When a call to `user_device_resync` fails, we don't currently mark the remote user's device list as out of sync, nor do we retry to sync it. https://github.com/matrix-org/synapse/pull/6776 introduced some code infrastructure to mark device lists as stale/out of sync. This commit uses that code infrastructure to mark device lists as out of sync if processing an incoming device list update makes the device handler realise that the device list is out of sync, but we can't resync right now. It also adds a looping call to retry all failed resync every 30s. This shouldn't cause too much spam in the logs as this commit also removes the "Failed to handle device list update for..." warning logs when catching `NotRetryingDestination`. Fixes #7418
* Stub out GET presence requests in the frontend proxy (#7545)Richard van der Hoff2020-05-211-0/+1
| | | | | We don't really make any promises about returning accurate presence data when presence is disabled, so we may as well just return a static response, rather than making the master handle a request.
* Ensure worker config exists in systemd service (#7528)David Vo2020-05-211-0/+1
|
* Fix bug in persist events when dealing with non member types. (#7548)Erik Johnston2020-05-211-0/+1
| | | | | `_is_server_still_joined` will throw if it is given state updates with non-user ID state keys with local user leaves. This is actually rarely a problem since local leaves almost always get persisted by themselves. (I discovered this on a branch that was otherwise broken, so I haven't seen this in the wild)
* Remove Ubuntu Cosmic and Disco which are both EOL. (#7539)Patrick Cloke2020-05-201-0/+1
|
* Hash passwords earlier in the password reset process (#7538)Patrick Cloke2020-05-201-0/+1
| | | | This now matches the logic of the registration process as modified in 56db0b1365965c02ff539193e26c333b7f70d101 / #7523.
* Minor clarifications to the TURN docs (#7533)Richard van der Hoff2020-05-201-0/+1
|
* synctl warns when no process is stopped and avoids start (#6598)Romain Bouyé2020-05-191-0/+1
| | | | | | * If an error occurs when stopping a process synctl now logs a warning. * During a restart, synctl will avoid attempting to start Synapse if an error occurs during stopping Synapse.
* Omit displayname or avatar_url if they aren't set instead of returning null ↵Aaron Raimist2020-05-191-0/+1
| | | | | | | | | (#7497) Per https://github.com/matrix-org/matrix-doc/issues/1436#issuecomment-410089470 they should be omitted instead of returning null or "". They aren't marked as required in the spec. Fixes https://github.com/matrix-org/synapse/issues/7333 Signed-off-by: Aaron Raimist <aaron@raim.ist>
* Allow ReplicationRestResource to be added to workers (#7515)Erik Johnston2020-05-181-0/+1
| | | This allows workers to talk to each other over HTTP replication.
* Merge pull request #7519 from matrix-org/rav/kill_py2_codeRichard van der Hoff2020-05-181-0/+1
|\ | | | | Kill off some old python 2 code
| * changelogRichard van der Hoff2020-05-151-0/+1
| |
* | fix mypy for tests/replication (#7518)Richard van der Hoff2020-05-181-0/+1
| |
* | Add type hints to room member handlers (#7513)Patrick Cloke2020-05-151-0/+1
| |
* | Fix limit logic for AccountDataStream (#7384)Richard van der Hoff2020-05-151-0/+1
| | | | | | | | | | | | Make sure that the AccountDataStream presents complete updates, in the right order. This is much the same fix as #7337 and #7358, but applied to a different stream.
* | Support UI Authentication for OpenID Connect accounts (#7457)Patrick Cloke2020-05-151-0/+1
| |
* | Add a worker store for search insertion. (#7516)Erik Johnston2020-05-151-0/+1
| | | | | | | | | | This is required as both event persistence and the background update needs access to this function. It should be perfectly safe for two workers to write to that table at the same time.
* | Prevent 0-member/null room_version rooms from appearing in group room ↵Andrew Morgan2020-05-151-0/+1
| | | | | | | | queries (#7465)
* | Move event stream handling out of slave store. (#7491)Erik Johnston2020-05-151-0/+1
| | | | | | | | | | This allows us to have the logic on both master and workers, which is necessary to move event persistence off master. We also combine the instantiation of ID generators from DataStore and slave stores to the base worker stores. This allows us to select which process writes events independently of the master/worker splits.
* | Add type hints to event_auth code. (#7505)Patrick Cloke2020-05-151-0/+1
| |
* | Fix a small typo in the arguments of simple_update in ↵Andrew Morgan2020-05-151-0/+1
| | | | | | | | update_remote_profile_cache (#7511)
* | Formatting for reverse-proxy docs (#7514)Richard van der Hoff2020-05-151-0/+1
|/ | | also a small clarification to nginx
* Add Caddy 2 example (#7463)Jeff Peeler2020-05-151-0/+1
| | | | | | | | | | The specific headers that are passed using this new configuration format are Host and X-Forwarded-For, which should be all that's required. Note that for production another matcher should be added in the first section to properly handle the base_url lookup: reverse_proxy /.well-known/matrix/* http://localhost:8008 Signed-off-by: Jeff Peeler <jpeeler@gmail.com>
* Update the room member handler to use async/await. (#7507)Patrick Cloke2020-05-151-0/+1
|
* Implement room version 6 (MSC2240). (#7506)Patrick Cloke2020-05-151-0/+1
|
* Ignore incoming presence updates when presence is disabled (#7508)Andrew Morgan2020-05-151-0/+1
|
* Strictly enforce canonicaljson requirements in a new room version (#7381)Patrick Cloke2020-05-141-0/+1
|
* Enforce MSC2209: auth rules for notifications in power level event (#7502)Patrick Cloke2020-05-141-0/+1
| | | | In a new room version, the "notifications" key of power level events are subject to restricted auth rules.
* Workaround for failure to wrap reason in Failure (#7473)Andrew Morgan2020-05-141-0/+1
|
* Fix b'GET' in prometheus metrics (#7503)Richard van der Hoff2020-05-141-0/+1
|
* Allow expired accounts to logout (#7443)Andrew Morgan2020-05-141-0/+1
|
* Move EventStream handling into default ReplicationDataHandler (#7493)Erik Johnston2020-05-141-0/+1
| | | This is so that the logic can happen on both master and workers when we move event persistence out.
* Add `instance_map` config and route replication calls (#7495)Erik Johnston2020-05-141-0/+1
|
* Allow censoring of events to happen on workers. (#7492)Erik Johnston2020-05-131-0/+1
| | | This is safe as we can now write to cache invalidation stream on workers, and is required for when we move event persistence off master.
* Fix copypasted comment (#7477)Paul Tötterman2020-05-131-0/+1
| | | Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
* Clean up replication unit tests. (#7490)Erik Johnston2020-05-131-0/+1
|
* Shuffle persist event data store functions. (#7440)Erik Johnston2020-05-131-0/+1
| | | | | | | | | | The aim here is to get to a stage where we have a `PersistEventStore` that holds all the write methods used during event persistence, so that we can take that class out of the `DataStore` mixin and instansiate it separately. This will allow us to instansiate it on processes other than master, while also ensuring it is only available on processes that are configured to write to events stream. This is a bit of an architectural change, where we end up with multiple classes per data store (rather than one per data store we have now). We end up having: 1. Storage classes that provide high level APIs that can talk to multiple data stores. 2. Data store modules that consist of classes that must point at the same database instance. 3. Classes in a data store that can be instantiated on processes depending on config.
* Have all instances correctly respond to REPLICATE command. (#7475)Erik Johnston2020-05-131-0/+1
| | | | | Before all streams were only written to from master, so only master needed to respond to `REPLICATE` commands. Before all instances wrote to the cache invalidation stream, but didn't respond to `REPLICATE`. This was a bug, which could lead to missed rows from cache invalidation stream if an instance is restarted, however all the caches would be empty in that case so it wasn't a problem.
* Fix Redis reconnection logic (#7482)Erik Johnston2020-05-131-0/+1
| | | Proactively send out `POSITION` commands (as if we had just received a `REPLICATE`) when we connect to Redis. This is important as other instances won't notice we've connected to issue a `REPLICATE` command (unlike for direct TCP connections). This is only currently an issue if master process reconnects without restarting (if it restarts then it won't have written anything and so other instances probably won't have missed anything).
* Update documentation about SSO mapping providers (#7458)Patrick Cloke2020-05-121-0/+1
|
* Fix new flake8 errors (#7470)Erik Johnston2020-05-121-0/+1
|
* Convert federation handler to async/await. (#7459)Patrick Cloke2020-05-111-0/+1
|
* Convert search code to async/await. (#7460)Patrick Cloke2020-05-111-0/+1
|
* Allow configuration of Synapse's cache without using synctl or environment ↵Amber Brown2020-05-111-0/+1
| | | | variables (#6391)
* Remove unused store method get_hosts_in_room (#7448)Andrew Morgan2020-05-111-0/+1
|
* Merge branch 'release-v1.13.0' into developAndrew Morgan2020-05-11138-138/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * release-v1.13.0: Don't UPGRADE database rows RST indenting Put rollback instructions in upgrade notes Fix changelog typo Oh yeah, RST Absolute URL it is then Fix upgrade notes link Provide summary of upgrade issues in changelog. Fix ) Move next version notes from changelog to upgrade notes Changelog fixes 1.13.0rc1 Documentation on setting up redis (#7446) Rework UI Auth session validation for registration (#7455) Fix errors from malformed log line (#7454) Drop support for redis.dbid (#7450)
| * 1.13.0rc1Andrew Morgan2020-05-11142-142/+0
| |
| * Documentation on setting up redis (#7446)Neil Johnson2020-05-111-0/+1
| |
| * Rework UI Auth session validation for registration (#7455)Patrick Cloke2020-05-081-0/+1
| | | | | | | | Be less strict about validation of UI authentication sessions during registration to match client expecations.
| * Fix errors from malformed log line (#7454)Richard van der Hoff2020-05-071-0/+1
| |
| * Drop support for redis.dbid (#7450)Richard van der Hoff2020-05-071-0/+1
| | | | | | Since we only use pubsub, the dbid is irrelevant.
* | Extend spam checker to allow for multiple modules (#7435)Andrew Morgan2020-05-081-0/+1
| |
* | Implement OpenID Connect-based login (#7256)Quentin Gliech2020-05-081-0/+1
| |
* | Add room details admin endpoint (#7317)Manuel Stahl2020-05-071-0/+1
| |
* | Merge branch 'release-v1.13.0' into developBrendan Abolivier2020-05-074-0/+4
|\|
| * Add a configuration setting for the dummy event threshold (#7422)Brendan Abolivier2020-05-071-0/+1
| | | | | | Add dummy_events_threshold which allows configuring the number of forward extremities a room needs for Synapse to send forward extremities in it.
| * Improve per-block CPU and DB usage metrics (#7426)Patrick Cloke2020-05-061-0/+1
| |
| * Port group attestation renewal slow down from matrix-org-hotfixes (#7442)Andrew Morgan2020-05-061-0/+1
| |
| * Make redis go faster with hiredis (#7439)Richard van der Hoff2020-05-061-0/+1
| | | | | | | | | | For the record, the reason we need this is as follows: each RDATA command comes down the redis pipe as a subscription message. txredisapi as written needs at least three reactor ticks to read each subscription message from the tcp buffer. Hence, once the process gets loaded, it starts getting behind, and eventually redis knifes the connection. it then takes ages for the master to work its way through the backlog, before it reconnects again, during which any commands from any workers are dropped.
* | Fixes typo (bellow -> below) (#7449)Patrick Cloke2020-05-071-0/+1
| |
* | Add more type hints to SAML handler. (#7445)Patrick Cloke2020-05-071-0/+1
| |
* | Support any process writing to cache invalidation stream. (#7436)Erik Johnston2020-05-071-0/+1
| |
* | Merge pull request #7398 from Starbix/alpine-3.11Brendan Abolivier2020-05-071-0/+1
|\ \ | | | | | | Update docker runtime image to Alpine v3.11
| * | Update runtime docker image to Alpine v3.11Cédric Laubacher2020-05-031-0/+1
| | |
* | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-063-0/+3
|\ \ \ | | |/ | |/|
| * | Stop Auth methods from polling the config on every req. (#7420)Andrew Morgan2020-05-061-0/+1
| | |
| * | Merge pull request #7423 from matrix-org/erikj/faster_device_lists_fetchErik Johnston2020-05-061-0/+1
| |\ \ | | | | | | | | Speed up fetching device lists changes in sync.
| | * \ Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-0511-0/+11
| | |\ \
| | * | | Update changelog.d/7423.miscRichard van der Hoff2020-05-051-1/+1
| | | | |
| | * | | NewsfileErik Johnston2020-05-051-0/+1
| | | | |
| * | | | Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-051-0/+1
| |\ \ \ \
| * \ \ \ \ Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-0511-0/+11
| |\ \ \ \ \ | | | |_|/ / | | |/| | |
| * | | | | changelogRichard van der Hoff2020-05-051-0/+1
| | |_|/ / | |/| | |
* | | | | Merge pull request #7428 from matrix-org/rav/cross_signing_keys_cacheRichard van der Hoff2020-05-061-0/+1
|\ \ \ \ \ | | | | | | | | | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulk
| * | | | | Make get_e2e_cross_signing_key delegate to get_e2e_cross_signing_keys_bulkRichard van der Hoff2020-05-061-0/+1
| | |_|/ / | |/| | | | | | | | | | | | | ... mostly because the latter has a cache.
* | | | | Merge branch 'release-v1.13.0' into developRichard van der Hoff2020-05-063-0/+3
|\| | | |
| * | | | Move logs about discarded RDATA to debug (#7421)Brendan Abolivier2020-05-051-0/+1
| | |/ / | |/| |
| * | | Add backwards compatibility codepath to LoggingContext. (#7408)Patrick Cloke2020-05-051-0/+1
| | | |
| * | | Fix bug in EventContext.deserialize. (#7393)Erik Johnston2020-05-051-0/+1
| | | | | | | | | | | | | | | | This caused `prev_state_ids` to be incorrect if the state event was not replacing an existing state entry.
* | | | Merge branch 'develop' into rav/upsert_for_device_listRichard van der Hoff2020-05-0614-1/+14
|\ \ \ \
| * | | | Fix typing annotations in synapse/federation (#7382)Richard van der Hoff2020-05-052-1/+2
| | | | | | | | | | | | | | | | | | | | We're pretty close to having mypy working for `synapse.federation`, so let's finish the job.
| * | | | Fix catchup-on-reconnect for the Federation Stream (#7374)Richard van der Hoff2020-05-051-0/+1
| | | | | | | | | | | | | | | | | | | | looks like we managed to break this during the refactorathon.
| * | | | Add MultiWriterIdGenerator. (#7281)Erik Johnston2020-05-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will be used to coordinate stream IDs across multiple writers. Functions as the equivalent of both `StreamIdGenerator` and `SlavedIdTracker`.
| * | | | Merge branch 'release-v1.13.0' into developBrendan Abolivier2020-05-042-0/+2
| |\| | |
| | * | | Merge pull request #7404 from matrix-org/babolivier/fix_manifestBrendan Abolivier2020-05-041-0/+1
| | |\ \ \ | | | | | | | | | | | | Fix MANIFEST.in
| | | * | | Fix MANIFEST.inBrendan Abolivier2020-05-041-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An update of check-manifest shone some light on some issues with MANIFEST.in, specifically that we didn't ignore/prune the contrib directory, and that we were using prune instead of exclude for files. This fixes both issues. Fixes #7403
| | * | | | Fix redis password support. (#7401)Erik Johnston2020-05-041-0/+1
| | | |_|/ | | |/| | | | | | | | | | | | | | | | | We forgot to set the password on the subscriber connection, as well as not calling super methods for overridden connectionMade/connectionLost functions.
| * / | | Convert the room handler to async/await. (#7396)Patrick Cloke2020-05-041-0/+1
| |/ / /
| * | | Convert synapse.server_notices to async/await. (#7394)Patrick Cloke2020-05-011-0/+1
| | | |
| * | | Convert the synapse.notifier module to async/await. (#7395)Patrick Cloke2020-05-011-0/+1
| | | |
| * | | Wait for current_state_events_membership before populate_stats_process_rooms ↵Richard van der Hoff2020-05-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7387) populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0. Fixes #7380.
| * | | Thread through instance name to replication client. (#7369)Erik Johnston2020-05-011-0/+1
| |/ / | | | | | | For in memory streams when fetching updates on workers we need to query the source of the stream, which currently is hard coded to be master. This PR threads through the source instance we received via `POSITION` through to the update function in each stream, which can then be passed to the replication client for in memory streams.
| * | Use `stream.current_token()` and remove `stream_positions()` (#7172)Erik Johnston2020-05-011-0/+1
| | | | | | | | | | | | We move the processing of typing and federation replication traffic into their handlers so that `Stream.current_token()` points to a valid token. This allows us to remove `get_streams_to_replicate()` and `stream_positions()`.
| * | async/await is_server_admin (#7363)Andrew Morgan2020-05-011-0/+1
| | |
| * | Further improvements to requesting the public rooms list on a homeserver ↵Andrew Morgan2020-05-011-0/+1
| |/ | | | | | | which has it set to private (#7368)
* / use an upsert to update device_lists_outbound_last_successRichard van der Hoff2020-05-061-0/+1
|/
* Workaround for assertion errors from db_query_to_update_function (#7378)Richard van der Hoff2020-05-011-0/+1
| | | Hopefully this is no worse than what we have on master...
* Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-301-0/+1
| | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
* Apply federation check for /publicRooms with filter list (#7367)Andrew Morgan2020-04-301-0/+1
|
* Add instance name to RDATA/POSITION commands (#7364)Erik Johnston2020-04-291-0/+1
| | | | | This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.
* Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352)Erik Johnston2020-04-291-0/+1
| | | | | | | | | | | | | | For direct TCP connections we need the master to relay REMOTE_SERVER_UP commands to the other connections so that all instances get notified about it. The old implementation just relayed to all connections, assuming that sending back to the original sender of the command was safe. This is not true for redis, where commands sent get echoed back to the sender, which was causing master to effectively infinite loop sending and then re-receiving REMOTE_SERVER_UP commands that it sent. The fix is to ensure that we only relay to *other* connections and not to the connection we received the notification from. Fixes #7334.
* Fix limit logic for EventsStream (#7358)Richard van der Hoff2020-04-291-0/+1
| | | | | | | | | | | | | | | | | | | * Factor out functions for injecting events into database I want to add some more flexibility to the tools for injecting events into the database, and I don't want to clutter up HomeserverTestCase with them, so let's factor them out to a new file. * Rework TestReplicationDataHandler This wasn't very easy to work with: the mock wrapping was largely superfluous, and it's useful to be able to inspect the received rows, and clear out the received list. * Fix AssertionErrors being thrown by EventsStream Part of the problem was that there was an off-by-one error in the assertion, but also the limit logic was too simple. Fix it all up and add some tests.
* Fix fallback value for account_threepid_delegates.email (#7316)Andrew Morgan2020-04-291-0/+1
|
* Clean up admin api docs (#7361)Andrew Morgan2020-04-281-0/+1
|
* Return total number of users and profile attributes in admin users endpoint ↵Manuel Stahl2020-04-281-0/+1
| | | | | (#6881) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Add some replication tests (#7278)Erik Johnston2020-04-281-0/+1
| | | | | | | Specifically some tests for the typing stream, which means we test streams that fetch missing updates via HTTP (rather than via the DB). We also shuffle things around a bit so that we create two separate `HomeServer` objects, rather than trying to insert a slaved store into places. Note: `test_typing.py` is heavily inspired by `test_receipts.py`
* Fix collation for postgres for unit tests (#7359)Richard van der Hoff2020-04-281-0/+1
| | | | When running the UTs against a postgres deatbase, we need to set the collation correctly.
* Run replication streamers on workers (#7146)Erik Johnston2020-04-281-0/+1
| | | Currently we never write to streams from workers, but that will change soon
* Fix incorrect metrics reporting for renew_attestations (#7344)Richard van der Hoff2020-04-271-0/+1
| | | | We need to wait for the renewals to finish, so that the metrics are correctly reported.
* Document monitoring workers (#7357)Brendan Abolivier2020-04-271-0/+1
| | | It doesn't seem to be documented anywhere and means that you suddenly start losing metrics without any obvious reason when you go from monolith to workers (e.g. #7312).
* Add some explanation to application_services.md (#7091)lub2020-04-271-0/+1
| | | Signed-off-by: Simon Körner <git@lubiland.de>
* Don't crash when one of the configuration files is empty (#7341)Brendan Abolivier2020-04-271-0/+1
| | | | | If the admin adds a `.yaml` file that's either empty or doesn't parse into a dict to a config directory (e.g. `conf.d` for debs installs), stuff like https://github.com/matrix-org/synapse/issues/7322 would happen. This PR checks that the file is correctly parsed into a dict, or ignores it with a warning if it parses into any other type (including `None` for empty files). Fixes https://github.com/matrix-org/synapse/issues/7322
* Add documentation to the sample config about the templates for SSO. (#7343)Patrick Cloke2020-04-241-0/+1
|
* Convert some of the federation handler methods to async/await. (#7338)Patrick Cloke2020-04-241-0/+1
|
* changelogRichard van der Hoff2020-04-241-0/+1
|
* Revert "Revert "Merge pull request #7315 from ↵Brendan Abolivier2020-04-231-0/+1
| | | | | | matrix-org/babolivier/request_token"" This reverts commit 1adf6a55870aa08de272591ff49db9dc49738076.
* Stop the master relaying USER_SYNC for other workers (#7318)Richard van der Hoff2020-04-221-0/+1
| | | | | | | Long story short: if we're handling presence on the current worker, we shouldn't be sending USER_SYNC commands over replication. In an attempt to figure out what is going on here, I ended up refactoring some bits of the presencehandler code, so the first 4 commits here are non-functional refactors to move this code slightly closer to sanity. (There's still plenty to do here :/). Suggest reviewing individual commits. Fixes (I hope) #7257.
* Fix replication metrics when using redis (#7325)Erik Johnston2020-04-221-0/+1
|
* Merge tag 'v1.12.4rc1' into developRichard van der Hoff2020-04-225-5/+0
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.12.4rc1 (2020-04-22) ============================== Features -------- - Always send users their own device updates. ([\#7160](https://github.com/matrix-org/synapse/issues/7160)) - Add support for handling GET requests for `account_data` on a worker. ([\#7311](https://github.com/matrix-org/synapse/issues/7311)) Bugfixes -------- - Fix a bug that prevented cross-signing with users on worker-mode synapses. ([\#7255](https://github.com/matrix-org/synapse/issues/7255)) - Do not treat display names as globs in push rules. ([\#7271](https://github.com/matrix-org/synapse/issues/7271)) - Fix a bug with cross-signing devices belonging to remote users who did not share a room with any user on the local homeserver. ([\#7289](https://github.com/matrix-org/synapse/issues/7289))
| * 1.12.4rc1Richard van der Hoff2020-04-225-5/+0
| |
* | Another go at fixing one-word commands (#7326)Richard van der Hoff2020-04-221-0/+1
| | | | | | I messed this up last time I tried (#7239 / e13c6c7).
* | fix changelog nameRichard van der Hoff2020-04-221-0/+0
| |
* | Extend StreamChangeCache to support multiple entities per stream ID (#7303)Richard van der Hoff2020-04-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First some background: StreamChangeCache is used to keep track of what "entities" have changed since a given stream ID. So for example, we might use it to keep track of when the last to-device message for a given user was received [1], and hence whether we need to pull any to-device messages from the database on a sync [2]. Now, it turns out that StreamChangeCache didn't support more than one thing being changed at a given stream_id (this was part of the problem with #7206). However, it's entirely valid to send to-device messages to more than one user at a time. As it turns out, this did in fact work, because *some* methods of StreamChangeCache coped ok with having multiple things changing on the same stream ID, and it seems we never actually use the methods which don't work on the stream change caches where we allow multiple changes at the same stream ID. But that feels horribly fragile, hence: let's update StreamChangeCache to properly support this, and add some typing and some more tests while we're at it. [1]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L301 [2]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L47-L51
* | Extend room admin api with additional attributes (#7225)Dirk Klimpel2020-04-221-0/+1
| |
* | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-222-0/+2
|\|
| * Do not treat display names as globs for push rules. (#7271)Patrick Cloke2020-04-221-0/+1
| |
| * Query missing cross-signing keys on local sig upload (#7289)Andrew Morgan2020-04-221-0/+1
| |
| * Fix changelog fileRichard van der Hoff2020-04-212-1/+1
| | | | | | | | I updated the PR and forgot to update the changelog.
| * Support GET account_data requests on a worker (#7311)Richard van der Hoff2020-04-211-0/+1
| |
* | Add ability to run replication protocol over redis. (#7040)Erik Johnston2020-04-221-0/+1
| | | | | | This is configured via the `redis` config options.
* | Reduce logging verbosity of URL cache cleanup. (#7295)Michael Kaye2020-04-221-0/+1
| |
* | import urllib.parse when using urllib.parse.quote (#7319)Andrew Morgan2020-04-221-0/+1
| |
* | Reduce federation logging on success (#7321)Michael Kaye2020-04-221-0/+1
| | | | | | | | Splitting based on the response code means we can avoid double logging here and identical information from line 164 while still logging at info if we don't get a good response and need to retry.
* | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-201-1/+0
|\|
| * Revert "Query missing cross-signing keys on local sig upload"Richard van der Hoff2020-04-201-1/+0
| | | | | | | | | | | | This was incorrectly merged to the release branch before it was ready. This reverts commit 72fe2affb6ac86d433b80b6452da57052365aa26.
* | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-201-0/+1
|\|
| * Always send the user updates to their own device list (#7160)David Baker2020-04-201-0/+1
| |
| * Query missing cross-signing keys on local sig uploadAndrew Morgan2020-04-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add changelog Save retrieved keys to the db lint Fix and de-brittle remote result dict processing Use query_user_devices instead, assume only master, self_signing key types Make changelog more useful Remove very specific exception handling Wrap get_verify_key_from_cross_signing_key in a try/except Note that _get_e2e_cross_signing_verify_key can raise a SynapseError lint Add comment explaining why this is useful Only fetch master and self_signing key types Fix log statements, docstrings Remove extraneous items from remote query try/except lint Factor key retrieval out into a separate function Send device updates, modeled after SigningKeyEduUpdater._handle_signing_key_updates Update method docstring
| * Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-141-0/+1
| |
| * 1.12.3Richard van der Hoff2020-04-031-1/+0
| |
| * Fix the debian build in a better way. (#7212)Richard van der Hoff2020-04-031-0/+1
| |
| * 1.12.1rc1Andrew Morgan2020-03-313-3/+0
| |
| * NewsfileErik Johnston2020-03-311-0/+1
| |
| * Rewrite changelogAndrew Morgan2020-03-311-1/+1
| |
| * Add changelogAndrew Morgan2020-03-311-0/+1
| |
| * Only import sqlite3 when type checkingDavid Vo2020-03-311-0/+1
| | | | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
* | Fix indention in generated config file (#7300)Lars Franke2020-04-201-0/+1
| | | | | | | | | | | | Also adjust sample_config.yaml Signed-off-by: Lars Franke <frcl@mailbox.org>
* | Reject unknown UI auth sessions (instead of silently generating a new one) ↵Patrick Cloke2020-04-201-0/+1
| | | | | | | | (#7268)
* | On catchup, process each row with its own stream id (#7286)Richard van der Hoff2020-04-201-0/+1
| | | | | | | | | | | | Other parts of the code (such as the StreamChangeCache) assume that there will not be multiple changes with the same stream id. This code was introduced in #7024, and I hope this fixes #7206.
* | Use a template for the SSO success page to allow for customization. (#7279)Patrick Cloke2020-04-171-0/+1
| |
* | Added explicit Python build tools to snap requirements (#7213)James2020-04-171-0/+1
| | | | | | Signed-off-by: James Hebden <james@ec0.io>
* | Improve type checking in `replication.tcp.Stream` (#7291)Richard van der Hoff2020-04-171-0/+1
| | | | | | | | | | | | | | The general idea here is to get rid of the type: ignore annotations on all of the current_token and update_function assignments, which would have caught #7290. After a bit of experimentation, it seems like the least-awful way to do this is to pass the offending functions in as parameters to the Stream constructor. Unfortunately that means that the concrete implementations no longer have the same constructor signature as Stream itself, which means that it gets hard to correctly annotate STREAMS_MAP. I've also introduced a couple of new types, to take out some duplication.
* | Clarify the comments for media_storage_providers options (#7272)Tristan Lins2020-04-171-0/+1
| |
* | Do not treat display names as globs for push rules. (#7271)Patrick Cloke2020-04-161-0/+1
| |
* | Fix 'generator object is not subscriptable' error (#7290)Richard van der Hoff2020-04-161-0/+1
| | | | | | | | | | | | Some of the query functions return generators rather than lists, so we can't index into the result. Happily we already have a copy of the results. (think this was introduced in #7024)
* | Convert auth handler to async/await (#7261)Patrick Cloke2020-04-151-0/+1
| |
* | Add notes to the changelog about an additional SSO template. (#7259)Patrick Cloke2020-04-151-0/+1
| |
* | Allow specifying the value of Accept-Language header for URL previews (#7265)Andrew Morgan2020-04-151-0/+1
| |
* | Fix a potentially-huge sql query (#7274)Richard van der Hoff2020-04-151-0/+1
| | | | | | | | | | We could end up looking up tens of thousands of events, which could cause large amounts of data to be logged to the postgres log.
* | Fix the parameters of a test fixture (#7243)Zay11Zay2020-04-141-0/+1
| |
* | Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-141-0/+1
| |
* | Add setting to nginx configuration to allow larger file uploads (#7251)Ryan Hovland2020-04-131-0/+1
| |
* | Check on room creation if the user is allowed to publish the room to the ↵PeerD2020-04-131-0/+1
| | | | | | | | room directory. (#7260)
* | Default PL100 to enable encryption in a room (#7230)Andrew Morgan2020-04-091-0/+1
| |
* | Do not allow a deactivated user to login via SSO. (#7240)Patrick Cloke2020-04-091-0/+1
| |
* | Unblacklist /upgrade creates a new room (#7228)Andrew Morgan2020-04-091-0/+1
| | | | | | | | | | | | This commit was originally merged in #7228 but reverted in #7254 as the associated sytest was not ready yet. Now that it is, we can merge this again.
* | Add matrix-synapse-shared-secret-auth as an example password provider (#7248)Andrew Morgan2020-04-091-0/+1
| |
* | Revert "Unblacklist /upgrade creates a new room (#7228)" (#7254)Andrew Morgan2020-04-091-1/+0
| | | | | | This reverts commit 59f0ca8b87c15a314859d94978d90a8aa0e7543b.
* | Unblacklist /upgrade creates a new room (#7228)Andrew Morgan2020-04-091-0/+1
| |
* | Fix --help commandline argument (#7249)Richard van der Hoff2020-04-091-0/+1
| | | | | | | | | | | | | | | | I don't really remember why this was so complicated; I think it dates back to the time when we had to instantiate the Config classes before we could call `add_arguments` - ie before #5597. In any case, I don't think there's a good reason for it any more, and the impact of it being complicated is that `--help` doesn't work correctly.
* | Make it clearer to the user that they haven't overridden onLogin/Register ↵Andrew Morgan2020-04-091-0/+1
| | | | | | | | (#7237)
* | Upgrade jQuery to 3.x on fallback login/registration screens (#7236)Andrew Morgan2020-04-091-0/+1
| |
* | Remove redundant checks on `daemonize` from synctl (#7233)Richard van der Hoff2020-04-081-0/+1
| | | | | | | | | | We pass --daemonize on the commandline, which (since at least #4853) overrides whatever the config file, so there is no need for it to be set in the config file.
* | Make systemd-with-workers doc official (#7234)Richard van der Hoff2020-04-081-0/+1
| | | | | | | | Simplify and update this documentation, and make it part of the core dist.
* | Fix changelog for #7235Brendan Abolivier2020-04-082-1/+1
| |
* | Add documentation to password_providers config option (#7238)Andrew Morgan2020-04-081-0/+1
| |
* | bg update to clear out duplicate outbound_device_list_pokes (#7193)Richard van der Hoff2020-04-071-0/+1
| | | | | | | | We seem to have some duplicates, which could do with being cleared out.
* | Merge pull request #7239 from matrix-org/rav/replication_cleanupRichard van der Hoff2020-04-071-0/+1
|\ \ | | | | | | Miscellaneous cleanups to replication code
| * | changelogRichard van der Hoff2020-04-071-0/+1
| | |
* | | Convert delete_url_cache_media to async/await. (#7241)Patrick Cloke2020-04-071-0/+1
| | |
* | | Add typing information to federation_server. (#7219)Patrick Cloke2020-04-071-0/+1
| | |
* | | Fix typo in the login fallback javascript (#7235)Brendan Abolivier2020-04-071-0/+1
|/ / | | | | | | | | * Fix typo in the login fallback javascript * Changelog
* | Remove sent outbound device list pokes from the database (#7192)Richard van der Hoff2020-04-071-0/+1
| | | | | | They just get in the way.
* | Fix race in replication (#7226)Erik Johnston2020-04-071-0/+1
| | | | | | | | Fixes a race between handling `POSITION` and `RDATA` commands. We do this by simply linearizing handling of them.
* | Move server command handling out of TCP protocol (#7187)Erik Johnston2020-04-071-0/+1
| | | | | | This completes the merging of server and client command processing.
* | Remove stream before/after debug log lines (#7207)Andrew Morgan2020-04-061-0/+1
| |
* | Improve error responses when a remote server doesn't allow you to access its ↵Andrew Morgan2020-04-061-0/+1
| | | | | | | | public rooms list (#6899)
* | Move client command handling out of TCP protocol (#7185)Erik Johnston2020-04-061-0/+1
| | | | | | The aim here is to move the command handling out of the TCP protocol classes and to also merge the client and server command handling (so that we can reuse them for redis protocol). This PR simply moves the client paths to the new `ReplicationCommandHandler`, a future PR will move the server paths too.
* | Server notices: Dissociate room creation/lookup from invite (#7199)Brendan Abolivier2020-04-041-0/+1
| | | | | | | | | | | | | | | | | | Fixes #6815 Before figuring out whether we should alert a user on MAU, we call get_notice_room_for_user to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by get_notice_room_for_user is cached. This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by get_notice_room_for_user doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts, so that function won't run very often. It also renames get_notice_room_for_user into get_or_create_notice_room_for_user to make what it does clearer.
* | Support CAS in UI Auth flows. (#7186)Patrick Cloke2020-04-031-0/+1
| |
* | Extend web_client_location to handle absolute URLs (#7006)Martin Milata2020-04-031-0/+1
| | | | | | | | | | Log warning when filesystem path is used. Signed-off-by: Martin Milata <martin@martinmilata.cz>
* | Add some benchmarks for LruCache (#6446)Amber Brown2020-04-031-0/+1
| |
* | Convert http.HTTPStatus objects to their int equivalent (#7188)Andrew Morgan2020-04-031-0/+1
| |
* | Reduce the number of calls to `resource.getrusage` (#7183)Richard van der Hoff2020-04-031-0/+1
| | | | | | Let's just call `getrusage` once on each logcontext change, rather than twice.
* | Merge pull request #7190 from matrix-org/rav/one_bg_update_at_a_timeRichard van der Hoff2020-04-031-0/+1
|\ \ | | | | | | Only run one background update at a time
| * | changelogRichard van der Hoff2020-03-311-0/+1
| | |
* | | Remove some `run_in_background` calls in replication code (#7203)Richard van der Hoff2020-04-031-0/+1
| | | | | | | | | | | | | | | | | | By running this stuff with `run_in_background`, it won't be correctly reported against the relevant CPU usage stats. Fixes #7202
* | | Fix device list update stream ids going backward (#7158)Richard van der Hoff2020-04-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Occasionally we could get a federation device list update transaction which looked like: ``` [ {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}} ] ``` Having `stream_ids` which are lower than `prev_ids` looks odd. It might work (I'm not actually sure), but in any case it doesn't seem like a reasonable thing to expect other implementations to support.
* | | Support SAML in the user interactive authentication workflow. (#7102)Patrick Cloke2020-04-011-0/+1
| | |
* | | Allow admins to create aliases when they are not in the room (#7191)Patrick Cloke2020-04-011-0/+1
| | |
* | | Update postgres.md (#7119)siroccal2020-04-011-0/+1
| | |
* | | Remove connections per replication stream metric. (#7195)Erik Johnston2020-04-011-0/+1
| | | | | | | | | | | | | | | This broke in a recent PR (#7024) and is no longer useful due to all replication clients implicitly subscribing to all streams, so let's just remove it.
* | | Improve TURN documentation. (#7167)Jostein Kjønigsen2020-03-311-0/+1
|/ /
* | Fix "'NoneType' has no attribute start|stop" logcontext errors (#7181)Richard van der Hoff2020-03-311-0/+1
| | | | | | | | Fixes #7179.
* | Fill in the 'default' field for user-defined push rules (#6639)Karlinde2020-03-311-0/+1
| | | | | | Signed-off-by: Karl Linderhed <git@karlinde.se>
* | Only setdefault for signatures if device has key_json (#7177)Andrew Morgan2020-03-311-0/+1
| |
* | Fix use of async/await in media code (#7184)Patrick Cloke2020-03-311-0/+1
| |
* | Fix a bug which could cause incorrect 'cyclic dependency' error. (#7178)Richard van der Hoff2020-03-311-0/+1
| | | | | | | | | | | | | | | | If there was an exception setting up one of the attributes of the Homeserver god object, then future attempts to fetch that attribute would raise a confusing "Cyclic dependency" error. Let's make sure that we clear the `building` flag so that we just get the original exception. Ref: #7169
* | Rewrite prune_old_outbound_device_pokes for efficiency (#7159)Richard van der Hoff2020-03-301-0/+1
| | | | | | | | make sure we clear out all but one update for the user
* | Transfer alias mappings when joining an upgraded room (#6946)Andrew Morgan2020-03-301-0/+1
| |
* | Fix a small typo in the `metrics_flags` config option. (#7171)Andrew Morgan2020-03-301-0/+1
| |
* | Remove usage of "conn_id" for presence. (#7128)Erik Johnston2020-03-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove `conn_id` usage for UserSyncCommand. Each tcp replication connection is assigned a "conn_id", which is used to give an ID to a remotely connected worker. In a redis world, there will no longer be a one to one mapping between connection and instance, so instead we need to replace such usages with an ID generated by the remote instances and included in the replicaiton commands. This really only effects UserSyncCommand. * Add CLEAR_USER_SYNCS command that is sent on shutdown. This should help with the case where a synchrotron gets restarted gracefully, rather than rely on 5 minute timeout.
* | Merge pull request #7160 from ↵David Baker2020-03-301-0/+1
|\ \ | | | | | | | | | | | | matrix-org/dbkr/always_send_own_device_list_updates Always send the user updates to their own device list
| * | changelogDavid Baker2020-03-271-0/+1
| | |
* | | Merge pull request #7157 from matrix-org/rev.outbound_device_pokes_testsRichard van der Hoff2020-03-301-0/+1
|\ \ \ | | | | | | | | Add tests for outbound device pokes
| * | | Add tests for outbound device pokesRichard van der Hoff2020-03-271-0/+1
| | | |
* | | | Add developer documentation for running a local CAS server (#7147)Patrick Cloke2020-03-301-0/+1
| | | |
* | | | Always whitelist the login fallback for SSO (#7153)Richard van der Hoff2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | That fallback sets the redirect URL to itself (so it can process the login token then return gracefully to the client). This would make it pointless to ask the user for confirmation, since the URL the confirmation page would be showing wouldn't be the client's.
* | | | Improve the UX of the login fallback when using SSO (#7152)Brendan Abolivier2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.
* | | | Admin API to join users to a room. (#7051)Dirk Klimpel2020-03-271-0/+1
| | | |
* | | | Add options to prevent users from changing their profile. (#7096)Dirk Klimpel2020-03-271-0/+1
| | | |
* | | | update debian installation instructions to recommend installing `virtualenv` ↵txt-file2020-03-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of `python3-virtualenv` (#6892) * change debian package from python3-virtualenv to virtualenv The virtualenv package is needed for the virtualenv command. The virtualenv package depends on python3-virtualenv (at least since debian jessie) so there is no need to specify python3-virtualenv additionally. Signed-off-by: Vieno Hakkerinen <vieno@hakkerinen.eu> * Add changelog Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
* | | | Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean (#7150)Andrew Morgan2020-03-271-0/+1
| | | |
* | | | Only import sqlite3 when type checking (#7155)David Vo2020-03-271-0/+1
| |/ / |/| | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
* | | Merge pull request #7151 from matrix-org/jaywink/saml-redirect-fixJason Robinson2020-03-261-0/+1
|\ \ \ | | | | | | | | Allow RedirectResponse in SAML response handler
| * | | Update changelog.d/7151.bugfixJason Robinson2020-03-261-1/+1
| | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | Allow RedirectResponse in SAML response handlerJason Robinson2020-03-261-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow custom SAML handlers to redirect after processing an auth response. Fixes #7149 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | | | Refactor the CAS code (move the logic out of the REST layer to a handler) ↵Patrick Cloke2020-03-261-0/+1
| | | | | | | | | | | | | | | | (#7136)
* | | | Don't default to an invalid sqlite config if no database configuration is ↵Nektarios Katakis2020-03-261-0/+1
| | | | | | | | | | | | | | | | provided (#6573)
* | | | Allow server admins to define and enforce a password policy (MSC2000). (#7118)Dirk Klimpel2020-03-261-0/+1
|/ / /
* | | Validate that the session is not modified during UI-Auth (#7068)Patrick Cloke2020-03-261-0/+1
| | |
* | | Remove unused captcha_bypass_secret option (#7137)Aaron Raimist2020-03-251-0/+1
| | | | | | | | | Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | | Move catchup of replication streams to worker. (#7024)Erik Johnston2020-03-251-0/+1
| | | | | | | | | This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
* | | Various cleanups to INSTALL.md (#7141)Andrew Morgan2020-03-251-0/+1
| | |
* | | Merge pull request #7133 from matrix-org/erikj/fix_worker_startupErik Johnston2020-03-251-0/+1
|\ \ \ | | | | | | | | Fix starting workers when federation sending not split out.
| * | | NewsfileErik Johnston2020-03-241-0/+1
| | | |
* | | | Clean up some LoggingContext stuff (#7120)Richard van der Hoff2020-03-241-0/+1
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Pull Sentinel out of LoggingContext ... and drop a few unnecessary references to it * Factor out LoggingContext.current_context move `current_context` and `set_context` out to top-level functions. Mostly this means that I can more easily trace what's actually referring to LoggingContext, but I think it's generally neater. * move copy-to-parent into `stop` this really just makes `start` and `stop` more symetric. It also means that it behaves correctly if you manually `set_log_context` rather than using the context manager. * Replace `LoggingContext.alive` with `finished` Turn `alive` into `finished` and make it a bit better defined.
* | | Fix CAS redirect url (#6634)Naugrimm2020-03-241-0/+1
| | | | | | | | | Build the same service URL when requesting the CAS ticket and when calling the proxyValidate URL.
* | | Use the proper error code when a canonical alias that does not exist is ↵Patrick Cloke2020-03-231-0/+1
| | | | | | | | | | | | used. (#7109)
* | | Update pre-built package name for FreeBSD (#7107). (#7107)Kartikaya Gupta (kats)2020-03-231-0/+1
| | | | | | | | | Signed-off-by: Kartikaya Gupta <kats@trevize.staktrace.com>
* | | Convert `*StreamRow` classes to inner classes (#7116)Richard van der Hoff2020-03-231-0/+1
| | | | | | | | | | | | | | | This just helps keep the rows closer to their streams, so that it's easier to see what the format of each stream is.