summary refs log tree commit diff
path: root/changelog.d/6573.bugfix (unfollow)
Commit message (Collapse)AuthorFilesLines
2023-06-15Fix unsafe hotserving behaviour for non-multimedia uploads. (#15680)Josh Qou4-19/+29
* Fix unsafe hotserving behaviour for non-multimedia uploads. * invert disposition assert * test_media_storage.py: run lint * test_base.py: /inline/attachment/s * Only return attachment for disposition type, update tests * Update synapse/media/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update changelog.d/15680.bugfix Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * add attribution * Update changelog. --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-06-14Fix joining rooms through aliases where the alias server isn't a real ↵Tulir Asokan2-1/+2
homeserver (#15776)
2023-06-141.86.0rc2 v1.86.0rc2Mathieu Velten4-2/+18
2023-06-14Revert "Allow for the configuration of max request retries and min/max retry ↵Mathieu Velten5-68/+10
delays in the matrix federation client (#12504)" This reverts commit d84e66144dc12dacf71c987a2ba802dd59c0b68e.
2023-06-14Fix empty scope when having version mismatch between workers (#15774)Mathieu Velten2-1/+2
2023-06-14Prefill events after invalidate not before when persisting events (#15758)Jason Little5-5/+70
Fixes #15757
2023-06-13Document `looping_call()` functionality that will wait for the given ↵Eric Eastwood2-0/+6
function to finish before scheduling another (#15772) Thanks to @erikjohnston for clarifying, https://github.com/matrix-org/synapse/pull/15743#discussion_r1226544457 We don't have to worry about calls stacking up if the given function takes longer than the scheduled time.
2023-06-13Replace `EventContext` fields `prev_group` and `delta_ids` with field ↵Shay6-58/+126
`state_group_deltas` (#15233)
2023-06-13Fix MSC3983 support: only one OTK per device was returned through federation ↵Mathieu Velten2-1/+4
(#15770)
2023-06-13Avoid backfill when we already have messages to return (#15737)Eric Eastwood2-22/+116
We now only block the client to backfill when we see a large gap in the events (more than 2 events missing in a row according to `depth`), more than 3 single-event holes, or not enough messages to fill the response. Otherwise, we return the messages directly to the client and backfill in the background for eventual consistency sake. Fix https://github.com/matrix-org/synapse/issues/15696
2023-06-13Fix MSC3983 support: Use the unstable /keys/claim federation endpoint if ↵Patrick Cloke2-1/+5
multiple keys are requested (#15755)
2023-06-13Fix changelog typo v1.86.0rc1Mathieu Velten1-1/+1
2023-06-131.86.0rc1Mathieu Velten33-31/+76
2023-06-13Bump regex from 1.7.3 to 1.8.4 (#15769)dependabot[bot]1-6/+6
Bumps [regex](https://github.com/rust-lang/regex) from 1.7.3 to 1.8.4. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/regex/compare/1.7.3...1.8.4) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-13Bump log from 0.4.18 to 0.4.19 (#15761)dependabot[bot]1-2/+2
Bumps [log](https://github.com/rust-lang/log) from 0.4.18 to 0.4.19. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/log/compare/0.4.18...0.4.19) --- updated-dependencies: - dependency-name: log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump minimum supported Rust version (#15768)Erik Johnston4-10/+19
Important crates such as `log` and `regex` have bumped theirs to 1.60.0 as well.
2023-06-12Bump pyo3-log from 0.8.1 to 0.8.2 (#15759)dependabot[bot]1-2/+2
Bumps [pyo3-log](https://github.com/vorner/pyo3-log) from 0.8.1 to 0.8.2. - [Changelog](https://github.com/vorner/pyo3-log/blob/main/CHANGELOG.md) - [Commits](https://github.com/vorner/pyo3-log/compare/v0.8.1...v0.8.2) --- updated-dependencies: - dependency-name: pyo3-log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump serde from 1.0.163 to 1.0.164 (#15760)dependabot[bot]1-4/+4
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.163 to 1.0.164. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.163...v1.0.164) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump pyopenssl from 23.1.1 to 23.2.0 (#15765)dependabot[bot]1-4/+4
Bumps [pyopenssl](https://github.com/pyca/pyopenssl) from 23.1.1 to 23.2.0. - [Changelog](https://github.com/pyca/pyopenssl/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/pyopenssl/compare/23.1.1...23.2.0) --- updated-dependencies: - dependency-name: pyopenssl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump pydantic from 1.10.8 to 1.10.9 (#15762)dependabot[bot]1-37/+37
Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.8 to 1.10.9. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](https://github.com/pydantic/pydantic/compare/v1.10.8...v1.10.9) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump sentry-sdk from 1.25.0 to 1.25.1 (#15764)dependabot[bot]1-3/+3
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.25.0 to 1.25.1. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.25.0...1.25.1) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump phonenumbers from 8.13.11 to 8.13.13 (#15763)dependabot[bot]1-3/+3
Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.13.11 to 8.13.13. - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.13.11...v8.13.13) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-12Bump types-pyopenssl from 23.1.0.2 to 23.2.0.0 (#15766)dependabot[bot]1-159/+7
Bumps [types-pyopenssl](https://github.com/python/typeshed) from 23.1.0.2 to 23.2.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyopenssl dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-09Backfill in the background if we're doing it "just because" (#15710)Eric Eastwood2-4/+15
Fix https://github.com/matrix-org/synapse/issues/15702
2023-06-09Speed up typechecking CI (#15752)Erik Johnston2-4/+5
By restoring the rust cache before installing the project.
2023-06-09Allow for the configuration of max request retries and min/max retry delays ↵Shay5-10/+68
in the matrix federation client (#12504) Co-authored-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
2023-06-08Fix up changelog v1.85.2Erik Johnston1-1/+1
2023-06-08Clear event caches when we purge history (#15609)Erik Johnston9-14/+184
This should help a little with #13476 --------- Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2023-06-081.85.2Erik Johnston4-2/+16
2023-06-08Fix using TLS for replication (#15746)Erik Johnston2-1/+2
Fixes #15744.
2023-06-07Quick & dirty metric for background update status (#15740)David Robertson4-1/+40
* Quick & dirty metric for background update status * Changelog * Remove debug Co-authored-by: Mathieu Velten <mathieuv@matrix.org> * Actually write to _aborted --------- Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-06-07Remove superfluous `room_memberships` join from background update (#15733)Eric Eastwood2-1/+1
Spawning from https://github.com/matrix-org/synapse/pull/15731
2023-06-07Remove redundant `room_memberships` join to find participating servers in a ↵Eric Eastwood2-3/+3
room (#15732) Spawning from https://github.com/matrix-org/synapse/pull/15731
2023-06-07Check required power levels earlier in createRoom handler. (#15695)Grant McLean3-14/+100
* Check required power levels earlier in createRoom handler. - If a server was configured to reject the creation of rooms with E2EE enabled (by specifying an unattainably high power level for "m.room.encryption" in default_power_level_content_override), the 403 error was not being triggered until after the room was created and before the "m.room.power_levels" was sent. This allowed a user to access the partially-configured room and complete the setup of E2EE and power levels manually. - This change causes the power level overrides to be checked earlier and the request to be rejected before the user gains access to the room. - A new `_validate_room_config` method is added to contain checks that should be run before a room is created. - The new test case confirms that a user request is rejected by the new validation method. Signed-off-by: Grant McLean <grant@catalyst.net.nz> * Add a changelog file. * Formatting fix for black. * Remove unneeded line from test. --------- Signed-off-by: Grant McLean <grant@catalyst.net.nz>
2023-06-07Update changelog v1.85.1Erik Johnston1-0/+2
2023-06-07Update changelogErik Johnston2-2/+1
2023-06-07Fix schema delta error in 1.85 (#15739)Erik Johnston2-2/+15
Some users seem to have multiple rows per user / room with a null thread ID, which we need to handle.
2023-06-071.85.1Erik Johnston4-2/+16
2023-06-07Fix schema delta error in 1.85 (#15738)Erik Johnston2-0/+9
There appears to be a race where you can end up with entries in `event_push_summary` with both a `NULL` and `main` thread ID. Fixes #15736 Introduced in #15597
2023-06-06No need for the extra join since `membership` is built-in to ↵Eric Eastwood2-4/+4
`current_state_events` (#15731) This helps with the upstream `is_host_joined()` and `is_host_invited()` functions. `membership` was added to `current_state_events` in https://github.com/matrix-org/synapse/pull/5706 and forced in https://github.com/matrix-org/synapse/pull/13745
2023-06-06Trace functions which return `Awaitable` (#15650)Eric Eastwood3-22/+59
2023-06-06Update error to more plainly explain we can only authorize our own events ↵Eric Eastwood2-1/+2
(#15725)
2023-06-06Add context for when/why to use the `long_retries` option when sending ↵Eric Eastwood2-2/+10
Federation requests (#15721)
2023-06-06Improve performance of user directory search (#15729)Shay2-4/+9
2023-06-06Prevent "twisted trunk" and "latest deps" workflows from running on forks ↵Andrew Morgan3-4/+44
(#15726)
2023-06-06Remove some unused `server_name` fields (#15723)Sean Quah6-5/+1
Signed-off-by: Sean Quah <seanq@matrix.org>
2023-06-06Fix link in changelogErik Johnston1-1/+1
2023-06-06Fixup changelog v1.85.0Erik Johnston1-1/+1
2023-06-061.85.0Erik Johnston3-1/+28
2023-06-06Stabilize support for MSC3952: Intentional mentions. (#15520)Patrick Cloke13-64/+27
2023-06-05Some house keeping on `maybe_backfill()` functions (#15709)Eric Eastwood2-0/+18
2023-06-05Bump types-requests from 2.31.0.0 to 2.31.0.1 (#15715)dependabot[bot]1-3/+3
Bumps [types-requests](https://github.com/python/typeshed) from 2.31.0.0 to 2.31.0.1. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-05Bump types-jsonschema from 4.17.0.7 to 4.17.0.8 (#15716)dependabot[bot]1-3/+3
Bumps [types-jsonschema](https://github.com/python/typeshed) from 4.17.0.7 to 4.17.0.8. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-jsonschema dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-05Bump sentry-sdk from 1.22.1 to 1.25.0 (#15714)dependabot[bot]1-5/+6
Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.22.1 to 1.25.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.22.1...1.25.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-05Bump pyasn1 from 0.4.8 to 0.5.0 (#15713)dependabot[bot]1-5/+5
Bumps [pyasn1](https://github.com/pyasn1/pyasn1) from 0.4.8 to 0.5.0. - [Release notes](https://github.com/pyasn1/pyasn1/releases) - [Changelog](https://github.com/pyasn1/pyasn1/blob/main/CHANGES.rst) - [Commits](https://github.com/pyasn1/pyasn1/compare/v0.4.8...v0.5.0) --- updated-dependencies: - dependency-name: pyasn1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-05Bump library/redis from 6-bullseye to 7-bullseye in /docker (#15712)dependabot[bot]1-1/+1
Bumps library/redis from 6-bullseye to 7-bullseye. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-05Bump importlib-metadata from 6.1.0 to 6.6.0 (#15711)dependabot[bot]1-7/+7
Bumps [importlib-metadata](https://github.com/python/importlib_metadata) from 6.1.0 to 6.6.0. - [Release notes](https://github.com/python/importlib_metadata/releases) - [Changelog](https://github.com/python/importlib_metadata/blob/main/CHANGES.rst) - [Commits](https://github.com/python/importlib_metadata/compare/v6.1.0...v6.6.0) --- updated-dependencies: - dependency-name: importlib-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-02`N + 3`: Read from column `full_user_id` rather than `user_id` of tables ↵Shay22-95/+252
`profiles` and `user_filters` (#15649)
2023-06-02Add a catch-all * to the supported relation types when redacting (#15705)Mathieu Velten4-8/+143
This is an update to MSC3912 implementation
2023-06-01Log when events are (unexpectedly) filtered out of responses in tests (#14213)Eric Eastwood7-14/+53
See https://github.com/matrix-org/synapse/pull/14095#discussion_r990335492 This is useful because when see that a relevant event is an `outlier` or `soft-failed`, then that's a good unexpected indicator explaining why it's not showing up. `filter_events_for_client` is used in `/sync`, `/messages`, `/context` which are all common end-to-end assertion touch points (also notifications, relations).
2023-06-011.85.0rc2 v1.85.0rc2H. Shay6-4/+28
2023-06-01Cache requests for user's devices from federation (#15675)Erik Johnston3-2/+70
This should mitigate the issue where lots of different servers requests the same user's devices all at once.
2023-06-01Implement stable support for MSC3882 to allow an existing device/session to ↵Hugh Nimmo-Smith12-75/+225
generate a login token for use on a new device/session (#15388) Implements stable support for MSC3882; this involves updating Synapse's support to match the MSC / the spec says. Continue to support the unstable version to allow clients to transition.
2023-06-01Add a note about deprecating /register with a user property. (#15703)Patrick Cloke2-0/+12
Application services providing a "user" property (instead of "username") for the /register endpoint was never specified. Deprecate this very old fallback.
2023-05-31Speed up background jobs populate_full_user_id_user_filters and ↵Shay3-2/+3
populate_full_user_id_profiles (#15700)
2023-05-31Add Synapse version deploy annotations to Grafana dashboard (#15674)Eric Eastwood2-174/+895
Fix https://github.com/matrix-org/synapse/issues/15662 This manifests as purple lines that show up on all time series panels that you can hover and see what version was deployed. Also added a new "Deployed Synapse versions over time" panel where the color block changes with each version. And mixed this color block into the "Up" time series panel. To get the Grafana dashboard JSON to copy here: use the **Share** icon at the top -> **Export** -> check the **Export for sharing externally** option -> **View JSON** or **Save to file**
2023-05-31Add stubs package for lxml. (#15697)Patrick Cloke10-48/+117
The stubs have some issues so this has some generous cast and ignores in it, but it is better than not having stubs. Note that confusing that Element is a function which creates _Element instances (and similarly for Comment).
2023-05-31Docker fully qualified image names (#15689)Jason Little8-10/+15
* Fully qualified docker image names for the main Dockerfile and Complement related. * Fully qualified docker image names for Dockerfiles associated with building Debian release artifacts. This one is harder and is separate from the other commit in case it wasn't correct or was unwanted. I decided to do the expansion on the docker images in the Dockerfile itself, instead of the various source places that build which distribution that is selected, as it would have been more invasive with the scripts breaking up the string for tagging and such. This one is untested. * Changelog * Update docker/Dockerfile-workers * Update docker/complement/Dockerfile --------- Co-authored-by: reivilibre <olivier@librepush.net>
2023-05-31Fix a performance issue introduced in Synapse v1.83.0 which meant that ↵reivilibre3-0/+52
purging rooms was very slow and database-intensive. (#15693) * Add indices required to efficiently validate new foreign key constraints on stream_ordering * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-05-31Add get_canonical_room_alias to module API (#15450)Gabriel Féron3-1/+29
Co-authored-by: Boxdot <d@zerovolt.org>
2023-05-31Add stricter mypy options (#15694)Patrick Cloke11-24/+40
Enable warn_unused_configs, strict_concatenate, disallow_subclassing_any, and disallow_incomplete_defs.
2023-05-30Enforce that an admin token also has the basic Matrix API scopeQuentin Gliech2-6/+27
2023-05-30