summary refs log tree commit diff
path: root/changelog.d/11311.misc (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-04-14Only send out device list updates for our own users (#12465)Erik Johnston5-8/+56
Broke in #12365
2022-04-14Reintroduce the lint targets in the linter script (#12455)David Robertson3-41/+30
2022-04-14Use `poetry` to manage the virtualenv in debian packages (#12449)David Robertson4-4/+25
* Use `poetry` to build venv in debian packages Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io> * Changelog * Only pull in from requirements.txt Addresses the same problem as #12439. * Include `test` and `all` extras `poetry export` helpfully silently ignores an unknown extra Haven't seen this before because it's the only place we export `all` and `test`. I could have __sworm__ that the syntax `--extra "all test"` worked for `poetry install`... * Clean up requirements file on subsequence builds * Fix shell syntax Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io>
2022-04-14We don't need README to exportDavid Robertson1-1/+1
we did need it to `install` though, (I think?)
2022-04-14Include some dockerfile changes from developDavid Robertson2-3/+3
I think these may have been retained in merge confusion.
2022-04-13Dockerfile-workers: give the master its own log config (#12466)Richard van der Hoff2-17/+32
When we run a worker-mode synapse under docker, everything gets logged to stdout. Currently, output from the workers is tacked with a worker name, for example: ``` 2022-04-13 15:27:56,810 - worker:frontend_proxy1 - synapse.util.caches.lrucache - 154 - INFO - LruCache._expire_old_entries-0 - Dropped 0 items from caches ``` - note `worker:frontend_proxy1`. No such tag is applied to log lines from the master, which makes somewhat confusing reading. To fix this, we generate a dedicated log config file for the master in the same way that we do for the workers, and use that.
2022-04-13Limit `device_id` size to 512B (#12454)Shay3-1/+36
*
2022-04-13docs: Don't render the table of contents on the print page (#12340)Andrew Morgan2-0/+15
2022-04-13Prevent a sync request from removing a user's busy presence status (#12213)David Baker5-18/+133
In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.
2022-04-13Fix missing sync events during historical batch imports (#12319)Nick Mills-Barrett5-19/+162
Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com
2022-04-13Use poetry lockfile in twisted trunk CI job (#12425)David Robertson3-20/+35
Fixes #12458 Co-authored-by: Sean Quah <seanq@element.io> Co-authored-by: Dan Callahan <danc@element.io>
2022-04-13Rename Mutual Rooms `unstable_features` flag to match MSC (#12445)Jonathan de Jong2-1/+2
Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
2022-04-12Bump twisted version to the latest in lockfile (#12441)Shay2-9/+11
2022-04-12Run "main" trial tests under poetry (#12438)David Robertson2-13/+14
* Run "main" trial tests under poetry Olddeps and twisted trunk tests are handled in separate PRs. The PyPy config is a best-effort only; it's completely untested. Pulled out from #12337. * Changelog
2022-04-12Run lints under poetry in CI; remove lint tox jobs (#12434)David Robertson4-46/+12
Co-authored-by: Dan Callahan <danc@element.io>
2022-04-12Process device list updates asynchronously (#12365)Erik Johnston7-119/+40
2022-04-12Remove the unstable event field for `/send_join` per MSC3083. (#12395)Patrick Cloke3-12/+1
This was missed when initially stabilising room version 8 and was left in as a compatibility shim. Most homeservers have upgraded to a version which expects the proper field name, and the failure mode is reasonable (a user on an older server may have to attempt joining the room twice with an obscure error message the first time).
2022-04-12Fix typos in release script docs (#12450)Erik Johnston2-1/+3
2022-04-12Disable groups/communities by default. (#12344)Patrick Cloke4-1/+10
This disables the endpoints (and sync response fields) for groups/communities by default.
2022-04-12Update changelogErik Johnston1-10/+6
2022-04-12Update UPGRADE notes to include more details about v1.57 upgrade failure ↵Richard van der Hoff1-8/+47
mode (#12448)
2022-04-12Resync state after partial-state join (#12394)Richard van der Hoff8-0/+289
We work through all the events with partial state, updating the state at each of them. Once it's done, we recalculate the state for the whole room, and then mark the room as having complete state.
2022-04-12Split changelogs by year v1.57.0rc1Erik Johnston6-5753/+5759
2022-04-12Remove references to unstable identifiers from MSC3440. (#12382)Patrick Cloke11-98/+21
Removes references to unstable thread relation, unstable identifiers for filtering parameters, and the experimental config flag.
2022-04-12Don't line wrapErik Johnston1-7/+2
2022-04-121.57.0rc1Erik Johnston87-86/+123
2022-04-12Add some type hints to datastore (#12423)Dirk Klimpel9-77/+123
* Add some type hints to datastore * newsfile * change `Collection` to `List` * refactor return type of `select_users_txn` * correct type hint in `stream.py` * Remove `Optional` in `select_users_txn` * remove not needed return type in `__init__` * Revert change in `get_stream_id_for_event_txn` * Remove import from `Literal`
2022-04-12Poetry: select olddeps using `poetry` (#12407)David Robertson4-29/+70
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-04-12Specify tls extra for Twisted dependency. (#12444)Erik Johnston5-9/+10
* Specify `tls` extra for Twisted dependency. It was already pulled in for us by `treq`, but we should be explicit that we do use the `tls` functionality of Twisted directly. * Mark `idna` as dev-dependency This doesn't actually change anything, as `Twisted[tls]` will put it in as a main dependency anyway.
2022-04-12Workaround pip bug installing latest treq and not-latest twisted from hashes ↵David Robertson2-1/+2
(#12439) The requirements file generated by `poetry export` isn't correctly processed by `pip install -r requirements.txt`. It contains twisted and treq, both pinned to 22.2.0. When `pip` installs treq, it notices that `Twisted[tls]` is required. It then tries to acquire the latest twisted release, only to fail (because this hash isn't listed in the requirements file).From e.g. https://github.com/matrix-org/synapse/runs/5977154990?check_suite_focus=true > ``` > #15 9.204 Collecting Twisted[tls]>=18.7.0 > #15 9.205 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: > #15 9.205 Twisted[tls]>=18.7.0 from https://files.pythonhosted.org/packages/db/99/38622ff95bb740bcc991f548eb46295bba62fcb6e907db1987c4d92edd09/Twisted-22.4.0-py3-none-any.whl#sha256=f9f7a91f94932477a9fc3b169d57f54f96c6e74a23d78d9ce54039a7f48928a2 (from treq==22.2.0->-r /synapse/requirements.txt (line 724)) > #15 ERROR: executor failed running [/bin/sh -c pip install --prefix="/install" --no-warn-script-location -r /synapse/requirements.txt]: exit code: 1 > ``` The underlying pip issue is https://github.com/pypa/pip/issues/9644. A comment notes that one can avoid this behaviour with by `pip install`ing with the `--no-deps` flag. Let us do so. (At first glance, the problem looks like https://github.com/python-poetry/poetry/issues/5311, but that was a bug in `poetry install`; this is `poetry export`, whose behaviour is fine AFAICS).
2022-04-11Remove experimental configuration flag for MSC3666. (#12436)Patrick Cloke3-19/+15
2022-04-11Add missing type hints to config classes. (#12402)Patrick Cloke51-151/+263
2022-04-11Enable certificate checking during complement tests (#12435)Richard van der Hoff3-12/+1
2022-04-11Do not consider events by ignored users for bundled aggregations (#12235)Patrick Cloke6-45/+427
Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / 4df10d32148ae29f792afc68ff774bcbd1915cea for corresponding changes for the `/relations` endpoint.
2022-04-11Fix up healthcheck generation for workers docker image (#12405)Richard van der Hoff4-11/+11
This wasn't quite generating the right thing.
2022-04-11Disallow untyped defs in synapse._scripts (#12422)David Robertson14-140/+221
Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.
2022-04-11Move complement setup stuff into the Synapse repo (#12404)Richard van der Hoff12-52/+449
Fixes matrix-org/complement#330 (or it will, once we remove the old files). It's not quite a lift-and-shift: I've also taken the opportunity to get rid of the custom CA that we used to use to sign the TLS certs, which has been superceded by the CA exposed by Complement.
2022-04-11Add Module API for reading and writing global account data. (#12391)reivilibre3-0/+234
2022-04-08CI: Fix the export-data job to run under poetry (#12418)David Robertson3-16/+13
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-04-08Optimise `_update_client_ips_batch_txn` to batch together database ↵reivilibre4-51/+190
operations. (#12252) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-04-08Make `synapse._scripts` pass typechecks (#12421)David Robertson6-43/+50
2022-04-08Stop maintaining a list of lint targets in `lint.sh` (#12420)David Robertson5-31/+10
2022-04-08Unify HTTP query parameter type hints (#12415)David Robertson6-38/+43
* Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410
2022-04-08Update the server notices user profile in room if changed. (#12115)Jorge Florian3-4/+148
2022-04-08CI: Get the portdb job to run under poetry (#12412)David Robertson3-19/+15
2022-04-08Add missing type definitions for scripts in docker folder (#12280)Jorge Florian3-4/+7
Signed-off-by: Jorge Florian <jafn28@gmail.com>
2022-04-07Minor tweaks to comments in response to reviewsDan Callahan1-5/+5
Signed-off-by: Dan Callahan <danc@element.io>
2022-04-07Fix rejecting invites over federation (#12409)Erik Johnston2-20/+34
Currently causes future incremental syncs to fail. Broke by #12191
2022-04-07Fix fetching public rooms over federation (#12410)Erik Johnston2-1/+2
Broke by #12364
2022-04-07Do not add groups to sync results if disabled. (#12408)Patrick Cloke3-10/+11
2022-04-07Add opentracing spans to calls to external cache (#12380)Erik Johnston3-11/+24
2022-04-07Inline CI steps for installing Twisted trunkDan Callahan2-25/+11
Signed-off-by: Dan Callahan <danc@element.io>
2022-04-07Poetry: use locked environment in Docker images (#12385)David Robertson4-26/+69
2022-04-07Support the v1 endpoint for `/relations`. (#12403)Patrick Cloke3-12/+13
Now that MSC2675 has passed FCP and the implementation is compliant with the final version.
2022-04-07Clarify a CI workflow step for Twisted trunkDan Callahan1-4/+8
Signed-off-by: Dan Callahan <danc@element.io>
2022-04-07Bump locked version of prometheus-client to 0.14.0Dan Callahan1-3/+3
The typechecking fix in #12389 only works if your local copy of prometheus-client is at least version 0.14. Otherwise, it fails with: synapse/metrics/_types.py:22: error: Module "prometheus_client.registry" has no attribute "Collector" [attr-defined] Signed-off-by: Dan Callahan <danc@element.io>
2022-04-06Install and run poetry export in dpkg-buildpackageDan Callahan3-17/+16
Signed-off-by: Dan Callahan <danc@element.io>
2022-04-06Clarify that we mark as outliers because we don't have any state for them ↵Eric Eastwood2-1/+3
(#12345) As discussed at https://github.com/matrix-org/synapse/pull/12179#discussion_r837263852
2022-04-06Update changelog to describe changes from #12370 relative to `develop` (#12401)Eric Eastwood2-1/+1
2022-04-06Remove docs for converting a legacy structured logging config. (#12392)Patrick Cloke3-81/+3
And update the upgrade notes to point at old versions of the documentation.
2022-04-06Remove support for the unstable identifier from MSC3288. (#12398)Patrick Cloke2-2/+1
2022-04-06Narrow the `importlib_metadata` dependency (#12400)David Robertson2-1/+2
2022-04-06Fix `synapse_event_persisted_position` metric (#12390)Richard van der Hoff2-3/+4
Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`
2022-04-06Update type annotations for compatiblity with prometheus_client 0.14 (#12389)Richard van der Hoff8-18/+67
Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.
2022-04-06Generate historic pagination token for `/messages` when no `?from` token ↵Eric Eastwood6-15/+27
provided (#12370)
2022-04-05Add missing dependency on importlib_metadata (#12384)David Robertson4-1/+8
2022-04-05Poetry: initial pyproject.toml and poetry.lock (#12381)David Robertson4-0/+3062
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-04-05Post 1.56.0 release tidy up (#12379)Sean Quah3-2/+2
2022-04-05Update mdbook to 0.4.17 (#12339)Andrew Morgan2-1/+2
Update mdbook (the tool used to render the documentation website) to version 0.4.17.
2022-04-05Fix edge case where a `Linearizer` could get stuck (#12358)Sean Quah3-5/+53
Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Make `StreamToken` and `RoomStreamToken` methods propagate cancellations ↵Sean Quah2-0/+6
(#12366) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Update docstrings for `ReadWriteLock` tests (#12354)Sean Quah2-6/+7
Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Refactor and convert `Linearizer` to async (#12357)Sean Quah21-115/+104
Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Convert `Linearizer` tests from `inlineCallbacks` to async (#12353)Sean Quah2-91/+134
Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Prefill more stream change caches. (#12372)Erik Johnston6-61/+92
2022-04-05Add type hints to some tests files (#12371)Dirk Klimpel6-42/+58
2022-04-05Tweak CHANGES.md v1.56.0Sean Quah1-3/+1
2022-04-05Fix a spec compliance issue where requests to the `/publicRooms` federation ↵reivilibre2-2/+3
API would specify `limit` as a string. (#12364)
2022-04-05Allow specifying the Postgres database's port when running unit tests with ↵reivilibre4-3/+24
Postgres. (#12376)
2022-04-051.56.0Sean Quah5-6/+20
2022-04-05Pin signedjson to <= 1.1.1 as a temporary workaround for #12324Sean Quah1-1/+1
To be reverted after the Synapse 1.56 release. Signed-off-by: Sean Quah <seanq@element.io>
2022-04-05Bump `black` and `click` versions (#12320)David Robertson16-30/+37
2022-04-05Explain how to decipher live and historic pagination tokens (#12317)Eric Eastwood2-11/+86
2022-04-04Update broken link in `workers.md` (#12369)Shay2-1/+2
2022-04-04Allow non-member state sent in room batch to resolve for historic events ↵Eric Eastwood2-26/+13
(MSC2716) (#12329) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.
2022-04-04Prefill the device_list_stream_cache (#12367)Erik Johnston3-2/+23
* Prefill the device_list_stream_cache * Newsfile * Newsfile
2022-04-04Track device list updates per room. (#12321)Erik Johnston11-47/+390
This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.
2022-04-04Only upgrade pip in dhvirtualenvDavid Robertson1-4/+5
2022-04-03Remove more dead/broken dev scripts (#12355)David Robertson5-359/+1
2022-04-01Add type hints for `tests/unittest.py`. (#12347)Richard van der Hoff12-48/+97
In particular, add type hints for get_success and friends, which are then helpful in a bunch of places.
2022-04-01Remove redundant `get_success` calls in test code (#12346)Richard van der Hoff13-121/+74
There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.
2022-04-01Default to `private` room visibility rather than `public` when a client does ↵reivilibre5-7/+15
not specify one, according to spec. (#12350)
2022-04-01Burn `check_signature` dev script. (#12351)David Robertson4-74/+2
2022-04-01Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209)Nick Mills-Barrett6-113/+83
Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.
2022-04-01Remove `list_url_patterns` dev script (#12349)David Robertson3-61/+1
2022-04-01Move single-use methods out of `TestCase` (#12348)Richard van der Hoff4-27/+28
These methods are only used by a single testcase, so they shouldn't be cluttering up the base `TestCase` class.
2022-04-01Move `update_client_ip` background job from the main process to the ↵reivilibre10-153/+160
background worker. (#12251)
2022-04-01Raise an exception when getting state at an outlier (#12191)Richard van der Hoff4-22/+87
It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.
2022-04-01Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040)Richard van der Hoff4-9/+268
If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.
2022-04-01Docker: `pip install --user poetry` path fixDavid Robertson1-2/+2
2022-04-01Olddeps: cat patched pyproject, instead of diffingDavid Robertson1-1/+1
2022-04-01Add a module callback to react to account data changes (#12327)Brendan Abolivier7-2/+250
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
2022-04-01Add set_user_admin function to the module API (#12341)Amanda Graven3-0/+26
2022-03-31Move MSC2654 support behind an experimental configuration flag. (#12295)Patrick Cloke4-1/+12
To match the current thinking on disabling experimental features by default.
2022-03-31Handle outliers in `/federation/v1/event` (#12332)Richard van der Hoff3-106/+182
The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.
2022-03-31Add more type hints to the main state store. (#12267)Patrick Cloke4-10/+16
2022-03-31Olddeps: leave a TODO for caret boundsDavid Robertson1-6/+12
2022-03-31olddeps: echo patch to confirm sed is sensibleDavid Robertson1-0/+4
2022-03-31Explain where requirements.txt comes from.David Robertson1-0/+2
2022-03-31Add a callback to react to 3PID associations (#12302)Brendan Abolivier6-0/+92
2022-03-31More clearly explain which extras are omitted from `all`.David Robertson1-3/+4
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-03-31Recommend synapse_homeserver entrypoint in READMEDavid Robertson1-2/+2
2022-03-31Batch of suggestsion from Brendan, part 2David Robertson4-6/+4
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-03-31Batch of suggestsion from Brendan, part 1David Robertson4-8/+7
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-03-31Fix typos spotted by SeanDavid Robertson3-3/+2
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-03-31README-testing.md: fix minor errorRichard van der Hoff1-1/+1
2022-03-31Remove an unnecessary class from the relations code. (#12338)Patrick Cloke4-74/+32
The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.
2022-03-31Remove `dockerfile-pgtests` (#12336)David Robertson5-89/+1
2022-03-31Ignore .envrc for direnv users (#12335)David Robertson2-0/+4
2022-03-31Nuke the tox `packaging` job (#12334)David Robertson3-10/+2
2022-03-31Ensure the type of URL attributes is always str when matching against ↵Brendan Abolivier3-4/+49
preview blacklist (#12333)
2022-03-30Undebug various changesDavid Robertson3-23/+22
- Stop always running twisted trunk on this branch - Stop building all devs on this branch - Run olddeps after linting
2022-03-30DOCS: recommend poetry where appropriateDavid Robertson4-56/+51
In particular the documentaion for contributors should only advocate poetry. I am not thrilled at the propsect of now having N+1 installation methods---but at the very least we ought to mention poetry here.
2022-03-30ChangelogDavid Robertson2-0/+8
2022-03-30CI: Fix Twisted trunk to run under poetrySean Quah2-13/+38
Signed-off-by: Sean Quah <seanq@element.io>
2022-03-30CI: Fix the olddeps job to run under poetryDavid Robertson3-31/+57
2022-03-30CI: Fix the export-data job to run under poetryDavid Robertson2-16/+11
2022-03-30CI: Fix the portdb job to run under poetryDavid Robertson2-17/+11
2022-03-30CI: Fix the "main" trial test runsDavid Robertson1-13/+13
2022-03-30CI: Use common linting workflowDavid Robertson5-73/+14
After #12107 it's much easier for black, isort and flake8 to find the scripts we want them to lint.
2022-03-30BUILDS: `poetry` in deb virtualenvsShay3-1/+14
2022-03-30BUILDS: `poetry` in Synapse docker imageDavid Robertson3-29/+49
2022-03-30DEPS: Dirty duplication to make `all` workDavid Robertson2-5/+38
See comment in the toml file: > The duplication here is awful. I hate hate hate hate hate it. I don't think that we're going to be adding many extras any time soon, and I think this is the least bad option.
2022-03-30DEPS: Add missing dependency on importlib_metadataDavid Robertson1-0/+3
Missed in #12088. We got away with it because we were indirectly importing it in other places. Without this, we encounter pain in `poetry export`; and besides, we should be explicit about our direct dependencies.
2022-03-30DEPS: Specify deps in pyproject.tomlDavid Robertson11-400/+3033
- Nuke python_dependencies and setup.py - Allow commiting poetry.lock - Initial lockfile pulling in the latest version of deps at the time of locking
2022-03-30Remove the unused and unstable `/aggregations` endpoint. (#12293)Patrick Cloke6-478/+17
This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.
2022-03-30Send device list updates to application services (MSC3202) - part 1 (#11881)Andrew Morgan15-82/+490
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-30DEBUG: build all debsDavid Robertson1-3/+3
2022-03-30DEBUG: always run twisted trunk; don't raise bugsDavid Robertson1-18/+19
2022-03-30Flesh out documentation for running SyTest against Synapse, including use of ↵reivilibre2-1/+8
Postgres and worker mode. (#12271) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-30Update dead links in check-newsfragment.sh (#12331)David Robertson2-2/+3
2022-03-30Remove references to "msc2403" (#12165)Andrew Morgan5-5/+4
2022-03-30Start application service stream token tracking from 1 (#12193)Andrew Morgan4-4/+6
Co-authored-by: Erik Johnston <erik@matrix.org>
2022-03-30Disable proactive sends for remote joins (#12330)Richard van der Hoff2-0/+7
Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.
2022-03-30Add a configuration to exclude rooms from sync response (#12310)Brendan Abolivier7-21/+138
2022-03-29Fix typechecker problems exposed by signedjson 1.1.2 (#12326)David Robertson9-25/+38
2022-03-29Room batch: fix up handling of unknown prev_event_ids (#12316)Richard van der Hoff2-8/+14
2022-03-29Add note in changelog of non-C type locale causing Synapse to refuse to ↵Andrew Morgan1-0/+5
start (#12323)
2022-03-29Move warning of open registration to v1.56 upgrade notes (#12322)Andrew Morgan3-7/+18
2022-03-29Update `LoggingTransaction.call_after` and `call_on_exception` docstrings ↵Sean Quah2-3/+21
(#12315) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>
2022-03-29Bump `black` and `click` versions (#12320)David Robertson16-30/+37
2022-03-29Missing period v1.56.0rc1Brendan Abolivier1-1/+1
2022-03-29Fix formattingBrendan Abolivier1-1/+1
2022-03-29Link to pre-1.0 changelogBrendan Abolivier1-0/+2
2022-03-29Linkify MSCsBrendan Abolivier1-2/+2
2022-03-29Split changelogsBrendan Abolivier2-3642/+3640
2022-03-29Fixup changelogBrendan Abolivier1-13/+13
2022-03-291.56.0rc1Brendan Abolivier46-44/+66
2022-03-29Remove unused `auth_event_ids` argument plumbing (#12304)Eric Eastwood3-27/+1
Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`
2022-03-28Exclude outliers in `on_backfill_request` (#12314)Richard van der Hoff2-3/+10
When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.
2022-03-28Add some type hints to datastore. (#12255)Dirk Klimpel10-42/+61
2022-03-28Un-revert Jinja2 fix (#12313)Brendan Abolivier3-6/+10
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
2022-03-28Allow modules to store already existing 3PID associations (#12195)Brendan Abolivier2-1/+27
2022-03-28Improve type annotations for `execute_values`. (#12311)reivilibre2-10/+8
2022-03-28HAProxy guide update (#12279)villepeh2-2/+3
HAproxy reverse proxy guide update to stop sending IPv4-mapped address to HS.
2022-03-25Add restrictions by default to open registration in Synapse (#12091)Shay7-4/+67
2022-03-25Add cache for `get_membership_from_event_ids` (#12272)Erik Johnston6-22/+72
This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>
2022-03-25Enhance logging for inbound federation events (#12301)Richard van der Hoff2-1/+2
It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.
2022-03-25Refactor `create_new_client_event` to use a new parameter, ↵Eric Eastwood5-65/+165
`state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)
2022-03-25Always allow the empty string as an avatar_url. (#12261)David Robertson4-0/+32
Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-25Authentik OpenID minor doc update (#12275)IronTooch2-1/+4
2022-03-25Mention the new behaviour on unsafe database locale in the upgrade notes ↵Brendan Abolivier2-0/+8
(#12288) Co-authored-by: Shay <hillerys@element.io>
2022-03-24Re-enable test concurrency on Complement (#12283)kegsay2-1/+2
2022-03-24Remove unused test code. (#12291)Patrick Cloke2-110/+1
The `MockHttpResource` and `MockKey` objects were unused since #9396 (74af356baf79de5d719fad6c32b981eedbdd950d).
2022-03-24changelog v1.55.2Richard van der Hoff1-1/+1
2022-03-241.55.2Richard van der Hoff4-2/+19
2022-03-24Pin Jinja to <3.1.0 (#12297)Andrew Morgan2-1/+3
as 3.1.0 removed the deprecated jinja2.Markup class which we still rely on.
2022-03-24Revert "Replace instances of deprecated `Jinja2.Markup` with ↵Andrew Morgan2-6/+4
`markupsafe.Markup`" (#12296) This reverts commit 8810c93e828a9ed1dcb008d08be8aa9fcb4d28c3.
2022-03-24update changelog for 1.55.1 v1.55.1Andrew Morgan1-2/+2
2022-03-241.55.1Andrew Morgan4-2/+18
2022-03-24Replace instances of deprecated `Jinja2.Markup` with `markupsafe.Markup` ↵Andrew Morgan3-4/+7
(#12289) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-24Do not consider events by ignored users for relations (#12285)Patrick Cloke7-4/+90
Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).
2022-03-24Optionally include account validity in MSC3720 account status responses (#12266)Brendan Abolivier4-1/+73
2022-03-23Refuse to start if DB has an unsafe locale (#12262)Shay6-18/+93
2022-03-23Use psycopg2 type stubs (#12269)David Robertson4-4/+14
2022-03-23Remove mutual_rooms `update_user_directory` check, and add extra ↵Jonathan de Jong3-5/+17
documentation (#12038) Resolves #10339
2022-03-23Allow registering admin users using the module API (#12250)Nicolas Werner3-0/+15
Signed-off-by: Nicolas Werner <n.werner@famedly.com>
2022-03-23Rename shared_rooms to mutual_rooms (#12036)Jonathan de Jong5-25/+27
Co-authored-by: reivilibre <olivier@librepush.net>
2022-03-22Changelog: sso -> Single Sign-On v1.55.0Andrew Morgan1-1/+1
2022-03-22changelog: move notice from rc to final releaseAndrew Morgan1-4/+5
2022-03-221.55.0Andrew Morgan5-3/+16
2022-03-22Tweak copy for sso account details template (#12265)Michael Telatynski4-6/+7
* Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2022-03-21Call out synctl changeDavid Robertson1-1/+3
2022-03-21Add type hints to tests files. (#12256)Dirk Klimpel6-88/+101
2022-03-21Reword 'Choose your user name' as 'Choose your account name' in the SSO ↵reivilibre2-1/+2
registration template, in order to comply with SIWA guidelines. (#12260) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2022-03-21Make it possible to enable compression for the metrics HTTP resource (#12258)Nick Mills-Barrett2-1/+5
* Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint
2022-03-21Return a 404 from `/state` for an outlier (#12087)Richard van der Hoff3-44/+25
* Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier
2022-03-18Try to detect borked package installations. (#12244)David Robertson3-2/+38
* Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
2022-03-18Move get_bundled_aggregations to relations handler. (#12237)Patrick Cloke9-157/+173
The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.
2022-03-18Only fetch thread participation for events with threads. (#12228)Patrick Cloke4-245/+289
We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.
2022-03-18Sync more worker regexes in the documentation. (#12243)Patrick Cloke2-16/+15
2022-03-18Add some type hints to datastore (#12248)Dirk Klimpel4-84/+117
* inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-18Correct `check_username_for_spam` annotations and docs (#12246)David Robertson8-16/+46
* Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
2022-03-17Generate announcement links in release script (#12242)David Robertson2-1/+41
2022-03-17Add type hints to more tests files. (#12240)Dirk Klimpel6-47/+66
2022-03-16Re-generate changelog. v1.55.0rc1Patrick Cloke2-1/+1
2022-03-16Fix bundling aggregations if unsigned is not a returned event field. (#12234)Patrick Cloke3-3/+35
An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.
2022-03-16Handle cancellation in `DatabasePool.runInteraction()` (#12199)Sean Quah3-24/+96
To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>
2022-03-16Add a relations handler to avoid duplication. (#12227)Patrick Cloke5-69/+134
Adds a handler layer between the REST and datastore layers for relations.
2022-03-16Add some missing type hints to cache datastore. (#12216)Patrick Cloke2-21/+37
2022-03-16Fix dead link in spam checker warning (#12231)David Robertson2-2/+3
2022-03-16Refactor relations tests (#12232)Patrick Cloke2-406/+364
* Moves the relation pagination tests to a separate class. * Move the assertion of the response code into the `_send_relation` helper. * Moves some helpers into the base-class.
2022-03-16Clean-up logic for rebasing URLs during URL preview. (#12219)Patrick Cloke4-91/+26
By using urljoin from the standard library and reducing the number of places URLs are rebased.
2022-03-15Use the ignored_users table to test event visibility & sync. (#12225)Patrick Cloke6-47/+62
Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.
2022-03-15Add tests for database transaction callbacks (#12198)Sean Quah2-1/+104
Signed-off-by: Sean Quah <seanq@element.io>
2022-03-15Add type hints to some tests/handlers files. (#12224)Dirk Klimpel7-131/+156
2022-03-15Changelog tweaksDavid Robertson1-4/+6
2022-03-151.55.0rc1David Robertson65-63/+89
2022-03-14Add cancellation support to `@cached` and `@cachedList` decorators (#12183)Sean Quah3-2/+157
These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>
2022-03-14Add cancellation support to `ReadWriteLock` (#12120)Sean Quah4-93/+382
Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>
2022-03-14Fix broken background updates when using sqlite with `enable_search` off ↵Sean Quah2-6/+8
(#12215) Signed-off-by: Sean Quah <seanq@element.io>
2022-03-14Add `delay_cancellation` utility function (#12180)Sean Quah3-12/+161
`delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>
2022-03-12Deprecate the groups/communities endpoints and add an experimental ↵Patrick Cloke7-7/+35
configuration flag. (#12200)
2022-03-11Add config settings for background update parameters (#11980)Shay9-34/+430
2022-03-11Implement a Jinja2 filter to extract localparts from email addresses (#12212)Brendan Abolivier6-2/+23
2022-03-11Improve code documentation for the typing stream over replication. (#12211)reivilibre5-6/+20
2022-03-11Add an additional HTTP pusher + push rule tests. (#12188)Nick Mills-Barrett5-28/+95
And rename the field used for caching from _id to _cache_key.
2022-03-11Update the SSO username picker template to comply with SIWA guidelines (#12210)Brendan Abolivier8-13/+47
Fixes https://github.com/matrix-org/synapse/issues/12205
2022-03-11Add type hints to `tests/rest`. (#12208)Dirk Klimpel5-85/+129
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-11Add some type hints to the tests.handlers module. (#12207)Patrick Cloke7-61/+74
2022-03-11Remove unnecessary pass statements. (#12206)Patrick Cloke11-15/+1
2022-03-11Note that contributors can sign off privately (#12204)Andrew Morgan2-0/+12
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2022-03-11Retention test: avoid relying on state at purged events (#12202)Richard van der Hoff2-12/+18
This test was relying on poking events which weren't in the database into filter_events_for_client.
2022-03-10Document that most streams can only have a single writer. (#12196)~creme2-14/+18
This includes the `typing`, `to_device`, `account_data`, `receipts`, and `presence` streams (really anything except the `events` stream).
2022-03-10fix misleading comment in `check_events_for_spam` (#12203)Shay2-2/+3
2022-03-10Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir ↵reivilibre3-7/+9
compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700)
2022-03-10Support stable identifiers for MSC3440: Threading (#12151)Patrick Cloke13-81/+109
The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.
2022-03-10Updates to the Room DAG concepts development document (#12179)Richard van der Hoff2-18/+54
Some stuff that came up while we were talking about #12173.
2022-03-10Allow retrieving the relations of a redacted event. (#12130)Patrick Cloke8-83/+122
This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).
2022-03-10Rename get_tcp_replication to get_replication_command_handler. (#12192)Patrick Cloke15-19/+20
Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.
2022-03-09Remove dead code in `tests/storage/test_database.py` (#12197)Sean Quah2-16/+1
Signed-off-by: Sean Quah <seanq@element.io>
2022-03-09Add third_party module callbacks to check if a user can delete a room and ↵Will Hunt8-1/+254
deactivate a user (#12028) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
2022-03-09Allow for ignoring some arguments when caching. (#12189)Patrick Cloke4-21/+142
* `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)
2022-03-09Remove some unused variables/parameters. (#12187)Patrick Cloke2-9/+6
2022-03-09Retry some http replication failures (#12182)Nick Mills-Barrett2-11/+37
This allows for the target process to be down for around a minute which provides time for restarts during synapse upgrades/config updates. Closes: #12178 Signed off by Nick Mills-Barrett nick@beeper.com
2022-03-09Skip attempt to get state at backwards-extremities (#12173)Richard van der Hoff2-57/+4
We don't *have* the state at a backwards-extremity, so this is never going to do anything useful.
2022-03-08Clean-up demo scripts & documentation (#12143)Patrick Cloke9-71/+89
* Rewrites the demo documentation to be clearer, accurate, and moves it to our documentation tree. * Improvements to the demo scripts: * `clean.sh` now runs `stop.sh` first to avoid zombie processes. * Uses more modern Synapse configuration (and removes some obsolete configuration). * Consistently use the HTTP ports for server name, etc. * Remove the `demo/etc` directory and place everything into the `demo/808x` directories.
2022-03-08Use `ParamSpec` in type hints for `synapse.logging.context` (#12150)Sean Quah5-25/+37
Signed-off-by: Sean Quah <seanq@element.io>
2022-03-08Fix CI not attaching source distributions and wheels to the GitHub releases. ↵reivilibre2-1/+3
(#12131)
2022-03-08Fix silly markdown typo v1.54.0Olivier Wilkinson (reivilibre)1-1/+1