summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Cap the version of prometheus_client to <v0.9.0 in the dockerfile (#8767)Andrew Morgan2020-11-173-1/+7
| | | Short-term fix for https://github.com/matrix-org/synapse/issues/8766.
* Fix changelog v1.23.0rc1Erik Johnston2020-11-131-4/+4
|
* Fix changelogErik Johnston2020-11-131-2/+2
|
* 1.23.0rc1Erik Johnston2020-11-1371-70/+87
|
* Migrate documentation `docs/admin_api/event_reports` to markdown (#8742)Dirk Klimpel2020-11-133-165/+173
| | | Related to #8714. `event_reports.rst` was introduced in Synapse 1.21.0.
* SAML: add <mdui:UIInfo> element examples (#8718)Marcus Schopen2020-11-133-0/+45
| | | add some mdui:UIInfo element examples for saml2_config in homeserver.yaml
* Updating README.rst (#8746)chagai952020-11-132-6/+11
| | | Minor corrections and advice... Should help beginners.
* Add metrics for tracking 3PID /requestToken requests. (#8712)Erik Johnston2020-11-134-0/+33
| | | | | | The main use case is to see how many requests are being made, and how many are second/third/etc attempts. If there are large number of retries then that likely indicates a delivery problem.
* Fix port script so that it can be run again after failure. (#8755)Erik Johnston2020-11-132-30/+55
| | | | | | | If the script fails (or is CTRL-C'ed) between porting some of the events table and copying of the sequences then the port script will immediately die if run again due to the postgres DB having inconsistencies between sequences and tables. The fix is to move the porting of sequences to before porting the tables, so that there is never a period where the Postgres DB is inconsistent. To do that we need to change how we port the sequences so that it calculates the values from the SQLite DB rather than the Postgres DB. Fixes #8619
* Cache event ID to auth event IDs lookups (#8752)Erik Johnston2020-11-132-12/+71
| | | | | This should hopefully speed up `get_auth_chain_difference` a bit in the case of repeated state res on the same rooms. `get_auth_chain_difference` does a breadth first walk of the auth graphs by repeatedly looking up events' auth events. Different state resolutions on the same room will end up doing a lot of the same event to auth events lookups, so by caching them we should speed things up in cases of repeated state resolutions on the same room.
* Enable reconnection in DB pool (#8726)Erik Johnston2020-11-122-1/+7
| | | | | | `adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574
* Fix port script fails when DB has no backfilled events. (#8729)Erik Johnston2020-11-112-7/+6
| | | Fixes #8618
* Fix port script to handle foreign key constraints (#8730)Erik Johnston2020-11-113-6/+63
|
* Check support room has only two users before sending a notice (#8728)Will Hunt2020-11-112-1/+2
| | | | | | | | | | | * Check support room has only two users * Create 8728.bugfix * Update synapse/server_notices/server_notices_manager.py Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
* Better error message when a remote resource uses invalid Content-Type (#8719)Andrew Morgan2020-11-112-2/+9
|
* Catch exceptions in password_providers (#8636)Nicolai Søborg2020-11-112-4/+10
| | | Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>
* Notes on SSO logins and media_repository worker (#8701)Marcus Schopen2020-11-062-0/+6
| | | | | | | If SSO login is used (e.g. SAML) in a multi worker setup, it should be mentioned that currently all SAML logins must run on the same worker, see https://github.com/matrix-org/synapse/issues/7530 Also, if you are using different ports (for example 443 and 8448) in a reverse proxy for client and federation, the path `/_matrix/media` on the client and federation port must point to the listener of the `media_repository` worker, otherwise you'll get a 404 on the federation port for the path `/_matrix/media`, if a remote server is trying to get the media object on federation port, see https://github.com/matrix-org/synapse/issues/8695
* Add documentation about documentation to CONTRIBUTING.md (#8714)Andrew Morgan2020-11-062-0/+19
| | | | | | This PR adds some documentation that: * Describes who the audience for the `docs/`, `docs/dev/` and `docs/admin/` directories are, as well as Synapse's wiki page. * Stresses that we'd like all documentation to be down in markdown.
* Fix SIGHUP handler (#8697)Richard van der Hoff2020-11-062-3/+3
| | | | | | | Fixes: ``` builtins.TypeError: _reload_logging_config() takes 1 positional argument but 2 were given ```
* Add an admin API for users' media statistics (#8700)Dirk Klimpel2020-11-056-0/+820
| | | | | | | | Add `GET /_synapse/admin/v1/statistics/users/media` to get statisics about local media usage by users. Related to #6094 It is the first API for statistics. Goal is to avoid/reduce usage of sql queries like [Wiki analyzing Synapse](https://github.com/matrix-org/synapse/wiki/SQL-for-analyzing-Synapse-PostgreSQL-database-stats) Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Add `displayname` to Shared-Secret Registration for admins (#8722)Dirk Klimpel2020-11-055-9/+138
| | | Add `displayname` to Shared-Secret Registration for admins to `POST /_synapse/admin/v1/register`
* Consolidate purge table lists to prevent desyncronisation (#8713)Andrew Morgan2020-11-042-67/+39
| | | I idly noticed that these lists were out of sync with each other, causing us to miss a table in a test case (`local_invites`). Let's consolidate this list instead to prevent this from happening in the future.
* Remove the "draft" status of the Room Details Admin API (#8702)Dirk Klimpel2020-11-032-3/+2
| | | Fixes #8550
* Block clients from sending server ACLs that lock the local server out. (#8708)Erik Johnston2020-11-035-9/+80
| | | Fixes #4042
* Document how to set up multiple event persisters (#8706)Erik Johnston2020-11-032-0/+13
|
* grammarMatthew Hodgson2020-11-021-1/+1
|
* Improve error messages of non-str displayname/avatar_url (#8705)Andrew Morgan2020-11-022-2/+7
| | | | | | | | This PR fixes two things: * Corrects the copy/paste error of telling the client their displayname is wrong when they are submitting an `avatar_url`. * Returns a `M_INVALID_PARAM` instead of `M_UNKNOWN` for non-str type parameters. Reported by @t3chguy.
* Add base pushrule to notify for jitsi conferences (#8286)David Baker2020-11-022-0/+25
| | | This could be customised to trigger a different kind of notification in the future, but for now it's a normal non-highlight one.
* Use Python 3.8 in Docker images by default (#8698)Dan Callahan2020-11-022-1/+2
| | | | | | | This bumps us closer to current Python without going all the way to 3.9. Fixes #8674 Signed-off-by: Dan Callahan <danc@element.io>
* Improve start time by adding index to e2e_cross_signing_keys (#8694)Erik Johnston2020-11-024-2/+36
| | | We do a `SELECT MAX(stream_id) FROM e2e_cross_signing_keys` on startup.
* typoMatthew Hodgson2020-11-021-1/+1
|
* Fix typos in systemd-with-workers docAndrew Morgan2020-11-021-2/+2
|
* Fix typo in workers docAndrew Morgan2020-11-021-1/+1
|
* Fix error handling around when completing an AS transaction (#8693)Brendan Abolivier2020-10-302-1/+2
|
* Merge branch 'master' into developErik Johnston2020-10-305-3/+17
|\
| * Fix changelog v1.22.1 github/release-v1.22.1 release-v1.22.1Erik Johnston2020-10-301-2/+2
| |
| * use correct versionErik Johnston2020-10-302-2/+2
| |
| * 1.22.1Erik Johnston2020-10-304-2/+16
| |
* | Merge branch 'release-v1.22.1' into developErik Johnston2020-10-300-0/+0
|\|
| * Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-307-40/+32
| | | | | | Fix serialisation errors when using third-party event rules.
| * Tie together matches_user_in_member_list and get_users_in_room caches (#8676)Will Hunt2020-10-302-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove **kwargs * Update 8676.bugfix
* | Improve the sample config for SSO (OIDC, SAML, and CAS). (#8635)Patrick Cloke2020-10-305-104/+157
| |
* | Implement and use an @lru_cache decorator (#8595)Richard van der Hoff2020-10-304-61/+272
| | | | | | We don't always need the full power of a DeferredCache.
* | Fail test cases if they fail to await all awaitables (#8690)Patrick Cloke2020-10-303-2/+39
| |
* | Fix race for concurrent downloads of remote media. (#8682)Erik Johnston2020-10-306-71/+431
| | | | | | Fixes #6755
* | Fix optional parameter in stripped state storage method (#8688)Andrew Morgan2020-10-302-1/+2
| | | | | | Missed in #8671.
* | Fix unit tests (#8689)Erik Johnston2020-10-292-1/+2
| | | | | | | | | | * Fix unit tests * Newsfile
* | Tie together matches_user_in_member_list and get_users_in_room caches (#8676)Will Hunt2020-10-292-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | * Tie together matches_user_in_member_list and get_users_in_room * changelog * Remove type to fix mypy * Add `on_invalidate` to the function signature in the hopes that may make things work well * Remove **kwargs * Update 8676.bugfix
* | Gracefully handle a pending logging connection during shutdown. (#8685)Patrick Cloke2020-10-295-10/+36
| |
* | Add ability for access tokens to belong to one user but grant access to ↵Erik Johnston2020-10-2922-138/+197
| | | | | | | | | | | | | | | | | | | | another user. (#8616) We do it this way round so that only the "owner" can delete the access token (i.e. `/logout/all` by the "owner" also deletes that token, but `/logout/all` by the "target user" doesn't). A future PR will add an API for creating such a token. When the target user and authenticated entity are different the `Processed request` log line will be logged with a: `{@admin:server as @bob:server} ...`. I'm not convinced by that format (especially since it adds spaces in there, making it harder to use `cut -d ' '` to chop off the start of log lines). Suggestions welcome.
* | Fix cache call signature to accept `on_invalidate`. (#8684)Erik Johnston2020-10-293-16/+35
| | | | | | Cached functions accept an `on_invalidate` function, which we failed to add to the type signature. It's rarely used in the files that we have typed, which is why we haven't noticed it before.
* | Use `%r` rather than `%s` for stringifying events (#8679)Richard van der Hoff2020-10-292-2/+3
| | | | | | | | otherwise non-state events get written as `<FrozenEvent ... state_key='None'>` which is indistinguishable from state events with the actual state_key `None`.
* | Optimise createRoom with multiple invites (#8559)Richard van der Hoff2020-10-293-13/+25
| | | | | | | | | | By not dropping the membership lock between invites, we can stop joins from grabbing the lock when we're half-done and slowing the whole thing down.
* | Support generating structured logs in addition to standard logs. (#8607)Patrick Cloke2020-10-2919-1011/+706
| | | | | | | | | | | | | | This modifies the configuration of structured logging to be usable from the standard Python logging configuration. This also separates the formatting of logs from the transport allowing JSON logs to files or standard logs to sockets.
* | Don't require hiredis to run unit tests (#8680)Erik Johnston2020-10-292-1/+11
| |
* | Merge pull request #8678 from matrix-org/rav/fix_frozen_eventsRichard van der Hoff2020-10-287-40/+32
|\ \ | | | | | | Fix serialisation errors when using third-party event rules.
| * | remove unused importsRichard van der Hoff2020-10-281-2/+0
| | |
| * | Remove frozendict_json_encoder and support frozendicts everywhereRichard van der Hoff2020-10-287-38/+32
| |/ | | | | | | | | | | Not being able to serialise `frozendicts` is fragile, and it's annoying to have to think about which serialiser you want. There's no real downside to supporting frozendicts, so let's just have one json encoder.
* | Add type hints to application services. (#8655)Patrick Cloke2020-10-285-79/+122
| |
* | Add an admin APIs to allow server admins to list users' pushers (#8610)Dirk Klimpel2020-10-285-1/+259
| | | | | | Add an admin API `GET /_synapse/admin/v1/users/<user_id>/pushers` like https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-pushers
* | Run mypy as part of the lint.sh script. (#8633)kleph2020-10-283-2/+4
| |
* | Don't pull event from DB when handling replication traffic. (#8669)Erik Johnston2020-10-285-31/+87
| | | | | | | | | | I was trying to make it so that we didn't have to start a background task when handling RDATA, but that is a bigger job (due to all the code in `generic_worker`). However I still think not pulling the event from the DB may help reduce some DB usage due to replication, even if most workers will simply go and pull that event from the DB later anyway. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Tell Black to format code for Python 3.5 (#8664)Dan Callahan2020-10-2710-11/+12
| | | | | | | | | | | | | | | | This allows trailing commas in multi-line arg lists. Minor, but we might as well keep our formatting current with regard to our minimum supported Python version. Signed-off-by: Dan Callahan <danc@element.io>
* | Minor updates to docs on how to run tests (#8666)Dan Callahan2020-10-273-10/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The test runner isn't present in the `[all]` set of extras, so the previous instructions did not work without also installing `[test]`. Note that this does not include the `[lint]` extras, since those do not install on all supported Python versions (specifically, isort 5.x requires Python 3.6, while we still support 3.5). Instructions for that are included in our pull request template, so we should be fine there. I've also dropped the `--no-use-pep517` arg to `pip install` since it seems to have been added to address a temporary regression in pip 19.1 which was fixed in pip 19.1.1 the following month. Lastly, updated the example output of the test suite to set more realistic expectations around run time. Signed-off-by: Dan Callahan <danc@element.io>
* | Note support for Python 3.9 (#8665)Dan Callahan2020-10-274-2/+4
| | | | | | | | | | As expected, all tests pass locally without modification. Signed-off-by: Dan Callahan <danc@element.io>
* | Cross-link documentation to the prometheus recording rules. (#8667)Michael Kaye2020-10-273-1/+4
| |
* | Abstract code for stripping room state into a separate method (#8671)Andrew Morgan2020-10-273-29/+61
| | | | | | | | | | | | | | | | | | | | | | This is a requirement for [knocking](https://github.com/matrix-org/synapse/pull/6739), and is abstracting some code that was originally used by the invite flow. I'm separating it out into this PR as it's a fairly contained change. For a bit of context: when you invite a user to a room, you send them [stripped state events](https://matrix.org/docs/spec/server_server/unstable#put-matrix-federation-v2-invite-roomid-eventid) as part of `invite_room_state`. This is so that their client can display useful information such as the room name and avatar. The same requirement applies to knocking, as it would be nice for clients to be able to display a list of rooms you've knocked on - room name and avatar included. The reason we're sending membership events down as well is in the case that you are invited to a room that does not have an avatar or name set. In that case, the client should use the displayname/avatar of the inviter. That information is located in the inviter's membership event. This is optional as knocks don't really have any user in the room to link up to. When you knock on a room, your knock is sent by you and inserted into the room. It wouldn't *really* make sense to show the avatar of a random user - plus it'd be a data leak. So I've opted not to send membership events to the client here. The UX on the client for when you knock on a room without a name/avatar is a separate problem. In essence this is just moving some inline code to a reusable store method.
* | Don't unnecessarily start bg process in replication sending loop. (#8670)Erik Johnston2020-10-272-0/+11
| |
* | Don't unnecessarily start bg process while handling typing. (#8668)Erik Johnston2020-10-272-8/+14
| | | | | | There's no point starting a background process when all its going to do is bail if federation isn't enabled.
* | Add admin API to list users' local media (#8647)Dirk Klimpel2020-10-278-1/+494
| | | | | | Add admin API `GET /_synapse/admin/v1/users/<user_id>/media` to get information of users' uploaded files.
* | Merge branch 'master' into developErik Johnston2020-10-273-1/+13
|\|
| * 1.22.0 v1.22.0 github/release-v1.22.0 release-v1.22.0Erik Johnston2020-10-273-1/+13
| |
* | e2e: ensure we have both master and self-signing key (#8455)Jonas Jelten2020-10-262-5/+23
| | | | | | | | | | | | | | it seems to be possible that only one of them ends up to be cached. when this was the case, the missing one was not fetched via federation, and clients then failed to validate cross-signed devices. Signed-off-by: Jonas Jelten <jj@sft.lol>
* | Add type hints for account validity handler (#8620)Patrick Cloke2020-10-266-12/+31
| | | | | | This also fixes a bug by fixing handling of an account which doesn't expire.
* | Split admin API for reported events into a detail and a list view (#8539)Dirk Klimpel2020-10-266-86/+411
| | | | | | | | | | | | | | | | | | | | | | | | Split admin API for reported events in detail und list view. API was introduced with #8217 in synapse v.1.21.0. It makes the list (`GET /_synapse/admin/v1/event_reports`) less complex and provides a better overview. The details can be queried with: `GET /_synapse/admin/v1/event_reports/<report_id>`. It is similar to room and users API. It is a kind of regression in `GET /_synapse/admin/v1/event_reports`. `event_json` was removed. But the api was introduced one version before and it is an admin API (not under spec). Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Added basic instructions for Azure AD to OpenId documentation (#8582)Peter Krantz2020-10-262-0/+27
| | | | | | Signed-off-by: Peter Krantz peter.krantz@gmail.com
* | Add an admin api to delete local media. (#8519)Dirk Klimpel2020-10-267-3/+868
| | | | | | | | | | | | Related to: #6459, #3479 Add `DELETE /_synapse/admin/v1/media/<server_name>/<media_id>` to delete a single file from server.
* | Fix filepath of Dex example config (#8657)Andrew Morgan2020-10-262-3/+3
| |
* | Fix a bug in the joined_rooms admin API (#8643)Dirk Klimpel2020-10-263-4/+20
| | | | | | | | If the user was not in any rooms then the API returned the same error as if the user did not exist.
* | Merge tag 'v1.22.0rc2' into developErik Johnston2020-10-265-4/+10
|\| | | | | | | | | | | | | | | | | | | | | Synapse 1.22.0rc2 (2020-10-26) ============================== Bugfixes -------- - Fix bugs where ephemeral events were not sent to appservices. Broke in v1.22.0rc1. ([\#8648](https://github.com/matrix-org/synapse/issues/8648), [\#8656](https://github.com/matrix-org/synapse/issues/8656)) - Fix `user_daily_visits` table to not have duplicate rows per user/device due to multiple user agents. Broke in v1.22.0rc1. ([\#8654](https://github.com/matrix-org/synapse/issues/8654))
| * Fixup changelog v1.22.0rc2Erik Johnston2020-10-261-3/+1
| |
| * Expand changelog entryErik Johnston2020-10-261-1/+1
| |
| * 1.22.0rc2Erik Johnston2020-10-265-4/+12
| |
* | Merge branch 'release-v1.22.0' into developErik Johnston2020-10-264-7/+11
|\|
| * Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-264-13/+85
| |
| * Properly handle presence events for application services. (#8656)Patrick Cloke2020-10-262-4/+6
| |
| * Fix user_daily_visits to not have duplicate rows for UA. (#8654)Erik Johnston2020-10-262-4/+6
| | | | | | | | | | | | | | | | | | | | | | * Fix user_daily_visits to not have duplicate rows for UA. Fixes #8641. * Newsfile * Fix typo. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix get|set_type_stream_id_for_appservice store functions (#8648)Will Hunt2020-10-264-13/+85
| |
* | Correct the package name in OpenID Connect install instructions (#8634)Andrew Morgan2020-10-262-1/+2
|\ \ | | | | | | The OpenID Connect install instructions suggested installing `synapse[oidc]`, but our PyPI package is called `matrix-synapse`.
| * | ChangelogAndrew Morgan2020-10-221-0/+1
| | |
| * | Correct the package name in authlib install instructionsAndrew Morgan2020-10-221-1/+1
| | |
* | | Add field `total` to device list in admin API (#8644)Dirk Klimpel2020-10-264-2/+23
| | |
* | | Check status codes that profile handler returns (#8580)LEdoian2020-10-262-0/+8
| | | | | | | | | | | | | | | | | | | | | Fixes #8520 Signed-off-by: Pavel Turinsky <pavel.turinsky@matfyz.cz> Co-authored-by: Erik Johnston <erikj@jki.re>
* | | Start fewer opentracing spans (#8640)Erik Johnston2020-10-268-53/+96
| | | | | | | | | | | | | | | | | | | | | #8567 started a span for every background process. This is good as it means all Synapse code that gets run should be in a span (unless in the sentinel logging context), but it means we generate about 15x the number of spans as we did previously. This PR attempts to reduce that number by a) not starting one for send commands to Redis, and b) deferring starting background processes until after we're sure they're necessary. I don't really know how much this will help.
* | | Fix typos and spelling errors. (#8639)Patrick Cloke2020-10-2341-60/+63
| | |
* | | Fix handling of User-Agent headers with bad utf-8. (#8632)Erik Johnston2020-10-238-28/+33
| | |
* | | Fix email notifications for invites without local state. (#8627)Erik Johnston2020-10-233-13/+58
|/ / | | | | | | This can happen if e.g. the room invited into is no longer on the server (or if all users left the room).
* | Merge tag 'v1.22.0rc1' into developErik Johnston2020-10-2289-88/+101
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.22.0rc1 (2020-10-22) ============================== Features -------- - Add a configuration option for always using the "userinfo endpoint" for OpenID Connect. This fixes support for some identity providers, e.g. GitLab. Contributed by Benjamin Koch. ([\#7658](https://github.com/matrix-org/synapse/issues/7658)) - Add ability for `ThirdPartyEventRules` modules to query and manipulate whether a room is in the public rooms directory. ([\#8292](https://github.com/matrix-org/synapse/issues/8292), [\#8467](https://github.com/matrix-org/synapse/issues/8467)) - Add support for olm fallback keys ([MSC2732](https://github.com/matrix-org/matrix-doc/pull/2732)). ([\#8312](https://github.com/matrix-org/synapse/issues/8312), [\#8501](https://github.com/matrix-org/synapse/issues/8501)) - Add support for running background tasks in a separate worker process. ([\#8369](https://github.com/matrix-org/synapse/issues/8369), [\#8458](https://github.com/matrix-org/synapse/issues/8458), [\#8489](https://github.com/matrix-org/synapse/issues/8489), [\#8513](https://github.com/matrix-org/synapse/issues/8513), [\#8544](https://github.com/matrix-org/synapse/issues/8544), [\#8599](https://github.com/matrix-org/synapse/issues/8599)) - Add support for device dehydration ([MSC2697](https://github.com/matrix-org/matrix-doc/pull/2697)). ([\#8380](https://github.com/matrix-org/synapse/issues/8380)) - Add support for [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409), which allows sending typing, read receipts, and presence events to appservices. ([\#8437](https://github.com/matrix-org/synapse/issues/8437), [\#8590](https://github.com/matrix-org/synapse/issues/8590)) - Change default room version to "6", per [MSC2788](https://github.com/matrix-org/matrix-doc/pull/2788). ([\#8461](https://github.com/matrix-org/synapse/issues/8461)) - Add the ability to send non-membership events into a room via the `ModuleApi`. ([\#8479](https://github.com/matrix-org/synapse/issues/8479)) - Increase default upload size limit from 10M to 50M. Contributed by @Akkowicz. ([\#8502](https://github.com/matrix-org/synapse/issues/8502)) - Add support for modifying event content in `ThirdPartyRules` modules. ([\#8535](https://github.com/matrix-org/synapse/issues/8535), [\#8564](https://github.com/matrix-org/synapse/issues/8564)) Bugfixes -------- - Fix a longstanding bug where invalid ignored users in account data could break clients. ([\#8454](https://github.com/matrix-org/synapse/issues/8454)) - Fix a bug where backfilling a room with an event that was missing the `redacts` field would break. ([\#8457](https://github.com/matrix-org/synapse/issues/8457)) - Don't attempt to respond to some requests if the client has already disconnected. ([\#8465](https://github.com/matrix-org/synapse/issues/8465)) - Fix message duplication if something goes wrong after persisting the event. ([\#8476](https://github.com/matrix-org/synapse/issues/8476)) - Fix incremental sync returning an incorrect `prev_batch` token in timeline section, which when used to paginate returned events that were included in the incremental sync. Broken since v0.16.0. ([\#8486](https://github.com/matrix-org/synapse/issues/8486)) - Expose the `uk.half-shot.msc2778.login.application_service` to clients from the login API. This feature was added in v1.21.0, but was not exposed as a potential login flow. ([\#8504](https://github.com/matrix-org/synapse/issues/8504)) - Fix error code for `/profile/{userId}/displayname` to be `M_BAD_JSON`. ([\#8517](https://github.com/matrix-org/synapse/issues/8517)) - Fix a bug introduced in v1.7.0 that could cause Synapse to insert values from non-state `m.room.retention` events into the `room_retention` database table. ([\#8527](https://github.com/matrix-org/synapse/issues/8527)) - Fix not sending events over federation when using sharded event writers. ([\#8536](https://github.com/matrix-org/synapse/issues/8536)) - Fix a long standing bug where email notifications for encrypted messages were blank. ([\#8545](https://github.com/matrix-org/synapse/issues/8545)) - Fix increase in the number of `There was no active span...` errors logged when using OpenTracing. ([\#8567](https://github.com/matrix-org/synapse/issues/8567)) - Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed. ([\#8585](https://github.com/matrix-org/synapse/issues/8585)) - Fix appservice transactions to only include a maximum of 100 persistent and 100 ephemeral events. ([\#8606](https://github.com/matrix-org/synapse/issues/8606)) Updates to the Docker image --------------------------- - Added multi-arch support (arm64,arm/v7) for the docker images. Contributed by @maquis196. ([\#7921](https://github.com/matrix-org/synapse/issues/7921)) - Add support for passing commandline args to the synapse process. Contributed by @samuel-p. ([\#8390](https://github.com/matrix-org/synapse/issues/8390)) Improved Documentation ---------------------- - Update the directions for using the manhole with coroutines. ([\#8462](https://github.com/matrix-org/synapse/issues/8462)) - Improve readme by adding new shield.io badges. ([\#8493](https://github.com/matrix-org/synapse/issues/8493)) - Added note about docker in manhole.md regarding which ip address to bind to. Contributed by @Maquis196. ([\#8526](https://github.com/matrix-org/synapse/issues/8526)) - Document the new behaviour of the `allowed_lifetime_min` and `allowed_lifetime_max` settings in the room retention configuration. ([\#8529](https://github.com/matrix-org/synapse/issues/8529)) Deprecations and Removals ------------------------- - Drop unused `device_max_stream_id` table. ([\#8589](https://github.com/matrix-org/synapse/issues/8589)) Internal Changes ---------------- - Check for unreachable code with mypy. ([\#8432](https://github.com/matrix-org/synapse/issues/8432)) - Add unit test for event persister sharding. ([\#8433](https://github.com/matrix-org/synapse/issues/8433)) - Allow events to be sent to clients sooner when using sharded event persisters. ([\#8439](https://github.com/matrix-org/synapse/issues/8439), [\#8488](https://github.com/matrix-org/synapse/issues/8488), [\#8496](https://github.com/matrix-org/synapse/issues/8496), [\#8499](https://github.com/matrix-org/synapse/issues/8499)) - Configure `public_baseurl` when using demo scripts. ([\#8443](https://github.com/matrix-org/synapse/issues/8443)) - Add SQL logging on queries that happen during startup. ([\#8448](https://github.com/matrix-org/synapse/issues/8448)) - Speed up unit tests when using PostgreSQL. ([\#8450](https://github.com/matrix-org/synapse/issues/8450)) - Remove redundant database loads of stream_ordering for events we already have. ([\#8452](https://github.com/matrix-org/synapse/issues/8452)) - Reduce inconsistencies between codepaths for membership and non-membership events. ([\#8463](https://github.com/matrix-org/synapse/issues/8463)) - Combine `SpamCheckerApi` with the more generic `ModuleApi`. ([\#8464](https://github.com/matrix-org/synapse/issues/8464)) - Additional testing for `ThirdPartyEventRules`. ([\#8468](https://github.com/matrix-org/synapse/issues/8468)) - Add `-d` option to `./scripts-dev/lint.sh` to lint files that have changed since the last git commit. ([\#8472](https://github.com/matrix-org/synapse/issues/8472)) - Unblacklist some sytests. ([\#8474](https://github.com/matrix-org/synapse/issues/8474)) - Include the log level in the phone home stats. ([\#8477](https://github.com/matrix-org/synapse/issues/8477)) - Remove outdated sphinx documentation, scripts and configuration. ([\#8480](https://github.com/matrix-org/synapse/issues/8480)) - Clarify error message when plugin config parsers raise an error. ([\#8492](https://github.com/matrix-org/synapse/issues/8492)) - Remove the deprecated `Handlers` object. ([\#8494](https://github.com/matrix-org/synapse/issues/8494)) - Fix a threadsafety bug in unit tests. ([\#8497](https://github.com/matrix-org/synapse/issues/8497)) - Add user agent to user_daily_visits table. ([\#8503](https://github.com/matrix-org/synapse/issues/8503)) - Add type hints to various parts of the code base. ([\#8407](https://github.com/matrix-org/synapse/issues/8407), [\#8505](https://github.com/matrix-org/synapse/issues/8505), [\#8507](https://github.com/matrix-org/synapse/issues/8507), [\#8547](https://github.com/matrix-org/synapse/issues/8547), [\#8562](https://github.com/matrix-org/synapse/issues/8562), [\#8609](https://github.com/matrix-org/synapse/issues/8609)) - Remove unused code from the test framework. ([\#8514](https://github.com/matrix-org/synapse/issues/8514)) - Apply some internal fixes to the `HomeServer` class to make its code more idiomatic and statically-verifiable. ([\#8515](https://github.com/matrix-org/synapse/issues/8515)) - Factor out common code between `RoomMemberHandler._locally_reject_invite` and `EventCreationHandler.create_event`. ([\#8537](https://github.com/matrix-org/synapse/issues/8537)) - Improve database performance by executing more queries without starting transactions. ([\#8542](https://github.com/matrix-org/synapse/issues/8542)) - Rename `Cache` to `DeferredCache`, to better reflect its purpose. ([\#8548](https://github.com/matrix-org/synapse/issues/8548)) - Move metric registration code down into `LruCache`. ([\#8561](https://github.com/matrix-org/synapse/issues/8561), [\#8591](https://github.com/matrix-org/synapse/issues/8591)) - Replace `DeferredCache` with the lighter-weight `LruCache` where possible. ([\#8563](https://github.com/matrix-org/synapse/issues/8563)) - Add virtualenv-generated folders to `.gitignore`. ([\#8566](https://github.com/matrix-org/synapse/issues/8566)) - Add `get_immediate` method to `DeferredCache`. ([\#8568](https://github.com/matrix-org/synapse/issues/8568)) - Fix mypy not properly checking across the codebase, additionally, fix a typing assertion error in `handlers/auth.py`. ([\#8569](https://github.com/matrix-org/synapse/issues/8569)) - Fix `synmark` benchmark runner. ([\#8571](https://github.com/matrix-org/synapse/issues/8571)) - Modify `DeferredCache.get()` to return `Deferred`s instead of `ObservableDeferred`s. ([\#8572](https://github.com/matrix-org/synapse/issues/8572)) - Adjust a protocol-type definition to fit `sqlite3` assertions. ([\#8577](https://github.com/matrix-org/synapse/issues/8577)) - Support macOS on the `synmark` benchmark runner. ([\#8578](https://github.com/matrix-org/synapse/issues/8578)) - Update `mypy` static type checker to 0.790. ([\#8583](https://github.com/matrix-org/synapse/issues/8583), [\#8600](https://github.com/matrix-org/synapse/issues/8600)) - Re-organize the structured logging code to separate the TCP transport handling from the JSON formatting. ([\#8587](https://github.com/matrix-org/synapse/issues/8587)) - Remove extraneous unittest logging decorators from unit tests. ([\#8592](https://github.com/matrix-org/synapse/issues/8592)) - Minor optimisations in caching code. ([\#8593](https://github.com/matrix-org/synapse/issues/8593), [\#8594](https://github.com/matrix-org/synapse/issues/8594))
| * Fixup changelog even more v1.22.0rc1Erik Johnston2020-10-221-2/+1
| |
| * Fixup changelog some moreErik Johnston2020-10-221-7/+3
| |
| * Fixup changelogErik Johnston2020-10-221-4/+4
| |
| * 1.22.0rc1Erik Johnston2020-10-2289-88/+106
| |
* | Remove unused OPTIONS handlers. (#8621)Patrick Cloke2020-10-2214-64/+2
| | | | | | | | The handling of OPTIONS requests was consolidated in #7534, but the endpoint specific handlers were not removed.
* | Don't 500 for invalid group IDs (#8628)Erik Johnston2020-10-222-1/+5
| |
* | Type hints for RegistrationStore (#8615)Erik Johnston2020-10-224-74/+85
| |
* | Don't instansiate Requester directly (#8614)Erik Johnston2020-10-226-11/+12
|/
* Optimise CacheDescriptor (#8594) github/release-v1.21.3 release-v1.21.3Richard van der Hoff2020-10-212-5/+8
| | | don't bother constricting a CacheContext unless we need one.
* Merge pull request #8593 from matrix-org/rav/cache_hacking/3Richard van der Hoff2020-10-212-3/+16
|\ | | | | Optimisation in DeferredCache.set
| * fix failure caseRichard van der Hoff2020-10-211-1/+4
| |
| * optimise DeferredCache.setRichard van der Hoff2020-10-212-3/+13
|/
* Merge pull request #8572 from matrix-org/rav/cache_hacking/2Richard van der Hoff2020-10-216-271/+441
|\ | | | | Push some deferred wrangling down into DeferredCache
| * Add some more testsRichard van der Hoff2020-10-212-0/+147
| |
| * Push some deferred wrangling down into DeferredCacheRichard van der Hoff2020-10-215-46/+67
| |
| * Combine the two sets of tests for CacheDescriptorRichard van der Hoff2020-10-212-228/+230
| |
* | Limit AS transactions to 100 events (#8606)Will Hunt2020-10-213-2/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | * Limit AS transactions to 100 events * Update changelog.d/8606.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Add tests * Update synapse/appservice/scheduler.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Separate the TCP and terse JSON formatting code. (#8587)Patrick Cloke2020-10-214-187/+240
| | | | | | | | This should (theoretically) allow for using the TCP code with a different output type and make it easier to use the JSON code with files / console.
* | Pin mypy-zope for compatibility with mypy. (#8600)Patrick Cloke2020-10-212-1/+2
| |
* | Add type hints to profile and base handlers. (#8609)Patrick Cloke2020-10-216-41/+72
|/
* Consistently use wrap_as_background_task in more places (#8599)Patrick Cloke2020-10-205-30/+20
|
* Update mypy to 0.790, and move dependencies to extras (#8583)Jonathan de Jong2020-10-203-3/+4
|
* Remove some extraneous @unittest.INFOs on unit tests (#8592)Andrew Morgan2020-10-203-2/+1
|
* Cast errors generated during synapse_port_db to str (#8585)Andrew Morgan2020-10-202-2/+4
| | | | | | | | | I noticed in https://github.com/matrix-org/synapse/issues/8575 that the `end_error` variable in `synapse_port_db` is set to an `Exception`, even though later we expect it to be a `str`. This PR simply casts an exception raised to a string. I'm doing this instead of having `end_error` be of type exception as we explicitly set `end_error` to a str here: https://github.com/matrix-org/synapse/blob/d25eb8f3709965d0face01a041d5292490bf0139/scripts/synapse_port_db#L542-L547 This whole file could probably use some heavy refactoring, but until then at least this fix will prevent exception contents from being hidden from us and users.
* Move schema file for as_device_stream (#8590)Will Hunt2020-10-202-3/+3
| | | | | | | | | * Move schema file * Add a . * Add matching changelog entry * Fix sqlite
* Fix 'LruCache' object has no attribute '_on_resize' (#8591)Richard van der Hoff2020-10-193-2/+17
| | | We need to make sure we are readu for the `set_cache_factor` callback.
* Drop unused `device_max_stream_id` table (#8589)Vasilis Gerakaris2020-10-192-0/+2
| | | Signed-off-by: Vasilis Gerakaris <vasilis.gerakaris@navarino.gr>
* Fix mypy error: auth handler "checkpw" internal function type mismatch (#8569)Jonathan de Jong2020-10-193-4/+6
|
* Expose the experimental appservice login flow to clients. (#8504)Patrick Cloke2020-10-192-0/+3
|
* Add `DeferredCache.get_immediate` method (#8568)Richard van der Hoff2020-10-197-27/+53
| | | | | | | | | | | * Add `DeferredCache.get_immediate` method A bunch of things that are currently calling `DeferredCache.get` are only really interested in the result if it's completed. We can optimise and simplify this case. * Remove unused 'default' parameter to DeferredCache.get() * another get_immediate instance
* Include a simple message in email notifications that include encrypted ↵Patrick Cloke2020-10-199-75/+107
| | | | content (#8545)
* Support running synmark on macOS. (#8578)Patrick Cloke2020-10-192-2/+6
| | | By using the "poll" reactor since macOS doesn't support epoll.
* Start an opentracing span for background processes. (#8567)Erik Johnston2020-10-192-5/+7
| | | | | | This should reduce the number of `There was no active span` errors we see. Fixes #8510.
* Replace DeferredCache with LruCache where possible (#8563)Richard van der Hoff2020-10-198-27/+30
| | | Most of these uses don't need a full-blown DeferredCache; LruCache is lighter and more appropriate.
* Pre-emptively fix synapse.storage.types.Connection for future mypy release ↵Jonathan de Jong2020-10-173-3/+4
| | | | | (#8577) Fix the Connection protocol according to typeshed's assertions about sqlite3.Connection
* Fix synmark (#8571)Richard van der Hoff2020-10-162-1/+2
| | | This seems to have been broken since #6513.
* Type annotations for LruCache (#8562)Richard van der Hoff2020-10-166-31/+95
|\ | | | | | | | | | | | | | | | | | | | | | | | | * type annotations for LruCache * changelog * Apply suggestions from code review Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * review comments Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * review commentsRichard van der Hoff2020-10-161-3/+8
| |
| * Apply suggestions from code reviewRichard van der Hoff2020-10-162-2/+2
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * changelogRichard van der Hoff2020-10-161-0/+1
| |
| * type annotations for LruCacheRichard van der Hoff2020-10-165-31/+89
| |
* | Clean-up old transaction IDs on the background worker. (#8544)Patrick Cloke2020-10-162-1/+2
| |
* | Add .venv* to .gitignore (#8566)Jonathan de Jong2020-10-162-0/+2
|/ | | Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* Make LruCache register its own metrics (#8561)Richard van der Hoff2020-10-168-62/+62
| | | | | rather than have everything that instantiates an LruCache manage metrics separately, have LruCache do it itself.
* Fix modifying events in `ThirdPartyRules` modules (#8564)Richard van der Hoff2020-10-163-2/+8
| | | EventBuilder.build wants auth events these days
* Merge pull request #8535 from matrix-org/rav/third_party_events_updatesRichard van der Hoff2020-10-156-81/+118
|\ | | | | Support modifying event content from ThirdPartyRules modules
| * changelogRichard van der Hoff2020-10-131-0/+1
| |
| * guard against accidental modificationRichard van der Hoff2020-10-133-3/+30
| |
| * Allow ThirdPartyRules modules to replace event contentRichard van der Hoff2020-10-133-9/+75
| | | | | | | | Support returning a new event dict from `check_event_allowed`.
| * Move third_party_rules check to event creation timeRichard van der Hoff2020-10-132-52/+13
| | | | | | | | | | Rather than waiting until we handle the event, call the ThirdPartyRules check when we fist create the event.
| * Remove redundant calls to third_party_rules in `on_send_{join,leave}`Richard van der Hoff2020-10-131-19/+1
| | | | | | | | | | There's not much point in calling these *after* we have decided to accept them into the DAG.
* | Solidify the HomeServer constructor. (#8515)Jonathan de Jong2020-10-157-25/+33
| | | | | | | | | | | | This implements a more standard API for instantiating a homeserver and moves some of the dependency injection into the test suite. More concretely this stops using `setattr` on all `kwargs` passed to `HomeServer`.
* | Send some ephemeral events to appservices (#8437)Will Hunt2020-10-1516-122/+563
| | | | | | Optionally sends typing, presence, and read receipt information to appservices.
* | Add option to scripts-dev/lint.sh to only lint files changed since the last ↵Andrew Morgan2020-10-154-12/+90
| | | | | | | | | | | | | | | | | | | | git commit (#8472) This PR makes several changes to the `./scripts-dev/lint.sh` script, which lints the codebase with a number of tools: * Adds usage information, with `-h` flag to show it. Otherwise it will show when providing an unknown flag. * Adds option `-d` which will check both staged and unstaged files that have changed since the last commit and add them to the list of files to lint. - Note that only files without an extension, or with a `.py` extension will be allowed. This prevents editing bash scripts causing the linters to break on non-python files. * Improves the print-out of which files/directories are being linted.
* | Merge branch 'master' into developPatrick Cloke2020-10-154-2/+32
|\ \
| * | Additional tweaks. v1.21.2 github/release-v1.21.2 release-v1.21.2Patrick Cloke2020-10-151-3/+3
| | |
| * | Clarify authlib changes.Patrick Cloke2020-10-151-1/+3
| | |
| * | Fix typo.Patrick Cloke2020-10-151-1/+1
| | |
| * | Add additional release notes.Patrick Cloke2020-10-151-0/+13
| | |
| * | 1.21.2Patrick Cloke2020-10-154-2/+17
| | |
* | | Merge branch 'release-v1.21.2' into developPatrick Cloke2020-10-150-0/+0
|\| |
| * | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-152-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | | Enable mypy for synapse.util.caches (#8547)Richard van der Hoff2020-10-155-10/+185
| | | | | | | | | This seemed to entail dragging in a type stub for SortedList.
* | | Merge pull request #8548 from matrix-org/rav/deferred_cacheRichard van der Hoff2020-10-1512-374/+454
|\ \ \ | | | | | | | | Rename Cache to DeferredCache, and related changes
| * | | changelogRichard van der Hoff2020-10-141-0/+1
| | | |
| * | | Combine the two sets of DeferredCache testsRichard van der Hoff2020-10-142-74/+75
| | | |
| * | | move DeferredCache into its own moduleRichard van der Hoff2020-10-1410-332/+367
| | | |
| * | | Rename Cache->DeferredCacheRichard van der Hoff2020-10-148-25/+30
| | | |
| * | | Add some more type annotations to CacheRichard van der Hoff2020-10-143-24/+62
| | |/ | |/|
* | | Include user agent in user daily visits table (#8503)Neil Johnson2020-10-153-3/+27
| | | | | | | | | Include user agent in user daily visits table.
* | | Merge pull request #8537 from matrix-org/rav/simplify_locally_reject_inviteRichard van der Hoff2020-10-159-65/+56
|\ \ \ | | | | | | | | Simplify `_locally_reject_invite`
| * | | changelogRichard van der Hoff2020-10-131-0/+1
| | | |
| * | | Simplify `_locally_reject_invite`Richard van der Hoff2020-10-136-57/+52
| | | | | | | | | | | | | | | | | | | | Update `EventCreationHandler.create_event` to accept an auth_events param, and use it in `_locally_reject_invite` instead of reinventing the wheel.
| * | | Remove redundant `token_id` parameter to create_eventRichard van der Hoff2020-10-134-8/+3
| |/ / | | | | | | | | | this is always the same as requester.access_token_id.
* | | Use autocommit mode for single statement DB functions. (#8542)Erik Johnston2020-10-145-70/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autocommit means that we don't wrap the functions in transactions, and instead get executed directly. Introduced in #8456. This will help: 1. reduce the number of `could not serialize access due to concurrent delete` errors that we see (though there are a few functions that often cause serialization errors that we don't fix here); 2. improve the DB performance, as it no longer needs to deal with the overhead of `REPEATABLE READ` isolation levels; and 3. improve wall clock speed of these functions, as we no longer need to send `BEGIN` and `COMMIT` to the DB. Some notes about the differences between autocommit mode and our default `REPEATABLE READ` transactions: 1. Currently `autocommit` only applies when using PostgreSQL, and is ignored when using SQLite (due to silliness with [Twisted DB classes](https://twistedmatrix.com/trac/ticket/9998)). 2. Autocommit functions may get retried on error, which means they can get applied *twice* (or more) to the DB (since they are not in a transaction the previous call would not get rolled back). This means that the functions need to be idempotent (or otherwise not care about being called multiple times). Read queries, simple deletes, and updates/upserts that replace rows (rather than generating new values from existing rows) are all idempotent. 3. Autocommit functions no longer get executed in [`REPEATABLE READ`](https://www.postgresql.org/docs/current/transaction-iso.html) isolation level, and so data can change queries, which is fine for single statement queries.
* | | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-142-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | | Add note to manhole.md about bind_address when using with docker (#8526)Christopher May-Townsend2020-10-142-7/+40
| | | | | | | | | | | | Signed-off-by: Christopher May-Townsend <chris@maytownsend.co.uk>
* | | Update documentation on retention policies limits (#8529)Brendan Abolivier2020-10-142-12/+23
| | | | | | | | | | | | | | | * Update documentation on retention policies limits Document the changes from https://github.com/matrix-org/synapse/pull/8104
* | | Add basic tests for sync/pagination with vector clock tokens. (#8488)Erik Johnston2020-10-143-1/+249
| | | | | | | | | | | | | | | These are tests for #8439
* | | Fix not sending events over federation when using sharded event persisters ↵Erik Johnston2020-10-1410-21/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8536) * Fix outbound federaion with multiple event persisters. We incorrectly notified federation senders that the minimum persisted stream position had advanced when we got an `RDATA` from an event persister. Notifying of federation senders already correctly happens in the notifier, so we just delete the offending line. * Change some interfaces to use RoomStreamToken. By enforcing use of `RoomStreamTokens` we make it less likely that people pass in random ints that they got from somewhere random.
* | | Make sure a retention policy is a state event (#8527)Brendan Abolivier2020-10-143-0/+8
| | | | | | | | | | | | | | | * Make sure a retention policy is a state event * Changelog
* | | Add correct M_BAD_JSON error code to /profile/{userId}/displayname (#8517)Aaron Raimist2020-10-142-1/+4
|/ / | | | | Fixes #8029
* | Move additional tasks to the background worker, part 4 (#8513)Patrick Cloke2020-10-1311-221/+196
| |
* | Fix message duplication if something goes wrong after persisting the event ↵Erik Johnston2020-10-1313-32/+481
| | | | | | | | | | (#8476) Should fix #3365.
* | Merge branch 'master' into developAndrew Morgan2020-10-134-2/+18
|\| | | | | | | | | | | * master: 1.21.1 Explicitly install test dependencies when building deb packages (#8523)
| * 1.21.1 v1.21.1 github/release-v1.21.1 release-v1.21.1Andrew Morgan2020-10-133-3/+13
| |
| * Explicitly install test dependencies when building deb packages (#8523)Andrew Morgan2020-10-122-1/+7
| | | | | | | | | | After https://github.com/matrix-org/synapse/pull/8377, the deb packages no longer indirectly installed the `"test"` dependencies, causing debian packages to fail to build while carrying out the unit tests. This PR installs `test` dependencies explicitly when building debian packages.
* | Multi arch docker support: add arm/v7 and arm64 to our docker images (#7921)Christopher May-Townsend2020-10-122-8/+53
| | | | | | Signed-off-by: Christopher May-Townsend (chris@maytownsend.co.uk)
* | Merge branch 'master' into developAndrew Morgan2020-10-123-4/+25
|\|
| * Reverse proxies are not the only thing to change;be explicit w/ new endpoint v1.21.0 github/release-v1.21.0 release-v1.21.0Andrew Morgan2020-10-121-6/+7
| |
| * Add deprecation warning for admin api under client api prefixesAndrew Morgan2020-10-121-0/+8
| |
| * 1.21.0Andrew Morgan2020-10-123-1/+13
| |
* | Make event persisters periodically announce position over replication. (#8499)Erik Johnston2020-10-129-34/+128
| | | | | | | | | | Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
* | Docker: support passing additional commandline args to synapse (#8390)Samuel Philipp2020-10-113-18/+44
| |
* | Clean-up some broken/unused code in the test framework (#8514)Patrick Cloke2020-10-093-70/+55
| |
* | Fix threadsafety in ThreadedMemoryReactorClock (#8497)Richard van der Hoff2020-10-092-4/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This could, very occasionally, cause: ``` tests.test_visibility.FilterEventsForServerTestCase.test_large_room =============================================================================== [ERROR] Traceback (most recent call last): File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache self.wait_on_thread(x) File "/src/tests/unittest.py", line 296, in wait_on_thread self.reactor.advance(0.01) File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance self._sortCalls() File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls self.calls.sort(key=lambda a: a.getTime()) builtins.ValueError: list modified during sort tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache ```
* | Increase default max_upload_size from 10M to 50M (#8502)Mateusz Przybyłowicz2020-10-095-5/+6
| | | | | | Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>
* | Add type hints to response cache. (#8507)Patrick Cloke2020-10-099-34/+48
| |
* | Allow modules to create and send events into rooms (#8479)Andrew Morgan2020-10-095-8/+157
| | | | | | | | | | This PR allows Synapse modules making use of the `ModuleApi` to create and send non-membership events into a room. This can useful to have modules send messages, or change power levels in a room etc. Note that they must send event through a user that's already in the room. The non-membership event limitation is currently arbitrary, as it's another chunk of work and not necessary at the moment.
* | Only send RDATA for instance local events. (#8496)Erik Johnston2020-10-096-25/+54
| | | | | | | | | | When pulling events out of the DB to send over replication we were not filtering by instance name, and so we were sending events for other instances.
* | Move additional tasks to the background worker, part 3 (#8489)Patrick Cloke2020-10-098-282/+276
| |
* | Remove the deprecated Handlers object (#8494)Patrick Cloke2020-10-0940-157/+116
| | | | | | All handlers now available via get_*_handler() methods on the HomeServer.
* | Add type hints to some handlers (#8505)Patrick Cloke2020-10-0910-22/+60
| |
* | Invalidate the cache when an olm fallback key is uploaded (#8501)Hubert Chathi2020-10-083-0/+25
| |
* | Merge tag 'v1.21.0rc3' into developErik Johnston2020-10-084-3/+16
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc3 (2020-10-08) ============================== Bugfixes -------- - Fix duplication of events on high traffic servers, caused by PostgreSQL `could not serialize access due to concurrent update` errors. ([\#8456](https://github.com/matrix-org/synapse/issues/8456)) Internal Changes ---------------- - Add Groovy Gorilla to the list of distributions we build `.deb`s for. ([\#8475](https://github.com/matrix-org/synapse/issues/8475))
| * Update change log v1.21.0rc3Erik Johnston2020-10-081-1/+1
| |
| * 1.21.0rc3Erik Johnston2020-10-084-3/+16
| |
* | Add useful shields to readme (#8493)Mateusz Przybyłowicz2020-10-082-7/+24
| | | | | | | | | | | | Added shields directing to synapse-dev room, showing license, latest version on PyPi and supported Python versions. I've moved substitution definitions to the bottom to improve readability. Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>
* | Clarify error message when plugin config parsers raise an error (#8492)Richard van der Hoff2020-10-082-1/+2
| | | | | | | | | | | | | | | | | | This turns: Failed to parse config for 'myplugin': Exception('error message') into: Failed to parse config for 'myplugin': error message.
* | Merge remote-tracking branch 'origin/release-v1.21.0' into developErik Johnston2020-10-072-0/+2
|\|
| * Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-077-5/+109
| | | | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
| * Add Ubuntu 20.10 (Groovy Gorilla) to build scripts. (#8475)Patrick Cloke2020-10-072-0/+2
| |
* | Move additional tasks to the background worker (#8458)Patrick Cloke2020-10-078-197/+195
| |
* | Include the configured log level in phone home stats. (#8477)Patrick Cloke2020-10-072-0/+8
| | | | | | By reporting the log level of the synapse logger as a string.
* | Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-077-8/+112
| | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
* | Use vector clocks for room stream tokens. (#8439)Erik Johnston2020-10-074-42/+380
| | | | | | | | | | | | | | | | | | | | Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).
* | Add typing information to the device handler. (#8407)Patrick Cloke2020-10-074-38/+59
| |
* | Fix returning incorrect prev_batch token in incremental sync (#8486)Erik Johnston2020-10-072-1/+7
| |
* | unblacklist some tests (#8474)Richard van der Hoff2020-10-073-34/+1
| | | | | | | | | | It seems most of these blacklisted tests do actually pass most of the time. I'm of the opinion that having them blacklisted here means there is very little incentive for us to deflake any flaky tests, and meanwhile any value in those tests is completely lost.
* | Add support for MSC2697: Dehydrated devices (#8380)Hubert Chathi2020-10-079-21/+454
| | | | | | | | This allows a user to store an offline device on the server and then restore it at a subsequent login.
* | Merge pull request #8463 from matrix-org/rav/clean_up_event_handlingRichard van der Hoff2020-10-076-92/+83
|\ \ | | | | | | Reduce inconsistencies between codepaths for membership and non-membership events.
| * | update wordingRichard van der Hoff2020-10-071-2/+3
| | |
| * | changelogRichard van der Hoff2020-10-051-0/+1
| | |
| * | kill off `send_nonmember_event`Richard van der Hoff2020-10-054-53/+31
| | | | | | | | | | | | This is now redundant, and we can just call `handle_new_client_event` directly.
| * | pull up event.sender assertionRichard van der Hoff2020-10-052-4/+5
| | |
| * | Move shadow-ban check down into `handle_new_client_event`.Richard van der Hoff2020-10-051-8/+24
| | |
| * | De-duplicate duplicate handlingRichard van der Hoff2020-10-052-38/+32
| | | | | | | | | | | | | | | move the "duplicate state event" handling down into `handle_new_client_event` where it can be shared between multiple call paths.
* | | Combine `SpamCheckerApi` with the more generic `ModuleApi`. (#8464)Richard van der Hoff2020-10-0710-58/+51
| | | | | | | | | | | | | | | Lots of different module apis is not easy to maintain. Rather than adding yet another ModuleApi(hs, hs.get_auth_handler()) incantation, first add an hs.get_module_api() method and use it where possible.
* | | Remove docs/sphinx and related references (#8480)Andrew Morgan2020-10-0762-839/+1
| | | | | | | | | https://github.com/matrix-org/synapse/tree/develop/docs/sphinx doesn't seem to really be utilised or changed recently since the initial commit. I like the idea of exportable documentation of the codebase, but at the moment after running through the build instructions the generated website wasn't very useful...
* | | Add support for MSC2732: olm fallback keys (#8312)Hubert Chathi2020-10-068-1/+215
| | |
* | | Additional tests for third-party event rules (#8468)Richard van der Hoff2020-10-063-18/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Optimise and test state fetching for 3p event rules Getting all the events at once is much more efficient than getting them individually * Test that 3p event rules can modify events
* | | Merge pull request #8467 from matrix-org/rav/fix_3pevent_rulesRichard van der Hoff2020-10-063-2/+5
|\ \ \ | | | | | | | | Fix third-party event modules for `check_visibility_can_be_modified` check
| * | | Fix third-party event modules for `check_visibility_can_be_modified` checkRichard van der Hoff2020-10-053-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | PR #8292 tried to maintain backwards compat with modules which don't provide a `check_visibility_can_be_modified` method, but the tests weren't being run, and the check didn't work.
* | | | Don't bother responding to client requests that have already disconnected ↵Andrew Morgan2020-10-063-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8465) This PR ports the quick fix from https://github.com/matrix-org/synapse/pull/2796 to further methods which handle media, URL preview and `/key/v2/server` requests. This prevents a harmless `ERROR` that comes up in the logs when we were unable to respond to a client request when the client had already disconnected. In this case we simply bail out if the client has already done so. This is the 'simple fix' as suggested by https://github.com/matrix-org/synapse/issues/5304#issuecomment-574740003. Fixes https://github.com/matrix-org/synapse/issues/6700 Fixes https://github.com/matrix-org/synapse/issues/5304
* | | | Update default room version to 6 (#8461)Richard van der Hoff2020-10-054-3/+13
|/ / / | | | | | | | | | Per https://github.com/matrix-org/matrix-doc/pull/2788
* / / Ensure that event.redacts is the proper type before handling it (#8457)Patrick Cloke2020-10-052-0/+3
|/ / | | | | This fixes a bug when backfilling invalid events.
* | Allow ThirdPartyEventRules modules to manipulate public room state (#8292)Andrew Morgan2020-10-058-19/+223
| | | | | | | | | | This PR allows `ThirdPartyEventRules` modules to view, manipulate and block changes to the state of whether a room is published in the public rooms directory. While the idea of whether a room is in the public rooms list is not kept within an event in the room, `ThirdPartyEventRules` generally deal with controlling which modifications can happen to a room. Public rooms fits within that idea, even if its toggle state isn't controlled through a state event.
* | Remove stream ordering from Metadata dict (#8452)Richard van der Hoff2020-10-0513-33/+53
| | | | | | | | | | | | | | | | There's no need for it to be in the dict as well as the events table. Instead, we store it in a separate attribute in the EventInternalMetadata object, and populate that on load. This means that we can rely on it being correctly populated for any event which has been persited to the database.
* | Update manhole documentation for async/await. (#8462)Patrick Cloke2020-10-052-2/+6
| |
* | Do not assume that account data is of the correct form. (#8454)Patrick Cloke2020-10-056-21/+34
| | | | | | | | This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.
* | Add logging on startup/shutdown (#8448)Erik Johnston2020-10-0225-113/+152
| | | | | | | | | | This is so we can tell what is going on when things are taking a while to start up. The main change here is to ensure that transactions that are created during startup get correctly logged like normal transactions.
* | Speed up unit tests when using PostgreSQL (#8450)Erik Johnston2020-10-023-1/+17
| |
* | Allow background tasks to be run on a separate worker. (#8369)Patrick Cloke2020-10-0219-449/+537
| |
* | Merge tag 'v1.21.0rc2' into developRichard van der Hoff2020-10-0214-141/+163
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc2 (2020-10-02) ============================== Features -------- - Convert additional templates from inline HTML to Jinja2 templates. ([\#8444](https://github.com/matrix-org/synapse/issues/8444)) Bugfixes -------- - Fix a regression in v1.21.0rc1 which broke thumbnails of remote media. ([\#8438](https://github.com/matrix-org/synapse/issues/8438)) - Do not expose the experimental `uk.half-shot.msc2778.login.application_service` flow in the login API, which caused a compatibility problem with Element iOS. ([\#8440](https://github.com/matrix-org/synapse/issues/8440)) - Fix malformed log line in new federation "catch up" logic. ([\#8442](https://github.com/matrix-org/synapse/issues/8442)) - Fix DB query on startup for negative streams which caused long start up times. Introduced in [\#8374](https://github.com/matrix-org/synapse/issues/8374). ([\#8447](https://github.com/matrix-org/synapse/issues/8447))
| * move #8444 to 'feature' v1.21.0rc2Richard van der Hoff2020-10-021-1/+5
| |
| * linkify changelogRichard van der Hoff2020-10-021-1/+1
| |
| * 1.21.0rc2Richard van der Hoff2020-10-021-1/+1
| |
| * 1.21.0rc2Richard van der Hoff2020-10-027-6/+14
| |
| * Fix bug in remote thumbnail search (#8438)Richard van der Hoff2020-10-022-20/+24
| | | | | | | | | | #7124 changed the behaviour of remote thumbnails so that the thumbnailing method was included in the filename of the thumbnail. To support existing files, it included a fallback so that we would check the old filename if the new filename didn't exist. Unfortunately, it didn't apply this logic to storage providers, so any thumbnails stored on such a storage provider was broken.
| * Fix DB query on startup for negative streams. (#8447)Erik Johnston2020-10-022-1/+2
| | | | | | | | | | | | | | | | For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.
| * Convert additional templates to Jinja (#8444)Patrick Cloke2020-10-029-116/+121
| | | | | | This converts a few more of our inline HTML templates to Jinja. This is somewhat part of #7280 and should make it a bit easier to customize these in the future.
| * Fix malformed log line in new federation "catch up" logic (#8442)Richard van der Hoff2020-10-022-1/+2
| |
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-28 11:49:26 +0000