summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Stop `get_joined_users` corruption from custom statuses (#7376)Richard van der Hoff2020-05-143-2/+52
| | | | | | | | Fix a bug where the `get_joined_users` cache could be corrupted by custom status events (or other state events with a state_key matching the user ID). The bug was introduced by #2229, but has largely gone unnoticed since then. Fixes #7099, #7373.
* Do not validate that the client dict is stable during UI Auth. (#7483)Patrick Cloke2020-05-134-65/+29
| | | | This backs out some of the validation for the client dictionary and logs if this changes during a user interactive authentication session instead.
* Fix new flake8 errors (#7489)Patrick Cloke2020-05-137-12/+19
| | | | This is a cherry-pick of 1a1da60ad2c9172fe487cd38a164b39df60f4cb5 (#7470) to the release-v1.13.0 branch.
* Don't UPGRADE database rows v1.13.0rc1Andrew Morgan2020-05-111-1/+1
|
* RST indentingAndrew Morgan2020-05-111-2/+2
|
* Put rollback instructions in upgrade notesAndrew Morgan2020-05-111-0/+19
|
* Fix changelog typoAndrew Morgan2020-05-111-1/+1
|
* Oh yeah, RSTAndrew Morgan2020-05-111-2/+1
|
* Absolute URL it is thenAndrew Morgan2020-05-111-1/+2
|
* Fix upgrade notes linkAndrew Morgan2020-05-111-1/+1
|
* Provide summary of upgrade issues in changelog. Fix )Andrew Morgan2020-05-112-12/+33
|
* Move next version notes from changelog to upgrade notesAndrew Morgan2020-05-112-14/+15
|
* Changelog fixesAndrew Morgan2020-05-111-3/+3
|
* 1.13.0rc1Andrew Morgan2020-05-11144-143/+139
|
* Documentation on setting up redis (#7446)Neil Johnson2020-05-112-60/+108
|
* Rework UI Auth session validation for registration (#7455)Patrick Cloke2020-05-086-102/+280
| | | | Be less strict about validation of UI authentication sessions during registration to match client expecations.
* Fix errors from malformed log line (#7454)Richard van der Hoff2020-05-072-1/+2
|
* Drop support for redis.dbid (#7450)Richard van der Hoff2020-05-073-4/+2
| | | Since we only use pubsub, the dbid is irrelevant.
* Add a configuration setting for the dummy event threshold (#7422)Brendan Abolivier2020-05-074-1/+31
| | | Add dummy_events_threshold which allows configuring the number of forward extremities a room needs for Synapse to send forward extremities in it.
* Improve per-block CPU and DB usage metrics (#7426)Patrick Cloke2020-05-062-12/+27
|
* Port group attestation renewal slow down from matrix-org-hotfixes (#7442)Andrew Morgan2020-05-062-4/+3
|
* Make redis go faster with hiredis (#7439)Richard van der Hoff2020-05-062-1/+4
| | | | | For the record, the reason we need this is as follows: each RDATA command comes down the redis pipe as a subscription message. txredisapi as written needs at least three reactor ticks to read each subscription message from the tcp buffer. Hence, once the process gets loaded, it starts getting behind, and eventually redis knifes the connection. it then takes ages for the master to work its way through the backlog, before it reconnects again, during which any commands from any workers are dropped.
* Stop Auth methods from polling the config on every req. (#7420)Andrew Morgan2020-05-067-106/+168
|
* Merge pull request #7423 from matrix-org/erikj/faster_device_lists_fetchErik Johnston2020-05-064-10/+26
|\ | | | | Speed up fetching device lists changes in sync.
| * Merge branch 'release-v1.13.0' into erikj/faster_device_lists_fetchRichard van der Hoff2020-05-0566-691/+847
| |\
| * | Update changelog.d/7423.miscRichard van der Hoff2020-05-051-1/+1
| | |
| * | NewsfileErik Johnston2020-05-051-0/+1
| | |
| * | Speed up fetching device lists changes in sync.Erik Johnston2020-05-053-10/+25
| | | | | | | | | | | | | | | Currently we copy `users_who_share_room` needlessly about three times, which is expensive when the set is large (which it can easily be).
* | | Merge pull request #7427 from matrix-org/rav/fix_dropped_messagesRichard van der Hoff2020-05-063-34/+70
|\ \ \ | | | | | | | | Fix lost events on replication reconnection
| * \ \ Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-052-1/+2
| |\ \ \ | |/ / / |/| | |
* | | | Move logs about discarded RDATA to debug (#7421)Brendan Abolivier2020-05-052-1/+2
| |_|/ |/| |
| * | Merge branch 'release-v1.13.0' into rav/fix_dropped_messagesRichard van der Hoff2020-05-0566-690/+847
| |\ \ | |/ / |/| |
* | | Add backwards compatibility codepath to LoggingContext. (#7408)Patrick Cloke2020-05-052-0/+42
| | |
* | | Fix bug in EventContext.deserialize. (#7393)Erik Johnston2020-05-054-8/+126
| | | | | | | | | | | | This caused `prev_state_ids` to be incorrect if the state event was not replacing an existing state entry.
* | | Fix ordering in MANIFEST.inBrendan Abolivier2020-05-041-6/+6
| | |
* | | Merge pull request #7404 from matrix-org/babolivier/fix_manifestBrendan Abolivier2020-05-042-3/+5
|\ \ \ | | | | | | | | Fix MANIFEST.in
| * | | Fix MANIFEST.inBrendan Abolivier2020-05-042-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | An update of check-manifest shone some light on some issues with MANIFEST.in, specifically that we didn't ignore/prune the contrib directory, and that we were using prune instead of exclude for files. This fixes both issues. Fixes #7403
* | | | Fix redis password support. (#7401)Erik Johnston2020-05-043-0/+7
| | | | | | | | | | | | | | | | | | | | We forgot to set the password on the subscriber connection, as well as not calling super methods for overridden connectionMade/connectionLost functions.
* | | | Convert synapse.server_notices to async/await. (#7394)Patrick Cloke2020-05-013-11/+8
| | | |
* | | | Convert the synapse.notifier module to async/await. (#7395)Patrick Cloke2020-05-012-10/+8
| | | |
* | | | Wait for current_state_events_membership before populate_stats_process_rooms ↵Richard van der Hoff2020-05-013-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (#7387) populate_stats_process_rooms was added in #5971 / v1.4.0; current_state_events_membership was added in #5706 / v1.3.0. Fixes #7380.
* | | | Thread through instance name to replication client. (#7369)Erik Johnston2020-05-0112-41/+101
|/ / / | | | | | | For in memory streams when fetching updates on workers we need to query the source of the stream, which currently is hard coded to be master. This PR threads through the source instance we received via `POSITION` through to the update function in each stream, which can then be passed to the replication client for in memory streams.
* | | Use `stream.current_token()` and remove `stream_positions()` (#7172)Erik Johnston2020-05-0119-154/+30
| | | | | | | | | | | | We move the processing of typing and federation replication traffic into their handlers so that `Stream.current_token()` points to a valid token. This allows us to remove `get_streams_to_replicate()` and `stream_positions()`.
* | | async/await is_server_admin (#7363)Andrew Morgan2020-05-0122-438/+410
| | |
* | | Further improvements to requesting the public rooms list on a homeserver ↵Andrew Morgan2020-05-013-23/+71
| |/ |/| | | | | which has it set to private (#7368)
| * changelogRichard van der Hoff2020-05-051-0/+1
| |
| * Wait for a POSITION on the right connection before accepting RDATARichard van der Hoff2020-05-052-19/+38
| | | | | | | | ... otherwise we can believe we're up to date when we're not.
| * Wait to subscribe before sending REPLICATERichard van der Hoff2020-05-052-20/+35
|/
* Workaround for assertion errors from db_query_to_update_function (#7378)Richard van der Hoff2020-05-012-2/+2
| | | Hopefully this is no worse than what we have on master...
* Persist user interactive authentication sessions (#7302)Patrick Cloke2020-04-3014-125/+434
| | | | | By persisting the user interactive authentication sessions to the database, this fixes situations where a user hits different works throughout their auth session and also allows sessions to persist through restarts of Synapse.
* Apply federation check for /publicRooms with filter list (#7367)Andrew Morgan2020-04-302-1/+6
|
* Add instance name to RDATA/POSITION commands (#7364)Erik Johnston2020-04-2910-50/+95
| | | | | This is primarily for allowing us to send those commands from workers, but for now simply allows us to ignore echoed RDATA/POSITION commands that we sent (we get echoes of sent commands when using redis). Currently we log a WARNING on the master process every time we receive an echoed RDATA.
* Don't relay REMOTE_SERVER_UP cmds to same conn. (#7352)Erik Johnston2020-04-296-25/+114
| | | | | | | | | | | | | | For direct TCP connections we need the master to relay REMOTE_SERVER_UP commands to the other connections so that all instances get notified about it. The old implementation just relayed to all connections, assuming that sending back to the original sender of the command was safe. This is not true for redis, where commands sent get echoed back to the sender, which was causing master to effectively infinite loop sending and then re-receiving REMOTE_SERVER_UP commands that it sent. The fix is to ensure that we only relay to *other* connections and not to the connection we received the notification from. Fixes #7334.
* Fix limit logic for EventsStream (#7358)Richard van der Hoff2020-04-2914-67/+658
| | | | | | | | | | | | | | | | | | | * Factor out functions for injecting events into database I want to add some more flexibility to the tools for injecting events into the database, and I don't want to clutter up HomeserverTestCase with them, so let's factor them out to a new file. * Rework TestReplicationDataHandler This wasn't very easy to work with: the mock wrapping was largely superfluous, and it's useful to be able to inspect the received rows, and clear out the received list. * Fix AssertionErrors being thrown by EventsStream Part of the problem was that there was an off-by-one error in the assertion, but also the limit logic was too simple. Fix it all up and add some tests.
* Fix fallback value for account_threepid_delegates.email (#7316)Andrew Morgan2020-04-292-3/+9
|
* Clean up admin api docs (#7361)Andrew Morgan2020-04-282-18/+43
|
* Return total number of users and profile attributes in admin users endpoint ↵Manuel Stahl2020-04-286-36/+100
| | | | | (#6881) Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
* Add some replication tests (#7278)Erik Johnston2020-04-283-11/+299
| | | | | | | Specifically some tests for the typing stream, which means we test streams that fetch missing updates via HTTP (rather than via the DB). We also shuffle things around a bit so that we create two separate `HomeServer` objects, rather than trying to insert a slaved store into places. Note: `test_typing.py` is heavily inspired by `test_receipts.py`
* Fix typo 'datbases' in ConfigErrorAndrew Morgan2020-04-281-1/+1
|
* Fix collation for postgres for unit tests (#7359)Richard van der Hoff2020-04-282-1/+5
| | | | When running the UTs against a postgres deatbase, we need to set the collation correctly.
* Run replication streamers on workers (#7146)Erik Johnston2020-04-283-22/+25
| | | Currently we never write to streams from workers, but that will change soon
* Fix incorrect metrics reporting for renew_attestations (#7344)Richard van der Hoff2020-04-272-10/+10
| | | | We need to wait for the renewals to finish, so that the metrics are correctly reported.
* Document monitoring workers (#7357)Brendan Abolivier2020-04-272-0/+26
| | | It doesn't seem to be documented anywhere and means that you suddenly start losing metrics without any obvious reason when you go from monolith to workers (e.g. #7312).
* Add some explanation to application_services.md (#7091)lub2020-04-272-0/+5
| | | Signed-off-by: Simon Körner <git@lubiland.de>
* Don't crash when one of the configuration files is empty (#7341)Brendan Abolivier2020-04-272-0/+7
| | | | | If the admin adds a `.yaml` file that's either empty or doesn't parse into a dict to a config directory (e.g. `conf.d` for debs installs), stuff like https://github.com/matrix-org/synapse/issues/7322 would happen. This PR checks that the file is correctly parsed into a dict, or ignores it with a warning if it parses into any other type (including `None` for empty files). Fixes https://github.com/matrix-org/synapse/issues/7322
* Add documentation to the sample config about the templates for SSO. (#7343)Patrick Cloke2020-04-243-0/+49
|
* Convert some of the federation handler methods to async/await. (#7338)Patrick Cloke2020-04-242-25/+25
|
* Merge pull request #7337 from matrix-org/rav/fix_update_limit_assertionRichard van der Hoff2020-04-245-44/+147
|\ | | | | Fix assertions being thrown by the EventsStream update function
| * changelogRichard van der Hoff2020-04-241-0/+1
| |
| * Fix EventsStream raising assertions when it falls behindRichard van der Hoff2020-04-242-30/+129
| | | | | | | | | | | | | | | | | | | | Figuring out how to correctly limit updates from this stream without dropping entries is far more complicated than just counting the number of rows being returned. We need to consider each query separately and, if any one query hits the limit, truncate the results from the others. I think this also fixes some potentially long-standing bugs where events or state changes could get missed if we hit the limit on either query.
| * Make it clear that the limit for an update_function is a targetRichard van der Hoff2020-04-231-5/+9
| |
| * Remove 'limit' param from `get_repl_stream_updates` APIRichard van der Hoff2020-04-232-9/+8
| | | | | | | | | | there doesn't seem to be much point in passing this limit all around, since both sides agree it's meant to be 100.
* | Merge branch 'master' into developPatrick Cloke2020-04-233-1/+16
|\ \ | |/ |/|
| * Merge tag 'v1.12.4'Patrick Cloke2020-04-2313-59/+360
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse v1.12.4 Features: * Always send users their own device updates. (#7160) * Add support for handling GET requests for account_data on a worker. (#7311) Bugfixes: * Fix a bug that prevented cross-signing with users on worker-mode synapses. (#7255) * Do not treat display names as globs in push rules. (#7271) * Fix a bug with cross-signing devices belonging to remote users who did not share a room with any user on the local homeserver. (#7289)
| | * 1.12.4 v1.12.4 github/release-v1.12.4 release-v1.12.4Patrick Cloke2020-04-233-1/+13
| | |
* | | Revert "Revert "Merge pull request #7315 from ↵Brendan Abolivier2020-04-237-3/+121
| | | | | | | | | | | | | | | | | | matrix-org/babolivier/request_token"" This reverts commit 1adf6a55870aa08de272591ff49db9dc49738076.
* | | Merge branch 'master' into developBrendan Abolivier2020-04-233-3/+75
|\| |
| * | Revert "Merge pull request #7315 from matrix-org/babolivier/request_token"Brendan Abolivier2020-04-237-121/+3
| | | | | | | | | | | | | | | This reverts commit 6f4319368b3afab661c55367b9348f9b77bc04a5, reversing changes made to 0d775fcc2d0c7b6a07dad5430256d4d6c75a9f0d.
| * | Merge pull request #7315 from matrix-org/babolivier/request_tokenBrendan Abolivier2020-04-237-3/+121
| |\ \ | | | | | | | | Config option to inhibit 3PID errors on /requestToken
| | * | Config option to inhibit 3PID errors on /requestTokenBrendan Abolivier2020-04-227-3/+121
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a request_token_inhibit_errors configuration flag (disabled by default) which, if enabled, change the behaviour of all /requestToken endpoints so that they return a 200 and a fake sid if the 3PID was/was not found associated with an account (depending on the endpoint), instead of an error. Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
| * | | Improve example TURN configuration in documentation (#7284)nataraj-hates-MS-for-stealing-github2020-04-171-1/+1
| | | |
| * | | Add some warnings and notes about slow upgrade (#7275)Richard van der Hoff2020-04-152-2/+74
| | | | | | | | | | | | | | | | | | | | Fixes #7144.
* | | | Stop the master relaying USER_SYNC for other workers (#7318)Richard van der Hoff2020-04-2210-159/+199
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Long story short: if we're handling presence on the current worker, we shouldn't be sending USER_SYNC commands over replication. In an attempt to figure out what is going on here, I ended up refactoring some bits of the presencehandler code, so the first 4 commits here are non-functional refactors to move this code slightly closer to sanity. (There's still plenty to do here :/). Suggest reviewing individual commits. Fixes (I hope) #7257.
* | | | Fix replication metrics when using redis (#7325)Erik Johnston2020-04-223-37/+30
| | | |
* | | | Merge tag 'v1.12.4rc1' into developRichard van der Hoff2020-04-227-6/+18
|\ \ \ \ | | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.12.4rc1 (2020-04-22) ============================== Features -------- - Always send users their own device updates. ([\#7160](https://github.com/matrix-org/synapse/issues/7160)) - Add support for handling GET requests for `account_data` on a worker. ([\#7311](https://github.com/matrix-org/synapse/issues/7311)) Bugfixes -------- - Fix a bug that prevented cross-signing with users on worker-mode synapses. ([\#7255](https://github.com/matrix-org/synapse/issues/7255)) - Do not treat display names as globs in push rules. ([\#7271](https://github.com/matrix-org/synapse/issues/7271)) - Fix a bug with cross-signing devices belonging to remote users who did not share a room with any user on the local homeserver. ([\#7289](https://github.com/matrix-org/synapse/issues/7289))
| * | | formatting for the changelog v1.12.4rc1Richard van der Hoff2020-04-221-1/+1
| | | |
| * | | 1.12.4rc1Richard van der Hoff2020-04-226-5/+18
| | | |
| * | | 1.12.4rc1Richard van der Hoff2020-04-221-1/+1
| | | |
* | | | Another go at fixing one-word commands (#7326)Richard van der Hoff2020-04-223-1/+44
| | | | | | | | | | | | I messed this up last time I tried (#7239 / e13c6c7).
* | | | fix changelog nameRichard van der Hoff2020-04-221-0/+0
| | | |
* | | | Extend StreamChangeCache to support multiple entities per stream ID (#7303)Richard van der Hoff2020-04-226-56/+272
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First some background: StreamChangeCache is used to keep track of what "entities" have changed since a given stream ID. So for example, we might use it to keep track of when the last to-device message for a given user was received [1], and hence whether we need to pull any to-device messages from the database on a sync [2]. Now, it turns out that StreamChangeCache didn't support more than one thing being changed at a given stream_id (this was part of the problem with #7206). However, it's entirely valid to send to-device messages to more than one user at a time. As it turns out, this did in fact work, because *some* methods of StreamChangeCache coped ok with having multiple things changing on the same stream ID, and it seems we never actually use the methods which don't work on the stream change caches where we allow multiple changes at the same stream ID. But that feels horribly fragile, hence: let's update StreamChangeCache to properly support this, and add some typing and some more tests while we're at it. [1]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L301 [2]: https://github.com/matrix-org/synapse/blob/release-v1.12.3/synapse/storage/data_stores/main/deviceinbox.py#L47-L51
* | | | Extend room admin api with additional attributes (#7225)Dirk Klimpel2020-04-226-604/+869
| | | |
* | | | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-227-18/+197
|\| | |
| * | | Do not treat display names as globs for push rules. (#7271)Patrick Cloke2020-04-224-30/+106
| | | |
| * | | Query missing cross-signing keys on local sig upload (#7289)Andrew Morgan2020-04-223-18/+180
| | | |
| * | | Fix changelog fileRichard van der Hoff2020-04-212-1/+1
| | | | | | | | | | | | | | | | I updated the PR and forgot to update the changelog.
| * | | Support GET account_data requests on a worker (#7311)Richard van der Hoff2020-04-214-0/+17
| | | |
* | | | Add ability to run replication protocol over redis. (#7040)Erik Johnston2020-04-2212-36/+342
| | | | | | | | | | | | This is configured via the `redis` config options.
* | | | Reduce logging verbosity of URL cache cleanup. (#7295)Michael Kaye2020-04-222-2/+8
| | | |
* | | | import urllib.parse when using urllib.parse.quote (#7319)Andrew Morgan2020-04-222-1/+2
| | | |
* | | | Reduce federation logging on success (#7321)Michael Kaye2020-04-222-8/+15
| | | | | | | | | | | | | | | | Splitting based on the response code means we can avoid double logging here and identical information from line 164 while still logging at info if we don't get a good response and need to retry.
* | | | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-203-141/+12
|\| | |
| * | | Revert "Query missing cross-signing keys on local sig upload"Richard van der Hoff2020-04-203-141/+12
| | | | | | | | | | | | | | | | | | | | | | | | This was incorrectly merged to the release branch before it was ready. This reverts commit 72fe2affb6ac86d433b80b6452da57052365aa26.
* | | | Merge branch 'release-v1.12.4' into developRichard van der Hoff2020-04-203-12/+141
|\| | |
| * | | Always send the user updates to their own device list (#7160)David Baker2020-04-203-3/+19
| | | |
| * | | Query missing cross-signing keys on local sig uploadAndrew Morgan2020-04-173-12/+141
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add changelog Save retrieved keys to the db lint Fix and de-brittle remote result dict processing Use query_user_devices instead, assume only master, self_signing key types Make changelog more useful Remove very specific exception handling Wrap get_verify_key_from_cross_signing_key in a try/except Note that _get_e2e_cross_signing_verify_key can raise a SynapseError lint Add comment explaining why this is useful Only fetch master and self_signing key types Fix log statements, docstrings Remove extraneous items from remote query try/except lint Factor key retrieval out into a separate function Send device updates, modeled after SigningKeyEduUpdater._handle_signing_key_updates Update method docstring
| * | | Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-142-7/+12
| | | |
* | | | Fix indention in generated config file (#7300)Lars Franke2020-04-203-48/+49
| | | | | | | | | | | | | | | | | | | | | | | | Also adjust sample_config.yaml Signed-off-by: Lars Franke <frcl@mailbox.org>
* | | | Reject unknown UI auth sessions (instead of silently generating a new one) ↵Patrick Cloke2020-04-202-65/+95
| | | | | | | | | | | | | | | | (#7268)
* | | | On catchup, process each row with its own stream id (#7286)Richard van der Hoff2020-04-203-5/+72
| | | | | | | | | | | | | | | | | | | | | | | | Other parts of the code (such as the StreamChangeCache) assume that there will not be multiple changes with the same stream id. This code was introduced in #7024, and I hope this fixes #7206.
* | | | Use a template for the SSO success page to allow for customization. (#7279)Patrick Cloke2020-04-176-37/+66
| | | |
* | | | Added explicit Python build tools to snap requirements (#7213)James2020-04-172-0/+5
| | | | | | | | | | | | Signed-off-by: James Hebden <james@ec0.io>
* | | | Improve type checking in `replication.tcp.Stream` (#7291)Richard van der Hoff2020-04-175-122/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The general idea here is to get rid of the type: ignore annotations on all of the current_token and update_function assignments, which would have caught #7290. After a bit of experimentation, it seems like the least-awful way to do this is to pass the offending functions in as parameters to the Stream constructor. Unfortunately that means that the concrete implementations no longer have the same constructor signature as Stream itself, which means that it gets hard to correctly annotate STREAMS_MAP. I've also introduced a couple of new types, to take out some duplication.
* | | | Clarify the comments for media_storage_providers options (#7272)Tristan Lins2020-04-173-8/+7
| | | |
* | | | Do not treat display names as globs for push rules. (#7271)Patrick Cloke2020-04-164-30/+106
| | | |
* | | | Fix 'generator object is not subscriptable' error (#7290)Richard van der Hoff2020-04-162-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | Some of the query functions return generators rather than lists, so we can't index into the result. Happily we already have a copy of the results. (think this was introduced in #7024)
* | | | Convert auth handler to async/await (#7261)Patrick Cloke2020-04-1510-170/+224
| | | |
* | | | Add notes to the changelog about an additional SSO template. (#7259)Patrick Cloke2020-04-152-4/+9
| | | |
* | | | Allow specifying the value of Accept-Language header for URL previews (#7265)Andrew Morgan2020-04-155-2/+116
| | | |
* | | | Fix a potentially-huge sql query (#7274)Richard van der Hoff2020-04-152-7/+17
| | | | | | | | | | | | | | | | | | | | We could end up looking up tens of thousands of events, which could cause large amounts of data to be logged to the postgres log.
* | | | Fix the parameters of a test fixture (#7243)Zay11Zay2020-04-142-1/+2
| | | |
* | | | Only register devices edu handler on the master process (#7255)Andrew Morgan2020-04-142-7/+12
| | | |
* | | | Add setting to nginx configuration to allow larger file uploads (#7251)Ryan Hovland2020-04-132-0/+4
| | | |
* | | | Check on room creation if the user is allowed to publish the room to the ↵PeerD2020-04-132-0/+8
| | | | | | | | | | | | | | | | room directory. (#7260)
* | | | typosMatthew Hodgson2020-04-112-2/+2
| | | |
* | | | Default PL100 to enable encryption in a room (#7230)Andrew Morgan2020-04-094-4/+299
| | | |
* | | | Do not allow a deactivated user to login via SSO. (#7240)Patrick Cloke2020-04-098-10/+110
| | | |
* | | | Unblacklist /upgrade creates a new room (#7228)Andrew Morgan2020-04-092-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | This commit was originally merged in #7228 but reverted in #7254 as the associated sytest was not ready yet. Now that it is, we can merge this again.
* | | | Add matrix-synapse-shared-secret-auth as an example password provider (#7248)Andrew Morgan2020-04-092-0/+2
| | | |
* | | | Revert "Unblacklist /upgrade creates a new room (#7228)" (#7254)Andrew Morgan2020-04-092-1/+2
| | | | | | | | | | | | This reverts commit 59f0ca8b87c15a314859d94978d90a8aa0e7543b.
* | | | Unblacklist /upgrade creates a new room (#7228)Andrew Morgan2020-04-092-2/+1
| | | |
* | | | Fix --help commandline argument (#7249)Richard van der Hoff2020-04-092-16/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I don't really remember why this was so complicated; I think it dates back to the time when we had to instantiate the Config classes before we could call `add_arguments` - ie before #5597. In any case, I don't think there's a good reason for it any more, and the impact of it being complicated is that `--help` doesn't work correctly.
* | | | Make it clearer to the user that they haven't overridden onLogin/Register ↵Andrew Morgan2020-04-093-3/+3
| | | | | | | | | | | | | | | | (#7237)
* | | | Upgrade jQuery to 3.x on fallback login/registration screens (#7236)Andrew Morgan2020-04-099-16/+15
| | | |
* | | | Fix bad merge of CHANGES.mdRichard van der Hoff2020-04-081-5/+1
| | | |
* | | | Remove redundant checks on `daemonize` from synctl (#7233)Richard van der Hoff2020-04-082-9/+12
| | | | | | | | | | | | | | | | | | | | We pass --daemonize on the commandline, which (since at least #4853) overrides whatever the config file, so there is no need for it to be set in the config file.
* | | | Make systemd-with-workers doc official (#7234)Richard van der Hoff2020-04-0810-194/+134
| | | | | | | | | | | | | | | | Simplify and update this documentation, and make it part of the core dist.
* | | | Fix changelog for #7235Brendan Abolivier2020-04-082-1/+1
| | | |
* | | | Add documentation to password_providers config option (#7238)Andrew Morgan2020-04-084-4/+32
| | | |
* | | | bg update to clear out duplicate outbound_device_list_pokes (#7193)Richard van der Hoff2020-04-076-13/+234
| | | | | | | | | | | | | | | | We seem to have some duplicates, which could do with being cleared out.
* | | | Merge pull request #7239 from matrix-org/rav/replication_cleanupRichard van der Hoff2020-04-074-32/+36
|\ \ \ \ | | | | | | | | | | Miscellaneous cleanups to replication code
| * | | | changelogRichard van der Hoff2020-04-071-0/+1
| | | | |
| * | | | Handle one-word replication commands correctlyRichard van der Hoff2020-04-071-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | `REPLICATE` is now a valid command, and it's nice if you can issue it from the console without remembering to call it `REPLICATE ` with a trailing space.
| * | | | Fix warnings about not calling superclass constructorRichard van der Hoff2020-04-071-15/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Separate `SimpleCommand` from `Command`, so that things which don't want to use the `data` property don't have to, and thus fix the warnings PyCharm was giving me about not calling `__init__` in the base class.
| * | | | Remove vestigal references to SYNC replication commandRichard van der Hoff2020-04-072-14/+0
| | | | | | | | | | | | | | | | | | | | We've ripped pretty much all of this out: let's remove the remains.
* | | | | Convert delete_url_cache_media to async/await. (#7241)Patrick Cloke2020-04-072-2/+3
| | | | |
* | | | | Add typing information to federation_server. (#7219)Patrick Cloke2020-04-073-66/+109
| | | | |
* | | | | Fix typo in the login fallback javascript (#7235)Brendan Abolivier2020-04-072-1/+2
|/ / / / | | | | | | | | | | | | | | | | * Fix typo in the login fallback javascript * Changelog
* | | | Remove sent outbound device list pokes from the database (#7192)Richard van der Hoff2020-04-073-2/+24
| | | | | | | | | | | | They just get in the way.
* | | | Fix race in replication (#7226)Erik Johnston2020-04-074-49/+68
| | | | | | | | | | | | | | | | Fixes a race between handling `POSITION` and `RDATA` commands. We do this by simply linearizing handling of them.
* | | | Move server command handling out of TCP protocol (#7187)Erik Johnston2020-04-074-269/+237
| | | | | | | | | | | | This completes the merging of server and client command processing.
* | | | Add information about .well-known to Debian installation. (#7227)Patrick Cloke2020-04-063-7/+18
| | | |
* | | | Remove stream before/after debug log lines (#7207)Andrew Morgan2020-04-062-2/+1
| | | |
* | | | Improve error responses when a remote server doesn't allow you to access its ↵Andrew Morgan2020-04-063-24/+33
| | | | | | | | | | | | | | | | public rooms list (#6899)
* | | | Move client command handling out of TCP protocol (#7185)Erik Johnston2020-04-0612-371/+378
| | | | | | | | | | | | The aim here is to move the command handling out of the TCP protocol classes and to also merge the client and server command handling (so that we can reuse them for redis protocol). This PR simply moves the client paths to the new `ReplicationCommandHandler`, a future PR will move the server paths too.
* | | | Server notices: Dissociate room creation/lookup from invite (#7199)Brendan Abolivier2020-04-044-22/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #6815 Before figuring out whether we should alert a user on MAU, we call get_notice_room_for_user to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by get_notice_room_for_user is cached. This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by get_notice_room_for_user doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts, so that function won't run very often. It also renames get_notice_room_for_user into get_or_create_notice_room_for_user to make what it does clearer.
* | | | Support CAS in UI Auth flows. (#7186)Patrick Cloke2020-04-035-83/+131
| | | |
* | | | Extend web_client_location to handle absolute URLs (#7006)Martin Milata2020-04-034-9/+30
| | | | | | | | | | | | | | | | | | | | Log warning when filesystem path is used. Signed-off-by: Martin Milata <martin@martinmilata.cz>
* | | | Add some benchmarks for LruCache (#6446)Amber Brown2020-04-035-5/+91
| | | |
* | | | Convert http.HTTPStatus objects to their int equivalent (#7188)Andrew Morgan2020-04-032-1/+9
| | | |
* | | | Reduce the number of calls to `resource.getrusage` (#7183)Richard van der Hoff2020-04-032-39/+64
| | | | | | | | | | | | Let's just call `getrusage` once on each logcontext change, rather than twice.
* | | | Merge pull request #7190 from matrix-org/rav/one_bg_update_at_a_timeRichard van der Hoff2020-04-036-72/+99
|\ \ \ \ | | | | | | | | | | Only run one background update at a time
| * | | | Update docstring per review commentsRichard van der Hoff2020-04-031-1/+1
| | | | |
| * | | | review commentRichard van der Hoff2020-04-021-1/+1
| | | | |
| * | | | changelogRichard van der Hoff2020-03-311-0/+1
| | | | |
| * | | | Only run one background update at a timeRichard van der Hoff2020-03-313-27/+68
| | | | |
| * | | | Make do_next_background_update return a boolRichard van der Hoff2020-03-312-10/+8
| | | | | | | | | | | | | | | | | | | | returning a None or an int that we don't use is confusing.
| * | | | Set a logging context while running the bg updatesRichard van der Hoff2020-03-311-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | This mostly just reduces the amount of "running from sentinel context" spam during unittest setup.
| * | | | Make `has_completed_background_updates` asyncRichard van der Hoff2020-03-312-5/+6
| | | | | | | | | | | | | | | | | | | | (Almost) everywhere that uses it is happy with an awaitable.
| * | | | Remove unused `start_background_update`Richard van der Hoff2020-03-312-26/+9
| | | | | | | | | | | | | | | | | | | | This was only used in a unit test, so let's just inline it in the test.
* | | | | Remove some `run_in_background` calls in replication code (#7203)Richard van der Hoff2020-04-032-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By running this stuff with `run_in_background`, it won't be correctly reported against the relevant CPU usage stats. Fixes #7202
* | | | | Merge branch 'master' into developRichard van der Hoff2020-04-034-7/+62
|\ \ \ \ \
| * | | | | Revert "Revert "Merge pull request #7153 from ↵Richard van der Hoff2020-04-034-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/babolivier/sso_whitelist_login_fallback"" This reverts commit 0122ef1037c8bfe826ea09d9fc7cd63fb9c59fd1.
| * | | | | Revert "Revert "Improve the UX of the login fallback when using SSO (#7152)""Richard van der Hoff2020-04-033-22/+32
| | |_|/ / | |/| | | | | | | | | | | | | This reverts commit 8d4cbdeaa9765ae0d87ec82b053f12ed8162f6f5.
| * | | | Merge tag 'v1.12.3'Richard van der Hoff2020-04-035-10/+46
| |\ \ \ \ | | | |/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.12.3 (2020-04-03) =========================== - Remove the the pin to Pillow 7.0 which was introduced in Synapse 1.12.2, and correctly fix the issue with building the Debian packages. ([\#7212](https://github.com/matrix-org/synapse/issues/7212))
| | * | | tweak changelog v1.12.3 github/release-v1.12.3 release-v1.12.3Richard van der Hoff2020-04-031-5/+2
| | | | |
| | * | | 1.12.3Richard van der Hoff2020-04-034-4/+16
| | | | |
| | * | | Fix the debian build in a better way. (#7212)Richard van der Hoff2020-04-034-9/+36
| | | | |
| * | | | Merge tag 'v1.12.2'Richard van der Hoff2020-04-034-2/+20
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.12.2 (2020-04-02) =========================== This release fixes [an issue](https://github.com/matrix-org/synapse/issues/7208) with building the debian packages. No other significant changes since 1.12.1.
| | * | | Fix changelog wording v1.12.2 github/release-v1.12.2 release-v1.12.2Andrew Morgan2020-04-021-1/+1
| | | | |
| | * | | 1.12.2Andrew Morgan2020-04-023-1/+17
| | | | |
| | * | | Pin Pillow>=4.3.0,<7.1.0 to fix dep issueAndrew Morgan2020-04-021-1/+3
| | | | |
| | * | | 1.12.1Andrew Morgan2020-04-023-1/+13
| | | | |
| * | | | Revert "Merge pull request #7153 from ↵Richard van der Hoff2020-04-034-28/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/babolivier/sso_whitelist_login_fallback" This was incorrectly merged to master. This reverts commit 319c41f573eb14a966367b60b2e6e93bf6b028d9, reversing changes made to 229eb81498b0fe1da81e9b5b333a0285acde9446.
| * | | | Revert "Improve the UX of the login fallback when using SSO (#7152)"Richard van der Hoff2020-04-033-32/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was incorrectly merged to `master` instead of develop. This reverts commit 90246344e340bce3417fb330da6be9338a701c5c.
* | | | | Fix device list update stream ids going backward (#7158)Richard van der Hoff2020-04-033-2/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Occasionally we could get a federation device list update transaction which looked like: ``` [ {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D2', 'prev_id': [], 'stream_id': 12, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D1', 'prev_id': [12], 'stream_id': 11, 'deleted': True}}, {'edu_type': 'm.device_list_update', 'content': {'user_id': '@user:test', 'device_id': 'D3', 'prev_id': [11], 'stream_id': 13, 'deleted': True}} ] ``` Having `stream_ids` which are lower than `prev_ids` looks odd. It might work (I'm not actually sure), but in any case it doesn't seem like a reasonable thing to expect other implementations to support.
* | | | | Merge branch 'master' into developAndrew Morgan2020-04-024-4/+26
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: 1.12.1 Note where bugs were introduced 1.12.1rc1 Newsfile Rewrite changelog Add changelog Only import sqlite3 when type checking Fix another instance Only setdefault for signatures if device has key_json Fix starting workers when federation sending not split out. Attempt to clarify Python version requirements (#7161) Improve the UX of the login fallback when using SSO (#7152) Update the wording of the config comment Lint Changelog Regenerate sample config Whitelist the login fallback by default for SSO
| * | | | Merge tag 'v1.12.1'Andrew Morgan2020-04-026-13/+55
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.12.1 (2020-04-02) =========================== No significant changes since 1.12.1rc1. Synapse 1.12.1rc1 (2020-03-31) ============================== Bugfixes -------- - Fix starting workers when federation sending not split out. ([\#7133](https://github.com/matrix-org/synapse/issues/7133)). Introduced in v1.12.0. - Avoid importing `sqlite3` when using the postgres backend. Contributed by David Vo. ([\#7155](https://github.com/matrix-org/synapse/issues/7155)). Introduced in v1.12.0rc1. - Fix a bug which could cause outbound federation traffic to stop working if a client uploaded an incorrect e2e device signature. ([\#7177](https://github.com/matrix-org/synapse/issues/7177)). Introduced in v1.11.0. * tag 'v1.12.1': 1.12.1 Note where bugs were introduced 1.12.1rc1 Newsfile Rewrite changelog Add changelog Only import sqlite3 when type checking Fix another instance Only setdefault for signatures if device has key_json Fix starting workers when federation sending not split out.
| | * | | | 1.12.1 v1.12.1 github/release-v1.12.1 release-v1.12.1Andrew Morgan2020-04-023-1/+13
| | |/ / /
| | * | | Note where bugs were introduced v1.12.1rc1Andrew Morgan2020-03-311-3/+3
| | | | |
| | * | | 1.12.1rc1Andrew Morgan2020-03-315-4/+12
| | | | |
| | * | | NewsfileErik Johnston2020-03-311-0/+1
| | | | |
| | * | | Rewrite changelogAndrew Morgan2020-03-311-1/+1
| | | | |
| | * | | Add changelogAndrew Morgan2020-03-311-0/+1
| | | | |
| | * | | Only import sqlite3 when type checkingDavid Vo2020-03-312-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
| | * | | Fix another instanceAndrew Morgan2020-03-311-5/+7
| | | | |
| | * | | Only setdefault for signatures if device has key_jsonAndrew Morgan2020-03-311-5/+7
| | | | |
| | * | | Fix starting workers when federation sending not split out.Erik Johnston2020-03-311-0/+12
| | | |/ | | |/|
| * | | Attempt to clarify Python version requirements (#7161)Richard van der Hoff2020-03-301-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular, we depend on `typing.TYPE_CHECKING`, which is only present in 3.5.2. It turns out that Ubuntu Xenial, despite having a package called `python 3 (3.5.1-3)`, actually has python 3.5.2, so I think this is fine.
| * | | Improve the UX of the login fallback when using SSO (#7152)Brendan Abolivier2020-03-273-22/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.
| * | | Merge pull request #7153 from matrix-org/babolivier/sso_whitelist_login_fallbackBrendan Abolivier2020-03-274-1/+28
| |\ \ \ | | | | | | | | | | Always whitelist the login fallback for SSO
| | * | | Update the wording of the config commentBrendan Abolivier2020-03-272-6/+6
| | | | |
| | * | | LintBrendan Abolivier2020-03-261-5/+1
| | | | |
| | * | | ChangelogBrendan Abolivier2020-03-261-0/+1
| | | | |
| | * | | Regenerate sample configBrendan Abolivier2020-03-261-1/+5
| | | | |
| | * | | Whitelist the login fallback by default for SSOBrendan Abolivier2020-03-262-2/+28
| | |/ /
* | | | Support SAML in the user interactive authentication workflow. (#7102)Patrick Cloke2020-04-0111-44/+227
| | | |
* | | | Allow admins to create aliases when they are not in the room (#7191)Patrick Cloke2020-04-013-1/+68
| | | |
* | | | Update postgres.md (#7119)siroccal2020-04-012-1/+28
| | | |
* | | | Remove connections per replication stream metric. (#7195)Erik Johnston2020-04-012-16/+1
| | | | | | | | | | | | | | | | | | | | This broke in a recent PR (#7024) and is no longer useful due to all replication clients implicitly subscribing to all streams, so let's just remove it.
* | | | Improve TURN documentation. (#7167)Jostein Kjønigsen2020-03-312-0/+8
| |_|/ |/| |
* | | Fix "'NoneType' has no attribute start|stop" logcontext errors (#7181)Richard van der Hoff2020-03-313-7/+12
| | | | | | | | | | | | Fixes #7179.
* | | Fill in the 'default' field for user-defined push rules (#6639)Karlinde2020-03-312-0/+2
| | | | | | | | | Signed-off-by: Karl Linderhed <git@karlinde.se>
* | | Only setdefault for signatures if device has key_json (#7177)Andrew Morgan2020-03-312-10/+15
| | |
* | | Fix use of async/await in media code (#7184)Patrick Cloke2020-03-312-2/+3
| | |
* | | Fix a bug which could cause incorrect 'cyclic dependency' error. (#7178)Richard van der Hoff2020-03-312-12/+11
| | | | | | | | | | | | | | | | | | | | | | | | If there was an exception setting up one of the attributes of the Homeserver god object, then future attempts to fetch that attribute would raise a confusing "Cyclic dependency" error. Let's make sure that we clear the `building` flag so that we just get the original exception. Ref: #7169
* | | Rewrite prune_old_outbound_device_pokes for efficiency (#7159)Richard van der Hoff2020-03-305-37/+173
| | | | | | | | | | | | make sure we clear out all but one update for the user
* | | Transfer alias mappings when joining an upgraded room (#6946)Andrew Morgan2020-03-303-3/+27
| | |
* | | Fix a small typo in the `metrics_flags` config option. (#7171)Andrew Morgan2020-03-303-2/+3
| | |
* | | Remove usage of "conn_id" for presence. (#7128)Erik Johnston2020-03-309-22/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove `conn_id` usage for UserSyncCommand. Each tcp replication connection is assigned a "conn_id", which is used to give an ID to a remotely connected worker. In a redis world, there will no longer be a one to one mapping between connection and instance, so instead we need to replace such usages with an ID generated by the remote instances and included in the replicaiton commands. This really only effects UserSyncCommand. * Add CLEAR_USER_SYNCS command that is sent on shutdown. This should help with the case where a synchrotron gets restarted gracefully, rather than rely on 5 minute timeout.
* | | Merge pull request #7160 from ↵David Baker2020-03-303-3/+19
|\ \ \ | | | | | | | | | | | | | | | | matrix-org/dbkr/always_send_own_device_list_updates Always send the user updates to their own device list
| * | | Add explanatory commentAndrew Morgan2020-03-302-1/+4
| | | |
| * | | blackDavid Baker2020-03-301-1/+3
| | | |
| * | | Just add own user ID to the list we track device changes forDavid Baker2020-03-302-7/+11
| | | |
| * | | Fix undefined variable & remove debug loggingDavid Baker2020-03-271-10/+2
| | | |
| * | | blackDavid Baker2020-03-271-4/+4
| | | |
| * | | changelogDavid Baker2020-03-271-0/+1
| | | |
| * | | Always send the user updates to their own device listDavid Baker2020-03-272-6/+20
| | | | | | | | | | | | | | | | | | | | This will allow clients to notify users about new devices even if the user isn't in any rooms (yet).
* | | | Merge pull request #7157 from matrix-org/rev.outbound_device_pokes_testsRichard van der Hoff2020-03-3011-22/+318
|\ \ \ \ | | | | | | | | | | Add tests for outbound device pokes
| * | | | Add tests for outbound device pokesRichard van der Hoff2020-03-273-3/+302
| | | | |
| * | | | Remove spurious "name" parameter to `default_config`Richard van der Hoff2020-03-249-19/+16
| | | | | | | | | | | | | | | | | | | | | | | | | this is never set to anything other than "test", and is a source of unnecessary boilerplate.
* | | | | Add developer documentation for running a local CAS server (#7147)Patrick Cloke2020-03-303-2/+71
| | | | |
* | | | | Always whitelist the login fallback for SSO (#7153)Richard van der Hoff2020-03-274-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That fallback sets the redirect URL to itself (so it can process the login token then return gracefully to the client). This would make it pointless to ask the user for confirmation, since the URL the confirmation page would be showing wouldn't be the client's.
* | | | | Improve the UX of the login fallback when using SSO (#7152)Brendan Abolivier2020-03-273-22/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Don't show the login forms if we're currently logging in with a password or a token. * Submit directly the SSO login form, showing only a spinner to the user, in order to eliminate from the clunkiness of SSO through this fallback.
* | | | | Admin API to join users to a room. (#7051)Dirk Klimpel2020-03-275-4/+405
| | | | |
* | | | | Add options to prevent users from changing their profile. (#7096)Dirk Klimpel2020-03-277-1/+449
| | | | |
* | | | | update debian installation instructions to recommend installing `virtualenv` ↵txt-file2020-03-272-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of `python3-virtualenv` (#6892) * change debian package from python3-virtualenv to virtualenv The virtualenv package is needed for the virtualenv command. The virtualenv package depends on python3-virtualenv (at least since debian jessie) so there is no need to specify python3-virtualenv additionally. Signed-off-by: Vieno Hakkerinen <vieno@hakkerinen.eu> * Add changelog Co-authored-by: Andrew Morgan <andrew@amorgan.xyz>
* | | | | Ensure is_verified on /_matrix/client/r0/room_keys/keys is a boolean (#7150)Andrew Morgan2020-03-273-2/+4
| | | | |
* | | | | Only import sqlite3 when type checking (#7155)David Vo2020-03-272-2/+6
| |/ / / |/| | | | | | | | | | | Fixes: #7127 Signed-off-by: David Vo <david@vovo.id.au>
* | | | Merge pull request #7151 from matrix-org/jaywink/saml-redirect-fixJason Robinson2020-03-262-0/+5
|\ \ \ \ | | | | | | | | | | Allow RedirectResponse in SAML response handler
| * | | | Update changelog.d/7151.bugfixJason Robinson2020-03-261-1/+1
| | | | | | | | | | | | | | | Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * | | | Allow RedirectResponse in SAML response handlerJason Robinson2020-03-262-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow custom SAML handlers to redirect after processing an auth response. Fixes #7149 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | | | | Refactor the CAS code (move the logic out of the REST layer to a handler) ↵Patrick Cloke2020-03-265-155/+227
| | | | | | | | | | | | | | | | | | | | (#7136)
* | | | | Don't default to an invalid sqlite config if no database configuration is ↵Nektarios Katakis2020-03-262-22/+48
| | | | | | | | | | | | | | | | | | | | provided (#6573)
* | | | | Allow server admins to define and enforce a password policy (MSC2000). (#7118)Dirk Klimpel2020-03-2611-0/+437
|/ / / /
* | | | Validate that the session is not modified during UI-Auth (#7068)Patrick Cloke2020-03-268-14/+117
| | | |
* | | | Remove unused captcha_bypass_secret option (#7137)Aaron Raimist2020-03-253-9/+1
| | | | | | | | | | | | Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | | | Move catchup of replication streams to worker. (#7024)Erik Johnston2020-03-2524-487/+635
| | | | | | | | | | | | This changes the replication protocol so that the server does not send down `RDATA` for rows that happened before the client connected. Instead, the server will send a `POSITION` and clients then query the database (or master out of band) to get up to date.
* | | | Various cleanups to INSTALL.md (#7141)Andrew Morgan2020-03-252-59/+40
| | | |
* | | | Merge pull request #7133 from matrix-org/erikj/fix_worker_startupErik Johnston2020-03-252-0/+13
|\ \ \ \ | | | | | | | | | | Fix starting workers when federation sending not split out.