summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Time how long it takes us to do backfill processing (#13535)Eric Eastwood2022-08-173-16/+90
|
* Add specific metric to time long-running `/messages` requests (#13533)Eric Eastwood2022-08-172-0/+33
|
* Instrument the federation/backfill part of `/messages` (#13489)Eric Eastwood2022-08-1611-33/+220
| | | | | | | | | Instrument the federation/backfill part of `/messages` so it's easier to follow what's going on in Jaeger when viewing a trace. Split out from https://github.com/matrix-org/synapse/pull/13440 Follow-up from https://github.com/matrix-org/synapse/pull/13368 Part of https://github.com/matrix-org/synapse/issues/13356
* Merge branch 'master' into developAndrew Morgan2022-08-163-2/+14
|\
| * Note explicitly that #11365 was reverted in the 1.65 CHANGELOGAndrew Morgan2022-08-161-1/+1
| |
| * 1.65.0 v1.65.0Andrew Morgan2022-08-163-1/+13
| |
* | Refuse to start when `faster_joins` is enabled on a worker deployment (#13531)Sean Quah2022-08-162-0/+8
| | | | | | | | | | | | Synapse does not currently support faster room joins on deployments with workers. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Add missing links in `user_consent` section of configuration manual (#13536)Dirk Klimpel2022-08-162-2/+3
| | | | | | Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* | Faster room joins: make `/joined_members` block whilst the room is partial ↵reivilibre2022-08-164-1/+22
| | | | | | | | stated. (#13514)
* | Make push rules use proper structures. (#13522)Erik Johnston2022-08-168-333/+494
| | | | | | | | | | | | | | | | | | | | | | | | This improves load times for push rules: | Version | Time per user | Time for 1k users | | -------------------- | ------------- | ----------------- | | Before | 138 µs | 138ms | | Now (with custom) | 2.11 µs | 2.11ms | | Now (without custom) | 49.7 ns | 0.05 ms | This therefore has a large impact on send times for rooms with large numbers of local users in the room.
* | Use Pydantic to systematically validate a first batch of endpoints in ↵David Robertson2022-08-1510-92/+296
| | | | | | | | `synapse.rest.client.account`. (#13188)
* | Add a warning to retention documentation regarding the possibility of ↵Shay2022-08-153-2/+9
| | | | | | | | database corruption (#13497)
* | Instrument `FederationStateIdsServlet` - `/state_ids` (#13499)Eric Eastwood2022-08-155-2/+21
| | | | | | Instrument FederationStateIdsServlet - `/state_ids` so it's easier to follow what's going on in Jaeger when viewing a trace.
* | Revert "Update locked versions of mypy and mypy-zope (#13521)"David Robertson2022-08-157-60/+73
| | | | | | | | | | | | | | | | This reverts commit f383b9b3eceaa082d5ae690550fe41460b711779. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.
* | Clarifications for event push action processing. (#13485)Patrick Cloke2022-08-153-21/+35
| | | | | | | | | | | | | | | | * Clarifies comments. * Fixes an erroneous comment (about return type) added in #13455 (ec24813220f9d54108924dc04aecd24555277b99). * Clarifies the name of a variable. * Simplifies logic of pulling out the latest join for the requesting user.
* | Update locked versions of mypy and mypy-zope (#13521)David Robertson2022-08-157-73/+60
| |
* | Update grafana dashboardRichard van der Hoff2022-08-131-1805/+2695
| |
* | Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker ↵reivilibre2022-08-122-1/+2
| | | | | | | | image. (#13515)
* | Add `openssl` example for registration HMAC (#13472)James Barton2022-08-112-2/+20
| | | | | | Signed-off-by: James Barton <james@neodon.com>
* | Add note to `redaction_retention_period` documentation mentioning that event ↵Andrew Morgan2022-08-112-0/+5
| | | | | | | | purging runs at most every 5m (#13492)
* | Add viewport directive to HTML templates to optimise for mobile (#13493)Germain2022-08-1131-47/+140
| |
* | Merge branch 'release-v1.65' into developOlivier Wilkinson (reivilibre)2022-08-114-1/+17
|\|
| * 1.65.0rc2 v1.65.0rc2Olivier Wilkinson (reivilibre)2022-08-114-2/+16
| |
| * Revert 'Remove the unspecced field in the response. (#13365)' to give more ↵reivilibre2022-08-112-0/+2
| | | | | | | | time for clients to update. (#13501)
* | Update the rejected state of events during resync (#13459)Richard van der Hoff2022-08-114-9/+66
| | | | | | | | | | Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.
* | Use literals in place of `HTTPStatus` constants in tests (#13488)Dirk Klimpel2022-08-1012-447/+177
| | | | | | | | | | | | | | | | | | * Use literals in place of `HTTPStatus` constants in tests * newsfile * code style * code style
* | Add some miscellaneous comments around sync (#13474)Sean Quah2022-08-103-40/+81
| | | | | | | | | | | | | | | | Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)Eric Eastwood2022-08-093-56/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```
* | Use literals in place of `HTTPStatus` constants in tests (#13479)Dirk Klimpel2022-08-0912-141/+141
| | | | | | | | | | | | | | | | | | | | Replace - `HTTPStatus.NOT_FOUND` - `HTTPStatus.FORBIDDEN` - `HTTPStatus.UNAUTHORIZED` - `HTTPStatus.CONFLICT` - `HTTPStatus.CREATED` Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* | Merge branch 'release-v1.65' into developOlivier Wilkinson (reivilibre)2022-08-0952-51/+81
|\|
| * Fix changelog mistakeOlivier Wilkinson (reivilibre)2022-08-091-2/+1
| |
| * Tweak the changelog v1.65.0rc1Olivier Wilkinson (reivilibre)2022-08-091-6/+6
| |
| * 1.65.0rc1Olivier Wilkinson (reivilibre)2022-08-0952-51/+82
| |
* | Strengthen tests about deleted old push actions. (#13471)Patrick Cloke2022-08-092-0/+16
|/
* Make the configuration for the cache clearer (#13481)Dirk Klimpel2022-08-092-4/+6
|
* Update matrix-synapse-ldap3 version in lockfile to v0.2.2. (#13470)Shay2022-08-082-12/+14
|
* Use literals in place of `HTTPStatus` constants in tests (#13469)Dirk Klimpel2022-08-0813-331/+329
|
* Correct a misnamed argument in state res v2 (#13467)David Robertson2022-08-082-6/+7
| | | | | | | | | | | In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.
* Support stable identifiers for MSC2285: private read receipts. (#13273)Šimon Brandner2022-08-0514-94/+246
| | | | | This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.
* Use literals in place of `HTTPStatus` constants in tests (#13463)Dirk Klimpel2022-08-0518-191/+172
|
* Mark token-authenticaticated-registration API as not-experimental (#11897)Julian-Samuel Gebühr2022-08-052-3/+4
|
* Update module API "update room membership" method to allow for remote joins ↵Matt C2022-08-053-4/+34
| | | | | | (#13441) Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Add comments about how event push actions are stored. (#13445)Erik Johnston2022-08-042-0/+62
|
* Fix `@tag_args` being off-by-one (ahead) (#13452)Eric Eastwood2022-08-042-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix @tag_args being off-by-one (ahead) Example: ``` argspec.args=[ 'self', 'room_id' ] args=( <synapse.storage.databases.main.DataStore object at 0x10d0b8d00>, '!HBehERstyQBxyJDLfR:my.synapse.server' ) ``` --- The previous logic was also flawed and we can end up in a situation like this: ``` argspec.args=['self', 'dest', 'room_id', 'limit', 'extremities'] args=(<synapse.federation.federation_client.FederationClient object at 0x7f1651c18160>, 'hs1', '!jAEHKIubyIfuLOdfpY:hs1') ``` From this source: ```py async def backfill( self, dest: str, room_id: str, limit: int, extremities: Collection[str] ) -> Optional[List[EventBase]]: ``` And this usage: ```py events = await self._federation_client.backfill( dest, room_id, limit=limit, extremities=extremities ) ``` which would previously cause this error: ``` synapse_main | 2022-08-04 06:13:12,051 - synapse.handlers.federation - 424 - ERROR - GET-5 - Failed to backfill from hs1 because tuple index out of range synapse_main | Traceback (most recent call last): synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation.py", line 392, in try_backfill synapse_main | await self._federation_event_handler.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation_event.py", line 593, in backfill synapse_main | events = await self._federation_client.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 827, in _wrapper synapse_main | with wrapping_logic(func, *args, **kwargs): synapse_main | File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__ synapse_main | return next(self.gen) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 922, in _wrapping_logic synapse_main | set_attribute("ARG_" + arg, str(args[i + 1])) # type: ignore[index] synapse_main | IndexError: tuple index out of range ```
* Improve comments (& avoid a duplicate query) in push actions processing. ↵Patrick Cloke2022-08-042-124/+159
| | | | | | | | | (#13455) * Adds docstrings and inline comments. * Formats SQL queries using triple quoted strings. * Minor formatting changes. * Avoid fetching `event_push_summary_stream_ordering` multiple times in the same transactions.
* Update type of `EventContext.rejected` (#13460)Richard van der Hoff2022-08-043-5/+5
|
* Faster Room Joins: prevent Synapse from answering federated join requests ↵reivilibre2022-08-043-0/+35
| | | | for a room which it has not fully joined yet. (#13416)
* Optimise async get event lookups (#13435)Nick Mills-Barrett2022-08-044-8/+87
| | | | | | Still maintains local in memory lookup optimisation, but does any external lookup as part of the deferred that prevents duplicate lookups for the same event at once. This makes the assumption that fetching from an external cache is a non-zero load operation.
* Update some outdated information on `sso_mapping_providers.md` (#13449)Dirk Klimpel2022-08-042-6/+9
|
* Fix return value in example on `password_auth_provider_callbacks.md` (#13450)Dirk Klimpel2022-08-042-2/+3
| | | | | Fixes: #12534 Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* synapse-workers docker: copy nginx and redis in from base images (#13447)Richard van der Hoff2022-08-043-36/+60
| | | Part of my continuing quest to make the docker images build quicker: copy nginx and redis in from base docker images, rather than apt installing each time.
* Add module API method to create a room (#13429)Matt C2022-08-043-0/+103
| | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix rooms not being properly excluded from incremental sync (#13408)Brendan Abolivier2022-08-043-10/+37
|
* Add some tracing spans to give insight into local joins (#13439)Shay2022-08-033-33/+40
|
* Instrument `/messages` for understandable traces in Jaeger (#13368)Eric Eastwood2022-08-0311-1/+32
| | | | | | In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work
* Return 404 or member list when getting joined_members after leaving (#13374)andrew do2022-08-033-2/+20
| | | | | | Signed-off-by: Andrew Doh <andrewddo@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <andrewm@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Install cryptography build dependencies in requirements image. (#13372)Jasper Spaans2022-08-032-1/+3
|
* Improve documentation on becoming server admin (#13230)jejo862022-08-032-1/+3
| | | | | | | | | | | | | | | | | | | | | | | * Improved section regarding server admin Added steps describing how to elevate an existing user to administrator by manipulating a `postgres` database. Signed-off-by: jejo86 28619134+jejo86@users.noreply.github.com * Improved section regarding server admin * Reference database settings Add instructions to check database settings to find out the database name, instead of listing all available PostgreSQL databases. * Add suggestions from PR conversation Replace config filename `homeserver.yaml`. with "config file". Remove instructions to switch to `postgres` user. Add instructions how to connect to SQLite database. * Update changelog.d/13230.doc Co-authored-by: reivilibre <olivier@librepush.net>
* Update doc for setting `macaroon_secret_key` (#13443)Dirk Klimpel2022-08-032-3/+8
| | | | | * Update doc for setting `macaroon_secret_key` * newsfile
* Rename `RateLimitConfig` to `RatelimitSettings` (#13442)Dirk Klimpel2022-08-035-29/+30
|
* Add module API method to resolve a room alias to a room ID (#13428)Matt C2022-08-033-0/+44
| | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Remove 'Contents' section from the Configuration Manual (#13438)Dirk Klimpel2022-08-032-43/+1
| | | Fixes: #13053
* Fix wrong headline for `url_preview_accept_language` in docs (#13437)Dirk Klimpel2022-08-032-1/+2
| | | Fixes: #13433
* Add a `merge-back` command to the release script, which automates merging ↵reivilibre2022-08-022-0/+77
| | | | the correct branches after a release. (#13393)
* Fix error when out of servers to sync partial state with (#13432)Sean Quah2022-08-022-2/+4
| | | | | so that we raise the intended error instead. Signed-off-by: Sean Quah <seanq@matrix.org>
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-08-024-2/+33
|\
| * Mention specific version in rc2 notes v1.64.0Olivier Wilkinson (reivilibre)2022-08-021-1/+1
| |
| * Add upgrade notesOlivier Wilkinson (reivilibre)2022-08-021-0/+10
| |
| * 1.64.0Olivier Wilkinson (reivilibre)2022-08-023-1/+22
| |
* | Faster Room Joins: don't leave a stuck room partial state flag if the join ↵reivilibre2022-08-013-15/+140
| | | | | | | | fails. (#13403)
* | Fix missing import in `federation_event` handler. (#13431)Patrick Cloke2022-08-012-0/+2
| | | | | | | | #13404 removed an import of `Optional` which was still needed due to #13413 added more usages.
* | Refactor `_resolve_state_at_missing_prevs` to return an `EventContext` (#13404)Sean Quah2022-08-015-86/+68
| | | | | | | | | | | | | | | | Previously, `_resolve_state_at_missing_prevs` returned the resolved state before an event and a partial state flag. These were unwieldy to carry around would only ever be used to build an event context. Build the event context directly instead. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Enable Complement CI tests in the 'latest deps' test run. (#13213)reivilibre2022-08-014-5/+58
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Re-enable running Complement tests against Synapse with workers. (#13420)reivilibre2022-08-012-24/+4
| |
* | Faster joins: fix rejected events becoming un-rejected during resync (#13413)Richard van der Hoff2022-08-013-6/+32
| | | | | | | | | | Make sure that we re-check the auth rules during state resync, otherwise rejected events get un-rejected.
* | Merge tag 'v1.64.0rc2' into developRichard van der Hoff2022-07-2914-268/+438
|\| | | | | | | | | | | | | Synapse 1.64.0rc2 (2022-07-29) ============================== This RC reintroduces support for `account_threepid_delegates.email`, which was removed in 1.64.0rc1. It remains deprecated and will be removed altogether in a future release. ([\#13406](https://github.com/matrix-org/synapse/issues/13406))
| * update changelog v1.64.0rc2Richard van der Hoff2022-07-291-5/+2
| |
| * 1.64.0rc2Richard van der Hoff2022-07-294-2/+16
| |
| * Revert "Drop support for delegating email validation (#13192)" (#13406)3nprob2022-07-2912-266/+425
| | | | | | | | | | Reverts commit fa71bb18b527d1a3e2629b48640ea67fff2f8c59, and tweaks documentation. Signed-off-by: 3nprob <git@3n.anonaddy.com>
* | Explicitly mention which resources support compression in the config guide ↵Brendan Abolivier2022-07-292-1/+3
| | | | | | | | (#13221)
* | Use stable prefixes for MSC3827: filtering of `/publicRooms` by room type ↵Šimon Brandner2022-07-277-11/+8
| | | | | | | | | | | | (#13370) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Add missing type hints for tests.unittest. (#13397)Patrick Cloke2022-07-276-52/+66
| |
* | Implement MSC3848: Introduce errcodes for specific event sending failures ↵Will Hunt2022-07-2711-36/+144
| | | | | | | | | | (#13343) Implements MSC3848
* | Make minor clarifications to the error messages given when we fail to join a ↵reivilibre2022-07-274-3/+17
| | | | | | | | room via any server. (#13160)
* | Fix `get_pdu` asking every remote destination even after it finds an event ↵Eric Eastwood2022-07-272-3/+4
| | | | | | | | (#13346)
* | Copy room serials before handling in `get_new_events_as` (#13392)Nick Mills-Barrett2022-07-262-3/+11
| |
* | Extend the release script to automatically push a new SyTest branch, rather ↵reivilibre2022-07-262-32/+55
| | | | | | | | | | than having that be a manual process. (#12978) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Merge branch 'release-v1.64' into developOlivier Wilkinson (reivilibre)2022-07-2673-73/+95
|\|
| * Explain less-known term 'Implicit TLS' v1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-261-1/+1
| |
| * Tweak changelog in response to reviewOlivier Wilkinson (reivilibre)2022-07-261-9/+7
| |
| * Tweak changelogOlivier Wilkinson (reivilibre)2022-07-261-9/+11
| |
| * 1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-2673-73/+95
| |
* | Remove the unspecced `room_id` field in the `/hierarchy` response. (#13365)Patrick Cloke2022-07-262-1/+1
| | | | | | | | | | | | | | | | | | The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
* | Fix infinite loop in partial-state resync (#13353)Richard van der Hoff2022-07-263-8/+27
| | | | | | | | | | Make sure that we only pull out events from the db once they have no prev-events with partial state.
* | Faster room joins: avoid blocking when pulling events with missing prevs ↵Sean Quah2022-07-268-33/+124
| | | | | | | | | | | | | | | | | | (#13355) Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Remove unused argument for get_relations_for_event. (#13383)Patrick Cloke2022-07-263-9/+1
|/
* Disable autocorrect and autocaptialisation when entering username for SSO ↵Doug2022-07-262-1/+2
| | | | | registration. (#13350) When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).
* Update Caddy reverse proxy documentation (#13344)Matt Holt2022-07-252-42/+12
| | | | | Improve/simplify Caddy examples. Remove Caddy v1 (has long been EOL'ed) Signed-off-by: Matthew Holt <mholt@users.noreply.github.com>
* Support Implicit TLS for sending emails (#13317)Jan Schär2022-07-255-13/+99
| | | | | | | | | | Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>
* Additional fixes for opentracing type hints. (#13362)Patrick Cloke2022-07-252-2/+3
|
* Refactor presence so we can prune user in room caches (#13313)Erik Johnston2022-07-254-91/+109
| | | | | | | | See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.
* Backfill remote event fetched by MSC3030 so we can paginate from it later ↵Eric Eastwood2022-07-223-15/+94
| | | | | | | | | (#13205) Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848
* Update config_documentation.md (#13364)Richard van der Hoff2022-07-221-2/+2
| | | "changed in" goes before the example
* Update locked frozendict version to 2.3.3 (#13352)Sean Quah2022-07-223-18/+28
| | | frozendict 2.3.3 includes fixes for memory leaks that get triggered during `/sync`.
* Skip soft fail checks for rooms with partial state (#13354)Sean Quah2022-07-222-0/+11
| | | | | | | | | | | | When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>
* Remove old empty/redundant slaved stores. (#13349)Nick Mills-Barrett2022-07-2112-238/+63
|
* Make DictionaryCache have better expiry properties (#13292)Erik Johnston2022-07-217-43/+358
|
* Don't hold onto full state in state cache (#13324)Erik Johnston2022-07-212-15/+54
|
* Call out buildkit is required when building test docker images (#13338)Brendan Abolivier2022-07-214-0/+7
| | | Co-authored-by: David Robertson <davidr@element.io>
* Track DB txn times w/ two counters, not histogram (#13342)David Robertson2022-07-212-3/+6
|
* Add missing types to opentracing. (#13345)Patrick Cloke2022-07-2114-45/+83
| | | After this change `synapse.logging` is fully typed.
* Use cache store remove base slaved (#13329)Nick Mills-Barrett2022-07-2116-114/+39
| | | This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
* Merge branch 'master' into developDavid Robertson2022-07-212-0/+9
|\
| * Document `rc_invites.per_issuer`, added in v1.63.David Teller2022-07-212-0/+9
| | | | | | | | | | | | | | Resolves #13330. Missed in #13125. Signed-off-by: David Teller <davidt@element.io>
* | Update `get_pdu` to return the original, pristine `EventBase` (#13320)Eric Eastwood2022-07-205-61/+233
| | | | | | | | | | | | | | | | | | | | | | | | Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
* | Validate federation destinations and log an error if server name is invalid. ↵Shay2022-07-203-2/+12
| | | | | | | | (#13318)
* | Merge remote-tracking branch 'origin/master' into developErik Johnston2022-07-205-2/+110
|\|
| * 1.63.1 v1.63.1Erik Johnston2022-07-204-2/+16
| |
| * Don't include appservice users when calculating push rules (#13332)Erik Johnston2022-07-203-0/+93
| | | | | | This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
* | Fix spurious warning when fetching state after a missing prev event (#13258)Sean Quah2022-07-192-0/+4
| |
* | Add type annotations to `trace` decorator. (#13328)Patrick Cloke2022-07-1912-55/+102
| | | | | | | | Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
* | Merge branch 'master' into developBrendan Abolivier2022-07-1911-32/+55
|\|
| * Improve precision on validation improvements v1.63.0Brendan Abolivier2022-07-191-1/+1
| |
| * 1.63.0Brendan Abolivier2022-07-194-4/+13
| |
| * Remove 'anonymised' from the phone home stats documentation (#13321)Andrew Morgan2022-07-1911-30/+44
| |
* | Reduce memory usage of state group cache (#13323)Erik Johnston2022-07-192-1/+3
| |
* | Stop building Ubuntu 21.10 (Impish Indri) which is end of life. (#13326)Patrick Cloke2022-07-192-1/+1
| |
* | Bash script for creating multiple stream writers (#13271)villepeh2022-07-193-1/+147
| | | | | | | | | | Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.
* | Add notes when config options were changed to config documentation (#13314)Jörg Behrmann2022-07-192-0/+6
| | | | | | | | Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
* | Rate limit joins per-room (#13276)David Robertson2022-07-1918-15/+498
| |
* | Safe async event cache (#13308)Nick Mills-Barrett2022-07-198-21/+102
| | | | | | | | | | | | | | | | Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
* | Increase batch size of `bulk_get_push_rules` and ↵Shay2022-07-183-1/+3
| | | | | | | | `_get_joined_profiles_from_event_ids`. (#13300)
* | Improve performance of query ` _get_subset_users_in_room_with_profiles` (#13299)Shay2022-07-182-1/+2
| |
* | Fix overcounting of pushers when they are replaced (#13296)Sean Quah2022-07-182-11/+17
| | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | Up the dependency on canonicaljson to ^1.5.0 (#13172)Brendan Abolivier2022-07-183-2/+5
| | | | | | Co-authored-by: David Robertson <davidr@element.io>
* | Prevent #3679 from appearing in blame results (#13311)Andrew Morgan2022-07-182-0/+14
| |
* | Revert "Make all `process_replication_rows` methods async (#13304)" (#13312)Erik Johnston2022-07-1814-40/+25
| | | | | | This reverts commit 5d4028f217f178fcd384d5bfddd92225b4e78c51.
* | Don't pull out full state when sending dummy events (#13310)Erik Johnston2022-07-182-7/+2
| |
* | Use READ COMMITTED isolation level when purging rooms (#12942)Nick Mills-Barrett2022-07-182-2/+32
| | | | | | | | | | To close: #10294. Signed off by Nick @ Beeper.
* | Update expected DB query count when creating a room (#13307)Andrew Morgan2022-07-182-2/+3
| |
* | Don't pull out the full state when creating an event (#13281)Erik Johnston2022-07-183-2/+10
| |
* | Remove unnecessary `json.dumps` from tests (#13303)Dirk Klimpel2022-07-1713-200/+143
| |
* | Make all `process_replication_rows` methods async (#13304)Nick Mills-Barrett2022-07-1714-25/+40
| | | | | | | | | | More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
* | Use HTTPStatus constants in place of literals in tests. (#13297)Dirk Klimpel2022-07-159-238/+308
| |
* | Provide more info why we don't have any thumbnails to serve (#13038)Eric Eastwood2022-07-154-17/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
* | Use and recommend poetry 1.1.14, up from 1.1.12 (#13285)David Robertson2022-07-155-4/+30
| |
* | Don't pull out the full state when storing state (#13274)Erik Johnston2022-07-156-71/+132
| |
* | Use a real room in the notification rotation tests. (#13260)Patrick Cloke2022-07-152-116/+80
| | | | | | | | Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
* | Use state before join to determine if we `_should_perform_remote_join` (#13270)David Robertson2022-07-154-24/+35
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Update locked frozendict version to 2.3.2 (#13284)Sean Quah2022-07-152-18/+19
| | | | | | | | | | | | | | | | `frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Bg update to populate new `events` table columns (#13215)Richard van der Hoff2022-07-153-0/+135
| | | | | | | | | | These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
* | Fix a bug which could lead to incorrect state (#13278)Erik Johnston2022-07-154-7/+58
| | | | | | | | | | There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
* | Docker: copy postgres from base image (#13279)Richard van der Hoff2022-07-153-34/+51
| | | | | | | | | | | | When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.
* | Async get event cache prep (#13242)Nick Mills-Barrett2022-07-1511-26/+86
| | | | | | | | | | Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
* | Federation Sender & Appservice Pusher Stream Optimisations (#13251)Nick Mills-Barrett2022-07-157-87/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | * Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
* | Rip out auth-event reconciliation code (#12943)Richard van der Hoff2022-07-146-375/+88
| | | | | | | | | | | | | | There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
* | CHANGES.md: fix link to upgrade notesRichard van der Hoff2022-07-141-1/+1
| |
* | Don't pull out state in `compute_event_context` for unconflicted state (#13267)Erik Johnston2022-07-147-136/+95
| |
* | Allow rate limiters to passively record actions they cannot limit (#13253)David Robertson2022-07-133-12/+157
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Notifier: accept callbacks to fire on room joins (#13254)David Robertson2022-07-132-0/+19
| |
* | Call the v2 identity service `/3pid/unbind` endpoint, rather than v1. (#13240)Jacek Kuśnierz2022-07-132-2/+3
| | | | | | | | | | | | | | | | | | | | | | * Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
* | Add support for room version 10 (#13220)Shay2022-07-134-1/+100
| |
* | Document advising against publicly exposing the Admin API and provide a ↵jejo862022-07-132-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | usage example (#13231) * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett2022-07-134-19/+78
| |
* | Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke2022-07-133-44/+33
| |
* | Add prometheus counters for content types other than events (#13175)Brad Murray2022-07-132-0/+15
| |
* | Drop unused tables from groups/communities. (#12967)Patrick Cloke2022-07-134-19/+36
| | | | | | | | These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
* | Do not fail build if complement with workers fails. (#13266)Patrick Cloke2022-07-132-3/+25
| |
* | Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston2022-07-133-0/+37
| | | | | | | | | | | | (#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Inline URL preview documentation. (#13261)Patrick Cloke2022-07-127-74/+62
| | | | | | Inline URL preview documentation near the implementation.
* | Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2022-07-122-0/+18
| | | | | | This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
* | Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz2022-07-123-26/+11
| | | | | | | | | | | | | | `id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* | Rename test case method to `add_hashes_and_signatures_from_other_server` ↵David Robertson2022-07-127-18/+14
| | | | | | | | (#13255)
* | Drop support for delegating email validation (#13192)Richard van der Hoff2022-07-1213-253/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
* | Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2022-07-122-0/+2
| | | | | | | | The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
* | Add info about configuration in the url preview docs (#13233)Shay2022-07-122-0/+3
| | | | | | Cross-link doc pages for easier navigation.
* | Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2022-07-122-2/+9
| | | | | | | | | | | | | | | | token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
* | expose whether a room is a space in the Admin API (#13208)andrew do2022-07-124-13/+36
|/
* Update changelog once more v1.63.0rc1Sean Quah2022-07-121-2/+2
|
* Reorder and tidy up changelogSean Quah2022-07-121-29/+25
|
* 1.63.0rc1Sean Quah2022-07-1254-54/+87
|
* Don't pull out the full state when calculating push actions (#13078)Erik Johnston2022-07-117-344/+164
|
* Add a sample bash script to docs for creating multiple worker files (#13032)villepeh2022-07-112-0/+32
| | | Signed-off-by: Ville Petteri Huh.
* Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett2022-07-113-2/+32
| | | | | | | | Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
* Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller2022-07-1112-60/+426
| | | | | | return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2022-07-112-2/+4
| | | | The field name was simply incorrect, leading to errors.
* Remove delay when rotating event push actions (#13211)Erik Johnston2022-07-112-3/+2
| | | | We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
* Document the 'databases' homeserver config option (#13212)Andrew Morgan2022-07-112-0/+93
|
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-113-138/+400
|
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2022-07-112-1/+4
| | | | | | | | | | | * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
* Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2022-07-112-1/+5
|
* editorconfig: add max_line_length for Python files (#13228)Sumner Evans2022-07-082-0/+2
| | | | | | See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>
* Fix notification count after a highlighted message (#13223)Erik Johnston2022-07-083-3/+16
| | | | | Fixes #13196 Broke by #13005
* Fix exception when using MSC3030 to look for remote federated events before ↵Eric Eastwood2022-07-072-1/+6
| | | | | | | | | | | | | | | | room creation (#13197) Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
* Add --build-only option to complement.sh to prevent actually running ↵reivilibre2022-07-072-3/+19
| | | | Complement. (#13158)
* Remove obsolete RoomEventsStoreTestCase (#13200)Petr Vaněk2022-07-072-69/+1
| | | | | | | | | | All tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b3c508 - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
* Faster room joins: fix race in recalculation of current room state (#13151)Sean Quah2022-07-078-55/+214
| | | | | | | | | | | Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>
* Use a single query in `ProfileHandler.get_profile` (#13209)Nick Mills-Barrett2022-07-072-12/+8
|
* Bump lxml from 4.8.0 to 4.9.1 (#13207)dependabot[bot]2022-07-072-62/+72
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Check that `auto_vacuum` is disabled when porting a SQLite database to ↵reivilibre2022-07-073-0/+43
| | | | Postgres, as `VACUUM`s must not be performed between runs of the script. (#13195)
* Make `_get_state_map_for_room` not break when room state events don't ↵David Teller2022-07-072-8/+2
| | | | | contain an event id. (#13174) Method `_get_state_map_for_room` seems to break in presence of some ill-formed events in the database. Reimplementing this method to use `get_current_state`, which is more robust to such events.
* Add information on how the Synapse team does reviews. (#13132)Patrick Cloke2022-07-064-1/+47
|
* Fix bug where we failed to delete old push actions (#13194)Erik Johnston2022-07-062-2/+5
| | | This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.
* Handle race between persisting an event and un-partial stating a room (#13100)Sean Quah2022-07-0510-74/+234
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever we want to persist an event, we first compute an event context, which includes the state at the event and a flag indicating whether the state is partial. After a lot of processing, we finally try to store the event in the database, which can fail for partial state events when the containing room has been un-partial stated in the meantime. We detect the race as a foreign key constraint failure in the data store layer and turn it into a special `PartialStateConflictError` exception, which makes its way up to the method in which we computed the event context. To make things difficult, the exception needs to cross a replication request: `/fed_send_events` for events coming over federation and `/send_event` for events from clients. We transport the `PartialStateConflictError` as a `409 Conflict` over replication and turn `409`s back into `PartialStateConflictError`s on the worker making the request. All client events go through `EventCreationHandler.handle_new_client_event`, which is called in *a lot* of places. Instead of trying to update all the code which creates client events, we turn the `PartialStateConflictError` into a `429 Too Many Requests` in `EventCreationHandler.handle_new_client_event` and hope that clients take it as a hint to retry their request. On the federation event side, there are 7 places which compute event contexts. 4 of them use outlier event contexts: `FederationEventHandler._auth_and_persist_outliers_inner`, `FederationHandler.do_knock`, `FederationHandler.on_invite_request` and `FederationHandler.do_remotely_reject_invite`. These events won't have the partial state flag, so we do not need to do anything for then. The remaining 3 paths which create events are `FederationEventHandler.process_remote_join`, `FederationEventHandler.on_send_membership_event` and `FederationEventHandler._process_received_pdu`. We can't experience the race in `process_remote_join`, unless we're handling an additional join into a partial state room, which currently blocks, so we make no attempt to handle it correctly. `on_send_membership_event` is only called by `FederationServer._on_send_membership_event`, so we catch the `PartialStateConflictError` there and retry just once. `_process_received_pdu` is called by `on_receive_pdu` for incoming events and `_process_pulled_event` for backfill. The latter should never try to persist partial state events, so we ignore it. We catch the `PartialStateConflictError` in `on_receive_pdu` and retry just once. Refering to the graph of code paths in https://github.com/matrix-org/synapse/issues/12988#issuecomment-1156857648 may make the above make more sense. Signed-off-by: Sean Quah <seanq@matrix.org>
* Type `tests.utils` (#13028)David Robertson2022-07-055-46/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cast to postgres types when handling postgres db * Remove unused method * Easy annotations * Annotate create_room * Use `ParamSpec` to annotate looping_call * Annotate `default_config` * Track `now` as a float `time_ms` returns an int like the proper Synapse `Clock` * Introduce a `Timer` dataclass * Introduce a Looper type * Suppress checking of a mock * tests.utils is typed * Changelog * Whoops, import ParamSpec from typing_extensions * ditch the psycopg2 casts
* Factor out some common Complement CI setup commands to a script. (#13157)reivilibre2022-07-054-47/+42
|
* Use upserts for updating `event_push_summary` (#13153)Erik Johnston2022-07-052-40/+8
|
* Merge branch 'master' into developDavid Robertson2022-07-053-1/+15
|\
| * Mention the spamchecker plugins v1.62.0David Robertson2022-07-051-0/+2
| |
| * 1.62.0David Robertson2022-07-053-1/+13
| |
* | Fix application service not being able to join remote federated room without ↵Eric Eastwood2022-07-052-9/+24
| | | | | | | | | | | | | | a profile set (#13131) Fix https://github.com/matrix-org/synapse/issues/4778 Complement tests: https://github.com/matrix-org/complement/pull/399
* | Add the ability to set the log level using the `SYNAPSE_TEST_LOG_LEVEL` ↵reivilibre2022-07-056-6/+44
| | | | | | | | environment when using `complement.sh`. (#13152)
* | Add missing links to config options (#13166)Dirk Klimpel2022-07-052-3/+4
| |
* | annotate tests.server.FakeChannel (#13136)David Robertson2022-07-047-26/+36
| |
* | Revert "Up the dependency on canonicaljson to ^1.5.0"Brendan Abolivier2022-07-041-3/+1
| | | | | | | | This reverts commit dcc4e0621cc101271efc573600bd7591a12cea7c.
* | Up the dependency on canonicaljson to ^1.5.0Brendan Abolivier2022-07-041-1/+3
| |
* | Merge tag 'v1.62.0rc3' into developAndrew Morgan2022-07-046-12/+33
|\| | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc3 (2022-07-04) ============================== Bugfixes -------- - Update the version of the [ldap3 plugin](https://github.com/matrix-org/matrix-synapse-ldap3/) included in the `matrixdotorg/synapse` DockerHub images and the Debian packages hosted on `packages.matrix.org` to 0.2.1. This fixes [a bug](https://github.com/matrix-org/matrix-synapse-ldap3/pull/163) with usernames containing uppercase characters. ([\#13156](https://github.com/matrix-org/synapse/issues/13156)) - Fix a bug introduced in Synapse 1.62.0rc1 affecting unread counts for users on small servers. ([\#13168](https://github.com/matrix-org/synapse/issues/13168))
| * Update changelog for v1.62.0rc2 v1.62.0rc3Andrew Morgan2022-07-041-2/+2
| |
| * 1.62.0rc3Andrew Morgan2022-07-045-3/+17
| |
| * Fix stuck notification counts on small servers (#13168)Erik Johnston2022-07-043-7/+13
| |
| * matrix-synapse-ldap3: 0.2.0 -> 0.2.1 (#13156)David Robertson2022-07-012-4/+5
| |
* | Remove tests/utils.py from mypy's exclude list (#13159)Andrew Morgan2022-07-044-4/+3
| |
* | [Complement] Allow device_name lookup over federation (#13167)Till2022-07-042-0/+3
| |
* | Enable Complement testing in the 'Twisted Trunk' CI runs. (#13079)reivilibre2022-07-014-2/+82
| |
* | complement.sh: Permit skipping docker build (#13143)Richard van der Hoff2022-07-012-18/+55
| | | | | | Add a `-f` argument to `complement.sh` to skip the docker build
* | Merge tag 'v1.62.0rc2' into developAndrew Morgan2022-07-015-3/+17
|\| | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc2 (2022-07-01) ============================== Bugfixes -------- - Fix unread counts for users on large servers. Introduced in v1.62.0rc1. ([\#13140](https://github.com/matrix-org/synapse/issues/13140)) - Fix DB performance when deleting old push notifications. Introduced in v1.62.0rc1. ([\#13141](https://github.com/matrix-org/synapse/issues/13141))
| * 1.62.0rc2 v1.62.0rc2Andrew Morgan2022-07-015-3/+17
| |
* | Extra validation for rest/client/account_data (#13148)David Robertson2022-07-012-2/+18
| | | | | | | | | | | | | | * Extra validation for rest/client/account_data This is a fairly simple endpoint and we did pretty well here. * Changelog
* | `_process_received_pdu`: Improve exception handling (#13145)Richard van der Hoff2022-07-012-7/+7
| | | | | | | | `_check_event_auth` is expected to raise `AuthError`s, so no need to log it again.
* | Skip waiting for full state for incoming events (#13144)Richard van der Hoff2022-07-013-4/+13
| | | | | | | | | | When we receive an event over federation during a faster join, there is no need to wait for full state, since we have a whole reconciliation process designed to take the partial state into account.
* | Add documentation for phone home stats (#13086)Andrew Morgan2022-06-303-0/+83
| |
* | Allow dependency errors to pass through (#13113)Jacek Kuśnierz2022-06-308-58/+16
| | | | | | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge remote-tracking branch 'origin/release-v1.62' into developPatrick Cloke2022-06-306-33/+64
|\|
| * Fix unread counts on large servers (#13140)Erik Johnston2022-06-303-29/+32
| |
| * Add index to help delete old push actions (#13141)Erik Johnston2022-06-304-4/+32
| |
* | Don't process /send requests for users who have hit their ratelimit (#13134)Shay2022-06-302-0/+4
| |
* | Cleanup references to sample config in the docs and redirect users to ↵Shay2022-06-3012-89/+73
| | | | | | | | configuration manual (#13077)
* | Add a link to the configuration manual from the homeserver sample config ↵Andrew Morgan2022-06-302-0/+4
| | | | | | | | documentation page (#13139)
* | More type hints for `synapse.logging` (#13103)Patrick Cloke2022-06-305-46/+56
| | | | | | | | Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.
* | Improve startup times in Complement test runs against workers, particularly ↵reivilibre2022-06-309-51/+243
| | | | | | | | | | in CPU-constrained environments. (#13127) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Actually typecheck `tests.test_server` (#13135)David Robertson2022-06-302-1/+1
| |
* | Rate limiting invites per issuer (#13125)David Teller2022-06-303-2/+24
| | | | | | Co-authored-by: reivilibre <oliverw@matrix.org>
* | Don't actually one-line the SQL statements we send to the DB (#13129)Brendan Abolivier2022-06-302-3/+5
| |
* | Implement MSC3827: Filtering of `/publicRooms` by room type (#13031)Šimon Brandner2022-06-2911-13/+345
| | | | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Fix documentation header for `allow_public_rooms_over_federation` (#13116)Moritz Stückler2022-06-292-1/+2
| | | | | | | | Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Improve performance of getting unread counts in rooms (#13119)Erik Johnston2022-06-296-4/+40
| |
* | Document the `--report-stats` argument (#13029)jejo862022-06-292-1/+4
|/ | | Signed-off-by: jejo86 <28619134+jejo86@users.noreply.github.com>
* Merge branch 'develop' into release-v1.62 v1.62.0rc1Andrew Morgan2022-06-281-1/+2
|\
| * fix linting error from the 1.61.1 main -> develop mergeAndrew Morgan2022-06-281-1/+2
| |
* | 1.62.0rc1Andrew Morgan2022-06-2880-80/+102
|/