summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Increase perf of handling presence when joining large rooms. (#9916)Erik Johnston2021-05-053-82/+87
|
* Support stable MSC1772 spaces identifiers. (#9915)Patrick Cloke2021-05-053-2/+10
| | | | Support both the unstable and stable identifiers. A future release will disable the unstable identifiers.
* Optionally track memory usage of each LruCache (#9881)Erik Johnston2021-05-058-1/+97
| | | | | This will double count slightly in the presence of interned strings. It's off by default as it can consume a lot of resources.
* Limit how often GC happens by time. (#9902)Erik Johnston2021-05-056-3/+63
| | | | | | | | | | | | | | | Synapse can be quite memory intensive, and unless care is taken to tune the GC thresholds it can end up thrashing, causing noticable performance problems for large servers. We fix this by limiting how often we GC a given generation, regardless of current counts/thresholds. This does not help with the reverse problem where the thresholds are set too high, but that should only happen in situations where they've been manually configured. Adds a `gc_min_seconds_between` config option to override the defaults. Fixes #9890.
* Don't set the external cache if its been done recently (#9905)Erik Johnston2021-05-053-5/+34
|
* Use get_current_users_in_room from store and not StateHandler (#9910)Erik Johnston2021-05-0512-17/+26
|
* Docker healthcheck timings - add startup delay and changed interval (#9913)Christopher May-Townsend2021-05-053-4/+16
| | | | | * Add healthcheck startup delay by 5secs and reduced interval check to 15s to reduce waiting time for docker aware edge routers bringing an instance online
* Leave out optional keys from /sync (#9919)DeepBlueV7.X2021-05-054-50/+51
| | | | | | This leaves out all optional keys from /sync. This should be fine for all clients tested against conduit already, but it may break some clients, as such we should check, that at least most of them don't break horribly and maybe back out some of the individual changes. (We can probably always leave out groups for example, while the others may cause more issues.) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* Merge branch 'master' into developBrendan Abolivier2021-05-054-4/+20
|\
| * 1.33.0 v1.33.0 github/release-v1.33.0 release-v1.33.0Brendan Abolivier2021-05-054-2/+16
| |
| * Build Debian packages for Ubuntu 21.04 Hirsute (#9909)Dan Callahan2021-04-302-3/+5
| | | | | | Signed-off-by: Dan Callahan <danc@element.io>
* | Time external cache response time (#9904)Erik Johnston2021-05-042-10/+27
| |
* | Add port parameter to the sample config for psycopg2 args (#9911)Andrew Morgan2021-05-043-0/+3
| | | | | | Adds the `port` option with the default value to the sample config file.
* | Merge tag 'v1.33.0rc2' into developAndrew Morgan2021-04-293-2/+10
|\| | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc2 (2021-04-29) ============================== Bugfixes -------- - Fix tight loop when handling presence replication when using workers. Introduced in v1.33.0rc1. ([\#9900](https://github.com/matrix-org/synapse/issues/9900))
| * typo in changelog v1.33.0rc2Andrew Morgan2021-04-291-1/+1
| |
| * 1.33.0rc2Andrew Morgan2021-04-293-2/+10
| |
* | Add missing type hints to handlers and fix a Spam Checker type hint. (#9896)Patrick Cloke2021-04-298-54/+82
| | | | | | | | | | The user_may_create_room_alias method on spam checkers declared the room_alias parameter as a str when in reality it is passed a RoomAlias object.
* | Delete room endpoint (#9889)ThibF2021-04-295-64/+128
| | | | | | | | | | | | Support the delete of a room through DELETE request and mark previous request as deprecated through documentation. Signed-off-by: Thibault Ferrante <thibault.ferrante@pm.me>
* | Merge remote-tracking branch 'origin/release-v1.33.0' into developErik Johnston2021-04-283-1/+46
|\|
| * Fix tight loop handling presence replication. (#9900)Erik Johnston2021-04-283-1/+46
| | | | | | | | | | Only affects workers. Introduced in #9819. Fixes #9899.
* | Use the parent's logging context name for runWithConnection. (#9895)Patrick Cloke2021-04-282-1/+4
| | | | | | | | | | This fixes a regression where the logging context for runWithConnection was reported as runWithConnection instead of the connection name, e.g. "POST-XYZ".
* | Merge tag 'v1.33.0rc1' into developAndrew Morgan2021-04-2841-173/+147
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc1 (2021-04-28) ============================== Features -------- - Update experimental support for [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083): restricting room access via group membership. ([\#9800](https://github.com/matrix-org/synapse/issues/9800), [\#9814](https://github.com/matrix-org/synapse/issues/9814)) - Add experimental support for handling presence on a worker. ([\#9819](https://github.com/matrix-org/synapse/issues/9819), [\#9820](https://github.com/matrix-org/synapse/issues/9820), [\#9828](https://github.com/matrix-org/synapse/issues/9828), [\#9850](https://github.com/matrix-org/synapse/issues/9850)) - Return a new template when an user attempts to renew their account multiple times with the same token, stating that their account is set to expire. This replaces the invalid token template that would previously be shown in this case. This change concerns the optional account validity feature. ([\#9832](https://github.com/matrix-org/synapse/issues/9832)) Bugfixes -------- - Fixes the OIDC SSO flow when using a `public_baseurl` value including a non-root URL path. ([\#9726](https://github.com/matrix-org/synapse/issues/9726)) - Fix thumbnail generation for some sites with non-standard content types. Contributed by @rkfg. ([\#9788](https://github.com/matrix-org/synapse/issues/9788)) - Add some sanity checks to identity server passed to 3PID bind/unbind endpoints. ([\#9802](https://github.com/matrix-org/synapse/issues/9802)) - Limit the size of HTTP responses read over federation. ([\#9833](https://github.com/matrix-org/synapse/issues/9833)) - Fix a bug which could cause Synapse to get stuck in a loop of resyncing device lists. ([\#9867](https://github.com/matrix-org/synapse/issues/9867)) - Fix a long-standing bug where errors from federation did not propagate to the client. ([\#9868](https://github.com/matrix-org/synapse/issues/9868)) Improved Documentation ---------------------- - Add a note to the docker docs mentioning that we mirror upstream's supported Docker platforms. ([\#9801](https://github.com/matrix-org/synapse/issues/9801)) Internal Changes ---------------- - Add a dockerfile for running Synapse in worker-mode under Complement. ([\#9162](https://github.com/matrix-org/synapse/issues/9162)) - Apply `pyupgrade` across the codebase. ([\#9786](https://github.com/matrix-org/synapse/issues/9786)) - Move some replication processing out of `generic_worker`. ([\#9796](https://github.com/matrix-org/synapse/issues/9796)) - Replace `HomeServer.get_config()` with inline references. ([\#9815](https://github.com/matrix-org/synapse/issues/9815)) - Rename some handlers and config modules to not duplicate the top-level module. ([\#9816](https://github.com/matrix-org/synapse/issues/9816)) - Fix a long-standing bug which caused `max_upload_size` to not be correctly enforced. ([\#9817](https://github.com/matrix-org/synapse/issues/9817)) - Reduce CPU usage of the user directory by reusing existing calculated room membership. ([\#9821](https://github.com/matrix-org/synapse/issues/9821)) - Small speed up for joining large remote rooms. ([\#9825](https://github.com/matrix-org/synapse/issues/9825)) - Introduce flake8-bugbear to the test suite and fix some of its lint violations. ([\#9838](https://github.com/matrix-org/synapse/issues/9838)) - Only store the raw data in the in-memory caches, rather than objects that include references to e.g. the data stores. ([\#9845](https://github.com/matrix-org/synapse/issues/9845)) - Limit length of accepted email addresses. ([\#9855](https://github.com/matrix-org/synapse/issues/9855)) - Remove redundant `synapse.types.Collection` type definition. ([\#9856](https://github.com/matrix-org/synapse/issues/9856)) - Handle recently added rate limits correctly when using `--no-rate-limit` with the demo scripts. ([\#9858](https://github.com/matrix-org/synapse/issues/9858)) - Disable invite rate-limiting by default when running the unit tests. ([\#9871](https://github.com/matrix-org/synapse/issues/9871)) - Pass a reactor into `SynapseSite` to make testing easier. ([\#9874](https://github.com/matrix-org/synapse/issues/9874)) - Make `DomainSpecificString` an `attrs` class. ([\#9875](https://github.com/matrix-org/synapse/issues/9875)) - Add type hints to `synapse.api.auth` and `synapse.api.auth_blocking` modules. ([\#9876](https://github.com/matrix-org/synapse/issues/9876)) - Remove redundant `_PushHTTPChannel` test class. ([\#9878](https://github.com/matrix-org/synapse/issues/9878)) - Remove backwards-compatibility code for Python versions < 3.6. ([\#9879](https://github.com/matrix-org/synapse/issues/9879)) - Small performance improvement around handling new local presence updates. ([\#9887](https://github.com/matrix-org/synapse/issues/9887))
| * Reword account validity template change to sound less like a bugfix v1.33.0rc1Andrew Morgan2021-04-281-1/+1
| |
| * 1.33.0rc1Andrew Morgan2021-04-2836-35/+54
| |
| * Revert "Experimental Federation Speedup (#9702)"Andrew Morgan2021-04-285-138/+93
| | | | | | | | This reverts commit 05e8c70c059f8ebb066e029bc3aa3e0cefef1019.
* | Reduce memory footprint of caches (#9886)Erik Johnston2021-04-282-18/+60
| |
* | Add type hints to presence handler (#9885)Erik Johnston2021-04-282-70/+90
|/
* Remove various bits of compatibility code for Python <3.6 (#9879)Andrew Morgan2021-04-2716-98/+29
| | | I went through and removed a bunch of cruft that was lying around for compatibility with old Python versions. This PR also will now prevent Synapse from starting unless you're running Python 3.6+.
* Pass errors back to the client when trying multiple federation destinations. ↵Patrick Cloke2021-04-272-58/+61
| | | | | | | | (#9868) This ensures that something like an auth error (403) will be returned to the requester instead of attempting to try more servers, which will likely result in the same error, and then passing back a generic 400 error.
* Use current state table for `presence.get_interested_remotes` (#9887)Erik Johnston2021-04-272-7/+3
| | | This should be a lot quicker than asking the state handler.
* Improved validation for received requests (#9817)Richard van der Hoff2021-04-2315-31/+174
| | | | | | * Simplify `start_listening` callpath * Correctly check the size of uploaded files
* Kill off `_PushHTTPChannel`. (#9878)Richard van der Hoff2021-04-233-121/+20
| | | | | First of all, a fixup to `FakeChannel` which is needed to make it work with the default HTTP channel implementation. Secondly, it looks like we no longer need `_PushHTTPChannel`, because as of #8013, the producer that gets attached to the `HTTPChannel` is now an `IPushProducer`. This is good, because it means we can remove a whole load of test-specific boilerplate which causes variation between tests and production.
* Allow OIDC cookies to work on non-root public baseurls (#9726)Andrew Morgan2021-04-233-9/+22
| | | | | Applied a (slightly modified) patch from https://github.com/matrix-org/synapse/issues/9574. As far as I understand this would allow the cookie set during the OIDC flow to work on deployments using public baseurls that do not sit at the URL path root.
* pass a reactor into SynapseSite (#9874)Richard van der Hoff2021-04-237-24/+43
|
* Add type hints to auth and auth_blocking. (#9876)Patrick Cloke2021-04-234-44/+48
|
* Make DomainSpecificString an attrs class (#9875)Erik Johnston2021-04-234-8/+24
|
* Remove room and user invite ratelimits in default unit test config (#9871)Andrew Morgan2021-04-232-0/+5
|
* Split presence out of master (#9820)Erik Johnston2021-04-2317-245/+245
|
* Check for space membership during a remote join of a restricted room (#9814)Patrick Cloke2021-04-236-68/+131
| | | | | | When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
* Only store data in caches, not "smart" objects (#9845)Erik Johnston2021-04-233-141/+182
|
* Limit the size of HTTP responses read over federation. (#9833)Richard van der Hoff2021-04-234-8/+110
|
* Handle all new rate limits in demo scripts (#9858)manuroe2021-04-222-12/+43
|
* Limit length of accepted email addresses (#9855)Erik Johnston2021-04-226-7/+100
|
* Clear the resync bit after resyncing device lists (#9867)Richard van der Hoff2021-04-223-10/+17
| | | Fixes #9866.
* Remove `synapse.types.Collection` (#9856)Richard van der Hoff2021-04-2226-62/+77
| | | This is no longer required, since we have dropped support for Python 3.5.
* Merge branch 'master' into developAndrew Morgan2021-04-224-4/+30
|\
| * Merge tag 'v1.32.2'Andrew Morgan2021-04-224-4/+30
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.32.2 (2021-04-22) =========================== This release includes a fix for a regression introduced in 1.32.0. Bugfixes -------- - Fix a regression in Synapse 1.32.0 and 1.32.1 which caused `LoggingContext` errors in plugins. ([\#9857](https://github.com/matrix-org/synapse/issues/9857))
| | * A regression can't be introduced twice v1.32.2 github/release-v1.32.2 release-v1.32.2Andrew Morgan2021-04-221-2/+2
| | |
| | * Note regression was in 1.32.0 and 1.32.1Andrew Morgan2021-04-221-2/+2
| | |
| | * Update dates in changelogsAndrew Morgan2021-04-212-2/+2
| | |
| | * 1.32.2Andrew Morgan2021-04-214-2/+18
| | |
| | * Merge branch 'release-v1.32.1' of github.com:matrix-org/synapse into ↵Andrew Morgan2021-04-212-9/+16
| | |\ | | | | | | | | | | | | release-v1.32.2
| | * | Make LoggingContext's name optional (#9857)Richard van der Hoff2021-04-212-3/+13
| | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse-s3-storage-provider/issues/55
* | | | Merge branch 'master' of github.com:matrix-org/synapse into developAndrew Morgan2021-04-212-9/+16
|\| | |
| * | | Merge branch 'release-v1.32.1' of github.com:matrix-org/synapseAndrew Morgan2021-04-212-9/+16
| |\ \ \ | | | |/ | | |/|
| | * | Note LoggingContext signature change incompatibility in 1.32.0 (#9859) github/release-v1.32.1 release-v1.32.1Andrew Morgan2021-04-212-9/+16
| | |/ | | | | | | | | | | | | 1.32.0 also introduced an incompatibility with Synapse modules that make use of `synapse.logging.context.LoggingContext`, such as [synapse-s3-storage-provider](https://github.com/matrix-org/synapse-s3-storage-provider). This PR adds a note to the 1.32.0 changelog and upgrade notes about it.
* | | Merge branch 'master' into developAndrew Morgan2021-04-216-15/+49
|\| |
| * | Merge tag 'v1.32.1'Andrew Morgan2021-04-216-15/+49
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.32.1 (2021-04-21) =========================== This release fixes [a regression](https://github.com/matrix-org/synapse/issues/9853) in Synapse 1.32.0 that caused connected Prometheus instances to become unstable. If you ran Synapse 1.32.0 with Prometheus metrics, first upgrade to Synapse 1.32.1 and follow [these instructions](https://github.com/matrix-org/synapse/pull/9854#issuecomment-823472183) to clean up any excess writeahead logs. Bugfixes -------- - Fix a regression in Synapse 1.32.0 which caused Synapse to report large numbers of Prometheus time series, potentially overwhelming Prometheus instances. ([\#9854](https://github.com/matrix-org/synapse/issues/9854))
| | * Clarify 1.32.0/1 changelog and upgrade notes v1.32.1Andrew Morgan2021-04-212-8/+7
| | |
| | * Add regression notes to CHANGES.md; fix link in 1.32.0 changelogAndrew Morgan2021-04-211-2/+6
| | |
| | * Add link to fixing prometheus to 1.32.0 upgrade notes; 1.32.1 has a fixAndrew Morgan2021-04-212-2/+6
| | |
| | * Fix typo in link to regression in 1.32.0 upgrade notesAndrew Morgan2021-04-211-1/+1
| | |
| | * 1.32.1Andrew Morgan2021-04-214-2/+16
| | |
| | * Mention Prometheus metrics regression in v1.32.0Andrew Morgan2021-04-212-0/+15
| | |
| | * Stop BackgroundProcessLoggingContext making new prometheus timeseries (#9854)Richard van der Hoff2021-04-213-5/+18
| | | | | | | | | | | | This undoes part of b076bc276e881b262048307b6a226061d96c4a8d.
* | | Rename handler and config modules which end in handler/config. (#9816)Patrick Cloke2021-04-2017-35/+43
| | |
* | | Merge branch 'master' into developAndrew Morgan2021-04-202-0/+15
|\| |
| * | Mention Prometheus metrics regression in v1.32.0 github/release-v1.32.0 release-v1.32.0Andrew Morgan2021-04-202-0/+15
| |/
* | Merge branch 'master' into developAndrew Morgan2021-04-201-0/+9
|\|
| * Further tweaking on gpg signing key noticeAndrew Morgan2021-04-201-2/+5
| |
| * Add note about expired Debian gpg signing keys to CHANGES.mdAndrew Morgan2021-04-201-0/+6
| |
* | Merge branch 'master' into developAndrew Morgan2021-04-2011-40/+62
|\|
| * Update v1.32.0 changelog. It's m.login.application_service, not plural v1.32.0Andrew Morgan2021-04-201-1/+1
| |
| * 1.32.0Andrew Morgan2021-04-204-6/+18
| |
| * Add Application Service registration type requirement + py35, pg95 ↵Andrew Morgan2021-04-201-0/+18
| | | | | | | | | | | | | | deprecation notices to v1.32.0 upgrade notes (#9849) Fixes https://github.com/matrix-org/synapse/issues/9846. Adds important removal information from the top of https://github.com/matrix-org/synapse/releases/tag/v1.32.0rc1 into UPGRADE.rst.
| * Always use the name as the log ID. (#9829)Patrick Cloke2021-04-208-34/+26
| | | | | | | | | | As far as I can tell our logging contexts are meant to log the request ID, or sometimes the request ID followed by a suffix (this is generally stored in the name field of LoggingContext). There's also code to log the name@memory location, but I'm not sure this is ever used. This simplifies the code paths to require every logging context to have a name and use that in logging. For sub-contexts (created via nested_logging_contexts, defer_to_threadpool, Measure) we use the current context's str (which becomes their name or the string "sentinel") and then potentially modify that (e.g. add a suffix).
* | Add presence federation stream (#9819)Erik Johnston2021-04-206-31/+426
| |
* | Fix bug where we sent remote presence states to remote servers (#9850)Erik Johnston2021-04-203-3/+13
| |
* | Fix (final) Bugbear violations (#9838)Jonathan de Jong2021-04-2023-49/+46
| |
* | Port "Allow users to click account renewal links multiple times without ↵Andrew Morgan2021-04-1918-263/+496
| | | | | | | | | | hitting an 'Invalid Token' page #74" from synapse-dinsic (#9832) This attempts to be a direct port of https://github.com/matrix-org/synapse-dinsic/pull/74 to mainline. There was some fiddling required to deal with the changes that have been made to mainline since (mainly dealing with the split of `RegistrationWorkerStore` from `RegistrationStore`, and the changes made to `self.make_request` in test code).
* | Sanity check identity server passed to bind/unbind. (#9802)Denis Kasak2021-04-193-3/+59
| | | | | | | | Signed-off-by: Denis Kasak <dkasak@termina.org.uk>
* | Don't send normal presence updates over federation replication stream (#9828)Erik Johnston2021-04-195-183/+75
| |
* | User directory: use calculated room membership state instead (#9821)Andrew Morgan2021-04-163-7/+36
| | | | | | | | | | Fixes: #9797. Should help reduce CPU usage on the user directory, especially when memberships change in rooms with lots of state history.
* | Small speed up joining large remote rooms (#9825)Erik Johnston2021-04-162-21/+34
| | | | | | | | | | There are a couple of points in `persist_events` where we are doing a query per event in series, which we can replace.
* | remove `HomeServer.get_config` (#9815)Richard van der Hoff2021-04-149-18/+16
| | | | | | | | Every single time I want to access the config object, I have to remember whether or not we use `get_config`. Let's just get rid of it.
* | Separate creating an event context from persisting it in the federation ↵Patrick Cloke2021-04-143-67/+118
| | | | | | | | | | | | handler (#9800) This refactoring allows adding logic that uses the event context before persisting it.
* | Revert "Check for space membership during a remote join of a restricted ↵Patrick Cloke2021-04-147-238/+131
| | | | | | | | | | | | | | | | room. (#9763)" This reverts commit cc51aaaa7adb0ec2235e027b5184ebda9b660ec4. The PR was prematurely merged and not yet approved.
* | Check for space membership during a remote join of a restricted room. (#9763)Patrick Cloke2021-04-147-131/+238
| | | | | | | | | | | | | | When receiving a /send_join request for a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
* | Experimental Federation Speedup (#9702)Jonathan de Jong2021-04-145-97/+129
| | | | | | | | | | This basically speeds up federation by "squeezing" each individual dual database call (to destinations and destination_rooms), which previously happened per every event, into one call for an entire batch (100 max). Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* | Move some replication processing out of generic_worker (#9796)Erik Johnston2021-04-146-483/+486
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | More robust handling of the Content-Type header for thumbnail generation (#9788)rkfg2021-04-143-0/+5
| | | | | | | | Signed-off-by: Sergey Shpikin <rkfg@rkfg.me>
* | Remove redundant "coding: utf-8" lines (#9786)Jonathan de Jong2021-04-14651-651/+1
| | | | | | | | | | | | | | Part of #9744 Removes all redundant `# -*- coding: utf-8 -*-` lines from files, as python 3 automatically reads source code as utf-8 now. `Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>`
* | Add a dockerfile for running a set of Synapse worker processes (#9162)Andrew Morgan2021-04-1411-6/+867
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR adds a Dockerfile and some supporting files to the `docker/` directory. The Dockerfile's intention is to spin up a container with: * A Synapse main process. * Any desired worker processes, defined by a `SYNAPSE_WORKERS` environment variable supplied at runtime. * A redis for worker communication. * A nginx for routing traffic. * A supervisord to start all worker processes and monitor them if any go down. Note that **this is not currently intended to be used in production**. If you'd like to use Synapse workers with Docker, instead make use of the official image, with one worker per container. The purpose of this dockerfile is currently to allow testing Synapse in worker mode with the [Complement](https://github.com/matrix-org/complement/) test suite. `configure_workers_and_start.py` is where most of the magic happens in this PR. It reads from environment variables (documented in the file) and creates all necessary config files for the processes. It is the entrypoint of the Dockerfile, and thus is run any time the docker container is spun up, recreating all config files in case you want to use a different set of workers. One can specify which workers they'd like to use by setting the `SYNAPSE_WORKERS` environment variable (as a comma-separated list of arbitrary worker names) or by setting it to `*` for all worker processes. We will be using the latter in CI. Huge thanks to @MatMaul for helping get this all working :tada: This PR is paired with its equivalent on the Complement side: https://github.com/matrix-org/complement/pull/62. Note, for the purpose of testing this PR before it's merged: You'll need to (re)build the base Synapse docker image for everything to work (`matrixdotorg/synapse:latest`). Then build the worker-based docker image on top (`matrixdotorg/synapse:workers`).
* | Add note to docker docs explaining platform support (#9801)Andrew Morgan2021-04-142-3/+7
|/ | | | | | | Context is in https://github.com/matrix-org/synapse/issues/9764#issuecomment-818615894. I struggled to find a more official link for this. The problem occurs when using WSL1 instead of WSL2, which some Windows platforms (at least Server 2019) still don't have. Docker have updated their documentation to paint a much happier picture now given WSL2's support. The last sentence here can probably be removed once WSL1 is no longer around... though that will likely not be for a very long time.
* Update changelog for v1.32.0 v1.32.0rc1Andrew Morgan2021-04-131-1/+1
|
* 1.32.0rc1Andrew Morgan2021-04-1337-36/+73
|
* Add release helper script (#9713)Erik Johnston2021-04-133-0/+252
| | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Bump black configuration to target py36 (#9781)Dan Callahan2021-04-1311-15/+16
| | | Signed-off-by: Dan Callahan <danc@element.io>
* Add an admin API to manage ratelimit for a specific user (#9648)Dirk Klimpel2021-04-136-6/+573
|
* Drop Python 3.5 from Trove classifier metadata. (#9782)Dan Callahan2021-04-122-1/+1
| | | | | * Drop Python 3.5 from Trove classifier metadata. Signed-off-by: Dan Callahan <danc@element.io>
* Add option to skip unit tests when building debs (#9793)Dan Callahan2021-04-124-13/+34
| | | Signed-off-by: Dan Callahan <danc@element.io>
* Require AppserviceRegistrationType (#9548)Will Hunt2021-04-125-23/+60
| | | This change ensures that the appservice registration behaviour follows the spec. We decided to do this for Dendrite, so it made sense to also make a PR for synapse to correct the behaviour.
* Use mock from the stdlib. (#9772)Patrick Cloke2021-04-0982-126/+86
|
* Fix duplicate logging of exceptions in transaction processing (#9780)Richard van der Hoff2021-04-092-7/+4
| | | There's no point logging this twice.
* Enable complement tests for MSC2946. (#9771)Patrick Cloke2021-04-092-1/+2
| | | By providing the additional build tag for `msc2946`.
* Proof of concept for GitHub Actions (#9661)Dan Callahan2021-04-092-0/+323
| | | Signed-off-by: Dan Callahan <danc@element.io>
* Remove old admin API `GET /_synapse/admin/v1/users/<user_id>` (#9401)Dirk Klimpel2021-04-095-27/+16
| | | | | | | | | | | | | Related: #8334 Deprecated in: #9429 - Synapse 1.28.0 (2021-02-25) `GET /_synapse/admin/v1/users/<user_id>` has no - unit tests - documentation API in v2 is available (#5925 - 12/2019, v1.7.0). API is misleading. It expects `user_id` and returns a list of all users. Signed-off-by: Dirk Klimpel dirk@klimpel.org
* Bugbear: Add Mutable Parameter fixes (#9682)Jonathan de Jong2021-04-0838-113/+224
| | | | | | | Part of #9366 Adds in fixes for B006 and B008, both relating to mutable parameter lint errors. Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* Merge pull request #9766 from matrix-org/rav/drop_py35Richard van der Hoff2021-04-0813-111/+24
|\ | | | | Require py36, Postgres 9.6, and sqlite 3.22
| * Merge remote-tracking branch 'origin/develop' into rav/drop_py35Richard van der Hoff2021-04-0867-825/+2182
| |\ | |/ |/|
* | Merge pull request #9769 from matrix-org/rav/fix_bionicRichard van der Hoff2021-04-083-11/+18
|\ \ | | | | | | Fix incompatibility with bionic
* \ \ Merge branch 'erikj/fix_stalled_catchup' into developErik Johnston2021-04-082-2/+5
|\ \ \
| * | | Fix sharded federation sender sometimes using 100% CPU.Erik Johnston2021-04-082-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We pull all destinations requiring catchup from the DB in batches. However, if all those destinations get filtered out (due to the federation sender being sharded), then the `last_processed` destination doesn't get updated, and we keep requesting the same set repeatedly.
* | | | Put opencontainers labels to the final image (#9765)Johannes Wienke2021-04-082-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | They don't make any sense on the intermediate builder image. The final images needs them to be of use for anyone. Signed-off-by: Johannes Wienke <languitar@semipol.de>
* | | | MSC3083: Check for space membership during a local join of restricted rooms. ↵Patrick Cloke2021-04-083-2/+76
|/ / / | | | | | | | | | | | | | | | | | | | | | (#9735) When joining a room with join rules set to 'restricted', check if the user is a member of the spaces defined in the 'allow' key of the join rules. This only applies to an experimental room version, as defined in MSC3083.
* | | Record more information into structured logs. (#9654)Patrick Cloke2021-04-0810-88/+255
| | | | | | | | | | | | Records additional request information into the structured logs, e.g. the requester, IP address, etc.
* | | Don't report anything from GaugeBucketCollector metrics until data is ↵Andrew Morgan2021-04-062-3/+14
| | | | | | | | | | | | | | | present (#8926) This PR modifies `GaugeBucketCollector` to only report data once it has been updated, rather than initially reporting a value of 0. Fixes zero values being reported for some metrics on startup until a background job to update the metric's value runs later.
* | | Add a Synapse Module for configuring presence update routing (#9491)Andrew Morgan2021-04-0614-64/+1282
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, if you'd like to share presence between local or remote users, those users must be sharing a room together. This isn't always the most convenient or useful situation though. This PR adds a module to Synapse that will allow deployments to set up extra logic on where presence updates should be routed. The module must implement two methods, `get_users_for_states` and `get_interested_users`. These methods are given presence updates or user IDs and must return information that Synapse will use to grant passing presence updates around. A method is additionally added to `ModuleApi` which allows triggering a set of users to receive the current, online presence information for all users they are considered interested in. This is the equivalent of that user receiving presence information during an initial sync. The goal of this module is to be fairly generic and useful for a variety of applications, with hard requirements being: * Sending state for a specific set or all known users to a defined set of local and remote users. * The ability to trigger an initial sync for specific users, so they receive all current state.
* | | Add type hints to expiring cache. (#9730)Patrick Cloke2021-04-068-54/+65
| | |
* | | Fix reported bugbear: too broad exception assertion (#9753)Andrew Morgan2021-04-062-2/+4
| | |
* | | Remove outdated constraint on remote_media_cache_thumbnails (#9725)Richard van der Hoff2021-04-063-3/+41
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `remote_media_cache_thumbnails_media_origin_media_id_thumbna_key` constraint is superceded by `remote_media_repository_thumbn_media_origin_id_width_height_met` (which adds `thumbnail_method` to the unique key). PR #7124 made an attempt to remove the old constraint, but got the name wrong, so it didn't work. Here we update the bg update and rerun it. Fixes #8649.
* | | Merge branch 'master' into developErik Johnston2021-04-068-8/+72
|\ \ \
| * | | 1.31.0 v1.31.0 github/release-v1.31.0 release-v1.31.0Erik Johnston2021-04-066-7/+27
| | | |
| * | | Add deprecation policy doc (#9723)Erik Johnston2021-04-064-2/+46
| | | | | | | | | | | | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * | | Fix version for bugbear (#9734)Jonathan de Jong2021-04-062-1/+2
| | | |
* | | | Add type hints to the federation handler and server. (#9743)Patrick Cloke2021-04-064-95/+97
| | | |
* | | | Convert storage test cases to HomeserverTestCase. (#9736)Patrick Cloke2021-04-0611-499/+265
| | | |
| | | * remove unused param on `make_tuple_comparison_clause`Richard van der Hoff2021-04-085-9/+3
| | | |
| | | * update test_old_deps scriptRichard van der Hoff2021-04-081-1/+1
| | | |
| | | * Update tox.ini to remove py35Richard van der Hoff2021-04-081-8/+6
| | | |
| | | * drop support for stretch and xenialRichard van der Hoff2021-04-081-2/+0
| | | |
| | | * Drop support for sqlite<3.22 as wellRichard van der Hoff2021-04-086-92/+14
| | | |
| | | * Require py36 and Postgres 9.6Richard van der Hoff2021-04-083-3/+4
| | |/
| | * unpin olddeps build from py36Richard van der Hoff2021-04-082-5/+5
| | |
| | * Fix incompatibility with tox 2.5Richard van der Hoff2021-04-082-6/+13
| |/ |/| | | | | | | Apparently on tox 2.5, `usedevelop` overrides `skip_install`, so we end up trying to install the full dependencies even for the `-old` environment.
* | Update mypy configuration: `no_implicit_optional = True` (#9742)Jonathan de Jong2021-04-0510-11/+21
| |
* | Fix version for bugbear (#9734)Jonathan de Jong2021-04-022-1/+2
| |
* | Improve tracing for to device messages (#9686)Erik Johnston2021-04-017-19/+102
| |
* | Add `order_by` to list user admin API (#9691)Dirk Klimpel2021-04-016-31/+248
| |
* | Add an experimental room version to support restricted join rules. (#9717)Patrick Cloke2021-03-316-11/+297
| | | | | | Per MSC3083.
* | Merge branch 'release-v1.31.0' into developPatrick Cloke2021-03-312-1/+2
|\|
| * Revert "Use 'dmypy run' in lint.sh instead of 'mypy' (#9701)" (#9720)Patrick Cloke2021-03-312-1/+2
| |
* | Make sample config allowed_local_3pids regex stricter. (#9719)Denis Kasak2021-03-313-4/+5
| | | | | | | | | | | | | | The regex should be terminated so that subdomain matches of another domain are not accepted. Just ensuring that someone doesn't shoot themselves in the foot by copying our example. Signed-off-by: Denis Kasak <dkasak@termina.org.uk>
* | Deprecate imp (#9718)Cristina2021-03-312-3/+9
| | | | | | | | | | Fixes #9642. Signed-off-by: Cristina Muñoz <hi@xmunoz.com>
* | Rewrite complement.sh (#9685)Andrew Morgan2021-03-312-11/+39
| | | | | | | | | | | | | | This PR rewrites the original complement.sh script with a number of improvements: * We can now use a local checkout of Complement (configurable with `COMPLEMENT_DIR`), though the default behaviour still downloads the master branch. * You can now specify a regex of test names to run, or just run all tests. * We now use the Synapse test blacklist tag (so all tests will pass).
* | Include m.room.create in invite_room_state for Spaces (#9710)Richard van der Hoff2021-03-302-0/+5
| |
* | Replace `room_invite_state_types` with `room_prejoin_state` (#9700)Richard van der Hoff2021-03-308-43/+144
| | | | | | | | | | | | | | `room_invite_state_types` was inconvenient as a configuration setting, because anyone that ever set it would not receive any new types that were added to the defaults. Here, we deprecate the old setting, and replace it with a couple of new settings under `room_prejoin_state`.
* | Make RateLimiter class check for ratelimit overrides (#9711)Erik Johnston2021-03-3016-154/+241
|/ | | | | | | This should fix a class of bug where we forget to check if e.g. the appservice shouldn't be ratelimited. We also check the `ratelimit_override` table to check if the user has ratelimiting disabled. That table is really only meant to override the event sender ratelimiting, so we don't use any values from it (as they might not make sense for different rate limits), but we do infer that if ratelimiting is disabled for the user we should disabled all ratelimits. Fixes #9663
* Update changelog v1.31.0rc1Erik Johnston2021-03-301-3/+7
|
* 1.31.0rc1Erik Johnston2021-03-3045-44/+65
|
* Use 'dmypy run' in lint.sh instead of 'mypy' (#9701)Andrew Morgan2021-03-302-1/+2
| | | For it's obvious performance benefits. `dmypy` support landed in #9692.
* Add type hints to DictionaryCache and TTLCache. (#9442)Patrick Cloke2021-03-297-67/+96
|
* Clarify that register_new_matrix_user is present also when installed via ↵blakehawkins2021-03-292-8/+19
| | | | | non-pip package (#9074) Signed-off-by: blakehawkins blake.hawkins.11@gmail.com
* Add type hints for the federation sender. (#9681)Patrick Cloke2021-03-297-59/+177
| | | | Includes an abstract base class which both the FederationSender and the FederationRemoteSendQueue must implement.
* Update the OIDC sample config (#9695)Richard van der Hoff2021-03-293-62/+7
| | | | | | | I've reiterated the advice about using `oidc` to migrate, since I've seen a few people caught by this. I've also removed a couple of the examples as they are duplicating the OIDC documentation, and I think they might be leading people astray.
* Fix CI by ignore type for None module import (#9709)Andrew Morgan2021-03-292-1/+2
|
* Fix `re.Pattern` mypy error on 3.6 (#9703)Jonathan de Jong2021-03-292-2/+3
|
* Fix the suggested pip incantation for cryptography (#9699)Richard van der Hoff2021-03-292-2/+16
| | | | | | | | | | | If you have the wrong version of `cryptography` installed, synapse suggests: ``` To install run: pip install --upgrade --force 'cryptography>=3.4.7;python_version>='3.6'' ``` However, the use of ' inside '...' doesn't work, so when you run this, you get an error.
* Make pip install faster in Docker build for Complement testing (#9610)Eric Eastwood2021-03-262-43/+42
| | | | | | | | | Make pip install faster in Docker build for [Complement](https://github.com/matrix-org/complement) testing. If files have changed in a `COPY` command, Docker will invalidate all of the layers below. So I changed the order of operations to install all dependencies before we `COPY synapse /synapse/synapse/`. This allows Docker to use our cached layer of dependencies even when we change the source of Synapse and speed up builds dramatically! `53.5s` -> `3.7s` builds 🤘 As an alternative, I did try using BuildKit caches but this still took 30 seconds overall on that step. 15 seconds to gather the dependencies from the cache and another 15 seconds to `Installing collected packages`. Fix https://github.com/matrix-org/synapse/issues/9364
* Suppress CryptographyDeprecationWarning (#9698)Richard van der Hoff2021-03-264-14/+26
| | | This warning is somewhat confusing to users, so let's suppress it
* Make it possible to use dmypy (#9692)Erik Johnston2021-03-2616-17/+56
| | | | | | | | | Running `dmypy run` will do a `mypy` check while spinning up a daemon that makes rerunning `dmypy run` a lot faster. `dmypy` doesn't support `follow_imports = silent` and has `local_partial_types` enabled, so this PR enables those options and fixes the issues that were newly raised. Note that `local_partial_types` will be enabled by default in upcoming mypy releases.
* Merge branch 'master' into developErik Johnston2021-03-265-21/+63
|\
| * Update cahngelog v1.30.1 github/release-v1.30.1 release-v1.30.1Erik Johnston2021-03-261-3/+2
| |
| * Update cahngelogErik Johnston2021-03-261-2/+14
| |
| * 1.30.1Erik Johnston2021-03-265-3/+26
| |
| * Explicitly upgrade openssl in docker file and enforce new version of ↵Erik Johnston2021-03-264-20/+28
| | | | | | | | cryptography (#9697)
* | Preserve host in example apache config (#9696)Paul Tötterman2021-03-262-5/+11
| | | | | | | | | | Fixes redirect loop Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
* | Use interpreter from $PATH instead of absolute paths in various scripts ↵Quentin Gliech2021-03-2517-17/+18
| | | | | | | | | | | | | | | | | | using /usr/bin/env (#9689) On NixOS, `bash` isn't under `/bin/bash` but rather in some directory in `$PATH`. Locally, I've been patching those scripts to make them work. `/usr/bin/env` seems to be the only [portable way](https://unix.stackexchange.com/questions/29608/why-is-it-better-to-use-usr-bin-env-name-instead-of-path-to-name-as-my) to use binaries from the PATH as interpreters. Signed-off-by: Quentin Gliech <quentingliech@gmail.com>
* | platform specific prerequisites in source install (#9667)Serban Constantin2021-03-252-7/+9
| | | | | | | | | | | | Make it clearer in the source install step that the platform specific prerequisites must be installed first. Signed-off-by: Serban Constantin <serban.constantin@gmail.com>
* | Add a storage method for returning all current presence from all users (#9650)Andrew Morgan2021-03-253-3/+69
| | | | | | | | | | | | | | Split off from https://github.com/matrix-org/synapse/pull/9491 Adds a storage method for getting the current presence of all local users, optionally excluding those that are offline. This will be used by the code in #9491 when a PresenceRouter module informs Synapse that a given user should have `"ALL"` user presence updates routed to them. Specifically, it is used here: https://github.com/matrix-org/synapse/blob/b588f16e391d664b11f43257eabf70663f0c6d59/synapse/handlers/presence.py#L1131-L1133 Note that there is a `get_all_presence_updates` function just above. That function is intended to walk up the table through stream IDs, and is primarily used by the presence replication stream. I could possibly make use of it in the PresenceRouter-related code, but it would be a bit of a bodge.
* | Fixed undefined variable error in catchup (#9664)Erik Johnston2021-03-242-0/+3
| | | | | | | | | | Broke in #9640 Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix typo in changelog.Patrick Cloke2021-03-242-2/+2
| |
* | Enable addtional flake8-bugbear linting checks. (#9659)Jonathan de Jong2021-03-248-8/+9
| |
* | Spaces summary: call out to other servers (#9653)Richard van der Hoff2021-03-244-27/+324
| | | | | | | | | | When we hit an unknown room in the space tree, see if there are other servers that we might be able to poll to get the data. Fixes: #9447
* | docs: fallback/web endpoint does not appear to be mounted on workers (#9679)Ben Banfield-Zanin2021-03-242-2/+2
| |
* | Bump mypy-zope to 0.2.13. (#9678)Patrick Cloke2021-03-242-1/+2
| | | | | | | | This fixes an error ("Cannot determine consistent method resolution order (MRO)") when running mypy with a cache.
* | Add type hints to misc. files. (#9676)Patrick Cloke2021-03-246-54/+57
| |
* | Add a type hints for service notices to the HomeServer object. (#9675)Patrick Cloke2021-03-2411-40/+52
| |
* | Increase default join burst ratelimiting (#9674)Erik Johnston2021-03-233-6/+7
| | | | | | It's legitimate behaviour to try and join a bunch of rooms at once.
* | Fix federation stall on concurrent access errors (#9639)Jonathan de Jong2021-03-232-36/+10
| |
* | Federation API for Space summary (#9652)Richard van der Hoff2021-03-233-54/+197
| | | | | | | | | | Builds on the work done in #9643 to add a federation API for space summaries. There's a bit of refactoring of the existing client-server code first, to avoid too much duplication.
* | Import HomeServer from the proper module. (#9665)Patrick Cloke2021-03-2359-58/+59
| |
* | Allow providing credentials to HTTPS_PROXY (#9657)Andrew Morgan2021-03-224-34/+184
| | | | | | | | | | | | | | Addresses https://github.com/matrix-org/synapse-dinsic/issues/70 This PR causes `ProxyAgent` to attempt to extract credentials from an `HTTPS_PROXY` env var. If credentials are found, a `Proxy-Authorization` header ([details](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Proxy-Authorization)) is sent to the proxy server to authenticate against it. The headers are *not* passed to the remote server. Also added some type hints.
* | Include opencontainers labels in Docker image (#9612)Johannes Wienke2021-03-222-0/+6
| | | | | | | | | | | | Cf. https://github.com/opencontainers/image-spec/blob/master/annotations.md#pre-defined-annotation-keys Signed-off-by: Johannes Wienke <languitar@semipol.de>
* | Fixed code misc. quality issues (#9649)Ankit Dobhal2021-03-224-3/+4
| | | | | | | | | | - Merge 'isinstance' calls. - Remove unnecessary dict call outside of comprehension. - Use 'sys.exit()' calls.
* | Merge branch 'master' into developErik Johnston2021-03-223-4/+17
|\|
| * 1.30.0 v1.30.0 github/release-v1.30.0 release-v1.30.0Erik Johnston2021-03-223-3/+16
| |
| * Fix jemalloc changelog entry wordingAndrew Morgan2021-03-161-1/+1
| |
* | Merge pull request #9644 from matrix-org/babolivier/msc3026Brendan Abolivier2021-03-227-4/+43
|\ \ | | | | | | Implement MSC3026: busy presence state
| * | Incorporate reviewBrendan Abolivier2021-03-192-2/+2
| | |
| * | Merge branch 'develop' into babolivier/msc3026Brendan Abolivier2021-03-1918-154/+563
| |\ \ | |/ / |/| |
* | | fix mypyRichard van der Hoff2021-03-191-4/+7
| | |
* | | federation_client: handle inline signing_keys in hs.yaml (#9647)Richard van der Hoff2021-03-182-54/+18
| | |
* | | federation_client: stop adding URL prefix (#9645)Richard van der Hoff2021-03-182-2/+3
| | |
* | | Fix type-hints from bad merge.Patrick Cloke2021-03-181-2/+2
| | |
* | | Initial spaces summary API (#9643)Richard van der Hoff2021-03-186-3/+277
| | | | | | | | | This is very bare-bones for now: federation will come soon, while pagination is descoped for now but will come later.
* | | Consistently check whether a password may be set for a user. (#9636)Dirk Klimpel2021-03-185-57/+122
| | |
* | | Make federation catchup send last event from any server. (#9640)Erik Johnston2021-03-184-38/+141
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently federation catchup will send the last *local* event that we failed to send to the remote. This can cause issues for large rooms where lots of servers have sent events while the remote server was down, as when it comes back up again it'll be flooded with events from various points in the DAG. Instead, let's make it so that all the servers send the most recent events, even if its not theirs. The remote should deduplicate the events, so there shouldn't be much overhead in doing this. Alternatively, the servers could only send local events if they were also extremities and hope that the other server will send the event over, but that is a bit risky.
| * | Fix lintBrendan Abolivier2021-03-192-11/+10
| | |
| * | Move support for MSC3026 behind an experimental flagBrendan Abolivier2021-03-183-3/+18
| | |
| * | Implement MSC3026: busy presence stateBrendan Abolivier2021-03-186-1/+27
|/ /
* | Ensure we use a copy of the event content dict before modifying it in ↵Andrew Morgan2021-03-175-2/+147
| | | | | | | | | | | | | | | | | | serialize_event (#9585) This bug was discovered by DINUM. We were modifying `serialized_event["content"]`, which - if you've got `USE_FROZEN_DICTS` turned on or are [using a third party rules module](https://github.com/matrix-org/synapse/blob/17cd48fe5171d50da4cb59db647b993168e7dfab/synapse/events/third_party_rules.py#L73-L76) - will raise a 500 if you try to a edit a reply to a message. `serialized_event["content"]` could be set to the edit event's content, instead of a copy of it, which is bad as we attempt to modify it. Instead, we also end up modifying the original event's content. DINUM uses a third party rules module, which meant the event's content got frozen and thus an exception was raised. To be clear, the problem is not that the event's content was frozen. In fact doing so helped us uncover the fact we weren't copying event content correctly.
* | Fix up types for the typing handler. (#9638)Patrick Cloke2021-03-174-14/+30
| | | | | | | | By splitting this to two separate methods the callers know what methods they can expect on the handler.
* | only save remote cross-signing keys if they're different from the current ↵Hubert Chathi2021-03-172-4/+19
| | | | | | | | | | ones (#9634) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix bad naming of storage function (#9637)Erik Johnston2021-03-174-4/+7
| | | | | | | | | | | | We had two functions named `get_forward_extremities_for_room` and `get_forward_extremeties_for_room` that took different paramters. We rename one of them to avoid confusion.
* | Prep work for removing `outlier` from `internal_metadata` (#9411)Richard van der Hoff2021-03-177-7/+36
| | | | | | | | | | | | | | | | | | | | | | | | * Populate `internal_metadata.outlier` based on `events` table Rather than relying on `outlier` being in the `internal_metadata` column, populate it based on the `events.outlier` column. * Move `outlier` out of InternalMetadata._dict Ultimately, this will allow us to stop writing it to the database. For now, we have to grandfather it back in so as to maintain compatibility with older versions of Synapse.
* | Add type hints to the room member handler. (#9631)Patrick Cloke2021-03-175-6/+17
| |
* | Enable flake8-bugbear, but disable most checks. (#9499)Jonathan de Jong2021-03-1612-10/+29
| | | | | | | | * Adds B00 to ignored checks. * Fixes remaining issues.
* | Add SSO attribute requirements for OIDC providers (#9609)Hubbe2021-03-165-1/+209
| | | | | | | | Allows limiting who can login using OIDC via the claims made from the IdP.
* | Return m.change_password.enabled=false if local database is disabled (#9588)Dirk Klimpel2021-03-164-15/+58
|/ | | | | Instead of if the user does not have a password hash. This allows a SSO user to add a password to their account, but only if the local password database is configured.
* Changelog typo v1.30.0rc1Andrew Morgan2021-03-161-1/+1
|
* Pull up appservice login deprecation noticeAndrew Morgan2021-03-161-6/+7
|
* 1.30.0rc1Andrew Morgan2021-03-1646-45/+71
|
* Pass SSO IdP information to spam checker's registration function (#9626)Andrew Morgan2021-03-165-6/+67
| | | | | | | Fixes https://github.com/matrix-org/synapse/issues/9572 When a SSO user logs in for the first time, we create a local Matrix user for them. This goes through the register_user flow, which ends up triggering the spam checker. Spam checker modules don't currently have any way to differentiate between a user trying to sign up initially, versus an SSO user (whom has presumably already been approved elsewhere) trying to log in for the first time. This PR passes `auth_provider_id` as an argument to the `check_registration_for_spam` function. This argument will contain an ID of an SSO provider (`"saml"`, `"cas"`, etc.) if one was used, else `None`.
* Install jemalloc in docker image (#8553)Mathieu Velten2021-03-164-2/+17
| | | | Co-authored-by: Will Hunt <willh@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
* Handle an empty cookie as an invalid macaroon. (#9620)Patrick Cloke2021-03-162-1/+3
| | | | | * Handle an empty cookie as an invalid macaroon. * Newsfragment
* Add support for stable MSC2858 API (#9617)Richard van der Hoff2021-03-1610-28/+88
| | | | | The stable format uses different brand identifiers, so we need to support two identifiers for each IdP.
* Clean up config settings for stats (#9604)Richard van der Hoff2021-03-164-29/+43
| | | ... and complain if people try to turn it off.
* Prevent bundling aggregations for state events (#9619)Andrew Morgan2021-03-163-2/+9
| | | There's no need to do aggregation bundling for state events. Doing so can cause performance issues.
* Fix Internal Server Error on `GET /saml2/authn_response` (#9623)Richard van der Hoff2021-03-162-2/+9
| | | | | | | * Fix Internal Server Error on `GET /saml2/authn_response` Seems to have been introduced in #8765 (Synapse 1.24.0) * Fix newsfile
* Revert requiring a specific version of Twisted for mypy checks. (#9618)Patrick Cloke2021-03-152-2/+1
|
* Fix remaining mypy issues due to Twisted upgrade. (#9608)Patrick Cloke2021-03-158-34/+42
|
* Don't go into federation catch up mode so easily (#9561)Erik Johnston2021-03-155-159/+190
| | | | | | | | | | Federation catch up mode is very inefficient if the number of events that the remote server has missed is small, since handling gaps can be very expensive, c.f. #9492. Instead of going into catch up mode whenever we see an error, we instead do so only if we've backed off from trying the remote for more than an hour (the assumption being that in such a case it is more than a transient failure).
* Optimise missing prev_event handling (#9601)Richard van der Hoff2021-03-153-28/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | Background: When we receive incoming federation traffic, and notice that we are missing prev_events from the incoming traffic, first we do a `/get_missing_events` request, and then if we still have missing prev_events, we set up new backwards-extremities. To do that, we need to make a `/state_ids` request to ask the remote server for the state at those prev_events, and then we may need to then ask the remote server for any events in that state which we don't already have, as well as the auth events for those missing state events, so that we can auth them. This PR attempts to optimise the processing of that state request. The `state_ids` API returns a list of the state events, as well as a list of all the auth events for *all* of those state events. The optimisation comes from the observation that we are currently loading all of those auth events into memory at the start of the operation, but we almost certainly aren't going to need *all* of the auth events. Rather, we can check that we have them, and leave the actual load into memory for later. (Ideally the federation API would tell us which auth events we're actually going to need, but it doesn't.) The effect of this is to reduce the number of events that I need to load for an event in Matrix HQ from about 60000 to about 22000, which means it can stay in my in-memory cache, whereas previously the sheer number of events meant that all 60K events had to be loaded from db for each request, due to the amount of cache churn. (NB I've already tripled the size of the cache from its default of 10K). Unfortunately I've ended up basically C&Ping `_get_state_for_room` and `_get_events_from_store_or_dest` into a new method, because `_get_state_for_room` is also called during backfill, which expects the auth events to be returned, so the same tricks don't work. That said, I don't really know why that codepath is completely different (ultimately we're doing the same thing in setting up a new backwards extremity) so I've left a TODO suggesting that we clean it up.
* Fix additional type hints from Twisted 21.2.0. (#9591)Patrick Cloke2021-03-1218-119/+187
|
* Reject concurrent transactions (#9597)Richard van der Hoff2021-03-122-35/+43
| | | | | | If more transactions arrive from an origin while we're still processing the first one, reject them. Hopefully a quick fix to https://github.com/matrix-org/synapse/issues/9489
* Improve logging when processing incoming transactions (#9596)Richard van der Hoff2021-03-123-73/+51
| | | Put the room id in the logcontext, to make it easier to understand what's going on.
* Add logging for redis connection setup (#9590)Richard van der Hoff2021-03-113-1/+39
|
* Add tests for blacklisting reactor/agent. (#9563)Patrick Cloke2021-03-113-14/+139
|
* Re-Activating account when local passwords are disabled (#9587)Dirk Klimpel2021-03-112-1/+5
| | | Fixes: #8393
* Convert Requester to attrs (#9586)Richard van der Hoff2021-03-105-35/+37
| | | | | | ... because namedtuples suck Fix up a couple of other annotations to keep mypy happy.
* Fix the auth provider on the logins metric (#9573)Richard van der Hoff2021-03-103-18/+33
| | | | | We either need to pass the auth provider over the replication api, or make sure we report the auth provider on the worker that received the request. I've gone with the latter.
* Fix spam checker modules documentation example (#9580)Jason Robinson2021-03-102-0/+11
| | | | Mention that parse_config must exist and note the check_media_file_for_spam method.
* Use the chain cover index in get_auth_chain_ids. (#9576)Patrick Cloke2021-03-105-11/+226
| | | | This uses a simplified version of get_chain_cover_difference to calculate auth chain of events.
* Fix a bug in the background task for purging chain cover. (#9583)Patrick Cloke2021-03-102-1/+2
|
* Do not ignore the unpaddedbase64 module when type checking. (#9568)Patrick Cloke2021-03-092-3/+1
|
* Add a background task to purge unused chain IDs. (#9542)Patrick Cloke2021-03-094-6/+99
| | | | | This is a companion change to apply the fix in #9498 / 922788c6043138165c025c78effeda87de842bab to previously purged rooms.
* Link to the List user's media admin API from media Admin API docs (#9571)Andrew Morgan2021-03-092-2/+15
| | | | | Earlier [I was convinced](https://github.com/matrix-org/synapse/issues/9565) that we didn't have an Admin API for listing media uploaded by a user. Foolishly I was looking under the Media Admin API documentation, instead of the User Admin API documentation. I thought it'd be helpful to link to the latter so others don't hit the same dead end :)
* JWT OIDC secrets for Sign in with Apple (#9549)Richard van der Hoff2021-03-0911-47/+444
| | | | | Apple had to be special. They want a client secret which is generated from an EC key. Fixes #9220. Also fixes #9212 while I'm here.
* Retry 5xx errors in federation client (#9567)Erik Johnston2021-03-092-3/+5
| | | Fixes #8915
* Fix additional type hints. (#9543)Patrick Cloke2021-03-099-18/+32
| | | Type hint fixes due to Twisted 21.2.0 adding type hints.
* Handle image transparency better when thumbnailing. (#9473)Patrick Cloke2021-03-093-11/+30
| | | | Properly uses RGBA mode for 1- and 8-bit images with transparency (instead of RBG mode).
* Add a list of hashes to ignore during git blame. (#9560)Patrick Cloke2021-03-093-0/+10
| | | | | | | The hashes are from commits due to auto-formatting, e.g. running black. git can be configured to use this automatically by running the following: git config blame.ignoreRevsFile .git-blame-ignore-revs
* Fixup sample configErik Johnston2021-03-091-2/+1
| | | | After 0764d0c6e575793ca506cf021aff3c4b9e0a5972
* Prevent the config-lint script erroring out on any sample_config changes (#9562)Andrew Morgan2021-03-092-2/+8
| | | | | | | | | I noticed that I'd occasionally have `scripts-dev/lint.sh` fail when messing about with config options in my PR. The script calls `scripts-dev/config-lint.sh`, which attempts some validation on the sample config. It does this by using `sed` to edit the sample_config, and then seeing if the file changed using `git diff`. The problem is: if you changed the sample_config as part of your commit, this script will error regardless. This PR attempts to change the check so that existing, unstaged changes to the sample_config will not cause the script to report an invalid file.
* Add logging to ObservableDeferred callbacks (#9523)Jonathan de Jong2021-03-092-8/+19
|
* quick config comment tweak to clarify allow_profile_lookup_over_federationMatthew Hodgson2021-03-081-2/+1
|
* Add ResponseCache tests. (#9458)Jonathan de Jong2021-03-0810-20/+156
|
* Warn that /register will soon require a type when called with an access ↵Will Hunt2021-03-082-0/+7
| | | | | token (#9559) This notice is giving a heads up to the planned spec compliance fix https://github.com/matrix-org/synapse/pull/9548.
* Add type hints to purge room and server notice admin API. (#9520)Dirk Klimpel2021-03-083-15/+24
|
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-01 06:32:07 +0000