summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Bump ijson from 3.2.0.post0 to 3.2.1 (#15802)dependabot[bot]2023-06-191-79/+79
| | | | | | | | | | | | | | | Bumps [ijson](https://github.com/ICRAR/ijson) from 3.2.0.post0 to 3.2.1. - [Changelog](https://github.com/ICRAR/ijson/blob/master/CHANGELOG.md) - [Commits](https://github.com/ICRAR/ijson/compare/v3.2.0.post0...v3.2.1) --- updated-dependencies: - dependency-name: ijson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump attrs from 22.2.0 to 23.1.0 (#15801)dependabot[bot]2023-06-191-9/+12
| | | | | | | | | | | | | | | | Bumps [attrs](https://github.com/python-attrs/attrs) from 22.2.0 to 23.1.0. - [Release notes](https://github.com/python-attrs/attrs/releases) - [Changelog](https://github.com/python-attrs/attrs/blob/main/CHANGELOG.md) - [Commits](https://github.com/python-attrs/attrs/compare/22.2.0...23.1.0) --- updated-dependencies: - dependency-name: attrs dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump phonenumbers from 8.13.13 to 8.13.14 (#15798)dependabot[bot]2023-06-191-3/+3
| | | | | | | | | | | | | | Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.13.13 to 8.13.14. - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.13.13...v8.13.14) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump ruff from 0.0.265 to 0.0.272 (#15799)dependabot[bot]2023-06-192-20/+20
| | | | | | | | | | | | | | | | Bumps [ruff](https://github.com/charliermarsh/ruff) from 0.0.265 to 0.0.272. - [Release notes](https://github.com/charliermarsh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/BREAKING_CHANGES.md) - [Commits](https://github.com/charliermarsh/ruff/compare/v0.0.265...v0.0.272) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump serde_json from 1.0.96 to 1.0.97 (#15797)dependabot[bot]2023-06-191-2/+2
| | | | | | | | | | | | | | | Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.96 to 1.0.97. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.96...v1.0.97) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove experimental MSC2716 implementation to incrementally import history ↵Eric Eastwood2023-06-1628-2103/+36
| | | | | | | | | | | | into existing rooms (#15748) Context for why we're removing the implementation: - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1487441010 - https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1504262734 Anyone wanting to continue MSC2716, should also address these leftover tasks: https://github.com/matrix-org/synapse/issues/10737 Closes https://github.com/matrix-org/synapse/issues/10737 in the fact that it is not longer necessary to track those things.
* Don't always lock "user_ips" table when performing non-native upsert (#15788)Andrew Morgan2023-06-162-1/+2
|
* push rules: fix internal conversion from _type to value (#15781)Mathieu Velten2023-06-164-17/+81
| | | Also fix wrong rule names for `is_user_mention` and `is_room_mention`.
* Regularly try to wake up dests instead of waiting for next PDU/EDU (#15743)Mathieu Velten2023-06-163-31/+26
|
* Fix unsafe hotserving behaviour for non-multimedia uploads. (#15680)Josh Qou2023-06-154-19/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix unsafe hotserving behaviour for non-multimedia uploads. * invert disposition assert * test_media_storage.py: run lint * test_base.py: /inline/attachment/s * Only return attachment for disposition type, update tests * Update synapse/media/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update changelog.d/15680.bugfix Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * add attribution * Update changelog. --------- Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Fix joining rooms through aliases where the alias server isn't a real ↵Tulir Asokan2023-06-142-1/+2
| | | | homeserver (#15776)
* Merge branch 'release-v1.86' into developMathieu Velten2023-06-1438-99/+103
|\
| * 1.86.0rc2 v1.86.0rc2Mathieu Velten2023-06-144-2/+18
| |
| * Revert "Allow for the configuration of max request retries and min/max retry ↵Mathieu Velten2023-06-145-68/+10
| | | | | | | | | | | | delays in the matrix federation client (#12504)" This reverts commit d84e66144dc12dacf71c987a2ba802dd59c0b68e.
| * Fix empty scope when having version mismatch between workers (#15774)Mathieu Velten2023-06-142-1/+2
| |
| * Fix changelog typo v1.86.0rc1Mathieu Velten2023-06-131-1/+1
| |
| * 1.86.0rc1Mathieu Velten2023-06-1333-31/+76
| |
* | Prefill events after invalidate not before when persisting events (#15758)Jason Little2023-06-145-5/+70
| | | | | | | | | | Fixes #15757
* | Document `looping_call()` functionality that will wait for the given ↵Eric Eastwood2023-06-132-0/+6
| | | | | | | | | | | | | | function to finish before scheduling another (#15772) Thanks to @erikjohnston for clarifying, https://github.com/matrix-org/synapse/pull/15743#discussion_r1226544457 We don't have to worry about calls stacking up if the given function takes longer than the scheduled time.
* | Replace `EventContext` fields `prev_group` and `delta_ids` with field ↵Shay2023-06-136-58/+126
| | | | | | | | `state_group_deltas` (#15233)
* | Fix MSC3983 support: only one OTK per device was returned through federation ↵Mathieu Velten2023-06-132-1/+4
| | | | | | | | (#15770)
* | Avoid backfill when we already have messages to return (#15737)Eric Eastwood2023-06-132-22/+116
| | | | | | | | | | We now only block the client to backfill when we see a large gap in the events (more than 2 events missing in a row according to `depth`), more than 3 single-event holes, or not enough messages to fill the response. Otherwise, we return the messages directly to the client and backfill in the background for eventual consistency sake. Fix https://github.com/matrix-org/synapse/issues/15696
* | Fix MSC3983 support: Use the unstable /keys/claim federation endpoint if ↵Patrick Cloke2023-06-132-1/+5
|/ | | | multiple keys are requested (#15755)
* Bump regex from 1.7.3 to 1.8.4 (#15769)dependabot[bot]2023-06-131-6/+6
| | | | | | | | | | | | | | | | Bumps [regex](https://github.com/rust-lang/regex) from 1.7.3 to 1.8.4. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/regex/compare/1.7.3...1.8.4) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump log from 0.4.18 to 0.4.19 (#15761)dependabot[bot]2023-06-131-2/+2
| | | | | | | | | | | | | | | | Bumps [log](https://github.com/rust-lang/log) from 0.4.18 to 0.4.19. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/log/compare/0.4.18...0.4.19) --- updated-dependencies: - dependency-name: log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump minimum supported Rust version (#15768)Erik Johnston2023-06-124-10/+19
| | | | Important crates such as `log` and `regex` have bumped theirs to 1.60.0 as well.
* Bump pyo3-log from 0.8.1 to 0.8.2 (#15759)dependabot[bot]2023-06-121-2/+2
| | | | | | | | | | | | | | | Bumps [pyo3-log](https://github.com/vorner/pyo3-log) from 0.8.1 to 0.8.2. - [Changelog](https://github.com/vorner/pyo3-log/blob/main/CHANGELOG.md) - [Commits](https://github.com/vorner/pyo3-log/compare/v0.8.1...v0.8.2) --- updated-dependencies: - dependency-name: pyo3-log dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump serde from 1.0.163 to 1.0.164 (#15760)dependabot[bot]2023-06-121-4/+4
| | | | | | | | | | | | | | | Bumps [serde](https://github.com/serde-rs/serde) from 1.0.163 to 1.0.164. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](https://github.com/serde-rs/serde/compare/v1.0.163...v1.0.164) --- updated-dependencies: - dependency-name: serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pyopenssl from 23.1.1 to 23.2.0 (#15765)dependabot[bot]2023-06-121-4/+4
| | | | | | | | | | | | | | | Bumps [pyopenssl](https://github.com/pyca/pyopenssl) from 23.1.1 to 23.2.0. - [Changelog](https://github.com/pyca/pyopenssl/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/pyopenssl/compare/23.1.1...23.2.0) --- updated-dependencies: - dependency-name: pyopenssl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump pydantic from 1.10.8 to 1.10.9 (#15762)dependabot[bot]2023-06-121-37/+37
| | | | | | | | | | | | | | | | Bumps [pydantic](https://github.com/pydantic/pydantic) from 1.10.8 to 1.10.9. - [Release notes](https://github.com/pydantic/pydantic/releases) - [Changelog](https://github.com/pydantic/pydantic/blob/main/HISTORY.md) - [Commits](https://github.com/pydantic/pydantic/compare/v1.10.8...v1.10.9) --- updated-dependencies: - dependency-name: pydantic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump sentry-sdk from 1.25.0 to 1.25.1 (#15764)dependabot[bot]2023-06-121-3/+3
| | | | | | | | | | | | | | | | Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.25.0 to 1.25.1. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.25.0...1.25.1) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump phonenumbers from 8.13.11 to 8.13.13 (#15763)dependabot[bot]2023-06-121-3/+3
| | | | | | | | | | | | | | Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.13.11 to 8.13.13. - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.13.11...v8.13.13) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump types-pyopenssl from 23.1.0.2 to 23.2.0.0 (#15766)dependabot[bot]2023-06-121-159/+7
| | | | | | | | | | | | | | Bumps [types-pyopenssl](https://github.com/python/typeshed) from 23.1.0.2 to 23.2.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyopenssl dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Backfill in the background if we're doing it "just because" (#15710)Eric Eastwood2023-06-092-4/+15
| | | Fix https://github.com/matrix-org/synapse/issues/15702
* Speed up typechecking CI (#15752)Erik Johnston2023-06-092-4/+5
| | | | By restoring the rust cache before installing the project.
* Allow for the configuration of max request retries and min/max retry delays ↵Shay2023-06-095-10/+68
| | | | | | | in the matrix federation client (#12504) Co-authored-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Erik Johnston <erik@matrix.org>
* Merge branch 'master' into developErik Johnston2023-06-084-2/+17
|\
| * Merge branch 'release-v1.85'Erik Johnston2023-06-084-2/+17
| |\
| | * Fix up changelog v1.85.2Erik Johnston2023-06-081-1/+1
| | |
| | * 1.85.2Erik Johnston2023-06-084-2/+16
| | |
| | * Fix using TLS for replication (#15746)Erik Johnston2023-06-082-1/+2
| | | | | | | | | Fixes #15744.
* | | Clear event caches when we purge history (#15609)Erik Johnston2023-06-089-14/+184
| | | | | | | | | | | | | | | | | | | | | This should help a little with #13476 --------- Co-authored-by: Patrick Cloke <patrickc@matrix.org>
* | | Quick & dirty metric for background update status (#15740)David Robertson2023-06-074-1/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Quick & dirty metric for background update status * Changelog * Remove debug Co-authored-by: Mathieu Velten <mathieuv@matrix.org> * Actually write to _aborted --------- Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
* | | Remove superfluous `room_memberships` join from background update (#15733)Eric Eastwood2023-06-072-1/+1
| | | | | | | | | Spawning from https://github.com/matrix-org/synapse/pull/15731
* | | Remove redundant `room_memberships` join to find participating servers in a ↵Eric Eastwood2023-06-072-3/+3
| | | | | | | | | | | | | | | room (#15732) Spawning from https://github.com/matrix-org/synapse/pull/15731
* | | Check required power levels earlier in createRoom handler. (#15695)Grant McLean2023-06-073-14/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Check required power levels earlier in createRoom handler. - If a server was configured to reject the creation of rooms with E2EE enabled (by specifying an unattainably high power level for "m.room.encryption" in default_power_level_content_override), the 403 error was not being triggered until after the room was created and before the "m.room.power_levels" was sent. This allowed a user to access the partially-configured room and complete the setup of E2EE and power levels manually. - This change causes the power level overrides to be checked earlier and the request to be rejected before the user gains access to the room. - A new `_validate_room_config` method is added to contain checks that should be run before a room is created. - The new test case confirms that a user request is rejected by the new validation method. Signed-off-by: Grant McLean <grant@catalyst.net.nz> * Add a changelog file. * Formatting fix for black. * Remove unneeded line from test. --------- Signed-off-by: Grant McLean <grant@catalyst.net.nz>
* | | Merge branch 'master' into developErik Johnston2023-06-074-2/+39
|\| |
| * | Merge branch 'release-v1.85'Erik Johnston2023-06-074-2/+39
| |\|
| | * Update changelog v1.85.1Erik Johnston2023-06-071-0/+2
| | |
| | * Update changelogErik Johnston2023-06-072-2/+1
| | |
| | * Fix schema delta error in 1.85 (#15739)Erik Johnston2023-06-072-2/+15
| | | | | | | | | | | | Some users seem to have multiple rows per user / room with a null thread ID, which we need to handle.
| | * 1.85.1Erik Johnston2023-06-074-2/+16
| | |
| | * Fix schema delta error in 1.85 (#15738)Erik Johnston2023-06-072-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | There appears to be a race where you can end up with entries in `event_push_summary` with both a `NULL` and `main` thread ID. Fixes #15736 Introduced in #15597
* | | No need for the extra join since `membership` is built-in to ↵Eric Eastwood2023-06-062-4/+4
| | | | | | | | | | | | | | | | | | | | | `current_state_events` (#15731) This helps with the upstream `is_host_joined()` and `is_host_invited()` functions. `membership` was added to `current_state_events` in https://github.com/matrix-org/synapse/pull/5706 and forced in https://github.com/matrix-org/synapse/pull/13745
* | | Trace functions which return `Awaitable` (#15650)Eric Eastwood2023-06-063-22/+59
| | |
* | | Update error to more plainly explain we can only authorize our own events ↵Eric Eastwood2023-06-062-1/+2
| | | | | | | | | | | | (#15725)
* | | Add context for when/why to use the `long_retries` option when sending ↵Eric Eastwood2023-06-062-2/+10
| | | | | | | | | | | | Federation requests (#15721)
* | | Improve performance of user directory search (#15729)Shay2023-06-062-4/+9
| | |
* | | Prevent "twisted trunk" and "latest deps" workflows from running on forks ↵Andrew Morgan2023-06-063-4/+44
| | | | | | | | | | | | (#15726)
* | | Remove some unused `server_name` fields (#15723)Sean Quah2023-06-066-5/+1
| | | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | | Merge remote-tracking branch 'origin/master' into developErik Johnston2023-06-061-1/+1
|\| |
| * | Fix link in changelogErik Johnston2023-06-061-1/+1
| |/
* | Merge branch 'master' into developErik Johnston2023-06-063-1/+28
|\|
| * Fixup changelog v1.85.0Erik Johnston2023-06-061-1/+1
| |
| * 1.85.0Erik Johnston2023-06-063-1/+28
| |
* | Stabilize support for MSC3952: Intentional mentions. (#15520)Patrick Cloke2023-06-0613-64/+27
| |
* | Some house keeping on `maybe_backfill()` functions (#15709)Eric Eastwood2023-06-052-0/+18
| |
* | Bump types-requests from 2.31.0.0 to 2.31.0.1 (#15715)dependabot[bot]2023-06-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [types-requests](https://github.com/python/typeshed) from 2.31.0.0 to 2.31.0.1. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | Bump types-jsonschema from 4.17.0.7 to 4.17.0.8 (#15716)dependabot[bot]2023-06-051-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [types-jsonschema](https://github.com/python/typeshed) from 4.17.0.7 to 4.17.0.8. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-jsonschema dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | Bump sentry-sdk from 1.22.1 to 1.25.0 (#15714)dependabot[bot]2023-06-051-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.22.1 to 1.25.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.22.1...1.25.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | Bump pyasn1 from 0.4.8 to 0.5.0 (#15713)dependabot[bot]2023-06-051-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [pyasn1](https://github.com/pyasn1/pyasn1) from 0.4.8 to 0.5.0. - [Release notes](https://github.com/pyasn1/pyasn1/releases) - [Changelog](https://github.com/pyasn1/pyasn1/blob/main/CHANGES.rst) - [Commits](https://github.com/pyasn1/pyasn1/compare/v0.4.8...v0.5.0) --- updated-dependencies: - dependency-name: pyasn1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | Bump library/redis from 6-bullseye to 7-bullseye in /docker (#15712)dependabot[bot]2023-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Bumps library/redis from 6-bullseye to 7-bullseye. --- updated-dependencies: - dependency-name: library/redis dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | Bump importlib-metadata from 6.1.0 to 6.6.0 (#15711)dependabot[bot]2023-06-051-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [importlib-metadata](https://github.com/python/importlib_metadata) from 6.1.0 to 6.6.0. - [Release notes](https://github.com/python/importlib_metadata/releases) - [Changelog](https://github.com/python/importlib_metadata/blob/main/CHANGES.rst) - [Commits](https://github.com/python/importlib_metadata/compare/v6.1.0...v6.6.0) --- updated-dependencies: - dependency-name: importlib-metadata dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* | `N + 3`: Read from column `full_user_id` rather than `user_id` of tables ↵Shay2023-06-0222-95/+252
| | | | | | | | `profiles` and `user_filters` (#15649)
* | Add a catch-all * to the supported relation types when redacting (#15705)Mathieu Velten2023-06-024-8/+143
| | | | | | This is an update to MSC3912 implementation
* | Log when events are (unexpectedly) filtered out of responses in tests (#14213)Eric Eastwood2023-06-017-14/+53
| | | | | | | | | | See https://github.com/matrix-org/synapse/pull/14095#discussion_r990335492 This is useful because when see that a relevant event is an `outlier` or `soft-failed`, then that's a good unexpected indicator explaining why it's not showing up. `filter_events_for_client` is used in `/sync`, `/messages`, `/context` which are all common end-to-end assertion touch points (also notifications, relations).
* | Merge branch 'release-v1.85' into developH. Shay2023-06-018-3/+92
|\|
| * 1.85.0rc2 v1.85.0rc2H. Shay2023-06-016-4/+28
| |
| * Add a note about deprecating /register with a user property. (#15703)Patrick Cloke2023-06-012-0/+12
| | | | | | | | | | Application services providing a "user" property (instead of "username") for the /register endpoint was never specified. Deprecate this very old fallback.
| * Speed up background jobs populate_full_user_id_user_filters and ↵Shay2023-05-313-2/+3
| | | | | | | | populate_full_user_id_profiles (#15700)
| * Fix a performance issue introduced in Synapse v1.83.0 which meant that ↵reivilibre2023-05-313-0/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | purging rooms was very slow and database-intensive. (#15693) * Add indices required to efficiently validate new foreign key constraints on stream_ordering * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Cache requests for user's devices from federation (#15675)Erik Johnston2023-06-013-2/+70
| | | | | | | | This should mitigate the issue where lots of different servers requests the same user's devices all at once.
* | Implement stable support for MSC3882 to allow an existing device/session to ↵Hugh Nimmo-Smith2023-06-0112-75/+225
| | | | | | | | | | | | | | | | generate a login token for use on a new device/session (#15388) Implements stable support for MSC3882; this involves updating Synapse's support to match the MSC / the spec says. Continue to support the unstable version to allow clients to transition.
* | Add Synapse version deploy annotations to Grafana dashboard (#15674)Eric Eastwood2023-05-312-174/+895
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/15662 This manifests as purple lines that show up on all time series panels that you can hover and see what version was deployed. Also added a new "Deployed Synapse versions over time" panel where the color block changes with each version. And mixed this color block into the "Up" time series panel. To get the Grafana dashboard JSON to copy here: use the **Share** icon at the top -> **Export** -> check the **Export for sharing externally** option -> **View JSON** or **Save to file**
* | Add stubs package for lxml. (#15697)Patrick Cloke2023-05-3110-48/+117
| | | | | | | | | | | | | | The stubs have some issues so this has some generous cast and ignores in it, but it is better than not having stubs. Note that confusing that Element is a function which creates _Element instances (and similarly for Comment).
* | Docker fully qualified image names (#15689)Jason Little2023-05-318-10/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fully qualified docker image names for the main Dockerfile and Complement related. * Fully qualified docker image names for Dockerfiles associated with building Debian release artifacts. This one is harder and is separate from the other commit in case it wasn't correct or was unwanted. I decided to do the expansion on the docker images in the Dockerfile itself, instead of the various source places that build which distribution that is selected, as it would have been more invasive with the scripts breaking up the string for tagging and such. This one is untested. * Changelog * Update docker/Dockerfile-workers * Update docker/complement/Dockerfile --------- Co-authored-by: reivilibre <olivier@librepush.net>
* | Add get_canonical_room_alias to module API (#15450)Gabriel Féron2023-05-313-1/+29
| | | | | | Co-authored-by: Boxdot <d@zerovolt.org>
* | Add stricter mypy options (#15694)Patrick Cloke2023-05-3111-24/+40
| | | | | | | | Enable warn_unused_configs, strict_concatenate, disallow_subclassing_any, and disallow_incomplete_defs.
* | Merge branch 'release-v1.85' into developDavid Robertson2023-05-3054-51/+84
|\|
| * fixup changelog v1.85.0rc1David Robertson2023-05-301-2/+2
| |
| * Update changelogDavid Robertson2023-05-301-2/+2
| |
| * Tweak release script dependabot wordingDavid Robertson2023-05-301-0/+2
| |
| * 1.85.0rc1David Robertson2023-05-3053-51/+82
| |
* | Enforce that an admin token also has the basic Matrix API scopeQuentin Gliech2023-05-302-6/+27
| |
* | Make the config tests spawn the homeserver only when neededQuentin Gliech2023-05-302-206/+182
| |
* | Reject tokens with multiple device scopesQuentin Gliech2023-05-302-7/+52
| |
* | Make OIDC scope constantsQuentin Gliech2023-05-301-10/+15
| |
* | Handle errors when introspecting tokensQuentin Gliech2023-05-303-7/+74
| | | | | | | | | | This returns a proper 503 when the introspection endpoint is not working for some reason, which should avoid logging out clients in those cases.
* | Newsfile.Quentin Gliech2023-05-301-0/+1
| |
* | Disable incompatible Admin API endpointsQuentin Gliech2023-05-303-8/+40
| |
* | Make AS tokens work & allow ASes to /registerQuentin Gliech2023-05-305-85/+159
| |
* | Add an admin token for MAS -> Synapse callsQuentin Gliech2023-05-302-0/+24
| |
* | Tests for JWKS endpointHugh Nimmo-Smith2023-05-302-11/+212
| |
* | Refactor config to be an experimental featureHugh Nimmo-Smith2023-05-3018-96/+479
| | | | | | | | Also enforce you can't combine it with incompatible config options
* | Test MSC2965 implementation: well-known discovery documentHugh Nimmo-Smith2023-05-301-0/+38
| |
* | Disable account related endpoints when using OAuth delegationQuentin Gliech2023-05-308-19/+243
| |
* | Actually enforce guest + return www-authenticate headerHugh Nimmo-Smith2023-05-304-8/+87
| |
* | Initial tests for OAuth delegationHugh Nimmo-Smith2023-05-301-0/+345
| |
* | MSC2967: Check access token scope for use as user and add guest supportHugh Nimmo-Smith2023-05-301-10/+20
| |
* | Use `name` claim as display name when registering users on the fly.Hugh Nimmo-Smith2023-05-301-1/+8
| | | | | | | | | | This makes is so that the `name` claim got when introspecting the token is used as the display name when registering a user on the fly.
* | Record the `sub` claims as an external_idQuentin Gliech2023-05-301-22/+37
| |
* | Handle the Synapse admin scopeQuentin Gliech2023-05-301-0/+3
| |
* | Save the scopes in the requesterQuentin Gliech2023-05-303-0/+11
| |
* | MSC2965: OIDC Provider discovery via well-known documentQuentin Gliech2023-05-301-0/+9
| |
* | Expose the public keys used for client authentication on an endpointQuentin Gliech2023-05-302-0/+78
| |
* | Initial MSC3964 support: delegation of auth to OIDC serverQuentin Gliech2023-05-303-1/+260
| |
* | Make the api.auth.Auth a ProtocolQuentin Gliech2023-05-307-248/+464
| |
* | Remove unused `FederationServer.__str__` override (#15690)Sean Quah2023-05-302-3/+1
|/ | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Create dependabot changelogs at release time (#15481)David Robertson2023-05-304-57/+57
| | | | | | | | | * Ditch dependabot changelog workflow * Summarise dependabot commits in release script * Changelog * Update scripts-dev/release.py
* Bump types-bleach from 6.0.0.1 to 6.0.0.3 (#15686)dependabot[bot]2023-05-302-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-bleach from 6.0.0.1 to 6.0.0.3 Bumps [types-bleach](https://github.com/python/typeshed) from 6.0.0.1 to 6.0.0.3. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-bleach dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Bump types-requests from 2.30.0.0 to 2.31.0.0 (#15684)dependabot[bot]2023-05-302-3/+4
| | | | | | | | | | | | | | | | | | | | | | | * Bump types-requests from 2.30.0.0 to 2.31.0.0 Bumps [types-requests](https://github.com/python/typeshed) from 2.30.0.0 to 2.31.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-requests dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump log from 0.4.17 to 0.4.18 (#15681)dependabot[bot]2023-05-292-5/+3
|
* Bump pydantic from 1.10.7 to 1.10.8 (#15685)dependabot[bot]2023-05-292-37/+38
|
* Bump prometheus-client from 0.16.0 to 0.17.0 (#15682)dependabot[bot]2023-05-292-3/+4
|
* Bump types-pyyaml from 6.0.12.9 to 6.0.12.10 (#15683)dependabot[bot]2023-05-292-3/+4
|
* Add Unix socket support for Redis connections (#15644)Jason Little2023-05-267-23/+100
| | | | Adds a new configuration setting to connect to Redis via a Unix socket instead of over TCP. Disabled by default.
* Add `MSC3820opt2` as a known room version (#15678)Travis Ralston2023-05-262-0/+2
|
* Documentation improvements to contributing guide (#15667) (#15668)Grant McLean2023-05-262-5/+29
| | | | | | | | | Fix #15667 - Reiterate the importance of getting Rust installed and set up before attempting to install the Python dependencies. - Mention the importance of confirming that `poetry install` completed successfully and include a typical error that the user might see if it did not. - Expand on "Now edit homeserver.yaml" to give examples of things likely to need changing and to link to the relevant sections of the Synapse server documentation.
* Set thread_id column to non-null for ↵Patrick Cloke2023-05-269-223/+292
| | | | | | | | | | | | | | | | event_push_{actions,actions_staging,summary} (#15597) Updates the database schema to require a thread_id (by adding a constraint that the column is non-null) for event_push_actions, event_push_actions_staging, and event_push_actions_summary. For PostgreSQL we add the constraint as NOT VALID, then VALIDATE the constraint a background job to avoid locking the table during an upgrade. Each table is updated as a separate schema delta to avoid deadlocks between them. For SQLite we simply rebuild the table & copy the data.
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2023-05-2611-7/+76
|\
| * Fix a typographical error in changelog v1.84.1Olivier Wilkinson (reivilibre)2023-05-261-1/+1
| |
| * 1.84.1Olivier Wilkinson (reivilibre)2023-05-265-3/+26
| |
| * Fix a bug introduced in Synapse v1.84.0 where workers do not start up when ↵reivilibre2023-05-268-5/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no `instance_map` was provided. (#15672) * Fix #15669: always populate instance map even if it was empty * Fix some tests * Fix more tests * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * CI fix: don't forget to update apt repository sources before installing olddeps deps * Add test testing the backwards compatibility --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Add `dch` and `notify-send` to the development Nix flake so that the release ↵reivilibre2023-05-262-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | script can be used. (#15673) * Add dch and notify-send to the Nix dev flake * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> --------- Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Add MSC3820 (room version 11) option 2 unstable room version. (#15666)Travis Ralston2023-05-262-0/+25
| |
* | Process previously failed backfill events in the background (#15585)Eric Eastwood2023-05-246-9/+252
| | | | | | | | | | | | | | | | | | Process previously failed backfill events in the background because they are bound to fail again and we don't need to waste time holding up the request for something that is bound to fail again. Fix https://github.com/matrix-org/synapse/issues/13623 Follow-up to https://github.com/matrix-org/synapse/issues/13621 and https://github.com/matrix-org/synapse/issues/13622 Part of making `/messages` faster: https://github.com/matrix-org/synapse/issues/13356
* | Add requesting user id parameter to key claim methods in ↵Shay2023-05-246-11/+39
| | | | | | | | `TransportLayerClient` (#15663)
* | Add type hints to test_descriptors. (#15659)Patrick Cloke2023-05-243-96/+105
| | | | | | Require type hints in test_descriptors and add missing ones.
* | Speed up user directory rebuild for users some more... (#15665)Erik Johnston2023-05-242-76/+115
| |
* | Improve type hints for cached decorator. (#15658)Patrick Cloke2023-05-246-63/+73
| | | | | | | | | | The cached decorators always return a Deferred, which was not properly propagated. It was close enough when wrapping coroutines, but failed if a bare function was wrapped.
* | Fix `@trace` not wrapping some state methods that return coroutines ↵Eric Eastwood2023-05-232-7/+9
| | | | | | | | | | | | | | | | | | | | | | correctly (#15647) ``` 2023-05-21 09:30:09,288 - synapse.logging.opentracing - 940 - ERROR - POST-1 - @trace may not have wrapped StateStorageController.get_state_for_groups correctly! The function is not async but returned a coroutine ``` Tracing instrumentation for these functions originally introduced in https://github.com/matrix-org/synapse/pull/15610
* | Consolidate logic to check for deactivated users. (#15634)Patrick Cloke2023-05-237-67/+55
| | | | | | | | | | | | | | This moves the deactivated user check to the method which all login types call. Additionally updates the application service tests to be more realistic by removing invalid tests and fixing server names.
* | Use a custom scheme & the worker name for replication requests. (#15578)Jason Little2023-05-234-19/+35
| | | | | | | | | | | | | | | | All the information needed is already in the `instance_map`, so use that instead of passing the hostname / IP & port manually for each replication request. This consolidates logic for future improvements of using e.g. UNIX sockets for workers.
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2023-05-234-8/+41
|\|
| * Tweak changelog and upgrade notes v1.84.0Olivier Wilkinson (reivilibre)2023-05-232-7/+25
| |
| * Tweak changelogOlivier Wilkinson (reivilibre)2023-05-231-1/+1
| |
| * 1.84.0Olivier Wilkinson (reivilibre)2023-05-234-2/+16
| |
| * `traceback.format_exception(...)` usage that is compatible with Python 3.7 ↵Eric Eastwood2023-05-162-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | and 3.11 (#15599) * Usage that is compatible with Python 3.8 and 3.11 > Since Python 3.10, instead of passing value and tb, an exception object can be passed as the first argument. If value and tb are provided, the first argument is ignored in order to provide backwards compatibility. > > -- https://docs.python.org/3/library/traceback.html * Add changelog
* | Bump requests from 2.28.2 to 2.31.0 (#15651)dependabot[bot]2023-05-232-5/+6
| |
* | Remove duplicate timestamp from test logs (`_trial_temp/test.log`) (#15636)Eric Eastwood2023-05-222-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/15618 ### Before ``` 2023-05-17 22:51:36-0500 [-] 2023-05-17 22:51:36,889 - synapse.server - 338 - INFO - sentinel - Finished setting up. ``` ### After ``` 2023-05-19 18:16:20-0500 [-] synapse.server - 338 - INFO - sentinel - Finished setting up. ``` ### Dev notes The `Twisted.Logger` controls the `2023-05-19 18:16:20-0500 [-]` prefix, see : [`twisted/twisted` -> `src/twisted/logger/_format.py#L362-L374`](https://github.com/twisted/twisted/blob/34b161e66bc7c9f9efbb95e82c770a863933e498/src/twisted/logger/_format.py#L362-L374) And we delegate our logs to the Twisted Logger for the tests which puts it in `_trial_temp/test.log`
* | Remove outdated comment in log config (#15648)Andrew Morgan2023-05-223-6/+3
| |
* | Properly parse event_fields in filters (#15607)Patrick Cloke2023-05-225-34/+99
| | | | | | | | | | | | | | | | The event_fields property in filters should use the proper escape rules, namely backslashes can be escaped with an additional backslash. This adds tests (adapted from matrix-js-sdk) and implements the logic to properly split the event_fields strings.
* | Bump pygithub from 1.58.1 to 1.58.2 (#15643)dependabot[bot]2023-05-222-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump pygithub from 1.58.1 to 1.58.2 Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.58.1 to 1.58.2. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/v1.58.2/doc/changes.rst) - [Commits](https://github.com/pygithub/pygithub/compare/v1.58.1...v1.58.2) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Limit the size of the `HomeServerConfig` cache in trial test runs (#15646)Sean Quah2023-05-222-16/+8
| | | | | | | | | | | | | | | | | | | | | | | | ...to try to control memory usage. `HomeServerConfig`s hold on to many Jinja2 objects, which come out to over 0.5 MiB per config. Over the course of a full test run, the cache grows to ~360 entries. Limit it to 8 entries. Part of #15622. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Bump furo from 2023.3.27 to 2023.5.20 (#15642)dependabot[bot]2023-05-222-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump furo from 2023.3.27 to 2023.5.20 Bumps [furo](https://github.com/pradyunsg/furo) from 2023.3.27 to 2023.5.20. - [Release notes](https://github.com/pradyunsg/furo/releases) - [Changelog](https://github.com/pradyunsg/furo/blob/main/docs/changelog.md) - [Commits](https://github.com/pradyunsg/furo/compare/2023.03.27...2023.05.20) --- updated-dependencies: - dependency-name: furo dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump sphinx from 6.1.3 to 6.2.1 (#15641)dependabot[bot]2023-05-222-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump sphinx from 6.1.3 to 6.2.1 Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 6.1.3 to 6.2.1. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/master/CHANGES) - [Commits](https://github.com/sphinx-doc/sphinx/compare/v6.1.3...v6.2.1) --- updated-dependencies: - dependency-name: sphinx dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-pillow from 9.5.0.2 to 9.5.0.4 (#15640)dependabot[bot]2023-05-222-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-pillow from 9.5.0.2 to 9.5.0.4 Bumps [types-pillow](https://github.com/python/typeshed) from 9.5.0.2 to 9.5.0.4. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pillow dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-setuptools from 67.7.0.2 to 67.8.0.0 (#15639)dependabot[bot]2023-05-222-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-setuptools from 67.7.0.2 to 67.8.0.0 Bumps [types-setuptools](https://github.com/python/typeshed) from 67.7.0.2 to 67.8.0.0. - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-setuptools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Instrument `state` and `state_group` storage related things (tracing) (#15610)Eric Eastwood2023-05-196-0/+63
| | | | | | | | | | Instrument `state` and `state_group` storage related things (tracing) so it's a little more clear where these database transactions are coming from as there is a lot of wires crossing in these functions. Part of `/messages` performance investigation: https://github.com/matrix-org/synapse/issues/13356
* | Trace how many new events from the backfill response we need to process (#15633)Eric Eastwood2023-05-192-0/+6
| | | | | | You can kinda derive this information from how many `_process_pulled_event` spans there are but it would be nice to quickly glance.
* | Remove old R30 because R30v2 supercedes it (#10428)reivilibre2023-05-195-246/+1
| | | | | | | | | | R30v2 has been out since 2021-07-19 (https://github.com/matrix-org/synapse/pull/10332) and we started collecting stats on 2021-08-16. Since it's been over a year now (almost 2 years), this is enough grace period for us to now rip it out.
* | Rename blacklist/whitelist internally. (#15620)Patrick Cloke2023-05-1925-206/+189
| | | | | | | | Avoid renaming configuration settings for now and rename internal code to use blocklist and allowlist instead.
* | Do not allow deactivated users to login with JWT. (#15624)Patrick Cloke2023-05-195-67/+156
| | | | | | | | | | To improve the organization of this code it moves the JWT login checks to a separate handler and then fixes the bug (and a deprecation warning).
* | Remove experimental configuration flags & unstable values for faster joins ↵Patrick Cloke2023-05-196-83/+8
| | | | | | | | | | | | | | (#15625) Synapse will no longer send (or respond to) the unstable flags for faster joins. These were only available behind a configuration flag and handled in parallel with the stable flags.
* | Fix `HomeServer`s leaking during `trial` test runs (#15630)Sean Quah2023-05-193-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change fixes two memory leaks during `trial` test runs. Garbage collection is disabled during each test case and a gen-0 GC is run at the end of each test. However, when the gen-0 GC is run, the `TestCase` object usually still holds references to the `HomeServer` used during the test. As a result, the `HomeServer` gets promoted to gen-1 and then never garbage collected. Fix this by periodically running full GCs. Additionally, fix `HomeServer`s leaking after tests that touch inbound federation due to `FederationRateLimiter`s adding themselves to a global set, by turning the set into a `WeakSet`. Resolves #15622. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Handle missing previous read marker event. (#15464)Nick Mills-Barrett2023-05-184-10/+162
| | | | | | | | | | If the previous read marker is pointing to an event that no longer exists (e.g. due to retention) then assume that the newly given read marker is newer.
* | Update Mutual Rooms (MSC2666) implementation (#15621)Jonathan de Jong2023-05-184-15/+37
| | | | | | | | | | | | | | | | To track changes in MSC2666: - The change from `/mutual_rooms/{user_id}` to `/mutual_rooms?user_id={user_id}`. - The addition of `next_batch_token` (and logic). - Unstable flag now being `uk.half-shot.msc2666.query_mutual_rooms`. - The error code when your own user is requested.
* | Fix olddeps build (#15626)Patrick Cloke2023-05-182-1/+3
| | | | | | Do an `apt update` before install packages.
* | flake.nix: start synapse automatically, add space usage warning (#15613)axel simon2023-05-182-15/+39
| | | | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Re-type config paths in `ConfigError`s to be `StrSequence`s (#15615)Sean Quah2023-05-188-26/+31
| | | | | | | | | | | | Part of #14809. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Fix error message when `app_service_config_files` validation fails (#15614)Sean Quah2023-05-182-2/+2
| | | | | | | | | | | | | | | | | | | | The second argument of `ConfigError` is a path, passed as an optional `Iterable[str]` and not a `str`. If a string is passed directly, Synapse unhelpfully emits "Error in configuration at a.p.p._.s.e.r.v.i.c.e._.c.o.n.f.i.g._.f.i.l.e.s'" when the config option has the wrong data type. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Add a new admin API to create a new device for a user. (#15611)Quentin Gliech2023-05-173-0/+57
| | | | | | | | This allows an external service (e.g. the matrix-authentication-service) to create devices for users.
* | Apply url_preview_url_blacklist to oEmbed and pre-cached images (#15601)Patrick Cloke2023-05-164-50/+379
| | | | | | | | | | | | | | | | There are two situations which were previously not properly checked: 1. If the requested URL was replaced with an oEmbed URL, then the oEmbed URL was not checked against url_preview_url_blacklist. 2. Follow-up URLs (either via autodiscovery of oEmbed or to pre-cache images) were not checked against url_preview_url_blacklist.
* | Update code to refer to "workers". (#15606)Patrick Cloke2023-05-1617-69/+38
| | | | | | | | A bunch of comments and variables are out of date and use obsolete terms.
* | Run mypy type checking with the minimum supported Python version (#15602)Eric Eastwood2023-05-162-0/+4
| | | | | | | | | | We use the oldest Python version because later Python versions can include some overloads which don't work in the older versions which we still support. We're using Python 3.8 instead of 3.7 which is our actual minimum support version because it's EOL is in a matter of weeks so can avoid the extra effort. And in any case, minimum Python 3.8 support is better than winging it on Python 3.11.
* | Add not null constraint to column `full_user_id` of tables `profiles` and ↵Shay2023-05-1610-4/+425
| | | | | | | | `user_filters` (#15537)
* | `traceback.format_exception(...)` usage that is compatible with Python 3.7 ↵Eric Eastwood2023-05-162-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | and 3.11 (#15599) * Usage that is compatible with Python 3.8 and 3.11 > Since Python 3.10, instead of passing value and tb, an exception object can be passed as the first argument. If value and tb are provided, the first argument is ignored in order to provide backwards compatibility. > > -- https://docs.python.org/3/library/traceback.html * Add changelog
* | Fix subscriptable type usage in Python <3.9 (#15604)Eric Eastwood2023-05-163-3/+3
|/ | | | | | | | | | | | Fix the following `mypy` errors when running `mypy` with Python 3.7: ``` synapse/storage/controllers/stats.py:58: error: "Counter" is not subscriptable, use "typing.Counter" instead [misc] tests/test_state.py:267: error: "dict" is not subscriptable, use "typing.Dict" instead [misc] ``` Part of https://github.com/matrix-org/synapse/issues/15603 In Python 3.9, `typing` is deprecated and the types are subscriptable (generics) by default, https://peps.python.org/pep-0585/#implementation
* Tweak changelog v1.84.0rc1Olivier Wilkinson (reivilibre)2023-05-161-1/+1
|
* 1.84.0rc1Olivier Wilkinson (reivilibre)2023-05-1656-54/+84
|
* Revert "Fix subscriptable dict type"Eric Eastwood2023-05-151-1/+1
| | | | This reverts commit 55b08534a412f462251753f67308405ca4d02ebe.
* Fix subscriptable dict typeEric Eastwood2023-05-151-1/+1
| | | | | | | | | | Fix: ``` tests/test_state.py:267: error: "dict" is not subscriptable, use "typing.Dict" instead [misc] ``` In Python 3.9, `typing` is deprecated and the types are subscriptable (generics) by default, https://peps.python.org/pep-0585/#implementation
* Export `run_as_background_process` from the module API (#15577)Shay2023-05-152-0/+2
|
* Implement MSC3821 to update redaction rules (`third_party_invite.signed`) ↵Patrick Cloke2023-05-154-1/+125
| | | | | | (#15563) Updates the redaction rules to protect enough information that the event can still be properly verified.
* Reject instead of erroring on invalid membership events. (#15564)Patrick Cloke2023-05-152-6/+12
| | | | Instead of resulting in an internal server error for invalid events, return that the event is invalid.
* Implement MSC3389 to protect relations from redaction. (#15565)Patrick Cloke2023-05-154-0/+120
| | | | | | MSC3389 proposes protecting the relation type & parent event ID from redaction. This keeps the relation information intact after redaction which helps with some UX flaws (e.g. deleting an event causes it to no longer be in a thread, which is confusing).
* Revert "Bump pillow from 9.4.0 to 9.5.0 (#15593)"Mathieu Velten2023-05-152-72/+82
| | | | This reverts commit 34ab8013793df7471352c4d2bb9d9dcd50de769a.
* Allow poetry-core 1.6.0 (#15588)icp2023-05-152-1/+2
|
* Update Mastodon SSO instructions (#15587)villepeh2023-05-152-2/+5
|
* Add an unstable feature flag for MSC3981 to the /versions endpoint (#15558)Michael Weimann2023-05-152-0/+3
| | | | Signed-off-by: Michael Weimann <michaelw@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Bump phonenumbers from 8.13.7 to 8.13.11 (#15590)dependabot[bot]2023-05-152-3/+4
|
* Bump types-psycopg2 from 2.9.21.9 to 2.9.21.10 (#15591)dependabot[bot]2023-05-152-3/+4
|
* Bump types-commonmark from 0.9.2.2 to 0.9.2.3 (#15592)dependabot[bot]2023-05-152-3/+4
|
* Bump types-setuptools from 67.7.0.1 to 67.7.0.2 (#15594)dependabot[bot]2023-05-152-3/+4
|
* Bump pillow from 9.4.0 to 9.5.0 (#15593)dependabot[bot]2023-05-152-82/+72
|
* Bump serde from 1.0.162 to 1.0.163 (#15589)dependabot[bot]2023-05-152-4/+5
|
* Declare support for Matrix 1.6 (#15559)Patrick Cloke2023-05-124-1/+23
| | | | | | | Adds logging for key server requests which include a key ID. This is technically in violation of the 1.6 spec, but is the only way to remain backwards compatibly with earlier versions of Synapse (and possibly other homeservers) which *did* include the key ID.
* Revert "Set thread_id column to non-null for ↵Erik Johnston2023-05-127-225/+234
| | | | | event_push_{actions,actions_staging,summary} (#15437)" (#15580) This reverts commit a7b3e9ce65335e452de216cb42b9e724e8f3ad1d.
* Relax poetry-core lower bound to 1.1.0 (#15571)David Robertson2023-05-125-54/+17
| | | | | See https://github.com/matrix-org/synapse/pull/15566#issuecomment-1543844104 Also check you can `pip install` in the old-deps CI job
* Add pkg-config package to Stage 0 (#15567)helix-loop2023-05-122-1/+2
|
* Deal with more GHA deprecations (#15576)David Robertson2023-05-113-8/+10
| | | | | | | | | * Bump netlify PR * Manually cache mypy cache dir cache cache cache cache cache cache cache cache cache cache * Changelog
* Print full startup/initialization error (#15569)Eric Eastwood2023-05-112-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I found the error in the **Before** really vague and obtuse and didn't realize port `5432` corresponded to the Postgres port until searching the codebase. It says to check the logs but that wasn't my first instinct. It's just more obvious if we just print the full thing which gives context of the error type and the traceback to the relevant area of code. #### Before ``` $ poetry run python -m synapse.app.homeserver -c homeserver.yaml ********************************************************************************** Error during initialisation: connection to server at "localhost" (::1), port 5432 failed: Connection refused Is the server running on that host and accepting TCP/IP connections? connection to server at "localhost" (127.0.0.1), port 5432 failed: Connection refused Is the server running on that host and accepting TCP/IP connections? There may be more information in the logs. ********************************************************************************** ``` #### After ```sh $ poetry run python -m synapse.app.homeserver -c homeserver.yaml ********************************************************************************** Error during initialisation: Traceback (most recent call last): File "/home/eric/Documents/github/element/synapse/synapse/app/homeserver.py", line 352, in setup hs.setup() File "/home/eric/Documents/github/element/synapse/synapse/server.py", line 337, in setup self.datastores = Databases(self.DATASTORE_CLASS, self) File "/home/eric/Documents/github/element/synapse/synapse/storage/databases/__init__.py", line 65, in __init__ with make_conn(database_config, engine, "startup") as db_conn: File "/home/eric/Documents/github/element/synapse/synapse/storage/database.py", line 161, in make_conn native_db_conn = engine.module.connect(**db_params) File "/home/eric/.cache/pypoetry/virtualenvs/matrix-synapse-xCtC9ulO-py3.10/lib/python3.10/site-packages/psycopg2/__init__.py", line 122, in connect conn = _connect(dsn, connection_factory=connection_factory, **kwasync) psycopg2.OperationalError: connection to server at "localhost" (::1), port 5432 failed: Connection refused Is the server running on that host and accepting TCP/IP connections? connection to server at "localhost" (127.0.0.1), port 5432 failed: Connection refused Is the server running on that host and accepting TCP/IP connections? There may be more information in the logs. ********************************************************************************** ```
* Allow `pip install` to use setuptools_rust 1.6.0 (#15570)David Robertson2023-05-112-1/+2
| | | | | | | | | | | | | | | * Allow `pip install` to use setuptools_rust 1.6.0 This was bumped by dependabot in #15512, but we didn't bump also raise the version guard here. I don't know how we can avoid this happening in the future. Closes #15461. Spotted in [1] by @landryb. [1]: https://github.com/matrix-org/synapse/issues/15461#issuecomment-1543513934 * Changelog
* Add redis SSL configuration options (#15312)Roel ter Maat2023-05-117-14/+98
| | | | | | | | | | | | | | | | | * Add SSL options to redis config * fix lint issues * Add documentation and changelog file * add missing . at the end of the changelog * Move client context factory to new file * Rename ssl to tls and fix typo * fix lint issues * Added when redis attributes were added
* Require at least poetry-core v1.2.0 (#15566)V024602023-05-112-1/+2
| | | Signed-off-by: Kai A. Hiller <V02460@gmail.com>
* Remove `worker_replication_*` settings (#15491)Jason Little2023-05-1114-66/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add master to the instance_map as part of Complement, have ReplicationEndpoint look at instance_map for master. * Fix typo in drive by. * Remove unnecessary worker_replication_* bits from unit tests and add master to instance_map(hopefully in the right place) * Several updates: 1. Switch from master to main for naming the main process in the instance_map. Add useful constants for easier adjustment of names in the future. 2. Add backwards compatibility for worker_replication_* to allow time to transition to new style. Make sure to prioritize declaring main directly on the instance_map. 3. Clean up old comments/commented out code. 4. Adjust unit tests to match with new code. 5. Adjust Complement setup infrastructure to only add main to the instance_map if workers are used and remove now unused options from the worker.yaml template. * Initial Docs upload * Changelog * Missed some commented out code that can go now * Remove TODO comment that no longer holds true. * Fix links in docs * More docs * Remove debug logging * Apply suggestions from code review Co-authored-by: reivilibre <olivier@librepush.net> * Apply suggestions from code review Co-authored-by: reivilibre <olivier@librepush.net> * Update version to latest, include completeish before/after examples in upgrade notes. * Fix up and docs too --------- Co-authored-by: reivilibre <olivier@librepush.net>
* Add an unstable feature flag for MSC3391 to the /versions endpoint (#15562)Andrew Morgan2023-05-112-0/+3
|
* Fix documented path to largest rooms statistics endpoint. (#15560)Reto Schneider2023-05-102-1/+2
|
* Stabilize MSC2659 support for AS ping endpoint. (#15528)Tulir Asokan2023-05-096-15/+11
|
* HTTP Replication Client (#15470)Jason Little2023-05-096-3/+297
| | | | | | Separate out a HTTP client for replication in preparation for also supporting using UNIX sockets. The major difference from the base class is that this does not use treq to handle HTTP requests.
* Add config option to prevent media downloads from listed domains. (#15197)Travis Ralston2023-05-096-0/+186
| | | | | | | This stops media (and thumbnails) from being accessed from the listed domains. It does not delete any already locally cached media, but will prevent accessing it. Note that admin APIs are unaffected by this change.
* Merge branch 'master' into developMathieu Velten2023-05-093-1/+13
|\
| * 1.83.0 v1.83.0Mathieu Velten2023-05-093-1/+13
| |
* | Error if attempting to set m.push_rules account data, per MSC4010. (#15555)Patrick Cloke2023-05-099-35/+95
| | | | | | | | | | m.push_rules, like m.fully_read, is a special account data type that cannot be set using the normal /account_data endpoint. Return an error instead of allowing data that will not be used to be stored.
* | Use account data constants in more places. (#15554)Patrick Cloke2023-05-095-9/+13
| |
* | Bump hiredis from 2.2.2 to 2.2.3 (#15552)dependabot[bot]2023-05-082-90/+91
| |
* | Bump serde from 1.0.160 to 1.0.162 (#15548)dependabot[bot]2023-05-080-0/+0
| |
* | Bump serde from 1.0.160 to 1.0.162 (#15548)dependabot[bot]2023-05-082-4/+5
| |
* | Bump sentry-sdk from 1.19.1 to 1.22.1 (#15550)dependabot[bot]2023-05-082-4/+5
| |
* | Bump types-setuptools from 67.6.0.5 to 67.7.0.1 (#15549)dependabot[bot]2023-05-082-3/+4
| |
* | Bump ruff from 0.0.259 to 0.0.265 (#15551)dependabot[bot]2023-05-083-20/+21
| |
* | Bump types-requests from 2.29.0.0 to 2.30.0.0 (#15553)dependabot[bot]2023-05-082-4/+5
| |
* | Check appservices for devices during a /user/devices query. (#15539)Patrick Cloke2023-05-053-1/+163
| | | | | | | | | | | | | | | | MSC3984 proxies /keys/query requests to appservices, but servers will can also requests devices / keys from the /user/devices endpoint. The formats are close enough that we can "proxy" that /user/devices to appservices (by calling /keys/query) and then change the format of the returned data before returning it over federation.
* | Implement MSC4009 to widen the allowed Matrix ID grammar (#15536)Patrick Cloke2023-05-056-17/+54
| | | | | | | | | | Behind a configuration flag this adds + to the list of allowed characters in Matrix IDs. The main feature this enables is using full E.164 phone numbers as Matrix IDs.
* | Handle `DNSNotImplementedError` in SRV resolver (#15523)Zdziszek2023-05-052-1/+5
| | | | | | Signed-off-by: Zdzichu <zdzichu.rks@protonmail.com>
* | Add `mdbook` to flake.nix (#15545)Andrew Morgan2023-05-054-2/+6
| |
* | Clean up and clarify "Create or modify Account" Admin API documentation (#15544)Andrew Morgan2023-05-056-42/+74
| |
* | Factor out an `is_mine_server_name` method (#15542)Sean Quah2023-05-0523-36/+64
| | | | | | | | | | | | | | | | | | | | | | | | Add an `is_mine_server_name` method, similar to `is_mine_id`. Ideally we would use this consistently, instead of sometimes comparing against `hs.hostname` and other times reaching into `hs.config.server.server_name`. Also fix a bug in the tests where `hs.hostname` would sometimes differ from `hs.config.server.server_name`. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Allow running Complement integration tests via podman (#15543)Andrew Morgan2023-05-053-12/+28
| |
* | Move ThirdPartyEventRules into module_api/callbacks (#15535)Andrew Morgan2023-05-0419-68/+92
| |
* | Update the base rules to remove the dont_notify action. (MSC3987) (#15534)Patrick Cloke2023-05-045-8/+14
| | | | | | | | | | A dont_notify action is a no-op (and coalesce is undefined). These are both considered no-ops by the spec, per MSC3987 and the predefined push rules were updated to remove dont_notify from the list of actions.
* | Bump pyicu from 2.10.2 to 2.11 (#15509)dependabot[bot]2023-05-032-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump pyicu from 2.10.2 to 2.11 Bumps [pyicu](https://gitlab.pyicu.org/main/pyicu) from 2.10.2 to 2.11. --- updated-dependencies: - dependency-name: pyicu dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Use oEmbed for YouTube Shorts (#15025)Sandro2023-05-032-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | It seems that YouTube Short previews do not work in some regions, but the oEmbed information for those areas is still valid. This causes YouTube Shorts to always use (only) the oEmbed endpoint which is a minor regression for regions where the URL preview was already working -- some of the additional video metadata is lost. It is not likely that clients are using this today and it is more beneficial to have a limited preview working everywhere than unused metadata in the Open Graph response.
* | Add `xmlsec` package to flake.nix (#15532)Andrew Morgan2023-05-032-0/+2
| |
* | Switch back to upstream devenv flake (#15533)Andrew Morgan2023-05-033-11/+8
| |
* | Merge branch 'release-v1.83' into developSean Quah2023-05-0342-64/+77
|\|
| * Revert "Reduce the size of the HTTP connection pool for non-pushers" (#15530) v1.83.0rc1Sean Quah2023-05-036-31/+16
| | | | | | | | | | | | | | | | | | #15514 introduced a regression where Synapse would encounter `PartialDownloadError`s when fetching OpenID metadata for certain providers on startup. Due to #8088, this prevents Synapse from starting entirely. Revert the change while we decide what to do about the regression.
| * Update CHANGES.mdSean Quah2023-05-021-1/+1
| |
| * Update CHANGES.mdSean Quah2023-05-021-5/+5
| |
| * Fix up docs summary to include new experimental features admin API docsSean Quah2023-05-021-0/+1
| |
| * 1.83.0rc1Sean Quah2023-05-0236-34/+61
| |
* | Speed up deleting of old rows in `event_push_actions` (#15531)Erik Johnston2023-05-032-0/+10
| | | | | | Enforce that we use index scans (rather than seq scans), which we also do for state queries. The reason to enforce this is that we can't correctly get PostgreSQL to understand the distribution of `stream_ordering` depends on `highlight`, and so it always defaults (on matrix.org) to sequential scans.
* | Speed up rebuilding of the user directory for local users (#15529)Erik Johnston2023-05-033-77/+172
| | | | | | The idea here is to batch up the work.
* | Suppress the trusted key server warning for matrix.org in the demo scripts ↵Andrew Morgan2023-05-032-7/+4
| | | | | | | | (#15527)
* | Set thread_id column to non-null for ↵Patrick Cloke2023-05-037-234/+225
| | | | | | | | | | | | | | | | | | | | | | | | | | event_push_{actions,actions_staging,summary} (#15437) Updates the database schema to require a thread_id (by adding a constraint that the column is non-null) for event_push_actions, event_push_actions_staging, and event_push_actions_summary. For PostgreSQL we add the constraint as NOT VALID, then VALIDATE the constraint a background job to avoid locking the table during an upgrade. For SQLite we simply rebuild the table & copy the data.
* | Add config option to forget rooms automatically when users leave them (#15224)Sean Quah2023-05-039-47/+259
| | | | | | | | | | This is largely based off the stats and user directory updater code. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Remove references to supporting per-user flag for msc2654 (#15522)Shay2023-05-024-13/+10
| |
* | Allow adding random delay to push (#15516)Erik Johnston2023-05-025-2/+68
|/ | | This is to discourage timing based profiling on the push gateways.
* Reduce the size of the HTTP connection pool for non-pushers. (#15514)Patrick Cloke2023-05-026-16/+31
| | | | | | | | | | | | | | Pushers tend to make many connections to the same HTTP host (e.g. a new event comes in, causes events to be pushed, and then the homeserver connects to the same host many times). Due to this the per-host HTTP connection pool size was increased, but this does not make sense for other SimpleHttpClients. Add a parameter for the connection pool and override it for pushers (making a separate SimpleHttpClient for pushers with the increased configuration). This returns the HTTP connection pool settings to the default Twisted ones for non-pusher HTTP clients.
* Initial implementation of MSC3981: recursive relations API (#15315)Patrick Cloke2023-05-026-18/+186
| | | | | | | | | | | Adds an optional keyword argument to the /relations API which will recurse a limited number of event relationships. This will cause the API to return not just the events related to the parent event, but also events related to those related to the parent event, etc. This is disabled by default behind an experimental configuration flag and is currently implemented using prefixed parameters.