summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Detox, part 1 of N (#12119)David Robertson2022-03-014-14/+12
| | | | * Don't use `tox` for `check-sampleconfig` * Don't use `tox` for check-newsfragment
* Use importlib.metadata to read requirements (#12088)David Robertson2022-03-0113-115/+237
| | | | | | | | | | | | | | | | | | * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases
* Fix rare error in `ReadWriteLock` when writers complete immediately (#12105)Sean Quah2022-03-013-1/+35
| | | | Signed-off-by: Sean Quah <seanq@element.io>
* Add module callbacks called for reacting to deactivation status change and ↵Brendan Abolivier2022-03-017-7/+360
| | | | profile update (#12062)
* Use Python 3.9 in Synapse dockerfiles by default (#12112)Andrew Morgan2022-03-012-2/+3
|
* Add `stop_cancellation` utility function (#12106)Sean Quah2022-03-013-0/+65
|
* Order in-flight state group queries in biggest-first order (#11610)reivilibre2022-03-013-4/+131
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Faster joins: persist to database (#12012)Richard van der Hoff2022-03-0112-32/+297
| | | | | | | | | | | | When we get a partial_state response from send_join, store information in the database about it: * store a record about the room as a whole having partial state, and stash the list of member servers too. * flag the join event itself as having partial state * also, for any new events whose prev-events are partial-stated, note that they will *also* be partial-stated. We don't yet make any attempt to interpret this data, so API calls (and a bunch of other things) are just going to get incorrect data.
* Advertise Python 3.10 support in setup.py (#12111)Andrew Morgan2022-03-012-0/+2
|
* Fix 'Unhandled error in Deferred' (#12089)Richard van der Hoff2022-03-013-37/+38
| | | | | | | | | | | | | * Fix 'Unhandled error in Deferred' Fixes a CRITICAL "Unhandled error in Deferred" log message which happened when a function wrapped with `@cachedList` failed * Minor optimisation to cachedListDescriptor we can avoid re-using `missing`, which saves looking up entries in `deferreds_map`, and means we don't need to copy it. * Improve type annotation on CachedListDescriptor
* Improve exception handling for concurrent execution (#12109)Richard van der Hoff2022-03-015-27/+151
| | | | | | | | | | | | | | | * fix incorrect unwrapFirstError import this was being imported from the wrong place * Refactor `concurrently_execute` to use `yieldable_gather_results` * Improve exception handling in `yieldable_gather_results` Try to avoid swallowing so many stack traces. * mark unwrapFirstError deprecated * changelog
* Add type hints to `tests/rest/client` (#12094)Dirk Klimpel2022-02-285-64/+72
| | | | | | | | | * Add type hints to `tests/rest/client` * update `mypy.ini` * newsfile * add `test_register.py`
* Remove the unstable `/spaces` endpoint. (#12073)Patrick Cloke2022-02-288-802/+46
| | | | | | | | ...and various code supporting it. The /spaces endpoint was from an old version of MSC2946 and included both a Client-Server and Server-Server API. Note that the unstable /hierarchy endpoint (from the final version of MSC2946) is not yet removed.
* Move experimental support for MSC3440 to /versions. (#12099)Patrick Cloke2022-02-283-3/+3
| | | | Instead of being part of /capabilities, this matches a change to MSC3440 to properly use these endpoints.
* Add type hints to `tests/rest/client` (#12084)Dirk Klimpel2022-02-2812-138/+198
|
* Fix `PushRuleEvaluator` and `Filter` to work on frozendicts (#12100)Richard van der Hoff2022-02-285-6/+27
| | | | | | | | | | * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.
* Actually fix bad debug logging rejecting device list & signing key ↵David Robertson2022-02-283-2/+21
| | | | transactions (#12098)
* Properly failover for unknown endpoints from Conduit/Dendrite. (#12077)Patrick Cloke2022-02-282-9/+14
| | | | | Before this fix, a legitimate 404 from a federation endpoint (e.g. due to an unknown room) would be treated as an unknown endpoint. This could cause unnecessary federation traffic.
* Replace assertEquals and friends with non-deprecated versions. (#12092)Patrick Cloke2022-02-2862-889/+888
|
* synctl: print warning if synctl_cache_factor is set in config (#11865)lukasdenk2022-02-282-0/+9
| | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Ensure that `get_datastores().main` is typed (#12070)Sean Quah2022-02-252-1/+3
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Minor typing fixes for `synapse/storage/persist_events.py` (#12069)Sean Quah2022-02-253-23/+26
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Add type hints to `tests/rest/client` (#12072)Dirk Klimpel2022-02-2411-102/+160
|
* Add support for MSC3202: sending one-time key counts and fallback key usage ↵reivilibre2022-02-2411-38/+528
| | | | | states to Application Services. (#11617) Co-authored-by: Erik Johnston <erik@matrix.org>
* Fix non-strings in the `event_search` table (#12037)Sean Quah2022-02-245-11/+173
| | | | | | | Don't attempt to add non-string `value`s to `event_search` and add a background update to clear out bad rows from `event_search` when using sqlite. Signed-off-by: Sean Quah <seanq@element.io>
* Add documentation for missing worker types. (#11599)Patrick Cloke2022-02-232-14/+77
| | | And clean-up the endpoints which should be routed to workers.
* Add logging to `/sync` for debugging #11916 (#12068)Erik Johnston2022-02-232-0/+10
|
* Add type hints to `tests/rest/client` (#12066)Dirk Klimpel2022-02-235-119/+149
|
* Remove more references to `get_datastore` (#12067)Richard van der Hoff2022-02-234-6/+6
| | | | | These have snuck in since #12031 was started. Also a couple of other cleanups while we're in the area.
* Remove `HomeServer.get_datastore()` (#12031)Richard van der Hoff2022-02-23230-500/+526
| | | | | | | The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733
* Rename default branch of complement.sh to main (#12063)Nicolas Werner2022-02-232-2/+3
| | | | | | | The complement.sh script relies on the name of the ref matching the name of the unpacked folder. The branch redirect from renaming the default branch breaks that assumption. Signed-off-by: Nicolas Werner <n.werner@famedly.com>
* Remove excess condition on `knock->leave` check (#11900)Travis Ralston2022-02-222-3/+4
|
* Better error message when failing to request from another process (#12060)Erik Johnston2022-02-222-1/+4
|
* Implement account status endpoints (MSC3720) (#12001)Brendan Abolivier2022-02-2211-6/+511
| | | | | See matrix-org/matrix-doc#3720 Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Prune setup.cfg some more (#12059)David Robertson2022-02-225-13/+14
| | | | | | | | | | * Remove `trial` section from setup.cfg This was added in the initial commit from 2014. I can't see that it does anything. Maybe it's there so that you can run `trial` without any extra args, but if I do that then I just get the `--help` message. * Move flake8's config to its own file
* Cap the number of in-flight requests for state from a single group (#11608)reivilibre2022-02-223-0/+86
|
* Use room version 9 as the default room version (per MSC3589). (#12058)Patrick Cloke2022-02-223-2/+3
|
* Run `_handle_queued_pdus` as a background process (#12041)Richard van der Hoff2022-02-222-2/+5
| | | ... to ensure it gets a proper log context, mostly.
* Fix slow performance of `/logout` in some cases where refresh tokens are in ↵reivilibre2022-02-224-4/+136
| | | | use. The slowness existed since the initial implementation of refresh tokens. (#12056)
* Merge remote-tracking branch 'origin/master' into developErik Johnston2022-02-223-3/+15
|\
| * Merge branch 'release-v1.53'Erik Johnston2022-02-22148-2262/+4213
| |\
| | * Update changelogErik Johnston2022-02-221-1/+1
| | |
| | * Update changelogErik Johnston2022-02-221-2/+2
| | |
| | * 1.53.0 v1.53.0Erik Johnston2022-02-223-1/+13
| | |
* | | Faster joins: Support for calling `/federation/v1/state` (#12013)Richard van der Hoff2022-02-227-17/+377
| | | | | | | | | | | | This is an endpoint that we have server-side support for, but no client-side support. It's going to be useful for resyncing partial-stated rooms, so let's introduce it.
* | | Fetch images when previewing Twitter URLs. (#11985)AndrewRyanChama2022-02-223-4/+11
| | | | | | | | | | | | By including "bot" in the User-Agent, which some sites use to decide whether to include additional Open Graph information.
* | | Merge remote-tracking branch 'origin/master' into developErik Johnston2022-02-222-2/+2
|\| |
| * | Recommend upgrading treq alongside twisted (#11943)Brendan Abolivier2022-02-092-2/+2
| | |
* | | Add more tests for in-flight state query duplication. (#12033)reivilibre2022-02-222-21/+172
| | |
* | | Tidy the building of sdists and wheels (#12051)David Robertson2022-02-223-28/+4
| | | | | | | | | | | | | | | * Don't build distribution pkgs in tests.yml * Run `release-artifacts` on release branches * Use backend-meta workflow for packaging
* | | Move isort config to `pyproject.toml` (#12052)David Robertson2022-02-224-12/+14
| | |
* | | Use v3 endpoints for fallback auth (Matrix 1.1) (#12019)Travis Ralston2022-02-222-4/+5
| | |
* | | remote join processing: get create event from state, not auth_chain (#12039)Richard van der Hoff2022-02-214-5/+8
| | | | | | | | | A follow-up to #12005, in which I apparently missed that there are a bunch of other places that assume the create event is in the auth chain.
* | | Minor typing fixes (#12034)Richard van der Hoff2022-02-214-16/+19
| | | | | | | | | | | | | | | | | | These started failing in https://github.com/matrix-org/synapse/pull/12031... I'm a bit mystified by how they ever worked.
* | | Add type hints to `synapse/storage/databases/main` (#11984)Dirk Klimpel2022-02-217-53/+79
| | |
* | | Advertise Matrix 1.2 in `/_matrix/client/versions` (#12022)Travis Ralston2022-02-212-0/+2
| | | | | | | | | Co-authored-by: Patrick Cloke <patrickc@matrix.org>
* | | Document why auth providers aren't validated in the admin API. (#12004)Patrick Cloke2022-02-184-2/+29
| | | | | | | | | | | | Since it is reasonable to give a future or past auth provider, which might not be in the current configuration.
* | | Track and deduplicate in-flight requests to `_get_state_for_groups`. (#10870)reivilibre2022-02-183-25/+312
| | | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Upgrade mypy to version 0.931 (#12030)Sean Quah2022-02-189-19/+33
| | | | | | | | | Upgrade mypy to 0.931, mypy-zope to 0.3.5 and fix new complaints.
* | | Fix bug in `StateFilter.return_expanded()` and add some tests. (#12016)reivilibre2022-02-183-1/+117
| | |
* | | Advertise Matrix 1.1 in `/_matrix/client/versions` (#12020)Travis Ralston2022-02-182-0/+2
| | |
* | | Use stable MSC3069 `is_guest` flag on `/whoami`. (#12021)Travis Ralston2022-02-183-3/+9
| | | | | | | | | Keeping backwards compatibility with the unstable flag for now.
* | | Fix 500 error with Postgres when looking backwards with the MSC3030 ↵Eric Eastwood2022-02-182-1/+2
| | | | | | | | | | | | `/timestamp_to_event` endpoint (#12024)
* | | Update the olddeps CI check to use an old version of markupsafe (#12025)Brendan Abolivier2022-02-182-0/+4
| | |
* | | Remove unstable MSC3283 flags (#12018)Erik Johnston2022-02-173-17/+1
| | | | | | | | | Fixes #11962
* | | Allow modules to set a display name on registration (#12009)Brendan Abolivier2022-02-176-34/+195
| | | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Faster joins: parse msc3706 fields in send_join response (#12011)Richard van der Hoff2022-02-176-33/+140
| | | | | | | | | Part of my work on #11249: add code to handle the new fields added in MSC3706.
* | | Configure `tox` to use `venv` (#12015)Richard van der Hoff2022-02-173-1/+9
| | | | | | | | | As the comment says, virtualenv is a pile of fail.
* | | Remove support for the legacy structured logging configuration. (#12008)Patrick Cloke2022-02-175-175/+24
| | |
* | | `send_join` response: get create event from `state`, not `auth_chain` (#12005)Richard van der Hoff2022-02-172-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | msc3706 proposes changing the `/send_join` response: > Any events returned within `state` can be omitted from `auth_chain`. Currently, we rely on `m.room.create` being returned in `auth_chain`, but since the `m.room.create` event must necessarily be part of the state, the above change will break this. In short, let's look for `m.room.create` in `state` rather than `auth_chain`.
* | | Prevent duplicate push notifications for room reads (#11835)lukasdenk2022-02-173-66/+71
| | |
* | | Explain the meaning of spam checker callbacks' return values (#12003)David Robertson2022-02-162-13/+28
| | | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Fix a typo in a comment.Patrick Cloke2022-02-161-1/+1
| | |
* | | Limit concurrent AS joins (#11996)Brendan Abolivier2022-02-162-19/+28
| | | | | | | | | | | | | | | | | | | | | Initially introduced in matrix-org-hotfixes by e5537cf (and tweaked by later commits). Fixes #11995 See also #4826
* | | Optimise calculating device_list changes in `/sync`. (#11974)Erik Johnston2022-02-154-15/+126
| | | | | | | | | | | | | | | | | | For users with large accounts it is inefficient to calculate the set of users they share a room with (and takes a lot of space in the cache). Instead we can look at users whose devices have changed since the last sync and check if they share a room with the syncing user.
* | | `_auth_and_persist_outliers`: drop events we have already seen (#11994)Richard van der Hoff2022-02-152-24/+21
| | | | | | | | | | | | | | | We already have two copies of this code, in 2/3 of the callers of `_auth_and_persist_outliers`. Before I add a third, let's push it down.
* | | Track cache invalidations (#12000)Erik Johnston2022-02-154-1/+10
| | | | | | | | | Currently we only track evictions due to size or time constraints.
* | | Fix incorrect `get_rooms_for_user` for remote user (#11999)Erik Johnston2022-02-153-11/+124
| | | | | | | | | | | | | | | | | | | | | When the server leaves a room the `get_rooms_for_user` cache is not correctly invalidated for the remote users in the room. This means that subsequent calls to `get_rooms_for_user` for the remote users would incorrectly include the room (it shouldn't be included because the server no longer knows anything about the room).
* | | Docker: remove `VOLUME` directive (#11997)Richard van der Hoff2022-02-152-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The driver for this is to stop Complement complaining about it, but as far as I can tell it was pointless and needed to go away anyway. I'm a bit unclear about what exactly VOLUME does, but I think what it means is that, if you don't override it with an explicit -v argument, then docker run will create a temporary volume, and copy things into it. The temporary volume is then deleted when the container finishes. That only sounds useful if your image has something to copy into it (otherwise you may as well just use the default root filesystem), and our image notably doesn't copy anything into /data. So... this wasn't doing anything, except annoying Complement?
* | | Refactor search code to reduce function size. (#11991)Patrick Cloke2022-02-153-226/+435
| | | | | | | | | | | | | | | | | | | | | | | | | | | Splits the search code into a few logical functions instead of a single unreadable function. There are also a few additional changes for readability. After refactoring it was clear to see there were some unused and unnecessary variables, which were simplified.
* | | Fix incorrect thread summaries when the latest event is edited. (#11992)Patrick Cloke2022-02-155-31/+107
| | | | | | | | | | | | | | | If the latest event in a thread was edited than the original event content was included in bundled aggregation for threads instead of the edited event content.
* | | Merge tag 'v1.53.0rc1' into developSean Quah2022-02-1560-58/+86
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.53.0rc1 (2022-02-15) ============================== Features -------- - Add experimental support for sending to-device messages to application services, as specified by [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409). ([\#11215](https://github.com/matrix-org/synapse/issues/11215), [\#11966](https://github.com/matrix-org/synapse/issues/11966)) - Remove account data (including client config, push rules and ignored users) upon user deactivation. ([\#11655](https://github.com/matrix-org/synapse/issues/11655)) - Experimental support for [MSC3666](https://github.com/matrix-org/matrix-doc/pull/3666): including bundled aggregations in server side search results. ([\#11837](https://github.com/matrix-org/synapse/issues/11837)) - Enable cache time-based expiry by default. The `expiry_time` config flag has been superseded by `expire_caches` and `cache_entry_ttl`. ([\#11849](https://github.com/matrix-org/synapse/issues/11849)) - Add a callback to allow modules to allow or forbid a 3PID (email address, phone number) from being associated to a local account. ([\#11854](https://github.com/matrix-org/synapse/issues/11854)) - Stabilize support and remove unstable endpoints for [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). Clients must switch to the stable identifier and endpoint. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#stablisation-of-msc3231) for more information. ([\#11867](https://github.com/matrix-org/synapse/issues/11867)) - Allow modules to retrieve the current instance's server name and worker name. ([\#11868](https://github.com/matrix-org/synapse/issues/11868)) - Use a dedicated configurable rate limiter for 3PID invites. ([\#11892](https://github.com/matrix-org/synapse/issues/11892)) - Support the stable API endpoint for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283): new settings in `/capabilities` endpoint. ([\#11933](https://github.com/matrix-org/synapse/issues/11933), [\#11989](https://github.com/matrix-org/synapse/issues/11989)) - Support the `dir` parameter on the `/relations` endpoint, per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#11941](https://github.com/matrix-org/synapse/issues/11941)) - Experimental implementation of [MSC3706](https://github.com/matrix-org/matrix-doc/pull/3706): extensions to `/send_join` to support reduced response size. ([\#11967](https://github.com/matrix-org/synapse/issues/11967)) Bugfixes -------- - Fix [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) historical messages backfilling in random order on remote homeservers. ([\#11114](https://github.com/matrix-org/synapse/issues/11114)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#11890](https://github.com/matrix-org/synapse/issues/11890)) - Fix a long-standing bug where some unknown endpoints would return HTML error pages instead of JSON `M_UNRECOGNIZED` errors. ([\#11930](https://github.com/matrix-org/synapse/issues/11930)) - Implement an allow list of content types for which we will attempt to preview a URL. This prevents Synapse from making useless longer-lived connections to streaming media servers. ([\#11936](https://github.com/matrix-org/synapse/issues/11936)) - Fix a long-standing bug where pagination tokens from `/sync` and `/messages` could not be provided to the `/relations` API. ([\#11952](https://github.com/matrix-org/synapse/issues/11952)) - Require that modules register their callbacks using keyword arguments. ([\#11975](https://github.com/matrix-org/synapse/issues/11975)) - Fix a long-standing bug where `M_WRONG_ROOM_KEYS_VERSION` errors would not include the specced `current_version` field. ([\#11988](https://github.com/matrix-org/synapse/issues/11988)) Improved Documentation ---------------------- - Fix typo in User Admin API: unpind -> unbind. ([\#11859](https://github.com/matrix-org/synapse/issues/11859)) - Document images returned by the User List Media Admin API can include those generated by URL previews. ([\#11862](https://github.com/matrix-org/synapse/issues/11862)) - Remove outdated MSC1711 FAQ document. ([\#11907](https://github.com/matrix-org/synapse/issues/11907)) - Correct the structured logging configuration example. Contributed by Brad Jones. ([\#11946](https://github.com/matrix-org/synapse/issues/11946)) - Add information on the Synapse release cycle. ([\#11954](https://github.com/matrix-org/synapse/issues/11954)) - Fix broken link in the README to the admin API for password reset. ([\#11955](https://github.com/matrix-org/synapse/issues/11955)) Deprecations and Removals ------------------------- - Drop support for `webclient` listeners and configuring `web_client_location` to a non-HTTP(S) URL. Deprecated configurations are a configuration error. ([\#11895](https://github.com/matrix-org/synapse/issues/11895)) - Remove deprecated `user_may_create_room_with_invites` spam checker callback. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html#removal-of-user_may_create_room_with_invites) for more information. ([\#11950](https://github.com/matrix-org/synapse/issues/11950)) - No longer build `.deb` packages for Ubuntu 21.04 Hirsute Hippo, which has now EOLed. ([\#11961](https://github.com/matrix-org/synapse/issues/11961)) Internal Changes ---------------- - Enhance user registration test helpers to make them more useful for tests involving application services and devices. ([\#11615](https://github.com/matrix-org/synapse/issues/11615), [\#11616](https://github.com/matrix-org/synapse/issues/11616)) - Improve performance when fetching bundled aggregations for multiple events. ([\#11660](https://github.com/matrix-org/synapse/issues/11660), [\#11752](https://github.com/matrix-org/synapse/issues/11752)) - Fix type errors introduced by new annotations in the Prometheus Client library. ([\#11832](https://github.com/matrix-org/synapse/issues/11832)) - Add missing type hints to replication code. ([\#11856](https://github.com/matrix-org/synapse/issues/11856), [\#11938](https://github.com/matrix-org/synapse/issues/11938)) - Ensure that `opentracing` scopes are activated and closed at the right time. ([\#11869](https://github.com/matrix-org/synapse/issues/11869)) - Improve opentracing for incoming federation requests. ([\#11870](https://github.com/matrix-org/synapse/issues/11870)) - Improve internal docstrings in `synapse.util.caches`. ([\#11876](https://github.com/matrix-org/synapse/issues/11876)) - Do not needlessly clear the `get_users_in_room` and `get_users_in_room_with_profiles` caches when any room state changes. ([\#11878](https://github.com/matrix-org/synapse/issues/11878)) - Convert `ApplicationServiceTestCase` to use `simple_async_mock`. ([\#11880](https://github.com/matrix-org/synapse/issues/11880)) - Remove experimental changes to the default push rules which were introduced in Synapse 1.19.0 but never enabled. ([\#11884](https://github.com/matrix-org/synapse/issues/11884)) - Disable coverage calculation for olddeps build. ([\#11888](https://github.com/matrix-org/synapse/issues/11888)) - Preparation to support sending device list updates to application services. ([\#11905](https://github.com/matrix-org/synapse/issues/11905)) - Add a test that checks users receive their own device list updates down `/sync`. ([\#11909](https://github.com/matrix-org/synapse/issues/11909)) - Run Complement tests sequentially. ([\#11910](https://github.com/matrix-org/synapse/issues/11910)) - Various refactors to the application service notifier code. ([\#11911](https://github.com/matrix-org/synapse/issues/11911), [\#11912](https://github.com/matrix-org/synapse/issues/11912)) - Tests: replace mocked `Authenticator` with the real thing. ([\#11913](https://github.com/matrix-org/synapse/issues/11913)) - Various refactors to the typing notifications code. ([\#11914](https://github.com/matrix-org/synapse/issues/11914)) - Use the proper type for the `Content-Length` header in the `UploadResource`. ([\#11927](https://github.com/matrix-org/synapse/issues/11927)) - Remove an unnecessary ignoring of type hints due to fixes in upstream packages. ([\#11939](https://github.com/matrix-org/synapse/issues/11939)) - Add missing type hints. ([\#11953](https://github.com/matrix-org/synapse/issues/11953)) - Fix an import cycle in `synapse.event_auth`. ([\#11965](https://github.com/matrix-org/synapse/issues/11965)) - Unpin `frozendict` but exclude the known bad version 2.1.2. ([\#11969](https://github.com/matrix-org/synapse/issues/11969)) - Prepare for rename of default Complement branch. ([\#11971](https://github.com/matrix-org/synapse/issues/11971)) - Fetch Synapse's version using a helper from `matrix-common`. ([\#11979](https://github.com/matrix-org/synapse/issues/11979))
| * | Update CHANGES.md v1.53.0rc1Sean Quah2022-02-151-7/+7
| | |
| * | 1.53.0rc1Sean Quah2022-02-1560-58/+86
| | |
* | | Add some tests for propagation of device list changes between local users ↵Andrew Morgan2022-02-154-3/+163
|/ / | | | | | | (#11972)
* | Revert "Pin to frozendict<2.1.2 (#11625)" and allow frozendict>2.1.2 (#11969)Pascal Bach2022-02-142-1/+2
| | | | | | | | | | This reverts commit 2bf31f7807c7a0c229170803c97090d612dc16f9. Signed-off-by: Pascal Bach <pascal.bach@nextrem.ch>
* | Fix M_WRONG_ROOM_KEYS_VERSION error not including `current_version` field ↵Michael Telatynski2022-02-142-0/+4
| | | | | | | | | | (#11988) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
* | Note when unstable MSC3283 prefixes will be removed (#11989)Andrew Morgan2022-02-142-1/+2
| |
* | remove empty file, reword/rename newsfragment, and add line to upgrade docH. Shay2022-02-144-1/+2
| |
* | Require that modules register their callbacks using keyword arguments. (#11975)Patrick Cloke2022-02-142-0/+7
| | | | | | | | To allow for easier backwards/forwards compatibility by making it easier to add/remove callbacks.
* | Use version string helper from matrix-common (#11979)David Robertson2022-02-1413-112/+42
| | | | | | | | * Require latest matrix-common * Use the common function
* | Notify users, rather than rooms, of device list updates (#11905)Andrew Morgan2022-02-122-5/+4
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Implement MSC3706: partial state in `/send_join` response (#11967)Richard van der Hoff2022-02-127-21/+262
| | | | | | | | | | | | | | | | | | | | | | | | * Make `get_auth_chain_ids` return a Set It has a set internally, and a set is often useful where it gets used, so let's avoid converting to an intermediate list. * Minor refactors in `on_send_join_request` A little bit of non-functional groundwork * Implement MSC3706: partial state in /send_join response
* | Enable cache time-based expiry by default (#11849)Shay2022-02-115-11/+50
| |
* | Support the MSC3715 for `/relations`. (#11941)Patrick Cloke2022-02-113-6/+36
| | | | | | | | This adds an unstable org.matrix.msc3715.dir parameter which acts like dir on /mesages.
* | Fetch thread summaries for multiple events in a single query (#11752)Patrick Cloke2022-02-113-74/+151
| | | | | | | | | | This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.
* | Prepare for rename of default complement branch (#11971)Richard van der Hoff2022-02-112-3/+4
| | | | | | use `HEAD` rather than hardcoding `master`
* | Remove deprecated user_may_create_room_with_invites callback (#11950)Brendan Abolivier2022-02-116-179/+22
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix NewsfileErik Johnston2022-02-111-0/+1
| | | | | | | | | | \#11966 fixes a bug introduced by #11215, which isn't in a released version.
* | Fix NewsfileErik Johnston2022-02-111-1/+0
| | | | | | | | | | \#11966 fixes a bug introduced by #11215, which isn't in a released version.
* | Fix to-device being dropped in limited sync in SQLite. (#11966)Erik Johnston2022-02-113-1/+45
| | | | | | | | | | | | | | | | | | If ther are more than 100 to-device messages pending for a device `/sync` will only return the first 100, however the next batch token was incorrectly calculated and so all other pending messages would be dropped. This is due to `txn.rowcount` only returning the number of rows that *changed*, rather than the number *selected* in SQLite.
* | fix import cycle (#11965)Richard van der Hoff2022-02-112-23/+32
| |
* | Adds misc missing type hints (#11953)Patrick Cloke2022-02-119-41/+48
| |
* | Tests: replace mocked Authenticator with the real thing (#11913)Richard van der Hoff2022-02-117-44/+117
| | | | | | | | | | | | | | | | | | | | | | | | If we prepopulate the test homeserver with a key for a remote homeserver, we can make federation requests to it without having to stub out the authenticator. This has two advantages: * means that what we are testing is closer to reality (ie, we now have complete tests for the incoming-request-authorisation flow) * some tests require that other objects be signed by the remote server (eg, the event in `/send_join`), and doing that would require a whole separate set of mocking out. It's much simpler just to use real keys.
* | Support the stable API endpoint for MSC3283: new settings in `/capabilities` ↵Dirk Klimpel2022-02-114-49/+55
| | | | | | | | endpoint (#11933)
* | Drop support for EOL Ubuntu 21.04 (#11961)Shay2022-02-102-1/+1
| |
* | Support pagination tokens from /sync and /messages in the relations API. ↵Patrick Cloke2022-02-105-53/+217
| | | | | | | | (#11952)
* | Implement a content type allow list for URL previews (#11936)Denis Kasak2022-02-104-0/+99
| | | | | | | | | | | | | | This implements an allow list for content types for which Synapse will attempt URL preview. If a URL resolves to a resource with a content type which isn't in the list, the download will terminate immediately. This makes sense given that Synapse would never successfully generate a URL preview for such files in the first place, and helps prevent issues with streaming media servers, such as #8302. Signed-off-by: Denis Kasak dkasak@termina.org.uk
* | Fix broken link in README to admin API. (#11955)Alexander Mnich2022-02-102-1/+2
| | | | | | From when the documentation was converted from rst -> md.
* | Basic documentation for the release cycle. (#11954)Patrick Cloke2022-02-103-0/+39
| |
* | Fix example for structured logging. (#11946)Brad Jones2022-02-092-1/+2
| | | | | | The StreamHandler takes a stream parameter, not location.
* | Update changelog from #11867 to be a single line.Patrick Cloke2022-02-091-5/+1
| |
* | Add missing type hints to synapse.replication. (#11938)Patrick Cloke2022-02-0819-147/+209
| |
* | Experimental support to include bundled aggregations in search results ↵Patrick Cloke2022-02-085-8/+76
| | | | | | | | (MSC3666) (#11837)
* | Remove unnecessary ignores due to Twisted upgrade. (#11939)Patrick Cloke2022-02-084-4/+5
| | | | | | | | Twisted 22.1.0 fixed some internal type hints, allowing Synapse to remove ignore calls for parameters to connectTCP.
* | Merge branch 'master' into developBrendan Abolivier2022-02-084-2/+34
|\|
| * Merge branch 'release-v1.52'Brendan Abolivier2022-02-08102-814/+2743
| |\
| | * Fix wordingBrendan Abolivier2022-02-082-12/+14
| | |
| | * Add words about the Twisted security fix v1.52.0Brendan Abolivier2022-02-082-2/+20
| | |
| | * 1.52.0Brendan Abolivier2022-02-083-1/+13
| | |
* | | Add missing type hints to synapse.replication.http. (#11856)Patrick Cloke2022-02-0813-162/+258
| | |
* | | Fetch edits for multiple events in a single query. (#11660)Patrick Cloke2022-02-083-54/+101
| | | | | | | | | | | | | | | This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.
* | | Return JSON errors for unknown resources under /matrix/client. (#11930)Patrick Cloke2022-02-082-7/+3
| | | | | | | | | | | | | | | Re-applies the changes from 3e0cfd447e17658a937fe62555db9e968f00b15b (#11602), reverting d93ec0a0ba5f6d2fbf2bc321086d4ad4c03136e0 (#11764) now that the conflict with the webclient listener was fixed in 119edf51eb3e4f5ed5139dc370f5d7aed46edc1c (#11895).
* | | Add a docstring to `add_device_change_to_streams` and fix some nearby types ↵Andrew Morgan2022-02-082-6/+17
| | | | | | | | | | | | (#11912)
* | | Add a callback to allow modules to deny 3PID (#11854)Brendan Abolivier2022-02-088-7/+161
| | | | | | | | | | | | | | | Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.
* | | Fix historical messages backfilling in random order on remote homeservers ↵Eric Eastwood2022-02-079-149/+342
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (MSC2716) (#11114) Fix https://github.com/matrix-org/synapse/issues/11091 Fix https://github.com/matrix-org/synapse/issues/10764 (side-stepping the issue because we no longer have to deal with `fake_prev_event_id`) 1. Made the `/backfill` response return messages in `(depth, stream_ordering)` order (previously only sorted by `depth`) - Technically, it shouldn't really matter how `/backfill` returns things but I'm just trying to make the `stream_ordering` a little more consistent from the origin to the remote homeservers in order to get the order of messages from `/messages` consistent ([sorted by `(topological_ordering, stream_ordering)`](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)). - Even now that we return backfilled messages in order, it still doesn't guarantee the same `stream_ordering` (and more importantly the [`/messages` order](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)) on the other server. For example, if a room has a bunch of history imported and someone visits a permalink to a historical message back in time, their homeserver will skip over the historical messages in between and insert the permalink as the next message in the `stream_order` and totally throw off the sort. - This will be even more the case when we add the [MSC3030 jump to date API endpoint](https://github.com/matrix-org/matrix-doc/pull/3030) so the static archives can navigate and jump to a certain date. - We're solving this in the future by switching to [online topological ordering](https://github.com/matrix-org/gomatrixserverlib/issues/187) and [chunking](https://github.com/matrix-org/synapse/issues/3785) which by its nature will apply retroactively to fix any inconsistencies introduced by people permalinking 2. As we're navigating `prev_events` to return in `/backfill`, we order by `depth` first (newest -> oldest) and now also tie-break based on the `stream_ordering` (newest -> oldest). This is technically important because MSC2716 inserts a bunch of historical messages at the same `depth` so it's best to be prescriptive about which ones we should process first. In reality, I think the code already looped over the historical messages as expected because the database is already in order. 3. Making the historical state chain and historical event chain float on their own by having no `prev_events` instead of a fake `prev_event` which caused backfill to get clogged with an unresolvable event. Fixes https://github.com/matrix-org/synapse/issues/11091 and https://github.com/matrix-org/synapse/issues/10764 4. We no longer find connected insertion events by finding a potential `prev_event` connection to the current event we're iterating over. We now solely rely on marker events which when processed, add the insertion event as an extremity and the federating homeserver can ask about it when time calls. - Related discussion, https://github.com/matrix-org/synapse/pull/11114#discussion_r741514793 Before | After --- | --- ![](https://user-images.githubusercontent.com/558581/139218681-b465c862-5c49-4702-a59e-466733b0cf45.png) | ![](https://user-images.githubusercontent.com/558581/146453159-a1609e0a-8324-439d-ae44-e4bce43ac6d1.png) #### Why aren't we sorting topologically when receiving backfill events? > The main reason we're going to opt to not sort topologically when receiving backfill events is because it's probably best to do whatever is easiest to make it just work. People will probably have opinions once they look at [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) which could change whatever implementation anyway. > > As mentioned, ideally we would do this but code necessary to make the fake edges but it gets confusing and gives an impression of “just whyyyy” (feels icky). This problem also dissolves with online topological ordering. > > -- https://github.com/matrix-org/synapse/pull/11114#discussion_r741517138 See https://github.com/matrix-org/synapse/pull/11114#discussion_r739610091 for the technical difficulties
* | | Remove optional state of `ApplicationService.is_interested`'s `store` ↵Andrew Morgan2022-02-074-25/+39
| | | | | | | | | | | | parameter (#11911)
* | | Pass the proper type when uploading files. (#11927)Patrick Cloke2022-02-072-4/+10
| | | | | | | | | | | | The Content-Length header should be treated as an int, not a string. This shouldn't have any user-facing change.
* | | Clean up an indirect reference to the homeserver datastore (#11914)Andrew Morgan2022-02-072-2/+3
| | |
* | | Add a unit test for users receiving their own device list updates (#11909)Andrew Morgan2022-02-072-1/+57
| | |
* | | Clarify that users' media are also preview images (#11862)Dirk Klimpel2022-02-043-1/+12
| | |
* | | Run Complement tests sequentially (#11910)kegsay2022-02-042-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #11811 there has been general Complement flakiness around networking. It seems like tests are hitting the wrong containers. In an effort to diagnose the cause of this, as well as reduce its impact on this project, set the parallelsim to 1 (no parallelism) when running tests. If this fixes the flakiness then this indicates the cause and I can diagnose this further. If this doesn't fix the flakiness then that implies some kind of test pollution which also helps to diagnose this further.
* | | Stabilise MSC3231 (Token Based Registration) (#11867)Jonathan de Jong2022-02-048-9/+28
| | |
* | | Delete MSC1711_certificates_FAQ.md (#11907)Richard van der Hoff2022-02-044-321/+3
| | | | | | | | | This document isn't really relevant any more, and its existence is more confusing than helpful.
* | | Merge remote-tracking branch 'origin/master' into developRichard van der Hoff2022-02-040-0/+0
|\| |
| * | Use changelog from developDavid Robertson2022-01-251-9/+11
| | | | | | | | | | | | | | | | | | It had already accounted for 1.50.2 (ordered chronologically rather than sem-ver-ically); it just seems this wasn't merged into master when we released 1.50.2.
* | | Remove support for the webclient listener. (#11895)Patrick Cloke2022-02-036-176/+29
| | | | | | | | | Also remove support for non-HTTP(S) web_client_location.
* | | Fix typo: unpind -> unbind (#11859)Christian Paul2022-02-032-1/+2
| | | | | | | | | Co-authored-by: reivilibre <olivier@librepush.net>
* | | Add a ratelimiter for 3pid invite (#11892)Brendan Abolivier2022-02-034-1/+31
| | |
* | | Allow specifying the application service-specific `user_id` parameter in the ↵reivilibre2022-02-033-6/+28
| | | | | | | | | | | | `join` test helper. (#11616)
* | | Improve opentracing for federation requests (#11870)Richard van der Hoff2022-02-033-19/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | The idea here is to set the parent span for incoming federation requests to the *outgoing* span on the other end. That means that you can see (most of) the full end-to-end flow when you have a process that includes federation requests. However, in order not to lose information, we still want a link to the `incoming-federation-request` span from the servlet, so we have to create another span to do exactly that.
* | | Fixes for opentracing scopes (#11869)Richard van der Hoff2022-02-024-35/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `start_active_span` was inconsistent as to whether it would activate the span immediately, or wait for `scope.__enter__` to happen (it depended on whether the current logcontext already had an associated scope). The inconsistency was rather confusing if you were hoping to set up a couple of separate spans before activating either. Looking at the other implementations of opentracing `ScopeManager`s, the intention is that it *should* be activated immediately, as the name implies. Indeed, the idea is that you don't have to use the scope as a contextmanager at all - you can just call `.close` on the result. Hence, our cleanup has to happen in `.close` rather than `.__exit__`. So, the main change here is to ensure that `start_active_span` does activate the span, and that `scope.close()` does close the scope. We also add some tests, which requires a `tracer` param so that we don't have to rely on the global variable in unit tests.
* | | Invalidate the get_users_in_room{_with_profile} caches only when necessary. ↵Patrick Cloke2022-02-023-8/+20
| | | | | | | | | | | | | | | | | | | | | (#11878) The get_users_in_room and get_users_in_room_with_profiles are now only invalidated when the membership of a room changes, instead of during any state change in the room.
* | | Fix type errors introduced by new annotations in the Prometheus Client ↵reivilibre2022-02-023-3/+11
| | | | | | | | | | | | | | | library. (#11832) Co-authored-by: David Robertson <davidr@element.io>
* | | Fix losing incoming EDUs if debug logging enabled (#11890)David Robertson2022-02-022-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix losing incoming EDUs if debug logging enabled Fixes #11889. Homeservers should only be affected if the `synapse.8631_debug` logger was enabled for DEBUG mode. I am not sure if this merits a bugfix release: I think the logging can be disabled in config if anyone is affected? But it is still pretty bad.
* | | Disable coverage calculation for olddeps build. (#11888)Richard van der Hoff2022-02-022-1/+2
| | | | | | | | | | | | We disabled coverage calculation for most of CI in #11017, but the olddeps build uses a separate script and got forgotten.
* | | Describe `prune_unread_entries` in docstrings (#11876)David Robertson2022-02-024-2/+18
| | | | | | | | | Should have been caught in #10826.
* | | Revert experimental push rules from #7997. (#11884)Patrick Cloke2022-02-025-252/+14
| | | | | | | | | Manually reverts the merge from cdbb8e6d6e36e0b6bc36e676d8fe66c96986b399.
* | | Add a background database update to purge account data for deactivated ↵reivilibre2022-02-025-55/+240
| | | | | | | | | | | | users. (#11655)
* | | Expose the registered device ID from the `register_appservice_user` test ↵reivilibre2022-02-025-8/+14
| | | | | | | | | | | | helper. (#11615)
* | | Convert `ApplicationServiceTestCase` to use `simple_async_mock` (#11880)Andrew Morgan2022-02-012-10/+10
| | |
* | | Allow modules to retrieve server and worker names (#11868)Brendan Abolivier2022-02-012-0/+27
| | | | | | | | | Fixes #10701
* | | Send to-device messages to application services (#11215)Andrew Morgan2022-02-0114-162/+856
| |/ |/| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Don't mention 3.6 EOL under misc v1.52.0rc1David Robertson2022-02-011-2/+1
| | | | | | It's already under deps & removals
* | 1.52.0rc1David Robertson2022-02-0140-38/+68
| |
* | Add type hints to `tests/rest/admin` (#11851)Dirk Klimpel2022-01-315-232/+184
| |
* | Consolidate the `access_token` information in the admin api (#11861)Dirk Klimpel2022-01-3110-95/+30
| | | | | | Co-authored-by: reivilibre <olivier@librepush.net>
* | Remove the obsolete MSC1849 configuration flag. (#11843)Patrick Cloke2022-01-313-6/+1
| | | | | | | | | | MSC1849 was replaced by MSC2675, which was merged. The configuration flag, which defaulted to true, is no longer useful.
* | Remove not needed old table of contents in documentation (#11860)Dirk Klimpel2022-01-314-53/+1
| |
* | Configurable limits on avatars (#11846)Brendan Abolivier2022-01-287-2/+363
| | | | | | | | | | | | Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from matrix-org/synapse-dinsic#19
* | Pass `isolation_level` to `runWithConnection` (#11847)Brendan Abolivier2022-01-272-0/+2
| | | | | | This was missed in https://github.com/matrix-org/synapse/pull/11799
* | Create singletons for `StateFilter.{all,none}()` (#11836)Richard van der Hoff2022-01-272-5/+10
| | | | | | No point recreating these for each call, since they are frozen
* | Fix some indentation inconsistencies in the sample config (modules) (#11838)Dirk Klimpel2022-01-273-10/+11
| |
* | Update installation docs to indicate that we support Python 3.10 (#11820)Shay2022-01-262-1/+2
| |
* | Include `prev_content` field in AS events (#11798)Vaishnav Nair2022-01-262-1/+2
| | | | | | | | | | | | * Include 'prev_content' field in AS events Signed-off-by: Vaishnav Nair <nairvaishnav007@icloud.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Add a module callback to set username at registration (#11790)Brendan Abolivier2022-01-266-3/+231
| | | | | | | | | | | | This is in the context of mainlining the Tchap fork of Synapse. Currently in Tchap usernames are derived from the user's email address (extracted from the UIA results, more specifically the m.login.email.identity step). This change also exports the check_username method from the registration handler as part of the module API, so that a module can check if the username it's trying to generate is correct and doesn't conflict with an existing one, and fallback gracefully if not. Co-authored-by: David Robertson <davidr@element.io>
* | Improvements to bundling aggregations. (#11815)Patrick Cloke2022-01-2612-139/+212
| | | | | | | | | | | | | | | | | | | | | | This is some odds and ends found during the review of #11791 and while continuing to work in this code: * Return attrs classes instead of dictionaries from some methods to improve type safety. * Call `get_bundled_aggregations` fewer times. * Adds a missing assertion in the tests. * Do not return empty bundled aggregations for an event (preferring to not include the bundle at all, as the docstring states).
* | Don't print HTTPStatus.* in "Processed..." logs (#11827)David Robertson2022-01-262-1/+5
| | | | | | | | | | | | | | | | | | * Don't print HTTPStatus.* in "Processed..." logs Fixes #11812. See also #7118 and https://github.com/matrix-org/synapse/pull/7188#r401719326 in particular. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Avoid type annotation problems in prom-client (#11834)David Robertson2022-01-262-1/+3
| |
* | Add a config flag to inhibit `M_USER_IN_USE` during registration (#11743)Brendan Abolivier2022-01-266-12/+89
| | | | | | | | | | | | | | This is mostly motivated by the tchap use case, where usernames are automatically generated from the user's email address (in a way that allows figuring out the email address from the username). Therefore, it's an issue if we respond to requests on /register and /register/available with M_USER_IN_USE, because it can potentially leak email addresses (which include the user's real name and place of work). This commit adds a flag to inhibit the M_USER_IN_USE errors that are raised both by /register/available, and when providing a username early into the registration process. This error will still be raised if the user completes the registration process but the username conflicts. This is particularly useful when using modules (https://github.com/matrix-org/synapse/pull/11790 adds a module callback to set the username of users at registration) or SSO, since they can ensure the username is unique. More context is available in the PR that introduced this behaviour to synapse-dinsic: matrix-org/synapse-dinsic#48 - as well as the issue in the matrix-dinsic repo: matrix-org/matrix-dinsic#476
* | Fix another jsonschema typecheck error (#11830)David Robertson2022-01-253-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similar to #11817. In `_create_power_level_validator` we - retrieve `validator`. This is a class implementing the `jsonschema.protocols.Validator` interface. In other words, `validator: Type[jsonschema.protocols.Validator]`. - we then create an second validator class by modifying the original `validator`. We return that class, which is also of type `Type[jsonschema.protocols.Validator]`. So the original annotation was incorrect: it claimed we were returning an instance of jsonSchema.Draft7Validator, not the class (or a subclass) itself. (Strictly speaking this is incorrect, because `POWER_LEVELS_SCHEMA` isn't pinned to a particular version of JSON Schema. But there are other complications with the type stubs if you try to fix this; I felt like the change herein was a decent compromise that better expresses intent). (I suspect/hope the typeshed project would welcome an effort to improve the jsonschema stubs. Let's see if I get some spare time.)
* | Check that `gc` method is available before using in `synapse/app/_base` ↵Shay2022-01-252-6/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#11816) * add check that gc.freeze is available before calling * newsfragment * lint * Update comment Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Dan Callahan <danc@element.io>
* | Add admin API to get a list of federated rooms (#11658)Dirk Klimpel2022-01-256-25/+444
| |
* | CI: run Complement on the VM, not inside Docker (#11811)kegsay2022-01-252-10/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * CI: run Complement on the VM, not inside Docker This requires https://github.com/matrix-org/complement/pull/289 We now run Complement on the VM instead of inside a Docker container. This is to allow Complement to bind to any high-numbered port when it starts up its own federation servers. We want to do this to allow for more concurrency when running complement tests. Previously, Complement only ever bound to `:8448` when running its own federation server. This prevented multiple federation tests running at the same time as they would fight each other on the port. This did however allow Complement to run in Docker, as the host could just port forward `:8448` to allow homeserver containers to communicate to Complement. Now that we are using random ports however, we cannot use Docker to run Complement. This ends up being a good thing because: - Running Complement tests locally is closer to how they run in CI. - Allows the `CI` env var to be removed in Complement. - Slightly speeds up runs as we don't need to pull down the Complement image prior to running tests. This assumes GHA caches actions sensibly. * Changelog * Full stop * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Review comments * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Log modules at startup (#11813)Brendan Abolivier2022-01-252-1/+3
| |
* | Db txn set isolation level (#11799)Nick Barrett2022-01-255-5/+61
| | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Minor updates, and docs, for schema delta files (#11823)Richard van der Hoff2022-01-253-3/+61
| | | | | | | | | | | | | | | | | | * Make functions in python deltas optional It's annoying to always have to write stubs for these. * Documentation for delta files * changelog
* | Docs: add missing PR submission process how-tos (#11821)Forest Johnson2022-01-252-1/+3
| | | | | | | | | | | | | | * Docs: add missing PR submission process how-tos The documentation says that in order to submit a pull request you have to run the linter and links to [Run the linters](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#run-the-linters). IMO "Run the linters" should explain that development dependencies are a pre-requisite. I also included `pip install wheel` which I had to run inside my virtual environment on ubuntu before I `pip install -e ".[all,dev]"` would succeed.
* | Merge branch 'master' into developDavid Robertson2022-01-253-2/+21
|\|
| * Merge branch 'release-v1.51'David Robertson2022-01-251-1/+1
| |\
| | * Point to upgrade notes in changelogDavid Robertson2022-01-251-1/+1
| | |
| * | Merge tag 'v1.51.0'David Robertson2022-01-25135-1646/+2592
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.51.0 (2022-01-25) =========================== No significant changes since 1.51.0rc2. Synapse 1.51.0 deprecates `webclient` listeners and non-HTTP(S) `web_client_location`s. Support for these will be removed in Synapse 1.53.0, at which point Synapse will not be capable of directly serving a web client for Matrix. Synapse 1.51.0rc2 (2022-01-24) ============================== Bugfixes -------- - Fix a bug introduced in Synapse 1.40.0 that caused Synapse to fail to process incoming federation traffic after handling a large amount of events in a v1 room. ([\#11806](https://github.com/matrix-org/synapse/issues/11806)) Synapse 1.51.0rc1 (2022-01-21) ============================== Features -------- - Add `track_puppeted_user_ips` config flag to record client IP addresses against puppeted users, and include the puppeted users in monthly active user counts. ([\#11561](https://github.com/matrix-org/synapse/issues/11561), [\#11749](https://github.com/matrix-org/synapse/issues/11749), [\#11757](https://github.com/matrix-org/synapse/issues/11757)) - Include whether the requesting user has participated in a thread when generating a summary for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440). ([\#11577](https://github.com/matrix-org/synapse/issues/11577)) - Return an `M_FORBIDDEN` error code instead of `M_UNKNOWN` when a spam checker module prevents a user from creating a room. ([\#11672](https://github.com/matrix-org/synapse/issues/11672)) - Add a flag to the `synapse_review_recent_signups` script to ignore and filter appservice users. ([\#11675](https://github.com/matrix-org/synapse/issues/11675), [\#11770](https://github.com/matrix-org/synapse/issues/11770)) Bugfixes -------- - Fix a long-standing issue which could cause Synapse to incorrectly accept data in the unsigned field of events received over federation. ([\#11530](https://github.com/matrix-org/synapse/issues/11530)) - Fix a long-standing bug where Synapse wouldn't cache a response indicating that a remote user has no devices. ([\#11587](https://github.com/matrix-org/synapse/issues/11587)) - Fix an error that occurs whilst trying to get the federation status of a destination server that was working normally. This admin API was newly introduced in Synapse v1.49.0. ([\#11593](https://github.com/matrix-org/synapse/issues/11593)) - Fix bundled aggregations not being included in the `/sync` response, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675). ([\#11612](https://github.com/matrix-org/synapse/issues/11612), [\#11659](https://github.com/matrix-org/synapse/issues/11659), [\#11791](https://github.com/matrix-org/synapse/issues/11791)) - Fix the `/_matrix/client/v1/room/{roomId}/hierarchy` endpoint returning incorrect fields which have been present since Synapse 1.49.0. ([\#11667](https://github.com/matrix-org/synapse/issues/11667)) - Fix preview of some GIF URLs (like tenor.com). Contributed by Philippe Daouadi. ([\#11669](https://github.com/matrix-org/synapse/issues/11669)) - Fix a bug where only the first 50 rooms from a space were returned from the `/hierarchy` API. This has existed since the introduction of the API in Synapse v1.41.0. ([\#11695](https://github.com/matrix-org/synapse/issues/11695)) - Fix a bug introduced in Synapse v1.18.0 where password reset and address validation emails would not be sent if their subject was configured to use the 'app' template variable. Contributed by @br4nnigan. ([\#11710](https://github.com/matrix-org/synapse/issues/11710), [\#11745](https://github.com/matrix-org/synapse/issues/11745)) - Make the 'List Rooms' Admin API sort stable. Contributed by Daniël Sonck. ([\#11737](https://github.com/matrix-org/synapse/issues/11737)) - Fix a long-standing bug where space hierarchy over federation would only work correctly some of the time. ([\#11775](https://github.com/matrix-org/synapse/issues/11775)) - Fix a bug introduced in Synapse v1.46.0 that prevented `on_logged_out` module callbacks from being correctly awaited by Synapse. ([\#11786](https://github.com/matrix-org/synapse/issues/11786)) Improved Documentation ---------------------- - Warn against using a Let's Encrypt certificate for TLS/DTLS TURN server client connections, and suggest using ZeroSSL certificate instead. This works around client-side connectivity errors caused by WebRTC libraries that reject Let's Encrypt certificates. Contibuted by @AndrewFerr. ([\#11686](https://github.com/matrix-org/synapse/issues/11686)) - Document the new `SYNAPSE_TEST_PERSIST_SQLITE_DB` environment variable in the contributing guide. ([\#11715](https://github.com/matrix-org/synapse/issues/11715)) - Document that the minimum supported PostgreSQL version is now 10. ([\#11725](https://github.com/matrix-org/synapse/issues/11725)) - Fix typo in demo docs: differnt. ([\#11735](https://github.com/matrix-org/synapse/issues/11735)) - Update room spec URL in config files. ([\#11739](https://github.com/matrix-org/synapse/issues/11739)) - Mention `python3-venv` and `libpq-dev` dependencies in the contribution guide. ([\#11740](https://github.com/matrix-org/synapse/issues/11740)) - Update documentation for configuring login with Facebook. ([\#11755](https://github.com/matrix-org/synapse/issues/11755)) - Update installation instructions to note that Python 3.6 is no longer supported. ([\#11781](https://github.com/matrix-org/synapse/issues/11781)) Deprecations and Removals ------------------------- - Remove the unstable `/send_relation` endpoint. ([\#11682](https://github.com/matrix-org/synapse/issues/11682)) - Remove `python_twisted_reactor_pending_calls` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724)) - Remove the `password_hash` field from the response dictionaries of the [Users Admin API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html). ([\#11576](https://github.com/matrix-org/synapse/issues/11576)) - **Deprecate support for `webclient` listeners and non-HTTP(S) `web_client_location` configuration. ([\#11774](https://github.com/matrix-org/synapse/issues/11774), [\#11783](https://github.com/matrix-org/synapse/issues/11783))** Internal Changes ---------------- - Run `pyupgrade --py37-plus --keep-percent-format` on Synapse. ([\#11685](https://github.com/matrix-org/synapse/issues/11685)) - Use buildkit's cache feature to speed up docker builds. ([\#11691](https://github.com/matrix-org/synapse/issues/11691)) - Use `auto_attribs` and native type hints for attrs classes. ([\#11692](https://github.com/matrix-org/synapse/issues/11692), [\#11768](https://github.com/matrix-org/synapse/issues/11768)) - Remove debug logging for #4422, which has been closed since Synapse 0.99. ([\#11693](https://github.com/matrix-org/synapse/issues/11693)) - Remove fallback code for Python 2. ([\#11699](https://github.com/matrix-org/synapse/issues/11699)) - Add a test for [an edge case](https://github.com/matrix-org/synapse/pull/11532#discussion_r769104461) in the `/sync` logic. ([\#11701](https://github.com/matrix-org/synapse/issues/11701)) - Add the option to write SQLite test dbs to disk when running tests. ([\#11702](https://github.com/matrix-org/synapse/issues/11702)) - Improve Complement test output for Gitub Actions. ([\#11707](https://github.com/matrix-org/synapse/issues/11707)) - Fix docstring on `add_account_data_for_user`. ([\#11716](https://github.com/matrix-org/synapse/issues/11716)) - Complement environment variable name change and update `.gitignore`. ([\#11718](https://github.com/matrix-org/synapse/issues/11718)) - Simplify calculation of Prometheus metrics for garbage collection. ([\#11723](https://github.com/matrix-org/synapse/issues/11723)) - Improve accuracy of `python_twisted_reactor_tick_time` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724), [\#11771](https://github.com/matrix-org/synapse/issues/11771)) - Minor efficiency improvements when inserting many values into the database. ([\#11742](https://github.com/matrix-org/synapse/issues/11742)) - Invite PR authors to give themselves credit in the changelog. ([\#11744](https://github.com/matrix-org/synapse/issues/11744)) - Add optional debugging to investigate [issue 8631](https://github.com/matrix-org/synapse/issues/8631). ([\#11760](https://github.com/matrix-org/synapse/issues/11760)) - Remove `log_function` utility function and its uses. ([\#11761](https://github.com/matrix-org/synapse/issues/11761)) - Add a unit test that checks both `client` and `webclient` resources will function when simultaneously enabled. ([\#11765](https://github.com/matrix-org/synapse/issues/11765)) - Allow overriding complement commit using `COMPLEMENT_REF`. ([\#11766](https://github.com/matrix-org/synapse/issues/11766)) - Add some comments and type annotations for `_update_outliers_txn`. ([\#11776](https://github.com/matrix-org/synapse/issues/11776))
| | * Correct version number v1.51.0David Robertson2022-01-251-1/+1
| | |
| | * Call out deprecationDavid Robertson2022-01-251-1/+2
| | |
| | * 1.51.0David Robertson2022-01-253-1/+13
| | |
* | | Add admin API to reset connection timeouts for remote server (#11639)Dirk Klimpel2022-01-2510-33/+183
| | | | | | | | | * Fix get federation status of destination if no error occured
* | | Ignore the jsonschema type. (#11817)Patrick Cloke2022-01-252-1/+4
| | |
* | | Skip the initial amd64-only Docker build (#11810)Richard van der Hoff2022-01-242-12/+3
| | | | | | | | | | | | | | | PyNaCl's recent 1.5.0 release on PyPi includes arm64 wheels, which means our arm64 docker images now build in a sensible amount of time, so we can skip the amd64-only build.
* | | Apply a timeout to reading the body when fetching a file. (#11784)Patrick Cloke2022-01-242-3/+13
| | | | | | | | | | | | This prevents the URL preview code from reading a stream forever.
* | | Merge branch 'master' into developAndrew Morgan2022-01-242-3/+14
|\| |
| * | 1.50.2 v1.50.2Andrew Morgan2022-01-244-2/+16
| | |
| * | Fix logic for dropping old events in fed queue (#11806)Andrew Morgan2022-01-243-7/+27
| | | | | | | | | | | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Richard van der Hoff <richard@matrix.org>
* | | Support rendering previews with data: URLs in them (#11767)Patrick Cloke2022-01-246-74/+299
| | | | | | | | | | | | | | | Images which are data URLs will no longer break URL previews and will properly be "downloaded" and thumbnailed.
* | | Merge tag 'v1.51.0rc2' into developAndrew Morgan2022-01-245-8/+44
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Synapse 1.51.0rc2 (2022-01-24) ============================== Bugfixes -------- - Fix a bug introduced in Synapse 1.40.0 that caused Synapse to fail to process incoming federation traffic after handling a large amount of events in a v1 room. ([\#11806](https://github.com/matrix-org/synapse/issues/11806))
| * | 1.51.0rc2 v1.51.0rc2Andrew Morgan2022-01-244-2/+16
| | |
| * | Fix logic for dropping old events in fed queue (#11806)Andrew Morgan2022-01-243-7/+29
| | | | | | | | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Richard van der Hoff <richard@matrix.org>
* | | Remove account data (including client config, push rules and ignored users) ↵reivilibre2022-01-245-3/+299
| | | | | | | | | | | | | | | upon user deactivation. (#11621) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Drop support for and remove references to EOL Python 3.6 (#11683)Shay2022-01-2113-28/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * remove reference in comments to python3.6 * upgrade tox python env in script * bump python version in example for completeness * upgrade python version requirement in setup doc * upgrade necessary python version in __init__.py * upgrade python version in setup.py * newsfragment * drops refs to bionic and replace with focal * bump refs to postgres 9.6 to 10 * fix hanging ci * try installing tzdata first * revert change made in b979f336 * ignore new random mypy error while debugging other error * fix lint error for temporary workaround * revert change to install list * try passing env var * export debian frontend var? * move line and add comment * bump pillow dependency * bump lxml depenency * install libjpeg-dev for pillow * bump automat version to one compatible with py3.8 * add libwebp for pillow * bump twisted trunk python version * change suffix of newsfragment * remove redundant python 3.7 checks * lint
* | | Remove obsolete newsfileOlivier Wilkinson (reivilibre)2022-01-211-1/+0
| | | | | | | | | | | | The PR was cherrypicked into v1.51.0rc1.
* | | Merge tag 'v1.51.0rc1' into developOlivier Wilkinson (reivilibre)2022-01-2157-56/+82
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.51.0rc1 (2022-01-21) ============================== Features -------- - Add `track_puppeted_user_ips` config flag to record client IP addresses against puppeted users, and include the puppeted users in monthly active user counts. ([\#11561](https://github.com/matrix-org/synapse/issues/11561), [\#11749](https://github.com/matrix-org/synapse/issues/11749), [\#11757](https://github.com/matrix-org/synapse/issues/11757)) - Include whether the requesting user has participated in a thread when generating a summary for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440). ([\#11577](https://github.com/matrix-org/synapse/issues/11577)) - Return an `M_FORBIDDEN` error code instead of `M_UNKNOWN` when a spam checker module prevents a user from creating a room. ([\#11672](https://github.com/matrix-org/synapse/issues/11672)) - Add a flag to the `synapse_review_recent_signups` script to ignore and filter appservice users. ([\#11675](https://github.com/matrix-org/synapse/issues/11675), [\#11770](https://github.com/matrix-org/synapse/issues/11770)) Bugfixes -------- - Fix a long-standing issue which could cause Synapse to incorrectly accept data in the unsigned field of events received over federation. ([\#11530](https://github.com/matrix-org/synapse/issues/11530)) - Fix a long-standing bug where Synapse wouldn't cache a response indicating that a remote user has no devices. ([\#11587](https://github.com/matrix-org/synapse/issues/11587)) - Fix an error that occurs whilst trying to get the federation status of a destination server that was working normally. This admin API was newly introduced in Synapse v1.49.0. ([\#11593](https://github.com/matrix-org/synapse/issues/11593)) - Fix bundled aggregations not being included in the `/sync` response, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675). ([\#11612](https://github.com/matrix-org/synapse/issues/11612), [\#11659](https://github.com/matrix-org/synapse/issues/11659), [\#11791](https://github.com/matrix-org/synapse/issues/11791)) - Fix the `/_matrix/client/v1/room/{roomId}/hierarchy` endpoint returning incorrect fields which have been present since Synapse 1.49.0. ([\#11667](https://github.com/matrix-org/synapse/issues/11667)) - Fix preview of some GIF URLs (like tenor.com). Contributed by Philippe Daouadi. ([\#11669](https://github.com/matrix-org/synapse/issues/11669)) - Fix a bug where only the first 50 rooms from a space were returned from the `/hierarchy` API. This has existed since the introduction of the API in Synapse v1.41.0. ([\#11695](https://github.com/matrix-org/synapse/issues/11695)) - Fix a bug introduced in Synapse v1.18.0 where password reset and address validation emails would not be sent if their subject was configured to use the 'app' template variable. Contributed by @br4nnigan. ([\#11710](https://github.com/matrix-org/synapse/issues/11710), [\#11745](https://github.com/matrix-org/synapse/issues/11745)) - Make the 'List Rooms' Admin API sort stable. Contributed by Daniël Sonck. ([\#11737](https://github.com/matrix-org/synapse/issues/11737)) - Fix a long-standing bug where space hierarchy over federation would only work correctly some of the time. ([\#11775](https://github.com/matrix-org/synapse/issues/11775)) - Fix a bug introduced in Synapse v1.46.0 that prevented `on_logged_out` module callbacks from being correctly awaited by Synapse. ([\#11786](https://github.com/matrix-org/synapse/issues/11786)) Improved Documentation ---------------------- - Warn against using a Let's Encrypt certificate for TLS/DTLS TURN server client connections, and suggest using ZeroSSL certificate instead. This works around client-side connectivity errors caused by WebRTC libraries that reject Let's Encrypt certificates. Contibuted by @AndrewFerr. ([\#11686](https://github.com/matrix-org/synapse/issues/11686)) - Document the new `SYNAPSE_TEST_PERSIST_SQLITE_DB` environment variable in the contributing guide. ([\#11715](https://github.com/matrix-org/synapse/issues/11715)) - Document that the minimum supported PostgreSQL version is now 10. ([\#11725](https://github.com/matrix-org/synapse/issues/11725)) - Fix typo in demo docs: differnt. ([\#11735](https://github.com/matrix-org/synapse/issues/11735)) - Update room spec URL in config files. ([\#11739](https://github.com/matrix-org/synapse/issues/11739)) - Mention `python3-venv` and `libpq-dev` dependencies in the contribution guide. ([\#11740](https://github.com/matrix-org/synapse/issues/11740)) - Update documentation for configuring login with Facebook. ([\#11755](https://github.com/matrix-org/synapse/issues/11755)) - Update installation instructions to note that Python 3.6 is no longer supported. ([\#11781](https://github.com/matrix-org/synapse/issues/11781)) Deprecations and Removals ------------------------- - Remove the unstable `/send_relation` endpoint. ([\#11682](https://github.com/matrix-org/synapse/issues/11682)) - Remove `python_twisted_reactor_pending_calls` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724)) - Remove the `password_hash` field from the response dictionaries of the [Users Admin API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html). ([\#11576](https://github.com/matrix-org/synapse/issues/11576)) - Deprecate support for `webclient` listeners and non-HTTP(S) `web_client_location` configuration. ([\#11774](https://github.com/matrix-org/synapse/issues/11774), [\#11783](https://github.com/matrix-org/synapse/issues/11783)) Internal Changes ---------------- - Run `pyupgrade --py37-plus --keep-percent-format` on Synapse. ([\#11685](https://github.com/matrix-org/synapse/issues/11685)) - Use buildkit's cache feature to speed up docker builds. ([\#11691](https://github.com/matrix-org/synapse/issues/11691)) - Use `auto_attribs` and native type hints for attrs classes. ([\#11692](https://github.com/matrix-org/synapse/issues/11692), [\#11768](https://github.com/matrix-org/synapse/issues/11768)) - Remove debug logging for #4422, which has been closed since Synapse 0.99. ([\#11693](https://github.com/matrix-org/synapse/issues/11693)) - Remove fallback code for Python 2. ([\#11699](https://github.com/matrix-org/synapse/issues/11699)) - Add a test for [an edge case](https://github.com/matrix-org/synapse/pull/11532#discussion_r769104461) in the `/sync` logic. ([\#11701](https://github.com/matrix-org/synapse/issues/11701)) - Add the option to write SQLite test dbs to disk when running tests. ([\#11702](https://github.com/matrix-org/synapse/issues/11702)) - Improve Complement test output for Gitub Actions. ([\#11707](https://github.com/matrix-org/synapse/issues/11707)) - Fix docstring on `add_account_data_for_user`. ([\#11716](https://github.com/matrix-org/synapse/issues/11716)) - Complement environment variable name change and update `.gitignore`. ([\#11718](https://github.com/matrix-org/synapse/issues/11718)) - Simplify calculation of Prometheus metrics for garbage collection. ([\#11723](https://github.com/matrix-org/synapse/issues/11723)) - Improve accuracy of `python_twisted_reactor_tick_time` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724), [\#11771](https://github.com/matrix-org/synapse/issues/11771)) - Minor efficiency improvements when inserting many values into the database. ([\#11742](https://github.com/matrix-org/synapse/issues/11742)) - Invite PR authors to give themselves credit in the changelog. ([\#11744](https://github.com/matrix-org/synapse/issues/11744)) - Add optional debugging to investigate [issue 8631](https://github.com/matrix-org/synapse/issues/8631). ([\#11760](https://github.com/matrix-org/synapse/issues/11760)) - Remove `log_function` utility function and its uses. ([\#11761](https://github.com/matrix-org/synapse/issues/11761)) - Add a unit test that checks both `client` and `webclient` resources will function when simultaneously enabled. ([\#11765](https://github.com/matrix-org/synapse/issues/11765)) - Allow overriding complement commit using `COMPLEMENT_REF`. ([\#11766](https://github.com/matrix-org/synapse/issues/11766)) - Add some comments and type annotations for `_update_outliers_txn`. ([\#11776](https://github.com/matrix-org/synapse/issues/11776))
| * | Edit the changelog according to feedback v1.51.0rc1Olivier Wilkinson (reivilibre)2022-01-211-3/+3
| | |
| * | Edit the changelog for grammar and clarityOlivier Wilkinson (reivilibre)2022-01-211-16/+15
| | |
| * | 1.51.0rc1Olivier Wilkinson (reivilibre)2022-01-2159-58/+83
| | |
| * | Do not try to serialize raw aggregations dict. (#11791)Patrick Cloke2022-01-217-54/+85
| | |
* | | Add `state_key` and `rejection_reason` to `events` (#11792)Richard van der Hoff2022-01-215-5/+42
| | | | | | | | | | | | ... and start populating them for new events
* | | Do not try to serialize raw aggregations dict. (#11791)Patrick Cloke2022-01-217-54/+85
| | |
* | | Drop unused table `public_room_list_stream`. (#11795)Richard van der Hoff2022-01-215-3/+22
| | | | | | | | | This is a follow-up to #10565.
* | | Stop reading from `event_reference_hashes` (#11794)Richard van der Hoff2022-01-215-33/+31
| | | | | | | | | | | | Preparation for dropping this table altogether. Part of #6574.
* | | Add `FrozenEvent.get_state_key` and use it in a couple of places (#11793)Richard van der Hoff2022-01-213-5/+11
| | | | | | | | | | | | This is more efficient, since we only have to look up `state_key` in the event dict once, rather than three (!) times.
* | | Make the `get_global_account_data_by_type_for_user` cache be a tree-cache ↵reivilibre2022-01-216-9/+10
| | | | | | | | | | | | whose key is prefixed with the user ID (#11788)
* | | Make `get_account_data_for_room_and_type` a tree cache (#11789)reivilibre2022-01-212-1/+2
|/ /
* | Correctly await on_logged_out callbacks (#11786)Brendan Abolivier2022-01-203-2/+29
| |
* | Fix redirecting to the webclient for non-HTTP(S) web_client_location. (#11783)Patrick Cloke2022-01-202-1/+9
| | | | | | | | | | To not change the behaviour during the deprecation period. Follow-up to #11774.
* | Add a regression test for using both webclient and client resources ↵Andrew Morgan2022-01-202-0/+109
| | | | | | | | simultaneously (#11765)
* | Partially revert #11675; prevent attempting to create pushers on workers ↵Andrew Morgan2022-01-202-7/+6
| | | | | | | | (#11770)
* | installation.md: drop python 3.6 support (#11781)Richard van der Hoff2022-01-202-1/+2
| | | | | | #11595 dropped support for python 3.6, but forgot to update this doc.
* | Add deprecation warnings for `webclient` listener and non-HTTP(S) ↵Patrick Cloke2022-01-205-28/+40
| | | | | | | | | | | | | | `web_client_location`. (#11774) This changes the behaviour of the root endpoint to redirect directly to the configuration of `web_client_location` if it is given an HTTP(S) URL.
* | Debug for device lists updates (#11760)David Robertson2022-01-204-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debug for #8631. I'm having a hard time tracking down what's going wrong in that issue. In the reported example, I could see server A sending federation traffic to server B and all was well. Yet B reports out-of-sync device updates from A. I couldn't see what was _in_ the events being sent from A to B. So I have added some crude logging to track - when we have updates to send to a remote HS - the edus we actually accumulate to send - when a federation transaction includes a device list update edu - when such an EDU is received This is a bit of a sledgehammer.
* | Allow overriding the complement ref. (#11766)Nicolas Werner2022-01-203-7/+10
| | | | | | | | | | Updates complement.sh to read the ref from an environment variable (defaulting to master) when downloading a complement bundle for testing.
* | Fix a bug that corrupted the cache of federated space hierarchies (#11775)Sean Quah2022-01-204-12/+102
| | | | | | | | `FederationClient.get_room_hierarchy()` caches its return values, so refactor the code to avoid modifying the returned room summary.
* | Comments and typing for `_update_outliers_txn` (#11776)Richard van der Hoff2022-01-192-12/+24
| | | | | | | | A couple of surprises for me here, so thought I'd document them
* | Fix mypy for platforms without epoll support. (#11771)Patrick Cloke2022-01-192-2/+3
| |
* | Add missing `auto_attribs=True` to the `_WrappedRustReporter` class (#11768)Andrew Morgan2022-01-192-1/+2
| |
* | Fix preview of imgur and Tenor URLs. (#11669)Philippe Daouadi2022-01-184-14/+39
| | | | | | | | | | | | By scraping Open Graph information from the HTML even when an autodiscovery endpoint is found. The results are then combined to capture as much information as possible from the page.
* | Merge branch 'master' into developAndrew Morgan2022-01-184-3/+29
|\|
| * Wording fixes to 1.50.0/1 changelog entries v1.50.1Andrew Morgan2022-01-181-3/+3
| |
| * Reword 1.50.0 warning a bit in the changelogAndrew Morgan2022-01-181-1/+3
| |
| * 1.50.1Andrew Morgan2022-01-184-2/+20
| |
| * Partially revert #11602 to prevent webclient overriding client resource (#11764)Andrew Morgan2022-01-182-2/+8
| |
* | Include whether the requesting user has participated in a thread. (#11577)Patrick Cloke2022-01-189-18/+85
| | | | | | | | | | | | Per updates to MSC3440. This is implement as a separate method since it needs to be cached on a per-user basis, instead of a per-thread basis.
* | Remove `log_function` and its uses (#11761)Richard van der Hoff2022-01-1813-155/+1
| | | | | | | | | | | | | | I've never found this terribly useful. I think it was added in the early days of Synapse, without much thought as to what would actually be useful to log, and has just been cargo-culted ever since. Rather, it tends to clutter up debug logs with useless information.
* | Merge branch 'master' into developAndrew Morgan2022-01-183-4/+15
|\|
| * Move python/postgres deprecation notice to the top of 1.50 changelog v1.50.0Andrew Morgan2022-01-181-2/+2
| |
| * 1.50.0Andrew Morgan2022-01-183-4/+15
| |
* | Add a flag to the `synapse_review_recent_signups` script to ignore and ↵lukasdenk2022-01-173-8/+23
| | | | | | | | filter appservice users. (#11675)
* | Warn against using Let's Encrypt certs for encrypted TURN (#11686)AndrewFerr2022-01-172-0/+17
| | | | | | | | | | | | | | | | | | * Warn against using Let's Encrypt certs for encrypted TURN This helps to avoid client-side issues: * https://github.com/vector-im/element-android/issues/1533 * https://github.com/vector-im/element-ios/issues/2712 Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>
* | Fix up docs for `track_puppeted_user_ips` (again) (#11757)Richard van der Hoff2022-01-175-10/+27
| | | | | | Fixes #11741
* | Update documentation for configuring facebook login (#11755)Richard van der Hoff2022-01-174-18/+26
| | | | | | ... and a minor thinko fix in the sample config.
* | Improve `reactor_tick_time` metric (#11724)Richard van der Hoff2022-01-175-109/+86
| | | | | | | | | | | | | | | | | | | | | | The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it *only* measures the time taken to execute timed calls and callbacks from threads. That neglects everything that happens off the back of I/O, which is obviously quite a lot for us. To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is the only place it should wait for something to happen - the rest of the loop *should* be quick. I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and it's a nuisance to populate.
* | Make pagination of rooms in admin api stable (#11737)Daniel Sonck2022-01-173-28/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Always add state.room_id after the configurable ORDER BY. Otherwise, for any sort, certain pages can contain results from other pages. (Especially when sorting by creator, since there may be many rooms by the same creator) * Document different order direction of numerical fields "joined_members", "joined_local_members", "version" and "state_events" are ordered in descending direction by default (dir=f). Added a note in tests to explain the differences in ordering. Signed-off-by: Daniël Sonck <daniel@sonck.nl>
* | Merge branch 'release-v1.50' into developOlivier Wilkinson (reivilibre)2022-01-145-20/+277
|\|
| * Tweak the changelog summary section v1.50.0rc2Olivier Wilkinson (reivilibre)2022-01-141-4/+3
| |
| * 1.50.0rc2Olivier Wilkinson (reivilibre)2022-01-147-5/+33
| |
| * Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could ↵reivilibre2022-01-133-17/+190
| | | | | | | | | | fail because too many EDUs were produced for device updates. (#11730) Co-authored-by: David Robertson <davidr@element.io>
| * Fix a bug introduced in Synapse v1.0.0 whereby device list updates would not ↵reivilibre2022-01-123-2/+57
| | | | | | | | | | be sent to remote homeservers if there were too many to send at once. (#11729) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| * Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714)David Robertson2022-01-122-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16
| * Fix documentation of supported PostgreSQL version (#11725)haslersn2022-01-122-1/+2
| | | | | | Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
* | Remove the 'password_hash' from the Users Admin API endpoint response ↵Andrew Morgan2022-01-145-43/+86
| | | | | | | | dictionary (#11576)
* | Fix sample_config.yaml in regards track_puppeted_user_ips (#11749)Jason Robinson2022-01-143-10/+13
| | | | | | | | | | | | | | * Fix sample_config.yaml in regards track_puppeted_user_ips Closes #11741 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | Replace uses of simple_insert_many with simple_insert_many_values. (#11742)Patrick Cloke2022-01-1319-298/+263
| | | | | | | | This should be (slightly) more efficient and it is simpler to have a single method for inserting multiple values.