summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Remove legacy Prometheus metrics names. They were deprecated in Synapse ↵reivilibre2022-11-2411-338/+70
| | | | v1.69.0 and disabled by default in Synapse v1.71.0. (#14538)
* Faster joins: use servers list approximation in `assert_host_in_room` (#14515)Mathieu Velten2022-11-242-11/+18
| | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* Add another index to `device_lists_changes_in_room` (#14534)Erik Johnston2022-11-233-0/+28
| | | | This helps avoid reading unnecessarily large amounts of data from the table when querying with a set of room IDs.
* Add missing type hints to test.util.caches (#14529)Patrick Cloke2022-11-227-66/+76
|
* Optimize `filter_events_for_client` for faster `/messages` - v2 (#14527)Eric Eastwood2022-11-222-20/+80
| | | Fix #14108
* Refactor `federation_sender` and `pusher` configuration loading. (#14496)realtyem2022-11-222-69/+71
| | | | | | To avoid duplicating the same logic for handling legacy configuration settings. This should help in applying similar logic to other worker types.
* Add more prompts to bug report form (#14522)David Robertson2022-11-222-2/+44
|
* Add a type hint for `get_device_handler()` and fix incorrect types. (#14055)Patrick Cloke2022-11-2216-77/+185
| | | | | This was the last untyped handler from the HomeServer object. Since it was being treated as Any (and thus unchecked) it was being used incorrectly in a few places.
* Apply correct editorconfig to .pyi files (#14526)Brendan Abolivier2022-11-222-1/+2
| | | The current configuration might cause some editors to misbehave when editing stub files.
* Track unconverted device list outbound pokes using a position instead (#14516)Sean Quah2022-11-226-49/+158
| | | | | | | | | | | | | | | | | | | | | When a local device list change is added to `device_lists_changes_in_room`, the `converted_to_destinations` flag is set to `FALSE` and the `_handle_new_device_update_async` background process is started. This background process looks for unconverted rows in `device_lists_changes_in_room`, copies them to `device_lists_outbound_pokes` and updates the flag. To update the `converted_to_destinations` flag, the database performs a `DELETE` and `INSERT` internally, which fragments the table. To avoid this, track unconverted rows using a `(stream ID, room ID)` position instead of the flag. From now on, the `converted_to_destinations` column indicates rows that need converting to outbound pokes, but does not indicate whether the conversion has already taken place. Closes #14037. Signed-off-by: Sean Quah <seanq@matrix.org>
* Parallelize calls to fetch bundled aggregations. (#14510)Patrick Cloke2022-11-222-32/+52
| | | | The bundled aggregations for annotations, references, and edits can be parallelized.
* Batch fetch bundled references (#14508)Patrick Cloke2022-11-226-79/+133
| | | | | | | | | Avoid an n+1 query problem and fetch the bundled aggregations for m.reference relations in a single query instead of a query per event. This applies similar logic for as was previously done for edits in 8b309adb436c162510ed1402f33b8741d71fc058 (#11660; threads in b65acead428653b988351ae8d7b22127a22039cd (#11752); and annotations in 1799a54a545618782840a60950ef4b64da9ee24d (#14491).
* Batch fetch bundled annotations (#14491)Patrick Cloke2022-11-225-141/+202
| | | | | | | | Avoid an n+1 query problem and fetch the bundled aggregations for m.annotation relations in a single query instead of a query per event. This applies similar logic for as was previously done for edits in 8b309adb436c162510ed1402f33b8741d71fc058 (#11660) and threads in b65acead428653b988351ae8d7b22127a22039cd (#11752).
* Merge branch 'master' into developDavid Robertson2022-11-224-348/+1227
|\
| * tweak postgres dep notice v1.72.0David Robertson2022-11-221-1/+1
| |
| * Move postgres warning banner to top of readmeDavid Robertson2022-11-221-2/+2
| |
| * 1.72.0David Robertson2022-11-224-2/+16
| |
| * Update forgotten references to legacy metrics in the included Grafana ↵reivilibre2022-11-222-345/+1210
| | | | | | | | | | dashboard. (#14477) Fixes https://github.com/matrix-org/synapse/issues/14465
* | Faster joins: filter out non local events when a room doesn't have its full ↵Mathieu Velten2022-11-215-13/+43
| | | | | | | | | | | | state (#14404) Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* | Fix broken admin API request recommendation link (#14499)Brennan Chapman2022-11-212-1/+2
| | | | | | Signed-off-by: Brennan Chapman <brennan@chapmanb.com>
* | Bump serde_json from 1.0.87 to 1.0.88 (#14505)dependabot[bot]2022-11-212-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump serde_json from 1.0.87 to 1.0.88 Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.87 to 1.0.88. - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](https://github.com/serde-rs/json/compare/v1.0.87...v1.0.88) --- updated-dependencies: - dependency-name: serde_json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump phonenumbers from 8.12.56 to 8.13.0 (#14504)dependabot[bot]2022-11-212-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump phonenumbers from 8.12.56 to 8.13.0 Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.12.56 to 8.13.0. - [Release notes](https://github.com/daviddrysdale/python-phonenumbers/releases) - [Commits](https://github.com/daviddrysdale/python-phonenumbers/compare/v8.12.56...v8.13.0) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump towncrier from 21.9.0 to 22.8.0 (#14503)dependabot[bot]2022-11-212-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump towncrier from 21.9.0 to 22.8.0 Bumps [towncrier](https://github.com/hawkowl/towncrier) from 21.9.0 to 22.8.0. - [Release notes](https://github.com/hawkowl/towncrier/releases) - [Changelog](https://github.com/twisted/towncrier/blob/trunk/NEWS.rst) - [Commits](https://github.com/hawkowl/towncrier/compare/21.9.0...22.8.0) --- updated-dependencies: - dependency-name: towncrier dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump pygithub from 1.56 to 1.57 (#14500)dependabot[bot]2022-11-212-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump pygithub from 1.56 to 1.57 Bumps [pygithub](https://github.com/pygithub/pygithub) from 1.56 to 1.57. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/master/doc/changes.rst) - [Commits](https://github.com/pygithub/pygithub/compare/v1.56...v1.57) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-pillow from 9.2.2.1 to 9.3.0.1 (#14502)dependabot[bot]2022-11-212-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-pillow from 9.2.2.1 to 9.3.0.1 Bumps [types-pillow](https://github.com/python/typeshed) from 9.2.2.1 to 9.3.0.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pillow dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump sentry-sdk from 1.10.1 to 1.11.0 (#14501)dependabot[bot]2022-11-212-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump sentry-sdk from 1.10.1 to 1.11.0 Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.10.1 to 1.11.0. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.10.1...1.11.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Fixes to `federation_client` dev script (#14479)Richard van der Hoff2022-11-202-35/+88
| | | | | | | | | | | | | | | | | | | | | | * Attempt to fix federation-client devscript handling of .well-known The script was setting the wrong value in the Host header * Fix TLS verification Turns out that actually doing TLS verification isn't that hard. Let's enable it.
* | Fix /key/v2/server calls with URL-unsafe key IDs (#14490)David Robertson2022-11-183-1/+14
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Reduce default third party invite rate limit to 216 invites per day (#14487)Sean Quah2022-11-182-4/+2
| | | | | | | | | | | | The previous default was the same as the `rc_message` rate limit, which defaults to 17,280 per day. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Enable 'strict_equality' checking for mypy (#14452)Andrew Morgan2022-11-172-0/+2
| |
* | Fix version that `worker_main_http_uri` is redundant from (#14476)David Robertson2022-11-173-3/+4
| | | | | | | | | | * Fix version that `worker_main_http_uri` is redundant from * Changelog
* | Fix check to ignore blank lines in incoming TCP replication (#14449)Andrew Morgan2022-11-173-4/+5
| |
* | Faster joins: do not wait for full state when creating events to send (#14403)Mathieu Velten2022-11-173-1/+9
| | | | | | Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* | Reintroduce #14376, with bugfix for monoliths (#14468)David Robertson2022-11-1614-186/+230
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add tests for StreamIdGenerator * Drive-by: annotate all defs * Revert "Revert "Remove slaved id tracker (#14376)" (#14463)" This reverts commit d63814fd736fed5d3d45ff3af5e6d3bfae50c439, which in turn reverted 36097e88c4da51fce6556a58c49bd675f4cf20ab. This restores the latter. * Fix StreamIdGenerator not handling unpersisted IDs Spotted by @erikjohnston. Closes #14456. * Changelog Co-authored-by: Nick Mills-Barrett <nick@fizzadar.com> Co-authored-by: Erik Johnston <erik@matrix.org>
* | Remove need for `worker_main_http_uri` setting to use /keys/upload. (#14400)realtyem2022-11-167-127/+130
| |
* | Merge branch 'release-v1.72' into developErik Johnston2022-11-1668-66/+79
|\|
| * Update changelog v1.72.0rc1Erik Johnston2022-11-161-2/+2
| |
| * Point to our deprecation policyErik Johnston2022-11-161-1/+1
| |
| * Update changelogErik Johnston2022-11-161-25/+2
| |
| * 1.72.0rc1Erik Johnston2022-11-1668-66/+102
| |
* | Fix an invalid comparison of `UserPresenceState` to `str` (#14393)Andrew Morgan2022-11-165-8/+46
| |
* | Remove redundant types from comments. (#14412)Patrick Cloke2022-11-1655-176/+174
|/ | | | | | | Remove type hints from comments which have been added as Python type hints. This helps avoid drift between comments and reality, as well as removing redundant information. Also adds some missing type hints which were simple to fill in.
* Fix background updates failing to add unique indexes on receipts (#14453)Sean Quah2022-11-163-24/+357
| | | | | | | | | | | | | | | | | | | | | | As part of the database migration to support threaded receipts, there is a possible window in between `73/08thread_receipts_non_null.sql.postgres` removing the original unique constraints on `receipts_linearized` and `receipts_graph` and the `reeipts_linearized_unique_index` and `receipts_graph_unique_index` background updates from `72/08thread_receipts.sql` completing where the unique constraints on `receipts_linearized` and `receipts_graph` are missing. Any emulated upserts on these tables must therefore be performed with a lock held, otherwise duplicate rows can end up in the tables when there are concurrent emulated upserts. Fix the missing lock. Note that emulated upserts no longer happen by default on sqlite, since the minimum supported version of sqlite supports native upserts by default now. Finally, clean up any duplicate receipts that may have crept in before trying to create the `receipts_graph_unique_index` and `receipts_linearized_unique_index` unique indexes. Signed-off-by: Sean Quah <seanq@matrix.org>
* Revert "Remove slaved id tracker (#14376)" (#14463)Erik Johnston2022-11-1611-74/+176
| | | This reverts commit 36097e88c4da51fce6556a58c49bd675f4cf20ab.
* Don't filter state in /context response (#14461)Erik Johnston2022-11-162-1/+2
| | | We don't filter state usually, so doing so here is a waste of time. This is not much of an issue for clients that enable lazy loading of members, since there will be fewer state events.
* Fix stub return type of `PushRuleEvaluator.run` (#14451)Andrew Morgan2022-11-162-2/+3
|
* Fix HTML templates missing correct HTML tags (#14448)Erik Johnston2022-11-1622-0/+23
|
* Include heroes in partial join responses' state (#14442)David Robertson2022-11-155-25/+60
| | | | | | | | | | | * Pull out hero selection logic * Include heroes in partial join response's state * Changelog * Fixup trial test * Remove TODO
* Fix typechecking errors introduced in #14128 (#14455)David Robertson2022-11-153-4/+6
| | | | | | | | | * Fix typechecking errors introduced in #14128 * Changelog * Correct annotations so that context_factory works if you don't use TLS
* Send content rules with pattern_type to clients (#14356)DeepBlueV7.X2022-11-152-3/+14
|
* Support using SSL on worker endpoints. (#14128)Tuomas Ojamies2022-11-157-53/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix missing SSL support in worker endpoints. * Add changelog * SSL for Replication endpoint * Remove unit test change * Refactor listener creation to reduce duplicated code * Fix the logger message * Update synapse/app/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update synapse/app/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update synapse/app/_base.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Add config documentation for new TLS option Co-authored-by: Tuomas Ojamies <tojamies@palantir.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Update docstring to clarify that `get_partial_state_events_batch` does not ↵reivilibre2022-11-152-1/+10
| | | | just give you completely arbitrary partial-state events. (#14417)
* Include additional TURN server example into documentation (#14293)sando382022-11-145-211/+390
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Include eturnal TURN server configuration example and moving specific configuration examples into sub folders. * Update docs/turn-howto.md Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> * Update docs/setup/turn/coturn.md Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> * Update docs/setup/turn/eturnal.md Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> * Fix TURN relaying public IP address hint * lint eturnal installation commands * Adjust synapse setup to link to existing documentation ..avoid redundant information. * remove redundant text * include alpine linux package link * Create 14293.doc * Update 14293.doc add missing dot * Update docs/setup/turn/eturnal.md Co-authored-by: reivilibre <olivier@librepush.net> * Update docs/setup/turn/eturnal.md Co-authored-by: reivilibre <olivier@librepush.net> * Update docs/setup/turn/coturn.md Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com> * Update docs/setup/turn/coturn.md Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com> * Update docs/setup/turn/coturn.md Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com> * Update docs/setup/turn/eturnal.md Co-authored-by: reivilibre <olivier@librepush.net> * Update docs/setup/turn/coturn.md Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com> * Update docs/setup/turn/coturn.md Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com> * Update eturnal.md to link to official documentation ... and to simplify some aspects * Adjust coturn to link to default prefix * Mention eturnalctl location * Update docs/turn-howto.md Co-authored-by: Saarko <sandomir@tutanotal.com> Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: Moritz Dietz <moritzdietz@users.noreply.github.com>
* Remove slaved id tracker (#14376)Nick Mills-Barrett2022-11-1411-176/+74
| | | | | This matches the multi instance writer ID generator class which can both handle advancing the current token over replication and by calling the database.
* Bump jsonschema from 4.16.0 to 4.17.0 (#14439)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | | * Bump jsonschema from 4.16.0 to 4.17.0 Bumps [jsonschema](https://github.com/python-jsonschema/jsonschema) from 4.16.0 to 4.17.0. - [Release notes](https://github.com/python-jsonschema/jsonschema/releases) - [Changelog](https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst) - [Commits](https://github.com/python-jsonschema/jsonschema/compare/v4.16.0...v4.17.0) --- updated-dependencies: - dependency-name: jsonschema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump flake8-comprehensions from 3.8.0 to 3.10.1 (#14438)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | | * Bump flake8-comprehensions from 3.8.0 to 3.10.1 Bumps [flake8-comprehensions](https://github.com/adamchainz/flake8-comprehensions) from 3.8.0 to 3.10.1. - [Release notes](https://github.com/adamchainz/flake8-comprehensions/releases) - [Changelog](https://github.com/adamchainz/flake8-comprehensions/blob/main/HISTORY.rst) - [Commits](https://github.com/adamchainz/flake8-comprehensions/compare/3.8.0...3.10.1) --- updated-dependencies: - dependency-name: flake8-comprehensions dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump types-pyopenssl from 22.0.10 to 22.1.0.2 (#14437)dependabot[bot]2022-11-142-5/+6
| | | | | | | | | | | | | | | | | | | | | | * Bump types-pyopenssl from 22.0.10 to 22.1.0.2 Bumps [types-pyopenssl](https://github.com/python/typeshed) from 22.0.10 to 22.1.0.2. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyopenssl dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump canonicaljson from 1.6.3 to 1.6.4 (#14440)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | | * Bump canonicaljson from 1.6.3 to 1.6.4 Bumps [canonicaljson](https://github.com/matrix-org/python-canonicaljson) from 1.6.3 to 1.6.4. - [Release notes](https://github.com/matrix-org/python-canonicaljson/releases) - [Changelog](https://github.com/matrix-org/python-canonicaljson/blob/main/CHANGES.md) - [Commits](https://github.com/matrix-org/python-canonicaljson/compare/v1.6.3...v1.6.4) --- updated-dependencies: - dependency-name: canonicaljson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump types-setuptools from 65.5.0.2 to 65.5.0.3 (#14436)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | * Bump types-setuptools from 65.5.0.2 to 65.5.0.3 Bumps [types-setuptools](https://github.com/python/typeshed) from 65.5.0.2 to 65.5.0.3. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-setuptools dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Make Dependabot only bump Rust deps in the lock file (#14434)Erik Johnston2022-11-143-6/+8
| | | This is to help downstream packagers.
* Remove unused type-ignores (#14433)David Robertson2022-11-143-6/+8
| | | | | | | * Remove unused type-ignores Oversights in #14427 and #14429. * Changelog
* Clean-up events persistance code (#14411)Patrick Cloke2022-11-143-8/+4
| | | | By removing unused variables and making some arguments required which are always provided.
* Bump gitpython from 3.1.27 to 3.1.29 (#14429)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | | * Bump gitpython from 3.1.27 to 3.1.29 Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.27 to 3.1.29. - [Release notes](https://github.com/gitpython-developers/GitPython/releases) - [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES) - [Commits](https://github.com/gitpython-developers/GitPython/compare/3.1.27...3.1.29) --- updated-dependencies: - dependency-name: gitpython dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump types-pyyaml from 6.0.12.1 to 6.0.12.2 (#14428)dependabot[bot]2022-11-142-3/+4
| | | | | | | | | | | | | | | | | | | | | | * Bump types-pyyaml from 6.0.12.1 to 6.0.12.2 Bumps [types-pyyaml](https://github.com/python/typeshed) from 6.0.12.1 to 6.0.12.2. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyyaml dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump attrs from 21.4.0 to 22.1.0 (#14427)dependabot[bot]2022-11-142-7/+8
| | | | | | | | | | | | | | | | | | | | | | | * Bump attrs from 21.4.0 to 22.1.0 Bumps [attrs](https://github.com/python-attrs/attrs) from 21.4.0 to 22.1.0. - [Release notes](https://github.com/python-attrs/attrs/releases) - [Changelog](https://github.com/python-attrs/attrs/blob/main/CHANGELOG.rst) - [Commits](https://github.com/python-attrs/attrs/compare/21.4.0...22.1.0) --- updated-dependencies: - dependency-name: attrs dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump flake8 from 4.0.1 to 5.0.4 (#14431)dependabot[bot]2022-11-142-20/+21
| | | | | | | | | | | | | | | | | | | | | | * Bump flake8 from 4.0.1 to 5.0.4 Bumps [flake8](https://github.com/pycqa/flake8) from 4.0.1 to 5.0.4. - [Release notes](https://github.com/pycqa/flake8/releases) - [Commits](https://github.com/pycqa/flake8/compare/4.0.1...5.0.4) --- updated-dependencies: - dependency-name: flake8 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump types-jsonschema from 4.17.0.0 to 4.17.0.1 (#14430)dependabot[bot]2022-11-142-3/+6
| | | | | | | | | | | | | | | | | | | | | | * Bump types-jsonschema from 4.17.0.0 to 4.17.0.1 Bumps [types-jsonschema](https://github.com/python/typeshed) from 4.17.0.0 to 4.17.0.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-jsonschema dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump blake2 from 0.10.4 to 0.10.5 (#14426)dependabot[bot]2022-11-143-3/+4
| | | | | | | | | | | | | | | | | | | | | | * Bump blake2 from 0.10.4 to 0.10.5 Bumps [blake2](https://github.com/RustCrypto/hashes) from 0.10.4 to 0.10.5. - [Release notes](https://github.com/RustCrypto/hashes/releases) - [Commits](https://github.com/RustCrypto/hashes/compare/blake2-v0.10.4...blake2-v0.10.5) --- updated-dependencies: - dependency-name: blake2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump actions/upload-artifact from 2 to 3 (#14425)dependabot[bot]2022-11-142-1/+2
| | | | | | | | | | | | | | | | | | | | | | * Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump dawidd6/action-download-artifact from 2.24.1 to 2.24.2 (#14424)dependabot[bot]2022-11-142-1/+2
| | | | | | | | | | | | | | | | | | | | | | * Bump dawidd6/action-download-artifact from 2.24.1 to 2.24.2 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.24.1 to 2.24.2. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/b12b127cf24433d14b4f93cee62f5465076ba82a...e6e25ac3a2b93187502a8be1ef9e9603afc34925) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Update sample Nginx configuration to HTTP 1.1 (#14414)Brad Jones2022-11-112-0/+4
| | | | Signed-off-by: Brad Jones <brad@kinksters.dating>
* Add an Admin API endpoint for looking up users based on 3PID (#14405)Ashish Kumar2022-11-115-13/+161
|
* Merge/remove `Slaved*` stores into `WorkerStores` (#14375)Nick Mills-Barrett2022-11-1117-377/+202
|
* Remove duplicated code to evict entries. (#14410)Patrick Cloke2022-11-102-9/+3
| | | | | | | | This code was factored out to a method, but also left in-place. Calling this twice in a row makes no sense: the first call will reduce the size appropriately, but the loop will immediately exit since the cache size was already reduced.
* Fix PostgreSQL sometimes using table scans for `event_search` (#14409)Sean Quah2022-11-102-0/+34
| | | | | | | | | | | PostgreSQL may underestimate the number of distinct `room_id`s in `event_search`, which can cause it to use table scans for queries for multiple rooms. Fix this by setting `n_distinct` on the column. Resolves #14402. Signed-off-by: Sean Quah <seanq@matrix.org>
* Quieter logging for stateres failure at missing prev events (#14346)David Robertson2022-11-102-3/+3
|
* Drop support for Postgres 10 in full text search code. (#14397)Patrick Cloke2022-11-094-95/+41
|
* Bump dawidd6/action-download-artifact from 2.24.0 to 2.24.1 (#14398)dependabot[bot]2022-11-092-1/+2
| | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: reivilibre <oliverw@matrix.org>
* Modernize configure_workers_and_start.py bootstrapping script for ↵realtyem2022-11-092-15/+15
| | | | Dockerfile-workers. (#14294)
* Build Debian packages for Ubuntu 22.10 Kinetic Kudu (#14396)Sean Quah2022-11-092-0/+2
| | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Test against PostgreSQL 15 in CI (#14394)Sean Quah2022-11-093-2/+12
| | | | | Resolves #14170. Signed-off-by: Sean Quah <seanq@matrix.org>
* Remove support for PostgreSQL 10 (#14392)Sean Quah2022-11-085-4/+15
| | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Add all Stream Writer worker types to configure_workers_and_start.py (#14197)realtyem2022-11-082-7/+70
| | | Co-authored-by: reivilibre <oliverw@matrix.org>
* Merge branch 'master' into developSean Quah2022-11-083-3/+16
|\
| * Update CHANGES.md to mention PostgreSQL 10 end of life v1.71.0Sean Quah2022-11-081-0/+2
| |
| * Update CHANGES.mdSean Quah2022-11-081-6/+5
| |
| * 1.71.0Sean Quah2022-11-083-1/+13
| |
* | Allow override for requesting specific worker types for Complement on ↵realtyem2022-11-084-1/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | command line. (#14324) * Expose getting SYNAPSE_WORKER_TYPES from external, allowing override of workers requested. * Add WORKER_TYPES variable option to complement.sh script that passes requested workers into start_for_complement.sh entrypoint. * Update docs to reflect this new ability. * Changelog * Don't rely on soft wrapping to format long strings Good idea dklimpel. Thanks for catching that. Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> * Small nits just noticed in docs. * Fixup new line in docs. Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com>
* | Correctly create power level event during initial room creation (#14361)Shay2022-11-073-4/+26
| |
* | Fix background update table-scanning `events` (#14374)Richard van der Hoff2022-11-072-8/+9
| | | | | | | | | | When this background update did its last batch, it would try to update all the events that had been inserted since the bgupdate started, which could cause a table-scan. Make sure we limit the update correctly.
* | Add example on how to load balance /sync requests (#14297)aceArt-GmbH2022-11-072-3/+6
| | | | | | | | | | Signed-off-by: lukas <lukas.walter@aceart.de> Signed-off-by: lukas <lukas.walter@aceart.de>
* | Do not reject `/sync` requests with unrecognised filter fields (#14369)Sean Quah2022-11-073-6/+24
| | | | | | | | | | | | | | | | For forward compatibility, Synapse needs to ignore fields it does not recognise instead of raising an error. Fixes #14365. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Bump types-jsonschema from 4.4.6 to 4.17.0.0 (#14386)dependabot[bot]2022-11-072-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-jsonschema from 4.4.6 to 4.17.0.0 Bumps [types-jsonschema](https://github.com/python/typeshed) from 4.4.6 to 4.17.0.0. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-jsonschema dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-pyyaml from 6.0.12 to 6.0.12.1 (#14385)dependabot[bot]2022-11-072-5/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-pyyaml from 6.0.12 to 6.0.12.1 Bumps [types-pyyaml](https://github.com/python/typeshed) from 6.0.12 to 6.0.12.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pyyaml dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump cryptography from 36.0.1 to 38.0.3 (#14384)dependabot[bot]2022-11-072-24/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump cryptography from 36.0.1 to 38.0.3 Bumps [cryptography](https://github.com/pyca/cryptography) from 36.0.1 to 38.0.3. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/36.0.1...38.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump pillow from 9.2.0 to 9.3.0 (#14383)dependabot[bot]2022-11-072-59/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump pillow from 9.2.0 to 9.3.0 Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.2.0 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](https://github.com/python-pillow/Pillow/compare/9.2.0...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-setuptools from 65.5.0.1 to 65.5.0.2 (#14382)dependabot[bot]2022-11-072-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-setuptools from 65.5.0.1 to 65.5.0.2 Bumps [types-setuptools](https://github.com/python/typeshed) from 65.5.0.1 to 65.5.0.2. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-setuptools dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump pyo3 from 0.17.2 to 0.17.3 (#14381)dependabot[bot]2022-11-073-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump pyo3 from 0.17.2 to 0.17.3 Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.17.2 to 0.17.3. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md) - [Commits](https://github.com/pyo3/pyo3/compare/v0.17.2...v0.17.3) --- updated-dependencies: - dependency-name: pyo3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump regex from 1.6.0 to 1.7.0 (#14380)dependabot[bot]2022-11-073-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump regex from 1.6.0 to 1.7.0 Bumps [regex](https://github.com/rust-lang/regex) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/regex/compare/1.6.0...1.7.0) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 (#14379)dependabot[bot]2022-11-072-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 Bumps [peaceiris/actions-mdbook](https://github.com/peaceiris/actions-mdbook) from 1.1.14 to 1.2.0. - [Release notes](https://github.com/peaceiris/actions-mdbook/releases) - [Changelog](https://github.com/peaceiris/actions-mdbook/blob/main/CHANGELOG.md) - [Commits](https://github.com/peaceiris/actions-mdbook/compare/v1.1.14...adeb05db28a0c0004681db83893d56c0388ea9ea) --- updated-dependencies: - dependency-name: peaceiris/actions-mdbook dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump dawidd6/action-download-artifact from 2.15.0 to 2.24.0 (#14378)dependabot[bot]2022-11-072-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump dawidd6/action-download-artifact from 2.15.0 to 2.24.0 Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 2.15.0 to 2.24.0. - [Release notes](https://github.com/dawidd6/action-download-artifact/releases) - [Commits](https://github.com/dawidd6/action-download-artifact/compare/af92a8455a59214b7b932932f2662fdefbd78126...46b4ae883bf0726f5949d025d31cb62c7a5ac70c) --- updated-dependencies: - dependency-name: dawidd6/action-download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump flake8-bugbear from 22.9.23 to 22.10.27 (#14329)dependabot[bot]2022-11-045-9/+12
| | | | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Fix the trigger path for deploying documentation PRs (#14370)Brendan Abolivier2022-11-042-1/+2
| | | | | | This was missed from #12947
* | Upload documentation PRs to Netlify (#12947)Michael Telatynski2022-11-043-0/+69
| | | | | | | | | | | | Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: David Robertson <davidr@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Fix /refresh endpoint version (#14364)Tulir Asokan2022-11-043-9/+10
| |
* | Merge tag 'v1.71.0rc2' into developSean Quah2022-11-048-7/+59
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.71.0rc2 (2022-11-04) ============================== Please note that, as announced in the release notes for Synapse 1.69.0, legacy Prometheus metric names are now disabled by default. They will be removed altogether in Synapse 1.73.0. If not already done, server administrators should update their dashboards and alerting rules to avoid using the deprecated metric names. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.71/upgrade.html#upgrading-to-v1710) for more details. Improved Documentation ---------------------- - Document the changes to monthly active user metrics due to deprecation of legacy Prometheus metric names. ([\#14358](https://github.com/matrix-org/synapse/issues/14358), [\#14360](https://github.com/matrix-org/synapse/issues/14360)) Deprecations and Removals ------------------------- - Disable legacy Prometheus metric names by default. They can still be re-enabled for now, but they will be removed altogether in Synapse 1.73.0. ([\#14353](https://github.com/matrix-org/synapse/issues/14353)) Internal Changes ---------------- - Run unit tests against Python 3.11. ([\#13812](https://github.com/matrix-org/synapse/issues/13812))
| * Update CHANGES.md v1.71.0rc2Sean Quah2022-11-041-11/+7
| |
| * 1.71.0rc2Sean Quah2022-11-047-5/+29
| |
| * Include monthly active user metrics in the list of legacy metrics names ↵David Robertson2022-11-042-0/+4
| | | | | | | | (#14360)
| * Cherry-pick "Run trial tests against Python 3.11 (#13812)" and fixup commitDavid Robertson2022-11-035-94/+146
| | | | | | | | | | | | | | | | | | 4f5d492cd6a9438de03d1b768f4c220cb662ac06 The release branch CI is failing because poetry seems unable to install wrapt 1.13.3 when run under CPython 3.11. Develop has already bumped wrapt for 3.11 compatibility. Cherry-pick that commit here to try and get CI going again.
| * Update legacy `synapse_admin_mau:` metric names in docs (#14358)Will Hunt2022-11-032-3/+4
| | | | | | | | | | * Rename legacy metrics in MAU docs * changelog
| * Disable legacy Prometheus metric names by default. They can still be ↵reivilibre2022-11-025-3/+29
| | | | | | | | re-enabled for now, but they will be removed altogether in Synapse 1.73.0. (#14353)
* | Implement MSC3912: Relation-based redactions (#14260)Brendan Abolivier2022-11-0310-28/+486
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Use maintained action to install Rust in latest deps/twisted trunk jobs (#14351)David Robertson2022-11-023-18/+13
| | | | | | | | | | | | | | * Use maintained action to install Rust Part of #14203. Like the changes in #14313. * Changelog
* | Fix issue automation for Needs-Info (#14343)Kat Gerasimova2022-11-011-27/+27
| | | | | | | | | | Run when an issue is labelled with X-Needs-Info only. Add to triage board. Use itemId which is output by actions/add-to-project to run the mutation to update the field value (i.e. move to the right column).
* | Fix typo in #13320 which could cause log spam (#14347)David Robertson2022-11-012-1/+2
| |
* | Enable testing MSC3874 in complement. (#14339)Patrick Cloke2022-11-013-3/+4
| |
* | Allow PUT/GET of aliases during faster join (#14292)David Robertson2022-11-012-2/+3
| | | | | | without blocking on full state.
* | Merge branch 'release-v1.71' into developDavid Robertson2022-11-0155-54/+89
|\|
| * Adjust changelog v1.71.0rc1David Robertson2022-11-011-25/+34
| |
| * 1.71.0rc1David Robertson2022-11-0155-54/+80
| |
* | Bump twisted from 22.8.0 to 22.10.0 (#14340)dependabot[bot]2022-11-012-12/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump twisted from 22.8.0 to 22.10.0 Bumps [twisted](https://github.com/twisted/twisted) from 22.8.0 to 22.10.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](https://github.com/twisted/twisted/compare/twisted-22.8.0...twisted-22.10.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Deal with another batch of GHA warning messages (#14313)David Robertson2022-11-012-16/+39
| |
* | Revert a testing commit from #13812David Robertson2022-11-011-3/+3
| | | | | | | | It (4f5d492cd6a9438de03d1b768f4c220cb662ac06) should have been reverted before the merge to develop.
* | Run trial tests against Python 3.11 (#13812)David Robertson2022-11-015-97/+149
|/
* Revert "Fix event size checks (#13710)"David Robertson2022-11-012-6/+5
| | | | | | | | | | | This reverts commit fab495a9e1442d99e922367f65f41de5eaa488eb. As noted in https://github.com/matrix-org/synapse/pull/13710#issuecomment-1298396007: > We want to see this change land for the protocol's sake (and plan to un-revert it) but want to give this a little more time before releasing this.
* Fix type annotation causing import time error in the Complement forking ↵reivilibre2022-11-012-2/+3
| | | | | launcher. (#14084) Co-authored-by: David Robertson <davidr@element.io>
* Fix dehydrated device REST checks (#14336)David Robertson2022-10-313-3/+37
|
* Support OIDC backchannel logouts (#11414)Quentin Gliech2022-10-3113-66/+960
| | | | | | | If configured an OIDC IdP can log a user's session out of Synapse when they log out of the identity provider. The IdP sends a request directly to Synapse (and must be configured with an endpoint) when a user logs out.
* Bump sentry-sdk from 1.5.11 to 1.10.1 (#14330)dependabot[bot]2022-10-312-10/+13
| | | | | | | | | | | | | | | | | | | | | | | * Bump sentry-sdk from 1.5.11 to 1.10.1 Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 1.5.11 to 1.10.1. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-python/compare/1.5.11...1.10.1) --- updated-dependencies: - dependency-name: sentry-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump psycopg2 from 2.9.4 to 2.9.5 (#14331)dependabot[bot]2022-10-312-12/+13
| | | | | | | | | | | | | | | | | | | | | | | * Bump psycopg2 from 2.9.4 to 2.9.5 Bumps [psycopg2](https://github.com/psycopg/psycopg2) from 2.9.4 to 2.9.5. - [Release notes](https://github.com/psycopg/psycopg2/releases) - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS) - [Commits](https://github.com/psycopg/psycopg2/commits) --- updated-dependencies: - dependency-name: psycopg2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump twine from 3.8.0 to 4.0.1 (#14332)dependabot[bot]2022-10-312-31/+31
| | | | | | | | | | | | | | | | | | | | | | | * Bump twine from 3.8.0 to 4.0.1 Bumps [twine](https://github.com/pypa/twine) from 3.8.0 to 4.0.1. - [Release notes](https://github.com/pypa/twine/releases) - [Changelog](https://github.com/pypa/twine/blob/main/docs/changelog.rst) - [Commits](https://github.com/pypa/twine/compare/3.8.0...4.0.1) --- updated-dependencies: - dependency-name: twine dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump black from 22.3.0 to 22.10.0 (#14328)dependabot[bot]2022-10-312-27/+26
| | | | | | | | | | | | | | | | | | | | | | | * Bump black from 22.3.0 to 22.10.0 Bumps [black](https://github.com/psf/black) from 22.3.0 to 22.10.0. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/main/CHANGES.md) - [Commits](https://github.com/psf/black/compare/22.3.0...22.10.0) --- updated-dependencies: - dependency-name: black dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Avoid incrementing bg process utime/stime counters by negative durations ↵David Robertson2022-10-316-5/+35
| | | | (#14323)
* Prevent federation user keys query from returning device names if disallowed ↵Andrew Morgan2022-10-283-9/+46
| | | | (#14304)
* Improve `RawHeaders` type hints (#14303)David Robertson2022-10-283-9/+24
|
* Switch search SQL to triple-quote strings. (#14311)Patrick Cloke2022-10-282-89/+100
| | | | For ease of reading we switch from concatenated strings to triple quote strings.
* Merge branch 'master' into developAndrew Morgan2022-10-281-0/+8
|\
| * Add a note that #14300 did not get a fix for 1.70.1 (#14318)Andrew Morgan2022-10-281-0/+8
| |
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-10-288-18/+98
|\|
| * Tweak changelog v1.70.1Olivier Wilkinson (reivilibre)2022-10-281-1/+1
| |
| * 1.70.1Olivier Wilkinson (reivilibre)2022-10-285-3/+17
| |
| * Fix room creation being rate limited too aggressively since Synapse v1.69.0. ↵reivilibre2022-10-284-9/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#14314) * Introduce a test for the old behaviour which we want to restore * Reintroduce the old behaviour in a simpler way * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Use 1 credit instead of 2 for creating a room: be more lenient than before Notably, the UI in Element Web was still broken after restoring to prior behaviour. After discussion, we agreed that it would be sensible to increase the limit. Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Fix incorrectly sending authentication tokens to application service as ↵David Robertson2022-10-263-8/+13
| | | | | | | | headers (#14301)
* | Add docs for an empty `trusted_key_servers` config option (#13999)Dirk Klimpel2022-10-282-0/+7
| | | | | | | | | | | | | | * Add docs for an empty `trusted_key_servers` config option * small rewording * Tweak changelog
* | Check appservice user interest against the local users instead of all users ↵Eric Eastwood2022-10-277-14/+214
| | | | | | | | (`get_users_in_room` mis-use) (#13958)
* | Fix tests for change in PostgreSQL 14 behavior change. (#14310)Patrick Cloke2022-10-273-7/+15
| | | | | | | | | | | | | | PostgreSQL 14 changed the behavior of `websearch_to_tsquery` to improve some behaviour. The tests were hitting those edge-cases about handling of hanging double quotes. This fixes the tests to take into account the PostgreSQL version.
* | Add workers settings to configuration manual (#14086)Dirk Klimpel2022-10-275-82/+291
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add workers settings to configuration manual * Update `pusher_instances` * update url to python logger * update headlines * update links after headline change * remove link from `daemon process` There is no docs in Synapse for this * extend example for `federation_sender_instances` and `pusher_instances` * more infos about stream writers * add link to DAG * update `pusher_instances` * update `worker_listeners` * update `stream_writers` * Update `worker_name` Co-authored-by: David Robertson <davidr@element.io>
* | Fix presence bug introduced in 1.64 by #13313 (#14243)Mathieu Velten2022-10-272-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | * Fix presence bug introduced in 1.64 by #13313 Signed-off-by: Mathieu Velten <mathieuv@matrix.org> * Add changelog * Add DISTINCT * Apply suggestions from code review Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
* | Reject history insertion during partial joins (#14291)David Robertson2022-10-272-0/+8
| |
* | Refactor MSC3030 `/timestamp_to_event` to move away from our snowflake pull ↵Eric Eastwood2022-10-267-126/+191
| | | | | | | | | | | | | | | | | | from `destination` pattern (#14096) 1. `federation_client.timestamp_to_event(...)` now handles all `destination` looping and uses our generic `_try_destination_list(...)` helper. 2. Consistently handling `NotRetryingDestination` and `FederationDeniedError` across `get_pdu` , backfill, and the generic `_try_destination_list` which is used for many places we use this pattern. 3. `get_pdu(...)` now returns `PulledPduInfo` so we know which `destination` we ended up pulling the PDU from
* | Use poetry 1.2 for complement in latest deps (#14305)David Robertson2022-10-262-2/+2
| |
* | fix broken avatar checks when server_name contains a port (#13927)Ashish Kumar2022-10-263-1/+55
| | | | | | | | | | | | Fixes check_avatar_size_and_mime_type() to successfully update avatars on homeservers running on non-default ports which it would mistakenly treat as remote homeserver while validating the avatar's size and mime type. Signed-off-by: Ashish Kumar ashfame@users.noreply.github.com
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-10-263-1/+13
|\|
| * 1.70.0 v1.70.0Olivier Wilkinson (reivilibre)2022-10-263-1/+13
| |
* | Save login tokens in database (#13844)Quentin Gliech2022-10-2611-227/+337
| | | | | | | | | | | | | | | | | | | | | | * Save login tokens in database Signed-off-by: Quentin Gliech <quenting@element.io> * Add upgrade notes * Track login token reuse in a Prometheus metric Signed-off-by: Quentin Gliech <quenting@element.io>
* | Unified search query syntax using the full-text search capabilities of the ↵James Salter2022-10-255-35/+454
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | underlying DB. (#11635) Support a unified search query syntax which leverages more of the full-text search of each database supported by Synapse. Supports, with the same syntax across Postgresql 11+ and Sqlite: - quoted "search terms" - `AND`, `OR`, `-` (negation) operators - Matching words based on their stem, e.g. searches for "dog" matches documents containing "dogs". This is achieved by - If on postgresql 11+, pass the user input to `websearch_to_tsquery` - If on sqlite, manually parse the query and transform it into the sqlite-specific query syntax. Note that postgresql 10, which is close to end-of-life, falls back to using `phraseto_tsquery`, which only supports a subset of the features. Multiple terms separated by a space are implicitly ANDed. Note that: 1. There is no escaping of full-text syntax that might be supported by the database; e.g. `NOT`, `NEAR`, `*` in sqlite. This runs the risk that people might discover this as accidental functionality and depend on something we don't guarantee. 2. English text is assumed for stemming. To support other languages, either the target language needs to be known at the time of indexing the message (via room metadata, or otherwise), or a separate index for each language supported could be created. Sqlite docs: https://www.sqlite.org/fts3.html#full_text_index_queries Postgres docs: https://www.postgresql.org/docs/11/textsearch-controls.html
* | Merge branch 'release-v1.70' into developOlivier Wilkinson (reivilibre)2022-10-258-53/+305
|\|
| * Tweak changelog v1.70.0rc2Olivier Wilkinson (reivilibre)2022-10-251-1/+1
| |
| * 1.70.0rc2Olivier Wilkinson (reivilibre)2022-10-258-6/+25
| |
| * Revert behavior change for bundling edits of non-message events (#14283)Patrick Cloke2022-10-242-4/+8
| |
| * Fix typo in cibuildwheel conf introduced in #14253David Robertson2022-10-241-1/+1
| |
| * Fix `TypeError: 'dict_keys' object is not reversible` (#14280)Erik Johnston2022-10-242-2/+2
| |
| * Only build aarch64 wheels for cpython manylinux (#14259)Erik Johnston2022-10-212-1/+2
| |
| * Try building ABI3 wheels for cpython (#14253)Erik Johnston2022-10-213-0/+142
| |
| * Properly update the threads table when thread events are redacted. (#14248)Patrick Cloke2022-10-213-43/+129
| | | | | | | | | | | | | | | | | | When the last event in a thread is redacted we need to update the threads table: * Find the new latest event in the thread and store it into the table; or * Remove the thread from the table if it is no longer a thread (i.e. all events in the thread were redacted).
| * Update changelog entry for #10015.David Robertson2022-10-201-1/+1
| | | | | | | | Per https://github.com/matrix-org/synapse/pull/10015#issuecomment-1282773048
* | Refactor OIDC tests to better mimic an actual OIDC provider. (#13910)Quentin Gliech2022-10-2510-460/+747
| | | | | | | | | | | | | | | | | | This implements a fake OIDC server, which intercepts calls to the HTTP client. Improves accuracy of tests by covering more internal methods. One particular example was the ID token validation, which previously mocked. This uncovered an incorrect dependency: Synapse actually requires at least authlib 0.15.1, not 0.14.0.
* | Implementation for MSC3664: Pushrules for relations (#11804)DeepBlueV7.X2022-10-2510-17/+454
| |
* | Remove unused `@lru_cache` decorator (#13595)Nick Mills-Barrett2022-10-253-140/+5
| | | | | | | | | | | | | | * Remove unused `@lru_cache` decorator Spotted this working on something else. Co-authored-by: David Robertson <davidr@element.io>
* | Cache rust build deps in trial CI (#14287)Erik Johnston2022-10-252-0/+9
| |
* | Enable WAL for SQLite (#13897)asymmetric2022-10-252-0/+5
| | | | | | Signed-off-by: Lorenzo Manacorda <lorenzo@mailbox.org>
* | Return NOT_JSON if decode fails and defer set_timeline_upper_limit ca… ↵Ryan Miguel2022-10-242-4/+5
| | | | | | | | | | | | | | (#14262) * Return NOT_JSON if decode fails and defer set_timeline_upper_limit call until after check_valid_filter. Fixes #13661. Signed-off-by: Ryan Miguel <miguel.ryanj@gmail.com>. * Reword changelog
* | Bump serde_json from 1.0.86 to 1.0.87 (#14279)dependabot[bot]2022-10-243-3/+4
| |
* | Bump peaceiris/actions-gh-pages from 3.8.0 to 3.9.0 (#14276)dependabot[bot]2022-10-242-1/+2
| |
* | Bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 (#14275)dependabot[bot]2022-10-242-1/+2
| |
* | Add debugging to help diagnose lost device-list-update (#14268)Richard van der Hoff2022-10-242-17/+38
| |
* | Bump pysaml2 from 7.1.2 to 7.2.1 (#14270)dependabot[bot]2022-10-242-4/+5
| |
* | Bump jinja2 from 3.0.3 to 3.1.2 (#14271)dependabot[bot]2022-10-242-4/+5
| |
* | Bump types-requests from 2.28.11 to 2.28.11.2 (#14272)dependabot[bot]2022-10-242-3/+4
| |
* | Bump setuptools-rust from 1.5.1 to 1.5.2 (#14273)dependabot[bot]2022-10-242-3/+4
| |
* | Bump prometheus-client from 0.14.0 to 0.15.0 (#14274)dependabot[bot]2022-10-242-3/+4
| |
* | Bump anyhow from 1.0.65 to 1.0.66 (#14278)dependabot[bot]2022-10-243-3/+4
| |
* | Bump serde from 1.0.145 to 1.0.147 (#14277)dependabot[bot]2022-10-243-5/+6
| |
* | Add initial power level event to batch of bulk persisted events when ↵Shay2022-10-218-58/+82
| | | | | | | | creating a new room. (#14228)
* | Improve aesthetics and reusability of HTML templates. (#13652)Germain2022-10-2131-740/+691
| | | | | | | | | | | | | | Use a base template to create a cohesive feel across the HTML templates provided by Synapse. Adds basic styling to the base template for a more user-friendly look and feel.
* | Fix logging error on SIGHUP (#14258)Richard van der Hoff2022-10-212-1/+3
| |
* | Show erasure status when listing users in the Admin API (#14205)Tadeusz Sośnierz2022-10-215-3/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Show erasure status when listing users in the Admin API * Use USING when joining erased_users * Add changelog entry * Revert "Use USING when joining erased_users" This reverts commit 30bd2bf106415caadcfdbdd1b234ef2b106cc394. * Make the erased check work on postgres * Add a testcase for showing erased user status * Appease the style linter * Explicitly convert `erased` to bool to make SQLite consistent with Postgres This also adds us an easy way in to fix the other accidentally integered columns. * Move erasure status test to UsersListTestCase * Include user erased status when fetching user info via the admin API * Document the erase status in user_admin_api * Appease the linter and mypy * Signpost comments in tests Co-authored-by: Tadeusz Sośnierz <tadeusz@sosnierz.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Fix event size checks (#13710)DeepBlueV7.X2022-10-212-5/+6
| |
* | Build wheels on macos 11, not 10.15 (#14249)David Robertson2022-10-202-3/+4
| |
* | Use servlets for /key/ endpoints. (#14229)Patrick Cloke2022-10-209-83/+86
| | | | | | | | | | To fix the response for unknown endpoints under that prefix. See MSC3743.
* | Stop returning `unsigned.invite_room_state` in `PUT ↵Andrew Morgan2022-10-202-0/+6
| | | | | | | | | | /_matrix/federation/v2/invite/{roomId}/{eventId}` responses (#14064) Co-authored-by: David Robertson <davidr@element.io>
* | Merge branch 'release-v1.70' into developErik Johnston2022-10-20105-104/+103
|\|
| * Remove poetry.lock updates v1.70.0rc1Erik Johnston2022-10-191-22/+0
| |
| * Update lockfileErik Johnston2022-10-191-9/+8
| |
| * 1.70.0rc1Erik Johnston2022-10-19105-104/+126
| |
* | Explain `SynapseError` and `FederationError` better (#14191)Eric Eastwood2022-10-193-3/+30
| | | | | | | | | | Explain `SynapseError` and `FederationError` better Spawning from https://github.com/matrix-org/synapse/pull/13816#discussion_r993262622
* | Bump types-opentracing from 2.4.7 to 2.4.10 (#14133)dependabot[bot]2022-10-192-3/+4
| | | | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com> Co-authored-by: reivilibre <oliverw@matrix.org>
* | Bump flake8-bugbear from 21.3.2 to 22.9.23 (#14042)dependabot[bot]2022-10-198-15/+22
| | | | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: David Robertson <davidr@element.io>
* | Document encryption_enabled_by_default_for_room_type under the right name ↵Matthew Hodgson2022-10-192-1/+2
| | | | | | | | | | | | | | | | | | (#14110) * document encryption_enabled_by_default_for_room_type under the right name * add changelog * Update changelog.d/14110.doc
* | let update_synapse_database run on a multi-database configurations (#13422)Finn2022-10-192-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow sharded database in db migrate script Signed-off-by: Finn Herzfeld <finn@beeper.com> * Update changelog.d/13422.bugfix Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Remove check entirely * remove unused import Signed-off-by: Finn Herzfeld <finn@beeper.com> Co-authored-by: finn <finn@beeper.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Use backend-meta edition of issue triage workflow (#14230)Will Hunt2022-10-192-21/+9
|/
* Fix MSC3030 `/timestamp_to_event` returning `outliers` that it has no idea ↵Eric Eastwood2022-10-183-21/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | whether are near a gap or not (#14215) Fix MSC3030 `/timestamp_to_event` endpoint returning `outliers` that it has no idea whether are near a gap or not (and therefore unable to determine whether it's actually the closest event). The reason Synapse doesn't know whether an `outlier` is next to a gap is because our gap checks rely on entries in the `event_edges`, `event_forward_extremeties`, and `event_backward_extremities` tables which is [not the case for `outliers`](https://github.com/matrix-org/synapse/blob/2c63cdcc3f1aa4625e947de3c23e0a8133c61286/docs/development/room-dag-concepts.md#outliers). Also fixes MSC3030 Complement `can_paginate_after_getting_remote_event_from_timestamp_to_event_endpoint` test flake. Although this acted flakey in Complement, if `sync_partial_state` raced and beat us before `/timestamp_to_event`, then even if we retried the failing `/context` request it wouldn't work until we made this Synapse change. With this PR, Synapse will never return an `outlier` event so that test will always go and ask over federation. Fix https://github.com/matrix-org/synapse/issues/13944 ### Why did this fail before? Why was it flakey? Sleuthing the server logs on the [CI failure](https://github.com/matrix-org/synapse/actions/runs/3149623842/jobs/5121449357#step:5:5805), it looks like `hs2:/timestamp_to_event` found `$NP6-oU7mIFVyhtKfGvfrEQX949hQX-T-gvuauG6eurU` as an `outlier` event locally. Then when we went and asked for it via `/context`, since it's an `outlier`, it was filtered out of the results -> `You don't have permission to access that event.` This is reproducible when `sync_partial_state` races and persists `$NP6-oU7mIFVyhtKfGvfrEQX949hQX-T-gvuauG6eurU` as an `outlier` before we evaluate `get_event_for_timestamp(...)`. To consistently reproduce locally, just add a delay at the [start of `get_event_for_timestamp(...)`](https://github.com/matrix-org/synapse/blob/cb20b885cb4bd1648581dd043a184d86fc8c7a00/synapse/handlers/room.py#L1470-L1496) so it always runs after `sync_partial_state` completes. ```py from twisted.internet import task as twisted_task d = twisted_task.deferLater(self.hs.get_reactor(), 3.5) await d ``` In a run where it passes, on `hs2`, `get_event_for_timestamp(...)` finds a different event locally which is next to a gap and we request from a closer one from `hs1` which gets backfilled. And since the backfilled event is not an `outlier`, it's returned as expected during `/context`. With this PR, Synapse will never return an `outlier` event so that test will always go and ask over federation.
* Fix hiding devices names over federation (#10015)Aaron Raimist2022-10-182-2/+9
| | | | | | And don't include blank opentracing stuff in device list updates. Signed-off-by: Aaron Raimist <aaron@raim.ist>
* Fix docstring in EventContext (#14145)Shay2022-10-182-1/+4
|
* Add aarch64 wheels to CI (#14212)MichaIng2022-10-182-5/+26
| | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Bump twisted from 22.4.0 to 22.8.0 (#14207)dependabot[bot]2022-10-182-13/+15
| | | | | | | | | | | | | | | | | | | | | | | * Bump twisted from 22.4.0 to 22.8.0 Bumps [twisted](https://github.com/twisted/twisted) from 22.4.0 to 22.8.0. - [Release notes](https://github.com/twisted/twisted/releases) - [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst) - [Commits](https://github.com/twisted/twisted/compare/twisted-22.4.0...twisted-22.8.0) --- updated-dependencies: - dependency-name: twisted dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Prepatory work for adding power level event to batched events (#14214)Shay2022-10-186-17/+47
|
* Bump pygithub from 1.55 to 1.56 (#14206)dependabot[bot]2022-10-182-4/+5
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Bump types-setuptools from 65.4.0.0 to 65.5.0.1 (#14208)dependabot[bot]2022-10-182-3/+4
| | | | | | | | | | | | | | | | | | | | | | * Bump types-setuptools from 65.4.0.0 to 65.5.0.1 Bumps [types-setuptools](https://github.com/python/typeshed) from 65.4.0.0 to 65.5.0.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-setuptools dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* Implementation of HTTP 307 response for MSC3886 POST endpoint (#14018)Hugh Nimmo-Smith2022-10-1816-45/+257
| | | | Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: Andrew Morgan <andrewm@element.io>
* Don't pin dev-deps in pyproject; use lower bounds (#14227)David Robertson2022-10-183-7/+8
| | | | | | | | | | | * Don't pin dev-deps in pyproject; use lower bounds This makes it slightly less tedious to update these things via successive dependabot updates, by reducing the likelihood of a merge conflict. * Changelog * Changelog
* Fixes to release-artifacts warnings (#14224)David Robertson2022-10-182-0/+5
|
* Update the thread_id right before use (in case the bg update hasn't ↵Patrick Cloke2022-10-185-134/+112
| | | | | | | | finished) (#14222) This avoids running a forced-update of a null thread_id rows. An index is added (in the background) to hopefully make this easier in the future.
* Enable URL previews in complement homeserver config. (#14198)Jonathan de Jong2022-10-182-0/+3
|
* Fix `track_memory_usage` on poetry-core 1.3.x installations (#14221)David Robertson2022-10-183-3/+4
| | | | | | | | | | | | | * Fix `track_memory_usage` on poetry-core 1.3.x installations The same kind of problem as discussed in #14085: 1. we defined an extra with an underscore 2. we look it up at runtime with an underscore 3. but poetry-core 1.3.x. installs it with a dash, causing (2) to fail. Fix by using a dash everywhere. * Changelog
* Deal with some GHA deprecation warnings (#14216)David Robertson2022-10-184-4/+12
|
* Flush stdout/err in Dockerfile-workers before replacing the current process ↵realtyem2022-10-183-17/+22
| | | | | | | (#14195) Also update `subprocess.check_output` to the slightly newer `subprocess.run`. Signed-off-by: Jason Little <realtyem@gmail.com>
* When restarting a partial join resync, prioritise the server which actioned ↵David Robertson2022-10-186-31/+95
| | | | a partial join (#14126)
* Allow poetry-core 1.3.2 (#14217)Ivan Shapovalov2022-10-182-1/+2
| | | Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
* Avoid checking the event cache when backfilling events (#14164)Andrew Morgan2022-10-184-15/+140
|
* Remove `_get_events_cache` check optimisation from `_have_seen_events_dict` ↵Andrew Morgan2022-10-183-30/+14
| | | | (#14161)
* Add debug logs to figure out why an event was filtered (#14095)Eric Eastwood2022-10-172-1/+32
| | | | | | | | | | | | | | | | Spawned while investigating https://github.com/matrix-org/synapse/issues/13944 This way we might get some more context whenever an `403 Forbidden - body: {"errcode":"M_FORBIDDEN","error":"You don't have permission to access that event."}` error is produced. `log_config.yaml` ```yaml loggers: synapse: level: INFO synapse.visibility: level: DEBUG ```
* Cache Rust build cache when building docker images (#14130)Erik Johnston2022-10-173-1/+5
|
* Bump click from 8.1.1 to 8.1.3 (#14201)dependabot[bot]2022-10-173-5/+6
|
* Merge branch 'master' into developErik Johnston2022-10-173-3/+15
|\
| * 1.69.0 v1.69.0Erik Johnston2022-10-173-3/+15
| |
* | Support filtering the /messages API by relation type (MSC3874). (#14148)Patrick Cloke2022-10-179-177/+212
| | | | | | Gated behind an experimental configuration flag.
* | Bump psycopg2 from 2.9.3 to 2.9.4 (#14200)dependabot[bot]2022-10-172-12/+13
| |
* | Bump bcrypt from 3.2.0 to 4.0.1 (#14186)dependabot[bot]2022-10-172-15/+23
| |
* | Use Pydantic when PUTting room aliases (#14179)David Robertson2022-10-173-31/+47
| |
* | Invalidate rooms for user caches when receiving membership events (#14155)Nick Mills-Barrett2022-10-172-0/+5
| | | | | | | | | | This should fix a race where the event notification comes in over replication before the state replication, leaving a window during which a sync may get an incorrect list of rooms for the user.
* | Fix dead link to admin registration API (#14189)David Robertson2022-10-172-1/+2
| | | | | | | | | | * Fix dead link to admin registration API * Changelog
* | Remove not needed `replication` listener in docker compose example (#14107)Dirk Klimpel2022-10-174-25/+2
| |
* | Stop getting missing `prev_events` after we already know their signature is ↵Eric Eastwood2022-10-157-2/+386
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | invalid (#13816) While https://github.com/matrix-org/synapse/pull/13635 stops us from doing the slow thing after we've already done it once, this PR stops us from doing one of the slow things in the first place. Related to - https://github.com/matrix-org/synapse/issues/13622 - https://github.com/matrix-org/synapse/pull/13635 - https://github.com/matrix-org/synapse/issues/13676 Part of https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13815 which tracks event signature failures. With this PR, we avoid the call to the costly `_get_state_ids_after_missing_prev_event` because the signature failure will count as an attempt before and we filter events based on the backoff before calling `_get_state_ids_after_missing_prev_event` now. For example, this will save us 156s out of the 185s total that this `matrix.org` `/messages` request. If you want to see the full Jaeger trace of this, you can drag and drop this `trace.json` into your own Jaeger, https://gist.github.com/MadLittleMods/4b12d0d0afe88c2f65ffcc907306b761 To explain this exact scenario around `/messages` -> backfill, we call `/backfill` and first check the signatures of the 100 events. We see bad signature for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` and `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` (both member events). Then we process the 98 events remaining that have valid signatures but one of the events references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event`. So we have to do the whole `_get_state_ids_after_missing_prev_event` rigmarole which pulls in those same events which fail again because the signatures are still invalid. - `backfill` - `outgoing-federation-request` `/backfill` - `_check_sigs_and_hash_and_fetch` - `_check_sigs_and_hash_and_fetch_one` for each event received over backfill - ❗ `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - ❗ `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - `_process_pulled_events` - `_process_pulled_event` for each validated event - ❗ Event `$Q0iMdqtz3IJYfZQU2Xk2WjB5NDF8Gg8cFSYYyKQgKJ0` references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event` which is missing so we try to get it - `_get_state_ids_after_missing_prev_event` - `outgoing-federation-request` `/state_ids` - ❗ `get_pdu` for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` which fails the signature check again - ❗ `get_pdu` for `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` which fails the signature check
* | Bump types-bleach from 4.1.4 to 5.0.3 (#14188)dependabot[bot]2022-10-142-3/+4
| | | | | | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Bump types-pillow from 9.2.2 to 9.2.2.1 (#14187)dependabot[bot]2022-10-152-20/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Bump types-pillow from 9.2.2 to 9.2.2.1 Bumps [types-pillow](https://github.com/python/typeshed) from 9.2.2 to 9.2.2.1. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-pillow dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
* | Strip whitespace from worker types in Dockerfile-workers (#14165)realtyem2022-10-142-4/+3
| |
* | Merge remote-tracking branch 'origin/release-v1.69' into developPatrick Cloke2022-10-149-22/+145
|\|
| * 1.69.0rc4 v1.69.0rc4Erik Johnston2022-10-146-5/+23
| |
| * Fix background update to use an index (#14181)Erik Johnston2022-10-142-11/+52
| |
| * Revert "Disable push of docker images"Erik Johnston2022-10-141-1/+1
| | | | | | | | This reverts commit f3f303aa22b9681c21468fb0bdce1b21d1bdbd92.
| * Fix docker workflowErik Johnston2022-10-141-3/+5
| |
| * Disable push of docker imagesErik Johnston2022-10-141-1/+1
| |
| * Fix docker build OOMing in CI for arm64 builds (#14173)Erik Johnston2022-10-133-1/+11
| | | | | | Co-authored-by: David Robertson <davidr@element.io>
| * Optimise the event_push_backfill_thread_id bg job (#14172)David Robertson2022-10-132-2/+9
| | | | | | Co-authored-by: Erik Johnston <erik@matrix.org>
| * Fixup changelog v1.69.0rc3Erik Johnston2022-10-121-6/+6
| |
| * 1.69.0rc3Erik Johnston2022-10-127-5/+24
| |
| * Fix rotating existing notifications in push summary (#14138)Erik Johnston2022-10-112-5/+16
| | | | | | | | | | Broke by #14045. Fixes #14120. Introduced in v1.69.0rc2.
| * Fallback if 'approved' isn't included in a registration replication request ↵Brendan Abolivier2022-10-112-1/+18
| | | | | | | | (#14135)