summary refs log tree commit diff
Commit message (Expand)AuthorAgeFilesLines
* Fix bug /sync returning 404 (#12729)Erik Johnston2022-05-162-8/+12
* other fixes v1.59.0rc1David Robertson2022-05-101-2/+2
* backquote `m.room.server_acl`David Robertson2022-05-101-1/+1
* v1 -> 1David Robertson2022-05-101-4/+4
* Fix deprecation noticeDavid Robertson2022-05-101-1/+1
* I manually added O's change, remove newsfileDavid Robertson2022-05-101-1/+0
* Add Olivier's last-minute mergeDavid Robertson2022-05-101-0/+1
* Group release script changesDavid Robertson2022-05-101-1/+1
* Fix changelog linkDavid Robertson2022-05-101-1/+1
* Add the `update_user_directory_from_worker` configuration option (superseding...reivilibre2022-05-109-34/+76
* Changelog typoDavid Robertson2022-05-101-1/+1
* Adjust changelogDavid Robertson2022-05-101-25/+29
* 1.59.0rc1David Robertson2022-05-1065-66/+96
* Immediately retry any requests that have backed off when a server comes back ...Erik Johnston2022-05-106-6/+179
* Implement MSC3786: Add a default push rule to ignore m.room.server_acl events...Å imon Brandner2022-05-104-11/+56
* Update `replication.md` with info on TCP module structure (#12621)Shay2022-05-093-1/+7
* Update SQL statements in docs for Synapse Admins (#12536)Dirk Klimpel2022-05-092-70/+122
* Tweaks to workers-under-complement (#12637)Richard van der Hoff2022-05-093-5/+15
* Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665)Val Lorentz2022-05-092-1/+2
* Implement cancellation support/protection for module callbacks (#12568)Sean Quah2022-05-096-27/+86
* Fix mypy against latest pillow stubs (#12671)David Robertson2022-05-093-6/+7
* Update changelog for #12587 to be more accurate (#12663)Sean Quah2022-05-092-1/+2
* Use `ParamSpec` in a few places (#12667)David Robertson2022-05-0914-68/+148
* Don't error on unknown receipt types (#12670)Erik Johnston2022-05-092-12/+16
* docs(contrib): Add link to documentation in dashboard (#12602)Sheogorath2022-05-092-1/+14
* Fix docs on how to run specific Complement tests after recent `complement.sh`...Eric Eastwood2022-05-092-2/+3
* Use `Concatenate` to annotate `do_execute` (#12666)David Robertson2022-05-093-6/+16
* Move `pympler` back into the `all` extras (#12652)David Robertson2022-05-075-6/+15
* Convert stringy power levels to integers on room upgrade (#12657)David Robertson2022-05-075-24/+137
* Prevent memory leak from reoccurring when presence is disabled. (#12656)Erik Johnston2022-05-063-28/+54
* Update mypy to 0.950 and fix complaints (#12650)David Robertson2022-05-0610-57/+98
* Add the `notify_appservices_from_worker` configuration option (superseding `n...reivilibre2022-05-069-21/+447
* Merge branch 'master' into developAndrew Morgan2022-05-054-2/+27
|\
| * Update v1.58.1 changelog entry with more familiar language v1.58.1Andrew Morgan2022-05-051-2/+2
| * link to relevant bug report in v1.58.1 changelogAndrew Morgan2022-05-051-1/+2
| * Minor wording change to v1.58.1 release notesAndrew Morgan2022-05-051-1/+1
| * 1.58.1Andrew Morgan2022-05-053-3/+15
| * Include extra dependency groups 'systemd' and 'cache_memory' in debian packag...Andrew Morgan2022-05-052-1/+13
* | Support MSC3266 room summaries over federation (#11507)DeepBlueV7.X2022-05-054-5/+78
* | Update `_on_new_receipts()` to work with MSC2285 changes. (#12636)Å imon Brandner2022-05-052-5/+4
* | Improve comments and error messages around access tokens. (#12577)reivilibre2022-05-052-8/+12
* | Use `docker/metadata-action` to generate docker image tags (#12573)Henry2022-05-052-19/+12
* | Use `private` instead of `hidden` in MSC2285 related code. (#12635)Å imon Brandner2022-05-057-25/+26
* | Edits/annotations should not have any bundled aggregations calculated. (#12633)Patrick Cloke2022-05-053-20/+50
* | Remove unused receipt datastore methods. (#12632)Patrick Cloke2022-05-052-54/+1
* | Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639)Will Hunt2022-05-054-4/+5
* | Reduce log spam when running multiple event persisters (#12610)Erik Johnston2022-05-053-2/+17
* | Add `mau_appservice_trial_days` config (#12619)Will Hunt2022-05-046-2/+110
* | Use `getClientAddress` instead of `getClientIP`. (#12599)Patrick Cloke2022-05-0416-46/+62
* | Implement changes to MSC2285 (hidden read receipts) (#12168)Å imon Brandner2022-05-0412-186/+647
* | Disable device name lookup over federation by default (#12616)Andrew Morgan2022-05-045-12/+24
* | Remove unstable/unspecced login types. (#12597)Patrick Cloke2022-05-046-20/+14
* | Improve logging for cancelled requests (#12587)Sean Quah2022-05-043-1/+32
* | Include bundled aggregations for the latest event in a thread. (#12273)Patrick Cloke2022-05-045-51/+198
* | remove constantly lib use and switch to enums. (#12624)andrew do2022-05-0411-38/+36
* | Fixes to the formatting of README.rst (#12627)Richard van der Hoff2022-05-042-7/+8
* | Add a consistency check on events read from the database (#12620)Richard van der Hoff2022-05-033-22/+50
* | Bump Synapse minimum Python version to 3.7.1 (#12613)David Robertson2022-05-033-3/+4
* | Remove unstable identifiers for MSC3069. (#12596)Patrick Cloke2022-05-033-8/+1
* | Add extra debug logging to federation sender (#12614)Richard van der Hoff2022-05-032-2/+19
* | Add missing space before 'docker' link in release announcement script (#12612)Andrew Morgan2022-05-032-1/+2
* | fix importsRichard van der Hoff2022-05-031-1/+2
* | minor wording fix in docstringRichard van der Hoff2022-05-031-3/+2
* | Exclude OOB memberships from the federation sender (#12570)Richard van der Hoff2022-05-033-4/+51
* | Merge branch 'master' into developAndrew Morgan2022-05-033-3/+15
|\|
| * Move groups/communities deprecation notice to 1.58.0 heading v1.58.0Andrew Morgan2022-05-031-2/+2
| * 1.58.0Andrew Morgan2022-05-033-1/+13
* | Add sanity checks to the release script (#12556)David Robertson2022-05-032-26/+38
* | Fix race when persisting an event and deleting a room (#12594)Erik Johnston2022-05-033-2/+22
* | Prune mypy ignore_missing_imports list (#12608)David Robertson2022-05-032-51/+3
* | Remove special-case for `twisted` logger (#12589)Richard van der Hoff2022-04-293-14/+1
* | Allow unused ignores in "bleeding edge" CI (#12576)David Robertson2022-04-293-0/+6
* | Improve the docstrings for the receipts store. (#12581)Patrick Cloke2022-04-282-5/+52
* | Use constants for receipt types in tests. (#12582)Å imon Brandner2022-04-284-23/+30
* | Fix logging of incorrect status codes for disconnected requests (#12580)Sean Quah2022-04-284-5/+36
* | Add linebreak to pipx install quote in README (#12579)DeepBlueV7.X2022-04-282-2/+3
* | Revert accidental direct-to-develop commits.David Robertson2022-04-283-6/+0
* | changelogDavid Robertson2022-04-281-0/+1
* | Use `--extras all` in latest deps mypy CIDavid Robertson2022-04-281-0/+1
* | Allow unused ignores in "bleeding edge" CIDavid Robertson2022-04-282-0/+4
* | Prefer `make_awaitable` over `defer.succeed` in tests (#12505)Sean Quah2022-04-2714-69/+72
* | Add a module API to allow modules to edit push rule actions (#12406)Brendan Abolivier2022-04-278-104/+319
* | Use supervisord to supervise Postgres and Caddy in the Complement image. (#12...reivilibre2022-04-279-12/+44
* | Make `scripts-dev` pass `mypy --disallow-untyped-defs` (#12356)David Robertson2022-04-279-53/+96
* | Remove unused `# type: ignore`s (#12531)David Robertson2022-04-2721-57/+60
* | Consistently use collections.abc.Mapping to check frozendict. (#12564)Patrick Cloke2022-04-275-9/+11
* | Add option to enable token registration without requiring 3pids (#12526)Will Hunt2022-04-275-2/+25
* | Add some type hints to datastore (#12485)Dirk Klimpel2022-04-2712-84/+188
* | Bound ephemeral events by key (#12544)Nick Mills-Barrett2022-04-264-4/+87
* | Merge tag 'v1.58.0rc2' into developDavid Robertson2022-04-2659-172/+144
|\|
| * Adjust changelog v1.58.0rc2David Robertson2022-04-261-1/+1
| * Credit Tulir's contribution in 1.58.0rc1 to Beeper, tooDavid Robertson2022-04-261-1/+1
| * 1.58.0rc2David Robertson2022-04-266-4/+25
| * Mark remote device list updates as already handled (#12557)Erik Johnston2022-04-264-4/+7
| * Comment out dodgy log-kv (#12554)David Robertson2022-04-262-3/+7
| * Fix sending opentracing contexts to remote servers (#12555)Erik Johnston2022-04-262-1/+12
| * Unbold deprecation: it is mentioned at the top v1.58.0rc1David Robertson2022-04-261-1/+1
| * Lint the release scriptDavid Robertson2022-04-261-1/+0
| * Another set of changelog updatesDavid Robertson2022-04-261-3/+5
| * We don't require redbaron in the release scriptDavid Robertson2022-04-262-62/+1
| * Changelog updateDavid Robertson2022-04-261-23/+16
| * 1.58.0rc1David Robertson2022-04-2654-55/+81
| * Temporarily lower debian changelog version numberDavid Robertson2022-04-261-1/+1
| * Update release script to be poetry-awareDavid Robertson2022-04-261-47/+21
* | Mark Dockerfile as requiring BuildKit (#12541)Jason Robinson2022-04-262-0/+2
|/
* build debian package for jammy jellyfish (#12543)Shay2022-04-262-0/+2
* Optimise backfill calculation (#12522)Richard van der Hoff2022-04-265-106/+168
* Add a table of contents to config manual (#12527)Shay2022-04-252-2/+46
* Handle cancellation in `EventsWorkerStore._get_events_from_cache_or_db` (#12529)Sean Quah2022-04-253-36/+169
* Correct typo in user_admin_api.md device deletion JSON (#12533)Sami Olmari2022-04-252-1/+2
* disallow-untyped-defs in `docker` and `stubs` directories (#12528)David Robertson2022-04-257-38/+52
* Misc. clean-ups to the relations code (#12519)Patrick Cloke2022-04-254-103/+68
* Add HAProxy delegation example to docs (#12501)villepeh2022-04-252-0/+23
* Add some example configurations for worker (#12492)Dirk Klimpel2022-04-255-24/+56
* Update `delay_cancellation` to accept any awaitable (#12468)Sean Quah2022-04-224-14/+75
* MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types ...Will Hunt2022-04-223-2/+3
* turn-howto: fix some linksRichard van der Hoff2022-04-221-2/+2
* Await un-partial-stating after a partial-state join (#12399)Richard van der Hoff2022-04-2110-6/+291
* Remove leftover references to setup.py (#12514)David Robertson2022-04-203-3/+4
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-204-5/+30
|\
| * Clarify changelog entry v1.57.1Olivier Wilkinson (reivilibre)2022-04-201-2/+4
| * 1.57.1Olivier Wilkinson (reivilibre)2022-04-205-3/+21
| * Include version 0.2.0 of the Synapse LDAP Auth Provider module in the Docker ...reivilibre2022-04-202-4/+9
* | Dump setuptools; correct pyproject version number (#12478)David Robertson2022-04-2013-412/+11
* | Fix Jinja templating error when generating thumbnail URLs. (#12510)Patrick Cloke2022-04-202-1/+2
* | Recommend poetry in docs (#12475)David Robertson2022-04-205-50/+301
* | Remove unnecessary config overrides for MSC3666. (#12511)Patrick Cloke2022-04-202-4/+1
* | Implement MSC2815: allow room moderators to view redacted event content (#12427)Tulir Asokan2022-04-207-3/+100
* | Add CI job to act as a canary for testing against latest dependencies (#12472)David Robertson2022-04-203-0/+161
* | Fix returned count of delete extremities admin API (#12496)Erik Johnston2022-04-192-3/+6
* | Fix `/room/.../event/...` to return the *original* event after any edits (#12...Richard van der Hoff2022-04-194-39/+79
* | Fix typo in deb changelogs from release script (#12497)Richard van der Hoff2022-04-192-1/+2
* | Implement MSC3383: include destination in X-Matrix auth header (#11398)Jan Christian Grünhage2022-04-194-11/+48
* | Fix a link in `README.rst` (#12495)Dirk Klimpel2022-04-192-1/+2
* | fix typo in debian changelogRichard van der Hoff2022-04-191-1/+1
* | Remove 'Non-maintainer upload' line from Debian changelogOlivier Wilkinson (reivilibre)2022-04-191-1/+0
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-195-6/+18
|\|
| * Link to specific version of upgrade notes v1.57.0Olivier Wilkinson (reivilibre)2022-04-191-1/+1
| * fix typo in upgrade notesRichard van der Hoff2022-04-191-1/+1
| * 1.57.0Olivier Wilkinson (reivilibre)2022-04-194-4/+16
* | Back out implementation of MSC2314 (#12474)Richard van der Hoff2022-04-195-61/+13
* | Fix grammatical error in error message (#12483)Travis Ralston2022-04-182-1/+2
* | Add a manual documenting config file options (#12368)Shay2022-04-183-0/+3414
* | Dockerfile-workers: reduce the amount we install (#12464)Richard van der Hoff2022-04-144-13/+27
* | Update documentation to reflect that `run_background_tasks_on` is no longer e...reivilibre2022-04-142-4/+5
* | complement-synapse-workers: factor out separate entry point script (#12467)Richard van der Hoff2022-04-143-33/+58
* | Replace `federation_reader` with `generic_worker` in docs (#12457)Dirk Klimpel2022-04-145-24/+23
* | Only send out device list updates for our own users (#12465)Erik Johnston2022-04-145-8/+56
* | Reintroduce the lint targets in the linter script (#12455)David Robertson2022-04-143-41/+30
* | Use `poetry` to manage the virtualenv in debian packages (#12449)David Robertson2022-04-144-4/+25
* | Dockerfile-workers: give the master its own log config (#12466)Richard van der Hoff2022-04-132-17/+32
* | Limit `device_id` size to 512B (#12454)Shay2022-04-133-1/+36
* | docs: Don't render the table of contents on the print page (#12340)Andrew Morgan2022-04-132-0/+15
* | Prevent a sync request from removing a user's busy presence status (#12213)David Baker2022-04-135-18/+133
* | Fix missing sync events during historical batch imports (#12319)Nick Mills-Barrett2022-04-135-19/+162
* | Use poetry lockfile in twisted trunk CI job (#12425)David Robertson2022-04-133-20/+35
* | Rename Mutual Rooms `unstable_features` flag to match MSC (#12445)Jonathan de Jong2022-04-132-1/+2
* | Bump twisted version to the latest in lockfile (#12441)Shay2022-04-122-9/+11
* | Run "main" trial tests under poetry (#12438)David Robertson2022-04-122-13/+14
* | Run lints under poetry in CI; remove lint tox jobs (#12434)David Robertson2022-04-124-46/+12
* | Process device list updates asynchronously (#12365)Erik Johnston2022-04-127-119/+40
* | Remove the unstable event field for `/send_join` per MSC3083. (#12395)Patrick Cloke2022-04-123-12/+1
* | Fix typos in release script docs (#12450)Erik Johnston2022-04-122-1/+3
* | Merge branch 'release-v1.57' into developErik Johnston2022-04-1293-5847/+5920
|\|
| * Update changelogErik Johnston2022-04-121-10/+6
| * Update UPGRADE notes to include more details about v1.57 upgrade failure mode...Richard van der Hoff2022-04-121-8/+47
| * Split changelogs by year v1.57.0rc1Erik Johnston2022-04-126-5753/+5759
| * Don't line wrapErik Johnston2022-04-121-7/+2
| * 1.57.0rc1Erik Johnston2022-04-1287-86/+123
* | Disable groups/communities by default. (#12344)Patrick Cloke2022-04-124-1/+10
* | Resync state after partial-state join (#12394)Richard van der Hoff2022-04-128-0/+289
* | Remove references to unstable identifiers from MSC3440. (#12382)Patrick Cloke2022-04-1211-98/+21
|/
* Add some type hints to datastore (#12423)Dirk Klimpel2022-04-129-77/+123
* Poetry: select olddeps using `poetry` (#12407)David Robertson2022-04-124-29/+70
* Specify tls extra for Twisted dependency. (#12444)Erik Johnston2022-04-125-9/+10
* Workaround pip bug installing latest treq and not-latest twisted from hashes ...David Robertson2022-04-122-1/+2
* Remove experimental configuration flag for MSC3666. (#12436)Patrick Cloke2022-04-113-19/+15
* Add missing type hints to config classes. (#12402)Patrick Cloke2022-04-1151-151/+263
* Enable certificate checking during complement tests (#12435)Richard van der Hoff2022-04-113-12/+1
* Do not consider events by ignored users for bundled aggregations (#12235)Patrick Cloke2022-04-116-45/+427
* Fix up healthcheck generation for workers docker image (#12405)Richard van der Hoff2022-04-114-11/+11
* Disallow untyped defs in synapse._scripts (#12422)David Robertson2022-04-1114-140/+221
* Move complement setup stuff into the Synapse repo (#12404)Richard van der Hoff2022-04-1112-52/+449
* Add Module API for reading and writing global account data. (#12391)reivilibre2022-04-113-0/+234
* CI: Fix the export-data job to run under poetry (#12418)David Robertson2022-04-083-16/+13
* Optimise `_update_client_ips_batch_txn` to batch together database operations...reivilibre2022-04-084-51/+190
* Make `synapse._scripts` pass typechecks (#12421)David Robertson2022-04-086-43/+50
* Stop maintaining a list of lint targets in `lint.sh` (#12420)David Robertson2022-04-085-31/+10
* Unify HTTP query parameter type hints (#12415)David Robertson2022-04-086-38/+43
* Update the server notices user profile in room if changed. (#12115)Jorge Florian2022-04-083-4/+148
* CI: Get the portdb job to run under poetry (#12412)David Robertson2022-04-083-19/+15
* Add missing type definitions for scripts in docker folder (#12280)Jorge Florian2022-04-083-4/+7
* Fix rejecting invites over federation (#12409)Erik Johnston2022-04-072-20/+34
* Fix fetching public rooms over federation (#12410)Erik Johnston2022-04-072-1/+2
* Do not add groups to sync results if disabled. (#12408)Patrick Cloke2022-04-073-10/+11
* Add opentracing spans to calls to external cache (#12380)Erik Johnston2022-04-073-11/+24
* Poetry: use locked environment in Docker images (#12385)David Robertson2022-04-074-26/+69
* Support the v1 endpoint for `/relations`. (#12403)Patrick Cloke2022-04-073-12/+13
* Clarify that we mark as outliers because we don't have any state for them (#1...Eric Eastwood2022-04-062-1/+3
* Update changelog to describe changes from #12370 relative to `develop` (#12401)Eric Eastwood2022-04-062-1/+1
* Remove docs for converting a legacy structured logging config. (#12392)Patrick Cloke2022-04-063-81/+3
* Remove support for the unstable identifier from MSC3288. (#12398)Patrick Cloke2022-04-062-2/+1
* Narrow the `importlib_metadata` dependency (#12400)David Robertson2022-04-062-1/+2
* Fix `synapse_event_persisted_position` metric (#12390)Richard van der Hoff2022-04-062-3/+4
* Update type annotations for compatiblity with prometheus_client 0.14 (#12389)Richard van der Hoff2022-04-068-18/+67
* Generate historic pagination token for `/messages` when no `?from` token prov...Eric Eastwood2022-04-066-15/+27
* Add missing dependency on importlib_metadata (#12384)David Robertson2022-04-054-1/+8
* Poetry: initial pyproject.toml and poetry.lock (#12381)David Robertson2022-04-054-0/+3062
* Post 1.56.0 release tidy up (#12379)Sean Quah2022-04-053-2/+2
* Update mdbook to 0.4.17 (#12339)Andrew Morgan2022-04-052-1/+2
* Fix edge case where a `Linearizer` could get stuck (#12358)Sean Quah2022-04-053-5/+53
* Make `StreamToken` and `RoomStreamToken` methods propagate cancellations (#12...Sean Quah2022-04-052-0/+6
* Update docstrings for `ReadWriteLock` tests (#12354)Sean Quah2022-04-052-6/+7
* Refactor and convert `Linearizer` to async (#12357)Sean Quah2022-04-0521-115/+104
* Merge branch 'master' into developSean Quah2022-04-055-10/+39
|\
| * Tweak CHANGES.md v1.56.0Sean Quah2022-04-051-3/+1
| * 1.56.0Sean Quah2022-04-055-6/+20
| * Pin signedjson to <= 1.1.1 as a temporary workaround for #12324Sean Quah2022-04-051-1/+1
| * Bump `black` and `click` versions (#12320)David Robertson2022-04-0516-30/+37
| * Add note in changelog of non-C type locale causing Synapse to refuse to start...Andrew Morgan2022-03-291-0/+5
| * Move warning of open registration to v1.56 upgrade notes (#12322)Andrew Morgan2022-03-293-7/+18
* | Convert `Linearizer` tests from `inlineCallbacks` to async (#12353)Sean Quah2022-04-052-91/+134
* | Prefill more stream change caches. (#12372)Erik Johnston2022-04-056-61/+92
* | Add type hints to some tests files (#12371)Dirk Klimpel2022-04-056-42/+58
* | Fix a spec compliance issue where requests to the `/publicRooms` federation A...reivilibre2022-04-052-2/+3
* | Allow specifying the Postgres database's port when running unit tests with Po...reivilibre2022-04-054-3/+24
* | Merge tag 'v1.56.0rc1' into developRichard van der Hoff2022-04-0547-3685/+3707
|\|
| * Missing period v1.56.0rc1Brendan Abolivier2022-03-291-1/+1
| * Fix formattingBrendan Abolivier2022-03-291-1/+1
| * Link to pre-1.0 changelogBrendan Abolivier2022-03-291-0/+2
| * Linkify MSCsBrendan Abolivier2022-03-291-2/+2
| * Split changelogsBrendan Abolivier2022-03-292-3642/+3640
| * Fixup changelogBrendan Abolivier2022-03-291-13/+13
| * 1.56.0rc1Brendan Abolivier2022-03-2946-44/+66
* | Explain how to decipher live and historic pagination tokens (#12317)Eric Eastwood2022-04-052-11/+86
* | Update broken link in `workers.md` (#12369)Shay2022-04-042-1/+2
* | Allow non-member state sent in room batch to resolve for historic events (MSC...Eric Eastwood2022-04-042-26/+13
* | Prefill the device_list_stream_cache (#12367)Erik Johnston2022-04-043-2/+23
* | Track device list updates per room. (#12321)Erik Johnston2022-04-0411-47/+390
* | Remove more dead/broken dev scripts (#12355)David Robertson2022-04-035-359/+1
* | Add type hints for `tests/unittest.py`. (#12347)Richard van der Hoff2022-04-0112-48/+97
* | Remove redundant `get_success` calls in test code (#12346)Richard van der Hoff2022-04-0113-121/+74
* | Default to `private` room visibility rather than `public` when a client does ...reivilibre2022-04-015-7/+15
* | Burn `check_signature` dev script. (#12351)David Robertson2022-04-014-74/+2
* | Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209)Nick Mills-Barrett2022-04-016-113/+83
* | Remove `list_url_patterns` dev script (#12349)David Robertson2022-04-013-61/+1
* | Move single-use methods out of `TestCase` (#12348)Richard van der Hoff2022-04-014-27/+28
* | Move `update_client_ip` background job from the main process to the backgroun...reivilibre2022-04-0110-153/+160
* | Raise an exception when getting state at an outlier (#12191)Richard van der Hoff2022-04-014-22/+87
* | Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040)Richard van der Hoff2022-04-014-9/+268