summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Ensure we store pusher data as text (#9117)Richard van der Hoff2021-01-152-3/+3
| | | | | I don't think there's any need to use canonicaljson here. Fixes: #4475.
* Land support for multiple OIDC providers (#9110)Richard van der Hoff2021-01-157-382/+456
| | | | | | | | | | | | | | | | | | | | | | | This is the final step for supporting multiple OIDC providers concurrently. First of all, we reorganise the config so that you can specify a list of OIDC providers, instead of a single one. Before: oidc_config: enabled: true issuer: "https://oidc_provider" # etc After: oidc_providers: - idp_id: prov1 issuer: "https://oidc_provider" - idp_id: prov2 issuer: "https://another_oidc_provider" The old format is still grandfathered in. With that done, it's then simply a matter of having OidcHandler instantiate a new OidcProvider for each configured provider.
* Add an admin API endpoint to protect media. (#9086)Patrick Cloke2021-01-154-18/+79
| | | | | | Protecting media stops it from being quarantined when e.g. all media in a room is quarantined. This is useful for sticker packs and other media that is uploaded by server administrators, but used by many people.
* Avoid raising the body exceeded error multiple times. (#9108)Patrick Cloke2021-01-154-3/+115
| | | | | Previously this code generated unreferenced `Deferred` instances which caused "Unhandled Deferreds" errors to appear in error situations.
* Remote dependency on distutils (#9125)Richard van der Hoff2021-01-156-8/+33
| | | | | | | | | `distutils` is pretty much deprecated these days, and replaced with `setuptools`. It's also annoying because it's you can't `pip install` it, and it's hard to figure out which debian package we should depend on to make sure it's there. Since we only use it for a tiny function anyway, let's just vendor said function into our codebase.
* Add type hints to media rest resources. (#9093)Patrick Cloke2021-01-1513-165/+286
|
* Improve UsernamePickerTestCase (#9112)Richard van der Hoff2021-01-155-125/+114
| | | | | * make the OIDC bits of the test work at a higher level - via the REST api instead of poking the OIDCHandler directly. * Move it to test_login.py, where I think it fits better.
* Store an IdP ID in the OIDC session (#9109)Richard van der Hoff2021-01-154-10/+42
| | | | | Again in preparation for handling more than one OIDC provider, add a new caveat to the macaroon used as an OIDC session cookie, which remembers which OIDC provider we are talking to. In future, when we get a callback, we'll need it to make sure we talk to the right IdP. As part of this, I'm adding an idp_id and idp_name field to the OIDC configuration object. They aren't yet documented, and we'll just use the old values by default.
* Add some extra notes for getting Synapse running on macOS. (#8997)Eric Eastwood2021-01-154-1/+25
|
* Merge pull request #9091 from matrix-org/rav/error_on_bad_ssoRichard van der Hoff2021-01-157-31/+103
|\ | | | | Give the user a better error when they present bad SSO creds
| * Add a test for wrong user returned by SSORichard van der Hoff2021-01-131-0/+27
| |
| * Move `complete_sso_ui_auth` into SSOHandlerRichard van der Hoff2021-01-132-28/+13
| | | | | | | | | | since we're hacking on this code anyway, may as well move it out of the cluttered AuthHandler.
| * Give the user a better error when they present bad SSO credsRichard van der Hoff2021-01-135-5/+65
| | | | | | | | | | | | | | | | | | If a user tries to do UI Auth via SSO, but uses the wrong account on the SSO IdP, try to give them a better error. Previously, the UIA would claim to be successful, but then the operation in question would simply fail with "auth fail". Instead, serve up an error page which explains the failure.
* | Fix event chain bg update. (#9118)Erik Johnston2021-01-143-1/+10
| | | | | | | | We passed in a graph to `sorted_topologically` which didn't have an entry for each node (as we dropped nodes with no edges).
* | Fix perf of get_cross_signing_keys (#9116)Erik Johnston2021-01-143-14/+30
| |
* | Fix chain cover background update to work with split out event persisters ↵Erik Johnston2021-01-145-29/+38
| | | | | | | | (#9115)
* | Fix get destinations to catch up query. (#9114)Erik Johnston2021-01-142-13/+12
| | | | | | | | t was doing a sequential scan on `destination_rooms`, which took minutes.
* | Add background update for add chain cover index (#9029)Erik Johnston2021-01-147-18/+360
| |
* | Split OidcProvider out of OidcHandler (#9107)Richard van der Hoff2021-01-144-144/+197
| | | | | | | | | | | | | | The idea here is that we will have an instance of OidcProvider for each configured IdP, with OidcHandler just doing the marshalling of them. For now it's still hardcoded with a single provider.
* | Fix wrong arguments being passed to BlacklistingAgentWrapper (#9098)Tim Leung2021-01-142-1/+1
|/ | | | | | A reactor was being passed instead of a whitelist for the BlacklistingAgentWrapper used by the WellyKnownResolver. This coulld cause exceptions when attempting to connect to IP addresses that are blacklisted, but in reality this did not have any observable affect since this code is not used for IP literals.
* Add a test for UI-Auth-via-SSO (#9082)Richard van der Hoff2021-01-134-42/+227
| | | | | * Add complete test for UI-Auth-via-SSO. * review comments
* Merge pull request #9105 from matrix-org/rav/multi_idp/oidc_provider_configRichard van der Hoff2021-01-133-62/+191
|\ | | | | Enhancements to OIDC configuration handling
| * changelogRichard van der Hoff2021-01-131-0/+1
| |
| * Add jsonschema verification for the oidc provider configRichard van der Hoff2021-01-131-0/+50
| |
| * Extract OIDCProviderConfig objectRichard van der Hoff2021-01-132-62/+140
| | | | | | | | | | Collect all the config options which related to an OIDC provider into a single object.
* | Reduce scope of exception handler. (#9106)Patrick Cloke2021-01-132-5/+6
| | | | | | | | Removes a bare `except Exception` clause and replaces it with catching a specific exception around the portion that might throw.
* | Register the /devices endpoint on workers. (#9092)Patrick Cloke2021-01-134-11/+34
|/
* Add basic domain validation for `DomainSpecificString.is_valid`. (#9071)Patrick Cloke2021-01-133-1/+12
| | | | | This checks that the domain given to `DomainSpecificString.is_valid` (e.g. `UserID`, `RoomAlias`, etc.) is of a valid form. Previously some validation was done on the localpart (e.g. the sigil), but not the domain portion.
* Merge branch 'master' into developErik Johnston2021-01-139-11/+229
|\
| * Move removal warning up changelog v1.25.0 github/release-v1.25.0 release-v1.25.0Erik Johnston2021-01-131-9/+9
| |
| * Link to GH profile and fix tenseErik Johnston2021-01-131-1/+1
| |
| * Fix link in changelogErik Johnston2021-01-131-1/+1
| |
| * Fixup changelogErik Johnston2021-01-131-9/+6
| |
| * 1.25.0Erik Johnston2021-01-134-4/+16
| |
| * Announce Python / PostgreSQL deprecation policies (#9085)Dan Callahan2021-01-122-0/+50
| | | | | | Fixes #8782
| * Don't apply the IP range blacklist to proxy connections (#9084)Marcus2021-01-124-3/+145
| | | | | | | | | | It is expected that the proxy would be on a private IP address so the configured proxy should be connected to regardless of the IP range blacklist.
| * Fix failures in Debian packaging (#9079)Dan Callahan2021-01-123-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Debian package builds were failing for two reasons: 1. Python versions prior to 3.7 throw exceptions when attempting to print Unicode characters under a "C" locale. (#9076) 2. We depended on `dh-systemd` which no longer exists in Debian Bullseye, but is necessary in Ubuntu Xenial. (#9073) Setting `LANG="C.UTF-8"` in the build environment fixes the first issue. See also: https://bugs.python.org/issue19846 The second issue is a bit trickier. The dh-systemd package was merged into debhelper version 9.20160709 and a transitional package left in its wake. The transitional dh-systemd package was removed in Debian Bullseye. However, Ubuntu Xenial ships an older debhelper, and still needs dh-systemd. Thus, builds were failing on Bullseye since we depended on a package which had ceased existing, but we couldn't remove it from the debian/control file and our build scripts because we still needed it for Ubuntu Xenial. We can fix the debian/control issue by listing dh-systemd as an alternative to the newer versions of debhelper. Since dh-systemd declares that it depends on debhelper, Ubuntu Xenial will select its older dh-systemd which will in turn pull in its older debhelper, resulting in no change from the status quo. All other supported releases will satisfy the debhelper dependency constraint and skip the dh-systemd alternative. Build scripts were fixed by unconditionally attempting to install dh-systemd on all releases and suppressing failures. Once we drop support for Ubuntu Xenial, we can revert most of this commit and rely on the version constraint on debhelper in debian/control. Fixes #9076 Fixes #9073 Signed-off-by: Dan Callahan <danc@element.io>
* | Preparatory refactors of OidcHandler (#9067)Richard van der Hoff2021-01-133-165/+201
| | | | | | | | | | | | | | | | Some light refactoring of OidcHandler, in preparation for bigger things: * remove inheritance from deprecated BaseHandler * add an object to hold the things that go into a session cookie * factor out a separate class for manipulating said cookies
* | Remove user's avatar URL and displayname when deactivated. (#8932)Dirk Klimpel2021-01-1213-17/+351
| | | | | | This only applies if the user's data is to be erased.
* | UI Auth via SSO: redirect the user to an appropriate SSO. (#9081)Richard van der Hoff2021-01-127-60/+133
| | | | | | | | | | | | | | If we have integrations with multiple identity providers, when the user does a UI Auth, we need to redirect them to the right one. There are a few steps to this. First of all we actually need to store the userid of the user we are trying to validate in the UIA session, since the /auth/sso/fallback/web request is unauthenticated. Then, once we get the /auth/sso/fallback/web request, we can fish the user id out of the session, and use it to look up the external id mappings, and hence pick an SSO provider for them.
* | Handle bad JSON data being returned from the federation API. (#9070)Patrick Cloke2021-01-123-1/+12
| |
* | Kill off `HomeServer.get_ip_from_request()` (#9080)Richard van der Hoff2021-01-129-52/+15
| | | | | | Homeserver.get_ip_from_request() used to be a bit more complicated, but now it is totally redundant. Let's get rid of it.
* | Remove SynapseRequest.get_user_agent (#9069)Richard van der Hoff2021-01-129-26/+29
| | | | | | | | | | | | | | | | | | | | | | SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests", which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the LoggingContext and write the right entries to the request log). Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a SynapseRequest when there is nothing synapse-specific about the Request at all, and any old twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult. In short: move get_user_agent out to a utility function.
* | Also support remote users on the joined_rooms admin API. (#8948)David Teller2021-01-114-13/+57
| | | | | | | | For remote users, only the rooms which the server knows about are returned. Local users have all of their joined rooms returned.
* | Move more encryption endpoints off master (#9068)Erik Johnston2021-01-113-46/+55
| |
* | Removes unnecessary declarations in the tests for the admin API. (#9063)Dirk Klimpel2021-01-117-17/+1
| |
* | Use a chain cover index to efficiently calculate auth chain difference (#8868)Erik Johnston2021-01-1114-48/+1769
| |
* | Clean up exception handling in the startup code (#9059)Richard van der Hoff2021-01-114-100/+120
| | | | | | | | Factor out the exception handling in the startup code to a utility function, and fix the some logging and exit code stuff.
* | Remove old tables after schema version bump (#9055)Erik Johnston2021-01-116-59/+37
| | | | | | | | | | These tables are unused, and can be dropped now the schema version has been bumped.
* | Ensure rejected events get added to some metadata tables (#9016)Erik Johnston2021-01-114-24/+167
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix a typo in the install docs. (#9040)0xflotus2021-01-112-1/+2
| |
* | Remove unused SynapseService (#9058)Richard van der Hoff2021-01-112-22/+1
| |
* | Drop last_used column from access_tokens (#9025)Jerin J Titus2021-01-113-0/+79
| | | | | | | | | | * Dropped last_used column from access_tokens Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* | fix spurious MD in README.rstMatthew Hodgson2021-01-101-1/+1
| |
* | Keycloak mapping_provider example (#9037) (#9057)Christopher Rücker2021-01-082-0/+5
| | | | | | | | | | This PR adds the missing user_mapping_provider section in oidc.md Signed-off-by: Christopher Rücker chris-ruecker@protonmail.com
* | Fix "Starting metrics collection from sentinel context" errors (#9053)Erik Johnston2021-01-083-21/+22
| |
* | Merge pull request #9036 from matrix-org/rav/multi_idp/testsRichard van der Hoff2021-01-085-38/+253
|\ \ | | | | | | Add tests for the IdP picker
| * | changelogRichard van der Hoff2021-01-071-0/+1
| | |
| * | Add some tests for the IDP picker flowRichard van der Hoff2021-01-073-5/+193
| | |
| * | Fix type hints in test_login.pyRichard van der Hoff2021-01-072-24/+55
| | |
| * | black-format tests/rest/client/v1/test_login.pyRichard van der Hoff2021-01-071-11/+6
| | | | | | | | | | | | | | | black seems to want to reformat this, despite `black --check` being happy with it :/
* | | Fix validate_config on nested objects (#9054)Richard van der Hoff2021-01-083-1/+55
| | |
* | | Fix error handling during insertion of client IPs (#9051)Erik Johnston2021-01-082-31/+24
| | | | | | | | | | | | | | | You can't continue using a transaction once an exception has been raised, so catching and dropping the error here is pointless and just causes more errors.
* | | Remove broken and unmaintained 'webserver.py' script (#9039)Richard van der Hoff2021-01-082-59/+1
| | | | | | | | | | | | | | | | | | I'm not even sure what this was supposed to do, but the fact it has python2isms and nobody has noticed suggests it's not terribly important. It doesn't seem to have been used since ff23e5ba3764506c99d9c1c640e202fe262b65ce.
* | | Run the linters on a consistent list of files (#9038)Richard van der Hoff2021-01-086-17/+24
| | | | | | | | | | | | | | | We were running some linters on some files and some on others. Extract a common setting and use it everywhere.
* | | Allow running sendToDevice on workers (#9044)Erik Johnston2021-01-0711-105/+231
| | |
* | | Support routing edu's to multiple instances (#9042)Erik Johnston2021-01-072-5/+17
| | | | | | | | | This is in preparation for moving `SendToDeviceServlet` off master
* | | Ensure that remote users' device list resyncing always happens on master (#9043)Erik Johnston2021-01-072-4/+14
| | | | | | | | | Currently `DeviceMessageHandler` only ever exists on master, but that is about to change.
* | | Some cleanups to device inbox store. (#9041)Erik Johnston2021-01-073-57/+59
| | |
* | | Fix typo in docs/systemd-with-workers/README.md (#9035)Emelie2021-01-072-1/+2
| | | | | | | | | Signed-off-by: Emelie em@nao.sh
* | | Improve the performance of calculating ignored users in large rooms (#9024)Patrick Cloke2021-01-076-34/+304
|/ / | | | | | | | | | | This allows for efficiently finding which users ignore a particular user. Co-authored-by: Erik Johnston <erik@matrix.org>
* | tox: Add a -noextras factor (#9030)Richard van der Hoff2021-01-072-2/+7
| | | | | | ... for running the tests with no optional deps.
* | Skip unit tests which require optional dependencies (#9031)Richard van der Hoff2021-01-077-13/+90
| | | | | | If we are lacking an optional dependency, skip the tests that rely on it.
* | Handle updating schema version without any deltas. (#9033)Erik Johnston2021-01-072-7/+11
| | | | | | | | This can happen when using a split out state database and we've upgraded the schema version without there being any changes in the state schema.
* | Empty iterables should count towards cache usage. (#9028)Patrick Cloke2021-01-063-24/+52
| |
* | Merge tag 'v1.25.0rc1' into developPatrick Cloke2021-01-0683-94/+96
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.25.0rc1 (2021-01-06) ============================== Removal warning --------------- The old [Purge Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/purge_room.md) and [Shutdown Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/shutdown_room.md) are deprecated and will be removed in a future release. They will be replaced by the [Delete Room API](https://github.com/matrix-org/synapse/tree/master/docs/admin_api/rooms.md#delete-room-api). `POST /_synapse/admin/v1/rooms/<room_id>/delete` replaces `POST /_synapse/admin/v1/purge_room` and `POST /_synapse/admin/v1/shutdown_room/<room_id>`. Features -------- - Add an admin API that lets server admins get power in rooms in which local users have power. ([\#8756](https://github.com/matrix-org/synapse/issues/8756)) - Add optional HTTP authentication to replication endpoints. ([\#8853](https://github.com/matrix-org/synapse/issues/8853)) - Improve the error messages printed as a result of configuration problems for extension modules. ([\#8874](https://github.com/matrix-org/synapse/issues/8874)) - Add the number of local devices to Room Details Admin API. Contributed by @dklimpel. ([\#8886](https://github.com/matrix-org/synapse/issues/8886)) - Add `X-Robots-Tag` header to stop web crawlers from indexing media. Contributed by Aaron Raimist. ([\#8887](https://github.com/matrix-org/synapse/issues/8887)) - Spam-checkers may now define their methods as `async`. ([\#8890](https://github.com/matrix-org/synapse/issues/8890)) - Add support for allowing users to pick their own user ID during a single-sign-on login. ([\#8897](https://github.com/matrix-org/synapse/issues/8897), [\#8900](https://github.com/matrix-org/synapse/issues/8900), [\#8911](https://github.com/matrix-org/synapse/issues/8911), [\#8938](https://github.com/matrix-org/synapse/issues/8938), [\#8941](https://github.com/matrix-org/synapse/issues/8941), [\#8942](https://github.com/matrix-org/synapse/issues/8942), [\#8951](https://github.com/matrix-org/synapse/issues/8951)) - Add an `email.invite_client_location` configuration option to send a web client location to the invite endpoint on the identity server which allows customisation of the email template. ([\#8930](https://github.com/matrix-org/synapse/issues/8930)) - The search term in the list room and list user Admin APIs is now treated as case-insensitive. ([\#8931](https://github.com/matrix-org/synapse/issues/8931)) - Apply an IP range blacklist to push and key revocation requests. ([\#8821](https://github.com/matrix-org/synapse/issues/8821), [\#8870](https://github.com/matrix-org/synapse/issues/8870), [\#8954](https://github.com/matrix-org/synapse/issues/8954)) - Add an option to allow re-use of user-interactive authentication sessions for a period of time. ([\#8970](https://github.com/matrix-org/synapse/issues/8970)) - Allow running the redact endpoint on workers. ([\#8994](https://github.com/matrix-org/synapse/issues/8994)) Bugfixes -------- - Fix bug where we might not correctly calculate the current state for rooms with multiple extremities. ([\#8827](https://github.com/matrix-org/synapse/issues/8827)) - Fix a long-standing bug in the register admin endpoint (`/_synapse/admin/v1/register`) when the `mac` field was not provided. The endpoint now properly returns a 400 error. Contributed by @edwargix. ([\#8837](https://github.com/matrix-org/synapse/issues/8837)) - Fix a long-standing bug on Synapse instances supporting Single-Sign-On, where users would be prompted to enter their password to confirm certain actions, even though they have not set a password. ([\#8858](https://github.com/matrix-org/synapse/issues/8858)) - Fix a longstanding bug where a 500 error would be returned if the `Content-Length` header was not provided to the upload media resource. ([\#8862](https://github.com/matrix-org/synapse/issues/8862)) - Add additional validation to pusher URLs to be compliant with the specification. ([\#8865](https://github.com/matrix-org/synapse/issues/8865)) - Fix the error code that is returned when a user tries to register on a homeserver on which new-user registration has been disabled. ([\#8867](https://github.com/matrix-org/synapse/issues/8867)) - Fix a bug where `PUT /_synapse/admin/v2/users/<user_id>` failed to create a new user when `avatar_url` is specified. Bug introduced in Synapse v1.9.0. ([\#8872](https://github.com/matrix-org/synapse/issues/8872)) - Fix a 500 error when attempting to preview an empty HTML file. ([\#8883](https://github.com/matrix-org/synapse/issues/8883)) - Fix occasional deadlock when handling SIGHUP. ([\#8918](https://github.com/matrix-org/synapse/issues/8918)) - Fix login API to not ratelimit application services that have ratelimiting disabled. ([\#8920](https://github.com/matrix-org/synapse/issues/8920)) - Fix bug where we ratelimited auto joining of rooms on registration (using `auto_join_rooms` config). ([\#8921](https://github.com/matrix-org/synapse/issues/8921)) - Fix a bug where deactivated users appeared in the user directory when their profile information was updated. ([\#8933](https://github.com/matrix-org/synapse/issues/8933), [\#8964](https://github.com/matrix-org/synapse/issues/8964)) - Fix bug introduced in Synapse v1.24.0 which would cause an exception on startup if both `enabled` and `localdb_enabled` were set to `False` in the `password_config` setting of the configuration file. ([\#8937](https://github.com/matrix-org/synapse/issues/8937)) - Fix a bug where 500 errors would be returned if the `m.room_history_visibility` event had invalid content. ([\#8945](https://github.com/matrix-org/synapse/issues/8945)) - Fix a bug causing common English words to not be considered for a user directory search. ([\#8959](https://github.com/matrix-org/synapse/issues/8959)) - Fix bug where application services couldn't register new ghost users if the server had reached its MAU limit. ([\#8962](https://github.com/matrix-org/synapse/issues/8962)) - Fix a long-standing bug where a `m.image` event without a `url` would cause errors on push. ([\#8965](https://github.com/matrix-org/synapse/issues/8965)) - Fix a small bug in v2 state resolution algorithm, which could also cause performance issues for rooms with large numbers of power levels. ([\#8971](https://github.com/matrix-org/synapse/issues/8971)) - Add validation to the `sendToDevice` API to raise a missing parameters error instead of a 500 error. ([\#8975](https://github.com/matrix-org/synapse/issues/8975)) - Add validation of group IDs to raise a 400 error instead of a 500 eror. ([\#8977](https://github.com/matrix-org/synapse/issues/8977)) Improved Documentation ---------------------- - Fix the "Event persist rate" section of the included grafana dashboard by adding missing prometheus rules. ([\#8802](https://github.com/matrix-org/synapse/issues/8802)) - Combine related media admin API docs. ([\#8839](https://github.com/matrix-org/synapse/issues/8839)) - Fix an error in the documentation for the SAML username mapping provider. ([\#8873](https://github.com/matrix-org/synapse/issues/8873)) - Clarify comments around template directories in `sample_config.yaml`. ([\#8891](https://github.com/matrix-org/synapse/issues/8891)) - Moved instructions for database setup, adjusted heading levels and improved syntax highlighting in [INSTALL.md](../INSTALL.md). Contributed by fossterer. ([\#8987](https://github.com/matrix-org/synapse/issues/8987)) - Update the example value of `group_creation_prefix` in the sample configuration. ([\#8992](https://github.com/matrix-org/synapse/issues/8992)) - Link the Synapse developer room to the development section in the docs. ([\#9002](https://github.com/matrix-org/synapse/issues/9002)) Deprecations and Removals ------------------------- - Deprecate Shutdown Room and Purge Room Admin APIs. ([\#8829](https://github.com/matrix-org/synapse/issues/8829)) Internal Changes ---------------- - Properly store the mapping of external ID to Matrix ID for CAS users. ([\#8856](https://github.com/matrix-org/synapse/issues/8856), [\#8958](https://github.com/matrix-org/synapse/issues/8958)) - Remove some unnecessary stubbing from unit tests. ([\#8861](https://github.com/matrix-org/synapse/issues/8861)) - Remove unused `FakeResponse` class from unit tests. ([\#8864](https://github.com/matrix-org/synapse/issues/8864)) - Pass `room_id` to `get_auth_chain_difference`. ([\#8879](https://github.com/matrix-org/synapse/issues/8879)) - Add type hints to push module. ([\#8880](https://github.com/matrix-org/synapse/issues/8880), [\#8882](https://github.com/matrix-org/synapse/issues/8882), [\#8901](https://github.com/matrix-org/synapse/issues/8901), [\#8940](https://github.com/matrix-org/synapse/issues/8940), [\#8943](https://github.com/matrix-org/synapse/issues/8943), [\#9020](https://github.com/matrix-org/synapse/issues/9020)) - Simplify logic for handling user-interactive-auth via single-sign-on servers. ([\#8881](https://github.com/matrix-org/synapse/issues/8881)) - Skip the SAML tests if the requirements (`pysaml2` and `xmlsec1`) aren't available. ([\#8905](https://github.com/matrix-org/synapse/issues/8905)) - Fix multiarch docker image builds. ([\#8906](https://github.com/matrix-org/synapse/issues/8906)) - Don't publish `latest` docker image until all archs are built. ([\#8909](https://github.com/matrix-org/synapse/issues/8909)) - Various clean-ups to the structured logging and logging context code. ([\#8916](https://github.com/matrix-org/synapse/issues/8916), [\#8935](https://github.com/matrix-org/synapse/issues/8935)) - Automatically drop stale forward-extremities under some specific conditions. ([\#8929](https://github.com/matrix-org/synapse/issues/8929)) - Refactor test utilities for injecting HTTP requests. ([\#8946](https://github.com/matrix-org/synapse/issues/8946)) - Add a maximum size of 50 kilobytes to .well-known lookups. ([\#8950](https://github.com/matrix-org/synapse/issues/8950)) - Fix bug in `generate_log_config` script which made it write empty files. ([\#8952](https://github.com/matrix-org/synapse/issues/8952)) - Clean up tox.ini file; disable coverage checking for non-test runs. ([\#8963](https://github.com/matrix-org/synapse/issues/8963)) - Add type hints to the admin and room list handlers. ([\#8973](https://github.com/matrix-org/synapse/issues/8973)) - Add type hints to the receipts and user directory handlers. ([\#8976](https://github.com/matrix-org/synapse/issues/8976)) - Drop the unused `local_invites` table. ([\#8979](https://github.com/matrix-org/synapse/issues/8979)) - Add type hints to the base storage code. ([\#8980](https://github.com/matrix-org/synapse/issues/8980)) - Support using PyJWT v2.0.0 in the test suite. ([\#8986](https://github.com/matrix-org/synapse/issues/8986)) - Fix `tests.federation.transport.RoomDirectoryFederationTests` and ensure it runs in CI. ([\#8998](https://github.com/matrix-org/synapse/issues/8998)) - Add type hints to the crypto module. ([\#8999](https://github.com/matrix-org/synapse/issues/8999))
| * More updates to changes for consistency. v1.25.0rc1Patrick Cloke2021-01-061-1/+1
| |
| * A few more tweaks to changes.Patrick Cloke2021-01-061-2/+2
| |
| * Some manual tweaks to the changes file.Patrick Cloke2021-01-061-23/+18
| |
| * 1.25.0rc1Patrick Cloke2021-01-0680-79/+92
| |
| * Fix-up assertions about last stream token in push (#9020)Patrick Cloke2021-01-055-14/+8
| | | | | | The last stream token is always known and we do not need to handle none.
* | Handle a display name / avatar URL not included in a federation request. (#9023)Patrick Cloke2021-01-062-2/+3
| | | | | | | | These may be omitted if not set, but Synapse assumed they would be in the response.
* | Ignore date-rotated logs (#9018)Eric Eastwood2021-01-052-0/+2
| | | | | | | | | | | | Ex. - homeserver.log.2020-12-29 - homeserver.log.2020-12-31
* | Add type hints to the logging context code. (#8939)Patrick Cloke2021-01-054-22/+47
| |
* | Implement MSC2176: Updated redaction rules (#8984)Patrick Cloke2021-01-055-30/+206
| | | | | | | | An experimental room version ("org.matrix.msc2176") contains the new redaction rules for testing.
* | Add initial support for a "pick your IdP" page (#9017)Richard van der Hoff2021-01-0511-3/+194
| | | | | | | | | | During login, if there are multiple IdPs enabled, offer the user a choice of IdPs.
* | Combine the SSO Redirect Servlets (#9015)Richard van der Hoff2021-01-048-113/+174
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | * Implement CasHandler.handle_redirect_request ... to make it match OidcHandler and SamlHandler * Clean up interface for OidcHandler.handle_redirect_request Make it accept `client_redirect_url=None`. * Clean up interface for `SamlHandler.handle_redirect_request` ... bring it into line with CAS and OIDC by making it take a Request parameter, move the magic for `client_redirect_url` for UIA into the handler, and fix the return type to be a `str` rather than a `bytes`. * Define a common protocol for SSO auth provider impls * Give SsoIdentityProvider an ID and register them * Combine the SSO Redirect servlets Now that the SsoHandler knows about the identity providers, we can combine the various *RedirectServlets into a single implementation which delegates to the right IdP. * changelog
* Add type hints to the receipts and user directory handlers. (#8976)Patrick Cloke2021-01-044-32/+64
|
* Add type hints to the crypto module. (#8999)Patrick Cloke2021-01-049-113/+158
|
* Add link to Synapse dev room to the relevant README section (#9002)Eric Eastwood2021-01-042-0/+3
|
* Use the SSO handler helpers for CAS registration/login. (#8856)Patrick Cloke2021-01-034-39/+199
|
* Fix RoomDirectoryFederationTests and make them actually run (#8998)Andrew Morgan2020-12-303-21/+19
| | | | | | | | | | The `RoomDirectoryFederationTests` tests were not being run unless explicitly called as an `__init__.py` file was not present in `tests/federation/transport/`. Thus the folder was not a python module, and `trial` did not look inside for any test cases to run. This was found while working on #6739. This PR adds a `__init__.py` and also fixes the test in a couple ways: - Switch to subclassing `unittest.FederatingHomeserverTestCase` instead, which sets up federation endpoints for us. - Supply a `federation_auth_origin` to `make_request` in order to more act like the request is coming from another server, instead of just an unauthenicated client requesting a federation endpoint. I found that the second point makes no difference to the test passing, but felt like the right thing to do if we're testing over federation.
* Check if group IDs are valid before using them. (#8977)Patrick Cloke2020-12-303-4/+47
|
* Add additional type hints to the storage module. (#8980)Patrick Cloke2020-12-3012-148/+224
|
* Doc/move database setup instructions in install md (#8987)Shashank Sabniveesu2020-12-302-121/+141
|
* Add type hints to admin and room list handlers. (#8973)Patrick Cloke2020-12-295-70/+100
|
* Validate input parameters for the sendToDevice API. (#8975)Patrick Cloke2020-12-292-1/+3
| | | | This makes the "messages" key in the content required. This is currently optional in the spec, but that seems to be an error.
* Update the value of group_creation_prefix in sample config. (#8992)Jerin J Titus2020-12-293-2/+3
| | | Removes the trailing slash with causes issues with matrix.to/Element.
* Allow redacting events on workers (#8994)Patrick Cloke2020-12-294-34/+16
| | | Adds the redacts endpoint to workers that have the client listener.
* Drop the unused local_invites table. (#8979)Patrick Cloke2020-12-293-1/+19
| | | This table has been unused since Synapse v1.17.0.
* Support PyJWT v2.0.0. (#8986)Patrick Cloke2020-12-222-4/+13
| | | | Tests were broken due to an API changing. The code used in Synapse proper should be compatible with both versions already.
* Refactor the CAS handler in prep for using the abstracted SSO code. (#8958)Patrick Cloke2020-12-184-69/+162
| | | | | | This makes the CAS handler look more like the SAML/OIDC handlers: * Render errors to users instead of throwing JSON errors. * Internal reorganization.
* Send the location of the web client to the IS when inviting via 3PIDs. (#8930)Patrick Cloke2020-12-184-0/+34
| | | | Adds a new setting `email.invite_client_location` which, if defined, is passed to the identity server during invites.
* Allow server admin to get admin bit in rooms where local user is an admin ↵Erik Johnston2020-12-185-3/+294
| | | | | | | (#8756) This adds an admin API that allows a server admin to get power in a room if a local user has power in a room. Will also invite the user if they're not in the room and its a private room. Can specify another user (rather than the admin user) to be granted power. Co-authored-by: Matthew Hodgson <matthew@matrix.org>
* Fix mainline ordering in state res v2 (#8971)Erik Johnston2020-12-183-2/+58
| | | | | | This had two effects 1) it'd give the wrong answer and b) would iterate *all* power levels in the auth chain of each event. The latter of which can be *very* expensive for certain types of IRC bridge rooms that have large numbers of power level changes.
* Implement a username picker for synapse (#8942)Richard van der Hoff2020-12-1814-59/+683
| | | | | | | | | | | | | | The final part (for now) of my work to implement a username picker in synapse itself. The idea is that we allow `UsernameMappingProvider`s to return `localpart=None`, in which case, rather than redirecting the browser back to the client, we redirect to a username-picker resource, which allows the user to enter a username. We *then* complete the SSO flow (including doing the client permission checks). The static resources for the username picker itself (in https://github.com/matrix-org/synapse/tree/rav/username_picker/synapse/res/username_picker) are essentially lifted wholesale from https://github.com/matrix-org/matrix-synapse-saml-mozilla/tree/master/matrix_synapse_saml_mozilla/res. As the comment says, we might want to think about making them customisable, but that can be a follow-up. Fixes #8876.
* Allow re-using a UI auth validation for a period of time (#8970)Patrick Cloke2020-12-1810-49/+193
|
* Ensure that a URL exists in the content during push. (#8965)Patrick Cloke2020-12-183-2/+7
| | | | This fixes an KeyError exception, after this PR the content is just considered unknown.
* Merge remote-tracking branch 'origin/erikj/as_mau_block' into developErik Johnston2020-12-187-9/+86
|\
| * Update tests/test_mau.pyErik Johnston2020-12-171-1/+2
| | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
| * Correctly handle AS registerations and add testErik Johnston2020-12-175-9/+77
| |
| * NewsfileErik Johnston2020-12-171-0/+1
| |
| * Don't MAU limit AS ghost usersErik Johnston2020-12-171-0/+7
| |
* | Try and drop stale extremities. (#8929)Erik Johnston2020-12-186-18/+523
| | | | | | | | If we see stale extremities while persisting events, and notice that they don't change the result of state resolution, we drop them.
* | Clean up tox.ini (#8963)Richard van der Hoff2020-12-173-19/+34
| | | | | | ... and disable coverage tracking for mypy and friends.
* | Fix `UsersListTestCase` (#8964)Richard van der Hoff2020-12-172-6/+5
| |
* | Use the simple dictionary in full text search for the user directory (#8959)Brendan Abolivier2020-12-173-12/+36
| | | | | | | | | | * Use the simple dictionary in fts for the user directory * Clarify naming
* | Fix a bug that deactivated users appear in the directory (#8933)Dirk Klimpel2020-12-174-4/+95
| | | | | | | | | | | | | | | | | | | | Fixes a bug that deactivated users appear in the directory when their profile information was updated. To change profile information of deactivated users is neccesary for example you will remove displayname or avatar. But they should not appear in directory. They are deactivated. Co-authored-by: Erik Johnston <erikj@jki.re>
* | Make search statement in List Room and User Admin API case-insensitive (#8931)Dirk Klimpel2020-12-177-11/+125
| |
* | Add a maximum size for well-known lookups. (#8950)Patrick Cloke2020-12-165-18/+80
| |
* | Push login completion down into SsoHandler (#8941)Richard van der Hoff2020-12-165-86/+80
| | | | | | This is another part of my work towards fixing #8876. It moves some of the logic currently in the SAML and OIDC handlers - in particular the call to `AuthHandler.complete_sso_login` down into the `SsoHandler`.
* | Fix the sample config location for the ip_range_whitelist setting. (#8954)Patrick Cloke2020-12-164-24/+25
| | | | | | | | Move it from the federation section to the server section to match ip_range_blacklist.
* | Convert internal pusher dicts to attrs classes. (#8940)Patrick Cloke2020-12-1617-204/+266
| | | | | | This improves type hinting and should use less memory.
* | Merge pull request #8951 from matrix-org/rav/username_picker_2Richard van der Hoff2020-12-163-82/+106
|\ \ | | | | | | More preparatory refactoring of the OidcHandler tests
| * | changelogRichard van der Hoff2020-12-151-0/+1
| | |
| * | Make `_make_callback_with_userinfo` asyncRichard van der Hoff2020-12-151-68/+83
| | | | | | | | | | | | | | | | | | ... so that we can test its behaviour when it raises. Also pull it out to the top level so that I can use it from other test classes.
| * | Remove spurious mocking of complete_sso_loginRichard van der Hoff2020-12-151-2/+0
| | | | | | | | | | | | The tests that need this all do it already.
| * | Test `get_extra_attributes` fallbackRichard van der Hoff2020-12-152-12/+22
| | | | | | | | | | | | | | | despite the warnings saying "don't implement get_extra_attributes", we had implemented it, so the tests weren't doing what we thought they were.
* | | Merge pull request #8946 from matrix-org/rav/refactor_send_requestRichard van der Hoff2020-12-1660-1028/+776
|\ \ \ | | | | | | | | Remove `Request` return value from `make_request`
| * | | lintRichard van der Hoff2020-12-155-7/+3
| | | |
| * | | changelogRichard van der Hoff2020-12-151-0/+1
| | | |
| * | | Remove spurious "SynapseRequest" result from `make_request"Richard van der Hoff2020-12-1559-983/+742
| | | | | | | | | | | | | | | | This was never used, so let's get rid of it.
| * | | Remove redundant reading of SynapseRequest.argsRichard van der Hoff2020-12-151-9/+1
| | | | | | | | | | | | | | | | this didn't seem to be doing a lot, so remove it.
| * | | Skip redundant check on `request.args`Richard van der Hoff2020-12-151-2/+1
| | | |
| * | | remove 'response' result from `_get_shared_rooms`Richard van der Hoff2020-12-151-8/+9
| | | |
| * | | Replace `request.code` with `channel.code`Richard van der Hoff2020-12-158-22/+22
| |/ / | | | | | | | | | | | | | | | The two are equivalent, but really we want to check the HTTP result that got returned to the channel, not the code that the Request object *intended* to return to the channel.
* | | Fix generate_log_config script (#8952)Richard van der Hoff2020-12-162-1/+4
| | | | | | | | | It used to write an empty file if you gave it a -o arg.
* | | Do not assume that the contents dictionary includes history_visibility. (#8945)Patrick Cloke2020-12-169-28/+58
|/ /
* | Preparatory refactoring of the SamlHandlerTestCase (#8938)Richard van der Hoff2020-12-155-54/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | * move simple_async_mock to test_utils ... so that it can be re-used * Remove references to `SamlHandler._map_saml_response_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead, factor out a higher-level method which takes a SAML object, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`. * changelog
* | Fix handling of stream tokens for push. (#8943)Patrick Cloke2020-12-156-50/+18
| | | | | | | | Removes faulty assertions and fixes the logic to ensure the max stream token is always set.
* | Fix startup failure with localdb_enabled: False (#8937)Richard van der Hoff2020-12-143-14/+36
| |
* | Various clean-ups to the logging context code (#8935)Patrick Cloke2020-12-1411-39/+20
| |
* | Preparatory refactoring of the OidcHandlerTestCase (#8911)Richard van der Hoff2020-12-142-141/+146
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove references to handler._auth_handler (and replace them with hs.get_auth_handler) * Factor out a utility function for building Requests * Remove mocks of `OidcHandler._map_userinfo_to_user` This method is going away, so mocking it out is no longer a valid approach. Instead, we mock out lower-level methods (eg _remote_id_from_userinfo), or simply allow the regular implementation to proceed and update the expectations accordingly. * Remove references to `OidcHandler._map_userinfo_to_user` from tests This method is going away, so we can no longer use it as a test point. Instead we build mock "callback" requests which we pass into `handle_oidc_callback`, and verify correct behaviour by mocking out `AuthHandler.complete_sso_login`.
* | Allow spam-checker modules to be provide async methods. (#8890)David Teller2020-12-1119-73/+98
| | | | | | | | Spam checker modules can now provide async methods. This is implemented in a backwards-compatible manner.
* | Add type hints to the push module. (#8901)Patrick Cloke2020-12-119-86/+159
| |
* | Honour AS ratelimit settings for /login requests (#8920)Erik Johnston2020-12-114-10/+27
| | | | | | | | Fixes #8846.
* | Improve tests for structured logging. (#8916)Patrick Cloke2020-12-112-27/+47
| |
* | Add number of local devices to Room Details Admin API (#8886)Dirk Klimpel2020-12-116-27/+138
| |
* | Don't ratelimit autojoining of rooms (#8921)Erik Johnston2020-12-114-11/+34
| | | | | | Fixes #8866
* | Don't publish `latest` docker image until all archs are built (#8909)Richard van der Hoff2020-12-102-3/+5
| |
* | Fix deadlock on SIGHUP (#8918)Erik Johnston2020-12-102-1/+6
| | | | | | Fixes #8892
* | Refactor `SsoHandler.get_mxid_from_sso` (#8900)Richard van der Hoff2020-12-103-28/+51
| | | | | | | | | | | | | | * Factor out _call_attribute_mapper and _register_mapped_user This is mostly an attempt to simplify `get_mxid_from_sso`. * Move mapping_lock down into SsoHandler.
* | Fix buglet in DirectRenderJsonResource (#8897)Richard van der Hoff2020-12-102-3/+6
| | | | | | | | this was using `canonical_json` without setting it, so when you used it as a standalone class, you would get exceptions.
* | Deprecate Shutdown Room and Purge Room Admin API (#8829)Dirk Klimpel2020-12-105-11/+63
| | | | | | | | | | Deprecate both APIs in favour of the Delete Room API. Related: #8663 and #8810
* | Default to blacklisting reserved IP ranges and add a whitelist. (#8870)Patrick Cloke2020-12-0910-89/+172
| | | | | | | | This defaults `ip_range_blacklist` to reserved IP ranges and also adds an `ip_range_whitelist` setting to override it.
* | Skip the SAML tests if xmlsec1 isn't available. (#8905)Patrick Cloke2020-12-092-0/+24
| |
* | Combine related media admin API docs (#8839)Dirk Klimpel2020-12-093-50/+87
| | | | | | | | | | | | Related: #8810 Also a few small improvements. Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Merge remote-tracking branch 'origin/master' into developRichard van der Hoff2020-12-092-3/+6
|\ \
| * \ Merge pull request #8906 from matrix-org/rav/fix_multiarch_buildsRichard van der Hoff2020-12-092-3/+6
| |\ \ | | | | | | | | Pin the docker version for multiarch builds
| | * | Pin the docker version for multiarch buildsRichard van der Hoff2020-12-092-3/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that letting CircleCI use its default docker version (17.09.0-ce, apparently) did not interact well with multiarch builds: in particular, we saw weird effects where running an amd64 build at the same time as an arm64 build caused the arm64 builds to fail with: Error while loading /usr/sbin/dpkg-deb: No such file or directory
* | | | Merge branch 'release-v1.24.0' into developErik Johnston2020-12-091-1/+2
|\ \ \ \
| * | | | Add 'xmlsec1' to dependency list github/release-v1.24.0 release-v1.24.0Erik Johnston2020-12-091-1/+2
| | |_|/ | |/| |
* | | | Merge branch 'master' into developErik Johnston2020-12-092-0/+60
|\ \ \ \ | | |/ / | |/| |
| * | | Merge tag 'v1.23.1'Erik Johnston2020-12-092-0/+60
| |\ \ \ | | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.23.1 (2020-12-09) =========================== Due to the two security issues highlighted below, server administrators are encouraged to update Synapse. We are not aware of these vulnerabilities being exploited in the wild. Security advisory ----------------- The following issues are fixed in v1.23.1 and v1.24.0. - There is a denial of service attack ([CVE-2020-26257](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26257)) against the federation APIs in which future events will not be correctly sent to other servers over federation. This affects all servers that participate in open federation. (Fixed in [#8776](https://github.com/matrix-org/synapse/pull/8776)). - Synapse may be affected by OpenSSL [CVE-2020-1971](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-1971). Synapse administrators should ensure that they have the latest versions of the cryptography Python package installed. To upgrade Synapse along with the cryptography package: * Administrators using the [`matrix.org` Docker image](https://hub.docker.com/r/matrixdotorg/synapse/) or the [Debian/Ubuntu packages from `matrix.org`](https://github.com/matrix-org/synapse/blob/master/INSTALL.md#matrixorg-packages) should ensure that they have version 1.24.0 or 1.23.1 installed: these images include the updated packages. * Administrators who have [installed Synapse from source](https://github.com/matrix-org/synapse/blob/master/INSTALL.md#installing-from-source) should upgrade the cryptography package within their virtualenv by running: ```sh <path_to_virtualenv>/bin/pip install 'cryptography>=3.3' ``` * Administrators who have installed Synapse from distribution packages should consult the information from their distributions. Bugfixes -------- - Fix a bug in some federation APIs which could lead to unexpected behaviour if different parameters were set in the URI and the request body. ([\#8776](https://github.com/matrix-org/synapse/issues/8776)) Internal Changes ---------------- - Add a maximum version for pysaml2 on Python 3.5. ([\#8898](https://github.com/matrix-org/synapse/issues/8898))
| | * | 1.23.1 v1.23.1 github/release-v1.23.1 release-v1.23.1Erik Johnston2020-12-095-3/+59
| | | |
| | * | Fix installing pysaml2 on Python 3.5. (#8898)Patrick Cloke2020-12-092-1/+6
| | | | | | | | | | | | This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.
| | * | Consistently use room_id from federation request body (#8776)Richard van der Hoff2020-12-095-54/+49
| | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Consistently use room_id from federation request body Some federation APIs have a redundant `room_id` path param (see https://github.com/matrix-org/matrix-doc/issues/2330). We should make sure we consistently use either the path param or the body param, and the body param is easier. * Kill off some references to "context" Once upon a time, "rooms" were known as "contexts". I think this kills of the last references to "contexts".
* | | Merge branch 'master' into developErik Johnston2020-12-094-2/+58
|\| |
| * | 1.24.0 v1.24.0Erik Johnston2020-12-094-2/+53
| | |
| * | Fix installing pysaml2 on Python 3.5. (#8898)Patrick Cloke2020-12-082-1/+6
| | | | | | | | | This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.
* | | Add X-Robots-Tag header to stop crawlers from indexing media (#8887)Aaron Raimist2020-12-083-0/+19
| | | | | | | | | | | | | | | | | | | | | Fixes / related to: https://github.com/matrix-org/synapse/issues/6533 This should do essentially the same thing as a robots.txt file telling robots to not index the media repo. https://developers.google.com/search/reference/robots_meta_tag Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | | Better formatting for config errors from modules (#8874)Richard van der Hoff2020-12-0813-37/+160
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea is that the parse_config method of extension modules can raise either a ConfigError or a JsonValidationError, and it will be magically turned into a legible error message. There's a few components to it: * Separating the "path" and the "message" parts of a ConfigError, so that we can fiddle with the path bit to turn it into an absolute path. * Generally improving the way ConfigErrors get printed. * Passing in the config path to load_module so that it can wrap any exceptions that get caught appropriately.
* | | Simplify the flow for SSO UIA (#8881)Richard van der Hoff2020-12-087-40/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | * SsoHandler: remove inheritance from BaseHandler * Simplify the flow for SSO UIA We don't need to do all the magic for mapping users when we are doing UIA, so let's factor that out.
* | | Clarify config template comments (#8891)Richard van der Hoff2020-12-084-16/+9
| | |
* | | Call set_avatar_url with target_user, not user_id (#8872)Will Hunt2020-12-073-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Call set_avatar_url with target_user, not user_id Fixes https://github.com/matrix-org/synapse/issues/8871 * Create 8872.bugfix * Update synapse/rest/admin/users.py Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Testing * Update changelog.d/8872.bugfix Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | | Do not raise a 500 exception when previewing empty media. (#8883)Patrick Cloke2020-12-073-12/+22
| | |
* | | Add type hints for HTTP and email pushers. (#8880)Patrick Cloke2020-12-078-101/+168
| | |
* | | Add type hints to the push mailer module. (#8882)Patrick Cloke2020-12-073-40/+85
| | |
* | | Add authentication to replication endpoints. (#8853)Patrick Cloke2020-12-047-15/+184
| | | | | | | | | | | | Authentication is done by checking a shared secret provided in the Synapse configuration file.
* | | Pass room_id to get_auth_chain_difference (#8879)Erik Johnston2020-12-046-17/+33
| | | | | | | | | | | | | | | This is so that we can choose which algorithm to use based on the room ID.
* | | Add additional validation to pusher URLs. (#8865)Patrick Cloke2020-12-046-30/+106
| | | | | | | | | | | | Pusher URLs now must end in `/_matrix/push/v1/notify` per the specification.
* | | Do not 500 if the content-length is not provided when uploading media. (#8862)Patrick Cloke2020-12-042-1/+2
| | | | | | | | | Instead return the proper 400 error.
* | | Merge tag 'v1.24.0rc2' into developPatrick Cloke2020-12-049-18/+81
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.24.0rc2 (2020-12-04) ============================== Bugfixes -------- - Fix a regression in v1.24.0rc1 which failed to allow SAML mapping providers which were unable to redirect users to an additional page. ([\#8878](https://github.com/matrix-org/synapse/issues/8878)) Internal Changes ---------------- - Add support for the `prometheus_client` newer than 0.9.0. Contributed by Jordan Bancino. ([\#8875](https://github.com/matrix-org/synapse/issues/8875))
| * | Minor update to CHANGES. v1.24.0rc2Patrick Cloke2020-12-041-1/+1
| | |
| * | 1.24.0rc2Patrick Cloke2020-12-044-3/+16
| | |
| * | Fix a regression that mapping providers should be able to redirect users. ↵Patrick Cloke2020-12-046-8/+60
| | | | | | | | | | | | | | | (#8878) This was broken in #8801.
| * | Remove version pin prometheus_client dependency (#8875)Jordan Bancino2020-12-043-9/+7
| | | | | | | | | | | | | | | | | | | | | This removes the version pin of the `prometheus_client` dependency, in direct response to #8831. If merged, this will close #8831 As far as I can tell, no other changes are needed, but as I'm no synapse expert, I'm relying heavily on CI and maintainer reviews for this. My very primitive test of synapse with prometheus_client v0.9.0 on my home server didn't bring up any issues, so we'll see what happens. Signed-off-by: Jordan Bancino
* | | Fix a buglet in the SAML username mapping provider doc (#8873)Richard van der Hoff2020-12-042-1/+4
| | | | | | | | | the constructor is called with a `module_api`.
* | | Fix errorcode for disabled registration (#8867)Richard van der Hoff2020-12-033-1/+3
| | | | | | | | | | | | The spec says we should return `M_FORBIDDEN` when someone tries to register and registration is disabled.
* | | Merge pull request #8861 from matrix-org/rav/remove_unused_mocksRichard van der Hoff2020-12-037-143/+7
|\ \ \ | | | | | | | | Remove some unnecessary mocking from the unit tests
| * \ \ Merge remote-tracking branch 'origin/develop' into rav/remove_unused_mocksRichard van der Hoff2020-12-0215-111/+367
| |\ \ \ | |/ / / |/| | |
* | | | Merge pull request #8858 from matrix-org/rav/sso_uiaRichard van der Hoff2020-12-0213-73/+366
|\ \ \ \ | | | | | | | | | | UIA: offer only available auth flows
| * | | | newsfileRichard van der Hoff2020-12-021-0/+1
| | | | |
| * | | | UIA: offer only available auth flowsRichard van der Hoff2020-12-026-33/+278
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During user-interactive auth, do not offer password auth to users with no password, nor SSO auth to users with no SSO. Fixes #7559.
| * | | | Factor out FakeResponse from test_oidcRichard van der Hoff2020-12-022-16/+28
| | | | |
| * | | | fix up various test casesRichard van der Hoff2020-12-025-17/+38
| | | | | | | | | | | | | | | | | | | | | | | | | A few test cases were relying on being able to mount non-client servlets on the test resource. it's better to give them their own Resources.
| * | | | Add `create_resource_dict` method to HomeserverTestCaseRichard van der Hoff2020-12-021-7/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than using a single JsonResource, construct a resource tree, as we do in the prod code, and allow testcases to add extra resources by overriding `create_resource_dict`.
* | | | | remove unused FakeResponse (#8864)Richard van der Hoff2020-12-022-26/+1
| | | | |
| | * | | changelogRichard van der Hoff2020-12-021-0/+1
| | | | |
| | * | | remove unused DeferredMockCallableRichard van der Hoff2020-12-021-90/+1
| | | | |
| | * | | remove unused `resource_for_federation`Richard van der Hoff2020-12-022-18/+13
| | | | | | | | | | | | | | | | | | | | This is now only used in `test_typing`, so move it there.
| | * | | Remove redundant mockingRichard van der Hoff2020-12-025-36/+5
| |/ / / |/| | |
* | | | Apply an IP range blacklist to push and key revocation requests. (#8821)Patrick Cloke2020-12-0243-115/+176
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaces the `federation_ip_range_blacklist` configuration setting with an `ip_range_blacklist` setting with wider scope. It now applies to: * Federation * Identity servers * Push notifications * Checking key validitity for third-party invite events The old `federation_ip_range_blacklist` setting is still honored if present, but with reduced scope (it only applies to federation and identity servers).
* | | | Correctly handle unpersisted events when calculating auth chain difference. ↵Erik Johnston2020-12-024-5/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8827) We do state res with unpersisted events when calculating the new current state of the room, so that should be the only thing impacted. I don't think this is tooooo big of a deal as: 1. the next time a state event happens in the room the current state should correct itself; 2. in the common case all the unpersisted events' auth events will be pulled in by other state, so will still return the correct result (or one which is sufficiently close to not affect the result); and 3. we mostly use the state at an event to do important operations, which isn't affected by this.
* | | | Add missing prometheus rules for persisted events (#8802)Johanna Dorothea Reichmann2020-12-022-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The official dashboard uses data from these rules, but they were never added to the synapse-v2.rules. They are mentioned in this issue: https://github.com/matrix-org/synapse/issues/7917#issuecomment-661330409, but never got added to the rules. Adding them results in all graphs in the "Event persist rate" section to function as intended. Signed-off-by: Johanna Dorothea Reichmann <transcaffeine@finallycoffee.eu>
* | | | Add additional validation for the admin register endpoint. (#8837)David Florness2020-12-022-0/+4
| |/ / |/| | | | | Raise a proper 400 error if the `mac` field is missing.
* | | Minor changes to the CHANGES doc. v1.24.0rc1Patrick Cloke2020-12-021-1/+1
| | |
* | | Minor fixes to changelog.Patrick Cloke2020-12-021-5/+5
| | |
* | | 1.24.0rc1Patrick Cloke2020-12-0255-54/+73
|/ /
* | Fix a regression when grandfathering SAML users. (#8855)Patrick Cloke2020-12-026-48/+94
| | | | | | | | | | | | This was broken in #8801 when abstracting code shared with OIDC. After this change both SAML and OIDC have a concept of grandfathering users, but with different implementations.
* | Add basic SAML tests for mapping users. (#8800)Patrick Cloke2020-12-025-19/+156
| |
* | Create a `PasswordProvider` wrapper object (#8849)Richard van der Hoff2020-12-023-57/+152
| | | | | | | | The idea here is to abstract out all the conditional code which tests which methods a given password provider has, to provide a consistent interface.
* | Allow specifying room version in 'RestHelper.create_room_as' and add typing ↵Andrew Morgan2020-12-022-2/+26
| | | | | | | | | | (#8854) This PR adds a `room_version` argument to the `RestHelper`'s `create_room_as` function for tests. I plan to use this for testing knocking, which currently uses an unstable room version.
* | Support "identifier" dicts in UIA (#8848)Richard van der Hoff2020-12-015-147/+190
| | | | | | | | | | | | | | | | | | | | The spec requires synapse to support `identifier` dicts for `m.login.password` user-interactive auth, which it did not (instead, it required an undocumented `user` parameter.) To fix this properly, we need to pull the code that interprets `identifier` into `AuthHandler.validate_login` so that it can be called from the UIA code. Fixes #5665.
* | Add missing `ordering` to background updates (#8850)Richard van der Hoff2020-12-015-12/+13
| | | | | | | | | | | | | | It's important that we make sure our background updates happen in a defined order, to avoid disasters like #6923. Add an ordering to all of the background updates that have landed since #7190.
* | Allow Date header through CORS (#8804)Nicolas Chamo2020-12-012-1/+2
| |
* | Don't offer password login when it is disabled (#8835)Richard van der Hoff2020-12-013-4/+115
| | | | | | Fix a minor bug where we would offer "m.login.password" login if a custom auth provider supported it, even if password login was disabled.
* | Add some tests for `password_auth_providers` (#8819)Richard van der Hoff2020-12-013-0/+488
| | | | | | | | These things seemed to be completely untested, so I added a load of tests for them.
* | Fix broken testcase (#8851)Richard van der Hoff2020-12-012-1/+1
| | | | | | | | This test was broken by #8565. It doesn't need to set set `self.clock` here anyway - that is done by `setUp`.
* | Fix typo in password_auth_providers docAndrew Morgan2020-12-011-0/+1
| | | | | | | | A word got removed accidentally in 83434df3812650f53c60e91fb23c2079db0fb5b8.
* | Simplify appservice login code (#8847)Richard van der Hoff2020-11-302-6/+22
| | | | | | we don't need to support legacy login dictionaries here.
* | Allow per-room profile to be used for server notice user (#8799)Mathieu Velten2020-11-302-1/+10
| | | | | | | | This applies even if the feature is disabled at the server level with `allow_per_room_profiles`. The server notice not being a real user it doesn't have an user profile.
* | Drop (almost) unused index on event_json (#8845)Richard van der Hoff2020-11-303-1/+21
| |
* | Add a config option to change whether unread push notification counts are ↵Andrew Morgan2020-11-306-9/+207
| | | | | | | | | | | | | | | | per-message or per-room (#8820) This PR adds a new config option to the `push` section of the homeserver config, `group_unread_count_by_room`. By default Synapse will group push notifications by room (so if you have 1000 unread messages, if they lie in 55 rooms, you'll see an unread count on your phone of 55). However, it is also useful to be able to send out the true count of unread messages if desired. If `group_unread_count_by_room` is set to `false`, then with the above example, one would see an unread count of 1000 (email anyone?).
* | Simplify the way the `HomeServer` object caches its internal attributes. ↵Jonathan de Jong2020-11-3011-35/+39
| | | | | | | | | | (#8565) Changes `@cache_in_self` to use underscore-prefixed attributes.
* | Add `force_purge` option to delete-room admin api. (#8843)Richard van der Hoff2020-11-304-12/+34
| |
* | Remove special case of pretty printing JSON responses for curl (#8833)Tulir Asokan2020-11-272-24/+6
| | | | | | | | | | * Remove special case of pretty printing JSON responses for curl Signed-off-by: Tulir Asokan <tulir@maunium.net>
* | Add typing to membership Replication class methods (#8809)Andrew Morgan2020-11-272-22/+45
| | | | | | | | | | This PR grew out of #6739, and adds typing to some method arguments You'll notice that there are a lot of `# type: ignores` in here. This is due to the base methods not matching the overloads here. This is necessary to stop mypy complaining, but a better solution is #8828.
* | Update example prometheus console (#8824)Dirk Klimpel2020-11-262-51/+51
| | | | | | | | Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Defer SIGHUP handlers to reactor. (#8817)Erik Johnston2020-11-262-1/+10
| | | | | | | | | | | | | | | | | | We can get a SIGHUP at any point, including times where we are not in a sane state. By deferring calling the handlers until the next reactor tick we ensure that we don't get unexpected conflicts, e.g. trying to flush logs from the signal handler while the code was in the process of writing a log entry. Fixes #8769.
* | Strip trailing / from server_url in register_new_matrix_user (#8823)Dmitry Borodaenko2020-11-262-1/+2
| | | | | | | | | | | | | | | | | | When server URL provided to register_new_matrix_user includes path component (e.g. "http://localhost:8008/"), the command fails with "ERROR! Received 400 Bad Request". Stripping trailing slash from the server_url command argument makes sure combined endpoint URL remains valid. Signed-off-by: Dmitry Borodaenko angdraug@debian.org
* | Improve documentation how to configure prometheus for workers (#8822)Dirk Klimpel2020-11-263-20/+65
| |
* | Remove deprecated `/_matrix/client/*/admin` endpoints (#8785)Dirk Klimpel2020-11-2516-68/+176
| | | | | | These are now only available via `/_synapse/admin/v1`.
* | Fix the formatting of push config section (#8818)Andrew Morgan2020-11-253-29/+40
| | | | | | This PR updates the push config's formatting to better align with our [code style guidelines](https://github.com/matrix-org/synapse/blob/develop/docs/code_style.md#configuration-file-format).
* | Speed up remote invite rejection database call (#8815)Andrew Morgan2020-11-253-6/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | This is another PR that grew out of #6739. The existing code for checking whether a user is currently invited to a room when they want to leave the room looks like the following: https://github.com/matrix-org/synapse/blob/f737368a26bb9eea401fcc3a5bdd7e0b59e91f09/synapse/handlers/room_member.py#L518-L540 It calls `get_invite_for_local_user_in_room`, which will actually query *all* rooms the user has been invited to, before iterating over them and matching via the room ID. It will then return a tuple of a lot of information which we pull the event ID out of. I need to do a similar check for knocking, but this code wasn't very efficient. I then tried to write a different implementation using `StateHandler.get_current_state` but this actually didn't work as we haven't *joined* the room yet - we've only been invited to it. That means that only certain tables in Synapse have our desired `invite` membership state. One of those tables is `local_current_membership`. So I wrote a store method that just queries that table instead
* | Add additional type hints to HTTP client. (#8812)Patrick Cloke2020-11-255-149/+142
| | | | | | | | This also removes some duplicated code between the simple HTTP client and matrix federation client.
* | Support trying multiple localparts for OpenID Connect. (#8801)Patrick Cloke2020-11-256-136/+330
| | | | | | | | Abstracts the SAML and OpenID Connect code which attempts to regenerate the localpart of a matrix ID if it is already in use.
* | Add type hints to matrix federation client / agent. (#8806)Patrick Cloke2020-11-256-195/+231
| |
* | Clarify documentation of the admin list media API (#8795)Dirk Klimpel2020-11-242-0/+2
| | | | | | Clarify that the list media API only shows media from unencrypted events.
* | Add a script to sign arbitrary json objects. (#8772)Richard van der Hoff2020-11-243-0/+129
| |
* | Update turn-howto (#8779)Richard van der Hoff2020-11-242-8/+124
| | | | | | Some hopefully-useful notes on setting up a turnserver.
* | Properly report user-agent/IP during registration of SSO users. (#8784)Patrick Cloke2020-11-236-122/+173
| | | | | | | | | | This also expands type-hints to the SSO and registration code. Refactors the CAS code to more closely match OIDC/SAML.
* | Fix synctl and duplicate worker spawning (#8798)Waylon Cude2020-11-232-0/+8
| | | | | | | | | | | | | | | | | | Synctl did not check if a worker thread was already running when using `synctl start` and would naively start a fresh copy. This would sometimes lead to cases where many duplicate copies of a single worker would run. This fix adds a pid check when starting worker threads and synctl will now refuse to start individual workers if they're already running.
* | Improve logging of the mapping from SSO IDs to Matrix IDs. (#8773)Andrew Morgan2020-11-233-5/+13
| |
* | INSTALL: Fix setting content-type on well-known (#8793)Daniele Sluijters2020-11-232-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using `add_header` nginx will literally add a header. If a `content-type` header is already configured (for example through a server wide default), this means we end up with 2 content-type headers, like so: ``` content-type: text/html content-type: application/json access-control-allow-origin: * ``` That doesn't make sense. Instead, we want the content type of that block to only be `application/json` which we can achieve using `default_type` instead. Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>
* | fix MDMatthew Hodgson2020-11-221-2/+2
| |
* | fix ancient changelog to be MDMatthew Hodgson2020-11-221-150/+146
| |
* | Improve error checking for OIDC/SAML mapping providers (#8774)Patrick Cloke2020-11-197-29/+137
| | | | | | | | | | | | Checks that the localpart returned by mapping providers for SAML and OIDC are valid before registering new users. Extends the OIDC tests for existing users and invalid data.
* | SAML: Allow specifying the IdP entityid to use. (#8630)Ben Banfield-Zanin2020-11-194-1/+21
| | | | | | | | If the SAML metadata includes multiple IdPs it is necessary to specify which IdP to redirect users to for authentication.
* | Consistently use room_id from federation request body (#8776)Richard van der Hoff2020-11-195-54/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | * Consistently use room_id from federation request body Some federation APIs have a redundant `room_id` path param (see https://github.com/matrix-org/matrix-doc/issues/2330). We should make sure we consistently use either the path param or the body param, and the body param is easier. * Kill off some references to "context" Once upon a time, "rooms" were known as "contexts". I think this kills of the last references to "contexts".
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-23 20:15:16 +0000