summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8535 from matrix-org/rav/third_party_events_updatesRichard van der Hoff2020-10-156-81/+118
|\ | | | | Support modifying event content from ThirdPartyRules modules
| * changelogRichard van der Hoff2020-10-131-0/+1
| |
| * guard against accidental modificationRichard van der Hoff2020-10-133-3/+30
| |
| * Allow ThirdPartyRules modules to replace event contentRichard van der Hoff2020-10-133-9/+75
| | | | | | | | Support returning a new event dict from `check_event_allowed`.
| * Move third_party_rules check to event creation timeRichard van der Hoff2020-10-132-52/+13
| | | | | | | | | | Rather than waiting until we handle the event, call the ThirdPartyRules check when we fist create the event.
| * Remove redundant calls to third_party_rules in `on_send_{join,leave}`Richard van der Hoff2020-10-131-19/+1
| | | | | | | | | | There's not much point in calling these *after* we have decided to accept them into the DAG.
* | Solidify the HomeServer constructor. (#8515)Jonathan de Jong2020-10-157-25/+33
| | | | | | | | | | | | This implements a more standard API for instantiating a homeserver and moves some of the dependency injection into the test suite. More concretely this stops using `setattr` on all `kwargs` passed to `HomeServer`.
* | Send some ephemeral events to appservices (#8437)Will Hunt2020-10-1516-122/+563
| | | | | | Optionally sends typing, presence, and read receipt information to appservices.
* | Add option to scripts-dev/lint.sh to only lint files changed since the last ↵Andrew Morgan2020-10-154-12/+90
| | | | | | | | | | | | | | | | | | | | git commit (#8472) This PR makes several changes to the `./scripts-dev/lint.sh` script, which lints the codebase with a number of tools: * Adds usage information, with `-h` flag to show it. Otherwise it will show when providing an unknown flag. * Adds option `-d` which will check both staged and unstaged files that have changed since the last commit and add them to the list of files to lint. - Note that only files without an extension, or with a `.py` extension will be allowed. This prevents editing bash scripts causing the linters to break on non-python files. * Improves the print-out of which files/directories are being linted.
* | Merge branch 'master' into developPatrick Cloke2020-10-154-2/+32
|\ \
| * | Additional tweaks. v1.21.2 github/release-v1.21.2 release-v1.21.2Patrick Cloke2020-10-151-3/+3
| | |
| * | Clarify authlib changes.Patrick Cloke2020-10-151-1/+3
| | |
| * | Fix typo.Patrick Cloke2020-10-151-1/+1
| | |
| * | Add additional release notes.Patrick Cloke2020-10-151-0/+13
| | |
| * | 1.21.2Patrick Cloke2020-10-154-2/+17
| | |
* | | Merge branch 'release-v1.21.2' into developPatrick Cloke2020-10-150-0/+0
|\| |
| * | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-152-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | | Enable mypy for synapse.util.caches (#8547)Richard van der Hoff2020-10-155-10/+185
| | | | | | | | | This seemed to entail dragging in a type stub for SortedList.
* | | Merge pull request #8548 from matrix-org/rav/deferred_cacheRichard van der Hoff2020-10-1512-374/+454
|\ \ \ | | | | | | | | Rename Cache to DeferredCache, and related changes
| * | | changelogRichard van der Hoff2020-10-141-0/+1
| | | |
| * | | Combine the two sets of DeferredCache testsRichard van der Hoff2020-10-142-74/+75
| | | |
| * | | move DeferredCache into its own moduleRichard van der Hoff2020-10-1410-332/+367
| | | |
| * | | Rename Cache->DeferredCacheRichard van der Hoff2020-10-148-25/+30
| | | |
| * | | Add some more type annotations to CacheRichard van der Hoff2020-10-143-24/+62
| | |/ | |/|
* | | Include user agent in user daily visits table (#8503)Neil Johnson2020-10-153-3/+27
| | | | | | | | | Include user agent in user daily visits table.
* | | Merge pull request #8537 from matrix-org/rav/simplify_locally_reject_inviteRichard van der Hoff2020-10-159-65/+56
|\ \ \ | | | | | | | | Simplify `_locally_reject_invite`
| * | | changelogRichard van der Hoff2020-10-131-0/+1
| | | |
| * | | Simplify `_locally_reject_invite`Richard van der Hoff2020-10-136-57/+52
| | | | | | | | | | | | | | | | | | | | Update `EventCreationHandler.create_event` to accept an auth_events param, and use it in `_locally_reject_invite` instead of reinventing the wheel.
| * | | Remove redundant `token_id` parameter to create_eventRichard van der Hoff2020-10-134-8/+3
| |/ / | | | | | | | | | this is always the same as requester.access_token_id.
* | | Use autocommit mode for single statement DB functions. (#8542)Erik Johnston2020-10-145-70/+156
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autocommit means that we don't wrap the functions in transactions, and instead get executed directly. Introduced in #8456. This will help: 1. reduce the number of `could not serialize access due to concurrent delete` errors that we see (though there are a few functions that often cause serialization errors that we don't fix here); 2. improve the DB performance, as it no longer needs to deal with the overhead of `REPEATABLE READ` isolation levels; and 3. improve wall clock speed of these functions, as we no longer need to send `BEGIN` and `COMMIT` to the DB. Some notes about the differences between autocommit mode and our default `REPEATABLE READ` transactions: 1. Currently `autocommit` only applies when using PostgreSQL, and is ignored when using SQLite (due to silliness with [Twisted DB classes](https://twistedmatrix.com/trac/ticket/9998)). 2. Autocommit functions may get retried on error, which means they can get applied *twice* (or more) to the DB (since they are not in a transaction the previous call would not get rolled back). This means that the functions need to be idempotent (or otherwise not care about being called multiple times). Read queries, simple deletes, and updates/upserts that replace rows (rather than generating new values from existing rows) are all idempotent. 3. Autocommit functions no longer get executed in [`REPEATABLE READ`](https://www.postgresql.org/docs/current/transaction-iso.html) isolation level, and so data can change queries, which is fine for single statement queries.
* | | Remove racey assertion in MultiWriterIDGenerator (#8530)Erik Johnston2020-10-142-7/+1
| | | | | | | | | | | | | | | | | | | | | | | | We asserted that the IDs returned by postgres sequence was greater than any we had seen, however this is technically racey as we may update the current positions out of order. We now assert that the sequences are correct on startup, so the assertion is no longer really required, so we remove them.
* | | Add note to manhole.md about bind_address when using with docker (#8526)Christopher May-Townsend2020-10-142-7/+40
| | | | | | | | | | | | Signed-off-by: Christopher May-Townsend <chris@maytownsend.co.uk>
* | | Update documentation on retention policies limits (#8529)Brendan Abolivier2020-10-142-12/+23
| | | | | | | | | | | | | | | * Update documentation on retention policies limits Document the changes from https://github.com/matrix-org/synapse/pull/8104
* | | Add basic tests for sync/pagination with vector clock tokens. (#8488)Erik Johnston2020-10-143-1/+249
| | | | | | | | | | | | | | | These are tests for #8439
* | | Fix not sending events over federation when using sharded event persisters ↵Erik Johnston2020-10-1410-21/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8536) * Fix outbound federaion with multiple event persisters. We incorrectly notified federation senders that the minimum persisted stream position had advanced when we got an `RDATA` from an event persister. Notifying of federation senders already correctly happens in the notifier, so we just delete the offending line. * Change some interfaces to use RoomStreamToken. By enforcing use of `RoomStreamTokens` we make it less likely that people pass in random ints that they got from somewhere random.
* | | Make sure a retention policy is a state event (#8527)Brendan Abolivier2020-10-143-0/+8
| | | | | | | | | | | | | | | * Make sure a retention policy is a state event * Changelog
* | | Add correct M_BAD_JSON error code to /profile/{userId}/displayname (#8517)Aaron Raimist2020-10-142-1/+4
|/ / | | | | Fixes #8029
* | Move additional tasks to the background worker, part 4 (#8513)Patrick Cloke2020-10-1311-221/+196
| |
* | Fix message duplication if something goes wrong after persisting the event ↵Erik Johnston2020-10-1313-32/+481
| | | | | | | | | | (#8476) Should fix #3365.
* | Merge branch 'master' into developAndrew Morgan2020-10-134-2/+18
|\| | | | | | | | | | | * master: 1.21.1 Explicitly install test dependencies when building deb packages (#8523)
| * 1.21.1 v1.21.1 github/release-v1.21.1 release-v1.21.1Andrew Morgan2020-10-133-3/+13
| |
| * Explicitly install test dependencies when building deb packages (#8523)Andrew Morgan2020-10-122-1/+7
| | | | | | | | | | After https://github.com/matrix-org/synapse/pull/8377, the deb packages no longer indirectly installed the `"test"` dependencies, causing debian packages to fail to build while carrying out the unit tests. This PR installs `test` dependencies explicitly when building debian packages.
* | Multi arch docker support: add arm/v7 and arm64 to our docker images (#7921)Christopher May-Townsend2020-10-122-8/+53
| | | | | | Signed-off-by: Christopher May-Townsend (chris@maytownsend.co.uk)
* | Merge branch 'master' into developAndrew Morgan2020-10-123-4/+25
|\|
| * Reverse proxies are not the only thing to change;be explicit w/ new endpoint v1.21.0 github/release-v1.21.0 release-v1.21.0Andrew Morgan2020-10-121-6/+7
| |
| * Add deprecation warning for admin api under client api prefixesAndrew Morgan2020-10-121-0/+8
| |
| * 1.21.0Andrew Morgan2020-10-123-1/+13
| |
* | Make event persisters periodically announce position over replication. (#8499)Erik Johnston2020-10-129-34/+128
| | | | | | | | | | Currently background proccesses stream the events stream use the "minimum persisted position" (i.e. `get_current_token()`) rather than the vector clock style tokens. This is broadly fine as it doesn't matter if the background processes lag a small amount. However, in extreme cases (i.e. SyTests) where we only write to one event persister the background processes will never make progress. This PR changes it so that the `MultiWriterIDGenerator` keeps the current position of a given instance as up to date as possible (i.e using the latest token it sees if its not in the process of persisting anything), and then periodically announces that over replication. This then allows the "minimum persisted position" to advance, albeit with a small lag.
* | Docker: support passing additional commandline args to synapse (#8390)Samuel Philipp2020-10-113-18/+44
| |
* | Clean-up some broken/unused code in the test framework (#8514)Patrick Cloke2020-10-093-70/+55
| |
* | Fix threadsafety in ThreadedMemoryReactorClock (#8497)Richard van der Hoff2020-10-092-4/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This could, very occasionally, cause: ``` tests.test_visibility.FilterEventsForServerTestCase.test_large_room =============================================================================== [ERROR] Traceback (most recent call last): File "/src/tests/rest/media/v1/test_media_storage.py", line 86, in test_ensure_media_is_in_local_cache self.wait_on_thread(x) File "/src/tests/unittest.py", line 296, in wait_on_thread self.reactor.advance(0.01) File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 826, in advance self._sortCalls() File "/src/.tox/py35/lib/python3.5/site-packages/twisted/internet/task.py", line 787, in _sortCalls self.calls.sort(key=lambda a: a.getTime()) builtins.ValueError: list modified during sort tests.rest.media.v1.test_media_storage.MediaStorageTests.test_ensure_media_is_in_local_cache ```
* | Increase default max_upload_size from 10M to 50M (#8502)Mateusz Przybyłowicz2020-10-095-5/+6
| | | | | | Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>
* | Add type hints to response cache. (#8507)Patrick Cloke2020-10-099-34/+48
| |
* | Allow modules to create and send events into rooms (#8479)Andrew Morgan2020-10-095-8/+157
| | | | | | | | | | This PR allows Synapse modules making use of the `ModuleApi` to create and send non-membership events into a room. This can useful to have modules send messages, or change power levels in a room etc. Note that they must send event through a user that's already in the room. The non-membership event limitation is currently arbitrary, as it's another chunk of work and not necessary at the moment.
* | Only send RDATA for instance local events. (#8496)Erik Johnston2020-10-096-25/+54
| | | | | | | | | | When pulling events out of the DB to send over replication we were not filtering by instance name, and so we were sending events for other instances.
* | Move additional tasks to the background worker, part 3 (#8489)Patrick Cloke2020-10-098-282/+276
| |
* | Remove the deprecated Handlers object (#8494)Patrick Cloke2020-10-0940-157/+116
| | | | | | All handlers now available via get_*_handler() methods on the HomeServer.
* | Add type hints to some handlers (#8505)Patrick Cloke2020-10-0910-22/+60
| |
* | Invalidate the cache when an olm fallback key is uploaded (#8501)Hubert Chathi2020-10-083-0/+25
| |
* | Merge tag 'v1.21.0rc3' into developErik Johnston2020-10-084-3/+16
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc3 (2020-10-08) ============================== Bugfixes -------- - Fix duplication of events on high traffic servers, caused by PostgreSQL `could not serialize access due to concurrent update` errors. ([\#8456](https://github.com/matrix-org/synapse/issues/8456)) Internal Changes ---------------- - Add Groovy Gorilla to the list of distributions we build `.deb`s for. ([\#8475](https://github.com/matrix-org/synapse/issues/8475))
| * Update change log v1.21.0rc3Erik Johnston2020-10-081-1/+1
| |
| * 1.21.0rc3Erik Johnston2020-10-084-3/+16
| |
* | Add useful shields to readme (#8493)Mateusz Przybyłowicz2020-10-082-7/+24
| | | | | | | | | | | | Added shields directing to synapse-dev room, showing license, latest version on PyPi and supported Python versions. I've moved substitution definitions to the bottom to improve readability. Signed-off-by: Mateusz Przybyłowicz <uamfhq@gmail.com>
* | Clarify error message when plugin config parsers raise an error (#8492)Richard van der Hoff2020-10-082-1/+2
| | | | | | | | | | | | | | | | | | This turns: Failed to parse config for 'myplugin': Exception('error message') into: Failed to parse config for 'myplugin': error message.
* | Merge remote-tracking branch 'origin/release-v1.21.0' into developErik Johnston2020-10-072-0/+2
|\|
| * Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-077-5/+109
| | | | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
| * Add Ubuntu 20.10 (Groovy Gorilla) to build scripts. (#8475)Patrick Cloke2020-10-072-0/+2
| |
* | Move additional tasks to the background worker (#8458)Patrick Cloke2020-10-078-197/+195
| |
* | Include the configured log level in phone home stats. (#8477)Patrick Cloke2020-10-072-0/+8
| | | | | | By reporting the log level of the synapse logger as a string.
* | Reduce serialization errors in MultiWriterIdGen (#8456)Erik Johnston2020-10-077-8/+112
| | | | | | | | | | | | We call `_update_stream_positions_table_txn` a lot, which is an UPSERT that can conflict in `REPEATABLE READ` isolation level. Instead of doing a transaction consisting of a single query we may as well run it outside of a transaction.
* | Use vector clocks for room stream tokens. (#8439)Erik Johnston2020-10-074-42/+380
| | | | | | | | | | | | | | | | | | | | Currently when using multiple event persisters we (in the worst case) don't tell clients about events until all event persisters have persisted new events after the original event. This is a suboptimal, especially if one of the event persisters goes down. To handle this, we encode the position of each event persister in the room tokens so that we can send events to clients immediately. To reduce the size of the token we do two things: 1. We create a unique immutable persistent mapping between instance names and a generated small integer ID, which we can encode in the tokens instead of the instance name; and 2. We encode the "persisted upto position" of the room token and then only explicitly include instances that have positions strictly greater than that. The new tokens look something like: `m3478~1.3488~2.3489`, where the first number is the min position, and the subsequent `-` separated pairs are the instance ID to positions map. (We use `.` and `~` as separators as they're URL safe and not already used by `StreamToken`).
* | Add typing information to the device handler. (#8407)Patrick Cloke2020-10-074-38/+59
| |
* | Fix returning incorrect prev_batch token in incremental sync (#8486)Erik Johnston2020-10-072-1/+7
| |
* | unblacklist some tests (#8474)Richard van der Hoff2020-10-073-34/+1
| | | | | | | | | | It seems most of these blacklisted tests do actually pass most of the time. I'm of the opinion that having them blacklisted here means there is very little incentive for us to deflake any flaky tests, and meanwhile any value in those tests is completely lost.
* | Add support for MSC2697: Dehydrated devices (#8380)Hubert Chathi2020-10-079-21/+454
| | | | | | | | This allows a user to store an offline device on the server and then restore it at a subsequent login.
* | Merge pull request #8463 from matrix-org/rav/clean_up_event_handlingRichard van der Hoff2020-10-076-92/+83
|\ \ | | | | | | Reduce inconsistencies between codepaths for membership and non-membership events.
| * | update wordingRichard van der Hoff2020-10-071-2/+3
| | |
| * | changelogRichard van der Hoff2020-10-051-0/+1
| | |
| * | kill off `send_nonmember_event`Richard van der Hoff2020-10-054-53/+31
| | | | | | | | | | | | This is now redundant, and we can just call `handle_new_client_event` directly.
| * | pull up event.sender assertionRichard van der Hoff2020-10-052-4/+5
| | |
| * | Move shadow-ban check down into `handle_new_client_event`.Richard van der Hoff2020-10-051-8/+24
| | |
| * | De-duplicate duplicate handlingRichard van der Hoff2020-10-052-38/+32
| | | | | | | | | | | | | | | move the "duplicate state event" handling down into `handle_new_client_event` where it can be shared between multiple call paths.
* | | Combine `SpamCheckerApi` with the more generic `ModuleApi`. (#8464)Richard van der Hoff2020-10-0710-58/+51
| | | | | | | | | | | | | | | Lots of different module apis is not easy to maintain. Rather than adding yet another ModuleApi(hs, hs.get_auth_handler()) incantation, first add an hs.get_module_api() method and use it where possible.
* | | Remove docs/sphinx and related references (#8480)Andrew Morgan2020-10-0762-839/+1
| | | | | | | | | https://github.com/matrix-org/synapse/tree/develop/docs/sphinx doesn't seem to really be utilised or changed recently since the initial commit. I like the idea of exportable documentation of the codebase, but at the moment after running through the build instructions the generated website wasn't very useful...
* | | Add support for MSC2732: olm fallback keys (#8312)Hubert Chathi2020-10-068-1/+215
| | |
* | | Additional tests for third-party event rules (#8468)Richard van der Hoff2020-10-063-18/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Optimise and test state fetching for 3p event rules Getting all the events at once is much more efficient than getting them individually * Test that 3p event rules can modify events
* | | Merge pull request #8467 from matrix-org/rav/fix_3pevent_rulesRichard van der Hoff2020-10-063-2/+5
|\ \ \ | | | | | | | | Fix third-party event modules for `check_visibility_can_be_modified` check
| * | | Fix third-party event modules for `check_visibility_can_be_modified` checkRichard van der Hoff2020-10-053-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | PR #8292 tried to maintain backwards compat with modules which don't provide a `check_visibility_can_be_modified` method, but the tests weren't being run, and the check didn't work.
* | | | Don't bother responding to client requests that have already disconnected ↵Andrew Morgan2020-10-063-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#8465) This PR ports the quick fix from https://github.com/matrix-org/synapse/pull/2796 to further methods which handle media, URL preview and `/key/v2/server` requests. This prevents a harmless `ERROR` that comes up in the logs when we were unable to respond to a client request when the client had already disconnected. In this case we simply bail out if the client has already done so. This is the 'simple fix' as suggested by https://github.com/matrix-org/synapse/issues/5304#issuecomment-574740003. Fixes https://github.com/matrix-org/synapse/issues/6700 Fixes https://github.com/matrix-org/synapse/issues/5304
* | | | Update default room version to 6 (#8461)Richard van der Hoff2020-10-054-3/+13
|/ / / | | | | | | | | | Per https://github.com/matrix-org/matrix-doc/pull/2788
* / / Ensure that event.redacts is the proper type before handling it (#8457)Patrick Cloke2020-10-052-0/+3
|/ / | | | | This fixes a bug when backfilling invalid events.
* | Allow ThirdPartyEventRules modules to manipulate public room state (#8292)Andrew Morgan2020-10-058-19/+223
| | | | | | | | | | This PR allows `ThirdPartyEventRules` modules to view, manipulate and block changes to the state of whether a room is published in the public rooms directory. While the idea of whether a room is in the public rooms list is not kept within an event in the room, `ThirdPartyEventRules` generally deal with controlling which modifications can happen to a room. Public rooms fits within that idea, even if its toggle state isn't controlled through a state event.
* | Remove stream ordering from Metadata dict (#8452)Richard van der Hoff2020-10-0513-33/+53
| | | | | | | | | | | | | | | | There's no need for it to be in the dict as well as the events table. Instead, we store it in a separate attribute in the EventInternalMetadata object, and populate that on load. This means that we can rely on it being correctly populated for any event which has been persited to the database.
* | Update manhole documentation for async/await. (#8462)Patrick Cloke2020-10-052-2/+6
| |
* | Do not assume that account data is of the correct form. (#8454)Patrick Cloke2020-10-056-21/+34
| | | | | | | | This fixes a bug where `m.ignored_user_list` was assumed to be a dict, leading to odd behavior for users who set it to something else.
* | Add logging on startup/shutdown (#8448)Erik Johnston2020-10-0225-113/+152
| | | | | | | | | | This is so we can tell what is going on when things are taking a while to start up. The main change here is to ensure that transactions that are created during startup get correctly logged like normal transactions.
* | Speed up unit tests when using PostgreSQL (#8450)Erik Johnston2020-10-023-1/+17
| |
* | Allow background tasks to be run on a separate worker. (#8369)Patrick Cloke2020-10-0219-449/+537
| |
* | Merge tag 'v1.21.0rc2' into developRichard van der Hoff2020-10-0214-141/+163
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc2 (2020-10-02) ============================== Features -------- - Convert additional templates from inline HTML to Jinja2 templates. ([\#8444](https://github.com/matrix-org/synapse/issues/8444)) Bugfixes -------- - Fix a regression in v1.21.0rc1 which broke thumbnails of remote media. ([\#8438](https://github.com/matrix-org/synapse/issues/8438)) - Do not expose the experimental `uk.half-shot.msc2778.login.application_service` flow in the login API, which caused a compatibility problem with Element iOS. ([\#8440](https://github.com/matrix-org/synapse/issues/8440)) - Fix malformed log line in new federation "catch up" logic. ([\#8442](https://github.com/matrix-org/synapse/issues/8442)) - Fix DB query on startup for negative streams which caused long start up times. Introduced in [\#8374](https://github.com/matrix-org/synapse/issues/8374). ([\#8447](https://github.com/matrix-org/synapse/issues/8447))
| * move #8444 to 'feature' v1.21.0rc2Richard van der Hoff2020-10-021-1/+5
| |
| * linkify changelogRichard van der Hoff2020-10-021-1/+1
| |
| * 1.21.0rc2Richard van der Hoff2020-10-021-1/+1
| |
| * 1.21.0rc2Richard van der Hoff2020-10-027-6/+14
| |
| * Fix bug in remote thumbnail search (#8438)Richard van der Hoff2020-10-022-20/+24
| | | | | | | | | | #7124 changed the behaviour of remote thumbnails so that the thumbnailing method was included in the filename of the thumbnail. To support existing files, it included a fallback so that we would check the old filename if the new filename didn't exist. Unfortunately, it didn't apply this logic to storage providers, so any thumbnails stored on such a storage provider was broken.
| * Fix DB query on startup for negative streams. (#8447)Erik Johnston2020-10-022-1/+2
| | | | | | | | | | | | | | | | For negative streams we have to negate the internal stream ID before querying the DB. The effect of this bug was to query far too many rows, slowing start up time, but we would correctly filter the results afterwards so there was no ill effect.
| * Convert additional templates to Jinja (#8444)Patrick Cloke2020-10-029-116/+121
| | | | | | This converts a few more of our inline HTML templates to Jinja. This is somewhat part of #7280 and should make it a bit easier to customize these in the future.
| * Fix malformed log line in new federation "catch up" logic (#8442)Richard van der Hoff2020-10-022-1/+2
| |
| * Do not expose the experimental appservice login flow to clients. (#8440)Patrick Cloke2020-10-012-2/+1
| |
* | Include a public_baseurl in configs generated by the demo script. (#8443)Patrick Cloke2020-10-022-0/+3
| |
* | Add unit test for event persister sharding (#8433)Erik Johnston2020-10-028-27/+371
| |
* | Add config option for always using "userinfo endpoint" for OIDC (#7658)BBBSnowball2020-10-016-15/+65
| | | | | | This allows for connecting to certain IdPs, e.g. GitLab.
* | Merge tag 'v1.21.0rc1' into developRichard van der Hoff2020-10-0188-88/+103
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.21.0rc1 (2020-10-01) ============================== Features -------- - Require the user to confirm that their password should be reset after clicking the email confirmation link. ([\#8004](https://github.com/matrix-org/synapse/issues/8004)) - Add an admin API `GET /_synapse/admin/v1/event_reports` to read entries of table `event_reports`. Contributed by @dklimpel. ([\#8217](https://github.com/matrix-org/synapse/issues/8217)) - Consolidate the SSO error template across all configuration. ([\#8248](https://github.com/matrix-org/synapse/issues/8248), [\#8405](https://github.com/matrix-org/synapse/issues/8405)) - Add a configuration option to specify a whitelist of domains that a user can be redirected to after validating their email or phone number. ([\#8275](https://github.com/matrix-org/synapse/issues/8275), [\#8417](https://github.com/matrix-org/synapse/issues/8417)) - Add experimental support for sharding event persister. ([\#8294](https://github.com/matrix-org/synapse/issues/8294), [\#8387](https://github.com/matrix-org/synapse/issues/8387), [\#8396](https://github.com/matrix-org/synapse/issues/8396), [\#8419](https://github.com/matrix-org/synapse/issues/8419)) - Add the room topic and avatar to the room details admin API. ([\#8305](https://github.com/matrix-org/synapse/issues/8305)) - Add an admin API for querying rooms where a user is a member. Contributed by @dklimpel. ([\#8306](https://github.com/matrix-org/synapse/issues/8306)) - Add `uk.half-shot.msc2778.login.application_service` login type to allow appservices to login. ([\#8320](https://github.com/matrix-org/synapse/issues/8320)) - Add a configuration option that allows existing users to log in with OpenID Connect. Contributed by @BBBSnowball and @OmmyZhang. ([\#8345](https://github.com/matrix-org/synapse/issues/8345)) - Add prometheus metrics for replication requests. ([\#8406](https://github.com/matrix-org/synapse/issues/8406)) - Support passing additional single sign-on parameters to the client. ([\#8413](https://github.com/matrix-org/synapse/issues/8413)) - Add experimental reporting of metrics on expensive rooms for state-resolution. ([\#8420](https://github.com/matrix-org/synapse/issues/8420)) - Add experimental prometheus metric to track numbers of "large" rooms for state resolutiom. ([\#8425](https://github.com/matrix-org/synapse/issues/8425)) - Add prometheus metrics to track federation delays. ([\#8430](https://github.com/matrix-org/synapse/issues/8430)) Bugfixes -------- - Fix a bug in the media repository where remote thumbnails with the same size but different crop methods would overwrite each other. Contributed by @deepbluev7. ([\#7124](https://github.com/matrix-org/synapse/issues/7124)) - Fix inconsistent handling of non-existent push rules, and stop tracking the `enabled` state of removed push rules. ([\#7796](https://github.com/matrix-org/synapse/issues/7796)) - Fix a longstanding bug when storing a media file with an empty `upload_name`. ([\#7905](https://github.com/matrix-org/synapse/issues/7905)) - Fix messages not being sent over federation until an event is sent into the same room. ([\#8230](https://github.com/matrix-org/synapse/issues/8230), [\#8247](https://github.com/matrix-org/synapse/issues/8247), [\#8258](https://github.com/matrix-org/synapse/issues/8258), [\#8272](https://github.com/matrix-org/synapse/issues/8272), [\#8322](https://github.com/matrix-org/synapse/issues/8322)) - Fix a longstanding bug where files that could not be thumbnailed would result in an Internal Server Error. ([\#8236](https://github.com/matrix-org/synapse/issues/8236), [\#8435](https://github.com/matrix-org/synapse/issues/8435)) - Upgrade minimum version of `canonicaljson` to version 1.4.0, to fix an unicode encoding issue. ([\#8262](https://github.com/matrix-org/synapse/issues/8262)) - Fix longstanding bug which could lead to incomplete database upgrades on SQLite. ([\#8265](https://github.com/matrix-org/synapse/issues/8265)) - Fix stack overflow when stderr is redirected to the logging system, and the logging system encounters an error. ([\#8268](https://github.com/matrix-org/synapse/issues/8268)) - Fix a bug which cause the logging system to report errors, if `DEBUG` was enabled and no `context` filter was applied. ([\#8278](https://github.com/matrix-org/synapse/issues/8278)) - Fix edge case where push could get delayed for a user until a later event was pushed. ([\#8287](https://github.com/matrix-org/synapse/issues/8287)) - Fix fetching malformed events from remote servers. ([\#8324](https://github.com/matrix-org/synapse/issues/8324)) - Fix `UnboundLocalError` from occuring when appservices send a malformed register request. ([\#8329](https://github.com/matrix-org/synapse/issues/8329)) - Don't send push notifications to expired user accounts. ([\#8353](https://github.com/matrix-org/synapse/issues/8353)) - Fix a regression in v1.19.0 with reactivating users through the admin API. ([\#8362](https://github.com/matrix-org/synapse/issues/8362)) - Fix a bug where during device registration the length of the device name wasn't limited. ([\#8364](https://github.com/matrix-org/synapse/issues/8364)) - Include `guest_access` in the fields that are checked for null bytes when updating `room_stats_state`. Broke in v1.7.2. ([\#8373](https://github.com/matrix-org/synapse/issues/8373)) - Fix theoretical race condition where events are not sent down `/sync` if the synchrotron worker is restarted without restarting other workers. ([\#8374](https://github.com/matrix-org/synapse/issues/8374)) - Fix a bug which could cause errors in rooms with malformed membership events, on servers using sqlite. ([\#8385](https://github.com/matrix-org/synapse/issues/8385)) - Fix "Re-starting finished log context" warning when receiving an event we already had over federation. ([\#8398](https://github.com/matrix-org/synapse/issues/8398)) - Fix incorrect handling of timeouts on outgoing HTTP requests. ([\#8400](https://github.com/matrix-org/synapse/issues/8400)) - Fix a regression in v1.20.0 in the `synapse_port_db` script regarding the `ui_auth_sessions_ips` table. ([\#8410](https://github.com/matrix-org/synapse/issues/8410)) - Remove unnecessary 3PID registration check when resetting password via an email address. Bug introduced in v0.34.0rc2. ([\#8414](https://github.com/matrix-org/synapse/issues/8414)) Improved Documentation ---------------------- - Add `/_synapse/client` to the reverse proxy documentation. ([\#8227](https://github.com/matrix-org/synapse/issues/8227)) - Add note to the reverse proxy settings documentation about disabling Apache's mod_security2. Contributed by Julian Fietkau (@jfietkau). ([\#8375](https://github.com/matrix-org/synapse/issues/8375)) - Improve description of `server_name` config option in `homserver.yaml`. ([\#8415](https://github.com/matrix-org/synapse/issues/8415)) Deprecations and Removals ------------------------- - Drop support for `prometheus_client` older than 0.4.0. ([\#8426](https://github.com/matrix-org/synapse/issues/8426)) Internal Changes ---------------- - Fix tests on distros which disable TLSv1.0. Contributed by @danc86. ([\#8208](https://github.com/matrix-org/synapse/issues/8208)) - Simplify the distributor code to avoid unnecessary work. ([\#8216](https://github.com/matrix-org/synapse/issues/8216)) - Remove the `populate_stats_process_rooms_2` background job and restore functionality to `populate_stats_process_rooms`. ([\#8243](https://github.com/matrix-org/synapse/issues/8243)) - Clean up type hints for `PaginationConfig`. ([\#8250](https://github.com/matrix-org/synapse/issues/8250), [\#8282](https://github.com/matrix-org/synapse/issues/8282)) - Track the latest event for every destination and room for catch-up after federation outage. ([\#8256](https://github.com/matrix-org/synapse/issues/8256)) - Fix non-user visible bug in implementation of `MultiWriterIdGenerator.get_current_token_for_writer`. ([\#8257](https://github.com/matrix-org/synapse/issues/8257)) - Switch to the JSON implementation from the standard library. ([\#8259](https://github.com/matrix-org/synapse/issues/8259)) - Add type hints to `synapse.util.async_helpers`. ([\#8260](https://github.com/matrix-org/synapse/issues/8260)) - Simplify tests that mock asynchronous functions. ([\#8261](https://github.com/matrix-org/synapse/issues/8261)) - Add type hints to `StreamToken` and `RoomStreamToken` classes. ([\#8279](https://github.com/matrix-org/synapse/issues/8279)) - Change `StreamToken.room_key` to be a `RoomStreamToken` instance. ([\#8281](https://github.com/matrix-org/synapse/issues/8281)) - Refactor notifier code to correctly use the max event stream position. ([\#8288](https://github.com/matrix-org/synapse/issues/8288)) - Use slotted classes where possible. ([\#8296](https://github.com/matrix-org/synapse/issues/8296)) - Support testing the local Synapse checkout against the [Complement homeserver test suite](https://github.com/matrix-org/complement/). ([\#8317](https://github.com/matrix-org/synapse/issues/8317)) - Update outdated usages of `metaclass` to python 3 syntax. ([\#8326](https://github.com/matrix-org/synapse/issues/8326)) - Move lint-related dependencies to package-extra field, update CONTRIBUTING.md to utilise this. ([\#8330](https://github.com/matrix-org/synapse/issues/8330), [\#8377](https://github.com/matrix-org/synapse/issues/8377)) - Use the `admin_patterns` helper in additional locations. ([\#8331](https://github.com/matrix-org/synapse/issues/8331)) - Fix test logging to allow braces in log output. ([\#8335](https://github.com/matrix-org/synapse/issues/8335)) - Remove `__future__` imports related to Python 2 compatibility. ([\#8337](https://github.com/matrix-org/synapse/issues/8337)) - Simplify `super()` calls to Python 3 syntax. ([\#8344](https://github.com/matrix-org/synapse/issues/8344)) - Fix bad merge from `release-v1.20.0` branch to `develop`. ([\#8354](https://github.com/matrix-org/synapse/issues/8354)) - Factor out a `_send_dummy_event_for_room` method. ([\#8370](https://github.com/matrix-org/synapse/issues/8370)) - Improve logging of state resolution. ([\#8371](https://github.com/matrix-org/synapse/issues/8371)) - Add type annotations to `SimpleHttpClient`. ([\#8372](https://github.com/matrix-org/synapse/issues/8372)) - Refactor ID generators to use `async with` syntax. ([\#8383](https://github.com/matrix-org/synapse/issues/8383)) - Add `EventStreamPosition` type. ([\#8388](https://github.com/matrix-org/synapse/issues/8388)) - Create a mechanism for marking tests "logcontext clean". ([\#8399](https://github.com/matrix-org/synapse/issues/8399)) - A pair of tiny cleanups in the federation request code. ([\#8401](https://github.com/matrix-org/synapse/issues/8401)) - Add checks on startup that PostgreSQL sequences are consistent with their associated tables. ([\#8402](https://github.com/matrix-org/synapse/issues/8402)) - Do not include appservice users when calculating the total MAU for a server. ([\#8404](https://github.com/matrix-org/synapse/issues/8404)) - Typing fixes for `synapse.handlers.federation`. ([\#8422](https://github.com/matrix-org/synapse/issues/8422)) - Various refactors to simplify stream token handling. ([\#8423](https://github.com/matrix-org/synapse/issues/8423)) - Make stream token serializing/deserializing async. ([\#8427](https://github.com/matrix-org/synapse/issues/8427))
| * update changelog v1.21.0rc1Richard van der Hoff2020-10-012-2/+1
| |
| * fix a logging error in thumbnailer (#8435)Richard van der Hoff2020-10-012-1/+2
| | | | | | Introduced in #8236
| * changelog fixesRichard van der Hoff2020-10-011-2/+1
| |
| * fix version numberRichard van der Hoff2020-10-012-3/+3
| | | | | | | | we're not doing a final release yet!
| * 1.21.0Richard van der Hoff2020-10-0187-87/+103
| |
* | Enable mypy checking for unreachable code and fix instances. (#8432)Patrick Cloke2020-10-0117-53/+38
|/
* Add prometheus metrics to track federation delays (#8430)Richard van der Hoff2020-10-018-6/+88
| | | | | Add a pair of federation metrics to track the delays in sending PDUs to/from particular servers.
* Make token serializing/deserializing async (#8427)Erik Johnston2020-09-3017-59/+115
| | | The idea is that in future tokens will encode a mapping of instance to position. However, we don't want to include the full instance name in the string representation, so instead we'll have a mapping between instance name and an immutable integer ID in the DB that we can use instead. We'll then do the lookup when we serialize/deserialize the token (we could alternatively pass around an `Instance` type that includes both the name and ID, but that turns out to be a lot more invasive).
* Merge pull request #8425 from matrix-org/rav/extremity_metricsRichard van der Hoff2020-09-305-84/+144
|\ | | | | Add an improved "forward extremities" metric
| * changelogRichard van der Hoff2020-09-301-0/+1
| |
| * Add an improved "forward extremities" metricRichard van der Hoff2020-09-301-2/+25
| | | | | | | | | | Hopefully, N(extremities) * N(state_events) is a more realistic approximation to "how big a problem is this room?".
| * Rewrite BucketCollectorRichard van der Hoff2020-09-303-71/+89
| | | | | | | | | | | | | | | | | | | | | | | | This was a bit unweildy for what I wanted: in particular, I wanted to assign each measurement straight into a bucket, rather than storing an intermediate Counter which didn't do any bucketing at all. I've replaced it with something that is hopefully a bit easier to use. (I'm not entirely sure what the difference between a HistogramMetricFamily and a GaugeHistogramMetricFamily is, but given our counters can go down as well as up the latter *sounds* more accurate?)
| * Fix _exposition.py to stop stripping samplesRichard van der Hoff2020-09-301-11/+29
| | | | | | | | | | | | Our hacked-up `_exposition.py` was stripping out some samples it shouldn't have been. Put them back in, to more closely match the upstream `exposition.py`.
* | Allow additional SSO properties to be passed to the client (#8413)Patrick Cloke2020-09-309-67/+278
|/
* Drop support for ancient prometheus_client (#8426)Richard van der Hoff2020-09-303-23/+8
| | | | Drop compatibility hacks for prometheus-client pre 0.4.0. Debian stretch and Fedora 31 both have newer versions, so hopefully this will be ok.
* Merge pull request #8420 from matrix-org/rav/state_res_statsRichard van der Hoff2020-09-304-79/+199
|\ | | | | Report metrics on expensive rooms for state res
| * changelogRichard van der Hoff2020-09-291-0/+1
| |
| * Report state res metrics to Prometheus and logRichard van der Hoff2020-09-291-20/+124
| |
| * Move Measure calls into `resolve_events_with_store`Richard van der Hoff2020-09-291-32/+31
| |
| * Expose a `get_resource_usage` method in `Measure`Richard van der Hoff2020-09-291-10/+21
| |
| * Move `resolve_events_with_store` into StateResolutionHandlerRichard van der Hoff2020-09-292-50/+55
| |
* | Various clean ups to room stream tokens. (#8423)Erik Johnston2020-09-2916-76/+96
| |
* | Update description of server_name config option (#8415)Aaron Raimist2020-09-293-8/+35
|/
* Discard an empty upload_name before persisting an uploaded file (#7905)Will Hunt2020-09-293-3/+9
|
* Don't check whether a 3pid is allowed to register during password reset (#8414)Andrew Morgan2020-09-292-7/+1
|\ | | | | | | | | | | | | | | * Don't check whether a 3pid is allowed to register during password reset This endpoint should only deal with emails that have already been approved, and are attached with user's account. There's no need to re-check them here. * Changelog
| * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Andrew Morgan2020-09-2919-118/+404
| |\ | | | | | | | | | anoa/info-mainline-no-check-password-reset
| * | ChangelogAndrew Morgan2020-09-281-0/+1
| | |
| * | Don't check whether a 3pid is allowed to register during password resetAndrew Morgan2020-09-281-7/+0
| | | | | | | | | | | | | | | This endpoint should only deal with emails that have already been approved, and are attached with user's account. There's no need to re-check them here.
* | | Don't table scan events on worker startup (#8419)Erik Johnston2020-09-293-1/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix table scan of events on worker startup. This happened because we assumed "new" writers had an initial stream position of 0, so the replication code tried to fetch all events written by the instance between 0 and the current position. Instead, set the initial position of new writers to the current persisted up to position, on the assumption that new writers won't have written anything before that point. * Consider old writers coming back as "new". Otherwise we'd try and fetch entries between the old stale token and the current position, even though it won't have written any rows. Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | | Mypy fixes for `synapse.handlers.federation` (#8422)Richard van der Hoff2020-09-296-11/+19
| |/ |/| | | For some reason, an apparently unrelated PR upset mypy about this module. Here are a number of little fixes.
* | Add support for running Complement against the local checkout (#8317)Andrew Morgan2020-09-292-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | This PR adds a script that: * Builds the local Synapse checkout using our existing `docker/Dockerfile` image. * Downloads [Complement](https://github.com/matrix-org/complement/)'s source code. * Builds the [Synapse.Dockerfile](https://github.com/matrix-org/complement/blob/master/dockerfiles/Synapse.Dockerfile) using the above dockerfile as a base. * Builds and runs Complement against it. This set up differs slightly from [that of the dendrite repo](https://github.com/matrix-org/dendrite/blob/master/build/scripts/complement.sh) (`complement.sh`, `Complement.Dockerfile`), which instead stores a separate, but slightly modified, dockerfile in Dendrite's repo rather than running the one stored in Complement's repo. That synapse equivalent to that dockerfile (`Synapse.Dockerfile`) in Complement's repo is just based on top of `matrixdotorg/synapse:latest`, which we opt to build here locally. Thus copying over the files from Complement's repo wouldn't change any functionality, and would result in two instances of the same files. So just using the dockerfile in Complement's repo was decided upon instead.
* | Filter out appservices from mau count (#8404)Will Hunt2020-09-293-2/+25
| | | | | | This is an attempt to fix #8403.
* | Only assert valid next_link params when provided (#8417)Andrew Morgan2020-09-293-6/+16
| | | | | | | | | | | | | | Broken in https://github.com/matrix-org/synapse/pull/8275 and has yet to be put in a release. Fixes https://github.com/matrix-org/synapse/issues/8418. `next_link` is an optional parameter. However, we were checking whether the `next_link` param was valid, even if it wasn't provided. In that case, `next_link` was `None`, which would clearly not be a valid URL. This would prevent password reset and other operations if `next_link` was not provided, and the `next_link_domain_whitelist` config option was set.
* | Add metrics to track success/otherwise of replication requests (#8406)Richard van der Hoff2020-09-292-12/+29
| | | | | | One hope is that this might provide some insights into #3365.
* | Fix handling of connection timeouts in outgoing http requests (#8400)Richard van der Hoff2020-09-299-98/+311
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove `on_timeout_cancel` from `timeout_deferred` The `on_timeout_cancel` param to `timeout_deferred` wasn't always called on a timeout (in particular if the canceller raised an exception), so it was unreliable. It was also only used in one place, and to be honest it's easier to do what it does a different way. * Fix handling of connection timeouts in outgoing http requests Turns out that if we get a timeout during connection, then a different exception is raised, which wasn't always handled correctly. To fix it, catch the exception in SimpleHttpClient and turn it into a RequestTimedOutError (which is already a documented exception). Also add a description to RequestTimedOutError so that we can see which stage it failed at. * Fix incorrect handling of timeouts reading federation responses This was trapping the wrong sort of TimeoutError, so was never being hit. The effect was relatively minor, but we should fix this so that it does the expected thing. * Fix inconsistent handling of `timeout` param between methods `get_json`, `put_json` and `delete_json` were applying a different timeout to the response body to `post_json`; bring them in line and test. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>
* Add checks for postgres sequence consistency (#8402)Erik Johnston2020-09-288-6/+160
|
* Create a mechanism for marking tests "logcontext clean" (#8399)Richard van der Hoff2020-09-284-21/+41
|
* Add `ui_auth_sessions_ips` table to `synapse_port_db` ignore list (#8410)Dagfinn Ilmari Mannsåker2020-09-282-0/+2
| | | | | | This table was created in #8034 (1.20.0). It references `ui_auth_sessions`, which is ignored, so this one should be too. Signed-off-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
* A pair of tiny cleanups in the federation request code. (#8401)Richard van der Hoff2020-09-283-3/+2
|
* typoMatthew Hodgson2020-09-281-1/+1
|
* Escape the error description on the sso_error template. (#8405)Patrick Cloke2020-09-252-1/+2
|
* Fix occasional "Re-starting finished log context" from keyring (#8398)Richard van der Hoff2020-09-253-90/+101
| | | | | | | | | | | | | | | * Fix test_verify_json_objects_for_server_awaits_previous_requests It turns out that this wasn't really testing what it thought it was testing (in particular, `check_context` was turning failures into success, which was making the tests pass even though it wasn't clear they should have been. It was also somewhat overcomplex - we can test what it was trying to test without mocking out perspectives servers. * Fix warnings about finished logcontexts in the keyring We need to make sure that we finish the key fetching magic before we run the verifying code, to ensure that we don't mess up our logcontexts.
* Allow existing users to login via OpenID Connect. (#8345)Tdxdxoz2020-09-256-17/+76
| | | | | | | Co-authored-by: Benjamin Koch <bbbsnowball@gmail.com> This adds configuration flags that will match a user to pre-existing users when logging in via OpenID Connect. This is useful when switching to an existing SSO system.
* Fix schema delta for servers that have not backfilled (#8396)Erik Johnston2020-09-253-2/+9
| | | | | Fixes #8395.
* Merge branch 'master' into developAndrew Morgan2020-09-244-3/+25
|\
| * s/URLs/variables in changelog v1.20.1 github/release-v1.20.1 release-v1.20.1Andrew Morgan2020-09-241-1/+1
| |
| * s/accidentally/incorrectly in changelogAndrew Morgan2020-09-241-1/+1
| |
| * Update changelog wordingAndrew Morgan2020-09-241-1/+1
| |
| * 1.20.1Andrew Morgan2020-09-245-3/+17
| |
| * Mark the shadow_banned column as boolean in synapse_port_db. (#8386)Patrick Cloke2020-09-243-0/+2
| |
| * Hotfix: disable autoescape by default when rendering Jinja2 templates (#8394)Andrew Morgan2020-09-243-3/+12
| | | | | | | | | | #8037 changed the default `autoescape` option when rendering Jinja2 templates from `False` to `True`. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users. This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.
* | Fix MultiWriteIdGenerator's handling of restarts. (#8374)Erik Johnston2020-09-247-30/+274
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On startup `MultiWriteIdGenerator` fetches the maximum stream ID for each instance from the table and uses that as its initial "current position" for each writer. This is problematic as a) it involves either a scan of events table or an index (neither of which is ideal), and b) if rows are being persisted out of order elsewhere while the process restarts then using the maximum stream ID is not correct. This could theoretically lead to race conditions where e.g. events that are persisted out of order are not sent down sync streams. We fix this by creating a new table that tracks the current positions of each writer to the stream, and update it each time we finish persisting a new entry. This is a relatively small overhead when persisting events. However for the cache invalidation stream this is a much bigger relative overhead, so instead we note that for invalidation we don't actually care about reliability over restarts (as there's no caches to invalidate) and simply don't bother reading and writing to the new table in that particular case.
* | Add type annotations to SimpleHttpClient (#8372)Richard van der Hoff2020-09-244-61/+143
| |
* | Add new sequences to port DB script (#8387)Erik Johnston2020-09-242-0/+25
| |
* | Add EventStreamPosition type (#8388)Erik Johnston2020-09-2411-57/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea is to remove some of the places we pass around `int`, where it can represent one of two things: 1. the position of an event in the stream; or 2. a token that partitions the stream, used as part of the stream tokens. The valid operations are then: 1. did a position happen before or after a token; 2. get all events that happened before or after a token; and 3. get all events between two tokens. (Note that we don't want to allow other operations as we want to change the tokens to be vector clocks rather than simple ints)
* | Mark the shadow_banned column as boolean in synapse_port_db. (#8386)Patrick Cloke2020-09-243-0/+2
| |
* | Factor out `_send_dummy_event_for_room` (#8370)Richard van der Hoff2020-09-232-48/+55
| | | | | | this makes it possible to use from the manhole, and seems cleaner anyway.
* | Improve logging of state resolution (#8371)Richard van der Hoff2020-09-232-48/+17
| | | | | | | | | | | | | | | | | | | | I'd like to get a better insight into what we are doing with respect to state res. The list of state groups we are resolving across should be short (if it isn't, that's a massive problem in itself), so it should be fine to log it in ite entiretly. I've done some grepping and found approximately zero cases in which the "shortcut" code delivered the result, so I've ripped that out too.
* | Fix bug which caused failure on join with malformed membership events (#8385)Richard van der Hoff2020-09-232-3/+8
| |
* | Use `async with` for ID gens (#8383)Erik Johnston2020-09-2315-105/+144
| | | | | | This will allow us to hit the DB after we've finished using the generated stream ID.
* | Don't push if an user account has expired (#8353)Mathieu Velten2020-09-234-5/+34
| |
* | Fix missing null character check on guest_access room state (#8373)Andrew Morgan2020-09-232-0/+3
|\ \ | | | | | | | | | | | | | | | | | | When updating the `room_stats_state` table, we try to check for null bytes slipping in to the content for state events. It turns out we had added `guest_access` as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a `m.room.guest_access` event then breaks `room_stats_state` updates. This PR adds the check for `guest_access`.
| * | ChangelogAndrew Morgan2020-09-221-0/+1
| | |
| * | Fix missing null character check on guest_access room stateAndrew Morgan2020-09-221-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When updating room_stats_state, we try to check for null bytes slipping in to the content for state events. It turns out we had added guest_access as a field to room_stats_state without including it in the null byte check. Lo and behold, a null byte in a m.room.guest_access event then breaks room_stats_state updates. This PR adds the check for guest_access. A further PR will improve this function so that this hopefully does not happen again in future.
* | | Do not check lint/test dependencies at runtime. (#8377)Patrick Cloke2020-09-235-15/+25
| | | | | | | | | moves non-runtime dependencies out of synapse.python_dependencies (test and lint)
* | | Add note to reverse_proxy.md about disabling Apache's mod_security2 (#8375)Julian Fietkau2020-09-232-0/+9
|/ / | | | | This change adds a note and a few lines of configuration settings for Apache users to disable ModSecurity for Synapse's virtual hosts. With ModSecurity enabled and running with its default settings, Matrix clients are unable to send chat messages through the Synapse installation. With this change, ModSecurity can be disabled only for the Synapse virtual hosts.
* | Fixed a bug with reactivating users with the admin API (#8362)Dirk Klimpel2020-09-223-1/+16
| | | | | | | | | | | | | | Fixes: #8359 Trying to reactivate a user with the admin API (`PUT /_synapse/admin/v2/users/<user_name>`) causes an internal server error. Seems to be a regression in #8033.
* | Admin API for reported events (#8217)Dirk Klimpel2020-09-226-0/+697
| | | | | | Add an admin API to read entries of table `event_reports`. API: `GET /_synapse/admin/v1/event_reports`
* | Merge branch 'master' into developAndrew Morgan2020-09-223-3/+24
|\|
| * Fix wording of deprecation notice in changelog v1.20.0 github/release-v1.20.0 release-v1.20.0Andrew Morgan2020-09-221-5/+4
| |
| * Deprecation warning for synapse admin api being accessible under /_matrixAndrew Morgan2020-09-221-1/+13
| |
| * 1.20.0Andrew Morgan2020-09-223-3/+13
| |
* | Create function to check for long names in devices (#8364)Dionysis Grigoropoulos2020-09-224-7/+38
| | | | | | | | | | | | | | | | | | * Create a new function to verify that the length of a device name is under a certain threshold. * Refactor old code and tests to use said function. * Verify device name length during registration of device * Add a test for the above Signed-off-by: Dionysis Grigoropoulos <dgrig@erethon.com>
* | Add a comment re #1691Richard van der Hoff2020-09-211-1/+5
| |
* | Fix a bad merge from release-v1.20.0. (#8354)Patrick Cloke2020-09-182-1/+2
| |
* | Merge tag 'v1.20.0rc5' into developPatrick Cloke2020-09-1810-28/+128
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc5 (2020-09-18) ============================== In addition to the below, Synapse 1.20.0rc5 also includes the bug fix that was included in 1.19.3. Features -------- - Add flags to the `/versions` endpoint for whether new rooms default to using E2EE. ([\#8343](https://github.com/matrix-org/synapse/issues/8343)) Bugfixes -------- - Fix rate limiting of federation `/send` requests. ([\#8342](https://github.com/matrix-org/synapse/issues/8342)) - Fix a longstanding bug where back pagination over federation could get stuck if it failed to handle a received event. ([\#8349](https://github.com/matrix-org/synapse/issues/8349)) Internal Changes ---------------- - Blacklist [MSC2753](https://github.com/matrix-org/matrix-doc/pull/2753) SyTests until it is implemented. ([\#8285](https://github.com/matrix-org/synapse/issues/8285))
| * Add a note about including the changes from 1.19.3. v1.20.0rc5Patrick Cloke2020-09-181-0/+2
| |
| * Tweak wording in the changelog.Patrick Cloke2020-09-181-2/+2
| |
| * 1.20.0rc5Patrick Cloke2020-09-186-5/+23
| |
| * Merge tag 'v1.19.3' into release-v1.20.0Patrick Cloke2020-09-183-5/+18
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.19.3 Synapse 1.19.3 (2020-09-18) =========================== Bugfixes -------- - Partially mitigate bug where newly joined servers couldn't get past events in a room when there is a malformed event. ([\#8350](https://github.com/matrix-org/synapse/issues/8350))
| | * 1.19.3 v1.19.3 github/release-v1.19.3 release-v1.19.3Andrew Morgan2020-09-184-2/+16
| | |
| | * Use _check_sigs_and_hash_and_fetch to validate backfill requests (#8350)Andrew Morgan2020-09-182-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a bit of a hack, as `_check_sigs_and_hash_and_fetch` is intended for attempting to pull an event from the database/(re)pull it from the server that originally sent the event if checking the signature of the event fails. During backfill we *know* that we won't have the event in our database, however it is still useful to be able to query the original sending server as the server we're backfilling from may be acting maliciously. The main benefit and reason for this change however is that `_check_sigs_and_hash_and_fetch` will drop an event during backfill if it cannot be successfully validated, whereas the current code will simply fail the backfill request - resulting in the client's /messages request silently being dropped. This is a quick patch to fix backfilling rooms that contain malformed events. A better implementation in planned in future.
| * | Intelligently select extremities used in backfill. (#8349)Erik Johnston2020-09-184-20/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of just using the most recent extremities let's pick the ones that will give us results that the pagination request cares about, i.e. pick extremities only if they have a smaller depth than the pagination token. This is useful when we fail to backfill an extremity, as we no longer get stuck requesting that same extremity repeatedly.
| * | Add flags to /versions about whether new rooms are encrypted by default. (#8343)Patrick Cloke2020-09-182-0/+20
| | |
* | | Admin API for querying rooms where a user is a member (#8306)Dirk Klimpel2020-09-185-2/+160
| | | | | | | | | | | | Add a new admin API `GET /_synapse/admin/v1/users/<user_id>/joined_rooms` to list all rooms where a user is a member.
* | | Catch-up after Federation Outage (bonus): Catch-up on Synapse Startup (#8322)reivilibre2020-09-1810-5/+218
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Fix _set_destination_retry_timings This came about because the code assumed that retry_interval could not be NULL — which has been challenged by catch-up.
* | | Simplify super() calls to Python 3 syntax. (#8344)Patrick Cloke2020-09-18133-281/+272
| | | | | | | | | | | | | | | | | | | | | This converts calls like super(Foo, self) -> super(). Generated with: sed -i "" -Ee 's/super\([^\(]+\)/super()/g' **/*.py
* | | Allow appservice users to /login (#8320)Will Hunt2020-09-183-11/+173
| | | | | | | | | | | | | | | Add ability for ASes to /login using the `uk.half-shot.msc2778.login.application_service` login `type`. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Update test logging to be able to accept braces (#8335)Jonathan de Jong2020-09-182-2/+2
| | |
* | | Merge remote-tracking branch 'origin/release-v1.20.0' into developErik Johnston2020-09-184-17/+54
|\| |
| * | Fix ratelimiting for federation `/send` requests. (#8342)Erik Johnston2020-09-184-17/+54
| | | | | | | | | c.f. #8295 for rationale
| * | blacklist MSC2753 sytests until it's implemented in synapse (#8285)Matthew Hodgson2020-09-172-0/+9
| | | | | | | | | Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.
* | | Move lint dependencies to extras_require (#8330)Jonathan de Jong2020-09-174-12/+10
| | | | | | | | | | | | | | | Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.
* | | Remove obsolete __future__ imports (#8337)Jonathan de Jong2020-09-1719-40/+2
| | |
* | | Use admin_patterns for all admin APIs. (#8331)Patrick Cloke2020-09-177-26/+20
| | | | | | | | | This reduces duplication of the admin prefix in regular expressions.
* | | Fix a potential bug of UnboundLocalError (#8329)Jonathan de Jong2020-09-172-5/+9
| | | | | | | | | Replaced with less buggier control flow
* | | Switch metaclass initialization to python 3-compatible syntax (#8326)Jonathan de Jong2020-09-168-26/+16
| | |
* | | Merge tag 'v1.20.0rc4' into developPatrick Cloke2020-09-163-2/+25
|\| | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc4 (2020-09-16) ============================== Synapse 1.20.0rc4 is identical to 1.20.0rc3, with the addition of the security fix that was included in 1.19.2.
| * | 1.20.0rc4 v1.20.0rc4Patrick Cloke2020-09-162-1/+8
| | |
| * | Merge remote-tracking branch 'origin/master' into release-v1.20.0Patrick Cloke2020-09-163-2/+17
| |\|
| * | Merge branch 'erikj/fix_origin_check' into release-v1.20.0Erik Johnston2020-09-162-3/+5
| |\ \
* | \ \ Merge branch 'master' into developErik Johnston2020-09-160-0/+0
|\ \ \ \ | | |_|/ | |/| |
| * | | 1.19.2 v1.19.2 github/release-v1.19.2 release-v1.19.2Erik Johnston2020-09-164-2/+18
| | | |
| * | | Merge branch 'erikj/fix_origin_check' into release-v1.19.2Erik Johnston2020-09-162-3/+5
| |\ \ \ | | | |/ | | |/|
* | | | Merge branch 'erikj/fix_origin_check' into developErik Johnston2020-09-162-3/+5
|\ \ \ \ | | |/ / | |/| |
| * | | NewsfileErik Johnston2020-09-161-0/+1
| | | |
| * | | Don't assume that an event has an origin fieldErik Johnston2020-09-161-3/+4
| |/ / | | | | | | | | | This fixes #8319.
* | | Catch-up after Federation Outage (split, 4): catch-up loop (#8272)reivilibre2020-09-155-5/+338
| | |
* | | Use slots in attrs classes where possible (#8296)Patrick Cloke2020-09-1422-50/+33
| | | | | | | | | | | | | | | slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.
* | | Fix typos in comments.Patrick Cloke2020-09-145-6/+6
| | |
* | | Add the topic and avatar to the room details admin API (#8305)Tulir Asokan2020-09-144-1/+9
| | |
* | | Improve SAML error messages (#8248)Patrick Cloke2020-09-149-185/+178
| | |
* | | Add experimental support for sharding event persister. Again. (#8294)Erik Johnston2020-09-1418-80/+211
| | | | | | | | | | | | | | | | | | This is *not* ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.
* | | Merge tag 'v1.20.0rc3' into developPatrick Cloke2020-09-119-17/+176
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Synapse 1.20.0rc3 (2020-09-11) ============================== Bugfixes -------- - Fix a bug introduced in v1.20.0rc1 where the wrong exception was raised when invalid JSON data is encountered. ([\#8291](https://github.com/matrix-org/synapse/issues/8291))
| * | Clarify changelog. v1.20.0rc3Patrick Cloke2020-09-111-1/+1
| | |
| * | 1.20.0rc3Patrick Cloke2020-09-113-2/+10
| | |
| * | Fix the exception that is raised when invalid JSON is encountered. (#8291)Patrick Cloke2020-09-106-2/+167
| | |
| * | Remove shared rooms info from upgrade/workers doc as it's still experimental ↵Andrew Morgan2020-09-102-14/+0
| | | | | | | | | | | | (#8290)
* | | Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281)Erik Johnston2020-09-1116-99/+114
| | |
* | | Use TLSv1.2 for fake servers in tests (#8208)Dan Callaghan2020-09-102-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some Linux distros have begun disabling TLSv1.0 and TLSv1.1 by default for security reasons, for example in Fedora 33 onwards: https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2 Use TLSv1.2 for the fake TLS servers created in the test suite, to avoid failures due to OpenSSL disallowing TLSv1.0: <twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines', 'ssl_choose_client_version', 'unsupported protocol')]> Signed-off-by: Dan Callaghan <djc@djc.id.au>
* | | Add /_synapse/client to the reverse proxy docs (#8227)Andrew Morgan2020-09-104-3/+39
| | | | | | | | | This PR adds a information about forwarding `/_synapse/client` endpoints through your reverse proxy. The first of these endpoints are introduced in https://github.com/matrix-org/synapse/pull/8004.
* | | Clean up `Notifier.on_new_room_event` code path (#8288)Erik Johnston2020-09-106-37/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out *when* the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A *or* before B, then P is before C. Future PR will change the token type to a dedicated type.
* | | Show a confirmation page during user password reset (#8004)Andrew Morgan2020-09-1016-90/+271
| | | | | | | | | | | | | | | This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset. This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.
* | | Merge branch 'release-v1.20.0' into developRichard van der Hoff2020-09-103-3/+13
|\| |
| * | 1.20.0rc2 v1.20.0rc2Richard van der Hoff2020-09-093-2/+10
| | |
| * | Fix /notifications and pushers misbehaving because of unread counts (#8280)Brendan Abolivier2020-09-082-2/+4
| | |
* | | Do not error when thumbnailing invalid files (#8236)Patrick Cloke2020-09-095-22/+106
| | | | | | | | | | | | If a file cannot be thumbnailed for some reason (e.g. the file is empty), then catch the exception and convert it to a reasonable error message for the client.
* | | Remove some unused distributor signals (#8216)Patrick Cloke2020-09-097-141/+18
| | | | | | | | | | | | | | | Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.
* | | Fixup pusher pool notifications (#8287)Erik Johnston2020-09-098-8/+24
| | | | | | | | | | | | | | | `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.
* | | Revert "Fixup pusher pool notifications"Erik Johnston2020-09-097-23/+8
| | | | | | | | | | | | This reverts commit e7fd336a53a4ca489cdafc389b494d5477019dc0.
* | | Fixup pusher pool notificationsErik Johnston2020-09-097-8/+23
| | |
* | | blacklist MSC2753 sytests until it's implemented in synapse (#8285)Matthew Hodgson2020-09-092-0/+9
| | | | | | | | | Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.
* | | Don't remember `enabled` of deleted push rules and properly return 404 for ↵reivilibre2020-09-095-13/+610
| | | | | | | | | | | | | | | | | | | | | missing push rules in `.../actions` and `.../enabled` (#7796) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | | Add types to async_helpers (#8260)Patrick Cloke2020-09-083-51/+88
| | |
* | | Fix mypy error on develop (#8282)Erik Johnston2020-09-082-3/+7
| | |
* | | Include method in thumbnail media name (#7124)DeepBlueV7.X2020-09-086-1/+181
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | | Add types to StreamToken and RoomStreamToken (#8279)Erik Johnston2020-09-085-91/+95
| | | | | | | | | The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.
* | | Add a config option for validating 'next_link' parameters against a domain ↵Andrew Morgan2020-09-085-17/+204
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | whitelist (#8275) This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285 They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality. This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint. This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.