summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Stop reading from `event_reference_hashes` (#11794)Richard van der Hoff2022-01-215-33/+31
| | | | Preparation for dropping this table altogether. Part of #6574.
* Add `FrozenEvent.get_state_key` and use it in a couple of places (#11793)Richard van der Hoff2022-01-213-5/+11
| | | | This is more efficient, since we only have to look up `state_key` in the event dict once, rather than three (!) times.
* Make the `get_global_account_data_by_type_for_user` cache be a tree-cache ↵reivilibre2022-01-216-9/+10
| | | | whose key is prefixed with the user ID (#11788)
* Make `get_account_data_for_room_and_type` a tree cache (#11789)reivilibre2022-01-212-1/+2
|
* Correctly await on_logged_out callbacks (#11786)Brendan Abolivier2022-01-203-2/+29
|
* Fix redirecting to the webclient for non-HTTP(S) web_client_location. (#11783)Patrick Cloke2022-01-202-1/+9
| | | | | To not change the behaviour during the deprecation period. Follow-up to #11774.
* Add a regression test for using both webclient and client resources ↵Andrew Morgan2022-01-202-0/+109
| | | | simultaneously (#11765)
* Partially revert #11675; prevent attempting to create pushers on workers ↵Andrew Morgan2022-01-202-7/+6
| | | | (#11770)
* installation.md: drop python 3.6 support (#11781)Richard van der Hoff2022-01-202-1/+2
| | | #11595 dropped support for python 3.6, but forgot to update this doc.
* Add deprecation warnings for `webclient` listener and non-HTTP(S) ↵Patrick Cloke2022-01-205-28/+40
| | | | | | | `web_client_location`. (#11774) This changes the behaviour of the root endpoint to redirect directly to the configuration of `web_client_location` if it is given an HTTP(S) URL.
* Debug for device lists updates (#11760)David Robertson2022-01-204-0/+46
| | | | | | | | | | | | | | | | | | Debug for #8631. I'm having a hard time tracking down what's going wrong in that issue. In the reported example, I could see server A sending federation traffic to server B and all was well. Yet B reports out-of-sync device updates from A. I couldn't see what was _in_ the events being sent from A to B. So I have added some crude logging to track - when we have updates to send to a remote HS - the edus we actually accumulate to send - when a federation transaction includes a device list update edu - when such an EDU is received This is a bit of a sledgehammer.
* Allow overriding the complement ref. (#11766)Nicolas Werner2022-01-203-7/+10
| | | | | Updates complement.sh to read the ref from an environment variable (defaulting to master) when downloading a complement bundle for testing.
* Fix a bug that corrupted the cache of federated space hierarchies (#11775)Sean Quah2022-01-204-12/+102
| | | | `FederationClient.get_room_hierarchy()` caches its return values, so refactor the code to avoid modifying the returned room summary.
* Comments and typing for `_update_outliers_txn` (#11776)Richard van der Hoff2022-01-192-12/+24
| | | | A couple of surprises for me here, so thought I'd document them
* Fix mypy for platforms without epoll support. (#11771)Patrick Cloke2022-01-192-2/+3
|
* Add missing `auto_attribs=True` to the `_WrappedRustReporter` class (#11768)Andrew Morgan2022-01-192-1/+2
|
* Fix preview of imgur and Tenor URLs. (#11669)Philippe Daouadi2022-01-184-14/+39
| | | | | | By scraping Open Graph information from the HTML even when an autodiscovery endpoint is found. The results are then combined to capture as much information as possible from the page.
* Merge branch 'master' into developAndrew Morgan2022-01-184-3/+29
|\
| * Wording fixes to 1.50.0/1 changelog entries v1.50.1Andrew Morgan2022-01-181-3/+3
| |
| * Reword 1.50.0 warning a bit in the changelogAndrew Morgan2022-01-181-1/+3
| |
| * 1.50.1Andrew Morgan2022-01-184-2/+20
| |
| * Partially revert #11602 to prevent webclient overriding client resource (#11764)Andrew Morgan2022-01-182-2/+8
| |
* | Include whether the requesting user has participated in a thread. (#11577)Patrick Cloke2022-01-189-18/+85
| | | | | | | | | | | | Per updates to MSC3440. This is implement as a separate method since it needs to be cached on a per-user basis, instead of a per-thread basis.
* | Remove `log_function` and its uses (#11761)Richard van der Hoff2022-01-1813-155/+1
| | | | | | | | | | | | | | I've never found this terribly useful. I think it was added in the early days of Synapse, without much thought as to what would actually be useful to log, and has just been cargo-culted ever since. Rather, it tends to clutter up debug logs with useless information.
* | Merge branch 'master' into developAndrew Morgan2022-01-183-4/+15
|\|
| * Move python/postgres deprecation notice to the top of 1.50 changelog v1.50.0Andrew Morgan2022-01-181-2/+2
| |
| * 1.50.0Andrew Morgan2022-01-183-4/+15
| |
* | Add a flag to the `synapse_review_recent_signups` script to ignore and ↵lukasdenk2022-01-173-8/+23
| | | | | | | | filter appservice users. (#11675)
* | Warn against using Let's Encrypt certs for encrypted TURN (#11686)AndrewFerr2022-01-172-0/+17
| | | | | | | | | | | | | | | | | | * Warn against using Let's Encrypt certs for encrypted TURN This helps to avoid client-side issues: * https://github.com/vector-im/element-android/issues/1533 * https://github.com/vector-im/element-ios/issues/2712 Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>
* | Fix up docs for `track_puppeted_user_ips` (again) (#11757)Richard van der Hoff2022-01-175-10/+27
| | | | | | Fixes #11741
* | Update documentation for configuring facebook login (#11755)Richard van der Hoff2022-01-174-18/+26
| | | | | | ... and a minor thinko fix in the sample config.
* | Improve `reactor_tick_time` metric (#11724)Richard van der Hoff2022-01-175-109/+86
| | | | | | | | | | | | | | | | | | | | | | The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it *only* measures the time taken to execute timed calls and callbacks from threads. That neglects everything that happens off the back of I/O, which is obviously quite a lot for us. To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is the only place it should wait for something to happen - the rest of the loop *should* be quick. I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and it's a nuisance to populate.
* | Make pagination of rooms in admin api stable (#11737)Daniel Sonck2022-01-173-28/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Always add state.room_id after the configurable ORDER BY. Otherwise, for any sort, certain pages can contain results from other pages. (Especially when sorting by creator, since there may be many rooms by the same creator) * Document different order direction of numerical fields "joined_members", "joined_local_members", "version" and "state_events" are ordered in descending direction by default (dir=f). Added a note in tests to explain the differences in ordering. Signed-off-by: Daniël Sonck <daniel@sonck.nl>
* | Merge branch 'release-v1.50' into developOlivier Wilkinson (reivilibre)2022-01-145-20/+277
|\|
| * Tweak the changelog summary section v1.50.0rc2Olivier Wilkinson (reivilibre)2022-01-141-4/+3
| |
| * 1.50.0rc2Olivier Wilkinson (reivilibre)2022-01-147-5/+33
| |
| * Fix a bug introduced in Synapse v1.50.0rc1 whereby outbound federation could ↵reivilibre2022-01-133-17/+190
| | | | | | | | | | fail because too many EDUs were produced for device updates. (#11730) Co-authored-by: David Robertson <davidr@element.io>
| * Fix a bug introduced in Synapse v1.0.0 whereby device list updates would not ↵reivilibre2022-01-123-2/+57
| | | | | | | | | | be sent to remote homeservers if there were too many to send at once. (#11729) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| * Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714)David Robertson2022-01-122-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16
| * Fix documentation of supported PostgreSQL version (#11725)haslersn2022-01-122-1/+2
| | | | | | Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
* | Remove the 'password_hash' from the Users Admin API endpoint response ↵Andrew Morgan2022-01-145-43/+86
| | | | | | | | dictionary (#11576)
* | Fix sample_config.yaml in regards track_puppeted_user_ips (#11749)Jason Robinson2022-01-143-10/+13
| | | | | | | | | | | | | | * Fix sample_config.yaml in regards track_puppeted_user_ips Closes #11741 Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | Replace uses of simple_insert_many with simple_insert_many_values. (#11742)Patrick Cloke2022-01-1319-298/+263
| | | | | | | | This should be (slightly) more efficient and it is simpler to have a single method for inserting multiple values.
* | Fix missing app variable in mail subject (#11745)David Robertson2022-01-133-2/+4
| | | | | | | | | | documentation claims that you can use the %(app)s variable in password_reset and email_validation subjects, but if you do you end up with an error 500 Co-authored-by: br4nnigan <10244835+br4nnigan@users.noreply.github.com>
* | Invite PR submitters to credit themselves (#11744)David Robertson2022-01-132-0/+2
| | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | update room spec url in config files (#11739)qwertyforce2022-01-133-2/+3
| | | | | | | | | | | | | | * change spec url in config files * Create 11739.txt * .txt -> .doc
* | Mention python3-venv and libpq-dev dependencies in contribution guide (#11740)Andy Balaam2022-01-132-1/+4
| |
* | Include bundled aggregations in the sync response cache. (#11659)Patrick Cloke2022-01-134-19/+19
| |
* | Simplify GC prometheus metrics (#11723)Richard van der Hoff2022-01-134-160/+209
| | | | | | | | | | Rather than hooking into the reactor loop, just add a timed task that runs every 100 ms to do the garbage collection. Part 1 of a quest to simplify the reactor monkey-patching.
* | Use auto_attribs/native type hints for attrs classes. (#11692)Patrick Cloke2022-01-1340-307/+300
| |
* | Fix typo in demo docs: differnt (#11735)Andy Balaam2022-01-132-1/+2
| |
* | Allow tracking puppeted users for MAU (#11561)Jason Robinson2022-01-125-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently when puppeting another user, the user doing the puppeting is tracked for client IPs and MAU (if configured). When tracking MAU is important, it becomes necessary to be possible to also track the client IPs and MAU of puppeted users. As an example a client that manages user creation and creation of tokens via the Synapse admin API, passing those tokens for the client to use. This PR adds optional configuration to enable tracking of puppeted users into monthly active users. The default behaviour stays the same. Signed-off-by: Jason Robinson <jasonr@matrix.org>
* | Fix documentation of supported PostgreSQL version (#11725)haslersn2022-01-122-1/+2
| | | | | | Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
* | Use buildkit's cache feature to speed up docker builds (#11691)Richard van der Hoff2022-01-124-5/+28
| | | | | | Having spent much of the last week attempting to run complement tests from somewhere with damp string instead of internet... something had to be done.
* | Complement environment variable name change and update .gitignore. (#11718)Michael Kaye2022-01-103-1/+6
| |
* | Document the `SYNAPSE_TEST_PERSIST_SQLITE_DB` unit test env var (#11715)Andrew Morgan2022-01-102-0/+22
| |
* | Fix docstring on `add_account_data_for_user`. (#11716)reivilibre2022-01-103-2/+3
| |
* | Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714)David Robertson2022-01-102-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16
* | Prettier complement logs (#11707)kegsay2022-01-102-1/+3
| | | | | | | | | | * Prettier complement logs * Changelog
* | Support spaces with > 50 rooms in the /hierarchy endpoint. (#11695)Patrick Cloke2022-01-073-8/+55
| | | | | | | | | | | | | | By returning all of the m.space.child state of the space, not just the first 50. The number of rooms returned is still capped at 50. For the federation API this implies that the requesting server will need to individually query for any other rooms it is not joined to.
* | Optionally use an on-disk sqlite db in tests (#11702)David Robertson2022-01-073-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Optionally use an on-disk sqlite db in tests When debugging a test it is sometimes useful to inspect the state of the DB. This is not easy when the db is in-memory: one cannot attach the sqlite CLI to another process's DB. With this change, if SYNAPSE_TEST_PERSIST_SQLITE_DB is set, we use `_trial_temp/test.db` as our sqlite database. One can then use `sqlite3 _trial_temp/test.db` and query to your heart's content. The DB is destroyed and recreated between different test cases. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Test that bans win a join against a race when computing `/sync` response ↵David Robertson2022-01-073-3/+105
| | | | | | | | (#11701)
* | Merge branch 'release-v1.50' into developOlivier Wilkinson (reivilibre)2022-01-0778-73/+117
|\|
| * Move changelog entry for drop of support to 'Deprecations and Removals'Olivier Wilkinson (reivilibre)2022-01-071-1/+1
| |
| * Re-run Towncrier to add in the changelog entry for the Mjolnir workaround v1.50.0rc1Olivier Wilkinson (reivilibre)2022-01-062-1/+1
| |
| * Work around Mjolnir compatibility issue by adding an import for ↵reivilibre2022-01-062-0/+8
| | | | | | | | `glob_to_regex` in `synapse.util`, where it moved from. (#11696)
| * Tweak changelog for #11677Olivier Wilkinson (reivilibre)2022-01-051-1/+1
| |
| * Re-run towncrier.Patrick Cloke2022-01-052-1/+1
| |
| * Include `io.element.thread` capability for MSC3440. (#11690)Patrick Cloke2022-01-052-0/+4
| |
| * Mention drop of support in changelogOlivier Wilkinson (reivilibre)2022-01-051-0/+3
| |
| * Add support removal notice to the upgrade notesOlivier Wilkinson (reivilibre)2022-01-051-0/+11
| |
| * Tweak changelogOlivier Wilkinson (reivilibre)2022-01-051-9/+8
| |
| * 1.50.0rc1Olivier Wilkinson (reivilibre)2022-01-0575-73/+92
| |
* | Bundle aggregations outside of the serialization method. (#11612)Patrick Cloke2022-01-0717-156/+249
| | | | | | | | | | | | | | | | This makes the serialization of events synchronous (and it no longer access the database), but we must manually calculate and provide the bundled aggregations. Overall this should cause no change in behavior, but is prep work for other improvements.
* | Remove the /send_relation endpoint. (#11682)Patrick Cloke2022-01-063-133/+19
| | | | | | | | This was removed from MSC2674 before that was approved and is not used by any known clients.
* | Remove a Python 2-ism and improve type hints. (#11699)Patrick Cloke2022-01-062-12/+8
| | | | | | | | On Python 2, indexing a byte-string gives back a byte-string, while on Python 3 it gives back the ASCII equivalent as an int.
* | Strip unauthorized fields from `unsigned` object in events received over ↵Shay2022-01-063-0/+99
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | federation (#11530) * add some tests to verify we are stripping unauthorized fields out of unsigned * add function to strip unauthorized fields from the unsigned object of event * newsfragment * update newsfragment number * add check to on_send_membership_event * refactor tests * fix lint error * slightly refactor tests and add some comments * slight refactor * refactor tests * fix import error * slight refactor * remove unsigned filtration code from synapse/handlers/federation_event.py * lint * move unsigned filtering code to event base * refactor tests * update newsfragment * requested changes * remove unused retun values
* | Make room creations denied by `user_may_create_room` cause an `M_FORBIDDEN` ↵lukasdenk2022-01-062-2/+7
| | | | | | | | | | error to be returned, not `M_UNKNOWN` (#11672) Co-authored-by: reivilibre <olivier@librepush.net>
* | Remove debug logging for #4422 (#11693)David Robertson2022-01-062-37/+2
| | | | | | | | as per https://github.com/matrix-org/synapse/pull/11532#discussion_r769123269
* | Fix space hierarchy endpoint to match MSC2946 (#11667)Travis Ralston2022-01-052-2/+5
| | | | | | | | | | | | | | Fixes minor discrepancies between the /hierarchy endpoint described in MSC2946 and the implementation. Note that the changes impact the stable and unstable /hierarchy and unstable /spaces endpoints for both client and federation APIs.
* | Fix get federation status of destination if no error occured (#11593)Dirk Klimpel2022-01-054-25/+88
| |
* | Run `pyupgrade --py37-plus --keep-percent-format` on Synapse (#11685)Shay2022-01-053-2/+2
| | | | | | | | | | | | | | | | | | * newsfragment * fix newsfragment number * update changelog * remove extra space
* | Cache empty responses from `/user/devices` (#11587)David Robertson2022-01-055-5/+114
|/ | | If we've never made a request to a remote homeserver, we should cache the response---even if the response is "this user has no devices".
* Refactor the way we set `outlier` (#11634)Richard van der Hoff2022-01-055-47/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `_auth_and_persist_outliers`: mark persisted events as outliers Mark any events that get persisted via `_auth_and_persist_outliers` as, well, outliers. Currently this will be a no-op as everything will already be flagged as an outlier, but I'm going to change that. * `process_remote_join`: stop flagging as outlier The events are now flagged as outliers later on, by `_auth_and_persist_outliers`. * `send_join`: remove `outlier=True` The events created here are returned in the result of `send_join` to `FederationHandler.do_invite_join`. From there they are passed into `FederationEventHandler.process_remote_join`, which passes them to `_auth_and_persist_outliers`... which sets the `outlier` flag. * `get_event_auth`: remove `outlier=True` stop flagging the events returned by `get_event_auth` as outliers. This method is only called by `_get_remote_auth_chain_for_event`, which passes the results into `_auth_and_persist_outliers`, which will flag them as outliers. * `_get_remote_auth_chain_for_event`: remove `outlier=True` we pass all the events into `_auth_and_persist_outliers`, which will now flag the events as outliers. * `_check_sigs_and_hash_and_fetch`: remove unused `outlier` parameter This param is now never set to True, so we can remove it. * `_check_sigs_and_hash_and_fetch_one`: remove unused `outlier` param This is no longer set anywhere, so we can remove it. * `get_pdu`: remove unused `outlier` parameter ... and chase it down into `get_pdu_from_destination_raw`. * `event_from_pdu_json`: remove redundant `outlier` param This is never set to `True`, so can be removed. * changelog * update docstring
* Fix link from generated configuration file to documentation (#11678)Philipp Matthias Schäfer2022-01-053-2/+3
| | | | Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: reivilibre <oliverw@matrix.org>
* Fix SimpleHttpClient not sending Accept header in `get_json` (#11677)Fr3shTea2022-01-052-1/+2
| | | Co-authored-by: reivilibre <olivier@librepush.net>
* Add admin API to get users' account data (#11664)Dirk Klimpel2022-01-055-0/+198
| | | Co-authored-by: reivilibre <olivier@librepush.net>
* Re-apply: Move glob_to_regex and re_word_boundary to matrix-python-common ↵reivilibre2022-01-059-123/+14
| | | | | #11505 (#11687) Co-authored-by: Sean Quah <seanq@element.io>
* Clarify SSO mapping provider documentation by writing `def` or `async def` ↵reivilibre2022-01-052-12/+13
| | | | before the names of methods, as appropriate. (#11681)
* Improve Docker docs for use with Postgres (#11640)Callum Macdonald2022-01-053-0/+6
|
* Correct Synapse install command for FreeBSD. (#11267)Donny Johnson2022-01-052-1/+2
| | | Co-authored-by: reivilibre <olivier@librepush.net>
* update ngnix reverse-proxy example (#11680)Richard van der Hoff2022-01-042-1/+2
| | | this should not be a case-insensitive match.
* Fix AssertionErrors after purging events (#11642)Richard van der Hoff2022-01-046-6/+30
| | | | | | | | | | | * Fix AssertionErrors after purging events If you purged a bunch of events from your database, and then restarted synapse without receiving more events, then you would get a bunch of AssertionErrors on restart. This fixes the situation by rewinding the stream processors. * `check-newsfragment`: ignore deleted newsfiles
* `FederationClient.backfill`: stop flagging events as outliers (#11632)Richard van der Hoff2022-01-043-2/+5
| | | | | | | | | | | | | | | | | | | | | Events returned by `backfill` should not be flagged as outliers. Fixes: ``` AssertionError: null File "synapse/handlers/federation.py", line 313, in try_backfill dom, room_id, limit=100, extremities=extremities File "synapse/handlers/federation_event.py", line 517, in backfill await self._process_pulled_events(dest, events, backfilled=True) File "synapse/handlers/federation_event.py", line 642, in _process_pulled_events await self._process_pulled_event(origin, ev, backfilled=backfilled) File "synapse/handlers/federation_event.py", line 669, in _process_pulled_event assert not event.internal_metadata.is_outlier() ``` See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/231992 Fixes #8894.
* Remove redundant `get_current_events_token` (#11643)Richard van der Hoff2022-01-047-36/+20
| | | | | | | | | | | | | | | | | * Push `get_room_{min,max_stream_ordering}` into StreamStore Both implementations of this are identical, so we may as well push it down and get rid of the abstract base class nonsense. * Remove redundant `StreamStore` class This is empty now * Remove redundant `get_current_events_token` This was an exact duplicate of `get_room_max_stream_ordering`, so let's get rid of it. * newsfile
* Better error messages from `get_create_event_for_room` (#11638)Richard van der Hoff2022-01-042-1/+6
| | | | "Unknown room" can mean a multitude of things here. To help with debugging, add some more words to the exception text.
* Include the topic event in the prejoin state, per MSC3173. (#11666)Patrick Cloke2022-01-044-0/+13
| | | | Invites and knocks will now include the topic in the stripped state send to clients before joining the room.
* Drop Bionic from Debian builds (#11633)Shay2022-01-034-7/+5
| | | | | | | | | | | | | | | | | * update Trove classifiers to remove py36 * stop building bionic * update dh-virtualenv * newsfragment * fix newsfragment * update version refs * another try at correct tag * Update changelog
* Convert all namedtuples to attrs. (#11665)Patrick Cloke2021-12-3022-206/+231
| | | To improve type hints throughout the code.
* Add type hints to `synapse/storage/databases/main/events_bg_updates.py` (#11654)Dirk Klimpel2021-12-303-30/+44
|
* Fix a type annotation in `test_account_data.py` and remove it from the Mypy ↵reivilibre2021-12-293-3/+3
| | | | | exclusion list. (#11657) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Improve type hints in storage classes. (#11652)Dirk Klimpel2021-12-2910-34/+44
| | | By using cast and making ignores more specific.
* Do not attempt to bundled aggregations for /members and /state. (#11623)Patrick Cloke2021-12-292-3/+2
| | | | Both of those APIs return state events, which will not have bundled aggregations added anyway.
* Add type hints to `synapse/storage/databases/main/stats.py` (#11653)Dirk Klimpel2021-12-293-42/+57
|
* Update to the current version of Black and run it on Synapse codebase (#11596)Shay2021-12-235-4/+3
| | | | | | | | | * update black version * run updated version of black on code * newsfragment * enumerate python versions
* Fix mypy error with opentracing.tags. (#11622)Patrick Cloke2021-12-232-0/+2
|
* Add details for how to set up TURN behind NAT (#11553)AndrewFerr2021-12-232-15/+53
| | | | Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>
* Drop EOL python 3.6 from CI (#11595)Shay2021-12-213-7/+8
| | | | | | | | | | | * remove python 3.6 and postgres 9.6 from github workflow * remove python 3.6 env from tox * newsfragment * correct postgres version * add py310 to tox env list
* Merge branch 'master' into developRichard van der Hoff2021-12-216-5/+43
|\
| * Merge branch 'release-v1.49'Richard van der Hoff2021-12-217-10/+57
| |\
| | * update changelog v1.49.2Richard van der Hoff2021-12-211-1/+1
| | | | | | | | | | | | postgres 10 _+_
| | * 1.49.2Richard van der Hoff2021-12-214-3/+19
| | |
| | * Pin to frozendict<2.1.2 (#11625)Richard van der Hoff2021-12-212-1/+3
| | | | | | | | | | | | ... to work around breakage on buster (https://github.com/Marco-Sulla/python-frozendict/issues/41)
| | * Add notes about dropping support for Python 3.6 and Postgres 9.6. v1.49.1Richard van der Hoff2021-12-212-2/+6
| | |
| | * typopoRichard van der Hoff2021-12-211-1/+1
| | |
| | * more wordsRichard van der Hoff2021-12-211-0/+2
| | |
| | * 1.49.1Richard van der Hoff2021-12-214-2/+16
| | |
* | | Refactor `tests.util.setup_test_homeserver` and ↵reivilibre2021-12-215-185/+195
| | | | | | | | | | | | `tests.server.setup_test_homeserver`. (#11503)
* | | Add type hints to event_push_actions. (#11594)Patrick Cloke2021-12-2111-154/+225
| | |
* | | Various opentracing enhancements (#11619)Richard van der Hoff2021-12-215-21/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Wrap `auth.get_user_by_req` in an opentracing span give `get_user_by_req` its own opentracing span, since it can result in a non-trivial number of sub-spans which it is useful to group together. This requires a bit of reorganisation because it also sets some tags (and may force tracing) on the servlet span. * Emit opentracing span for encoding json responses This can be a significant time sink. * Rename all sync spans with a prefix * Write an opentracing span for encoding sync response * opentracing span to group generate_room_entries * opentracing spans within sync.encode_response * changelog * Use the `trace` decorator instead of context managers
* | | Do not bundle aggregations for APIs which shouldn't include them. (#11592)Patrick Cloke2021-12-209-27/+31
| | | | | | | | | | | | | | | And make bundling aggregations opt-in, instead of opt-out to avoid having APIs to include extraneous data (and being much heavier than necessary).
* | | Improve opentracing support for `ResponseCache` (#11607)Richard van der Hoff2021-12-205-48/+149
| | | | | | | | | This adds some opentracing annotations to ResponseCache, to make it easier to see what's going on; in particular, it adds a link back to the initial trace which is actually doing the work of generating the response.
* | | Improve opentracing for incoming HTTP requests (#11618)Richard van der Hoff2021-12-204-73/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * remove `start_active_span_from_request` Instead, pull out a separate function, `span_context_from_request`, to extract the parent span, which we can then pass into `start_active_span` as normal. This seems to be clearer all round. * Remove redundant tags from `incoming-federation-request` These are all wrapped up inside a parent span generated in AsyncResource, so there's no point duplicating all the tags that are set there. * Leave request spans open until the request completes It may take some time for the response to be encoded into JSON, and that JSON to be streamed back to the client, and really we want that inside the top-level span, so let's hand responsibility for closure to the SynapseRequest. * opentracing logs for HTTP request events * changelog
* | | Merge remote-tracking branch 'origin/release-v1.49' into developRichard van der Hoff2021-12-203-6/+15
|\ \ \ | | |/ | |/|
| * | Disable aggregation bundling on `/sync` responses (#11583)Richard van der Hoff2021-12-203-6/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Disable aggregation bundling on `/sync` responses A partial revert of #11478. This turns out to have had a significant CPU impact on initial-sync handling. For now, let's disable it, until we find a more efficient way of achieving this. * Fix tests. Co-authored-by: Patrick Cloke <patrickc@matrix.org>
* | | Return JSON errors for unknown resources under /matrix/client. (#11602)Patrick Cloke2021-12-203-10/+6
| | | | | | | | | | | | Instead of returning 404 errors with HTML bodies when an unknown prefix was requested (e.g. /matrix/client/v1 before Synapse v1.49.0).
* | | Use mock from standard library (#11588)V024602021-12-203-12/+10
| | | | | | | | | Instead of the backported version.
* | | Add opentracing types (#11603)Shay2021-12-205-13/+18
| | |
* | | Add type hints to `synapse/tests/rest/admin` (#11590)Dirk Klimpel2021-12-167-57/+74
| | |
* | | Add type hints to `synapse/storage/databases/main/transactions.py` (#11589)Dirk Klimpel2021-12-163-25/+29
| | |
* | | Add MSC2716 and MSC3030 to `/versions` -> `unstable_features` (#11582)Eric Eastwood2021-12-163-1/+6
| | | | | | | | | | | | As suggested in https://github.com/matrix-org/matrix-react-sdk/pull/7372#discussion_r769523369
* | | Add type hints to `synapse/storage/databases/main/room.py` (#11575)Sean Quah2021-12-155-77/+108
| | |
* | | Require Collections as the parameters for simple_* methods. (#11580)Patrick Cloke2021-12-153-40/+12
| | | | | | | | | | | | Instead of Iterable since the generators are not allowed due to the potential for their re-use.
* | | Convert EventStreamResult to attrs. (#11574)Patrick Cloke2021-12-153-9/+24
| | |
* | | Add experimental support for MSC3202: allowing application services to ↵reivilibre2021-12-155-14/+162
| | | | | | | | | | | | masquerade as specific devices. (#11538)
* | | Add type hints to `synapse/storage/databases/main/e2e_room_keys.py` (#11549)Sean Quah2021-12-146-79/+188
| | |
* | | Add missing type hints to `synapse.logging.context` (#11556)Sean Quah2021-12-1413-122/+215
| | |
* | | Add missing type hints to `synapse.appservice` (#11360)Patrick Cloke2021-12-147-93/+148
| | |
* | | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2021-12-143-3/+27
|\ \ \ | | |/ | |/|
| * | Merge tag 'v1.49.0'Olivier Wilkinson (reivilibre)2021-12-143-3/+27
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.49.0 (2021-12-14) =========================== No significant changes since version 1.49.0rc1. Support for Ubuntu 21.04 ends next month on the 20th of January --------------------------------------------------------------- For users of Ubuntu 21.04 (Hirsute Hippo), please be aware that [upstream support for this version of Ubuntu will end next month][Ubuntu2104EOL]. We will stop producing packages for Ubuntu 21.04 after upstream support ends. [Ubuntu2104EOL]: https://lists.ubuntu.com/archives/ubuntu-announce/2021-December/000275.html The wiki has been migrated to the documentation website ------------------------------------------------------- We've decided to move the existing, somewhat stagnant pages from the GitHub wiki to the [documentation website](https://matrix-org.github.io/synapse/latest/). This was done for two reasons. The first was to ensure that changes are checked by multiple authors before being committed (everyone makes mistakes!) and the second was visibility of the documentation. Not everyone knows that Synapse has some very useful information hidden away in its GitHub wiki pages. Bringing them to the documentation website should help with visibility, as well as keep all Synapse documentation in one, easily-searchable location. Note that contributions to the documentation website happen through [GitHub pull requests](https://github.com/matrix-org/synapse/pulls). Please visit [#synapse-dev:matrix.org](https://matrix.to/#/#synapse-dev:matrix.org) if you need help with the process! Synapse 1.49.0rc1 (2021-12-07) ============================== Features -------- - Add [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) experimental client and federation API endpoints to get the closest event to a given timestamp. ([\#9445](https://github.com/matrix-org/synapse/issues/9445)) - Include bundled relation aggregations during a limited `/sync` request and `/relations` request, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675). ([\#11284](https://github.com/matrix-org/synapse/issues/11284), [\#11478](https://github.com/matrix-org/synapse/issues/11478)) - Add plugin support for controlling database background updates. ([\#11306](https://github.com/matrix-org/synapse/issues/11306), [\#11475](https://github.com/matrix-org/synapse/issues/11475), [\#11479](https://github.com/matrix-org/synapse/issues/11479)) - Support the stable API endpoints for [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946): the room `/hierarchy` endpoint. ([\#11329](https://github.com/matrix-org/synapse/issues/11329)) - Add admin API to get some information about federation status with remote servers. ([\#11407](https://github.com/matrix-org/synapse/issues/11407)) - Support expiry of refresh tokens and expiry of the overall session when refresh tokens are in use. ([\#11425](https://github.com/matrix-org/synapse/issues/11425)) - Stabilise support for [MSC2918](https://github.com/matrix-org/matrix-doc/blob/main/proposals/2918-refreshtokens.md#msc2918-refresh-tokens) refresh tokens as they have now been merged into the Matrix specification. ([\#11435](https://github.com/matrix-org/synapse/issues/11435), [\#11522](https://github.com/matrix-org/synapse/issues/11522)) - Update [MSC2918 refresh token](https://github.com/matrix-org/matrix-doc/blob/main/proposals/2918-refreshtokens.md#msc2918-refresh-tokens) support to confirm with the latest revision: accept the `refresh_tokens` parameter in the request body rather than in the URL parameters. ([\#11430](https://github.com/matrix-org/synapse/issues/11430)) - Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. ([\#11445](https://github.com/matrix-org/synapse/issues/11445)) - Expose `synapse_homeserver` and `synapse_worker` commands as entry points to run Synapse's main process and worker processes, respectively. Contributed by @Ma27. ([\#11449](https://github.com/matrix-org/synapse/issues/11449)) - `synctl stop` will now wait for Synapse to exit before returning. ([\#11459](https://github.com/matrix-org/synapse/issues/11459), [\#11490](https://github.com/matrix-org/synapse/issues/11490)) - Extend the "delete room" admin api to work correctly on rooms which have previously been partially deleted. ([\#11523](https://github.com/matrix-org/synapse/issues/11523)) - Add support for the `/_matrix/client/v3/login/sso/redirect/{idpId}` API from Matrix v1.1. This endpoint was overlooked when support for v3 endpoints was added in Synapse 1.48.0rc1. ([\#11451](https://github.com/matrix-org/synapse/issues/11451)) Bugfixes -------- - Fix using [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) batch sending in combination with event persistence workers. Contributed by @tulir at Beeper. ([\#11220](https://github.com/matrix-org/synapse/issues/11220)) - Fix a long-standing bug where all requests that read events from the database could get stuck as a result of losing the database connection, properly this time. Also fix a race condition introduced in the previous insufficient fix in Synapse 1.47.0. ([\#11376](https://github.com/matrix-org/synapse/issues/11376)) - The `/send_join` response now includes the stable `event` field instead of the unstable field from [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083). ([\#11413](https://github.com/matrix-org/synapse/issues/11413)) - Fix a bug introduced in Synapse 1.47.0 where `send_join` could fail due to an outdated `ijson` version. ([\#11439](https://github.com/matrix-org/synapse/issues/11439), [\#11441](https://github.com/matrix-org/synapse/issues/11441), [\#11460](https://github.com/matrix-org/synapse/issues/11460)) - Fix a bug introduced in Synapse 1.36.0 which could cause problems fetching event-signing keys from trusted key servers. ([\#11440](https://github.com/matrix-org/synapse/issues/11440)) - Fix a bug introduced in Synapse 1.47.1 where the media repository would fail to work if the media store path contained any symbolic links. ([\#11446](https://github.com/matrix-org/synapse/issues/11446)) - Fix an `LruCache` corruption bug, introduced in Synapse 1.38.0, that would cause certain requests to fail until the next Synapse restart. ([\#11454](https://github.com/matrix-org/synapse/issues/11454)) - Fix a long-standing bug where invites from ignored users were included in incremental syncs. ([\#11511](https://github.com/matrix-org/synapse/issues/11511)) - Fix a regression in Synapse 1.48.0 where presence workers would not clear their presence updates over replication on shutdown. ([\#11518](https://github.com/matrix-org/synapse/issues/11518)) - Fix a regression in Synapse 1.48.0 where the module API's `looping_background_call` method would spam errors to the logs when given a non-async function. ([\#11524](https://github.com/matrix-org/synapse/issues/11524)) Updates to the Docker image --------------------------- - Update `Dockerfile-workers` to healthcheck all workers in the container. ([\#11429](https://github.com/matrix-org/synapse/issues/11429)) Improved Documentation ---------------------- - Update the media repository documentation. ([\#11415](https://github.com/matrix-org/synapse/issues/11415)) - Update section about backward extremities in the room DAG concepts doc to correct the misconception about backward extremities indicating whether we have fetched an events' `prev_events`. ([\#11469](https://github.com/matrix-org/synapse/issues/11469)) Internal Changes ---------------- - Add `Final` annotation to string constants in `synapse.api.constants` so that they get typed as `Literal`s. ([\#11356](https://github.com/matrix-org/synapse/issues/11356)) - Add a check to ensure that users cannot start the Synapse master process when `worker_app` is set. ([\#11416](https://github.com/matrix-org/synapse/issues/11416)) - Add a note about postgres memory management and hugepages to postgres doc. ([\#11467](https://github.com/matrix-org/synapse/issues/11467)) - Add missing type hints to `synapse.config` module. ([\#11465](https://github.com/matrix-org/synapse/issues/11465)) - Add missing type hints to `synapse.federation`. ([\#11483](https://github.com/matrix-org/synapse/issues/11483)) - Add type annotations to `tests.storage.test_appservice`. ([\#11488](https://github.com/matrix-org/synapse/issues/11488), [\#11492](https://github.com/matrix-org/synapse/issues/11492)) - Add type annotations to some of the configuration surrounding refresh tokens. ([\#11428](https://github.com/matrix-org/synapse/issues/11428)) - Add type hints to `synapse/tests/rest/admin`. ([\#11501](https://github.com/matrix-org/synapse/issues/11501)) - Add type hints to storage classes. ([\#11411](https://github.com/matrix-org/synapse/issues/11411)) - Add wiki pages to documentation website. ([\#11402](https://github.com/matrix-org/synapse/issues/11402)) - Clean up `tests.storage.test_main` to remove use of legacy code. ([\#11493](https://github.com/matrix-org/synapse/issues/11493)) - Clean up `tests.test_visibility` to remove legacy code. ([\#11495](https://github.com/matrix-org/synapse/issues/11495)) - Convert status codes to `HTTPStatus` in `synapse.rest.admin`. ([\#11452](https://github.com/matrix-org/synapse/issues/11452), [\#11455](https://github.com/matrix-org/synapse/issues/11455)) - Extend the `scripts-dev/sign_json` script to support signing events. ([\#11486](https://github.com/matrix-org/synapse/issues/11486)) - Improve internal types in push code. ([\#11409](https://github.com/matrix-org/synapse/issues/11409)) - Improve type annotations in `synapse.module_api`. ([\#11029](https://github.com/matrix-org/synapse/issues/11029)) - Improve type hints for `LruCache`. ([\#11453](https://github.com/matrix-org/synapse/issues/11453)) - Preparation for database schema simplifications: disambiguate queries on `state_key`. ([\#11497](https://github.com/matrix-org/synapse/issues/11497)) - Refactor `backfilled` into specific behavior function arguments (`_persist_events_and_state_updates` and downstream calls). ([\#11417](https://github.com/matrix-org/synapse/issues/11417)) - Refactor `get_version_string` to fix-up types and duplicated code. ([\#11468](https://github.com/matrix-org/synapse/issues/11468)) - Refactor various parts of the `/sync` handler. ([\#11494](https://github.com/matrix-org/synapse/issues/11494), [\#11515](https://github.com/matrix-org/synapse/issues/11515)) - Remove unnecessary `json.dumps` from `tests.rest.admin`. ([\#11461](https://github.com/matrix-org/synapse/issues/11461)) - Save the OpenID Connect session ID on login. ([\#11482](https://github.com/matrix-org/synapse/issues/11482)) - Update and clean up recently ported documentation pages. ([\#11466](https://github.com/matrix-org/synapse/issues/11466))
| | * Restructure changelog v1.49.0Olivier Wilkinson (reivilibre)2021-12-141-2/+9
| | |
| | * 1.49.0Olivier Wilkinson (reivilibre)2021-12-143-1/+18
| | |
| * | Revert "Revert accidental fast-forward merge from v1.49.0rc1"Olivier Wilkinson (reivilibre)2021-12-14165-2708/+7720
| | | | | | | | | | | | This reverts commit 158d73ebdd61eef33831ae5f6990acf07244fc55.
| * | Revert accidental fast-forward merge from v1.49.0rc1Sean Quah2021-12-07165-7720/+2708
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit 26b5d2320f62b5eb6262c7614fbdfc364a4dfc02. This reverts commit bce4220f387bf5448387f0ed7d14ed1e41e40747. This reverts commit 966b5d0fa0893c3b628c942dfc232e285417f46d. This reverts commit 088d748f2cb51f03f3bcacc0fb3af1e0f9607737. This reverts commit 14d593f72d10b4d8cb67e3288bb3131ee30ccf59. This reverts commit 2a3ec6facf79f6aae011d9fb6f9ed5e43c7b6bec. This reverts commit eccc49d7554d1fab001e1fefb0fda8ffb254b630. This reverts commit b1ecd19c5d19815b69e425d80f442bf2877cab76. This reverts commit 9c55dedc8c4484e6269451a8c3c10b3e314aeb4a. This reverts commit 2d42e586a8c54be1a83643148358b1651c1ca666. This reverts commit 2f053f3f82ca174cc1c858c75afffae51af8ce0d. This reverts commit a15a893df8428395df7cb95b729431575001c38a. This reverts commit 8b4b153c9e86c04c7db8c74fde4b6a04becbc461. This reverts commit 494ebd7347ba52d702802fba4c3bb13e7bfbc2cf. This reverts commit a77c36989785c0d5565ab9a1169f4f88e512ce8a. This reverts commit 4eb77965cd016181d2111f37d93526e9bb0434f0. This reverts commit 637df95de63196033a6da4a6e286e1d58ea517b6. This reverts commit e5f426cd54609e7f05f8241d845e6e36c5f10d9a. This reverts commit 8cd68b8102eeab1b525712097c1b2e9679c11896. This reverts commit 6cae125e20865c52d770b24278bb7ab8fde5bc0d. This reverts commit 7be88fbf48156b36b6daefb228e1258e7d48cae4. This reverts commit b3fd99b74a3f6f42a9afd1b19ee4c60e38e8e91a. This reverts commit f7ec6e7d9e0dc360d9fb41f3a1afd7bdba1475c7. This reverts commit 5640992d176a499204a0756b1677c9b1575b0a49. This reverts commit d26808dd854006bd26a2366c675428ce0737238c. This reverts commit f91624a5950e14ba9007eed9bfa1c828676d4745. This reverts commit 16d39a5490ce74c901c7a8dbb990c6e83c379207. This reverts commit 8a4c2969874c0b7d72003f2523883eba8a348e83. This reverts commit 49e1356ee3d5d72929c91f778b3a231726c1413c. This reverts commit d2279f471ba8f44d9f578e62b286897a338d8aa1. This reverts commit b50e39df578adc3f86c5efa16bee9035cfdab61b. This reverts commit 858d80bf0f9f656a03992794874081b806e49222. This reverts commit 435f04480728c5d982e1a63c1b2777784bf9cd26. This reverts commit f61462e1be36a51dbf571076afa8e1930cb182f4. This reverts commit a6f1a3abecf8e8fd3e1bff439a06b853df18f194. This reverts commit 84dc50e160a2ec6590813374b5a1e58b97f7a18d. This reverts commit ed635d32853ee0a3e5ec1078679b27e7844a4ac7. This reverts commit 7b62791e001d6a4f8897ed48b3232d7f8fe6aa48. This reverts commit 153194c7717d8016b0eb974c81b1baee7dc1917d. This reverts commit f44d729d4ccae61bc0cdd5774acb3233eb5f7c13. This reverts commit a265fbd397ae72b2d3ea4c9310591ff1d0f3e05c. This reverts commit b9fef1a7cdfcc128fa589a32160e6aa7ed8964d7. This reverts commit b0eb64ff7bf6bde42046e091f8bdea9b7aab5f04. This reverts commit f1795463bf503a6fca909d77f598f641f9349f56. This reverts commit 70cbb1a5e311f609b624e3fae1a1712db639c51e. This reverts commit 42bf0204635213e2c75188b19ee66dc7e7d8a35e. This reverts commit 379f2650cf875f50c59524147ec0e33cfd5ef60c. This reverts commit 7ff22d6da41cd5ca80db95c18b409aea38e49fcd. This reverts commit 5a0b652d36ae4b6d423498c1f2c82c97a49c6f75. This reverts commit 432a174bc192740ac7a0a755009f6099b8363ad9. This reverts commit b14f8a1baf6f500997ae4c1d6a6d72094ce14270, reversing changes made to e713855dca17a7605bae99ea8d71bc7f8657e4b8.
* | Remove redundant `COALESCE()`s around `COUNT()`s in database queries (#11570)Sean Quah2021-12-149-21/+20
| | | | | | | | | | `COUNT()` never returns `NULL`. A `COUNT(*)` over 0 rows is 0 and a `COUNT(NULL)` is also 0.
* | Add missing type hints to synapse.http. (#11571)Patrick Cloke2021-12-148-51/+76
| |
* | checks for generators in database functions (#11564)Richard van der Hoff2021-12-133-7/+49
| | | | | | | | | | A couple of safety-checks to hopefully stop people doing what I just did, and create a storage function which only works the first time it is called (and not when it is re-run due to a database concurrency error or similar).
* | Move HTML parsing to a separate file for URL previews. (#11566)Patrick Cloke2021-12-136-401/+432
| | | | | | | | | | | | | | * Splits the logic for parsing HTML from the resource handling code. * Fix a circular import in the oEmbed code (which uses the HTML parsing code). * Renames some of the HTML parsing methods to: * Make it clear which methods are "internal" to the module. * Clarify what the methods do.
* | Type hint the constructors of the data store classes (#11555)Sean Quah2021-12-1335-87/+351
| |
* | Add type hints to `synapse/storage/databases/main/end_to_end_keys.py` (#11551)Sean Quah2021-12-134-69/+150
| |
* | Add type hints to `synapse/storage/databases/main/account_data.py` (#11546)Sean Quah2021-12-134-33/+87
| |
* | Make `get_device` return None if the device doesn't exist rather than ↵reivilibre2021-12-136-13/+20
| | | | | | | | | | raising an exception. (#11565) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Allow events to be created with no `prev_events` (MSC2716) (#11243)Eric Eastwood2021-12-104-7/+124
| | | | | | | | | | The event still needs to have `auth_events` defined to be valid. Split out from https://github.com/matrix-org/synapse/pull/11114
* | Test to ensure we share the same `state_group` across the whole historical ↵Eric Eastwood2021-12-102-0/+181
| | | | | | | | | | | | | | | | batch (MSC2716) (#11487) Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716 We did some work on making sure the `state_groups` were shared in https://github.com/matrix-org/synapse/pull/10975
* | Adjust _get_rooms_changed comments (#11550)David Robertson2021-12-102-22/+30
| | | | | | C.f. https://github.com/matrix-org/synapse/pull/11494#pullrequestreview-827780886
* | skip some dict munging in event persistence (#11560)Richard van der Hoff2021-12-103-60/+114
| | | | | | | | | | | | Create a new dict helper method `simple_insert_many_values_txn`, which takes raw row values, rather than {key=>value} dicts. This saves us a bunch of dict munging, and makes it easier to use generators rather than creating intermediate lists and dicts.
* | Stop populating `state_events.prev_state` (#11558)Richard van der Hoff2021-12-103-5/+5
| | | | | | this field is never read, so we may as well stop populating it.
* | Ensure emails are canonicalized before fetching associated user. (#11547)Patrick Cloke2021-12-105-4/+11
| | | | | | | | This should fix pushers with an email in non-canonical form is used as the pushkey.
* | Do not allow cross-room relations, per MSC2674. (#11516)Patrick Cloke2021-12-096-17/+161
| |
* | Additional type hints for the config module, part 2. (#11480)Patrick Cloke2021-12-095-19/+28
| |
* | Use HTTPStatus constants in place of literals in `synapse.http` (#11543)Dirk Klimpel2021-12-094-19/+47
| |
* | Support unprefixed versions of fallback key property names. (#11541)Hubert Chathi2021-12-094-6/+32
| |
* | Add missing `errcode` to `parse_string` and `parse_boolean` (#11542)Dirk Klimpel2021-12-096-12/+13
| |
* | Allow guests to send state events (#11378)Robert Long2021-12-092-1/+2
| |
* | Add a constant for receipt types (m.read). (#11531)Patrick Cloke2021-12-089-45/+87
| | | | | | And expand some type hints in the receipts storage module.
* | Clean up `synapse.rest.admin` (#11535)Dirk Klimpel2021-12-0815-165/+96
| |
* | Document the usage of refresh tokens. (#11427)reivilibre2021-12-083-0/+141
| | | | | | Co-authored-by: David Robertson <davidr@element.io>
* | Use HTTPStatus constants in place of literals in ↵reivilibre2021-12-082-47/+88
| | | | | | | | `tests.rest.client.test_auth`. (#11520)
* | Improve log messages for stream ids (#11536)Richard van der Hoff2021-12-083-4/+7
| | | | | | | | Somehow I'd managed to get my database in a pickle with stream ids. These changes were useful to debug.
* | Send and handle cross-signing messages using the stable prefix. (#10520)Hubert Chathi2021-12-084-5/+13
| |
* | Fix case in `wait_for_background_updates` where `self.store` does not exist ↵Andrew Morgan2021-12-072-7/+5
|/ | | | | | (#11331) Pull the DataStore from the HomeServer instance, which always exists.
* Sort internal changes in changelog v1.49.0rc1Sean Quah2021-12-071-16/+16
|
* Update CHANGES.mdSean Quah2021-12-071-30/+26
|
* 1.49.0rc1Sean Quah2021-12-0765-63/+87
|
* Revert "Move `glob_to_regex` and `re_word_boundary` to ↵Sean Quah2021-12-078-12/+124
| | | | | | `matrix-python-common` (#11505) (#11527) This reverts commit a77c36989785c0d5565ab9a1169f4f88e512ce8a.
* Refactors in `_generate_sync_entry_for_rooms` (#11515)David Robertson2021-12-073-46/+79
| | | | | | | | * Move sync_token up to the top * Pull out _get_ignored_users * Try to signpost the body of `_generate_sync_entry_for_rooms` * Pull out _calculate_user_changes Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Correctly register shutdown handler for presence workers (#11518)David Robertson2021-12-072-1/+2
| | | Fixes #11517
* Fix `ModuleApi.looping_background_call` for non-async functions (#11524)Sean Quah2021-12-072-3/+3
| | | | | | After #10847, `looping_background_call` would print an error in the logs every time a non-async function was called. Since the error would be caught and ignored immediately, there were no other side effects.
* Fix 'delete room' admin api to work on incomplete rooms (#11523)Richard van der Hoff2021-12-075-37/+33
| | | | | If, for some reason, we don't have the create event, we should still be able to purge a room.
* Correctly ignore invites from ignored users (#11511)David Robertson2021-12-072-5/+7
|
* Fix the test breakage introduced by #11435 as a result of concurrent PRs ↵reivilibre2021-12-072-1/+2
| | | | (#11522)
* Stabilise support for MSC2918 refresh tokens as they have now been merged ↵reivilibre2021-12-066-44/+115
| | | | into the Matrix specification. (#11435)
* Save the OIDC session ID (sid) with the device on login (#11482)Quentin Gliech2021-12-0615-65/+370
| | | As a step towards allowing back-channel logout for OIDC.
* Add admin API to get some information about federation status (#11407)Dirk Klimpel2021-12-067-0/+783
|
* Include bundled aggregations in /sync and related fixes (#11478)Patrick Cloke2021-12-0610-101/+169
| | | | | | | | Due to updates to MSC2675 this includes a few fixes: * Include bundled aggregations for /sync. * Do not include bundled aggregations for /initialSync and /events. * Do not bundle aggregations for state events. * Clarifies comments and variable names.
* Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)Sean Quah2021-12-068-123/+13
|
* Update backward extremity docs to make it clear that it does not indicate ↵Eric Eastwood2021-12-032-9/+8
| | | | | | | whether we have fetched an events' `prev_events` (#11469) Spawning from https://github.com/matrix-org/synapse/pull/9445#discussion_r758958181 Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Support configuring the lifetime of non-refreshable access tokens separately ↵reivilibre2021-12-035-3/+221
| | | | to refreshable access tokens. (#11445)
* Add type hints to `synapse/tests/rest/admin` (#11501)Dirk Klimpel2021-12-0311-228/+257
|
* Revert accidental commits to develop.Olivier Wilkinson (reivilibre)2021-12-035-195/+185
|
* NewsfileOlivier Wilkinson (reivilibre)2021-12-031-0/+1
| | | | Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Give `tests.server.setup_test_homeserver` (nominally!) the same behaviourOlivier Wilkinson (reivilibre)2021-12-031-0/+3
| | | | | | | | | | by calling into `make_test_homeserver_synchronous`. The function *could* have been inlined at this point but the function is big enough and it felt fine to leave it as is. At least there isn't a confusing name clash anymore!
* Move `tests.utils.setup_test_homeserver` to `tests.server`Olivier Wilkinson (reivilibre)2021-12-034-177/+188
| | | | | | | It had no users. We have just taken the identity of a previous function but don't provide the same behaviour, so we need to fix this in the next commit...
* Convert one of the `setup_test_homeserver`s to ↵Olivier Wilkinson (reivilibre)2021-12-031-8/+3
| | | | | | | | `make_test_homeserver_synchronous` and pass in the homeserver rather than calling a same-named function to ask for one. Later commits will jiggle things around to make this sensible.
* Disambiguate queries on `state_key` (#11497)Richard van der Hoff2021-12-027-16/+21
| | | | | We're going to add a `state_key` column to the `events` table, so we need to add some disambiguation to queries which use it.
* Comments on the /sync tentacles (#11494)David Robertson2021-12-023-43/+129
| | | | | This mainly consists of docstrings and inline comments. There are one or two type annotations and variable renames thrown in while I was here. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Clean up tests.storage.test_appservice (#11492)reivilibre2021-12-022-177/+169
|
* Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)reivilibre2021-12-022-17/+11
|
* Clean up `tests.test_visibility` to remove legacy code. (#11495)reivilibre2021-12-023-203/+40
|
* Minor cleanup on recently ported doc pages (#11466)Shay2021-12-025-46/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * requested changes to admin_faq.md * requested changes to database_maintenance_tools.md * requested changes to understanding_synapse_through_graphana_graphs.md * add changelog * fix leftover merge errata * fix unwanted changes from merge * use two spaces between entries * outdent code blocks
* Add most of the missing type hints to `synapse.federation`. (#11483)Patrick Cloke2021-12-0210-49/+84
| | | This skips a few methods which are difficult to type.
* Avoid waiting for zombie processes in `synctl stop` (#11490)Sean Quah2021-12-022-3/+17
|
* Fix media repository failing when media store path contains symlinks (#11446)Sean Quah2021-12-023-45/+180
|
* Add type annotations to `tests.storage.test_appservice`. (#11488)reivilibre2021-12-025-53/+98
|
* `scripts-dev/sign_json`: support for signing events (#11486)Richard van der Hoff2021-12-023-1/+43
|
* Add MSC3030 experimental client and federation API endpoints to get the ↵Eric Eastwood2021-12-0213-31/+674
| | | | | | | | | | | | | | | | | | | | | | | | | closest event to a given timestamp (#9445) MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030 Client API endpoint. This will also go and fetch from the federation API endpoint if unable to find an event locally or we found an extremity with possibly a closer event we don't know about. ``` GET /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Federation API endpoint: ``` GET /_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Co-authored-by: Erik Johnston <erik@matrix.org>
* Port wiki pages to documentation website (#11402)Shay2021-12-019-0/+483
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * revert unintentional change to CHANGES.md * add link Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update CHANGES.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Add a license header and comment. (#11479)Patrick Cloke2021-12-012-0/+16
|
* Clean-up get_version_string (#11468)Patrick Cloke2021-12-012-57/+26
|
* Link background update controller docs to summary (#11475)Brendan Abolivier2021-12-012-0/+2
|
* Additional type hints for config module. (#11465)Patrick Cloke2021-12-0115-99/+129
| | | | This adds some misc. type hints to helper methods used in the `synapse.config` module.
* Register the login redirect endpoint for v3. (#11451)Patrick Cloke2021-12-013-3/+4
| | | As specified for Matrix v1.1.
* Update openid.mdRichard van der Hoff2021-12-011-1/+1
| | | fix header level
* Remove mention of OIDC certification from Dex (#11470)Etienne Dysli Metref2021-12-011-1/+1
| | | | | | | Dex isn't yet [1,2] a certified OpenID Provider implementation. As of today, it's not on the list maintained by the OpenID Foundation. [3] [1] https://github.com/dexidp/dex/issues/42 [2] https://github.com/dexidp/dex/issues/262 [3] https://openid.net/certification/
* Add a note about huge pages to our Postgres doc (#11467)Shay2021-11-302-0/+4
| | | | | * Add note to postgres doc about hugepages * Newsfragment
* Don't start Synapse master process if `worker_app` is set (#11416)Shay2021-11-303-0/+39
| | | | | | | | | | | | | | | | | | | | | * Add check to catch syanpse master process starting when workers are configured * add test to verify that starting master process with worker config raises error * newsfragment * specify config.worker.worker_app in check * update test * report specific config option that triggered the error Co-authored-by: reivilibre <oliverw@matrix.org> * clarify error message Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>
* Expose worker & homeserver as entrypoints in `setup.py` (#11449)Maximilian Bosch2021-11-303-1/+12
| | | Co-authored-by: reivilibre <oliverw@matrix.org>
* Bundle relations of relations into the `/relations` result. (#11284)Patrick Cloke2021-11-304-6/+130
| | | | | Per updates to MSC2675 which now states that bundled aggregations should be included from the `/relations` endpoint.
* Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)Sean Quah2021-11-303-1/+17
| | | | | | | | | | | When all entries in an `LruCache` have a size of 0 according to the provided `size_callback`, and `drop_from_cache` is called on a cache node, the node would be unlinked from the LRU linked list but remain in the cache dictionary. An assertion would be later be tripped due to the inconsistency. Avoid unintentionally calling `__len__` and use a strict `is None` check instead when unwrapping the weak reference.
* Eliminate a few `Any`s in `LruCache` type hints (#11453)Sean Quah2021-11-304-19/+32
|
* Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)Dirk Klimpel2021-11-302-41/+21
| | | | | The tests helpers automatically convert dictionaries to JSON payloads, no need to do it manually for each test.
* Merge branch 'master' into developBrendan Abolivier2021-11-3072-71/+101
|\
| * Merge trust_identity_server_for_password_resets PRs v1.48.0Brendan Abolivier2021-11-301-2/+1
| |
| * Move notices upBrendan Abolivier2021-11-301-5/+4
| |
| * Fixup changelogBrendan Abolivier2021-11-301-1/+1
| |
| * 1.48.0Brendan Abolivier2021-11-303-1/+13
| |
| * Fix docker hub name v1.48.0rc1Brendan Abolivier2021-11-251-1/+1
| |
| * Incorporate review from synapse-devBrendan Abolivier2021-11-251-10/+12
| |
| * Fixup changelogBrendan Abolivier2021-11-251-13/+12
| |
| * 1.48.0rc1Brendan Abolivier2021-11-2572-71/+90
| |
* | Add missing copyright header. (#11460)Patrick Cloke2021-11-302-0/+15
| |
* | synctl stop: wait for processes to exit (#11459)Richard van der Hoff2021-11-302-25/+15
| | | | | | | | | | If you're trying to shut down Synapse, it's rather handy if it *actually* shuts down before you move on.
* | Improved push typing (#11409)Marcus2021-11-307-36/+210
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Convert status codes to `HTTPStatus` in `tests.rest.admin` (#11455)Dirk Klimpel2021-11-3012-557/+887
| |
* | Convert status codes to `HTTPStatus` in `synapse.rest.admin` (#11452)Dirk Klimpel2021-11-2912-171/+276
| |
* | Refactor `backfilled` into specific behavior function arguments ↵Eric Eastwood2021-11-293-21/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (`_persist_events_and_state_updates`) (#11417) Part of https://github.com/matrix-org/synapse/issues/11300 Call stack: - `_persist_events_and_state_updates` (added `use_negative_stream_ordering`) - `_persist_events_txn` - `_update_room_depths_txn` (added `update_room_forward_stream_ordering`) - `_update_metadata_tables_txn` - `_store_room_members_txn` (added `inhibit_local_membership_updates`) Using keyword-only arguments (`*`) to reduce the mistakes from `backfilled` being left as a positional argument somewhere and being interpreted wrong by our new arguments.
* | Support the stable /hierarchy endpoint from MSC2946 (#11329)Patrick Cloke2021-11-2911-51/+134
| | | | | | | | | | | | This also makes additional updates where the implementation had drifted from the approved MSC. Unstable endpoints will be removed at a later data.
* | Make background updates controllable via a plugin (#11306)Erik Johnston2021-11-2912-61/+407
| | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Return the stable `event` field from `/send_join` per MSC3083. (#11413)Patrick Cloke2021-11-295-4/+19
| | | | | | | | | | This does not remove the unstable field and still parses both. Handling of the unstable field will need to be removed in the future.
* | Update the media repository documentation (#11415)Sean Quah2021-11-292-19/+71
| |
* | Add type annotations to some of the configuration surrounding refresh ↵reivilibre2021-11-293-2/+11
| | | | | | | | tokens. (#11428)
* | Fix perspectives requests for multiple keys for the same server (#11440)Richard van der Hoff2021-11-293-11/+91
| | | | | | | | | | If we tried to request multiple keys for the same server, we would end up dropping some of those requests.
* | Fix using MSC2716 batch sending with event persistence workers (#11220)Tulir Asokan2021-11-293-0/+8
| | | | | | | | Signed-off-by: Tulir Asokan <tulir@beeper.com>
* | disallow-untyped-defs for the module_api (#11029)David Robertson2021-11-293-30/+59
| |
* | Fix changelog filename in #11441David Robertson2021-11-291-0/+0
| |
* | Add a test case for the SendJoinParser (#11441)David Robertson2021-11-293-0/+55
| | | | | | This would have caught the bug #11438 introduced in #11217 and fixed in #11439.
* | Bump ijson dependency to 3.1 (#11438) (#11439)Daniel Molkentin2021-11-262-1/+2
| | | | | | | | | | | | | | | | | | | | Since e81fa9264873369653171157514ff68226491fff, Synapse depends on the use_float flag which has been introduced in ijson 3.1 and is not available in 3.0. This is known to cause runtime errors with send_join. Signed-off-by: Daniel Molkentin <danimo@infra.run> Co-authored-by: Daniel Molkentin <danimo@infra.run>
* | Update MSC2918 refresh token support to confirm with the latest revision: ↵reivilibre2021-11-264-22/+58
| | | | | | | | accept the `refresh_tokens` parameter in the request body rather than in the URL parameters. (#11430)
* | Add type hints to `synapse/storage/databases/main/events_worker.py` (#11411)Sean Quah2021-11-2613-171/+255
| | | | | | | | Also refactor the stream ID trackers/generators a bit and try to document them better.
* | Support expiry of refresh tokens and expiry of the overall session when ↵reivilibre2021-11-268-54/+338
| | | | | | | | refresh tokens are in use. (#11425)
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-05 16:36:56 +0000