summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Add a windows->unix file endings commit to git blame ignore file (#12824)Andrew Morgan2022-05-231-0/+3
|
* Remove Caddy from the Synapse workers image used in Complement. (#12818)reivilibre2022-05-237-93/+38
|
* Fix media thumbnails being unusable before the index had been added in the ↵reivilibre2022-05-232-0/+3
| | | | background. (#12823)
* Send `USER_IP` commands on a different Redis channel, in order to reduce ↵reivilibre2022-05-205-4/+17
| | | | traffic to workers that do not process these commands. (#12809)
* Uniformize spam-checker API, part 1: the `Code` enum. (#12703)David Teller2022-05-202-2/+10
|
* Update EventContext `get_current_event_ids` and `get_prev_event_ids` to ↵Shay2022-05-2010-18/+65
| | | | accept state filters and update calls where possible (#12791)
* Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803)Sean Quah2022-05-192-2/+3
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Add a unit test for copying over arbitrary room types when upgrading a room ↵Andrew Morgan2022-05-193-2/+33
| | | | (#12792)
* Lay some foundation work to allow workers to only subscribe to some kinds of ↵reivilibre2022-05-195-24/+173
| | | | messages, reducing replication traffic. (#12672)
* Add detail to `cache_autotuning` config option documentation (#12776)Shay2022-05-192-4/+11
|
* Update configuration manual to document size-related suffixes (#12777)Shay2022-05-192-0/+10
|
* Properly close providers.json file stream. (#12794)Petr Vaněk2022-05-192-3/+4
|
* Add a unique index to `state_group_edges` to prevent duplicates being ↵reivilibre2022-05-195-0/+139
| | | | accidentally introduced and the consequential impact to performance. (#12687)
* hash_password: raise an error if no config file is specified (#12789)Jae Lo Presti2022-05-192-5/+6
|
* Simplify untyped-defs config in mypy.ini (#12790)David Robertson2022-05-192-156/+18
|
* Implement MSC3818: copy room type on upgrade (#12786)Aminda Suomalainen2022-05-192-8/+9
| | | | | Resolves: #11896 Signed-off-by: Aminda Suomalainen <suomalainen+git@mikaela.info>
* Add missing user directory search endpoint to the generic worker ↵Sami Olmari2022-05-192-0/+11
| | | | | | documentation (#12773) Signed-off-by: Sami Olmari <sami@olmari.fi>
* openid.md: fix some linksRichard van der Hoff2022-05-191-9/+9
| | | docbook doesn't auto-linkify links
* Downgrade some OIDC exceptions to warnings (#12723)David Robertson2022-05-182-2/+3
|
* Fix federation in demo scripts. (#12783)Patrick Cloke2022-05-183-6/+11
|
* Skip waiting for full state if a StateFilter does not require it (#12498)Richard van der Hoff2022-05-182-4/+60
| | | | | If `StateFilter` specifies a state set which we will have regardless of state-syncing, then we may as well return it immediately.
* Fix YAML parsing error in `url_preview_accept_language` (#12785)Andrew Morgan2022-05-182-6/+7
|
* Refactor `resolve_state_groups_for_events` to not pull out full state when ↵Shay2022-05-185-23/+40
| | | | no state resolution happens. (#12775)
* Add documentation for cancellation of request processing (#12761)Sean Quah2022-05-183-0/+394
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Add some type hints to `event_federation` datastore (#12753)Dirk Klimpel2022-05-185-65/+127
| | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Merge branch 'master' into developBrendan Abolivier2022-05-183-1/+18
|\
| * Fixup changelog v1.59.1Brendan Abolivier2022-05-181-2/+4
| |
| * 1.59.1Brendan Abolivier2022-05-184-2/+16
| |
| * Discard null-containing strings before updating the user directory (#12762)David Robertson2022-05-186-11/+45
| |
* | Do not keep going if there are 5 back-to-back background update failures. ↵reivilibre2022-05-182-0/+9
| | | | | | | | (#12781)
* | Give a meaningful error message when a client tries to create a room with an ↵reivilibre2022-05-183-0/+19
| | | | | | | | invalid alias localpart. (#12779)
* | Switch the 'Configuration' link in the docs homepage to the config manual ↵Andrew Morgan2022-05-182-3/+4
| | | | | | | | (#12748)
* | Add some documentation around the `rc_invites` option to the config docs ↵Andrew Morgan2022-05-182-0/+15
| | | | | | | | (#12759)
* | Discard null-containing strings before updating the user directory (#12762)David Robertson2022-05-186-11/+45
| |
* | Make handling of federation Authorization header (more) compliant with ↵Hubert Chathi2022-05-184-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | RFC7230 (#12774) The main differences are: - values with delimiters (such as colons) should be quoted, so always quote the origin, since it could contain a colon followed by a port number - should allow more than one space after "X-Matrix" - quoted values with backslash-escaped characters should be unescaped - names should be case insensitive
* | Move methods that call add_push_rule to PushRuleStore (#12772)Adam2022-05-182-51/+52
| | | | | | Signed-off-by: Adam Roddick <ajroddick@tuta.io>
* | Suggest using docker when testing against postgres (#12765)David Robertson2022-05-172-3/+29
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Delete events from federation_inbound_events_staging table on purge (#12770)Mathieu Velten2022-05-173-0/+3
| |
* | allow `on_invalidate=None` in `@cached` methods (#12769)David Robertson2022-05-173-10/+19
| |
* | Add some type hints to datastore (#12717)Dirk Klimpel2022-05-1710-161/+254
| |
* | Add a new room version for MSC3787's knock+restricted join rule (#12623)Travis Ralston2022-05-176-7/+68
| |
* | Remove code which updates `application_services_state.last_txn` (#12680)Richard van der Hoff2022-05-175-55/+35
| | | | | | | | This column is unused as of #12209, so let's stop writing to it.
* | Fix push for m.read events (#12721)SpiritCroc2022-05-172-1/+2
| | | | | | | | badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.
* | Merge branch 'master' into developDavid Robertson2022-05-174-4/+22
|\|
| * version tweak in changelog v1.59.0David Robertson2022-05-171-1/+1
| |
| * 1.59.0David Robertson2022-05-174-4/+21
| |
| * Fix query performance for /sync (#12745)Erik Johnston2022-05-162-1/+2
| |
* | Add index to cache invalidations (#12747)Erik Johnston2022-05-173-0/+27
| | | | | | | | | | For workers that rarely write to the cache the `get_all_updated_caches` query can become expensive if the worker falls behind when reading the cache.
* | Track in memory events using weakrefs (#10533)Erik Johnston2022-05-174-2/+60
| |
* | Tidy up and type-hint the database engine modules (#12734)David Robertson2022-05-177-94/+182
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Fix typo in name of 'run_background_tasks_on' option in config manual (#12749)Andrew Morgan2022-05-162-1/+2
| |
* | Revert "changelog"Andrew Morgan2022-05-161-1/+0
| | | | | | | | | | | | This reverts commit e24c11afd6bb63de2dd7e029a5839d84f592df3c. whoops...
* | changelogAndrew Morgan2022-05-161-0/+1
| |
* | Add `StreamKeyType` class and replace string literals with constants (#12567)Andrew Morgan2022-05-1619-80/+125
| |
* | Avoid unnecessary copies when filtering private read receipts. (#12711)Šimon Brandner2022-05-164-73/+92
| | | | | | | | | | | | A minor optimization to avoid unnecessary copying/building identical dictionaries when filtering private read receipts. Also clarifies comments and cleans-up some tests.
* | Merge tag 'v1.59.0rc2' into developDavid Robertson2022-05-164-11/+29
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.59.0rc2 (2022-05-16) ============================== Synapse 1.59 makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0 where `/sync` would fail if the most recent event in a room was rejected. ([\#12729](https://github.com/matrix-org/synapse/issues/12729))
| * Move 1.59 warning to the top v1.59.0rc2David Robertson2022-05-161-9/+9
| |
| * 1.59.0rc2David Robertson2022-05-164-2/+16
| |
| * Fix bug /sync returning 404 (#12729)Erik Johnston2022-05-162-8/+12
| | | | | | | | | | * Fix bug /sync returning 404 Fixes #12571
* | Fix typo in listener config (#12742)Dirk Klimpel2022-05-164-4/+5
| |
* | Fix room upgrades creating an empty room when auth fails (#12696)Sean Quah2022-05-163-56/+84
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Consolidate logic for parsing relations. (#12693)Patrick Cloke2022-05-167-61/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | Parse the `m.relates_to` event content field (which describes relations) in a single place, this is used during: * Event persistence. * Validation of the Client-Server API. * Fetching bundled aggregations. * Processing of push rules. Each of these separately implement the logic and each made slightly different assumptions about what was valid. Some had minor / potential bugs.
* | Add config flags to allow for cache auto-tuning (#12701)Shay2022-05-137-54/+266
| |
* | Update configs used by Complement to allow more invites (#12731)Till2022-05-133-0/+25
| |
* | Don't create an empty room when checking for MAU limits (#12713)Brendan Abolivier2022-05-134-56/+66
| |
* | Another batch of type annotations (#12726)David Robertson2022-05-1311-79/+144
| |
* | SpamChecker metrics (#12513)Jess Porter2022-05-134-26/+64
| | | | | | | | | | | | | | | | | | * add Measure blocks all over SpamChecker Signed-off-by: jesopo <github@lolnerd.net> * fix test_spam_checker_may_join_room and test_threepid_invite_spamcheck * better changelog entry
* | Update issuer URL in example OIDC Keycloak config (#12727)Niklas2022-05-132-1/+2
| | | | | | | | | | | | | | * Update openid.md Newer versions of keycloak returning a 404 when using the `/auth` prefix. Related: https://github.com/matrix-org/synapse/issues/12714
* | URL preview cache expiry logs: INFO -> DEBUG, text clarifications (#12720)Andrew Morgan2022-05-122-9/+22
| |
* | Reduce the number of "untyped defs" (#12716)David Robertson2022-05-1216-69/+142
| |
* | add default_power_level_content_override config option. (#12618)Andy Balaam2022-05-126-1/+381
| | | | | | Co-authored-by: Matthew Hodgson <matthew@matrix.org>
* | Fix reference to the wrong symbol in the media admin api docs (#12715)Andrew Morgan2022-05-122-1/+2
| |
* | Enable cancellation of `GET /members` and `GET /state` requests (#12708)Sean Quah2022-05-113-2/+9
| | | | | | | | | | | | | | | | Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$state_key/*` requests. Signed-off-by: Sean Quah <seanq@element.io>
* | No longer permit empty body when sending receipts (#12709)David Robertson2022-05-113-38/+6
| |
* | Complain if a federation endpoint has the `@cancellable` flag (#12705)Sean Quah2022-05-113-1/+15
| | | | | | | | | | | | | | | | `BaseFederationServlet` wraps its endpoints in a bunch of async code that has not been vetted for compatibility with cancellation. Fail CI if a `@cancellable` flag is applied to a federation endpoint. Signed-off-by: Sean Quah <seanq@element.io>
* | Reload cache factors from disk on SIGHUP (#12673)David Robertson2022-05-1111-61/+199
| |
* | Respect the `@cancellable` flag for `ReplicationEndpoint`s (#12700)Sean Quah2022-05-114-2/+139
| | | | | | | | | | | | | | | | | | While `ReplicationEndpoint`s register themselves via `JsonResource`, they pass a method that calls the handler, instead of the handler itself, to `register_paths`. As a result, `JsonResource` will not correctly pick up the `@cancellable` flag and we have to apply it ourselves. Signed-off-by: Sean Quah <seanq@element.io>
* | Respect the `@cancellable` flag for `RestServlet`s and ↵Sean Quah2022-05-116-2/+191
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BaseFederationServlet`s (#12699) Both `RestServlet`s and `BaseFederationServlet`s register their handlers with `HttpServer.register_paths` / `JsonResource.register_paths`. Update `JsonResource` to respect the `@cancellable` flag on handlers registered in this way. Although `ReplicationEndpoint` also registers itself using `register_paths`, it does not pass the handler method that would have the `@cancellable` flag directly, and so needs separate handling. Signed-off-by: Sean Quah <seanq@element.io>
* | Respect the `@cancellable` flag for `DirectServe{Html,Json}Resource`s (#12698)Sean Quah2022-05-113-2/+112
| | | | | | | | | | | | | | | | | | | | | | | | `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit from `_AsyncResource`. These classes expect to be subclassed with `_async_render_*` methods. This commit has no effect on `JsonResource`, despite inheriting from `_AsyncResource`. `JsonResource` has its own `_async_render` override which will need to be updated separately. Signed-off-by: Sean Quah <seanq@element.io>
* | Remove unneeded `ActionGenerator` class. (#12691)Patrick Cloke2022-05-117-60/+17
| | | | | | | | It simply passes through to `BulkPushRuleEvaluator`, which can be called directly instead.
* | Fix `/messages` throwing a 500 when querying for non-existent room (#12683)Eric Eastwood2022-05-103-16/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/12678 Complement test added: https://github.com/matrix-org/complement/pull/369 **Before:** 500 internal server error **After:** According to the [spec](https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages), calling `/messages` against a non-existent `room_id` should throw a 403 forbidden (since you're not part of the room). This also matches the behavior before https://github.com/matrix-org/synapse/pull/12370 which regressed Synapse to the 500 behavior. ```json { "errcode": "M_FORBIDDEN", "error": "User @test:my.synapse.server not in room !dne:my.synapse.server, and room previews are disabled" } ```
* | Refactor `EventContext` (#12689)Erik Johnston2022-05-1013-200/+70
| | | | | | | | | | | | | | | | | | | | Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684
* | Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694)Sean Quah2022-05-103-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | All async request processing goes through `_AsyncResource`, so this is the only place where a `Deferred` needs to be captured for cancellation. Unfortunately, the same isn't true for determining whether a request can be cancelled. Each of `RestServlet`, `BaseFederationServlet`, `DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have different wrappers around the method doing the request handling and they all need to be handled separately. Signed-off-by: Sean Quah <seanq@element.io>
* | Fix incorrect type hint in filtering code. (#12695)Patrick Cloke2022-05-102-2/+4
| |
* | Add some type hints to datastore. (#12477)Dirk Klimpel2022-05-104-71/+122
| |
* | Stop writing to `event_reference_hashes` (#12679)Richard van der Hoff2022-05-105-38/+5
| | | | | | | | | | This table is never read, since #11794. We stop writing to it; in future we can drop it altogether.
* | Add helper class for testing request cancellation (#12630)Sean Quah2022-05-104-0/+127
| | | | | | | | | | | | | | Also expose the `SynapseRequest` from `FakeChannel` in tests, so that we can call `Request.connectionLost` to simulate a client disconnecting. Signed-off-by: Sean Quah <seanq@element.io>
* | Add ability to cancel disconnected requests to `SynapseRequest` (#12588)Sean Quah2022-05-102-1/+24
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Add `@cancellable` decorator, for use on request handlers (#12586)Sean Quah2022-05-102-0/+62
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Merge tag 'v1.59.0rc1' into developDavid Robertson2022-05-1073-103/+179
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](https://github.com/matrix-org/matrix-spec-proposals/pull/2285/commits/4a77139249c2e830aec3c7d6bd5501a514d1cc27) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671))
| * other fixes v1.59.0rc1David Robertson2022-05-101-2/+2
| |
| * backquote `m.room.server_acl`David Robertson2022-05-101-1/+1
| |
| * v1 -> 1David Robertson2022-05-101-4/+4
| |
| * Fix deprecation noticeDavid Robertson2022-05-101-1/+1
| |
| * I manually added O's change, remove newsfileDavid Robertson2022-05-101-1/+0
| |
| * Add Olivier's last-minute mergeDavid Robertson2022-05-101-0/+1
| |
| * Group release script changesDavid Robertson2022-05-101-1/+1
| |
| * Fix changelog linkDavid Robertson2022-05-101-1/+1
| |
| * Add the `update_user_directory_from_worker` configuration option ↵reivilibre2022-05-109-34/+76
| | | | | | | | | | (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. (#12654) Co-authored-by: Shay <hillerys@element.io>
| * Changelog typoDavid Robertson2022-05-101-1/+1
| |
| * Adjust changelogDavid Robertson2022-05-101-25/+29
| |
| * 1.59.0rc1David Robertson2022-05-1065-66/+96
| |
* | Move free functions into PushRuleEvaluatorForEvent. (#12677)Patrick Cloke2022-05-103-34/+69
| | | | | | | | | | | | * Move `_condition_checker` into `PushRuleEvaluatorForEvent`. * Move the condition cache into `PushRuleEvaluatorForEvent`. * Improve docstrings. * Inline a method which is only called once.
* | Add class-diagrams and notes for push. (#12676)Patrick Cloke2022-05-102-0/+80
|/
* Immediately retry any requests that have backed off when a server comes back ↵Erik Johnston2022-05-106-6/+179
| | | | | online. (#12500) Otherwise it can take up to a minute for any in-flight `/send` requests to be retried.
* Implement MSC3786: Add a default push rule to ignore m.room.server_acl ↵Šimon Brandner2022-05-104-11/+56
| | | | | | events (#12601) Fixes vector-im/element-web#20788 Implements matrix-org/matrix-spec-proposals#3786
* Update `replication.md` with info on TCP module structure (#12621)Shay2022-05-093-1/+7
|
* Update SQL statements in docs for Synapse Admins (#12536)Dirk Klimpel2022-05-092-70/+122
|
* Tweaks to workers-under-complement (#12637)Richard van der Hoff2022-05-093-5/+15
| | | | | | | * Bump the HS startup timeout * Log prefixes for more processes * Bump the overall timeout
* Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665)Val Lorentz2022-05-092-1/+2
|
* Implement cancellation support/protection for module callbacks (#12568)Sean Quah2022-05-096-27/+86
| | | | | | | | | | | | There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>
* Fix mypy against latest pillow stubs (#12671)David Robertson2022-05-093-6/+7
|
* Update changelog for #12587 to be more accurate (#12663)Sean Quah2022-05-092-1/+2
| | | | | | #12587 has fallen on the wrong side of the release cutoff to the rest of the related PRs. Signed-off-by: Sean Quah <seanq@element.io>
* Use `ParamSpec` in a few places (#12667)David Robertson2022-05-0914-68/+148
|
* Don't error on unknown receipt types (#12670)Erik Johnston2022-05-092-12/+16
| | | Fixes #12669
* docs(contrib): Add link to documentation in dashboard (#12602)Sheogorath2022-05-092-1/+14
|
* Fix docs on how to run specific Complement tests after recent ↵Eric Eastwood2022-05-092-2/+3
| | | | `complement.sh` change (#12664)
* Use `Concatenate` to annotate `do_execute` (#12666)David Robertson2022-05-093-6/+16
|
* Move `pympler` back into the `all` extras (#12652)David Robertson2022-05-075-6/+15
| | | | | | | | | | | | | * Move `pympler` back into the `all` extras Undoes a change I made in #12381. I can't fully remember my reasoning, but this changed the contents of the debian packages in a backwards incompatible way. We're not aware of anyone who's been bitten by this, but we still want to fix it. To the reviewer: please be convinced that the debian packages will still contain pympler after this change. * Debian changelog entry to keep the linter happy
* Convert stringy power levels to integers on room upgrade (#12657)David Robertson2022-05-075-24/+137
|
* Prevent memory leak from reoccurring when presence is disabled. (#12656)Erik Johnston2022-05-063-28/+54
|
* Update mypy to 0.950 and fix complaints (#12650)David Robertson2022-05-0610-57/+98
|
* Add the `notify_appservices_from_worker` configuration option (superseding ↵reivilibre2022-05-069-21/+447
| | | | `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. (#12452)
* Merge branch 'master' into developAndrew Morgan2022-05-054-2/+27
|\
| * Update v1.58.1 changelog entry with more familiar language v1.58.1Andrew Morgan2022-05-051-2/+2
| |
| * link to relevant bug report in v1.58.1 changelogAndrew Morgan2022-05-051-1/+2
| |
| * Minor wording change to v1.58.1 release notesAndrew Morgan2022-05-051-1/+1
| |
| * 1.58.1Andrew Morgan2022-05-053-3/+15
| |
| * Include extra dependency groups 'systemd' and 'cache_memory' in debian ↵Andrew Morgan2022-05-052-1/+13
| | | | | | | | | | packages (#12640) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Support MSC3266 room summaries over federation (#11507)DeepBlueV7.X2022-05-054-5/+78
| | | | | | | | Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Update `_on_new_receipts()` to work with MSC2285 changes. (#12636)Šimon Brandner2022-05-052-5/+4
| |
* | Improve comments and error messages around access tokens. (#12577)reivilibre2022-05-052-8/+12
| |
* | Use `docker/metadata-action` to generate docker image tags (#12573)Henry2022-05-052-19/+12
| | | | | | | | | | | | | | Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Signed-off-by: Henry <97804910+henryclw@users.noreply.github.com>
* | Use `private` instead of `hidden` in MSC2285 related code. (#12635)Šimon Brandner2022-05-057-25/+26
| |
* | Edits/annotations should not have any bundled aggregations calculated. (#12633)Patrick Cloke2022-05-053-20/+50
| | | | | | | | | | | | Fixes a regression from 8b309adb436c162510ed1402f33b8741d71fc058 (#11660) and b65acead428653b988351ae8d7b22127a22039cd (#11752) where events which themselves were an edit or an annotation could have bundled aggregations calculated, which is not allowed.
* | Remove unused receipt datastore methods. (#12632)Patrick Cloke2022-05-052-54/+1
| | | | | | The last usage was removed in 5a1dd297c3ce105a7f516d9d9fe87b94b9d356c8 (#8059).
* | Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639)Will Hunt2022-05-054-4/+5
| |
* | Reduce log spam when running multiple event persisters (#12610)Erik Johnston2022-05-053-2/+17
| |
* | Add `mau_appservice_trial_days` config (#12619)Will Hunt2022-05-046-2/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add mau_appservice_trial_days * Add a test * Tweaks * changelog * Ensure we sync after the delay * Fix types * Add config statement * Fix test * Reinstate logging that got removed * Fix feature name
* | Use `getClientAddress` instead of `getClientIP`. (#12599)Patrick Cloke2022-05-0416-46/+62
| | | | | | | | | | getClientIP was deprecated in Twisted 18.4.0, which also added getClientAddress. The Synapse minimum version for Twisted is currently 18.9.0, so all supported versions have the new API.
* | Implement changes to MSC2285 (hidden read receipts) (#12168)Šimon Brandner2022-05-0412-186/+647
| | | | | | | | | | * Changes hidden read receipts to be a separate receipt type (instead of a field on `m.read`). * Updates the `/receipts` endpoint to accept `m.fully_read`.
* | Disable device name lookup over federation by default (#12616)Andrew Morgan2022-05-045-12/+24
| |
* | Remove unstable/unspecced login types. (#12597)Patrick Cloke2022-05-046-20/+14
| | | | | | | | | | | | * `m.login.jwt`, which was never specced and has been deprecated since Synapse 1.16.0. (`org.matrix.login.jwt` can be used instead.) * `uk.half-shot.msc2778.login.application_service`, which was stabilized as part of the Matrix spec v1.2 release.
* | Improve logging for cancelled requests (#12587)Sean Quah2022-05-043-1/+32
| | | | | | | | | | | | | | Don't log stack traces for cancelled requests and use a custom HTTP status code of 499. Signed-off-by: Sean Quah <seanq@element.io>
* | Include bundled aggregations for the latest event in a thread. (#12273)Patrick Cloke2022-05-045-51/+198
| | | | | | | | | | | | The `latest_event` field of the bundled aggregations for `m.thread` relations did not include bundled aggregations itself. This resulted in clients needing to immediately request the event from the server (and thus making it useless that the latest event itself was serialized instead of just including an event ID).
* | remove constantly lib use and switch to enums. (#12624)andrew do2022-05-0411-38/+36
| |
* | Fixes to the formatting of README.rst (#12627)Richard van der Hoff2022-05-042-7/+8
| | | | | | Fixes a couple of formatting errors which were introduced in #12475.
* | Add a consistency check on events read from the database (#12620)Richard van der Hoff2022-05-033-22/+50
| | | | | | | | | | | | | | I've seen a few errors which can only plausibly be explained by the calculated event id for an event being different from the ID of the event in the database. It should be cheap to check this, so let's do so and raise an exception.
* | Bump Synapse minimum Python version to 3.7.1 (#12613)David Robertson2022-05-033-3/+4
| |
* | Remove unstable identifiers for MSC3069. (#12596)Patrick Cloke2022-05-033-8/+1
| |
* | Add extra debug logging to federation sender (#12614)Richard van der Hoff2022-05-032-2/+19
| | | | | | | | ... in order to debug some problems we've been having with certain events not being sent when expected.
* | Add missing space before 'docker' link in release announcement script (#12612)Andrew Morgan2022-05-032-1/+2
| |
* | fix importsRichard van der Hoff2022-05-031-1/+2
| | | | | | broken in 5938928 :-S
* | minor wording fix in docstringRichard van der Hoff2022-05-031-3/+2
| |
* | Exclude OOB memberships from the federation sender (#12570)Richard van der Hoff2022-05-033-4/+51
| | | | | | | | | | | | | | As the comment says, there is no need to process such events, and indeed we need to avoid doing so. Fixes #12509.
* | Merge branch 'master' into developAndrew Morgan2022-05-033-3/+15
|\|
| * Move groups/communities deprecation notice to 1.58.0 heading v1.58.0Andrew Morgan2022-05-031-2/+2
| |
| * 1.58.0Andrew Morgan2022-05-033-1/+13
| |
* | Add sanity checks to the release script (#12556)David Robertson2022-05-032-26/+38
| | | | | | | | | | | | | | Check we're on the right branch before tagging, and on the right tag before uploading * Abort if we're on the wrong branch * Check we have the right tag checked out * Clarify that `publish` only releases to GitHub
* | Fix race when persisting an event and deleting a room (#12594)Erik Johnston2022-05-033-2/+22
| | | | | | | | | | This works by taking a row level lock on the `rooms` table at the start of both transactions, ensuring that they don't run at the same time. In the event persistence transaction we also check that there is an entry still in the `rooms` table. I can't figure out how to do this in SQLite. I was just going to lock the table, but it seems that we don't support that in SQLite either, so I'm *really* confused as to how we maintain integrity in SQLite when using `lock_table`....
* | Prune mypy ignore_missing_imports list (#12608)David Robertson2022-05-032-51/+3
| |
* | Remove special-case for `twisted` logger (#12589)Richard van der Hoff2022-04-293-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was originally added when we first added a `MemoryHandler` to the default log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure that we didn't explode with an infinite loop if there was an error formatting the logs. Since then, we made additional improvements to logging which make this workaround redundant. In particular: * we no longer attempt to log un-UTF8-decodable byte sequences, which were the most likely cause of an error in the first place. * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely case that there *is* an error, it won't cause an infinite loop.
* | Allow unused ignores in "bleeding edge" CI (#12576)David Robertson2022-04-293-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Allow unused ignores in "bleeding edge" CI Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs. Follow up from #12531. Resolves #12574. * Use `--extras all` in latest deps mypy CI Twisted trunk job already does this. Missed in #12531. * changelog
* | Improve the docstrings for the receipts store. (#12581)Patrick Cloke2022-04-282-5/+52
| |
* | Use constants for receipt types in tests. (#12582)Šimon Brandner2022-04-284-23/+30
| |
* | Fix logging of incorrect status codes for disconnected requests (#12580)Sean Quah2022-04-284-5/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The status code of requests must always be set, regardless of client disconnection, otherwise they will always be logged as 200!. Broken for `respond_with_json` in f48792eec43f893f4f893ffdcbf00f8958b6f6b5. Broken for `respond_with_json_bytes` in 3e58ce72b42f2ae473c1e76a967548cd6fa7e2e6. Broken for `respond_with_html_bytes` in ea26e9a98b0541fc886a1cb826a38352b7599dbe. Signed-off-by: Sean Quah <seanq@element.io>
* | Add linebreak to pipx install quote in README (#12579)DeepBlueV7.X2022-04-282-2/+3
| |
* | Revert accidental direct-to-develop commits.David Robertson2022-04-283-6/+0
| | | | | | | | | | | | This reverts commit 5a320baa45b8e826e52bdd6cadadfad727ab0357. This reverts commit f282d5fc1185dde3f9ec31c49b630cff962545d7. This reverts commit ce6ecdd4b4939fd99418bc949b40c01d39480489.
* | changelogDavid Robertson2022-04-281-0/+1
| |
* | Use `--extras all` in latest deps mypy CIDavid Robertson2022-04-281-0/+1
| | | | | | | | | | | | Twisted trunk job already does this. Missed in #12531.
* | Allow unused ignores in "bleeding edge" CIDavid Robertson2022-04-282-0/+4
| | | | | | | | | | | | | | Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs. Follow up from #12531. Resolves #12574.
* | Prefer `make_awaitable` over `defer.succeed` in tests (#12505)Sean Quah2022-04-2714-69/+72
| | | | | | | | | | | | | | | | | | | | | | When configuring the return values of mocks, prefer awaitables from `make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable once, so it is inappropriate for a mock to return the same `Deferred` multiple times. Also update `run_in_background` to support functions that return arbitrary awaitables. Signed-off-by: Sean Quah <seanq@element.io>
* | Add a module API to allow modules to edit push rule actions (#12406)Brendan Abolivier2022-04-278-104/+319
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Use supervisord to supervise Postgres and Caddy in the Complement image. ↵reivilibre2022-04-279-12/+44
| | | | | | | | | | (#12480) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Make `scripts-dev` pass `mypy --disallow-untyped-defs` (#12356)David Robertson2022-04-279-53/+96
| | | | | | Not enforced in config yet. One day.
* | Remove unused `# type: ignore`s (#12531)David Robertson2022-04-2721-57/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.
* | Consistently use collections.abc.Mapping to check frozendict. (#12564)Patrick Cloke2022-04-275-9/+11
| |
* | Add option to enable token registration without requiring 3pids (#12526)Will Hunt2022-04-275-2/+25
| |
* | Add some type hints to datastore (#12485)Dirk Klimpel2022-04-2712-84/+188
| |
* | Bound ephemeral events by key (#12544)Nick Mills-Barrett2022-04-264-4/+87
| | | | | | | | Co-authored-by: Brad Murray <bradtgmurray@gmail.com> Co-authored-by: Andrew Morgan <andrewm@element.io>
* | Merge tag 'v1.58.0rc2' into developDavid Robertson2022-04-2659-172/+144
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.58.0rc2 (2022-04-26) ============================== This release candidate fixes bugs related to Synapse 1.58.0rc1's logic for handling device list updates. Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory while handling sentry logging failures. ([\#12554](https://github.com/matrix-org/synapse/issues/12554)) - Fix a bug introduced in Synapse 1.58.0rc1 where opentracing contexts were not correctly sent to whitelisted remote servers with device lists updates. ([\#12555](https://github.com/matrix-org/synapse/issues/12555)) Internal Changes ---------------- - Reduce unnecessary work when handling remote device list updates. ([\#12557](https://github.com/matrix-org/synapse/issues/12557))
| * Adjust changelog v1.58.0rc2David Robertson2022-04-261-1/+1
| |
| * Credit Tulir's contribution in 1.58.0rc1 to Beeper, tooDavid Robertson2022-04-261-1/+1
| |
| * 1.58.0rc2David Robertson2022-04-266-4/+25
| |
| * Mark remote device list updates as already handled (#12557)Erik Johnston2022-04-264-4/+7
| |
| * Comment out dodgy log-kv (#12554)David Robertson2022-04-262-3/+7
| |
| * Fix sending opentracing contexts to remote servers (#12555)Erik Johnston2022-04-262-1/+12
| |
| * Unbold deprecation: it is mentioned at the top v1.58.0rc1David Robertson2022-04-261-1/+1
| |
| * Lint the release scriptDavid Robertson2022-04-261-1/+0
| |
| * Another set of changelog updatesDavid Robertson2022-04-261-3/+5
| |
| * We don't require redbaron in the release scriptDavid Robertson2022-04-262-62/+1
| |
| * Changelog updateDavid Robertson2022-04-261-23/+16
| |
| * 1.58.0rc1David Robertson2022-04-2654-55/+81
| |
| * Temporarily lower debian changelog version numberDavid Robertson2022-04-261-1/+1
| | | | | | | | This seems to make dch happy when we prepare the release.
| * Update release script to be poetry-awareDavid Robertson2022-04-261-47/+21
| | | | | | | | Poetry now manages the project version in pyproject.toml.
* | Mark Dockerfile as requiring BuildKit (#12541)Jason Robinson2022-04-262-0/+2
|/ | | Co-authored-by: David Robertson <davidr@element.io>
* build debian package for jammy jellyfish (#12543)Shay2022-04-262-0/+2
|
* Optimise backfill calculation (#12522)Richard van der Hoff2022-04-265-106/+168
| | | | | | Try to avoid an OOM by checking fewer extremities. Generally this is a big rewrite of _maybe_backfill, to try and fix some of the TODOs and other problems in it. It's best reviewed commit-by-commit.
* Add a table of contents to config manual (#12527)Shay2022-04-252-2/+46
| | | * Update config_documentation.md
* Handle cancellation in `EventsWorkerStore._get_events_from_cache_or_db` (#12529)Sean Quah2022-04-253-36/+169
| | | | | | | | Multiple calls to `EventsWorkerStore._get_events_from_cache_or_db` can reuse the same database fetch, which is initiated by the first call. Ensure that cancelling the first call doesn't cancel the other calls sharing the same database fetch. Signed-off-by: Sean Quah <seanq@element.io>
* Correct typo in user_admin_api.md device deletion JSON (#12533)Sami Olmari2022-04-252-1/+2
| | | | Signed-off-by: Sami Olmari <sami@olmari.fi>
* disallow-untyped-defs in `docker` and `stubs` directories (#12528)David Robertson2022-04-257-38/+52
|
* Misc. clean-ups to the relations code (#12519)Patrick Cloke2022-04-254-103/+68
| | | | | * Corrects some typos / copy & paste errors in tests. * Clarifies docstrings. * Removes an unnecessary method.
* Add HAProxy delegation example to docs (#12501)villepeh2022-04-252-0/+23
| | | Signed-off-by: Ville Petteri Huh
* Add some example configurations for worker (#12492)Dirk Klimpel2022-04-255-24/+56
| | | Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* Update `delay_cancellation` to accept any awaitable (#12468)Sean Quah2022-04-224-14/+75
| | | | | | | | This will mainly be useful when dealing with module callbacks, which are all typed as returning `Awaitable`s instead of coroutines or `Deferred`s. Signed-off-by: Sean Quah <seanq@element.io>
* MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types ↵Will Hunt2022-04-223-2/+3
| | | | | | | (#12520) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog
* turn-howto: fix some linksRichard van der Hoff2022-04-221-2/+2
|
* Await un-partial-stating after a partial-state join (#12399)Richard van der Hoff2022-04-2110-6/+291
| | | | | | When we join a room via the faster-joins mechanism, we end up with "partial state" at some points on the event DAG. Many parts of the codebase need to wait for the full state to load. So, we implement a mechanism to keep track of which events have partial state, and wait for them to be fully-populated.
* Remove leftover references to setup.py (#12514)David Robertson2022-04-203-3/+4
| | | | | | | * Remove leftover references to setup.py Missed in #12478. * Changelog
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-204-5/+30
|\
| * Clarify changelog entry v1.57.1Olivier Wilkinson (reivilibre)2022-04-201-2/+4
| |
| * 1.57.1Olivier Wilkinson (reivilibre)2022-04-205-3/+21
| |
| * Include version 0.2.0 of the Synapse LDAP Auth Provider module in the Docker ↵reivilibre2022-04-202-4/+9
| | | | | | | | | | | | | | | | | | image. (#12512) * poetry update matrix-synapse-ldap3 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Dump setuptools; correct pyproject version number (#12478)David Robertson2022-04-2013-412/+11
| |
* | Fix Jinja templating error when generating thumbnail URLs. (#12510)Patrick Cloke2022-04-202-1/+2
| | | | | | scale is meant to be a constant string, not refer to a variable.
* | Recommend poetry in docs (#12475)David Robertson2022-04-205-50/+301
| | | | | | | | | | | | | | | | | | | | | | * Recommend poetry in docs - readme - contributor guide - upgrade notes - new dev cheat sheet for poetry Co-authored-by: Shay <hillerys@element.io> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Remove unnecessary config overrides for MSC3666. (#12511)Patrick Cloke2022-04-202-4/+1
| |
* | Implement MSC2815: allow room moderators to view redacted event content (#12427)Tulir Asokan2022-04-207-3/+100
| | | | | | | | | | | | Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>
* | Add CI job to act as a canary for testing against latest dependencies (#12472)David Robertson2022-04-203-0/+161
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix returned count of delete extremities admin API (#12496)Erik Johnston2022-04-192-3/+6
| |
* | Fix `/room/.../event/...` to return the *original* event after any edits ↵Richard van der Hoff2022-04-194-39/+79
| | | | | | | | | | | | (#12476) This is what the MSC (now) requires. Fixes https://github.com/matrix-org/synapse/issues/10310.
* | Fix typo in deb changelogs from release script (#12497)Richard van der Hoff2022-04-192-1/+2
| | | | | | | | The release script used to incorrectly write `New synapse release 1.57.0~rc1.` instead of `New synapse release 1.57.0rc1.`
* | Implement MSC3383: include destination in X-Matrix auth header (#11398)Jan Christian Grünhage2022-04-194-11/+48
| | | | | | | | Co-authored-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz> Co-authored-by: Marcus Hoffmann <bubu@bubu1.eu>
* | Fix a link in `README.rst` (#12495)Dirk Klimpel2022-04-192-1/+2
| | | | | | | | | | * Fix a link in `README.rst` * newsfile
* | fix typo in debian changelogRichard van der Hoff2022-04-191-1/+1
| |
* | Remove 'Non-maintainer upload' line from Debian changelogOlivier Wilkinson (reivilibre)2022-04-191-1/+0
| |
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-195-6/+18
|\|
| * Link to specific version of upgrade notes v1.57.0Olivier Wilkinson (reivilibre)2022-04-191-1/+1
| |
| * fix typo in upgrade notesRichard van der Hoff2022-04-191-1/+1
| |
| * 1.57.0Olivier Wilkinson (reivilibre)2022-04-194-4/+16
| |
* | Back out implementation of MSC2314 (#12474)Richard van der Hoff2022-04-195-61/+13
| | | | | | | | | | | | | | | | MSC2314 has now been closed, so we're backing out its implementation, which originally happened in #6176. Unfortunately it's not a direct revert, as that PR mixed in a bunch of unrelated changes to tests etc.
* | Fix grammatical error in error message (#12483)Travis Ralston2022-04-182-1/+2
| | | | | | | | | | * Fix grammatical error in error message * changelog
* | Add a manual documenting config file options (#12368)Shay2022-04-183-0/+3414
| |
* | Dockerfile-workers: reduce the amount we install (#12464)Richard van der Hoff2022-04-144-13/+27
| | | | | | | | This is an attempt to reduce the rebuild time. In short, we reduce the amount of stuff that the dockerfile installs, so as to give a faster startup.
* | Update documentation to reflect that `run_background_tasks_on` is no longer ↵reivilibre2022-04-142-4/+5
| | | | | | | | | | | | | | | | | | | | | | experimental. (#12451) * Background workers aren't experimental anymore * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Stream writers aren't experimental either
* | complement-synapse-workers: factor out separate entry point script (#12467)Richard van der Hoff2022-04-143-33/+58
| | | | | | ... with a bit more verbosity.
* | Replace `federation_reader` with `generic_worker` in docs (#12457)Dirk Klimpel2022-04-145-24/+23
| |
* | Only send out device list updates for our own users (#12465)Erik Johnston2022-04-145-8/+56
| | | | | | Broke in #12365
* | Reintroduce the lint targets in the linter script (#12455)David Robertson2022-04-143-41/+30
| |
* | Use `poetry` to manage the virtualenv in debian packages (#12449)David Robertson2022-04-144-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use `poetry` to build venv in debian packages Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io> * Changelog * Only pull in from requirements.txt Addresses the same problem as #12439. * Include `test` and `all` extras `poetry export` helpfully silently ignores an unknown extra Haven't seen this before because it's the only place we export `all` and `test`. I could have __sworm__ that the syntax `--extra "all test"` worked for `poetry install`... * Clean up requirements file on subsequence builds * Fix shell syntax Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io>
* | Dockerfile-workers: give the master its own log config (#12466)Richard van der Hoff2022-04-132-17/+32
| | | | | | | | | | | | | | | | | | | | | | When we run a worker-mode synapse under docker, everything gets logged to stdout. Currently, output from the workers is tacked with a worker name, for example: ``` 2022-04-13 15:27:56,810 - worker:frontend_proxy1 - synapse.util.caches.lrucache - 154 - INFO - LruCache._expire_old_entries-0 - Dropped 0 items from caches ``` - note `worker:frontend_proxy1`. No such tag is applied to log lines from the master, which makes somewhat confusing reading. To fix this, we generate a dedicated log config file for the master in the same way that we do for the workers, and use that.
* | Limit `device_id` size to 512B (#12454)Shay2022-04-133-1/+36
| | | | | | *
* | docs: Don't render the table of contents on the print page (#12340)Andrew Morgan2022-04-132-0/+15
| |
* | Prevent a sync request from removing a user's busy presence status (#12213)David Baker2022-04-135-18/+133
| | | | | | | | | | | | | | | | | | | | In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.
* | Fix missing sync events during historical batch imports (#12319)Nick Mills-Barrett2022-04-135-19/+162
| | | | | | | | | | | | | | | | Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com
* | Use poetry lockfile in twisted trunk CI job (#12425)David Robertson2022-04-133-20/+35
| | | | | | | | | | | | Fixes #12458 Co-authored-by: Sean Quah <seanq@element.io> Co-authored-by: Dan Callahan <danc@element.io>
* | Rename Mutual Rooms `unstable_features` flag to match MSC (#12445)Jonathan de Jong2022-04-132-1/+2
| | | | | | Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* | Bump twisted version to the latest in lockfile (#12441)Shay2022-04-122-9/+11
| |
* | Run "main" trial tests under poetry (#12438)David Robertson2022-04-122-13/+14
| | | | | | | | | | | | | | | | | | | | | | * Run "main" trial tests under poetry Olddeps and twisted trunk tests are handled in separate PRs. The PyPy config is a best-effort only; it's completely untested. Pulled out from #12337. * Changelog
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-22 04:30:24 +0000