summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'release-v1.64' into developOlivier Wilkinson (reivilibre)2022-07-2673-73/+95
|\
| * Explain less-known term 'Implicit TLS' v1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-261-1/+1
| |
| * Tweak changelog in response to reviewOlivier Wilkinson (reivilibre)2022-07-261-9/+7
| |
| * Tweak changelogOlivier Wilkinson (reivilibre)2022-07-261-9/+11
| |
| * 1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-2673-73/+95
| |
* | Remove the unspecced `room_id` field in the `/hierarchy` response. (#13365)Patrick Cloke2022-07-262-1/+1
| | | | | | | | | | | | | | | | | | The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
* | Fix infinite loop in partial-state resync (#13353)Richard van der Hoff2022-07-263-8/+27
| | | | | | | | | | Make sure that we only pull out events from the db once they have no prev-events with partial state.
* | Faster room joins: avoid blocking when pulling events with missing prevs ↵Sean Quah2022-07-268-33/+124
| | | | | | | | | | | | | | | | | | (#13355) Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Remove unused argument for get_relations_for_event. (#13383)Patrick Cloke2022-07-263-9/+1
|/
* Disable autocorrect and autocaptialisation when entering username for SSO ↵Doug2022-07-262-1/+2
| | | | | registration. (#13350) When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).
* Update Caddy reverse proxy documentation (#13344)Matt Holt2022-07-252-42/+12
| | | | | Improve/simplify Caddy examples. Remove Caddy v1 (has long been EOL'ed) Signed-off-by: Matthew Holt <mholt@users.noreply.github.com>
* Support Implicit TLS for sending emails (#13317)Jan Schär2022-07-255-13/+99
| | | | | | | | | | Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>
* Additional fixes for opentracing type hints. (#13362)Patrick Cloke2022-07-252-2/+3
|
* Refactor presence so we can prune user in room caches (#13313)Erik Johnston2022-07-254-91/+109
| | | | | | | | See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.
* Backfill remote event fetched by MSC3030 so we can paginate from it later ↵Eric Eastwood2022-07-223-15/+94
| | | | | | | | | (#13205) Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848
* Update config_documentation.md (#13364)Richard van der Hoff2022-07-221-2/+2
| | | "changed in" goes before the example
* Update locked frozendict version to 2.3.3 (#13352)Sean Quah2022-07-223-18/+28
| | | frozendict 2.3.3 includes fixes for memory leaks that get triggered during `/sync`.
* Skip soft fail checks for rooms with partial state (#13354)Sean Quah2022-07-222-0/+11
| | | | | | | | | | | | When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>
* Remove old empty/redundant slaved stores. (#13349)Nick Mills-Barrett2022-07-2112-238/+63
|
* Make DictionaryCache have better expiry properties (#13292)Erik Johnston2022-07-217-43/+358
|
* Don't hold onto full state in state cache (#13324)Erik Johnston2022-07-212-15/+54
|
* Call out buildkit is required when building test docker images (#13338)Brendan Abolivier2022-07-214-0/+7
| | | Co-authored-by: David Robertson <davidr@element.io>
* Track DB txn times w/ two counters, not histogram (#13342)David Robertson2022-07-212-3/+6
|
* Add missing types to opentracing. (#13345)Patrick Cloke2022-07-2114-45/+83
| | | After this change `synapse.logging` is fully typed.
* Use cache store remove base slaved (#13329)Nick Mills-Barrett2022-07-2116-114/+39
| | | This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
* Merge branch 'master' into developDavid Robertson2022-07-212-0/+9
|\
| * Document `rc_invites.per_issuer`, added in v1.63.David Teller2022-07-212-0/+9
| | | | | | | | | | | | | | Resolves #13330. Missed in #13125. Signed-off-by: David Teller <davidt@element.io>
* | Update `get_pdu` to return the original, pristine `EventBase` (#13320)Eric Eastwood2022-07-205-61/+233
| | | | | | | | | | | | | | | | | | | | | | | | Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
* | Validate federation destinations and log an error if server name is invalid. ↵Shay2022-07-203-2/+12
| | | | | | | | (#13318)
* | Merge remote-tracking branch 'origin/master' into developErik Johnston2022-07-205-2/+110
|\|
| * 1.63.1 v1.63.1Erik Johnston2022-07-204-2/+16
| |
| * Don't include appservice users when calculating push rules (#13332)Erik Johnston2022-07-203-0/+93
| | | | | | This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
* | Fix spurious warning when fetching state after a missing prev event (#13258)Sean Quah2022-07-192-0/+4
| |
* | Add type annotations to `trace` decorator. (#13328)Patrick Cloke2022-07-1912-55/+102
| | | | | | | | Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
* | Merge branch 'master' into developBrendan Abolivier2022-07-1911-32/+55
|\|
| * Improve precision on validation improvements v1.63.0Brendan Abolivier2022-07-191-1/+1
| |
| * 1.63.0Brendan Abolivier2022-07-194-4/+13
| |
| * Remove 'anonymised' from the phone home stats documentation (#13321)Andrew Morgan2022-07-1911-30/+44
| |
* | Reduce memory usage of state group cache (#13323)Erik Johnston2022-07-192-1/+3
| |
* | Stop building Ubuntu 21.10 (Impish Indri) which is end of life. (#13326)Patrick Cloke2022-07-192-1/+1
| |
* | Bash script for creating multiple stream writers (#13271)villepeh2022-07-193-1/+147
| | | | | | | | | | Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.
* | Add notes when config options were changed to config documentation (#13314)Jörg Behrmann2022-07-192-0/+6
| | | | | | | | Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
* | Rate limit joins per-room (#13276)David Robertson2022-07-1918-15/+498
| |
* | Safe async event cache (#13308)Nick Mills-Barrett2022-07-198-21/+102
| | | | | | | | | | | | | | | | Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
* | Increase batch size of `bulk_get_push_rules` and ↵Shay2022-07-183-1/+3
| | | | | | | | `_get_joined_profiles_from_event_ids`. (#13300)
* | Improve performance of query ` _get_subset_users_in_room_with_profiles` (#13299)Shay2022-07-182-1/+2
| |
* | Fix overcounting of pushers when they are replaced (#13296)Sean Quah2022-07-182-11/+17
| | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | Up the dependency on canonicaljson to ^1.5.0 (#13172)Brendan Abolivier2022-07-183-2/+5
| | | | | | Co-authored-by: David Robertson <davidr@element.io>
* | Prevent #3679 from appearing in blame results (#13311)Andrew Morgan2022-07-182-0/+14
| |
* | Revert "Make all `process_replication_rows` methods async (#13304)" (#13312)Erik Johnston2022-07-1814-40/+25
| | | | | | This reverts commit 5d4028f217f178fcd384d5bfddd92225b4e78c51.
* | Don't pull out full state when sending dummy events (#13310)Erik Johnston2022-07-182-7/+2
| |
* | Use READ COMMITTED isolation level when purging rooms (#12942)Nick Mills-Barrett2022-07-182-2/+32
| | | | | | | | | | To close: #10294. Signed off by Nick @ Beeper.
* | Update expected DB query count when creating a room (#13307)Andrew Morgan2022-07-182-2/+3
| |
* | Don't pull out the full state when creating an event (#13281)Erik Johnston2022-07-183-2/+10
| |
* | Remove unnecessary `json.dumps` from tests (#13303)Dirk Klimpel2022-07-1713-200/+143
| |
* | Make all `process_replication_rows` methods async (#13304)Nick Mills-Barrett2022-07-1714-25/+40
| | | | | | | | | | More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
* | Use HTTPStatus constants in place of literals in tests. (#13297)Dirk Klimpel2022-07-159-238/+308
| |
* | Provide more info why we don't have any thumbnails to serve (#13038)Eric Eastwood2022-07-154-17/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
* | Use and recommend poetry 1.1.14, up from 1.1.12 (#13285)David Robertson2022-07-155-4/+30
| |
* | Don't pull out the full state when storing state (#13274)Erik Johnston2022-07-156-71/+132
| |
* | Use a real room in the notification rotation tests. (#13260)Patrick Cloke2022-07-152-116/+80
| | | | | | | | Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
* | Use state before join to determine if we `_should_perform_remote_join` (#13270)David Robertson2022-07-154-24/+35
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Update locked frozendict version to 2.3.2 (#13284)Sean Quah2022-07-152-18/+19
| | | | | | | | | | | | | | | | `frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Bg update to populate new `events` table columns (#13215)Richard van der Hoff2022-07-153-0/+135
| | | | | | | | | | These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
* | Fix a bug which could lead to incorrect state (#13278)Erik Johnston2022-07-154-7/+58
| | | | | | | | | | There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
* | Docker: copy postgres from base image (#13279)Richard van der Hoff2022-07-153-34/+51
| | | | | | | | | | | | When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.
* | Async get event cache prep (#13242)Nick Mills-Barrett2022-07-1511-26/+86
| | | | | | | | | | Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
* | Federation Sender & Appservice Pusher Stream Optimisations (#13251)Nick Mills-Barrett2022-07-157-87/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | * Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
* | Rip out auth-event reconciliation code (#12943)Richard van der Hoff2022-07-146-375/+88
| | | | | | | | | | | | | | There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
* | CHANGES.md: fix link to upgrade notesRichard van der Hoff2022-07-141-1/+1
| |
* | Don't pull out state in `compute_event_context` for unconflicted state (#13267)Erik Johnston2022-07-147-136/+95
| |
* | Allow rate limiters to passively record actions they cannot limit (#13253)David Robertson2022-07-133-12/+157
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Notifier: accept callbacks to fire on room joins (#13254)David Robertson2022-07-132-0/+19
| |
* | Call the v2 identity service `/3pid/unbind` endpoint, rather than v1. (#13240)Jacek Kuśnierz2022-07-132-2/+3
| | | | | | | | | | | | | | | | | | | | | | * Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
* | Add support for room version 10 (#13220)Shay2022-07-134-1/+100
| |
* | Document advising against publicly exposing the Admin API and provide a ↵jejo862022-07-132-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | usage example (#13231) * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett2022-07-134-19/+78
| |
* | Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke2022-07-133-44/+33
| |
* | Add prometheus counters for content types other than events (#13175)Brad Murray2022-07-132-0/+15
| |
* | Drop unused tables from groups/communities. (#12967)Patrick Cloke2022-07-134-19/+36
| | | | | | | | These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
* | Do not fail build if complement with workers fails. (#13266)Patrick Cloke2022-07-132-3/+25
| |
* | Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston2022-07-133-0/+37
| | | | | | | | | | | | (#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Inline URL preview documentation. (#13261)Patrick Cloke2022-07-127-74/+62
| | | | | | Inline URL preview documentation near the implementation.
* | Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2022-07-122-0/+18
| | | | | | This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
* | Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz2022-07-123-26/+11
| | | | | | | | | | | | | | `id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* | Rename test case method to `add_hashes_and_signatures_from_other_server` ↵David Robertson2022-07-127-18/+14
| | | | | | | | (#13255)
* | Drop support for delegating email validation (#13192)Richard van der Hoff2022-07-1213-253/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
* | Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2022-07-122-0/+2
| | | | | | | | The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
* | Add info about configuration in the url preview docs (#13233)Shay2022-07-122-0/+3
| | | | | | Cross-link doc pages for easier navigation.
* | Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2022-07-122-2/+9
| | | | | | | | | | | | | | | | token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
* | expose whether a room is a space in the Admin API (#13208)andrew do2022-07-124-13/+36
|/
* Update changelog once more v1.63.0rc1Sean Quah2022-07-121-2/+2
|
* Reorder and tidy up changelogSean Quah2022-07-121-29/+25
|
* 1.63.0rc1Sean Quah2022-07-1254-54/+87
|
* Don't pull out the full state when calculating push actions (#13078)Erik Johnston2022-07-117-344/+164
|
* Add a sample bash script to docs for creating multiple worker files (#13032)villepeh2022-07-112-0/+32
| | | Signed-off-by: Ville Petteri Huh.
* Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett2022-07-113-2/+32
| | | | | | | | Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
* Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller2022-07-1112-60/+426
| | | | | | return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2022-07-112-2/+4
| | | | The field name was simply incorrect, leading to errors.
* Remove delay when rotating event push actions (#13211)Erik Johnston2022-07-112-3/+2
| | | | We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
* Document the 'databases' homeserver config option (#13212)Andrew Morgan2022-07-112-0/+93
|
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-113-138/+400
|
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2022-07-112-1/+4
| | | | | | | | | | | * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
* Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2022-07-112-1/+5
|
* editorconfig: add max_line_length for Python files (#13228)Sumner Evans2022-07-082-0/+2
| | | | | | See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>
* Fix notification count after a highlighted message (#13223)Erik Johnston2022-07-083-3/+16
| | | | | Fixes #13196 Broke by #13005
* Fix exception when using MSC3030 to look for remote federated events before ↵Eric Eastwood2022-07-072-1/+6
| | | | | | | | | | | | | | | | room creation (#13197) Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```
* Add --build-only option to complement.sh to prevent actually running ↵reivilibre2022-07-072-3/+19
| | | | Complement. (#13158)
* Remove obsolete RoomEventsStoreTestCase (#13200)Petr Vaněk2022-07-072-69/+1
| | | | | | | | | | All tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b3c508 - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
* Faster room joins: fix race in recalculation of current room state (#13151)Sean Quah2022-07-078-55/+214
| | | | | | | | | | | Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>
* Use a single query in `ProfileHandler.get_profile` (#13209)Nick Mills-Barrett2022-07-072-12/+8
|
* Bump lxml from 4.8.0 to 4.9.1 (#13207)dependabot[bot]2022-07-072-62/+72
| | | | Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>
* Check that `auto_vacuum` is disabled when porting a SQLite database to ↵reivilibre2022-07-073-0/+43
| | | | Postgres, as `VACUUM`s must not be performed between runs of the script. (#13195)
* Make `_get_state_map_for_room` not break when room state events don't ↵David Teller2022-07-072-8/+2
| | | | | contain an event id. (#13174) Method `_get_state_map_for_room` seems to break in presence of some ill-formed events in the database. Reimplementing this method to use `get_current_state`, which is more robust to such events.
* Add information on how the Synapse team does reviews. (#13132)Patrick Cloke2022-07-064-1/+47
|
* Fix bug where we failed to delete old push actions (#13194)Erik Johnston2022-07-062-2/+5
| | | This happened if we encountered a stream ordering in `event_push_actions` that had more rows than the batch size of the delete, as If we don't delete any rows in an iteration then the next time round we get the exact same stream ordering and get stuck.
* Handle race between persisting an event and un-partial stating a room (#13100)Sean Quah2022-07-0510-74/+234
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Whenever we want to persist an event, we first compute an event context, which includes the state at the event and a flag indicating whether the state is partial. After a lot of processing, we finally try to store the event in the database, which can fail for partial state events when the containing room has been un-partial stated in the meantime. We detect the race as a foreign key constraint failure in the data store layer and turn it into a special `PartialStateConflictError` exception, which makes its way up to the method in which we computed the event context. To make things difficult, the exception needs to cross a replication request: `/fed_send_events` for events coming over federation and `/send_event` for events from clients. We transport the `PartialStateConflictError` as a `409 Conflict` over replication and turn `409`s back into `PartialStateConflictError`s on the worker making the request. All client events go through `EventCreationHandler.handle_new_client_event`, which is called in *a lot* of places. Instead of trying to update all the code which creates client events, we turn the `PartialStateConflictError` into a `429 Too Many Requests` in `EventCreationHandler.handle_new_client_event` and hope that clients take it as a hint to retry their request. On the federation event side, there are 7 places which compute event contexts. 4 of them use outlier event contexts: `FederationEventHandler._auth_and_persist_outliers_inner`, `FederationHandler.do_knock`, `FederationHandler.on_invite_request` and `FederationHandler.do_remotely_reject_invite`. These events won't have the partial state flag, so we do not need to do anything for then. The remaining 3 paths which create events are `FederationEventHandler.process_remote_join`, `FederationEventHandler.on_send_membership_event` and `FederationEventHandler._process_received_pdu`. We can't experience the race in `process_remote_join`, unless we're handling an additional join into a partial state room, which currently blocks, so we make no attempt to handle it correctly. `on_send_membership_event` is only called by `FederationServer._on_send_membership_event`, so we catch the `PartialStateConflictError` there and retry just once. `_process_received_pdu` is called by `on_receive_pdu` for incoming events and `_process_pulled_event` for backfill. The latter should never try to persist partial state events, so we ignore it. We catch the `PartialStateConflictError` in `on_receive_pdu` and retry just once. Refering to the graph of code paths in https://github.com/matrix-org/synapse/issues/12988#issuecomment-1156857648 may make the above make more sense. Signed-off-by: Sean Quah <seanq@matrix.org>
* Type `tests.utils` (#13028)David Robertson2022-07-055-46/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Cast to postgres types when handling postgres db * Remove unused method * Easy annotations * Annotate create_room * Use `ParamSpec` to annotate looping_call * Annotate `default_config` * Track `now` as a float `time_ms` returns an int like the proper Synapse `Clock` * Introduce a `Timer` dataclass * Introduce a Looper type * Suppress checking of a mock * tests.utils is typed * Changelog * Whoops, import ParamSpec from typing_extensions * ditch the psycopg2 casts
* Factor out some common Complement CI setup commands to a script. (#13157)reivilibre2022-07-054-47/+42
|
* Use upserts for updating `event_push_summary` (#13153)Erik Johnston2022-07-052-40/+8
|
* Merge branch 'master' into developDavid Robertson2022-07-053-1/+15
|\
| * Mention the spamchecker plugins v1.62.0David Robertson2022-07-051-0/+2
| |
| * 1.62.0David Robertson2022-07-053-1/+13
| |
* | Fix application service not being able to join remote federated room without ↵Eric Eastwood2022-07-052-9/+24
| | | | | | | | | | | | | | a profile set (#13131) Fix https://github.com/matrix-org/synapse/issues/4778 Complement tests: https://github.com/matrix-org/complement/pull/399
* | Add the ability to set the log level using the `SYNAPSE_TEST_LOG_LEVEL` ↵reivilibre2022-07-056-6/+44
| | | | | | | | environment when using `complement.sh`. (#13152)
* | Add missing links to config options (#13166)Dirk Klimpel2022-07-052-3/+4
| |
* | annotate tests.server.FakeChannel (#13136)David Robertson2022-07-047-26/+36
| |
* | Revert "Up the dependency on canonicaljson to ^1.5.0"Brendan Abolivier2022-07-041-3/+1
| | | | | | | | This reverts commit dcc4e0621cc101271efc573600bd7591a12cea7c.
* | Up the dependency on canonicaljson to ^1.5.0Brendan Abolivier2022-07-041-1/+3
| |
* | Merge tag 'v1.62.0rc3' into developAndrew Morgan2022-07-046-12/+33
|\| | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc3 (2022-07-04) ============================== Bugfixes -------- - Update the version of the [ldap3 plugin](https://github.com/matrix-org/matrix-synapse-ldap3/) included in the `matrixdotorg/synapse` DockerHub images and the Debian packages hosted on `packages.matrix.org` to 0.2.1. This fixes [a bug](https://github.com/matrix-org/matrix-synapse-ldap3/pull/163) with usernames containing uppercase characters. ([\#13156](https://github.com/matrix-org/synapse/issues/13156)) - Fix a bug introduced in Synapse 1.62.0rc1 affecting unread counts for users on small servers. ([\#13168](https://github.com/matrix-org/synapse/issues/13168))
| * Update changelog for v1.62.0rc2 v1.62.0rc3Andrew Morgan2022-07-041-2/+2
| |
| * 1.62.0rc3Andrew Morgan2022-07-045-3/+17
| |
| * Fix stuck notification counts on small servers (#13168)Erik Johnston2022-07-043-7/+13
| |
| * matrix-synapse-ldap3: 0.2.0 -> 0.2.1 (#13156)David Robertson2022-07-012-4/+5
| |
* | Remove tests/utils.py from mypy's exclude list (#13159)Andrew Morgan2022-07-044-4/+3
| |
* | [Complement] Allow device_name lookup over federation (#13167)Till2022-07-042-0/+3
| |
* | Enable Complement testing in the 'Twisted Trunk' CI runs. (#13079)reivilibre2022-07-014-2/+82
| |
* | complement.sh: Permit skipping docker build (#13143)Richard van der Hoff2022-07-012-18/+55
| | | | | | Add a `-f` argument to `complement.sh` to skip the docker build
* | Merge tag 'v1.62.0rc2' into developAndrew Morgan2022-07-015-3/+17
|\| | | | | | | | | | | | | | | | | | | | | Synapse 1.62.0rc2 (2022-07-01) ============================== Bugfixes -------- - Fix unread counts for users on large servers. Introduced in v1.62.0rc1. ([\#13140](https://github.com/matrix-org/synapse/issues/13140)) - Fix DB performance when deleting old push notifications. Introduced in v1.62.0rc1. ([\#13141](https://github.com/matrix-org/synapse/issues/13141))
| * 1.62.0rc2 v1.62.0rc2Andrew Morgan2022-07-015-3/+17
| |
* | Extra validation for rest/client/account_data (#13148)David Robertson2022-07-012-2/+18
| | | | | | | | | | | | | | * Extra validation for rest/client/account_data This is a fairly simple endpoint and we did pretty well here. * Changelog
* | `_process_received_pdu`: Improve exception handling (#13145)Richard van der Hoff2022-07-012-7/+7
| | | | | | | | `_check_event_auth` is expected to raise `AuthError`s, so no need to log it again.
* | Skip waiting for full state for incoming events (#13144)Richard van der Hoff2022-07-013-4/+13
| | | | | | | | | | When we receive an event over federation during a faster join, there is no need to wait for full state, since we have a whole reconciliation process designed to take the partial state into account.
* | Add documentation for phone home stats (#13086)Andrew Morgan2022-06-303-0/+83
| |
* | Allow dependency errors to pass through (#13113)Jacek Kuśnierz2022-06-308-58/+16
| | | | | | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge remote-tracking branch 'origin/release-v1.62' into developPatrick Cloke2022-06-306-33/+64
|\|
| * Fix unread counts on large servers (#13140)Erik Johnston2022-06-303-29/+32
| |
| * Add index to help delete old push actions (#13141)Erik Johnston2022-06-304-4/+32
| |
* | Don't process /send requests for users who have hit their ratelimit (#13134)Shay2022-06-302-0/+4
| |
* | Cleanup references to sample config in the docs and redirect users to ↵Shay2022-06-3012-89/+73
| | | | | | | | configuration manual (#13077)
* | Add a link to the configuration manual from the homeserver sample config ↵Andrew Morgan2022-06-302-0/+4
| | | | | | | | documentation page (#13139)
* | More type hints for `synapse.logging` (#13103)Patrick Cloke2022-06-305-46/+56
| | | | | | | | Completes type hints for synapse.logging.scopecontextmanager and (partially) for synapse.logging.opentracing.
* | Improve startup times in Complement test runs against workers, particularly ↵reivilibre2022-06-309-51/+243
| | | | | | | | | | in CPU-constrained environments. (#13127) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Actually typecheck `tests.test_server` (#13135)David Robertson2022-06-302-1/+1
| |
* | Rate limiting invites per issuer (#13125)David Teller2022-06-303-2/+24
| | | | | | Co-authored-by: reivilibre <oliverw@matrix.org>
* | Don't actually one-line the SQL statements we send to the DB (#13129)Brendan Abolivier2022-06-302-3/+5
| |
* | Implement MSC3827: Filtering of `/publicRooms` by room type (#13031)Šimon Brandner2022-06-2911-13/+345
| | | | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Fix documentation header for `allow_public_rooms_over_federation` (#13116)Moritz Stückler2022-06-292-1/+2
| | | | | | | | Signed-off-by: Moritz Stückler <moritz.stueckler@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Improve performance of getting unread counts in rooms (#13119)Erik Johnston2022-06-296-4/+40
| |
* | Document the `--report-stats` argument (#13029)jejo862022-06-292-1/+4
|/ | | Signed-off-by: jejo86 <28619134+jejo86@users.noreply.github.com>
* Merge branch 'develop' into release-v1.62 v1.62.0rc1Andrew Morgan2022-06-281-1/+2
|\
| * fix linting error from the 1.61.1 main -> develop mergeAndrew Morgan2022-06-281-1/+2
| |
* | 1.62.0rc1Andrew Morgan2022-06-2880-80/+102
|/
* Merge branch 'master' into developAndrew Morgan2022-06-285-25/+84
|\
| * Linkify GHSA commit v1.61.1Andrew Morgan2022-06-281-1/+1
| |
| * 1.61.1Andrew Morgan2022-06-283-1/+28
| |
| * Merge pull request from GHSA-22p3-qrh9-cx32reivilibre2022-06-282-24/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Make _iterate_over_text easier to read by using simple data structures * Prefer a set of tags to ignore In my tests, it's 4x faster to check for containment in a set of this size * Add a stack size limit to _iterate_over_text * Continue accepting the case where there is no body element * Use an early return instead for None Co-authored-by: Richard van der Hoff <richard@matrix.org>
* | Fix serialization errors when rotating notifications (#13118)Erik Johnston2022-06-285-83/+202
| |
* | Extra type annotations in `test_server` (#13124)David Robertson2022-06-283-37/+48
| |
* | Remove unspecced DELETE endpoint that modifies room visibility (#13123)santhoshivan232022-06-282-11/+1
| |
* | Update MSC3786 implementation: Check the `state_key` (#12939)Šimon Brandner2022-06-272-1/+8
| | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Add Cross-Origin-Resource-Policy header to thumbnail and download media ↵Robert Long2022-06-275-2/+44
| | | | | | | | endpoints (#12944)
* | Refactor the Dockerfile-workers configuration script to use Jinja2 templates ↵reivilibre2022-06-274-38/+43
| | | | | | | | | | in Synapse workers' Supervisord blocks. (#13054) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Remove docs for Delete Group Admin API (#13112)Aaron Raimist2022-06-273-15/+1
| | | | | | | | | | | | This API no longer exists. Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | validate room alias before interacting with the room directory (#13106)santhoshivan232022-06-223-0/+20
| |
* | Use caret (semver bounds) for matrix.org packages (#13082)David Robertson2022-06-174-6/+9
| |
* | Update opentracing docs to reference the configuration manual rather than ↵Shay2022-06-172-2/+4
| | | | | | | | the configuation file. (#13076)
* | Fix inconsistencies in event validation (#13088)Richard van der Hoff2022-06-175-7/+118
| |
* | Fix inconsistencies in event validation for `m.room.create` events (#13087)Richard van der Hoff2022-06-173-25/+88
| | | | | | | | | | | | | | | | | | | | * Extend the auth rule checks for `m.room.create` events ... and move them up to the top of the function. Since the no auth_events are allowed for m.room.create events, we may as well get the m.room.create event checks out of the way first. * Add a test for create events with prev_events
* | Add type hints to event push actions tests. (#13099)Patrick Cloke2022-06-173-12/+19
| |
* | Fix type error that made its way onto develop (#13098)reivilibre2022-06-172-2/+3
| | | | | | | | | | | | | | * Fix type error introduced accidentally by #13045 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Update info on downstream debs (#13095)Richard van der Hoff2022-06-172-9/+9
| |
* | Simplify the alias deletion logic as an application service. (#13093)Quentin Gliech2022-06-173-22/+48
| |
* | Rotate notifications more frequently (#13096)Erik Johnston2022-06-172-1/+2
| |
* | Use new `device_list_changes_in_room` table when getting device list changes ↵Erik Johnston2022-06-174-31/+117
| | | | | | | | (#13045)
* | Allow MSC3030 'timestamp_to_event' calls from anyone on world-readable ↵Quentin Gliech2022-06-172-1/+4
| | | | | | | | | | rooms. (#13062) Signed-off-by: Quentin Gliech <quenting@element.io>
* | Fix logging context misuse when we fail to persist a federation event (#13089)Sean Quah2022-06-172-4/+3
| | | | | | | | | | | | | | | | | | When we fail to persist a federation event, we kick off a task to remove its push actions in the background, using the current logging context. Since we don't `await` that task, we may finish our logging context before the task finishes. There's no reason to not `await` the task, so let's do that. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Add desc to `get_earliest_token_for_stats` (#13085)Erik Johnston2022-06-162-0/+2
| |
* | Add a Subject Alternative Name to the certificate generated for Complement ↵reivilibre2022-06-162-3/+20
| | | | | | | | tests. (#13071)
* | Improve URL previews for sites with only Twitter card information. (#13056)Patrick Cloke2022-06-163-17/+137
| | | | | | | | | | | | Pull out `twitter:` meta tags when generating a preview and use it to augment any `og:` meta tags. Prefers Open Graph information over Twitter card information.
* | Reduce the duplication of code that invokes the rate limiter. (#13070)reivilibre2022-06-162-27/+4
| |
* | Complement: use SQLite by default (#13075)Richard van der Hoff2022-06-163-2/+3
| | | | | | | | | | If no database is configured explicitly, use sqlite. This means that you don't have to pass any variables into the image.
* | Add custom well-known (#13035)Jacek Kuśnierz2022-06-165-1/+68
| | | | | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Add instructions for running Complement with `gotestfmt`-formatted output ↵reivilibre2022-06-162-0/+15
| | | | | | | | locally. (#13073)
* | Move some event auth checks out to a different method (#13065)Richard van der Hoff2022-06-157-98/+219
| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add auth events to events used in tests * Move some event auth checks out to a different method Some of the event auth checks apply to an event's auth_events, rather than the state at the event - which means they can play no part in state resolution. Move them out to a separate method. * Rename check_auth_rules_for_event Now it only checks the state-dependent auth rules, it needs a better name.
* | Add headers to individual options in config documentation to allow for ↵Shay2022-06-152-163/+164
| | | | | | | | linking. (#13055)
* | Add more tests for room upgrades (#13074)Sean Quah2022-06-152-5/+79
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Change default `sync_response_cache_duration` (#13042)Erik Johnston2022-06-155-4/+11
| |
* | Replace pyjwt with authlib in `org.matrix.login.jwt` (#13011)Hannes Lerchl2022-06-158-57/+100
| |
* | Sort failing jobs in Complement CI to the top of the logs to make them ↵reivilibre2022-06-153-0/+104
| | | | | | | | easier to read. (#13057)
* | Add a CI job to check that schema deltas are in the correct folder. (#13063)Erik Johnston2022-06-155-6/+126
| |
* | Type annotations in `synapse.databases.main.devices` (#13025)David Robertson2022-06-155-21/+36
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Speed up `get_unread_event_push_actions_by_room` (#13005)Erik Johnston2022-06-1514-152/+323
| | | | | | | | | | | | | | | | | | | | | | Fixes #11887 hopefully. The core change here is that `event_push_summary` now holds a summary of counts up until a much more recent point, meaning that the range of rows we need to count in `event_push_actions` is much smaller. This needs two major changes: 1. When we get a receipt we need to recalculate `event_push_summary` rather than just delete it 2. The logic for deleting `event_push_actions` is now divorced from calculating `event_push_summary`. In future it would be good to calculate `event_push_summary` while we persist a new event (it should just be a case of adding one to the relevant rows in `event_push_summary`), as that will further simplify the get counts logic and remove the need for us to periodically update `event_push_summary` in a background job.
* | Rename complement-developonly (#13046)Erik Johnston2022-06-152-0/+3
| |
* | Use updated `update_user_directory_from_worker` options in Complement tests. ↵reivilibre2022-06-152-3/+4
| | | | | | | | (#13069)
* | Collapse Docker build commands in Complement CI runs to make the logs easier ↵reivilibre2022-06-156-7/+23
| | | | | | | | to read. (#13058)
* | Track a histogram of state res durations (#13036)David Robertson2022-06-152-0/+13
| |
* | Fix a long-standing bug which meant that rate limiting was not restrictive ↵reivilibre2022-06-153-12/+45
| | | | | | | | enough in some cases. (#13018)
* | Don't use keyword arguments when initialising modules (#13060)Brendan Abolivier2022-06-152-1/+2
| |
* | Clean up schema for `event_edges` (#12893)Richard van der Hoff2022-06-157-11/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove redundant references to `event_edges.room_id` We don't need to care about the room_id here, because we are already checking the event id. * Clean up the event_edges table We make a number of changes to `event_edges`: * We give the `room_id` and `is_state` columns defaults (null and false respectively) so that we can stop populating them. * We drop any rows that have `is_state` set true - they should no longer exist. * We drop any rows that do not exist in `events` - these should not exist either. * We drop the old unique constraint on all the colums, which wasn't much use. * We create a new unique index on `(event_id, prev_event_id)`. * We add a foreign key constraint to `events`. These happen rather differently depending on whether we are on Postgres or SQLite. For SQLite, we just rebuild the whole table, copying only the rows we want to keep. For Postgres, we try to do things in the background as much as possible. * Stop populating `event_edges.room_id` and `is_state` We can just rely on the defaults.
* | Fix typechecks against twisted trunk (#13061)David Robertson2022-06-153-4/+6
| |
* | Merge branch 'master' into developPatrick Cloke2022-06-141-1/+1
|\|
| * Fix incorrect link in changelog.Patrick Cloke2022-06-141-1/+1
| |
* | Refactor entry points so that they all have a `main` function. (#13052)reivilibre2022-06-1411-10/+61
| |
* | Fix `destination_is` errors seen in sentry. (#13041)David Robertson2022-06-147-8/+59
| | | | | | | | | | | | * Rename test_fedclient to match its source file * Require at least one destination to be truthy * Explicitly validate user ID in profile endpoint GETs Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Up complement time outs (#13048)Erik Johnston2022-06-142-3/+4
| |
* | Fix version number in spam checker callbacks doc (#13047)Brendan Abolivier2022-06-142-6/+7
| |
* | Remove code generating comments in configuration file (#12941)Shay2022-06-1441-5711/+66
| |
* | Rename delta to apply in the proper schema version. (#13050)Patrick Cloke2022-06-142-0/+1
| |
* | Move the "email unsubscribe" resource, refactor the macaroon generator & ↵Quentin Gliech2022-06-1416-441/+619
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | simplify the access token verification logic. (#12986) This simplifies the access token verification logic by removing the `rights` parameter which was only ever used for the unsubscribe link in email notifications. The latter has been moved under the `/_synapse` namespace, since it is not a standard API. This also makes the email verification link more secure, by embedding the app_id and pushkey in the macaroon and verifying it. This prevents the user from tampering the query parameters of that unsubscribe link. Macaroon generation is refactored: - Centralised all macaroon generation and verification logic to the `MacaroonGenerator` - Moved to `synapse.utils` - Changed the constructor to require only a `Clock`, hostname, and a secret key (instead of a full `Homeserver`). - Added tests for all methods.
* | Fix Complement runs always being Postgres (#13034)reivilibre2022-06-142-1/+2
| | | | | | | | | | | | | | * Fix Complement runs always being Postgres * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Merge branch 'release-v1.61' into developErik Johnston2022-06-144-20/+40
|\|
| * Fixup upgrades v1.61.0Erik Johnston2022-06-141-3/+3
| |
| * Update changelogErik Johnston2022-06-141-3/+6
| |
| * 1.61.0Erik Johnston2022-06-144-2/+16
| |
| * Mention removed community/group worker endpoints in upgrade.md (#13023)Sami Olmari2022-06-142-0/+19
| |
* | Mention removed community/group worker endpoints in upgrade.md (#13023)Sami Olmari2022-06-142-0/+17
| |
* | Decouple `synapse.api.auth_blocking.AuthBlocking` from ↵Quentin Gliech2022-06-1414-50/+63
| | | | | | | | `synapse.api.auth.Auth`. (#13021)
* | Uniformize spam-checker API, part 4: port other spam-checker callbacks to ↵David Teller2022-06-1312-182/+604
| | | | | | | | | | return `Union[Allow, Codes]`. (#12857) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Replace noop background updates with DELETE. (#12954)Patrick Cloke2022-06-1314-146/+62
| | | | | | | | Removes the `register_noop_background_update` and deletes the background updates directly in a delta file.
* | Merge branch 'rav/simplify_event_auth_interface' into developRichard van der Hoff2022-06-1311-228/+239
|\ \
| * | changelogRichard van der Hoff2022-06-121-0/+1
| | |
| * | Remove redundant `room_version` param from `check_auth_rules_from_context`Richard van der Hoff2022-06-124-35/+8
| | | | | | | | | | | | It's now implied by the room_version property on the event.
| * | Remove `room_version` param from `check_auth_rules_for_event`Richard van der Hoff2022-06-126-65/+16
| | | | | | | | | | | | | | | | | | | | | Instead, use the `room_version` property of the event we're checking. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
| * | Remove `room_version` param from `validate_event_for_room_version`Richard van der Hoff2022-06-126-14/+14
| | | | | | | | | | | | | | | | | | | | | Instead, use the `room_version` property of the event we're validating. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
| * | EventAuthTestCase: build events for the right room versionRichard van der Hoff2022-06-121-119/+205
| |/ | | | | | | | | | | In practice, when we run the auth rules, all of the events have the right room version. Let's stop building Room V1 events for these tests and use the right version.
* | Revert "Changelog"David Robertson2022-06-101-1/+0
| | | | | | | | | | | | This reverts commit ae09cc2ee45715f3e5c14a5549b3d142a026406f. This commit was intended for a different branch.
* | ChangelogDavid Robertson2022-06-101-0/+1
| |
* | Add missing TOC link to poetry cheat sheet (#13022)David Robertson2022-06-102-0/+2
| | | | | | Missed by #12475.
* | Fix-up the contrib/graph scripts. (#13013)Patrick Cloke2022-06-104-43/+70
| | | | | | | | | | | | * Clarifies comments and documentation. * Adds type-hints. * Fixes Python 3 compatibility (and runs pyupgrade). * Updates for changes in Synapse internals.
* | Stop depending on `room_id` to be returned for children state in the ↵Patrick Cloke2022-06-103-5/+3
| | | | | | | | | | | | | | | | | | | | | | hierarchy response. (#12991) The `room_id` field was removed from MSC2946 before it was accepted. It was initially kept for backwards compatibility and should be removed now that the stable form of the API is used. This change only stops Synapse from validating that it is returned, a future PR will remove returning it as part of the response.
* | Enable testing against PostgreSQL databases in Complement CI. (#12965)reivilibre2022-06-092-1/+12
| |
* | Fix example of running complement.sh. (#12990)Patrick Cloke2022-06-092-1/+2
| |
* | Faster joins: add issue links to the TODOs (#13004)Richard van der Hoff2022-06-099-2/+27
| | | | | | | | ... to help us keep track of these things
* | Type annotations for `test_v2` (#12985)David Robertson2022-06-094-58/+129
| |
* | Use READ COMMITTED isolation level when inserting read receipts (#12957)Nick Mills-Barrett2022-06-092-0/+6
| |
* | Move the (unstable) `dir` parameter for /relations behind an experimental ↵Patrick Cloke2022-06-084-3/+15
| | | | | | | | | | | | flag. (#12984) MSC3715 defines this parameter, but the unstable version of it should be behind an experimental flag.
* | Use a GitHub form for issues rather than a hard-to-read, easy-to-ignore ↵reivilibre2022-06-083-72/+104
| | | | | | | | | | template. (#12982) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge the Complement testing Docker images into a single, multi-purpose ↵reivilibre2022-06-0818-371/+276
| | | | | | | | | | image. (#12881) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Docker Compose Worker Documentation and Examples (#12737)James2022-06-085-0/+236
| |