summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Fix some b'abcd' noise in logs and metricsRichard van der Hoff2018-09-172-5/+8
| | | | | Python 3 compatibility: make sure that we decode some byte sequences before we use them to create log lines and metrics labels.
* README: run python_dependencies with -mRichard van der Hoff2018-09-171-1/+1
| | | ... to stop things which try to import `types` getting `synapse.types` instead
* Merge pull request #3888 from matrix-org/rav/nuke_nuke_roomsAmber Brown2018-09-172-57/+1
|\ | | | | Remove nuke-room-from-db.sh script
| * changelogRichard van der Hoff2018-09-171-0/+1
| |
| * Remove nuke-room-from-db.sh scriptRichard van der Hoff2018-09-171-57/+0
|/ | | | | | | | | | | | The problem with this script is that it is largely untested, entirely unmaintained, and running it is likely to make your synapse blow up in exciting ways. For example, it leaves a bunch of tables with dead values in it, like event_to_state_groups. Having it here sends a message that it is a supported part of synapse, which is absolutely not the case.
* missing changelogMatthew Hodgson2018-09-151-0/+1
|
* mention libjemalloc in readme (#3877)Vincent Breitmoser2018-09-151-0/+8
|
* Fix timeout functionErik Johnston2018-09-151-1/+2
| | | | | Turns out deferred.cancel sometimes throws, so we do that last to ensure that we always do resolve the new deferred.
* Merge pull request #3875 from matrix-org/erikj/extra_timeoutsErik Johnston2018-09-143-0/+63
|\ | | | | Add an awful secondary timeout to fix wedged requests
| * NewsfileErik Johnston2018-09-141-0/+1
| |
| * Add an awful secondary timeout to fix wedged requestsErik Johnston2018-09-142-0/+62
|/ | | | This is an attempt to mitigate #3842 by adding yet-another-timeout
* don't filter membership events based on history visibility (#3874)Matthew Hodgson2018-09-142-8/+1
| | | | | | | | don't filter membership events based on history visibility as we will already have filtered the messages in the timeline, and state events are always visible. and because @erikjohnston said so.
* Merge pull request #3872 from matrix-org/hawkowl/timeouts-2Erik Johnston2018-09-145-7/+13
|\ | | | | timeouts 2: electric boogaloo
| * fixAmber Brown2018-09-151-3/+3
| |
| * changelogAmber Brown2018-09-151-0/+1
| |
| * fixAmber Brown2018-09-141-1/+4
| |
| * fixAmber Brown2018-09-141-1/+1
| |
| * redact betterAmber Brown2018-09-141-2/+2
| |
| * we do that higher upAmber Brown2018-09-141-0/+1
| |
| * Merge remote-tracking branch 'origin/develop' into hawkowl/timeouts-2Amber Brown2018-09-148-61/+55
| |\
| * | buffer?Amber Brown2018-09-141-1/+2
| | |
* | | Merge pull request #3871 from matrix-org/erikj/in_flight_block_metricsErik Johnston2018-09-145-4/+217
|\ \ \ | | | | | | | | Add in flight real time metrics for Measure blocks
| * | | Remove spurious commentErik Johnston2018-09-141-2/+0
| | | |
| * | | Measure outbound requestsErik Johnston2018-09-141-3/+6
| | | |
| * | | NewsfileErik Johnston2018-09-141-0/+1
| | | |
| * | | TestsErik Johnston2018-09-141-0/+81
| | | |
| * | | Add in flight real time metrics for Measure blocksErik Johnston2018-09-142-1/+131
|/ / /
* | | Merge pull request #3860 from matrix-org/travis/typo-1Travis Ralston2018-09-132-1/+2
|\ \ \ | |_|/ |/| | Fix minor typo in exception
| * | Create 3860.miscTravis Ralston2018-09-131-0/+1
| | |
| * | Fix minor typo in exceptionTravis Ralston2018-09-131-1/+1
|/ /
* / merge (#3576)Amber Brown2018-09-148-61/+55
|/
* Merge pull request #3856 from matrix-org/erikj/speed_up_purge hhs-8Erik Johnston2018-09-132-16/+29
|\ | | | | Make purge history slightly faster
| * commentErik Johnston2018-09-131-0/+2
| |
| * pep8Erik Johnston2018-09-131-1/+0
| |
| * Create indices after insertionErik Johnston2018-09-131-14/+18
| |
| * Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-09-134-2/+28
| |\ | | | | | | | | | erikj/speed_up_purge
| * | NewsfileErik Johnston2018-09-131-0/+1
| | |
| * | Make purge history slightly fasterErik Johnston2018-09-131-2/+9
| | | | | | | | | | | | | | | Don't pull out events that are outliers and won't be deleted, as nothing should happen to them.
* | | Merge pull request #3859 from matrix-org/erikj/add_iterkeysAmber Brown2018-09-143-1/+7
|\ \ \ | | | | | | | | Fix handling of redacted events from federation
| * | | NewsfileErik Johnston2018-09-131-0/+1
| | | |
| * | | Fix handling of redacted events from federationErik Johnston2018-09-132-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we receive an event that doesn't pass their content hash check (e.g. due to already being redacted) then we hit a bug which causes an exception to be raised, which then promplty stops the event (and request) from being processed. This effects all sorts of federation APIs, including joining rooms with a redacted state event.
* | | | fix circleci merged builds (#3858)Amber Brown2018-09-142-0/+5
|/ / / | | | | | | | | | | | | | | | * fix * changelog
* | / Attempt to figure out what's going on with timeouts (#3857)Amber Brown2018-09-144-57/+241
| |/ |/|
* | Remove some superfluous logging (#3855)Amber Brown2018-09-134-2/+28
|/
* Merge pull request #3846 from matrix-org/neilj/expose-registered-users hhs-7Neil Johnson2018-09-124-3/+60
|\ | | | | expose number of real reserved users
| * improve namingNeil Johnson2018-09-124-10/+14
| |
| * towncrierNeil Johnson2018-09-121-0/+1
| |
| * expose number of real reserved usersNeil Johnson2018-09-123-3/+55
| |
* | show heroes if a room has a 'deleted' name/canonical_alias (#3851)Matthew Hodgson2018-09-122-2/+16
| |
* | Merge pull request #3853 from matrix-org/erikj/log_outbound_each_timeErik Johnston2018-09-122-75/+75
|\ \ | | | | | | Log outbound requests when we retry
| * | NewsfileErik Johnston2018-09-121-0/+1
| | |
| * | Log outbound requests when we retryErik Johnston2018-09-121-75/+74
| | |
* | | argh pep8Matthew Hodgson2018-09-121-1/+1
| | |
* | | correctly log gappy sync metricsMatthew Hodgson2018-09-121-1/+1
| | |
* | | fix loglineMatthew Hodgson2018-09-121-1/+1
| | |
* | | Merge pull request #3841 from matrix-org/erikj/manhole_key_lengthErik Johnston2018-09-122-13/+32
|\ \ \ | | | | | | | | Change the manhole SSH key to have more bits
| * | | NewsfileErik Johnston2018-09-111-0/+1
| | | |
| * | | Change the manhole SSH key to have more bitsErik Johnston2018-09-111-13/+31
| | | | | | | | | | | | | | | | | | | | Newer versions of openssh client refuse to connect to the old key due to its length.
* | | | Add JUnit summaries to CircleCI as well as merged runs (#3704)Amber Brown2018-09-123-0/+94
| | | |
* | | | Port federation/ to py3 (#3847)Amber Brown2018-09-124-19/+19
| | | |
* | | | Merge pull request #3835 from krombel/fix_3821Amber Brown2018-09-122-1/+6
|\ \ \ \ | | | | | | | | | | fix VOIP crashes under Python 3
| * | | | add changelogKrombel2018-09-101-0/+1
| | | | |
| * | | | fix VOIP crashes under Python 3 (#3821)Krombel2018-09-101-1/+5
| | | | |
* | | | | Merge pull request #3826 from matrix-org/rav/logging_for_keyringAmber Brown2018-09-124-13/+47
|\ \ \ \ \ | | | | | | | | | | | | add some logging for the keyring queue
| * | | | | changelogRichard van der Hoff2018-09-071-0/+1
| | | | | |
| * | | | | clearer logging when things fail, tooRichard van der Hoff2018-09-062-7/+28
| | | | | |
| * | | | | add some logging for the keyring queueRichard van der Hoff2018-09-061-6/+18
| | | | | | | | | | | | | | | | | | | | | | | | why is it so damn slow?
* | | | | | Merge pull request #3824 from matrix-org/rav/fix_jwt_importAmber Brown2018-09-123-1/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix jwt import check
| * | | | | | changelogRichard van der Hoff2018-09-071-0/+1
| | | | | | |
| * | | | | | Fix jwt import checkRichard van der Hoff2018-09-072-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This handy code attempted to check that we could import jwt, but utterly failed to check it was the right jwt. Fixes https://github.com/matrix-org/synapse/issues/3793
* | | | | | | Port rest/ to Python 3 (#3823)Amber Brown2018-09-1218-100/+113
| |_|_|_|/ / |/| | | | |
* | | | | | Port crypto/ to Python 3 (#3822)Amber Brown2018-09-124-6/+14
| | | | | |
* | | | | | Merge pull request #3845 from matrix-org/erikj/timeout_readsAmber Brown2018-09-122-7/+46
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Timeout reading body for outbound HTTP requests
| * | | | | NewsfileErik Johnston2018-09-121-0/+1
| | | | | |
| * | | | | Timeout reading body for outbound HTTP requestsErik Johnston2018-09-121-7/+45
|/ / / / /
* | | | / Speed up lazy loading (#3827)Matthew Hodgson2018-09-125-30/+159
| |_|_|/ |/| | | | | | | | | | | | | | | * speed up room summaries by pulling their data from room_memberships rather than room state * disable LL for incr syncs, and log incr sync stats (#3840)
* | | | Merge pull request #3834 from mvgorcum/developErik Johnston2018-09-102-10/+17
|\ \ \ \ | |_|_|/ |/| | | Remove build requirements after building docker image
| * | | add runtime dependenciesJan Christian Grünhage2018-09-101-5/+10
| | | |
| * | | NewsfileMathijs van Gorcum2018-09-101-0/+1
| | | |
| * | | Move COPY before RUN and merge RUNsMathijs van Gorcum2018-09-101-5/+5
| | | |
| * | | Remove build requirements after buildingMathijs van Gorcum2018-09-101-2/+3
|/ / /
* | | Merge pull request #3810 from matrix-org/erikj/send_tags_down_sync_on_joinAmber Brown2018-09-072-0/+14
|\ \ \ | | | | | | | | Send existing room tags down sync on join
| * | | NewsfileErik Johnston2018-09-061-0/+1
| | | |
| * | | Don't send empty tags list down syncErik Johnston2018-09-061-0/+5
| | | |
| * | | Send existing room tags down sync on joinErik Johnston2018-09-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a user joined a room any existing tags were not sent down the sync stream. Ordinarily this isn't a problem because the user needs to be in the room to have set tags in it, however synapse will sometimes add tags for a user to a room, e.g. for server notices, which need to come down sync.
* | | | Merge pull request #3783 from cwmke/developRichard van der Hoff2018-09-071-0/+12
|\ \ \ \ | |_|/ / |/| | | Add apache vhost config to Readme
| * | | Remove end '/'sColin W2018-09-021-2/+2
| | | |
| * | | Update readme on develop branchColin W2018-09-021-0/+12
| | | |
* | | | Merge branch 'master' into developAmber Brown2018-09-0729-28/+61
|\ \ \ \
| * | | | changelog v0.33.4 github/release-v0.33.4 release-v0.33.4Amber Brown2018-09-072-1/+9
| | | | |
| * | | | versionAmber Brown2018-09-071-1/+1
| | | | |
| * | | | Merge branch 'master' of github.com:matrix-org/synapse into release-v0.33.4 v0.33.4rc2Erik Johnston2018-09-060-0/+0
| |\ \ \ \
| * | | | | Bump version and changelogErik Johnston2018-09-062-1/+7
| | | | | |
| * | | | | Merge tag 'v0.33.3.1' into release-v0.33.4Erik Johnston2018-09-067-46/+158
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 0.33.3.1 (2018-09-06) ============================= SECURITY FIXES -------------- - Fix an issue where event signatures were not always correctly validated ([\#3796](https://github.com/matrix-org/synapse/issues/3796)) - Fix an issue where server_acls could be circumvented for incoming events ([\#3796](https://github.com/matrix-org/synapse/issues/3796)) Internal Changes ---------------- - Unignore synctl in .dockerignore to fix docker builds ([\#3802](https://github.com/matrix-org/synapse/issues/3802))
| * \ \ \ \ \ Merge pull request #3802 from matrix-org/jcgruenhage/docker-unignore-synctlAmber Brown2018-09-062-1/+1
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | remove synctl from .dockerignore
| | * | | | | | Create 3802.miscJan Christian Grünhage2018-09-061-0/+1
| | | | | | | |
| | * | | | | | remove synctl from .dockerignoreJan Christian Grünhage2018-09-061-1/+0
| |/ / / / / /
| * | | | | | version and towncrier v0.33.4rc1Amber Brown2018-09-0429-28/+45
| | | | | | |
* | | | | | | Port tests/ to Python 3 (#3808)Amber Brown2018-09-0712-430/+349
| | | | | | |
* | | | | | | Merge pull request #3800 from matrix-org/neilj/remove-guests-from-mau-count hhs-6Neil Johnson2018-09-065-6/+54
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | guest users should not be part of mau total
| * | | | | | ensure guests never enter mau listNeil Johnson2018-09-064-8/+10
| | | | | | |
| * | | | | | towncrierNeil Johnson2018-09-051-0/+1
| | | | | | |
| * | | | | | guest users should not be part of mau totalNeil Johnson2018-09-052-3/+48
| | | | | | |
* | | | | | | Merge pull request #3805 from matrix-org/erikj/limit_transaction_pdus_edusAmber Brown2018-09-072-0/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Limit the number of PDUs/EDUs per fedreation transaction
| * | | | | | | SpellingErik Johnston2018-09-061-1/+1
| | | | | | | |
| * | | | | | | NewsfileErik Johnston2018-09-061-0/+1
| | | | | | | |
| * | | | | | | Limit the number of PDUs/EDUs per fedreation transactionErik Johnston2018-09-061-0/+12
| | | | | | | |
* | | | | | | | Merge pull request #3806 from matrix-org/erikj/limit_postgres_travisAmber Brown2018-09-072-3/+3
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Only start postgres instance for postgres tests on Travis CI
| * | | | | | | | NewsfileErik Johnston2018-09-061-0/+1
| | | | | | | | |
| * | | | | | | | Only start postgres instance for postgres tests on Travis CIErik Johnston2018-09-061-3/+2
| |/ / / / / / /
* | | | | | | | Merge pull request #3788 from matrix-org/erikj/remove_conn_idAmber Brown2018-09-072-12/+13
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove conn_id from repl prometheus metrics
| * | | | | | | | Remove conn_idErik Johnston2018-09-041-2/+2
| | | | | | | | |
| * | | | | | | | NewsfileErik Johnston2018-09-031-0/+1
| | | | | | | | |
| * | | | | | | | Remove conn_id from repl prometheus metricsErik Johnston2018-09-031-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `conn_id` gets set to a random string, and so we end up filling up prometheus with tonnes of data series, which is bad.
* | | | | | | | | Merge pull request #3795 from matrix-org/erikj/faster_sync_stateAmber Brown2018-09-072-8/+9
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | User iter* during sync state calculations
| * | | | | | | | | NewsfileErik Johnston2018-09-051-0/+1
| | | | | | | | | |
| * | | | | | | | | User iter* during sync state calculationsErik Johnston2018-09-051-8/+8
| | | | | | | | | |
* | | | | | | | | | Merge pull request #3804 from matrix-org/rav/fix_openssl_depAmber Brown2018-09-072-2/+3
|\ \ \ \ \ \ \ \ \ \ | |_|_|/ / / / / / / |/| | | | | | | | | bump dep on pyopenssl to 16.x
| * | | | | | | | | changelogRichard van der Hoff2018-09-061-0/+1
| | | | | | | | | |
| * | | | | | | | | bump dep on pyopenssl to 16.xRichard van der Hoff2018-09-061-2/+2
| | |_|/ / / / / / | |/| | | | | | |
* | | | | | | | | Port handlers/ to Python 3 (#3803)Amber Brown2018-09-078-19/+24
| |_|_|_|_|_|_|/ |/| | | | | | |
* | | | | | | | Merge branch 'master' into developRichard van der Hoff2018-09-069-47/+157
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | / / | | |_|_|_|/ / | |/| | | | |
| * | | | | | Merge tag 'v0.33.3.1'Richard van der Hoff2018-09-069-47/+157
| |\ \ \ \ \ \ | | | |_|_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 0.33.3.1 (2018-09-06) ============================= SECURITY FIXES -------------- - Fix an issue where event signatures were not always correctly validated ([\#3796](https://github.com/matrix-org/synapse/issues/3796)) - Fix an issue where server_acls could be circumvented for incoming events ([\#3796](https://github.com/matrix-org/synapse/issues/3796)) Internal Changes ---------------- - Unignore synctl in .dockerignore to fix docker builds ([\#3802](https://github.com/matrix-org/synapse/issues/3802))
| | * | | | | prepare v0.33.3.1 v0.33.3.1 github/release-v0.33.3.1 release-v0.33.3.1Richard van der Hoff2018-09-063-2/+15
| | | | | | |
| | * | | | | Create 3802.miscJan Christian Grünhage2018-09-061-0/+1
| | | | | | |
| | * | | | | remove synctl from .dockerignoreJan Christian Grünhage2018-09-061-1/+0
| | | | | | |
| | * | | | | Fix origin handling for pushed transactionsRichard van der Hoff2018-09-055-29/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use the actual origin for push transactions, rather than whatever the remote server claimed.
| | * | | | | Check that signatures on events are validRichard van der Hoff2018-09-051-16/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should check that both the sender's server, and the server which created the event_id (which may be different from whatever the remote server has told us the origin is), have signed the event.
* | | | | | | Merge pull request #3790 from matrix-org/rav/respect_event_format_in_filterRichard van der Hoff2018-09-053-13/+40
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Implement 'event_format' filter param in /sync
| * | | | | | | changelogRichard van der Hoff2018-09-041-0/+1
| | | | | | | |
| * | | | | | | Implement 'event_format' filter param in /syncRichard van der Hoff2018-09-042-13/+39
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | This has been specced and part-implemented; let's implement it for /sync (but no other endpoints yet :/).
* | | | | | | Port http/ to Python 3 (#3771)Amber Brown2018-09-068-186/+134
| |_|_|/ / / |/| | | | |
* | | | | | Merge pull request #3789 from matrix-org/neilj/improve_threepid_error_strings hhs-5Neil Johnson2018-09-043-7/+22
|\ \ \ \ \ \ | |/ / / / / |/| | | | | improve human readable error messages
| * | | | | towncrierNeil Johnson2018-09-041-0/+1
| | | | | |
| * | | | | improve human readable error messageNeil Johnson2018-09-041-1/+2
| | | | | |
| * | | | | improve human readable error messagesNeil Johnson2018-09-042-7/+20
| | | | | |
* | | | | | Fix tests on postgresql (#3740)Amber Brown2018-09-0418-341/+356
| |_|_|/ / |/| | | |
* | | | | Merge pull request #3737 from matrix-org/erikj/remove_redundant_state_funcErik Johnston2018-09-034-57/+8
|\ \ \ \ \ | | | | | | | | | | | | Remove unnecessary resolve_events_with_state_map
| * | | | | NewsfileErik Johnston2018-09-031-0/+1
| | | | | |
| * | | | | Remove unnecessary resolve_events_with_state_mapErik Johnston2018-08-223-57/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We only ever used the synchronous resolve_events_with_state_map in one place, which is trivial to replace with the async version.
* | | | | | Merge pull request #3378 from NickEckardt/developAmber Brown2018-09-032-5/+1
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | matrix-synapse-auto-deploy is no longer maintained.
| * | | | | Create 3378.miscAmber Brown2018-09-031-0/+1
| | | | | |
| * | | | | Merge branch 'develop' into developAmber Brown2018-09-03441-11570/+24237
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #3777 from matrix-org/neilj/fix_register_user_registrationNeil Johnson2018-08-319-5/+78
|\ \ \ \ \ \ | | |_|/ / / | |/| | | | fix bug where preserved threepid user comes to sign up and server is …
| * | | | | assert rather than warn hhs-4Neil Johnson2018-08-311-3/+2
| | | | | |
| * | | | | move threepid checker to config, add missing yieldsNeil Johnson2018-08-316-21/+41
| | | | | |
| * | | | | fix reference to is_threepid_reservedNeil Johnson2018-08-311-1/+1
| | | | | |
| * | | | | typoNeil Johnson2018-08-311-1/+1
| | | | | |
| * | | | | ensure post registration auth checks do not fail erroneouslyNeil Johnson2018-08-314-6/+24
| | | | | |
| * | | | | news fragemntNeil Johnson2018-08-311-0/+1
| | | | | |
| * | | | | fix bug where preserved threepid user comes to sign up and server is mau blockedNeil Johnson2018-08-315-3/+38
|/ / / / /
* | | | | Port storage/ to Python 3 (#3725)Amber Brown2018-08-3117-36/+208
| | | | |
* | | | | Merge pull request #3764 from matrix-org/rav/close_db_conn_after_initRichard van der Hoff2018-08-3016-54/+41
|\ \ \ \ \ | | | | | | | | | | | | Make sure that we close db connections opened during init
| * | | | | Fix up testsRichard van der Hoff2018-08-283-6/+10
| | | | | |
| * | | | | use abc.abstractpropertyRichard van der Hoff2018-08-281-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | This gives clearer messages when someone gets it wrong
| * | | | | changelogRichard van der Hoff2018-08-281-0/+1
| | | | | |
| * | | | | Make sure that we close db connections opened during initRichard van der Hoff2018-08-2812-48/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should explicitly close any db connections we open, because failing to do so can block other transactions as per https://github.com/matrix-org/synapse/issues/3682. Let's also try to factor out some of the boilerplate by having server classes define their datastore class rather than duplicating the whole of `setup`.
* | | | | | Merge pull request #3768 from krombel/fix_3445Erik Johnston2018-08-292-2/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix #3445 - do not use itervalues() on SortedDict()
| * | | | | | changelogKrombel2018-08-292-1/+1
| | | | | | |
| * | | | | | fix #3445Krombel2018-08-292-2/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | itervalues(d) calls d.itervalues() [PY2] and d.values() [PY3] but SortedDict only implements d.values()
* | | | | | Update CONTRIBUTING to clarify miscs & Markdown (#3730)Amber Brown2018-08-292-3/+5
| | | | | |
* | | | | | don't return non-LL-member state in incremental sync state blocks (#3760)Matthew Hodgson2018-08-282-1/+9
|/ / / / / | | | | | | | | | | don't return non-LL-member state in incremental sync state blocks
* | | | | Merge pull request #3758 from matrix-org/erikj/admin_contact hhs-3Erik Johnston2018-08-248-13/+14
|\ \ \ \ \ | | | | | | | | | | | | Change admin_uri to admin_contact in config and errors
| * \ \ \ \ Merge branch 'develop' of github.com:matrix-org/synapse into erikj/admin_contactErik Johnston2018-08-243-4/+5
| |\ \ \ \ \ | |/ / / / / |/| | | | |
* | | | | | Merge pull request #3756 from matrix-org/erikj/fix_tags_server_noticesErik Johnston2018-08-243-4/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix checking if service notice room is already tagged
| * | | | | | NewsfileErik Johnston2018-08-241-0/+1
| | | | | | |
| * | | | | | Fix checking if service notice room is already taggedErik Johnston2018-08-242-4/+4
|/ / / / / / | | | | | | | | | | | | | | | | | | This manifested in synapse repeatedly setting the tag for the room
| * | | | | NewsfileErik Johnston2018-08-241-0/+1
| | | | | |
| * | | | | Change admin_uri to admin_contact in config and errorsErik Johnston2018-08-247-13/+13
|/ / / / /
* | | | | Merge pull request #3755 from matrix-org/erikj/fix_server_notice_tags hhs-2Erik Johnston2018-08-243-4/+16
|\ \ \ \ \ | | | | | | | | | | | | Fix up tagging server notice rooms.
| * | | | | NewsfileErik Johnston2018-08-241-0/+1
| | | | | |
| * | | | | Ensure we wake up /sync when we add tag to notice roomErik Johnston2018-08-242-2/+13
| | | | | |
| * | | | | Make content of tag an empty object rather than nullErik Johnston2018-08-242-2/+2
|/ / / / /
* | | | | Merge pull request #3754 from matrix-org/erikj/fix_whitelist hhs-1Erik Johnston2018-08-242-1/+2
|\ \ \ \ \ | | | | | | | | | | | | Allow federation_domain_whitelist to be emtpy list
| * | | | | NewsfileErik Johnston2018-08-241-0/+1
| | | | | |
| * | | | | Fix bug when federation_domain_whitelist is an emtpy listErik Johnston2018-08-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Outbound federation were incorrectly allowed when the config option was set to an empty list
* | | | | | Merge pull request #3753 from matrix-org/erikj/fix_no_server_noticseErik Johnston2018-08-242-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix bug where we broke sync when using limit_usage_by_mau
| * | | | | | NewsfileErik Johnston2018-08-241-0/+1
| | | | | | |
| * | | | | | Fix bug where we broke sync when using limit_usage_by_mauErik Johnston2018-08-241-0/+4
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | We assumed that we always had service notices configured, but that is not always true
* | | | | | Merge pull request #3751 from matrix-org/rav/twisted_17Richard van der Hoff2018-08-242-1/+2
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Pin to twisted 17.1 or later
| * | | | | changelogRichard van der Hoff2018-08-241-0/+1
| | | | | |
| * | | | | Pin to twisted 17.1 or laterRichard van der Hoff2018-08-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/3741.
* | | | | | Merge pull request #3749 from matrix-org/erikj/add_trial_usersErik Johnston2018-08-248-5/+272
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Implement trial users
| * | | | | NewsfileErik Johnston2018-08-231-0/+1
| | | | | |
| * | | | | Unit testsErik Johnston2018-08-232-3/+227
| | | | | |
| * | | | | Implement trail usersErik Johnston2018-08-235-2/+44
|/ / / / /
* | | | | Merge pull request #3747 from matrix-org/erikj/fix_multiple_sends_noticeErik Johnston2018-08-233-1/+72
|\ \ \ \ \ | | | | | | | | | | | | Fix bug where we resent "limit exceeded" server notices
| * | | | | NewsfileErik Johnston2018-08-231-0/+1
| | | | | |
| * | | | | Fix bug where we resent "limit exceeded" server noticesErik Johnston2018-08-232-1/+71
|/ / / / / | | | | | | | | | | | | | | | This was due to a bug where we mutated a cached event's contents
* | | | | Merge pull request #3734 from matrix-org/travis/worker-docsTravis Ralston2018-08-232-1/+2
|\ \ \ \ \ | | | | | | | | | | | | Reference that the federation_reader needs the HTTP replication port set
| * | | | | Create 3734.miscTravis Ralston2018-08-211-0/+1
| | | | | |
| * | | | | Reference that the federation_reader needs the HTTP replication port setTravis Ralston2018-08-211-1/+1
| | | | | |
* | | | | | Merge pull request #3746 from matrix-org/erikj/mau_fixupsErik Johnston2018-08-233-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix MAU invalidation due to missing yield
| * | | | | | NewsfileErik Johnston2018-08-231-0/+1
| | | | | | |
| * | | | | | Actually run the testsErik Johnston2018-08-231-0/+0
| | | | | | |
| * | | | | | Add missing yieldErik Johnston2018-08-231-1/+2
|/ / / / / /
* | | | | | Merge pull request #3680 from matrix-org/neilj/server_notices_on_blockingErik Johnston2018-08-2210-32/+408
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | server notices on resource limit blocking
| * | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-08-22116-764/+1624
| |\ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | neilj/server_notices_on_blocking
* | | | | | Merge branch 'master' into developRichard van der Hoff2018-08-223-4/+12
|\ \ \ \ \ \ | | |_|_|/ / | |/| | | |
| * | | | | Use recaptcha_ajax.js directly from GoogleRichard van der Hoff2018-08-222-196/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was originally done in commit c75b71a397d91c013a65a7f57d2c13199cf4c204, but got reverted on this branch due to the PR (#3677) being based on the wrong branch. We're ready to merge this to master now, so let's make it match release-v0.33.3.
| * | | | | Merge tag 'v0.33.3'Richard van der Hoff2018-08-22200-3529/+5653
| |\ \ \ \ \ | | | |_|_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Features -------- - Add support for the SNI extension to federation TLS connections. Thanks to @vojeroen! ([\#3439](https://github.com/matrix-org/synapse/issues/3439)) - Add /_media/r0/config ([\#3184](https://github.com/matrix-org/synapse/issues/3184)) - speed up /members API and add `at` and `membership` params as per MSC1227 ([\#3568](https://github.com/matrix-org/synapse/issues/3568)) - implement `summary` block in /sync response as per MSC688 ([\#3574](https://github.com/matrix-org/synapse/issues/3574)) - Add lazy-loading support to /messages as per MSC1227 ([\#3589](https://github.com/matrix-org/synapse/issues/3589)) - Add ability to limit number of monthly active users on the server ([\#3633](https://github.com/matrix-org/synapse/issues/3633)) - Support more federation endpoints on workers ([\#3653](https://github.com/matrix-org/synapse/issues/3653)) - Basic support for room versioning ([\#3654](https://github.com/matrix-org/synapse/issues/3654)) - Ability to disable client/server Synapse via conf toggle ([\#3655](https://github.com/matrix-org/synapse/issues/3655)) - Ability to whitelist specific threepids against monthly active user limiting ([\#3662](https://github.com/matrix-org/synapse/issues/3662)) - Add some metrics for the appservice and federation event sending loops ([\#3664](https://github.com/matrix-org/synapse/issues/3664)) - Where server is disabled, block ability for locked out users to read new messages ([\#3670](https://github.com/matrix-org/synapse/issues/3670)) - set admin uri via config, to be used in error messages where the user should contact the administrator ([\#3687](https://github.com/matrix-org/synapse/issues/3687)) - Synapse's presence functionality can now be disabled with the "use_presence" configuration option. ([\#3694](https://github.com/matrix-org/synapse/issues/3694)) - For resource limit blocked users, prevent writing into rooms ([\#3708](https://github.com/matrix-org/synapse/issues/3708)) Bugfixes -------- - Fix occasional glitches in the synapse_event_persisted_position metric ([\#3658](https://github.com/matrix-org/synapse/issues/3658)) - Fix bug on deleting 3pid when using identity servers that don't support unbind API ([\#3661](https://github.com/matrix-org/synapse/issues/3661)) - Make the tests pass on Twisted < 18.7.0 ([\#3676](https://github.com/matrix-org/synapse/issues/3676)) - Don’t ship recaptcha_ajax.js, use it directly from Google ([\#3677](https://github.com/matrix-org/synapse/issues/3677)) - Fixes test_reap_monthly_active_users so it passes under postgres ([\#3681](https://github.com/matrix-org/synapse/issues/3681)) - Fix mau blocking calulation bug on login ([\#3689](https://github.com/matrix-org/synapse/issues/3689)) - Fix missing yield in synapse.storage.monthly_active_users.initialise_reserved_users ([\#3692](https://github.com/matrix-org/synapse/issues/3692)) - Improve HTTP request logging to include all requests ([\#3700](https://github.com/matrix-org/synapse/issues/3700)) - Avoid timing out requests while we are streaming back the response ([\#3701](https://github.com/matrix-org/synapse/issues/3701)) - Support more federation endpoints on workers ([\#3705](https://github.com/matrix-org/synapse/issues/3705), [\#3713](https://github.com/matrix-org/synapse/issues/3713)) - Fix "Starting db txn 'get_all_updated_receipts' from sentinel context" warning ([\#3710](https://github.com/matrix-org/synapse/issues/3710)) - Fix bug where `state_cache` cache factor ignored environment variables ([\#3719](https://github.com/matrix-org/synapse/issues/3719)) - Fix bug in v0.33.3rc1 which caused infinite loops and OOMs ([\#3723](https://github.com/matrix-org/synapse/issues/3723)) - Fix bug introduced in v0.33.3rc1 which made the ToS give a 500 error ([\#3732](https://github.com/matrix-org/synapse/issues/3732)) Deprecations and Removals ------------------------- - The Shared-Secret registration method of the legacy v1/register REST endpoint has been removed. For a replacement, please see [the admin/register API documentation](https://github.com/matrix-org/synapse/blob/master/docs/admin_api/register_api.rst). ([\#3703](https://github.com/matrix-org/synapse/issues/3703)) Internal Changes ---------------- - The test suite now can run under PostgreSQL. ([\#3423](https://github.com/matrix-org/synapse/issues/3423)) - Refactor HTTP replication endpoints to reduce code duplication ([\#3632](https://github.com/matrix-org/synapse/issues/3632)) - Tests now correctly execute on Python 3. ([\#3647](https://github.com/matrix-org/synapse/issues/3647)) - Sytests can now be run inside a Docker container. ([\#3660](https://github.com/matrix-org/synapse/issues/3660)) - Port over enough to Python 3 to allow the sytests to start. ([\#3668](https://github.com/matrix-org/synapse/issues/3668)) - Update docker base image from alpine 3.7 to 3.8. ([\#3669](https://github.com/matrix-org/synapse/issues/3669)) - Rename synapse.util.async to synapse.util.async_helpers to mitigate async becoming a keyword on Python 3.7. ([\#3678](https://github.com/matrix-org/synapse/issues/3678)) - Synapse's tests are now formatted with the black autoformatter. ([\#3679](https://github.com/matrix-org/synapse/issues/3679)) - Implemented a new testing base class to reduce test boilerplate. ([\#3684](https://github.com/matrix-org/synapse/issues/3684)) - Rename MAU prometheus metrics ([\#3690](https://github.com/matrix-org/synapse/issues/3690)) - add new error type ResourceLimit ([\#3707](https://github.com/matrix-org/synapse/issues/3707)) - Logcontexts for replication command handlers ([\#3709](https://github.com/matrix-org/synapse/issues/3709)) - Update admin register API documentation to reference a real user ID. ([\#3712](https://github.com/matrix-org/synapse/issues/3712))
| | * | | | changelog for 0.33.3 v0.33.3 github/release-v0.33.3 release-v0.33.3Richard van der Hoff2018-08-222-1/+9
| | | | | |
| | * | | | bump version to 0.33.3Richard van der Hoff2018-08-221-1/+1
| | | | | |
| | * | | | Update attributions and PR links in changelogRichard van der Hoff2018-08-221-2/+2
| | | | | |
| * | | | | Merge pull request #3685 from matrix-org/revert-3677-masterRichard van der Hoff2018-08-133-2/+196
| |\ \ \ \ \ | | | | | | | | | | | | | | Revert "Use recaptcha_ajax.js directly from Google"
| | * | | | | Revert "Use recaptcha_ajax.js directly from Google"Richard van der Hoff2018-08-133-2/+196
| |/ / / / /
| * | | | | Merge pull request #3677 from andrewshadura/masterRichard van der Hoff2018-08-133-196/+2
| |\ \ \ \ \ | | | | | | | | | | | | | | Use recaptcha_ajax.js directly from Google
* | \ \ \ \ \ Merge pull request #3724 from Half-Shot/hs/guest-fetch-eventErik Johnston2018-08-222-1/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Allow guests to use /rooms/:roomId/event/:eventId
| * | | | | | | 3724.featureWill Hunt2018-08-201-0/+1
| | | | | | | |
| * | | | | | | Allow guests to access /rooms/:roomId/event/:eventIdWill Hunt2018-08-201-1/+1
| | | | | | | |
* | | | | | | | Merge pull request #3659 from matrix-org/erikj/split_profilesErik Johnston2018-08-229-44/+78
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Allow profile updates to happen on workers
| * | | | | | | | Rename WorkerProfileHandler to BaseProfileHandlerErik Johnston2018-08-222-5/+12
| | | | | | | | |
| * | | | | | | | Add assert to ensure handler is only run on masterErik Johnston2018-08-221-0/+2
| | | | | | | | |
| * | | | | | | | Remove redundant varsErik Johnston2018-08-221-3/+0
| | | | | | | | |
| * | | | | | | | Add some fixmesErik Johnston2018-08-172-0/+6
| | | | | | | | |
| * | | | | | | | Call UserDirectoryHandler methods directlyErik Johnston2018-08-174-104/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out that the user directory handling is fairly racey as a bunch of stuff assumes that the processing happens on master, which it doesn't when there is a synapse.app.user_dir worker. So lets just call the function directly until we actually get round to fixing it, since it doesn't make the situation any worse.
| * | | | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-08-17244-2980/+3681
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | erikj/split_profiles
| * | | | | | | | | Split ProfileHandler into master and workerErik Johnston2018-08-173-11/+21
| | | | | | | | | |
| * | | | | | | | | Remote profile cache should remain in master workerErik Johnston2018-08-171-4/+2
| | | | | | | | | |
| * | | | | | | | | DocstringsErik Johnston2018-08-091-1/+11
| | | | | | | | | |
| * | | | | | | | | NewsfileErik Johnston2018-08-091-0/+1
| | | | | | | | | |
| * | | | | | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-08-0967-408/+1156
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | erikj/split_profiles
| * | | | | | | | | | Update workers.rst with new pathsErik Johnston2018-08-071-0/+1
| | | | | | | | | | |
| * | | | | | | | | | Allow ratelimiting on workersErik Johnston2018-08-071-29/+29
| | | | | | | | | | |
| * | | | | | | | | | Allow profile changes to happen on workersErik Johnston2018-08-075-8/+106
| | | | | | | | | | |
* | | | | | | | | | | Merge pull request #3673 from matrix-org/erikj/refactor_state_handlerErik Johnston2018-08-2213-277/+437
|\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Refactor state module to support multiple room versions
| * \ \ \ \ \ \ \ \ \ \ Merge branch 'develop' of github.com:matrix-org/synapse into ↵Erik Johnston2018-08-20208-3244/+4271
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | erikj/refactor_state_handler
| * | | | | | | | | | | | Remove redundant room_version checksErik Johnston2018-08-202-15/+4
| | | | | | | | | | | | |
| * | | | | | | | | | | | Revert spurious changeErik Johnston2018-08-201-2/+2
| | | | | | | | | | | | |
| * | | | | | | | | | | | NewsfileErik Johnston2018-08-091-0/+1
| | | | | | | | | | | | |
| * | | | | | | | | | | | Fix testsErik Johnston2018-08-096-5/+46
| | | | | | | | | | | | |
| * | | | | | | | | | | | Add fast path in state res for zero prev eventsErik Johnston2018-08-091-1/+6
| | | | | | | | | | | | |
| * | | | | | | | | | | | Choose state algorithm based on room versionErik Johnston2018-08-094-16/+105
| | | | | | | | | | | | |
| * | | | | | | | | | | | Add constants for room versionsErik Johnston2018-08-091-2/+7
| | | | | | | | | | | | |
| * | | | | | | | | | | | Refactor state moduleErik Johnston2018-08-092-296/+325
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We split out the actual state resolution algorithm to prepare for having multiple versions.
* | | | | | | | | | | | | Merge pull request #3735 from matrix-org/travis/federation-spellingRichard van der Hoff2018-08-222-1/+2
|\ \ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | limt -> limit
| * | | | | | | | | | | | | Create 3735.miscTravis Ralston2018-08-211-0/+1
| | | | | | | | | | | | | |
| * | | | | | | | | | | | | limt -> limitTravis Ralston2018-07-311-1/+1
| | | | | | | | | | | | | |
* | | | | | | | | | | | | | Merge remote-tracking branch 'origin/release-v0.33.3' into developRichard van der Hoff2018-08-222-3/+13
|\ \ \ \ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|_|/ / / / | |/| | | | | | | | | | / / | |_|_|_|_|_|_|_|_|_|_|/ / |/| | | | | | | | | | | |
| * | | | | | | | | | | | Merge pull request #3732 from matrix-org/rav/fix_gdpr_consentRichard van der Hoff2018-08-222-3/+13
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix 500 error from /consent form
| | * | | | | | | | | | | | changelogRichard van der Hoff2018-08-211-0/+1
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | fix another consent encoding failRichard van der Hoff2018-08-211-1/+1
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | Fix 500 error from /consent formRichard van der Hoff2018-08-211-2/+11
| |/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #3731
* | | | | | | | | | | | | Split the state_group_cache in two (#3726)Matthew Hodgson2018-08-223-28/+236
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Splits the state_group_cache in two. One half contains normal state events; the other contains member events. The idea is that the lazyloading common case of: "I want a subset of member events plus all of the other state" can be accomplished efficiently by splitting the cache into two, and asking for "all events" from the non-members cache, and "just these keys" from the members cache. This means we can avoid having to make DictionaryCache aware of these sort of complicated queries, whilst letting LL requests benefit from the caching. Previously we were unable to sensibly use the caching and had to pull all state from the DB irrespective of the filtering, which made things slow. Hopefully fixes https://github.com/matrix-org/synapse/issues/3720.
* | | | | | | | | | | | | Merge tag 'v0.33.3rc2' into developRichard van der Hoff2018-08-2146-46/+91
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bugfixes -------- - Fix bug in v0.33.3rc1 which caused infinite loops and OOMs ([\#3723](https://github.com/matrix-org/synapse/issues/3723))
| * | | | | | | | | | | | changelog v0.33.3rc2Amber Brown2018-08-213-2/+10
| | | | | | | | | | | | |
| * | | | | | | | | | | | Merge pull request #3723 from matrix-org/rav/fix_logcontext_disasterAmber Brown2018-08-213-3/+18
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix exceptions when a connection is closed before we read the headers
| | * | | | | | | | | | | | changelogRichard van der Hoff2018-08-201-0/+1
| | | | | | | | | | | | | |
| | * | | | | | | | | | | | Fix exceptions when a connection is closed before we read the headersRichard van der Hoff2018-08-202-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes bugs introduced in #3700, by making sure that we behave sanely when an incoming connection is closed before the headers are read.
| | * | | | | | | | | | | | Robustness fix for logcontext filterRichard van der Hoff2018-08-201-1/+7
| |/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the logcontext filter not explode if it somehow ends up with a logcontext of None, since that infinite-loops the whole logging system.