summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch 'rei/as_device_masquerading_msc3202' of ↵ github/anoa/e2e_as_internal_testing anoa/e2e_as_internal_testingAndrew Morgan2021-12-1086-194/+518
|\ | | | | | | github.com:matrix-org/synapse into anoa/e2e_as_internal_testing
| * Update tests to enable experimental featuresOlivier Wilkinson (reivilibre)2021-12-091-0/+3
| |
| * Add an experimental flag to control device masqueradingOlivier Wilkinson (reivilibre)2021-12-092-1/+9
| |
| * Add a pair of tests for the ?device_id parameter for AS device masqueradingOlivier Wilkinson (reivilibre)2021-12-091-0/+61
| |
| * Switch to the 400 M_EXCLUSIVE error code for non-existent device IDsOlivier Wilkinson (reivilibre)2021-12-091-1/+4
| | | | | | | | This is as a result of a discussion on the MSC
| * NewsfileOlivier Wilkinson (reivilibre)2021-12-081-0/+1
| | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Allow masquerading as a device by specifying the device_id URI parameterOlivier Wilkinson (reivilibre)2021-12-081-1/+18
| |
| * Add get_device_opt which returns None instead of raising if it doesn't existOlivier Wilkinson (reivilibre)2021-12-081-0/+22
| |
| * Remove early return because we need more logic hereOlivier Wilkinson (reivilibre)2021-12-081-7/+8
| |
| * Remove superfluous linesOlivier Wilkinson (reivilibre)2021-12-081-2/+0
| |
| * Expand get_user_by_req to support handling a device IDOlivier Wilkinson (reivilibre)2021-12-081-5/+13
| |
| * Expand return type of get_appservice_user_id to allow returning a device ID ↵Olivier Wilkinson (reivilibre)2021-12-081-8/+36
| | | | | | | | to masquerade as
| * Improve log messages for stream ids (#11536)Richard van der Hoff2021-12-083-4/+7
| | | | | | | | Somehow I'd managed to get my database in a pickle with stream ids. These changes were useful to debug.
| * Send and handle cross-signing messages using the stable prefix. (#10520)Hubert Chathi2021-12-084-5/+13
| |
| * Fix case in `wait_for_background_updates` where `self.store` does not exist ↵Andrew Morgan2021-12-072-7/+5
| | | | | | | | | | | | (#11331) Pull the DataStore from the HomeServer instance, which always exists.
| * Sort internal changes in changelog v1.49.0rc1Sean Quah2021-12-071-16/+16
| |
| * Update CHANGES.mdSean Quah2021-12-071-30/+26
| |
| * 1.49.0rc1Sean Quah2021-12-0765-63/+87
| |
| * Revert "Move `glob_to_regex` and `re_word_boundary` to ↵Sean Quah2021-12-078-12/+124
| | | | | | | | | | | | `matrix-python-common` (#11505) (#11527) This reverts commit a77c36989785c0d5565ab9a1169f4f88e512ce8a.
| * Refactors in `_generate_sync_entry_for_rooms` (#11515)David Robertson2021-12-073-46/+79
| | | | | | | | | | | | | | | | * Move sync_token up to the top * Pull out _get_ignored_users * Try to signpost the body of `_generate_sync_entry_for_rooms` * Pull out _calculate_user_changes Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * Correctly register shutdown handler for presence workers (#11518)David Robertson2021-12-072-1/+2
| | | | | | Fixes #11517
| * Fix `ModuleApi.looping_background_call` for non-async functions (#11524)Sean Quah2021-12-072-3/+3
| | | | | | | | | | | | After #10847, `looping_background_call` would print an error in the logs every time a non-async function was called. Since the error would be caught and ignored immediately, there were no other side effects.
| * Fix 'delete room' admin api to work on incomplete rooms (#11523)Richard van der Hoff2021-12-075-37/+33
| | | | | | | | | | If, for some reason, we don't have the create event, we should still be able to purge a room.
| * Correctly ignore invites from ignored users (#11511)David Robertson2021-12-072-5/+7
| |
| * Fix the test breakage introduced by #11435 as a result of concurrent PRs ↵reivilibre2021-12-072-1/+2
| | | | | | | | (#11522)
* | store argument is no longer optional in is_interested_in_roomAndrew Morgan2021-12-103-11/+11
| |
* | Squash into and use everywhereAndrew Morgan2021-12-101-5/+5
| |
* | Update reset device list mock before starting testsAndrew Morgan2021-12-101-0/+3
| |
* | Squash into "and use everywhere"Andrew Morgan2021-12-101-1/+2
| |
* | Squash into "and use everywhere"Andrew Morgan2021-12-101-1/+0
| |
* | squash into 'and use everywhere'Andrew Morgan2021-12-091-3/+3
| |
* | squash into move DeviceLists commitAndrew Morgan2021-12-091-0/+1
| |
* | squash into 'and use everywhere'Andrew Morgan2021-12-099-18/+18
| |
* | Support sending device lists everywhere; needs cleaning upAndrew Morgan2021-12-096-41/+121
| |
* | Squash into "and use everywhere"Andrew Morgan2021-12-091-1/+2
| |
* | fix tests for device listsAndrew Morgan2021-12-094-29/+79
| |
* | Create ApplicationService.is_interested_in_user, and use everywhereAndrew Morgan2021-12-091-0/+25
| |
* | Switch DeviceLists to containing Sets, as we'll need a type that we can ↵Andrew Morgan2021-12-092-5/+9
| | | | | | | | delete items from
* | Move DeviceLists type to synapse.typesAndrew Morgan2021-12-082-26/+18
| | | | | | | | Such that we can use it elsewhere.
* | Fix up database method to grab device list changes - bit dirtyAndrew Morgan2021-12-081-12/+19
| |
* | Add device_list as one of the supported streams set_typeAndrew Morgan2021-12-081-1/+1
| |
* | wip: get device lists working squashmeAndrew Morgan2021-12-081-1/+5
| |
* | migration delta to track device_list stream id per appserviceAndrew Morgan2021-12-081-0/+18
| |
* | Fix calling is_interested_in_event with store.Andrew Morgan2021-12-081-1/+1
| |
* | wip: get device lists workingAndrew Morgan2021-12-082-83/+102
| | | | | | | | still need a way to put them in the top-level of the transaction json
* | is_interested_in_room publicAndrew Morgan2021-12-081-2/+2
| |
* | Add some caching to interest methodsAndrew Morgan2021-12-081-12/+37
| | | | | | | | | | | | | | | | This also fixes (I believe) is_interested_in_presence, the cache of which was never invalidated. Note that namespaces can only be changed via a server restart. Users leaving and joining rooms do change on the fly though.
* | Refactor appservice interest-checking methodsAndrew Morgan2021-12-081-39/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit refactors the methods of an application service which can be used to determine whether an appservice is interested in a given user, event or room. We now have the following list of functions: is_user_in_namespace is_room_alias_in_namespace is_room_id_in_namespace is_interested_in_event is_interested_in_room Which is clearer than before. There is no `is_interested_in_user`, as it would be equivalent to is_user_in_namespace.
* | Clean up reference to homeserver storeAndrew Morgan2021-12-081-4/+2
| |
* | rename ApplicationService.is_interested_in_room_id -> is_room_id_in_namespaceAndrew Morgan2021-12-081-2/+2
| |
* | rename ApplicationService.is_interested_in_alias -> is_room_alias_in_namespaceAndrew Morgan2021-12-083-6/+6
| |
* | rename ApplicationService.is_interested_in_user -> is_user_in_namespaceAndrew Morgan2021-12-087-14/+14
| |
* | rename ApplicationServices.is_interested -> is_interested_in_eventAndrew Morgan2021-12-083-12/+38
| |
* | wipAndrew Morgan2021-12-083-4/+103
| |
* | Add docstring to add_device_change_to_streams and fix types.Andrew Morgan2021-12-081-6/+16
| |
* | possible perf boost to calculating device list update recipientsAndrew Morgan2021-12-082-9/+9
| |
* | Add an experimental config option for sending device lists to AS'sAndrew Morgan2021-12-081-0/+4
| |
* | Fix calls to create_appservice_txn in testsAndrew Morgan2021-12-071-4/+12
| |
* | Merge branch 'develop' of github.com:matrix-org/synapse into ↵Andrew Morgan2021-12-07315-3841/+10682
|\| | | | | | | anoa/e2e_as_to_device
| * Stabilise support for MSC2918 refresh tokens as they have now been merged ↵reivilibre2021-12-066-44/+115
| | | | | | | | into the Matrix specification. (#11435)
| * Save the OIDC session ID (sid) with the device on login (#11482)Quentin Gliech2021-12-0615-65/+370
| | | | | | As a step towards allowing back-channel logout for OIDC.
| * Add admin API to get some information about federation status (#11407)Dirk Klimpel2021-12-067-0/+783
| |
| * Include bundled aggregations in /sync and related fixes (#11478)Patrick Cloke2021-12-0610-101/+169
| | | | | | | | | | | | | | | | Due to updates to MSC2675 this includes a few fixes: * Include bundled aggregations for /sync. * Do not include bundled aggregations for /initialSync and /events. * Do not bundle aggregations for state events. * Clarifies comments and variable names.
| * Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)Sean Quah2021-12-068-123/+13
| |
| * Update backward extremity docs to make it clear that it does not indicate ↵Eric Eastwood2021-12-032-9/+8
| | | | | | | | | | | | | | whether we have fetched an events' `prev_events` (#11469) Spawning from https://github.com/matrix-org/synapse/pull/9445#discussion_r758958181 Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * Support configuring the lifetime of non-refreshable access tokens separately ↵reivilibre2021-12-035-3/+221
| | | | | | | | to refreshable access tokens. (#11445)
| * Add type hints to `synapse/tests/rest/admin` (#11501)Dirk Klimpel2021-12-0311-228/+257
| |
| * Revert accidental commits to develop.Olivier Wilkinson (reivilibre)2021-12-035-195/+185
| |
| * NewsfileOlivier Wilkinson (reivilibre)2021-12-031-0/+1
| | | | | | | | Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
| * Give `tests.server.setup_test_homeserver` (nominally!) the same behaviourOlivier Wilkinson (reivilibre)2021-12-031-0/+3
| | | | | | | | | | | | | | | | | | | | by calling into `make_test_homeserver_synchronous`. The function *could* have been inlined at this point but the function is big enough and it felt fine to leave it as is. At least there isn't a confusing name clash anymore!
| * Move `tests.utils.setup_test_homeserver` to `tests.server`Olivier Wilkinson (reivilibre)2021-12-034-177/+188
| | | | | | | | | | | | | | It had no users. We have just taken the identity of a previous function but don't provide the same behaviour, so we need to fix this in the next commit...
| * Convert one of the `setup_test_homeserver`s to ↵Olivier Wilkinson (reivilibre)2021-12-031-8/+3
| | | | | | | | | | | | | | | | `make_test_homeserver_synchronous` and pass in the homeserver rather than calling a same-named function to ask for one. Later commits will jiggle things around to make this sensible.
| * Disambiguate queries on `state_key` (#11497)Richard van der Hoff2021-12-027-16/+21
| | | | | | | | | | We're going to add a `state_key` column to the `events` table, so we need to add some disambiguation to queries which use it.
| * Comments on the /sync tentacles (#11494)David Robertson2021-12-023-43/+129
| | | | | | | | | | This mainly consists of docstrings and inline comments. There are one or two type annotations and variable renames thrown in while I was here. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
| * Clean up tests.storage.test_appservice (#11492)reivilibre2021-12-022-177/+169
| |
| * Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)reivilibre2021-12-022-17/+11
| |
| * Clean up `tests.test_visibility` to remove legacy code. (#11495)reivilibre2021-12-023-203/+40
| |
| * Minor cleanup on recently ported doc pages (#11466)Shay2021-12-025-46/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * requested changes to admin_faq.md * requested changes to database_maintenance_tools.md * requested changes to understanding_synapse_through_graphana_graphs.md * add changelog * fix leftover merge errata * fix unwanted changes from merge * use two spaces between entries * outdent code blocks
| * Add most of the missing type hints to `synapse.federation`. (#11483)Patrick Cloke2021-12-0210-49/+84
| | | | | | This skips a few methods which are difficult to type.
| * Avoid waiting for zombie processes in `synctl stop` (#11490)Sean Quah2021-12-022-3/+17
| |
| * Fix media repository failing when media store path contains symlinks (#11446)Sean Quah2021-12-023-45/+180
| |
| * Add type annotations to `tests.storage.test_appservice`. (#11488)reivilibre2021-12-025-53/+98
| |
| * `scripts-dev/sign_json`: support for signing events (#11486)Richard van der Hoff2021-12-023-1/+43
| |
| * Add MSC3030 experimental client and federation API endpoints to get the ↵Eric Eastwood2021-12-0213-31/+674
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | closest event to a given timestamp (#9445) MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030 Client API endpoint. This will also go and fetch from the federation API endpoint if unable to find an event locally or we found an extremity with possibly a closer event we don't know about. ``` GET /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Federation API endpoint: ``` GET /_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Co-authored-by: Erik Johnston <erik@matrix.org>
| * Port wiki pages to documentation website (#11402)Shay2021-12-019-0/+483
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * revert unintentional change to CHANGES.md * add link Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update CHANGES.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
| * Add a license header and comment. (#11479)Patrick Cloke2021-12-012-0/+16
| |
| * Clean-up get_version_string (#11468)Patrick Cloke2021-12-012-57/+26
| |
| * Link background update controller docs to summary (#11475)Brendan Abolivier2021-12-012-0/+2
| |
| * Additional type hints for config module. (#11465)Patrick Cloke2021-12-0115-99/+129
| | | | | | | | This adds some misc. type hints to helper methods used in the `synapse.config` module.
| * Register the login redirect endpoint for v3. (#11451)Patrick Cloke2021-12-013-3/+4
| | | | | | As specified for Matrix v1.1.
| * Update openid.mdRichard van der Hoff2021-12-011-1/+1
| | | | | | fix header level
| * Remove mention of OIDC certification from Dex (#11470)Etienne Dysli Metref2021-12-011-1/+1
| | | | | | | | | | | | | | Dex isn't yet [1,2] a certified OpenID Provider implementation. As of today, it's not on the list maintained by the OpenID Foundation. [3] [1] https://github.com/dexidp/dex/issues/42 [2] https://github.com/dexidp/dex/issues/262 [3] https://openid.net/certification/
| * Add a note about huge pages to our Postgres doc (#11467)Shay2021-11-302-0/+4
| | | | | | | | | | * Add note to postgres doc about hugepages * Newsfragment
| * Don't start Synapse master process if `worker_app` is set (#11416)Shay2021-11-303-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add check to catch syanpse master process starting when workers are configured * add test to verify that starting master process with worker config raises error * newsfragment * specify config.worker.worker_app in check * update test * report specific config option that triggered the error Co-authored-by: reivilibre <oliverw@matrix.org> * clarify error message Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>
| * Expose worker & homeserver as entrypoints in `setup.py` (#11449)Maximilian Bosch2021-11-303-1/+12
| | | | | | Co-authored-by: reivilibre <oliverw@matrix.org>
| * Bundle relations of relations into the `/relations` result. (#11284)Patrick Cloke2021-11-304-6/+130
| | | | | | | | | | Per updates to MSC2675 which now states that bundled aggregations should be included from the `/relations` endpoint.
| * Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)Sean Quah2021-11-303-1/+17
| | | | | | | | | | | | | | | | | | | | | | When all entries in an `LruCache` have a size of 0 according to the provided `size_callback`, and `drop_from_cache` is called on a cache node, the node would be unlinked from the LRU linked list but remain in the cache dictionary. An assertion would be later be tripped due to the inconsistency. Avoid unintentionally calling `__len__` and use a strict `is None` check instead when unwrapping the weak reference.
| * Eliminate a few `Any`s in `LruCache` type hints (#11453)Sean Quah2021-11-304-19/+32
| |
| * Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)Dirk Klimpel2021-11-302-41/+21
| | | | | | | | | | The tests helpers automatically convert dictionaries to JSON payloads, no need to do it manually for each test.
| * Merge branch 'master' into developBrendan Abolivier2021-11-3072-71/+101
| |\
| | * Merge trust_identity_server_for_password_resets PRs v1.48.0Brendan Abolivier2021-11-301-2/+1
| | |
| | * Move notices upBrendan Abolivier2021-11-301-5/+4
| | |
| | * Fixup changelogBrendan Abolivier2021-11-301-1/+1
| | |
| | * 1.48.0Brendan Abolivier2021-11-303-1/+13
| | |
| | * Fix docker hub name v1.48.0rc1Brendan Abolivier2021-11-251-1/+1
| | |
| | * Incorporate review from synapse-devBrendan Abolivier2021-11-251-10/+12
| | |
| | * Fixup changelogBrendan Abolivier2021-11-251-13/+12
| | |
| | * 1.48.0rc1Brendan Abolivier2021-11-2572-71/+90
| | |
| * | Add missing copyright header. (#11460)Patrick Cloke2021-11-302-0/+15
| | |
| * | synctl stop: wait for processes to exit (#11459)Richard van der Hoff2021-11-302-25/+15
| | | | | | | | | | | | | | | If you're trying to shut down Synapse, it's rather handy if it *actually* shuts down before you move on.
| * | Improved push typing (#11409)Marcus2021-11-307-36/+210
| | | | | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
| * | Convert status codes to `HTTPStatus` in `tests.rest.admin` (#11455)Dirk Klimpel2021-11-3012-557/+887
| | |
| * | Convert status codes to `HTTPStatus` in `synapse.rest.admin` (#11452)Dirk Klimpel2021-11-2912-171/+276
| | |
| * | Refactor `backfilled` into specific behavior function arguments ↵Eric Eastwood2021-11-293-21/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (`_persist_events_and_state_updates`) (#11417) Part of https://github.com/matrix-org/synapse/issues/11300 Call stack: - `_persist_events_and_state_updates` (added `use_negative_stream_ordering`) - `_persist_events_txn` - `_update_room_depths_txn` (added `update_room_forward_stream_ordering`) - `_update_metadata_tables_txn` - `_store_room_members_txn` (added `inhibit_local_membership_updates`) Using keyword-only arguments (`*`) to reduce the mistakes from `backfilled` being left as a positional argument somewhere and being interpreted wrong by our new arguments.
| * | Support the stable /hierarchy endpoint from MSC2946 (#11329)Patrick Cloke2021-11-2911-51/+134
| | | | | | | | | | | | | | | | | | This also makes additional updates where the implementation had drifted from the approved MSC. Unstable endpoints will be removed at a later data.
| * | Make background updates controllable via a plugin (#11306)Erik Johnston2021-11-2912-61/+407
| | | | | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
| * | Return the stable `event` field from `/send_join` per MSC3083. (#11413)Patrick Cloke2021-11-295-4/+19
| | | | | | | | | | | | | | | This does not remove the unstable field and still parses both. Handling of the unstable field will need to be removed in the future.
| * | Update the media repository documentation (#11415)Sean Quah2021-11-292-19/+71
| | |
| * | Add type annotations to some of the configuration surrounding refresh ↵reivilibre2021-11-293-2/+11
| | | | | | | | | | | | tokens. (#11428)
| * | Fix perspectives requests for multiple keys for the same server (#11440)Richard van der Hoff2021-11-293-11/+91
| | | | | | | | | | | | | | | If we tried to request multiple keys for the same server, we would end up dropping some of those requests.
| * | Fix using MSC2716 batch sending with event persistence workers (#11220)Tulir Asokan2021-11-293-0/+8
| | | | | | | | | | | | Signed-off-by: Tulir Asokan <tulir@beeper.com>
| * | disallow-untyped-defs for the module_api (#11029)David Robertson2021-11-293-30/+59
| | |
| * | Fix changelog filename in #11441David Robertson2021-11-291-0/+0
| | |
| * | Add a test case for the SendJoinParser (#11441)David Robertson2021-11-293-0/+55
| | | | | | | | | This would have caught the bug #11438 introduced in #11217 and fixed in #11439.
| * | Bump ijson dependency to 3.1 (#11438) (#11439)Daniel Molkentin2021-11-262-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since e81fa9264873369653171157514ff68226491fff, Synapse depends on the use_float flag which has been introduced in ijson 3.1 and is not available in 3.0. This is known to cause runtime errors with send_join. Signed-off-by: Daniel Molkentin <danimo@infra.run> Co-authored-by: Daniel Molkentin <danimo@infra.run>
| * | Update MSC2918 refresh token support to confirm with the latest revision: ↵reivilibre2021-11-264-22/+58
| | | | | | | | | | | | accept the `refresh_tokens` parameter in the request body rather than in the URL parameters. (#11430)
| * | Add type hints to `synapse/storage/databases/main/events_worker.py` (#11411)Sean Quah2021-11-2613-171/+255
| | | | | | | | | | | | Also refactor the stream ID trackers/generators a bit and try to document them better.
| * | Support expiry of refresh tokens and expiry of the overall session when ↵reivilibre2021-11-268-54/+338
| | | | | | | | | | | | refresh tokens are in use. (#11425)
| * | Create healthcheck script for synapse-workers container (#11429)Michael Kaye2021-11-264-0/+23
| | | | | | | | | | | | | | | The intent is to iterate through all the worker ports and only report healthy when all are healthy, starting with the main process.
| * | Track ongoing event fetches correctly (again) (#11376)Sean Quah2021-11-263-43/+251
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous fix for the ongoing event fetches counter (8eec25a1d9d656905db18a2c62a5552e63db2667) was both insufficient and incorrect. When the database is unreachable, `_do_fetch` never gets run and so `_event_fetch_ongoing` is never decremented. The previous fix also moved the `_event_fetch_ongoing` decrement outside of the `_event_fetch_lock` which allowed race conditions to corrupt the counter.
| * | Annotate string constants in `synapse.api.constants` with `Final` (#11356)Sean Quah2021-11-252-98/+101
| |/ | | | | | | | | | | | | | | | | | | This change makes mypy complain if the constants are ever reassigned, and, more usefully, makes mypy type them as `Literal`s instead of `str`s, allowing code of the following form to pass mypy: ```py def do_something(membership: Literal["join", "leave"], ...): ... do_something(Membership.JOIN, ...) ```
| * Improve performance of `remove_{hidden,deleted}_devices_from_device_inbox` ↵Brendan Abolivier2021-11-254-148/+84
| | | | | | | | | | (#11421) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * Lower minumum batch size to 1 for background updates (#11422)Brendan Abolivier2021-11-244-13/+23
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| * Rename unstable `access_token_lifetime` configuration option to ↵reivilibre2021-11-236-16/+36
| | | | | | | | `refreshable_access_token_lifetime` to make it clear it only concerns refreshable access tokens. (#11388)
| * Add missing type hints to config base classes (#11377)Patrick Cloke2021-11-2313-109/+184
| |
| * Remove code invalidated by deprecated config flag ↵Shay2021-11-234-41/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'trust_identity_servers_for_password_resets' (#11395) * remove background update code related to deprecated config flag * changelog entry * update changelog * Delete 11394.removal Duplicate, wrong number * add no-op background update and change newfragment so it will be consolidated with associated work * remove unused code * Remove code associated with deprecated flag from legacy docker dynamic config file Co-authored-by: reivilibre <oliverw@matrix.org>
| * Merge branch 'master' into developSean Quah2021-11-238-51/+513
| |\
| | * Merge tag 'v1.47.1'Sean Quah2021-11-238-51/+513
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.47.1 (2021-11-23) =========================== This release fixes a security issue in the media store, affecting all prior releases of Synapse. Server administrators are encouraged to update Synapse as soon as possible. We are not aware of these vulnerabilities being exploited in the wild. Server administrators who are unable to update Synapse may use the workarounds described in the linked GitHub Security Advisory below. Security advisory ----------------- The following issue is fixed in 1.47.1. - **[GHSA-3hfw-x7gx-437c](https://github.com/matrix-org/synapse/security/advisories/GHSA-3hfw-x7gx-437c) / [CVE-2021-41281](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-41281): Path traversal when downloading remote media.** Synapse instances with the media repository enabled can be tricked into downloading a file from a remote server into an arbitrary directory, potentially outside the media store directory. The last two directories and file name of the path are chosen randomly by Synapse and cannot be controlled by an attacker, which limits the impact. Homeservers with the media repository disabled are unaffected. Homeservers configured with a federation whitelist are also unaffected. Fixed by [91f2bd090](https://github.com/matrix-org/synapse/commit/91f2bd090).
| | | * Add CVE number v1.47.1Sean Quah2021-11-191-1/+1
| | | |
| | | * Refer to 1.47.1 without the vSean Quah2021-11-191-1/+1
| | | |
| | | * Update 1.47.1 release date in CHANGES.mdSean Quah2021-11-191-1/+1
| | | |
| | | * 1.47.1Sean Quah2021-11-193-1/+30
| | | |
| | | * Prevent the media store from writing outside of the configured directorySean Quah2021-11-195-50/+483
| | | | | | | | | | | | | | | | | | | | Also tighten validation of server names by forbidding invalid characters in IPv6 addresses and empty domain labels.
| * | | Refactor the code to inject bundled relations during serialization. (#11408)Patrick Cloke2021-11-238-73/+92
| | | |
| * | | Add config for customizing the claim used for JWT logins. (#11361)Kostas2021-11-226-35/+57
| | | | | | | | | | | | | | | | | | | | Allows specifying a different claim (from the default "sub") to use when calculating the localpart of the Matrix ID used during the JWT login.
| * | | Store arbitrary relations from events. (#11391)Patrick Cloke2021-11-226-45/+193
| | | | | | | | | | | | | | | | | | | | Instead of only known relation types. This also reworks the background update for thread relations to crawl events and search for any relation type, not just threaded relations.
| * | | Update README.mdShay2021-11-191-2/+4
| | | |
| * | | Add an admin API to run background jobs. (#11352)Dirk Klimpel2021-11-199-43/+280
| | | | | | | | | | | | | | | | | | | | | | | | Instead of having admins poke into the database directly. Can currently run jobs to populate stats and to populate the user directory.
| * | | Fix checking whether a room can be published on creation. (#11392)Patrick Cloke2021-11-194-56/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If `room_list_publication_rules` was configured with a rule with a non-wildcard alias and a room was created with an alias then an internal server error would have been thrown. This fixes the error and properly applies the publication rules during room creation.
| * | | Remove dead code from acme support. (#11393)Patrick Cloke2021-11-192-50/+1
| | | |
| * | | Remove msc2716 from the list of tests for complement. (#11389)Patrick Cloke2021-11-192-1/+2
| | | | | | | | | | | | As the tests are currently failing and not run in CI.
| * | | Keep fallback key marked as used if it's re-uploaded (#11382)Hubert Chathi2021-11-193-12/+72
| | | |
| * | | Publish a `develop` docker image (#11380)Richard van der Hoff2021-11-192-1/+5
| | | | | | | | | | | | | | | | I'd find it helpful to have a docker image corresponding to current develop, without having to build my own.
| * | | Fix verification of objects signed with old local keys (#11379)Richard van der Hoff2021-11-193-31/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a bug introduced in #11129: objects signed by the local server, but with keys other than the current one, could not be successfully verified. We need to check the key id in the signature, and track down the right key.
| * | | Prevent historical state from being pushed to an application service via ↵Eric Eastwood2021-11-184-2/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `/transactions` (MSC2716) (#11265) Mark historical state from the MSC2716 `/batch_send` endpoint as `historical` which makes it `backfilled` and have a negative `stream_ordering` so it doesn't get queried by `/transactions`. Fix https://github.com/matrix-org/synapse/issues/11241 Complement tests: https://github.com/matrix-org/complement/pull/221
| * | | Remove legacy code related to deprecated ↵Shay2021-11-185-47/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `trust_identity_server_for_password_resets` config flag (#11333) * remove code legacy code related to deprecated config flag "trust_identity_server_for_password_resets" from synapse/config/emailconfig.py * remove legacy code supporting depreciated config flag "trust_identity_server_for_password_resets" from synapse/config/registration.py * remove legacy code supporting depreciated config flag "trust_identity_server_for_password_resets" from synapse/handlers/identity.py * add tests to ensure config error is thrown and synapse refuses to start when depreciated config flag is found * add changelog * slightly change behavior to only check for deprecated flag if set to 'true' * Update changelog.d/11333.misc Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>
| * | | Add dedicated admin API for blocking a room (#11324)Dirk Klimpel2021-11-186-0/+404
| | | |
| * | | Add/Unerase annotations to Module API (#11341)reivilibre2021-11-182-23/+135
| | | |
| * | | Rename `get_refresh_token_for_user_id` to `create_refresh_token_for_user_id` ↵reivilibre2021-11-183-3/+4
| | | | | | | | | | | | | | | | (#11370)
| * | | Use auto_attribs for RefreshTokenLookupResult (#11386)reivilibre2021-11-182-7/+8
| | | |
| * | | Do not allow MSC3440 threads to fork threads (#11161)Patrick Cloke2021-11-184-8/+176
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds validation to the Client-Server API to ensure that the potential thread head does not relate to another event already. This results in not allowing a thread to "fork" into other threads. If the target event is unknown for some reason (maybe it isn't visible to your homeserver), but is the target of other events it is assumed that the thread can be created from it. Otherwise, it is rejected as an unknown event.
| * | | Docs: Quote wildcard `federation_certificate_verification_whitelist` (#11381)Nicolai Søborg2021-11-183-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise I get this beautiful stacktrace: ``` python3 -m synapse.app.homeserver --config-path /etc/matrix/homeserver.yaml Traceback (most recent call last): File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/root/synapse/synapse/app/homeserver.py", line 455, in <module> main() File "/root/synapse/synapse/app/homeserver.py", line 445, in main hs = setup(sys.argv[1:]) File "/root/synapse/synapse/app/homeserver.py", line 345, in setup config = HomeServerConfig.load_or_generate_config( File "/root/synapse/synapse/config/_base.py", line 671, in load_or_generate_config config_dict = read_config_files(config_files) File "/root/synapse/synapse/config/_base.py", line 717, in read_config_files yaml_config = yaml.safe_load(file_stream) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 125, in safe_load return load(stream, SafeLoader) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 81, in load return loader.get_single_data() File "/root/synapse/env/lib/python3.8/site-packages/yaml/constructor.py", line 49, in get_single_data node = self.get_single_node() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 55, in compose_document node = self.compose_node(None, None) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node item_value = self.compose_node(node, item_key) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 82, in compose_node node = self.compose_sequence_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 110, in compose_sequence_node while not self.check_event(SequenceEndEvent): File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 98, in check_event self.current_event = self.state() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 379, in parse_block_sequence_first_entry return self.parse_block_sequence_entry() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 384, in parse_block_sequence_entry if not self.check_token(BlockEntryToken, BlockEndToken): File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 116, in check_token self.fetch_more_tokens() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 227, in fetch_more_tokens return self.fetch_alias() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 610, in fetch_alias self.tokens.append(self.scan_anchor(AliasToken)) File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 922, in scan_anchor raise ScannerError("while scanning an %s" % name, start_mark, yaml.scanner.ScannerError: while scanning an alias in "/etc/matrix/homeserver.yaml", line 614, column 5 expected alphabetic or numeric character, but found '.' in "/etc/matrix/homeserver.yaml", line 614, column 6 ``` Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>
| * | | Add type annotations to `synapse.metrics` (#10847)Sean Quah2021-11-1712-85/+173
| | | |
| * | | Add support for `/_matrix/media/v3` APIs (#11371)Aaron R2021-11-176-51/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add support for `/_matrix/media/v3` APIs Signed-off-by: Aaron Raimist <aaron@raim.ist> * Update `workers.md` to use v3 client and media APIs Signed-off-by: Aaron Raimist <aaron@raim.ist> * Add changelog Signed-off-by: Aaron Raimist <aaron@raim.ist>
| * | | Merge branch 'master' into developDavid Robertson2021-11-175-3/+15
| |\| |
| | * | Merge remote-tracking branch 'origin/release-v1.47'David Robertson2021-11-17168-1293/+4113
| | |\|
| | | * 1.47.0 v1.47.0David Robertson2021-11-173-1/+13
| | | |
| | * | Correct target of link to the modules page from the Password Auth Providers ↵reivilibre2021-11-121-1/+1
| | | | | | | | | | | | | | | | page (#11309)
| | * | Wrong DTLS port in "Troubleshooting" (#11268)jmcparland2021-11-081-1/+1
| | | | | | | | | | | | Port 5349, not 5479.
| * | | Rename `get_access_token_for_user_id` method to ↵reivilibre2021-11-177-15/+16
| | | | | | | | | | | | | | | | `create_access_token_for_user_id` (#11369)
| * | | Fix running complement.sh script. (#11368)Patrick Cloke2021-11-172-3/+4
| | | | | | | | | | | | | | | | By reverting changes from #11166 in this script. Specifically commit 13f084eb58c379b2fc073680818d5931e94626f4.
| * | | Fix incorrect return value in tests. (#11359)Patrick Cloke2021-11-162-1/+2
| | | |
| * | | Merge tag 'v1.47.0rc3' into developDavid Robertson2021-11-166-21/+103
| |\ \ \ | | | |/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.47.0rc3 (2021-11-16) ============================== Bugfixes -------- - Fix a bug introduced in 1.47.0rc1 which caused worker processes to not halt startup in the presence of outstanding database migrations. ([\#11346](https://github.com/matrix-org/synapse/issues/11346)) - Fix a bug introduced in 1.47.0rc1 which prevented the 'remove deleted devices from `device_inbox` column' background process from running when updating from a recent Synapse version. ([\#11303](https://github.com/matrix-org/synapse/issues/11303), [\#11353](https://github.com/matrix-org/synapse/issues/11353))
| | * | fix up changelog language v1.47.0rc3Andrew Morgan2021-11-161-1/+1
| | | |
| | * | mark the migration file migration as a bugAndrew Morgan2021-11-161-6/+1
| | | |
| | * | 1.47.0rc3Andrew Morgan2021-11-166-4/+22
| | | |
| | * | Rename `remove_deleted_devices_from_device_inbox` to ensure it is always run ↵Andrew Morgan2021-11-162-1/+14
| | | | | | | | | | | | | | | | | | | | (#11353) Co-authored-by: reivilibre <oliverw@matrix.org>
| | * | Run _upgrade_existing_database on workers if at current schema_version (#11346)Andrew Morgan2021-11-153-19/+74
| | | | | | | | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
| | * | Move sql file for `remove_deleted_devices_from_device_inbox` into v65 (#11303)Dirk Klimpel2021-11-152-1/+2
| | | |
| * | | Avoid sharing room hierarchy responses between users (#11355)Sean Quah2021-11-163-2/+65
| | | | | | | | | | | | | | | | | | | | Different users may be allowed to see different rooms within a space, so sharing responses between users is inadvisable.
| * | | Add support for `/_matrix/client/v3` APIs (#11318)Aaron R2021-11-164-3/+5
| | | | | | | | | | | | | | | | | | | | This is one of the changes required to support Matrix 1.1 Signed-off-by: Aaron Raimist <aaron@raim.ist>
| * | | Add most missing type hints to synapse.util (#11328)Patrick Cloke2021-11-1610-165/+161
| | | |
| * | | Properly register all callback hooks for legacy password authentication ↵reivilibre2021-11-162-13/+14
| | | | | | | | | | | | | | | | | | | | providers (#11340) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | | Modify tests to handle new location of to-device messages in AS txnsAndrew Morgan2021-12-032-47/+52
| | | |
* | | | Insert to-device messages into the new to-device part of AS txnsAndrew Morgan2021-12-032-6/+32
| | | |
* | | | Add to-device messages as their own special section in AS txnsAndrew Morgan2021-12-033-8/+39
| | | |
* | | | Fix tests to mock _TransactionController.send of ↵Andrew Morgan2021-12-033-25/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ApplicationServiceScheduler.enqueue* With enqueue_for_appservice being called per-event per-appservice, it's not a great target for mocking. So we use _TransactionController.send instead, to track things that are actually sent out to AS's. This also has the benefit of testing a wider bit of the AS txn pipeline
* | | | Refactor and generalise the sending of arbitrary fields over AS transactionsAndrew Morgan2021-12-032-34/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Things were starting to get a little inflexible as we kept adding new types of data to send to application services. It's better to just have one method for adding data to AS transactions, than one for each type of data. Note that subsequent PRs will need to add device lists, one-time keys and fallback keys to these transactions. Adding those are additional arguments to a method is much nicer than a new method for each one. Plus with this setup we can add multiple different types of data at once without kicking off an AS transaction for each type. This will be useful for OTK/fallback keys, as we plan to lazily attach those when handling other event types.
* | | | Add comment on why we don't NOT NULL to_device_stream_idAndrew Morgan2021-11-241-0/+5
| | | |
* | | | Add some FIXME commentsAndrew Morgan2021-11-241-0/+3
| | | |
* | | | rename set_type_stream_id_for_appservice -> set_appservice_stream_type_posAndrew Morgan2021-11-244-13/+13
| | | |
* | | | Fix existing unit tests github/anoa/e2e_as anoa/e2e_asAndrew Morgan2021-11-221-8/+5
| | | | | | | | | | | | | | | | There is so much mocking going on here. I look forward to replacing these one day.
* | | | Simplify registration of appservices in testsAndrew Morgan2021-11-191-64/+51
| | | |
* | | | Rename user1, user2 in tests to something more usefulAndrew Morgan2021-11-191-30/+51
| | | |
* | | | Rename ApplicationServiceEphemeralEventsTestCaseAndrew Morgan2021-11-191-1/+5
| | | |
* | | | _handle_to_device -> _get_to_device_messagesAndrew Morgan2021-11-191-3/+7
| | | |
* | | | Deduplicate ephemeral events to send conditionalAndrew Morgan2021-11-193-28/+34
| | | | | | | | | | | | | | | | | | | | | | | | Test cases needed to be updated, as we now always call submit_ephemeral_events_for_as, it may just be with an empty events list.
* | | | Broaden type hints; update commentAndrew Morgan2021-11-192-5/+7
| | | |
* | | | Move stream filter back into AppserviceHandlerAndrew Morgan2021-11-192-17/+21
| | | |
* | | | Make msc2409_to_device_messages_enabled private; remove unnecessary checkAndrew Morgan2021-11-191-6/+3
| | | | | | | | | | | | | | | | | | | | The second check for self._msc2409_to_device_messages_enabled was not necessary. It's already checked in notify_interested_services_ephemeral earlier.
* | | | ChangelogAndrew Morgan2021-11-161-0/+1
| | | |
* | | | Add testsAndrew Morgan2021-11-161-4/+246
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I decided to spin up another test class for this as the existing one is 1. quite old and 2. was mocking away too much of the infrastructure to my liking. I've named the new class alluding to ephemeral messages, and while we already have some ephemeral tests in AppServiceHandlerTestCase, ideally I'd like to migrate those over. There's two new tests here. One for testing that to-device messages for a local user are received by any application services that have registered interest in that user - and that those that haven't won't receive those messages. The next test is similar, but tests with a whole bunch of to-device messages. Rather than actually registering tons of devices - which would make for a very slow unit test - we just directly insert them into the database.
* | | | Add a to_device_stream_id column to the application_services_state tableAndrew Morgan2021-11-161-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is for tracking the stream id that each application service has been sent up to. In other words, there shouldn't be any need to process stream ids below the recorded one here as the AS should have already received them. Note that there is no reliability built-in here. Reliability of delivery if intended for a separate PR.
* | | | Add database method to fetch to-device messages by user_ids from dbAndrew Morgan2021-11-161-1/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method is quite similar to the one below, except that it doesn't support device ids, and supports querying with more than one user id, both of which are relevant to application services. The results are also formatted in a different data structure, so I'm not sure how much we could really share here between the two methods.
* | | | Allow setting/getting stream id per appservice for to-device messagesAndrew Morgan2021-11-161-2/+2
| | | |
* | | | Add a new ephemeral AS handler for to_device message edusAndrew Morgan2021-11-162-15/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Here we add the ability for the application service ephemeral message processor to handle new events on the "to_device" stream. We keep track of a stream id (token) per application service, and every time a new to-device message comes in, for each appservice we pull the messages between the last-recorded and current stream id and check whether any of the messages are for a user in that appservice's user namespace. get_new_messages is implemented in the next commit. since we rebased off latest develop.
* | | | Add experimental config option to send to-device messages to AS'sAndrew Morgan2021-11-162-0/+11
|/ / /
* | | Add ability to un-shadow-ban via the admin API. (#11347)Patrick Cloke2021-11-165-12/+53
| | |
* | | Misc typing fixes for tests, part 2 of N (#11330)David Robertson2021-11-165-29/+66
| | |
* | | change 'Home Server' to one word 'homeserver' (#11320)Ashwin Nair2021-11-164-15/+16
| | | | | | | | | Signed-off-by: Ashwin S. Nair <58840757+Ashwin-exe@users.noreply.github.com>
* | | Database storage profile passes mypy (#11342)David Robertson2021-11-154-8/+21
| | | | | | | | | | | | | | | | | | It already seems to pass mypy. I wonder what changed, given that it was on the exclusion list. So this commit consists of me ensuring `--disallow-untyped-defs` passes and a minor fixup to a function that returned either `True` or `None`.
* | | Get directory db file to pass mypy (#11339)David Robertson2021-11-154-7/+11
| | |
* | | Add support for the stable version of MSC2778 (#11335)Tulir Asokan2021-11-154-4/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Add support for the stable version of MSC2778 Signed-off-by: Tulir Asokan <tulir@maunium.net> * Expect m.login.application_service in login and password provider tests Signed-off-by: Tulir Asokan <tulir@maunium.net>
* | | Remove unused tables `room_stats_historical` and `user_stats_historical` ↵Shay2021-11-123-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (#11280) * remove unused tables room_stats_historical and user_stats_historical * update changelog number * Bump schema compat version comment * make linter happy * Update comment to give more info Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>
* | | Annotations for state_deltas.py (#11316)David Robertson2021-11-123-4/+17
| | | | | | | | | | | | | | | I was sad that I couldn't do better for `_curr_state_delta_stream_cache`. At least it's explicitly called out in a comment with #TODO.
* | | Rollback #11322 due to wrong syntax in mypy.ini. (#11332)Patrick Cloke2021-11-122-2/+15
| | | | | | | | | | | | This was only checking the __init__ files in modules instead of all files in a module, which don't pass yet.
* | | Test room alias deletion (#11327)David Robertson2021-11-125-31/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Prefer `HTTPStatus` over plain `int` This is an Opinion that no-one has seemed to object to yet. * `--disallow-untyped-defs` for `tests.rest.client.test_directory` * Improve synapse's annotations for deleting aliases * Test case for deleting a room alias * Changelog
* | | Change display names/avatar URLs to None if they contain null bytes before ↵Shay2021-11-123-4/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | storing in DB (#11230) * change display names/avatar URLS to None if they contain null bytes * add changelog * add POC test, requested changes * add a saner test and remove old one * update test to verify that display name has been changed to None * make test less fragile
* | | Add type hints to media repository storage module (#11311)Patrick Cloke2021-11-124-62/+89
| | |
* | | Attempt to annotate events_forward_extremities (#11314)David Robertson2021-11-124-8/+17
| | | | | | | | | | | | | | | | | | * Make DataStore inherit from EventForwardExtremitiesStore before CacheInvalidationWorkerStore the former implicitly inherits from the latter, so they should be ordered like this when used.
* | | Misc typing fixes for `tests`, part 1 of N (#11323)David Robertson2021-11-127-29/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Annotate HomeserverTestCase.servlets * Correct annotation of federation_auth_origin * Use AnyStr custom_headers instead of a Union This allows (str, str) and (bytes, bytes). This disallows (str, bytes) and (bytes, str) * DomainSpecificString.SIGIL is a ClassVar
* | | Generalize the disallowed_untyped_defs in mypy.ini (#11322)Patrick Cloke2021-11-122-14/+3
| | |
* | | Add more type hints to synapse.util. (#11321)Patrick Cloke2021-11-123-15/+24
| | |
* | | Suggest using `/etc/matrix-synapse/conf.d/` for configuration with Debian ↵reivilibre2021-11-122-0/+7
| | | | | | | | | | | | packages (#11281)
* | | Convert delete room admin API to async endpoint (#11223)Dirk Klimpel2021-11-129-91/+1317
| | | | | | | | | Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | | Annotations for user_erasure_store (#11313)David Robertson2021-11-113-5/+9
| | | | | | | | | | | | I'm not sure why this was excluded---it seemed to be passing for me. But it's easy enough to fixup.
* | | Get db signatures file to pass mypy (#11312)David Robertson2021-11-114-10/+8
| | |
* | | Correct type hint for room_batch.py (#11310)David Robertson2021-11-113-11/+12
| | | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | | Move sql file for `remove_deleted_devices_from_device_inbox` into v65 (#11303)Dirk Klimpel2021-11-112-1/+2
| | |
* | | Add type hints to some storage classes (#11307)Patrick Cloke2021-11-119-54/+116
| | |
* | | Fix error in thumbnail generation (#11288)Neeeflix2021-11-102-4/+5
| | | | | | | | | Signed-off-by: Jonas Zeunert <jonas@zeunert.org>
* | | Add missing type hints to `synapse.app`. (#11287)Patrick Cloke2021-11-1017-190/+223
| | |
* | | Add type hints to synapse._scripts (#11297)Patrick Cloke2021-11-105-20/+30
| | |
* | | Add documentation page stubs for Single Sign-On, SAML and CAS pages (#11298)Andrew Morgan2021-11-105-3/+25
| | |
* | | Remove redundant parameters on `_check_event_auth` (#11292)Richard van der Hoff2021-11-103-12/+1
| | | | | | | | | as of #11012, these parameters are unused.
* | | Merge tag 'v1.47.0rc2' into developOlivier Wilkinson (reivilibre)2021-11-1060-60/+101
|\| | | | | | | | | | | | | | | | | | | | | | | Synapse 1.47.0rc2 (2021-11-10) ============================== This fixes an issue with publishing the Debian packages for 1.47.0rc1. It is otherwise identical to 1.47.0rc1.
| * | Changelog tweak from feedback v1.47.0rc2Olivier Wilkinson (reivilibre)2021-11-101-1/+1
| | |
| * | Move Debian changelog entries to rc2 since rc1 was not publishedOlivier Wilkinson (reivilibre)2021-11-101-7/+4
| | |
| * | 1.47.0rc2Olivier Wilkinson (reivilibre)2021-11-103-1/+14
| | |
| * | Correct the Debian changelogOlivier Wilkinson (reivilibre)2021-11-101-1/+1
| | |
| * | Update __init__.py v1.47.0rc1Olivier Wilkinson (reivilibre)2021-11-091-1/+1
| | |
| * | Changelog tweaks from reviewOlivier Wilkinson (reivilibre)2021-11-091-5/+5
| | |
| * | Make Deprecations and Removals more prominentOlivier Wilkinson (reivilibre)2021-11-091-7/+7
| | |
| * | Changelog tweaksOlivier Wilkinson (reivilibre)2021-11-091-6/+6
| | |
| * | 1.47.0rc1Olivier Wilkinson (reivilibre)2021-11-0959-59/+90
| | |
* | | Fix typos in the `username_available` admin API documentation. (#11286)Stanislav Motylkov2021-11-092-1/+2
| | |
* | | Split out federated PDU retrieval into a non-cached version (#11242)Eric Eastwood2021-11-092-22/+59
| | | | | | | | | | | | Context: https://github.com/matrix-org/synapse/pull/11114/files#r741643968
* | | Ignore missing imports for parameterized. (#11285)Patrick Cloke2021-11-092-0/+4
| | | | | | | | | | | | This was due to a conflict between #11282, which changed mypy configuration, and #11228, a normal change.
* | | Require mypy for synapse/ & tests/ unless excluded (#11282)Dan Callahan2021-11-093-77/+168
| | | | | | | | | Signed-off-by: Dan Callahan <danc@element.io>
* | | Clarifications and small fixes to to-device related code (#11247)Andrew Morgan2021-11-096-17/+78
| | | | | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>