summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Remove redundant `room_version` param from `check_auth_rules_from_context`Richard van der Hoff2022-06-124-35/+8
| | | | It's now implied by the room_version property on the event.
* Remove `room_version` param from `check_auth_rules_for_event`Richard van der Hoff2022-06-126-65/+16
| | | | | | | Instead, use the `room_version` property of the event we're checking. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
* Remove `room_version` param from `validate_event_for_room_version`Richard van der Hoff2022-06-126-14/+14
| | | | | | | Instead, use the `room_version` property of the event we're validating. The `room_version` was originally added as a parameter somewhere around #4482, but really it's been redundant since #6875 added a `room_version` field to `EventBase`.
* EventAuthTestCase: build events for the right room versionRichard van der Hoff2022-06-121-119/+205
| | | | | | In practice, when we run the auth rules, all of the events have the right room version. Let's stop building Room V1 events for these tests and use the right version.
* Correct typographical errors in the changelog v1.61.0rc1Olivier Wilkinson (reivilibre)2022-06-071-2/+2
|
* 1.61.0rc1Olivier Wilkinson (reivilibre)2022-06-0777-77/+92
|
* Fix Debian changelogOlivier Wilkinson (reivilibre)2022-06-071-2/+1
|
* Prevent breaking old sqlite's when media retention is enabled (#12977)Andrew Morgan2022-06-072-1/+2
|
* Prevent local quarantined media from being claimed by media retention (#12972)Andrew Morgan2022-06-076-29/+185
|
* Remove remaining pieces of groups code. (#12966)Patrick Cloke2022-06-068-209/+6
| | | | | * Remove an unused stream ID generator. * Remove the now unused remote profile cache.
* Reduce state pulled from DB due to sending typing and receipts over ↵Erik Johnston2022-06-069-16/+68
| | | | | federation (#12964) Reducing the amount of state we pull from the DB is useful as fetching state is expensive in terms of DB, CPU and memory.
* Do not break URL previews if an image is unreachable. (#12950)Patrick Cloke2022-06-063-6/+53
| | | | Avoid breaking a URL preview completely if the chosen image 404s or is unreachable for some other reason (e.g. DNS).
* Implement MSC3816, consider the root event for thread participation. (#12766)Patrick Cloke2022-06-063-47/+97
| | | | As opposed to only considering a user to have "participated" if they replied to the thread.
* Allow updating passwords using the admin api without logging out devices ↵Jan Christian Grünhage2022-06-063-2/+11
| | | | (#12952)
* Reduce the amount of state we pull from the DB (#12811)Erik Johnston2022-06-0623-146/+161
|
* Remove groups code from synapse_port_db. (#12899)Patrick Cloke2022-06-033-15/+18
|
* Improve URL previews for some pages (#12951)Patrick Cloke2022-06-033-18/+72
| | | | | * Skip `og` and `meta` tags where the value is empty. * Fallback to the favicon if there are no other images. * Ignore tags meant for navigation.
* Wait for lazy join to complete when getting current state (#12872)Erik Johnston2022-06-0133-82/+361
|
* Fix complement tests using the wrong path (#12933)Michael Telatynski2022-06-012-1/+2
|
* Remove remaining bits of groups code. (#12936)Patrick Cloke2022-06-0119-35/+1
| | | | | | * Update worker docs to remove group endpoints. * Removes an unused parameter to `ApplicationService`. * Break dependency between media repo and groups. * Avoid copying `m.room.related_groups` state events during room upgrades.
* Remove direct refeferences to PyNaCl (use signedjson instead). (#12902)Jacek Kuśnierz2022-06-016-20/+12
|
* Fix 404 on `/sync` when the last event is a redaction of an unknown/purged ↵Richard van der Hoff2022-06-016-65/+129
| | | | | | | | | | | event (#12905) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.
* Fix potential thumbnail memory leaks. (#12932)Erik Johnston2022-06-013-135/+202
|
* Remove most groups datastore code. (#12895)Patrick Cloke2022-05-313-1396/+7
| | | | The remaining piece is a background update that is needed for backwards compatibility.
* Improve logging when signature checks fail (#12925)Richard van der Hoff2022-05-314-65/+95
| | | | | | | | | | | | | * Raise a dedicated `InvalidEventSignatureError` from `_check_sigs_on_pdu` * Downgrade logging about redactions to DEBUG this can be very spammy during a room join, and it's not very useful. * Raise `InvalidEventSignatureError` from `_check_sigs_and_hash` ... and, more importantly, move the logging out to the callers. * changelog
* Remove groups replication code. (#12900)Patrick Cloke2022-05-317-90/+1
| | | | The replication logic for groups is no longer used, so the message passing infrastructure can be removed.
* Add config options for media retention (#12732)Andrew Morgan2022-05-315-2/+353
|
* Faster room joins: Resume state re-syncing after a Synapse restart (#12813)Sean Quah2022-05-313-2/+53
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Faster room joins: Try other destinations when resyncing the state of a ↵Sean Quah2022-05-314-9/+94
| | | | | | | partial-state room (#12812) Signed-off-by: Sean Quah <seanq@matrix.org>
* Merge branch 'master' into developErik Johnston2022-05-3110-86/+91
|\
| * Update changelogErik Johnston2022-05-311-2/+2
| |
| * 1.60.0 v1.60.0Erik Johnston2022-05-314-4/+18
| |
| * Fix import in module_api module and docs on the new check_event_for_spam ↵Brendan Abolivier2022-05-318-78/+66
| | | | | | | | | | signature (#12918) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Test Synapse against Complement with workers. (#12810)reivilibre2022-05-313-20/+66
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Reduce DB load of /sync when using presence (#12885)Erik Johnston2022-05-312-27/+49
| | | | | | While the query was fast, we were calling it *a lot*.
* | Stop reading from `event_edges.room_id`. (#12914)Richard van der Hoff2022-05-314-24/+22
| | | | | | event_edges.room_id is implied by the event id, so there is no need to join on the room id.
* | Rename storage classes (#12913)Erik Johnston2022-05-3153-551/+708
| |
* | Rework stream token to stop caring about groups. (#12897)Patrick Cloke2022-05-313-3/+8
| |
* | Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12923)Travis Ralston2022-05-313-2/+3
| |
* | Revert "Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922)"Travis Ralston2022-05-303-3/+2
| | | | | | | | This reverts commit e0fae823e9938618a260adadb82bfee6e4c2f907.
* | Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922)Travis Ralston2022-05-313-2/+3
| | | | | | `M_` is a reserved namespace.
* | Don't return `end` from `/messages` if there are no more events (#12903)Jacek Kuśnierz2022-05-302-6/+18
| | | | | | | | Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de>
* | Document the Synapse version of a new module API method (#12917)Brendan Abolivier2022-05-302-1/+7
| |
* | Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ↵David Teller2022-05-305-17/+43
| | | | | | | | | | ability to return additional fields (#12846) Signed-off-by: David Teller <davidt@element.io>
* | demo: check if we are in a virtualenv before overriding PYTHONPATH (#12916)Mathieu Velten2022-05-302-5/+7
| |
* | Add a migration step to cleanup potential leftovers of bug 11833 (#12784)Mathieu Velten2022-05-302-0/+20
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Fix invite notifications for users without pushers (#12840)DeepBlueV7.X2022-05-304-12/+96
| | | | | | | | Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>
* | Fix `get_metadata_for_events` (#12904)Richard van der Hoff2022-05-302-2/+3
| | | | | | | | This method was introduced in #12852. It is using the `state_key` column from the `events` table, which is not (yet) reliable (see #11496).
* | Remove unused `contrib/experiments/cursesio.py` (#12910)David Robertson2022-05-302-165/+1
| |
* | Remove `contrib/experiments/test_messaging.py` (#12911)David Robertson2022-05-302-367/+1
| |
* | Remove contrib/jitsimeetbridge (#12909)David Robertson2022-05-3012-5549/+8
| |
* | Remove contrib/scripts/kick_users.py (#12908)David Robertson2022-05-302-88/+1
| |
* | Bump jsonschema stubs (#12912)David Robertson2022-05-303-5/+11
| |
* | Mutual rooms: Remove dependency on user directory (#12836)Jonathan de Jong2022-05-305-58/+27
| |
* | LockStore: fix acquiring a lock via `LockStore.try_acquire_lock` (#12832)Sumner Evans2022-05-303-1/+73
| | | | | | Signed-off-by: Sumner Evans <sumner@beeper.com>
* | Add a background job to automatically delete stale devices (#12855)Brendan Abolivier2022-05-276-1/+135
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Add code M_USER_ACCOUNT_SUSPENDED, as per MSC3823. (#12845)David Teller2022-05-272-0/+8
| | | | | | | | Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Clean-up some receipts code (#12888)Patrick Cloke2022-05-272-42/+48
| | | | | | | | | | * Properly marks private methods as private. * Adds missing docstrings. * Rework inline methods.
* | Additional constants for EDU types. (#12884)Patrick Cloke2022-05-2735-96/+146
| | | | | | Instead of hard-coding strings in many places.
* | Remove federation client code for groups. (#12563)Patrick Cloke2022-05-272-483/+1
| |
* | Merge tag 'v1.60.0rc2' into developSean Quah2022-05-2711-17/+138
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.60.0rc2 (2022-05-27) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Add an option allowing users to use their password to reauthenticate for privileged actions even though password login is disabled. ([\#12883](https://github.com/matrix-org/synapse/issues/12883)) Bugfixes -------- - Explicitly close `ijson` coroutines once we are done with them, instead of leaving the garbage collector to close them. ([\#12875](https://github.com/matrix-org/synapse/issues/12875)) Internal Changes ---------------- - Improve URL previews by not including the content of media tags in the generated description. ([\#12887](https://github.com/matrix-org/synapse/issues/12887))
| * 1.60.0rc2 v1.60.0rc2Sean Quah2022-05-276-5/+29
| |
| * Close `ijson` coroutines ourselves instead of letting the GC close them (#12875)Sean Quah2022-05-273-2/+19
| | | | | | | | | | | | | | Hopefully this means that exceptions raised due to truncated JSON get a sensible logging context and stack. Signed-off-by: Sean Quah <seanq@matrix.org>
| * Add an option allowing users to use their password to reauthenticate even ↵reivilibre2022-05-276-12/+83
| | | | | | | | though password authentication is disabled. (#12883)
| * Improve URL previews by not including the content of media tags in the ↵reivilibre2022-05-262-1/+10
| | | | | | | | generated description. (#12887)
* | Add storage and module API methods to get monthly active users and their ↵Matt C2022-05-274-0/+149
| | | | | | | | appservices (#12838)
* | Easy type hints in synapse.logging.opentracing (#12894)David Robertson2022-05-274-57/+73
| |
* | Fix room deletion (#12889)Richard van der Hoff2022-05-272-9/+11
| | | | | | | | | | | | | | | | | | * Fix room deletion ae7858f broke room deletion by attempting to delete the entry from `rooms` before the tables that reference it. * faster_joins: remove database rows on purge
* | Refactor have_seen_events to reduce OOMs (#12886)Richard van der Hoff2022-05-272-18/+25
| | | | | | | | | | My server is currently OOMing in the middle of have_seen_events, so let's try to fix that.
* | Remove backing code for groups/communities (#12558)Patrick Cloke2022-05-2613-1894/+6
| | | | | | | | Including handlers, configuration code, appservice support, and the GroupID construct.
* | Bump pyjwt from 2.3.0 to 2.4.0 (#12865)dependabot[bot]2022-05-262-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](https://github.com/jpadilla/pyjwt/compare/2.3.0...2.4.0) --- updated-dependencies: - dependency-name: pyjwt dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
* | Fix ambiguous column name that would prevent use of MSC2716 History Import ↵reivilibre2022-05-262-1/+2
| | | | | | | | when using Postgres as a database. (#12843)
* | Remove unstable APIs for /hierarchy. (#12851)Patrick Cloke2022-05-266-28/+16
| | | | | | | | Removes the unstable endpoint as well as a duplicated field which was modified during stabilization.
* | Avoid attempting to delete push actions for remote users. (#12879)Patrick Cloke2022-05-265-4/+8
| | | | | | | | Remote users will never have push actions, so we can avoid a database round-trip/transaction completely.
* | Pull out less state when handling gaps mk2 (#12852)Erik Johnston2022-05-268-127/+236
| |
* | Allow bigger responses to `/federation/v1/state` (#12877)Richard van der Hoff2022-05-254-32/+19
| | | | | | | | | | | | | | | | | | | | | | * Refactor HTTP response size limits Rather than passing a separate `max_response_size` down the stack, make it an attribute of the `parser`. * Allow bigger responses on `federation/v1/state` `/state` can return huge responses, so we need to handle that.
* | Fix up `state_store` naming (#12871)Erik Johnston2022-05-2515-49/+58
| |
* | Remove user-visible groups/communities code (#12553)Patrick Cloke2022-05-2519-2217/+3
| | | | | | | | | | | | | | | | | | Makes it so that groups/communities no longer exist from a user-POV. E.g. we remove: * All API endpoints (including Client-Server, Server-Server, and admin). * Documented configuration options (and the experimental flag, which is now unused). * Special handling during room upgrades. * The `groups` section of the `/sync` response.
* | Fix caching behavior for relations push rules. (#12859)Patrick Cloke2022-05-253-9/+12
| | | | | | | | | | By always returning all requested values from the function wrapped by cachedList. Otherwise implicit None values get added into the cache, which are unexpected.
* | Misc clean-up of push rules datastore (#12856)Patrick Cloke2022-05-252-11/+6
| |
* | Correct typo in changelog for #12858.David Robertson2022-05-251-1/+1
| |
* | Add the `batch_send` endpoint to generic workers (#12868)Nick Mills-Barrett2022-05-254-0/+5
| |
* | Don't create empty AS txns when the AS is down (#12869)Nick Mills-Barrett2022-05-252-1/+6
| |
* | Add the `/account/whoami` endpoint to generic workers (#12866)Nick Mills-Barrett2022-05-253-1/+4
| |
* | Fix incorrect worker-allowed path in documentation (#12867)Nick Mills-Barrett2022-05-252-3/+1
| |
* | Make sure `prev_ids` defaults to empty list (#12829)Carl Bordum Hansen2022-05-252-0/+5
| | | | | | Signed-off-by: Carl Bordum Hansen <carl@bordum.dk>
* | Fix typos in documentation (#12863)Dirk Klimpel2022-05-254-3/+4
| |
* | Correct annotation of `_iterate_over_text` (#12860)David Robertson2022-05-242-1/+2
| |
* | Fixes to MSC3787 implementation (#12858)David Robertson2022-05-244-20/+21
| |
* | Remove `dont_notify` from the `.m.rule.room.server_acl` rule (#12849)Šimon Brandner2022-05-242-1/+2
| | | | | | | | Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Add authentication to thirdparty bridge APIs (#12746)Will Hunt2022-05-243-3/+115
| | | | | | Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* | Merge tag 'v1.60.0rc1' into developSean Quah2022-05-2487-87/+119
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.60.0rc1 (2022-05-24) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Measure the time taken in spam-checking callbacks and expose those measurements as metrics. ([\#12513](https://github.com/matrix-org/synapse/issues/12513)) - Add a `default_power_level_content_override` config option to set default room power levels per room preset. ([\#12618](https://github.com/matrix-org/synapse/issues/12618)) - Add support for [MSC3787: Allowing knocks to restricted rooms](https://github.com/matrix-org/matrix-spec-proposals/pull/3787). ([\#12623](https://github.com/matrix-org/synapse/issues/12623)) - Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. ([\#12672](https://github.com/matrix-org/synapse/issues/12672), [\#12809](https://github.com/matrix-org/synapse/issues/12809)) - Synapse will now reload [cache config](https://matrix-org.github.io/synapse/latest/usage/configuration/config_documentation.html#caching) when it receives a [SIGHUP](https://en.wikipedia.org/wiki/SIGHUP) signal. ([\#12673](https://github.com/matrix-org/synapse/issues/12673)) - Add a config options to allow for auto-tuning of caches. ([\#12701](https://github.com/matrix-org/synapse/issues/12701)) - Update [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) implementation to process marker events from the current state to avoid markers being lost in timeline gaps for federated servers which would cause the imported history to be undiscovered. ([\#12718](https://github.com/matrix-org/synapse/issues/12718)) - Add a `drop_federated_event` callback to `SpamChecker` to disregard inbound federated events before they take up much processing power, in an emergency. ([\#12744](https://github.com/matrix-org/synapse/issues/12744)) - Implement [MSC3818: Copy room type on upgrade](https://github.com/matrix-org/matrix-spec-proposals/pull/3818). ([\#12786](https://github.com/matrix-org/synapse/issues/12786), [\#12792](https://github.com/matrix-org/synapse/issues/12792)) - Update to the `check_event_for_spam` module callback. Deprecate the current callback signature, replace it with a new signature that is both less ambiguous (replacing booleans with explicit allow/block) and more powerful (ability to return explicit error codes). ([\#12808](https://github.com/matrix-org/synapse/issues/12808)) Bugfixes -------- - Fix a bug introduced in Synapse 1.7.0 that would prevent events from being sent to clients if there's a retention policy in the room when the support for retention policies is disabled. ([\#12611](https://github.com/matrix-org/synapse/issues/12611)) - Fix a bug introduced in Synapse 1.57.0 where `/messages` would throw a 500 error when querying for a non-existent room. ([\#12683](https://github.com/matrix-org/synapse/issues/12683)) - Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. ([\#12687](https://github.com/matrix-org/synapse/issues/12687)) - Fix a long-standing bug where an empty room would be created when a user with an insufficient power level tried to upgrade a room. ([\#12696](https://github.com/matrix-org/synapse/issues/12696)) - Fix a bug introduced in Synapse 1.30.0 where empty rooms could be automatically created if a monthly active users limit is set. ([\#12713](https://github.com/matrix-org/synapse/issues/12713)) - Fix push to dismiss notifications when read on another client. Contributed by @SpiritCroc @ Beeper. ([\#12721](https://github.com/matrix-org/synapse/issues/12721)) - Fix poor database performance when reading the cache invalidation stream for large servers with lots of workers. ([\#12747](https://github.com/matrix-org/synapse/issues/12747)) - Delete events from the `federation_inbound_events_staging` table when a room is purged through the admin API. ([\#12770](https://github.com/matrix-org/synapse/issues/12770)) - Give a meaningful error message when a client tries to create a room with an invalid alias localpart. ([\#12779](https://github.com/matrix-org/synapse/issues/12779)) - Fix a bug introduced in 1.43.0 where a file (`providers.json`) was never closed. Contributed by @arkamar. ([\#12794](https://github.com/matrix-org/synapse/issues/12794)) - Fix a long-standing bug where finished log contexts would be re-started when failing to contact remote homeservers. ([\#12803](https://github.com/matrix-org/synapse/issues/12803)) - Fix a bug, introduced in Synapse 1.21.0, that led to media thumbnails being unusable before the index has been added in the background. ([\#12823](https://github.com/matrix-org/synapse/issues/12823)) Updates to the Docker image --------------------------- - Fix the docker file after a dependency update. ([\#12853](https://github.com/matrix-org/synapse/issues/12853)) Improved Documentation ---------------------- - Fix a typo in the Media Admin API documentation. ([\#12715](https://github.com/matrix-org/synapse/issues/12715)) - Update the OpenID Connect example for Keycloak to be compatible with newer versions of Keycloak. Contributed by @nhh. ([\#12727](https://github.com/matrix-org/synapse/issues/12727)) - Fix typo in server listener documentation. ([\#12742](https://github.com/matrix-org/synapse/issues/12742)) - Link to the configuration manual from the welcome page of the documentation. ([\#12748](https://github.com/matrix-org/synapse/issues/12748)) - Fix typo in `run_background_tasks_on` option name in configuration manual documentation. ([\#12749](https://github.com/matrix-org/synapse/issues/12749)) - Add information regarding the `rc_invites` ratelimiting option to the configuration docs. ([\#12759](https://github.com/matrix-org/synapse/issues/12759)) - Add documentation for cancellation of request processing. ([\#12761](https://github.com/matrix-org/synapse/issues/12761)) - Recommend using docker to run tests against postgres. ([\#12765](https://github.com/matrix-org/synapse/issues/12765)) - Add missing user directory endpoint from the generic worker documentation. Contributed by @olmari. ([\#12773](https://github.com/matrix-org/synapse/issues/12773)) - Add additional info to documentation of config option `cache_autotuning`. ([\#12776](https://github.com/matrix-org/synapse/issues/12776)) - Update configuration manual documentation to document size-related suffixes. ([\#12777](https://github.com/matrix-org/synapse/issues/12777)) - Fix invalid YAML syntax in the example documentation for the `url_preview_accept_language` config option. ([\#12785](https://github.com/matrix-org/synapse/issues/12785)) Deprecations and Removals ------------------------- - Require a body in POST requests to `/rooms/{roomId}/receipt/{receiptType}/{eventId}`, as required by the [Matrix specification](https://spec.matrix.org/v1.2/client-server-api/#post_matrixclientv3roomsroomidreceiptreceipttypeeventid). This breaks compatibility with Element Android 1.2.0 and earlier: users of those clients will be unable to send read receipts. ([\#12709](https://github.com/matrix-org/synapse/issues/12709)) Internal Changes ---------------- - Improve event caching mechanism to avoid having multiple copies of an event in memory at a time. ([\#10533](https://github.com/matrix-org/synapse/issues/10533)) - Preparation for faster-room-join work: return subsets of room state which we already have, immediately. ([\#12498](https://github.com/matrix-org/synapse/issues/12498)) - Add `@cancellable` decorator, for use on endpoint methods that can be cancelled when clients disconnect. ([\#12586](https://github.com/matrix-org/synapse/issues/12586), [\#12588](https://github.com/matrix-org/synapse/issues/12588), [\#12630](https://github.com/matrix-org/synapse/issues/12630), [\#12694](https://github.com/matrix-org/synapse/issues/12694), [\#12698](https://github.com/matrix-org/synapse/issues/12698), [\#12699](https://github.com/matrix-org/synapse/issues/12699), [\#12700](https://github.com/matrix-org/synapse/issues/12700), [\#12705](https://github.com/matrix-org/synapse/issues/12705)) - Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$event_type/*` requests. ([\#12708](https://github.com/matrix-org/synapse/issues/12708)) - Improve documentation of the `synapse.push` module. ([\#12676](https://github.com/matrix-org/synapse/issues/12676)) - Refactor functions to on `PushRuleEvaluatorForEvent`. ([\#12677](https://github.com/matrix-org/synapse/issues/12677)) - Preparation for database schema simplifications: stop writing to `event_reference_hashes`. ([\#12679](https://github.com/matrix-org/synapse/issues/12679)) - Remove code which updates unused database column `application_services_state.last_txn`. ([\#12680](https://github.com/matrix-org/synapse/issues/12680)) - Refactor `EventContext` class. ([\#12689](https://github.com/matrix-org/synapse/issues/12689)) - Remove an unneeded class in the push code. ([\#12691](https://github.com/matrix-org/synapse/issues/12691)) - Consolidate parsing of relation information from events. ([\#12693](https://github.com/matrix-org/synapse/issues/12693)) - Convert namespace class `Codes` into a string enum. ([\#12703](https://github.com/matrix-org/synapse/issues/12703)) - Optimize private read receipt filtering. ([\#12711](https://github.com/matrix-org/synapse/issues/12711)) - Drop the logging level of status messages for the URL preview cache expiry job from INFO to DEBUG. ([\#12720](https://github.com/matrix-org/synapse/issues/12720)) - Downgrade some OIDC errors to warnings in the logs, to reduce the noise of Sentry reports. ([\#12723](https://github.com/matrix-org/synapse/issues/12723)) - Update configs used by Complement to allow more invites/3PID validations during tests. ([\#12731](https://github.com/matrix-org/synapse/issues/12731)) - Fix a long-standing bug where the user directory background process would fail to make forward progress if a user included a null codepoint in their display name or avatar. ([\#12762](https://github.com/matrix-org/synapse/issues/12762)) - Tweak the mypy plugin so that `@cached` can accept `on_invalidate=None`. ([\#12769](https://github.com/matrix-org/synapse/issues/12769)) - Move methods that call `add_push_rule` to the `PushRuleStore` class. ([\#12772](https://github.com/matrix-org/synapse/issues/12772)) - Make handling of federation Authorization header (more) compliant with RFC7230. ([\#12774](https://github.com/matrix-org/synapse/issues/12774)) - Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. ([\#12775](https://github.com/matrix-org/synapse/issues/12775)) - Do not keep going if there are 5 back-to-back background update failures. ([\#12781](https://github.com/matrix-org/synapse/issues/12781)) - Fix federation when using the demo scripts. ([\#12783](https://github.com/matrix-org/synapse/issues/12783)) - The `hash_password` script now fails when it is called without specifying a config file. Contributed by @jae1911. ([\#12789](https://github.com/matrix-org/synapse/issues/12789)) - Improve and fix type hints. ([\#12567](https://github.com/matrix-org/synapse/issues/12567), [\#12477](https://github.com/matrix-org/synapse/issues/12477), [\#12717](https://github.com/matrix-org/synapse/issues/12717), [\#12753](https://github.com/matrix-org/synapse/issues/12753), [\#12695](https://github.com/matrix-org/synapse/issues/12695), [\#12734](https://github.com/matrix-org/synapse/issues/12734), [\#12716](https://github.com/matrix-org/synapse/issues/12716), [\#12726](https://github.com/matrix-org/synapse/issues/12726), [\#12790](https://github.com/matrix-org/synapse/issues/12790), [\#12833](https://github.com/matrix-org/synapse/issues/12833)) - Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible. ([\#12791](https://github.com/matrix-org/synapse/issues/12791)) - Remove Caddy from the Synapse workers image used in Complement. ([\#12818](https://github.com/matrix-org/synapse/issues/12818)) - Add Complement's shared registration secret to the Complement worker image. This fixes tests that depend on it. ([\#12819](https://github.com/matrix-org/synapse/issues/12819)) - Support registering Application Services when running with workers under Complement. ([\#12826](https://github.com/matrix-org/synapse/issues/12826)) - Disable 'faster room join' Complement tests when testing against Synapse with workers. ([\#12842](https://github.com/matrix-org/synapse/issues/12842))
| * Update changelog v1.60.0rc1Sean Quah2022-05-241-19/+19
| |
| * 1.60.0rc1Sean Quah2022-05-2487-87/+119
| |
* | Experimental support for MSC3772 (#12740)Patrick Cloke2022-05-2410-6/+287
|/ | | | | | | | | | Implements the following behind an experimental configuration flag: * A new push rule kind for mutually related events. * A new default push rule (`.m.rule.thread_reply`) under an unstable prefix. This is missing part of MSC3772: * The `.m.rule.thread_reply_to_me` push rule, this depends on MSC3664 / #11804.
* contributing_guide.md: fix link to DCORichard van der Hoff2022-05-241-2/+2
|
* Pin poetry.core in Docker images (#12853)Erik Johnston2022-05-242-1/+2
|
* Marker events as state - MSC2716 (#12718)Eric Eastwood2022-05-232-1/+26
| | | | | | | | | | | | | | | | Sending marker events as state now so they are always able to be seen by homeservers (not lost in some timeline gap). Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) Complement tests: https://github.com/matrix-org/complement/pull/371 As initially discussed at https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r782629097 and https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r876684431 When someone joins a room, process all of the marker events we see in the current state. Marker events should be sent with a unique `state_key` so that they can all resolve in the current state to easily be discovered. Marker events as state - If we re-use the same `state_key` (like `""`), then we would have to fetch previous snapshots of state up through time to find all of the marker events. This way we can avoid all of that. This PR was originally doing this but then thought of the smarter way to tackle in an [out of band discussion with @erikjohnston](https://docs.google.com/document/d/1JJDuPfcPNX75fprdTWlxlaKjWOdbdJylbpZ03hzo638/edit#bookmark=id.sm92fqyq7vpp). - Also avoids state resolution conflicts where only one of the marker events win As a homeserver, when we see new marker state, we know there is new history imported somewhere back in time and should process it to fetch the insertion event where the historical messages are and set it as an insertion extremity. This way we know where to backfill more messages when someone asks for scrollback.
* Uniformize spam-checker API, part 2: check_event_for_spam (#12808)David Teller2022-05-2310-31/+129
| | | Signed-off-by: David Teller <davidt@element.io>
* Prevent expired events from being filtered out when retention is disabled ↵Brendan Abolivier2022-05-237-32/+71
| | | | | | (#12611) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* add SpamChecker callback for silently dropping inbound federated events (#12744)Jess Porter2022-05-235-4/+108
| | | Signed-off-by: jesopo <github@lolnerd.net>
* Disable 'faster room join' Complement tests when testing against Synapse ↵reivilibre2022-05-232-1/+9
| | | | with workers. (#12842)
* Support registering Application Services when running with workers under ↵reivilibre2022-05-234-1/+31
| | | | | Complement. (#12826) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add some type hints to tests files (#12833)Dirk Klimpel2022-05-237-23/+19
| | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* Fix Complement `TestCanRegisterAdmin` with workers, by adding Complement's ↵reivilibre2022-05-232-0/+7
| | | | shared registration secret. (#12819)
* Add a windows->unix file endings commit to git blame ignore file (#12824)Andrew Morgan2022-05-231-0/+3
|
* Remove Caddy from the Synapse workers image used in Complement. (#12818)reivilibre2022-05-237-93/+38
|
* Fix media thumbnails being unusable before the index had been added in the ↵reivilibre2022-05-232-0/+3
| | | | background. (#12823)
* Send `USER_IP` commands on a different Redis channel, in order to reduce ↵reivilibre2022-05-205-4/+17
| | | | traffic to workers that do not process these commands. (#12809)
* Uniformize spam-checker API, part 1: the `Code` enum. (#12703)David Teller2022-05-202-2/+10
|
* Update EventContext `get_current_event_ids` and `get_prev_event_ids` to ↵Shay2022-05-2010-18/+65
| | | | accept state filters and update calls where possible (#12791)
* Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803)Sean Quah2022-05-192-2/+3
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Add a unit test for copying over arbitrary room types when upgrading a room ↵Andrew Morgan2022-05-193-2/+33
| | | | (#12792)
* Lay some foundation work to allow workers to only subscribe to some kinds of ↵reivilibre2022-05-195-24/+173
| | | | messages, reducing replication traffic. (#12672)
* Add detail to `cache_autotuning` config option documentation (#12776)Shay2022-05-192-4/+11
|
* Update configuration manual to document size-related suffixes (#12777)Shay2022-05-192-0/+10
|
* Properly close providers.json file stream. (#12794)Petr Vaněk2022-05-192-3/+4
|
* Add a unique index to `state_group_edges` to prevent duplicates being ↵reivilibre2022-05-195-0/+139
| | | | accidentally introduced and the consequential impact to performance. (#12687)
* hash_password: raise an error if no config file is specified (#12789)Jae Lo Presti2022-05-192-5/+6
|
* Simplify untyped-defs config in mypy.ini (#12790)David Robertson2022-05-192-156/+18
|
* Implement MSC3818: copy room type on upgrade (#12786)Aminda Suomalainen2022-05-192-8/+9
| | | | | Resolves: #11896 Signed-off-by: Aminda Suomalainen <suomalainen+git@mikaela.info>
* Add missing user directory search endpoint to the generic worker ↵Sami Olmari2022-05-192-0/+11
| | | | | | documentation (#12773) Signed-off-by: Sami Olmari <sami@olmari.fi>
* openid.md: fix some linksRichard van der Hoff2022-05-191-9/+9
| | | docbook doesn't auto-linkify links
* Downgrade some OIDC exceptions to warnings (#12723)David Robertson2022-05-182-2/+3
|
* Fix federation in demo scripts. (#12783)Patrick Cloke2022-05-183-6/+11
|
* Skip waiting for full state if a StateFilter does not require it (#12498)Richard van der Hoff2022-05-182-4/+60
| | | | | If `StateFilter` specifies a state set which we will have regardless of state-syncing, then we may as well return it immediately.
* Fix YAML parsing error in `url_preview_accept_language` (#12785)Andrew Morgan2022-05-182-6/+7
|
* Refactor `resolve_state_groups_for_events` to not pull out full state when ↵Shay2022-05-185-23/+40
| | | | no state resolution happens. (#12775)
* Add documentation for cancellation of request processing (#12761)Sean Quah2022-05-183-0/+394
| | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* Add some type hints to `event_federation` datastore (#12753)Dirk Klimpel2022-05-185-65/+127
| | | Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* Merge branch 'master' into developBrendan Abolivier2022-05-183-1/+18
|\
| * Fixup changelog v1.59.1Brendan Abolivier2022-05-181-2/+4
| |
| * 1.59.1Brendan Abolivier2022-05-184-2/+16
| |
| * Discard null-containing strings before updating the user directory (#12762)David Robertson2022-05-186-11/+45
| |
* | Do not keep going if there are 5 back-to-back background update failures. ↵reivilibre2022-05-182-0/+9
| | | | | | | | (#12781)
* | Give a meaningful error message when a client tries to create a room with an ↵reivilibre2022-05-183-0/+19
| | | | | | | | invalid alias localpart. (#12779)
* | Switch the 'Configuration' link in the docs homepage to the config manual ↵Andrew Morgan2022-05-182-3/+4
| | | | | | | | (#12748)
* | Add some documentation around the `rc_invites` option to the config docs ↵Andrew Morgan2022-05-182-0/+15
| | | | | | | | (#12759)
* | Discard null-containing strings before updating the user directory (#12762)David Robertson2022-05-186-11/+45
| |
* | Make handling of federation Authorization header (more) compliant with ↵Hubert Chathi2022-05-184-5/+35
| | | | | | | | | | | | | | | | | | | | | | | | RFC7230 (#12774) The main differences are: - values with delimiters (such as colons) should be quoted, so always quote the origin, since it could contain a colon followed by a port number - should allow more than one space after "X-Matrix" - quoted values with backslash-escaped characters should be unescaped - names should be case insensitive
* | Move methods that call add_push_rule to PushRuleStore (#12772)Adam2022-05-182-51/+52
| | | | | | Signed-off-by: Adam Roddick <ajroddick@tuta.io>
* | Suggest using docker when testing against postgres (#12765)David Robertson2022-05-172-3/+29
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Delete events from federation_inbound_events_staging table on purge (#12770)Mathieu Velten2022-05-173-0/+3
| |
* | allow `on_invalidate=None` in `@cached` methods (#12769)David Robertson2022-05-173-10/+19
| |
* | Add some type hints to datastore (#12717)Dirk Klimpel2022-05-1710-161/+254
| |
* | Add a new room version for MSC3787's knock+restricted join rule (#12623)Travis Ralston2022-05-176-7/+68
| |
* | Remove code which updates `application_services_state.last_txn` (#12680)Richard van der Hoff2022-05-175-55/+35
| | | | | | | | This column is unused as of #12209, so let's stop writing to it.
* | Fix push for m.read events (#12721)SpiritCroc2022-05-172-1/+2
| | | | | | | | badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.
* | Merge branch 'master' into developDavid Robertson2022-05-174-4/+22
|\|
| * version tweak in changelog v1.59.0David Robertson2022-05-171-1/+1
| |
| * 1.59.0David Robertson2022-05-174-4/+21
| |
| * Fix query performance for /sync (#12745)Erik Johnston2022-05-162-1/+2
| |
* | Add index to cache invalidations (#12747)Erik Johnston2022-05-173-0/+27
| | | | | | | | | | For workers that rarely write to the cache the `get_all_updated_caches` query can become expensive if the worker falls behind when reading the cache.
* | Track in memory events using weakrefs (#10533)Erik Johnston2022-05-174-2/+60
| |
* | Tidy up and type-hint the database engine modules (#12734)David Robertson2022-05-177-94/+182
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Fix typo in name of 'run_background_tasks_on' option in config manual (#12749)Andrew Morgan2022-05-162-1/+2
| |
* | Revert "changelog"Andrew Morgan2022-05-161-1/+0
| | | | | | | | | | | | This reverts commit e24c11afd6bb63de2dd7e029a5839d84f592df3c. whoops...
* | changelogAndrew Morgan2022-05-161-0/+1
| |
* | Add `StreamKeyType` class and replace string literals with constants (#12567)Andrew Morgan2022-05-1619-80/+125
| |
* | Avoid unnecessary copies when filtering private read receipts. (#12711)Šimon Brandner2022-05-164-73/+92
| | | | | | | | | | | | A minor optimization to avoid unnecessary copying/building identical dictionaries when filtering private read receipts. Also clarifies comments and cleans-up some tests.
* | Merge tag 'v1.59.0rc2' into developDavid Robertson2022-05-164-11/+29
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.59.0rc2 (2022-05-16) ============================== Synapse 1.59 makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0 where `/sync` would fail if the most recent event in a room was rejected. ([\#12729](https://github.com/matrix-org/synapse/issues/12729))
| * Move 1.59 warning to the top v1.59.0rc2David Robertson2022-05-161-9/+9
| |
| * 1.59.0rc2David Robertson2022-05-164-2/+16
| |
| * Fix bug /sync returning 404 (#12729)Erik Johnston2022-05-162-8/+12
| | | | | | | | | | * Fix bug /sync returning 404 Fixes #12571
* | Fix typo in listener config (#12742)Dirk Klimpel2022-05-164-4/+5
| |
* | Fix room upgrades creating an empty room when auth fails (#12696)Sean Quah2022-05-163-56/+84
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Consolidate logic for parsing relations. (#12693)Patrick Cloke2022-05-167-61/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | Parse the `m.relates_to` event content field (which describes relations) in a single place, this is used during: * Event persistence. * Validation of the Client-Server API. * Fetching bundled aggregations. * Processing of push rules. Each of these separately implement the logic and each made slightly different assumptions about what was valid. Some had minor / potential bugs.
* | Add config flags to allow for cache auto-tuning (#12701)Shay2022-05-137-54/+266
| |
* | Update configs used by Complement to allow more invites (#12731)Till2022-05-133-0/+25
| |
* | Don't create an empty room when checking for MAU limits (#12713)Brendan Abolivier2022-05-134-56/+66
| |
* | Another batch of type annotations (#12726)David Robertson2022-05-1311-79/+144
| |
* | SpamChecker metrics (#12513)Jess Porter2022-05-134-26/+64
| | | | | | | | | | | | | | | | | | * add Measure blocks all over SpamChecker Signed-off-by: jesopo <github@lolnerd.net> * fix test_spam_checker_may_join_room and test_threepid_invite_spamcheck * better changelog entry
* | Update issuer URL in example OIDC Keycloak config (#12727)Niklas2022-05-132-1/+2
| | | | | | | | | | | | | | * Update openid.md Newer versions of keycloak returning a 404 when using the `/auth` prefix. Related: https://github.com/matrix-org/synapse/issues/12714
* | URL preview cache expiry logs: INFO -> DEBUG, text clarifications (#12720)Andrew Morgan2022-05-122-9/+22
| |
* | Reduce the number of "untyped defs" (#12716)David Robertson2022-05-1216-69/+142
| |
* | add default_power_level_content_override config option. (#12618)Andy Balaam2022-05-126-1/+381
| | | | | | Co-authored-by: Matthew Hodgson <matthew@matrix.org>
* | Fix reference to the wrong symbol in the media admin api docs (#12715)Andrew Morgan2022-05-122-1/+2
| |
* | Enable cancellation of `GET /members` and `GET /state` requests (#12708)Sean Quah2022-05-113-2/+9
| | | | | | | | | | | | | | | | Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$state_key/*` requests. Signed-off-by: Sean Quah <seanq@element.io>
* | No longer permit empty body when sending receipts (#12709)David Robertson2022-05-113-38/+6
| |
* | Complain if a federation endpoint has the `@cancellable` flag (#12705)Sean Quah2022-05-113-1/+15
| | | | | | | | | | | | | | | | `BaseFederationServlet` wraps its endpoints in a bunch of async code that has not been vetted for compatibility with cancellation. Fail CI if a `@cancellable` flag is applied to a federation endpoint. Signed-off-by: Sean Quah <seanq@element.io>
* | Reload cache factors from disk on SIGHUP (#12673)David Robertson2022-05-1111-61/+199
| |
* | Respect the `@cancellable` flag for `ReplicationEndpoint`s (#12700)Sean Quah2022-05-114-2/+139
| | | | | | | | | | | | | | | | | | While `ReplicationEndpoint`s register themselves via `JsonResource`, they pass a method that calls the handler, instead of the handler itself, to `register_paths`. As a result, `JsonResource` will not correctly pick up the `@cancellable` flag and we have to apply it ourselves. Signed-off-by: Sean Quah <seanq@element.io>
* | Respect the `@cancellable` flag for `RestServlet`s and ↵Sean Quah2022-05-116-2/+191
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `BaseFederationServlet`s (#12699) Both `RestServlet`s and `BaseFederationServlet`s register their handlers with `HttpServer.register_paths` / `JsonResource.register_paths`. Update `JsonResource` to respect the `@cancellable` flag on handlers registered in this way. Although `ReplicationEndpoint` also registers itself using `register_paths`, it does not pass the handler method that would have the `@cancellable` flag directly, and so needs separate handling. Signed-off-by: Sean Quah <seanq@element.io>
* | Respect the `@cancellable` flag for `DirectServe{Html,Json}Resource`s (#12698)Sean Quah2022-05-113-2/+112
| | | | | | | | | | | | | | | | | | | | | | | | `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit from `_AsyncResource`. These classes expect to be subclassed with `_async_render_*` methods. This commit has no effect on `JsonResource`, despite inheriting from `_AsyncResource`. `JsonResource` has its own `_async_render` override which will need to be updated separately. Signed-off-by: Sean Quah <seanq@element.io>
* | Remove unneeded `ActionGenerator` class. (#12691)Patrick Cloke2022-05-117-60/+17
| | | | | | | | It simply passes through to `BulkPushRuleEvaluator`, which can be called directly instead.
* | Fix `/messages` throwing a 500 when querying for non-existent room (#12683)Eric Eastwood2022-05-103-16/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/12678 Complement test added: https://github.com/matrix-org/complement/pull/369 **Before:** 500 internal server error **After:** According to the [spec](https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages), calling `/messages` against a non-existent `room_id` should throw a 403 forbidden (since you're not part of the room). This also matches the behavior before https://github.com/matrix-org/synapse/pull/12370 which regressed Synapse to the 500 behavior. ```json { "errcode": "M_FORBIDDEN", "error": "User @test:my.synapse.server not in room !dne:my.synapse.server, and room previews are disabled" } ```
* | Refactor `EventContext` (#12689)Erik Johnston2022-05-1013-200/+70
| | | | | | | | | | | | | | | | | | | | Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684
* | Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694)Sean Quah2022-05-103-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | All async request processing goes through `_AsyncResource`, so this is the only place where a `Deferred` needs to be captured for cancellation. Unfortunately, the same isn't true for determining whether a request can be cancelled. Each of `RestServlet`, `BaseFederationServlet`, `DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have different wrappers around the method doing the request handling and they all need to be handled separately. Signed-off-by: Sean Quah <seanq@element.io>
* | Fix incorrect type hint in filtering code. (#12695)Patrick Cloke2022-05-102-2/+4
| |
* | Add some type hints to datastore. (#12477)Dirk Klimpel2022-05-104-71/+122
| |
* | Stop writing to `event_reference_hashes` (#12679)Richard van der Hoff2022-05-105-38/+5
| | | | | | | | | | This table is never read, since #11794. We stop writing to it; in future we can drop it altogether.
* | Add helper class for testing request cancellation (#12630)Sean Quah2022-05-104-0/+127
| | | | | | | | | | | | | | Also expose the `SynapseRequest` from `FakeChannel` in tests, so that we can call `Request.connectionLost` to simulate a client disconnecting. Signed-off-by: Sean Quah <seanq@element.io>
* | Add ability to cancel disconnected requests to `SynapseRequest` (#12588)Sean Quah2022-05-102-1/+24
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Add `@cancellable` decorator, for use on request handlers (#12586)Sean Quah2022-05-102-0/+62
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Merge tag 'v1.59.0rc1' into developDavid Robertson2022-05-1073-103/+179
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](https://github.com/matrix-org/matrix-spec-proposals/pull/2285/commits/4a77139249c2e830aec3c7d6bd5501a514d1cc27) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671))
| * other fixes v1.59.0rc1David Robertson2022-05-101-2/+2
| |
| * backquote `m.room.server_acl`David Robertson2022-05-101-1/+1
| |
| * v1 -> 1David Robertson2022-05-101-4/+4
| |
| * Fix deprecation noticeDavid Robertson2022-05-101-1/+1
| |
| * I manually added O's change, remove newsfileDavid Robertson2022-05-101-1/+0
| |
| * Add Olivier's last-minute mergeDavid Robertson2022-05-101-0/+1
| |
| * Group release script changesDavid Robertson2022-05-101-1/+1
| |
| * Fix changelog linkDavid Robertson2022-05-101-1/+1
| |
| * Add the `update_user_directory_from_worker` configuration option ↵reivilibre2022-05-109-34/+76
| | | | | | | | | | (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. (#12654) Co-authored-by: Shay <hillerys@element.io>
| * Changelog typoDavid Robertson2022-05-101-1/+1
| |
| * Adjust changelogDavid Robertson2022-05-101-25/+29
| |
| * 1.59.0rc1David Robertson2022-05-1065-66/+96
| |
* | Move free functions into PushRuleEvaluatorForEvent. (#12677)Patrick Cloke2022-05-103-34/+69
| | | | | | | | | | | | * Move `_condition_checker` into `PushRuleEvaluatorForEvent`. * Move the condition cache into `PushRuleEvaluatorForEvent`. * Improve docstrings. * Inline a method which is only called once.
* | Add class-diagrams and notes for push. (#12676)Patrick Cloke2022-05-102-0/+80
|/
* Immediately retry any requests that have backed off when a server comes back ↵Erik Johnston2022-05-106-6/+179
| | | | | online. (#12500) Otherwise it can take up to a minute for any in-flight `/send` requests to be retried.
* Implement MSC3786: Add a default push rule to ignore m.room.server_acl ↵Šimon Brandner2022-05-104-11/+56
| | | | | | events (#12601) Fixes vector-im/element-web#20788 Implements matrix-org/matrix-spec-proposals#3786
* Update `replication.md` with info on TCP module structure (#12621)Shay2022-05-093-1/+7
|
* Update SQL statements in docs for Synapse Admins (#12536)Dirk Klimpel2022-05-092-70/+122
|
* Tweaks to workers-under-complement (#12637)Richard van der Hoff2022-05-093-5/+15
| | | | | | | * Bump the HS startup timeout * Log prefixes for more processes * Bump the overall timeout
* Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665)Val Lorentz2022-05-092-1/+2
|
* Implement cancellation support/protection for module callbacks (#12568)Sean Quah2022-05-096-27/+86
| | | | | | | | | | | | There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>
* Fix mypy against latest pillow stubs (#12671)David Robertson2022-05-093-6/+7
|
* Update changelog for #12587 to be more accurate (#12663)Sean Quah2022-05-092-1/+2
| | | | | | #12587 has fallen on the wrong side of the release cutoff to the rest of the related PRs. Signed-off-by: Sean Quah <seanq@element.io>
* Use `ParamSpec` in a few places (#12667)David Robertson2022-05-0914-68/+148
|
* Don't error on unknown receipt types (#12670)Erik Johnston2022-05-092-12/+16
| | | Fixes #12669
* docs(contrib): Add link to documentation in dashboard (#12602)Sheogorath2022-05-092-1/+14
|
* Fix docs on how to run specific Complement tests after recent ↵Eric Eastwood2022-05-092-2/+3
| | | | `complement.sh` change (#12664)
* Use `Concatenate` to annotate `do_execute` (#12666)David Robertson2022-05-093-6/+16
|
* Move `pympler` back into the `all` extras (#12652)David Robertson2022-05-075-6/+15
| | | | | | | | | | | | | * Move `pympler` back into the `all` extras Undoes a change I made in #12381. I can't fully remember my reasoning, but this changed the contents of the debian packages in a backwards incompatible way. We're not aware of anyone who's been bitten by this, but we still want to fix it. To the reviewer: please be convinced that the debian packages will still contain pympler after this change. * Debian changelog entry to keep the linter happy
* Convert stringy power levels to integers on room upgrade (#12657)David Robertson2022-05-075-24/+137
|
* Prevent memory leak from reoccurring when presence is disabled. (#12656)Erik Johnston2022-05-063-28/+54
|
* Update mypy to 0.950 and fix complaints (#12650)David Robertson2022-05-0610-57/+98
|
* Add the `notify_appservices_from_worker` configuration option (superseding ↵reivilibre2022-05-069-21/+447
| | | | `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. (#12452)
* Merge branch 'master' into developAndrew Morgan2022-05-054-2/+27
|\
| * Update v1.58.1 changelog entry with more familiar language v1.58.1Andrew Morgan2022-05-051-2/+2
| |
| * link to relevant bug report in v1.58.1 changelogAndrew Morgan2022-05-051-1/+2
| |
| * Minor wording change to v1.58.1 release notesAndrew Morgan2022-05-051-1/+1
| |
| * 1.58.1Andrew Morgan2022-05-053-3/+15
| |
| * Include extra dependency groups 'systemd' and 'cache_memory' in debian ↵Andrew Morgan2022-05-052-1/+13
| | | | | | | | | | packages (#12640) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Support MSC3266 room summaries over federation (#11507)DeepBlueV7.X2022-05-054-5/+78
| | | | | | | | Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Update `_on_new_receipts()` to work with MSC2285 changes. (#12636)Šimon Brandner2022-05-052-5/+4
| |
* | Improve comments and error messages around access tokens. (#12577)reivilibre2022-05-052-8/+12
| |
* | Use `docker/metadata-action` to generate docker image tags (#12573)Henry2022-05-052-19/+12
| | | | | | | | | | | | | | Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Signed-off-by: Henry <97804910+henryclw@users.noreply.github.com>
* | Use `private` instead of `hidden` in MSC2285 related code. (#12635)Šimon Brandner2022-05-057-25/+26
| |
* | Edits/annotations should not have any bundled aggregations calculated. (#12633)Patrick Cloke2022-05-053-20/+50
| | | | | | | | | | | | Fixes a regression from 8b309adb436c162510ed1402f33b8741d71fc058 (#11660) and b65acead428653b988351ae8d7b22127a22039cd (#11752) where events which themselves were an edit or an annotation could have bundled aggregations calculated, which is not allowed.
* | Remove unused receipt datastore methods. (#12632)Patrick Cloke2022-05-052-54/+1
| | | | | | The last usage was removed in 5a1dd297c3ce105a7f516d9d9fe87b94b9d356c8 (#8059).
* | Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639)Will Hunt2022-05-054-4/+5
| |
* | Reduce log spam when running multiple event persisters (#12610)Erik Johnston2022-05-053-2/+17
| |
* | Add `mau_appservice_trial_days` config (#12619)Will Hunt2022-05-046-2/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add mau_appservice_trial_days * Add a test * Tweaks * changelog * Ensure we sync after the delay * Fix types * Add config statement * Fix test * Reinstate logging that got removed * Fix feature name
* | Use `getClientAddress` instead of `getClientIP`. (#12599)Patrick Cloke2022-05-0416-46/+62
| | | | | | | | | | getClientIP was deprecated in Twisted 18.4.0, which also added getClientAddress. The Synapse minimum version for Twisted is currently 18.9.0, so all supported versions have the new API.
* | Implement changes to MSC2285 (hidden read receipts) (#12168)Šimon Brandner2022-05-0412-186/+647
| | | | | | | | | | * Changes hidden read receipts to be a separate receipt type (instead of a field on `m.read`). * Updates the `/receipts` endpoint to accept `m.fully_read`.
* | Disable device name lookup over federation by default (#12616)Andrew Morgan2022-05-045-12/+24
| |
* | Remove unstable/unspecced login types. (#12597)Patrick Cloke2022-05-046-20/+14
| | | | | | | | | | | | * `m.login.jwt`, which was never specced and has been deprecated since Synapse 1.16.0. (`org.matrix.login.jwt` can be used instead.) * `uk.half-shot.msc2778.login.application_service`, which was stabilized as part of the Matrix spec v1.2 release.
* | Improve logging for cancelled requests (#12587)Sean Quah2022-05-043-1/+32
| | | | | | | | | | | | | | Don't log stack traces for cancelled requests and use a custom HTTP status code of 499. Signed-off-by: Sean Quah <seanq@element.io>
* | Include bundled aggregations for the latest event in a thread. (#12273)Patrick Cloke2022-05-045-51/+198
| | | | | | | | | | | | The `latest_event` field of the bundled aggregations for `m.thread` relations did not include bundled aggregations itself. This resulted in clients needing to immediately request the event from the server (and thus making it useless that the latest event itself was serialized instead of just including an event ID).
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-25 21:54:34 +0000