summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types ↵Will Hunt2022-04-223-2/+3
| | | | | | | (#12520) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog
* turn-howto: fix some linksRichard van der Hoff2022-04-221-2/+2
|
* Await un-partial-stating after a partial-state join (#12399)Richard van der Hoff2022-04-2110-6/+291
| | | | | | When we join a room via the faster-joins mechanism, we end up with "partial state" at some points on the event DAG. Many parts of the codebase need to wait for the full state to load. So, we implement a mechanism to keep track of which events have partial state, and wait for them to be fully-populated.
* Remove leftover references to setup.py (#12514)David Robertson2022-04-203-3/+4
| | | | | | | * Remove leftover references to setup.py Missed in #12478. * Changelog
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-204-5/+30
|\
| * Clarify changelog entry v1.57.1Olivier Wilkinson (reivilibre)2022-04-201-2/+4
| |
| * 1.57.1Olivier Wilkinson (reivilibre)2022-04-205-3/+21
| |
| * Include version 0.2.0 of the Synapse LDAP Auth Provider module in the Docker ↵reivilibre2022-04-202-4/+9
| | | | | | | | | | | | | | | | | | image. (#12512) * poetry update matrix-synapse-ldap3 * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Dump setuptools; correct pyproject version number (#12478)David Robertson2022-04-2013-412/+11
| |
* | Fix Jinja templating error when generating thumbnail URLs. (#12510)Patrick Cloke2022-04-202-1/+2
| | | | | | scale is meant to be a constant string, not refer to a variable.
* | Recommend poetry in docs (#12475)David Robertson2022-04-205-50/+301
| | | | | | | | | | | | | | | | | | | | | | * Recommend poetry in docs - readme - contributor guide - upgrade notes - new dev cheat sheet for poetry Co-authored-by: Shay <hillerys@element.io> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Remove unnecessary config overrides for MSC3666. (#12511)Patrick Cloke2022-04-202-4/+1
| |
* | Implement MSC2815: allow room moderators to view redacted event content (#12427)Tulir Asokan2022-04-207-3/+100
| | | | | | | | | | | | Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>
* | Add CI job to act as a canary for testing against latest dependencies (#12472)David Robertson2022-04-203-0/+161
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Fix returned count of delete extremities admin API (#12496)Erik Johnston2022-04-192-3/+6
| |
* | Fix `/room/.../event/...` to return the *original* event after any edits ↵Richard van der Hoff2022-04-194-39/+79
| | | | | | | | | | | | (#12476) This is what the MSC (now) requires. Fixes https://github.com/matrix-org/synapse/issues/10310.
* | Fix typo in deb changelogs from release script (#12497)Richard van der Hoff2022-04-192-1/+2
| | | | | | | | The release script used to incorrectly write `New synapse release 1.57.0~rc1.` instead of `New synapse release 1.57.0rc1.`
* | Implement MSC3383: include destination in X-Matrix auth header (#11398)Jan Christian Grünhage2022-04-194-11/+48
| | | | | | | | Co-authored-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz> Co-authored-by: Marcus Hoffmann <bubu@bubu1.eu>
* | Fix a link in `README.rst` (#12495)Dirk Klimpel2022-04-192-1/+2
| | | | | | | | | | * Fix a link in `README.rst` * newsfile
* | fix typo in debian changelogRichard van der Hoff2022-04-191-1/+1
| |
* | Remove 'Non-maintainer upload' line from Debian changelogOlivier Wilkinson (reivilibre)2022-04-191-1/+0
| |
* | Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-04-195-6/+18
|\|
| * Link to specific version of upgrade notes v1.57.0Olivier Wilkinson (reivilibre)2022-04-191-1/+1
| |
| * fix typo in upgrade notesRichard van der Hoff2022-04-191-1/+1
| |
| * 1.57.0Olivier Wilkinson (reivilibre)2022-04-194-4/+16
| |
* | Back out implementation of MSC2314 (#12474)Richard van der Hoff2022-04-195-61/+13
| | | | | | | | | | | | | | | | MSC2314 has now been closed, so we're backing out its implementation, which originally happened in #6176. Unfortunately it's not a direct revert, as that PR mixed in a bunch of unrelated changes to tests etc.
* | Fix grammatical error in error message (#12483)Travis Ralston2022-04-182-1/+2
| | | | | | | | | | * Fix grammatical error in error message * changelog
* | Add a manual documenting config file options (#12368)Shay2022-04-183-0/+3414
| |
* | Dockerfile-workers: reduce the amount we install (#12464)Richard van der Hoff2022-04-144-13/+27
| | | | | | | | This is an attempt to reduce the rebuild time. In short, we reduce the amount of stuff that the dockerfile installs, so as to give a faster startup.
* | Update documentation to reflect that `run_background_tasks_on` is no longer ↵reivilibre2022-04-142-4/+5
| | | | | | | | | | | | | | | | | | | | | | experimental. (#12451) * Background workers aren't experimental anymore * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Stream writers aren't experimental either
* | complement-synapse-workers: factor out separate entry point script (#12467)Richard van der Hoff2022-04-143-33/+58
| | | | | | ... with a bit more verbosity.
* | Replace `federation_reader` with `generic_worker` in docs (#12457)Dirk Klimpel2022-04-145-24/+23
| |
* | Only send out device list updates for our own users (#12465)Erik Johnston2022-04-145-8/+56
| | | | | | Broke in #12365
* | Reintroduce the lint targets in the linter script (#12455)David Robertson2022-04-143-41/+30
| |
* | Use `poetry` to manage the virtualenv in debian packages (#12449)David Robertson2022-04-144-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use `poetry` to build venv in debian packages Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io> * Changelog * Only pull in from requirements.txt Addresses the same problem as #12439. * Include `test` and `all` extras `poetry export` helpfully silently ignores an unknown extra Haven't seen this before because it's the only place we export `all` and `test`. I could have __sworm__ that the syntax `--extra "all test"` worked for `poetry install`... * Clean up requirements file on subsequence builds * Fix shell syntax Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io>
* | Dockerfile-workers: give the master its own log config (#12466)Richard van der Hoff2022-04-132-17/+32
| | | | | | | | | | | | | | | | | | | | | | When we run a worker-mode synapse under docker, everything gets logged to stdout. Currently, output from the workers is tacked with a worker name, for example: ``` 2022-04-13 15:27:56,810 - worker:frontend_proxy1 - synapse.util.caches.lrucache - 154 - INFO - LruCache._expire_old_entries-0 - Dropped 0 items from caches ``` - note `worker:frontend_proxy1`. No such tag is applied to log lines from the master, which makes somewhat confusing reading. To fix this, we generate a dedicated log config file for the master in the same way that we do for the workers, and use that.
* | Limit `device_id` size to 512B (#12454)Shay2022-04-133-1/+36
| | | | | | *
* | docs: Don't render the table of contents on the print page (#12340)Andrew Morgan2022-04-132-0/+15
| |
* | Prevent a sync request from removing a user's busy presence status (#12213)David Baker2022-04-135-18/+133
| | | | | | | | | | | | | | | | | | | | In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.
* | Fix missing sync events during historical batch imports (#12319)Nick Mills-Barrett2022-04-135-19/+162
| | | | | | | | | | | | | | | | Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com
* | Use poetry lockfile in twisted trunk CI job (#12425)David Robertson2022-04-133-20/+35
| | | | | | | | | | | | Fixes #12458 Co-authored-by: Sean Quah <seanq@element.io> Co-authored-by: Dan Callahan <danc@element.io>
* | Rename Mutual Rooms `unstable_features` flag to match MSC (#12445)Jonathan de Jong2022-04-132-1/+2
| | | | | | Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>
* | Bump twisted version to the latest in lockfile (#12441)Shay2022-04-122-9/+11
| |
* | Run "main" trial tests under poetry (#12438)David Robertson2022-04-122-13/+14
| | | | | | | | | | | | | | | | | | | | | | * Run "main" trial tests under poetry Olddeps and twisted trunk tests are handled in separate PRs. The PyPy config is a best-effort only; it's completely untested. Pulled out from #12337. * Changelog
* | Run lints under poetry in CI; remove lint tox jobs (#12434)David Robertson2022-04-124-46/+12
| | | | | | Co-authored-by: Dan Callahan <danc@element.io>
* | Process device list updates asynchronously (#12365)Erik Johnston2022-04-127-119/+40
| |
* | Remove the unstable event field for `/send_join` per MSC3083. (#12395)Patrick Cloke2022-04-123-12/+1
| | | | | | | | | | | | | | This was missed when initially stabilising room version 8 and was left in as a compatibility shim. Most homeservers have upgraded to a version which expects the proper field name, and the failure mode is reasonable (a user on an older server may have to attempt joining the room twice with an obscure error message the first time).
* | Fix typos in release script docs (#12450)Erik Johnston2022-04-122-1/+3
| |
* | Merge branch 'release-v1.57' into developErik Johnston2022-04-1293-5847/+5920
|\|
| * Update changelogErik Johnston2022-04-121-10/+6
| |
| * Update UPGRADE notes to include more details about v1.57 upgrade failure ↵Richard van der Hoff2022-04-121-8/+47
| | | | | | | | mode (#12448)
| * Split changelogs by year v1.57.0rc1Erik Johnston2022-04-126-5753/+5759
| |
| * Don't line wrapErik Johnston2022-04-121-7/+2
| |
| * 1.57.0rc1Erik Johnston2022-04-1287-86/+123
| |
* | Disable groups/communities by default. (#12344)Patrick Cloke2022-04-124-1/+10
| | | | | | | | This disables the endpoints (and sync response fields) for groups/communities by default.
* | Resync state after partial-state join (#12394)Richard van der Hoff2022-04-128-0/+289
| | | | | | | | | | We work through all the events with partial state, updating the state at each of them. Once it's done, we recalculate the state for the whole room, and then mark the room as having complete state.
* | Remove references to unstable identifiers from MSC3440. (#12382)Patrick Cloke2022-04-1211-98/+21
|/ | | | | Removes references to unstable thread relation, unstable identifiers for filtering parameters, and the experimental config flag.
* Add some type hints to datastore (#12423)Dirk Klimpel2022-04-129-77/+123
| | | | | | | | | | | | | | | | | | | * Add some type hints to datastore * newsfile * change `Collection` to `List` * refactor return type of `select_users_txn` * correct type hint in `stream.py` * Remove `Optional` in `select_users_txn` * remove not needed return type in `__init__` * Revert change in `get_stream_id_for_event_txn` * Remove import from `Literal`
* Poetry: select olddeps using `poetry` (#12407)David Robertson2022-04-124-29/+70
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Specify tls extra for Twisted dependency. (#12444)Erik Johnston2022-04-125-9/+10
| | | | | | | | | | | * Specify `tls` extra for Twisted dependency. It was already pulled in for us by `treq`, but we should be explicit that we do use the `tls` functionality of Twisted directly. * Mark `idna` as dev-dependency This doesn't actually change anything, as `Twisted[tls]` will put it in as a main dependency anyway.
* Workaround pip bug installing latest treq and not-latest twisted from hashes ↵David Robertson2022-04-122-1/+2
| | | | | | | | | | | | | | | | | | | | | | | (#12439) The requirements file generated by `poetry export` isn't correctly processed by `pip install -r requirements.txt`. It contains twisted and treq, both pinned to 22.2.0. When `pip` installs treq, it notices that `Twisted[tls]` is required. It then tries to acquire the latest twisted release, only to fail (because this hash isn't listed in the requirements file).From e.g. https://github.com/matrix-org/synapse/runs/5977154990?check_suite_focus=true > ``` > #15 9.204 Collecting Twisted[tls]>=18.7.0 > #15 9.205 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: > #15 9.205 Twisted[tls]>=18.7.0 from https://files.pythonhosted.org/packages/db/99/38622ff95bb740bcc991f548eb46295bba62fcb6e907db1987c4d92edd09/Twisted-22.4.0-py3-none-any.whl#sha256=f9f7a91f94932477a9fc3b169d57f54f96c6e74a23d78d9ce54039a7f48928a2 (from treq==22.2.0->-r /synapse/requirements.txt (line 724)) > #15 ERROR: executor failed running [/bin/sh -c pip install --prefix="/install" --no-warn-script-location -r /synapse/requirements.txt]: exit code: 1 > ``` The underlying pip issue is https://github.com/pypa/pip/issues/9644. A comment notes that one can avoid this behaviour with by `pip install`ing with the `--no-deps` flag. Let us do so. (At first glance, the problem looks like https://github.com/python-poetry/poetry/issues/5311, but that was a bug in `poetry install`; this is `poetry export`, whose behaviour is fine AFAICS).
* Remove experimental configuration flag for MSC3666. (#12436)Patrick Cloke2022-04-113-19/+15
|
* Add missing type hints to config classes. (#12402)Patrick Cloke2022-04-1151-151/+263
|
* Enable certificate checking during complement tests (#12435)Richard van der Hoff2022-04-113-12/+1
|
* Do not consider events by ignored users for bundled aggregations (#12235)Patrick Cloke2022-04-116-45/+427
| | | | | | | Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / 4df10d32148ae29f792afc68ff774bcbd1915cea for corresponding changes for the `/relations` endpoint.
* Fix up healthcheck generation for workers docker image (#12405)Richard van der Hoff2022-04-114-11/+11
| | | This wasn't quite generating the right thing.
* Disallow untyped defs in synapse._scripts (#12422)David Robertson2022-04-1114-140/+221
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.
* Move complement setup stuff into the Synapse repo (#12404)Richard van der Hoff2022-04-1112-52/+449
| | | | | | Fixes matrix-org/complement#330 (or it will, once we remove the old files). It's not quite a lift-and-shift: I've also taken the opportunity to get rid of the custom CA that we used to use to sign the TLS certs, which has been superceded by the CA exposed by Complement.
* Add Module API for reading and writing global account data. (#12391)reivilibre2022-04-113-0/+234
|
* CI: Fix the export-data job to run under poetry (#12418)David Robertson2022-04-083-16/+13
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Optimise `_update_client_ips_batch_txn` to batch together database ↵reivilibre2022-04-084-51/+190
| | | | | operations. (#12252) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Make `synapse._scripts` pass typechecks (#12421)David Robertson2022-04-086-43/+50
|
* Stop maintaining a list of lint targets in `lint.sh` (#12420)David Robertson2022-04-085-31/+10
|
* Unify HTTP query parameter type hints (#12415)David Robertson2022-04-086-38/+43
| | | | | | * Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410
* Update the server notices user profile in room if changed. (#12115)Jorge Florian2022-04-083-4/+148
|
* CI: Get the portdb job to run under poetry (#12412)David Robertson2022-04-083-19/+15
|
* Add missing type definitions for scripts in docker folder (#12280)Jorge Florian2022-04-083-4/+7
| | | | Signed-off-by: Jorge Florian <jafn28@gmail.com>
* Fix rejecting invites over federation (#12409)Erik Johnston2022-04-072-20/+34
| | | | | Currently causes future incremental syncs to fail. Broke by #12191
* Fix fetching public rooms over federation (#12410)Erik Johnston2022-04-072-1/+2
| | | Broke by #12364
* Do not add groups to sync results if disabled. (#12408)Patrick Cloke2022-04-073-10/+11
|
* Add opentracing spans to calls to external cache (#12380)Erik Johnston2022-04-073-11/+24
|
* Poetry: use locked environment in Docker images (#12385)David Robertson2022-04-074-26/+69
|
* Support the v1 endpoint for `/relations`. (#12403)Patrick Cloke2022-04-073-12/+13
| | | | Now that MSC2675 has passed FCP and the implementation is compliant with the final version.
* Clarify that we mark as outliers because we don't have any state for them ↵Eric Eastwood2022-04-062-1/+3
| | | | | (#12345) As discussed at https://github.com/matrix-org/synapse/pull/12179#discussion_r837263852
* Update changelog to describe changes from #12370 relative to `develop` (#12401)Eric Eastwood2022-04-062-1/+1
|
* Remove docs for converting a legacy structured logging config. (#12392)Patrick Cloke2022-04-063-81/+3
| | | And update the upgrade notes to point at old versions of the documentation.
* Remove support for the unstable identifier from MSC3288. (#12398)Patrick Cloke2022-04-062-2/+1
|
* Narrow the `importlib_metadata` dependency (#12400)David Robertson2022-04-062-1/+2
|
* Fix `synapse_event_persisted_position` metric (#12390)Richard van der Hoff2022-04-062-3/+4
| | | | Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`
* Update type annotations for compatiblity with prometheus_client 0.14 (#12389)Richard van der Hoff2022-04-068-18/+67
| | | | | | | Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.
* Generate historic pagination token for `/messages` when no `?from` token ↵Eric Eastwood2022-04-066-15/+27
| | | | provided (#12370)
* Add missing dependency on importlib_metadata (#12384)David Robertson2022-04-054-1/+8
|
* Poetry: initial pyproject.toml and poetry.lock (#12381)David Robertson2022-04-054-0/+3062
| | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Post 1.56.0 release tidy up (#12379)Sean Quah2022-04-053-2/+2
|
* Update mdbook to 0.4.17 (#12339)Andrew Morgan2022-04-052-1/+2
| | | Update mdbook (the tool used to render the documentation website) to version 0.4.17.
* Fix edge case where a `Linearizer` could get stuck (#12358)Sean Quah2022-04-053-5/+53
| | | | | | | Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
* Make `StreamToken` and `RoomStreamToken` methods propagate cancellations ↵Sean Quah2022-04-052-0/+6
| | | | | | | | | (#12366) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>
* Update docstrings for `ReadWriteLock` tests (#12354)Sean Quah2022-04-052-6/+7
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Refactor and convert `Linearizer` to async (#12357)Sean Quah2022-04-0521-115/+104
| | | | | | | | | | | Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>
* Merge branch 'master' into developSean Quah2022-04-055-10/+39
|\
| * Tweak CHANGES.md v1.56.0Sean Quah2022-04-051-3/+1
| |
| * 1.56.0Sean Quah2022-04-055-6/+20
| |
| * Pin signedjson to <= 1.1.1 as a temporary workaround for #12324Sean Quah2022-04-051-1/+1
| | | | | | | | | | | | To be reverted after the Synapse 1.56 release. Signed-off-by: Sean Quah <seanq@element.io>
| * Bump `black` and `click` versions (#12320)David Robertson2022-04-0516-30/+37
| |
| * Add note in changelog of non-C type locale causing Synapse to refuse to ↵Andrew Morgan2022-03-291-0/+5
| | | | | | | | start (#12323)
| * Move warning of open registration to v1.56 upgrade notes (#12322)Andrew Morgan2022-03-293-7/+18
| |
* | Convert `Linearizer` tests from `inlineCallbacks` to async (#12353)Sean Quah2022-04-052-91/+134
| | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Prefill more stream change caches. (#12372)Erik Johnston2022-04-056-61/+92
| |
* | Add type hints to some tests files (#12371)Dirk Klimpel2022-04-056-42/+58
| |
* | Fix a spec compliance issue where requests to the `/publicRooms` federation ↵reivilibre2022-04-052-2/+3
| | | | | | | | API would specify `limit` as a string. (#12364)
* | Allow specifying the Postgres database's port when running unit tests with ↵reivilibre2022-04-054-3/+24
| | | | | | | | Postgres. (#12376)
* | Merge tag 'v1.56.0rc1' into developRichard van der Hoff2022-04-0547-3685/+3707
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314))
| * Missing period v1.56.0rc1Brendan Abolivier2022-03-291-1/+1
| |
| * Fix formattingBrendan Abolivier2022-03-291-1/+1
| |
| * Link to pre-1.0 changelogBrendan Abolivier2022-03-291-0/+2
| |
| * Linkify MSCsBrendan Abolivier2022-03-291-2/+2
| |
| * Split changelogsBrendan Abolivier2022-03-292-3642/+3640
| |
| * Fixup changelogBrendan Abolivier2022-03-291-13/+13
| |
| * 1.56.0rc1Brendan Abolivier2022-03-2946-44/+66
| |
* | Explain how to decipher live and historic pagination tokens (#12317)Eric Eastwood2022-04-052-11/+86
| |
* | Update broken link in `workers.md` (#12369)Shay2022-04-042-1/+2
| |
* | Allow non-member state sent in room batch to resolve for historic events ↵Eric Eastwood2022-04-042-26/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | (MSC2716) (#12329) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.
* | Prefill the device_list_stream_cache (#12367)Erik Johnston2022-04-043-2/+23
| | | | | | | | | | | | | | * Prefill the device_list_stream_cache * Newsfile * Newsfile
* | Track device list updates per room. (#12321)Erik Johnston2022-04-0411-47/+390
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.
* | Remove more dead/broken dev scripts (#12355)David Robertson2022-04-035-359/+1
| |
* | Add type hints for `tests/unittest.py`. (#12347)Richard van der Hoff2022-04-0112-48/+97
| | | | | | In particular, add type hints for get_success and friends, which are then helpful in a bunch of places.
* | Remove redundant `get_success` calls in test code (#12346)Richard van der Hoff2022-04-0113-121/+74
| | | | | | There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.
* | Default to `private` room visibility rather than `public` when a client does ↵reivilibre2022-04-015-7/+15
| | | | | | | | not specify one, according to spec. (#12350)
* | Burn `check_signature` dev script. (#12351)David Robertson2022-04-014-74/+2
| |
* | Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209)Nick Mills-Barrett2022-04-016-113/+83
| | | | | | | | | | | | | | | | Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.
* | Remove `list_url_patterns` dev script (#12349)David Robertson2022-04-013-61/+1
| |
* | Move single-use methods out of `TestCase` (#12348)Richard van der Hoff2022-04-014-27/+28
| | | | | | | | These methods are only used by a single testcase, so they shouldn't be cluttering up the base `TestCase` class.
* | Move `update_client_ip` background job from the main process to the ↵reivilibre2022-04-0110-153/+160
| | | | | | | | background worker. (#12251)
* | Raise an exception when getting state at an outlier (#12191)Richard van der Hoff2022-04-014-22/+87
| | | | | | | | | | | | It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.
* | Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040)Richard van der Hoff2022-04-014-9/+268
| | | | | | If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.
* | Add a module callback to react to account data changes (#12327)Brendan Abolivier2022-04-017-2/+250
| | | | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Add set_user_admin function to the module API (#12341)Amanda Graven2022-04-013-0/+26
| |
* | Move MSC2654 support behind an experimental configuration flag. (#12295)Patrick Cloke2022-03-314-1/+12
| | | | | | To match the current thinking on disabling experimental features by default.
* | Handle outliers in `/federation/v1/event` (#12332)Richard van der Hoff2022-03-313-106/+182
| | | | | | | | | | | | | | The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.
* | Add more type hints to the main state store. (#12267)Patrick Cloke2022-03-314-10/+16
| |
* | Add a callback to react to 3PID associations (#12302)Brendan Abolivier2022-03-316-0/+92
| |
* | README-testing.md: fix minor errorRichard van der Hoff2022-03-311-1/+1
| |
* | Remove an unnecessary class from the relations code. (#12338)Patrick Cloke2022-03-314-74/+32
| | | | | | | | | | The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.
* | Remove `dockerfile-pgtests` (#12336)David Robertson2022-03-315-89/+1
| |
* | Ignore .envrc for direnv users (#12335)David Robertson2022-03-312-0/+4
| |
* | Nuke the tox `packaging` job (#12334)David Robertson2022-03-313-10/+2
| |
* | Ensure the type of URL attributes is always str when matching against ↵Brendan Abolivier2022-03-313-4/+49
| | | | | | | | preview blacklist (#12333)
* | Remove the unused and unstable `/aggregations` endpoint. (#12293)Patrick Cloke2022-03-306-478/+17
| | | | | | | | | | | | | | | | | | This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.
* | Send device list updates to application services (MSC3202) - part 1 (#11881)Andrew Morgan2022-03-3015-82/+490
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Flesh out documentation for running SyTest against Synapse, including use of ↵reivilibre2022-03-302-1/+8
| | | | | | | | | | Postgres and worker mode. (#12271) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Update dead links in check-newsfragment.sh (#12331)David Robertson2022-03-302-2/+3
| |
* | Remove references to "msc2403" (#12165)Andrew Morgan2022-03-305-5/+4
| |
* | Start application service stream token tracking from 1 (#12193)Andrew Morgan2022-03-304-4/+6
| | | | | | Co-authored-by: Erik Johnston <erik@matrix.org>
* | Disable proactive sends for remote joins (#12330)Richard van der Hoff2022-03-302-0/+7
| | | | | | | | Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.
* | Add a configuration to exclude rooms from sync response (#12310)Brendan Abolivier2022-03-307-21/+138
| |
* | Fix typechecker problems exposed by signedjson 1.1.2 (#12326)David Robertson2022-03-299-25/+38
| |
* | Room batch: fix up handling of unknown prev_event_ids (#12316)Richard van der Hoff2022-03-292-8/+14
| |
* | Update `LoggingTransaction.call_after` and `call_on_exception` docstrings ↵Sean Quah2022-03-292-3/+21
| | | | | | | | | | | | | | | | (#12315) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>
* | Bump `black` and `click` versions (#12320)David Robertson2022-03-2916-30/+37
|/
* Remove unused `auth_event_ids` argument plumbing (#12304)Eric Eastwood2022-03-293-27/+1
| | | | | | | | | | | | | | Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`
* Exclude outliers in `on_backfill_request` (#12314)Richard van der Hoff2022-03-282-3/+10
| | | | | | When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.
* Add some type hints to datastore. (#12255)Dirk Klimpel2022-03-2810-42/+61
|
* Un-revert Jinja2 fix (#12313)Brendan Abolivier2022-03-283-6/+10
| | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Allow modules to store already existing 3PID associations (#12195)Brendan Abolivier2022-03-282-1/+27
|
* Improve type annotations for `execute_values`. (#12311)reivilibre2022-03-282-10/+8
|
* HAProxy guide update (#12279)villepeh2022-03-282-2/+3
| | | HAproxy reverse proxy guide update to stop sending IPv4-mapped address to HS.
* Add restrictions by default to open registration in Synapse (#12091)Shay2022-03-257-4/+67
|
* Add cache for `get_membership_from_event_ids` (#12272)Erik Johnston2022-03-256-22/+72
| | | | | This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>
* Enhance logging for inbound federation events (#12301)Richard van der Hoff2022-03-252-1/+2
| | | | It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.
* Refactor `create_new_client_event` to use a new parameter, ↵Eric Eastwood2022-03-255-65/+165
| | | | | | | `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)
* Always allow the empty string as an avatar_url. (#12261)David Robertson2022-03-254-0/+32
| | | | | Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Authentik OpenID minor doc update (#12275)IronTooch2022-03-252-1/+4
|
* Mention the new behaviour on unsafe database locale in the upgrade notes ↵Brendan Abolivier2022-03-252-0/+8
| | | | | (#12288) Co-authored-by: Shay <hillerys@element.io>
* Re-enable test concurrency on Complement (#12283)kegsay2022-03-242-1/+2
|
* Merge branch 'master' into developRichard van der Hoff2022-03-245-8/+25
|\
| * changelog v1.55.2Richard van der Hoff2022-03-241-1/+1
| |
| * 1.55.2Richard van der Hoff2022-03-244-2/+19
| |
| * Pin Jinja to <3.1.0 (#12297)Andrew Morgan2022-03-242-1/+3
| | | | | | as 3.1.0 removed the deprecated jinja2.Markup class which we still rely on.
| * Revert "Replace instances of deprecated `Jinja2.Markup` with ↵Andrew Morgan2022-03-242-6/+4
| | | | | | | | | | `markupsafe.Markup`" (#12296) This reverts commit 8810c93e828a9ed1dcb008d08be8aa9fcb4d28c3.
* | Remove unused test code. (#12291)Patrick Cloke2022-03-242-110/+1
| | | | | | | | The `MockHttpResource` and `MockKey` objects were unused since #9396 (74af356baf79de5d719fad6c32b981eedbdd950d).
* | Merge branch 'master' into developAndrew Morgan2022-03-245-5/+24
|\|
| * update changelog for 1.55.1 v1.55.1Andrew Morgan2022-03-241-2/+2
| |
| * 1.55.1Andrew Morgan2022-03-244-2/+18
| |
| * Replace instances of deprecated `Jinja2.Markup` with `markupsafe.Markup` ↵Andrew Morgan2022-03-243-4/+7
| | | | | | | | | | (#12289) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Do not consider events by ignored users for relations (#12285)Patrick Cloke2022-03-247-4/+90
| | | | | | | | Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).
* | Optionally include account validity in MSC3720 account status responses (#12266)Brendan Abolivier2022-03-244-1/+73
| |
* | Refuse to start if DB has an unsafe locale (#12262)Shay2022-03-236-18/+93
| |
* | Use psycopg2 type stubs (#12269)David Robertson2022-03-234-4/+14
| |
* | Remove mutual_rooms `update_user_directory` check, and add extra ↵Jonathan de Jong2022-03-233-5/+17
| | | | | | | | | | documentation (#12038) Resolves #10339
* | Allow registering admin users using the module API (#12250)Nicolas Werner2022-03-233-0/+15
| | | | | | Signed-off-by: Nicolas Werner <n.werner@famedly.com>
* | Rename shared_rooms to mutual_rooms (#12036)Jonathan de Jong2022-03-235-25/+27
| | | | | | Co-authored-by: reivilibre <olivier@librepush.net>
* | Merge branch 'master' into developAndrew Morgan2022-03-227-11/+28
|\|
| * Changelog: sso -> Single Sign-On v1.55.0Andrew Morgan2022-03-221-1/+1
| |
| * changelog: move notice from rc to final releaseAndrew Morgan2022-03-221-4/+5
| |
| * 1.55.0Andrew Morgan2022-03-225-3/+16
| |
| * Tweak copy for sso account details template (#12265)Michael Telatynski2022-03-224-6/+7
| | | | | | | | | | | | | | * Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
| * Call out synctl changeDavid Robertson2022-03-211-1/+3
| |
* | Add type hints to tests files. (#12256)Dirk Klimpel2022-03-216-88/+101
| |
* | Merge branch 'release-v1.55' into developDavid Robertson2022-03-212-1/+2
|\|
| * Reword 'Choose your user name' as 'Choose your account name' in the SSO ↵reivilibre2022-03-212-1/+2
| | | | | | | | | | | | | | | | | | registration template, in order to comply with SIWA guidelines. (#12260) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* | Make it possible to enable compression for the metrics HTTP resource (#12258)Nick Mills-Barrett2022-03-212-1/+5
| | | | | | | | | | | | | | | | | | | | * Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint
* | Return a 404 from `/state` for an outlier (#12087)Richard van der Hoff2022-03-213-44/+25
| | | | | | | | | | * Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier
* | Try to detect borked package installations. (#12244)David Robertson2022-03-183-2/+38
| | | | | | | | | | | | | | * Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Move get_bundled_aggregations to relations handler. (#12237)Patrick Cloke2022-03-189-157/+173
| | | | | | | | | | The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.
* | Only fetch thread participation for events with threads. (#12228)Patrick Cloke2022-03-184-245/+289
| | | | | | | | | | | | | | | | | | We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.
* | Sync more worker regexes in the documentation. (#12243)Patrick Cloke2022-03-182-16/+15
| |
* | Add some type hints to datastore (#12248)Dirk Klimpel2022-03-184-84/+117
| | | | | | | | | | * inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Correct `check_username_for_spam` annotations and docs (#12246)David Robertson2022-03-188-16/+46
| | | | | | | | | | | | | | * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Generate announcement links in release script (#12242)David Robertson2022-03-172-1/+41
| |
* | Add type hints to more tests files. (#12240)Dirk Klimpel2022-03-176-47/+66
| |
* | Merge branch 'release-v1.55' into developPatrick Cloke2022-03-1667-66/+126
|\|
| * Re-generate changelog. v1.55.0rc1Patrick Cloke2022-03-162-1/+1
| |
| * Fix bundling aggregations if unsigned is not a returned event field. (#12234)Patrick Cloke2022-03-163-3/+35
| | | | | | | | | | | | | | An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.
| * Changelog tweaksDavid Robertson2022-03-151-4/+6
| |
| * 1.55.0rc1David Robertson2022-03-1565-63/+89
| |
* | Handle cancellation in `DatabasePool.runInteraction()` (#12199)Sean Quah2022-03-163-24/+96
| | | | | | | | | | | | | | | | | | | | | | | | To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>
* | Add a relations handler to avoid duplication. (#12227)Patrick Cloke2022-03-165-69/+134
| | | | | | Adds a handler layer between the REST and datastore layers for relations.
* | Add some missing type hints to cache datastore. (#12216)Patrick Cloke2022-03-162-21/+37
| |
* | Fix dead link in spam checker warning (#12231)David Robertson2022-03-162-2/+3
| |
* | Refactor relations tests (#12232)Patrick Cloke2022-03-162-406/+364
| | | | | | | | | | * Moves the relation pagination tests to a separate class. * Move the assertion of the response code into the `_send_relation` helper. * Moves some helpers into the base-class.
* | Clean-up logic for rebasing URLs during URL preview. (#12219)Patrick Cloke2022-03-164-91/+26
| | | | | | | | By using urljoin from the standard library and reducing the number of places URLs are rebased.
* | Use the ignored_users table to test event visibility & sync. (#12225)Patrick Cloke2022-03-156-47/+62
| | | | | | | | | | Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.
* | Add tests for database transaction callbacks (#12198)Sean Quah2022-03-152-1/+104
| | | | | | | | Signed-off-by: Sean Quah <seanq@element.io>
* | Add type hints to some tests/handlers files. (#12224)Dirk Klimpel2022-03-157-131/+156
|/
* Add cancellation support to `@cached` and `@cachedList` decorators (#12183)Sean Quah2022-03-143-2/+157
| | | | | | | | These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>
* Add cancellation support to `ReadWriteLock` (#12120)Sean Quah2022-03-144-93/+382
| | | | | | Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>
* Fix broken background updates when using sqlite with `enable_search` off ↵Sean Quah2022-03-142-6/+8
| | | | | (#12215) Signed-off-by: Sean Quah <seanq@element.io>
* Add `delay_cancellation` utility function (#12180)Sean Quah2022-03-143-12/+161
| | | | | | | | | `delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>
* Deprecate the groups/communities endpoints and add an experimental ↵Patrick Cloke2022-03-127-7/+35
| | | | configuration flag. (#12200)
* Add config settings for background update parameters (#11980)Shay2022-03-119-34/+430
|
* Implement a Jinja2 filter to extract localparts from email addresses (#12212)Brendan Abolivier2022-03-116-2/+23
|
* Improve code documentation for the typing stream over replication. (#12211)reivilibre2022-03-115-6/+20
|
* Add an additional HTTP pusher + push rule tests. (#12188)Nick Mills-Barrett2022-03-115-28/+95
| | | And rename the field used for caching from _id to _cache_key.
* Update the SSO username picker template to comply with SIWA guidelines (#12210)Brendan Abolivier2022-03-118-13/+47
| | | Fixes https://github.com/matrix-org/synapse/issues/12205
* Add type hints to `tests/rest`. (#12208)Dirk Klimpel2022-03-115-85/+129
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Add some type hints to the tests.handlers module. (#12207)Patrick Cloke2022-03-117-61/+74
|
* Remove unnecessary pass statements. (#12206)Patrick Cloke2022-03-1111-15/+1
|
* Note that contributors can sign off privately (#12204)Andrew Morgan2022-03-112-0/+12
| | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Retention test: avoid relying on state at purged events (#12202)Richard van der Hoff2022-03-112-12/+18
| | | | This test was relying on poking events which weren't in the database into filter_events_for_client.
* Document that most streams can only have a single writer. (#12196)~creme2022-03-102-14/+18
| | | | This includes the `typing`, `to_device`, `account_data`, `receipts`, and `presence` streams (really anything except the `events` stream).
* fix misleading comment in `check_events_for_spam` (#12203)Shay2022-03-102-2/+3
|
* Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir ↵reivilibre2022-03-103-7/+9
| | | | compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700)
* Support stable identifiers for MSC3440: Threading (#12151)Patrick Cloke2022-03-1013-81/+109
| | | | The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.
* Updates to the Room DAG concepts development document (#12179)Richard van der Hoff2022-03-102-18/+54
| | | | Some stuff that came up while we were talking about #12173.
* Allow retrieving the relations of a redacted event. (#12130)Patrick Cloke2022-03-108-83/+122
| | | | | | | | | This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).
* Rename get_tcp_replication to get_replication_command_handler. (#12192)Patrick Cloke2022-03-1015-19/+20
| | | | | | Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.
* Remove dead code in `tests/storage/test_database.py` (#12197)Sean Quah2022-03-092-16/+1
| | | Signed-off-by: Sean Quah <seanq@element.io>
* Add third_party module callbacks to check if a user can delete a room and ↵Will Hunt2022-03-098-1/+254
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | deactivate a user (#12028) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Allow for ignoring some arguments when caching. (#12189)Patrick Cloke2022-03-094-21/+142
| | | | | * `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)
* Remove some unused variables/parameters. (#12187)Patrick Cloke2022-03-092-9/+6
|
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-11 08:17:39 +0000