summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Do not recurse into non-spaces in the spaces summary. (#10256)Patrick Cloke2021-06-295-26/+43
| | | | | Previously m.child.room events in non-space rooms would be treated as part of the room graph, but this is no longer supported.
* Fix `populate_stream_ordering2` background job (#10267)Richard van der Hoff2021-06-292-16/+13
| | | | It was possible for us not to find any rows in a batch, and hence conclude that we had finished. Let's not do that.
* Migrate stream_ordering to a bigint (#10264)Richard van der Hoff2021-06-294-16/+163
| | | | | | | | | | * Move background update names out to a separate class `EventsBackgroundUpdatesStore` gets inherited and we don't really want to further pollute the namespace. * Migrate stream_ordering to a bigint * changelog
* Soft-fail spammy events received over federation (#10263)Richard van der Hoff2021-06-292-6/+7
|
* Merge branch 'master' into developBrendan Abolivier2021-06-293-3/+11
|\
| * Move deprecation notices to the top of the changelog v1.37.0Brendan Abolivier2021-06-291-6/+2
| |
| * 1.37.0Brendan Abolivier2021-06-293-1/+13
| |
* | Add additional types to the federation transport server. (#10213)Patrick Cloke2021-06-283-118/+521
| |
* | Adjust the URL in the README.rst file to point to LiberaChat instead of ↵Felix Kronlage-Dammers2021-06-282-1/+2
| | | | | | | | freenode (#10258)
* | Create an index.html file when generating a docs build (#10242)Andrew Morgan2021-06-242-1/+7
| | | | | | | | | | | | | | | | | | Currently when a new build of the docs is created, an `index.html` file does not exist. Typically this would be generated from a`docs/README.md` file - which we have - however we're currently using [docs/README.md](https://github.com/matrix-org/synapse/blob/394673055db4df49bfd58c2f6118834a6d928563/docs/README.md) to explain the docs and point to the website. It is not part of the content of the website. So we end up not having an `index.html` file, which will result in a 404 page if one tries to navigate to `https://matrix-org.github.io/synapse/<docs_version>/index.html`. This isn't a really problem for the default version of the documentation (currently `develop`), as [navigating to the top-level root](https://matrix-org.github.io/synapse/) of the website (without specifying a version) will [redirect](https://github.com/matrix-org/synapse/blob/a77e6925f26597958eccf0ef9956cb13c536e57e/index.html#L2) you to the Welcome and Overview page of the `develop` docs version. However, ideally once we add a GUI for switching between versions, we'll want to send the user to `matrix-org.github.io/synapse/<version>/index.html`, which currently isn't generated. This PR modifies the CI that builds the docs to simply copy the rendered [Welcome & Overview page](https://matrix-org.github.io/synapse/develop/welcome_and_overview.html) to `index.html`.
* | Return errors from `send_join` etc if the event is rejected (#10243)Richard van der Hoff2021-06-243-10/+41
| | | | | | Rather than persisting rejected events via `send_join` and friends, raise a 403 if someone tries to pull a fast one.
* | Improve validation for `send_{join,leave,knock}` (#10225)Richard van der Hoff2021-06-246-183/+132
| | | | | | The idea here is to stop people sending things that aren't joins/leaves/knocks through these endpoints: previously you could send anything you liked through them. I wasn't able to find any security holes from doing so, but it doesn't sound like a good thing.
* | MSC2918 Refresh tokens implementation (#9450)Quentin Gliech2021-06-2415-61/+892
| | | | | | | | | | | | | | | | | | | | This implements refresh tokens, as defined by MSC2918 This MSC has been implemented client side in Hydrogen Web: vector-im/hydrogen-web#235 The basics of the MSC works: requesting refresh tokens on login, having the access tokens expire, and using the refresh token to get a new one. Signed-off-by: Quentin Gliech <quentingliech@gmail.com>
* | Merge tag 'v1.37.0rc1' into developBrendan Abolivier2021-06-2450-53/+155
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.37.0rc1 (2021-06-24) ============================== This release deprecates the current spam checker interface. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new generic module interface. This release also removes support for fetching and renewing TLS certificates using the ACME v1 protocol, which has been fully decommissioned by Let's Encrypt on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. Features -------- - Implement "room knocking" as per [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403). Contributed by @Sorunome and anoa. ([\#6739](https://github.com/matrix-org/synapse/issues/6739), [\#9359](https://github.com/matrix-org/synapse/issues/9359), [\#10167](https://github.com/matrix-org/synapse/issues/10167), [\#10212](https://github.com/matrix-org/synapse/issues/10212), [\#10227](https://github.com/matrix-org/synapse/issues/10227)) - Add experimental support for backfilling history into rooms ([MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716)). ([\#9247](https://github.com/matrix-org/synapse/issues/9247)) - Implement a generic interface for third-party plugin modules. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10206](https://github.com/matrix-org/synapse/issues/10206)) - Implement config option `sso.update_profile_information` to sync SSO users' profile information with the identity provider each time they login. Currently only displayname is supported. ([\#10108](https://github.com/matrix-org/synapse/issues/10108)) - Ensure that errors during startup are written to the logs and the console. ([\#10191](https://github.com/matrix-org/synapse/issues/10191)) Bugfixes -------- - Fix a bug introduced in Synapse v1.25.0 that prevented the `ip_range_whitelist` configuration option from working for federation and identity servers. Contributed by @mikure. ([\#10115](https://github.com/matrix-org/synapse/issues/10115)) - Remove a broken import line in Synapse's `admin_cmd` worker. Broke in Synapse v1.33.0. ([\#10154](https://github.com/matrix-org/synapse/issues/10154)) - Fix a bug introduced in Synapse v1.21.0 which could cause `/sync` to return immediately with an empty response. ([\#10157](https://github.com/matrix-org/synapse/issues/10157), [\#10158](https://github.com/matrix-org/synapse/issues/10158)) - Fix a minor bug in the response to `/_matrix/client/r0/user/{user}/openid/request_token` causing `expires_in` to be a float instead of an integer. Contributed by @lukaslihotzki. ([\#10175](https://github.com/matrix-org/synapse/issues/10175)) - Always require users to re-authenticate for dangerous operations: deactivating an account, modifying an account password, and adding 3PIDs. ([\#10184](https://github.com/matrix-org/synapse/issues/10184)) - Fix a bug introduced in Synpase v1.7.2 where remote server count metrics collection would be incorrectly delayed on startup. Found by @heftig. ([\#10195](https://github.com/matrix-org/synapse/issues/10195)) - Fix a bug introduced in Synapse v1.35.1 where an `allow` key of a `m.room.join_rules` event could be applied for incorrect room versions and configurations. ([\#10208](https://github.com/matrix-org/synapse/issues/10208)) - Fix performance regression in responding to user key requests over federation. Introduced in Synapse v1.34.0rc1. ([\#10221](https://github.com/matrix-org/synapse/issues/10221)) Improved Documentation ---------------------- - Add a new guide to decoding request logs. ([\#8436](https://github.com/matrix-org/synapse/issues/8436)) - Mention in the sample homeserver config that you may need to configure max upload size in your reverse proxy. Contributed by @aaronraimist. ([\#10122](https://github.com/matrix-org/synapse/issues/10122)) - Fix broken links in documentation. ([\#10180](https://github.com/matrix-org/synapse/issues/10180)) - Deploy a snapshot of the documentation website upon each new Synapse release. ([\#10198](https://github.com/matrix-org/synapse/issues/10198)) Deprecations and Removals ------------------------- - The current spam checker interface is deprecated in favour of a new generic modules system. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#deprecation-of-the-current-spam-checker-interface) for more information on how to update to the new system. ([\#10062](https://github.com/matrix-org/synapse/issues/10062), [\#10210](https://github.com/matrix-org/synapse/issues/10210), [\#10238](https://github.com/matrix-org/synapse/issues/10238)) - Stop supporting the unstable spaces prefixes from MSC1772. ([\#10161](https://github.com/matrix-org/synapse/issues/10161)) - Remove Synapse's support for automatically fetching and renewing certificates using the ACME v1 protocol. This protocol has been fully turned off by Let's Encrypt for existing installations on June 1st 2021. Admins previously using this feature should use a [reverse proxy](https://matrix-org.github.io/synapse/develop/reverse_proxy.html) to handle TLS termination, or use an external ACME client (such as [certbot](https://certbot.eff.org/)) to retrieve a certificate and key and provide them to Synapse using the `tls_certificate_path` and `tls_private_key_path` configuration settings. ([\#10194](https://github.com/matrix-org/synapse/issues/10194)) Internal Changes ---------------- - Update the database schema versioning to support gradual migration away from legacy tables. ([\#9933](https://github.com/matrix-org/synapse/issues/9933)) - Add type hints to the federation servlets. ([\#10080](https://github.com/matrix-org/synapse/issues/10080)) - Improve OpenTracing for event persistence. ([\#10134](https://github.com/matrix-org/synapse/issues/10134), [\#10193](https://github.com/matrix-org/synapse/issues/10193)) - Clean up the interface for injecting OpenTracing over HTTP. ([\#10143](https://github.com/matrix-org/synapse/issues/10143)) - Limit the number of in-flight `/keys/query` requests from a single device. ([\#10144](https://github.com/matrix-org/synapse/issues/10144)) - Refactor EventPersistenceQueue. ([\#10145](https://github.com/matrix-org/synapse/issues/10145)) - Document `SYNAPSE_TEST_LOG_LEVEL` to see the logger output when running tests. ([\#10148](https://github.com/matrix-org/synapse/issues/10148)) - Update the Complement build tags in GitHub Actions to test currently experimental features. ([\#10155](https://github.com/matrix-org/synapse/issues/10155)) - Add a `synapse_federation_soft_failed_events_total` metric to track how often events are soft failed. ([\#10156](https://github.com/matrix-org/synapse/issues/10156)) - Fetch the corresponding complement branch when performing CI. ([\#10160](https://github.com/matrix-org/synapse/issues/10160)) - Add some developer documentation about boolean columns in database schemas. ([\#10164](https://github.com/matrix-org/synapse/issues/10164)) - Add extra logging fields to better debug where events are being soft failed. ([\#10168](https://github.com/matrix-org/synapse/issues/10168)) - Add debug logging for when we enter and exit `Measure` blocks. ([\#10183](https://github.com/matrix-org/synapse/issues/10183)) - Improve comments in structured logging code. ([\#10188](https://github.com/matrix-org/synapse/issues/10188)) - Update [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083) support with modifications from the MSC. ([\#10189](https://github.com/matrix-org/synapse/issues/10189)) - Remove redundant DNS lookup limiter. ([\#10190](https://github.com/matrix-org/synapse/issues/10190)) - Upgrade `black` linting tool to 21.6b0. ([\#10197](https://github.com/matrix-org/synapse/issues/10197)) - Expose OpenTracing trace id in response headers. ([\#10199](https://github.com/matrix-org/synapse/issues/10199))
| * Incorportate review comments v1.37.0rc1Brendan Abolivier2021-06-241-3/+3
| |
| * Fix date in changelogBrendan Abolivier2021-06-241-1/+1
| |
| * Tweak changelogBrendan Abolivier2021-06-242-15/+19
| |
| * Fix wrapping of legacy check_registration_for_spam (#10238)Brendan Abolivier2021-06-233-6/+84
| | | | | | Fixes #10234
| * 1.37.0rc1Brendan Abolivier2021-06-2348-47/+67
| |
* | Convert UPGRADE.rst to markdown (#10166)Andrew Morgan2021-06-238-1365/+1381
| | | | | | | | | | | | | | | | | | This PR: * Converts UPGRADE.rst to markdown and moves the contents into the `docs/` directory. * Updates the contents of UPGRADE.rst to point to the website instead. * Updates links around the codebase that point to UPGRADE.rst. `pandoc` + some manual editing was used to convert from RST to md.
* | Fixes to the release script (#10239)Brendan Abolivier2021-06-232-25/+28
| | | | | | | | * rename major/minor into the right semver terminology minor/patch (since this was something that got me very confused the first couple of times I've used the script) * name the release branch based on the new version, not the previous one
* | Re-introduce "Leave out optional keys from /sync" change (#10214)Andrew Morgan2021-06-234-55/+53
| | | | | | Required some fixes due to merge conflicts with #6739, but nothing too hairy. The first commit is the same as the original (after merge conflict resolution) then two more for compatibility with the latest sync code.
* | Improve the reliability of auto-joining remote rooms (#10237)Brendan Abolivier2021-06-233-17/+96
| | | | | | | | | | | | If a room is remote and we don't have a user in it, always try to join it. It might fail if the room is invite-only, but we don't have a user to invite with, so at this point it's the best we can do. Fixes #10233 (at least to some extent)
* | Send out invite rejections and knocks over federation (#10223)Richard van der Hoff2021-06-233-1/+16
| | | | | | | | | | ensure that events sent via `send_leave` and `send_knock` are sent on to the rest of the federation.
* | Drop Origin & Accept from Access-Control-Allow-Headers value (#10114)Michael[tm] Smith2021-06-232-1/+2
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop Origin & Accept from Access-Control-Allow-Headers value This change drops the Origin and Accept header names from the value of the Access-Control-Allow-Headers response header sent by Synapse. Per the CORS protocol, it’s not necessary or useful to include those header names. Details: Per-spec at https://fetch.spec.whatwg.org/#forbidden-header-name, Origin is a “forbidden header name” set by the browser and that frontend JavaScript code is never allowed to set. So the value of Access-Control-Allow-Headers isn’t relevant to Origin or in general to other headers set by the browser itself — the browser never ever consults the Access-Control-Allow-Headers value to confirm that it’s OK for the request to include an Origin header. And per-spec at https://fetch.spec.whatwg.org/#cors-safelisted-request-header, Accept is a “CORS-safelisted request-header”, which means that browsers allow requests to contain the Accept header regardless of whether the Access-Control-Allow-Headers value contains "Accept". So it’s unnecessary for the Access-Control-Allow-Headers to explicitly include Accept. Browsers will not perform a CORS preflight for requests containing an Accept request header. Related: https://github.com/matrix-org/matrix-doc/pull/3225 Signed-off-by: Michael[tm] Smith <mike@w3.org>
* Fix schema delta to not take as long on large servers (#10227)Erik Johnston2021-06-222-2/+6
| | | Introduced in #6739
* Warn users trying to use the deprecated spam checker interface (#10210)Brendan Abolivier2021-06-222-0/+16
| | | So admins aren't surprised if things break when we remove this code in a couple of months.
* Add endpoints for backfilling history (MSC2716) (#9247)Eric Eastwood2021-06-2214-23/+584
| | | Work on https://github.com/matrix-org/matrix-doc/pull/2716
* Implement config option `sso.update_profile_information` (#10108)jkanefendt2021-06-214-1/+51
| | | | | | Implemented config option sso.update_profile_information to keep user's display name in sync with the SSO displayname. Signed-off-by: Johannes Kanefendt <johannes.kanefendt@krzn.de>
* Fix performance of responding to user key requests over federation (#10221)Erik Johnston2021-06-213-1/+11
| | | | | We were repeatedly looking up a config option in a loop (using the unclassed config style), which is expensive enough that it can cause large CPU usage.
* Check third party rules before persisting knocks over federation (#10212)Andrew Morgan2021-06-212-2/+3
| | | | | An accidental mis-ordering of operations during #6739 technically allowed an incoming knock event over federation in before checking it against any configured Third Party Access Rules modules. This PR corrects that by performing the TPAR check *before* persisting the event.
* Ensure that errors during startup are written to the logs and the console. ↵Richard van der Hoff2021-06-215-16/+55
| | | | | | | | (#10191) * Defer stdio redirection until we are about to start the reactor * Catch and handle exceptions during startup
* Deploy a documentation version for each new Synapse release (#10198)Andrew Morgan2021-06-182-0/+34
| | | | | | | | | This PR will run a new "Deploy release-specific documentation" job whenever a push to a branch name matching `release-v*` occurs. Doing so will create/add to a folder named `vX.Y` on the `gh-pages` branch. Doing so will allow us to build up `major.minor` releases of the docs as we release Synapse. This is especially useful for having a mechanism for keeping around documentation of old/removed features (for those running older versions of Synapse), without needing to clutter the latest copy of the docs. After a [discussion](https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$rKmkBmQle8OwTlGcoyu0BkcWXdnHW3_oap8BMgclwIY?via=matrix.org&via=vector.modular.im&via=envs.net) in #synapse-dev, we wanted to use tags to trigger the documentation deployments, which I agreed with. However, I soon realised that the bash-foo required to turn a tag of `v1.2.3rc1` into `1.2` was a lot more complex than the branch's `release-v1.2`. So, I've gone with the latter for simplicity. In the future we'll have some UI on the website to switch between versions, but for now you can simply just change 'develop' to 'v1.2' in the URL.
* Fix a missing await when in the spaces summary. (#10208)Patrick Cloke2021-06-183-3/+100
| | | | | | | This could cause a minor data leak if someone defined a non-restricted join rule with an allow key or used a restricted join rule in an older room version, but this is unlikely. Additionally this starts adding unit tests to the spaces summary handler.
* Describe callbacks signatures as async in new modules doc (#10206)Brendan Abolivier2021-06-182-8/+9
|
* Standardise the module interface (#10062)Brendan Abolivier2021-06-1823-188/+769
| | | This PR adds a common configuration section for all modules (see docs). These modules are then loaded at startup by the homeserver. Modules register their hooks and web resources using the new `register_[...]_callbacks` and `register_web_resource` methods of the module API.
* Expose opentracing trace id in response headers (#10199)Richard van der Hoff2021-06-183-0/+25
| | | Fixes: #9480
* Remove support for ACME v1 (#10194)Brendan Abolivier2021-06-1718-836/+18
| | | | | Fixes #9778 ACME v1 has been fully decommissioned for existing installs on June 1st 2021(see https://community.letsencrypt.org/t/end-of-life-plan-for-acmev1/88430/27), so we can now safely remove it from Synapse.
* Update MSC3083 support per changes in the MSC. (#10189)Patrick Cloke2021-06-174-31/+47
| | | Adds a "type" field and generalize "space" to "room_id".
* Ensure that we do not cache empty sync responses after a timeout (#10158)Richard van der Hoff2021-06-178-21/+84
| | | Fixes #8518 by telling the ResponseCache not to cache the /sync response if the next_batch param is the same as the since token.
* Rip out the DNS lookup limiter (#10190)Richard van der Hoff2021-06-172-104/+1
| | | As I've written in various places in the past (#7113, #9865) I'm pretty sure this is doing nothing useful at all.
* update black to 21.6b0 (#10197)Marcus2021-06-1717-27/+28
| | | | | Reformat all files with the new version. Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>
* Fix incorrect time magnitude on delayed call (#10195)Andrew Morgan2021-06-172-1/+2
| | | | | | | | | Fixes https://github.com/matrix-org/synapse/issues/10030. We were expecting milliseconds where we should have provided a value in seconds. The impact of this bug isn't too bad. The code is intended to count the number of remote servers that the homeserver can see and report that as a metric. This metric is supposed to run initially 1 second after server startup, and every 60s as well. Instead, it ran 1,000 seconds after server startup, and every 60s after startup. This fix allows for the correct metrics to be collected immediately, as well as preventing a random collection 1,000s in the future after startup.
* Add fields to better debug where events are being soft_failed (#10168)Eric Eastwood2021-06-172-3/+19
| | | Follow-up to https://github.com/matrix-org/synapse/pull/10156#discussion_r650292223
* Fix persist_events to stop leaking opentracing contexts (#10193)Richard van der Hoff2021-06-172-1/+2
|
* Improve comments in the structured logging code. (#10188)Patrick Cloke2021-06-162-4/+6
|
* Always require users to re-authenticate for dangerous operations. (#10184)Patrick Cloke2021-06-166-1/+24
| | | | | | | Dangerous actions means deactivating an account, modifying an account password, or adding a 3PID. Other actions (deleting devices, uploading keys) can re-use the same UI auth session if ui_auth.session_timeout is configured.
* A guide to the request log lines format. (#8436)Michael Kaye2021-06-163-0/+46
| | | | | | | This doc is short but a useful guide to what the request log lines mean. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org> Co-authored-by: Daniele Sluijters <daenney@users.noreply.github.com>
* Add debug logging when we enter/exit Measure block (#10183)Erik Johnston2021-06-162-0/+6
| | | It can be helpful to know when trying to track down slow requests.
* Fix requestOpenIdToken response: integer expires_in (#10175)Lukas Lihotzki2021-06-162-1/+2
| | | | | | | | | | `expires_in` must be an integer according to the OpenAPI spec: https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/definitions/openid_token.yaml#L32 True division (`/`) returns a float instead (`"expires_in": 3600.0`). Floor division (`//`) returns an integer, so the response is spec compliant. Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
* Fix broken links in documentation (#10180)Dirk Klimpel2021-06-1619-51/+53
| | | | | * Fix broken links in documentation * newsfile
* Make opentracing trace into event persistence (#10134)Richard van der Hoff2021-06-164-9/+99
| | | | | | | | | | | | | | * Trace event persistence When we persist a batch of events, set the parent opentracing span to the that from the request, so that we can trace all the way in. * changelog * When we force tracing, set a baggage item ... so that we can check again later. * Link in both directions between persist_events spans
* Merge branch 'master' into developErik Johnston2021-06-153-1/+13
|\
| * 1.36.0 v1.36.0 github/release-v1.36 release-v1.36Erik Johnston2021-06-153-1/+13
| |
* | Remove support for unstable MSC1772 prefixes. (#10161)Patrick Cloke2021-06-153-16/+4
| | | | | | | | The stable prefixes have been supported since v1.34.0. The unstable prefixes are not supported by any known clients.
* | Remove the experimental flag for knocking and use stable prefixes / ↵Patrick Cloke2021-06-1513-96/+33
| | | | | | | | | | | | | | endpoints. (#10167) * Room version 7 for knocking. * Stable prefixes and endpoints (both client and federation) for knocking. * Removes the experimental configuration flag.
* | Fix 'ip_range_whitelist' not working for federation servers (#10115)Michael Kutzner2021-06-153-13/+19
| | | | | | | | | | Add 'federation_ip_range_whitelist'. This allows backwards-compatibility, If 'federation_ip_range_blacklist' is set. Otherwise 'ip_range_whitelist' will be used for federation servers. Signed-off-by: Michael Kutzner 1mikure@gmail.com
* | Refactor `EventPersistenceQueue` (#10145)Richard van der Hoff2021-06-142-77/+89
| | | | | | some cleanup, pulled out of #10134.
* | Extend `ResponseCache` to pass a context object into the callback (#10157)Richard van der Hoff2021-06-145-37/+146
| | | | | | | | | | This is the first of two PRs which seek to address #8518. This first PR lays the groundwork by extending ResponseCache; a second PR (#10158) will update the SyncHandler to actually use it, and fix the bug. The idea here is that we allow the callback given to ResponseCache.wrap to decide whether its result should be cached or not. We do that by (optionally) passing a ResponseCacheContext into it, which it can modify.
* | Notes on boolean columns in database schemas (#10164)Richard van der Hoff2021-06-112-0/+43
| |
* | Merge tag 'v1.36.0rc2' into developErik Johnston2021-06-115-4/+12
|\| | | | | | | | | | | | | | | | | | | | | | | Synapse 1.36.0rc2 (2021-06-11) ============================== Bugfixes -------- - Fix a bug which caused presence updates to stop working some time after a restart, when using a presence writer worker. Broke in v1.33.0. ([\#10149](https://github.com/matrix-org/synapse/issues/10149)) - Fix a bug when using federation sender worker where it would send out more presence updates than necessary, leading to high resource usage. Broke in v1.33.0. ([\#10163](https://github.com/matrix-org/synapse/issues/10163)) - Fix a bug where Synapse could send the same presence update to a remote twice. ([\#10165](https://github.com/matrix-org/synapse/issues/10165))
| * Fixup changelog v1.36.0rc2Erik Johnston2021-06-111-1/+1
| |
| * 1.36.0rc2Erik Johnston2021-06-115-4/+12
| |
| * Only send a presence state to a destination once (#10165)Erik Johnston2021-06-112-13/+13
| | | | | | | | It turns out that we were sending the same presence state to a remote potentially multiple times.
| * Fix sending presence over federation when using workers (#10163)Erik Johnston2021-06-112-6/+20
| | | | | | | | | | | | When using a federation sender we'd send out all local presence updates over federation even when they shouldn't be. Fixes #10153.
| * Fix bug when running presence off master (#10149)Erik Johnston2021-06-113-1/+17
| | | | | | Hopefully fixes #10027.
* | Only send a presence state to a destination once (#10165)Erik Johnston2021-06-112-13/+13
| | | | | | | | It turns out that we were sending the same presence state to a remote potentially multiple times.
* | Support for database schema version ranges (#9933)Richard van der Hoff2021-06-117-77/+206
| | | | | | This is essentially an implementation of the proposal made at https://hackmd.io/@richvdh/BJYXQMQHO, though the details have ended up looking slightly different.
* | Use the matching complement branch when running tests in CI. (#10160)Patrick Cloke2021-06-112-5/+24
| | | | | | | | | | | | | | | | | | | | | | This implements similar behavior to sytest where a matching branch is used, if one exists. This is useful when needing to modify both application code and tests at the same time. The following rules are used to find a matching complement branch: 1. Search for the branch name of the pull request. (E.g. feature/foo.) 2. Search for the base branch of the pull request. (E.g. develop or release-vX.Y.) 3. Search for the reference branch of the commit. (E.g. master or release-vX.Y.) 4. Fallback to 'master', the default complement branch name.
* | Fix sending presence over federation when using workers (#10163)Erik Johnston2021-06-112-6/+20
| | | | | | | | | | | | When using a federation sender we'd send out all local presence updates over federation even when they shouldn't be. Fixes #10153.
* | Clean up a broken import in admin_cmd.py (#10154)Andrew Morgan2021-06-112-2/+1
| |
* | Fix bug when running presence off master (#10149)Erik Johnston2021-06-113-1/+17
| | | | | | Hopefully fixes #10027.
* | Add metrics to track how often events are `soft_failed` (#10156)Eric Eastwood2021-06-112-0/+8
| | | | | | | | | | | | | | | | | | | | | | Spawned from missing messages we were seeing on `matrix.org` from a federated Gtiter bridged room, https://gitlab.com/gitterHQ/webapp/-/issues/2770. The underlying issue in Synapse is tracked by https://github.com/matrix-org/synapse/issues/10066 where the message and join event race and the message is `soft_failed` before the `join` event reaches the remote federated server. Less soft_failed events = better and usually this should only trigger for events where people are doing bad things and trying to fuzz and fake everything.
* | Document how to see logger output when running the twisted tests (#10148)Eric Eastwood2021-06-113-13/+26
| |
* | Mention that you need to configure max upload size in reverse proxy as well ↵Aaron Raimist2021-06-103-0/+9
| | | | | | | | | | (#10122) Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Update Complement run with Synapse-supported MSC-related build tags (#10155)Andrew Morgan2021-06-092-1/+2
| | | | | | | | | | This PR updates the build tags that we perform Complement runs with to match our [buildkite pipeline](https://github.com/matrix-org/pipelines/blob/618b3e90bcae8efd1a71502ae95b7913e6e24665/synapse/pipeline.yml#L570), as well as adding `msc2403` (as it will be required once #9359 is merged). Build tags are what we use to determine which tests to run in Complement (really it determines which test files are compiled into the final binary). I haven't put in a comment about updating the buildkite side here, as we've decided to migrate fully to GitHub Actions anyhow.
* | Integrate knock rooms with the public rooms directory (#9359)Andrew Morgan2021-06-093-5/+11
| | | | | | | | | | | | | | | | | | | | This PR implements the ["Changes regarding the Public Rooms Directory"](https://github.com/Sorunome/matrix-doc/blob/soru/knock/proposals/2403-knock.md#changes-regarding-the-public-rooms-directory) section of knocking MSC2403. Specifically, it: * Allows rooms with `join_rule` "knock" to be returned by the query behind the public rooms directory * Adds the field `join_rule` to each room entry returned by a public rooms directory query, so clients can know whether to attempt a join or knock on a room Based on https://github.com/matrix-org/synapse/issues/6739. Complement tests for this change: https://github.com/matrix-org/complement/pull/72
* | Implement knock feature (#6739)Sorunome2021-06-0929-118/+1613
| | | | | | | | | | | | This PR aims to implement the knock feature as proposed in https://github.com/matrix-org/matrix-doc/pull/2403 Signed-off-by: Sorunome mail@sorunome.de Signed-off-by: Andrew Morgan andrewm@element.io
* | Limit the number of in-flight /keys/query requests from a single device. ↵Patrick Cloke2021-06-094-173/+196
| | | | | | | | (#10144)
* | Clean up the interface for injecting opentracing over HTTP (#10143)Richard van der Hoff2021-06-094-92/+26
| | | | | | | | | | | | | | * Remove unused helper functions * Clean up the interface for injecting opentracing over HTTP * changelog
* | Add type hints to the federation server transport. (#10080)Patrick Cloke2021-06-085-75/+194
|/
* Make changelog lines consistent v1.36.0rc1Andrew Morgan2021-06-081-1/+1
|
* fix typo in changelogAndrew Morgan2021-06-081-1/+1
|
* 1.36.0rc1Andrew Morgan2021-06-0846-45/+69
|
* Fix logging context when opening new DB connection (#10141)Erik Johnston2021-06-082-3/+10
| | | | Fixes #10140
* Correct type hints for parse_string(s)_from_args. (#10137)Patrick Cloke2021-06-088-83/+132
|
* Name release branches just after major.minor (#10013)Dan Callahan2021-06-083-5/+6
| | | | | | | | | | | | | | | | | | With the prior format, 1.33.0 / 1.33.1 / 1.33.2 got separate branches: release-v1.33.0 release-v1.33.1 release-v1.33.2 Under the new model, all three would share a common branch: release-v1.33 As before, RCs and actual releases exist as tags on these branches. This better reflects our support model, e.g., that the "1.33" series had a formal release followed by two patches / updates. Signed-off-by: Dan Callahan <danc@element.io>
* When joining a remote room limit the number of events we concurrently check ↵Erik Johnston2021-06-085-256/+202
| | | | | signatures/hashes for (#10117) If we do hundreds of thousands at once the memory overhead can easily reach 500+ MB.
* Handle /backfill returning no events (#10133)Erik Johnston2021-06-082-13/+26
| | | Fixes #10123
* More database opentracing (#10136)Richard van der Hoff2021-06-072-2/+6
| | | Add a couple of extra logs/spans, to give a bit of a better idea.
* opentracing: use a consistent name for background processes (#10135)Richard van der Hoff2021-06-073-2/+5
| | | | ... otherwise we tend to get a namespace clash between the bg process and the functions that it calls.
* Make link in docs use HTTPS (#10130)Rohan Sharma2021-06-072-1/+2
| | | | | Fixes #10121 Signed-off-by: Rohan Sharma <rhnsharma5113@gmail.com>
* Fix broken link to README at root of repo (#10132)Chris Castle2021-06-072-1/+2
| | | Signed-off-by: Chris Castle chris@crc.io
* Always update AS last_pos, even on no events (#10107)14mRh4X0r2021-06-073-17/+15
| | | | | | | | | | Fixes #1834. `get_new_events_for_appservice` internally calls `get_events_as_list`, which will filter out any rejected events. If all returned events are filtered out, `_notify_interested_services` will return without updating the last handled stream position. If there are 100 consecutive such events, processing will halt altogether. Breaking the loop is now done by checking whether we're up-to-date with `current_max` in the loop condition, instead of relying on an empty `events` list. Signed-off-by: Willem Mulder <14mRh4X0r@gmail.com>
* Add missing type hints to the admin API servlets (#10105)Dirk Klimpel2021-06-076-40/+48
|
* Delete completes to-device messages earlier in /sync (#10124)Richard van der Hoff2021-06-072-10/+12
| | | | I hope this will improve https://github.com/matrix-org/synapse/issues/9564.
* Don't try and backfill the same room in parallel. (#10116)Erik Johnston2021-06-042-0/+9
| | | | | If backfilling is slow then the client may time out and retry, causing Synapse to start a new `/backfill` before the existing backfill has finished, duplicating work.
* Limit number of events in a replication request (#10118)Erik Johnston2021-06-042-2/+4
| | | Fixes #9956.
* Enable Prometheus metrics for the jaeger client library (#10112)Richard van der Hoff2021-06-043-1/+5
|
* Compile and render Synapse's docs into a browsable, mobile-friendly and ↵Andrew Morgan2021-06-0335-54/+978
| | | | searchable website (#10086)
* Add OpenTracing for database activity. (#10113)Richard van der Hoff2021-06-033-33/+60
| | | | | | | | | | This adds quite a lot of OpenTracing decoration for database activity. Specifically it adds tracing at four different levels: * emit a span for each "interaction" - ie, the top level database function that we tend to call "transaction", but isn't really, because it can end up as multiple transactions. * emit a span while we hold a database connection open * emit a span for each database transaction - actual actual transaction. * emit a span for each database query. I'm aware this might be quite a lot of overhead, but even just running it on a local Synapse it looks really interesting, and I hope the overhead can be offset just by turning down the sampling frequency and finding other ways of tracing requests of interest (eg, the `force_tracing_for_users` setting).
* Improve opentracing annotations for Notifier (#10111)Richard van der Hoff2021-06-032-33/+34
| | | | | | | The existing tracing reports an error each time there is a timeout, which isn't really representative. Additionally, we log things about the way `wait_for_events` works (eg, the result of the callback) to the *parent* span, which is confusing.
* Convert admin api docs to markdown (#10089)Andrew Morgan2021-06-039-1132/+1160
| | | So that they render nicely in mdbook (see #10086), and so that we no longer have a mix of structured text languages in our documentation (excluding files outside of `docs/`).
* r0.6.1 support: /rooms/:roomId/aliases endpoint (#9224)Travis Ralston2021-06-033-3/+3
| | | | | | [MSC2432](https://github.com/matrix-org/matrix-doc/pull/2432) added this endpoint originally but it has since been included in the spec for nearly a year. This is progress towards https://github.com/matrix-org/synapse/issues/8334
* Merge branch 'master' into developPatrick Cloke2021-06-034-2/+16
|\
| * Clarify changelog. v1.35.1 github/release-v1.35 release-v1.35Patrick Cloke2021-06-031-1/+1
| |
| * 1.35.1Patrick Cloke2021-06-034-2/+16
| |
| * Do not show invite-only rooms in spaces summary (unless joined/invited). ↵Patrick Cloke2021-06-032-10/+10
| | | | | | | | (#10109)
* | Add new admin APIs to remove media by media ID from quarantine. (#10044)Dirk Klimpel2021-06-025-10/+201
| | | | | | | | | | Related to: #6681, #5956, #10040 Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | github actions: summarize Sytest results in an easy-to-read format (#10094)Richard van der Hoff2021-06-022-2/+3
| | | | | | ... using the script from matrix-org/sytest#1052
* | Rewrite the KeyRing (#10035)Erik Johnston2021-06-028-492/+393
| |
* | Do not show invite-only rooms in spaces summary (unless joined/invited). ↵Patrick Cloke2021-06-022-10/+10
| | | | | | | | (#10109)
* | Make /sync do less state res (#10102)Erik Johnston2021-06-022-2/+3
| |
* | Merge branch 'master' into developAndrew Morgan2021-06-015-2/+50
|\|
| * Merge v1.35.0rc3 into v1.35.0 due to incorrect tagging v1.35.0Andrew Morgan2021-06-011-5/+1
| |
| * Indicate that there were no functional changes since v1.35.0rc3Andrew Morgan2021-06-011-0/+2
| |
| * 1.35.0Andrew Morgan2021-06-014-2/+16
| |
| * Announce deprecation of experimental `msc2858_enabled` option. (#10101)Erik Johnston2021-06-011-0/+1
| | | | | | | | | | c.f. https://github.com/matrix-org/synapse/pull/9617 and https://github.com/matrix-org/matrix-doc/blob/master/proposals/2858-Multiple-SSO-Identity-Providers.md Fixes #9627.
| * CHANGELOGErik Johnston2021-05-281-2/+2
| |
| * 1.35.0rc3Erik Johnston2021-05-285-4/+17
| |
| * Merge remote-tracking branch 'origin/release-v1.35.0' into release-v1.35Erik Johnston2021-05-283-2/+10
| |\
| * | Limit the number of events sent over replication when persisting events. ↵Brendan Abolivier2021-05-282-7/+11
| | | | | | | | | | | | (#10082)
| * | Log method and path when dropping request due to size limit (#10091)Erik Johnston2021-05-282-1/+4
| | |
| * | Allow response of `/send_join` to be larger. (#10093)Erik Johnston2021-05-283-1/+21
| | | | | | | | | Fixes #10087.
* | | add a cache to have_seen_event (#9953)Richard van der Hoff2021-06-0110-20/+205
| | | | | | | | | Empirically, this helped my server considerably when handling gaps in Matrix HQ. The problem was that we would repeatedly call have_seen_events for the same set of (50K or so) auth_events, each of which would take many minutes to complete, even though it's only an index scan.
* | | Fix opentracing inject to use the SpanContext, not the Span (#10074)Brad Murray2021-06-012-5/+6
| | | | | | | | | Signed-off-by: Brad Murray brad@beeper.com
* | | Set opentracing priority before setting other tags (#10092)Richard van der Hoff2021-05-285-11/+32
| | | | | | | | | ... because tags on spans which aren't being sampled get thrown away.
* | | Log method and path when dropping request due to size limit (#10091)Erik Johnston2021-05-282-1/+4
| | |
* | | Add `parse_strings_from_args` to get `prev_events` array (#10048)Eric Eastwood2021-05-282-43/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Split out from https://github.com/matrix-org/synapse/pull/9247 Strings: - `parse_string` - `parse_string_from_args` - `parse_strings_from_args` For comparison with ints: - `parse_integer` - `parse_integer_from_args` Previous discussions: - https://github.com/matrix-org/synapse/pull/9247#discussion_r573195687 - https://github.com/matrix-org/synapse/pull/9247#discussion_r574214156 - https://github.com/matrix-org/synapse/pull/9247#discussion_r573264791 Signed-off-by: Eric Eastwood <erice@element.io>
* | | Move some more endpoints off master (#10084)Erik Johnston2021-05-274-6/+10
| | |
* | | Make reason and score optional for report_event (#10077)Callum Brown2021-05-276-13/+105
| | | | | | | | | | | | | | | | | | Implements MSC2414: https://github.com/matrix-org/matrix-doc/pull/2414 See #8551 Signed-off-by: Callum Brown <callum@calcuode.com>
* | | Limit the number of events sent over replication when persisting events. ↵Brendan Abolivier2021-05-272-7/+11
| | | | | | | | | | | | (#10082)
* | | Merge tag 'v1.35.0rc2' into developErik Johnston2021-05-273-2/+11
|\ \ \ | | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Synapse 1.35.0rc2 (2021-05-27) ============================== Bugfixes -------- - Fix a bug introduced in v1.35.0rc1 when calling the spaces summary API via a GET request. ([\#10079](https://github.com/matrix-org/synapse/issues/10079))
| * | 1.35.0rc2 v1.35.0rc2 github/release-v1.35.0 release-v1.35.0Erik Johnston2021-05-273-2/+10
| |/
| * Pass the origin when calculating the spaces summary over GET. (#10079)Patrick Cloke2021-05-272-1/+2
| | | | | | | | Fixes a bug due to conflicting PRs which were merged. (One added a new caller to a method, the other added a new parameter to the same method.)
* | Fix up `BatchingQueue` (#10078)Erik Johnston2021-05-273-24/+125
| | | | | | Fixes #10068
* | Clarify security note regarding the domain Synapse is hosted on. (#9221)Denis Kasak2021-05-272-11/+36
| |
* | Improve the error message printed by synctl when synapse fails to start. ↵Richard van der Hoff2021-05-272-4/+9
| | | | | | | | (#10059)
* | Remove redundant, unmaintained `convert_server_keys` script. (#10055)Richard van der Hoff2021-05-272-108/+1
| |
* | Remove redundant code to reload tls cert (#10054)Richard van der Hoff2021-05-274-25/+6
| | | | | | | | | | we don't need to reload the tls cert if we don't have any tls listeners. Follow-up to #9280.
* | Combine `LruCache.invalidate` and `invalidate_many` (#9973)Richard van der Hoff2021-05-2712-52/+52
| | | | | | | | | | | | | | | | | | | | * Make `invalidate` and `invalidate_many` do the same thing ... so that we can do either over the invalidation replication stream, and also because they always confused me a bit. * Kill off `invalidate_many` * changelog
* | Remove the experimental spaces enabled flag. (#10063)Patrick Cloke2021-05-266-49/+9
| | | | | | | | In lieu of just always enabling the unstable spaces endpoint and unstable room version.
* | Fix GitHub Actions lint for newsfragments (#10069)Dan Callahan2021-05-262-0/+7
| | | | | | | | | | * Fix GitHub Actions lint for newsfragments Signed-off-by: Dan Callahan <danc@element.io>
* | Tweak wording of database recommendation in INSTALL.md (#10057)Aaron Raimist2021-05-262-5/+8
| | | | | | | | | | | | * Tweak wording of database recommendation in INSTALL.md Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Tell CircleCI to build Docker images from `main` (#9906)Dan Callahan2021-05-262-1/+2
| | | | | | | | | | | | The `only` field takes a string or list of strings per the Circle docs: https://circleci.com/docs/2.0/configuration-reference/#branches Signed-off-by: Dan Callahan <danc@element.io>
* | Add an admin API for unprotecting local media from quarantine (#10040)Dirk Klimpel2021-05-265-5/+151
| | | | | | Signed-off-by: Dirk Klimpel dirk@klimpel.org
* | Update CAPTCHA documentation to mention turning off verify origin feature ↵Aaron Raimist2021-05-262-22/+29
|/ | | | | | | | (#10046) * Update CAPTCHA documentation to mention turning off verify origin Signed-off-by: Aaron Raimist <aaron@raim.ist>
* 1.35.0rc1 v1.35.0rc1Erik Johnston2021-05-2539-38/+65
|
* Run complement with Synapse workers manually. (#10039)Patrick Cloke2021-05-243-7/+27
| | | | Adds an option to complement.sh to run Synapse in worker mode (instead of the default monolith mode).
* Add missing type hints to synapse.util (#9982)Patrick Cloke2021-05-249-25/+39
|
* Fix docker image to not log at `/homeserver.log` (#10045)Sergio Miguéns2021-05-242-1/+4
| | | | | Fixes #9970 Signed-off-by: Sergio Miguéns Iglesias lonyelon@lony.xyz
* Remove tls_fingerprints option (#9280)Jerin J Titus2021-05-246-95/+1
| | | | Signed-off-by: Jerin J Titus <72017981+jerinjtitus@users.noreply.github.com>
* Fix --no-daemonize for synctl with workers (#9995)Richard van der Hoff2021-05-242-70/+33
|
* Fix off-by-one-error in synapse_port_db (#9991)Richard van der Hoff2021-05-245-9/+10
| | | fixes #9979
* Remove `keylen` from `LruCache`. (#9993)Richard van der Hoff2021-05-2411-55/+80
| | | | | | | `keylen` seems to be a thing that is frequently incorrectly set, and we don't really need it. The only time it was used was to figure out if we had removed a subtree in `del_multi`, which we can do better by changing `TreeCache.pop` to return a different type (`TreeCacheNode`). Commits should be independently reviewable.
* Enable experimental spaces by default. (#10011)Patrick Cloke2021-05-244-2/+35
| | | | The previous spaces_enabled flag now defaults to true and is exposed in the sample config.
* Add missing entry to the table of contents of room admin API (#10043)Dirk Klimpel2021-05-242-0/+2
|
* Fix `get_state_ids_for_event` return type typo to match what the function ↵Eric Eastwood2021-05-242-1/+2
| | | | | actually does (#10050) It looks like a typo copy/paste from `get_state_for_event` above.
* Don't hammer the database for destination retry timings every ~5mins (#10036)Erik Johnston2021-05-2110-76/+62
|
* Fix /upload 500'ing when presented a very large image (#10029)Michael Telatynski2021-05-213-0/+12
| | | | | | | | | | | | * Fix /upload 500'ing when presented a very large image Catch DecompressionBombError and re-raise as ThumbnailErrors * Set PIL's MAX_IMAGE_PIXELS to match homeserver.yaml to get it to bomb out quicker, to load less into memory in the case of super large images * Add changelog entry for 10029
* Add a test for update_presence (#10033)Andrew Morgan2021-05-212-1/+47
| | | | | | | https://github.com/matrix-org/synapse/issues/9962 uncovered that we accidentally removed all but one of the presence updates that we store in the database when persisting multiple updates. This could cause users' presence state to be stale. The bug was fixed in #10014, and this PR just adds a test that failed on the old code, and was used to initially verify the bug. The test attempts to insert some presence into the database in a batch using `PresenceStore.update_presence`, and then simply pulls it out again.
* Remove unused properties from the SpaceSummaryHandler. (#10038)Patrick Cloke2021-05-212-2/+1
|
* Fixed removal of new presence stream states (#10014)Marek Matys2021-05-212-9/+10
| | | | | | | | | Fixes: https://github.com/matrix-org/synapse/issues/9962 This is a fix for above problem. I fixed it by swaping the order of insertion of new records and deletion of old ones. This ensures that we don't delete fresh database records as we do deletes before inserts. Signed-off-by: Marek Matys <themarcq@gmail.com>
* Add a batching queue implementation. (#10017)Erik Johnston2021-05-213-0/+323
|
* Add `Keyring.verify_events_for_server` and reduce memory usage (#10018)Erik Johnston2021-05-203-22/+94
| | | | | | Also add support for giving a callback to generate the JSON object to verify. This should reduce memory usage, as we no longer have the event in memory in dict form (which has a large memory footprint) for extend periods of time.
* Use ijson to parse the response to `/send_join`, reducing memory usage. (#9958)Erik Johnston2021-05-207-58/+227
| | | Instead of parsing the full response to `/send_join` into Python objects (which can be huge for large rooms) and *then* parsing that into events, we instead use ijson to stream parse the response directly into `EventBase` objects.
* Allow a user who could join a restricted room to see it in spaces summary. ↵Patrick Cloke2021-05-204-54/+254
| | | | | | (#9922) This finishes up the experimental implementation of MSC3083 by showing the restricted rooms in the spaces summary (from MSC2946).
* Merge branch 'master' of github.com:matrix-org/synapse into developAndrew Morgan2021-05-202-1/+2
|\
| * Update user_directory.md (#10016)Javier Junquera Sánchez2021-05-202-1/+2
| | | | | | Signed-off-by: Javier Junquera Sánchez <javier@junquera.io>
* | Update the contrib grafana dashboard (#10001)Erik Johnston2021-05-192-644/+3558
| |
* | Hardened systemd unit files (#9803)Savyasachee Jha2021-05-193-0/+102
| | | | | | Signed-off-by: Savyasachee Jha savya.jha@hawkradius.com
* | Refactor checking restricted join rules (#10007)Patrick Cloke2021-05-184-51/+50
| | | | | | | | | | To be more consistent with similar code. The check now automatically raises an AuthError instead of passing back a boolean. It also absorbs some shared logic between callers.
* | Use a database table to hold the users that should have full presence sent ↵Andrew Morgan2021-05-1811-158/+479
| | | | | | | | to them, instead of something in-memory (#9823)
* | Fix the allowed range of valid ordering characters for spaces. (#10002)Patrick Cloke2021-05-172-2/+3
| | | | | | | | \x7F was meant to be \0x7E (~) this was originally incorrect in MSC1772.
* | Clarify comments in the space summary handler. (#9974)Patrick Cloke2021-05-172-5/+47
| |
* | Merge branch 'master' into developErik Johnston2021-05-174-15/+25
|\|
| * Changelog v1.34.0 github/release-v1.34.0 release-v1.34.0Erik Johnston2021-05-171-6/+6
| |
| * Update UPGRADE.rstErik Johnston2021-05-171-7/+4
| |
| * 1.34.0Erik Johnston2021-05-173-3/+16
| |
* | Split multiplart email sending into a dedicated handler (#9977)Brendan Abolivier2021-05-175-90/+122
| | | | | | Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Update postgres docs (#9989)Richard van der Hoff2021-05-143-103/+98
| |
* | Run `black` on the scripts (#9981)Richard van der Hoff2021-05-148-76/+141
| | | | | | | | Turns out these scripts weren't getting linted.
* | Minor `@cachedList` enhancements (#9975)Richard van der Hoff2021-05-146-20/+31
| | | | | | | | | | | | - use a tuple rather than a list for the iterable that is passed into the wrapped function, for performance - test that we can pass an iterable and that keys are correctly deduped.
* | Remove unnecessary SystemRandom from SQLBaseStore (#9987)Dan Callahan2021-05-143-3/+3
| | | | | | | | | | | | | | | | It's not obvious that instances of SQLBaseStore each need their own instances of random.SystemRandom(); let's just use random directly. Introduced by 52839886d664576831462e033b88e5aba4c019e3 Signed-off-by: Dan Callahan <danc@element.io>
* | Remove superfluous call to bool() (#9986)Dan Callahan2021-05-142-1/+2
| | | | | | | | | | Our strtobool already returns a bool, so no need to re-cast here Signed-off-by: Dan Callahan <danc@element.io>
* | Simplify exception handling in is_ascii. (#9985)Dan Callahan2021-05-142-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can get away with just catching UnicodeError here. ⋮ +-- ValueError | +-- UnicodeError | +-- UnicodeDecodeError | +-- UnicodeEncodeError | +-- UnicodeTranslateError ⋮ https://docs.python.org/3/library/exceptions.html#exception-hierarchy Signed-off-by: Dan Callahan <danc@element.io>
* | Use Python's secrets module instead of random (#9984)Dan Callahan2021-05-142-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Functionally identical, but more obviously cryptographically secure. ...Explicit is better than implicit? Avoids needing to know that SystemRandom() implies a CSPRNG, and complies with the big scary red box on the documentation for random: > Warning: > The pseudo-random generators of this module should not be used for > security purposes. For security or cryptographic uses, see the > secrets module. https://docs.python.org/3/library/random.html Signed-off-by: Dan Callahan <danc@element.io>
* | Support enabling opentracing by user (#9978)Richard van der Hoff2021-05-145-17/+56
| | | | | | | | | | Add a config option which allows enabling opentracing by user id, eg for debugging requests made by a test user.
* | Update minimum supported version in postgres.md (#9988)Andrew Morgan2021-05-142-1/+2
| |
* | Update SSO mapping providers documentation about unique IDs. (#9980)Patrick Cloke2021-05-132-7/+12
|/
* Incorporate changes from review v1.34.0rc1Brendan Abolivier2021-05-121-2/+6
|
* Refer and link to the upgrade notes rather than to the file nameBrendan Abolivier2021-05-121-1/+1
|
* 1.34.0rc1Brendan Abolivier2021-05-1236-35/+62
|
* Correctly ratelimit invites when creating a room (#9968)Brendan Abolivier2021-05-126-12/+157
| | | | | * Correctly ratelimit invites when creating a room Also allow ratelimiting for more than one action at a time.
* Change the format of access tokens away from macaroons (#5588)Richard van der Hoff2021-05-129-103/+78
|
* Run cache_joined_hosts_for_event in background (#9951)Erik Johnston2021-05-122-5/+41
|
* Tests for to-device messages (#9965)Richard van der Hoff2021-05-112-0/+202
|
* Sort child events according to MSC1772 for the spaces summary API. (#9954)Patrick Cloke2021-05-113-2/+151
| | | | | | | | | This should help ensure that equivalent results are achieved between homeservers querying for the summary of a space. This implements modified MSC1772 rules, according to MSC2946. The different is that the origin_server_ts of the m.room.create event is not used as a tie-breaker since this might not be known if the homeserver is not part of the room.
* Support fetching the spaces summary via GET over federation. (#9947)Patrick Cloke2021-05-114-0/+29
| | | | | | | | | | | Per changes in MSC2946, the C-S and S-S APIs for spaces summary should use GET requests. Until this is stable, the POST endpoints still exist. This does not switch federation requests to use the GET version yet since it is newly added and already deployed servers might not support it. When switching to the stable endpoint we should switch to GET requests.
* Send the `m.room.create` stripped event with invites (support MSC1772). (#9966)Patrick Cloke2021-05-115-5/+34
| | | | | MSC1772 specifies the m.room.create event should be sent as part of the invite_state. This was done optionally behind an experimental flag, but is now done by default due to MSC1772 being approved.
* Merge branch 'master' into developBrendan Abolivier2021-05-1110-70/+319
|\
| * Use link to advisory rather than to the CVE repo v1.33.2 github/release-v1.33.2 release-v1.33.2Brendan Abolivier2021-05-111-1/+1
| |
| * 1.33.2Brendan Abolivier2021-05-114-2/+23
| |
| * Merge pull request from GHSA-x345-32rc-8h85Richard van der Hoff2021-05-116-68/+296
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * tests for push rule pattern matching * tests for acl pattern matching * factor out common `re.escape` * Factor out common re.compile * Factor out common anchoring code * add word_boundary support to `glob_to_regex` * Use `glob_to_regex` in push rule evaluator NB that this drops support for character classes. I don't think anyone ever used them. * Improve efficiency of globs with multiple wildcards The idea here is that we compress multiple `*` globs into a single `.*`. We also need to consider `?`, since `*?*` is as hard to implement efficiently as `**`. * add assertion on regex pattern * Fix mypy * Simplify glob_to_regex * Inline the glob_to_regex helper function Signed-off-by: Dan Callahan <danc@element.io> * Moar comments Signed-off-by: Dan Callahan <danc@element.io> Co-authored-by: Dan Callahan <danc@element.io>
* | Add config option to hide device names over federation (#9945)Aaron Raimist2021-05-114-1/+20
| | | | | | | | | | Now that cross signing exists there is much less of a need for other people to look at devices and verify them individually. This PR adds a config option to allow you to prevent device display names from being shared with other servers. Signed-off-by: Aaron Raimist <aaron@raim.ist>
* | Add debug logging for issue #9533 (#9959)Richard van der Hoff2021-05-116-2/+42
| | | | | | | | | | Hopefully this will help us track down where to-device messages are getting lost/delayed.
* | Fix `m.room_key_request` to-device messages (#9961)Richard van der Hoff2021-05-114-26/+32
| | | | | | fixes #9960
* | Improve performance of backfilling in large rooms. (#9935)Erik Johnston2021-05-102-69/+55
| | | | | | | | | | | | We were pulling the full auth chain for the room out of the DB each time we backfilled, which can be *huge* for large rooms and is totally unnecessary.
* | Fix port_db on empty db (#9930)Richard van der Hoff2021-05-106-54/+69
| | | | | | | | ... and test it.
* | Always cache 'event_to_prev_state_group' (#9950)Erik Johnston2021-05-072-6/+8
| | | | | | Fixes regression in send PDU times introduced in #9905.
* | Fix make_full_schema to create the db with the right options and user (#9931)Richard van der Hoff2021-05-072-9/+11
| |
* | Merge remote-tracking branch 'origin/release-v1.33.2' into developErik Johnston2021-05-072-1/+2
|\|
| * Unpin attrs dep after new version has been released (#9946)Erik Johnston2021-05-072-1/+2
| | | | | | c.f. #9936
* | Reorganise the database schema directories (#9932)Richard van der Hoff2021-05-07284-47/+81
| | | | | | | | | | The hope here is that by moving all the schema files into synapse/storage/schema, it gets a bit easier for newcomers to navigate. It certainly got easier for me to write a helpful README. There's more to do on that front, but I'll follow up with other PRs for that.
* | Export jemalloc stats to prometheus when used (#9882)Erik Johnston2021-05-064-0/+200
| |
* | Revert "Leave out optional keys from /sync (#9919)" (#9940)Erik Johnston2021-05-064-51/+50
| | | | | | This reverts commit e9eb3549d32a6f93d07de8dbd5e1ebe54c8d8278.
* | Merge remote-tracking branch 'origin/master' into developErik Johnston2021-05-064-2/+18
|\|
| * 1.33.1 v1.33.1 github/release-v1.33.1 release-v1.33.1Erik Johnston2021-05-064-2/+16
| |
| * Pin attrs to <21.1.0 (#9937)Erik Johnston2021-05-062-1/+3
| | | | | | Fixes #9936
* | Follow-up to #9915 to correct the identifier for room types.Patrick Cloke2021-05-051-1/+1
| |
* | Include the time of the create event in Spaces Summary. (#9928)Patrick Cloke2021-05-052-0/+2
| | | | | | | | | | This is an update based on changes to MSC2946. The origin_server_ts of the m.room.create event is copied into the creation_ts field for each room returned from the spaces summary.
* | Increase perf of handling presence when joining large rooms. (#9916)Erik Johnston2021-05-053-82/+87
| |
* | Support stable MSC1772 spaces identifiers. (#9915)Patrick Cloke2021-05-053-2/+10
| | | | | | | | Support both the unstable and stable identifiers. A future release will disable the unstable identifiers.
* | Optionally track memory usage of each LruCache (#9881)Erik Johnston2021-05-058-1/+97
| | | | | | | | | | This will double count slightly in the presence of interned strings. It's off by default as it can consume a lot of resources.
* | Limit how often GC happens by time. (#9902)Erik Johnston2021-05-056-3/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse can be quite memory intensive, and unless care is taken to tune the GC thresholds it can end up thrashing, causing noticable performance problems for large servers. We fix this by limiting how often we GC a given generation, regardless of current counts/thresholds. This does not help with the reverse problem where the thresholds are set too high, but that should only happen in situations where they've been manually configured. Adds a `gc_min_seconds_between` config option to override the defaults. Fixes #9890.
* | Don't set the external cache if its been done recently (#9905)Erik Johnston2021-05-053-5/+34
| |
* | Use get_current_users_in_room from store and not StateHandler (#9910)Erik Johnston2021-05-0512-17/+26
| |
* | Docker healthcheck timings - add startup delay and changed interval (#9913)Christopher May-Townsend2021-05-053-4/+16
| | | | | | | | | | * Add healthcheck startup delay by 5secs and reduced interval check to 15s to reduce waiting time for docker aware edge routers bringing an instance online
* | Leave out optional keys from /sync (#9919)DeepBlueV7.X2021-05-054-50/+51
| | | | | | | | | | | | This leaves out all optional keys from /sync. This should be fine for all clients tested against conduit already, but it may break some clients, as such we should check, that at least most of them don't break horribly and maybe back out some of the individual changes. (We can probably always leave out groups for example, while the others may cause more issues.) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* | Merge branch 'master' into developBrendan Abolivier2021-05-054-4/+20
|\|
| * 1.33.0 v1.33.0 github/release-v1.33.0 release-v1.33.0Brendan Abolivier2021-05-054-2/+16
| |
| * Build Debian packages for Ubuntu 21.04 Hirsute (#9909)Dan Callahan2021-04-302-3/+5
| | | | | | Signed-off-by: Dan Callahan <danc@element.io>
* | Time external cache response time (#9904)Erik Johnston2021-05-042-10/+27
| |
* | Add port parameter to the sample config for psycopg2 args (#9911)Andrew Morgan2021-05-043-0/+3
| | | | | | Adds the `port` option with the default value to the sample config file.
* | Merge tag 'v1.33.0rc2' into developAndrew Morgan2021-04-293-2/+10
|\| | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc2 (2021-04-29) ============================== Bugfixes -------- - Fix tight loop when handling presence replication when using workers. Introduced in v1.33.0rc1. ([\#9900](https://github.com/matrix-org/synapse/issues/9900))
| * typo in changelog v1.33.0rc2Andrew Morgan2021-04-291-1/+1
| |
| * 1.33.0rc2Andrew Morgan2021-04-293-2/+10
| |
* | Add missing type hints to handlers and fix a Spam Checker type hint. (#9896)Patrick Cloke2021-04-298-54/+82
| | | | | | | | | | The user_may_create_room_alias method on spam checkers declared the room_alias parameter as a str when in reality it is passed a RoomAlias object.
* | Delete room endpoint (#9889)ThibF2021-04-295-64/+128
| | | | | | | | | | | | Support the delete of a room through DELETE request and mark previous request as deprecated through documentation. Signed-off-by: Thibault Ferrante <thibault.ferrante@pm.me>
* | Merge remote-tracking branch 'origin/release-v1.33.0' into developErik Johnston2021-04-283-1/+46
|\|
| * Fix tight loop handling presence replication. (#9900)Erik Johnston2021-04-283-1/+46
| | | | | | | | | | Only affects workers. Introduced in #9819. Fixes #9899.
* | Use the parent's logging context name for runWithConnection. (#9895)Patrick Cloke2021-04-282-1/+4
| | | | | | | | | | This fixes a regression where the logging context for runWithConnection was reported as runWithConnection instead of the connection name, e.g. "POST-XYZ".
* | Merge tag 'v1.33.0rc1' into developAndrew Morgan2021-04-2841-173/+147
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.33.0rc1 (2021-04-28) ============================== Features -------- - Update experimental support for [MSC3083](https://github.com/matrix-org/matrix-doc/pull/3083): restricting room access via group membership. ([\#9800](https://github.com/matrix-org/synapse/issues/9800), [\#9814](https://github.com/matrix-org/synapse/issues/9814)) - Add experimental support for handling presence on a worker. ([\#9819](https://github.com/matrix-org/synapse/issues/9819), [\#9820](https://github.com/matrix-org/synapse/issues/9820), [\#9828](https://github.com/matrix-org/synapse/issues/9828), [\#9850](https://github.com/matrix-org/synapse/issues/9850)) - Return a new template when an user attempts to renew their account multiple times with the same token, stating that their account is set to expire. This replaces the invalid token template that would previously be shown in this case. This change concerns the optional account validity feature. ([\#9832](https://github.com/matrix-org/synapse/issues/9832)) Bugfixes -------- - Fixes the OIDC SSO flow when using a `public_baseurl` value including a non-root URL path. ([\#9726](https://github.com/matrix-org/synapse/issues/9726)) - Fix thumbnail generation for some sites with non-standard content types. Contributed by @rkfg. ([\#9788](https://github.com/matrix-org/synapse/issues/9788)) - Add some sanity checks to identity server passed to 3PID bind/unbind endpoints. ([\#9802](https://github.com/matrix-org/synapse/issues/9802)) - Limit the size of HTTP responses read over federation. ([\#9833](https://github.com/matrix-org/synapse/issues/9833)) - Fix a bug which could cause Synapse to get stuck in a loop of resyncing device lists. ([\#9867](https://github.com/matrix-org/synapse/issues/9867)) - Fix a long-standing bug where errors from federation did not propagate to the client. ([\#9868](https://github.com/matrix-org/synapse/issues/9868)) Improved Documentation ---------------------- - Add a note to the docker docs mentioning that we mirror upstream's supported Docker platforms. ([\#9801](https://github.com/matrix-org/synapse/issues/9801)) Internal Changes ---------------- - Add a dockerfile for running Synapse in worker-mode under Complement. ([\#9162](https://github.com/matrix-org/synapse/issues/9162)) - Apply `pyupgrade` across the codebase. ([\#9786](https://github.com/matrix-org/synapse/issues/9786)) - Move some replication processing out of `generic_worker`. ([\#9796](https://github.com/matrix-org/synapse/issues/9796)) - Replace `HomeServer.get_config()` with inline references. ([\#9815](https://github.com/matrix-org/synapse/issues/9815)) - Rename some handlers and config modules to not duplicate the top-level module. ([\#9816](https://github.com/matrix-org/synapse/issues/9816)) - Fix a long-standing bug which caused `max_upload_size` to not be correctly enforced. ([\#9817](https://github.com/matrix-org/synapse/issues/9817)) - Reduce CPU usage of the user directory by reusing existing calculated room membership. ([\#9821](https://github.com/matrix-org/synapse/issues/9821)) - Small speed up for joining large remote rooms. ([\#9825](https://github.com/matrix-org/synapse/issues/9825)) - Introduce flake8-bugbear to the test suite and fix some of its lint violations. ([\#9838](https://github.com/matrix-org/synapse/issues/9838)) - Only store the raw data in the in-memory caches, rather than objects that include references to e.g. the data stores. ([\#9845](https://github.com/matrix-org/synapse/issues/9845)) - Limit length of accepted email addresses. ([\#9855](https://github.com/matrix-org/synapse/issues/9855)) - Remove redundant `synapse.types.Collection` type definition. ([\#9856](https://github.com/matrix-org/synapse/issues/9856)) - Handle recently added rate limits correctly when using `--no-rate-limit` with the demo scripts. ([\#9858](https://github.com/matrix-org/synapse/issues/9858)) - Disable invite rate-limiting by default when running the unit tests. ([\#9871](https://github.com/matrix-org/synapse/issues/9871)) - Pass a reactor into `SynapseSite` to make testing easier. ([\#9874](https://github.com/matrix-org/synapse/issues/9874)) - Make `DomainSpecificString` an `attrs` class. ([\#9875](https://github.com/matrix-org/synapse/issues/9875)) - Add type hints to `synapse.api.auth` and `synapse.api.auth_blocking` modules. ([\#9876](https://github.com/matrix-org/synapse/issues/9876)) - Remove redundant `_PushHTTPChannel` test class. ([\#9878](https://github.com/matrix-org/synapse/issues/9878)) - Remove backwards-compatibility code for Python versions < 3.6. ([\#9879](https://github.com/matrix-org/synapse/issues/9879)) - Small performance improvement around handling new local presence updates. ([\#9887](https://github.com/matrix-org/synapse/issues/9887))
| * Reword account validity template change to sound less like a bugfix v1.33.0rc1Andrew Morgan2021-04-281-1/+1
| |
| * 1.33.0rc1Andrew Morgan2021-04-2836-35/+54
| |
| * Revert "Experimental Federation Speedup (#9702)"Andrew Morgan2021-04-285-138/+93
| | | | | | | | This reverts commit 05e8c70c059f8ebb066e029bc3aa3e0cefef1019.
* | Reduce memory footprint of caches (#9886)Erik Johnston2021-04-282-18/+60
| |
* | Add type hints to presence handler (#9885)Erik Johnston2021-04-282-70/+90
|/
* Remove various bits of compatibility code for Python <3.6 (#9879)Andrew Morgan2021-04-2716-98/+29
| | | I went through and removed a bunch of cruft that was lying around for compatibility with old Python versions. This PR also will now prevent Synapse from starting unless you're running Python 3.6+.
* Pass errors back to the client when trying multiple federation destinations. ↵Patrick Cloke2021-04-272-58/+61
| | | | | | | | (#9868) This ensures that something like an auth error (403) will be returned to the requester instead of attempting to try more servers, which will likely result in the same error, and then passing back a generic 400 error.
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-18 07:23:20 +0000