Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | (Really) fix tablescan of event_push_actions on purge | Richard van der Hoff | 2018-02-16 | 1 | -1/+0 |
| | | | | | commit 278d21b5 added new code to avoid the tablescan, but didn't remove the old :/ | ||||
* | Merge pull request #2874 from matrix-org/erikj/creator_push_actions | Erik Johnston | 2018-02-16 | 9 | -46/+140 |
|\ | | | | | Store push actions in DB staging area instead of context | ||||
| * | Fix typo of double is_highlight | Erik Johnston | 2018-02-16 | 1 | -1/+1 |
| | | |||||
| * | Comments | Erik Johnston | 2018-02-16 | 3 | -1/+9 |
| | | |||||
| * | Fix unit test | Erik Johnston | 2018-02-15 | 1 | -4/+6 |
| | | |||||
| * | Ensure that we delete staging push actions on errors | Erik Johnston | 2018-02-15 | 2 | -3/+25 |
| | | |||||
| * | Remove context.push_actions | Erik Johnston | 2018-02-15 | 5 | -20/+11 |
| | | |||||
| * | Update event_push_actions table from staging table | Erik Johnston | 2018-02-15 | 2 | -22/+39 |
| | | |||||
| * | Store push actions in staging area | Erik Johnston | 2018-02-15 | 3 | -0/+54 |
|/ | |||||
* | Merge pull request #2873 from matrix-org/erikj/event_creator_no_state | Erik Johnston | 2018-02-15 | 3 | -8/+51 |
|\ | | | | | Don't serialize current state over replication | ||||
| * | Don't serialize current state over replication | Erik Johnston | 2018-02-15 | 3 | -8/+51 |
|/ | |||||
* | Merge pull request #2872 from matrix-org/erikj/event_worker_dont_log | Erik Johnston | 2018-02-15 | 1 | -1/+10 |
|\ | | | | | Don't log errors propogated from send_event | ||||
| * | Don't log errors propogated from send_event | Erik Johnston | 2018-02-15 | 1 | -1/+10 |
| | | |||||
* | | Merge pull request #2871 from matrix-org/erikj/event_creator_state | Erik Johnston | 2018-02-15 | 1 | -41/+41 |
|\ \ | |/ |/| | Fix state group storage bug in workers | ||||
| * | Fix state group storage bug in workers | Erik Johnston | 2018-02-15 | 1 | -41/+41 |
|/ | | | | | We needed to move `_count_state_group_hops_txn` to the StateGroupWorkerStore. | ||||
* | Merge pull request #2867 from matrix-org/rav/rework_purge | Richard van der Hoff | 2018-02-15 | 1 | -35/+83 |
|\ | | | | | purge_history cleanups | ||||
| * | purge_history: fix sqlite syntax error | Richard van der Hoff | 2018-02-14 | 1 | -1/+4 |
| | | | | | | | | apparently sqlite insists on indexes being named | ||||
| * | purge_history: handle sqlite asshattery | Richard van der Hoff | 2018-02-14 | 1 | -19/+27 |
| | | | | | | | | | | apparently creating a temporary table commits the transaction. because that's a useful thing. | ||||
| * | purge_history: fix index use | Richard van der Hoff | 2018-02-14 | 1 | -0/+14 |
| | | | | | | | | | | event_push_actions doesn't have an index on event_id, so we need to specify room_id. | ||||
| * | Rework event purge to use a temporary table | Richard van der Hoff | 2018-02-14 | 1 | -35/+58 |
| | | | | | | | | | | ... which should speed things up by reducing the amount of data being shuffled across the connection | ||||
* | | Merge pull request #2769 from matrix-org/matthew/hit_the_gin | Richard van der Hoff | 2018-02-14 | 5 | -20/+110 |
|\ \ | | | | | | | switch back from GIST to GIN indexes | ||||
| * | | remove overzealous exception handling | Richard van der Hoff | 2018-02-14 | 1 | -18/+10 |
| | | | |||||
| * | | Merge branch 'matthew/gin_work_mem' into matthew/hit_the_gin | Richard van der Hoff | 2018-02-13 | 116 | -1790/+4182 |
| |\ \ | |||||
| | * \ | Merge branch 'develop' into matthew/gin_work_mem | Richard van der Hoff | 2018-02-13 | 40 | -629/+1256 |
| | |\ \ | |||||
| | * | | | Factor out common code for search insert | Richard van der Hoff | 2018-02-04 | 1 | -33/+56 |
| | | | | | | | | | | | | | | | | | | | | | | | | | we can reuse the same code as is used for event insert, for doing the background index population. | ||||
| | * | | | Clean up work_mem handling | Richard van der Hoff | 2018-02-03 | 1 | -11/+41 |
| | | | | | | | | | | | | | | | | | | | | | | | | | Add some comments and improve exception handling when twiddling work_mem for the search update | ||||
| | * | | | Move store_event_search_txn to SearchStore | Richard van der Hoff | 2018-02-03 | 2 | -37/+43 |
| | | | | | | | | | | | | | | | | | | | | | | | | | ... as a precursor to making event storing and doing the bg update share some code. | ||||
| | * | | | Merge branch 'develop' into matthew/gin_work_mem | Richard van der Hoff | 2018-02-03 | 87 | -1120/+2820 |
| | |\ \ \ | |||||
| | * | | | | oops | hera | 2018-01-09 | 2 | -2/+2 |
| | | | | | | |||||
| | * | | | | oops, tweak work_mem when actually storing | Matthew Hodgson | 2018-01-09 | 1 | -0/+2 |
| | | | | | | |||||
| | * | | | | avoid 80s GIN inserts by tweaking work_mem | Matthew Hodgson | 2018-01-09 | 1 | -0/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | see https://github.com/matrix-org/synapse/issues/2753 for details | ||||
| * | | | | | move search reindex to schema 47 | Richard van der Hoff | 2018-02-13 | 2 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We're up to schema v47 on develop now, so this will have to go in there to have an effect. This might cause an error if somebody has already run it in the v46 guise, and runs it again in the v47 guise, because it will cause a duplicate entry in the bbackground_updates table. On the other hand, the entry is removed once it is complete, and it is unlikely that anyone other than matrix.org has run it on v46. The update itself is harmless to re-run because it deliberately copes with the index already existing. | ||||
| * | | | | | GIN reindex: Fix syntax errors, improve exception handling | Richard van der Hoff | 2018-02-13 | 1 | -13/+27 |
| | | | | | | |||||
| * | | | | | Reinstate event_search_postgres_gist handler | Richard van der Hoff | 2018-02-02 | 3 | -6/+31 |
| | | | | | | | | | | | | | | | | | | | | | | | | People may have queued updates for this, so we can't just delete it. | ||||
| * | | | | | fix GIST->GIN switch | Matthew Hodgson | 2018-01-09 | 3 | -14/+37 |
| | | | | | | |||||
| * | | | | | switch back from GIST to GIN indexes | Matthew Hodgson | 2018-01-09 | 1 | -8/+13 |
| |/ / / / | |||||
* | | | | | Merge pull request #2854 from matrix-org/erikj/event_create_worker | Erik Johnston | 2018-02-13 | 12 | -25/+534 |
|\ \ \ \ \ | |_|_|_|/ |/| | | | | Create a worker for event creation | ||||
| * | | | | Update docs | Erik Johnston | 2018-02-13 | 1 | -1/+4 |
| | | | | | |||||
| * | | | | Update workers docs to include http port | Erik Johnston | 2018-02-12 | 1 | -5/+20 |
| | | | | | |||||
| * | | | | Add note in docs/workers.rst | Erik Johnston | 2018-02-07 | 1 | -0/+11 |
| | | | | | |||||
| * | | | | Move presence handling into handle_new_client_event | Erik Johnston | 2018-02-07 | 1 | -6/+6 |
| | | | | | | | | | | | | | | | | | | | | As we want to have it run on the main synapse instance | ||||
| * | | | | Add event_creator worker | Erik Johnston | 2018-02-07 | 3 | -1/+190 |
| | | | | | |||||
| * | | | | Add replication http endpoint for event sending | Erik Johnston | 2018-02-07 | 8 | -13/+304 |
| | | | | | |||||
* | | | | | Fix log message in purge_history | Richard van der Hoff | 2018-02-13 | 1 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | | (we don't just remove remote events) | ||||
* | | | | | Merge pull request #2864 from matrix-org/rav/persist_event_caching | Richard van der Hoff | 2018-02-13 | 2 | -60/+70 |
|\ \ \ \ \ | | | | | | | | | | | | | Use StateResolutionHandler to resolve state in persist_events | ||||
| * | | | | | style nit | Richard van der Hoff | 2018-02-13 | 1 | -1/+1 |
| | | | | | | |||||
| * | | | | | Use StateResolutionHandler to resolve state in persist events | Richard van der Hoff | 2018-02-05 | 1 | -48/+24 |
| | | | | | | | | | | | | | | | | | | | | | | | | ... and thus benefit (hopefully) from its cache. | ||||
| * | | | | | Flatten _get_new_state_after_events | Richard van der Hoff | 2018-02-05 | 1 | -44/+46 |
| | | | | | | | | | | | | | | | | | | | | | | | | rejig the if statements to simplify the logic and reduce indentation | ||||
| * | | | | | Check that events being persisted have state_group | Richard van der Hoff | 2018-02-05 | 1 | -4/+9 |
| | | | | | | |||||
| * | | | | | Add event_map param to resolve_state_groups | Richard van der Hoff | 2018-02-05 | 2 | -4/+31 |
| | | | | | | |||||
* | | | | | | Fix typos in purge api & doc | Richard van der Hoff | 2018-02-13 | 2 | -4/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * It's supposed to be purge_local_events, not ..._history * Fix the doc to have valid json | ||||
* | | | | | | Merge pull request #2695 from okurz/feature/allow_recent_pysaml | Richard van der Hoff | 2018-02-13 | 1 | -1/+1 |
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | Allow use of higher versions of saml2 | ||||
| * | | | | | Allow use of higher versions of saml2 | Oliver Kurz | 2017-11-20 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The package was pinned to <4.0 with 07cf96eb because "from saml2 import config" did not work. This seems to have been fixed in the mean time in the saml2 package and therefore should not stop to use a more recent version. Signed-off-by: Oliver Kurz <okurz@suse.de> | ||||
* | | | | | | Merge pull request #2857 from matrix-org/erikj/upload_store | Erik Johnston | 2018-02-12 | 1 | -0/+6 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Tell storage providers about new file so they can upload | ||||
| * | | | | | | Tell storage providers about new file so they can upload | Erik Johnston | 2018-02-07 | 1 | -0/+6 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #2858 from matrix-org/rav/purge_updates | Richard van der Hoff | 2018-02-09 | 5 | -41/+100 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | delete_local_events for purge_room_history | ||||
| * | | | | | | | purge: move room_depth update to end | Richard van der Hoff | 2018-02-09 | 1 | -6/+12 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... to avoid locking the table for too long | ||||
| * | | | | | | | delete_local_events for purge_history | Richard van der Hoff | 2018-02-09 | 5 | -15/+67 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a flag which makes the purger delete local events | ||||
| * | | | | | | | purge: Move cache invalidation to more appropriate place | Richard van der Hoff | 2018-02-09 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | it was a bit of a non-sequitur there | ||||
| * | | | | | | | bump purge logging to info | Richard van der Hoff | 2018-02-09 | 1 | -13/+14 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this thing takes ages and the only sign of any progress is the logs, so having some logs is useful. | ||||
| * | | | | | | | rename delete_old_state -> purge_history | Richard van der Hoff | 2018-02-09 | 2 | -8/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (beacause it deletes more than state) | ||||
* | | | | | | | | Merge pull request #2856 from matrix-org/erikj/remove_ratelimit | Erik Johnston | 2018-02-07 | 1 | -5/+0 |
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | / / / | | |_|_|/ / / | |/| | | | | | Remove pointless ratelimit check | ||||
| * | | | | | | Remove pointless ratelimit check | Erik Johnston | 2018-02-07 | 1 | -5/+0 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The intention was for the check to be called as early as possible in the request, but actually was called just before the main ratelimit check, so was fairly pointless. | ||||
* | | | | | | Merge pull request #2847 from matrix-org/erikj/separate_event_creation | Erik Johnston | 2018-02-06 | 10 | -196/+217 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Split event creation into a separate handler | ||||
| * | | | | | | Update copyright | Erik Johnston | 2018-02-06 | 6 | -1/+6 |
| | | | | | | | |||||
| * | | | | | | s/_create_new_client_event/create_new_client_event/ | Erik Johnston | 2018-02-06 | 4 | -12/+12 |
| | | | | | | | |||||
| * | | | | | | Updates tests | Erik Johnston | 2018-02-05 | 2 | -8/+6 |
| | | | | | | | |||||
| * | | | | | | Update places where we create events | Erik Johnston | 2018-02-05 | 7 | -38/+42 |
| | | | | | | | |||||
| * | | | | | | Split event creation into a separate handler | Erik Johnston | 2018-02-05 | 1 | -146/+160 |
| | | | | | | | |||||
* | | | | | | | Store state groups separately from events (#2784) | Erik Johnston | 2018-02-06 | 12 | -189/+326 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Split state group persist into seperate storage func * Add per database engine code for state group id gen * Move store_state_group to StateReadStore This allows other workers to use it, and so resolve state. * Hook up store_state_group * Fix tests * Rename _store_mult_state_groups_txn * Rename StateGroupReadStore * Remove redundant _have_persisted_state_group_txn * Update comments * Comment compute_event_context * Set start val for state_group_id_seq ... otherwise we try to recreate old state groups * Update comments * Don't store state for outliers * Update comment * Update docstring as state groups are ints | ||||
* | | | | | | | Merge pull request #2849 from matrix-org/rav/clean_up_state_delta | Richard van der Hoff | 2018-02-05 | 1 | -10/+23 |
|\ \ \ \ \ \ \ | | |_|_|/ / / | |/| | | | | | Remove redundant return value from _calculate_state_delta | ||||
| * | | | | | | Remove redundant return value from _calculate_state_delta | Richard van der Hoff | 2018-02-05 | 1 | -10/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we already have the state from _get_new_state_after_events, so returning it from _calculate_state_delta is just confusing. | ||||
* | | | | | | | Merge pull request #2848 from matrix-org/rav/refactor_search_insert | Richard van der Hoff | 2018-02-05 | 2 | -59/+94 |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | Factor out common code for search insert | ||||
| * | | | | | | Factor out common code for search insert | Richard van der Hoff | 2018-02-05 | 1 | -33/+62 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we can reuse the same code as is used for event insert, for doing the background index population. | ||||
| * | | | | | | Move store_event_search_txn to SearchStore | Richard van der Hoff | 2018-02-05 | 2 | -35/+41 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | ... as a precursor to making event storing and doing the bg update share some code. | ||||
* | | | | | | Merge pull request #2844 from matrix-org/rav/evicted_metrics | Richard van der Hoff | 2018-02-05 | 5 | -5/+56 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | montoring metrics for number of cache evictions | ||||
| * | | | | | report metrics on number of cache evictions | Richard van der Hoff | 2018-02-05 | 5 | -5/+56 |
| | |_|_|/ | |/| | | | |||||
* | | | | | Fix broken unit test for media storage | Erik Johnston | 2018-02-05 | 1 | -1/+6 |
| | | | | | |||||
* | | | | | Add .vscode to gitignore | Erik Johnston | 2018-02-05 | 1 | -0/+2 |
| | | | | | |||||
* | | | | | Merge pull request #2791 from matrix-org/erikj/media_storage_refactor | Erik Johnston | 2018-02-05 | 6 | -12/+156 |
|\ \ \ \ \ | | | | | | | | | | | | | Ensure media is in local cache before thumbnailing | ||||
| * | | | | | Add unit tests | Erik Johnston | 2018-01-18 | 3 | -0/+109 |
| | | | | | | |||||
| * | | | | | Use better file consumer | Erik Johnston | 2018-01-18 | 1 | -5/+10 |
| | | | | | | |||||
| * | | | | | Ensure media is in local cache before thumbnailing | Erik Johnston | 2018-01-18 | 3 | -10/+40 |
| | | | | | | |||||
* | | | | | | Merge pull request #2845 from matrix-org/rav/urlcache_error_handling | Richard van der Hoff | 2018-02-02 | 1 | -21/+34 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Handle url_previews with no content-type | ||||
| * | | | | | | Handle url_previews with no content-type | Richard van der Hoff | 2018-02-02 | 1 | -21/+34 |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | avoid failing with an exception if the remote server doesn't give us a Content-Type header. Also, clean up the exception handling a bit. | ||||
* | | | | | | Merge pull request #2842 from matrix-org/rav/state_resolution_handler | Richard van der Hoff | 2018-02-02 | 5 | -66/+119 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Factor out resolve_state_groups to a separate handler | ||||
| * | | | | | | Factor out resolve_state_groups to a separate handler | Richard van der Hoff | 2018-02-01 | 4 | -54/+108 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We extract the storage-independent bits of the state group resolution out to a separate functiom, and stick it in a new handler, in preparation for its use from the storage layer. | ||||
| * | | | | | | Rename resolve_state_groups -> resolve_state_groups_for_events | Richard van der Hoff | 2018-02-01 | 2 | -12/+11 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (to make way for a method that actually just does the state group resolution) | ||||
* | | | | | | | Merge pull request #2841 from matrix-org/rav/refactor_calc_state_delta | Richard van der Hoff | 2018-02-02 | 1 | -18/+39 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | factor _get_new_state_after_events out of _calculate_state_delta | ||||
| * | | | | | | | factor _get_new_state_after_events out of _calculate_state_delta | Richard van der Hoff | 2018-01-31 | 1 | -18/+39 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | This reduces the scope of a bunch of variables | ||||
* | | | | | | | Merge pull request #2836 from matrix-org/rav/resolve_state_events_docstring | Richard van der Hoff | 2018-02-02 | 1 | -8/+28 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Docstring fixes | ||||
| * | | | | | | | doc arg types for _seperate | Richard van der Hoff | 2018-02-01 | 1 | -0/+15 |
| | | | | | | | | |||||
| * | | | | | | | More docstring fixes | Richard van der Hoff | 2018-02-01 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a couple of errors in docstrings | ||||
| * | | | | | | | Fix docstring for StateHandler.resolve_state_groups | Richard van der Hoff | 2018-02-01 | 1 | -4/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The return type was a complete lie, so fix it | ||||
* | | | | | | | | Merge pull request #2818 from turt2live/travis/admin-list-media | Richard van der Hoff | 2018-02-02 | 3 | -56/+142 |
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | Add an admin route to get all the media in a room | ||||
| * | | | | | | | Merge branch 'develop' into travis/admin-list-media | Travis Ralston | 2018-02-01 | 47 | -386/+716 |
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | | |||||
* | | | | | | | | Merge pull request #2837 from matrix-org/rav/fix_quarantine_media | Richard van der Hoff | 2018-02-01 | 1 | -1/+1 |
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | Fix sql error in quarantine_media | ||||
| * | | | | | | | Fix sql error in quarantine_media | Richard van der Hoff | 2018-01-30 | 1 | -1/+1 |
| | |/ / / / / | |/| | | | | | |||||
* | | | | | | | Merge pull request #2838 from matrix-org/rav/fix_logging_on_dns_fail | Richard van der Hoff | 2018-01-31 | 1 | -2/+1 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Remove spurious log argument | ||||
| * | | | | | | | Remove spurious log argument | Richard van der Hoff | 2018-01-30 | 1 | -2/+1 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | ... which would cause scary-looking and unhelpful errors in the log on dns fail | ||||
* | | | | | | | Merge pull request #2835 from matrix-org/rav/remove_event_type_param | Richard van der Hoff | 2018-01-31 | 1 | -6/+14 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Remove unused "event_type" param on state.get_current_state_ids | ||||
| * | | | | | | | docstring for get_current_state_ids | Richard van der Hoff | 2018-01-29 | 1 | -0/+13 |
| | | | | | | | | |||||
| * | | | | | | | Remove unused "event_type" param on state.get_current_state_ids | Richard van der Hoff | 2018-01-29 | 1 | -6/+1 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this param doesn't seem to be used, and is a bit pointless anyway because it can easily be replicated by the caller. It is also horrible, because it changes the return type of the method. | ||||
* | | | | | | | Merge pull request #2834 from ↵ | Richard van der Hoff | 2018-01-31 | 1 | -3/+3 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | matrix-org/rav/better_persist_event_exception_handling Improve exception handling in persist_event | ||||
| * | | | | | | | Improve exception handling in persist_event | Richard van der Hoff | 2018-01-29 | 1 | -3/+3 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. use `deferred.errback()` instead of `deferred.errback(e)`, which means that a Failure object will be constructed using the current exception state, *including* its stack trace - so the stack trace is saved in the Failure, leading to better exception reports. 2. Set `consumeErrors=True` on the ObservableDeferred, because we know that there will always be at least one observer - which avoids a spurious "CRITICAL: unhandled exception in Deferred" error in the logs | ||||
* | | | | | | | Merge pull request #2833 from matrix-org/rav/pusher_hacks | Richard van der Hoff | 2018-01-31 | 1 | -7/+30 |
|\ \ \ \ \ \ \ | | |_|_|/ / / | |/| | | | | | Logging and metrics for the http pusher | ||||
| * | | | | | | Better logging when pushes fail | Richard van der Hoff | 2018-01-29 | 1 | -2/+8 |
| | | | | | | | |||||
| * | | | | | | add appid/device_display_name to to pusher logging | Richard van der Hoff | 2018-01-29 | 1 | -2/+2 |
| | | | | | | | |||||
| * | | | | | | Fix logging and add user_id | Richard van der Hoff | 2018-01-22 | 1 | -2/+3 |
| | | | | | | | |||||
| * | | | | | | logging and debug for http pusher | Richard van der Hoff | 2018-01-22 | 1 | -4/+20 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #2817 from matrix-org/rav/http_conn_pool | Richard van der Hoff | 2018-01-31 | 1 | -1/+13 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Use a connection pool for the SimpleHttpClient | ||||
| * | | | | | | | Increase http conn pool size | Richard van der Hoff | 2018-01-29 | 1 | -1/+6 |
| |/ / / / / / | |||||
| * | | | | | | Use a connection pool for the SimpleHttpClient | Richard van der Hoff | 2018-01-20 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In particular I hope this will help the pusher, which makes many requests to sygnal, and is currently negotiating SSL for each one. | ||||
* | | | | | | | Script to move remote media to another media store | Richard van der Hoff | 2018-01-31 | 1 | -0/+133 |
| |/ / / / / |/| | | | | | |||||
* | | | | | | Merge pull request #2831 from matrix-org/rav/fix-userdir-search-again | Richard van der Hoff | 2018-01-27 | 3 | -7/+96 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix SQL for user search | ||||
| * | | | | | | Add tests for user directory search | Richard van der Hoff | 2018-01-27 | 2 | -0/+89 |
| | | | | | | | |||||
| * | | | | | | Fix SQL for user search | Richard van der Hoff | 2018-01-27 | 1 | -7/+7 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix some syntax errors for user search when search_all_users is enabled fixes #2801, hopefully | ||||
* | | | | | | Merge pull request #2829 from matrix-org/rav/postgres_in_tests | Richard van der Hoff | 2018-01-27 | 2 | -38/+47 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Make it possible to run tests against postgres | ||||
| * | | | | | | Make it possible to run tests against postgres | Richard van der Hoff | 2018-01-27 | 1 | -9/+34 |
| | | | | | | | |||||
| * | | | | | | Create dbpool as normal in tests | Richard van der Hoff | 2018-01-27 | 2 | -45/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... instead of creating our own special SQLiteMemoryDbPool, whose purpose was a bit of a mystery. For some reason this makes one of the tests run slightly slower, so bump the sleep(). Sorry. | ||||
| * | | | | | | Run on_new_connection for unit tests | Richard van der Hoff | 2018-01-27 | 1 | -7/+17 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Configure the connectionpool used for unit tests to run the `on_new_connection` function. | ||||
* | | | | | | Merge pull request #2828 from matrix-org/rav/kill_memory_datastore | Richard van der Hoff | 2018-01-27 | 1 | -151/+13 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove unused/bitrotted MemoryDataStore | ||||
| * | | | | | | Remove unused/bitrotted MemoryDataStore | Richard van der Hoff | 2018-01-26 | 1 | -151/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This isn't used, and looks thoroughly bitrotted. | ||||
* | | | | | | | Merge pull request #2830 from matrix-org/rav/factor_out_get_conn | Richard van der Hoff | 2018-01-27 | 11 | -130/+17 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Factor out get_db_conn to HomeServer base class | ||||
| * | | | | | | | Factor out get_db_conn to HomeServer base class | Richard van der Hoff | 2018-01-26 | 11 | -130/+17 |
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function is identical to all subclasses, so we may as well push it up to the base class to reduce duplication (and make use of it in the tests) | ||||
* | | | | | | | Merge pull request #2827 from ↵ | Neil Johnson | 2018-01-26 | 1 | -1/+2 |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | matrix-org/fix_server_500_on_public_rooms_call_when_no_rooms_exist Fix server 500 on public rooms call when no rooms exist | ||||
| * | | | | | | add white space line | Neil Johnson | 2018-01-26 | 1 | -0/+1 |
| | | | | | | | |||||
| * | | | | | | rather than try reconstruct the results object, better to guard against the ↵ | Neil Johnson | 2018-01-26 | 1 | -6/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | xrange step argument being 0 | ||||
| * | | | | | | fix return type, should be a dict | Neil Johnson | 2018-01-25 | 1 | -1/+1 |
| | | | | | | | |||||
| * | | | | | | fix PEP8 violation | Neil Johnson | 2018-01-25 | 1 | -1/+1 |
| | | | | | | | |||||
| * | | | | | | remove white space | Neil Johnson | 2018-01-25 | 1 | -1/+0 |
| | | | | | | | |||||
| * | | | | | | synapse 500s on a call to publicRooms in the case where the number of public ↵ | Neil Johnson | 2018-01-25 | 1 | -0/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | rooms is zero, the specific cause is due to xrange trying to use a step value of zero, but if the total room number really is zero then it makes sense to just bail and save the extra processing | ||||
* | | | | | | | Remove spurious unittest.DEBUG | Richard van der Hoff | 2018-01-26 | 1 | -1/+0 |
| | | | | | | | |||||
* | | | | | | | fix thinko on 3pid whitelisting | Matthew Hodgson | 2018-01-24 | 1 | -2/+2 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #2816 from matrix-org/rav/metrics_comments | Richard van der Hoff | 2018-01-23 | 1 | -1/+6 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Add some comments about the reactor tick time metric | ||||
| * | | | | | | | Add some comments about the reactor tick time metric | Richard van der Hoff | 2018-01-19 | 1 | -1/+6 |
| | | | | | | | | |||||
* | | | | | | | | add ?ts massaging for ASes (#2754) | Matthew Hodgson | 2018-01-23 | 1 | -6/+11 |
| |/ / / / / / |/| | | | | | | | | | | | | | blindly implement ?ts for AS. untested | ||||
* | | | | | | | Merge pull request #2821 from matrix-org/rav/matthew_test_fixes | Richard van der Hoff | 2018-01-22 | 1 | -2/+6 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Matthew's fixes to the unit tests | ||||
| * | | | | | | | Matthew's fixes to the unit tests | Richard van der Hoff | 2018-01-22 | 1 | -2/+6 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extracted from https://github.com/matrix-org/synapse/pull/2820 | ||||
* | | | | | | | | Add federation_domain_whitelist option (#2820) | Matthew Hodgson | 2018-01-22 | 14 | -7/+146 |
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add federation_domain_whitelist gives a way to restrict which domains your HS is allowed to federate with. useful mainly for gracefully preventing a private but internet-connected HS from trying to federate to the wider public Matrix network | ||||
* | | | | | | | Merge pull request #2813 from matrix-org/matthew/registrations_require_3pid | Matthew Hodgson | 2018-01-22 | 8 | -23/+178 |
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | add registrations_require_3pid and allow_local_3pids | ||||
| * | | | | | | fix typo (thanks sytest) | Matthew Hodgson | 2018-01-19 | 1 | -1/+1 |
| | | | | | | | |||||
| * | | | | | | oops, check all login types | Matthew Hodgson | 2018-01-19 | 1 | -14/+11 |
| | | | | | | | |||||
| * | | | | | | fix PR nitpicking | Matthew Hodgson | 2018-01-19 | 1 | -3/+6 |
| | | | | | | | |||||
| * | | | | | | trailing commas | Matthew Hodgson | 2018-01-19 | 2 | -7/+7 |
| | | | | | | | |||||
| * | | | | | | rewrite based on PR feedback: | Matthew Hodgson | 2018-01-19 | 7 | -89/+102 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * [ ] split config options into allowed_local_3pids and registrations_require_3pid * [ ] simplify and comment logic for picking registration flows * [ ] fix docstring and move check_3pid_allowed into a new util module * [ ] use check_3pid_allowed everywhere @erikjohnston PTAL | ||||
| * | | | | | | fix up v1, and improve errors | Matthew Hodgson | 2018-01-19 | 4 | -20/+65 |
| | | | | | | | |||||
| * | | | | | | fix pep8 | Matthew Hodgson | 2018-01-19 | 1 | -2/+1 |
| | | | | | | | |||||
| * | | | | | | mock registrations_require_3pid | Matthew Hodgson | 2018-01-19 | 1 | -0/+1 |
| | | | | | | | |||||
| * | | | | | | add registrations_require_3pid | Matthew Hodgson | 2018-01-19 | 5 | -13/+110 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | lets homeservers specify a whitelist for 3PIDs that users are allowed to associate with. Typically useful for stopping people from registering with non-work emails | ||||
| | | * | | | | pep8 | Travis Ralston | 2018-01-31 | 1 | -9/+12 |
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Travis Ralston <travpc@gmail.com> | ||||
| | | * | | | | Add admin api documentation for list media endpoint | Travis Ralston | 2018-01-31 | 1 | -0/+23 |
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Travis Ralston <travpc@gmail.com> | ||||
| | | * | | | | Documentation and naming | Travis Ralston | 2018-01-31 | 1 | -7/+26 |
| | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Travis Ralston <travpc@gmail.com> | ||||
| | | * | | | | Appease the linter | Travis Ralston | 2018-01-20 | 1 | -5/+5 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are ids anyways, not mxc uris. Signed-off-by: Travis Ralston <travpc@gmail.com> | ||||
| | | * | | | | Add an admin route to get all the media in a room | Travis Ralston | 2018-01-20 | 2 | -56/+97 |
| |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | This is intended to be used by administrators to monitor the media that is passing through their server, if they wish. Signed-off-by: Travis Ralston <travpc@gmail.com> | ||||
* | | | | | | Merge pull request #2814 from matrix-org/rav/fix_urlcache_thumbs | Richard van der Hoff | 2018-01-19 | 1 | -0/+8 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Use the right path for url_preview thumbnails | ||||
| * | | | | | | Use the right path for url_preview thumbnails | Richard van der Hoff | 2018-01-19 | 1 | -0/+8 |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was introduced by #2627: we were overwriting the original media for url previews with the thumbnails :/ (fixes https://github.com/vector-im/riot-web/issues/6012, hopefully) | ||||
* | | | | | | Fix storage provider bug introduced when renamed to store_local | Erik Johnston | 2018-01-18 | 1 | -1/+1 |
| | | | | | | |||||
* | | | | | | Merge pull request #2812 from matrix-org/erikj/media_storage_provider_config | Erik Johnston | 2018-01-18 | 3 | -33/+101 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Make storage providers configurable | ||||
| * | | | | | | Fix passing wrong config to provider constructor | Erik Johnston | 2018-01-18 | 1 | -1/+1 |
| | | | | | | | |||||
| * | | | | | | Remove duplicate directory test | Erik Johnston | 2018-01-18 | 1 | -4/+0 |
| | | | | | | | |||||
| * | | | | | | Missing staticmethod | Erik Johnston | 2018-01-18 | 1 | -0/+1 |
| | | | | | | | |||||
| * | | | | | | Fixup comments | Erik Johnston | 2018-01-18 | 2 | -3/+7 |
| | | | | | | | |||||
| * | | | | | | Make storage providers more configurable | Erik Johnston | 2018-01-18 | 3 | -31/+98 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #2804 from matrix-org/erikj/file_consumer | Erik Johnston | 2018-01-18 | 2 | -0/+315 |
|\ \ \ \ \ \ \ | | |_|_|/ / / | |/| | | | | | Add decent impl of a FileConsumer | ||||
| * | | | | | | Do logcontexts correctly | Erik Johnston | 2018-01-18 | 1 | -2/+2 |
| | | | | | | | |||||
| * | | | | | | Move test stuff to tests | Erik Johnston | 2018-01-18 | 2 | -33/+47 |
| | | | | | | | |||||
| * | | | | | | Make all fields private | Erik Johnston | 2018-01-18 | 1 | -31/+31 |
| | | | | | | | |||||
| * | | | | | | Ensure we registerProducer isn't called twice | Erik Johnston | 2018-01-18 | 1 | -0/+3 |
| | | | | | | | |||||
| * | | | | | | Fix _notify_empty typo | Erik Johnston | 2018-01-18 | 1 | -1/+1 |
| | | | | | | | |||||
| * | | | | | | Move definition of paused_producer to __init__ | Erik Johnston | 2018-01-18 | 1 | -2/+4 |
| | | | | | | | |||||
| * | | | | | | Fix comments | Erik Johnston | 2018-01-18 | 1 | -3/+3 |
| | | | | | | | |||||
| * | | | | | | Add decent impl of a FileConsumer | Erik Johnston | 2018-01-17 | 2 | -0/+296 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Twisted core doesn't have a general purpose one, so we need to write one ourselves. Features: - All writing happens in background thread - Supports both push and pull producers - Push producers get paused if the consumer falls behind | ||||
* | | | | | | Fix typo in thumbnail resource causing access times to be incorrect | Erik Johnston | 2018-01-18 | 1 | -2/+2 |
| | | | | | | |||||
* | | | | | | Merge pull request #2810 from matrix-org/rav/metrics_fixes | Richard van der Hoff | 2018-01-18 | 1 | -2/+4 |
|\ \ \ \ \ \ | | |/ / / / | |/| | | | | Fix bugs in block metrics | ||||
| * | | | | | Fix bugs in block metrics | Richard van der Hoff | 2018-01-18 | 1 | -2/+4 |
|/ / / / / | | | | | | | | | | | | | | | | ... which I introduced in #2785 | ||||
* | | | | | Merge pull request #2809 from matrix-org/rav/metrics_errors | Richard van der Hoff | 2018-01-18 | 1 | -1/+8 |
|\ \ \ \ \ | |_|/ / / |/| | | | | better exception logging in callbackmetrics | ||||
| * | | | | better exception logging in callbackmetrics | Richard van der Hoff | 2018-01-18 | 1 | -1/+8 |
| | | | | | | | | | | | | | | | | | | | | when we fail to render a metric, give a clue as to which metric it was | ||||
* | | | | | Merge pull request #2805 from matrix-org/rav/log_state_res | Richard van der Hoff | 2018-01-17 | 1 | -0/+6 |
|\ \ \ \ \ | |/ / / / |/| | | | | Log room when doing state resolution | ||||
| * | | | | Log room when doing state resolution | Richard van der Hoff | 2018-01-17 | 1 | -0/+6 |
| | | | | | | | | | | | | | | | | | | | | Mostly because it helps figure out what is prompting the resolution | ||||
* | | | | | Merge pull request #2783 from matrix-org/erikj/media_last_accessed | Erik Johnston | 2018-01-17 | 5 | -11/+64 |
|\ \ \ \ \ | | | | | | | | | | | | | Keep track of last access time for local media | ||||
| * | | | | | Remove lost comment | Erik Johnston | 2018-01-17 | 1 | -3/+0 |
| | | | | | | |||||
| * | | | | | Update last access time when thumbnails are viewed | Erik Johnston | 2018-01-17 | 1 | -0/+2 |
| | | | | | | |||||
| * | | | | | Keep track of last access time for local media | Erik Johnston | 2018-01-17 | 4 | -11/+65 |
| | |/ / / | |/| | | | |||||
* | | | | | Merge pull request #2803 from matrix-org/matthew/fix-userdir-sql | Matthew Hodgson | 2018-01-17 | 1 | -2/+7 |
|\ \ \ \ \ | | | | | | | | | | | | | fix SQL when searching all users | ||||
| * | | | | | fix SQL when searching all users | Matthew Hodgson | 2018-01-17 | 1 | -2/+7 |
| | | | | | | |||||
* | | | | | | Merge pull request #2802 from matrix-org/rav/clean_up_resolve_events | Richard van der Hoff | 2018-01-17 | 2 | -20/+29 |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Split resolve_events into two functions | ||||
| * | | | | | Split resolve_events into two functions | Richard van der Hoff | 2018-01-17 | 2 | -20/+29 |
|/ / / / / | | | | | | | | | | | | | | | | ... so that the return type doesn't depend on the arg types | ||||
* | | | | | Merge pull request #2795 from matrix-org/rav/track_db_scheduling | Richard van der Hoff | 2018-01-17 | 5 | -4/+43 |
|\ \ \ \ \ | | | | | | | | | | | | | Track DB scheduling delay per-request | ||||
| * \ \ \ \ | Merge remote-tracking branch 'origin/develop' into rav/track_db_scheduling | Richard van der Hoff | 2018-01-17 | 5 | -34/+78 |
| |\ \ \ \ \ | |||||
| * | | | | | | Track DB scheduling delay per-request | Richard van der Hoff | 2018-01-16 | 5 | -4/+43 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For each request, track the amount of time spent waiting for a db connection. This entails adding it to the LoggingContext and we may as well add metrics for it while we are passing. | ||||
| * | | | | | | Merge branch 'rav/db_txn_time_in_millis' into rav/track_db_scheduling | Richard van der Hoff | 2018-01-16 | 6 | -31/+49 |
| |\ \ \ \ \ \ | |||||
* | \ \ \ \ \ \ | Merge pull request #2797 from matrix-org/rav/user_id_checking | Richard van der Hoff | 2018-01-17 | 2 | -8/+19 |
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | Sanity checking for user ids | ||||
| * | | | | | | | Sanity checking for user ids | Richard van der Hoff | 2018-01-17 | 2 | -8/+19 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check the user_id passed to a couple of APIs for validity, to avoid "IndexError: list index out of range" exception which looks scary and results in a 500 rather than a more useful error. Fixes #1432, among other things | ||||
* | | | | | | | | Merge pull request #2793 from matrix-org/rav/db_txn_time_in_millis | Richard van der Hoff | 2018-01-17 | 4 | -10/+17 |
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | Track db txn time in millisecs | ||||
| * | | | | | | | | Merge branch 'develop' into rav/db_txn_time_in_millis | Richard van der Hoff | 2018-01-17 | 4 | -25/+69 |
| |\| | | | | | | | | |_|/ / / / / | |/| | | | | | | |||||
| * | | | | | | | Track db txn time in millisecs | Richard van der Hoff | 2018-01-16 | 4 | -10/+17 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... to reduce the amount of floating-point foo we do. | ||||
* | | | | | | | | Merge pull request #2796 from matrix-org/rav/fix_closed_connection_errors | Richard van der Hoff | 2018-01-17 | 1 | -9/+9 |
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | Fix 'NoneType' object has no attribute 'writeHeaders' | ||||
| * \ \ \ \ \ \ \ | Merge branch 'develop' into rav/fix_closed_connection_errors | Richard van der Hoff | 2018-01-17 | 7 | -47/+102 |
| |\ \ \ \ \ \ \ \ | | | |/ / / / / / | | |/| | | | | | | |||||
| * | | | | | | | | Fix 'NoneType' object has no attribute 'writeHeaders' | Richard van der Hoff | 2018-01-16 | 1 | -9/+9 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid throwing a (harmless) exception when we try to write an error response to an http request where the client has disconnected. This comes up as a CRITICAL error in the logs which tends to mislead people into thinking there's an actual problem | ||||
* | | | | | | | | | Merge pull request #2794 from matrix-org/rav/rework_run_interaction | Richard van der Hoff | 2018-01-17 | 1 | -20/+31 |
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | | rework runInteraction in terms of runConnection | ||||
| * | | | | | | | | Merge branch 'develop' into rav/rework_run_interaction | Richard van der Hoff | 2018-01-17 | 7 | -47/+102 |
| |\ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | / / / / / | | |_|/ / / / / | |/| | | | | | | |||||
* | | | | | | | | Merge pull request #2792 from matrix-org/rav/optimise_logging_context | Richard van der Hoff | 2018-01-17 | 3 | -22/+33 |
|\ \ \ \ \ \ \ \ | |_|_|_|/ / / / |/| | | | | | | | Optimise LoggingContext creation and copying | ||||
| * | | | | | | | Merge remote-tracking branch 'origin/develop' into rav/optimise_logging_context | Richard van der Hoff | 2018-01-17 | 4 | -25/+69 |
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | / / / / | | |_|/ / / / | |/| | | | | | |||||
* | | | | | | | Merge pull request #2789 from matrix-org/erikj/fix_thumbnails | Erik Johnston | 2018-01-17 | 3 | -24/+68 |
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | Fix thumbnailing remote files | ||||
| * | | | | | | | Add docstring | Erik Johnston | 2018-01-17 | 1 | -1/+1 |
| | | | | | | | | |||||
| * | | | | | | | Use local vars | Erik Johnston | 2018-01-16 | 1 | -6/+2 |
| | | | | | | | | |||||
| * | | | | | | | Change _generate_thumbnails to take media_type | Erik Johnston | 2018-01-16 | 2 | -7/+10 |
| | | | | | | | | |||||
| * | | | | | | | Move setting of file_id up to caller | Erik Johnston | 2018-01-16 | 2 | -13/+14 |
| | | | | | | | | |||||
| * | | | | | | | Fix typo | Erik Johnston | 2018-01-16 | 1 | -7/+10 |
| | | | | | | | | |||||
| * | | | | | | | Fix up log lines | Erik Johnston | 2018-01-16 | 2 | -7/+10 |
| | | | | | | | | |||||
| * | | | | | | | Correctly use server_name/file_id when generating/fetching remote thumbnails | Erik Johnston | 2018-01-16 | 2 | -5/+8 |
| | | | | | | | | |||||
| * | | | | | | | Log when we respond with 404 | Erik Johnston | 2018-01-16 | 2 | -1/+8 |
| | | | | | | | | |||||
| * | | | | | | | Fix thumbnailing remote files | Erik Johnston | 2018-01-16 | 2 | -2/+30 |
| | | | | | | | | |||||
* | | | | | | | | fix typo | Matthew Hodgson | 2018-01-16 | 1 | -1/+1 |
| |_|_|/ / / / |/| | | | | | | |||||
| | * | | | | | Optimise LoggingContext creation and copying | Richard van der Hoff | 2018-01-16 | 3 | -22/+33 |
| |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that the only thing we use the __dict__ of LoggingContext for is `request`, and given we create lots of LoggingContexts and then copy them every time we do a db transaction or log line, using the __dict__ seems a bit redundant. Let's try to optimise things by making the request attribute explicit. | ||||
| | * | | | | rework runInteraction in terms of runConnection | Richard van der Hoff | 2018-01-16 | 1 | -20/+31 |
| |/ / / / |/| | | | | | | | | | | | | | | ... so that we can share the code | ||||
* | | | | | Merge pull request #2785 from matrix-org/rav/reorganise_metrics_again | Richard van der Hoff | 2018-01-16 | 5 | -47/+209 |
|\ \ \ \ \ | | | | | | | | | | | | | Reorganise request and block metrics | ||||
| * | | | | | document metrics changes | Richard van der Hoff | 2018-01-16 | 2 | -8/+58 |
| | | | | | | |||||
| * | | | | | Reorganise request and block metrics | Richard van der Hoff | 2018-01-15 | 2 | -25/+84 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to circumvent the number of duplicate foo:count metrics increasing without bounds, it's time for a rearrangement. The following are all deprecated, and replaced with synapse_util_metrics_block_count: synapse_util_metrics_block_timer:count synapse_util_metrics_block_ru_utime:count synapse_util_metrics_block_ru_stime:count synapse_util_metrics_block_db_txn_count:count synapse_util_metrics_block_db_txn_duration:count The following are all deprecated, and replaced with synapse_http_server_response_count: synapse_http_server_requests synapse_http_server_response_time:count synapse_http_server_response_ru_utime:count synapse_http_server_response_ru_stime:count synapse_http_server_response_db_txn_count:count synapse_http_server_response_db_txn_duration:count The following are renamed (the old metrics are kept for now, but deprecated): synapse_util_metrics_block_timer:total -> synapse_util_metrics_block_time_seconds synapse_util_metrics_block_ru_utime:total -> synapse_util_metrics_block_ru_utime_seconds synapse_util_metrics_block_ru_stime:total -> synapse_util_metrics_block_ru_stime_seconds synapse_util_metrics_block_db_txn_count:total -> synapse_util_metrics_block_db_txn_count synapse_util_metrics_block_db_txn_duration:total -> synapse_util_metrics_block_db_txn_duration_seconds synapse_http_server_response_time:total -> synapse_http_server_response_time_seconds synapse_http_server_response_ru_utime:total -> synapse_http_server_response_ru_utime_seconds synapse_http_server_response_ru_stime:total -> synapse_http_server_response_ru_stime_seconds synapse_http_server_response_db_txn_count:total -> synapse_http_server_response_db_txn_count synapse_http_server_response_db_txn_duration:total synapse_http_server_response_db_txn_duration_seconds | ||||
| * | | | | | mechanism to render metrics with alternative names | Richard van der Hoff | 2018-01-15 | 1 | -13/+40 |
| | | | | | | |||||
| * | | | | | Add some comments to metrics classes | Richard van der Hoff | 2018-01-15 | 1 | -1/+27 |
| | | | | | | |||||
* | | | | | | Merge pull request #2790 from matrix-org/rav/preserve_event_logcontext_leak | Richard van der Hoff | 2018-01-16 | 1 | -1/+8 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix a logcontext leak in persist_events | ||||
| * | | | | | | Fix a logcontext leak in persist_events | Richard van der Hoff | 2018-01-16 | 1 | -1/+8 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ObserveableDeferred expects its callbacks to be called without any logcontexts, whereas it turns out we were calling them with the logcontext of the request which initiated the persistence loop. It seems wrong that we are attributing work done in the persistence loop to the request that happened to initiate it, so let's solve this by dropping the logcontext for it. (I'm not sure this actually causes any real problems other than messages in the debug log, but let's clean it up anyway) | ||||
* | | | | | | Merge pull request #2787 from matrix-org/rav/worker_event_counts | Richard van der Hoff | 2018-01-16 | 2 | -0/+11 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Metrics for events processed in appservice and fed sender | ||||
| * | | | | | | Metrics for events processed in appservice and fed sender | Richard van der Hoff | 2018-01-15 | 2 | -0/+11 |
| |/ / / / / | | | | | | | | | | | | | | | | | | | More metrics I wished I'd had | ||||
* | | | | | | Merge pull request #2786 from matrix-org/rav/rdata_metrics | Richard van der Hoff | 2018-01-16 | 1 | -5/+14 |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | Metrics for number of RDATA commands received | ||||
| * | | | | | Metrics for number of RDATA commands received | Richard van der Hoff | 2018-01-15 | 1 | -5/+14 |
| |/ / / / | | | | | | | | | | | | | | | | I found myself wishing we had this. | ||||
* | | | | | Merge pull request #2767 from matrix-org/erikj/media_storage_refactor | Erik Johnston | 2018-01-16 | 7 | -346/+843 |
|\ \ \ \ \ | |/ / / / |/| | | | | Refactor MediaRepository to separate out storage | ||||
| * | | | | Fix up comments | Erik Johnston | 2018-01-12 | 2 | -7/+16 |
| | | | | | |||||
| * | | | | Correctly reraise exception | Erik Johnston | 2018-01-12 | 1 | -2/+4 |
| | | | | | |||||
| * | | | | Make Responder a context manager | Erik Johnston | 2018-01-12 | 2 | -9/+10 |
| | | | | | |||||
| * | | | | Add missing class var | Erik Johnston | 2018-01-12 | 1 | -0/+3 |
| | | | | | |||||
| * | | | | Merge branch 'develop' of github.com:matrix-org/synapse into ↵ | Erik Johnston | 2018-01-12 | 9 | -28/+116 |
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | erikj/media_storage_refactor | ||||
| * | | | | | Remove unnecessary condition | Erik Johnston | 2018-01-12 | 1 | -4/+1 |
| | | | | | | |||||
| * | | | | | Remove unused variables | Erik Johnston | 2018-01-12 | 1 | -3/+0 |
| | | | | | | |||||
| * | | | | | Make class var local | Erik Johnston | 2018-01-12 | 1 | -3/+3 |
| | | | | | | |||||
| * | | | | | Comments | Erik Johnston | 2018-01-12 | 3 | -15/+65 |
| | | | | | | |||||
| * | | | | | Add StorageProvider concept | Erik Johnston | 2018-01-09 | 3 | -9/+162 |
| | | | | | | |||||
| * | | | | | Make PreviewUrlResource use MediaStorage | Erik Johnston | 2018-01-09 | 2 | -8/+14 |
| | | | | | | |||||
| * | | | | | Make ThumbnailResource use MediaStorage | Erik Johnston | 2018-01-09 | 2 | -48/+68 |
| | | | | | | |||||
| * | | | | | Use MediaStorage for remote media | Erik Johnston | 2018-01-09 | 2 | -136/+156 |
| | | | | | | |||||
| * | | | | | Use MediaStorage for local files | Erik Johnston | 2018-01-09 | 2 | -119/+73 |
| | | | | | | |||||
| * | | | | | Add MediaStorage class | Erik Johnston | 2018-01-09 | 1 | -0/+198 |
| | | | | | | |||||
| * | | | | | Add some helper classes | Erik Johnston | 2018-01-09 | 1 | -0/+73 |
| | | | | | | |||||
| * | | | | | Split out add_file_headers | Erik Johnston | 2018-01-09 | 1 | -28/+42 |
| | | | | | | |||||
* | | | | | | Merge pull request #2778 from matrix-org/rav/counters_should_be_floats | Richard van der Hoff | 2018-01-15 | 1 | -3/+10 |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | Make Counter render floats | ||||
| * | | | | | Make Counter render floats | Richard van der Hoff | 2018-01-12 | 1 | -3/+10 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prometheus handles all metrics as floats, and sometimes we store non-integer values in them (notably, durations in seconds), so let's render them as floats too. (Note that the standard client libraries also treat Counters as floats.) | ||||
* | | | | | Merge pull request #2777 from matrix-org/rav/fix_remote_thumbnails | Richard van der Hoff | 2018-01-12 | 1 | -0/+5 |
|\ \ \ \ \ | | | | | | | | | | | | | Reinstate media download on thumbnail request | ||||
| * | | | | | Reinstate media download on thumbnail request | Richard van der Hoff | 2018-01-12 | 1 | -0/+5 |
|/ / / / / | | | | | | | | | | | | | | | | | | | | | We need to actually download the remote media when we get a request for a thumbnail. |