summary refs log tree commit diff
Commit message (Collapse)AuthorAgeFilesLines
* Optimize how we calculate `likely_domains` during backfill (#13575)Eric Eastwood2022-08-305-70/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimize how we calculate `likely_domains` during backfill because I've seen this take 17s in production just to `get_current_state` which is used to `get_domains_from_state` (see case [*2. Loading tons of events* in the `/messages` investigation issue](https://github.com/matrix-org/synapse/issues/13356)). There are 3 ways we currently calculate hosts that are in the room: 1. `get_current_state` -> `get_domains_from_state` - Used in `backfill` to calculate `likely_domains` and `/timestamp_to_event` because it was cargo-culted from `backfill` - This one is being eliminated in favor of `get_current_hosts_in_room` in this PR 🕳 1. `get_current_hosts_in_room` - Used for other federation things like sending read receipts and typing indicators 1. `get_hosts_in_room_at_events` - Used when pushing out events over federation to other servers in the `_process_event_queue_loop` Fix https://github.com/matrix-org/synapse/issues/13626 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh) ### Query performance #### Before The query from `get_current_state` sucks just because we have to get all 80k events. And we see almost the exact same performance locally trying to get all of these events (16s vs 17s): ``` synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 16035.612 ms (00:16.036) synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 4243.237 ms (00:04.243) ``` But what about `get_current_hosts_in_room`: When there is 8M rows in the `current_state_events` table, the previous query in `get_current_hosts_in_room` took 13s from complete freshness (when the events were first added). But takes 930ms after a Postgres restart or 390ms if running back to back to back. ```sh $ psql synapse synapse=# \timing on synapse=# SELECT COUNT(DISTINCT substring(state_key FROM '@[^:]*:(.*)$')) FROM current_state_events WHERE type = 'm.room.member' AND membership = 'join' AND room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 4130 (1 row) Time: 13181.598 ms (00:13.182) synapse=# SELECT COUNT(*) from current_state_events where room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 80814 synapse=# SELECT COUNT(*) from current_state_events; count --------- 8162847 synapse=# SELECT pg_size_pretty( pg_total_relation_size('current_state_events') ); pg_size_pretty ---------------- 4702 MB ``` #### After I'm not sure how long it takes from complete freshness as I only really get that opportunity once (maybe restarting computer but that's cumbersome) and it's not really relevant to normal operating times. Maybe you get closer to the fresh times the more access variability there is so that Postgres caches aren't as exact. Update: The longest I've seen this run for is 6.4s and 4.5s after a computer restart. After a Postgres restart, it takes 330ms and running back to back takes 260ms. ```sh $ psql synapse synapse=# \timing on Timing is on. synapse=# SELECT substring(c.state_key FROM '@[^:]*:(.*)$') as host FROM current_state_events c /* Get the depth of the event from the events table */ INNER JOIN events AS e USING (event_id) WHERE c.type = 'm.room.member' AND c.membership = 'join' AND c.room_id = '!OGEhHVWSdvArJzumhm:matrix.org' GROUP BY host ORDER BY min(e.depth) ASC; Time: 333.800 ms ``` #### Going further To improve things further we could add a `limit` parameter to `get_current_hosts_in_room`. Realistically, we don't need 4k domains to choose from because there is no way we're going to query that many before we a) probably get an answer or b) we give up. Another thing we can do is optimize the query to use a index skip scan: - https://wiki.postgresql.org/wiki/Loose_indexscan - Index Skip Scan, https://commitfest.postgresql.org/37/1741/ - https://www.timescale.com/blog/how-we-made-distinct-queries-up-to-8000x-faster-on-postgresql/
* Print complement failure results last (#13639)Richard van der Hoff2022-08-286-11/+31
| | | | | Since github always scrolls to the bottom of any test output, let's put the failed tests last and hide any successful packages.
* Improve documentation around user registration (#13640)Richard van der Hoff2022-08-264-103/+134
| | | | | Update a bunch of the documentation for user registration, add some cross links, etc.
* Generate missing configuration files at startup (#13615)Richard van der Hoff2022-08-263-12/+56
| | | | | | | | If things like the signing key file are missing, let's just try to generate them on startup. Again, this is useful for k8s-like deployments where we just want to generate keys on the first run.
* Update debhelper (#13594)Jörg Behrmann2022-08-267-41/+15
| | | | | | | | | | | | | | | | | | | | | | | | * Update debian packaging to debhelper version 12 Don't call dh_installinit anymore, because it has been deprecated, and use dh_installsystemd instead of dh_systemd_enable for the same reason. Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de> * Drop preinst script It was used for reasons of interactions of dh_systemd_start and dh_installinit, which have both be deprecated Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de> * Drop /etc/default file It was no longer being installed. * Remove debian/compat file This is managed by the control file nowadays
* Move the execution of the retention purge_jobs to the main worker (#13632)Brad Murray2022-08-262-4/+3
| | | | | Fixes #9927 Signed-off-by: Brad Murray brad@beeper.com
* Debian packaging: explicitly allocate a group for the system user (#13593)Jörg Behrmann2022-08-252-2/+8
| | | | | | | Otherwise the files of the synapse user are readable by the nobody user, which is unsafe. Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
* Support `registration_shared_secret` in a file (#13614)Richard van der Hoff2022-08-254-5/+92
| | | | A new `registration_shared_secret_path` option. This is kinda handy for k8s deployments and things.
* register_new_matrix_user: read server url from config (#13616)Richard van der Hoff2022-08-252-6/+52
| | | | Fixes https://github.com/matrix-org/synapse/issues/3672: `https://localhost:8448` is virtually never right.
* Update automation for incoming issues (#13629)Kat Gerasimova2022-08-251-4/+4
| | | GitHub appears to be deprecating addProjectNextItem by not allowing it to be used alongside projectV2 to get the project ID, so switching to using addProjectV2ItemById instead.
* Comment about a better future where we can get the state diff between two ↵Eric Eastwood2022-08-242-0/+9
| | | | | | | | | | events (#13586) Split off from https://github.com/matrix-org/synapse/pull/13561 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh)
* Rename `event_map` to `unpersisted_events` (#13603)David Robertson2022-08-242-32/+38
|
* Update `get_users_in_room` mis-use to get hosts with dedicated ↵Eric Eastwood2022-08-246-17/+31
| | | | | `get_current_hosts_in_room` (#13605) See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
* Directly lookup local membership instead of getting all members in a room ↵Eric Eastwood2022-08-248-17/+60
| | | | | first (`get_users_in_room` mis-use) (#13608) See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755
* When loading current ids, sort by `stream_id` to avoid incorrect overwrite ↵Eric Eastwood2022-08-242-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | and avoid errors caused by sorting alphabetical instance name which can be `null` (#13585) When loading current ids, sort by stream ID so that we don't want to overwrite the `current_position` of an instance to a lower stream ID than we're actually at ([discussion](https://github.com/matrix-org/synapse/pull/13585#discussion_r951795379)). Previously, it sorted alphabetically by instance name which can be `null` and throw errors but more importantly, accomplishes nothing. Fixes the following startup error which is why I started looking into this area: ``` $ poetry run synapse_homeserver --config-path homeserver.yaml **************************************************************** Error during initialisation: '<' not supported between instances of 'NoneType' and 'str' There may be more information in the logs. **************************************************************** ``` Somehow my database ended up looking like the following, notice the `instance_name` is `null` in the db, and we can't sort `NoneType` things. Another question is why do we see the `instance_name` as `null` sometimes instead of `master` in monolith mode? ``` $ psql synapse synapse=# SELECT * FROM stream_positions; stream_name | instance_name | stream_id -----------------+---------------+----------- account_data | master | 1242 events | master | 1787 to_device | master | 58 presence_stream | master | 485638 receipts | master | 341 backfill | master | -139106 (6 rows) synapse=# SELECT instance_name, stream_id FROM receipts_linearized; instance_name | stream_id ---------------+----------- | 211 | 3 | 4 | 212 | 213 | 224 | 228 | 164 | 313 | 253 | 38 | 321 | 324 | 189 | 192 | 193 | 194 | 195 | 197 | 198 | 275 | 79 | 339 | 340 | 82 | 341 | 84 | 85 | 91 | 119 ```
* Use dedicated `get_local_users_in_room` to find local users when calculating ↵Eric Eastwood2022-08-242-6/+4
| | | | | | | `join_authorised_via_users_server` of a `/make_join` request (#13606) Use dedicated `get_local_users_in_room` to find local users when calculating `join_authorised_via_users_server` ("the authorising user for joining a restricted room") of a `/make_join` request. Found while working on https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 but it's not related.
* First draft of triage_labelled action (#13612)Andy Balaam2022-08-241-0/+44
|
* Add experimental configuration option to allow disabling legacy Prometheus ↵reivilibre2022-08-249-21/+150
| | | | | metric names. (#13540) Co-authored-by: David Robertson <davidr@element.io>
* Add GitHub automation for new issues (#13610)Kat Gerasimova2022-08-241-0/+28
| | | Set up automation to move newly opened issues in GitHub to the issue triage board.
* Rewrite get push actions queries (#13597)Nick Mills-Barrett2022-08-242-160/+69
|
* Faster Room Joins: fix `/make_knock` blocking indefinitely when the room in ↵reivilibre2022-08-242-0/+12
| | | | | question is a partial-stated room. (#13583) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child ↵Eric Eastwood2022-08-235-3/+47
| | | | | | | | | concurrent calls (#13588) Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child concurrent calls because I've see `_check_sigs_and_hash_and_fetch` take [10.41s to process 100 events](https://github.com/matrix-org/synapse/issues/13587) Fix https://github.com/matrix-org/synapse/issues/13587 Part of https://github.com/matrix-org/synapse/issues/13356
* Write about the chain cover a little. (#13602)David Robertson2022-08-232-9/+43
| | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* Speed up `@cachedList` (#13591)Erik Johnston2022-08-234-141/+298
| | | | | | | | | This speeds things up by ~2x. The vast majority of the time is now spent in `LruCache` moving things around the linked lists. We do this via two things: 1. Don't create a deferred per-key during bulk set operations in `DeferredCache`. Instead, only create them if a subsequent caller asks for the key. 2. Add a bulk lookup API to `DeferredCache` rather than use a loop.
* Fix regression caused by #13573 (#13600)Erik Johnston2022-08-232-4/+7
| | | Broke in #13573.
* Update openid.md (#13568)nilsKr32022-08-231-1/+3
| | | Linking the help article may prevent confusion regarding the creation of the necessary rule using auth0.
* Merge tag 'v1.66.0rc1' into developDavid Robertson2022-08-2359-291/+185
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Synapse 1.66.0rc1 (2022-08-23) ============================== This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\#13188](https://github.com/matrix-org/synapse/issues/13188), [\#13563](https://github.com/matrix-org/synapse/issues/13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\#13503](https://github.com/matrix-org/synapse/issues/13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](https://github.com/matrix-org/matrix-spec-proposals/pull/3852). ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](https://github.com/matrix-org/matrix-spec-proposals/pull/2716). ([\#13551](https://github.com/matrix-org/synapse/issues/13551)) - Add support for compression to federation responses. ([\#13537](https://github.com/matrix-org/synapse/issues/13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\#13522](https://github.com/matrix-org/synapse/issues/13522), [\#13547](https://github.com/matrix-org/synapse/issues/13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\#13514](https://github.com/matrix-org/synapse/issues/13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\#13525](https://github.com/matrix-org/synapse/issues/13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\#13566](https://github.com/matrix-org/synapse/issues/13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\#13574](https://github.com/matrix-org/synapse/issues/13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\#13472](https://github.com/matrix-org/synapse/issues/13472)) - Tidy up Synapse's README. ([\#13491](https://github.com/matrix-org/synapse/issues/13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\#13492](https://github.com/matrix-org/synapse/issues/13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\#13497](https://github.com/matrix-org/synapse/issues/13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\#13515](https://github.com/matrix-org/synapse/issues/13515)) - Add missing links in `user_consent` section of configuration manual. ([\#13536](https://github.com/matrix-org/synapse/issues/13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\#13538](https://github.com/matrix-org/synapse/issues/13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\#13459](https://github.com/matrix-org/synapse/issues/13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\#13477](https://github.com/matrix-org/synapse/issues/13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\#13531](https://github.com/matrix-org/synapse/issues/13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\#13453](https://github.com/matrix-org/synapse/issues/13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\#13489](https://github.com/matrix-org/synapse/issues/13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\#13499](https://github.com/matrix-org/synapse/issues/13499), [\#13554](https://github.com/matrix-org/synapse/issues/13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\#13533](https://github.com/matrix-org/synapse/issues/13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\#13534](https://github.com/matrix-org/synapse/issues/13534), [\#13541](https://github.com/matrix-org/synapse/issues/13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\#13535](https://github.com/matrix-org/synapse/issues/13535), [\#13584](https://github.com/matrix-org/synapse/issues/13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\#13544](https://github.com/matrix-org/synapse/issues/13544)) - Update metrics to track `/messages` response time by room size. ([\#13545](https://github.com/matrix-org/synapse/issues/13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\#13024](https://github.com/matrix-org/synapse/issues/13024)) - Clean-up tests for notifications. ([\#13471](https://github.com/matrix-org/synapse/issues/13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\#13474](https://github.com/matrix-org/synapse/issues/13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\#13479](https://github.com/matrix-org/synapse/issues/13479), [\#13488](https://github.com/matrix-org/synapse/issues/13488)) - Add comments about how event push actions are rotated. ([\#13485](https://github.com/matrix-org/synapse/issues/13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\#13493](https://github.com/matrix-org/synapse/issues/13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\#13502](https://github.com/matrix-org/synapse/issues/13502)) - Reduce the number of tests using legacy TCP replication. ([\#13543](https://github.com/matrix-org/synapse/issues/13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\#13558](https://github.com/matrix-org/synapse/issues/13558))
| * Remove manually-added changelog v1.66.0rc1David Robertson2022-08-231-1/+0
| |
| * Drop support for delegating email validation, round 2 (#13596)David Robertson2022-08-2313-245/+108
| |
| * Update changelogDavid Robertson2022-08-231-5/+5
| |
| * Adjust changelogDavid Robertson2022-08-231-18/+26
| |
| * Describe changes to admin API in 1.66David Robertson2022-08-231-0/+2
| | | | | | | | Cross-ref #13525
| * 1.66.0rc1David Robertson2022-08-2347-46/+68
| |
* | Speed up fetching large numbers of push rules (#13592)Erik Johnston2022-08-234-9/+2
| |
* | Cache user IDs instead of profile objects (#13573)Nick Mills-Barrett2022-08-235-54/+57
|/ | | The profile objects are never used and increase cache size significantly.
* Fix that sending server notices fail if avatar is `None` (#13566)Dirk Klimpel2022-08-234-4/+64
| | | Indroduced in #11846.
* Fix Prometheus metrics being negative (mixed up start/end) (#13584)Eric Eastwood2022-08-234-2/+22
| | | | | | | Fix: - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244
* `synapse.api.auth.Auth` cleanup: make permission-related methods use ↵Quentin Gliech2022-08-2226-208/+203
| | | | | | | | | `Requester` instead of the `UserID` (#13024) Part of #13019 This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it. It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.
* Remove redundant opentracing spans for `/sendToDevice` and `/keys/upload` ↵Andrew Morgan2022-08-223-4/+3
| | | | (#13574)
* MSC2716v4 room version - remove namespace from MSC2716 event content fields ↵Eric Eastwood2022-08-195-24/+25
| | | | | | | | (#13551) Complement PR: https://github.com/matrix-org/complement/pull/450 As suggested in https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r941444525
* Implement MSC3852: Expose `last_seen_user_agent` to users for their own ↵Andrew Morgan2022-08-198-2/+153
| | | | devices; also expose to Admin API (#13549)
* Register homeserver modules when creating test homeserver (#13558)Andrew Morgan2022-08-195-22/+15
|
* Reduce the number of tests using TCP replication. (#13543)Patrick Cloke2022-08-196-77/+36
| | | | Uses Redis replication in additional test cases (instead of TCP replication). A small step towards dropping TCP replication.
* Fix validation problem that occurs when a user tries to deactivate their ↵reivilibre2022-08-193-3/+19
| | | | account or change their password. (#13563)
* Add metrics to track `/messages` response time by room size (#13545)Eric Eastwood2022-08-182-2/+54
| | | | | Follow-up to https://github.com/matrix-org/synapse/pull/13533 Part of https://github.com/matrix-org/synapse/issues/13356
* Fix incorrect juggling of logging contexts in `_PerHostRatelimiter` (#13554)Sean Quah2022-08-182-10/+8
| | | | | | Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* Track number of hosts affected by the rate limiter (#13541)Eric Eastwood2022-08-182-4/+40
| | | | | | | Track number of hosts affected by the rate limiter so we can differentiate one really noisy homeserver from a general ratelimit tuning problem across the federation. Follow-up to https://github.com/matrix-org/synapse/pull/13534 Part of https://github.com/matrix-org/synapse/issues/13356
* Add support for compression to federation responses (#13537)Ayush Anand2022-08-183-2/+6
| | | | | | Closes #13415. Signed-off-by: Ayush Anand <iamayushanand@gmail.com>
* Avoid blocking lazy-loading `/sync`s during partial joins (#13477)Sean Quah2022-08-183-34/+244
| | | | | | | | | | | | | | | | | Use a state filter or accept partial state in a few places where we request state, to avoid blocking. To make lazy-loading `/sync`s work, we need to provide the memberships of event senders, which are not guaranteed to be in the room state. Instead we dig through auth events for memberships to present to clients. The auth events of an event are guaranteed to contain a passable membership event, otherwise the event would have been rejected. Note that this only covers the common code paths encountered during testing. There has been no exhaustive checking of all sync code paths. Fixes #13146. Signed-off-by: Sean Quah <seanq@matrix.org>
* Add metrics to track how the rate limiter is affecting requests ↵Eric Eastwood2022-08-172-8/+30
| | | | | | | (sleep/reject) (#13534) Related to https://github.com/matrix-org/synapse/pull/13499 Part of https://github.com/matrix-org/synapse/issues/13356
* Fix a bug in the `/event_reports` Admin API which meant that the total count ↵reivilibre2022-08-173-0/+34
| | | | | could be larger than the number of results you can actually query for. (#13525) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* A first pass at pruning the Synapse README (#13491)David Robertson2022-08-173-347/+194
|
* Fix breaking event sending due to bad push rule (#13547)Erik Johnston2022-08-172-1/+13
| | | | | | | Broke by #13522 It looks like we have some rules in the DB with a priority class less than 0 that don't override the base rules. Before these were just dropped, but #13522 made that a hard error.
* Reject non-strict types in Pydantic models (#13502)David Robertson2022-08-174-1/+440
|
* Fix a typo in docs and in some warnings (#13538)Antonin Loubiere2022-08-175-4/+5
|
* Add forgotten status to Room Details API (#13503)Dirk Klimpel2022-08-176-1/+101
|
* Add metrics to track rate limiter queue timing (#13544)Eric Eastwood2022-08-172-0/+31
|
* Time how long it takes us to do backfill processing (#13535)Eric Eastwood2022-08-173-16/+90
|
* Add specific metric to time long-running `/messages` requests (#13533)Eric Eastwood2022-08-172-0/+33
|
* Instrument the federation/backfill part of `/messages` (#13489)Eric Eastwood2022-08-1611-33/+220
| | | | | | | | | Instrument the federation/backfill part of `/messages` so it's easier to follow what's going on in Jaeger when viewing a trace. Split out from https://github.com/matrix-org/synapse/pull/13440 Follow-up from https://github.com/matrix-org/synapse/pull/13368 Part of https://github.com/matrix-org/synapse/issues/13356
* Merge branch 'master' into developAndrew Morgan2022-08-163-2/+14
|\
| * Note explicitly that #11365 was reverted in the 1.65 CHANGELOGAndrew Morgan2022-08-161-1/+1
| |
| * 1.65.0 v1.65.0Andrew Morgan2022-08-163-1/+13
| |
* | Refuse to start when `faster_joins` is enabled on a worker deployment (#13531)Sean Quah2022-08-162-0/+8
| | | | | | | | | | | | Synapse does not currently support faster room joins on deployments with workers. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Add missing links in `user_consent` section of configuration manual (#13536)Dirk Klimpel2022-08-162-2/+3
| | | | | | Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* | Faster room joins: make `/joined_members` block whilst the room is partial ↵reivilibre2022-08-164-1/+22
| | | | | | | | stated. (#13514)
* | Make push rules use proper structures. (#13522)Erik Johnston2022-08-168-333/+494
| | | | | | | | | | | | | | | | | | | | | | | | This improves load times for push rules: | Version | Time per user | Time for 1k users | | -------------------- | ------------- | ----------------- | | Before | 138 µs | 138ms | | Now (with custom) | 2.11 µs | 2.11ms | | Now (without custom) | 49.7 ns | 0.05 ms | This therefore has a large impact on send times for rooms with large numbers of local users in the room.
* | Use Pydantic to systematically validate a first batch of endpoints in ↵David Robertson2022-08-1510-92/+296
| | | | | | | | `synapse.rest.client.account`. (#13188)
* | Add a warning to retention documentation regarding the possibility of ↵Shay2022-08-153-2/+9
| | | | | | | | database corruption (#13497)
* | Instrument `FederationStateIdsServlet` - `/state_ids` (#13499)Eric Eastwood2022-08-155-2/+21
| | | | | | Instrument FederationStateIdsServlet - `/state_ids` so it's easier to follow what's going on in Jaeger when viewing a trace.
* | Revert "Update locked versions of mypy and mypy-zope (#13521)"David Robertson2022-08-157-60/+73
| | | | | | | | | | | | | | | | This reverts commit f383b9b3eceaa082d5ae690550fe41460b711779. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.
* | Clarifications for event push action processing. (#13485)Patrick Cloke2022-08-153-21/+35
| | | | | | | | | | | | | | | | * Clarifies comments. * Fixes an erroneous comment (about return type) added in #13455 (ec24813220f9d54108924dc04aecd24555277b99). * Clarifies the name of a variable. * Simplifies logic of pulling out the latest join for the requesting user.
* | Update locked versions of mypy and mypy-zope (#13521)David Robertson2022-08-157-73/+60
| |
* | Update grafana dashboardRichard van der Hoff2022-08-131-1805/+2695
| |
* | Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker ↵reivilibre2022-08-122-1/+2
| | | | | | | | image. (#13515)
* | Add `openssl` example for registration HMAC (#13472)James Barton2022-08-112-2/+20
| | | | | | Signed-off-by: James Barton <james@neodon.com>
* | Add note to `redaction_retention_period` documentation mentioning that event ↵Andrew Morgan2022-08-112-0/+5
| | | | | | | | purging runs at most every 5m (#13492)
* | Add viewport directive to HTML templates to optimise for mobile (#13493)Germain2022-08-1131-47/+140
| |
* | Merge branch 'release-v1.65' into developOlivier Wilkinson (reivilibre)2022-08-114-1/+17
|\|
| * 1.65.0rc2 v1.65.0rc2Olivier Wilkinson (reivilibre)2022-08-114-2/+16
| |
| * Revert 'Remove the unspecced field in the response. (#13365)' to give more ↵reivilibre2022-08-112-0/+2
| | | | | | | | time for clients to update. (#13501)
* | Update the rejected state of events during resync (#13459)Richard van der Hoff2022-08-114-9/+66
| | | | | | | | | | Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.
* | Use literals in place of `HTTPStatus` constants in tests (#13488)Dirk Klimpel2022-08-1012-447/+177
| | | | | | | | | | | | | | | | | | * Use literals in place of `HTTPStatus` constants in tests * newsfile * code style * code style
* | Add some miscellaneous comments around sync (#13474)Sean Quah2022-08-103-40/+81
| | | | | | | | | | | | | | | | Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Allow use of both `@trace` and `@tag_args` stacked on the same function (#13453)Eric Eastwood2022-08-093-56/+186
| | | | | | | | | | | | | | | | | | | | | | | | | | ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```
* | Use literals in place of `HTTPStatus` constants in tests (#13479)Dirk Klimpel2022-08-0912-141/+141
| | | | | | | | | | | | | | | | | | | | Replace - `HTTPStatus.NOT_FOUND` - `HTTPStatus.FORBIDDEN` - `HTTPStatus.UNAUTHORIZED` - `HTTPStatus.CONFLICT` - `HTTPStatus.CREATED` Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* | Merge branch 'release-v1.65' into developOlivier Wilkinson (reivilibre)2022-08-0952-51/+81
|\|
| * Fix changelog mistakeOlivier Wilkinson (reivilibre)2022-08-091-2/+1
| |
| * Tweak the changelog v1.65.0rc1Olivier Wilkinson (reivilibre)2022-08-091-6/+6
| |
| * 1.65.0rc1Olivier Wilkinson (reivilibre)2022-08-0952-51/+82
| |
* | Strengthen tests about deleted old push actions. (#13471)Patrick Cloke2022-08-092-0/+16
|/
* Make the configuration for the cache clearer (#13481)Dirk Klimpel2022-08-092-4/+6
|
* Update matrix-synapse-ldap3 version in lockfile to v0.2.2. (#13470)Shay2022-08-082-12/+14
|
* Use literals in place of `HTTPStatus` constants in tests (#13469)Dirk Klimpel2022-08-0813-331/+329
|
* Correct a misnamed argument in state res v2 (#13467)David Robertson2022-08-082-6/+7
| | | | | | | | | | | In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.
* Support stable identifiers for MSC2285: private read receipts. (#13273)Šimon Brandner2022-08-0514-94/+246
| | | | | This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.
* Use literals in place of `HTTPStatus` constants in tests (#13463)Dirk Klimpel2022-08-0518-191/+172
|
* Mark token-authenticaticated-registration API as not-experimental (#11897)Julian-Samuel Gebühr2022-08-052-3/+4
|
* Update module API "update room membership" method to allow for remote joins ↵Matt C2022-08-053-4/+34
| | | | | | (#13441) Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Add comments about how event push actions are stored. (#13445)Erik Johnston2022-08-042-0/+62
|
* Fix `@tag_args` being off-by-one (ahead) (#13452)Eric Eastwood2022-08-042-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix @tag_args being off-by-one (ahead) Example: ``` argspec.args=[ 'self', 'room_id' ] args=( <synapse.storage.databases.main.DataStore object at 0x10d0b8d00>, '!HBehERstyQBxyJDLfR:my.synapse.server' ) ``` --- The previous logic was also flawed and we can end up in a situation like this: ``` argspec.args=['self', 'dest', 'room_id', 'limit', 'extremities'] args=(<synapse.federation.federation_client.FederationClient object at 0x7f1651c18160>, 'hs1', '!jAEHKIubyIfuLOdfpY:hs1') ``` From this source: ```py async def backfill( self, dest: str, room_id: str, limit: int, extremities: Collection[str] ) -> Optional[List[EventBase]]: ``` And this usage: ```py events = await self._federation_client.backfill( dest, room_id, limit=limit, extremities=extremities ) ``` which would previously cause this error: ``` synapse_main | 2022-08-04 06:13:12,051 - synapse.handlers.federation - 424 - ERROR - GET-5 - Failed to backfill from hs1 because tuple index out of range synapse_main | Traceback (most recent call last): synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation.py", line 392, in try_backfill synapse_main | await self._federation_event_handler.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation_event.py", line 593, in backfill synapse_main | events = await self._federation_client.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 827, in _wrapper synapse_main | with wrapping_logic(func, *args, **kwargs): synapse_main | File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__ synapse_main | return next(self.gen) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 922, in _wrapping_logic synapse_main | set_attribute("ARG_" + arg, str(args[i + 1])) # type: ignore[index] synapse_main | IndexError: tuple index out of range ```
* Improve comments (& avoid a duplicate query) in push actions processing. ↵Patrick Cloke2022-08-042-124/+159
| | | | | | | | | (#13455) * Adds docstrings and inline comments. * Formats SQL queries using triple quoted strings. * Minor formatting changes. * Avoid fetching `event_push_summary_stream_ordering` multiple times in the same transactions.
* Update type of `EventContext.rejected` (#13460)Richard van der Hoff2022-08-043-5/+5
|
* Faster Room Joins: prevent Synapse from answering federated join requests ↵reivilibre2022-08-043-0/+35
| | | | for a room which it has not fully joined yet. (#13416)
* Optimise async get event lookups (#13435)Nick Mills-Barrett2022-08-044-8/+87
| | | | | | Still maintains local in memory lookup optimisation, but does any external lookup as part of the deferred that prevents duplicate lookups for the same event at once. This makes the assumption that fetching from an external cache is a non-zero load operation.
* Update some outdated information on `sso_mapping_providers.md` (#13449)Dirk Klimpel2022-08-042-6/+9
|
* Fix return value in example on `password_auth_provider_callbacks.md` (#13450)Dirk Klimpel2022-08-042-2/+3
| | | | | Fixes: #12534 Signed-off-by: Dirk Klimpel <dirk@klimpel.org>
* synapse-workers docker: copy nginx and redis in from base images (#13447)Richard van der Hoff2022-08-043-36/+60
| | | Part of my continuing quest to make the docker images build quicker: copy nginx and redis in from base docker images, rather than apt installing each time.
* Add module API method to create a room (#13429)Matt C2022-08-043-0/+103
| | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix rooms not being properly excluded from incremental sync (#13408)Brendan Abolivier2022-08-043-10/+37
|
* Add some tracing spans to give insight into local joins (#13439)Shay2022-08-033-33/+40
|
* Instrument `/messages` for understandable traces in Jaeger (#13368)Eric Eastwood2022-08-0311-1/+32
| | | | | | In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work
* Return 404 or member list when getting joined_members after leaving (#13374)andrew do2022-08-033-2/+20
| | | | | | Signed-off-by: Andrew Doh <andrewddo@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <andrewm@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Install cryptography build dependencies in requirements image. (#13372)Jasper Spaans2022-08-032-1/+3
|
* Improve documentation on becoming server admin (#13230)jejo862022-08-032-1/+3
| | | | | | | | | | | | | | | | | | | | | | | * Improved section regarding server admin Added steps describing how to elevate an existing user to administrator by manipulating a `postgres` database. Signed-off-by: jejo86 28619134+jejo86@users.noreply.github.com * Improved section regarding server admin * Reference database settings Add instructions to check database settings to find out the database name, instead of listing all available PostgreSQL databases. * Add suggestions from PR conversation Replace config filename `homeserver.yaml`. with "config file". Remove instructions to switch to `postgres` user. Add instructions how to connect to SQLite database. * Update changelog.d/13230.doc Co-authored-by: reivilibre <olivier@librepush.net>
* Update doc for setting `macaroon_secret_key` (#13443)Dirk Klimpel2022-08-032-3/+8
| | | | | * Update doc for setting `macaroon_secret_key` * newsfile
* Rename `RateLimitConfig` to `RatelimitSettings` (#13442)Dirk Klimpel2022-08-035-29/+30
|
* Add module API method to resolve a room alias to a room ID (#13428)Matt C2022-08-033-0/+44
| | | | Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Remove 'Contents' section from the Configuration Manual (#13438)Dirk Klimpel2022-08-032-43/+1
| | | Fixes: #13053
* Fix wrong headline for `url_preview_accept_language` in docs (#13437)Dirk Klimpel2022-08-032-1/+2
| | | Fixes: #13433
* Add a `merge-back` command to the release script, which automates merging ↵reivilibre2022-08-022-0/+77
| | | | the correct branches after a release. (#13393)
* Fix error when out of servers to sync partial state with (#13432)Sean Quah2022-08-022-2/+4
| | | | | so that we raise the intended error instead. Signed-off-by: Sean Quah <seanq@matrix.org>
* Merge branch 'master' into developOlivier Wilkinson (reivilibre)2022-08-024-2/+33
|\
| * Mention specific version in rc2 notes v1.64.0Olivier Wilkinson (reivilibre)2022-08-021-1/+1
| |
| * Add upgrade notesOlivier Wilkinson (reivilibre)2022-08-021-0/+10
| |
| * 1.64.0Olivier Wilkinson (reivilibre)2022-08-023-1/+22
| |
* | Faster Room Joins: don't leave a stuck room partial state flag if the join ↵reivilibre2022-08-013-15/+140
| | | | | | | | fails. (#13403)
* | Fix missing import in `federation_event` handler. (#13431)Patrick Cloke2022-08-012-0/+2
| | | | | | | | #13404 removed an import of `Optional` which was still needed due to #13413 added more usages.
* | Refactor `_resolve_state_at_missing_prevs` to return an `EventContext` (#13404)Sean Quah2022-08-015-86/+68
| | | | | | | | | | | | | | | | Previously, `_resolve_state_at_missing_prevs` returned the resolved state before an event and a partial state flag. These were unwieldy to carry around would only ever be used to build an event context. Build the event context directly instead. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Enable Complement CI tests in the 'latest deps' test run. (#13213)reivilibre2022-08-014-5/+58
| | | | | | Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
* | Re-enable running Complement tests against Synapse with workers. (#13420)reivilibre2022-08-012-24/+4
| |
* | Faster joins: fix rejected events becoming un-rejected during resync (#13413)Richard van der Hoff2022-08-013-6/+32
| | | | | | | | | | Make sure that we re-check the auth rules during state resync, otherwise rejected events get un-rejected.
* | Merge tag 'v1.64.0rc2' into developRichard van der Hoff2022-07-2914-268/+438
|\| | | | | | | | | | | | | Synapse 1.64.0rc2 (2022-07-29) ============================== This RC reintroduces support for `account_threepid_delegates.email`, which was removed in 1.64.0rc1. It remains deprecated and will be removed altogether in a future release. ([\#13406](https://github.com/matrix-org/synapse/issues/13406))
| * update changelog v1.64.0rc2Richard van der Hoff2022-07-291-5/+2
| |
| * 1.64.0rc2Richard van der Hoff2022-07-294-2/+16
| |
| * Revert "Drop support for delegating email validation (#13192)" (#13406)3nprob2022-07-2912-266/+425
| | | | | | | | | | Reverts commit fa71bb18b527d1a3e2629b48640ea67fff2f8c59, and tweaks documentation. Signed-off-by: 3nprob <git@3n.anonaddy.com>
* | Explicitly mention which resources support compression in the config guide ↵Brendan Abolivier2022-07-292-1/+3
| | | | | | | | (#13221)
* | Use stable prefixes for MSC3827: filtering of `/publicRooms` by room type ↵Šimon Brandner2022-07-277-11/+8
| | | | | | | | | | | | (#13370) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
* | Add missing type hints for tests.unittest. (#13397)Patrick Cloke2022-07-276-52/+66
| |
* | Implement MSC3848: Introduce errcodes for specific event sending failures ↵Will Hunt2022-07-2711-36/+144
| | | | | | | | | | (#13343) Implements MSC3848
* | Make minor clarifications to the error messages given when we fail to join a ↵reivilibre2022-07-274-3/+17
| | | | | | | | room via any server. (#13160)
* | Fix `get_pdu` asking every remote destination even after it finds an event ↵Eric Eastwood2022-07-272-3/+4
| | | | | | | | (#13346)
* | Copy room serials before handling in `get_new_events_as` (#13392)Nick Mills-Barrett2022-07-262-3/+11
| |
* | Extend the release script to automatically push a new SyTest branch, rather ↵reivilibre2022-07-262-32/+55
| | | | | | | | | | than having that be a manual process. (#12978) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
* | Merge branch 'release-v1.64' into developOlivier Wilkinson (reivilibre)2022-07-2673-73/+95
|\|
| * Explain less-known term 'Implicit TLS' v1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-261-1/+1
| |
| * Tweak changelog in response to reviewOlivier Wilkinson (reivilibre)2022-07-261-9/+7
| |
| * Tweak changelogOlivier Wilkinson (reivilibre)2022-07-261-9/+11
| |
| * 1.64.0rc1Olivier Wilkinson (reivilibre)2022-07-2673-73/+95
| |
* | Remove the unspecced `room_id` field in the `/hierarchy` response. (#13365)Patrick Cloke2022-07-262-1/+1
| | | | | | | | | | | | | | | | | | The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.
* | Fix infinite loop in partial-state resync (#13353)Richard van der Hoff2022-07-263-8/+27
| | | | | | | | | | Make sure that we only pull out events from the db once they have no prev-events with partial state.
* | Faster room joins: avoid blocking when pulling events with missing prevs ↵Sean Quah2022-07-268-33/+124
| | | | | | | | | | | | | | | | | | (#13355) Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Remove unused argument for get_relations_for_event. (#13383)Patrick Cloke2022-07-263-9/+1
|/
* Disable autocorrect and autocaptialisation when entering username for SSO ↵Doug2022-07-262-1/+2
| | | | | registration. (#13350) When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).
* Update Caddy reverse proxy documentation (#13344)Matt Holt2022-07-252-42/+12
| | | | | Improve/simplify Caddy examples. Remove Caddy v1 (has long been EOL'ed) Signed-off-by: Matthew Holt <mholt@users.noreply.github.com>
* Support Implicit TLS for sending emails (#13317)Jan Schär2022-07-255-13/+99
| | | | | | | | | | Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>
* Additional fixes for opentracing type hints. (#13362)Patrick Cloke2022-07-252-2/+3
|
* Refactor presence so we can prune user in room caches (#13313)Erik Johnston2022-07-254-91/+109
| | | | | | | | See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.
* Backfill remote event fetched by MSC3030 so we can paginate from it later ↵Eric Eastwood2022-07-223-15/+94
| | | | | | | | | (#13205) Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848
* Update config_documentation.md (#13364)Richard van der Hoff2022-07-221-2/+2
| | | "changed in" goes before the example
* Update locked frozendict version to 2.3.3 (#13352)Sean Quah2022-07-223-18/+28
| | | frozendict 2.3.3 includes fixes for memory leaks that get triggered during `/sync`.
* Skip soft fail checks for rooms with partial state (#13354)Sean Quah2022-07-222-0/+11
| | | | | | | | | | | | When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>
* Remove old empty/redundant slaved stores. (#13349)Nick Mills-Barrett2022-07-2112-238/+63
|
* Make DictionaryCache have better expiry properties (#13292)Erik Johnston2022-07-217-43/+358
|
* Don't hold onto full state in state cache (#13324)Erik Johnston2022-07-212-15/+54
|
* Call out buildkit is required when building test docker images (#13338)Brendan Abolivier2022-07-214-0/+7
| | | Co-authored-by: David Robertson <davidr@element.io>
* Track DB txn times w/ two counters, not histogram (#13342)David Robertson2022-07-212-3/+6
|
* Add missing types to opentracing. (#13345)Patrick Cloke2022-07-2114-45/+83
| | | After this change `synapse.logging` is fully typed.
* Use cache store remove base slaved (#13329)Nick Mills-Barrett2022-07-2116-114/+39
| | | This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.
* Merge branch 'master' into developDavid Robertson2022-07-212-0/+9
|\
| * Document `rc_invites.per_issuer`, added in v1.63.David Teller2022-07-212-0/+9
| | | | | | | | | | | | | | Resolves #13330. Missed in #13125. Signed-off-by: David Teller <davidt@element.io>
* | Update `get_pdu` to return the original, pristine `EventBase` (#13320)Eric Eastwood2022-07-205-61/+233
| | | | | | | | | | | | | | | | | | | | | | | | Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](https://github.com/matrix-org/synapse/blob/7864f33e286dec22368dc0b11c06eebb1462a51e/synapse/federation/federation_client.py#L581-L594).
* | Validate federation destinations and log an error if server name is invalid. ↵Shay2022-07-203-2/+12
| | | | | | | | (#13318)
* | Merge remote-tracking branch 'origin/master' into developErik Johnston2022-07-205-2/+110
|\|
| * 1.63.1 v1.63.1Erik Johnston2022-07-204-2/+16
| |
| * Don't include appservice users when calculating push rules (#13332)Erik Johnston2022-07-203-0/+93
| | | | | | This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078
* | Fix spurious warning when fetching state after a missing prev event (#13258)Sean Quah2022-07-192-0/+4
| |
* | Add type annotations to `trace` decorator. (#13328)Patrick Cloke2022-07-1912-55/+102
| | | | | | | | Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.
* | Merge branch 'master' into developBrendan Abolivier2022-07-1911-32/+55
|\|
| * Improve precision on validation improvements v1.63.0Brendan Abolivier2022-07-191-1/+1
| |
| * 1.63.0Brendan Abolivier2022-07-194-4/+13
| |
| * Remove 'anonymised' from the phone home stats documentation (#13321)Andrew Morgan2022-07-1911-30/+44
| |
* | Reduce memory usage of state group cache (#13323)Erik Johnston2022-07-192-1/+3
| |
* | Stop building Ubuntu 21.10 (Impish Indri) which is end of life. (#13326)Patrick Cloke2022-07-192-1/+1
| |
* | Bash script for creating multiple stream writers (#13271)villepeh2022-07-193-1/+147
| | | | | | | | | | Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.
* | Add notes when config options were changed to config documentation (#13314)Jörg Behrmann2022-07-192-0/+6
| | | | | | | | Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>
* | Rate limit joins per-room (#13276)David Robertson2022-07-1918-15/+498
| |
* | Safe async event cache (#13308)Nick Mills-Barrett2022-07-198-21/+102
| | | | | | | | | | | | | | | | Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).
* | Increase batch size of `bulk_get_push_rules` and ↵Shay2022-07-183-1/+3
| | | | | | | | `_get_joined_profiles_from_event_ids`. (#13300)
* | Improve performance of query ` _get_subset_users_in_room_with_profiles` (#13299)Shay2022-07-182-1/+2
| |
* | Fix overcounting of pushers when they are replaced (#13296)Sean Quah2022-07-182-11/+17
| | | | | | | | Signed-off-by: Sean Quah <seanq@matrix.org>
* | Up the dependency on canonicaljson to ^1.5.0 (#13172)Brendan Abolivier2022-07-183-2/+5
| | | | | | Co-authored-by: David Robertson <davidr@element.io>
* | Prevent #3679 from appearing in blame results (#13311)Andrew Morgan2022-07-182-0/+14
| |
* | Revert "Make all `process_replication_rows` methods async (#13304)" (#13312)Erik Johnston2022-07-1814-40/+25
| | | | | | This reverts commit 5d4028f217f178fcd384d5bfddd92225b4e78c51.
* | Don't pull out full state when sending dummy events (#13310)Erik Johnston2022-07-182-7/+2
| |
* | Use READ COMMITTED isolation level when purging rooms (#12942)Nick Mills-Barrett2022-07-182-2/+32
| | | | | | | | | | To close: #10294. Signed off by Nick @ Beeper.
* | Update expected DB query count when creating a room (#13307)Andrew Morgan2022-07-182-2/+3
| |
* | Don't pull out the full state when creating an event (#13281)Erik Johnston2022-07-183-2/+10
| |
* | Remove unnecessary `json.dumps` from tests (#13303)Dirk Klimpel2022-07-1713-200/+143
| |
* | Make all `process_replication_rows` methods async (#13304)Nick Mills-Barrett2022-07-1714-25/+40
| | | | | | | | | | More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)
* | Use HTTPStatus constants in place of literals in tests. (#13297)Dirk Klimpel2022-07-159-238/+308
| |
* | Provide more info why we don't have any thumbnails to serve (#13038)Eric Eastwood2022-07-154-17/+129
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.
* | Use and recommend poetry 1.1.14, up from 1.1.12 (#13285)David Robertson2022-07-155-4/+30
| |
* | Don't pull out the full state when storing state (#13274)Erik Johnston2022-07-156-71/+132
| |
* | Use a real room in the notification rotation tests. (#13260)Patrick Cloke2022-07-152-116/+80
| | | | | | | | Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.
* | Use state before join to determine if we `_should_perform_remote_join` (#13270)David Robertson2022-07-154-24/+35
| | | | | | Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
* | Update locked frozendict version to 2.3.2 (#13284)Sean Quah2022-07-152-18/+19
| | | | | | | | | | | | | | | | `frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by: Sean Quah <seanq@matrix.org>
* | Bg update to populate new `events` table columns (#13215)Richard van der Hoff2022-07-153-0/+135
| | | | | | | | | | These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.
* | Fix a bug which could lead to incorrect state (#13278)Erik Johnston2022-07-154-7/+58
| | | | | | | | | | There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.
* | Docker: copy postgres from base image (#13279)Richard van der Hoff2022-07-153-34/+51
| | | | | | | | | | | | When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.
* | Async get event cache prep (#13242)Nick Mills-Barrett2022-07-1511-26/+86
| | | | | | | | | | Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)
* | Federation Sender & Appservice Pusher Stream Optimisations (#13251)Nick Mills-Barrett2022-07-157-87/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | * Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.
* | Rip out auth-event reconciliation code (#12943)Richard van der Hoff2022-07-146-375/+88
| | | | | | | | | | | | | | There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.
* | CHANGES.md: fix link to upgrade notesRichard van der Hoff2022-07-141-1/+1
| |
* | Don't pull out state in `compute_event_context` for unconflicted state (#13267)Erik Johnston2022-07-147-136/+95
| |
* | Allow rate limiters to passively record actions they cannot limit (#13253)David Robertson2022-07-133-12/+157
| | | | | | Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* | Notifier: accept callbacks to fire on room joins (#13254)David Robertson2022-07-132-0/+19
| |
* | Call the v2 identity service `/3pid/unbind` endpoint, rather than v1. (#13240)Jacek Kuśnierz2022-07-132-2/+3
| | | | | | | | | | | | | | | | | | | | | | * Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc
* | Add support for room version 10 (#13220)Shay2022-07-134-1/+100
| |
* | Document advising against publicly exposing the Admin API and provide a ↵jejo862022-07-132-0/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | usage example (#13231) * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Optimise room creation event lookups part 2 (#13224)Nick Mills-Barrett2022-07-134-19/+78
| |
* | Reduce duplicate code in receipts servlets. (#13198)Patrick Cloke2022-07-133-44/+33
| |
* | Add prometheus counters for content types other than events (#13175)Brad Murray2022-07-132-0/+15
| |
* | Drop unused tables from groups/communities. (#12967)Patrick Cloke2022-07-134-19/+36
| | | | | | | | These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.
* | Do not fail build if complement with workers fails. (#13266)Patrick Cloke2022-07-132-3/+25
| |
* | Fix "add user" admin api error when request contains a "msisdn" threepid ↵Thomas Weston2022-07-133-0/+37
| | | | | | | | | | | | (#13263) Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
* | Inline URL preview documentation. (#13261)Patrick Cloke2022-07-127-74/+62
| | | | | | Inline URL preview documentation near the implementation.
* | Drop unused table `event_reference_hashes` (#13218)Richard van der Hoff2022-07-122-0/+18
| | | | | | This is unused since Synapse 1.60.0 (#12679). It's time for it to go.
* | Drop support for calling `/_matrix/client/v3/account/3pid/bind` without an ↵Jacek Kuśnierz2022-07-123-26/+11
| | | | | | | | | | | | | | `id_access_token` (#13239) Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de
* | Rename test case method to `add_hashes_and_signatures_from_other_server` ↵David Robertson2022-07-127-18/+14
| | | | | | | | (#13255)
* | Drop support for delegating email validation (#13192)Richard van der Hoff2022-07-1213-253/+110
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too
* | Log the stack when waiting for an entire room to be un-partial stated (#13257)Sean Quah2022-07-122-0/+2
| | | | | | | | The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.
* | Add info about configuration in the url preview docs (#13233)Shay2022-07-122-0/+3
| | | | | | Cross-link doc pages for easier navigation.
* | Make the AS login method call `Auth.get_user_by_req` for checking the AS ↵Quentin Gliech2022-07-122-2/+9
| | | | | | | | | | | | | | | | token. (#13094) This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>
* | expose whether a room is a space in the Admin API (#13208)andrew do2022-07-124-13/+36
|/
* Update changelog once more v1.63.0rc1Sean Quah2022-07-121-2/+2
|
* Reorder and tidy up changelogSean Quah2022-07-121-29/+25
|
* 1.63.0rc1Sean Quah2022-07-1254-54/+87
|
* Don't pull out the full state when calculating push actions (#13078)Erik Johnston2022-07-117-344/+164
|
* Add a sample bash script to docs for creating multiple worker files (#13032)villepeh2022-07-112-0/+32
| | | Signed-off-by: Ville Petteri Huh.
* Reduce event lookups during room creation by passing known event IDs (#13210)Nick Mills-Barrett2022-07-113-2/+32
| | | | | | | | Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)
* Uniformize spam-checker API, part 5: expand other spam-checker callbacks to ↵David Teller2022-07-1112-60/+426
| | | | | | return `Tuple[Codes, dict]` (#13044) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
* Fix to-device messages not being sent to MSC3202-enabled appservices (#13235)Travis Ralston2022-07-112-2/+4
| | | | The field name was simply incorrect, leading to errors.
* Remove delay when rotating event push actions (#13211)Erik Johnston2022-07-112-3/+2
| | | | We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
* Document the 'databases' homeserver config option (#13212)Andrew Morgan2022-07-112-0/+93
|
* Add a `filter_event_for_clients_with_state` function (#13222)Erik Johnston2022-07-113-138/+400
|
* Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236)Travis Ralston2022-07-112-1/+4
| | | | | | | | | | | * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again
* Ensure portdb selects _all_ rows with negative rowids (#13226)David Robertson2022-07-112-1/+5
|
* editorconfig: add max_line_length for Python files (#13228)Sumner Evans2022-07-082-0/+2
| | | | | | See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>
* Fix notification count after a highlighted message (#13223)Erik Johnston2022-07-083-3/+16
| | | | | Fixes #13196 Broke by #13005
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-11 14:22:44 +0000