1 files changed, 8 insertions, 8 deletions
diff --git a/synapse/handlers/room.py b/synapse/handlers/room.py
index 53569e5212..b7d64a2f5a 100644
--- a/synapse/handlers/room.py
+++ b/synapse/handlers/room.py
@@ -469,14 +469,14 @@ class RoomCreationHandler:
(EventTypes.PowerLevels, ""),
]
- # If the old room was a space, copy over the room type and the rooms in
- # the space.
- if (
- old_room_create_event.content.get(EventContentFields.ROOM_TYPE)
- == RoomTypes.SPACE
- ):
- creation_content[EventContentFields.ROOM_TYPE] = RoomTypes.SPACE
- types_to_copy.append((EventTypes.SpaceChild, None))
+ # Copy the room type as per MSC3818.
+ room_type = old_room_create_event.content.get(EventContentFields.ROOM_TYPE)
+ if room_type is not None:
+ creation_content[EventContentFields.ROOM_TYPE] = room_type
+
+ # If the old room was a space, copy over the rooms in the space.
+ if room_type == RoomTypes.SPACE:
+ types_to_copy.append((EventTypes.SpaceChild, None))
old_room_state_ids = await self.store.get_filtered_current_state_ids(
old_room_id, StateFilter.from_types(types_to_copy)
|