diff options
Diffstat (limited to '')
-rw-r--r-- | changelog.d/9265.bugfix | 1 | ||||
-rw-r--r-- | synapse/handlers/auth.py | 10 |
2 files changed, 1 insertions, 10 deletions
diff --git a/changelog.d/9265.bugfix b/changelog.d/9265.bugfix new file mode 100644 index 0000000000..34f7bd8ddd --- /dev/null +++ b/changelog.d/9265.bugfix @@ -0,0 +1 @@ +Prevent password hashes from getting dropped if a client failed threepid validation during a User Interactive Auth stage. Removes a workaround for an ancient bug in Riot Web <v0.7.4. \ No newline at end of file diff --git a/synapse/handlers/auth.py b/synapse/handlers/auth.py index 0e98db22b3..3127357964 100644 --- a/synapse/handlers/auth.py +++ b/synapse/handlers/auth.py @@ -567,16 +567,6 @@ class AuthHandler(BaseHandler): session.session_id, login_type, result ) except LoginError as e: - if login_type == LoginType.EMAIL_IDENTITY: - # riot used to have a bug where it would request a new - # validation token (thus sending a new email) each time it - # got a 401 with a 'flows' field. - # (https://github.com/vector-im/vector-web/issues/2447). - # - # Grandfather in the old behaviour for now to avoid - # breaking old riot deployments. - raise - # this step failed. Merge the error dict into the response # so that the client can have another go. errordict = e.error_dict() |