summary refs log tree commit diff
path: root/webclient/room/room-directive.js
diff options
context:
space:
mode:
authorMatthew Hodgson <matthew@matrix.org>2014-09-23 23:25:56 +0100
committerMatthew Hodgson <matthew@matrix.org>2014-09-23 23:25:56 +0100
commit53ae5bce1343856e40d57b91561afb9fcd8196f6 (patch)
tree9b2c0471e55ea22716d38e6953c69f77a207f16c /webclient/room/room-directive.js
parentfix yet more room id leak disasters (diff)
downloadsynapse-53ae5bce1343856e40d57b91561afb9fcd8196f6.tar.xz
comment-convo with kegan
Diffstat (limited to '')
-rw-r--r--webclient/room/room-directive.js11
1 files changed, 10 insertions, 1 deletions
diff --git a/webclient/room/room-directive.js b/webclient/room/room-directive.js
index d5108b5f1c..1d02a94c39 100644
--- a/webclient/room/room-directive.js
+++ b/webclient/room/room-directive.js
@@ -52,12 +52,21 @@ angular.module('RoomController')
                 // console.log("targetIndex: " + targetIndex + ", 
                 // text=" + text);
                                     
-                // FIXME: use the correct regexp to recognise userIDs
+                // FIXME: use the correct regexp to recognise userIDs --M
+                //
                 // XXX: I don't really know what the point of this is. You
                 // WANT to match freeform text given you want to match display
                 // names AND user IDs. Surely you just want to get the last
                 // word out of the input text and that's that?
                 // Am I missing something here? -- Kegan
+                //
+                // You're not missing anything - my point was that we should
+                // explicitly define the syntax for user IDs /somewhere/.
+                // Meanwhile as long as the delimeters are well defined, we
+                // could just pick "the last word".  But to know what the
+                // correct delimeters are, we probably do need a formal
+                // syntax for user IDs to refer to... --Matthew
+                
                 var search = /@?([a-zA-Z0-9_\-:\.]+)$/.exec(text);
 
                 if (targetIndex === 0) { // 0 is always the original text