diff --git a/tests/api/test_filtering.py b/tests/api/test_filtering.py
index 6c6a9ab4b4..222449baac 100644
--- a/tests/api/test_filtering.py
+++ b/tests/api/test_filtering.py
@@ -26,13 +26,15 @@ from synapse.api.errors import SynapseError
from synapse.api.filtering import Filter
from synapse.api.presence import UserPresenceState
from synapse.server import HomeServer
-from synapse.types import JsonDict
+from synapse.types import JsonDict, UserID
from synapse.util import Clock
from synapse.util.frozenutils import freeze
from tests import unittest
from tests.events.test_utils import MockEvent
+user_id = UserID.from_string("@test_user:test")
+user2_id = UserID.from_string("@test_user2:test")
user_localpart = "test_user"
@@ -437,7 +439,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
user_filter_json = {"presence": {"senders": ["@foo:bar"]}}
filter_id = self.get_success(
self.datastore.add_user_filter(
- user_localpart=user_localpart, user_filter=user_filter_json
+ user_id=user_id, user_filter=user_filter_json
)
)
presence_states = [
@@ -467,7 +469,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
filter_id = self.get_success(
self.datastore.add_user_filter(
- user_localpart=user_localpart + "2", user_filter=user_filter_json
+ user_id=user2_id, user_filter=user_filter_json
)
)
presence_states = [
@@ -495,7 +497,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
filter_id = self.get_success(
self.datastore.add_user_filter(
- user_localpart=user_localpart, user_filter=user_filter_json
+ user_id=user_id, user_filter=user_filter_json
)
)
event = MockEvent(sender="@foo:bar", type="m.room.topic", room_id="!foo:bar")
@@ -514,7 +516,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
user_filter_json = {"room": {"state": {"types": ["m.*"]}}}
filter_id = self.get_success(
self.datastore.add_user_filter(
- user_localpart=user_localpart, user_filter=user_filter_json
+ user_id=user_id, user_filter=user_filter_json
)
)
event = MockEvent(
@@ -598,7 +600,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
filter_id = self.get_success(
self.filtering.add_user_filter(
- user_localpart=user_localpart, user_filter=user_filter_json
+ user_id=user_id, user_filter=user_filter_json
)
)
@@ -619,7 +621,7 @@ class FilteringTestCase(unittest.HomeserverTestCase):
filter_id = self.get_success(
self.datastore.add_user_filter(
- user_localpart=user_localpart, user_filter=user_filter_json
+ user_id=user_id, user_filter=user_filter_json
)
)
diff --git a/tests/handlers/test_profile.py b/tests/handlers/test_profile.py
index 7c174782da..64a9a22afe 100644
--- a/tests/handlers/test_profile.py
+++ b/tests/handlers/test_profile.py
@@ -66,9 +66,7 @@ class ProfileTestCase(unittest.HomeserverTestCase):
self.handler = hs.get_profile_handler()
def test_get_my_name(self) -> None:
- self.get_success(
- self.store.set_profile_displayname(self.frank.localpart, "Frank")
- )
+ self.get_success(self.store.set_profile_displayname(self.frank, "Frank"))
displayname = self.get_success(self.handler.get_displayname(self.frank))
@@ -121,9 +119,7 @@ class ProfileTestCase(unittest.HomeserverTestCase):
self.hs.config.registration.enable_set_displayname = False
# Setting displayname for the first time is allowed
- self.get_success(
- self.store.set_profile_displayname(self.frank.localpart, "Frank")
- )
+ self.get_success(self.store.set_profile_displayname(self.frank, "Frank"))
self.assertEqual(
(
@@ -166,8 +162,14 @@ class ProfileTestCase(unittest.HomeserverTestCase):
)
def test_incoming_fed_query(self) -> None:
- self.get_success(self.store.create_profile("caroline"))
- self.get_success(self.store.set_profile_displayname("caroline", "Caroline"))
+ self.get_success(
+ self.store.create_profile(UserID.from_string("@caroline:test"))
+ )
+ self.get_success(
+ self.store.set_profile_displayname(
+ UserID.from_string("@caroline:test"), "Caroline"
+ )
+ )
response = self.get_success(
self.query_handlers["profile"](
@@ -183,9 +185,7 @@ class ProfileTestCase(unittest.HomeserverTestCase):
def test_get_my_avatar(self) -> None:
self.get_success(
- self.store.set_profile_avatar_url(
- self.frank.localpart, "http://my.server/me.png"
- )
+ self.store.set_profile_avatar_url(self.frank, "http://my.server/me.png")
)
avatar_url = self.get_success(self.handler.get_avatar_url(self.frank))
@@ -237,9 +237,7 @@ class ProfileTestCase(unittest.HomeserverTestCase):
# Setting displayname for the first time is allowed
self.get_success(
- self.store.set_profile_avatar_url(
- self.frank.localpart, "http://my.server/me.png"
- )
+ self.store.set_profile_avatar_url(self.frank, "http://my.server/me.png")
)
self.assertEqual(
diff --git a/tests/rest/admin/test_user.py b/tests/rest/admin/test_user.py
index b4241ceaf0..434bb56d44 100644
--- a/tests/rest/admin/test_user.py
+++ b/tests/rest/admin/test_user.py
@@ -802,9 +802,21 @@ class UsersListTestCase(unittest.HomeserverTestCase):
# Set avatar URL to all users, that no user has a NULL value to avoid
# different sort order between SQlite and PostreSQL
- self.get_success(self.store.set_profile_avatar_url("user1", "mxc://url3"))
- self.get_success(self.store.set_profile_avatar_url("user2", "mxc://url2"))
- self.get_success(self.store.set_profile_avatar_url("admin", "mxc://url1"))
+ self.get_success(
+ self.store.set_profile_avatar_url(
+ UserID.from_string("@user1:test"), "mxc://url3"
+ )
+ )
+ self.get_success(
+ self.store.set_profile_avatar_url(
+ UserID.from_string("@user2:test"), "mxc://url2"
+ )
+ )
+ self.get_success(
+ self.store.set_profile_avatar_url(
+ UserID.from_string("@admin:test"), "mxc://url1"
+ )
+ )
# order by default (name)
self._order_test([self.admin_user, user1, user2], None)
@@ -1127,7 +1139,9 @@ class DeactivateAccountTestCase(unittest.HomeserverTestCase):
# set attributes for user
self.get_success(
- self.store.set_profile_avatar_url("user", "mxc://servername/mediaid")
+ self.store.set_profile_avatar_url(
+ UserID.from_string("@user:test"), "mxc://servername/mediaid"
+ )
)
self.get_success(
self.store.user_add_threepid("@user:test", "email", "foo@bar.com", 0, 0)
@@ -1257,7 +1271,9 @@ class DeactivateAccountTestCase(unittest.HomeserverTestCase):
Reproduces #12257.
"""
# Patch `self.other_user` to have an empty string as their avatar.
- self.get_success(self.store.set_profile_avatar_url("user", ""))
+ self.get_success(
+ self.store.set_profile_avatar_url(UserID.from_string("@user:test"), "")
+ )
# Check we can still erase them.
channel = self.make_request(
@@ -2311,7 +2327,9 @@ class UserRestTestCase(unittest.HomeserverTestCase):
# set attributes for user
self.get_success(
- self.store.set_profile_avatar_url("user", "mxc://servername/mediaid")
+ self.store.set_profile_avatar_url(
+ UserID.from_string("@user:test"), "mxc://servername/mediaid"
+ )
)
self.get_success(
self.store.user_add_threepid("@user:test", "email", "foo@bar.com", 0, 0)
diff --git a/tests/rest/client/test_filter.py b/tests/rest/client/test_filter.py
index 91678abf13..9faa9de050 100644
--- a/tests/rest/client/test_filter.py
+++ b/tests/rest/client/test_filter.py
@@ -17,6 +17,7 @@ from twisted.test.proto_helpers import MemoryReactor
from synapse.api.errors import Codes
from synapse.rest.client import filter
from synapse.server import HomeServer
+from synapse.types import UserID
from synapse.util import Clock
from tests import unittest
@@ -76,7 +77,8 @@ class FilterTestCase(unittest.HomeserverTestCase):
def test_get_filter(self) -> None:
filter_id = self.get_success(
self.filtering.add_user_filter(
- user_localpart="apple", user_filter=self.EXAMPLE_FILTER
+ user_id=UserID.from_string("@apple:test"),
+ user_filter=self.EXAMPLE_FILTER,
)
)
self.reactor.advance(1)
diff --git a/tests/storage/test_main.py b/tests/storage/test_main.py
index 5806cb0e4b..27f450e22d 100644
--- a/tests/storage/test_main.py
+++ b/tests/storage/test_main.py
@@ -29,9 +29,9 @@ class DataStoreTestCase(unittest.HomeserverTestCase):
def test_get_users_paginate(self) -> None:
self.get_success(self.store.register_user(self.user.to_string(), "pass"))
- self.get_success(self.store.create_profile(self.user.localpart))
+ self.get_success(self.store.create_profile(self.user))
self.get_success(
- self.store.set_profile_displayname(self.user.localpart, self.displayname)
+ self.store.set_profile_displayname(self.user, self.displayname)
)
users, total = self.get_success(
diff --git a/tests/storage/test_profile.py b/tests/storage/test_profile.py
index a019d06e09..6ec34997ea 100644
--- a/tests/storage/test_profile.py
+++ b/tests/storage/test_profile.py
@@ -27,11 +27,9 @@ class ProfileStoreTestCase(unittest.HomeserverTestCase):
self.u_frank = UserID.from_string("@frank:test")
def test_displayname(self) -> None:
- self.get_success(self.store.create_profile(self.u_frank.localpart))
+ self.get_success(self.store.create_profile(self.u_frank))
- self.get_success(
- self.store.set_profile_displayname(self.u_frank.localpart, "Frank")
- )
+ self.get_success(self.store.set_profile_displayname(self.u_frank, "Frank"))
self.assertEqual(
"Frank",
@@ -43,21 +41,17 @@ class ProfileStoreTestCase(unittest.HomeserverTestCase):
)
# test set to None
- self.get_success(
- self.store.set_profile_displayname(self.u_frank.localpart, None)
- )
+ self.get_success(self.store.set_profile_displayname(self.u_frank, None))
self.assertIsNone(
self.get_success(self.store.get_profile_displayname(self.u_frank.localpart))
)
def test_avatar_url(self) -> None:
- self.get_success(self.store.create_profile(self.u_frank.localpart))
+ self.get_success(self.store.create_profile(self.u_frank))
self.get_success(
- self.store.set_profile_avatar_url(
- self.u_frank.localpart, "http://my.site/here"
- )
+ self.store.set_profile_avatar_url(self.u_frank, "http://my.site/here")
)
self.assertEqual(
@@ -70,9 +64,7 @@ class ProfileStoreTestCase(unittest.HomeserverTestCase):
)
# test set to None
- self.get_success(
- self.store.set_profile_avatar_url(self.u_frank.localpart, None)
- )
+ self.get_success(self.store.set_profile_avatar_url(self.u_frank, None))
self.assertIsNone(
self.get_success(self.store.get_profile_avatar_url(self.u_frank.localpart))
|
