diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2019-07-30 08:25:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-30 08:25:02 +0100 |
| commit | 8c97f6414cf322fc5b42a92ed0df2fb70bfab3fc (patch) | |
| tree | 93848385c7dfb304b761b60f3a11856664a66a38 /tests | |
| parent | Room Complexity Client Implementation (#5783) (diff) | |
| download | synapse-8c97f6414cf322fc5b42a92ed0df2fb70bfab3fc.tar.xz | |
Remove non-functional 'expire_access_token' setting (#5782)
The `expire_access_token` didn't do what it sounded like it should do. What it actually did was make Synapse enforce the 'time' caveat on macaroons used as access tokens, but since our access token macaroons never contained such a caveat, it was always a no-op. (The code to add 'time' caveats was removed back in v0.18.5, in #1656)
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/handlers/test_register.py | 2 | ||||
| -rw-r--r-- | tests/server_notices/test_resource_limits_server_notices.py | 2 | ||||
| -rw-r--r-- | tests/utils.py | 1 |
3 files changed, 2 insertions, 3 deletions
diff --git a/tests/handlers/test_register.py b/tests/handlers/test_register.py index 99dce45cfe..0ad0a88165 100644 --- a/tests/handlers/test_register.py +++ b/tests/handlers/test_register.py @@ -44,7 +44,7 @@ class RegistrationTestCase(unittest.HomeserverTestCase): hs_config["max_mau_value"] = 50 hs_config["limit_usage_by_mau"] = True - hs = self.setup_test_homeserver(config=hs_config, expire_access_token=True) + hs = self.setup_test_homeserver(config=hs_config) return hs def prepare(self, reactor, clock, hs): diff --git a/tests/server_notices/test_resource_limits_server_notices.py b/tests/server_notices/test_resource_limits_server_notices.py index 984feb623f..cdf89e3383 100644 --- a/tests/server_notices/test_resource_limits_server_notices.py +++ b/tests/server_notices/test_resource_limits_server_notices.py @@ -36,7 +36,7 @@ class TestResourceLimitsServerNotices(unittest.HomeserverTestCase): "room_name": "Server Notices", } - hs = self.setup_test_homeserver(config=hs_config, expire_access_token=True) + hs = self.setup_test_homeserver(config=hs_config) return hs def prepare(self, reactor, clock, hs): diff --git a/tests/utils.py b/tests/utils.py index 6350646263..f1eb9a545c 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -126,7 +126,6 @@ def default_config(name, parse=False): "enable_registration": True, "enable_registration_captcha": False, "macaroon_secret_key": "not even a little secret", - "expire_access_token": False, "trusted_third_party_id_servers": [], "room_invite_state_types": [], "password_providers": [], |