diff options
| author | Erik Johnston <erik@matrix.org> | 2018-09-21 14:19:46 +0100 |
|---|---|---|
| committer | Erik Johnston <erik@matrix.org> | 2018-09-21 14:19:46 +0100 |
| commit | 8601c24287c452c0d9a803b130e0f68cf6169f6a (patch) | |
| tree | 5651cf7a06b3be5db0d04a61cf94bf4eddc843ba /tests | |
| parent | Merge pull request #3927 from matrix-org/erikj/handle_background_errors (diff) | |
| download | synapse-8601c24287c452c0d9a803b130e0f68cf6169f6a.tar.xz | |
Fix some instances of ExpiringCache not expiring cache items
ExpiringCache required that `start()` be called before it would actually start expiring entries. A number of places didn't do that. This PR removes `start` from ExpiringCache, and automatically starts backround reaping process on creation instead.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/util/test_expiring_cache.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/util/test_expiring_cache.py b/tests/util/test_expiring_cache.py index 5cbada4eda..50bc7702d2 100644 --- a/tests/util/test_expiring_cache.py +++ b/tests/util/test_expiring_cache.py @@ -65,7 +65,6 @@ class ExpiringCacheTestCase(unittest.TestCase): def test_time_eviction(self): clock = MockClock() cache = ExpiringCache("test", clock, expiry_ms=1000) - cache.start() cache["key"] = 1 clock.advance_time(0.5) |