summary refs log tree commit diff
path: root/tests
diff options
context:
space:
mode:
authorRichard van der Hoff <richard@matrix.org>2020-03-31 17:24:06 +0100
committerRichard van der Hoff <richard@matrix.org>2020-03-31 17:24:06 +0100
commitcfe8c8ab8e412b6320e5963ced0670fbc7b00d1b (patch)
tree22d3eaed314d21069684b9d26cd95cf2e19ed366 /tests
parentFix "'NoneType' has no attribute start|stop" logcontext errors (#7181) (diff)
downloadsynapse-cfe8c8ab8e412b6320e5963ced0670fbc7b00d1b.tar.xz
Remove unused `start_background_update`
This was only used in a unit test, so let's just inline it in the test.
Diffstat (limited to 'tests')
-rw-r--r--tests/storage/test_background_update.py14
1 files changed, 9 insertions, 5 deletions
diff --git a/tests/storage/test_background_update.py b/tests/storage/test_background_update.py
index ae14fb407d..aca41eb215 100644
--- a/tests/storage/test_background_update.py
+++ b/tests/storage/test_background_update.py
@@ -25,12 +25,20 @@ class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
         # the target runtime for each bg update
         target_background_update_duration_ms = 50000
 
+        store = self.hs.get_datastore()
+        self.get_success(
+            store.db.simple_insert(
+                "background_updates",
+                values={"update_name": "test_update", "progress_json": '{"my_key": 1}'},
+            )
+        )
+
         # first step: make a bit of progress
         @defer.inlineCallbacks
         def update(progress, count):
             yield self.clock.sleep((count * duration_ms) / 1000)
             progress = {"my_key": progress["my_key"] + 1}
-            yield self.hs.get_datastore().db.runInteraction(
+            yield store.db.runInteraction(
                 "update_progress",
                 self.updates._background_update_progress_txn,
                 "test_update",
@@ -39,10 +47,6 @@ class BackgroundUpdateTestCase(unittest.HomeserverTestCase):
             return count
 
         self.update_handler.side_effect = update
-
-        self.get_success(
-            self.updates.start_background_update("test_update", {"my_key": 1})
-        )
         self.update_handler.reset_mock()
         res = self.get_success(
             self.updates.do_next_background_update(