diff options
| author | Sean Quah <8349537+squahtx@users.noreply.github.com> | 2021-12-14 12:34:30 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-14 12:34:30 +0000 |
| commit | a4dce5b53dd460e7c6757648ff4a348b490c6213 (patch) | |
| tree | 92e9f608c727a246002fffb2ff81b7cc410d6a55 /tests | |
| parent | Add missing type hints to synapse.http. (#11571) (diff) | |
| download | synapse-a4dce5b53dd460e7c6757648ff4a348b490c6213.tar.xz | |
Remove redundant `COALESCE()`s around `COUNT()`s in database queries (#11570)
`COUNT()` never returns `NULL`. A `COUNT(*)` over 0 rows is 0 and a `COUNT(NULL)` is also 0.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/storage/test_event_federation.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/storage/test_event_federation.py b/tests/storage/test_event_federation.py index c3fcf7e7b4..ecfda7677e 100644 --- a/tests/storage/test_event_federation.py +++ b/tests/storage/test_event_federation.py @@ -550,7 +550,7 @@ class EventFederationWorkerStoreTestCase(tests.unittest.HomeserverTestCase): self.store.db_pool.simple_select_one_onecol( table="federation_inbound_events_staging", keyvalues={"room_id": room_id}, - retcol="COALESCE(COUNT(*), 0)", + retcol="COUNT(*)", desc="test_prune_inbound_federation_queue", ) ) |