summary refs log tree commit diff
path: root/tests/util/caches
diff options
context:
space:
mode:
authorRichard van der Hoff <1389908+richvdh@users.noreply.github.com>2021-11-02 00:17:35 +0000
committerGitHub <noreply@github.com>2021-11-02 00:17:35 +0000
commit46d0937447479761a22a8c843f6ba51bbcdc914b (patch)
treee3f91fb7ee5cd43dbf91afed7e25610f6364c316 /tests/util/caches
parentUpdate outdated links in `PULL_REQUEST_TEMPLATE.md` (#11225) (diff)
downloadsynapse-46d0937447479761a22a8c843f6ba51bbcdc914b.tar.xz
ObservableDeferred: run observers in order (#11229)
Diffstat (limited to 'tests/util/caches')
-rw-r--r--tests/util/caches/test_deferred_cache.py4
1 files changed, 1 insertions, 3 deletions
diff --git a/tests/util/caches/test_deferred_cache.py b/tests/util/caches/test_deferred_cache.py
index 54a88a8325..c613ce3f10 100644
--- a/tests/util/caches/test_deferred_cache.py
+++ b/tests/util/caches/test_deferred_cache.py
@@ -47,9 +47,7 @@ class DeferredCacheTestCase(TestCase):
             self.assertTrue(set_d.called)
             return r
 
-        # TODO: Actually ObservableDeferred *doesn't* run its tests in order on py3.8.
-        #   maybe we should fix that?
-        # get_d.addCallback(check1)
+        get_d.addCallback(check1)
 
         # now fire off all the deferreds
         origin_d.callback(99)