diff options
author | David Robertson <davidr@element.io> | 2022-04-27 14:03:44 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-27 14:03:44 +0100 |
commit | 646324437543c096e737777c81b4fe4b45c3e1a7 (patch) | |
tree | 5320ddebe74982e1ff8ba427e45ef27135565699 /tests/test_utils/logging_setup.py | |
parent | Consistently use collections.abc.Mapping to check frozendict. (#12564) (diff) | |
download | synapse-646324437543c096e737777c81b4fe4b45c3e1a7.tar.xz |
Remove unused `# type: ignore`s (#12531)
Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.
Diffstat (limited to 'tests/test_utils/logging_setup.py')
-rw-r--r-- | tests/test_utils/logging_setup.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test_utils/logging_setup.py b/tests/test_utils/logging_setup.py index 51a197a8c6..9228454c9e 100644 --- a/tests/test_utils/logging_setup.py +++ b/tests/test_utils/logging_setup.py @@ -27,7 +27,7 @@ class ToTwistedHandler(logging.Handler): def emit(self, record): log_entry = self.format(record) log_level = record.levelname.lower().replace("warning", "warn") - self.tx_log.emit( # type: ignore + self.tx_log.emit( twisted.logger.LogLevel.levelWithName(log_level), "{entry}", entry=log_entry ) |