summary refs log tree commit diff
path: root/tests/storage/test_transactions.py
diff options
context:
space:
mode:
authorErik Johnston <erik@matrix.org>2019-10-02 10:36:27 +0100
committerErik Johnston <erik@matrix.org>2019-10-02 10:36:27 +0100
commitf44f1d2e8374b7250a8a68cf3a49e6d1ac63b0fb (patch)
tree03c05511cab1e261429a1113556419fc67a8e006 /tests/storage/test_transactions.py
parentMerge pull request #6141 from matrix-org/erikj/censor_redactions_fix (diff)
downloadsynapse-f44f1d2e8374b7250a8a68cf3a49e6d1ac63b0fb.tar.xz
Fix errors storing large retry intervals.
We have set the max retry interval to a value larger than a postgres or
sqlite int can hold, which caused exceptions when updating the
destinations table.

To fix postgres we need to change the column to a bigint, and for sqlite
we lower the max interval to 2**62 (which is still incredibly long).
Diffstat (limited to 'tests/storage/test_transactions.py')
-rw-r--r--tests/storage/test_transactions.py11
1 files changed, 11 insertions, 0 deletions
diff --git a/tests/storage/test_transactions.py b/tests/storage/test_transactions.py
index a771d5af29..8e817e2c7f 100644
--- a/tests/storage/test_transactions.py
+++ b/tests/storage/test_transactions.py
@@ -13,6 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from synapse.util.retryutils import MAX_RETRY_INTERVAL
+
 from tests.unittest import HomeserverTestCase
 
 
@@ -45,3 +47,12 @@ class TransactionStoreTestCase(HomeserverTestCase):
         """
         d = self.store.set_destination_retry_timings("example.com", 1000, 50, 100)
         self.get_success(d)
+
+    def test_large_destination_retry(self):
+        d = self.store.set_destination_retry_timings(
+            "example.com", MAX_RETRY_INTERVAL, MAX_RETRY_INTERVAL, MAX_RETRY_INTERVAL
+        )
+        self.get_success(d)
+
+        d = self.store.get_destination_retry_timings("example.com")
+        self.get_success(d)