diff options
| author | Erik Johnston <erik@matrix.org> | 2020-05-22 14:21:54 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-22 14:21:54 +0100 |
| commit | 1531b214fc57714c14046a8f66c7b5fe5ec5dcdd (patch) | |
| tree | fd150f21a14dcc6f5cf3f373984478dd12d43c95 /tests/storage/test_cleanup_extrems.py | |
| parent | Convert sending mail to async/await. (#7557) (diff) | |
| download | synapse-1531b214fc57714c14046a8f66c7b5fe5ec5dcdd.tar.xz | |
Add ability to wait for replication streams (#7542)
The idea here is that if an instance persists an event via the replication HTTP API it can return before we receive that event over replication, which can lead to races where code assumes that persisting an event immediately updates various caches (e.g. current state of the room). Most of Synapse doesn't hit such races, so we don't do the waiting automagically, instead we do so where necessary to avoid unnecessary delays. We may decide to change our minds here if it turns out there are a lot of subtle races going on. People probably want to look at this commit by commit.
Diffstat (limited to 'tests/storage/test_cleanup_extrems.py')
| -rw-r--r-- | tests/storage/test_cleanup_extrems.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/storage/test_cleanup_extrems.py b/tests/storage/test_cleanup_extrems.py index 0e04b2cf92..43425c969a 100644 --- a/tests/storage/test_cleanup_extrems.py +++ b/tests/storage/test_cleanup_extrems.py @@ -39,7 +39,7 @@ class CleanupExtremBackgroundUpdateStoreTestCase(HomeserverTestCase): # Create a test user and room self.user = UserID("alice", "test") self.requester = Requester(self.user, None, False, None, None) - info = self.get_success(self.room_creator.create_room(self.requester, {})) + info, _ = self.get_success(self.room_creator.create_room(self.requester, {})) self.room_id = info["room_id"] def run_background_update(self): @@ -261,7 +261,7 @@ class CleanupExtremDummyEventsTestCase(HomeserverTestCase): self.user = UserID.from_string(self.register_user("user1", "password")) self.token1 = self.login("user1", "password") self.requester = Requester(self.user, None, False, None, None) - info = self.get_success(self.room_creator.create_room(self.requester, {})) + info, _ = self.get_success(self.room_creator.create_room(self.requester, {})) self.room_id = info["room_id"] self.event_creator = homeserver.get_event_creation_handler() homeserver.config.user_consent_version = self.CONSENT_VERSION |