diff options
| author | Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> | 2020-09-29 12:36:44 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-09-29 12:36:44 +0100 |
| commit | 1c6b8752b891c1a25524d8dfaa8efb7176c0dbec (patch) | |
| tree | 38b6720705ee6fdd4de6b436b87b62ef0e019444 /tests/rest/client | |
| parent | Add metrics to track success/otherwise of replication requests (#8406) (diff) | |
| download | synapse-1c6b8752b891c1a25524d8dfaa8efb7176c0dbec.tar.xz | |
Only assert valid next_link params when provided (#8417)
Broken in https://github.com/matrix-org/synapse/pull/8275 and has yet to be put in a release. Fixes https://github.com/matrix-org/synapse/issues/8418. `next_link` is an optional parameter. However, we were checking whether the `next_link` param was valid, even if it wasn't provided. In that case, `next_link` was `None`, which would clearly not be a valid URL. This would prevent password reset and other operations if `next_link` was not provided, and the `next_link_domain_whitelist` config option was set.
Diffstat (limited to 'tests/rest/client')
| -rw-r--r-- | tests/rest/client/v2_alpha/test_account.py | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/tests/rest/client/v2_alpha/test_account.py b/tests/rest/client/v2_alpha/test_account.py index 93f899d861..ae2cd67f35 100644 --- a/tests/rest/client/v2_alpha/test_account.py +++ b/tests/rest/client/v2_alpha/test_account.py @@ -732,6 +732,12 @@ class ThreepidEmailRestTestCase(unittest.HomeserverTestCase): @override_config({"next_link_domain_whitelist": ["example.com", "example.org"]}) def test_next_link_domain_whitelist(self): """Tests next_link parameters must fit the whitelist if provided""" + + # Ensure not providing a next_link parameter still works + self._request_token( + "something@example.com", "some_secret", next_link=None, expect_code=200, + ) + self._request_token( "something@example.com", "some_secret", |