diff options
| author | Richard van der Hoff <1389908+richvdh@users.noreply.github.com> | 2022-04-01 16:10:31 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-01 16:10:31 +0100 |
| commit | 33ebee47e4e96a2b6fdf72091769e59034dc550f (patch) | |
| tree | e77cad2918fd13cd14100e8e7f2e0856900a69ca /tests/rest/admin | |
| parent | Default to `private` room visibility rather than `public` when a client does ... (diff) | |
| download | synapse-33ebee47e4e96a2b6fdf72091769e59034dc550f.tar.xz | |
Remove redundant `get_success` calls in test code (#12346)
There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.
Diffstat (limited to 'tests/rest/admin')
| -rw-r--r-- | tests/rest/admin/test_server_notice.py | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/tests/rest/admin/test_server_notice.py b/tests/rest/admin/test_server_notice.py index 2c855bff99..a53463c9ba 100644 --- a/tests/rest/admin/test_server_notice.py +++ b/tests/rest/admin/test_server_notice.py @@ -214,9 +214,7 @@ class ServerNoticeTestCase(unittest.HomeserverTestCase): self.assertEqual(messages[0]["sender"], "@notices:test") # invalidate cache of server notices room_ids - self.get_success( - self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() - ) + self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() # send second message channel = self.make_request( @@ -291,9 +289,7 @@ class ServerNoticeTestCase(unittest.HomeserverTestCase): # invalidate cache of server notices room_ids # if server tries to send to a cached room_id the user gets the message # in old room - self.get_success( - self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() - ) + self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() # send second message channel = self.make_request( @@ -380,9 +376,7 @@ class ServerNoticeTestCase(unittest.HomeserverTestCase): # invalidate cache of server notices room_ids # if server tries to send to a cached room_id it gives an error - self.get_success( - self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() - ) + self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all() # send second message channel = self.make_request( |